WebKit-https.git
9 years ago2010-11-11 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 11 Nov 2010 09:44:45 +0000 (09:44 +0000)]
2010-11-11  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Nikolas Zimmermann.

        Fixed WebKitGTK gtk3 compilation.

        * platform/gtk/WidgetRenderingContextGtk3.cpp:
        (WebCore::WidgetRenderingContext::WidgetRenderingContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReverted r71975:71976. That change was wrong, and the tests caught it.
mitz@apple.com [Thu, 11 Nov 2010 08:56:33 +0000 (08:56 +0000)]
Reverted r71975:71976. That change was wrong, and the tests caught it.

* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::create):
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a test for form submission by <input type=image>
tkent@chromium.org [Thu, 11 Nov 2010 08:25:36 +0000 (08:25 +0000)]
Add a test for form submission by <input type=image>
https://bugs.webkit.org/show_bug.cgi?id=49302

Reviewed by Shinichiro Hamaji.

* fast/forms/input-image-submit-expected.txt: Added.
* fast/forms/input-image-submit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-11 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Thu, 11 Nov 2010 08:07:15 +0000 (08:07 +0000)]
2010-11-11  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Dan Bernstein.

        Fix LayoutTests/canvas/philip/tests/2d.drawImage.null.html
        https://bugs.webkit.org/show_bug.cgi?id=48307

        There are no new tests because this is a fix for a pre-existing failing test.)

        * bindings/js/JSCanvasRenderingContext2DCustom.cpp: Corrected expection throwing cases to match up with spec.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 11 Nov 2010 07:37:47 +0000 (07:37 +0000)]
2010-11-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        [HTML5] 10.2.8.4 Scripts that modify the page as it is being parsed
        https://bugs.webkit.org/show_bug.cgi?id=49364

        Fixed HTMLScriptRunner's executeScript to use the ScriptController of the frame to which script element belongs
        as supposed to that of the frame associated with the HTMLScriptRunner.

        See also: http://www.whatwg.org/specs/web-apps/current-work/#scripts-that-modify-the-page-as-it-is-being-parsed

        Test: fast/parser/script-modify-page-outer.html

        * html/parser/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent): Calls executeScript.
        (WebCore::HTMLScriptRunner::executeScript): Uses the correct ScriptController instance.
        (WebCore::HTMLScriptRunner::runScript): Call executeScript.
        * html/parser/HTMLScriptRunner.h:
2010-11-10  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        [HTML5] 10.2.8.4 Scripts that modify the page as it is being parsed
        https://bugs.webkit.org/show_bug.cgi?id=49364

        Added a test to ensure moving the script element to the parent document as it is being parsed
        changes the script's global object to the parent document's window object.

        See also: http://www.whatwg.org/specs/web-apps/current-work/#scripts-that-modify-the-page-as-it-is-being-parsed

        * fast/parser/move-during-parsing-expected.txt:
        * fast/parser/resources/script-modify-page-inner.html: Added.
        * fast/parser/script-modify-page-outer-expected.txt: Added.
        * fast/parser/script-modify-page-outer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyle fix I said I’d make then forgot to make.
mitz@apple.com [Thu, 11 Nov 2010 05:20:24 +0000 (05:20 +0000)]
Style fix I said I’d make then forgot to make.

* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow for the possibility of CoreText generating multiple runs for a single text...
mitz@apple.com [Thu, 11 Nov 2010 05:18:54 +0000 (05:18 +0000)]
Allow for the possibility of CoreText generating multiple runs for a single text run.
https://bugs.webkit.org/show_bug.cgi?id=49353

Patch by Ned Holbrook <nholbrook@apple.com> on 2010-11-10
Reviewed by Dan Bernstein.

* platform/graphics/mac/ComplexTextController.h:
(WebCore::ComplexTextController::ComplexTextRun::create):
* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations.
ukai@chromium.org [Thu, 11 Nov 2010 04:58:59 +0000 (04:58 +0000)]
Unreviewed, updating Chromium expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 11 Nov 2010 03:09:41 +0000 (03:09 +0000)]
2010-11-10  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        [chromium] Clean up gfx::GetGLImplementation calls in WebGraphicsContext3DDefaultImpl
        https://bugs.webkit.org/show_bug.cgi?id=49336

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
        (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Chris Guillory <chris.guillory@google.com>
commit-queue@webkit.org [Thu, 11 Nov 2010 02:37:53 +0000 (02:37 +0000)]
2010-11-10  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Use IAccessibleComparable to compare accessibility objects.
        https://bugs.webkit.org/show_bug.cgi?id=49118

        * platform/win/Skipped:
2010-11-10  Chris Guillory  <chris.guillory@google.com>

        Reviewed by Chris Fleizach.

        Use IAccessibleComparable to compare accessibility objects.
        https://bugs.webkit.org/show_bug.cgi?id=49118

        * DumpRenderTree/AccessibilityUIElement.cpp:
        (AccessibilityUIElement::isEqual):
        * DumpRenderTree/AccessibilityUIElement.h:
        * DumpRenderTree/win/AccessibilityUIElementWin.cpp:
        (comparableObject):
        (AccessibilityUIElement::isEqual):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-10-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 11 Nov 2010 02:28:56 +0000 (02:28 +0000)]
2010-10-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Widgets do not support CSS transformations
        https://bugs.webkit.org/show_bug.cgi?id=40139

        Added a platform-specific baseline for the slider transformation
        test. This baseline says "FAIL" because the test has platform-specific
        offsets hard-coded. The result is only one tick off from expected though,
        so it's likely correct for us.

        * platform/gtk/Skipped: Unskip.
        * platform/gtk/fast/forms/slider-transformed-expected.txt: Added.
2010-10-15  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Widgets do not support CSS transformations
        https://bugs.webkit.org/show_bug.cgi?id=40139

        Instead of rendering directly onto the target drawable when rendering
        form controls on GTK+ 2.0, render onto an intermediate surface and use
        cairo to blit the result back to the target surface. This has two
        benefits. The first is that it always honors the current Cairo
        transformation. The second is that since the intermediate drawable is
        always a 32-bit GdkPixmap, we do not have to have a set of widgets
        per-colormap any longer.

        This change also begins the abstraction of widget rendering so that GTK+
        2 and GTK+ 3 can use the same code path. The WidgetRenderingContext will
        eventually hide all version differences from RenderThemeGtk, which can
        just focus on interpreting the GtkStyle properties.

        * GNUmakefile.am: Add WidgetRenderinContext source files to the sources list.
        * platform/graphics/cairo/PlatformRefPtrCairo.cpp:
        (WTF::refPlatformPtr): Add a specialization for Cairo patterns.
        (WTF::derefPlatformPtr): Ditto.
        * platform/graphics/cairo/PlatformRefPtrCairo.h: Ditto.
        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::RenderThemeGtk): No longer keep a set of
        widgets per-colormap for GTK+, instead just determine if we can use RGBA
        colormaps and go from there.
        (WebCore::RenderThemeGtk::~RenderThemeGtk): Ditto.
        (WebCore::RenderThemeGtk::getIndicatorMetrics): Put the logic for
        getting toggle button indicator metrics into this helper.
        (WebCore::RenderThemeGtk::paintRenderObject): Now uses
        WidgetRenderingContext to do widget rendering.
        (WebCore::setToggleSize): Use the new getIndicatorMetrics helper.
        * platform/gtk/RenderThemeGtk.h: Added a member to track whether or not
          the widgets are using a RGBA colormap. Also remove a defunct Page*
          member.
        * platform/gtk/ScrollbarThemeGtk.cpp: Switch all widget drawing
        operations to use WidgetRenderingContext.
        (WebCore::ScrollbarThemeGtk::paintTrackBackground): Ditto.
        (WebCore::ScrollbarThemeGtk::paintScrollbarBackground): Ditto.
        (WebCore::ScrollbarThemeGtk::paintThumb): Ditto.
        (WebCore::ScrollbarThemeGtk::paint): Ditto.
        (WebCore::ScrollbarThemeGtk::paintButton): Ditto.
        * platform/gtk/WidgetRenderingContext.h: Added.
        * platform/gtk/WidgetRenderingContextGtk2.cpp: Added.
        (WebCore::purgeScratchBuffer): Added, this is similar to the scratch
        buffer implementation from ContextShadow.
        (WebCore::PurgeScratchBufferTimer::fired): Ditto.
        (WebCore::scheduleScratchBufferPurge): Ditto.
        (WebCore::getExtraSpaceForWidget):
        (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added.
        (WebCore::WidgetRenderingContext::~WidgetRenderingContext): Added.
        (WebCore::WidgetRenderingContext::paintMozillaWidget): Added.
        * platform/gtk/WidgetRenderingContextGtk3.cpp: Added.
        (WebCore::WidgetRenderingContext::WidgetRenderingContext): Added.
        (WebCore::~WidgetRenderingContext::WidgetRenderingContext): Added.
        (WebCore::WidgetRenderingContext::paintMozillaWidget): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=49356
bdakin@apple.com [Thu, 11 Nov 2010 02:00:57 +0000 (02:00 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=49356
-[WebView _scaleWebView:] should take and origin and scroll the
document
-and corresponding-
<rdar://problem/8643921>

Reviewed by Simon Fraser.

WebCore:

Apply the scale to the origin, and set a new scroll position.
* page/Frame.cpp:
(WebCore::Frame::scalePage):
* page/Frame.h:
* WebCore.exp.in:

WebKit/mac:

* WebView/WebView.mm:
(-[WebView _scaleWebView:atOrigin:]):
* WebView/WebViewPrivate.h:

WebKit2:

* Shared/API/c/WKSharedAPICast.h:
(WebKit::toImpl):
* UIProcess/API/C/WKPage.cpp:
(WKPageScaleWebView):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scaleWebView):
* UIProcess/WebPageProxy.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaleWebView):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 11 Nov 2010 01:19:20 +0000 (01:19 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaselines.

        Rebaseline fast/lists/001-vertical.html and fast/lists/008-vertical.html
        with the chromium-mac scrollbars.

        Rest of fast/lists/00*-vertical.html tests fail due to bug 48634,
        add them to that grouping.

        * platform/chromium-mac/fast/lists/001-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/lists/001-vertical-expected.png: Added.
        * platform/chromium-mac/fast/lists/008-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/lists/008-vertical-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Fix Windows build.
adachan@apple.com [Thu, 11 Nov 2010 01:16:35 +0000 (01:16 +0000)]
    Fix Windows build.

        * win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
mitz@apple.com [Thu, 11 Nov 2010 01:11:32 +0000 (01:11 +0000)]
REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295

Reviewed by Darin Adler.

WebCore:

* platform/graphics/mac/ComplexTextControllerATSUI.cpp: Reverted to r71565. Eliding bidi
control characters from ATSUI is no longer necessary since ComplexTextController removes
any glyphs corresponding to them.
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation):
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun):

LayoutTests:

* platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 11 Nov 2010 01:02:53 +0000 (01:02 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed removal of unncessary Qt baseline (atfer r71781 Qt should
        use the base one).

        * platform/qt/svg/animations/repeatDur-zero-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Pascal Massimino <pascal.massimino@gmail.com>
commit-queue@webkit.org [Thu, 11 Nov 2010 00:48:29 +0000 (00:48 +0000)]
2010-11-10  Pascal Massimino  <pascal.massimino@gmail.com>

        Reviewed by Adam Barth.

        add test case for png where each row has or hasn't alpha values.
        This is to exercise code logic within PNGImageDecoder.cpp

        https://bugs.webkit.org/show_bug.cgi?id=49333

        * fast/images/png_per_row_alpha_decoding-expected.png: Added.
        * fast/images/png_per_row_alpha_decoding-expected.txt: Added.
        * fast/images/png_per_row_alpha_decoding.html: Added.
        * fast/images/resources/png_per_row_alpha.png: Added.
2010-11-10  Pascal Massimino  <pascal.massimino@gmail.com>

        Reviewed by Adam Barth.

        Simplify the alpha-detection code in png's decoding loop.
        https://bugs.webkit.org/show_bug.cgi?id=49333

        Added a special test for this case: png_per_row_alpha_decoding.html

        * platform/image-decoders/png/PNGImageDecoder.cpp:
        (WebCore::PNGImageDecoder::rowAvailable): modified loop.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8647848> REGRESSION (r68551): Spaces shown at soft hyphens with compl...
mitz@apple.com [Thu, 11 Nov 2010 00:40:04 +0000 (00:40 +0000)]
<rdar://problem/8647848> REGRESSION (r68551): Spaces shown at soft hyphens with complex justification
https://bugs.webkit.org/show_bug.cgi?id=49352

Reviewed by Simon Fraser.

WebCore:

Test: fast/text/justification-padding-mid-word.html

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::adjustGlyphsAndAdvances): Changed to add justification padding
and word spacing only at characters that are treated as space, instead of all characters that
use the space glyph (which includes characters treated as zero-width space as well).

LayoutTests:

* fast/text/justification-padding-mid-word-expected.txt: Added.
* fast/text/justification-padding-mid-word.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 11 Nov 2010 00:31:49 +0000 (00:31 +0000)]
2010-11-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Anders Carlsson.

        Misc drawing area cleanup
        https://bugs.webkit.org/show_bug.cgi?id=49349

        * UIProcess/LayerBackedDrawingAreaProxy.cpp:
        (WebKit::LayerBackedDrawingAreaProxy::setSize):
        (WebKit::LayerBackedDrawingAreaProxy::setPageIsVisible):
        (WebKit::LayerBackedDrawingAreaProxy::update):
        Call process()->send() instead of process()->connection()->send() in case
        the web process has not been launched yet.

        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::WebPage): Delay creation of the drawing area
        until after other WebPage state has been initialized, in case
        the DrawingArea creation needs to call back to the WebPage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 11 Nov 2010 00:29:07 +0000 (00:29 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Simon Fraser.

        svg/animations/repeatDur-zero.xhtml should use dumpAsText
        https://bugs.webkit.org/show_bug.cgi?id=49348

        Per r71066 (which added the test), all that we're testing for is whether
        or not we hang, therefore using dumpAsText is better (since then we
        don't need per-platform baselines).

        * platform/chromium/test_expectations.txt:
        * platform/mac/svg/animations/repeatDur-zero-expected.txt: Removed.
        * svg/animations/repeatDur-zero-expected.txt: Added.
        * svg/animations/repeatDur-zero.xhtml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 11 Nov 2010 00:22:22 +0000 (00:22 +0000)]
2010-11-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben.

        Push m_viewSize down to DrawingAreaProxy base class
        https://bugs.webkit.org/show_bug.cgi?id=49347

        Some refactoring so that the various drawing area classes
        can share m_size.

        * UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::setSize):
        * UIProcess/ChunkedUpdateDrawingAreaProxy.h:
        * UIProcess/DrawingAreaProxy.h:
        (WebKit::DrawingAreaProxy::setSize):
        (WebKit::DrawingAreaProxy::size):
        * UIProcess/LayerBackedDrawingAreaProxy.cpp:
        (WebKit::LayerBackedDrawingAreaProxy::setSize):
        * UIProcess/LayerBackedDrawingAreaProxy.h:
        * UIProcess/mac/ChunkedUpdateDrawingAreaProxyMac.mm:
        (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
        (WebKit::ChunkedUpdateDrawingAreaProxy::drawUpdateChunkIntoBackingStore):
        * UIProcess/mac/LayerBackedDrawingAreaProxyMac.mm:
        (WebKit::LayerBackedDrawingAreaProxy::platformSetSize):
        (WebKit::LayerBackedDrawingAreaProxy::attachCompositingContext):
        * UIProcess/win/ChunkedUpdateDrawingAreaProxyWin.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):
        * UIProcess/qt/ChunkedUpdateDrawingAreaProxyQt.cpp:
        (WebKit::ChunkedUpdateDrawingAreaProxy::ensureBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 11 Nov 2010 00:22:14 +0000 (00:22 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaselines.

        Add missing Mac, Windows and Linux baselines (no actual Linux baselines
        are included, the Windows ones are also used for it).

        * platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.checksum:
        * platform/chromium-mac/fast/blockflow/background-horizontal-bt-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.checksum:
        * platform/chromium-mac/fast/blockflow/background-vertical-lr-expected.png: Added.
        * platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.checksum: Added.
        * platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.png: Added.
        * platform/chromium-win/fast/blockflow/background-horizontal-bt-expected.txt: Added.
        * platform/chromium-win/fast/blockflow/background-vertical-lr-expected.checksum: Added.
        * platform/chromium-win/fast/blockflow/background-vertical-lr-expected.png: Added.
        * platform/chromium-win/fast/blockflow/background-vertical-lr-expected.txt: Added.
        * platform/chromium-win/fast/blockflow/background-vertical-rl-expected.checksum: Added.
        * platform/chromium-win/fast/blockflow/background-vertical-rl-expected.png: Added.
        * platform/chromium-win/fast/blockflow/background-vertical-rl-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 11 Nov 2010 00:00:53 +0000 (00:00 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline.

        Add back text expectation mistakenly removed by r71773.

        * platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 23:34:16 +0000 (23:34 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Leopard rebaseline.

        Rebaseline fast/text/international/bidi-neutral-run.html after r71763.

        * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 10 Nov 2010 23:08:03 +0000 (23:08 +0000)]
2010-11-10  Tony Chang  <tony@chromium.org>

        Reviewed by Darin Adler.

        plugins/npruntime/enumerate.html shouldn't depend on object enumeration order
        https://bugs.webkit.org/show_bug.cgi?id=49338

        The ES spec doesn't specify the order, so the test shouldn't depend on it.
        Unfortunately, the test still fails in Chromium.

        * platform/chromium/test_expectations.txt:
        * plugins/npruntime/enumerate.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 10 Nov 2010 22:49:57 +0000 (22:49 +0000)]
2010-11-10  Stephen White  <senorblanco@chromium.org>

        Unreviewed; test expectations and baselines.

        [chromium] Clean up test_expectations from my lazy gardening.  One
        new baseline.  Remove expectations for many-layers.html (which itself
        was removed in r71577).

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium-linux/fast/text/midword-break-after-breakable-char-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Evan Stade <estade@chromium.org>
estade@chromium.org [Wed, 10 Nov 2010 22:47:42 +0000 (22:47 +0000)]
2010-11-10  Evan Stade  <estade@chromium.org>

        Reviewed by Tony Chang.

        [chromium] menu key doesn't work when capslock or numslock is on
        https://bugs.webkit.org/show_bug.cgi?id=49289

        Add a special bitmask for the "input" modifier keys (shift, alt, crtl, meta). The Modifier
        enum has grown to something that might be better termed State, but changing the nomenclature
        now is difficult. The bitmask gets its name from the related function getWebInputModifiers.

        * public/WebInputEvent.h: add InputModifiers mask for true modifier keys
        * src/WebViewImpl.cpp: disregard non-modifier keys
        (WebKit::WebViewImpl::keyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 22:44:50 +0000 (22:44 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline.

        Update chromium-mac baselines after r71763.

        * platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.checksum:
        * platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.png:
        * platform/chromium-mac/fast/text/international/bidi-control-chars-treated-as-ZWS-expected.txt: Removed.
        * platform/chromium-mac/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 10 Nov 2010 22:44:23 +0000 (22:44 +0000)]
2010-11-10  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Darin Adler.

        Crash in documentWillBecomeInactive() when closing window with Reader showing content with SVG
        https://bugs.webkit.org/show_bug.cgi?id=49084

        Manual test added.

        * manual-tests/svg-deep-clone-to-new-doc.html: Added manual test for reproducing bug since an automated version proved to be a bit tough to craft up.
        * svg/SVGSVGElement.cpp: Added in necessary document ownership transfer calls.
        * svg/SVGSVGElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 10 Nov 2010 22:32:48 +0000 (22:32 +0000)]
2010-11-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Red error bubbles don't fit content.
        https://bugs.webkit.org/show_bug.cgi?id=49305

        * inspector/front-end/textViewer.css:
        (.webkit-html-message-bubble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago https://bugs.webkit.org/show_bug.cgi?id=45205
ap@apple.com [Wed, 10 Nov 2010 22:07:59 +0000 (22:07 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=45205
        <rdar://problem/8391455> Detached elements shouldn't have style sheets.

        Land test files I missed in original check-in.

        * fast/dom/StyleSheet/resources: Added.
        * fast/dom/StyleSheet/resources/detached-style.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Release build fix.
ap@apple.com [Wed, 10 Nov 2010 21:38:28 +0000 (21:38 +0000)]
    Release build fix.

        * css/StyleSheet.cpp: isAcceptableStyleSheetParent() is a debug-only function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 10 Nov 2010 21:16:34 +0000 (21:16 +0000)]
2010-11-10  Stephen White  <senorblanco@chromium.org>

        Unreviewed; updated test baselines.

        Updated chromium-win tests affected slightly by
        http://trac.webkit.org/changeset/71760.

        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-color-01-b-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-in-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-type-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-dom-values-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFEColorMatrixElement-svgdom-in-prop-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-baseFrequency-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-numOctaves-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-seed-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-stitchTiles-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-dom-type-attr-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-numOctaves-prop-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-seed-prop-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-stitchTiles-prop-expected.png:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.checksum:
        * platform/chromium-win/svg/dynamic-updates/SVGFETurbulenceElement-svgdom-type-prop-expected.png:
        * platform/chromium-win/svg/filters/feLighting-crash-expected.checksum:
        * platform/chromium-win/svg/filters/feLighting-crash-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 10 Nov 2010 21:12:39 +0000 (21:12 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=45205
        <rdar://problem/8391455> Detached elements shouldn't have style sheets.

        Tests: fast/dom/StyleSheet/detached-style-2.html
               fast/dom/StyleSheet/detached-style-pi.xhtml
               fast/dom/StyleSheet/detached-style.html
               fast/dom/StyleSheet/detached-style-pi-2.xhtml

        * bindings/js/JSStyleSheetCustom.cpp: (WebCore::JSStyleSheet::markChildren):
        There is no longer a need to mark owner nodes - StyleSheet->ownerNode() is only non-null when
        the node is in document.

        * css/StyleSheet.cpp: (WebCore::StyleSheet::StyleSheet): Added an assertion checking that
        all nodes that can be StyleSheet parents have been verified.

        * css/StyleSheet.h: (WebCore::StyleSheet::clearOwnerNode): Added.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::~ProcessingInstruction): Clear stylesheet's owner node. This
        shouldn't have observable effect, since a processing instruction that is in document can only
        be destroyed with document, and a reachable stylsheet keeps document alive.
        (WebCore::ProcessingInstruction::removedFromDocument): Clear the relationship between node and style sheet when removed.
        (WebCore::ProcessingInstruction::setCSSStyleSheet): If the element was removed during load, we still
        don't want to create a style sheet.

        * dom/StyleElement.cpp:
        (WebCore::StyleElement::sheet): There is no reason for lazy creation. It was a wrong fix for
        bug 14462, whose regression test still passes.
        (WebCore::StyleElement::removedFromDocument): Clear the relationship between node and style sheet when removed.
        (WebCore::StyleElement::finishParsingChildren): Don't call sheet(), it doens't have side effects any more.
        (WebCore::StyleElement::createSheet): Assert that the element is in document. We never want
        to create a style sheet for an element that isn't.

        * dom/StyleElement.h: (WebCore::StyleElement::sheet): Made implementation inline, now that
        it's a simple getter.

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::~HTMLLinkElement): Clear stylesheet's owner node.
        (WebCore::HTMLLinkElement::process): Assert that there is no style sheet lingering for any reason.
        (WebCore::HTMLLinkElement::removedFromDocument): Clear the relationship between node and style sheet when removed.
        (WebCore::HTMLLinkElement::setCSSStyleSheet): If the element was removed during load, we still
        don't want to create a style sheet.

        * html/HTMLStyleElement.cpp: (WebCore::HTMLStyleElement::~HTMLStyleElement):
        * html/HTMLStyleElement.h:
        * svg/SVGStyleElement.cpp: (WebCore::SVGStyleElement::~SVGStyleElement):
        * svg/SVGStyleElement.h:
        Clear stylesheet's owner node. As above, this shouldn't have observable effect.

        * xml/XSLTProcessor.h:
        * xml/XSLTProcessor.cpp: (WebCore::XSLTProcessor::~XSLTProcessor):
        * dom/Document.cpp: (WebCore::Document::~Document):
        * css/CSSParser.cpp: (WebCore::CSSParser::parseSelector):
        Assert that stylesheet won't outlive its owner node. We don't really use refcounting here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed messed-up ChangeLog.
senorblanco@chromium.org [Wed, 10 Nov 2010 21:04:39 +0000 (21:04 +0000)]
Fixed messed-up ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Dan Bernstein <mitz@apple.com>
senorblanco@chromium.org [Wed, 10 Nov 2010 20:55:05 +0000 (20:55 +0000)]
2010-11-10  Dan Bernstein  <mitz@apple.com>

        REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
        https://bugs.webkit.org/show_bug.cgi?id=49295

        * platform/mac-leopard/Skipped: Re-enable the previously failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
mitz@apple.com [Wed, 10 Nov 2010 20:53:27 +0000 (20:53 +0000)]
REGRESSION (r71566): r71566 breaks bidi-control-chars-treated-as-ZWS.html
https://bugs.webkit.org/show_bug.cgi?id=49295

WebCore:

Reviewed by Dave Hyatt.

* platform/graphics/mac/ComplexTextController.h: Added m_indexOffset.
* platform/graphics/mac/ComplexTextControllerATSUI.cpp:
(WebCore::ComplexTextController::ComplexTextRun::overrideLayoutOperation): Use m_indexOffset
instead of computing the offset based on m_directionalOverride.
(WebCore::ComplexTextController::ComplexTextRun::ComplexTextRun): Set m_indexOffset to
the offset between indices in m_characters and indices in the text passed to ATSUI.

LayoutTests:

* platform/mac-leopard/Skipped: Re-enable the previously failing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Wed, 10 Nov 2010 20:44:18 +0000 (20:44 +0000)]
2010-11-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Gear menu floats to right edge and expands
        to bottom of "Styles" section.
        https://bugs.webkit.org/show_bug.cgi?id=49303

        This fixes computed style's option wrapping to the next line.

        * inspector/front-end/inspector.css:
        (.sidebar-pane-subtitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoClosing tabs sometimes crashes the WebProcess in invalidateContentsAndWindow
andersca@apple.com [Wed, 10 Nov 2010 20:30:05 +0000 (20:30 +0000)]
Closing tabs sometimes crashes the WebProcess in invalidateContentsAndWindow
https://bugs.webkit.org/show_bug.cgi?id=49335
<rdar://problem/8646621>

Reviewed by Dan Bernstein.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::changeAcceleratedCompositingMode):
If we fail to send the DidChangeAcceleratedCompositing message, don't null out the
drawing area. This will happen during page teardown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 10 Nov 2010 20:16:00 +0000 (20:16 +0000)]
2010-11-10  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        Fix canvas.putImageData(canvas.getImageData(...)) to be lossless.
        https://bugs.webkit.org/show_bug.cgi?id=49330

        These cycles should be lossless for valid colours.  A similar fix went
        into the CG port at r32878.

        Covered by canvas/philip/tests/2d.imageData.put.unchanged.html.

        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::mulDiv255Ceil):
        A helper function to do (a + b + 254) / 255 without a divide.
        (WebCore::putImageData):
        Use the above helper to round up when premultiplying alpha.
2010-11-10  Stephen White  <senorblanco@chromium.org>

        Reviewed by James Robinson.

        Mark 2d.imageData.put.unchanged.html as passing on Win/Linux.
        https://bugs.webkit.org/show_bug.cgi?id=49330

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 19:29:30 +0000 (19:29 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium Mac rebaselines.

        Add Chromium Mac baselines for tests added by r71382 (since they have
        scrollbars they can't use the upstream Mac baselines).

        * platform/chromium-mac/fast/table/027-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/table/027-vertical-expected.png: Added.
        * platform/chromium-mac/fast/table/028-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/table/028-vertical-expected.png: Added.
        * platform/chromium-mac/fast/table/038-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/table/038-vertical-expected.png: Added.
        * platform/chromium-mac/fast/table/040-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/table/040-vertical-expected.png: Added.
        * platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/table/border-collapsing/002-vertical-expected.png: Added.
        * platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/table/border-collapsing/004-vertical-expected.png: Added.
        * platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
        * platform/chromium-mac/fast/table/height-percent-test-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/table/height-percent-test-vertical-expected.png: Added.
        * platform/chromium-mac/fast/table/table-display-types-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/table/table-display-types-vertical-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 10 Nov 2010 19:18:49 +0000 (19:18 +0000)]
2010-11-10  Tony Chang  <tony@chromium.org>

        Unreviewed, update DRT Chromium Mac plugin test results.
        This matches the past 2 runs on the bot.

        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 19:11:31 +0000 (19:11 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium Mac rebaselines.

        Rebaseline css1/ and css2.1/ (because of scrollbar display diferences).

        * platform/chromium-mac/css1/cascade/cascade_order-expected.checksum: Added.
        * platform/chromium-mac/css1/cascade/cascade_order-expected.png: Added.
        * platform/chromium-mac/css1/classification/display-expected.checksum: Added.
        * platform/chromium-mac/css1/classification/display-expected.png: Added.
        * platform/chromium-mac/css1/classification/list_style_type-expected.checksum: Added.
        * platform/chromium-mac/css1/classification/list_style_type-expected.png: Added.
        * platform/chromium-mac/css1/classification/white_space-expected.checksum: Added.
        * platform/chromium-mac/css1/classification/white_space-expected.png: Added.
        * platform/chromium-mac/css1/color_and_background/background-expected.checksum: Added.
        * platform/chromium-mac/css1/color_and_background/background-expected.png: Added.
        * platform/chromium-mac/css1/color_and_background/background_attachment-expected.checksum: Added.
        * platform/chromium-mac/css1/color_and_background/background_attachment-expected.png: Added.
        * platform/chromium-mac/css1/color_and_background/background_position-expected.checksum: Added.
        * platform/chromium-mac/css1/color_and_background/background_position-expected.png: Added.
        * platform/chromium-mac/css1/color_and_background/background_repeat-expected.checksum: Added.
        * platform/chromium-mac/css1/color_and_background/background_repeat-expected.png: Added.
        * platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.checksum: Added.
        * platform/chromium-mac/css1/conformance/forward_compatible_parsing-expected.png: Added.
        * platform/chromium-mac/css1/font_properties/font-expected.checksum: Added.
        * platform/chromium-mac/css1/font_properties/font-expected.png: Added.
        * platform/chromium-mac/css1/font_properties/font_size-expected.checksum: Added.
        * platform/chromium-mac/css1/font_properties/font_size-expected.png: Added.
        * platform/chromium-mac/css1/font_properties/font_weight-expected.checksum: Added.
        * platform/chromium-mac/css1/font_properties/font_weight-expected.png: Added.
        * platform/chromium-mac/css1/formatting_model/floating_elements-expected.checksum: Added.
        * platform/chromium-mac/css1/formatting_model/floating_elements-expected.png: Added.
        * platform/chromium-mac/css1/formatting_model/height_of_lines-expected.checksum: Added.
        * platform/chromium-mac/css1/formatting_model/height_of_lines-expected.png: Added.
        * platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.checksum: Added.
        * platform/chromium-mac/css1/formatting_model/horizontal_formatting-expected.png: Added.
        * platform/chromium-mac/css1/formatting_model/inline_elements-expected.checksum: Added.
        * platform/chromium-mac/css1/formatting_model/inline_elements-expected.png: Added.
        * platform/chromium-mac/css1/formatting_model/replaced_elements-expected.checksum: Added.
        * platform/chromium-mac/css1/formatting_model/replaced_elements-expected.png: Added.
        * platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.checksum: Added.
        * platform/chromium-mac/css1/formatting_model/vertical_formatting-expected.png: Added.
        * platform/chromium-mac/css1/pseudo/anchor-expected.checksum: Added.
        * platform/chromium-mac/css1/pseudo/anchor-expected.png: Added.
        * platform/chromium-mac/css1/pseudo/firstletter-expected.checksum: Added.
        * platform/chromium-mac/css1/pseudo/firstletter-expected.png: Added.
        * platform/chromium-mac/css1/pseudo/firstline-expected.checksum: Added.
        * platform/chromium-mac/css1/pseudo/firstline-expected.png: Added.
        * platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.checksum: Added.
        * platform/chromium-mac/css1/pseudo/multiple_pseudo_elements-expected.png: Added.
        * platform/chromium-mac/css1/text_properties/letter_spacing-expected.checksum: Added.
        * platform/chromium-mac/css1/text_properties/letter_spacing-expected.png: Added.
        * platform/chromium-mac/css1/text_properties/line_height-expected.checksum: Added.
        * platform/chromium-mac/css1/text_properties/line_height-expected.png: Added.
        * platform/chromium-mac/css1/text_properties/text_decoration-expected.checksum: Added.
        * platform/chromium-mac/css1/text_properties/text_decoration-expected.png: Added.
        * platform/chromium-mac/css1/text_properties/text_indent-expected.checksum: Added.
        * platform/chromium-mac/css1/text_properties/text_indent-expected.png: Added.
        * platform/chromium-mac/css1/text_properties/text_transform-expected.checksum: Added.
        * platform/chromium-mac/css1/text_properties/text_transform-expected.png: Added.
        * platform/chromium-mac/css1/text_properties/vertical_align-expected.checksum: Added.
        * platform/chromium-mac/css1/text_properties/vertical_align-expected.png: Added.
        * platform/chromium-mac/css1/text_properties/word_spacing-expected.checksum: Added.
        * platform/chromium-mac/css1/text_properties/word_spacing-expected.png: Added.
        * platform/chromium-mac/css1/units/color_units-expected.checksum: Added.
        * platform/chromium-mac/css1/units/color_units-expected.png: Added.
        * platform/chromium-mac/css1/units/length_units-expected.checksum: Added.
        * platform/chromium-mac/css1/units/length_units-expected.png: Added.
        * platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t0803-c5502-mrgn-r-02-c-expected.png: Added.
        * platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t0803-c5505-mrgn-02-c-expected.png: Added.
        * platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t080301-c411-vt-mrgn-00-b-expected.png: Added.
        * platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t0905-c5525-fltclr-00-c-ag-expected.png: Added.
        * platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t0905-c5525-fltmrgn-00-c-ag-expected.png: Added.
        * platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t0905-c5525-fltwidth-00-c-g-expected.png: Added.
        * platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t0905-c5526-fltclr-00-c-ag-expected.png: Added.
        * platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t1002-c5523-width-02-b-g-expected.png: Added.
        * platform/chromium-mac/css2.1/t1202-counters-08-b-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t1202-counters-08-b-expected.png: Added.
        * platform/chromium-mac/css2.1/t1202-counters-09-b-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t1202-counters-09-b-expected.png: Added.
        * platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t140201-c535-bg-fixd-00-b-g-expected.png: Added.
        * platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t140201-c537-bgfxps-00-c-ag-expected.png: Added.
        * platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t1508-c527-font-07-b-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 10 Nov 2010 19:02:55 +0000 (19:02 +0000)]
2010-11-10  Martin Robinson  <mrobinson@igalia.com>

        Rebaseline a new test. The patch was posted before font
        hinting was disabled in the GTK+ DRT.

        * platform/gtk/fonts/complex-text-shadows-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 18:51:39 +0000 (18:51 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium DRT expectations update.

        - fast/images/gif-loop-count.html fails on Linux and Mac when under the
          DRT.
        - Add more flaky media tests
        - Tweak video-referrer.html error output to be more useful

        * http/tests/media/video-referer.html:
        * platform/chromium/drt_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Csaba Osztrogonác <ossy@webkit.org>
ossy@webkit.org [Wed, 10 Nov 2010 18:43:50 +0000 (18:43 +0000)]
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * Configurations/FeatureDefines.xcconfig:
        * JavaScriptCorePrefix.h:: Touch it to avoid incremental build failure on Windows.
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * features.gypi:
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        * WebKitPrefix.h: Touch it to avoid incremental build failure on Windows.
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * Configurations/FeatureDefines.xcconfig:
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCorePrefix.h: Touch WebCorePrefix.h to avoid incremental build failure on Windows.
        * config.h: Touch config.h to avoid incremental build failure on Windows.
        * features.pri:
        * html/HTMLTagNames.in:
        * rendering/RenderBlock.cpp: Remove ENABLE_RUBY guard.
        (WebCore::canMergeContiguousAnonymousBlocks):
        * rendering/RenderObject.cpp: Remove ENABLE_RUBY guard.
        (WebCore::RenderObject::createObject):
        * rendering/RenderRuby.cpp: Remove ENABLE_RUBY guard.
        * rendering/RenderRuby.h: Remove ENABLE_RUBY guard.
        * rendering/RenderRubyBase.cpp: Remove ENABLE_RUBY guard.
        * rendering/RenderRubyBase.h: Remove ENABLE_RUBY guard.
        * rendering/RenderRubyRun.cpp: Remove ENABLE_RUBY guard.
        * rendering/RenderRubyRun.h: Remove ENABLE_RUBY guard.
        * rendering/RenderRubyText.cpp: Remove ENABLE_RUBY guard.
        * rendering/RenderRubyText.h: Remove ENABLE_RUBY guard.
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * cmake/OptionsEfl.cmake:
        * cmakeconfig.h.cmake:
        * configure.ac:
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * Scripts/build-webkit:
2010-11-10  Csaba Osztrogonác  <ossy@webkit.org>

        Reviewed by David Hyatt.

        HTML5 Ruby support should be mandatory feature
        https://bugs.webkit.org/show_bug.cgi?id=49272

        Remove Ruby as optional feature.

        * Configurations/FeatureDefines.xcconfig:
        * WebKit2Prefix.h: Touch it to avoid incremental build failure on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Adrienne Walker <enne@google.com>
commit-queue@webkit.org [Wed, 10 Nov 2010 18:37:33 +0000 (18:37 +0000)]
2010-11-10  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        Add a test for "is" tests on WebGL objects that have not been bound or
        have been deleted.  This currently does not work in the Chromium
        command buffer or in Mesa, so is skipped there.
        https://bugs.webkit.org/show_bug.cgi?id=48877

        * fast/canvas/webgl/is-object-expected.txt: Added.
        * fast/canvas/webgl/is-object.html: Added.
        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPrint VC++ Express build logs in the same order that the projects are built
aroben@apple.com [Wed, 10 Nov 2010 18:34:40 +0000 (18:34 +0000)]
Print VC++ Express build logs in the same order that the projects are built

Fixes <http://webkit.org/b/49326> print-vse-failure-logs prints logs
in an unhelpful order

Reviewed by Eric Seidel.

* Scripts/print-vse-failure-logs:
(PrintVisualStudioExpressLogs._build_order): Added. Uses
print-msvc-project-dependencies to figure out the order in which
projects are built.
(PrintVisualStudioExpressLogs._sort_buildlogs): Added. Sorts the logs
based on their build order and project name.
(PrintVisualStudioExpressLogs._obj_directory): Moved code to find the
scripts directory from here...
(PrintVisualStudioExpressLogs._scripts_directory): ...to here.
(PrintVisualStudioExpressLogs.main): Sort the logs before printing
them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOnly print the interesting text from VC++ Express build logs
aroben@apple.com [Wed, 10 Nov 2010 18:34:06 +0000 (18:34 +0000)]
Only print the interesting text from VC++ Express build logs

Fixes <http://webkit.org/b/49325> It's hard to find the interesting
output from print-vse-failure-logs

Reviewed by Eric Seidel.

* Scripts/print-vse-failure-logs: Removed unnecessary os.path import,
added newly-required imports. Removed a comment that was essentially a
FIXME, and is now fixed.
(PrintVisualStudioExpressLogs._relevant_text): Added. Uses
BeautifulSoup to extract the relevant text from the build log.
(PrintVisualStudioExpressLogs.main): Only print the relevant text.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 10 Nov 2010 17:59:20 +0000 (17:59 +0000)]
2010-11-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Complex text does not have full CSS text-shadow support
        https://bugs.webkit.org/show_bug.cgi?id=45597

        Add a test which verifies text-shadow on complex text for the GTK+
        port. This can easily be made into a cross-platform test with baselines
        for other ports.

        * platform/gtk/fonts/complex-text-shadows-expected.checksum: Added.
        * platform/gtk/fonts/complex-text-shadows-expected.png: Added.
        * platform/gtk/fonts/complex-text-shadows-expected.txt: Added.
        * platform/gtk/fonts/complex-text-shadows.html: Added.
2010-11-10  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] Complex text does not have full CSS text-shadow support
        https://bugs.webkit.org/show_bug.cgi?id=45597

        Add ContextShadow support to FontGtk, which enables non-solid shadows
        for complex text rendering.

        Test: platform/gtk/fonts/complex-text-shadows.html

        * platform/graphics/gtk/FontGtk.cpp:
        (WebCore::destroyPangoRegion): Added this helper, which helps reduce
        the number of #ifdefs when dealing with GTK+ region type differences.
        (WebCore::getPangoRegionExtents): Ditto.
        (WebCore::drawGlyphsShadow): Added this helper which either renders
        a solid shadow manually or uses ContextShadow to render a blurry shadow.
        (WebCore::Font::drawComplexText): Use the new helpers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 10 Nov 2010 17:45:50 +0000 (17:45 +0000)]
2010-11-10  Tony Chang  <tony@chromium.org>

        Unreviewed, add libvpx as a chromium dependency.

        This should fix the chromium linux build.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 10 Nov 2010 17:34:01 +0000 (17:34 +0000)]
2010-11-10  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [gtk] The revision r71528 causes crashes in GObjectEventListener
        https://bugs.webkit.org/show_bug.cgi?id=49314

        Moved the addition of the event listener to the node after calling
        the constructor of the event listener. This is required beacuse
        the addEventListener API receives the EventListener inside a
        PassRefPtr.

        * bindings/gobject/GObjectEventListener.cpp:
        (WebCore::GObjectEventListener::GObjectEventListener):
        * bindings/gobject/GObjectEventListener.h:
        (WebCore::GObjectEventListener::addEventListener):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd license to DerivedSources.make.
weinig@apple.com [Wed, 10 Nov 2010 17:21:04 +0000 (17:21 +0000)]
Add license to DerivedSources.make.

Reviewed by Anders Carlsson.

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoConvert client classes to use APIClient base class.
weinig@apple.com [Wed, 10 Nov 2010 17:14:38 +0000 (17:14 +0000)]
Convert client classes to use APIClient base class.
https://bugs.webkit.org/show_bug.cgi?id=49322

Reviewed by Adam Roben.

* UIProcess/WebFormClient.cpp:
(WebKit::WebFormClient::willSubmitForm):
* UIProcess/WebFormClient.h:
* UIProcess/WebLoaderClient.cpp:
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPolicyClient.cpp:
* UIProcess/WebPolicyClient.h:
* UIProcess/WebUIClient.cpp:
* UIProcess/WebUIClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageContextMenuClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageFormClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageFormClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-02 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 10 Nov 2010 17:12:45 +0000 (17:12 +0000)]
2010-11-02  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Enable InspectorCSSAgent (not used by frontend for CSS editing yet)
        https://bugs.webkit.org/show_bug.cgi?id=48834

        Drive-by fix: use a single API method to retrieve all node-related styles instead of a bunch of separate calls.

        Test: inspector/styles-new-API.html

        WebCore:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/Inspector.idl:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::InspectorCSSAgent):
        (WebCore::InspectorCSSAgent::setDOMAgent):
        (WebCore::InspectorCSSAgent::reset):
        (WebCore::InspectorCSSAgent::getStylesForNode2):
        (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
        (WebCore::InspectorCSSAgent::addRule2):
        (WebCore::InspectorCSSAgent::querySelectorAll):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::releaseFrontendLifetimeAgents):
        (WebCore::InspectorController::didCommitLoad):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::cssAgent):
        * inspector/InspectorDOMAgent.cpp:
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::setPropertyText):
        (WebCore::InspectorStyle::styleText):
        (WebCore::InspectorStyle::disableProperty):
        (WebCore::InspectorStyle::populateAllProperties):
        (WebCore::InspectorStyle::populateObjectWithStyleProperties):
        (WebCore::InspectorStyleSheet::buildObjectForRule):
        (WebCore::InspectorStyleSheet::fixUnparsedPropertyRanges):
        (WebCore::InspectorStyleSheet::ensureSourceData):
        (WebCore::InspectorStyleSheetForInlineStyle::text):
        * inspector/InspectorStyleSheet.h:
        (WebCore::InspectorStyleProperty::setRawTextFromStyleDeclaration):
        (WebCore::InspectorStyleProperty::hasRawText):

        LayoutTests:
        * inspector/resources/styles-new-API.css: Added.
        (html):
        (body):
        (/* comment before selector */body.main1/* comment after selector */):
        (body.main2):
        (body::after):
        (h1):
        * inspector/styles-new-API-expected.txt: Added.
        * inspector/styles-new-API.html: Added.
        * inspector/styles-source-offsets-expected.txt:
        * inspector/styles-source-offsets.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 16:28:06 +0000 (16:28 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviwed, updating Chromium GPU test expectations.

        canvas/philip/tests/2d.pattern.image.incomplete.html was fixed by
        r71718.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Wed, 10 Nov 2010 16:27:21 +0000 (16:27 +0000)]
2010-11-10  Andras Becsi  <abecsi@webkit.org>

        Rubber-stamped by Csaba Osztrogonác.

        [Qt] Deduplicate the Skipped list entries.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Wed, 10 Nov 2010 16:13:39 +0000 (16:13 +0000)]
2010-11-10  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Move CSSStyleDeclaration from DOMAgent.js into CSSStyleModel.js
        https://bugs.webkit.org/show_bug.cgi?id=49312

        No new tests, as it's just code motion.

        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleDeclaration):
        (WebInspector.CSSStyleDeclaration.parsePayload):
        (WebInspector.CSSStyleDeclaration.prototype.get allProperties):
        (WebInspector.CSSStyleDeclaration.prototype.getLiveProperty):
        (WebInspector.CSSStyleDeclaration.prototype.getPropertyValue):
        (WebInspector.CSSStyleDeclaration.prototype.getPropertyPriority):
        (WebInspector.CSSStyleDeclaration.prototype.getPropertyShorthand):
        (WebInspector.CSSStyleDeclaration.prototype.isPropertyImplicit):
        (WebInspector.CSSStyleDeclaration.prototype.styleTextWithShorthands):
        (WebInspector.CSSStyleDeclaration.prototype.getLonghandProperties):
        (WebInspector.CSSStyleDeclaration.prototype.getShorthandValue):
        (WebInspector.CSSStyleDeclaration.prototype.getShorthandPriority):
        (WebInspector.CSSStyleDeclaration.prototype.appendProperty):
        (WebInspector.CSSStyleDeclaration.prototype.propertyAt):
        (WebInspector.CSSRule):
        (WebInspector.CSSRule.parsePayload):
        (WebInspector.CSSRule.prototype.get isUserAgent):
        (WebInspector.CSSRule.prototype.get isUser):
        (WebInspector.CSSRule.prototype.get isViaInspector):
        (WebInspector.CSSRule.prototype.get isRegular):
        (WebInspector.CSSProperty):
        (WebInspector.CSSProperty.parsePayload):
        (WebInspector.CSSProperty.prototype.get propertyText):
        (WebInspector.CSSProperty.prototype.get isLive):
        (WebInspector.CSSProperty.prototype.get active):
        (WebInspector.CSSProperty.prototype.get styleBased):
        (WebInspector.CSSProperty.prototype.get inactive):
        (WebInspector.CSSProperty.prototype.get disabled):
        (WebInspector.CSSProperty.prototype.setText):
        (WebInspector.CSSProperty.prototype.setValue):
        (WebInspector.CSSProperty.prototype.setDisabled.callback):
        (WebInspector.CSSProperty.prototype.setDisabled):
        * inspector/front-end/DOMAgent.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Wed, 10 Nov 2010 16:10:38 +0000 (16:10 +0000)]
2010-11-10  Andras Becsi  <abecsi@webkit.org>

        Unreviewed.

        [Qt][WK2] http/tests/history/popstate-fires-with-pending-requests.html breaks ~400 subsequent tests
        https://bugs.webkit.org/show_bug.cgi?id=49321

        * platform/qt-wk2/Skipped:
        Skip the tests until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 15:43:14 +0000 (15:43 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed, updating Chromium baselines.

        Update Chromium inspector/console-log-syntax-error.html baselines
        (after r71010 the path displayed is the same as the upstream baseline).

        * platform/chromium/inspector/console-log-syntax-error-expected.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 15:34:44 +0000 (15:34 +0000)]
2010-11-10  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed, updating Chromium Mac baselines.

        - editing/selection/extend-by-word-002.html had selection display
          changed (for the better) by r71700
        - fast/block/basic/truncation-rtl.html was likely checked in with
          Snow Leopard baselines, but chromium-mac is still on Leopard
        - tables/mozilla/bugs/bug82946-2.html needed rebaseline after r71311
          switched on ICCJPEG

        * platform/chromium-mac/editing/selection/extend-by-word-002-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/extend-by-word-002-expected.png: Added.
        * platform/chromium-mac/fast/block/basic/truncation-rtl-expected.checksum: Added.
        * platform/chromium-mac/fast/block/basic/truncation-rtl-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.checksum:
        * platform/chromium-mac/tables/mozilla/bugs/bug82946-2-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Sheriff Bot <webkit.review.bot@gmail.com>
andreas.kling@nokia.com [Wed, 10 Nov 2010 15:13:47 +0000 (15:13 +0000)]
2010-11-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r71733.
        http://trac.webkit.org/changeset/71733
        https://bugs.webkit.org/show_bug.cgi?id=49319

        made qt bot crashy and sad (Requested by kling on #webkit).

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2010-11-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r71733.
        http://trac.webkit.org/changeset/71733
        https://bugs.webkit.org/show_bug.cgi?id=49319

        made qt bot crashy and sad (Requested by kling on #webkit).

        * page/FrameView.cpp:
        (WebCore::FrameView::windowClipRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Peter Rybin <peter.rybin@gmail.com>
caseq@chromium.org [Wed, 10 Nov 2010 14:43:50 +0000 (14:43 +0000)]
2010-11-10  Peter Rybin  <peter.rybin@gmail.com>

        Reviewed by Adam Barth.

        HTML parser should provide script column position within HTML document to JavaScript engine
        https://bugs.webkit.org/show_bug.cgi?id=45271

        Adds TextPosition* classes -- a structure that stores line/column/generation
        level coordinates inside text document. Adds *BasedNumber classes -- typesafe int
        wrappers that emphasize whether int number is used as zero-based or
        one-based.

        * GNUmakefile.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * wtf/text/TextPosition.h: Added.
        (WTF::TextPosition::TextPosition):
        (WTF::TextPosition::minimumPosition):
        (WTF::TextPosition::belowRangePosition):
        (WTF::ZeroBasedNumber::fromZeroBasedInt):
        (WTF::ZeroBasedNumber::ZeroBasedNumber):
        (WTF::ZeroBasedNumber::zeroBasedInt):
        (WTF::ZeroBasedNumber::base):
        (WTF::ZeroBasedNumber::belowBase):
        (WTF::OneBasedNumber::fromOneBasedInt):
        (WTF::OneBasedNumber::OneBasedNumber):
        (WTF::OneBasedNumber::oneBasedInt):
        (WTF::OneBasedNumber::convertAsZeroBasedInt):
        (WTF::OneBasedNumber::convertToZeroBased):
        (WTF::OneBasedNumber::base):
        (WTF::OneBasedNumber::belowBase):
        (WTF::toZeroBasedTextPosition):
        (WTF::toOneBasedTextPosition):
        (WTF::ZeroBasedNumber::convertToOneBased):

2010-11-10  Peter Rybin  <peter.rybin@gmail.com>

        Reviewed by Adam Barth.

        HTML parser should provide script column position within HTML document to JavaScript engine
        https://bugs.webkit.org/show_bug.cgi?id=45271

        Replaces line number with TextPosition struct so that script engine
        gets script starting line/column.

        * ForwardingHeaders/wtf/text/TextPosition.h: Added.
        * bindings/js/ScriptSourceCode.h:
        (WebCore::ScriptSourceCode::ScriptSourceCode):
        * bindings/v8/ScheduledAction.cpp:
        (WebCore::ScheduledAction::ScheduledAction):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::eventHandlerPosition):
        * bindings/v8/ScriptController.h:
        * bindings/v8/ScriptEventListener.cpp:
        (WebCore::createAttributeEventListener):
        * bindings/v8/ScriptSourceCode.h:
        (WebCore::ScriptSourceCode::ScriptSourceCode):
        (WebCore::ScriptSourceCode::startLine):
        (WebCore::ScriptSourceCode::startPosition):
        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::V8LazyEventListener):
        (WebCore::V8LazyEventListener::prepareListenerObject):
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::create):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::compileScript):
        (WebCore::V8Proxy::evaluate):
        (WebCore::V8Proxy::runScript):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::evaluate):
        (WebCore::WorkerContextExecutionProxy::runScript):
        * bindings/v8/WorkerContextExecutionProxy.h:
        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate):
        * dom/PendingScript.cpp:
        (WebCore::PendingScript::releaseElementAndClear):
        * dom/PendingScript.h:
        (WebCore::PendingScript::PendingScript):
        (WebCore::PendingScript::operator=):
        (WebCore::PendingScript::startingPosition):
        * dom/ScriptableDocumentParser.h:
        * dom/XMLDocumentParser.h:
        * dom/XMLDocumentParserLibxml2.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::startElementNs):
        (WebCore::XMLDocumentParser::endElementNs):
        (WebCore::XMLDocumentParser::lineNumber):
        (WebCore::XMLDocumentParser::columnNumber):
        (WebCore::XMLDocumentParser::textPosition):
        (WebCore::XMLDocumentParser::textPositionOneBased):
        * dom/XMLDocumentParserQt.cpp:
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::textPosition):
        (WebCore::XMLDocumentParser::parseStartElement):
        (WebCore::XMLDocumentParser::parseEndElement):
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::runScriptsForPausedTreeBuilder):
        (WebCore::HTMLDocumentParser::textPosition):
        * html/parser/HTMLDocumentParser.h:
        * html/parser/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::sourceFromPendingScript):
        (WebCore::HTMLScriptRunner::execute):
        (WebCore::HTMLScriptRunner::runScript):
        * html/parser/HTMLScriptRunner.h:
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::uninitializedPositionValue1):
        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
        (WebCore::HTMLTreeBuilder::takeScriptToProcess):
        (WebCore::HTMLTreeBuilder::processEndTag):
        (WebCore::HTMLTreeBuilder::processScriptStartTag):
        * html/parser/HTMLTreeBuilder.h:

2010-11-10  Peter Rybin  <peter.rybin@gmail.com>

        Reviewed by Adam Barth.

        HTML parser should provide script column position within HTML document to JavaScript engine
        https://bugs.webkit.org/show_bug.cgi?id=45271

        Replaces script line number with TextPosition structure.

        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::executeScript):
        (WebKit::WebFrameImpl::executeScriptInIsolatedWorld):
        (WebKit::WebFrameImpl::executeScriptAndReturnValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Wed, 10 Nov 2010 13:54:10 +0000 (13:54 +0000)]
2010-11-10  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Fix autofill popup height computation -- take icon heights into account.
        https://bugs.webkit.org/show_bug.cgi?id=49306

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Kenneth Rohde Christiansen <kenneth@webkit.org>
andreas.kling@nokia.com [Wed, 10 Nov 2010 13:48:39 +0000 (13:48 +0000)]
2010-11-10  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        Use paintEntireContents in combination with tiling, allowing to
        actually set visibleContentRect to something different from
        the actual contents size.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::updateResizesToContentsForPage):
        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::transitionToCommittedForNewPage):
2010-11-10  Kenneth Rohde Christiansen  <kenneth@webkit.org>

        Reviewed by Andreas Kling.

        In paintEntireContents mode (used in combination with tiling) we
        cannot clip to the actual visibleContentRect as the clipped regions
        will not be updated again on scroll. If paintsEntireContents is
        enabled, return the actual content rect.

        * page/FrameView.cpp:
        (WebCore::FrameView::windowClipRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Wed, 10 Nov 2010 12:03:34 +0000 (12:03 +0000)]
Unreviewed.

[Qt] Add platform specific expected results for new passing tests introduced in r71563 and r71700.
Compared to Mac png files and Mac expected files.

* platform/qt/fast/blockflow/horizontal-bt-replaced-selection-expected.checksum: Added.
* platform/qt/fast/blockflow/horizontal-bt-replaced-selection-expected.png: Added.
* platform/qt/fast/blockflow/horizontal-bt-replaced-selection-expected.txt: Added.
* platform/qt/fast/blockflow/vertical-lr-replaced-selection-expected.checksum: Added.
* platform/qt/fast/blockflow/vertical-lr-replaced-selection-expected.png: Added.
* platform/qt/fast/blockflow/vertical-lr-replaced-selection-expected.txt: Added.
* platform/qt/fast/blockflow/vertical-rl-replaced-selection-expected.checksum: Added.
* platform/qt/fast/blockflow/vertical-rl-replaced-selection-expected.png: Added.
* platform/qt/fast/blockflow/vertical-rl-replaced-selection-expected.txt: Added.
* platform/qt/fast/lists/001-vertical-expected.checksum: Added.
* platform/qt/fast/lists/001-vertical-expected.png: Added.
* platform/qt/fast/lists/001-vertical-expected.txt: Added.
* platform/qt/fast/lists/002-vertical-expected.checksum: Added.
* platform/qt/fast/lists/002-vertical-expected.png: Added.
* platform/qt/fast/lists/002-vertical-expected.txt: Added.
* platform/qt/fast/lists/003-vertical-expected.checksum: Added.
* platform/qt/fast/lists/003-vertical-expected.png: Added.
* platform/qt/fast/lists/003-vertical-expected.txt: Added.
* platform/qt/fast/lists/005-vertical-expected.checksum: Added.
* platform/qt/fast/lists/005-vertical-expected.png: Added.
* platform/qt/fast/lists/005-vertical-expected.txt: Added.
* platform/qt/fast/lists/006-vertical-expected.checksum: Added.
* platform/qt/fast/lists/006-vertical-expected.png: Added.
* platform/qt/fast/lists/006-vertical-expected.txt: Added.
* platform/qt/fast/lists/007-vertical-expected.checksum: Added.
* platform/qt/fast/lists/007-vertical-expected.png: Added.
* platform/qt/fast/lists/007-vertical-expected.txt: Added.
* platform/qt/fast/lists/008-vertical-expected.checksum: Added.
* platform/qt/fast/lists/008-vertical-expected.png: Added.
* platform/qt/fast/lists/008-vertical-expected.txt: Added.
* platform/qt/fast/lists/009-vertical-expected.checksum: Added.
* platform/qt/fast/lists/009-vertical-expected.png: Added.
* platform/qt/fast/lists/009-vertical-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Wed, 10 Nov 2010 11:03:01 +0000 (11:03 +0000)]
Unreviewed.

[Qt] svg/animations/animate-path-nested-transforms.html fails
https://bugs.webkit.org/show_bug.cgi?id=48987

svg/animations/animate-text-nested-transforms.html introduced in r71726
and has same failure as svg/animations/animate-path-nested-transforms.html

* platform/qt/Skipped: svg/animations/animate-text-nested-transforms.html added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviwed, updating Chromium test expectations.
ukai@chromium.org [Wed, 10 Nov 2010 10:55:08 +0000 (10:55 +0000)]
Unreviwed, updating Chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Wed, 10 Nov 2010 10:46:36 +0000 (10:46 +0000)]
2010-11-10  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt][WK2] Fix re-use of memory-mapped files
        https://bugs.webkit.org/show_bug.cgi?id=49310

        QTemporaryFile::fileName() returns an empty string after close()
        so we have to keep separate track of the filename.

        Also, we can't reopen the file if it's been QFile::remove()d,
        so we defer unlinking until the MappedMemoryPool is destroyed or
        the CrashHandler kicks in.

        This makes re-use of memory-mapped files work (after we kill an
        assertion that the file size == the new mmap size - it's fine if
        the file is larger, too.)

        * Platform/qt/MappedMemoryPool.cpp:
        (WebKit::MappedMemoryPool::~MappedMemoryPool):
        (WebKit::MappedMemoryPool::clear):
        (WebKit::MappedMemoryPool::mapMemory):
        (WebKit::MappedMemoryPool::mapFile):
        * Platform/qt/MappedMemoryPool.h:
        (WebKit::MappedMemory::mappedFileName):
        * Shared/qt/CrashHandler.cpp:
        (WebKit::CrashHandler::deleteObjects):
        * Shared/qt/UpdateChunk.cpp:
        (WebKit::UpdateChunk::encode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations.
ukai@chromium.org [Wed, 10 Nov 2010 10:23:09 +0000 (10:23 +0000)]
Unreviewed, updating Chromium expectations.

removed the followings, since these always passes recently.
BUG51161 LINUX DEBUG : svg/W3C-SVG-1.1/masking-mask-01-b.svg = CRASH
BUG51161 LINUX DEBUG : svg/clip-path/clip-path-text.svg = CRASH
BUG8729 LINUX DEBUG : http/tests/multipart/invalid-image-data.html = IMAGE PASS
BUGWK45991 : canvas/philip/tests/2d.pattern.image.incomplete.html
BUGDPRANKE LINUX DEBUG : fast/forms/restore-selection-after-layout.html = TEXT

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Wed, 10 Nov 2010 09:12:25 +0000 (09:12 +0000)]
2010-11-10  Shinichiro Hamaji  <hamaji@chromium.org>

        Adding a manual test which I forgot to add in r71618.

        [Chromium] display:none has no effect on <option> element
        https://bugs.webkit.org/show_bug.cgi?id=49169

        * manual-tests/display-none-option.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Shane Stephens <shanestephens@google.com>
commit-queue@webkit.org [Wed, 10 Nov 2010 09:04:09 +0000 (09:04 +0000)]
2010-11-10  Shane Stephens  <shanestephens@google.com>

        Reviewed by Dirk Schulze.

        SVGTextElement supplemental transforms pre-multiplied but should be
        post-multiplied in animatedLocalTransform
        https://bugs.webkit.org/show_bug.cgi?id=48215

        * svg/animations/animate-text-nested-transforms-expected.txt: Added.
        * svg/animations/animate-text-nested-transforms.svg: Added.
2010-11-10  Shane Stephens  <shanestephens@google.com>

        Reviewed by Dirk Schulze.

        SVGTextElement supplemental transforms pre-multiplied but should be
        post-multiplied in animatedLocalTransform
        https://bugs.webkit.org/show_bug.cgi?id=48215

        Test: svg/animations/animate-text-nested-transforms.svg

        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::animatedLocalTransform):

        Switched order of multiplication.  Note that due to a bug in
        AffineTransform's operator* implementation the order of arguments is
        reversed (see http://bugs.webkit.org/show_bug.cgi?id=48031).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations
ukai@chromium.org [Wed, 10 Nov 2010 08:48:22 +0000 (08:48 +0000)]
Unreviewed, updating Chromium expectations
from chrome/src/webkit/tools/layout_tests/test_expectations.txt

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Wed, 10 Nov 2010 08:24:25 +0000 (08:24 +0000)]
2010-11-09  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Fieldsets avoid floats. Legend elements are expected to have their parent
        as fieldset. When this not the case, floats get added incorrectly added to the
        legend blocks. This patch tries to prevent those floats addition.
        https://bugs.webkit.org/show_bug.cgi?id=49214

        Test: fast/blockflow/overhanging-float-legend-crash.html

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::avoidsFloats):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::isLegend):
        * rendering/RenderObject.h:
2010-11-09  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dan Bernstein.

        Tests that we do not crash and avoid floats to be added in legend element
        when it is not enclosed in a fieldset.
        https://bugs.webkit.org/show_bug.cgi?id=49214

        * fast/blockflow/overhanging-float-legend-crash-expected.txt: Added.
        * fast/blockflow/overhanging-float-legend-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-10 Cris Neckar <cdn@chromium.org>
inferno@chromium.org [Wed, 10 Nov 2010 08:20:05 +0000 (08:20 +0000)]
2010-11-10  Cris Neckar  <cdn@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Added check to ensure that svg viewport containers are not treated in the same way as generic svg containers.
        https://bugs.webkit.org/show_bug.cgi?id=49188

        Test: svg/dom/viewport-container-crash.svg

        * rendering/SVGImageBufferTools.cpp:
        (WebCore::SVGImageBufferTools::renderSubtreeToImageBuffer):
2010-11-10  Cris Neckar  <cdn@chromium.org>

        Reviewed by Nikolas Zimmermann.

        Test for crash when svg viewport containers are treated as generic svg containers.
        https://bugs.webkit.org/show_bug.cgi?id=49188

        * svg/dom/viewport-container-crash-expected.txt: Added.
        * svg/dom/viewport-container-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Gabor Loki <loki@webkit.org>
loki@webkit.org [Wed, 10 Nov 2010 07:36:33 +0000 (07:36 +0000)]
2010-11-09  Gabor Loki  <loki@webkit.org>

        Reviewed by Gavin Barraclough.

        ARM JIT asserts when loading http://reader.google.com in debug mode
        https://bugs.webkit.org/show_bug.cgi?id=48912

        There are several cases when the uninterrupted sequence is larger than
        maximum required offset for pathing the same sequence. Eg.: if in a
        uninterrupted sequence the last macroassembler's instruction is a stub
        call, it emits store instruction(s) which should not be included in the
        calculation of length of uninterrupted sequence. So, the insnSpace and
        constSpace should be upper limit instead of hard limit.

        * jit/JIT.h:
        * jit/JITInlineMethods.h:
        (JSC::JIT::endUninterruptedSequence):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Wed, 10 Nov 2010 05:59:45 +0000 (05:59 +0000)]
2010-11-09  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Eric Seidel.

        [WML] Fix build breaks when WML is enabled.
        https://bugs.webkit.org/show_bug.cgi?id=49168

        The backForward() of Page class returns BackForwarddController class type.
        So, WML classes need to include the BackForwardController.h file. And, select()
        of RenderTextControl.h was removed. Thus, the select() should be replaced by
        setSelectionRange().

        * wml/WMLDoElement.cpp: Includes BackForwardController.h.
        * wml/WMLDocument.cpp: ditto.
        * wml/WMLInputElement.cpp:
        (WebCore::WMLInputElement::select): Replaced by setSelectionRange().
        * wml/WMLPageState.cpp: Includes BackForwardController.h.
        * wml/WMLPrevElement.cpp: ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations
ukai@chromium.org [Wed, 10 Nov 2010 05:56:26 +0000 (05:56 +0000)]
Unreviewed, updating Chromium expectations

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 10 Nov 2010 05:55:57 +0000 (05:55 +0000)]
2010-11-09  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add JavaScriptAudioNode files
        https://bugs.webkit.org/show_bug.cgi?id=48875

        No new tests since audio API is not yet implemented.

        * webaudio/JavaScriptAudioNode.cpp: Added.
        (WebCore::JavaScriptAudioNode::create):
        (WebCore::JavaScriptAudioNode::JavaScriptAudioNode):
        (WebCore::JavaScriptAudioNode::~JavaScriptAudioNode):
        (WebCore::JavaScriptAudioNode::initialize):
        (WebCore::JavaScriptAudioNode::uninitialize):
        (WebCore::JavaScriptAudioNode::toJavaScriptAudioNode):
        (WebCore::JavaScriptAudioNode::process):
        (WebCore::JavaScriptAudioNode::fireProcessEventDispatch):
        (WebCore::JavaScriptAudioNode::fireProcessEvent):
        (WebCore::JavaScriptAudioNode::reset):
        (WebCore::JavaScriptAudioNode::scriptExecutionContext):
        * webaudio/JavaScriptAudioNode.h: Added.
        (WebCore::JavaScriptAudioNode::eventTargetData):
        (WebCore::JavaScriptAudioNode::ensureEventTargetData):
        (WebCore::JavaScriptAudioNode::bufferSize):
        (WebCore::JavaScriptAudioNode::doubleBufferIndex):
        (WebCore::JavaScriptAudioNode::swapBuffers):
        (WebCore::JavaScriptAudioNode::refEventTarget):
        (WebCore::JavaScriptAudioNode::derefEventTarget):
        * webaudio/JavaScriptAudioNode.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Wed, 10 Nov 2010 05:41:30 +0000 (05:41 +0000)]
2010-11-09  Helder Correia  <helder@sencha.com>

        Reviewed by Darin Adler.

        Philip Canvas test 2d.pattern.image.incomplete fails
        https://bugs.webkit.org/show_bug.cgi?id=49230

        Modidy test to correctly follow the spec and create an image object
        with its complete attribute set to false. See also:
        https://bugs.webkit.org/show_bug.cgi?id=48306

        * canvas/philip/tests/2d.pattern.image.incomplete.html:
        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/canvas/philip/tests/2d.pattern.image.incomplete-expected.txt: Removed.
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Nico Weber <thakis@chromium.org>
thakis@chromium.org [Wed, 10 Nov 2010 05:24:54 +0000 (05:24 +0000)]
2010-11-09  Nico Weber  <thakis@chromium.org>

        Reviewed by Kenneth Russell.

        [Chromium] Text jitter during 2D CSS transform
        https://bugs.webkit.org/show_bug.cgi?id=49224

        Text subpixel rendering only works in AlphaPremultipliedFirst |
        kCGBitmapByteOrder32Host contexts:
        http://www.cocoabuilder.com/archive/cocoa/228931-sub-pixel-font-smoothing-with-cgbitmapcontext.html

        Changing this has the added benefit that the data layout now matches
        skia.

        * platform/graphics/chromium/ContentLayerChromium.cpp:
        (WebCore::ContentLayerChromium::SharedValues::SharedValues):
        (WebCore::ContentLayerChromium::updateContents):
        * platform/graphics/chromium/ImageLayerChromium.cpp:
        (WebCore::ImageLayerChromium::updateContents):
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::setRootLayerCanvasSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Wed, 10 Nov 2010 05:06:48 +0000 (05:06 +0000)]
2010-11-09  Helder Correia  <helder@sencha.com>

        Reviewed by Darin Adler.

        Philip Canvas test 2d.path.rect.winding fails
        https://bugs.webkit.org/show_bug.cgi?id=49225

        Remove test from skipped list.

        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/qt/Skipped:
2010-11-09  Helder Correia  <helder@sencha.com>

        Reviewed by Darin Adler.

        Philip Canvas test 2d.path.rect.winding fails
        https://bugs.webkit.org/show_bug.cgi?id=49225

        Rect path direction is important for nonzero winding rule.

        The rect(x, y, w, h) method must create a new subpath containing just the four points
        (x, y), (x+w, y), (x+w, y+h), (x, y+h), with those four points connected by straight
        lines, and must then mark the subpath as closed.

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::rect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix on Chromium/Win at r71711
ukai@chromium.org [Wed, 10 Nov 2010 04:59:58 +0000 (04:59 +0000)]
Unreviewed build fix on Chromium/Win at r71711

RefCound.h reported an error that it cannot access private member
declared in class 'WebCore::FileWriterSync' at
WebCore::FileWriterSync::~FileWriterSync.

* fileapi/FileWriterSync.h: make destructor public

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Chris Rogers <crogers@google.com>
crogers@google.com [Wed, 10 Nov 2010 04:48:26 +0000 (04:48 +0000)]
2010-11-09  Chris Rogers  <crogers@google.com>

        Reviewed by James Robinson.

        AudioFileReaderMac.cpp must include <CoreServices/CoreServices.h>
        https://bugs.webkit.org/show_bug.cgi?id=49270

        * platform/audio/mac/AudioFileReaderMac.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Adrienne Walker <enne@google.com>
commit-queue@webkit.org [Wed, 10 Nov 2010 04:23:56 +0000 (04:23 +0000)]
2010-11-09  Adrienne Walker  <enne@google.com>

        Reviewed by Kenneth Russell.

        Removing context-attributes.html webgl test as it is now redundant.
        https://bugs.webkit.org/show_bug.cgi?id=47111

        * fast/canvas/webgl/context-attributes-expected.txt: Removed.
        * fast/canvas/webgl/context-attributes.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations
ukai@chromium.org [Wed, 10 Nov 2010 04:20:37 +0000 (04:20 +0000)]
Unreviewed, updating Chromium expectations

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Eric Uhrhane <ericu@chromium.org>
commit-queue@webkit.org [Wed, 10 Nov 2010 04:02:59 +0000 (04:02 +0000)]
2010-11-09  Eric Uhrhane  <ericu@chromium.org>

        Reviewed by David Levin.

        Add idl and mock classes for FileWriterSync.
        https://bugs.webkit.org/show_bug.cgi?id=48693

        No new tests, as there's no functionality.

        Build file additions.
        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/scripts/CodeGeneratorV8.pm:

        * fileapi/FileWriterSync.cpp: Added.
        * fileapi/FileWriterSync.h: Added.
        * fileapi/FileWriterSync.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Mario Sanchez Prada <msanchez@igalia.com>
commit-queue@webkit.org [Wed, 10 Nov 2010 03:44:33 +0000 (03:44 +0000)]
2010-11-09  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Improve accessibility of focusable lists
        https://bugs.webkit.org/show_bug.cgi?id=25679

        Emit the 'selected' and 'focused' events as needed.

        This is the last bit of a series of patches to fix bug 25679,
        which just ensures that the right signals are emmited whenever a
        selection inside a listbox object changes, that is, the signals
        'state-changed::selected', 'state-changed::focused' and
        'focus-event', along with the right detail for each of them to
        report if the focus/selection has been activated or not.

        * accessibility/gtk/AXObjectCacheAtk.cpp:
        (WebCore::notifyChildrenSelectionChange): New, takes care of
        emitting all the needed signals when children selection has
        changed, both from the point of view of the container and the
        selected/unselected items inside of it. It currently supports
        listboxes (html 'select' controls) only.
        (WebCore::AXObjectCache::postPlatformNotification): Replaced some
        old code with a simple call to notifyChildrenSelectionChange().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 10 Nov 2010 03:10:05 +0000 (03:10 +0000)]
2010-11-09  Ryosuke Niwa  <rniwa@webkit.org>

        Yet another unreviewed Chromium rebaselines for r71465.

        * platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.checksum:
        * platform/chromium-mac/fast/blockflow/border-radius-clipping-vertical-lr-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.checksum:
        * platform/chromium-mac/fast/blockflow/border-vertical-lr-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.checksum:
        * platform/chromium-mac/fast/blockflow/box-shadow-vertical-lr-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
        * platform/chromium-mac/fast/blockflow/japanese-lr-selection-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.checksum:
        * platform/chromium-mac/fast/blockflow/japanese-lr-text-expected.png: Added.
        * platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.checksum: Added.
        * platform/chromium-mac/fast/blockflow/japanese-rl-selection-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 02:51:49 +0000 (02:51 +0000)]
2010-11-09  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline.

        Add missing Linux and Windows baselines for the tests added by r71700.
        Also update baselines for editing/selection/extend-by-word-002.html
        and fast/lists/markers-in-selection-expected.html.

        * platform/chromium-linux/editing/selection/extend-by-word-002-expected.checksum:
        * platform/chromium-linux/editing/selection/extend-by-word-002-expected.png:
        * platform/chromium-linux/fast/lists/001-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/lists/001-vertical-expected.png: Added.
        * platform/chromium-linux/fast/lists/001-vertical-expected.txt: Added.
        * platform/chromium-linux/fast/lists/002-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/lists/002-vertical-expected.png: Added.
        * platform/chromium-linux/fast/lists/002-vertical-expected.txt: Added.
        * platform/chromium-linux/fast/lists/003-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/lists/003-vertical-expected.png: Added.
        * platform/chromium-linux/fast/lists/003-vertical-expected.txt: Added.
        * platform/chromium-linux/fast/lists/005-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/lists/005-vertical-expected.png: Added.
        * platform/chromium-linux/fast/lists/005-vertical-expected.txt: Added.
        * platform/chromium-linux/fast/lists/006-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/lists/006-vertical-expected.png: Added.
        * platform/chromium-linux/fast/lists/006-vertical-expected.txt: Added.
        * platform/chromium-linux/fast/lists/007-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/lists/007-vertical-expected.png: Added.
        * platform/chromium-linux/fast/lists/007-vertical-expected.txt: Added.
        * platform/chromium-linux/fast/lists/008-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/lists/008-vertical-expected.png: Added.
        * platform/chromium-linux/fast/lists/008-vertical-expected.txt: Added.
        * platform/chromium-linux/fast/lists/009-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/lists/009-vertical-expected.png: Added.
        * platform/chromium-linux/fast/lists/009-vertical-expected.txt: Added.
        * platform/chromium-linux/fast/lists/markers-in-selection-expected.checksum:
        * platform/chromium-linux/fast/lists/markers-in-selection-expected.png:
        * platform/chromium-win/editing/selection/extend-by-word-002-expected.checksum:
        * platform/chromium-win/editing/selection/extend-by-word-002-expected.png:
        * platform/chromium-win/fast/lists/001-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/lists/001-vertical-expected.png: Added.
        * platform/chromium-win/fast/lists/001-vertical-expected.txt: Added.
        * platform/chromium-win/fast/lists/002-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/lists/002-vertical-expected.png: Added.
        * platform/chromium-win/fast/lists/002-vertical-expected.txt: Added.
        * platform/chromium-win/fast/lists/003-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/lists/003-vertical-expected.png: Added.
        * platform/chromium-win/fast/lists/003-vertical-expected.txt: Added.
        * platform/chromium-win/fast/lists/005-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/lists/005-vertical-expected.png: Added.
        * platform/chromium-win/fast/lists/005-vertical-expected.txt: Added.
        * platform/chromium-win/fast/lists/006-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/lists/006-vertical-expected.png: Added.
        * platform/chromium-win/fast/lists/006-vertical-expected.txt: Added.
        * platform/chromium-win/fast/lists/007-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/lists/007-vertical-expected.png: Added.
        * platform/chromium-win/fast/lists/007-vertical-expected.txt: Added.
        * platform/chromium-win/fast/lists/008-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/lists/008-vertical-expected.png: Added.
        * platform/chromium-win/fast/lists/008-vertical-expected.txt: Added.
        * platform/chromium-win/fast/lists/009-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/lists/009-vertical-expected.png: Added.
        * platform/chromium-win/fast/lists/009-vertical-expected.txt: Added.
        * platform/chromium-win/fast/lists/markers-in-selection-expected.checksum:
        * platform/chromium-win/fast/lists/markers-in-selection-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 10 Nov 2010 02:35:53 +0000 (02:35 +0000)]
2010-11-09  Xiaomei Ji  <xji@chromium.org>

        Reviewed by NOBODY.

        Skip bidi-control-chars-treated-as-ZWS.html in leopard while investigating
        bug 49295 -- Regression in ATSUI handling.

        * platform/mac-leopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 10 Nov 2010 02:33:09 +0000 (02:33 +0000)]
2010-11-09  Xiaomei Ji  <xji@chromium.org>

        Reviewed by NOBODY.

        Rebaseline for leopard after r71566.

        * platform/mac-leopard/fast/text/international/bidi-neutral-run-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Wed, 10 Nov 2010 02:26:17 +0000 (02:26 +0000)]
2010-11-09  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        WebGraphicsContext3DDefaultImpl does not run on top of OpenGL ES 2.0 implementations
        https://bugs.webkit.org/show_bug.cgi?id=48282

        Fixed assumptions in WebGraphicsContext3DDefaultImpl that it was
        running on top of desktop GL.

        Tested various WebGL demos on Windows with ANGLE and
        --in-process-webgl --disable-accelerated-compositing; all are now
        working. Verified that --use-gl=desktop continues to work in the
        same configuration.

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::WebGraphicsContext3DDefaultImpl):
        (WebKit::WebGraphicsContext3DDefaultImpl::initialize):
        (WebKit::WebGraphicsContext3DDefaultImpl::validateAttributes):
        (WebKit::WebGraphicsContext3DDefaultImpl::resolveMultisampledFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::isGLES2Compliant):
        (WebKit::WebGraphicsContext3DDefaultImpl::reshape):
        (WebKit::WebGraphicsContext3DDefaultImpl::readBackFramebuffer):
        (WebKit::WebGraphicsContext3DDefaultImpl::getIntegerv):
        (WebKit::WebGraphicsContext3DDefaultImpl::angleValidateShaderSource):
        * src/WebGraphicsContext3DDefaultImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 02:24:07 +0000 (02:24 +0000)]
2010-11-09  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium rebaseline.

        Add missing Linux and Windows baselines for the tests added by r71382.

        * platform/chromium-linux/fast/table/027-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/027-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/028-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/028-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/035-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/035-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/038-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/038-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/040-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/040-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/auto-with-percent-height-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/border-collapsing/001-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/border-collapsing/002-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/border-collapsing/003-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/border-collapsing/004-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/height-percent-test-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/height-percent-test-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/rowspan-paint-order-vertical-expected.png: Added.
        * platform/chromium-linux/fast/table/table-display-types-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/table/table-display-types-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/027-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/027-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/027-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/028-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/028-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/028-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/035-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/035-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/035-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/038-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/038-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/038-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/040-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/040-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/040-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/auto-with-percent-height-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/border-collapsing/001-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/border-collapsing/002-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/border-collapsing/002-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/border-collapsing/002-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/border-collapsing/003-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/border-collapsing/004-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/border-collapsing/border-collapsing-head-foot-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/border-collapsing/equal-precedence-resolution-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/border-collapsing/rtl-border-collapsing-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/height-percent-test-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/height-percent-test-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/rowspan-paint-order-vertical-expected.txt: Added.
        * platform/chromium-win/fast/table/table-display-types-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/table/table-display-types-vertical-expected.png: Added.
        * platform/chromium-win/fast/table/table-display-types-vertical-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 10 Nov 2010 02:22:03 +0000 (02:22 +0000)]
2010-11-09  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaselines.

        * platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/delete-after-span-ws-001-expected.png: Added.
        * platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/delete-after-span-ws-002-expected.png: Added.
        * platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/delete-after-span-ws-003-expected.png: Added.
        * platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/delete-line-end-ws-001-expected.png: Added.
        * platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.checksum: Added.
        * platform/chromium-mac/editing/deleting/delete-line-end-ws-002-expected.png: Added.
        * platform/chromium-mac/editing/inserting/insert-div-023-expected.checksum: Added.
        * platform/chromium-mac/editing/inserting/insert-div-023-expected.png: Added.
        * platform/chromium-mac/editing/selection/focus_editable_html-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/focus_editable_html-expected.png: Added.
        * platform/chromium-mac/editing/selection/iframe-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/iframe-expected.png: Added.
        * platform/chromium-mac/editing/selection/select-all-001-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/select-all-001-expected.png: Added.
        * platform/chromium-mac/editing/selection/select-all-002-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/select-all-002-expected.png: Added.
        * platform/chromium-mac/editing/selection/select-all-003-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/select-all-003-expected.png: Added.
        * platform/chromium-mac/editing/selection/select-all-004-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/select-all-004-expected.png: Added.
        * platform/chromium-mac/editing/selection/unrendered-001-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/unrendered-001-expected.png: Added.
        * platform/chromium-mac/editing/selection/unrendered-003-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/unrendered-003-expected.png: Added.
        * platform/chromium-mac/editing/selection/unrendered-004-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/unrendered-004-expected.png: Added.
        * platform/chromium-mac/editing/selection/unrendered-005-expected.checksum: Added.
        * platform/chromium-mac/editing/selection/unrendered-005-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 10 Nov 2010 02:09:04 +0000 (02:09 +0000)]
2010-11-09  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectations update.
        Skip platform/mac/editing/deleting/backward-delete.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 02:07:18 +0000 (02:07 +0000)]
2010-11-09  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium test_expectations.txt update.

        svg/animations/animate-path-nested-transforms.html is flaky on all
        platforms.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=49202
hyatt@apple.com [Wed, 10 Nov 2010 01:46:10 +0000 (01:46 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=49202

Reviewed by Dan Bernstein.

WebCore:

Make lists work with vertical text.

(1) Patch all the CSS rules in html.css so that the margins are directionally abstract.
(2) Add a transposedRect and transposedSize method to IntRect and IntSize for swapping x/y and width/height.
(3) Add adjustLineDirectionPosition as a helper for moving a line box only in the line direction.
(4) Fix a bug in addIntrudingFLoats uncovered by list test cases where the top margin of an element was being
incorrectly added to a float's physical left side instead of its top side.
(5) Make positioning and painting and selection of list markers account for all writing modes.
(6) Add helpers for setting the start and end margins directly in a RenderStyle, since lists do this to hack
marker margins before they have been calculated and set on the box.

Cloned a bunch of fast/lists tests into fast/lists/*-vertical.html versions.

* css/html.css:
* platform/graphics/IntRect.h:
(WebCore::IntRect::transposedRect):
* platform/graphics/IntSize.h:
(WebCore::IntSize::transposedSize):
* rendering/InlineBox.h:
(WebCore::InlineBox::adjustLineDirectionPosition):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::addIntrudingFloats):
* rendering/RenderListItem.cpp:
(WebCore::getParentOfFirstLineBox):
(WebCore::RenderListItem::positionListMarker):
(WebCore::RenderListItem::paint):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::localSelectionRect):
(WebCore::RenderListMarker::paint):
(WebCore::RenderListMarker::layout):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMargins):
(WebCore::RenderListMarker::getRelativeMarkerRect):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setMarginStart):
(WebCore::RenderStyle::setMarginEnd):
* rendering/style/RenderStyle.h:

LayoutTests:

Make lists work with vertical text.

(1) Patch all the CSS rules in html.css so that the margins are directionally abstract.
(2) Add a transposedRect and transposedSize method to IntRect and IntSize for swapping x/y and width/height.
(3) Add adjustLineDirectionPosition as a helper for moving a line box only in the line direction.
(4) Fix a bug in addIntrudingFLoats uncovered by list test cases where the top margin of an element was being
incorrectly added to a float's physical left side instead of its top side.
(5) Make positioning and painting and selection of list markers account for all writing modes.
(6) Add helpers for setting the start and end margins directly in a RenderStyle, since lists do this to hack
marker margins before they have been calculated and set on the box.

Cloned a bunch of fast/lists tests into fast/lists/*-vertical.html versions.

* fast/lists/001-vertical.html: Added.
* fast/lists/002-vertical.html: Added.
* fast/lists/003-vertical.html: Added.
* fast/lists/005-vertical.html: Added.
* fast/lists/006-vertical.html: Added.
* fast/lists/007-vertical.html: Added.
* fast/lists/008-vertical.html: Added.
* fast/lists/009-vertical.html: Added.
* platform/mac/fast/lists/001-vertical-expected.checksum: Added.
* platform/mac/fast/lists/001-vertical-expected.png: Added.
* platform/mac/fast/lists/001-vertical-expected.txt: Added.
* platform/mac/fast/lists/002-vertical-expected.checksum: Added.
* platform/mac/fast/lists/002-vertical-expected.png: Added.
* platform/mac/fast/lists/002-vertical-expected.txt: Added.
* platform/mac/fast/lists/003-vertical-expected.checksum: Added.
* platform/mac/fast/lists/003-vertical-expected.png: Added.
* platform/mac/fast/lists/003-vertical-expected.txt: Added.
* platform/mac/fast/lists/005-vertical-expected.checksum: Added.
* platform/mac/fast/lists/005-vertical-expected.png: Added.
* platform/mac/fast/lists/005-vertical-expected.txt: Added.
* platform/mac/fast/lists/006-vertical-expected.checksum: Added.
* platform/mac/fast/lists/006-vertical-expected.png: Added.
* platform/mac/fast/lists/006-vertical-expected.txt: Added.
* platform/mac/fast/lists/007-vertical-expected.checksum: Added.
* platform/mac/fast/lists/007-vertical-expected.png: Added.
* platform/mac/fast/lists/007-vertical-expected.txt: Added.
* platform/mac/fast/lists/008-vertical-expected.checksum: Added.
* platform/mac/fast/lists/008-vertical-expected.png: Added.
* platform/mac/fast/lists/008-vertical-expected.txt: Added.
* platform/mac/fast/lists/009-vertical-expected.checksum: Added.
* platform/mac/fast/lists/009-vertical-expected.png: Added.
* platform/mac/fast/lists/009-vertical-expected.txt: Added.
* platform/mac/fast/lists/inlineBoxWrapperNullCheck-expected.png:
* platform/mac/fast/lists/markers-in-selection-expected.checksum:
* platform/mac/fast/lists/markers-in-selection-expected.png:
* platform/mac/fast/lists/ol-start-parsing-expected.checksum:
* platform/mac/fast/lists/ol-start-parsing-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 00:46:44 +0000 (00:46 +0000)]
2010-11-09  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] http/tests/security/XFrameOptions fail with Chromium DRT
        https://bugs.webkit.org/show_bug.cgi?id=49286

        The tests in http/tests/security/XFrameOptions started to fail after
        r71297, since it changed the WebViewHost::assignIdentifierToRequest
        logic to always assign identifiers to requests, even if we're not going
        to be dumping resource load callbacks at that point. These tests
        only call LayoutTestController.dumpResourceLoadCallbacks after the
        request is started, thus their expectations have "<unknown>" as the
        identifier. Change WebViewHost to the previous behavior, which also
        match the other ports'.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (WebViewHost::assignIdentifierToRequest):
        (WebViewHost::removeIdentifierForRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-11-09 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Wed, 10 Nov 2010 00:40:32 +0000 (00:40 +0000)]
2010-11-09  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed Chromium test_expectations.txt update.

        - fast/images/gif-loop-count.html fails on other platforms too (not just
          on Windows)
        - svg/animations/animate-path-nested-transforms.html also has text diffs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@71698 268f45cc-cd09-0410-ab3c-d52691b4dbfc