WebKit-https.git
6 years ago[chromium] Remove unused WebRegularExpression API
commit-queue@webkit.org [Fri, 29 Mar 2013 01:48:00 +0000 (01:48 +0000)]
[chromium] Remove unused WebRegularExpression API
https://bugs.webkit.org/show_bug.cgi?id=113520

Patch by James Robinson <jamesr@chromium.org> on 2013-03-28
Reviewed by Kent Tamura.

Last reference to these files removed in r190880.

* WebKit.gyp:
* public/WebRegularExpression.h: Removed.
* public/WebTextCaseSensitivity.h: Removed.
* src/AssertMatchingEnums.cpp:
* src/WebRegularExpression.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWe leak NetworkConnectionToWebProcess objects.
beidson@apple.com [Fri, 29 Mar 2013 01:16:54 +0000 (01:16 +0000)]
We leak NetworkConnectionToWebProcess objects.
<rdar://problem/13393118> and https://bugs.webkit.org/show_bug.cgi?id=113551

Reviewed by Anders Carlsson.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::didClose): Remove this from the global set
  of NetworkConnectionToWebProcess objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplified the bytecode by removing op_loop and op_loop_if_*
ggaren@apple.com [Fri, 29 Mar 2013 01:09:53 +0000 (01:09 +0000)]
Simplified the bytecode by removing op_loop and op_loop_if_*
https://bugs.webkit.org/show_bug.cgi?id=113548

Reviewed by Filip Pizlo.

Regular jumps will suffice.

These opcodes are identical to branches, except they also do timeout
checking. That style of timeout checking has been broken for a long
time, and when we add back timeout checking, it won't use these opcodes.

* JavaScriptCore.order:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
* bytecode/Opcode.h:
(JSC):
(JSC::padOpcodeName):
* bytecode/PreciseJumpTargets.cpp:
(JSC::computePreciseJumpTargets):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitJump):
(JSC::BytecodeGenerator::emitJumpIfTrue):
(JSC::BytecodeGenerator::emitJumpIfFalse):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.h:
(JSC::DFG::canCompileOpcode):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
(JSC::JIT::privateCompileSlowCases):
* jit/JIT.h:
(JIT):
(JSC):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Don't cross editing boundary when touch hold selection expands
commit-queue@webkit.org [Fri, 29 Mar 2013 01:01:01 +0000 (01:01 +0000)]
[BlackBerry] Don't cross editing boundary when touch hold selection expands
https://bugs.webkit.org/show_bug.cgi?id=113537

Patch by Iris Wu <shuwu@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Set editing boundary crossing rule to make sure it won't cross
editing boundary when selection expands.

Reviewed Internally By Genevieve Mak and Mike Fenton.

* WebKitSupport/SelectionHandler.cpp:
(BlackBerry::WebKit::SelectionHandler::selectNextParagraph):
(BlackBerry::WebKit::SelectionHandler::findNextAnimationOverlayRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
mkwst@chromium.org [Fri, 29 Mar 2013 00:51:05 +0000 (00:51 +0000)]
Unreviewed gardening.

http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
crashes sometimes. Applying the patch from wkbug.com/111902 fixes it
locally for me: skipping it until that patch lands.

* platform/mac/TestExpectations:
    Marking http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html
    as crashy in Debug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix compiler warning in IDBTransaction::modeToString
pdr@google.com [Fri, 29 Mar 2013 00:50:18 +0000 (00:50 +0000)]
Fix compiler warning in IDBTransaction::modeToString
https://bugs.webkit.org/show_bug.cgi?id=113547

Reviewed by Darin Adler.

Not all compilers are smart enough to handle this switch. This patch refactors
modeToString to not return from the default case.

No new tests as this is just a compiler fix.

* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::modeToString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
simon.fraser@apple.com [Fri, 29 Mar 2013 00:18:44 +0000 (00:18 +0000)]
GraphicsLayerCA::recomputeVisibleRects() shouldn't actually set the visible rect
https://bugs.webkit.org/show_bug.cgi?id=113544

Reviewed by Tim Horton.

The functions added in r147058 to update the visible rects of GraphicsLayerCAs
should not have actually set the m_visibleRect on the layer, because this
caused a later call to adjustTiledLayerVisibleRect() to think that the visible
rect had not changed, so it did no expansion.

Clarify the logic to ask the GraphicsLayer whether, given a new visible
rect, it would need to make new tiles (which happens later during a flush).

Add a function to RenderLayerCompositor to call this code (but which has
no callers yet).

* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::visibleRectChangeRequiresFlush): Make private.
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::recursiveVisibleRectChangeRequiresFlush):
(WebCore::GraphicsLayerCA::visibleRectChangeRequiresFlush):
* platform/graphics/ca/GraphicsLayerCA.h:
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::noteVisibleRectChanged):
* rendering/RenderLayerCompositor.h:
(RenderLayerCompositor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[HTMLTemplateElement] <template> should be able to be a foster parent
rafaelw@chromium.org [Fri, 29 Mar 2013 00:13:05 +0000 (00:13 +0000)]
[HTMLTemplateElement] <template> should be able to be a foster parent
https://bugs.webkit.org/show_bug.cgi?id=113541

Source/WebCore:

Reviewed by Eric Seidel

This adds to the check in findFosterSite to include whether the parent is a DocumentFragment which is a template contents.

Tests added to html5lib suite.

* html/parser/HTMLConstructionSite.cpp:
(WebCore::HTMLConstructionSite::findFosterSite):

LayoutTests:

Reviewed by Eric Seidel.

* html5lib/resources/template.dat:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSimplified the bytecode by removing op_jmp_scopes
ggaren@apple.com [Fri, 29 Mar 2013 00:09:56 +0000 (00:09 +0000)]
Simplified the bytecode by removing op_jmp_scopes
https://bugs.webkit.org/show_bug.cgi?id=113545

Reviewed by Filip Pizlo.

We already have op_pop_scope and op_jmp, so we don't need op_jmp_scopes.
Using op_jmp_scopes was also adding a "jump to self" to codegen for
return statements, which was pretty silly.

* JavaScriptCore.order:
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
* bytecode/Opcode.h:
(JSC::padOpcodeName):
* bytecode/PreciseJumpTargets.cpp:
(JSC::computePreciseJumpTargets):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitComplexPopScopes):
(JSC::BytecodeGenerator::emitPopScopes):
* bytecompiler/BytecodeGenerator.h:
(BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITOpcodes.cpp:
* jit/JITOpcodes32_64.cpp:
* jit/JITStubs.cpp:
* jit/JITStubs.h:
* llint/LLIntSlowPaths.cpp:
* llint/LLIntSlowPaths.h:
* llint/LowLevelInterpreter.asm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoConvert some flexbox layout tests to using flexbox.css
tony@chromium.org [Thu, 28 Mar 2013 23:46:09 +0000 (23:46 +0000)]
Convert some flexbox layout tests to using flexbox.css
https://bugs.webkit.org/show_bug.cgi?id=113534

Reviewed by Ojan Vafai.

This allows tests to be run without the -webkit prefix for flexbox tests allowing
some of them to run in Firefox.

* css3/flexbox/flex-align-baseline.html:
* css3/flexbox/flex-align-column.html:
* css3/flexbox/flex-align-end.html:
* css3/flexbox/flex-align-max.html:
* css3/flexbox/flex-align-percent-height.html:
* css3/flexbox/flex-align-stretch.html:
* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Unreviewed, fix up some lint errors in TestExpectations.
tony@chromium.org [Thu, 28 Mar 2013 23:43:14 +0000 (23:43 +0000)]
[chromium] Unreviewed, fix up some lint errors in TestExpectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Use widget.parent() for plugin WebMouseEvents
aelias@chromium.org [Thu, 28 Mar 2013 23:40:28 +0000 (23:40 +0000)]
[chromium] Use widget.parent() for plugin WebMouseEvents
https://bugs.webkit.org/show_bug.cgi?id=113543

Reviewed by James Robinson.

In r142571 I switches widget.parent() to widget.root() in the plugin
WebCore event -> WebMouseEvent creator, to make the converter the
inverse of the one going the other way and avoid null pointer crashes.
But the plugin code expects it to be parent() (see
http://crbug.com/223335).

* src/WebInputEventConversion.cpp:
(WebKit::updateWebMouseEventFromWebCoreMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoResources are never revalidated/reloaded if a cached response exists on disk.
beidson@apple.com [Thu, 28 Mar 2013 23:09:03 +0000 (23:09 +0000)]
Resources are never revalidated/reloaded if a cached response exists on disk.
<rdar://problem/13479890> and https://bugs.webkit.org/show_bug.cgi?id=113542

Reviewed by Alexey Proskuryakov.

Trying to get a cached resource in didReceiveResponse and then aborting the load
meant we never performed any new loads.

We can check and see if the data is cached data inside didReceiveBuffer, instead.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit::NetworkResourceLoader::didReceiveResponse): Don't try for cached resources here.
(WebKit::NetworkResourceLoader::didReceiveData): This callback should never be used.
(WebKit::NetworkResourceLoader::didReceiveBuffer): Try to see if this data objected represents
  a file based mmaped buffer.
* NetworkProcess/NetworkResourceLoader.h:

Refactor these utility functions to start from either a CFURLCachedResponse or a SharedBuffer:
* NetworkProcess/mac/NetworkResourceLoaderMac.mm:
(CFCachedURLResponseGetMemMappedData):
(CFURLCacheIsMemMappedData):
(WebKit::tryGetShareableHandleFromCFData):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromCFURLCachedResponse):
(WebKit::NetworkResourceLoader::tryGetShareableHandleFromSharedBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Don't create SolidColorLayer for full transparent background
wangxianzhu@chromium.org [Thu, 28 Mar 2013 23:08:43 +0000 (23:08 +0000)]
[Chromium] Don't create SolidColorLayer for full transparent background
https://bugs.webkit.org/show_bug.cgi?id=113524

Reviewed by James Robinson.

Source/WebCore:

Test: GraphicsLayerChromiumTest.setContentsToSolidColor

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToSolidColor):

Source/WebKit/chromium:

* tests/GraphicsLayerChromiumTest.cpp:
(GraphicsLayerChromiumTest::setContentsToSolidColor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agouse XMLHttpRequestResponseType enumeration in XMLHttpRequest.idl
commit-queue@webkit.org [Thu, 28 Mar 2013 22:39:44 +0000 (22:39 +0000)]
use XMLHttpRequestResponseType enumeration in XMLHttpRequest.idl
https://bugs.webkit.org/show_bug.cgi?id=113518

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

Use enum XMLHttpRequestResponseType type instead of DOMString for
XMLHttpRequest responseType.

Argument validation now happens in the bindings.
XMLHttpRequest::setResponseType should then never receive invalid
arguments. So, replace console message with ASSERT_NOT_REACHED();

Test: fast/xmlhttprequest/xmlhttprequest-set-responsetype.html

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::setResponseType):
* xml/XMLHttpRequest.idl:

LayoutTests:

Update xmlhttprequest-responsetype-set-invalidtype expected result:
Test all valide responseType. Remove expected console message in case
of invalid responseType. Rename to xmlhttprequest-set-responsetype

* fast/xmlhttprequest/xmlhttprequest-set-responsetype-expected.txt: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt.
* fast/xmlhttprequest/xmlhttprequest-set-responsetype.html: Renamed from LayoutTests/fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype.html.
* fast/xmlhttprequest/xmlhttprequest-responsetype-set-invalidtype-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[css3-text] Add platform support for "wavy" text decoration style
commit-queue@webkit.org [Thu, 28 Mar 2013 22:25:23 +0000 (22:25 +0000)]
[css3-text] Add platform support for "wavy" text decoration style
https://bugs.webkit.org/show_bug.cgi?id=92868

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-03-28
Reviewed by Benjamin Poulain.

Source/WebCore:

This patch uses GraphicsContext::strokePath() to implement
wavy decoration for the CSS3 property "text-decoration-style".

No new tests as this is covered with existing tests.

* rendering/InlineTextBox.cpp:
(WebCore::textDecorationStyleToStrokeStyle): Remove obsolete comment.
(WebCore::adjustStepToDecorationLength): Add function to adjust
variables used to calculate the lenght of Bezier curves.
(WebCore::strokeWavyTextDecoration): Add function to stroke wavy
decoration based on cubic Bezier curve.
(WebCore::InlineTextBox::paintDecoration): Call
strokeWavyTextDecoration when necessary.

LayoutTests:

Rebaseline chromium-linux expectation for
fast/css3-text/css3-text-decoration/text-decoration-style.html.

* platform/chromium-linux/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r147149): breaks binding test on Mac. (Requested by mlam_ on #webkit).
commit-queue@webkit.org [Thu, 28 Mar 2013 22:17:05 +0000 (22:17 +0000)]
REGRESSION(r147149): breaks binding test on Mac. (Requested by mlam_ on #webkit).
https://bugs.webkit.org/show_bug.cgi?id=113538

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Simon Fraser.

Run run-bindings-tests --reset-results to fix broken tests after
r147149.

* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::TestInterfaceV8Internal::supplementalNodeAttrSetter):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::shortAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedShortAttrAttrSetter):
(WebCore::TestObjV8Internal::longAttrAttrSetter):
(WebCore::TestObjV8Internal::longLongAttrAttrSetter):
(WebCore::TestObjV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestObjV8Internal::testObjAttrAttrSetter):
(WebCore::TestObjV8Internal::XMLObjAttrAttrSetter):
(WebCore::TestObjV8Internal::createAttrSetter):
(WebCore::TestObjV8Internal::reflectedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedUnsignedIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedBooleanAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomIntegralAttrAttrSetter):
(WebCore::TestObjV8Internal::reflectedCustomBooleanAttrAttrSetter):
(WebCore::TestObjV8Internal::typedArrayAttrAttrSetter):
(WebCore::TestObjV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::attrWithSetterExceptionAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateAttributeRaisesAttrSetter):
(WebCore::TestObjV8Internal::withScriptExecutionContextAndScriptStateWithSpacesAttributeAttrSetter):
(WebCore::TestObjV8Internal::withScriptArgumentsAndCallStackAttributeAttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr1AttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr2AttrSetter):
(WebCore::TestObjV8Internal::conditionalAttr3AttrSetter):
(WebCore::TestObjV8Internal::anyAttributeAttrSetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr1AttrSetter):
(WebCore::TestObjV8Internal::enabledAtRuntimeAttr2AttrSetter):
(WebCore::TestObjV8Internal::enabledPerContextAttr1AttrSetter):
(WebCore::TestObjV8Internal::enabledPerContextAttr2AttrSetter):
(WebCore::TestObjV8Internal::floatArrayAttrSetter):
(WebCore::TestObjV8Internal::doubleArrayAttrSetter):
(WebCore::TestObjV8Internal::mutablePointAttrSetter):
(WebCore::TestObjV8Internal::immutablePointAttrSetter):
(WebCore::TestObjV8Internal::strawberryAttrSetter):
(WebCore::TestObjV8Internal::strictFloatAttrSetter):
(WebCore::TestObjV8Internal::idAttrSetter):
(WebCore::TestObjV8Internal::nullableLongSettableAttributeAttrSetter):
(WebCore::TestObjV8Internal::nullableStringValueAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetter):
(WebCore::TestObjV8Internal::perWorldAttributeAttrSetterForMainWorld):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::TestSerializedScriptValueInterfaceV8Internal::valueAttrSetter):
(WebCore::TestSerializedScriptValueInterfaceV8Internal::cachedValueAttrSetter):
* bindings/scripts/test/V8/V8TestTypedefs.cpp:
(WebCore::TestTypedefsV8Internal::unsignedLongLongAttrAttrSetter):
(WebCore::TestTypedefsV8Internal::immutableSerializedScriptValueAttrSetter):
(WebCore::TestTypedefsV8Internal::attrWithGetterExceptionAttrSetter):
(WebCore::TestTypedefsV8Internal::attrWithSetterExceptionAttrSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed...
timothy_horton@apple.com [Thu, 28 Mar 2013 22:07:16 +0000 (22:07 +0000)]
[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed by PluginDocuments leaving the page cache
https://bugs.webkit.org/show_bug.cgi?id=113430
<rdar://problem/12729564>

Reviewed by Brady Eidson.

http://trac.webkit.org/changeset/147152 was wrong, and should have been
(as the ChangeLog stated) testing the argument to redirectDataToPlugin,
not the value of m_pluginView.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::redirectDataToPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r147130.
commit-queue@webkit.org [Thu, 28 Mar 2013 22:07:12 +0000 (22:07 +0000)]
Unreviewed, rolling out r147130.
http://trac.webkit.org/changeset/147130
https://bugs.webkit.org/show_bug.cgi?id=113539

Not needed now that we do not sleep in preprocessor.pm
(Requested by jamesr on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28

* WebCore.gyp/WebCore.gyp:
* bindings/scripts/CodeGenerator.pm:
(ParseInterface):
* bindings/scripts/IDLParser.pm:
(Parse):
* bindings/scripts/generate-bindings.pl:
* bindings/scripts/generate-preprocessed-idls.pl: Removed.
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDisable running tests on Mac EWS until we can find a way to keep the queue at a reaso...
lforschler@apple.com [Thu, 28 Mar 2013 22:01:32 +0000 (22:01 +0000)]
Disable running tests on Mac EWS until we can find a way to keep the queue at a reasonable length.

Unreviewed.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Don't grant local content permissions for appcache loads.
japhet@chromium.org [Thu, 28 Mar 2013 21:58:19 +0000 (21:58 +0000)]
Source/WebCore: Don't grant local content permissions for appcache loads.
https://bugs.webkit.org/show_bug.cgi?id=112542

Reviewed by Antti Koivisto.

No new tests, fixing http/tests/appcache/local-content.html

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::DocumentLoader):
(WebCore::DocumentLoader::commitData): Don't grant local load permissions
    to all SubstituteData loads, only give them to loads that were SubstituteData
    loads at the time of DocumentLoader construction. This constitutes all
    SubstituteData loads except those triggered by appcache.
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::didBeginDocument): Move granting local load
    permissions for SubstituteData loads to DocumentLoader::commitData().

LayoutTests: Remove expected failure for https://bugs.webkit.org/show_bug.cgi?id=112542

Reviewed by Antti Koivisto.

* platform/qt-5.0-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoX-Frame-Options: Blocked resources should fire load events.
mkwst@chromium.org [Thu, 28 Mar 2013 21:56:07 +0000 (21:56 +0000)]
X-Frame-Options: Blocked resources should fire load events.
https://bugs.webkit.org/show_bug.cgi?id=113192

Reviewed by Nate Chapin.

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::responseReceived):
    Fire a load event on the frame's owner element when denying access
    due to X-Frame-Options header content. This brings us in-line with
    Gecko and IE, which both trigger load events currently.

LayoutTests:

* http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow.html:
* http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients.html:
* http/tests/security/XFrameOptions/x-frame-options-deny.html:
* http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
* http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny.html:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-expected.txt:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-meta-tag-parent-same-origin-allow-expected.txt:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-deny-multiple-clients-expected.txt:
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-parent-same-origin-deny-expected.txt:
    Add some expectations around the 'load' event to ensure it's fired.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSupport bottom-right anchored fixed-position elements during a pinch gesture
commit-queue@webkit.org [Thu, 28 Mar 2013 21:50:39 +0000 (21:50 +0000)]
Support bottom-right anchored fixed-position elements during a pinch gesture
https://bugs.webkit.org/show_bug.cgi?id=111670

Patch by Tien-Ren Chen <trchen@chromium.org> on 2013-03-28
Reviewed by James Robinson.

Source/Platform:

Added WebLayerPositionConstraint for layers that need position
adjustment during threaded scrolling.
Currently it is only used for fixed-position layers.

* Platform.gypi:
* chromium/public/WebLayer.h:
(WebKit):
(WebLayer):
(WebKit::WebLayer::setPositionConstraint):
(WebKit::WebLayer::positionConstraint):
(WebKit::WebLayer::setFixedToContainerLayer):
(WebKit::WebLayer::fixedToContainerLayer):
* chromium/public/WebLayerPositionConstraint.h: Added.
(WebKit):
(WebLayerPositionConstraint):
(WebKit::WebLayerPositionConstraint::WebLayerPositionConstraint):
(WebKit::WebLayerPositionConstraint::fixedPosition):

Source/WebCore:

This patch adds support to bottom-right fixed-position elements by
introducing WebLayerPositionConstraint to WebLayer.

No new tests. Can't test until chromium patch landed.

* page/scrolling/ScrollingCoordinator.h:
(WebCore::ScrollingCoordinator::updateLayerPositionConstraint):
* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::clearPositionConstraintExceptForLayer):
(WebCore):
(WebCore::computePositionConstraint):
(WebCore::ScrollingCoordinatorChromium::updateLayerPositionConstraint):
* page/scrolling/chromium/ScrollingCoordinatorChromium.h:
(ScrollingCoordinatorChromium):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::registerScrollingLayers):
* rendering/RenderLayerBacking.h:
(WebCore::RenderLayerBacking::contentsContainmentLayer):
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] REGRESSION(r88030): Right-click on invalid form controls unexpectedly...
tkent@chromium.org [Thu, 28 Mar 2013 21:46:53 +0000 (21:46 +0000)]
[Chromium] REGRESSION(r88030): Right-click on invalid form controls unexpectedly dispatches 'invalid' events
https://bugs.webkit.org/show_bug.cgi?id=113377

Reviewed by Dimitri Glazkov.

* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::getCustomMenuFromDefaultItems):
We don't need to call HTMLFormElement::checkValidity here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Unreviewed. Test Expectations update.
jshin@chromium.org [Thu, 28 Mar 2013 21:44:35 +0000 (21:44 +0000)]
[Chromium] Unreviewed. Test Expectations update.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unnecessary 1 second sleep on windows from preprocessor.pm
jamesr@google.com [Thu, 28 Mar 2013 21:31:38 +0000 (21:31 +0000)]
Remove unnecessary 1 second sleep on windows from preprocessor.pm
https://bugs.webkit.org/show_bug.cgi?id=113536

Unreviewed, partial rollout of r146661.

This rolls out one line of 146661 that slows down the windows build significantly.

* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Enable font measurement optimization for Chromium-mac when there...
leviw@chromium.org [Thu, 28 Mar 2013 21:03:44 +0000 (21:03 +0000)]
Source/WebCore: Enable font measurement optimization for Chromium-mac when there are no font-feature-settings.

Enable measure-once optimization on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=113243

Reviewed by Eric Seidel.

Bugs in Chromium-mac's -webkit-font-feature-settings support prevented us from enabling the
optimization when it was enabled for all other platforms. This was believed to be related to
kerning, but the bug shows up when there are any font-feature-settings specified. For now,
optimizing the common case and only turning off the optimization when there are font-feature-
settings in play.

Updated test fast/text/shaping/shaping-selection-rect.html to avoid breaking due to
https://bugs.webkit.org/show_bug.cgi?id=113418

* rendering/RenderBlockLineLayout.cpp:
(WebCore::setLogicalWidthForTextRun):

LayoutTests: Disable font measurement optimization for Chromium-mac when there are font-feature-settings.

Enable measure-once optimization on Chromium-Mac
https://bugs.webkit.org/show_bug.cgi?id=113243

Reviewed by Eric Seidel.

* fast/text/shaping/shaping-selection-rect.html: Adding a small-caps case to prevent regressing
due to https://bugs.webkit.org/show_bug.cgi?id=113418.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Exclusions][CSS Regions] Block children do not layout inline content correctly...
zoltan@webkit.org [Thu, 28 Mar 2013 21:01:49 +0000 (21:01 +0000)]
[CSS Exclusions][CSS Regions] Block children do not layout inline content correctly in a region with shape-inside set
https://bugs.webkit.org/show_bug.cgi?id=112177

Reviewed by David Hyatt.

Source/WebCore:

When we had two multiple regions and a shape-inside was applied on the second region, but not on the first region and the content contained
paragraphs, the content was pushed down almost to the bottom in the second region. In a flow thread this behavior caused by the lack of the
proper updating of absoluteLogicalTop in RenderBlock::layoutRunsAndFloatsInRange function.

Tests: fast/regions/shape-inside/shape-inside-on-additional-regions.html
       fast/regions/shape-inside/shape-inside-on-regions.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutRunsAndFloatsInRange): Update the value of absoluteLogicalTop in every run when we are in a flow thread.

LayoutTests:

Add a new subdirectory for regions shape-inside tests. Move old and add new test files to the directory.

* fast/regions/shape-inside: Added.
* fast/regions/shape-inside/shape-inside-on-additional-regions-expected.html: Added.
* fast/regions/shape-inside/shape-inside-on-additional-regions.html: Added.
* fast/regions/shape-inside/shape-inside-on-regions-expected.html: Renamed from LayoutTests/fast/regions/shape-inside-on-regions-expected.html.
* fast/regions/shape-inside/shape-inside-on-regions.html: Renamed from LayoutTests/fast/regions/shape-inside-on-regions.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed rebaseline.
alokp@chromium.org [Thu, 28 Mar 2013 20:52:59 +0000 (20:52 +0000)]
Unreviewed rebaseline.
Adding missing baseline for new test compositing/contents-opaque/control-layer.html

* platform/chromium-mac/platform/chromium/virtual/softwarecompositing/contents-opaque/control-layer-expected.txt: Copied from LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt.
* platform/chromium-win/compositing/contents-opaque/control-layer-expected.txt: Renamed from LayoutTests/platform/chromium/compositing/contents-opaque/control-layer-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r191172. Requested by
commit-queue@webkit.org [Thu, 28 Mar 2013 20:38:31 +0000 (20:38 +0000)]
Unreviewed.  Rolled Chromium DEPS to r191172.  Requested by
pdr2 via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed...
timothy_horton@apple.com [Thu, 28 Mar 2013 20:24:27 +0000 (20:24 +0000)]
[wk2] REGRESSION (r125500): WebFrameLoaderClient's active m_pluginView can be zeroed by PluginDocuments leaving the page cache
https://bugs.webkit.org/show_bug.cgi?id=113430
<rdar://problem/12729564>

Reviewed by Brady Eidson.

Ignore redirectDataToPlugin(0), which is only called from PluginDocument::detach(),
and only after r125500. Otherwise, PluginDocuments that are put into the page cache
but leave later can clear a totally different and legitimate PluginView from the
WebFrameLoaderClient, causing data to be lost and PluginDocument loads to stall.

This restores our behavior to the pre-r125500 state, which should be fine, as we
clear WebFrameLoaderClient's m_pluginView when the load fails or finishes. This
matches the changes made in r125500 for every platform other than Chromium and WebKit2.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::redirectDataToPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPDFPlugin: shouldUsePDFPlugin can't use pdfLayerControllerClass() because it asserts...
timothy_horton@apple.com [Thu, 28 Mar 2013 20:21:13 +0000 (20:21 +0000)]
PDFPlugin: shouldUsePDFPlugin can't use pdfLayerControllerClass() because it asserts if it's not available
https://bugs.webkit.org/show_bug.cgi?id=113533
<rdar://problem/13528720>

Reviewed by Simon Fraser.

* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::shouldUsePDFPlugin):
Move shouldUsePDFPlugin to WebPageMac, where it belongs, and explicitly look up PDFLayerController
instead of using pdfLayerControllerClass(), which ASSERT()s if it isn't available.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSafari hangs during test262 run in CodeCache::pruneSlowCase
mhahnenberg@apple.com [Thu, 28 Mar 2013 20:21:08 +0000 (20:21 +0000)]
Safari hangs during test262 run in CodeCache::pruneSlowCase
https://bugs.webkit.org/show_bug.cgi?id=113469

Reviewed by Geoffrey Garen.

We can end up hanging for quite some time if we add a lot of small keys to the CodeCache.
By the time we get around to pruning the cache, we have a potentially tens or hundreds of
thousands of small entries, which can cause a noticeable hang when pruning them.

To fix this issue we added a hard cap to the number of entries in the cache because we
could potentially have to remove every element in the map.

* runtime/CodeCache.cpp:
(JSC::CodeCacheMap::pruneSlowCase): We need to prune until we're both under the hard cap and the
capacity in bytes.
* runtime/CodeCache.h:
(CodeCacheMap):
(JSC::CodeCacheMap::numberOfEntries): Convenience accessor function to the number of entries in
the map that does the cast to size_t of m_map.size() for us.
(JSC::CodeCacheMap::canPruneQuickly): Checks that the total number is under the hard cap. We put this
check inside a function to more accurately describe why we're doing the check and to abstract out
the actual calculation in case we want to coalesce calls to pruneSlowCase in the future.
(JSC::CodeCacheMap::prune): Check the number of entries against our hard cap. If it's greater than
the cap then we need to drop down to pruneSlowCase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoexceptions are not checked after toInt32 calls in bindings.
commit-queue@webkit.org [Thu, 28 Mar 2013 20:08:36 +0000 (20:08 +0000)]
exceptions are not checked after toInt32 calls in bindings.
https://bugs.webkit.org/show_bug.cgi?id=113218

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

In attribute setter, wrap JSValue to native value conversion in a try
catch block.

Define a new macro binding: V8TRYCATCH_VOID

No new tests: covered by fast/dom/exception-in-binding.html

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNormalAttrSetter):
* bindings/v8/V8BindingMacros.h:
(WebCore):

LayoutTests:

* platform/chromium/TestExpectations: Enable fast/dom/exception-in-binding.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening on AppleWin port.
roger_fong@apple.com [Thu, 28 Mar 2013 20:05:04 +0000 (20:05 +0000)]
Unreviewed gardening on AppleWin port.
More tests that use mouseScrollBy event which hasn't been implemented yet on Windows.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse the right OS name on Mac EWS instead of mac-future.
rniwa@webkit.org [Thu, 28 Mar 2013 20:01:06 +0000 (20:01 +0000)]
Use the right OS name on Mac EWS instead of mac-future.

Rubber-stamped by Dirk Pranke.

* Scripts/webkitpy/tool/commands/queues.py:
(PatchProcessingQueue._new_port_name_from_old):
(PatchProcessingQueue.begin_work_queue):
(PatchProcessingQueue._upload_results_archive_for_patch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPrepare extend-selection-enclosing-block test to support different editing behavior
csaavedra@igalia.com [Thu, 28 Mar 2013 19:59:22 +0000 (19:59 +0000)]
Prepare extend-selection-enclosing-block test to support different editing behavior
https://bugs.webkit.org/show_bug.cgi?id=113424

Reviewed by Ryosuke Niwa.

We make this test Mac specific and change
extendAndLogSelectionWithinBlock() to take the platform as a
parameter. When bug 110487 is fixed this should be extended to
test the Windows editing behavior.

* editing/selection/extend-selection-enclosing-block-mac-expected.txt:
Renamed from
LayoutTests/editing/selection/extend-selection-enclosing-block-expected.txt.
* editing/selection/extend-selection-enclosing-block-mac.html:
Renamed from
LayoutTests/editing/selection/extend-selection-enclosing-block.html.
* editing/selection/resources/extend-selection.js:
(extendAndLogSelectionWithinBlock): Extend to receive platform as
a parameter. Only "mac" is supported for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][AC] Use transform property of ClutterActor
commit-queue@webkit.org [Thu, 28 Mar 2013 19:59:07 +0000 (19:59 +0000)]
[GTK][AC] Use transform property of ClutterActor
https://bugs.webkit.org/show_bug.cgi?id=113317

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-03-28
Reviewed by Gustavo Noronha Silva.

ClutterActor has a transform property to set transformation matrix directly
since version 1.12. So we don't need to keep and use the matrix property of GraphicsLayerActor.

No new tests because of no functionality change.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(_GraphicsLayerActorPrivate):
(graphicsLayerActorDispose):
(graphicsLayerActorApplyTransform):
* platform/graphics/clutter/GraphicsLayerActor.h:
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::updateTransform):
* platform/graphics/clutter/PlatformClutterAnimation.cpp:
(WebCore::PlatformClutterAnimation::addTransformTransition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r143834.
commit-queue@webkit.org [Thu, 28 Mar 2013 19:57:35 +0000 (19:57 +0000)]
Unreviewed, rolling out r143834.
http://trac.webkit.org/changeset/143834
https://bugs.webkit.org/show_bug.cgi?id=113530

Multiple use-after-free regressions on ClusterFuzz (Requested
by inferno-sec on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-03-28

* dom/Attr.cpp:
(WebCore::Attr::Attr):
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
* dom/Attr.h:
(Attr):
* dom/Element.cpp:
(WebCore::Element::setAttributeInternal):
* dom/Element.h:
(Element):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse String.trim() in editing/selection/move-vertically-with-paddings-borders.html...
csaavedra@igalia.com [Thu, 28 Mar 2013 19:52:46 +0000 (19:52 +0000)]
Use String.trim() in editing/selection/move-vertically-with-paddings-borders.html test
https://bugs.webkit.org/show_bug.cgi?id=113490

Reviewed by Ryosuke Niwa.

* editing/selection/move-vertically-with-paddings-borders.html:
(selectWord): Use String.trim() to drop trailing whitespaces that
might be added depending on the editing behavior. See related bug
110487.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] Before / start paddings and borders are not accounted for when...
jchaffraix@webkit.org [Thu, 28 Mar 2013 19:24:03 +0000 (19:24 +0000)]
[CSS Grid Layout] Before / start paddings and borders are not accounted for when placing the grid items
https://bugs.webkit.org/show_bug.cgi?id=113351

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-element-border-grid-item.html
       fast/css-grid-layout/grid-element-border-padding-grid-item.html
       fast/css-grid-layout/grid-element-padding-grid-item.html

* rendering/RenderBoxModelObject.h:
(WebCore::RenderBoxModelObject::borderAndPaddingBefore):
Added this helper function (we do have borderAndPaddingStart but didn't have this
one for some reason).

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::findChildLogicalPosition):
Shifted |offset| by the paddings and borders before / start.

LayoutTests:

* fast/css-grid-layout/resources/grid.css:
(.verticalLR):
(.horizontalBT):
(.directionRTL):
Added more helper classes.

* fast/css-grid-layout/grid-element-border-grid-item-expected.txt: Added.
* fast/css-grid-layout/grid-element-border-grid-item.html: Added.
* fast/css-grid-layout/grid-element-border-padding-grid-item-expected.txt: Added.
* fast/css-grid-layout/grid-element-border-padding-grid-item.html: Added.
* fast/css-grid-layout/grid-element-padding-grid-item-expected.txt: Added.
* fast/css-grid-layout/grid-element-padding-grid-item.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Unskip some layout test folder on Windows port.
roger_fong@apple.com [Thu, 28 Mar 2013 19:08:02 +0000 (19:08 +0000)]
Unreviewed. Unskip some layout test folder on Windows port.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReduce PluginProcess lifetime.
beidson@apple.com [Thu, 28 Mar 2013 19:00:54 +0000 (19:00 +0000)]
Reduce PluginProcess lifetime.
<rdar://problem/12465479> and https://bugs.webkit.org/show_bug.cgi?id=113523

Reviewed by Sam Weinig.

Lower the minimum process lifetime from 30 minutes to 2 minutes.
Lower the "shutdown after last plugin goes away" period from 10 minutes to 1 minute.

* UIProcess/Plugins/PluginProcessProxy.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent...
zandobersek@gmail.com [Thu, 28 Mar 2013 18:58:02 +0000 (18:58 +0000)]
[GTK] Build GTK-specific, non-layer-violating source code into WebCore-independent libPlatformGtk.la
https://bugs.webkit.org/show_bug.cgi?id=112546

Reviewed by Martin Robinson.

.:

* GNUmakefile.am: Define the new platform_webcore_cppflags.

Source/Platform:

* GNUmakefile.am: Only specify the very minimal set of inclusion directories, containing the Source/WebCore/platform
directory and its subdirectories. This will allow only for the WebCore-independent GTK-specific sources to be built into
libPlatformGtk.la. Also include the GTK, libsecret and libsoup dependencies' cflags amongst the libPlatformGtk's
CPPFLAGS.
* GNUmakefile.list.am: Removed. The build targets are now listed (and will be listed until the migration) in the
GNUmakefile.list.am under Source/WebCore, following the common sense of specifying the build target in the
GNUmakefile.list.am placed in the same framework directory in which the source file is located.

Source/WebCore:

No new tests - no new functionality.

* GNUmakefile.am: Passing the DATA_DIR value through the cppflags is not required anymore as the affected source is now
built into libPlatformGtk.la.
* GNUmakefile.list.am: Build the GTK-specific source files that are already independent of WebCore into the
libPlatformGtk.la by assigning the build targets listing to the platformgtk_sources variable.
* platform/gtk/GtkVersioning.c: Renamed from Source/Platform/gtk/GtkVersioning.c.
* platform/gtk/GtkVersioning.h: Renamed from Source/Platform/gtk/GtkVersioning.h.

Source/WebKit/gtk:

* GNUmakefile.am: The GtkVersioning.c file has moved back under Source/WebCore/platform.

Source/WebKit2:

* GNUmakefile.am: Reference the platform_webcore_cppflags and GTK, libsecret and libsoup dependencies' cflags amongst the
libPlatformGtk2's CPPFLAGS.
* Scripts/generate-forwarding-headers.pl: Remove the Platform framework from the list of the frameworks to be searched
for forwarding headers, it's at the moment not necessary to be included.
* Shared/gtk/ArgumentCodersGtk.cpp: Adjust the forwarding header for GtkVersioning.h that's been moved back under the
WebCore framework.
* Shared/gtk/WebEventFactory.cpp: Ditto.
* UIProcess/API/gtk/WebKitWebViewBase.cpp: Ditto.
* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp: Ditto.

Tools:

* GNUmakefile.am: Reference the platformgtk_cppflags amongst the libWebCoreInternals' CPPFLAGS. GtkVersioning.c file has
moved back to Source/WebCore/platform. Fix an indentation issue as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Don't use WebKit thread scale information in WebPageCompositor.
commit-queue@webkit.org [Thu, 28 Mar 2013 18:44:08 +0000 (18:44 +0000)]
[BlackBerry] Don't use WebKit thread scale information in WebPageCompositor.
https://bugs.webkit.org/show_bug.cgi?id=113447
Internal PR 313452

Patch by Jakob Petsovits <jpetsovits@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Potential threading problems are avoided by moving from
WebPage members and mapToTransformed() to the web page
client's userInterfaceViewportAccessor().

As part of this cleaning effort, the WebPageCompositor's
render() method is changed to now take document instead of
pixel coordinates.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::render):
(BlackBerry::WebKit::WebPageCompositor::render):
* Api/WebPageCompositor.h:
* Api/WebPageCompositor_p.h:
(WebPageCompositorPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRefactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormCo...
falken@chromium.org [Thu, 28 Mar 2013 18:38:38 +0000 (18:38 +0000)]
Refactoring: Replace Element::disabled and isEnabledFormControl with isDisabledFormControl
https://bugs.webkit.org/show_bug.cgi?id=113273

Reviewed by Kent Tamura.

Element::disabled is about form controls and Element::isEnabledFormControl
is redundant with it, so replace them with a single function
Element::isDisabledFormControl.

Source/WebCore:

No new tests, there should be no behavior change.

* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::canSetSelectedChildrenAttribute):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::canSetSelectedAttribute):
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::canSetFocusAttribute):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::isEnabled):
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::isEnabled):
(WebCore::AccessibilityNodeObject::actionElement):
(WebCore::AccessibilityNodeObject::canSetFocusAttribute):
* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithControl):
* dom/Element.cpp:
(WebCore::Element::isDisabledFormControl):
* dom/Element.h:
(Element):
(WebCore::isDisabledFormControl): Add helper function for convenience.
(WebCore):
* dom/EventDispatcher.cpp:
(WebCore::EventDispatcher::dispatchSimulatedClick):
* dom/GestureEvent.cpp:
(WebCore::GestureEventDispatchMediator::dispatchEvent):
* dom/MouseEvent.cpp:
(WebCore::MouseEventDispatchMediator::dispatchEvent):
* dom/Node.cpp:
(WebCore::Node::handleLocalEvents):
(WebCore::Node::willRespondToMouseMoveEvents):
(WebCore::Node::willRespondToMouseClickEvents):
(WebCore::Node::willRespondToTouchEvents):
* html/BaseMultipleFieldsDateAndTimeInputType.cpp:
(WebCore::BaseMultipleFieldsDateAndTimeInputType::isEditControlOwnerDisabled):
* html/DOMFormData.cpp:
(WebCore::DOMFormData::DOMFormData):
* html/FileInputType.cpp:
(WebCore::FileInputType::handleDOMActivateEvent):
(WebCore::FileInputType::disabledAttributeChanged):
* html/HTMLButtonElement.cpp:
(WebCore::HTMLButtonElement::defaultEventHandler):
(WebCore::HTMLButtonElement::willRespondToMouseClickEvents):
(WebCore::HTMLButtonElement::isSuccessfulSubmitButton):
* html/HTMLCollection.cpp:
(WebCore::isMatchingElement):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::updateAncestorDisabledState):
(WebCore::HTMLFormControlElement::isDisabledFormControl):
(WebCore::HTMLFormControlElement::supportsFocus):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
(WebCore::HTMLFormControlElement::isDisabledOrReadOnly):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::isSuccessfulSubmitButton):
(WebCore::HTMLInputElement::willRespondToMouseClickEvents):
* html/HTMLOptGroupElement.cpp:
(WebCore::HTMLOptGroupElement::isDisabledFormControl):
* html/HTMLOptGroupElement.h:
(HTMLOptGroupElement):
* html/HTMLOptionElement.cpp:
(WebCore::HTMLOptionElement::isDisabledFormControl):
* html/HTMLOptionElement.h:
(HTMLOptionElement):
* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::willRespondToMouseClickEvents):
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::nextValidIndex):
(WebCore::HTMLSelectElement::updateListBoxSelection):
(WebCore::HTMLSelectElement::recalcListItems):
(WebCore::HTMLSelectElement::appendFormData):
(WebCore::HTMLSelectElement::updateSelectedState):
(WebCore::HTMLSelectElement::listBoxDefaultEventHandler):
(WebCore::HTMLSelectElement::defaultEventHandler):
(WebCore::HTMLSelectElement::optionAtIndex):
* html/ImageInputType.cpp:
(WebCore::ImageInputType::handleDOMActivateEvent):
* html/ResetInputType.cpp:
(WebCore::ResetInputType::handleDOMActivateEvent):
* html/SubmitInputType.cpp:
(WebCore::SubmitInputType::handleDOMActivateEvent):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::isDisabledFormControl):
(WebCore::SliderThumbElement::defaultEventHandler):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
* html/shadow/SliderThumbElement.h:
(SliderThumbElement):
* html/shadow/SpinButtonElement.h:
* html/shadow/TextFieldDecorationElement.cpp:
(WebCore::TextFieldDecorationElement::updateImage):
* loader/FormSubmission.cpp:
(WebCore::FormSubmission::create):
* page/DragController.cpp:
(WebCore::DragController::tryDocumentDrag):
(WebCore::DragController::concludeEditDrag):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::addFocusRingRects):
(WebCore::RenderListBox::paintItemForeground):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::itemIsEnabled):
* rendering/RenderTextControl.cpp:
(WebCore::updateUserModifyProperty):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isEnabled):
* rendering/RenderThemeMac.mm:
(WebCore::getMediaUIPartStateFlags):
* rendering/RenderThemeMacShared.mm:
(WebCore::RenderThemeMacShared::adjustMenuListStyle):
(WebCore::RenderThemeMacShared::paintSearchFieldCancelButton):
* rendering/RenderThemeSafari.cpp:
(WebCore::RenderThemeSafari::adjustMenuListStyle):

Source/WebKit/blackberry:

* WebCoreSupport/CredentialTransformData.cpp:
(WebCore::CredentialTransformData::findPasswordFormFields):
* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::openSelectPopup):

Source/WebKit/chromium:

* src/WebFormControlElement.cpp:
(WebKit::WebFormControlElement::isEnabled):
* src/WebOptionElement.cpp:
(WebKit::WebOptionElement::isEnabled):
* src/WebPasswordFormUtils.cpp:
(WebKit::findPasswordFormFields):
* src/WebSearchableFormData.cpp:
(HTMLNames::findSuitableSearchInputElement):
(HTMLNames::buildSearchString):

Source/WebKit/win:

* DOMHTMLClasses.cpp:
(DOMHTMLInputElement::disabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove workaround for <rdar://problem/5321972>.
beidson@apple.com [Thu, 28 Mar 2013 18:24:55 +0000 (18:24 +0000)]
Remove workaround for <rdar://problem/5321972>.
<rdar://problem/12022862> and https://bugs.webkit.org/show_bug.cgi?id=113516

Reviewed by Sam Weinig.

No new tests (No point in testing the removal of bizarre behavior).

* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary): This workaround isn't needed on Lion+

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agouse CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
commit-queue@webkit.org [Thu, 28 Mar 2013 18:13:10 +0000 (18:13 +0000)]
use CanvasWindingRule enumeration in CanvasRenderingContext2D.idl
https://bugs.webkit.org/show_bug.cgi?id=113456

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-03-28
Reviewed by Kentaro Hara.

Source/WebCore:

Use enum CanvasWindingRule type instead of DOMString for winding
arguments when needed. Changed methods are: fill, stroke and isPointInPath.

Test: fast/canvas/winding-enumeration.html

* html/canvas/CanvasRenderingContext2D.idl:

LayoutTests:

When calling methods accepting a CanvasWindingRule with an invalid
string, check that a TypeError is thrown.

* fast/canvas/winding-enumeration-expected.txt: Added.
* fast/canvas/winding-enumeration.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRebaseline font-face-woff after r147020
allan.jensen@digia.com [Thu, 28 Mar 2013 17:47:16 +0000 (17:47 +0000)]
Rebaseline font-face-woff after r147020

Unreviewed gardening.

Updated using garden-o-matic.

* fast/css/font-face-woff-expected.txt: Renamed from LayoutTests/platform/chromium/fast/css/font-face-woff-expected.txt.
* platform/mac/fast/css/font-face-woff-expected.txt: Removed.
* platform/qt/fast/css/font-face-woff-expected.png: Added.
* platform/qt/fast/css/font-face-woff-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGardening: bypassing inspector/styles/paste-property.html, compositing/iframes/remove...
mark.lam@apple.com [Thu, 28 Mar 2013 17:40:46 +0000 (17:40 +0000)]
Gardening: bypassing inspector/styles/paste-property.html, compositing/iframes/remove-iframe-crash.html.

Not Reviewed.

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove preprocessing of idl to pre-pass for gyp
commit-queue@webkit.org [Thu, 28 Mar 2013 17:27:01 +0000 (17:27 +0000)]
Move preprocessing of idl to pre-pass for gyp
https://bugs.webkit.org/show_bug.cgi?id=113448

Patch by Scott Graham <scottmg@chromium.org> on 2013-03-28
Reviewed by Tony Chang.

Moves the preprocessor invocations when parsing IDL files to a
pre-pass to avoid reinvocations when IDLs are referenced from others.
This reduces the number of invocations of the preprocessor from 20071
to 633, which reduces the runtime from 12m30 to 1m (on a Windows box).

No new tests, this is a build time improvement, and shouldn't have any
visible effect.

* WebCore.gyp/WebCore.gyp:
* bindings/scripts/CodeGenerator.pm:
(ParseInterface):
* bindings/scripts/IDLParser.pm:
(Parse):
* bindings/scripts/generate-bindings.pl:
* bindings/scripts/generate-preprocessed-idls.pl: Added.
* bindings/scripts/preprocessor.pm:
(applyPreprocessor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardneing. Updated png expected results after r146206.
kadam@inf.u-szeged.hu [Thu, 28 Mar 2013 17:25:27 +0000 (17:25 +0000)]
[Qt] Unreviewed gardneing. Updated png expected results after r146206.

* platform/qt-5.0-wk2/editing/deleting/5126166-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/5206311-1-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/5369009-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/5433862-2-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-3608445-fix-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-at-paragraph-boundaries-002-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-block-contents-003-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-005-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-006-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-007-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-block-merge-contents-008-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-br-002-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-br-003-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-br-004-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-br-006-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-hr-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-image-002-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/delete-listitem-001-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/merge-different-styles-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/pruning-after-merge-2-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/smart-delete-003-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/smart-delete-004-expected.png: Added.
* platform/qt-5.0-wk2/editing/deleting/type-delete-after-quote-expected.png: Added.
* platform/qt-5.0-wk2/editing/execCommand/4580583-1-expected.png: Added.
* platform/qt-5.0-wk2/editing/execCommand/4924441-expected.png: Added.
* platform/qt-5.0-wk2/editing/execCommand/indent-empty-root-expected.png: Added.
* platform/qt-5.0-wk2/editing/execCommand/insertHorizontalRule-expected.png: Added.
* platform/qt-5.0-wk2/editing/execCommand/insertImage-expected.png: Added.
* platform/qt-5.0-wk2/editing/execCommand/nsresponder-indent-expected.png: Added.
* platform/qt-5.0-wk2/editing/execCommand/nsresponder-outdent-expected.png: Added.
* platform/qt-5.0-wk2/editing/execCommand/remove-list-item-1-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/4875189-1-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/4875189-2-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/4959067-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/5418891-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/insert-3778059-fix-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/insert-3800346-fix-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/insert-div-025-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/insert-paragraph-02-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/paragraph-separator-03-expected.png: Added.
* platform/qt-5.0-wk2/editing/inserting/redo-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/4076267-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/4242293-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/4641033-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/4944770-1-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/4944770-2-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/5032095-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/5134759-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/merge-end-borders-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/merge-start-list-expected.png: Added.
* platform/qt-5.0-wk2/editing/pasteboard/styled-element-markup-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/13804-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/4866671-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/5076323-1-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/5099303-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/5195166-2-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/expanding-selections-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/expanding-selections2-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/extend-by-character-003-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/extend-by-character-005-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/extend-by-sentence-001-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/inline-table-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/mixed-editability-4-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/mixed-editability-5-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/mixed-editability-9-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/move-by-character-003-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/move-by-character-005-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/replace-selection-1-expected.png: Added.
* platform/qt-5.0-wk2/editing/selection/table-caret-3-expected.png: Added.
* platform/qt-5.0-wk2/editing/style/4916887-expected.png: Added.
* platform/qt-5.0-wk2/editing/style/5084241-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix layout test for blending in the background
commit-queue@webkit.org [Thu, 28 Mar 2013 17:14:40 +0000 (17:14 +0000)]
Fix layout test for blending in the background
https://bugs.webkit.org/show_bug.cgi?id=113402

Patch by Mirela Budaes <mbudaes@adobe.com> on 2013-03-28
Reviewed by Dirk Schulze.

Fixed the layout test effect-background-blend-mode.html typo
Also rebaselined the test

* css3/compositing/effect-background-blend-mode.html:
* platform/mac/css3/compositing/effect-background-blend-mode-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
alokp@chromium.org [Thu, 28 Mar 2013 17:03:11 +0000 (17:03 +0000)]
RenderBox::backgroundIsKnownToBeOpaqueInRect may be wrong for theme-painted elements
https://bugs.webkit.org/show_bug.cgi?id=113419

Reviewed by Simon Fraser.

Source/WebCore:

Do not consider control elements as opaque. They are typically theme painted, and we cannot assume opaqueness on the behalf of theme. It can be improved by asking the theme if it paints opaque.

Test: compositing/contents-opaque/control-layer.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::backgroundIsKnownToBeOpaqueInRect):

LayoutTests:

* compositing/contents-opaque/control-layer-expected.txt: Added.
* compositing/contents-opaque/control-layer.html: Added.
* platform/chromium/compositing/contents-opaque/control-layer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening. Adding failure expectation for a reftest added in r147111
zandobersek@gmail.com [Thu, 28 Mar 2013 16:46:19 +0000 (16:46 +0000)]
Unreviewed GTK gardening. Adding failure expectation for a reftest added in r147111
that's failing due to subpixel layout being disabled on the GTK port.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] [gyp] Improve support for rerunning gyp automatically
mrobinson@webkit.org [Thu, 28 Mar 2013 16:38:54 +0000 (16:38 +0000)]
[GTK] [gyp] Improve support for rerunning gyp automatically
https://bugs.webkit.org/show_bug.cgi?id=113360

Reviewed by Gustavo Noronha Silva.

Add support for automatically rerunning gyp when input file changes are detected
while running make.

* gyp/GNUmakefile: Added. A wrapper that invokes the generated makefile.
* gyp/autogen.sh: Add a symlink to the wrapper script.
* gyp/configure.ac: "Freeze" the TOPLEVEL_DIRECTORY command-line argument so that
run-gyp reads it properly when configure is run independently of autogen.sh.
* gyp/run-gyp: Prevent generation of auto-regeneration rules in gyp. They are buggy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Committer Email Updates
commit-queue@webkit.org [Thu, 28 Mar 2013 16:32:58 +0000 (16:32 +0000)]
[BlackBerry] Committer Email Updates
https://bugs.webkit.org/show_bug.cgi?id=113435

Patch by Ming Xie <mxie@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Add the @blackberry.com email address for all our BlackBerry
WebKit committers. This is the first step for our email address
migration.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLayout Test inspector/console/console-css-warnings.html is failing on debug.
commit-queue@webkit.org [Thu, 28 Mar 2013 16:31:08 +0000 (16:31 +0000)]
Layout Test inspector/console/console-css-warnings.html is failing on debug.
https://bugs.webkit.org/show_bug.cgi?id=113483

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.

This test is temporatily disabled in TestExpectations. platform/chromium/TestExpectations override this expectation for chromium/debug.
It removed for now.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
philn@webkit.org [Thu, 28 Mar 2013 16:05:12 +0000 (16:05 +0000)]
[jhbuild] GStreamer system plugins conflict with the ones built in jhbuild
https://bugs.webkit.org/show_bug.cgi?id=113508

Reviewed by Martin Robinson.

Prevent the GStreamer plugin scanner to load system-wide
plugins. Only the ones built in JHBuild should be loaded and used
at runtime.

* efl/jhbuildrc:
* gtk/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][AC] Animating layer disappears while running with clutter backend
commit-queue@webkit.org [Thu, 28 Mar 2013 16:00:06 +0000 (16:00 +0000)]
[GTK][AC] Animating layer disappears while running with clutter backend
https://bugs.webkit.org/show_bug.cgi?id=110470

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-03-28
Reviewed by Gustavo Noronha Silva.

The reason of this issue is that clutter_actor_remove_child leads to stopping animations
of child actor. ClutterActor's animation could be defined only when it has a parent actor.
So we should avoid the case calling the api as much as we can. At least we don't
need to reset a actor's parent at all if the current parent is same with new one.
If we can't avoid invoking clutter_actor_remove_child for an animating actor, we may apply
a more complicated way to keep the animation. But I haven't faced such a case yet.

Covered by existing animation tests.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorSetSublayers):
* platform/graphics/clutter/GraphicsLayerClutter.cpp:
(WebCore::GraphicsLayerClutter::recursiveCommitChanges):
(WebCore::GraphicsLayerClutter::updateSublayerList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoNon-painting fixed elements should not cause repaints on scroll
wangxianzhu@chromium.org [Thu, 28 Mar 2013 15:48:28 +0000 (15:48 +0000)]
Non-painting fixed elements should not cause repaints on scroll
https://bugs.webkit.org/show_bug.cgi?id=110430

Reviewed by Simon Fraser.

Source/WebCore:

Test: compositing/repaint/scroll-fixed-layer-no-content.html
Test: compositing/repaint/scroll-fixed-layer-out-of-view.html

* page/FrameView.cpp:
(WebCore::FrameView::scrollContentsFastPath): Check for no-content and out-of-view flag set by RLC.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresCompositingForPosition): Moved the check for no-content above out-of-view because it's faster.

LayoutTests:

* compositing/repaint/scroll-fixed-layer-no-content.html: Added.
* compositing/repaint/scroll-fixed-layer-no-content-expected.txt: Added.
* compositing/repaint/scroll-fixed-layer-out-of-view.html: Added.
* compositing/repaint/scroll-fixed-layer-out-of-view-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening.
ch.dumez@sisa.samsung.com [Thu, 28 Mar 2013 15:46:52 +0000 (15:46 +0000)]
Unreviewed gardening.

Fix bad rebaseline in r147115.

* fast/forms/validationMessage-expected.txt:
* platform/efl/fast/forms/validationMessage-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, revert accidentally added line committed in r147117.
apavlov@chromium.org [Thu, 28 Mar 2013 15:35:04 +0000 (15:35 +0000)]
Unreviewed, revert accidentally added line committed in r147117.

* inspector/front-end/ElementsTreeOutline.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Elements] Syntax-highlight the "Edit as HTML" editor
apavlov@chromium.org [Thu, 28 Mar 2013 15:15:07 +0000 (15:15 +0000)]
Web Inspector: [Elements] Syntax-highlight the "Edit as HTML" editor
https://bugs.webkit.org/show_bug.cgi?id=113306

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Use CodeMirror as the raw HTML editor for the "Edit as HTML" menu item
(and all multiline editors for WebInspector.startEditing()).
Drive-by fix for handling the editing when the editor has been invoked on the closing tag.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype.commit):
(WebInspector.ElementsTreeElement.prototype._startEditingAsHTML):
* inspector/front-end/UIUtils.js:
(WebInspector.EditingConfig.prototype.setMultiline):
(WebInspector.startEditing):
(WebInspector.CodeMirrorCSSLoadView): A bogus view to load-unload CodeMirror-related CSS on demand.
* inspector/front-end/elementsPanel.css:
(#elements-content .CodeMirror):
(#elements-content .CodeMirror pre):
(#elements-content .CodeMirror-lines):
* inspector/front-end/elementsPanel.css: CodeMirror styles for the "Edit as HTML" editor.
* inspector/front-end/externs.js: Declare CodeMirror type with some members, as it is third-party code.
* inspector/front-end/inspector.html: Fix script order (UIUtils.js requires View.js).

LayoutTests:

* inspector/elements/edit-dom-actions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Thu, 28 Mar 2013 14:53:50 +0000 (14:53 +0000)]
Unreviewed EFL gardening.

Mark several tests as failing due to missing WKTR / DRT functionality.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Thu, 28 Mar 2013 14:44:34 +0000 (14:44 +0000)]
Unreviewed EFL gardening.

Rebaseline fast/forms/validationMessage.html after r145024.

* fast/forms/validationMessage-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening of test failures after r147086 and r147090.
zandobersek@gmail.com [Thu, 28 Mar 2013 14:41:53 +0000 (14:41 +0000)]
Unreviewed gardening of test failures after r147086 and r147090.

* platform/gtk-wk1/TestExpectations:
* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCustom Elements: should support non-HTML namespaces.
morrita@google.com [Thu, 28 Mar 2013 14:34:21 +0000 (14:34 +0000)]
Custom Elements: should support non-HTML namespaces.
https://bugs.webkit.org/show_bug.cgi?id=111693

Reviewed by Dimitri Glazkov.

Source/WebCore:

Some existing code assumes that the element extends HTMLElements.
This change allow it to extend from Element. Note that the
namespace URI of a custom element is determined by given element
prototype: An element will have XHTML namespace if its prototype
chain includes HTMLElements, SVGElement leads SVG namespace and
null otherwise, respectively.

Test: fast/dom/custom/document-register-namespace.html

* bindings/v8/CustomElementHelpers.cpp:
(WebCore::hasValidPrototypeChainFor): Factored out from isValidPrototypeParameter()
(WebCore::CustomElementHelpers::isValidPrototypeParameter): Extend to support non HTMLElement prototype
(WebCore::CustomElementHelpers::findLocalName): Support non-HTML element names.
* bindings/v8/CustomElementHelpers.h:
(CustomElementHelpers):
* dom/CustomElementConstructor.cpp:
(WebCore::CustomElementConstructor::createElementInternal):
* dom/CustomElementRegistry.cpp:
(WebCore::CustomElementRegistry::registerElement): No longer hard-codes namespace and picks one based on the prototype value.
* dom/CustomElementRegistry.h:
(CustomElementRegistry):

LayoutTests:

* fast/dom/custom/document-register-namespace-expected.txt: Added.
* fast/dom/custom/document-register-namespace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Thu, 28 Mar 2013 14:28:32 +0000 (14:28 +0000)]
Unreviewed EFL gardening.

Add platform specific expectation for http/tests/inspector/console-resource-errors.html.
We get the same result as mac port.

* platform/efl/http/tests/inspector/console-resource-errors-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Exclusions] Add support for the simple case of padding a polygonal shape-inside
hmuller@adobe.com [Thu, 28 Mar 2013 14:20:13 +0000 (14:20 +0000)]
[CSS Exclusions] Add support for the simple case of padding a polygonal shape-inside
https://bugs.webkit.org/show_bug.cgi?id=112592

Reviewed by Dirk Schulze.

Source/WebCore:

First pass at computing the padded or inset boundary of a polygon.  This version does not handle
self-intersecting polygons, or values of shape-padding large enough to change the shape of the
original polygon. The implementation computes an offset edge for each polgon edge, where the offset
edge is parallel to the original edge and separated by shape-padding. The padded polygon's vertices
are the intersections of each pair of adjacent offset edges. When adjacent offset edges do not intersect,
because they share a reflex vertex in the original polygon, an approximation to a circular arc
connects the offset edges.

Tests: fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html
       fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html
       fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html

* rendering/ExclusionPolygon.cpp:
(WebCore::isReflexVertex): Just moved this function earlier in the file.
(WebCore::inwardEdgeNormal): Unit vector that's perpindicular to the edge and that points inwards.
(WebCore::outwardEdgeNormal): Unit vector that's perpindicular to the edge and that points outwards.
(WebCore::appendArc): Append a linear approximation to a circular arc to a vector of vertices.
(WebCore::computeShapePaddingBounds): Return a polygon whose edges are all inset by shape-padding from m_polygon.
(WebCore::computeShapeMarginBounds): Just a stub, see bug 112917.
(WebCore::ExclusionPolygon::shapePaddingBounds): Lazily use computeShapePaddingBounds() to initialize m_paddingBounds.
(WebCore::ExclusionPolygon::shapeMarginBounds): Lazily use computeShapeMarginBounds() to initialize m_marginBounds.
(WebCore::ExclusionPolygon::getIncludedIntervals): Now based on the value of shapePaddingBounds().
(WebCore::ExclusionPolygon::firstIncludedIntervalLogicalTop): Now based on the value of shapePaddingBounds().
* rendering/ExclusionPolygon.h:
(WebCore::ExclusionPolygon::ExclusionPolygon):

LayoutTests:

Verify that the CSS shape-padding property works correctly for some simple polygonal shapes:
a rectangle, a rectangle rotated 45 degress, and rectangular shape with a single reflex vertex.

* fast/exclusions/shape-inside/shape-inside-polygon-padding-001-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-polygon-padding-001.html: Added.
* fast/exclusions/shape-inside/shape-inside-polygon-padding-002-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-polygon-padding-002.html: Added.
* fast/exclusions/shape-inside/shape-inside-polygon-padding-003-expected.html: Added.
* fast/exclusions/shape-inside/shape-inside-polygon-padding-003.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Handle EXIF orientation for ImageDocuments
commit-queue@webkit.org [Thu, 28 Mar 2013 14:04:13 +0000 (14:04 +0000)]
[BlackBerry] Handle EXIF orientation for ImageDocuments
https://bugs.webkit.org/show_bug.cgi?id=113423

Internal Bug: PR 293648
Informally Reviewed by Jeff Rogers
Patch by Chris Hutten-Czapski <chutten@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

Support image orientation in our image draw calls, and advertise
the capability to the calling code. This allows us to respect EXIF
orientation data.

* platform/graphics/BitmapImage.h:
* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::BitmapImage::draw):
(WebCore):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::shouldRespectImageOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: name timeline overview controls consistently
caseq@chromium.org [Thu, 28 Mar 2013 13:46:13 +0000 (13:46 +0000)]
Web Inspector: name timeline overview controls consistently
https://bugs.webkit.org/show_bug.cgi?id=113503

Reviewed by Yury Semikhatsky.

Refactoring, covered by existing tests.

- rename HeapGraph to TimelineMemoryOverview;
- rename TimelineCategoryStrips to TimelineEventOvrview.

* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineOverviewPane):
(WebInspector.TimelineOverviewPane.prototype.setMode):
(WebInspector.TimelineOverviewPane.prototype._setFrameMode):
(WebInspector.TimelineOverviewPane.prototype._onCategoryVisibilityChanged):
(WebInspector.TimelineOverviewPane.prototype._update):
(WebInspector.TimelineOverviewPane.prototype.setMinimumRecordDuration):
(WebInspector.TimelineMemoryOverview):
(WebInspector.TimelineEventOverview):
(WebInspector.TimelineEventOverview.prototype._renderBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] run-launcher --gtk -2 fails on a WK2-only build
philn@webkit.org [Thu, 28 Mar 2013 13:43:45 +0000 (13:43 +0000)]
[GTK] run-launcher --gtk -2 fails on a WK2-only build
https://bugs.webkit.org/show_bug.cgi?id=113386

Reviewed by Carlos Garcia Campos.

* Scripts/webkitdirs.pm:
(builtDylibPathForName): The WebKit2GTK .so name change from 1.0
version to 3.0. Reflect this change so the builtDylibPathForName
function doesn't fail to report the library as found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Correct glyph contour winding direction when fake-bolding
commit-queue@webkit.org [Thu, 28 Mar 2013 13:39:16 +0000 (13:39 +0000)]
[BlackBerry] Correct glyph contour winding direction when fake-bolding
https://bugs.webkit.org/show_bug.cgi?id=113411

Patch by Eli Fidler <efidler@blackberry.com> on 2013-03-28
Reviewed by Rob Buis.

* platform/graphics/blackberry/FontPlatformDataBlackBerry.cpp:
(WebCore::FontPlatformData::applyState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Make JavaScriptSourceFrame work correctly with breakpoints when uiSour...
vsevik@chromium.org [Thu, 28 Mar 2013 13:35:07 +0000 (13:35 +0000)]
Web Inspector: Make JavaScriptSourceFrame work correctly with breakpoints when uiSourceCode does not have a scriptFile.
https://bugs.webkit.org/show_bug.cgi?id=113500

Reviewed by Pavel Feldman.

JavaScriptSourceFrame now listens for uiSourceCode working copy related events and supports muting breakpoints without script file.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._workingCopyChanged):
(WebInspector.JavaScriptSourceFrame.prototype._workingCopyCommitted):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: factor out node search controller from inspector.js
caseq@chromium.org [Thu, 28 Mar 2013 13:25:50 +0000 (13:25 +0000)]
Web Inspector: factor out node search controller from inspector.js
https://bugs.webkit.org/show_bug.cgi?id=112689

Reviewed by Pavel Feldman.

This just extracts the existing logic of toggling node search
from inspector.js into a class of its own, InspectElementModeController.
Drive-by: add CtrlOrMeta+Shift+C to help screen.
* English.lproj/localizedStrings.js:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* inspector/compile-front-end.py:
* inspector/front-end/InspectElementModeController.js: Added.
(WebInspector.InspectElementModeController):
(WebInspector.InspectElementModeController.createShortcut):
(WebInspector.InspectElementModeController.prototype.enabled):
(WebInspector.InspectElementModeController.prototype.disable):
(WebInspector.InspectElementModeController.prototype.toggleSearch.callback):
(WebInspector.InspectElementModeController.prototype.toggleSearch):
(WebInspector.InspectElementModeController.prototype.handleShortcut):
* inspector/front-end/InspectorFrontendAPI.js:
(InspectorFrontendAPI.enterInspectElementMode):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector._registerShortcuts):
(WebInspector.documentKeyDown):
(WebInspector._updateFocusedNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota.
eustas@chromium.org [Thu, 28 Mar 2013 13:09:12 +0000 (13:09 +0000)]
Web Inspector: [Settings] "previouslyViewedFiles" exceeds local storage quota.
https://bugs.webkit.org/show_bug.cgi?id=113375

Reviewed by Pavel Feldman.

Serialized "previouslyViewedFiles" may make local storage overflow.
Two fixed applied:
- limit number of history log items
- limit length of URIs that get serialized;
  this would affect only data-url URIs.

* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
Added length check.
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
Added output array length limit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Heap snapshots retained size falls out of the grid if column is too...
commit-queue@webkit.org [Thu, 28 Mar 2013 13:07:43 +0000 (13:07 +0000)]
Web Inspector: Heap snapshots retained size falls out of the grid if column is too narrow
https://bugs.webkit.org/show_bug.cgi?id=113497

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-28
Reviewed by Pavel Feldman.

* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype._createValueCell):
* inspector/front-end/heapProfiler.css:
(.heap-snapshot-view .data-grid div.heap-snapshot-multiple-values):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: ResourceScriptFile should check if resource content really matches...
vsevik@chromium.org [Thu, 28 Mar 2013 13:06:25 +0000 (13:06 +0000)]
Web Inspector: ResourceScriptFile should check if resource content really matches VM script when determining hasDiverged state.
https://bugs.webkit.org/show_bug.cgi?id=113488

Reviewed by Pavel Feldman.

Source/WebCore:

Enabled support for checking that file content matches VM script in ResourceScriptFile (For script resources only).
This check is never done before content is loaded in corresponding editor to avoid regressing performance.
File - script content matching is done bearing in mind sourceURLs.
Live edit keeps sourceURL in script content now even if it is not present in file's content.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):
* inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditScriptFile.prototype.checkMapping):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._bindUISourceCodeToScripts):
(WebInspector.ScriptFile.prototype.checkMapping):
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._isDiverged):
(WebInspector.ResourceScriptFile.prototype._sourceMatchesScriptSource):
(WebInspector.ResourceScriptFile.prototype._sourceEndsWithSourceURL):
(WebInspector.ResourceScriptFile.prototype.checkMapping.callback):
(WebInspector.ResourceScriptFile.prototype.checkMapping):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.SnippetScriptFile.prototype.checkMapping):

LayoutTests:

* http/tests/inspector/debugger-test.js:
* inspector/debugger/file-system-project-mapping-expected.txt:
* inspector/debugger/file-system-project-mapping.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Updated png expected results after r146206.
kadam@inf.u-szeged.hu [Thu, 28 Mar 2013 13:04:52 +0000 (13:04 +0000)]
[Qt] Unreviewed gardening. Updated png expected results after r146206.

* platform/qt/editing/deleting/5126166-expected.png:
* platform/qt/editing/deleting/5206311-1-expected.png:
* platform/qt/editing/deleting/5272440-expected.png:
* platform/qt/editing/deleting/5369009-expected.png:
* platform/qt/editing/deleting/5433862-2-expected.png:
* platform/qt/editing/deleting/delete-3608445-fix-expected.png:
* platform/qt/editing/deleting/delete-at-paragraph-boundaries-002-expected.png:
* platform/qt/editing/deleting/delete-block-contents-003-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-005-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-006-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-007-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-008-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-018-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-020-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-021-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-022-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-023-expected.png:
* platform/qt/editing/deleting/delete-block-merge-contents-024-expected.png:
* platform/qt/editing/deleting/delete-br-002-expected.png:
* platform/qt/editing/deleting/delete-br-003-expected.png:
* platform/qt/editing/deleting/delete-br-004-expected.png:
* platform/qt/editing/deleting/delete-br-005-expected.png:
* platform/qt/editing/deleting/delete-br-006-expected.png:
* platform/qt/editing/deleting/delete-hr-expected.png:
* platform/qt/editing/deleting/delete-image-002-expected.png:
* platform/qt/editing/deleting/delete-line-003-expected.png:
* platform/qt/editing/deleting/delete-line-004-expected.png:
* platform/qt/editing/deleting/delete-line-end-ws-001-expected.png:
* platform/qt/editing/deleting/delete-line-end-ws-002-expected.png:
* platform/qt/editing/deleting/delete-listitem-001-expected.png:
* platform/qt/editing/deleting/forward-delete-expected.png:
* platform/qt/editing/deleting/merge-different-styles-expected.png:
* platform/qt/editing/deleting/pruning-after-merge-2-expected.png:
* platform/qt/editing/deleting/smart-delete-003-expected.png:
* platform/qt/editing/deleting/smart-delete-004-expected.png:
* platform/qt/editing/deleting/type-delete-after-quote-expected.png:
* platform/qt/editing/execCommand/4580583-1-expected.png:
* platform/qt/editing/execCommand/4924441-expected.png:
* platform/qt/editing/execCommand/5482023-expected.png:
* platform/qt/editing/execCommand/findString-2-expected.png:
* platform/qt/editing/execCommand/indent-empty-root-expected.png:
* platform/qt/editing/execCommand/insertHorizontalRule-expected.png:
* platform/qt/editing/execCommand/insertImage-expected.png:
* platform/qt/editing/execCommand/nsresponder-indent-expected.png:
* platform/qt/editing/execCommand/nsresponder-outdent-expected.png:
* platform/qt/editing/execCommand/paste-1-expected.png:
* platform/qt/editing/execCommand/paste-2-expected.png:
* platform/qt/editing/execCommand/remove-list-item-1-expected.png:
* platform/qt/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/qt/editing/inserting/4875189-1-expected.png:
* platform/qt/editing/inserting/4875189-2-expected.png:
* platform/qt/editing/inserting/4959067-expected.png:
* platform/qt/editing/inserting/5418891-expected.png:
* platform/qt/editing/inserting/before-after-input-element-expected.png:
* platform/qt/editing/inserting/editable-html-element-expected.png:
* platform/qt/editing/inserting/edited-whitespace-1-expected.png:
* platform/qt/editing/inserting/insert-3654864-fix-expected.png:
* platform/qt/editing/inserting/insert-3778059-fix-expected.png:
* platform/qt/editing/inserting/insert-3800346-fix-expected.png:
* platform/qt/editing/inserting/insert-3851164-fix-expected.png:
* platform/qt/editing/inserting/insert-div-011-expected.png:
* platform/qt/editing/inserting/insert-div-012-expected.png:
* platform/qt/editing/inserting/insert-div-013-expected.png:
* platform/qt/editing/inserting/insert-div-014-expected.png:
* platform/qt/editing/inserting/insert-div-015-expected.png:
* platform/qt/editing/inserting/insert-div-016-expected.png:
* platform/qt/editing/inserting/insert-div-017-expected.png:
* platform/qt/editing/inserting/insert-div-018-expected.png:
* platform/qt/editing/inserting/insert-div-019-expected.png:
* platform/qt/editing/inserting/insert-div-020-expected.png:
* platform/qt/editing/inserting/insert-div-025-expected.png:
* platform/qt/editing/inserting/insert-div-027-expected.png:
* platform/qt/editing/inserting/insert-paragraph-02-expected.png:
* platform/qt/editing/inserting/paragraph-separator-03-expected.png:
* platform/qt/editing/inserting/redo-expected.png:
* platform/qt/editing/pasteboard/4076267-expected.png:
* platform/qt/editing/pasteboard/4242293-expected.png:
* platform/qt/editing/pasteboard/4641033-expected.png:
* platform/qt/editing/pasteboard/4944770-1-expected.png:
* platform/qt/editing/pasteboard/4944770-2-expected.png:
* platform/qt/editing/pasteboard/4989774-expected.png:
* platform/qt/editing/pasteboard/5028447-expected.png:
* platform/qt/editing/pasteboard/5032095-expected.png:
* platform/qt/editing/pasteboard/5134759-expected.png:
* platform/qt/editing/pasteboard/innerText-inline-table-expected.png:
* platform/qt/editing/pasteboard/input-field-1-expected.png:
* platform/qt/editing/pasteboard/merge-after-delete-expected.png:
* platform/qt/editing/pasteboard/merge-end-borders-expected.png:
* platform/qt/editing/pasteboard/merge-start-list-expected.png:
* platform/qt/editing/pasteboard/paste-text-004-expected.png:
* platform/qt/editing/pasteboard/paste-text-008-expected.png:
* platform/qt/editing/pasteboard/paste-text-009-expected.png:
* platform/qt/editing/pasteboard/paste-text-013-expected.png:
* platform/qt/editing/pasteboard/paste-text-014-expected.png:
* platform/qt/editing/pasteboard/paste-text-016-expected.png:
* platform/qt/editing/pasteboard/styled-element-markup-expected.png:
* platform/qt/editing/selection/13804-expected.png:
* platform/qt/editing/selection/4402375-expected.png:
* platform/qt/editing/selection/4776665-expected.png:
* platform/qt/editing/selection/4866671-expected.png:
* platform/qt/editing/selection/4889598-expected.png:
* platform/qt/editing/selection/4895428-2-expected.png:
* platform/qt/editing/selection/4895428-3-expected.png:
* platform/qt/editing/selection/4947387-expected.png:
* platform/qt/editing/selection/4960116-expected.png:
* platform/qt/editing/selection/4960137-expected.png:
* platform/qt/editing/selection/4975120-expected.png:
* platform/qt/editing/selection/4983858-expected.png:
* platform/qt/editing/selection/5076323-1-expected.png:
* platform/qt/editing/selection/5081257-1-expected.png:
* platform/qt/editing/selection/5081257-2-expected.png:
* platform/qt/editing/selection/5099303-expected.png:
* platform/qt/editing/selection/5195166-2-expected.png:
* platform/qt/editing/selection/5240265-expected.png:
* platform/qt/editing/selection/7152-1-expected.png:
* platform/qt/editing/selection/7152-2-expected.png:
* platform/qt/editing/selection/addRange-expected.png:
* platform/qt/editing/selection/caret-ltr-2-expected.png:
* platform/qt/editing/selection/caret-ltr-2-left-expected.png:
* platform/qt/editing/selection/caret-ltr-expected.png:
* platform/qt/editing/selection/caret-ltr-right-expected.png:
* platform/qt/editing/selection/caret-rtl-2-left-expected.png:
* platform/qt/editing/selection/caret-rtl-right-expected.png:
* platform/qt/editing/selection/clear-selection-expected.png:
* platform/qt/editing/selection/contenteditable-click-inside-expected.png:
* platform/qt/editing/selection/drag-select-1-expected.png:
* platform/qt/editing/selection/editable-html-element-expected.png:
* platform/qt/editing/selection/expanding-selections-expected.png:
* platform/qt/editing/selection/expanding-selections2-expected.png:
* platform/qt/editing/selection/extend-by-character-003-expected.png:
* platform/qt/editing/selection/extend-by-character-005-expected.png:
* platform/qt/editing/selection/extend-inside-transforms-backward-expected.png:
* platform/qt/editing/selection/extend-inside-transforms-forward-expected.png:
* platform/qt/editing/selection/focus_editable_html-expected.png:
* platform/qt/editing/selection/inline-table-expected.png:
* platform/qt/editing/selection/mixed-editability-1-expected.png:
* platform/qt/editing/selection/mixed-editability-3-expected.png:
* platform/qt/editing/selection/mixed-editability-4-expected.png:
* platform/qt/editing/selection/mixed-editability-5-expected.png:
* platform/qt/editing/selection/mixed-editability-8-expected.png:
* platform/qt/editing/selection/mixed-editability-9-expected.png:
* platform/qt/editing/selection/move-3875618-fix-expected.png:
* platform/qt/editing/selection/move-3875641-fix-expected.png:
* platform/qt/editing/selection/move-between-blocks-yes-001-expected.png:
* platform/qt/editing/selection/move-by-character-003-expected.png:
* platform/qt/editing/selection/move-by-character-005-expected.png:
* platform/qt/editing/selection/node-removal-1-expected.png:
* platform/qt/editing/selection/node-removal-2-expected.png:
* platform/qt/editing/selection/paragraph-granularity-expected.png:
* platform/qt/editing/selection/range-between-block-and-inline-expected.png:
* platform/qt/editing/selection/replace-selection-1-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-1-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-2-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-3-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-4-expected.png:
* platform/qt/editing/selection/select-across-readonly-input-5-expected.png:
* platform/qt/editing/selection/select-all-003-expected.png:
* platform/qt/editing/selection/select-all-005-expected.png:
* platform/qt/editing/selection/select-all-006-expected.png:
* platform/qt/editing/selection/select-all-iframe-expected.png:
* platform/qt/editing/selection/select-text-overflow-ellipsis-expected.png:
* platform/qt/editing/selection/selectNode-expected.png:
* platform/qt/editing/selection/selectNodeContents-expected.png:
* platform/qt/editing/selection/selection-actions-expected.png:
* platform/qt/editing/selection/selection-button-text-expected.png:
* platform/qt/editing/selection/table-caret-3-expected.png:
* platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-br-expected.png:
* platform/qt/editing/selection/vertical-rl-rtl-extend-line-forward-p-expected.png:
* platform/qt/editing/selection/word-granularity-expected.png:
* platform/qt/editing/selection/wrapped-line-caret-1-expected.png:
* platform/qt/editing/selection/wrapped-line-caret-2-expected.png:
* platform/qt/editing/style/4916887-expected.png:
* platform/qt/editing/style/5084241-expected.png:
* platform/qt/editing/style/apple-style-editable-mix-expected.png:
* platform/qt/editing/style/block-style-001-expected.png:
* platform/qt/editing/style/block-style-002-expected.png:
* platform/qt/editing/style/block-style-003-expected.png:
* platform/qt/editing/style/create-block-for-style-001-expected.png:
* platform/qt/editing/style/create-block-for-style-002-expected.png:
* platform/qt/editing/style/create-block-for-style-003-expected.png:
* platform/qt/editing/style/create-block-for-style-004-expected.png:
* platform/qt/editing/style/create-block-for-style-005-expected.png:
* platform/qt/editing/style/create-block-for-style-006-expected.png:
* platform/qt/editing/style/create-block-for-style-007-expected.png:
* platform/qt/editing/style/create-block-for-style-008-expected.png:
* platform/qt/editing/style/create-block-for-style-009-expected.png:
* platform/qt/editing/style/create-block-for-style-010-expected.png:
* platform/qt/editing/style/create-block-for-style-011-expected.png:
* platform/qt/editing/style/create-block-for-style-012-expected.png:
* platform/qt/editing/style/create-block-for-style-013-expected.png:
* platform/qt/editing/style/designmode-expected.png:
* platform/qt/editing/style/relative-font-size-change-001-expected.png:
* platform/qt/editing/style/relative-font-size-change-002-expected.png:
* platform/qt/editing/style/relative-font-size-change-003-expected.png:
* platform/qt/editing/style/relative-font-size-change-004-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] Unreviewed gardening. Rebaselining after r147086.
zarvai@inf.u-szeged.hu [Thu, 28 Mar 2013 12:45:58 +0000 (12:45 +0000)]
[Qt][WK2] Unreviewed gardening. Rebaselining after r147086.

* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
* platform/qt-5.0-wk2/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Simplify ResourceScriptFile so that it stores hasDiverged state in it.
vsevik@chromium.org [Thu, 28 Mar 2013 12:34:16 +0000 (12:34 +0000)]
Web Inspector: Simplify ResourceScriptFile so that it stores hasDiverged state in it.
https://bugs.webkit.org/show_bug.cgi?id=113489

Reviewed by Pavel Feldman.

ResourceScriptFile._hasDiverged is the one flag that shows whether we have diverged from VM.
It's values is based both on dirty flag on uiSourceCode and information about live edit failures stored in _lastLiveEditFailed field.
Removed willMerge/Diverge events from ScriptFile.
JavaScriptSourceFrame now uses isMergingToVM/DivergingFromVM methods on ScriptFile.
to determine whether breakpointAdded/Removed events should be ignored.
Introduced muted state on JavaScriptSourceFrame to determine whether it should ignore user attempts to set/remove breakpoints.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._didMergeToVM):
(WebInspector.JavaScriptSourceFrame.prototype._didDivergeFromVM):
(WebInspector.JavaScriptSourceFrame.prototype._muteBreakpointsWhileEditing):
(WebInspector.JavaScriptSourceFrame.prototype._restoreBreakpointsAfterEditing):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._shouldIgnoreExternalBreakpointEvents):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointAdded):
(WebInspector.JavaScriptSourceFrame.prototype._breakpointRemoved):
(WebInspector.JavaScriptSourceFrame.prototype._updateScriptFile):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):
* inspector/front-end/LiveEditSupport.js:
(WebInspector.LiveEditScriptFile.prototype.isMergingToVM):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ScriptFile.prototype.isMergingToVM):
(WebInspector.ResourceScriptFile):
(WebInspector.ResourceScriptFile.prototype._workingCopyCommitted):
(WebInspector.ResourceScriptFile.prototype._isDiverged):
(WebInspector.ResourceScriptFile.prototype._workingCopyChanged):
(WebInspector.ResourceScriptFile.prototype._update):
(WebInspector.ResourceScriptFile.prototype._divergeFromVM):
(WebInspector.ResourceScriptFile.prototype._mergeToVM):
(WebInspector.ResourceScriptFile.prototype.hasDivergedFromVM):
(WebInspector.ResourceScriptFile.prototype.isMergingToVM):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.SnippetScriptFile.prototype.isMergingToVM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Updated png expected results after r146206..
kadam@inf.u-szeged.hu [Thu, 28 Mar 2013 12:31:29 +0000 (12:31 +0000)]
[Qt] Unreviewed gardening. Updated png expected results after r146206..

* platform/qt-5.0-wk2/fast/backgrounds/mask-box-image-expected.png: Added.
* platform/qt-5.0-wk2/fast/backgrounds/size/backgroundSize08-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/block-mask-overlay-image-outset-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/border-image-scaled-gradient-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/border-image-slice-constrained-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/border-image-slices-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-expected.png: Added.
* platform/qt-5.0-wk2/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png: Added.
* platform/qt-5.0-wk2/fast/box-shadow/box-shadow-radius-expected.png: Added.
* platform/qt-5.0-wk2/fast/box-shadow/box-shadow-transformed-expected.png: Added.
* platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadow-radius-expected.png: Added.
* platform/qt-5.0-wk2/fast/box-shadow/inset-box-shadows-expected.png: Added.
* platform/qt-5.0-wk2/fast/box-shadow/inset-expected.png: Added.
* platform/qt-5.0-wk2/fast/box-shadow/scaled-box-shadow-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/canvas-as-image-expected.png: Added.
* platform/qt-5.0-wk2/fast/canvas/canvas-bg-zoom-expected.png: Added.
* platform/qt-5.0-wk2/fast/clip/overflow-border-radius-composited-expected.png:
* platform/qt-5.0-wk2/fast/css/value-list-out-of-bounds-crash-expected.png: Added.
* platform/qt-5.0-wk2/fast/forms/listbox-clip-expected.png:
* platform/qt-5.0-wk2/fast/forms/select-background-none-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: DOMContentLoaded event divider is not shown on Timeline's main view
caseq@chromium.org [Thu, 28 Mar 2013 12:16:03 +0000 (12:16 +0000)]
Web Inspector: DOMContentLoaded event divider is not shown on Timeline's main view
https://bugs.webkit.org/show_bug.cgi?id=113196

Reviewed by Pavel Feldman.

Source/WebCore:

- keep event divider records in TimelinePresentationModel, not in TimelinePanel;
- process event divider records on every level, not just on top.

* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._updateEventDividers):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline.checkVisible):
(WebInspector.TimelinePanel.prototype._resetPanel):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype._innerAddRecord):
(WebInspector.TimelinePresentationModel.prototype.eventDividerRecords):

LayoutTests:

- use TimelinePresentationModel to fetch list of event divider records;

* http/tests/inspector/timeline-test.js:
(initialize_Timeline.InspectorTest.printTimestampRecords):
* inspector/timeline/timeline-load-event-expected.txt:
* inspector/timeline/timeline-load-event.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed inspector front-end closure compilation fix.
vsevik@chromium.org [Thu, 28 Mar 2013 12:14:13 +0000 (12:14 +0000)]
Unreviewed inspector front-end closure compilation fix.

* inspector/front-end/CookiesTable.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [DTE] Paint overlay highlight over line background color
commit-queue@webkit.org [Thu, 28 Mar 2013 12:11:42 +0000 (12:11 +0000)]
Web Inspector: [DTE] Paint overlay highlight over line background color
https://bugs.webkit.org/show_bug.cgi?id=113346

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-03-28
Reviewed by Pavel Feldman.

Source/WebCore:

No new tests: no change in behaviour.

- Append spans instead of text nodes to lineRows.
- Set positioning of all spans inside of webkit-line-content as
relative
- Set z-index property so that overlay highlight is above line
background but under text.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._measureHighlightDescriptor):
(WebInspector.TextEditorMainPanel.prototype._measureSpans):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._insertSpanBefore):
* inspector/front-end/textEditor.css:
(.webkit-line-content > .text-editor-overlay-highlight):
(.webkit-line-content > *):

LayoutTests:

Updated test expectations to correspond to new DefaultTextEditor's DOM
layout.

* inspector/editor/text-editor-brace-highlighter-expected.txt:
* inspector/editor/text-editor-highlight-api-expected.txt:
* inspector/editor/text-editor-highlight-token-expected.txt:
* inspector/editor/text-editor-long-line-expected.txt:
* inspector/editor/text-editor-remove-chunks-from-dom-expected.txt:
* inspector/editor/text-editor-show-whitespace-expected.txt:
* inspector/editor/text-editor-type-over-decoration-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [REGRESSION] [Styles] Pasting a property in the "name" field is broken
apavlov@chromium.org [Thu, 28 Mar 2013 12:02:15 +0000 (12:02 +0000)]
Web Inspector: [REGRESSION] [Styles] Pasting a property in the "name" field is broken
https://bugs.webkit.org/show_bug.cgi?id=113491

Reviewed by Pavel Feldman.

Source/WebCore:

Update the CSSProperty name and value upon pasting properties into the Styles pane.
Drive-by: start editing the next/new property name after pasting.
Test: inspector/styles/paste-property.html

* inspector/front-end/StylesSidebarPane.js:
(.selectElement):
(.moveDirection.alreadyNew):

LayoutTests:

* inspector/styles/paste-property-expected.txt: Added.
* inspector/styles/paste-property.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 28 Mar 2013 10:54:58 +0000 (10:54 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adjusting the expectation for media/track/track-in-band-legacy-api.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Updated expected png results after r146206.
kadam@inf.u-szeged.hu [Thu, 28 Mar 2013 10:40:48 +0000 (10:40 +0000)]
[Qt] Unreviewed gardening. Updated expected png results after r146206.

* platform/qt/fast/backgrounds/001-expected.png:
* platform/qt/fast/backgrounds/background-clip-text-expected.png:
* platform/qt/fast/backgrounds/background-origin-root-element-expected.png:
* platform/qt/fast/backgrounds/gradient-background-leakage-expected.png:
* platform/qt/fast/backgrounds/opacity-on-document-element-expected.png:
* platform/qt/fast/backgrounds/quirks-mode-line-box-backgrounds-expected.png:
* platform/qt/fast/block/basic/001-expected.png:
* platform/qt/fast/block/basic/004-expected.png:
* platform/qt/fast/block/basic/005-expected.png:
* platform/qt/fast/block/basic/007-expected.png:
* platform/qt/fast/block/basic/008-expected.png:
* platform/qt/fast/block/basic/010-expected.png:
* platform/qt/fast/block/basic/011-expected.png:
* platform/qt/fast/block/basic/015-expected.png:
* platform/qt/fast/block/basic/016-expected.png:
* platform/qt/fast/block/basic/018-expected.png:
* platform/qt/fast/block/basic/019-expected.png:
* platform/qt/fast/block/basic/min-pref-width-nowrap-floats-expected.png:
* platform/qt/fast/block/basic/minheight-expected.png:
* platform/qt/fast/block/basic/quirk-height-expected.png:
* platform/qt/fast/block/basic/quirk-percent-height-grandchild-expected.png:
* platform/qt/fast/block/basic/white-space-pre-wraps-expected.png:
* platform/qt/fast/block/float/001-expected.png:
* platform/qt/fast/block/float/003-expected.png:
* platform/qt/fast/block/float/004-expected.png:
* platform/qt/fast/block/float/005-expected.png:
* platform/qt/fast/block/float/006-expected.png:
* platform/qt/fast/block/float/010-expected.png:
* platform/qt/fast/block/float/015-expected.png:
* platform/qt/fast/block/float/016-expected.png:
* platform/qt/fast/block/float/017-expected.png:
* platform/qt/fast/block/float/021-expected.png:
* platform/qt/fast/block/float/023-expected.png:
* platform/qt/fast/block/float/024-expected.png:
* platform/qt/fast/block/float/025-expected.png:
* platform/qt/fast/block/float/027-expected.png:
* platform/qt/fast/block/float/029-expected.png:
* platform/qt/fast/block/float/030-expected.png:
* platform/qt/fast/block/float/031-expected.png:
* platform/qt/fast/block/float/avoidance-percent-width-strict-expected.png:
* platform/qt/fast/block/float/avoiding-float-centered-expected.png:
* platform/qt/fast/block/float/editable-text-overlapping-float-expected.png:
* platform/qt/fast/block/float/fit_line_below_floats-expected.png:
* platform/qt/fast/block/float/float-avoidance-expected.png:
* platform/qt/fast/block/float/float-on-zero-height-line-expected.png:
* platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position-expected.png:
* platform/qt/fast/block/float/intruding-float-add-in-sibling-block-on-static-position2-expected.png:
* platform/qt/fast/block/float/marquee-shrink-to-avoid-floats-expected.png:
* platform/qt/fast/block/float/multiple-float-positioning-expected.png:
* platform/qt/fast/block/float/nestedAnonymousBlocks-expected.png:
* platform/qt/fast/block/float/nestedAnonymousBlocks2-expected.png:
* platform/qt/fast/block/float/overhanging-after-height-decrease-offsets-expected.png:
* platform/qt/fast/block/float/overhanging-float-add-in-static-position-block-expected.png:
* platform/qt/fast/block/float/overhanging-float-add-in-static-position-block2-expected.png:
* platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block-expected.png:
* platform/qt/fast/block/float/overhanging-float-remove-from-absolute-position-block2-expected.png:
* platform/qt/fast/block/float/shrink-to-avoid-float-complexity-expected.png:
* platform/qt/fast/block/float/shrink-to-fit-width-expected.png:
* platform/qt/fast/block/float/width-update-after-clear-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
* platform/qt/fast/block/lineboxcontain/replaced-expected.png:
* platform/qt/fast/block/margin-collapse/001-expected.png:
* platform/qt/fast/block/margin-collapse/005-expected.png:
* platform/qt/fast/block/margin-collapse/006-expected.png:
* platform/qt/fast/block/margin-collapse/010-expected.png:
* platform/qt/fast/block/margin-collapse/011-expected.png:
* platform/qt/fast/block/margin-collapse/012-expected.png:
* platform/qt/fast/block/margin-collapse/015-expected.png:
* platform/qt/fast/block/margin-collapse/016-expected.png:
* platform/qt/fast/block/margin-collapse/017-expected.png:
* platform/qt/fast/block/margin-collapse/018-expected.png:
* platform/qt/fast/block/margin-collapse/019-expected.png:
* platform/qt/fast/block/margin-collapse/020-expected.png:
* platform/qt/fast/block/margin-collapse/025-expected.png:
* platform/qt/fast/block/margin-collapse/030-expected.png:
* platform/qt/fast/block/margin-collapse/031-expected.png:
* platform/qt/fast/block/margin-collapse/037-expected.png:
* platform/qt/fast/block/margin-collapse/038-expected.png:
* platform/qt/fast/block/margin-collapse/043-expected.png:
* platform/qt/fast/block/margin-collapse/056-expected.png:
* platform/qt/fast/block/margin-collapse/059-expected.png:
* platform/qt/fast/block/margin-collapse/100-expected.png:
* platform/qt/fast/block/margin-collapse/103-expected.png:
* platform/qt/fast/block/margin-collapse/104-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/001-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/005-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/006-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/010-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/011-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/012-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/015-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/016-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/017-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/018-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/019-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/020-expected.png:
* platform/qt/fast/block/margin-collapse/block-inside-inline/025-expected.png:
* platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.png:
* platform/qt/fast/block/positioning/047-expected.png:
* platform/qt/fast/block/positioning/049-expected.png:
* platform/qt/fast/block/positioning/051-expected.png:
* platform/qt/fast/block/positioning/052-expected.png:
* platform/qt/fast/block/positioning/054-expected.png:
* platform/qt/fast/block/positioning/055-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-lr/005-expected.png:
* platform/qt/fast/block/positioning/auto/vertical-rl/005-expected.png:
* platform/qt/fast/block/positioning/height-change-expected.png:
* platform/qt/fast/block/positioning/pref-width-change-expected.png:
* platform/qt/fast/block/positioning/relative-overflow-block-expected.png:
* platform/qt/fast/block/positioning/relative-overflow-replaced-expected.png:
* platform/qt/fast/block/positioning/relative-overflow-replaced-float-expected.png:
* platform/qt/fast/block/positioning/relayout-on-position-change-expected.png:
* platform/qt/fast/block/positioning/window-height-change-expected.png:
* platform/qt/fast/body-propagation/background-image/009-expected.png:
* platform/qt/fast/body-propagation/background-image/009-xhtml-expected.png:
* platform/qt/fast/body-propagation/overflow/001-expected.png:
* platform/qt/fast/body-propagation/overflow/001-xhtml-expected.png:
* platform/qt/fast/body-propagation/overflow/005-declarative-expected.png:
* platform/qt/fast/body-propagation/overflow/005-expected.png:
* platform/qt/fast/body-propagation/overflow/005-xhtml-expected.png:
* platform/qt/fast/borders/bidi-002-expected.png:
* platform/qt/fast/borders/bidi-009a-expected.png:
* platform/qt/fast/borders/bidi-012-expected.png:
* platform/qt/fast/borders/border-color-inherit-expected.png:
* platform/qt/fast/borders/border-radius-huge-assert-expected.png:
* platform/qt/fast/borders/border-radius-inline-flow-expected.png:
* platform/qt/fast/borders/border-radius-split-inline-expected.png:
* platform/qt/fast/borders/borderRadiusArcs01-expected.png:
* platform/qt/fast/borders/borderRadiusDotted05-expected.png:
* platform/qt/fast/borders/borderRadiusDouble01-expected.png:
* platform/qt/fast/borders/borderRadiusDouble02-expected.png:
* platform/qt/fast/borders/borderRadiusDouble03-expected.png:
* platform/qt/fast/borders/borderRadiusGroove01-expected.png:
* platform/qt/fast/borders/borderRadiusGroove02-expected.png:
* platform/qt/fast/borders/borderRadiusInset01-expected.png:
* platform/qt/fast/borders/borderRadiusInvalidColor-expected.png:
* platform/qt/fast/borders/borderRadiusOutset01-expected.png:
* platform/qt/fast/borders/borderRadiusRidge01-expected.png:
* platform/qt/fast/borders/borderRadiusSolid01-expected.png:
* platform/qt/fast/borders/borderRadiusSolid02-expected.png:
* platform/qt/fast/borders/borderRadiusSolid03-expected.png:
* platform/qt/fast/borders/borderRadiusSolid04-expected.png:
* platform/qt/fast/borders/different-color-borders-expected.png:
* platform/qt/fast/borders/fieldsetBorderRadius-expected.png:
* platform/qt/fast/borders/inline-mask-overlay-image-outset-expected.png:
* platform/qt/fast/borders/inline-mask-overlay-image-outset-vertical-rl-expected.png:
* platform/qt/fast/borders/rtl-border-05-expected.png:
* platform/qt/fast/borders/table-borders-expected.png:
* platform/qt/fast/borders/webkit-border-radius-expected.png:
* platform/qt/fast/box-shadow/basic-shadows-expected.png:
* platform/qt/fast/box-shadow/box-shadow-radius-expected.png:
* platform/qt/fast/box-shadow/inset-box-shadow-radius-expected.png:
* platform/qt/fast/box-shadow/inset-box-shadows-expected.png:
* platform/qt/fast/box-shadow/inset-with-extraordinary-radii-and-border-expected.png:
* platform/qt/fast/box-shadow/spread-multiple-inset-expected.png: Added.
* platform/qt/fast/box-shadow/spread-multiple-normal-expected.png: Added.
* platform/qt/fast/box-sizing/box-sizing-expected.png:
* platform/qt/fast/box-sizing/panels-one-expected.png:
* platform/qt/fast/box-sizing/panels-two-expected.png:
* platform/qt/fast/canvas/canvas-zoom-expected.png:
* platform/qt/fast/clip/001-expected.png:
* platform/qt/fast/clip/002-expected.png:
* platform/qt/fast/clip/003-expected.png:
* platform/qt/fast/clip/004-expected.png:
* platform/qt/fast/clip/005-expected.png:
* platform/qt/fast/clip/006-expected.png:
* platform/qt/fast/clip/007-expected.png:
* platform/qt/fast/clip/008-expected.png:
* platform/qt/fast/clip/009-expected.png:
* platform/qt/fast/clip/010-expected.png:
* platform/qt/fast/clip/011-expected.png:
* platform/qt/fast/clip/012-expected.png:
* platform/qt/fast/clip/013-expected.png:
* platform/qt/fast/clip/014-expected.png:
* platform/qt/fast/clip/015-expected.png:
* platform/qt/fast/clip/nestedTransparencyClip-expected.png:
* platform/qt/fast/clip/outline-overflowClip-expected.png:
* platform/qt/fast/clip/overflow-border-radius-clip-expected.png:
* platform/qt/fast/clip/overflow-border-radius-combinations-expected.png:
* platform/qt/fast/clip/overflow-border-radius-composited-expected.png:
* platform/qt/fast/clip/overflow-border-radius-fixed-position-expected.png:
* platform/qt/fast/clip/overflow-border-radius-transformed-expected.png:
* platform/qt/fast/css-generated-content/001-expected.png:
* platform/qt/fast/css-generated-content/002-expected.png:
* platform/qt/fast/css-generated-content/008-expected.png:
* platform/qt/fast/css-generated-content/009-expected.png:
* platform/qt/fast/css-generated-content/013-expected.png:
* platform/qt/fast/css-generated-content/016-expected.png:
* platform/qt/fast/css-generated-content/after-duplicated-after-split-expected.png:
* platform/qt/fast/css-generated-content/after-order-expected.png:
* platform/qt/fast/css-generated-content/beforeAfter-interdocument-expected.png:
* platform/qt/fast/css-generated-content/inline-display-types-expected.png:
* platform/qt/fast/css-generated-content/table-before-after-child-add-expected.png:
* platform/qt/fast/css-generated-content/table-cell-before-after-child-add-expected.png:
* platform/qt/fast/css-generated-content/table-row-before-after-child-add-expected.png:
* platform/qt/fast/css-generated-content/table-row-before-after-expected.png:
* platform/qt/fast/css-generated-content/table-row-group-to-inline-expected.png:
* platform/qt/fast/css-generated-content/table-table-before-after-child-add-expected.png:
* platform/qt/fast/css/002-expected.png:
* platform/qt/fast/css/003-expected.png:
* platform/qt/fast/css/004-expected.png:
* platform/qt/fast/css/005-expected.png:
* platform/qt/fast/css/008-expected.png:
* platform/qt/fast/css/ZeroOpacityLayers-expected.png:
* platform/qt/fast/css/ZeroOpacityLayers2-expected.png:
* platform/qt/fast/css/absolute-poition-in-rtl-parent-expected.png:
* platform/qt/fast/css/attribute-selector-dynamic-expected.png:
* platform/qt/fast/css/attribute-selector-empty-value-expected.png:
* platform/qt/fast/css/background-shorthand-invalid-url-expected.png:
* platform/qt/fast/css/beforeSelectorOnCodeElement-expected.png:
* platform/qt/fast/css/begin-end-contain-selector-empty-value-expected.png:
* platform/qt/fast/css/border-height-expected.png:
* platform/qt/fast/css/border-radius-outline-offset-expected.png:
* platform/qt/fast/css/border-solid-single-edge-antialias-expected.png: Added.
* platform/qt/fast/css/child-style-can-override-visited-style-expected.png:
* platform/qt/fast/css/clip-text-in-scaled-div-expected.png:
* platform/qt/fast/css/color-correction-backgrounds-and-text-expected.png:
* platform/qt/fast/css/continuationCrash-expected.png:
* platform/qt/fast/css/create_element_align-expected.png:
* platform/qt/fast/css/css-imports-expected.png:
* platform/qt/fast/css/css3-modsel-22-expected.png:
* platform/qt/fast/css/css3-nth-child-expected.png:
* platform/qt/fast/css/error-in-last-decl-expected.png:
* platform/qt/fast/css/first-letter-first-line-hover-expected.png:
* platform/qt/fast/css/first-letter-float-after-float-expected.png:
* platform/qt/fast/css/first-letter-float-expected.png:
* platform/qt/fast/css/first-letter-punctuation-expected.png:
* platform/qt/fast/css/first-letter-recalculation-expected.png:
* platform/qt/fast/css/first-letter-visibility-expected.png:
* platform/qt/fast/css/focus-ring-detached-expected.png:
* platform/qt/fast/css/focus-ring-multiline-writingmode-vertical-expected.png:
* platform/qt/fast/css/focus-ring-outline-color-expected.png:
* platform/qt/fast/css/focus-ring-outline-offset-expected.png:
* platform/qt/fast/css/focus-ring-outline-width-expected.png:
* platform/qt/fast/css/font-face-implicit-local-font-expected.png:
* platform/qt/fast/css/font-face-multiple-faces-expected.png:
* platform/qt/fast/css/font-face-multiple-remote-sources-expected.png:
* platform/qt/fast/css/font-smoothing-expected.png:
* platform/qt/fast/css/font_property_normal-expected.png:
* platform/qt/fast/css/hsla-color-expected.png:
* platform/qt/fast/css/import-rule-regression-11590-expected.png:
* platform/qt/fast/css/inline-properties-important-expected.png:
* platform/qt/fast/css/invalid-percentage-property-expected.png:
* platform/qt/fast/css/invalidation-errors-2-expected.png:
* platform/qt/fast/css/invalidation-errors-3-expected.png:
* platform/qt/fast/css/invalidation-errors-expected.png:
* platform/qt/fast/css/last-child-style-sharing-expected.png:
* platform/qt/fast/css/layerZOrderCrash-expected.png:
* platform/qt/fast/css/line-height-overflow-expected.png:
* platform/qt/fast/css/link-outside-head-expected.png:
* platform/qt/fast/css/list-outline-expected.png:
* platform/qt/fast/css/margin-bottom-form-element-quirk-expected.png:
* platform/qt/fast/css/margin-bottom-form-element-strict-expected.png:
* platform/qt/fast/css/namespaces/004-expected.png:
* platform/qt/fast/css/namespaces/005-expected.png:
* platform/qt/fast/css/namespaces/006-expected.png:
* platform/qt/fast/css/namespaces/namespaces-comments-expected.png:
* platform/qt/fast/css/namespaces/namespaces-empty-expected.png:
* platform/qt/fast/css/namespaces/namespaces-invalid-at-expected.png:
* platform/qt/fast/css/negative-leading-expected.png:
* platform/qt/fast/css/non-empty-span-expected.png:
* platform/qt/fast/css/pendingStylesheetFontSize-expected.png:
* platform/qt/fast/css/percent-top-relative-container-height-unspecified-expected.png:
* platform/qt/fast/css/position-negative-top-margin-expected.png:
* platform/qt/fast/css/preserve-user-specified-zoom-level-on-reload-expected.png:
* platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-expected.png:
* platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-dynamic-removed-expected.png:
* platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-expected.png:
* platform/qt/fast/css/relative-positioned-block-nested-with-inline-parent-multiple-descendant-blocks-dynamic-expected.png:
* platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-and-parent-dynamic-expected.png:
* platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-expected.png:
* platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-dynamic-removed-expected.png:
* platform/qt/fast/css/relative-positioned-block-with-inline-ancestor-expected.png:
* platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-expected.png:
* platform/qt/fast/css/relative-positioned-block-with-inline-parent-dynamic-removed-expected.png:
* platform/qt/fast/css/relative-positioned-block-with-inline-parent-keeps-style-expected.png:
* platform/qt/fast/css/rem-dynamic-scaling-expected.png:
* platform/qt/fast/css/rem-units-on-root-expected.png:
* platform/qt/fast/css/rgb-float-expected.png:
* platform/qt/fast/css/selector-set-attribute-expected.png:
* platform/qt/fast/css/shadow-multiple-expected.png:
* platform/qt/fast/css/style-outside-head-expected.png:
* platform/qt/fast/css/style-parsed-outside-head-expected.png:
* platform/qt/fast/css/table-rules-attribute-groups-with-frame-expected.png:
* platform/qt/fast/css/table-text-align-quirk-expected.png:
* platform/qt/fast/css/table-text-align-strict-expected.png:
* platform/qt/fast/css/target-fragment-match-expected.png:
* platform/qt/fast/css/text-align-expected.png:
* platform/qt/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/qt/fast/css/text-overflow-ellipsis-text-align-center-expected.png:
* platform/qt/fast/css/text-overflow-ellipsis-text-align-justify-expected.png:
* platform/qt/fast/css/text-overflow-ellipsis-text-align-left-expected.png:
* platform/qt/fast/css/text-overflow-ellipsis-text-align-right-expected.png:
* platform/qt/fast/css/text-transform-select-expected.png:
* platform/qt/fast/css/textCapitalizeEdgeCases-expected.png:
* platform/qt/fast/css/transform-default-parameter-expected.png:
* platform/qt/fast/css/transformed-mask-expected.png:
* platform/qt/fast/css/transition-color-unspecified-expected.png:
* platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-justify-expected.png:
* platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-left-expected.png:
* platform/qt/fast/css/vertical-text-overflow-ellipsis-text-align-right-expected.png:
* platform/qt/fast/css/visibility-hit-test-expected.png:
* platform/qt/fast/css/zoom-font-size-expected.png:
* platform/qt/fast/doctypes/001-expected.png:
* platform/qt/fast/doctypes/002-expected.png:
* platform/qt/fast/doctypes/003-expected.png:
* platform/qt/fast/doctypes/004-expected.png:
* platform/qt/fast/dom/34176-expected.png:
* platform/qt/fast/dom/Element/null-offset-parent-expected.png:
* platform/qt/fast/dom/HTMLElement/bdo-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/head-link-style-href-check-expected.png:
* platform/qt/fast/dom/HTMLInputElement/input-image-alt-text-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-styles-expected.png:
* platform/qt/fast/dom/HTMLObjectElement/vspace-hspace-as-number-expected.png:
* platform/qt/fast/dom/HTMLProgressElement/progress-bar-value-pseudo-element-expected.png:
* platform/qt/fast/dom/HTMLStyleElement/insert-parser-generated-expected.png:
* platform/qt/fast/dom/HTMLTableColElement/resize-table-using-col-width-expected.png:
* platform/qt/fast/dom/HTMLTableElement/colSpan-expected.png:
* platform/qt/fast/dom/HTMLTableElement/createCaption-expected.png:
* platform/qt/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png:
* platform/qt/fast/dom/Range/create-contextual-fragment-expected.png:
* platform/qt/fast/dom/Range/surroundContents-1-expected.png:
* platform/qt/fast/dom/Window/open-existing-pop-up-blocking-expected.png:
* platform/qt/fast/dom/anchor-text-expected.png:
* platform/qt/fast/dom/blur-contenteditable-expected.png:
* platform/qt/fast/dom/createDocumentType-expected.png:
* platform/qt/fast/dom/css-rule-functions-expected.png:
* platform/qt/fast/dom/delete-contents-expected.png:
* platform/qt/fast/dom/gc-10-expected.png:
* platform/qt/fast/dom/importNodeHTML-expected.png:
* platform/qt/fast/dom/importNodeXML-expected.png:
* platform/qt/fast/dynamic/002-expected.png:
* platform/qt/fast/dynamic/011-expected.png:
* platform/qt/fast/dynamic/014-expected.png:
* platform/qt/fast/dynamic/015-expected.png:
* platform/qt/fast/dynamic/anonymous-block-orphaned-lines-expected.png:
* platform/qt/fast/dynamic/dirty-float-in-clean-line-expected.png:
* platform/qt/fast/dynamic/first-letter-display-change-expected.png:
* platform/qt/fast/dynamic/float-at-line-break-expected.png:
* platform/qt/fast/dynamic/float-no-longer-overhanging-expected.png:
* platform/qt/fast/dynamic/float-withdrawal-2-expected.png:
* platform/qt/fast/dynamic/float-withdrawal-expected.png:
* platform/qt/fast/dynamic/noninlinebadness-expected.png:
* platform/qt/fast/dynamic/outerHTML-doc-expected.png:
* platform/qt/fast/dynamic/outerHTML-img-expected.png:
* platform/qt/fast/dynamic/subtree-parent-static-y-expected.png:
* platform/qt/fast/dynamic/unicode-bidi-expected.png:
* platform/qt/fast/dynamic/view-overflow-expected.png:
* platform/qt/fast/encoding/utf-16-big-endian-expected.png:
* platform/qt/fast/encoding/utf-16-little-endian-expected.png:
* platform/qt/fast/events/event-listener-on-link-expected.png:
* platform/qt/fast/events/resize-events-expected.png:
* platform/qt/fast/fast-mobile-scrolling/fixed-position-element-expected.png:
* platform/qt/fast/fast-mobile-scrolling/no-fixed-position-elements-expected.png:
* platform/qt/fast/flexbox/001-expected.png:
* platform/qt/fast/flexbox/002-expected.png:
* platform/qt/fast/flexbox/003-expected.png:
* platform/qt/fast/flexbox/004-expected.png:
* platform/qt/fast/flexbox/005-expected.png:
* platform/qt/fast/flexbox/006-expected.png:
* platform/qt/fast/flexbox/007-expected.png:
* platform/qt/fast/flexbox/008-expected.png:
* platform/qt/fast/flexbox/009-expected.png:
* platform/qt/fast/flexbox/010-expected.png:
* platform/qt/fast/flexbox/011-expected.png:
* platform/qt/fast/flexbox/012-expected.png:
* platform/qt/fast/flexbox/013-expected.png:
* platform/qt/fast/flexbox/014-expected.png:
* platform/qt/fast/flexbox/015-expected.png:
* platform/qt/fast/flexbox/016-expected.png:
* platform/qt/fast/flexbox/017-expected.png:
* platform/qt/fast/flexbox/018-expected.png:
* platform/qt/fast/flexbox/019-expected.png:
* platform/qt/fast/flexbox/020-expected.png:
* platform/qt/fast/flexbox/021-expected.png:
* platform/qt/fast/flexbox/022-expected.png:
* platform/qt/fast/flexbox/023-expected.png:
* platform/qt/fast/flexbox/024-expected.png:
* platform/qt/fast/flexbox/overhanging-floats-removed-expected.png:
* platform/qt/fast/forms/HTMLOptionElement_label05-expected.png:
* platform/qt/fast/forms/basic-buttons-expected.png:
* platform/qt/fast/forms/basic-textareas-quirks-expected.png:
* platform/qt/fast/forms/button-default-title-expected.png:
* platform/qt/fast/forms/button-inner-block-reuse-expected.png:
* platform/qt/fast/forms/button-table-styles-expected.png:
* platform/qt/fast/forms/button-text-transform-expected.png:
* platform/qt/fast/forms/control-clip-overflow-expected.png:
* platform/qt/fast/forms/disabled-select-change-index-expected.png:
* platform/qt/fast/forms/fieldset-align-expected.png:
* platform/qt/fast/forms/file/file-input-direction-expected.png:
* platform/qt/fast/forms/floating-textfield-relayout-expected.png:
* platform/qt/fast/forms/form-hides-table-expected.png:
* platform/qt/fast/forms/input-appearance-selection-expected.png:
* platform/qt/fast/forms/input-placeholder-paint-order-expected.png:
* platform/qt/fast/forms/listbox-clip-expected.png:
* platform/qt/fast/forms/menulist-clip-expected.png:
* platform/qt/fast/forms/menulist-option-wrap-expected.png:
* platform/qt/fast/forms/negativeLineHeight-expected.png:
* platform/qt/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
* platform/qt/fast/forms/option-strip-whitespace-expected.png:
* platform/qt/fast/forms/placeholder-position-expected.png:
* platform/qt/fast/forms/search-rtl-expected.png:
* platform/qt/fast/forms/select-change-popup-to-listbox-expected.png:
* platform/qt/fast/forms/select-initial-position-expected.png:
* platform/qt/fast/forms/select-item-background-clip-expected.png:
* platform/qt/fast/forms/select-list-box-with-height-expected.png:
* platform/qt/fast/forms/select/optgroup-rendering-expected.png:
* platform/qt/fast/forms/textarea-align-expected.png:
* platform/qt/fast/forms/textarea-placeholder-pseudo-style-expected.png:
* platform/qt/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Rebaselining after r147086.
zarvai@inf.u-szeged.hu [Thu, 28 Mar 2013 10:07:49 +0000 (10:07 +0000)]
[Qt] Unreviewed gardening. Rebaselining after r147086.

* platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
* platform/qt/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Auto expand retaining path until there are more than one retainer.
commit-queue@webkit.org [Thu, 28 Mar 2013 09:50:00 +0000 (09:50 +0000)]
Web Inspector: Auto expand retaining path until there are more than one retainer.
https://bugs.webkit.org/show_bug.cgi?id=112596

Patch by Alexei Filippov <alph@chromium.org> on 2013-03-28
Reviewed by Yury Semikhatsky.

Source/WebCore:

When retainers view gets opened automatically expand retaining path
for objects having just a single retainer.

Test: inspector/profiler/heap-snapshot-summary-retainers.html

* inspector/front-end/HeapSnapshotDataGrids.js:
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.populateComplete):
(WebInspector.HeapSnapshotRetainmentDataGrid.prototype.setDataSource):
* inspector/front-end/HeapSnapshotGridNodes.js:
(WebInspector.HeapSnapshotGridNode.prototype.childrenRetrieved):
(WebInspector.HeapSnapshotGridNode.prototype._populateChildren):

LayoutTests:

When retainers view gets opened automatically expand retaining path
for objects having just a single retainer.
- Added a test for the new behavior.
- Replaced hardcoded "populate complete" string with the event object.

* inspector/profiler/heap-snapshot-summary-retainers-expected.txt:
* inspector/profiler/heap-snapshot-summary-retainers.html:
* inspector/profiler/heap-snapshot-test.js:
(initialize_HeapSnapshotTest.):
(initialize_HeapSnapshotTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Updating PNG expected results after r146206.
zarvai@inf.u-szeged.hu [Thu, 28 Mar 2013 09:47:30 +0000 (09:47 +0000)]
[Qt] Unreviewed gardening. Updating PNG expected results after r146206.

* platform/qt/tables/mozilla/bugs/bug46480-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug46480-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug46623-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug46623-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug46924-expected.png:
* platform/qt/tables/mozilla/bugs/bug47432-expected.png:
* platform/qt/tables/mozilla/bugs/bug4849-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug48827-expected.png:
* platform/qt/tables/mozilla/bugs/bug51037-expected.png:
* platform/qt/tables/mozilla/bugs/bug5188-expected.png:
* platform/qt/tables/mozilla/bugs/bug52505-expected.png:
* platform/qt/tables/mozilla/bugs/bug52506-expected.png:
* platform/qt/tables/mozilla/bugs/bug53690-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug53690-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug5538-expected.png:
* platform/qt/tables/mozilla/bugs/bug55527-expected.png:
* platform/qt/tables/mozilla/bugs/bug55694-expected.png:
* platform/qt/tables/mozilla/bugs/bug55789-expected.png:
* platform/qt/tables/mozilla/bugs/bug57300-expected.png:
* platform/qt/tables/mozilla/bugs/bug57828-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug57828-expected.png:
* platform/qt/tables/mozilla/bugs/bug5799-expected.png:
* platform/qt/tables/mozilla/bugs/bug5835-expected.png:
* platform/qt/tables/mozilla/bugs/bug5838-expected.png:
* platform/qt/tables/mozilla/bugs/bug59354-expected.png:
* platform/qt/tables/mozilla/bugs/bug60804-expected.png:
* platform/qt/tables/mozilla/bugs/bug60807-expected.png:
* platform/qt/tables/mozilla/bugs/bug6184-expected.png:
* platform/qt/tables/mozilla/bugs/bug6304-expected.png:
* platform/qt/tables/mozilla/bugs/bug641-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug641-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug647-expected.png:
* platform/qt/tables/mozilla/bugs/bug650-expected.png:
* platform/qt/tables/mozilla/bugs/bug67915-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug68912-expected.png:
* platform/qt/tables/mozilla/bugs/bug68998-expected.png:
* platform/qt/tables/mozilla/bugs/bug69187-expected.png:
* platform/qt/tables/mozilla/bugs/bug69382-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug69382-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug709-expected.png:
* platform/qt/tables/mozilla/bugs/bug7112-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug7112-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug7121-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug7342-expected.png:
* platform/qt/tables/mozilla/bugs/bug7471-expected.png:
* platform/qt/tables/mozilla/bugs/bug7714-expected.png:
* platform/qt/tables/mozilla/bugs/bug78162-expected.png:
* platform/qt/tables/mozilla/bugs/bug80762-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug82946-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug82946-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug8381-expected.png:
* platform/qt/tables/mozilla/bugs/bug8411-expected.png:
* platform/qt/tables/mozilla/bugs/bug88035-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug88035-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug88524-expected.png:
* platform/qt/tables/mozilla/bugs/bug8858-expected.png:
* platform/qt/tables/mozilla/bugs/bug9072-expected.png:
* platform/qt/tables/mozilla/bugs/bug9123-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug9123-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug92143-expected.png:
* platform/qt/tables/mozilla/bugs/bug9271-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug9271-2-expected.png:
* platform/qt/tables/mozilla/bugs/bug92868-expected.png:
* platform/qt/tables/mozilla/bugs/bug93363-expected.png:
* platform/qt/tables/mozilla/bugs/bug963-expected.png:
* platform/qt/tables/mozilla/bugs/bug96334-expected.png:
* platform/qt/tables/mozilla/bugs/bug96343-expected.png:
* platform/qt/tables/mozilla/bugs/bug965-expected.png:
* platform/qt/tables/mozilla/bugs/bug97138-expected.png:
* platform/qt/tables/mozilla/bugs/bug97383-expected.png:
* platform/qt/tables/mozilla/bugs/bug98196-expected.png:
* platform/qt/tables/mozilla/bugs/bug9879-1-expected.png:
* platform/qt/tables/mozilla/bugs/bug99948-expected.png:
* platform/qt/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
* platform/qt/tables/mozilla/core/borders-expected.png:
* platform/qt/tables/mozilla/core/captions-expected.png:
* platform/qt/tables/mozilla/core/col_span-expected.png:
* platform/qt/tables/mozilla/core/col_widths_auto_autoFixPer-expected.png:
* platform/qt/tables/mozilla/core/col_widths_auto_autoPer-expected.png:
* platform/qt/tables/mozilla/core/col_widths_auto_fix-expected.png:
* platform/qt/tables/mozilla/core/col_widths_auto_fixPer-expected.png:
* platform/qt/tables/mozilla/core/col_widths_auto_per-expected.png:
* platform/qt/tables/mozilla/core/col_widths_fix_autoFix-expected.png:
* platform/qt/tables/mozilla/core/col_widths_fix_autoPer-expected.png:
* platform/qt/tables/mozilla/core/col_widths_fix_fix-expected.png:
* platform/qt/tables/mozilla/core/col_widths_fix_fixPer-expected.png:
* platform/qt/tables/mozilla/core/col_widths_fix_per-expected.png:
* platform/qt/tables/mozilla/core/margins-expected.png:
* platform/qt/tables/mozilla/core/nested1-expected.png:
* platform/qt/tables/mozilla/core/row_span-expected.png:
* platform/qt/tables/mozilla/core/table_frame-expected.png:
* platform/qt/tables/mozilla/core/table_rules-expected.png:
* platform/qt/tables/mozilla/core/table_widths-expected.png:
* platform/qt/tables/mozilla/dom/deleteCol1-expected.png:
* platform/qt/tables/mozilla/dom/deleteCol2-expected.png:
* platform/qt/tables/mozilla/dom/deleteCol3-expected.png:
* platform/qt/tables/mozilla/dom/deleteColGroup1-expected.png:
* platform/qt/tables/mozilla/dom/deleteColGroup2-expected.png:
* platform/qt/tables/mozilla/dom/deleteRowsRebuild1-expected.png:
* platform/qt/tables/mozilla/dom/deleteRowsShrink1-expected.png:
* platform/qt/tables/mozilla/dom/deleteTbodyExpand1-expected.png:
* platform/qt/tables/mozilla/dom/deleteTbodyRebuild1-expected.png:
* platform/qt/tables/mozilla/dom/insertCellsExpand2-expected.png:
* platform/qt/tables/mozilla/dom/insertCellsRebuild1-expected.png:
* platform/qt/tables/mozilla/dom/insertCellsRebuild2-expected.png:
* platform/qt/tables/mozilla/dom/insertColGroups1-expected.png:
* platform/qt/tables/mozilla/dom/insertColGroups2-expected.png:
* platform/qt/tables/mozilla/dom/insertCols1-expected.png:
* platform/qt/tables/mozilla/dom/insertCols2-expected.png:
* platform/qt/tables/mozilla/dom/insertCols3-expected.png:
* platform/qt/tables/mozilla/dom/insertCols4-expected.png:
* platform/qt/tables/mozilla/dom/insertCols5-expected.png:
* platform/qt/tables/mozilla/dom/tableDom-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_simple-table-column-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_simple-table-column-group-expected.png:
* platform/qt/tables/mozilla/marvin/backgr_simple-table-row-expected.png:
* platform/qt/tables/mozilla/marvin/body_tbody-expected.png:
* platform/qt/tables/mozilla/marvin/body_tfoot-expected.png:
* platform/qt/tables/mozilla/marvin/body_thead-expected.png:
* platform/qt/tables/mozilla/marvin/col_span-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_span-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_valign_baseline-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_valign_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_valign_middle-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_valign_top-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_width_pct-expected.png:
* platform/qt/tables/mozilla/marvin/colgroup_width_px-expected.png:
* platform/qt/tables/mozilla/marvin/table_frame_border-expected.png:
* platform/qt/tables/mozilla/marvin/table_frame_box-expected.png:
* platform/qt/tables/mozilla/marvin/table_row_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/table_row_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/table_row_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/table_rules_all-expected.png:
* platform/qt/tables/mozilla/marvin/table_rules_groups-expected.png:
* platform/qt/tables/mozilla/marvin/table_rules_none-expected.png:
* platform/qt/tables/mozilla/marvin/tables_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/tables_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/tables_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/tables_border_0-expected.png:
* platform/qt/tables/mozilla/marvin/tables_border_1-expected.png:
* platform/qt/tables/mozilla/marvin/tables_border_2-expected.png:
* platform/qt/tables/mozilla/marvin/tables_border_3-expected.png:
* platform/qt/tables/mozilla/marvin/tables_caption_align_bot-expected.png:
* platform/qt/tables/mozilla/marvin/tables_caption_align_top-expected.png:
* platform/qt/tables/mozilla/marvin/tables_cellpadding-expected.png:
* platform/qt/tables/mozilla/marvin/tables_cellpadding_pct-expected.png:
* platform/qt/tables/mozilla/marvin/tables_cellspacing-expected.png:
* platform/qt/tables/mozilla/marvin/tables_class-expected.png:
* platform/qt/tables/mozilla/marvin/tables_default-expected.png:
* platform/qt/tables/mozilla/marvin/tables_id-expected.png:
* platform/qt/tables/mozilla/marvin/tables_row_th_nowrap-expected.png:
* platform/qt/tables/mozilla/marvin/tables_style-expected.png:
* platform/qt/tables/mozilla/marvin/tables_td_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/tables_td_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/tables_td_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/tables_td_colspan-expected.png:
* platform/qt/tables/mozilla/marvin/tables_td_height-expected.png:
* platform/qt/tables/mozilla/marvin/tables_td_nowrap-expected.png:
* platform/qt/tables/mozilla/marvin/tables_td_rowspan-expected.png:
* platform/qt/tables/mozilla/marvin/tables_td_width-expected.png:
* platform/qt/tables/mozilla/marvin/tables_th_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/tables_th_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/tables_th_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/tables_th_colspan-expected.png:
* platform/qt/tables/mozilla/marvin/tables_th_height-expected.png:
* platform/qt/tables/mozilla/marvin/tables_th_rowspan-expected.png:
* platform/qt/tables/mozilla/marvin/tables_th_width-expected.png:
* platform/qt/tables/mozilla/marvin/tables_width_percent-expected.png:
* platform/qt/tables/mozilla/marvin/tables_width_px-expected.png:
* platform/qt/tables/mozilla/marvin/tbody_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/tbody_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/tbody_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/tbody_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/tbody_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/tbody_char-expected.png:
* platform/qt/tables/mozilla/marvin/tfoot_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/tfoot_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/tfoot_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/tfoot_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/tfoot_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/tfoot_char-expected.png:
* platform/qt/tables/mozilla/marvin/thead_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/thead_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/thead_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/thead_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/thead_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/thead_char-expected.png:
* platform/qt/tables/mozilla/marvin/x_caption_align_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/x_caption_align_top-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_span-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_valign_baseline-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_valign_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_valign_middle-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_valign_top-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_width_pct-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_width_px-expected.png:
* platform/qt/tables/mozilla/marvin/x_col_width_rel-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_span-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_valign_baseline-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_valign_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_valign_middle-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_valign_top-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_width_pct-expected.png:
* platform/qt/tables/mozilla/marvin/x_colgroup_width_rel-expected.png:
* platform/qt/tables/mozilla/marvin/x_table-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_bgcolor_name-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_bgcolor_rgb-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_border-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_border_none-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_border_px-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_cellpadding-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_cellpadding_pct-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_cellspacing_pct-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_class-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_frame_void-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_id-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_rules_groups-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_rules_none-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_style-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_width_pct-expected.png:
* platform/qt/tables/mozilla/marvin/x_table_width_px-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_class-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_id-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_style-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_valign_baseline-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_valign_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_valign_middle-expected.png:
* platform/qt/tables/mozilla/marvin/x_tbody_valign_top-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_bgcolor_name-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_bgcolor_rgb-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_height-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_nowrap-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_valign_baseline-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_valign_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_valign_middle-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_valign_top-expected.png:
* platform/qt/tables/mozilla/marvin/x_td_width-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_class-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_id-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_style-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_valign_baseline-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_valign_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_valign_middle-expected.png:
* platform/qt/tables/mozilla/marvin/x_tfoot_valign_top-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_bgcolor_name-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_bgcolor_rgb-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_class-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_height-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_id-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_nowrap-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_style-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_valign_baseline-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_valign_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_valign_top-expected.png:
* platform/qt/tables/mozilla/marvin/x_th_width-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_align_left-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_align_right-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_class-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_id-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_style-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_valign_baseline-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_valign_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_valign_middle-expected.png:
* platform/qt/tables/mozilla/marvin/x_thead_valign_top-expected.png:
* platform/qt/tables/mozilla/marvin/x_tr_align_center-expected.png:
* platform/qt/tables/mozilla/marvin/x_tr_align_char-expected.png:
* platform/qt/tables/mozilla/marvin/x_tr_align_justify-expected.png:
* platform/qt/tables/mozilla/marvin/x_tr_bgcolor_name-expected.png:
* platform/qt/tables/mozilla/marvin/x_tr_bgcolor_rgb-expected.png:
* platform/qt/tables/mozilla/marvin/x_tr_valign_baseline-expected.png:
* platform/qt/tables/mozilla/marvin/x_tr_valign_bottom-expected.png:
* platform/qt/tables/mozilla/marvin/x_tr_valign_middle-expected.png:
* platform/qt/tables/mozilla/marvin/x_tr_valign_top-expected.png:
* platform/qt/tables/mozilla/other/cellspacing-expected.png:
* platform/qt/tables/mozilla/other/nested2-expected.png:
* platform/qt/tables/mozilla/other/nestedTables-expected.png:
* platform/qt/tables/mozilla/other/padding-expected.png:
* platform/qt/tables/mozilla/other/test3-expected.png:
* platform/qt/tables/mozilla/other/test6-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/97619-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug10140-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug10216-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug104898-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug106966-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug1128-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug11331-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug11945-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug131020-3-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug14007-1-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug14007-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug14489-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug17826-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug18770-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug19526-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug21518-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug22122-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug2479-5-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug24880-1-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug25707-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug29058-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-18-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug3166-5-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug32205-1-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug32205-4-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug42043-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug4294-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug47163-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug51000-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug56024-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug59252-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug61042-1-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug61042-2-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug72393-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug7243-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug73629-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug89315-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug91057-expected.png:
* platform/qt/tables/mozilla_expected_failures/bugs/bug9879-1-expected.png:
* platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-1-expected.png:
* platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/qt/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/backgrounds-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/captions3-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/col_span2-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/cols1-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/columns-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/conflicts-expected.png:
* platform/qt/tables/mozilla_expected_failures/core/standards1-expected.png:
* platform/qt/tables/mozilla_expected_failures/dom/appendCells1-expected.png:
* platform/qt/tables/mozilla_expected_failures/dom/appendCellsRebuild1-expected.png:
* platform/qt/tables/mozilla_expected_failures/dom/appendColGroup1-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_frame_above-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_frame_below-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_frame_hsides-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_frame_lhs-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_frame_rhs-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_frame_void-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_frame_vsides-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_cell-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_row_sibling-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_table_caption-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_style_reflow_tbody_sibling-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_overflow_td_align_right-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_rules_cols-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/table_rules_rows-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_left-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/tables_caption_align_right-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/tables_cellspacing_pct-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_left-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_caption_align_right-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_colgroup_width_px-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_above-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_below-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_border-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_box-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_hsides-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_lhs-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_rhs-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_frame_vsides-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_all-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_cols-expected.png:
* platform/qt/tables/mozilla_expected_failures/marvin/x_table_rules_rows-expected.png:
* platform/qt/tables/mozilla_expected_failures/other/empty_cells-expected.png:
* platform/qt/tables/mozilla_expected_failures/other/test4-expected.png:
* platform/qt/transforms/2d/compound-transforms-vs-containers-expected.png:
* platform/qt/transforms/2d/transform-borderbox-expected.png:
* platform/qt/transforms/2d/transform-fixed-container-expected.png:
* platform/qt/transforms/2d/transform-origin-borderbox-expected.png:
* platform/qt/transforms/2d/zoom-menulist-expected.png:
* platform/qt/transitions/cross-fade-background-image-expected.png:
* platform/qt/transitions/cross-fade-border-image-expected.png:
* platform/qt/transitions/svg-text-shadow-transition-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Fixed property text indentation in Styles sidebar.
commit-queue@webkit.org [Thu, 28 Mar 2013 09:33:57 +0000 (09:33 +0000)]
Web Inspector: Fixed property text indentation in Styles sidebar.
https://bugs.webkit.org/show_bug.cgi?id=113409

Patch by Vladislav Kaznacheev <kaznacheev@chromium.org> on 2013-03-28
Reviewed by Alexander Pavlov.

When the sidebar is too narrow and the property text wraps around it breaks the indentation.
This was introduced in r143207 which spuriously modified DOM elements order.

* inspector/front-end/StylesSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRegression: Crash when selecting Hebrew and numbers in a list
commit-queue@webkit.org [Thu, 28 Mar 2013 09:13:21 +0000 (09:13 +0000)]
Regression: Crash when selecting Hebrew and numbers in a list
https://bugs.webkit.org/show_bug.cgi?id=111894

Patch by Arpita Bahuguna <a.bah@samsung.com> on 2013-03-28
Reviewed by Ryosuke Niwa.

Source/WebCore:

There is a crash when trying to click/select an anonymous
renderer.

This is a regression due to r143313 which tries to add border/padding
to the computed caret rect in RenderBox::localCaretRect().
The patch calls on the node() method for the corresponding
renderer. For an anonymous renderer though, node() returns
null. Since no check had been added for this, a crash occurs when
caret rect for an anonymous renderer is being computed.

Test: editing/selection/click-on-anonymous-content-crash.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::localCaretRect):
Added a check for validating the return from the node() call.

LayoutTests:

* editing/selection/click-on-anonymous-content-crash-expected.txt: Added.
* editing/selection/click-on-anonymous-content-crash.html: Added.
Added a testcase for verifying that no crash occurs when trying to
select/click an anonymous renderer, in this case the list marker's
renderer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoX-Frame-Options: Multiple headers are ignored completely.
mkwst@chromium.org [Thu, 28 Mar 2013 08:59:00 +0000 (08:59 +0000)]
X-Frame-Options: Multiple headers are ignored completely.
https://bugs.webkit.org/show_bug.cgi?id=113387

Reviewed by Nate Chapin.

Source/WebCore:

If a server sends multiple 'X-Frame-Options' headers, we end up with a
value like 'SAMEORIGIN, SAMEORIGIN'. Currently, we're treating that as
invalid, and ignoring the header. It would be safer to follow Gecko's
lead[1] by:

- Folding duplicated entries into their common value (that is:
  'sameorigin, sameorigin' -> 'sameorigin').

- Failing closed in the case of conflicts (that is:
  'sameorigin, allowall' -> 'deny').

[1]: https://bugzilla.mozilla.org/show_bug.cgi?id=761655

Tests: http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html
       http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow.html
       http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldInterruptLoadForXFrameOptions):
    Call out to parseXFrameOptionsHeader to get the header's disposition
    and deal with each case in a switch statement for clarity. Add a new
    console warning for the conflict case described above.
* platform/network/HTTPParsers.cpp:
(WebCore::parseXFrameOptionsHeader):
* platform/network/HTTPParsers.h:
    Move X-Frame-Options parsing out into HTTPParsers, as it's getting
    more and more complicated. To do this, the patch defines a new enum
    to pass around the header's disposition.

LayoutTests:

* http/tests/security/XFrameOptions/resources/x-frame-options-multiple-headers-conflict.cgi: Added.
* http/tests/security/XFrameOptions/resources/x-frame-options-multiple-headers-sameorigin.cgi: Added.
* http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict.html: Added.
* http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow.html: Added.
* http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.
* http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny.html: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-conflict-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-allow-expected.txt: Added.
* platform/chromium/http/tests/security/XFrameOptions/x-frame-options-multiple-headers-sameorigin-deny-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK build fix after r147039.
zandobersek@gmail.com [Thu, 28 Mar 2013 08:48:37 +0000 (08:48 +0000)]
Unreviewed GTK build fix after r147039.

* Source/autotools/symbols.filter: Export the missing symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Convert layout tests region-style-block-background-color[2] to ref...
commit-queue@webkit.org [Thu, 28 Mar 2013 08:37:53 +0000 (08:37 +0000)]
[CSS Regions] Convert layout tests region-style-block-background-color[2] to ref-tests
https://bugs.webkit.org/show_bug.cgi?id=86339

Patch by Mihai Tica <mitica@adobe.com> on 2013-03-28
Reviewed by Tony Chang.

This patch converts the pixel test baseline into ref-tests for the following tests:
fast/regions/region-style-block-background-color.html
fast/regions/region-style-block-background-color2.html

* fast/regions/region-style-block-background-color-expected.html: Added.
* fast/regions/region-style-block-background-color.html:
* fast/regions/region-style-block-background-color2-expected.html: Added.
* fast/regions/region-style-block-background-color2.html:
* platform/chromium-linux/fast/regions/region-style-block-background-color-expected.png: Removed.
* platform/chromium-linux/fast/regions/region-style-block-background-color2-expected.png: Removed.
* platform/chromium-mac-lion/fast/regions/region-style-block-background-color-expected.png: Removed.
* platform/chromium-mac-lion/fast/regions/region-style-block-background-color2-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-style-block-background-color-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-style-block-background-color2-expected.png: Removed.
* platform/chromium-mac/fast/regions/region-style-block-background-color-expected.png: Removed.
* platform/chromium-mac/fast/regions/region-style-block-background-color2-expected.png: Removed.
* platform/chromium-win/fast/regions/region-style-block-background-color-expected.png: Removed.
* platform/chromium-win/fast/regions/region-style-block-background-color-expected.txt: Removed.
* platform/chromium-win/fast/regions/region-style-block-background-color2-expected.png: Removed.
* platform/chromium-win/fast/regions/region-style-block-background-color2-expected.txt: Removed.
* platform/chromium/fast/regions/region-style-block-background-color-expected.txt: Removed.
* platform/chromium/fast/regions/region-style-block-background-color2-expected.txt: Removed.
* platform/efl/fast/regions/region-style-block-background-color-expected.png: Removed.
* platform/efl/fast/regions/region-style-block-background-color-expected.txt: Removed.
* platform/efl/fast/regions/region-style-block-background-color2-expected.png: Removed.
* platform/efl/fast/regions/region-style-block-background-color2-expected.txt: Removed.
* platform/gtk/fast/regions/region-style-block-background-color-expected.png: Removed.
* platform/gtk/fast/regions/region-style-block-background-color-expected.txt: Removed.
* platform/gtk/fast/regions/region-style-block-background-color2-expected.png: Removed.
* platform/gtk/fast/regions/region-style-block-background-color2-expected.txt: Removed.
* platform/mac/fast/regions/region-style-block-background-color-expected.png: Removed.
* platform/mac/fast/regions/region-style-block-background-color-expected.txt: Removed.
* platform/mac/fast/regions/region-style-block-background-color2-expected.png: Removed.
* platform/mac/fast/regions/region-style-block-background-color2-expected.txt: Removed.
* platform/qt/fast/regions/region-style-block-background-color-expected.png: Removed.
* platform/qt/fast/regions/region-style-block-background-color-expected.txt: Removed.
* platform/qt/fast/regions/region-style-block-background-color2-expected.png: Removed.
* platform/qt/fast/regions/region-style-block-background-color2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGardening. Organize expected results, because the generic expected file should be...
kadam@inf.u-szeged.hu [Thu, 28 Mar 2013 08:30:23 +0000 (08:30 +0000)]
Gardening. Organize expected results, because the generic expected file should be the one that uses JSC.
https://bugs.webkit.org/show_bug.cgi?id=113291.

Reviewed by Csaba Osztrogon√°c.

* inspector/console/console-eval-syntax-error-expected.txt:
* inspector/debugger/debugger-pause-in-eval-script-expected.txt:
* inspector/extensions/extensions-eval-expected.txt:
* platform/chromium/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Copied from LayoutTests/inspector/debugger/debugger-pause-in-eval-script-expected.txt.
* platform/chromium/inspector/extensions/extensions-eval-expected.txt: Copied from LayoutTests/inspector/extensions/extensions-eval-expected.txt.
* platform/mac/inspector/console/console-eval-syntax-error-expected.txt: Removed.
* platform/mac/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Removed.
* platform/mac/inspector/extensions/extensions-eval-expected.txt: Removed.
* platform/qt/inspector/console/console-eval-syntax-error-expected.txt: Removed.
* platform/qt/inspector/debugger/debugger-pause-in-eval-script-expected.txt: Removed.
* platform/qt/inspector/extensions/extensions-eval-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Consolidate use of RenderRegion::isValid
mihnea@adobe.com [Thu, 28 Mar 2013 08:26:28 +0000 (08:26 +0000)]
[CSSRegions] Consolidate use of RenderRegion::isValid
https://bugs.webkit.org/show_bug.cgi?id=113154

Reviewed by David Hyatt.

After https://bugs.webkit.org/show_bug.cgi?id=98752, the list of invalid regions is kept separately than the list of valid regions.
A valid region has always a valid flow thread attached. We can use isValid() throughout the RenderRegion code
instead of testing for both isValid() and m_flowThread.

No new tests since there is no change is functionality, just code refactoring.

* rendering/RenderNamedFlowThread.cpp:
(WebCore::RenderNamedFlowThread::addRegionToNamedFlowThread): Added a new function to keep the code
used in addRegionToThread and checkInvalidRegions.
(WebCore::RenderNamedFlowThread::addRegionToThread):
(WebCore::RenderNamedFlowThread::checkInvalidRegions):
* rendering/RenderNamedFlowThread.h:
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::overflowRectForFlowThreadPortion):
(WebCore::RenderRegion::isFirstRegion):
(WebCore::RenderRegion::isLastRegion):
(WebCore::RenderRegion::paintObject):
(WebCore::RenderRegion::nodeAtPoint):
(WebCore::RenderRegion::incrementAutoLogicalHeightCount):
(WebCore::RenderRegion::decrementAutoLogicalHeightCount):
(WebCore::RenderRegion::layoutBlock):
(WebCore::RenderRegion::repaintFlowThreadContentRectangle):
(WebCore::RenderRegion::attachRegion):
(WebCore::RenderRegion::renderBoxRegionInfo):
(WebCore::RenderRegion::setRenderBoxRegionInfo):
(WebCore::RenderRegion::logicalTopOfFlowThreadContentRect):
(WebCore::RenderRegion::logicalBottomOfFlowThreadContentRect):
(WebCore::RenderRegion::computePreferredLogicalWidths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
commit-queue@webkit.org [Thu, 28 Mar 2013 08:25:04 +0000 (08:25 +0000)]
[CMAKE] Build fix after r147052. Add WebKit2/Shared/Plugins to include path
https://bugs.webkit.org/show_bug.cgi?id=113484

Unreviewed build fix.

Add "WebKit2/Shared/Plugins" to include path for TestWebKitAPI, WebKitTestRunner.

Patch by Jaehun Lim <ljaehun.lim@samsung.com> on 2013-03-28

* TestWebKitAPI/CMakeLists.txt:
* WebKitTestRunner/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147081 268f45cc-cd09-0410-ab3c-d52691b4dbfc