WebKit-https.git
7 years agoUnreviewed, rolling out r123159, r123165, r123168, r123492,
commit-queue@webkit.org [Thu, 26 Jul 2012 18:50:48 +0000 (18:50 +0000)]
Unreviewed, rolling out r123159, r123165, r123168, r123492,
and r123650.
http://trac.webkit.org/changeset/123159
http://trac.webkit.org/changeset/123165
http://trac.webkit.org/changeset/123168
http://trac.webkit.org/changeset/123492
http://trac.webkit.org/changeset/123650
https://bugs.webkit.org/show_bug.cgi?id=92406

allowing inline-table anonymous wrappers is a bad idea due to
tons of corner cases that should be properly handled
(Requested by jchaffraix on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

* rendering/RenderInline.cpp:
(WebCore::RenderInline::addChildIgnoringContinuation):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::createAnonymousWithParentRenderer):

LayoutTests:

* css2.1/20110323/inline-table-002b-expected.htm: Removed.
* css2.1/20110323/inline-table-002b.html: Removed.
* fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
* fast/table/inline-block-generates-table-wrapper-expected.html: Removed.
* fast/table/inline-block-generates-table-wrapper.html: Removed.
* fast/table/inline-table-in-continuation-expected.html: Removed.
* fast/table/inline-table-in-continuation.html: Removed.
* fast/table/inline-table-with-caption-expected.html: Removed.
* fast/table/inline-table-with-caption.html: Removed.
* platform/chromium-linux/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-mac-snowleopard/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-mac/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-win/fast/dynamic/insert-before-table-part-in-continuation-expected.png:
* platform/chromium-win/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
* platform/chromium-win/tables/mozilla/bugs/bug3037-1-expected.txt:
* platform/efl/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
* platform/efl/tables/mozilla/bugs/bug3037-1-expected.txt: Renamed from LayoutTests/tables/mozilla/bugs/bug3037-1-expected.txt.
* platform/gtk/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Added.
* platform/gtk/tables/mozilla/bugs/bug3037-1-expected.txt:
* platform/mac-wk2/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
* platform/mac-wk2/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
* platform/mac-wk2/tables/mozilla/bugs/bug3037-1-expected.txt: Removed.
* platform/mac/fast/dynamic/insert-before-table-part-in-continuation-expected.txt:
* platform/mac/tables/mozilla/bugs/bug3037-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a ChromeClient method to send diagnostic logging messages from WebCore to the...
jer.noble@apple.com [Thu, 26 Jul 2012 18:45:46 +0000 (18:45 +0000)]
Add a ChromeClient method to send diagnostic logging messages from WebCore to the client.
https://bugs.webkit.org/show_bug.cgi?id=92340

Reviewed by Anders Carlsson.

Source/WebCore:

Add a new ChromeClient menthod, to be implemented by WebKit and WebKit2, which sends
a diagnostic logging message up to the client.

* page/ChromeClient.h:
(WebCore::ChromeClient::logDiagnosticMessage):
* page/ChromeClient.h:
(WebCore::ChromeClient::logDiagnosticMessage):
(ChromeClient):
* page/DiagnosticLoggingKeys.cpp: Added.
(WebCore::DiagnosticLoggingKeys::mediaLoadedKey):
(WebCore::DiagnosticLoggingKeys::mediaLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadedKey):
(WebCore::DiagnosticLoggingKeys::pluginLoadingFailedKey):
(WebCore::DiagnosticLoggingKeys::passKey):
(WebCore::DiagnosticLoggingKeys::failKey):
(WebCore::DiagnosticLoggingKeys::noopKey):
* page/DiagnosticLoggingKeys.h: Added.
(DiagnosticLoggingKeys):

Add the new files DiagnosticLoggingKeys.cpp,h to the project:
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

Pipe the ChromeClient logDiagnosticMessage() function through WebKit2 to a new bundle class
InjectedBundlePageDiagnosticLoggingClient, to be implemented by the client.

* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetDiagnosticLoggingClient): Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::logDiagnosticMessage):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleDiagnosticLoggingClient):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleDiagnosticLoggingClient):

Add a convenience class to retrieve the diagnostic message keys:
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.cpp: Added.
(WebKit::InjectedBundlePageDiagnosticLoggingClient::logDiagnosticMessage):
* WebProcess/InjectedBundle/InjectedBundlePageDiagnosticLoggingClient.h: Added.
(InjectedBundlePageDiagnosticLoggingClient):

Add the InjectedBundlePageDiagnosticLoggingClient.cpp,h files.
* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* win/WebKit2.vcproj:
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoexpectations change for skia rev. 4771
reed@google.com [Thu, 26 Jul 2012 18:27:02 +0000 (18:27 +0000)]
expectations change for skia rev. 4771
https://bugs.webkit.org/show_bug.cgi?id=92402

Reviewed by NOBODY : expectations change only

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[nrwt] get rid of --skip-pixel-test-if-no-baseline
kbalazs@webkit.org [Thu, 26 Jul 2012 18:26:41 +0000 (18:26 +0000)]
[nrwt] get rid of --skip-pixel-test-if-no-baseline
https://bugs.webkit.org/show_bug.cgi?id=92377

Reviewed by Adam Barth.

Remove the option and all code paths that handled it.

* Scripts/webkitpy/layout_tests/port/base.py:
(Port.should_run_as_pixel_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_repeat_each):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd setting to enable and disable diagnostic logging.
jer.noble@apple.com [Thu, 26 Jul 2012 18:26:32 +0000 (18:26 +0000)]
Add setting to enable and disable diagnostic logging.
https://bugs.webkit.org/show_bug.cgi?id=92337

Reviewed by Anders Carlsson.

Source/WebCore:

Add a new entry in Settings, defaulting to false.

* page/Settings.cpp:
(WebCore::Settings::Settings): Default the new setting to false.
* page/Settings.h:
(WebCore::Settings::setDiagnosticLoggingEnabled): Simple accessor.
(WebCore::Settings::diagnosticLoggingEnabled): Ditto.

Source/WebKit/mac:

Add a WebKit WebPreferences API to set set the WebCore diagnosticLoggingEnabled setting.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Register the default value to false.
(-[WebPreferences diagnosticLoggingEnabled]): Simple userDefaults accessor.
(-[WebPreferences setDiagnosticLoggingEnabled:]): Ditto.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Ensure this preference is propagated to Settings
    whenever the preferences change.

Source/WebKit2:

Add a WebKit2 WKPreferences API to set set the WebCore diagnosticLoggingEnabled setting.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetDiagnosticLoggingEnabled):
(WKPreferencesGetDiagnosticLoggingEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Ensure this preference is propagated to Settings
    whenever the preferences change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Regression(r123731): Linking errors due to efreet functions
commit-queue@webkit.org [Thu, 26 Jul 2012 18:18:09 +0000 (18:18 +0000)]
[EFL][WK2] Regression(r123731): Linking errors due to efreet functions
https://bugs.webkit.org/show_bug.cgi?id=92378

Unreviewed build fix.

The library list created by PlatformEfl.cmake was being erased by a
SET called after including the platform specific file. Luckily the
dependencies were fulfilled by other targets until efreet was add.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-26

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd FastMalloc statistics in window.internals
commit-queue@webkit.org [Thu, 26 Jul 2012 18:16:54 +0000 (18:16 +0000)]
Add FastMalloc statistics in window.internals
https://bugs.webkit.org/show_bug.cgi?id=91274

Patch by Olivier Blin <olivier.blin@softathome.com> on 2012-07-26
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/harness/fastmallocstatistics-object.html

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.vcproj/WebCoreTestSupport.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* testing/FastMallocStatistics.h: Added.
(WebCore):
(FastMallocStatistics):
(WebCore::FastMallocStatistics::create):
(WebCore::FastMallocStatistics::reservedVMBytes):
(WebCore::FastMallocStatistics::committedVMBytes):
(WebCore::FastMallocStatistics::freeListBytes):
(WebCore::FastMallocStatistics::FastMallocStatistics):
* testing/FastMallocStatistics.idl: Added.
* testing/Internals.cpp:
(WebCore::Internals::fastMallocStatistics):
(WebCore):
* testing/Internals.h:
(WebCore):
(Internals):
* testing/Internals.idl:

Tools:

* GNUmakefile.am:

LayoutTests:

* fast/harness/fastmallocstatistics-object-expected.txt: Added.
* fast/harness/fastmallocstatistics-object.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [chromium] Remove redundant surface origin transforms
enne@google.com [Thu, 26 Jul 2012 18:02:42 +0000 (18:02 +0000)]
Source/WebCore: [chromium] Remove redundant surface origin transforms
https://bugs.webkit.org/show_bug.cgi?id=91815

Reviewed by Stephen White.

Bug 91417 changed draw transforms to become equivalent to origin
transforms for surfaces. This change removes them as they are no
longer needed for anything.

No new tests. Just a refactoring.

* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::leaveToRenderTarget):
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit2: [EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
https://bugs.webkit.org/show_bug.cgi?id=92387

Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in EWK2UnitTestServer.cpp.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
(EWK2UnitTestServer::EWK2UnitTestServer):

LayoutTests: [Qt] css3/filters, editing/undo, fast/block/lineboxcontain, fast/js and tables/layering tests need update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92292

Reviewed by Alexis Menard.

* platform/qt-5.0/Skipped:
* platform/qt/css3/filters/effect-blur-expected.txt:
* platform/qt/css3/filters/effect-blur-hw-expected.txt:
* platform/qt/css3/filters/regions-expanding-expected.txt:
* platform/qt/editing/undo/5378473-expected.txt:
* platform/qt/editing/undo/undo-misspellings-expected.txt:
* platform/qt/fast/block/lineboxcontain/inline-box-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-box-expected.txt:
* platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-box-vertical-expected.txt:
* platform/qt/fast/block/lineboxcontain/inline-replaced-expected.png:
* platform/qt/fast/block/lineboxcontain/inline-replaced-expected.txt:
* platform/qt/fast/block/lineboxcontain/none-expected.png:
* platform/qt/fast/block/lineboxcontain/none-expected.txt:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.png:
* platform/qt/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/qt/fast/block/lineboxcontain/replaced-expected.png:
* platform/qt/fast/block/lineboxcontain/replaced-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove redundant surface origin transforms
enne@google.com [Thu, 26 Jul 2012 17:59:59 +0000 (17:59 +0000)]
[chromium] Remove redundant surface origin transforms
https://bugs.webkit.org/show_bug.cgi?id=91815

Reviewed by Stephen White.

Source/WebCore:

Bug 91417 changed draw transforms to become equivalent to origin
transforms for surfaces. This change removes them as they are no
longer needed for anything.

No new tests. Just a refactoring.

* platform/graphics/chromium/RenderSurfaceChromium.h:
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCDamageTracker.cpp:
(WebCore::CCDamageTracker::extendDamageForRenderSurface):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::computeScrollCompensationMatrixForChildren):
(WebCore::calculateDrawTransformsInternal):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::leaveToRenderTarget):
(WebCore::::unoccludedContributingSurfaceContentRect):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.cpp:
(WebCore::CCRenderPassDrawQuad::create):
(WebCore::CCRenderPassDrawQuad::CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderPassDrawQuad.h:
(CCRenderPassDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::createSharedQuadState):
(WebCore::CCRenderSurface::createReplicaSharedQuadState):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(CCRenderSurface):

Source/WebKit/chromium:

Clean up use of origin transforms in tests. Where possible, test
against the equivalent draw transform.

* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
* tests/CCRenderSurfaceTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: simplify handling of status bar items
caseq@chromium.org [Thu, 26 Jul 2012 17:55:35 +0000 (17:55 +0000)]
Web Inspector: simplify handling of status bar items
https://bugs.webkit.org/show_bug.cgi?id=92143

Reviewed by Pavel Feldman.

- split status bars into "global" (always in the bottom) and "panel"
    (on top of the drawer when drawer is shown)
- use "inner" status bar section in global status bar to display either
    panel status bar items or drawer view items (depending on drawer visibility)
- let panels/views manage their counters as part of their status bar
    items, not through special interface members;
- get rid of absolute positioning in the status bars where possible;

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView.prototype.get statusBarItems):
* inspector/front-end/Drawer.js:
(WebInspector.Drawer):
(WebInspector.Drawer.prototype.show.animationFinished):
(WebInspector.Drawer.prototype.show):
(WebInspector.Drawer.prototype.hide.animationFinished):
(WebInspector.Drawer.prototype.hide):
(WebInspector.Drawer.prototype._startStatusBarDragging):
* inspector/front-end/Panel.js:
(WebInspector.Panel.prototype.wasShown):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype.get statusBarItems):
(WebInspector.TimelinePanel.prototype.willHide):
* inspector/front-end/elementsPanel.css:
(.crumbs):
* inspector/front-end/inspector.css:
(#main):
(body.drawer-visible #main-panels):
(.status-bar):
(.status-bar-item):
(#panel-status-bar-placeholder):
(body.drawer-visible #panel-status-bar-placeholder):
(#panel-status-bar-resizer):
(#panel-status-bar):
(#panel-status-bar > div):
(#error-warning-count):
(#drawer):
(#drawer-contents):
(.status-bar-items):
(.drawer-header):
(#inner-status-bar):
(.search-status-bar-item):
(.search-status-bar-message):
(.search-status-bar-progress):
(body:not(.platform-mac) .search-status-bar-progress):
(body.platform-mac .search-status-bar-progress):
(.search-status-bar-stop-button-item):
(.search-status-bar-stop-button .glyph):
(.search-results-status-bar-message):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector.showViewInDrawer):
(WebInspector._closePreviousDrawerView):
* inspector/front-end/timelinePanel.css:
(.timeline-records-counter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Implement Network Information provider
commit-queue@webkit.org [Thu, 26 Jul 2012 17:47:18 +0000 (17:47 +0000)]
[EFL][WK2] Implement Network Information provider
https://bugs.webkit.org/show_bug.cgi?id=92343

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Moved Network Information provider code from WebKit1
to WebCore so that it can be shared with WebKit2.

No new tests, no behavior change.

* PlatformEfl.cmake:
* platform/efl/NetworkInfoProviderEfl.cpp: Copied from Source/WebKit/efl/WebCoreSupport/NetworkInfoClientEfl.cpp.
(WebCore):
(WebCore::NetworkInfoProviderEfl::NetworkInfoProviderEfl):
(WebCore::NetworkInfoProviderEfl::startUpdating):
(WebCore::NetworkInfoProviderEfl::stopUpdating):
(WebCore::NetworkInfoProviderEfl::bandwidth):
* platform/efl/NetworkInfoProviderEfl.h: Added.
(WebCore):
(NetworkInfoProviderEfl):

Source/WebKit:

WebKit EFL not longer needs to link against EEZE
library since the Network Information provider
was moved to WebCore.

* CMakeLists.txt:
* PlatformEfl.cmake:

Source/WebKit/efl:

Make NetworkInfoClientEfl use NetworkInfoProviderEfl
from WebCore to avoid code duplication with WebKit2.

* WebCoreSupport/NetworkInfoClientEfl.cpp:
(WebCore::NetworkInfoClientEfl::startUpdating):
(WebCore::NetworkInfoClientEfl::stopUpdating):
(WebCore::NetworkInfoClientEfl::bandwidth):
(WebCore::NetworkInfoClientEfl::metered):
(WebCore):
* WebCoreSupport/NetworkInfoClientEfl.h:
(WebCore):
(NetworkInfoClientEfl):

Source/WebKit2:

Add Network Information provider for WebKit2 EFL
by using NetworkInfoProviderEfl class from
WebCore.

* CMakeLists.txt:
* PlatformEfl.cmake:
* UIProcess/API/efl/NetworkInfoProvider.cpp: Added.
(toNetworkInfoProvider):
(startUpdatingCallback):
(stopUpdatingCallback):
(getBandwidthCallback):
(isMeteredCallback):
(NetworkInfoProvider::create):
(NetworkInfoProvider::NetworkInfoProvider):
(NetworkInfoProvider::~NetworkInfoProvider):
(NetworkInfoProvider::bandwidth):
(NetworkInfoProvider::metered):
(NetworkInfoProvider::startUpdating):
(NetworkInfoProvider::stopUpdating):
* UIProcess/API/efl/NetworkInfoProvider.h: Added.
(NetworkInfoProvider):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: SASS source mapping straw man (behind experiment)
pfeldman@chromium.org [Thu, 26 Jul 2012 17:25:00 +0000 (17:25 +0000)]
Web Inspector: SASS source mapping straw man (behind experiment)
https://bugs.webkit.org/show_bug.cgi?id=92265

Reviewed by Vsevolod Vlasov.

This change introduces SASS mapping support (behind the experiment).

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype.resourceBinding):
(WebInspector.CSSStyleModel.prototype.setSourceMapping):
(WebInspector.CSSStyleModel.prototype.resetSourceMappings):
(WebInspector.CSSStyleModel.prototype._rawLocationToUILocation):
(WebInspector.CSSLocation):
(WebInspector.CSSRule):
(WebInspector.CSSRule.prototype.get isRegular):
(WebInspector.CSSRule.prototype.uiLocation):
* inspector/front-end/ContentProviders.js:
(WebInspector.StaticContentProvider.prototype.contentType):
* inspector/front-end/SASSSourceMapping.js: Added.
(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._populate):
(WebInspector.SASSSourceMapping.prototype._resourceAdded.didRequestContent):
(WebInspector.SASSSourceMapping.prototype._resourceAdded):
(rawLocationToUILocation):
(uiLocationToRawLocation):
(uiSourceCodes):
(reset):
(WebInspector.SASSSource):
(WebInspector.SASSSource.prototype.isEditable):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._createSourceFrame):
* inspector/front-end/Settings.js:
(WebInspector.ExperimentsSettings):
* inspector/front-end/StylesPanel.js:
(WebInspector.StylesUISourceCodeProvider):
(WebInspector.StylesUISourceCodeProvider.prototype.rawLocationToUILocation):
(WebInspector.StylesUISourceCodeProvider.prototype.uiLocationToRawLocation):
(WebInspector.StylesUISourceCodeProvider.prototype._resourceAdded):
(WebInspector.StylesUISourceCodeProvider.prototype.reset):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertyTreeElement.prototype):
* inspector/front-end/UISourceCode.js:
(WebInspector.UILocation.prototype.uiLocationToRawLocation):
(WebInspector.UILocation.prototype.url):
* inspector/front-end/Workspace.js:
(WebInspector.Workspace):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit should expose @title as label (AXTitle or AXDescription) sometimes instead...
cfleizach@apple.com [Thu, 26 Jul 2012 17:23:20 +0000 (17:23 +0000)]
WebKit should expose @title as label (AXTitle or AXDescription) sometimes instead of AXHelp, according to the ARIA text alt computation
https://bugs.webkit.org/show_bug.cgi?id=91911

Reviewed by Anders Carlsson.

Source/WebCore:

The ARIA spec states that the title attribute should be used as the last resort for a description of an element. WebKit needs to honor that.

Test: platform/mac/accessibility/title-attribute-used-as-last-resort.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::helpText):
(WebCore::AccessibilityRenderObject::accessibilityDescription):

LayoutTests:

* platform/mac/accessibility/title-attribute-used-as-last-resort-expected.txt: Added.
* platform/mac/accessibility/title-attribute-used-as-last-resort.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
commit-queue@webkit.org [Thu, 26 Jul 2012 16:59:07 +0000 (16:59 +0000)]
[EFL][WK2] Compilation warning in EWK2UnitTestServer.cpp
https://bugs.webkit.org/show_bug.cgi?id=92387

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Fix compilation warning in EWK2UnitTestServer.cpp.

* UIProcess/API/efl/tests/UnitTestUtils/EWK2UnitTestServer.cpp:
(EWK2UnitTestServer::EWK2UnitTestServer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed r123761 follow-up, inspector closure compilation fix.
vsevik@chromium.org [Thu, 26 Jul 2012 16:54:44 +0000 (16:54 +0000)]
Unreviewed r123761 follow-up, inspector closure compilation fix.

* inspector/front-end/Script.js:
(WebInspector.Script.Location.prototype.uiLocation):
* inspector/front-end/ScriptSnippetModel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup GraphicsContext::(getWindowsContext|releaseWindowsContext)
paroga@webkit.org [Thu, 26 Jul 2012 16:50:44 +0000 (16:50 +0000)]
Cleanup GraphicsContext::(getWindowsContext|releaseWindowsContext)
https://bugs.webkit.org/show_bug.cgi?id=92113

Reviewed by Simon Hausmann.

Cleanup the definition of the two methods across different ports and
replace the calls to them with LocalWindowsContext where possible.

* platform/graphics/GraphicsContext.h:
(GraphicsContext):
* platform/win/ScrollbarThemeWin.cpp:
(WebCore::ScrollbarThemeWin::paintThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Fix after r123733.
kbalazs@webkit.org [Thu, 26 Jul 2012 16:45:07 +0000 (16:45 +0000)]
[Qt] Unreviewed gardening. Fix after r123733.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-26

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Reskip fast/forms WK2 added results
commit-queue@webkit.org [Thu, 26 Jul 2012 16:44:11 +0000 (16:44 +0000)]
[Qt] Reskip fast/forms WK2 added results
https://bugs.webkit.org/show_bug.cgi?id=91504

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-26
Reviewed by Alexis Menard.

This patch reverts the added WK2 layout test results from r123156 "[Qt]
Added/updated missing fast/forms results after rebaseline". As discussed with
Caio, almost all of these additions were due to an erroneous input-text and
text-area default size diff between WK1 and WK2 (handled in bug 91990), and a
few ones that are still failing independent of font changes (handled in bug
91610). These tests were reskipped and reassigned to proper bugs.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/forms/basic-inputs-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/basic-inputs-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/basic-textareas-quirks-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/basic-textareas-quirks-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/control-restrict-line-height-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/control-restrict-line-height-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/encoding-test-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/fieldset-align-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/fieldset-align-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-bkcolor-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-default-bkcolor-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-disabled-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-disabled-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-focus-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-focus-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-preventDefault-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-readonly-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-readonly-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-selection-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-selection-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-appearance-visibility-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-baseline-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-baseline-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-double-click-selection-gap-bug-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/input-double-click-selection-gap-bug-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-placeholder-visibility-1-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-placeholder-visibility-3-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-readonly-dimmed-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-readonly-empty-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-spaces-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-click-inside-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-double-click-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-option-delete-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-self-emptying-click-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-text-word-wrap-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/input-width-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/placeholder-position-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/placeholder-position-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/search-cancel-button-style-sharing-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/search-display-none-cancel-button-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/search-rtl-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/search-rtl-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/search-vertical-alignment-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/search-vertical-alignment-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/text-style-color-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/text-style-color-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-placeholder-pseudo-style-expected.png: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-placeholder-pseudo-style-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-placeholder-visibility-1-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textarea-placeholder-visibility-2-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textfield-focus-ring-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textfield-outline-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/forms/textfield-overflow-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Introduce generic LiveLocation, make Script.Location inherit it.
vsevik@chromium.org [Thu, 26 Jul 2012 16:42:27 +0000 (16:42 +0000)]
Web Inspector: Introduce generic LiveLocation, make Script.Location inherit it.
https://bugs.webkit.org/show_bug.cgi?id=92388

Reviewed by Pavel Feldman.

Introduced abstract LiveLocation implemented by Script.Location.

* inspector/front-end/Script.js:
(WebInspector.Script.Location):
(WebInspector.Script.Location.prototype.uiLocation):
(WebInspector.Script.Location.prototype.dispose):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.LiveLocation):
(WebInspector.LiveLocation.prototype.update):
(WebInspector.LiveLocation.prototype.rawLocation):
(WebInspector.LiveLocation.prototype.uiLocation):
(WebInspector.LiveLocation.prototype.dispose):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] platform/qt/tables/mozilla tests needs update after rebaseline and new testfonts
rafael.lobo@openbossa.org [Thu, 26 Jul 2012 16:40:49 +0000 (16:40 +0000)]
[Qt] platform/qt/tables/mozilla tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=91242

Reviewed by Alexis Menard.

Some leftovers were removed from qt-5.0-wk1 and wk2. If some of them
fail on qt-5.0-wk2, then they should be skipped again, but creating
proper bug reports for them.

* platform/qt-5.0-wk1/Skipped:
* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.png: Removed.
* platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] readPixels on FBOs are limited to canvas size on SGX platforms
commit-queue@webkit.org [Thu, 26 Jul 2012 16:34:29 +0000 (16:34 +0000)]
[BlackBerry] readPixels on FBOs are limited to canvas size on SGX platforms
https://bugs.webkit.org/show_bug.cgi?id=92301

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-26
Reviewed by Rob Buis.

This fixes fast/canvas/webgl/uninitialized-test.html on BlackBerry, no new tests.

* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):
(WebCore::GraphicsContext3D::readPixelsAndConvertToBGRAIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: reduce auto refresh rate of the live native memory diagram
commit-queue@webkit.org [Thu, 26 Jul 2012 16:26:46 +0000 (16:26 +0000)]
Web Inspector: reduce auto refresh rate of the live native memory diagram
https://bugs.webkit.org/show_bug.cgi?id=92372

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-26
Reviewed by Pavel Feldman.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemoryBarChart.prototype.wasShown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agobuildbot: Remove the configuration of hfreyther*
zecke@webkit.org [Thu, 26 Jul 2012 16:23:41 +0000 (16:23 +0000)]
buildbot: Remove the configuration of hfreyther*
https://bugs.webkit.org/show_bug.cgi?id=91849

Reviewed by Adam Roben.

The machine running these configs was decommissioned and
there is no replacement at this point. Remove them from the
configuration.

* BuildSlaveSupport/build.webkit.org-config/config.json: Remove hfreyther* from
the config. The Qt Linux SH4 and Qt Linux MIPS schedulers are orphaned, remove
them too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Refactor BackingStorePrivate::BackingStorePrivate::clearAndUpdateTileOfN...
commit-queue@webkit.org [Thu, 26 Jul 2012 16:22:25 +0000 (16:22 +0000)]
[BlackBerry] Refactor BackingStorePrivate::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion() to avoid touching tile frontbuffer
https://bugs.webkit.org/show_bug.cgi?id=92095

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-26
Reviewed by George Staikos.

PR: 141439
Specifically, we want to avoid changing the rendered region of the
front buffer without proper synchronization.

The method is trying to force checkerboard to appear on screen because
an area was invalidated but the render job was dropped, so the tile
contents are now invalid.

Unfortunately it did this in a way which is not thread safe. Fixed by
making it thread safe, in a way that minimizes memory bandwidth usage.

Instead of using the customary sequence of copy-back, modify and swap,
we send a synchronous message to the compositing thread to avoid the
copy-back step and save memory bandwidth. The trade-off is that the
WebKit thread might wait a little longer for the compositing thread
than it would from a waitForCurrentMessage() call.

The way we synchronize this is rather expensive for the WebKit thread,
and this method is called rather carelessly, so add various early
returns to avoid doing it redundantly.

Internally reviewed by Jakob Petsovits and Adam Treat.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::indexOfTile):
(BlackBerry::WebKit::BackingStorePrivate::clearAndUpdateTileOfNotRenderedRegion):
* Api/BackingStore_p.h:
(BackingStorePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add GC button to the profiles panel toolbar.
commit-queue@webkit.org [Thu, 26 Jul 2012 16:17:21 +0000 (16:17 +0000)]
Web Inspector: add GC button to the profiles panel toolbar.
https://bugs.webkit.org/show_bug.cgi?id=92369

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-26
Reviewed by Pavel Feldman.

* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfilesPanel.prototype.get statusBarItems):
(WebInspector.ProfilesPanel.prototype._garbageCollectButtonClicked):
* inspector/front-end/profilesPanel.css:
(.garbage-collect-status-bar-item .glyph):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove region from HitTestResult to HitTestPoint.
allan.jensen@nokia.com [Thu, 26 Jul 2012 16:15:27 +0000 (16:15 +0000)]
Move region from HitTestResult to HitTestPoint.
https://bugs.webkit.org/show_bug.cgi?id=92367

Reviewed by Antonio Gomes.

Moves the region to HitTestPoint where it makes more sense, and use this
change to simplify hit-testing a new region in RenderFlowThread.

No new functionality. No new tests.

* rendering/HitTestResult.cpp:
(WebCore::HitTestPoint::HitTestPoint):
(WebCore::HitTestPoint::operator=):
(WebCore::HitTestResult::HitTestResult):
(WebCore::HitTestResult::operator=):
* rendering/HitTestResult.h:
(HitTestPoint):
(WebCore::HitTestPoint::region):
(HitTestResult):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::nodeAtPoint):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::hitTestRegion):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestLayer):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::nodeAtPoint):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::nodeAtPoint):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::nodeAtPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: ExtensionView constructor shouldn't take parent argument
commit-queue@webkit.org [Thu, 26 Jul 2012 16:12:32 +0000 (16:12 +0000)]
Web Inspector: ExtensionView constructor shouldn't take parent argument
https://bugs.webkit.org/show_bug.cgi?id=92326

Patch by Jan Keromnes <janx@linux.com> on 2012-07-26
Reviewed by Pavel Feldman.

ExtensionView's constructor took a parent element parameter and auto-
showed itself in the constructor. This didn't allow lazy showing and
was confusing because it didn't work like a classic View object. Fixed.

No new tests needed: Refactoring with no behavior changes.

* inspector/front-end/ExtensionPanel.js:
(WebInspector.ExtensionPanel):
(WebInspector.ExtensionSidebarPane.prototype.setPage):
* inspector/front-end/ExtensionView.js:
(WebInspector.ExtensionView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add unit tests for Ewk_Context
commit-queue@webkit.org [Thu, 26 Jul 2012 16:04:20 +0000 (16:04 +0000)]
[EFL][WK2] Add unit tests for Ewk_Context
https://bugs.webkit.org/show_bug.cgi?id=92005

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Antonio Gomes.

Add unit tests for WebKit2 Ewk_Context.

* PlatformEfl.cmake:
* UIProcess/API/efl/ewk_url_scheme_request.cpp:
(ewk_url_scheme_request_finish):
* UIProcess/API/efl/ewk_url_scheme_request.h: Mark content_data
argument as const.
* UIProcess/API/efl/tests/test_ewk2_context.cpp: Added.
(TEST_F):
(schemeRequestCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Refactor BackingStorePrivate::render() to avoid touching tile frontbuffer
commit-queue@webkit.org [Thu, 26 Jul 2012 16:00:16 +0000 (16:00 +0000)]
[BlackBerry] Refactor BackingStorePrivate::render() to avoid touching tile frontbuffer
https://bugs.webkit.org/show_bug.cgi?id=91989

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-26
Reviewed by George Staikos.

PR: 141439
Specifically, we want to avoid changing the rendered region of the
front buffer. The code only touched the front buffer rendered region
if the tile was not committed.

Instead of immediately marking the tile as committed, and clearing the
front buffer's rendered region to make it appear as checkerboard, we
leave the front buffer alone and only mark the tile as committed once
the front buffer has valid content. Un-committed tiles will also be
rendered as checkerboard, so leaving it uncommitted is equivalent to
clearing the front buffer rendered region here.

In addition to the main change, some related changes follow naturally.

The copyPreviousContentsToBackSurfaceOfTile() call only makes sense if
the tile is committed, and the front buffer has valid content.
Otherwise, clearing the back buffer is equivalent. The code has been
updated to this effect.

Since copyPreviousContentsToBackSurfaceOfTile() always sets the
rendered region to the union of the front and back buffer regions,
there is no point in the "backBufferIsValid" check. It has been turned
into an ASSERT instead, just to make sure.

Internally reviewed by Jakob Petsovits.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] editing/selection tests needs update after rebaseline and new testfonts
commit-queue@webkit.org [Thu, 26 Jul 2012 15:51:45 +0000 (15:51 +0000)]
[Qt] editing/selection tests needs update after rebaseline and new testfonts
https://bugs.webkit.org/show_bug.cgi?id=92186

Patch by Bruno de Oliveira Abinader <bruno.abinader@basyskom.com> on 2012-07-26
Reviewed by Alexis Menard.

After the rebaseline from changeset 121971 - [Qt] DumpRenderTree does not use
'monospace' font when directed, editing/selection tests directory needs to be
updated.

It is important to notice some Qt WK2 layout tests are still failing, some
requires more investigation (handled in bug 91610) and others have a known cause
(input text and text areas differ in WK2 - bug 91990).

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/editing/selection/select-box-expected.png:
* platform/qt-5.0-wk2/editing/selection/select-box-expected.txt:
* platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/qt-5.0-wk2/editing/selection/select-element-paragraph-boundary-expected.txt:
* platform/qt-5.0/Skipped:
* platform/qt-5.0/editing/selection/editable-html-element-expected.txt:
* platform/qt-5.0/editing/selection/extend-by-word-001-expected.txt:
* platform/qt-5.0/editing/selection/select-box-expected.png:
* platform/qt-5.0/editing/selection/select-box-expected.txt:
* platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/qt-5.0/editing/selection/select-element-paragraph-boundary-expected.txt:
* platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-backward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-lr-ltr-extend-line-forward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-p-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-backward-wrap-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-p-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-ltr-extend-line-forward-wrap-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-br-expected.txt:
* platform/qt-5.0/editing/selection/vertical-rl-rtl-extend-line-backward-p-expected.txt:
* platform/qt/editing/selection/5825350-1-expected.txt:
* platform/qt/editing/selection/5825350-2-expected.txt:
* platform/qt/editing/selection/drag-start-event-client-x-y-expected.txt:
* platform/qt/editing/selection/fake-doubleclick-expected.png:
* platform/qt/editing/selection/fake-doubleclick-expected.txt:
* platform/qt/editing/selection/hit-test-on-text-with-line-height-expected.txt:
* platform/qt/editing/selection/unrendered-001-expected.png:
* platform/qt/editing/selection/unrendered-001-expected.txt:
* platform/qt/editing/selection/unrendered-002-expected.png:
* platform/qt/editing/selection/unrendered-002-expected.txt:
* platform/qt/editing/selection/unrendered-003-expected.png:
* platform/qt/editing/selection/unrendered-003-expected.txt:
* platform/qt/editing/selection/unrendered-004-expected.png:
* platform/qt/editing/selection/unrendered-004-expected.txt:
* platform/qt/editing/selection/unrendered-005-expected.png:
* platform/qt/editing/selection/unrendered-005-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebGL] ANGLEWebKitBridge should support ESSL platforms
commit-queue@webkit.org [Thu, 26 Jul 2012 15:25:47 +0000 (15:25 +0000)]
[WebGL] ANGLEWebKitBridge should support ESSL platforms
https://bugs.webkit.org/show_bug.cgi?id=92295

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-26
Reviewed by Rob Buis.

This tells ANGLEWebKitBridge to output ESSL code for the BlackBerry
platform. This eliminates the need for a previous hack. In addition,
some (GLSL) ANGLE output that could not be compiled (for example,
glsl-mat4-to-mat3.html) now compiles.

* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::GraphicsContext3D):
* platform/graphics/opengl/Extensions3DOpenGLCommon.cpp:
(WebCore::Extensions3DOpenGLCommon::getTranslatedShaderSourceANGLE):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: replace "textInput" keyboard event listener breakpoint with "input"
pfeldman@chromium.org [Thu, 26 Jul 2012 15:21:58 +0000 (15:21 +0000)]
Web Inspector: replace "textInput" keyboard event listener breakpoint with "input"
https://bugs.webkit.org/show_bug.cgi?id=92384

Reviewed by Vsevolod Vlasov.

* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.EventListenerBreakpointsSidebarPane):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a MediaPlayer API to retrieve the description of the current media engine.
jer.noble@apple.com [Thu, 26 Jul 2012 15:10:00 +0000 (15:10 +0000)]
Add a MediaPlayer API to retrieve the description of the current media engine.
https://bugs.webkit.org/show_bug.cgi?id=92336

Reviewed by Eric Carlson.

Add a utility function which retrieves, for diagnostic purposes, a brief description
of the current media engine. Stubs have been added for each of the MediaPlayerPrivate
subclasses which return the name of the class.

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::engineDescription):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(WebCore::MediaPlayerPrivateInterface::engineDescription):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(WebCore::MediaPlayerPrivateAVFoundation::engineDescription):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(WebCore::MediaPlayerPrivate::engineDescription):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(WebCore::MediaPlayerPrivateGStreamer::engineDescription):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(WebCore::MediaPlayerPrivateQTKit::engineDescription):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(WebCore::MediaPlayerPrivateQt::engineDescription):
* platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(WebCore::MediaPlayerPrivate::engineDescription):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::engineDescription):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Edits of styles declared after invalid selector are not applied
pfeldman@chromium.org [Thu, 26 Jul 2012 15:08:14 +0000 (15:08 +0000)]
Web Inspector: Edits of styles declared after invalid selector are not applied
https://bugs.webkit.org/show_bug.cgi?id=92382

Reviewed by Vsevolod Vlasov.

Source/WebCore:

Now popping selectorless rules as well.

Test: inspector/styles/styles-edit-property-after-invalid-rule.html

* css/CSSParser.cpp:
(WebCore::CSSParser::createStyleRule):

LayoutTests:

Additional information of the change such as approach, rationale.

* inspector/styles/styles-edit-property-after-invalid-rule-expected.txt: Added.
* inspector/styles/styles-edit-property-after-invalid-rule.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebGL] GraphicsContext3D::readPixels has extraneous code from GraphicsContext3D...
commit-queue@webkit.org [Thu, 26 Jul 2012 14:54:23 +0000 (14:54 +0000)]
[WebGL] GraphicsContext3D::readPixels has extraneous code from GraphicsContext3D::readPixelsIMG
https://bugs.webkit.org/show_bug.cgi?id=92302

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-26
Reviewed by Noam Rosenthal.

This undoes a mistake from https://bugs.webkit.org/show_bug.cgi?id=90567.

No new tests, because it introduces no new functionality, but it makes the WebGL aquarium demo
run quite a bit smoother on SGX :)

* platform/graphics/opengl/GraphicsContext3DOpenGLES.cpp:
(WebCore::GraphicsContext3D::readPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Revert r123740 as it breaks AppleMac compilation.
yurys@chromium.org [Thu, 26 Jul 2012 14:49:36 +0000 (14:49 +0000)]
Unreviewed. Revert r123740 as it breaks AppleMac compilation.

Source/WebCore:

* WebCore.exp.in:
* inspector/InspectorMemoryAgent.cpp:
(WebCore):

Source/WTF:

* wtf/text/StringImpl.cpp:
* wtf/text/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix AppleMac compilation after r123740.
yurys@chromium.org [Thu, 26 Jul 2012 14:40:08 +0000 (14:40 +0000)]
Unreviewed. Fix AppleMac compilation after r123740.

* WebCore.exp.in: Added missing symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add form client for Ewk_View
commit-queue@webkit.org [Thu, 26 Jul 2012 13:28:25 +0000 (13:28 +0000)]
[EFL][WK2] Add form client for Ewk_View
https://bugs.webkit.org/show_bug.cgi?id=92358

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Implement a form client for EFL port in order to
send a "form,request,new" signal on the Ewk_View
whenever a form will be submitted.

The Ewk_Form_Submission_Request type is
introduced to provide the client with information
about the form (e.g. text fields contained in the
form) and to submit it.

This is typically used to store login information
that can be used later to pre-fill the form.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_form_submission_request.cpp: Added.
(_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::_Ewk_Form_Submission_Request):
(_Ewk_Form_Submission_Request::~_Ewk_Form_Submission_Request):
(ewk_form_submission_request_ref):
(ewk_form_submission_request_unref):
(ewk_form_submission_request_field_names_get):
(ewk_form_submission_request_field_value_get):
(ewk_form_submission_request_submit):
(ewk_form_submission_request_new):
* UIProcess/API/efl/ewk_form_submission_request.h: Added.
* UIProcess/API/efl/ewk_form_submission_request_private.h: Added.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
(ewk_view_form_submission_request_new):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_form_client.cpp: Added.
(willSubmitForm):
(ewk_view_form_client_attach):
* UIProcess/API/efl/ewk_view_form_client_private.h: Added.
* UIProcess/API/efl/ewk_view_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Added Qt5 specific expected results after r123670.
kkristof@inf.u-szeged.hu [Thu, 26 Jul 2012 13:20:40 +0000 (13:20 +0000)]
[Qt] Unreviewed gardening. Added Qt5 specific expected results after r123670.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-26

* platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.png: Added after r123670.
* platform/qt-5.0/tables/mozilla/bugs/bug3037-1-expected.txt: Added after r123670.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move StringImpl size calculation to StringImpl
yurys@chromium.org [Thu, 26 Jul 2012 13:17:51 +0000 (13:17 +0000)]
Web Inspector: move StringImpl size calculation to StringImpl
https://bugs.webkit.org/show_bug.cgi?id=92359

Reviewed by Pavel Feldman.

Moved stringSize(StringImpl*) implementation from InspectorMemoryAgent to
StringImpl::sizeInBytes();

Source/WebCore:

* inspector/InspectorMemoryAgent.cpp:
(WebCore):

Source/WTF:

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::sizeInBytes):
(WTF):
* wtf/text/StringImpl.h:
(StringImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r123696
commit-queue@webkit.org [Thu, 26 Jul 2012 13:03:33 +0000 (13:03 +0000)]
[EFL] Gardening after r123696
https://bugs.webkit.org/show_bug.cgi?id=92361

Unreviewed gardening. r123696 made css3/flexbox tests failing on EFL and QT.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-26

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed speculative Mac buildfix after r123729 - 2nd attempt.
kbalazs@webkit.org [Thu, 26 Jul 2012 12:43:29 +0000 (12:43 +0000)]
Unreviewed speculative Mac buildfix after r123729 - 2nd attempt.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, adding text failure expectations for two
zandobersek@gmail.com [Thu, 26 Jul 2012 12:38:26 +0000 (12:38 +0000)]
Unreviewed GTK gardening, adding text failure expectations for two
CSS3 Flexbox tests introduced in r123696.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed speculative buildfix after r123729.
kbalazs@webkit.org [Thu, 26 Jul 2012 12:32:36 +0000 (12:32 +0000)]
Unreviewed speculative buildfix after r123729.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::runTest): Fix sign errors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][ARM]ARMAssembler needs buildfix afert r123417
zherczeg@webkit.org [Thu, 26 Jul 2012 12:29:10 +0000 (12:29 +0000)]
[Qt][ARM]ARMAssembler needs buildfix afert r123417
https://bugs.webkit.org/show_bug.cgi?id=92086

Reviewed by Csaba Osztrogonác.

The ARM implementation of this should be optimized code path
is covered by a non-optimized code path. This patch fixes this,
and adds a new function which returns with the offset range.

* assembler/ARMAssembler.h:
(JSC::ARMAssembler::readPointer):
(ARMAssembler):
(JSC::ARMAssembler::repatchInt32):
(JSC::ARMAssembler::repatchCompact):
* assembler/MacroAssemblerARM.h:
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::isCompactPtrAlignedAddressOffset):
(JSC::MacroAssemblerARM::load32WithCompactAddressOffsetPatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove redundant include of PageGroup.h in FrameLoader.cpp
charles.wei@torchmobile.com.cn [Thu, 26 Jul 2012 12:21:09 +0000 (12:21 +0000)]
Remove redundant include of PageGroup.h in FrameLoader.cpp
https://bugs.webkit.org/show_bug.cgi?id=92357

Reviewed by Kentaro Hara.

No new tests, just remove redundant include file.

* loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip a failing tests.
kkristof@inf.u-szeged.hu [Thu, 26 Jul 2012 12:11:17 +0000 (12:11 +0000)]
[Qt] Unreviewed gardening. Skip a failing tests.
https://bugs.webkit.org/show_bug.cgi?id=92355.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-26

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] WebPage::handleEditingKeyboardEvent does not check whether the node allows...
commit-queue@webkit.org [Thu, 26 Jul 2012 12:10:21 +0000 (12:10 +0000)]
[WK2] WebPage::handleEditingKeyboardEvent does not check whether the node allows editing.
https://bugs.webkit.org/show_bug.cgi?id=92364

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

Added a check whether the input node allows editing. If editing is not allowed
text input event will not be emitted.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::handleEditingKeyboardEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] EFL port should use XDG paths
commit-queue@webkit.org [Thu, 26 Jul 2012 12:01:37 +0000 (12:01 +0000)]
[EFL] EFL port should use XDG paths
https://bugs.webkit.org/show_bug.cgi?id=91719

Patch by Zoltan Nyul <zoltan.nyul@intel.com> on 2012-07-26
Reviewed by Kenneth Rohde Christiansen.

.:

Efreet library added.

* Source/cmake/FindEFL.cmake:

Source/WebKit:

Add efreet library to get the xdg paths.

* PlatformEfl.cmake:

Source/WebKit/efl:

Using xdg paths instead of home/.webkit directory for application
cache, web-database and local-storage.

* ewk/ewk_main.cpp:
(_ewk_init_body):

Source/WebKit2:

Setting xdg paths for application cache, web-database and local-storage.

* PlatformEfl.cmake:
* UIProcess/efl/WebContextEfl.cpp:
(WebKit::WebContext::applicationCacheDirectory):
(WebKit::WebContext::platformDefaultDatabaseDirectory):
(WebKit::WebContext::platformDefaultLocalStorageDirectory):

Tools:

The appcache/localstorage/webdatabase path should be set in the
ewk_main.cpp instead of the DumpRenderTree, and the XDG_DATA_HOME and
XDG_CACHE_HOME should be set to different directory for each processes
for the layout-tests.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::initialize):
* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.setup_environ_for_server):
* efl/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago2% of all samples running grid demo show up in StyleResolver::canShareStyleWithElemen...
eric@webkit.org [Thu, 26 Jul 2012 11:52:40 +0000 (11:52 +0000)]
2% of all samples running grid demo show up in StyleResolver::canShareStyleWithElement, 20% of those due to getAttribute instead of fastGetAttribute
https://bugs.webkit.org/show_bug.cgi?id=92257

Reviewed by Andreas Kling.

This check was added 7 years ago by hyatt in:
http://trac.webkit.org/changeset/10984
And then later made slow after triggering an ASSERT added:
http://trac.webkit.org/changeset/97670

SVG uses a "type" attribute (and it is animatable), but only when
used on filter elements:
http://www.w3.org/TR/SVG/attindex.html
In any case, this does not apply here, and is certainly not what
this check was originally intended for.

I've moved the check to canShareStyleWithControl
as it is only needed when the elements in question are both input elements.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[NRWT] should have a way to restrict pixel tests for individual directories
kbalazs@webkit.org [Thu, 26 Jul 2012 11:40:06 +0000 (11:40 +0000)]
[NRWT] should have a way to restrict pixel tests for individual directories
https://bugs.webkit.org/show_bug.cgi?id=91754

Reviewed by Dirk Pranke.

Added --pixel-test-directories option to nrwt. It implies --pixel-tests.
If the platform supports this option only tests from these directories will
be executed as pixel tests. Furthermore, platforms can have a default set of
pixel test directories. To support the feature the test harness have to be
able to inform the driver whether to dump pixels for each tests. For this
purpose I changed WTR and the Qt DRT to handle a --pixel-test argument from
the standard output and made NRWT use this argument with these drivers.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::open):
(WebCore::DumpRenderTree::processLine):
(WebCore::DumpRenderTree::setDumpPixelsForAllTests):
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/main.cpp:
(main):
Handle the --pixel-test argument.

* Scripts/webkitpy/layout_tests/controllers/single_test_runner.py:
(SingleTestRunner._should_fetch_expected_checksum):
(SingleTestRunner._overwrite_baselines):
(SingleTestRunner._compare_output):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker._update_test_input):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.supports_switching_pixel_tests_per_test): Ports can override this to inform
the harness that --pixel-test argument is supported. True for WTR, otherwise calls
private version that can be overridden by the actual platform. Only true with WTR
and Qt DRT currently. This supposed to exist only temporary until there are ports
that doesn't support the feature in their DRT's.
(Port):
(Port._supports_switching_pixel_tests_per_test):
(Port.should_run_as_pixel_test):
(Port._should_run_as_pixel_test): Ports can override this to define their
default set of pixel tests directories.
* Scripts/webkitpy/layout_tests/port/driver.py:
(Driver.cmd_line): Don't pass --pixel-tests if the platform supports per test
--pixel-test.
(Driver._command_from_driver_input): Pass --pixel-test if it is supported and pixel
tests are enabled.
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort.check_sys_deps):
(QtPort):
(QtPort._supports_switching_pixel_tests_per_test):
(QtPort._should_run_as_pixel_test):
(QtPort._default_pixel_test_directories): Only compositing will be our default pixel
test directory for the time being.
* Scripts/webkitpy/layout_tests/port/test.py:
(TestPort.supports_switching_pixel_tests_per_test):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(_set_up_derived_options):
(parse_args):
Handle the --pixel-test-directory option. It expect a directory below LayoutTests
and can be specified multiple times. Added fixme's that we should improve how we
handle these arguments.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_run_singly_actually_runs_tests):
(MainTest.test_pixel_test_directories):
Added an integration test for the feature.

* WebKitTestRunner/TestController.cpp:
(WTR::TestController::TestController):
(WTR::TestController::initialize):
(WTR::TestController::runTest):
* WebKitTestRunner/TestController.h:
(TestController):
Handle the --pixel-test argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r123634
commit-queue@webkit.org [Thu, 26 Jul 2012 11:38:16 +0000 (11:38 +0000)]
[EFL] Gardening after r123634
https://bugs.webkit.org/show_bug.cgi?id=92351

Unreviewed gardening.

Newly added inspector tests failing on EFL port due to missing Geolocation support (bug 82140).
Moved Geolocation tests to TestExpectations from Skipped.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-07-26

* platform/efl/Skipped:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [WK2] Memory leak in ewk_view_resource_load_client.cpp
commit-queue@webkit.org [Thu, 26 Jul 2012 11:32:27 +0000 (11:32 +0000)]
[EFL] [WK2] Memory leak in ewk_view_resource_load_client.cpp
https://bugs.webkit.org/show_bug.cgi?id=92099

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-26
Reviewed by Kentaro Hara.

Fix a memory leak by clearing the loadingResources HashMap on exit.

* UIProcess/API/efl/ewk_view.cpp:
(_Ewk_View_Private_Data::~_Ewk_View_Private_Data):
(_ewk_view_priv_loading_resources_clear):
(ewk_view_load_provisional_started):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add memory reporting routine to StyleResolver
yurys@chromium.org [Thu, 26 Jul 2012 10:42:27 +0000 (10:42 +0000)]
Web Inspector: add memory reporting routine to StyleResolver
https://bugs.webkit.org/show_bug.cgi?id=92259

Reviewed by Vsevolod Vlasov.

SyleResolver::reportMemoryUsage is added for estimating StyleResolver
memory footprint.

* css/StyleResolver.cpp:
(RuleData):
(RuleSet):
(RuleSetSelectorPair):
(WebCore::StyleResolver::Features::reportMemoryUsage):
(WebCore):
(WebCore::StyleResolver::collectMatchingRulesForList):
* css/StyleResolver.h:
(Features):
(StyleResolver):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/MemoryInstrumentation.h:
(MemoryInstrumentation):
(WebCore::MemoryClassInfo::addInstrumentedHashSet):
(WebCore::MemoryClassInfo::addInstrumentedVector):
(WebCore::MemoryInstrumentation::addHashMap):
(WebCore):
(WebCore::MemoryInstrumentation::addInstrumentedCollection):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[DRT] LTC:: pageNumberForElementById() could be moved to Internals
gyuyoung.kim@samsung.com [Thu, 26 Jul 2012 10:35:49 +0000 (10:35 +0000)]
[DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Kentaro Hara.

Missing a symbol filter for Mac win port.

* win/WebKit2.def:
* win/WebKit2CFLite.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Remove DeprecatedPeerConnection
tommyw@google.com [Thu, 26 Jul 2012 10:34:09 +0000 (10:34 +0000)]
MediaStream API: Remove DeprecatedPeerConnection
https://bugs.webkit.org/show_bug.cgi?id=92106

Reviewed by Adam Barth.

Source/WebCore:

Since we are getting ready to add an updated PeerConnection
the old DeprecatedPeerConnection will have to go.

No new tests, and old tests converted to use PeerConnection00.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/DOMWindowMediaStream.idl:
* Modules/mediastream/DeprecatedPeerConnection.cpp: Removed.
* Modules/mediastream/DeprecatedPeerConnection.h: Removed.
* Modules/mediastream/DeprecatedPeerConnection.idl: Removed.
* Modules/mediastream/SignalingCallback.h: Removed.
* Modules/mediastream/SignalingCallback.idl: Removed.
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:
* UseJSC.cmake:
* WebCore.gypi:
* bindings/generic/RuntimeEnabledFeatures.h:
* bindings/js/JSDeprecatedPeerConnectionCustom.cpp: Removed.
* dom/EventTargetFactory.in:
* platform/mediastream/DeprecatedPeerConnectionHandler.h: Removed.
* platform/mediastream/DeprecatedPeerConnectionHandlerClient.h: Removed.
* platform/mediastream/blackberry/DeprecatedPeerConnectionHandler.cpp: Removed.
* platform/mediastream/chromium/DeprecatedPeerConnectionHandler.cpp: Removed.
* platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.cpp: Removed.
* platform/mediastream/chromium/DeprecatedPeerConnectionHandlerInternal.h: Removed.
* platform/mediastream/gstreamer/DeprecatedPeerConnectionHandler.cpp: Removed.

LayoutTests:

Changed all usages of DeprecatedPeerConnection to PeerConnection00.

* fast/dom/call-a-constructor-as-a-function-expected.txt:
* fast/dom/call-a-constructor-as-a-function.html:
* fast/mediastream/peerconnection-addstream-expected.txt:
* fast/mediastream/peerconnection-argument-types-expected.txt:
* fast/mediastream/peerconnection-eventlistener-optional-argument.html:
* fast/mediastream/peerconnection-mediastreamlist.html:
* fast/mediastream/peerconnection-removestream-expected.txt:
* fast/mediastream/script-tests/peerconnection-addstream.js:
* fast/mediastream/script-tests/peerconnection-argument-types.js:
* fast/mediastream/script-tests/peerconnection-removestream.js:
* platform/chromium/fast/dom/call-a-constructor-as-a-function-expected.txt:
* platform/gtk/fast/dom/call-a-constructor-as-a-function-expected.txt:
* platform/gtk/fast/js/global-constructors-expected.txt:
* platform/win/fast/dom/call-a-constructor-as-a-function-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
commit-queue@webkit.org [Thu, 26 Jul 2012 10:07:41 +0000 (10:07 +0000)]
[EFL] Regression(r123604): webintents/web-intents-obj-constructor.html is crashing
https://bugs.webkit.org/show_bug.cgi?id=92349

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-26
Reviewed by Kentaro Hara.

Fix crash occurring after r123604, which replaced strdup()
usage with eina_stringshare_add(). Unfortunately, the DRT
was not updated accordingly to use eina_stringshare_del()
instead of free() on the values returned by Ewk_Intent
getters and it was causing
webintents/web-intents-obj-constructor.html to crash.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onFrameIntentNew):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: CSP 1.1: Implement the Content Security Policy script interface.
commit-queue@webkit.org [Thu, 26 Jul 2012 09:49:52 +0000 (09:49 +0000)]
Source/WebCore: CSP 1.1: Implement the Content Security Policy script interface.
https://bugs.webkit.org/show_bug.cgi?id=91707

Patch by Mike West <mkwst@chromium.org> on 2012-07-26
Reviewed by Adam Barth.

The CSP 1.1 editor's draft defines a script interface that gives
developers the ability to query a document regarding the restrictions
set by it's currently active content security policy[1]. This patch
exposes that API in terms of a new DOMSecurityPolicy object.

Data for the API is gathered from the existing ContentSecurityPolicy
object on the containing document. CSP's various methods have been
extended with a `reportingStatus` parameter which, unsurprisingly,
determines whether a violation report should be sent for blocked
resources. This allows us to reuse the same codepaths by simply using
ContentSecurityPolicy::SuppressReport when querying on behalf of the
API, and ContentSecurityPolicy::SendReport when checking resources a
page wants to load.

This feature is gated on the CSP_NEXT flag, which is currently disabled
for all ports other than Chromium.

[1]: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#script-interfaces--experimental

Tests: http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowconnectionto.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-alloweval.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowfontfrom.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowframefrom.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowimagefrom.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowmediafrom.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowobjectfrom.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowscriptfrom.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowstylefrom.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive.html
       http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* WebCore.gypi:
* bindings/gobject/GNUmakefile.am:
* WebCore.xcodeproj/project.pbxproj:
    We added a new object, so let's tell _everyone!_
* dom/Document.cpp:
(WebCore::Document::securityPolicy):
    Expose the SecurityPolicy object via Document, gated on CSP_NEXT.
(WebCore):
* dom/Document.h:
(WebCore):
(Document):
* dom/Document.idl:
    Adding the SecurityPolicy object to the document, gated on CSP_NEXT.
* page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::checkInline):
(WebCore::CSPDirectiveList::checkNonce):
(WebCore::CSPDirectiveList::checkSource):
    Extracting the core checks out into separate methods.
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
    Use checkEval.
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
    Use checkNonce.
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
    Use checkInline.
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
    Use checkSource.
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectToSource):
    These methods now branch on `reportingStatus`: if `SendReoport`,
    they call `checkXAndReportViolation`, otherwise, they call `checkX`.
(WebCore::CSPDirectiveList::gatherReportURIs):
    New method that gathers the violation report URIs into a DOMStringList.
(WebCore::isAllowedByAllWithCallStack):
(WebCore::isAllowedByAllWithContext):
(WebCore::isAllowedByAllWithURL):
    These now pass reportingStatus through to the various `allowX` methods.
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectToSource):
    These accept a new `reportingStatus` parameter, which is passed through
    to the CSPDirectiveList methods.
(WebCore::ContentSecurityPolicy::isActive):
    New method that returns `true` if policy is active.
(WebCore::ContentSecurityPolicy::gatherReportURIs):
    New method that returns a DOMStringList of violation report URIs.
* page/ContentSecurityPolicy.h:
(WebCore):
* page/DOMSecurityPolicy.cpp: Added.
(WebCore::DOMSecurityPolicy::DOMSecurityPolicy):
(WebCore):
(WebCore::DOMSecurityPolicy::~DOMSecurityPolicy):
(WebCore::DOMSecurityPolicy::isActive):
(WebCore::DOMSecurityPolicy::reportURIs):
(WebCore::DOMSecurityPolicy::allowsInlineScript):
(WebCore::DOMSecurityPolicy::allowsInlineStyle):
(WebCore::DOMSecurityPolicy::allowsEval):
(WebCore::DOMSecurityPolicy::allowsConnectionTo):
(WebCore::DOMSecurityPolicy::allowsFontFrom):
(WebCore::DOMSecurityPolicy::allowsFrameFrom):
(WebCore::DOMSecurityPolicy::allowsImageFrom):
(WebCore::DOMSecurityPolicy::allowsMediaFrom):
(WebCore::DOMSecurityPolicy::allowsObjectFrom):
(WebCore::DOMSecurityPolicy::allowsScriptFrom):
(WebCore::DOMSecurityPolicy::allowsStyleFrom):
* page/DOMSecurityPolicy.h: Added.
(WebCore):
(DOMSecurityPolicy):
(WebCore::DOMSecurityPolicy::create):
* page/DOMSecurityPolicy.idl: Added.

LayoutTests: Implement the experimental Content Security Policy script interface.
https://bugs.webkit.org/show_bug.cgi?id=91707

Patch by Mike West <mkwst@chromium.org> on 2012-07-26
Reviewed by Adam Barth.

* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowconnectionto-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowconnectionto.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-alloweval-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-alloweval.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowfontfrom-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowfontfrom.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowframefrom-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowframefrom.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowimagefrom-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowimagefrom.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowmediafrom-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowmediafrom.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowobjectfrom-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowobjectfrom.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowscriptfrom-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowscriptfrom.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowstylefrom-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-allowstylefrom.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-isactive.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/securitypolicy-reporturi.html: Added.
* http/tests/security/contentSecurityPolicy/resources/securitypolicy-tests-base.js: Added.
(log):
(injectPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix build break on mac win port by r123716.
gyuyoung.kim@samsung.com [Thu, 26 Jul 2012 09:46:20 +0000 (09:46 +0000)]
Unreviewed. Fix build break on mac win port by r123716.

* platform/KURL.h:
(KURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Added Qt5 specific expected results and png.
kkristof@inf.u-szeged.hu [Thu, 26 Jul 2012 09:36:04 +0000 (09:36 +0000)]
[Qt] Unreviewed gardening. Added Qt5 specific expected results and png.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-26

* platform/qt-5.0-wk2/fast/block/float/overhanging-tall-block-expected.png: Added after r123551.
* platform/qt-5.0-wk2/fast/block/float/overhanging-tall-block-expected.txt: Added after r123551.
* platform/qt-5.0-wk2/platform/qt/plugins/application-plugin-plugins-disabled-expected.png: Added after r123514.
* platform/qt-5.0-wk2/platform/qt/plugins/application-plugin-plugins-disabled-expected.txt: Update after r123514.
* platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.png: Added after r123631.
* platform/qt-5.0/css2.1/t0805-c5519-brdr-r-01-e-expected.txt: Added after r123631.
* platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.png: Added after r123631.
* platform/qt-5.0/css2.1/t0905-c5525-fltblck-00-d-ag-expected.txt: Added after r123631.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r123715.
vsevik@chromium.org [Thu, 26 Jul 2012 09:32:25 +0000 (09:32 +0000)]
Unreviewed, rolling out r123715.
http://trac.webkit.org/changeset/123715
https://bugs.webkit.org/show_bug.cgi?id=92356

Breaks compilation on multiple platforms (Requested by vsevik
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-26

Source/WebCore:

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::getResponseBody):
* inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::ResourceData::dataLength):
(WebCore::NetworkResourcesData::ResourceData::appendData):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
(WebCore::NetworkResourcesData::ensureFreeSpace):
* inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::clearPreloads):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::evict):
* testing/InternalSettings.cpp:
* testing/Internals.cpp:
* testing/Internals.h:
(Internals):

LayoutTests:

* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Removed.
* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Removed.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Removed.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Fix build break on Apple win bot after r123711
gyuyoung.kim@samsung.com [Thu, 26 Jul 2012 09:28:32 +0000 (09:28 +0000)]
[Mac] Fix build break on Apple win bot after r123711
https://bugs.webkit.org/show_bug.cgi?id=92354

Reviewed by Adam Barth.

Missing return value.

* WebFrame.cpp:
(WebFrame::pageNumberForElementById):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip the failing tests.
kkristof@inf.u-szeged.hu [Thu, 26 Jul 2012 09:09:06 +0000 (09:09 +0000)]
[Qt] Unreviewed gardening. Skip the failing tests.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd *explicit* keyword to constructors in WebCore/platform
gyuyoung.kim@samsung.com [Thu, 26 Jul 2012 08:55:13 +0000 (08:55 +0000)]
Add *explicit* keyword to constructors in WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=92238

Reviewed by Kentaro Hara.

As a step to let *explicit* keyword add to constructors which have a parameter,
*explicit* keyword is added to Source/WebCore/platform in order to avoid implicit
type conversion.

Some files in platform directory can't use explicit keyword because of build breaks.

No new tests. Covered by existing tests.

* platform/AutodrainedPool.h:
(AutodrainedPool):
* platform/ContentType.h:
(ContentType):
* platform/ContextMenu.h:
(ContextMenu):
* platform/ContextMenuItem.h:
(ContextMenuItem):
* platform/Cursor.h:
(WebCore::SharedCursor::SharedCursor):
(Cursor):
* platform/KURL.h:
(WebCore::KURL::KURL):
(KURL):
* platform/KURLGooglePrivate.h:
(KURLGooglePrivate):
* platform/PODRedBlackTree.h:
(WebCore::PODRedBlackTree::PODRedBlackTree):
* platform/Pasteboard.h:
(Pasteboard):
* platform/PlatformEvent.h:
(WebCore::PlatformEvent::PlatformEvent):
* platform/PlatformKeyboardEvent.h:
(PlatformKeyboardEvent):
* platform/PlatformMouseEvent.h:
(PlatformMouseEvent):
* platform/PlatformPasteboard.h:
(PlatformPasteboard):
* platform/PlatformTouchEvent.h:
(PlatformTouchEvent):
* platform/PlatformWheelEvent.h:
(PlatformWheelEvent):
* platform/RunLoop.h:
(TimerBase):
* platform/ScrollAnimator.h:
(ScrollAnimator):
* platform/ScrollAnimatorNone.h:
(ScrollAnimatorNone):
* platform/SharedBuffer.h:
(SharedBuffer):
* platform/WheelFlingPlatformGestureCurve.h:
(WheelFlingPlatformGestureCurve):
* platform/Widget.h:
(Widget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Resource agent's reference to cached resources should be weak.
vsevik@chromium.org [Thu, 26 Jul 2012 08:48:01 +0000 (08:48 +0000)]
Web Inspector: Resource agent's reference to cached resources should be weak.
https://bugs.webkit.org/show_bug.cgi?id=92108

Reviewed by Pavel Feldman.

Source/WebCore:

NetworkResourcesData now stores a raw pointer to CachedResource.
CachedResource now notifies InspectorInstrumentation that it will be destroyed.
InspectorInstrumentation stores a set of InstrumentingAgents and broadcasts willDestroyCachedResource event to all available resourceAgents.
Destroyed resources content is saved to NetworkResourcesData.
Changed content size variables type in NetworkResourcesData from int to size_t.

Tests: http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html
       http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::inspectedPageDestroyed):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willDestroyCachedResourceImpl):
(WebCore::InspectorInstrumentation::registerInstrumentingAgents):
(WebCore::InspectorInstrumentation::unregisterInstrumentingAgents):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willDestroyCachedResource):
(WebCore):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::didReceiveData):
(WebCore::InspectorResourceAgent::willDestroyCachedResource):
(WebCore):
(WebCore::InspectorResourceAgent::getResponseBody):
* inspector/InspectorResourceAgent.h:
(InspectorResourceAgent):
* inspector/NetworkResourcesData.cpp:
(WebCore::NetworkResourcesData::ResourceData::ResourceData):
(WebCore::NetworkResourcesData::ResourceData::setContent):
(WebCore::NetworkResourcesData::ResourceData::dataLength):
(WebCore::NetworkResourcesData::ResourceData::appendData):
(WebCore::NetworkResourcesData::ResourceData::decodeDataToContent):
(WebCore::NetworkResourcesData::setResourceContent):
(WebCore::NetworkResourcesData::maybeAddResourceData):
(WebCore::NetworkResourcesData::maybeDecodeDataToContent):
(WebCore::NetworkResourcesData::removeCachedResource):
(WebCore):
(WebCore::NetworkResourcesData::setResourcesDataSizeLimits):
(WebCore::NetworkResourcesData::ensureFreeSpace):
* inspector/NetworkResourcesData.h:
(ResourceData):
(WebCore::NetworkResourcesData::ResourceData::base64Encoded):
(WebCore::NetworkResourcesData::ResourceData::cachedResource):
(NetworkResourcesData):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
(WebCore::CachedResource::removeClient):
(WebCore::CachedResource::deleteIfPossible):
* loader/cache/CachedResource.h:
(CachedResource):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::garbageCollectDocumentResourcesTimerFired):
(WebCore::CachedResourceLoader::garbageCollectDocumentResources):
(WebCore::CachedResourceLoader::clearPreloads):
* loader/cache/CachedResourceLoader.h:
(CachedResourceLoader):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::evict):
* testing/InternalSettings.cpp:
* testing/Internals.cpp:
(WebCore::Internals::garbageCollectDocumentResources):
(WebCore):
* testing/Internals.h:
(Internals):

LayoutTests:

* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage-expected.txt: Added.
* http/tests/inspector/network/cached-resource-destroyed-moved-to-storage.html: Added.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded-expected.txt: Added.
* http/tests/inspector/network/cached-resource-destroyed-too-big-discarded.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix null ptr deref in CSSParser::storeVariableDeclaration().
macpherson@chromium.org [Thu, 26 Jul 2012 08:32:35 +0000 (08:32 +0000)]
Fix null ptr deref in CSSParser::storeVariableDeclaration().
https://bugs.webkit.org/show_bug.cgi?id=92333

Reviewed by Andreas Kling.

Fix null pointer deref that occurs if the CSSParserValue couldn't be converted to a CSSValue.

Test fast/css/variables/variable-unparseable-value-crash.html added.

* css/CSSParser.cpp:
(WebCore::CSSParser::storeVariableDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Add UserAgentShadowDOM to FormControlElement just before adding Autho...
shinyak@chromium.org [Thu, 26 Jul 2012 08:11:37 +0000 (08:11 +0000)]
Source/WebCore: Add UserAgentShadowDOM to FormControlElement just before adding AuthorShadowDOM
https://bugs.webkit.org/show_bug.cgi?id=90866

Reviewed by Hajime Morita.

It ensures that UserAgentShadowDOM is the oldest ShadowDOM.

To show ValidationMessage, WebKit adds a Shadow DOM to some of FormControlElements.
ValidationMessage assumes that the added Shadow DOM is the oldest, however, there was a case
that a page author might add a Shadow DOM before ValidationMessage adds a Shadow DOM.
It will break the assumption that the Shadow DOM added by ValidationMessage is the oldest.
So we have prohibited a page author adding a Shadow DOM to FormControlElement.

To add UserAgentShadowDOM, we use a callback which is called before a page author adding a Shadow DOM.
It adds a UserAgentShadowDOM if it does not exist, so we can ensure that UserAgentShadowDOM is the oldest.

Tests: fast/dom/shadow/input-with-validation-without-shadow.html
       fast/dom/shadow/input-with-validation.html
       fast/dom/shadow/shadowdom-for-button-complex-shadow.html
       fast/dom/shadow/shadowdom-for-button-only-shadow.html
       fast/dom/shadow/shadowdom-for-button-without-shadow.html
       fast/dom/shadow/shadowdom-for-fieldset-complex-shadow.html
       fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html
       fast/dom/shadow/shadowdom-for-fieldset-without-shadow.html
       fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html
       fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html
       fast/dom/shadow/shadowdom-for-keygen-only-shadow.html
       fast/dom/shadow/shadowdom-for-keygen-without-shadow.html
       fast/dom/shadow/shadowdom-for-object-complex-shadow.html
       fast/dom/shadow/shadowdom-for-object-only-shadow.html
       fast/dom/shadow/shadowdom-for-object-without-shadow.html
       fast/dom/shadow/shadowdom-for-output-complex-shadow.html
       fast/dom/shadow/shadowdom-for-output-only-shadow.html
       fast/dom/shadow/shadowdom-for-output-without-shadow.html
       fast/dom/shadow/shadowdom-for-select-complex-shadow.html
       fast/dom/shadow/shadowdom-for-select-only-shadow.html
       fast/dom/shadow/shadowdom-for-select-without-shadow.html
       fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html
       fast/dom/shadow/shadowdom-for-textarea-only-shadow.html
       fast/dom/shadow/shadowdom-for-textarea-without-shadow.html

* dom/ShadowRoot.cpp:
(WebCore::allowsAuthorShadowRoot):
* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::ensureUserAgentShadowRoot): Ensures the existence of a UserAgentShadowRoot.
If it does not exist, we create it with empty content.
(WebCore):
* html/FormAssociatedElement.h:
(FormAssociatedElement):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::willAddAuthorShadowRoot):
(WebCore):
* html/HTMLFormControlElement.h:
(HTMLFormControlElement):
* html/ValidationMessage.cpp:
(WebCore::adjustBubblePosition): When AuthroShadowRoot does not a shadow element, ValidationMessage
does not have a renderer. So we have to check the existence of renderer.
(WebCore::ValidationMessage::buildBubbleTree):

LayoutTests: Add UserAgentShadowDOM to FormControlElement just before ading UserShadowDOM
https://bugs.webkit.org/show_bug.cgi?id=90866

Reviewed by Hajime Morita.

Added a lot of tests of ShadowDOM for replaced elements. They don't crash,
but many of them are not rendered correctly. Please see Bug 82313,
which is a meta bug of Shadow DOM for replaced elements.

* fast/dom/shadow/input-with-validation-expected.html: Added.
* fast/dom/shadow/input-with-validation-without-shadow-expected.html: Added.
* fast/dom/shadow/input-with-validation-without-shadow.html: Added.
* fast/dom/shadow/input-with-validation.html: Added.
* fast/dom/shadow/shadow-disable-expected.txt:
* fast/dom/shadow/shadow-disable.html:
* fast/dom/shadow/shadowdom-for-button-complex-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-button-complex-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-button-only-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-button-only-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-button-without-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-button-without-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-fieldset-complex-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-fieldset-complex-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-fieldset-only-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-fieldset-only-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-fieldset-without-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-fieldset-without-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-form-associated-element-useragent-expected.txt: Added.
* fast/dom/shadow/shadowdom-for-form-associated-element-useragent.html: Added.
* fast/dom/shadow/shadowdom-for-keygen-complex-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-keygen-complex-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-keygen-only-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-keygen-only-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-keygen-without-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-keygen-without-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-object-complex-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-object-complex-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-object-only-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-object-only-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-object-without-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-object-without-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-output-complex-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-output-complex-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-output-only-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-output-only-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-output-without-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-output-without-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-select-complex-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-select-complex-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-select-only-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-select-only-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-select-without-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-select-without-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-complex-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-complex-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-only-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-only-shadow.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-without-shadow-expected.html: Added.
* fast/dom/shadow/shadowdom-for-textarea-without-shadow.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/qt/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed attempt to fix the chromium-win build.
abarth@webkit.org [Thu, 26 Jul 2012 07:48:58 +0000 (07:48 +0000)]
Unreviewed attempt to fix the chromium-win build.

* DumpRenderTree/chromium/TestRunner/TestRunner.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago.: [DRT] LTC:: pageNumberForElementById() could be moved to Internals.
kaustubh@motorola.com [Thu, 26 Jul 2012 07:06:57 +0000 (07:06 +0000)]
.: [DRT] LTC:: pageNumberForElementById() could be moved to Internals.
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Exporting Internals::pageNumber symbols for the Gtk build.

* Source/autotools/symbols.filter:

Source/WebCore: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

Covered by existing test cases.

* testing/Internals.cpp:
(WebCore::Internals::counterValue):
(WebCore):
(WebCore::Internals::pageNumber):
* testing/Internals.h:
(Internals):
(WebCore::Internals::pageNumber):
* testing/Internals.idl:

Source/WebKit/efl: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:

Source/WebKit/gtk: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/qt: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Moved the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

* WebFrame.cpp: Added comment for removing the function. Removed implementation.

Tools: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

* DumpRenderTree/LayoutTestController.cpp:
(LayoutTestController::staticFunctions):
* DumpRenderTree/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/blackberry/LayoutTestControllerBlackBerry.cpp:
* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::setPrinting):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
* DumpRenderTree/mac/LayoutTestControllerMac.mm:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController):
* DumpRenderTree/win/LayoutTestControllerWin.cpp:
* DumpRenderTree/wx/LayoutTestControllerWx.cpp:
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(LayoutTestController):

LayoutTests: [DRT] LTC:: pageNumberForElementById() could be moved to Internals
https://bugs.webkit.org/show_bug.cgi?id=92091

Reviewed by Adam Barth.

Move the pageNumberForElementById from LayoutTestCotroller to Internals and
remove the old platform specific implementations as it exclusively tests WebCore functionality.

* printing/pageNumerForElementById-expected.txt:
* printing/resources/paged-media-test-utils.js:
(pageNumberForElementShouldBe):
* printing/return-from-printing-mode.html:
* printing/script-tests/pageNumerForElementById.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: WebKit API interfaces for "upgradeneeded" methods and events
dgrogan@chromium.org [Thu, 26 Jul 2012 06:37:34 +0000 (06:37 +0000)]
IndexedDB: WebKit API interfaces for "upgradeneeded" methods and events
https://bugs.webkit.org/show_bug.cgi?id=92203

Reviewed by Adam Barth.

This is the beginning of our typical three-sided-patch process.

* public/WebIDBCallbacks.h:
(WebKit::WebIDBCallbacks::onBlocked):
(WebKit::WebIDBCallbacks::onUpgradeNeeded):
* public/WebIDBDatabaseCallbacks.h:
(WebKit::WebIDBDatabaseCallbacks::onVersionChange):
* public/WebIDBFactory.h:
(WebIDBFactory):
(WebKit::WebIDBFactory::open):
* src/WebIDBFactoryImpl.cpp:
(WebKit::WebIDBFactoryImpl::open):
(WebKit):
* src/WebIDBFactoryImpl.h:
(WebIDBFactoryImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpstream declaration of WebGraphicsContext3D::createStreamTextureCHROMIUM() for android
commit-queue@webkit.org [Thu, 26 Jul 2012 06:30:50 +0000 (06:30 +0000)]
Upstream declaration of WebGraphicsContext3D::createStreamTextureCHROMIUM() for android
https://bugs.webkit.org/show_bug.cgi?id=92308

Patch by Min Qin <qinmin@chromium.org> on 2012-07-25
Reviewed by Adam Barth.

For android, we need 2 calls to create and destroy the stream texture.
This change adds the interface for these 2 calls.
The actual implementation will be in webgraphicscontext3d_in_process_impl and webgraphicscontext3d_command_buffer_impl.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::createStreamTextureCHROMIUM):
(WebKit::WebGraphicsContext3D::destroyStreamTextureCHROMIUM):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for 32-bit after r123682
mhahnenberg@apple.com [Thu, 26 Jul 2012 06:06:25 +0000 (06:06 +0000)]
Build fix for 32-bit after r123682

* runtime/JSObject.h: Need to pad out JSObjects on 32-bit so that they're the correct size since
we only removed one 4-byte word and we need to be 8-byte aligned.
(JSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium][Win] <progress> animation on RTL direction is reverse
morrita@google.com [Thu, 26 Jul 2012 03:26:50 +0000 (03:26 +0000)]
[Chromium][Win] <progress> animation on RTL direction is reverse
https://bugs.webkit.org/show_bug.cgi?id=92236

Reviewed by Kent Tamura.

Source/WebCore:

This change modfies the way to handle RTL progress bar painting.
Originally it computes the flipped coordinates. This change uses transformation for the flip.
DirectionFlippingScope handles it.

* rendering/RenderThemeChromiumLinux.cpp:
(WebCore::RenderThemeChromiumLinux::paintProgressBar): Applied DirectionFlippingScope
* rendering/RenderThemeChromiumSkia.cpp:
(WebCore::RenderThemeChromiumSkia::determinateProgressValueRectFor):
- Deleted RTL handling in favor of DirectionFlippingScope
(WebCore::RenderThemeChromiumSkia::DirectionFlippingScope::DirectionFlippingScope):
(WebCore):
(WebCore::RenderThemeChromiumSkia::DirectionFlippingScope::~DirectionFlippingScope):
* rendering/RenderThemeChromiumSkia.h:
(RenderThemeChromiumSkia):
(DirectionFlippingScope): Added.
* rendering/RenderThemeChromiumWin.cpp:
(WebCore):
(WebCore::RenderThemeChromiumWin::paintProgressBar): Applied DirectionFlippingScope

LayoutTests:

Updated the expectation file which went slightly different.

* platform/chromium-linux/fast/dom/HTMLProgressElement/progress-element-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=92260
commit-queue@webkit.org [Thu, 26 Jul 2012 03:24:46 +0000 (03:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=92260
Repalce "int" with "long" from WebCore/*.idls

Patch by Vineet Chaudhary <rgf748@motorola.com> on 2012-07-25
Reviewed by Adam Barth.

As per the WebIDL spec IDL shouldn't have int attributes but long instead.
Repalced attributes types int with long from WebCore/*.idls.

No new tests. TestObj.idl already covers this.
There should be no behavioural changes.

* dom/Touch.idl: Repalce int with long.
* dom/WebKitNamedFlow.idl: Ditto.
* html/canvas/ArrayBuffer.idl: Ditto.
* html/canvas/WebGLActiveInfo.idl: Ditto.
* html/canvas/WebGLShaderPrecisionFormat.idl: Ditto.
* page/WebKitAnimation.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe elements in ShadowDOM of meter or progress should not be modifiable.
shinyak@chromium.org [Thu, 26 Jul 2012 03:10:09 +0000 (03:10 +0000)]
The elements in ShadowDOM of meter or progress should not be modifiable.
https://bugs.webkit.org/show_bug.cgi?id=92199

Reviewed by Hajime Morita.

Source/WebCore:

A user can set -webkit-user-modify: read-write to the elements in Shadow DOM in a meter or progress element.
This might cause a undesired crash like Bug 65738. They should be unmodifiable.

We add default css values to elements in ShadowDOM of meter or progress to prohibit editing them.

Tests: fast/html/meter-user-modify.html
       fast/html/progress-user-modify.html

* css/html.css:
Added -webkit-user-modify: read-only !important; for these elements so that they won't be
changed by a user.
(meter::-webkit-meter-bar):
(meter::-webkit-meter-optimum-value):
(meter::-webkit-meter-suboptimum-value):
(meter::-webkit-meter-even-less-good-value):
(progress::-webkit-progress-bar):
(progress::-webkit-progress-value):

LayoutTests:

* fast/html/meter-user-modify.html: Added.
* fast/html/meter-user-modify-expected.txt: Added.
* fast/html/progress-user-modify.html: Added.
* fast/html/progress-user-modify-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Implement the inspector for WebKitTestRunner
commit-queue@webkit.org [Thu, 26 Jul 2012 03:02:20 +0000 (03:02 +0000)]
[EFL][WK2] Implement the inspector for WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=92213

Patch by Seokju Kwon <seokju.kwon@samsung.com> on 2012-07-25
Reviewed by Ryosuke Niwa.

Partial Implementation of WebInspectorProxyEfl for WebkitTestRunner.
And Web Inspector resources installation.

* PlatformEfl.cmake:
* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::WebInspectorProxy):
* UIProcess/WebInspectorProxy.h:
(WebInspectorProxy):
* UIProcess/efl/WebInspectorProxyEfl.cpp:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
(WebKit::WebInspectorProxy::platformDidClose):
(WebKit::WebInspectorProxy::inspectorPageURL):
(WebKit::WebInspectorProxy::inspectorBaseURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] GraphicsContext3D::paintToCanvas should not swap 0th and 2nd components...
commit-queue@webkit.org [Thu, 26 Jul 2012 02:52:45 +0000 (02:52 +0000)]
[BlackBerry] GraphicsContext3D::paintToCanvas should not swap 0th and 2nd components of color
https://bugs.webkit.org/show_bug.cgi?id=92314

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it corrects existing functionality, but it makes BlackBerry
pass canvas-text.html and others.

* platform/graphics/GraphicsContext3D.h:
* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::paintToCanvas):
* platform/graphics/opengl/GraphicsContext3DOpenGLCommon.cpp:
(WebCore::GraphicsContext3D::paintRenderingResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] GraphicsContext3D::reshapeFBOs does not report when bound FBOs should...
commit-queue@webkit.org [Thu, 26 Jul 2012 02:46:37 +0000 (02:46 +0000)]
[BlackBerry] GraphicsContext3D::reshapeFBOs does not report when bound FBOs should be restored
https://bugs.webkit.org/show_bug.cgi?id=92304

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it corrects existing functionality, but it makes BlackBerry
pass framebuffer-bindings-unaffected-on-resize.html.

* platform/graphics/blackberry/GraphicsContext3DBlackBerry.cpp:
(WebCore::GraphicsContext3D::reshapeFBOs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] readPixels should set alpha to 255 instead of 0 when alpha is disabled
commit-queue@webkit.org [Thu, 26 Jul 2012 02:36:25 +0000 (02:36 +0000)]
[BlackBerry] readPixels should set alpha to 255 instead of 0 when alpha is disabled
https://bugs.webkit.org/show_bug.cgi?id=92303

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it corrects existing functionality, but it makes BlackBerry
pass context-attributes-alpha-depth-stencil-antialias.html.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore):
(WebCore::WebGLRenderingContext::readPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WebGL] fast/canvas/webgl/framebuffer-object-attachment.html fails on certain platforms
commit-queue@webkit.org [Thu, 26 Jul 2012 02:32:13 +0000 (02:32 +0000)]
[WebGL] fast/canvas/webgl/framebuffer-object-attachment.html fails on certain platforms
https://bugs.webkit.org/show_bug.cgi?id=92296

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

No new tests, because it introduces no new functionality, only fixes the above mentioned test.

* html/canvas/WebGLFramebuffer.cpp:
(WebCore::WebGLFramebuffer::checkStatus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: IDBTransaction::abort() should throw DOMException
commit-queue@webkit.org [Thu, 26 Jul 2012 02:30:34 +0000 (02:30 +0000)]
IndexedDB: IDBTransaction::abort() should throw DOMException
https://bugs.webkit.org/show_bug.cgi?id=92069

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-07-25
Reviewed by Kentaro Hara.

Source/WebCore:

Keep aligned with the W3C spec.
http://dvcs.w3.org/hg/IndexedDB/raw-file/tip/Overview.html#widl-IDBTransaction-abort-void

Test: storage/indexeddb/transaction-abort.html.

* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::abort):
(WebCore):
* Modules/indexeddb/IDBTransaction.h:
(IDBTransaction):
* Modules/indexeddb/IDBTransaction.idl:

LayoutTests:

Add the exception test for IDBTransaction::abort().

* storage/indexeddb/resources/transaction-abort.js:
(transactionAborted):
* storage/indexeddb/transaction-abort-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update fast/canvas/webgl expectations
commit-queue@webkit.org [Thu, 26 Jul 2012 02:28:17 +0000 (02:28 +0000)]
[BlackBerry] Update fast/canvas/webgl expectations
https://bugs.webkit.org/show_bug.cgi?id=92309

Patch by Joshua Netterfield <jnetterfield@rim.com> on 2012-07-25
Reviewed by Rob Buis.

Add the css-webkit-canvas-* files, because we render them correctly.

There is nothing we can do about running out of memory on draw-elements-out-of-bounds,
so make that expected.

Our output for framebuffer-object-attachement-expected.txt is valid.

* platform/blackberry/fast/canvas/webgl/css-webkit-canvas-expected.png: Added.
* platform/blackberry/fast/canvas/webgl/css-webkit-canvas-expected.txt: Added.
* platform/blackberry/fast/canvas/webgl/css-webkit-canvas-repaint-expected.png: Added.
* platform/blackberry/fast/canvas/webgl/css-webkit-canvas-repaint-expected.txt: Added.
* platform/blackberry/fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Added.
* platform/blackberry/fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoflexitems can overflow the flexbox due to rounding
tony@chromium.org [Thu, 26 Jul 2012 02:24:47 +0000 (02:24 +0000)]
flexitems can overflow the flexbox due to rounding
https://bugs.webkit.org/show_bug.cgi?id=92163

Reviewed by Levi Weintraub.

Source/WebCore:

Don't round flex item sizes and use LayoutPoint for the location of flex items.

Test: css3/flexbox/flex-rounding.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::resolveFlexibleLengths):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::layoutColumnReverse):

LayoutTests:

Tests for dividing space in non-integral amounts.

* css3/flexbox/flex-rounding-expected.txt: Added.
* css3/flexbox/flex-rounding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTestRunner.a should contain a TestRunner object
abarth@webkit.org [Thu, 26 Jul 2012 02:19:09 +0000 (02:19 +0000)]
TestRunner.a should contain a TestRunner object
https://bugs.webkit.org/show_bug.cgi?id=92313

Reviewed by Kent Tamura.

This patch adds a stub implementation of TestRunner, which is the new
home for our implementation of window.testRunner. A future patch will
migrate functions from LayoutTestController to TestRunner.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/LayoutTestController.h:
* DumpRenderTree/chromium/TestRunner/TestRunner.cpp: Added.
* DumpRenderTree/chromium/TestRunner/TestRunner.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Integrate certmgr with CredentialBackingStore
commit-queue@webkit.org [Thu, 26 Jul 2012 02:16:56 +0000 (02:16 +0000)]
[BlackBerry] Integrate certmgr with CredentialBackingStore
https://bugs.webkit.org/show_bug.cgi?id=92183

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-07-25
Reviewed by George Staikos.

Integrated BlackBerry::Platform::CertMgrWrapper with
CredentialBackingStore, when certmgr is ready we save
the password in certmgr and retrieve it from certmgr.

RIM PR: 171991
Internally reviewed by Joe Mason <jmason@rim.com>.

No new tests since there's no functional change.

* platform/network/blackberry/CredentialBackingStore.cpp:
(WebCore::hashCredentialInfo):
(WebCore):
(WebCore::CredentialBackingStore::CredentialBackingStore):
(WebCore::CredentialBackingStore::open):
(WebCore::CredentialBackingStore::addLogin):
(WebCore::CredentialBackingStore::updateLogin):
(WebCore::CredentialBackingStore::getLogin):
* platform/network/blackberry/CredentialBackingStore.h:
(CredentialBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Support RTSP in browser
commit-queue@webkit.org [Thu, 26 Jul 2012 02:14:27 +0000 (02:14 +0000)]
[BlackBerry] Support RTSP in browser
https://bugs.webkit.org/show_bug.cgi?id=92233

Patch by Jonathan Dong <jonathan.dong@torchmobile.com.cn> on 2012-07-25
Reviewed by Rob Buis.

Handle URL scheme "rtsp://" before creating the DocumentLoader
and send the request to webkit. As we don't have any application
which can deal with rtsp invocation for now, we need to create
a media document to wrap the rtsp url within a video tag which
makes it load as a normal video clip.

RIM PR: 169669
Internally reviewed by Charles Wei <charles.wei@torchmobile.com.cn>.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::createDocumentLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Tests] Re-factor fast/forms/number/number-spinbutton-change-and-input-events.html
yosin@chromium.org [Thu, 26 Jul 2012 02:05:51 +0000 (02:05 +0000)]
[Tests] Re-factor fast/forms/number/number-spinbutton-change-and-input-events.html
https://bugs.webkit.org/show_bug.cgi?id=92206

Reviewed by Kent Tamura.

For ease of maintenance and improving test coverage with low cost, I
would like to make a test script of number-spinbutton-change-and-inputs.html
sharable with other input types which have spin button.

This patch moves JavaScript codes from test HTML file to shared JavaScript
file, common-spinbutton-change-and-input-events.html with parametrized
entry point for specifying input type.

* fast/forms/number/number-spinbutton-change-and-input-events-expected.txt: Changed "numnber" to "number", and "numberInput" to "testInput".
* fast/forms/number/number-spinbutton-change-and-input-events.html: Removed JavaScript code.
* fast/forms/resources/common-spinbutton-change-and-input-events.js: Removed HTML code. Made entry point. Changed to support testing without maximum value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r121420): Performance regression of form state saving for pages with multi...
tkent@chromium.org [Thu, 26 Jul 2012 01:36:33 +0000 (01:36 +0000)]
REGRESSION(r121420): Performance regression of form state saving for pages with multiple forms
https://bugs.webkit.org/show_bug.cgi?id=91804

Reviewed by Hajime Morita.

The complexity of FormKeyGenerator::formKey() was O(N) where N is the
number form elements with an identical action URL, and formKey() is
called for every form. So, it's O(N^2). A page in www.reddit.com
contains hundreds of form elements with action="#". So FormController::
formElementsState() took a few seconds on a slow machine.

In order to avoid O(N^2) operation, storing a map from form signatures
to next index numbers, instead of storing existing formKey strings.

No new tests. Just a performance improvement.

Note: This is a re-landing of r123191. We rolled it out because of
suspicion of a performance regression. However it was innocent.

* html/FormController.cpp:
(FormKeyGenerator): Remove m_existingKeys. Add a map from a form
signature string to the next index number.
(WebCore::formSignature): Returns a signature string for a form, without
an index number. This is like "actionURL [name1 name2 ]"
(WebCore::FormKeyGenerator::formKey):
Creates a formKey string by concatenating a formSignature and #n. N is
obtained from m_formSignatureToNextIndexMap in O(1).
(WebCore::FormKeyGenerator::willDeleteForm):
Remove the code for m_existingKeys.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoJSC GC object copying APIs should allow for greater flexibility
fpizlo@apple.com [Thu, 26 Jul 2012 01:22:59 +0000 (01:22 +0000)]
JSC GC object copying APIs should allow for greater flexibility
https://bugs.webkit.org/show_bug.cgi?id=92316

Reviewed by Mark Hahnenberg.

It's now the case that visitChildren() methods can directly pin and allocate in new space during copying.
They can also do the copying and marking themselves. This new API is only used for JSObjects for now.

* JavaScriptCore.xcodeproj/project.pbxproj:
* heap/MarkStack.cpp:
(JSC::SlotVisitor::allocateNewSpaceSlow):
(JSC::SlotVisitor::allocateNewSpaceOrPin):
(JSC):
(JSC::SlotVisitor::copyAndAppend):
* heap/MarkStack.h:
(MarkStack):
(JSC::MarkStack::appendUnbarrieredValue):
(JSC):
* heap/SlotVisitor.h:
* heap/SlotVisitorInlineMethods.h: Added.
(JSC):
(JSC::SlotVisitor::checkIfShouldCopyAndPinOtherwise):
(JSC::SlotVisitor::allocateNewSpace):
* runtime/JSObject.cpp:
(JSC::JSObject::visitOutOfLineStorage):
(JSC):
(JSC::JSObject::visitChildren):
(JSC::JSFinalObject::visitChildren):
* runtime/JSObject.h:
(JSObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInitialize QualifiedName's strings from the read only data segment
benjamin@webkit.org [Thu, 26 Jul 2012 01:05:23 +0000 (01:05 +0000)]
Initialize QualifiedName's strings from the read only data segment
https://bugs.webkit.org/show_bug.cgi?id=92226

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-25
Reviewed by Anders Carlsson.

Source/WebCore:

Modify the initialization of static QualifiedName to initialize the AtomicString
with the data from the read only memory.

Overall, HTMLNames::init() gets 10% faster.

* dom/QualifiedName.cpp:
(WebCore::QualifiedName::QualifiedName):
* dom/QualifiedName.h:
(QualifiedName):
Remove the useless constructor taking a char* and get rid of the init() function.
The AtomicString representing the name should be constructed by the caller of QualifiedName.

Because the init() code is relatively large and is only executed once, it is important to
keep the AtomicString construction separate. The function createQualifiedName() was added
to improve the cache use. The short version let us reduce the code one more instruction per
call.

* dom/make_names.pl:
(printQualifiedNameMaker):
(printShortQualifiedNameMaker):
(printNamesCppFile):
(printDefinitions):

Source/WTF:

Add constructors for StringImpl and AtomicString to be able to create
the strings from the literal in read only memory.

* wtf/text/AtomicString.cpp:
(HashTranslatorCharBuffer):
(WTF::LCharBufferFromLiteralDataTranslator::hash):
(LCharBufferFromLiteralDataTranslator):
(WTF::LCharBufferFromLiteralDataTranslator::equal):
(WTF::LCharBufferFromLiteralDataTranslator::translate):
(WTF::AtomicString::addFromLiteralData):
* wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
(AtomicString):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::createFromLiteral):
* wtf/text/StringImpl.h:
(WTF):
(StringImpl):
(WTF::StringImpl::createFromLiteral):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanges to the WebFrame API cause dependent apps to crash.
commit-queue@webkit.org [Thu, 26 Jul 2012 01:01:24 +0000 (01:01 +0000)]
Changes to the WebFrame API cause dependent apps to crash.
https://bugs.webkit.org/show_bug.cgi?id=91656
<rdar://problem/11904605>

Patch by Roger Fong <roger_fong@apple.com> on 2012-07-25
Reviewed by Jon Honeycutt.

Changes to the WebFrame API cause certain apps to crash because of inconsistencies in the COM interface.
The resumeAnimations and suspendAnimations are removed, which are still needed.
The counterValueByElementId method was also removed, although is not needed there.
However, for all of these methods, no method stubs were added where appropriate after removal.

* Interfaces/IWebFramePrivate.idl:
Added resumeAnimations() and suspendAnimations() methods back in. Added unused method stub for counterValueByElementId method.

* WebFrame.cpp:
(WebFrame::resumeAnimations):
Added this method back in.
(WebFrame::suspendAnimations):
Added this method back in.

* WebFrame.h:
(Re)added methods and unused method stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Forms] Move HTMLInputElement::updateInnerTextValue to InputType class
yosin@chromium.org [Thu, 26 Jul 2012 01:01:08 +0000 (01:01 +0000)]
[Forms] Move HTMLInputElement::updateInnerTextValue to InputType class
https://bugs.webkit.org/show_bug.cgi?id=92230

Reviewed by Kent Tamura.

This patch moves implementaion of HTMLInputElement::updateInnerTextValue()
into input type classes, removes updateInnerTextValue() from HTMLInputElement,
and updates call site of updateInnerTextValue().

No new tests. This patch doesn't change behavior.

* html/DateInputType.cpp:
(WebCore::DateInputType::handleBlurEvent): Updated call site of updateInnerTextValue().
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateType): Updated call site of updateInnerTextValue().
(WebCore::HTMLInputElement::parseAttribute): Updated call site of updateInnerTextValue().
(WebCore::HTMLInputElement::copyNonAttributePropertiesFromElement): Updated call site of updateInnerTextValue().
(WebCore::HTMLInputElement::setSuggestedValue): Updated call site of updateInnerTextValue().
* html/HTMLInputElement.h:
(HTMLInputElement): Removed updateInnerTextValue().
* html/InputType.cpp:
(WebCore::InputType::updateInnerTextValue): Added default implementaion.
* html/InputType.h:
(InputType): Added declaration of updateInnerTextValue().
* html/NumberInputType.cpp:
(WebCore::NumberInputType::handleBlurEvent): Updated call site of updateInnerTextValue().
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::setValue): Updated call site of updateInnerTextValue().
(WebCore::TextFieldInputType::updateInnerTextValue): Moved implementaion from HTMLInputElement.
* html/TextFieldInputType.h:
(TextFieldInputType): Added declaration of updateInnerTextValue().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move ephemeral data for a single frame in LayerRendererChromium into a...
danakj@chromium.org [Thu, 26 Jul 2012 00:57:51 +0000 (00:57 +0000)]
[chromium] Move ephemeral data for a single frame in LayerRendererChromium into a structure with a scoped lifetime equal to the frame
https://bugs.webkit.org/show_bug.cgi?id=92294

Reviewed by Adrienne Walker.

The LayerRendererChromium class has a number of member variables that are used
while drawing a single frame. Because they are member variables, their lifetimes
are not clear, and some are even updated between frames, which is not needed.

This change creates a LRC::DrawingFrame structure that holds the data used
while drawing the current frame, and an instance of this structure is held
and passed around to functions in LayerRendererChromium, moving all of the
data out from being member variables on the class to being function
arguments on the relevant methods.

The projection and window matrices are a part of this frame data, and are not
used externally, so they are removed from the CCRenderer interface and included
within the DrawingFrame structure.

Covered by existing tests, no change in behaviour intended.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::viewportChanged):
(WebCore::LayerRendererChromium::clearFramebuffer):
(WebCore::LayerRendererChromium::drawFrame):
(WebCore::LayerRendererChromium::drawRenderPass):
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::LayerRendererChromium::drawCheckerboardQuad):
(WebCore::LayerRendererChromium::drawDebugBorderQuad):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderPassQuad):
(WebCore::LayerRendererChromium::drawSolidColorQuad):
(WebCore::LayerRendererChromium::drawTileQuad):
(WebCore::LayerRendererChromium::drawYUVVideoQuad):
(WebCore::LayerRendererChromium::drawStreamVideoQuad):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::drawIOSurfaceQuad):
(WebCore::LayerRendererChromium::finishDrawingFrame):
(WebCore::LayerRendererChromium::drawTexturedQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
(WebCore::LayerRendererChromium::isCurrentRenderPass):
(WebCore::LayerRendererChromium::useRenderPass):
(WebCore::LayerRendererChromium::useScopedTexture):
(WebCore::LayerRendererChromium::bindFramebufferToTexture):
(WebCore::LayerRendererChromium::setScissorToRect):
(WebCore::LayerRendererChromium::setDrawFramebufferRect):
* platform/graphics/chromium/LayerRendererChromium.h:
(DrawingFrame):
(WebCore::LayerRendererChromium::DrawingFrame::DrawingFrame):
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCRenderer.h:
(CCRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Make all compositor screen space transforms operate on content rects
enne@google.com [Thu, 26 Jul 2012 00:53:47 +0000 (00:53 +0000)]
[chromium] Make all compositor screen space transforms operate on content rects
https://bugs.webkit.org/show_bug.cgi?id=91807

Reviewed by Kenneth Russell.

Source/WebCore:

Previously, surface screen space transforms operated on surface
content space but layer screen space transforms operated on layer
space. For the purpose of consistency, unify these two so that they
both operate on content space.

No tests, because no change in behavior expected. Just a refactoring.

* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/cc/CCDebugRectHistory.cpp:
(WebCore::CCDebugRectHistory::savePaintRects):
(WebCore::CCDebugRectHistory::savePropertyChangedRects):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsInternal):
(WebCore::CCLayerTreeHostCommon::findLayerThatIsHitByPoint):
* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

Source/WebKit/chromium:

Update tests that deal with screen space transforms to reflect this change.

* tests/CCLayerTreeHostCommonTest.cpp:
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHit testing in one column or in the gap between cloumns along the block axis can...
mitz@apple.com [Thu, 26 Jul 2012 00:30:35 +0000 (00:30 +0000)]
Hit testing in one column or in the gap between cloumns along the block axis can return a result from the wrong column
https://bugs.webkit.org/show_bug.cgi?id=92311

Reviewed by Anders Carlsson.

Source/WebCore:

Tests: fast/multicol/hit-test-end-of-column.html
       fast/multicol/hit-test-gap-block-axis.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren): To prevent hits after the last
line on a given column from returning the next line in the next column, added a check if
the hit occurred within the pagination strut of a line. Covered by the first test.
(WebCore::RenderBlock::adjustPointToColumnContents): Added clamp-to-column logic for the
block-axis case. This prevents hits near the bottom of the top half of the gap from bleeding
into the top of the next column. Covered by the second test.

LayoutTests:

* fast/multicol/hit-test-end-of-column-expected.txt: Added.
* fast/multicol/hit-test-end-of-column.html: Added.
* fast/multicol/hit-test-gap-block-axis-expected.txt: Added.
* fast/multicol/hit-test-gap-block-axis.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Make db.version return an integer if appropriate
dgrogan@chromium.org [Thu, 26 Jul 2012 00:24:57 +0000 (00:24 +0000)]
IndexedDB: Make db.version return an integer if appropriate
https://bugs.webkit.org/show_bug.cgi?id=92195

Reviewed by Tony Chang.

Make use of the existing IDBAny mechanism to return an integer if
integer versions have been used.

No new tests - no change in behavior expected.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::version):
(WebCore):
* Modules/indexeddb/IDBDatabase.h:
(IDBDatabase):
* Modules/indexeddb/IDBDatabase.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove JSObject::m_inheritorID
mhahnenberg@apple.com [Thu, 26 Jul 2012 00:12:58 +0000 (00:12 +0000)]
Remove JSObject::m_inheritorID
https://bugs.webkit.org/show_bug.cgi?id=88378

Reviewed by Filip Pizlo.

This is rarely used, and not performance critical (the commonly accessed copy is cached on JSFunction),
and most objects don't need an inheritorID (this value is only used if the object is used as a prototype).
Instead use a private named value in the object's property storage.

* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::emitAllocateBasicJSObject): No need m_inheritorID to initialize!
* jit/JITInlineMethods.h:
(JSC::JIT::emitAllocateBasicJSObject): No need m_inheritorID to initialize!
* llint/LowLevelInterpreter.asm: No need m_inheritorID to initialize!
* runtime/JSGlobalData.h:
(JSGlobalData): Added private name 'm_inheritorIDKey'.
* runtime/JSGlobalThis.cpp:
(JSC::JSGlobalThis::setUnwrappedObject): resetInheritorID is now passed a JSGlobalData&.
* runtime/JSObject.cpp:
(JSC::JSObject::visitChildren): No m_inheritorID to be marked.
(JSC::JSFinalObject::visitChildren): No m_inheritorID to be marked.
(JSC::JSObject::createInheritorID): Store the newly created inheritorID in the property map. Make sure
it's got the DontEnum attribute!!
* runtime/JSObject.h:
(JSObject):
(JSC::JSObject::resetInheritorID): Remove the inheritorID from property storage.
(JSC):
(JSC::JSObject::inheritorID): Read the inheritorID from property storage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Fix infinite loop issue for chromium android layout test
commit-queue@webkit.org [Thu, 26 Jul 2012 00:05:13 +0000 (00:05 +0000)]
[Chromium] Fix infinite loop issue for chromium android layout test
https://bugs.webkit.org/show_bug.cgi?id=92197

Patch by Wei James <james.wei@intel.com> on 2012-07-25
Reviewed by Adam Barth.

The change brought in by r123530 will cause infinite loop when running
Chromium Android Layout Test.
Revert the change for this line only.

* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort._build_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium change to disable failing WebViewTest.AutoResizeInBetweenSizes.
atwilson@chromium.org [Wed, 25 Jul 2012 23:48:02 +0000 (23:48 +0000)]
Unreviewed chromium change to disable failing WebViewTest.AutoResizeInBetweenSizes.
https://bugs.webkit.org/show_bug.cgi?id=92318

* tests/WebViewTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert HTML parser to handle 8-bit resources without converting to UChar*
msaboff@apple.com [Wed, 25 Jul 2012 23:42:07 +0000 (23:42 +0000)]
Convert HTML parser to handle 8-bit resources without converting to UChar*
https://bugs.webkit.org/show_bug.cgi?id=90321

Reviewed by Geoffrey Garen.

Source/WebCore:

No new tests, no new functionality therefore covered by existing tests.

Changed the parsing of HTML to handle 8-bit strings without converting the
whole string to 16-bits.  Primary change was to use the appropriate
character pointer type (LChar* or UChar*) depending on the source string.
This access is abstracted in SegmentedSubstring by getCurrentChar{8,16} and
incrementAndGetCurrentChar{8,16} methods.  In SegmentedString, the advance()
and advanceAndUpdateLineNumber() methods have been refactored into a
state machine managed pair of function pointers.  The possible functions
have not only the 8 and 16 bitness factored out, they also have the
"exclude line numbers" logic factored out for advanceAndUpdateLineNumber().
This provides a net speed-up even with the 8/16 bit testing.
Other changes involve using String methods to access and compare with the
source data.

* html/FTPDirectoryDocument.cpp:
(WebCore::FTPDirectoryDocumentParser::append): Changed to use currentChar()
instead of SegmentedString '*' operator.
* html/parser/HTMLEntityParser.cpp: Changed to use currentChar() instead of
SegmentedString '*' operator.
* html/parser/HTMLParserIdioms.cpp:
(WebCore::stripLeadingAndTrailingHTMLSpaces): Added 8-bit fast path.
* html/parser/HTMLSourceTracker.cpp:
(WebCore::HTMLSourceTracker::sourceForToken): Changed to use currentChar() instead of
SegmentedString '*' operator.
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::script): Updated to use new String::dataSize() method.
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::operator=):
(WebCore::SegmentedString::clear):
(WebCore::SegmentedString::append):
(WebCore::SegmentedString::prepend):
(WebCore::SegmentedString::advanceSubstring):
(WebCore::SegmentedString::advance): Changed to be a wrapper that invokes current
advance function.
(WebCore::SegmentedString::advance8): Fast path advance function for 8 bit data.
(WebCore::SegmentedString::advance16): Fast path advance function for 16 bit data.
(WebCore::SegmentedString::advanceAndUpdateLineNumber8IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 8 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceAndUpdateLineNumber16IncludeLineNumbers): Fast
path advanceAndUpdateLineNumber for 16 bit data when we need to update the line number.
(WebCore::SegmentedString::advanceSlowCase): Slow case advance function for both
8 and 16 bit advance.
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase): Slow case
advanceAndUpdateLineNumber function for both 8 and 16 bit data.
(WebCore::SegmentedString::advanceEmpty): Advance function when input has been exhausted.
* platform/text/SegmentedString.h:
(WebCore::SegmentedSubstring::SegmentedSubstring):
(WebCore::SegmentedSubstring::clear):
(SegmentedSubstring):
(WebCore::SegmentedSubstring::is8Bit): New getter.
(WebCore::SegmentedSubstring::appendTo):
(WebCore::SegmentedSubstring::getCurrentChar8): New getter for the 8 bit case.
(WebCore::SegmentedSubstring::getCurrentChar16): New getter for the 16 bit case.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar8): New wrapper functions
that pre-increments the 8 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar16): New wrapper functions
that pre-increments the 16 bit pointer and returns the next character.
(WebCore::SegmentedSubstring::currentSubString):
(WebCore::SegmentedSubstring::getCurrentChar):
(WebCore::SegmentedSubstring::incrementAndGetCurrentChar):
(WebCore::SegmentedString::SegmentedString):
(WebCore::SegmentedString::push):
(WebCore::SegmentedString::isEmpty):
(WebCore::SegmentedString::lookAhead):
(WebCore::SegmentedString::lookAheadIgnoringCase):
(WebCore::SegmentedString::advance):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(WebCore::SegmentedString::advanceAndASSERT):
(WebCore::SegmentedString::advanceAndASSERTIgnoringCase):
(WebCore::SegmentedString::advancePastNonNewline):
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(WebCore::SegmentedString::currentChar):
(WebCore::SegmentedString::setSlowCase): Set advance function pointers to slow case
functions.
(WebCore::SegmentedString::decrementAndCheckLength): Decrement substring length and
change to slow case functions when only one character left.
(WebCore::SegmentedString::setAdvanceFunctionPointers): Select appropriate advance
functions based on current substring.
(WebCore::SegmentedString::lookAheadInline): Changed to use String::startsWith().
(WebCore::SegmentedString::lookAheadSlowCase):
* xml/parser/CharacterReferenceParserInlineMethods.h:
(WebCore::consumeCharacterReference): Changed to use currentChar() instead of
SegmentedString '*' operator.
* xml/parser/MarkupTokenizerBase.h:
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::nextInputCharacter):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek): Changed to use
currentChar() instead of SegmentedString '*' operator.
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):

Source/WTF:

* wtf/text/WTFString.h:
(WTF::String::dataSize): New method to return the number of bytes
the string requires.  This replaces a harcoded calculation based on
length and sizeof(UChar).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@123679 268f45cc-cd09-0410-ab3c-d52691b4dbfc