WebKit-https.git
4 years agoFix quirks in CMake build on Mac and Windows
achristensen@apple.com [Wed, 22 Jul 2015 17:04:03 +0000 (17:04 +0000)]
Fix quirks in CMake build on Mac and Windows
https://bugs.webkit.org/show_bug.cgi?id=147174

Reviewed by Gyuyoung Kim.

.:

* CMakeLists.txt:
* Source/cmake/OptionsWindows.cmake:
Added options I removed in r187022. They are indeed needed.
* Source/cmake/WebKitFS.cmake:
Make the DerivedSources/WebKit directory.

Source/JavaScriptCore:

* PlatformMac.cmake:
Add JSRemoteInspector.cpp and remove semicolon from command to make it actually run.

Source/WebCore:

* PlatformMac.cmake:
Removed files that don't exist any more.
* platform/win/WindowsTouch.h:
Only use definitions of touch structures when compiling with VS2012.

Source/WebKit:

* PlatformMac.cmake:
Fixed syntax, removed files that don't exist any more.

Source/WebKit/win:

* WebView.cpp:
Include winuser.h to get definitions of touch-related structures like tagGESTUREINFO.

Tools:

* CMakeLists.txt:
Don't build DumpRenderTree with CMake for now (until we get that working).
* WinLauncher/CMakeLists.txt:
Renamed WinLauncherLauncher to WinLauncher and WinLauncher to WinLauncherLib to match the Visual Studio build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix cast-align warning in NetworkStateNotifierEfl.cpp
ossy@webkit.org [Wed, 22 Jul 2015 16:08:03 +0000 (16:08 +0000)]
Fix cast-align warning in NetworkStateNotifierEfl.cpp
https://bugs.webkit.org/show_bug.cgi?id=145915

Reviewed by Gyuyoung Kim.

* platform/network/efl/NetworkStateNotifierEfl.cpp:
(WebCore::NetworkStateNotifier::readSocketCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Seccomp Filters] Add helpers to get XDG base directory locations
mcatanzaro@igalia.com [Wed, 22 Jul 2015 15:56:50 +0000 (15:56 +0000)]
[Seccomp Filters] Add helpers to get XDG base directory locations
https://bugs.webkit.org/show_bug.cgi?id=142982

Reviewed by Zan Dobersek.

* PlatformEfl.cmake:
* PlatformGTK.cmake:
* Shared/linux/SeccompFilters/XDGBaseDirectory.h: Added.
* Shared/linux/SeccompFilters/XDGBaseDirectoryGLib.cpp: Added.
(WebKit::userHomeDirectory):
(WebKit::userCacheDirectory):
(WebKit::userConfigDirectory):
(WebKit::userDataDirectory):
(WebKit::userRuntimeDirectory):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Change syntax highlighting color for regular expressions to make them...
nvasilyev@apple.com [Wed, 22 Jul 2015 15:44:04 +0000 (15:44 +0000)]
Web Inspector: Change syntax highlighting color for regular expressions to make them more readable
https://bugs.webkit.org/show_bug.cgi?id=146956

Reviewed by Timothy Hatcher.

* UserInterface/Views/FormattedValue.css:
(.formatted-regexp):
* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.syntax-highlighted :matches(.css-string, .javascript-string, .html-attribute-value)):
(.syntax-highlighted .javascript-regexp):
(.syntax-highlighted :matches(.css-string, .javascript-string, .javascript-regexp, .html-attribute-value)): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[l10n] Updated Swedish translation
mcatanzaro@igalia.com [Wed, 22 Jul 2015 14:57:53 +0000 (14:57 +0000)]
[l10n] Updated Swedish translation
https://bugs.webkit.org/show_bug.cgi?id=147190

Patch by Josef Andersson <josef.andersson@fripost.org> on 2015-07-22

* sv.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL][WK2] EWK2ContextTestMultipleProcesses.ewk_context_network_process_model fails...
gyuyoung.kim@webkit.org [Wed, 22 Jul 2015 14:53:31 +0000 (14:53 +0000)]
[EFL][WK2] EWK2ContextTestMultipleProcesses.ewk_context_network_process_model fails to pass
https://bugs.webkit.org/show_bug.cgi?id=142967

Reviewed by Csaba Osztrogonác.

Though processIdentifier() can return 0 when a page is not closed, ewk_context_network_process_model has
not been considered process id can be 0. This patch adds a protection logic which doesn't test when process
id is 0 at the moment.

* UIProcess/API/efl/tests/test_ewk2_context.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK][EFL] Remove dead functions in LocalizedStrings
ryuan.choi@navercorp.com [Wed, 22 Jul 2015 13:20:40 +0000 (13:20 +0000)]
[GTK][EFL] Remove dead functions in LocalizedStrings
https://bugs.webkit.org/show_bug.cgi?id=147188

Reviewed by Csaba Osztrogonác.

* platform/efl/LocalizedStringsEfl.cpp:
(WebCore::contextMenuItemTagHideMediaControls):
(WebCore::contextMenuitemTagHideMediaControls): Fixed typo since r152117.
(WebCore::inactivePluginText): Deleted since r151530.
(WebCore::textTrackClosedCaptionsText): Deleted since r141864.
* platform/gtk/LocalizedStringsGtk.cpp:
(WebCore::inactivePluginText): Deleted since r151530.
(WebCore::textTrackClosedCaptionsText): Deleted since r141864.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[check-webkit-style] .lut.h files shouldn't raise a sorting issue
calvaris@igalia.com [Wed, 22 Jul 2015 08:15:48 +0000 (08:15 +0000)]
[check-webkit-style] .lut.h files shouldn't raise a sorting issue
https://bugs.webkit.org/show_bug.cgi?id=147146

Reviewed by Darin Adler.

* Scripts/webkitpy/style/checkers/cpp.py:
(check_include_line): Avoid checking previous lines if it it is a lut.h include.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(OrderOfIncludesTest.test_check_alphabetical_include_order): Added test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Fix some warnings when generating GTK+ HTML API docs.
carlosgc@webkit.org [Wed, 22 Jul 2015 08:13:17 +0000 (08:13 +0000)]
Unreviewed. Fix some warnings when generating GTK+ HTML API docs.

* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add
WebKitWebsiteDataManager and WebKitWebEditor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Update OptionsGTK.cmake and NEWS for 2.9.4 release.
carlosgc@webkit.org [Wed, 22 Jul 2015 07:10:04 +0000 (07:10 +0000)]
Unreviewed. Update OptionsGTK.cmake and NEWS for 2.9.4 release.

.:

* Source/cmake/OptionsGTK.cmake: Bump version numbers.

Source/WebKit2:

* gtk/NEWS: Add release notes for 2.9.4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CSS Selectors Level 4] Add #ifdefs to the new '>>' descendant combinator
benjamin@webkit.org [Wed, 22 Jul 2015 05:23:06 +0000 (05:23 +0000)]
[CSS Selectors Level 4] Add #ifdefs to the new '>>' descendant combinator
https://bugs.webkit.org/show_bug.cgi?id=147184

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-07-21
Reviewed by Anders Carlsson.

Now that '>>>' is dead, the combinator '>>' is at risk.

This patch #ifdef all that code with the other experimental
features from Level 4.

* css/CSSGrammar.y.in:
* css/CSSParserValues.cpp:
(WebCore::CSSParserSelector::appendTagHistory):
* css/CSSParserValues.h:
* css/CSSSelector.cpp:
(WebCore::CSSSelector::CSSSelector):
(WebCore::CSSSelector::selectorText):
* css/CSSSelector.h:
(WebCore::CSSSelector::CSSSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUpdate Mac test results for libxml2 v2.9.2.
ap@apple.com [Wed, 22 Jul 2015 03:51:12 +0000 (03:51 +0000)]
Update Mac test results for libxml2 v2.9.2.

These results will probably become cross-platform eventually, but for now it's just Mac.

* platform/mac-yosemite/fast/dom/adopt-attribute-crash-expected.txt: Copied from LayoutTests/fast/dom/adopt-attribute-crash-expected.txt.
* platform/mac-yosemite/fast/parser: Added.
* platform/mac-yosemite/fast/parser/xml-colon-entity-expected.txt: Copied from LayoutTests/fast/parser/xml-colon-entity-expected.txt.
* platform/mac-yosemite/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Copied from LayoutTests/fast/parser/xml-declaration-missing-ending-mark-expected.txt.
* platform/mac-yosemite/fast/xsl: Added.
* platform/mac-yosemite/fast/xsl/xslt-extra-content-at-end-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png.
* platform/mac-yosemite/fast/xsl/xslt-extra-content-at-end-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt.
* platform/mac-yosemite/fast/xsl/xslt-missing-namespace-in-xslt-expected.png: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.png.
* platform/mac-yosemite/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt: Copied from LayoutTests/platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt.
* platform/mac-yosemite/svg/custom: Added.
* platform/mac-yosemite/svg/custom/bug78807-expected.txt: Copied from LayoutTests/svg/custom/bug78807-expected.txt.
* platform/mac-yosemite/svg/custom/missing-xlink-expected.png: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.png.
* platform/mac-yosemite/svg/custom/missing-xlink-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/missing-xlink-expected.txt.
* platform/mac-yosemite/svg/custom/path-bad-data-expected.png: Copied from LayoutTests/platform/mac/svg/custom/path-bad-data-expected.png.
* platform/mac-yosemite/svg/custom/path-bad-data-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/path-bad-data-expected.txt.
* platform/mac-yosemite/svg/custom/use-font-face-crash-expected.png: Copied from LayoutTests/platform/mac/svg/custom/use-font-face-crash-expected.png.
* platform/mac-yosemite/svg/custom/use-font-face-crash-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/use-font-face-crash-expected.txt.
* platform/mac/fast/dom/adopt-attribute-crash-expected.txt: Added.
* platform/mac/fast/parser/xml-colon-entity-expected.txt: Added.
* platform/mac/fast/parser/xml-declaration-missing-ending-mark-expected.txt: Added.
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.png:
* platform/mac/fast/xsl/xslt-extra-content-at-end-expected.txt:
* platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.png:
* platform/mac/fast/xsl/xslt-missing-namespace-in-xslt-expected.txt:
* platform/mac/svg/custom/bug78807-expected.txt: Added.
* platform/mac/svg/custom/missing-xlink-expected.png:
* platform/mac/svg/custom/missing-xlink-expected.txt:
* platform/mac/svg/custom/path-bad-data-expected.png:
* platform/mac/svg/custom/path-bad-data-expected.txt:
* platform/mac/svg/custom/use-font-face-crash-expected.png:
* platform/mac/svg/custom/use-font-face-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: console.log("%d", 0) or console.log("%d", "str") show nothing, expecte...
commit-queue@webkit.org [Wed, 22 Jul 2015 02:35:18 +0000 (02:35 +0000)]
Web Inspector: console.log("%d", 0) or console.log("%d", "str") show nothing, expected Number or NaN
https://bugs.webkit.org/show_bug.cgi?id=147163

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-21
Reviewed by Timothy Hatcher.

* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._formatWithSubstitutionString.append):
When appending the result for a substitution formatter, don't check against a
falsey value, check against undefined. This will allow falsely values like
0 and NaN to be output as expected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: [Mac] "Open Image In New Window" context menu item does nothing on...
commit-queue@webkit.org [Wed, 22 Jul 2015 01:49:40 +0000 (01:49 +0000)]
Web Inspector: [Mac] "Open Image In New Window" context menu item does nothing on an image
https://bugs.webkit.org/show_bug.cgi?id=147175

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-21
Reviewed by Timothy Hatcher.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController webView:contextMenuItemsForElement:defaultMenuItems:]):
Remove default context menus that won't work in the inspector page.

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::getContextMenuFromProposedMenu):
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
Remove default context menus that won't work in the inspector page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Node highlights are wrong when the page is zoomed
commit-queue@webkit.org [Wed, 22 Jul 2015 01:46:00 +0000 (01:46 +0000)]
Web Inspector: Node highlights are wrong when the page is zoomed
https://bugs.webkit.org/show_bug.cgi?id=147177

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-21
Reviewed by Simon Fraser.

* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::update):
Remove scaling that appears to no longer be needed, it was double
scaling the overlay content and misplacing it in the process.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDefault media controls use a serif font, which seems wrong
dino@apple.com [Wed, 22 Jul 2015 01:39:17 +0000 (01:39 +0000)]
Default media controls use a serif font, which seems wrong
https://bugs.webkit.org/show_bug.cgi?id=147179
<rdar://problem/21931728>

Reviewed by Simon Fraser.

The captions menu (and other text) should use a system style,
-webkit-small-control.

* Modules/mediacontrols/mediaControlsApple.css:
(::-webkit-media-controls):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd newTarget accessor to JS constructor written in C++
utatane.tea@gmail.com [Wed, 22 Jul 2015 00:29:39 +0000 (00:29 +0000)]
Add newTarget accessor to JS constructor written in C++
https://bugs.webkit.org/show_bug.cgi?id=147160

Reviewed by Geoffrey Garen.

This patch adds `ExecState#newTarget()` which returns `new.target` defined in ECMA262 6th.
It enables some C++ constructors (like Intl.XXX constructors) to leverage this to complete
its implementation.

When the constructor is called, |this| in the arguments is used for storing new.target instead.
So by adding the accessor for |this|, JS constructor written in C++ can access new.target.

And at the same time, this patch extends the existing `construct` to accept new.target value.
It is corresponding to the spec's Construct abstract operation.

* interpreter/CallFrame.h:
(JSC::ExecState::newTarget):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeConstruct):
* interpreter/Interpreter.h:
* runtime/ConstructData.cpp:
(JSC::construct):
* runtime/ConstructData.h:
(JSC::construct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoExposed method to query device by UID
commit-queue@webkit.org [Wed, 22 Jul 2015 00:06:05 +0000 (00:06 +0000)]
Exposed method to query device by UID
https://bugs.webkit.org/show_bug.cgi?id=147117
<rdar://problem/21904678>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-21
Reviewed by Eric Carlson.

* platform/mediastream/mac/AVCaptureDeviceManager.h: Added method to
query device by UID
* platform/mediastream/mac/AVCaptureDeviceManager.mm: Ditto
(WebCore::AVCaptureDeviceManager::sourceWithUID): Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, fix a lot of tests. Need to initialize WTF threading sooner.
fpizlo@apple.com [Wed, 22 Jul 2015 00:01:46 +0000 (00:01 +0000)]
Unreviewed, fix a lot of tests. Need to initialize WTF threading sooner.

* jsc.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Content Extensions] Use a jump table when consecutive transitions have different...
benjamin@webkit.org [Tue, 21 Jul 2015 23:45:00 +0000 (23:45 +0000)]
[Content Extensions] Use a jump table when consecutive transitions have different targets
https://bugs.webkit.org/show_bug.cgi?id=147099

Reviewed by Alex Christensen.

Source/WebCore:

When handling consecutive single transitions, merge them into
a jump table instead of creating many individual CheckValue.

From local testing on x86_64, it reduces the bytecode size by about 5%
and improve the runtime by about 10%.

* contentextensions/DFABytecode.h:
(WebCore::ContentExtensions::instructionSizeWithArguments):
* contentextensions/DFABytecodeCompiler.cpp:
(WebCore::ContentExtensions::DFABytecodeCompiler::extractJumpTable):
(WebCore::ContentExtensions::DFABytecodeCompiler::transitions):
(WebCore::ContentExtensions::DFABytecodeCompiler::checkForJumpTableMaxBytecodeSize):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileJumpTable):
(WebCore::ContentExtensions::DFABytecodeCompiler::nodeTransitionsMaxBytecodeSize):
(WebCore::ContentExtensions::DFABytecodeCompiler::compileNodeTransitions):
(WebCore::ContentExtensions::DFABytecodeCompiler::ranges): Deleted.
* contentextensions/DFABytecodeCompiler.h:
* contentextensions/DFABytecodeInterpreter.cpp:
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpetJumpTable):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
* contentextensions/DFABytecodeInterpreter.h:

Source/WebKit2:

* UIProcess/API/APIUserContentExtensionStore.h:

LayoutTests:

Add some primitive testing to make sure the code is covered.

* http/tests/contentextensions/test-jump-table-bytecode-generation-expected.txt: Added.
* http/tests/contentextensions/test-jump-table-bytecode-generation.html: Added.
* http/tests/contentextensions/test-jump-table-bytecode-generation.html.json: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the build following <https://trac.webkit.org/changeset/187129>
dbates@webkit.org [Tue, 21 Jul 2015 23:33:37 +0000 (23:33 +0000)]
Fix the build following <https://trac.webkit.org/changeset/187129>
(https://bugs.webkit.org/show_bug.cgi?id=147112)

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::reinstateNetworkProcessAssertionState): Guard implementation with PLATFORM(IOS)
since this logic is specific to the iOS port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRename the 'View' log channel to 'Printing'
simon.fraser@apple.com [Tue, 21 Jul 2015 23:31:48 +0000 (23:31 +0000)]
Rename the 'View' log channel to 'Printing'
https://bugs.webkit.org/show_bug.cgi?id=147172

Reviewed by Zalan Bujtas.

"View" was a terrible name for a log channel that was all about printing.
Sort the log channels.

* Platform/Logging.h:
* UIProcess/API/mac/WKView.mm:
(-[WKView drawRect:]):
(-[WKView printOperationWithPrintInfo:forFrame:]):
* UIProcess/mac/WKPrintingView.mm:
(-[WKPrintingView _preparePDFDataForPrintingOnSecondaryThread]):
(pageDidComputePageRects):
(-[WKPrintingView knowsPageRange:]):
(-[WKPrintingView drawRect:]):
(-[WKPrintingView rectForPage:]):
(-[WKPrintingView beginDocument]):
(-[WKPrintingView endDocument]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd a logging channel for Layout, remove the LiveConnect channel
simon.fraser@apple.com [Tue, 21 Jul 2015 23:31:44 +0000 (23:31 +0000)]
Add a logging channel for Layout, remove the LiveConnect channel
https://bugs.webkit.org/show_bug.cgi?id=147170

Reviewed by Zalan Bujtas.

Add a layout logging channel to WebCore, and remove the LiveConnect channel.

Source/WebCore:

* page/FrameView.cpp:
(WebCore::FrameView::adjustViewSize):
(WebCore::FrameView::forceLayoutParentViewIfNeeded):
(WebCore::FrameView::layout):
(WebCore::FrameView::performPostLayoutTasks):
(WebCore::FrameView::autoSizeIfEnabled):
* platform/Logging.h:

Source/WebKit/mac:

* Misc/WebKitLogging.h:
* Plugins/WebNetscapePluginPackage.mm:
(-[WebNetscapePluginPackage _tryLoad]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoStyleSheetContents::wrapperInsertRule() can create rules that overflow RuleData's...
benjamin@webkit.org [Tue, 21 Jul 2015 23:17:02 +0000 (23:17 +0000)]
StyleSheetContents::wrapperInsertRule() can create rules that overflow RuleData's selector index
https://bugs.webkit.org/show_bug.cgi?id=147144

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-07-21
Reviewed by Alex Christensen.

Source/WebCore:

RuleData identifies selectors by the index in a large array. The index only has 13 bits
so rules with more than 8192 selectors should be split.

One of the paths was not splitting the rule: StyleSheetContents::wrapperInsertRule().
When rules with too many selectors were added, the index would overflow and
some RuleData would point to selectors in the middle of selector chains. The resulting
behavior is random based on the selectors and the DOM.

We cannot easily fix that because the CSS OM API do not expect to create
several rules in response to calls to the API.
In this patch, I don't do anything fancy and just let the calls fail
if we cannot use the rules safely.

Content Extensions were also running into this problem. Large Selector lists are
pretty common, and ContentExtensionStyleSheet::addDisplayNoneSelector() was
overflowing the RuleData, creating broken page.

Unlike CSSOM, there is no problem with splitting rules coming from Content Extensions.
Instead of creating new APIs for that case, I rely on the parser to extend the StyleSheetContents.
That code already knows how to break rules correctly.

Tests: fast/css/insert-rule-overflow-rule-data.html
       http/tests/contentextensions/css-display-none-overflows-rule-data-1.html
       http/tests/contentextensions/css-display-none-overflows-rule-data-2.html

* contentextensions/ContentExtensionStyleSheet.cpp:
(WebCore::ContentExtensions::ContentExtensionStyleSheet::addDisplayNoneSelector):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::wrapperInsertRule):

LayoutTests:

This bug was affecting two parts of WebKit:
-In CSSOM, StyleSheet.insertRule() could create bogus rules.
 The new test verifies that the call fails instead of creating undefined
 behaviors.
-In ContentExtensions, large selectors are now working correctly. The tests
 cover the case of a default stylesheet and an dynamic stylesheet.

* fast/css/insert-rule-overflow-rule-data-expected.txt: Added.
* fast/css/insert-rule-overflow-rule-data.html: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-1-expected.txt: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-1.html: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-1.html.json: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-2-expected.txt: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-2.html: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-2.html.json: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-3-expected.txt: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-3.html: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-3.html.json: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-4-expected.txt: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-4.html: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-4.html.json: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-5-expected.txt: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-5.html: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-5.html.json: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-6-expected.txt: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-6.html: Added.
* http/tests/contentextensions/css-display-none-overflows-rule-data-6.html.json: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Add needTouchEvents() stub to WebChromeClient.h for a successful build with...
commit-queue@webkit.org [Tue, 21 Jul 2015 23:14:43 +0000 (23:14 +0000)]
[Win] Add needTouchEvents() stub to WebChromeClient.h for a successful build with ENABLE_TOUCH_EVENTS=ON
https://bugs.webkit.org/show_bug.cgi?id=147141

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-07-21
Reviewed by Darin Adler.

* WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Menu drop down such as on nike.com does not stay
zalan@apple.com [Tue, 21 Jul 2015 22:35:57 +0000 (22:35 +0000)]
[iOS] Menu drop down such as on nike.com does not stay
https://bugs.webkit.org/show_bug.cgi?id=147047
rdar://problem/21046961

Reviewed by Benjamin Poulain.

This is a workaround for unintended scrolling while scaling.
(Based on Benjamin Poulain's WIP patch for webkit.org/b/136904)

In certain cases when scaling would result in moving the scrollview (which would trigger
a scroll event on WebCore side), zoomRect is called instead of setZoomScale to ensure
that the scroll position stays intact.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _didCommitLayerTree:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Keyboard bold/italic/underline keys don't highlight after being
jhoneycutt@apple.com [Tue, 21 Jul 2015 22:34:27 +0000 (22:34 +0000)]
[iOS] Keyboard bold/italic/underline keys don't highlight after being
tapped to style a selection
https://bugs.webkit.org/show_bug.cgi?id=147164
<rdar://problem/21630806>

Reviewed by Ryosuke Niwa.

* editing/cocoa/EditorCocoa.mm:
(WebCore::Editor::styleForSelectionStart):
Use adjustedSelectionStartForStyleComputation(), which will ensure that
we're at the start of the selected node, not at the end of the node
before the selection.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWTFCrash() in WebKit::WebProcess::networkConnection()
dbates@webkit.org [Tue, 21 Jul 2015 22:33:53 +0000 (22:33 +0000)]
WTFCrash() in WebKit::WebProcess::networkConnection()
https://bugs.webkit.org/show_bug.cgi?id=147112
<rdar://problem/18477459>

Reviewed by Gavin Barraclough.

Source/WebKit2:

Fixes an issue where a newly launched network process may be jetsam'd because it has not
taken a process assertion between the time it was launched and the time when a web process
makes use of it.

Initially a network process does not have a process assertion. A process assertion is taken
(if one has not been taken) for the network process when a process assertion is taken for at
least one web process. When the network process crashes a WebProcess may ultimately launch a
new network process in WebProcess::networkConnection(). The new network process may be jetsam'd
immediately when the system is under some measure pressure because it has a low jetsam priority,
0 (since it does not have a process assertion and higher priority implies that a process is less
likely to be jetsam'd). And the logic in WebProcess::networkConnection() explicitly calls
CRASH() if the newly launched network process crashes immediately. Towards preventing the newly
launched network process from being jetsam'd we should obtain a process assertion for it.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::WebProcessPool): Initialize m_didNetworkProcessCrash to false.
(WebKit::WebProcessPool::ensureNetworkProcess): If the network process crashed (m_didNetworkProcessCrash == true)
then tell each process in the pool to reinstate their network activity token for the new network process.
(WebKit::WebProcessPool::networkProcessCrashed): Set m_didNetworkProcessCrash to true when the
network process crashed.
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::reinstateNetworkProcessAssertionState): Added.
(WebKit::WebProcessProxy::didSetAssertionState): Add assert to ensure we never have both
a background- and foreground- activity token for the network process.
* UIProcess/WebProcessProxy.h:

Source/WTF:

Add explicit boolean conversion function and remove overload of operator! to support
checking whether an activity token is valid more directly than using the overloaded operator!.

* wtf/RefCounter.h:
(WTF::RefCounter::Token::operator bool): Added.
(WTF::RefCounter::Token::operator!): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoPlacing video in fullscreen caused WebKit crash at WebCore::Range::textQuads
timothy_horton@apple.com [Tue, 21 Jul 2015 22:16:16 +0000 (22:16 +0000)]
Placing video in fullscreen caused WebKit crash at WebCore::Range::textQuads
https://bugs.webkit.org/show_bug.cgi?id=147166
<rdar://problem/21928558>

Reviewed by Simon Fraser.

* editing/FrameSelection.cpp:
(WebCore::FrameSelection::getClippedVisibleTextRectangles):
Check the Range, as always.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[El Capitan] Test gardening
mmaxfield@apple.com [Tue, 21 Jul 2015 21:43:04 +0000 (21:43 +0000)]
[El Capitan] Test gardening
https://bugs.webkit.org/show_bug.cgi?id=147059

* platform/mac-yosemite/fast/dom/52776-expected.png: Copied from LayoutTests/platform/mac/fast/dom/52776-expected.png.
* platform/mac-yosemite/fast/text/complex-text-opacity-expected.png: Copied from LayoutTests/platform/mac/fast/text/complex-text-opacity-expected.png.
* platform/mac-yosemite/fast/text/font-weights-expected.png: Copied from LayoutTests/platform/mac/fast/text/font-weights-expected.png.
* platform/mac-yosemite/fast/text/indic-expected.png: Copied from LayoutTests/platform/mac/fast/text/indic-expected.png.
* platform/mac-yosemite/fast/text/indic-expected.txt: Copied from LayoutTests/platform/mac/fast/text/indic-expected.txt.
* platform/mac-yosemite/fast/text/international/bidi-AN-after-L-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-AN-after-L-expected.png.
* platform/mac-yosemite/fast/text/international/bidi-mirror-he-ar-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png.
* platform/mac-yosemite/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png.
* platform/mac-yosemite/fast/text/international/bidi-neutral-run-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/bidi-neutral-run-expected.png.
* platform/mac-yosemite/fast/text/international/danda-space-expected.png: Copied from LayoutTests/platform/mac/fast/text/international/danda-space-expected.png.
* platform/mac-yosemite/fast/text/international/danda-space-expected.txt: Copied from LayoutTests/platform/mac/fast/text/international/danda-space-expected.txt.
* platform/mac-yosemite/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png.
* platform/mac-yosemite/svg/text/text-intro-05-t-expected.png: Copied from LayoutTests/platform/mac/svg/text/text-intro-05-t-expected.png.
* platform/mac/fast/dom/52776-expected.png:
* platform/mac/fast/dom/52776-expected.txt:
* platform/mac/fast/text/arabic-times-new-roman-expected.png:
* platform/mac/fast/text/arabic-times-new-roman-expected.txt:
* platform/mac/fast/text/complex-text-opacity-expected.png:
* platform/mac/fast/text/complex-text-opacity-expected.txt:
* platform/mac/fast/text/font-weights-expected.png:
* platform/mac/fast/text/font-weights-expected.txt:
* platform/mac/fast/text/indic-expected.png:
* platform/mac/fast/text/indic-expected.txt:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.png:
* platform/mac/fast/text/international/bidi-AN-after-L-expected.txt:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/mac/fast/text/international/bidi-mirror-he-ar-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.png:
* platform/mac/fast/text/international/bidi-neutral-directionality-paragraph-start-expected.txt:
* platform/mac/fast/text/international/bidi-neutral-run-expected.png:
* platform/mac/fast/text/international/bidi-neutral-run-expected.txt:
* platform/mac/fast/text/international/danda-space-expected.png:
* platform/mac/fast/text/international/danda-space-expected.txt:
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1-SE/text-intro-05-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.txt:
* platform/mac/svg/text/text-intro-05-t-expected.png:
* platform/mac/svg/text/text-intro-05-t-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFixed VM pool allocation should have a reserve for allocations that cannot fail
fpizlo@apple.com [Tue, 21 Jul 2015 21:41:30 +0000 (21:41 +0000)]
Fixed VM pool allocation should have a reserve for allocations that cannot fail
https://bugs.webkit.org/show_bug.cgi?id=147154
rdar://problem/21847618

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

This adds the notion of a JIT pool reserve fraction. Some fraction, currently 1/4, of
the JIT pool is reserved for allocations that cannot fail. It makes sense to make this
a fraction rather than a constant because each allocation that can fail may cause some
number of allocations that cannot fail (for example, the OSR exit thunks that we
compile when we exit from some CodeBlock cannot fail).

I've tested this by adding a test mode where we artificially limit the JIT pool size.
Prior to the fix, we had >20 failures. Now we have none.

* heap/GCLogging.cpp:
(WTF::printInternal): I needed a dump method on Options members when debugging this.
* heap/GCLogging.h:
* jit/ExecutableAllocator.h: Raise the ARM64 limit to 32MB because 16MB is cutting it too close.
* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::FixedVMPoolExecutableAllocator): Add the ability to artificially limit JIT pool size for testing.
(JSC::ExecutableAllocator::memoryPressureMultiplier): Implement the reserve when computing memory pressure for JIT tier-up heuristics.
(JSC::ExecutableAllocator::allocate): Implement the reserve when allocating can-fail things.
* jsc.cpp: Rewire some options parsing so that CommandLine happens before we create the JIT pool.
(main):
(CommandLine::parseArguments):
(jscmain):
* runtime/Options.cpp:
(JSC::OptionRange::dump): I needed a dump method on Options members when debugging this.
(JSC::Options::initialize): This can now be called more than once.
* runtime/Options.h:

Tools:

Add a new test mode where we artificially limit JIT memory to 50KB. If our JIT OOM
mitigations work, these should all pass. Prior to this patch there were >20 failures.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoASSERT(m_suspendMessageCount >= 0) fails in ProcessThrottler::didCancelProcessSuspens...
dbates@webkit.org [Tue, 21 Jul 2015 21:39:58 +0000 (21:39 +0000)]
ASSERT(m_suspendMessageCount >= 0) fails in ProcessThrottler::didCancelProcessSuspension()
when WebContent process crashes; Network process may never voluntarily suspend
https://bugs.webkit.org/show_bug.cgi?id=147122
<rdar://problem/21906759>

Reviewed by Chris Dumez.

Fixes an issue where the network process may never voluntarily release its process assertion.

Currently the network process always sends both a ProcessReadyToSuspend and CancelPrepareToSuspend
message in response to receiving a PrepareToSuspend message and CancelPrepareToSuspend message,
respectively. The process throttler expects to receive either a ProcessReadyToSuspend message
or a CancelPrepareToSuspend message (and not both) in response to sending the message sequence
PrepareToSuspend, CancelPrepareToSuspend. When a process throttler receives both messages in
response to this sequence then its internal message count becomes imbalanced and it will
never release the process assertion it manages. One user interaction that can cause such an
imbalance, in the process throttler held by NetworkProcessProxy, is switching tabs.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::cancelPrepareToSuspend): Do not send message NetworkProcessProxy::DidCancelProcessSuspension.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didCancelProcessSuspension): Deleted.
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in: Remove message NetworkProcessProxy::DidCancelProcessSuspension.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Total download size doesn't update soon after loading
commit-queue@webkit.org [Tue, 21 Jul 2015 21:23:26 +0000 (21:23 +0000)]
Web Inspector: Total download size doesn't update soon after loading
https://bugs.webkit.org/show_bug.cgi?id=147161

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-21
Reviewed by Timothy Hatcher.

* UserInterface/Models/DefaultDashboard.js:
(WebInspector.DefaultDashboard.prototype._mainResourceDidChange):
Previously autorecording would always have made us start capturing,
however we only autorecord if users are on the Timeline tab. Just
reset the time always, a navigation happened and start the timer.

(WebInspector.DefaultDashboard.prototype._resourceSizeDidChange):
Move to a better location within the file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake sure to invalidate requests for user media after webpage reset
commit-queue@webkit.org [Tue, 21 Jul 2015 21:23:12 +0000 (21:23 +0000)]
Make sure to invalidate requests for user media after webpage reset
https://bugs.webkit.org/show_bug.cgi?id=147155
<rdar://problem/21924174>

Patch by Matthew Daiter <mdaiter@apple.com> on 2015-07-21
Reviewed by Brent Fulgham.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::resetState): Added user media reset

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSafari mis-applies "animation-fill-mode: forwards" when using fractional iteration...
simon.fraser@apple.com [Tue, 21 Jul 2015 21:19:20 +0000 (21:19 +0000)]
Safari mis-applies "animation-fill-mode: forwards" when using fractional iteration count
https://bugs.webkit.org/show_bug.cgi?id=146996

Reviewed by Dean Jackson.
Source/WebCore:

animation-fill-mode: forwards with fractional iteration counts always snapped to
1 or 0, depending on direction. Fix to compute the fill-forward state from the
correct keyframes.

If filling forwards, AnimationBase::progress() sets the elapsed time to the duration,
then uses fractionalTime() to handle animation direction mapping. If the fractionalTime
is integral, we can return early, avoiding the cost of mapping through timing functions.

Tested by existing tests.

* page/animation/AnimationBase.cpp:
(WebCore::AnimationBase::progress):
(WebCore::AnimationBase::getElapsedTime):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::fetchIntervalEndpointsForProperty): It was possible
to end up with prevIndex == nextIndex with reverse animations, which resulted
in divide-by-zero when computing scale. Fix by picking a nextIndex that is different
from prevIndex.

LayoutTests:

Progressions, improved tests.

* animations/animation-direction-reverse-fill-mode-expected.txt: New results; this is a progression.
* animations/animation-direction-reverse-fill-mode.html: Use a shorter animation. Fixed results.
* animations/fill-mode-iteration-count-non-integer-expected.txt:
* animations/fill-mode-iteration-count-non-integer.html: Use iteration counts that are not multiplies
of 0.5, so the test can differentiation between forward and backwards states. Add a non-linear timing
function to check that fill-forwards consults the timing functions. Don't print exact succeeding
results because they may have floating point values.
* animations/fill-mode-reverse-expected.txt: New results; this is a progression.
* animations/fill-mode-reverse.html: Fixed results, use gray.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix failing WK1 layout tests. Make sure to reset the text zoom scale
hyatt@apple.com [Tue, 21 Jul 2015 20:57:06 +0000 (20:57 +0000)]
Fix failing WK1 layout tests. Make sure to reset the text zoom scale
in Internals::resetToConsistentState.

Reviewed by Anders Carlsson

* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoObjectPatternNode's entry should use "const Identifier&" instead of "Identifier"
saambarati1@gmail.com [Tue, 21 Jul 2015 20:22:37 +0000 (20:22 +0000)]
ObjectPatternNode's entry should use "const Identifier&" instead of "Identifier"
https://bugs.webkit.org/show_bug.cgi?id=147156

Reviewed by Andreas Kling.

* parser/Nodes.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoObject allocation sinking phase is performing needless HashMap copies
basile_clement@apple.com [Tue, 21 Jul 2015 20:15:54 +0000 (20:15 +0000)]
Object allocation sinking phase is performing needless HashMap copies
https://bugs.webkit.org/show_bug.cgi?id=147159

Reviewed by Geoffrey Garen.

The points-to analyzer in the object allocation sinking phase is
currently performing copies of its allocation and pointers tables in
several places. While this is not a huge problem since those tables are
usually small and we are in the FTL path anyway, we still shouldn't be
doing such useless copying.

This patch also removes the DFGInsertOSRHintsForUpdate files that are
no longer needed with the new object sinking phase and should have been
removed in r186795.

* CMakeLists.txt:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj:
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.filters:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGInsertOSRHintsForUpdate.cpp: Removed.
(JSC::DFG::insertOSRHintsForUpdate): Deleted.
* dfg/DFGInsertOSRHintsForUpdate.h: Removed.
* dfg/DFGObjectAllocationSinkingPhase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Avoid using a TextIndicator if there are non-text things to indicate
timothy_horton@apple.com [Tue, 21 Jul 2015 19:58:02 +0000 (19:58 +0000)]
[iOS] Avoid using a TextIndicator if there are non-text things to indicate
https://bugs.webkit.org/show_bug.cgi?id=147152
<rdar://problem/21921061>

Reviewed by Beth Dakin.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView willPresentPreviewViewController:forPosition:inSourceView:]):
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::shouldUseTextIndicatorForLink):
(WebKit::WebPage::getPositionInformation):
Fall back to a rectangular area instead of a TextIndicator if there are any
non-inline elements inside the link.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r172417, r184065): Multiple rendering issues with fixed attached backgrou...
commit-queue@webkit.org [Tue, 21 Jul 2015 19:56:24 +0000 (19:56 +0000)]
REGRESSION (r172417, r184065): Multiple rendering issues with fixed attached background-image
https://bugs.webkit.org/show_bug.cgi?id=147049
<rdar://problem/21110936>

Patch by Said Abou-Hallawa <sabouhallawa@apple.com> on 2015-07-21
Reviewed by Simon Fraser.
Source/WebCore:

The fixed-attached background-image rendering is special. In general, to
display it, the destinationSize should be set to visibleContentSize. The
destinationLocation should be set such that the background-image does
not move with scrolling. The topContentInset should be subtracted from
the destinationLocation such that background-image can be rendered blurred
in the topContentArea. However there are cases in which these rules have to
be changed.

-- destinationSize: In the case of fixed layout size, the fixedLayoutSize
is bigger than the visibleContentSize. In this case, if the background-image
belongs to the root element, the destinationSize has to be set to fixedLayoutSize.
Otherwise it has to be set to the borderBoxSize unless the overflow is
hidden.

-- destinationLocation: If the background-image belongs to the root element, no
scroll offset to added to destinationLocation. For non-root element case,
FrameView::documentScrollOffsetRelativeToViewOrigin() should be used if no page
scaling is applied. Otherwise FrameView::scrollOffsetForFixedPosition() should be
used instead.

Tests: platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-cover.html
       platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-local.html

* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry): Ensure
the geometry for the fixed-attached background-image is calculated correctly.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateGeometry): Ensure the background layer
gets the correct size for the fixedLayoutSize mode.

LayoutTests:

fixedLayoutSize background-image rendering for root and non-root elements.

* platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-cover-expected.html: Added.
* platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-cover.html: Added.
* platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-local-expected.html: Added.
* platform/mac-wk2/tiled-drawing/fixed-layout-size-fixed-attachment-local.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAPI::Session should clean up its storage in the network process when destroyed.
akling@apple.com [Tue, 21 Jul 2015 19:54:23 +0000 (19:54 +0000)]
API::Session should clean up its storage in the network process when destroyed.
<https://webkit.org/b/147139>
<rdar://problem/21838764>

Reviewed by Anders Carlsson.

Have ~Session() send a DestroyPrivateBrowsingSession message to all networking processes
for ephemeral sessions. This plugs a NetworkStorageSession leak that could retain a large
CFNetwork object graph.

* UIProcess/API/APISession.cpp:
(API::Session::~Session):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake PluginProxy::handleMouseEvent() asynchronous.
commit-queue@webkit.org [Tue, 21 Jul 2015 19:52:29 +0000 (19:52 +0000)]
Make PluginProxy::handleMouseEvent() asynchronous.
https://bugs.webkit.org/show_bug.cgi?id=146142

Patch by Sungmann Cho <sungmann.cho@navercorp.com> on 2015-07-21
Reviewed by Anders Carlsson.

PluginProxy::handleMouseEvent() forwards the generated mouse event to PluginControllerProxy
using a synchronous message, but the recipient always reply immediately with the same value("true")
even before handling the received message. So I think PluginProxy::handleMouseEvent() is perfectly
OK to process its messages asynchronously.

Source/WebKit2:

* PluginProcess/PluginControllerProxy.cpp:
(WebKit::PluginControllerProxy::handleMouseEvent):
* PluginProcess/PluginControllerProxy.h:
* PluginProcess/PluginControllerProxy.messages.in:
* WebProcess/Plugins/PluginProxy.cpp:
(WebKit::PluginProxy::handleMouseEvent):

LayoutTests:

platform/mac-wk2/plugins/mouse-events-expected.txt was introduced by webkit.org/b/116665 to avoid
flakey tests, but from now on we can share the common expectations.

* platform/mac-wk2/plugins/mouse-events-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoExpose shrink-wrapping as UIKit support SPI
timothy_horton@apple.com [Tue, 21 Jul 2015 19:33:12 +0000 (19:33 +0000)]
Expose shrink-wrapping as UIKit support SPI
https://bugs.webkit.org/show_bug.cgi?id=147148
<rdar://problem/21920008>

* WebKit.iOS.exp:
Also export.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the !ENABLE(DETAILS_ELEMENT) build after r186598
ossy@webkit.org [Tue, 21 Jul 2015 19:21:59 +0000 (19:21 +0000)]
Fix the !ENABLE(DETAILS_ELEMENT) build after r186598
https://bugs.webkit.org/show_bug.cgi?id=147115

Reviewed by Chris Fleizach.

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::setIsExpanded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDestructuringPatternNode and DestructuringAssignmentNode should be ParserArenaFreeable
saambarati1@gmail.com [Tue, 21 Jul 2015 19:18:47 +0000 (19:18 +0000)]
DestructuringPatternNode and DestructuringAssignmentNode should be ParserArenaFreeable
https://bugs.webkit.org/show_bug.cgi?id=147140

Reviewed by Geoffrey Garen.

The descendants of DestructuringPatternNode that need destruction also
inherit from ParserArenaDeletable.

* parser/Nodes.h:
(JSC::DestructuringPatternNode::~DestructuringPatternNode):
(JSC::ObjectPatternNode::appendEntry):
(JSC::DestructuringAssignmentNode::bindings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoNeed a way to ignore text-zoom in a Web page.
hyatt@apple.com [Tue, 21 Jul 2015 18:43:46 +0000 (18:43 +0000)]
Need a way to ignore text-zoom in a Web page.
https://bugs.webkit.org/show_bug.cgi?id=27092
rdar://problem/7037987

Reviewed by Simon Fraser.

Source/WebCore:

This patch adds a new property, -webkit-text-zoom, with values of normal and reset. The reset
keyword, just as with the zoom property, can be used to ignore any inherited zoom from the
document.

Added new test in fast/text.

* Modules/mediacontrols/mediaControlsApple.css:
(audio::-webkit-media-controls-panel):
(video::-webkit-media-controls-panel):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::operator ContentDistributionType):
(WebCore::CSSPrimitiveValue::operator TextZoom):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
* css/CSSPropertyNames.in:
* css/StyleBuilderConverter.h:
(WebCore::StyleBuilderConverter::csstoLengthConversionDataWithTextZoomFactor):
* css/StyleBuilderCustom.h:
(WebCore::StyleBuilderCustom::applyValueWebkitTextSizeAdjust):
(WebCore::StyleBuilderCustom::applyValueWebkitTextZoom):
(WebCore::StyleBuilderCustom::applyTextOrBoxShadowValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::checkForZoomChange):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::changeRequiresLayout):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:
* style/StyleFontSizeFunctions.cpp:
(WebCore::Style::computedFontSizeFromSpecifiedSize):
* testing/Internals.cpp:
(WebCore::Internals::setPageZoomFactor):
(WebCore::Internals::setTextZoomFactor):
(WebCore::Internals::setUseFixedLayout):
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* fast/text/text-zoom-reset-expected.html: Added.
* fast/text/text-zoom-reset.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWinLauncher does not start on WinXP.
peavo@outlook.com [Tue, 21 Jul 2015 18:40:07 +0000 (18:40 +0000)]
WinLauncher does not start on WinXP.
https://bugs.webkit.org/show_bug.cgi?id=147147

Reviewed by Alex Christensen.

Source/WebCore:

Calling GetProcessMemoryInfo() on WinXP requires that PSAPI_VERSION is set to 1,
see https://msdn.microsoft.com/en-us/library/windows/desktop/ms683219(v=vs.85).aspx.

* WebCore.vcxproj/WebCoreCommon.props:

Source/WebKit/win:

ANGLE requires Win7, accelerated compositing must be disabled on earlier Windows versions.

* WebCoreSupport/AcceleratedCompositingContext.cpp:
(AcceleratedCompositingContext::acceleratedCompositingAvailable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd support for the new.target syntax.
commit-queue@webkit.org [Tue, 21 Jul 2015 18:18:42 +0000 (18:18 +0000)]
Add support for the new.target syntax.
https://bugs.webkit.org/show_bug.cgi?id=147051

Patch by Keith Miller <keith_miller@apple.com> on 2015-07-21
Reviewed by Yusuke Suzuki.

Add support for new.target. Essentially the implementation is, before constructor calls,
the target of a "new" is placed where "this" noramlly goes in the calling convention.
Then in the constructor before object is initialized we move the target of the "new"
into a local variable.

* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
* bytecompiler/NodesCodegen.cpp:
(JSC::NewTargetNode::emitBytecode):
* parser/ASTBuilder.h:
(JSC::ASTBuilder::newTargetExpr):
* parser/NodeConstructors.h:
(JSC::NewTargetNode::NewTargetNode):
* parser/Nodes.h:
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseMemberExpression):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::newTargetExpr):
* runtime/CommonIdentifiers.h:
* tests/stress/new-target.js: Added.
(test):
(call):
(Constructor.subCall):
(Constructor.SubConstructor):
(Constructor):
(noAssign):
(doWeirdThings):
(SuperClass):
(SubClass):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoExpose shrink-wrapping as UIKit support SPI
timothy_horton@apple.com [Tue, 21 Jul 2015 17:14:00 +0000 (17:14 +0000)]
Expose shrink-wrapping as UIKit support SPI
https://bugs.webkit.org/show_bug.cgi?id=147148
<rdar://problem/21920008>

Reviewed by Simon Fraser.

* Misc/WebUIKitSupport.h:
* Misc/WebUIKitSupport.mm:
(WebKitCreatePathWithShrinkWrappedRects):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Convert all colors from RGB to HSL color scheme
nvasilyev@apple.com [Tue, 21 Jul 2015 16:53:11 +0000 (16:53 +0000)]
Web Inspector: Convert all colors from RGB to HSL color scheme
https://bugs.webkit.org/show_bug.cgi?id=147143

HSL color scheme is more human friendly than RGB.

RGB -> HSL
RGB hex (e.g. #bada55 and #456) -> HSL
RGBA -> HSLA
Named colors (white, black, lightgoldenrodyellow) are unchanged

Reviewed by Timothy Hatcher.

* UserInterface/Controllers/CodeMirrorGradientEditingController.css:
(.gradient-editing-controller > label > input):
* UserInterface/Views/BoxModelDetailsSectionRow.css:
(.details-section .row.box-model .position):
(.details-section .row.box-model .margin):
(.details-section .row.box-model .margin.active):
(.details-section .row.box-model .border):
(.details-section .row.box-model .border.active):
(.details-section .row.box-model .padding):
(.details-section .row.box-model .padding.active):
(.details-section .row.box-model .content):
(.details-section .row.box-model .content.active):
* UserInterface/Views/Breakpoint.css:
(.popover .edit-breakpoint-popover-content > table > tr > th):
* UserInterface/Views/BreakpointActionView.css:
(.breakpoint-action-remove-button):
(.breakpoint-action-append-button):
(.breakpoint-action-block-body):
(.breakpoint-action-eval-editor):
* UserInterface/Views/BreakpointTreeElement.css:
(.breakpoint-generic-line-icon .icon > span):
(.data-updated.breakpoint-generic-line-icon .icon > span):
* UserInterface/Views/ButtonNavigationItem.css:
(.navigation-bar .item.button.text-only):
(.navigation-bar .item.button.suppress-emboss > .glyph):
* UserInterface/Views/ButtonToolbarItem.css:
(.toolbar .item.button > .label):
(.toolbar.label-only .item.activate.button.activated > .label):
* UserInterface/Views/CSSStyleDeclarationSection.css:
(.style-declaration-section > .header > .selector):
(.style-declaration-section > .header > .origin):
* UserInterface/Views/CSSStyleDeclarationTextEditor.css:
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property:matches(.disabled, .invalid, .other-vendor, .not-inherited, .overridden)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .css-style-declaration-property.invalid):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .editing-line .css-style-declaration-property:matches(.disabled, .other-vendor, .not-inherited, .overridden)):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch > span):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch:hover > span):
(.css-style-text-editor > .CodeMirror .CodeMirror-lines .color-swatch:active > span):
(.css-style-text-editor > .CodeMirror .cm-link):
* UserInterface/Views/CSSStyleDetailsSidebarPanel.css:
(.sidebar > .panel.details.css-style > .content > .pseudo-classes):
(.sidebar > .panel.details.css-style > .content > .pseudo-classes > .group > label):
(.sidebar > .panel.details.css-style > .content.has-filter-bar + .filter-bar):
(.sidebar > .panel.details.css-style > .content.filter-in-progress .filter-matching):
(.sidebar > .panel.details.css-style > .content.filter-in-progress .style-declaration-section:not(.filter-section-has-label)):
* UserInterface/Views/ChartDetailsSectionRow.css:
(.details-section > .content > .group > .row.chart > .title):
(.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .label > .color-swatch):
(.details-section > .content > .group > .row.chart > .chart-content > .legend > .legend-item > .label):
* UserInterface/Views/CodeMirrorOverrides.css:
(.CodeMirror .CodeMirror-selected):
(.CodeMirror .CodeMirror-lines .CodeMirror-matchingbracket):
(.CodeMirror .CodeMirror-lines .CodeMirror-nonmatchingbracket):
(.CodeMirror .CodeMirror-gutters):
(.CodeMirror .CodeMirror-linenumber):
* UserInterface/Views/CompletionSuggestionsView.css:
(.completion-suggestions):
(.completion-suggestions-container > .item:active):
* UserInterface/Views/ConsoleMessageView.css:
(.console-user-command.special-user-log > .console-message-text):
(.console-message .repeat-count):
(.console-message-preview-divider):
(.console-message-enclosed):
(.console-user-command > .console-message-text):
(.console-saved-variable):
* UserInterface/Views/DOMStorageContentView.css:
(.content-view.dom-storage > .data-grid tr.missing-value td.value-column):
(.content-view.dom-storage > .data-grid:focus tr.selected.missing-value td.value-column):
* UserInterface/Views/DOMTreeOutline.css:
(.dom-tree-outline li.hovered:not(.selected) .selection):
(.dom-tree-outline li.selected .selection):
(.dom-tree-outline li.elements-drag-over .selection):
(.dom-tree-outline:focus li.selected .selection):
(.showing-find-banner .dom-tree-outline .search-highlight):
* UserInterface/Views/DataGrid.css:
(.data-grid .highlight):
(.data-grid.inline):
(.data-grid th):
(body.window-inactive .data-grid th):
(.data-grid :matches(th, td):not(:last-child)):
(body.window-inactive .data-grid :matches(th, td):not(:last-child)):
(.data-grid th.sortable:active):
(.data-grid th:matches(.sort-ascending, .sort-descending)):
(.data-grid table.data):
(.data-grid:matches(:focus, .force-focus) tr.selected td:not(:last-child)):
(.data-grid tr.selected):
(.data-grid:matches(:focus, .force-focus) tr.selected):
(.data-grid td .subtitle):
(.data-grid:matches(:focus, .force-focus) tr.selected td .subtitle):
(.data-grid td.error):
* UserInterface/Views/DatabaseContentView.css:
(.storage-view .storage-table-error):
(.database-user-query):
(.database-query-text):
* UserInterface/Views/DebuggerDashboardView.css:
(.toolbar .dashboard.debugger):
(.dashboard.debugger .navigation-bar .item.button > .glyph):
(.dashboard.debugger > .divider):
(.dashboard.debugger > .location .function-name):
(.dashboard.debugger > .location .go-to-link):
* UserInterface/Views/DebuggerSidebarPanel.css:
(.sidebar > .panel.navigation.debugger.paused .details-section.scripts):
* UserInterface/Views/DefaultDashboardView.css:
(.toolbar .dashboard.default > .item.enabled:hover):
(.toolbar .dashboard.default > .item.enabled:active):
(.toolbar .dashboard.default > .item > div):
(.toolbar .dashboard.default > .item.enabled > div):
(.toolbar .dashboard.default > .item.enabled:hover > div):
(.toolbar .dashboard.default > .errors.enabled > div):
(.toolbar .dashboard.default > .errors.enabled:hover > div):
(.toolbar .dashboard.default > .issues.enabled > div):
(.toolbar .dashboard.default > .issues.enabled:hover > div):
* UserInterface/Views/DetailsSection.css:
(.details-section):
(.details-section .details-section):
(.details-section .details-section:first-child):
(.details-section > .header):
(.details-section .details-section > .header):
(.details-section .details-section:not(.collapsed) > .header):
(.details-section.computed-style-properties:not(.collapsed) > .header):
(.details-section > .header > label):
(.details-section > .content > .group):
(.details-section > .content > .group:nth-child(even) > .row:matches(.simple:first-child > *, :not(.simple):first-child)):
(.details-section > .content > .group > .row.simple > .label):
(.details-section > .content .data-grid tr:nth-child(odd)):
* UserInterface/Views/DividerNavigationItem.css:
(.navigation-bar .item.divider):
* UserInterface/Views/Editing.css:
(.editing):
* UserInterface/Views/FilterBar.css:
(.filter-bar):
(.filter-bar > input[type="search"]):
(.filter-bar > input[type="search"]::-webkit-input-placeholder):
* UserInterface/Views/FindBanner.css:
(.find-banner):
(body.window-inactive .find-banner):
(.find-banner > input[type="search"]):
(.find-banner > button):
(.find-banner > button:active:not(:disabled)):
(.find-banner > button:disabled):
* UserInterface/Views/FormattedValue.css:
(:matches(.formatted-array, .formatted-map, .formatted-set, .formatted-weakmap, .formatted-weakset) > .size):
(.formatted-number):
(.formatted-boolean):
(.formatted-string):
(.formatted-regexp):
(.formatted-symbol):
(.formatted-null, .formatted-undefined):
* UserInterface/Views/GoToLineDialog.css:
(.go-to-line-dialog):
(.go-to-line-dialog > div):
(.go-to-line-dialog > div > input):
(.go-to-line-dialog > div > input::-webkit-input-placeholder):
(.go-to-line-dialog > div > img):
(.go-to-line-dialog > div > img:active):
* UserInterface/Views/GradientSlider.css:
(.gradient-slider):
(.gradient-slider-knob > div):
* UserInterface/Views/HierarchicalPathComponent.css:
(.hierarchical-path-component > .title):
* UserInterface/Views/HoverMenu.css:
(.hover-menu > svg > :matches(path, rect)):
* UserInterface/Views/ImageResourceContentView.css:
(.content-view.resource.image):
* UserInterface/Views/IndexedDatabaseObjectStoreContentView.css:
(.content-view.indexed-database-object-store > .data-grid table.data tr:nth-child(odd)):
* UserInterface/Views/LayerTreeDetailsSidebarPanel.css:
(.panel.details.layer-tree .name-column :matches(.pseudo-element, .reflection)):
(.panel.details.layer-tree tr.selected .name-column :matches(.pseudo-element, .reflection)):
(.panel.details.layer-tree .bottom-bar):
* UserInterface/Views/LogContentView.css:
(.console-item):
(.console-session + .console-session):
(.console-messages a):
(.console-messages a:hover):
(.search-bar.log-search-bar > input[type="search"]):
(.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted):
(.search-in-progress .console-item:not(.filtered-out-by-search) .highlighted.selected):
* UserInterface/Views/Main.css:
(body.docked.bottom):
(body.docked.right):
(body.window-inactive.docked.bottom):
(body.window-inactive.docked.right):
(#split-content-browser):
(body.window-inactive #split-content-browser):
(#split-content-browser > .navigation-bar):
(#split-content-browser .hierarchical-path-component.log-icon .title):
(.message-text-view):
(.message-text-view.error):
(.go-to-link):
(.value-with-clarification .clarification):
(.bouncy-highlight):
* UserInterface/Views/NavigationBar.css:
(.navigation-bar):
(body.window-inactive .navigation-bar):
* UserInterface/Views/NavigationSidebarPanel.css:
(.sidebar > .panel.navigation > .overflow-shadow):
(body.window-inactive .sidebar > .panel.navigation > .overflow-shadow):
(.sidebar > .panel.navigation > .empty-content-placeholder > .message):
(.navigation-sidebar-panel-content-tree-outline .item.selected):
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected):
(body.window-inactive .navigation-sidebar-panel-content-tree-outline .item.selected):
(.navigation-sidebar-panel-content-tree-outline .item .highlighted):
(.navigation-sidebar-panel-content-tree-outline .item .subtitle):
(.navigation-sidebar-panel-content-tree-outline:matches(:focus, .force-focus) .item.selected .subtitle):
* UserInterface/Views/NetworkGridContentView.css:
(.content-view.network-grid > .data-grid table.data):
* UserInterface/Views/NetworkSidebarPanel.css:
(.sidebar > .panel.navigation.network > .title-bar):
(body.window-inactive .sidebar > .panel.navigation.network > .title-bar):
(.sidebar > .panel.navigation.network.network-grid-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
* UserInterface/Views/NetworkTimelineOverviewGraph.css:
(.timeline-overview-graph.network:nth-child(even) > .graph-row > .timeline-record-bar > .segment:not(.inactive)):
* UserInterface/Views/NewTabContentView.css:
(.new-tab.tab.content-view):
(.new-tab.tab.content-view > .tab-item > .box):
* UserInterface/Views/ObjectPreviewView.css:
(.object-preview .name):
(.object-preview > .size):
* UserInterface/Views/ObjectTreeView.css:
(.object-tree-outline li .empty-message):
* UserInterface/Views/OverviewTimelineView.css:
(.timeline-view.overview > .timeline-ruler > .header):
(body.window-inactive .timeline-view.overview > .timeline-ruler > .header):
(.timeline-view.overview > .data-grid tr.parent:not(.expanded).selected td.graph-column .timeline-record-bar:not(.has-inactive-segment) > .segment):
(.timeline-view.overview > .data-grid:focus tr.parent:not(.expanded).selected td.graph-column .timeline-record-bar:not(.has-inactive-segment) > .segment):
(.timeline-view.overview > .data-grid tr.parent:not(.expanded).selected td.graph-column .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(.timeline-view.overview > .data-grid:focus tr.parent:not(.expanded).selected td.graph-column .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
* UserInterface/Views/ProbeSetDataGrid.css:
(.details-section.probe-set .data-grid tr.past-value td):
(.details-section.probe-set .data-grid > td.unknown-value):
(@-webkit-keyframes blink-frame-highlight):
(100%):
(.details-section.probe-set .data-grid tr.separator):
(@-webkit-keyframes blink-probe-frame):
* UserInterface/Views/QuickConsole.css:
(.quick-console):
(body.window-inactive .quick-console):
(.quick-console.showing-log):
* UserInterface/Views/RadioButtonNavigationItem.css:
(.navigation-bar .item.radio.button.text-only:hover):
(.navigation-bar .item.radio.button.text-only.selected):
(.navigation-bar .item.radio.button.text-only:active):
(.navigation-bar .item.radio.button.text-only.selected:active):
* UserInterface/Views/RenderingFrameTimelineOverviewGraph.css:
(.timeline-overview-graph.rendering-frame > .divider):
(.timeline-overview-graph.rendering-frame > .divider > .label):
* UserInterface/Views/ReplayDashboardView.css:
(.toolbar .dashboard.replay):
* UserInterface/Views/ResourceTreeElement.css:
(.item.resource.failed):
(.item.resource.failed .subtitle):
* UserInterface/Views/RulesStyleDetailsPanel.css:
(.sidebar > .panel.details.css-style .rules .label):
(.sidebar > .panel.details.css-style > .content.filter-in-progress > .rules.filter-non-matching > .no-filter-results > .no-filter-results-message):
* UserInterface/Views/ScopeBar.css:
(.scope-bar > li):
(.scope-bar > li:hover):
(.scope-bar > li.selected):
(.scope-bar > li:active):
(.scope-bar > li.selected:active):
* UserInterface/Views/SearchBar.css:
(.search-bar > input[type="search"]):
(.search-bar > input[type="search"]::-webkit-input-placeholder):
* UserInterface/Views/SearchSidebarPanel.css:
(.sidebar > .panel.navigation.search > .search-bar):
* UserInterface/Views/Sidebar.css:
(.sidebar):
(.sidebar.left):
(.sidebar.right):
(body.window-inactive .sidebar.left):
(body.window-inactive .sidebar.right):
* UserInterface/Views/SourceCodeTextEditor.css:
(.source-code.text-editor > .CodeMirror .warning):
(.source-code.text-editor > .CodeMirror .error):
(.source-code.text-editor > .CodeMirror .issue-widget.warning):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.warning):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.warning > .arrow):
(.source-code.text-editor > .CodeMirror .issue-widget.error):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.error):
(.source-code.text-editor > .CodeMirror .issue-widget.inline.error > .arrow):
(.popover .debugger-popover-content > .body):
* UserInterface/Views/SyntaxHighlightingDefaultTheme.css:
(.syntax-highlighted :matches(.css-comment, .javascript-comment, .html-comment)):
(.syntax-highlighted :matches(.css-keyword, .css-tag, .css-at-rule, .css-important, .javascript-keyword, .html-tag)):
(.syntax-highlighted :matches(.css-number, .javascript-number)):
(.syntax-highlighted :matches(.css-string, .javascript-string, .javascript-regexp, .html-attribute-value)):
(.syntax-highlighted :matches(.html-doctype, .html-processing-instruction)):
(.syntax-highlighted .html-attribute-name):
(.syntax-highlighted a):
(.supports-find-banner.showing-find-banner .syntax-highlighted .search-result):
(.cm-s-default .basic-block-has-not-executed):
(.cm-s-default .basic-block-has-not-executed.cm-m-css:matches(.cm-atom, .cm-meta, .cm-variable-3, .cm-property)):
(.cm-s-default .basic-block-has-not-executed:matches(.cm-number, .cm-atom.cm-hex-color)):
(.cm-s-default .basic-block-has-not-executed.cm-string):
(.cm-s-default .basic-block-has-not-executed.cm-m-xml.cm-meta):
* UserInterface/Views/TabBar.css:
(.tab-bar):
(body.window-inactive .tab-bar):
(.tab-bar > .top-border):
(body.window-inactive .tab-bar > .top-border):
(.tab-bar > .item):
(.tab-bar.dragging-tab > .item.selected):
(.tab-bar > .item:not(.disabled).selected):
(.tab-bar > .item.new-tab-button:not(.disabled):hover):
(.tab-bar:not(.animating) > .item:not(.selected, .disabled):hover + .item):
(body.window-inactive .tab-bar > .item):
(body.window-inactive .tab-bar > .item.selected):
(.tab-bar > .item > .close:hover):
(.tab-bar > .item > .title):
(.tab-bar:not(.animating) > .item:not(.selected):hover > .title):
(.tab-bar > .item.selected > .title):
(.tab-bar.animating.closing-tab > .item.selected):
(body.window-inactive .tab-bar.animating.closing-tab > .item.selected):
* UserInterface/Views/TextEditor.css:
(.text-editor > .CodeMirror .execution-line):
(.text-editor > .CodeMirror .hovered-expression-highlight):
(to):
* UserInterface/Views/TimelineDataGrid.css:
(.data-grid.timeline th):
(body.window-inactive .data-grid.timeline th):
(.timeline-data-grid-tree-outline .item:hover):
(.timeline-data-grid-tree-outline .item .subtitle):
* UserInterface/Views/TimelineOverview.css:
(.timeline-overview > .graphs-container > .timeline-overview-graph:nth-child(even)):
(.timeline-overview > .graphs-container > .timeline-overview-graph:not(:first-child)):
* UserInterface/Views/TimelineRecordBar.css:
(.timeline-record-bar > .segment):
(:matches(:focus, .force-focus) .selected .timeline-record-bar > .segment.inactive):
(:matches(:focus, .force-focus) .selected .timeline-record-bar.has-inactive-segment > .segment:not(.inactive)):
(.timeline-record-bar.timeline-record-type-network > .segment):
(.timeline-record-bar.timeline-record-type-network > .segment.inactive):
(.timeline-record-bar.timeline-record-type-layout > .segment):
(.timeline-record-bar.timeline-record-type-layout.layout-timeline-record-composite > .segment):
(.timeline-record-bar.timeline-record-type-script > .segment):
* UserInterface/Views/TimelineRecordFrame.css:
(.timeline-record-frame):
(.timeline-record-frame > .frame > .duration):
(.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-script):
(.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-layout):
(.timeline-record-frame > .frame > .duration.rendering-frame-timeline-record-paint):
* UserInterface/Views/TimelineRecordingContentView.css:
(.content-view.timeline-recording > .content-view-container > .timeline-view > .data-grid table.data):
* UserInterface/Views/TimelineRuler.css:
(.timeline-ruler > .header):
(body.window-inactive .timeline-ruler > .header):
(.timeline-ruler > .header > .divider):
(body.window-inactive .timeline-ruler > .header > .divider):
(.timeline-ruler > .header > .divider > .label):
(.timeline-ruler > .markers > .divider):
(.timeline-ruler > .markers > .marker):
(.timeline-ruler > .markers > .marker.load-event):
(.timeline-ruler > .markers > .marker.dom-content-event):
(.timeline-ruler > .markers > .marker.timestamp):
(.timeline-ruler > .selection-handle):
(.timeline-ruler > .shaded-area):
* UserInterface/Views/TimelineSidebarPanel.css:
(.sidebar > .panel.navigation.timeline > .status-bar):
(body.window-inactive .sidebar > .panel.navigation.timeline > .status-bar):
(.sidebar > .panel.navigation.timeline > .status-bar > .record-status):
(.sidebar > .panel.navigation.timeline > .title-bar):
(body.window-inactive .sidebar > .panel.navigation.timeline > .title-bar):
(.sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(body.window-inactive .sidebar > .panel.navigation.timeline > .title-bar.timeline-events):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):nth-child(even)):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item:not(.selected):not(:first-child)):
(.sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item):
(body.window-inactive .sidebar > .panel.navigation.timeline > .timelines-content li.item.selected + li.item):
(.sidebar > .panel.navigation.timeline > .timelines-content :focus li.item.selected + li.item):
* UserInterface/Views/TimelineView.css:
(.panel.navigation.timeline.timeline-recording-content-view-showing > .content > .navigation-sidebar-panel-content-tree-outline):
* UserInterface/Views/Toolbar.css:
(.toolbar):
(body.window-inactive .toolbar):
* UserInterface/Views/TreeElementStatusButton.css:
(.item > .status > .status-button > svg .filled):
(.item > .status > .status-button > svg .stroked):
* UserInterface/Views/TypeTokenView.css:
(.type-token-function, .type-token-boolean):
(.type-token-number):
(.type-token-string):
(.type-token-symbol):
(.type-token-default):
(.type-token-empty):
(.type-token-many):
* UserInterface/Views/TypeTreeView.css:
(.type-tree-outline li .empty-message):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix WebPreferences infinite recursion introduced in r186232.
beidson@apple.com [Tue, 21 Jul 2015 16:19:32 +0000 (16:19 +0000)]
Fix WebPreferences infinite recursion introduced in r186232.
<rdar://problem/9091261> and https://bugs.webkit.org/show_bug.cgi?id=147149

Reviewed by Tim Horton.

* WebView/WebPreferences.mm:
(-[WebPreferences metaRefreshEnabled]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION(r184376): [SOUP] Multiple assertions when downloading files
mcatanzaro@igalia.com [Tue, 21 Jul 2015 06:18:24 +0000 (06:18 +0000)]
REGRESSION(r184376): [SOUP] Multiple assertions when downloading files
https://bugs.webkit.org/show_bug.cgi?id=147039

Reviewed by Darin Adler.

No new tests; this will be covered once we enable the network process for API tests.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::releaseForDownload): Call RefPtrBase::relaxAdoptionRequirement so
that we don't assert when storing the non-adopted ResourceHandle in a RefPtr. The ref will
be dropped in ResourceHandle::cleanupSoupOperation, which as the comment says should always
run. HOPEFULLY.
(WebCore::ResourceHandle::continueWillSendRequest): Don't assert that client() is nonnull,
because the code clearly expects and handles the case where it is null.
(WebCore::ResourceHandle::continueDidReceiveResponse): Ditto; note that here client() will
always be null for a download.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Add API to be notified about editor state changes
carlosgc@webkit.org [Tue, 21 Jul 2015 06:06:18 +0000 (06:06 +0000)]
[GTK] Add API to be notified about editor state changes
https://bugs.webkit.org/show_bug.cgi?id=145875

Reviewed by Gustavo Noronha Silva.

Source/WebKit2:

Add WebKitEditorState object, that is created on demand by the
WebKitWebView and can be used to get the typing attributes of the
editor at the current position or selection.

* PlatformGTK.cmake:
* Shared/EditorState.cpp: Use part of the PostLayoutData struct
for the GTK port too.
(WebKit::EditorState::encode): Encode PostLayoutData for GTK and
remove our custom cursorRect.
(WebKit::EditorState::decode): Decode PostLayoutData for GTK and
remove our custom cursorRect.
(WebKit::EditorState::PostLayoutData::encode): Reorder it to
reduce the amonut of ifdefs.
(WebKit::EditorState::PostLayoutData::decode): Ditto.
* Shared/EditorState.h: Add AttributeStrikeThrough to
TypingAttributes enum.
* UIProcess/API/gtk/PageClientImpl.cpp:
(WebKit::PageClientImpl::selectionDidChange): Rename
updateTextInputState() to selectionDidChange() and also notify the
WebKitWebView.
* UIProcess/API/gtk/PageClientImpl.h:
* UIProcess/API/gtk/WebKitEditorState.cpp: Added.
(webkitEditorStateGetProperty):
(webkit_editor_state_class_init):
(webkitEditorStateSetTypingAttributes):
(webkitEditorStateCreate):
(webkitEditorStateChanged):
(webkit_editor_state_get_typing_attributes):
* UIProcess/API/gtk/WebKitEditorState.h: Added.
* UIProcess/API/gtk/WebKitEditorStatePrivate.h: Added.
* UIProcess/API/gtk/WebKitWebView.cpp:
(webkitWebViewSelectionDidChange): Notify the WebKitEditorState if
it has already been created.
(webkit_web_view_get_editor_state): Ensure a WebKitEditorState and
return it.
* UIProcess/API/gtk/WebKitWebView.h:
* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseUpdateTextInputState): Get the caret cursor rect
from PostLayoutData.
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt: Add new symbols.
* UIProcess/API/gtk/docs/webkit2gtk-4.0.types: Add webkit_editor_state_get_type.
* UIProcess/API/gtk/docs/webkit2gtk-docs.sgml: Add new section for WebKitEditorState.
* UIProcess/API/gtk/webkit2.h: Include WebKitEditorState.h.
* UIProcess/PageClient.h:
* UIProcess/gtk/WebPageProxyGtk.cpp:
(WebKit::WebPageProxy::editorStateChanged): Call PageClientImpl::selectionDidChange().
* WebProcess/WebPage/gtk/WebPageGtk.cpp:
(WebKit::WebPage::platformEditorState): Add typing attributes to EditorState.

Tools:

Update the typing attributes toggle buttons state according to the
editor state in MiniBrowser, and add a test case to the
WebViewEditor unit tests.

* MiniBrowser/gtk/BrowserWindow.c:
(browserWindowEditingCommandToggleButtonSetActive):
(typingAttributesChanged):
(browserWindowSetupEditorToolbar):
(browserWindowConstructed):
(browser_window_init):
* TestWebKitAPI/Tests/WebKit2Gtk/TestWebViewEditor.cpp:
(testWebViewEditorEditorStateTypingAttributes):
(beforeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFollow-up to my earlier fix for r147085
adachan@apple.com [Tue, 21 Jul 2015 05:39:55 +0000 (05:39 +0000)]
Follow-up to my earlier fix for r147085
https://bugs.webkit.org/show_bug.cgi?id=147085

Reviewed by Eric Carlson.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::isPlayingAudioDidChange):
Null-check document() before dereferencing it in case the audio context's document is destroyed
by the time the code block is called on the main thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove RenderTheme::shouldShowPlaceholderWhenFocused()
carlosgc@webkit.org [Tue, 21 Jul 2015 05:33:50 +0000 (05:33 +0000)]
Remove RenderTheme::shouldShowPlaceholderWhenFocused()
https://bugs.webkit.org/show_bug.cgi?id=147104

Reviewed by Martin Robinson.

GTK+ is the only port that returns false in
shouldShowPlaceholderWhenFocused(). That's inconsistent with all
other browsers that show the placeholder text even for focused
entries in all platforms. We should change the GTK+ port
behaviour, but that would leave all implementations of
shouldShowPlaceholderWhenFocused returning true, so let's just
remove it.

* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::placeholderShouldBeVisible):
Do not consider whether the entry is focused or not.
* platform/efl/RenderThemeEfl.h:
* rendering/RenderTheme.h:
(WebCore::RenderTheme::shouldShowPlaceholderWhenFocused): Deleted.
* rendering/RenderThemeIOS.h:
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::shouldShowPlaceholderWhenFocused): Deleted.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::shouldShowPlaceholderWhenFocused): Deleted.
* rendering/RenderThemeSafari.h:
(WebCore::RenderThemeSafari::shouldShowPlaceholderWhenFocused): Deleted.
* rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CoordinatedGraphics] CoordinatedGraphicsLayer::setContentsToImage() should avoid...
zandobersek@gmail.com [Tue, 21 Jul 2015 05:16:44 +0000 (05:16 +0000)]
[CoordinatedGraphics] CoordinatedGraphicsLayer::setContentsToImage() should avoid scheduling unnecessary flushes
https://bugs.webkit.org/show_bug.cgi?id=147118

Reviewed by Martin Robinson.

Have CoordinatedGraphicsLayer::setContentsToImage() return early if the new
passed-in Image and the corresponding native image pointer are equal to the
currently set values.

This specifically avoids scheduling unnecessary flushes when setContentsToImage()
is repeatedly called with a null Image pointer, which in previous code would
unconditionally result in a scheduled flush even if there was no Image assigned
as the content of this layer before. Until now the layer flush scheduling was only
avoided if the two non-null native image pointers were equal.

* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::setContentsToImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the iOS build.
simon.fraser@apple.com [Tue, 21 Jul 2015 04:37:33 +0000 (04:37 +0000)]
Fix the iOS build.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFacebook in tiled fullscreen is slow
simon.fraser@apple.com [Tue, 21 Jul 2015 02:00:56 +0000 (02:00 +0000)]
Facebook in tiled fullscreen is slow
https://bugs.webkit.org/show_bug.cgi?id=147134
rdar://problem/21823349

Reviewed by Tim Horton.

TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded() could cause a page to toggle
between two fixed layout sizes differing by a pixel, because of rounding. This would cause
lots of extra layouts and painting.

This happened because the the fixed layout size was computed using ceil(m_webPage.size().width() / viewScale)

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scaleViewToFitDocumentIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAX: Selection change as a result of focusing an element may cause Safari to crash
commit-queue@webkit.org [Tue, 21 Jul 2015 01:08:53 +0000 (01:08 +0000)]
AX: Selection change as a result of focusing an element may cause Safari to crash
https://bugs.webkit.org/show_bug.cgi?id=147052
<rdar://problem/21778212>

Patch by Nan Wang <n_wang@apple.com> on 2015-07-20
Reviewed by Chris Fleizach.

Source/WebCore:

When focusing an element, it may trigger a deferred layout that invalidates the render
element, which will cause axObjectCache() to be a nullptr, and lead to a crash. Fix that
by using a RefPtr to hold the object and also caching the axObjectCache().

Test: platform/mac/accessibility/focus-crash.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::setFocused):
(WebCore::AccessibilityRenderObject::setSelectedRows):

LayoutTests:

* platform/mac/accessibility/focus-crash-expected.txt: Added.
* platform/mac/accessibility/focus-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: console.assert(false, "Message") message is not visible in console
commit-queue@webkit.org [Tue, 21 Jul 2015 00:58:38 +0000 (00:58 +0000)]
Web Inspector: console.assert(false, "Message") message is not visible in console
https://bugs.webkit.org/show_bug.cgi?id=147130

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-07-20
Reviewed by Timothy Hatcher.

* Localizations/en.lproj/localizedStrings.js:
* UserInterface/Views/ConsoleMessageView.js:
(WebInspector.ConsoleMessageView.prototype._appendMessageTextAndArguments):
We were forgetting to assign the result of args.concat back into args.
In re-addressing this, improve the formatting of output if there is
a string message or not as the second argument to console.assert(), as
that is the common usage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed build fix after r187049.
achristensen@apple.com [Tue, 21 Jul 2015 00:27:56 +0000 (00:27 +0000)]
Unreviewed build fix after r187049.

* contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::populateDomainCacheIfNeeded):
Can't shrinkToFit HashSets.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix crash due to RemoteLayerTreeDisplayRefreshMonitor outliving RemoteLayerTreeDrawin...
wenson_hsieh@apple.com [Tue, 21 Jul 2015 00:23:05 +0000 (00:23 +0000)]
Fix crash due to RemoteLayerTreeDisplayRefreshMonitor outliving RemoteLayerTreeDrawingArea
https://bugs.webkit.org/show_bug.cgi?id=147124
<rdar://problem/21582858>

Reviewed by Simon Fraser.

Refactors RemoteLayerTreeDisplayRefreshMonitor to use a weak pointer rather than a reference
to its RemoteLayerTreeDrawingArea, since the drawing area may be deallocated before the monitor
in some rare cases. This rarely caused pages using requestAnimationFrame to crash on iOS. However,
this should not be the case: logically, a RemoteLayerTreeDrawingArea should always outlive its
refresh monitors. Refer to https://bugs.webkit.org/show_bug.cgi?id=147128 for more details.

* WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.h:
* WebProcess/WebPage/Cocoa/RemoteLayerTreeDisplayRefreshMonitor.mm:
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::RemoteLayerTreeDisplayRefreshMonitor):
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::~RemoteLayerTreeDisplayRefreshMonitor): On destruction, checks
    first to see whether or not the drawing area has been deallocated before telling it to update its monitors.
(WebKit::RemoteLayerTreeDisplayRefreshMonitor::requestRefreshCallback):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
(WebKit::RemoteLayerTreeDrawingArea::createWeakPtr): Creates and returns a new weak pointer to itself.
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Content Extensions] Cache actions with domains that match everything
achristensen@apple.com [Tue, 21 Jul 2015 00:12:13 +0000 (00:12 +0000)]
[Content Extensions] Cache actions with domains that match everything
https://bugs.webkit.org/show_bug.cgi?id=147050

Reviewed by Benjamin Poulain.

Source/WebCore:

If you have lots of rules with triggers like {"url-filter":".*","if-domain":["*webkit.org"]}
we will spend a lot of time adding unnecessary actions to HashSets when you are not on webkit.org.
Caching all the rules and only adding them to a collection once when the domain changes saves a lot of URL interpreting time.

We already had an optimization for the css-display-none actions with triggers that matched everything using a special bytecode operation.
This removes the need for a special bytecode operation by caching the triggers that match everything with and without domains,
then from those cached actions we compile a stylesheet, and create cached actions for every new domain we visit.

All functionality is covered by existing API tests.

* contentextensions/CompiledContentExtension.cpp:
(WebCore::ContentExtensions::CompiledContentExtension::~CompiledContentExtension):
(WebCore::ContentExtensions::CompiledContentExtension::globalDisplayNoneSelectors): Deleted.
* contentextensions/CompiledContentExtension.h:
* contentextensions/ContentExtension.cpp:
(WebCore::ContentExtensions::ContentExtension::ContentExtension):
(WebCore::ContentExtensions::ContentExtension::findFirstIgnorePreviousRules):
(WebCore::ContentExtensions::ContentExtension::globalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtension::compileGlobalDisplayNoneStyleSheet):
(WebCore::ContentExtensions::ContentExtension::populateDomainCacheIfNeeded):
(WebCore::ContentExtensions::ContentExtension::cachedDomainActions):
(WebCore::ContentExtensions::ContentExtension::universalActionsWithDomains):
* contentextensions/ContentExtension.h:
(WebCore::ContentExtensions::ContentExtension::compiledExtension):
(WebCore::ContentExtensions::ContentExtension::universalActionsWithoutDomains):
* contentextensions/ContentExtensionCompiler.cpp:
(WebCore::ContentExtensions::compileRuleList):
* contentextensions/ContentExtensionRule.cpp:
(WebCore::ContentExtensions::ContentExtensionRule::ContentExtensionRule):
(WebCore::ContentExtensions::Action::deserialize):
(WebCore::ContentExtensions::Action::deserializeType):
(WebCore::ContentExtensions::Action::serializedLength):
* contentextensions/ContentExtensionRule.h:
(WebCore::ContentExtensions::Action::operator==):
(WebCore::ContentExtensions::Action::setExtensionIdentifier):
(WebCore::ContentExtensions::Action::extensionIdentifier):
* contentextensions/ContentExtensionsBackend.cpp:
(WebCore::ContentExtensions::ContentExtensionsBackend::actionsForResourceLoad):
* contentextensions/DFABytecode.h:
(WebCore::ContentExtensions::instructionSizeWithArguments):
* contentextensions/DFABytecodeCompiler.cpp:
(WebCore::ContentExtensions::DFABytecodeCompiler::emitAppendAction):
* contentextensions/DFABytecodeInterpreter.cpp:
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpretTestFlagsAndAppendAction):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsMatchingEverything):
(WebCore::ContentExtensions::DFABytecodeInterpreter::interpret):
(WebCore::ContentExtensions::DFABytecodeInterpreter::actionsForDefaultStylesheetFromDFARoot): Deleted.
* contentextensions/DFABytecodeInterpreter.h:
* loader/ResourceLoadInfo.h:

Source/WebKit2:

* UIProcess/API/APIUserContentExtensionStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSupport blocking a plug-in for non-security reasons
andersca@apple.com [Mon, 20 Jul 2015 23:45:41 +0000 (23:45 +0000)]
Support blocking a plug-in for non-security reasons
https://bugs.webkit.org/show_bug.cgi?id=145009

Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2015-07-20
Reviewed by Anders Carlsson.

* Shared/Plugins/PluginModuleInfo.h:
Replace PluginModuleBlocked with separate enum values for blocking for security and compatibility.

* UIProcess/API/C/WKAPICast.h:
(WebKit::toWKPluginLoadPolicy):
Modify to handle change to PluginModuleBlocked enum.

(WebKit::toPluginModuleLoadPolicy):
Ditto.

* UIProcess/API/C/WKPluginLoadPolicy.h:
Added enum value for blocking a plugin for compatibility reasons.

* UIProcess/Plugins/mac/PluginInfoStoreMac.mm:
(WebKit::shouldBlockPlugin):
Check load policy for both reasons a plugin may be blocked.

(WebKit::WKPlugInModuleLoadPolicyToPluginModuleLoadPolicy):
Added function to convert between load policy enum types.

(WebKit::PluginInfoStore::defaultLoadPolicyForPlugin):
Modified to call WKLoadPolicyForPluginVersion() which can distinguish between blocked for security or compatibility.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::findPlugin):
Updated to recognize both PluginModuleBlocked enum values that indicate a plugin is blocked.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::createPlugin):
Ditto.

(WebKit::WebPage::canPluginHandleResponse):
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: start using Promises to handle asynchronous steps in protocol tests
burg@cs.washington.edu [Mon, 20 Jul 2015 23:35:51 +0000 (23:35 +0000)]
Web Inspector: start using Promises to handle asynchronous steps in protocol tests
https://bugs.webkit.org/show_bug.cgi?id=147096

Reviewed by Joseph Pecoraro.

Existing protocol tests use lots of reinvented wheels to run
multiple asynchronous tests. This patch begins consolidation of
these redundant wheels, using a tiny test framework based on
promises.

The first change is to introduce InspectorTest.awaitCommand,
which returns a promise that is fulfilled or rejected if the command
succeeds or fails. This is the building block for writing protocol
tests with promises.

The second change is the introduction of InspectorTest.AsyncTestSuite.
This properly chains together multiple asynchronous test methods
using the promise interface. A synchronous version is also added.

To demonstrate how async tests can be written using this new approach,
this patch converts existing protocol test. Test coverage for the
new frameworks also demonstrates their use.

* http/tests/inspector-protocol/resources/InspectorTest.js:
(InspectorTest.sendCommand):
(InspectorTest.awaitCommand):
(InspectorTest.sendMessage):
(InspectorFrontendAPI.dispatchMessageAsync):
(InspectorTest.AsyncTestSuite): Add tests for this micro framework.
(InspectorTest.AsyncTestSuite.prototype.get passCount):
(InspectorTest.AsyncTestSuite.prototype.get skipCount):
(InspectorTest.AsyncTestSuite.prototype.addTestCase):
(InspectorTest.AsyncTestSuite.prototype.runTestCasesAndFinish.finish):
(InspectorTest.AsyncTestSuite.prototype.runTestCasesAndFinish):
(InspectorTest.AsyncTestSuite.prototype.runTestCases):
(InspectorTest.SyncTestSuite): Add tests for this micro framework.
(InspectorTest.SyncTestSuite.prototype.get passCount):
(InspectorTest.SyncTestSuite.prototype.get skipCount):
(InspectorTest.SyncTestSuite.prototype.addTestCase):
(InspectorTest.SyncTestSuite.prototype.runTestCasesAndFinish):
(InspectorTest.SyncTestSuite.prototype.runTestCases):
(InspectorTest.log):
(InspectorTest.assert):
* inspector-protocol/runtime/getProperties-expected.txt:
* inspector-protocol/runtime/getProperties.html: Rewrite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoNSURLCache fallback does not work on iOS due to sandboxing
antti@apple.com [Mon, 20 Jul 2015 23:31:55 +0000 (23:31 +0000)]
NSURLCache fallback does not work on iOS due to sandboxing
https://bugs.webkit.org/show_bug.cgi?id=146314
<rdar://problem/21433691>

Reviewed by Anders Carlsson.

This broke with earlier cache path computation changes.

* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):

    NSURLCache path is relative to the container cache path so "." is sufficient.
    This puts the cache files under
    <container>/Library/Caches/com.apple.WebKit.Networking/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdopt AVPlayerLayerView
commit-queue@webkit.org [Mon, 20 Jul 2015 23:27:49 +0000 (23:27 +0000)]
Adopt AVPlayerLayerView
https://bugs.webkit.org/show_bug.cgi?id=146862

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-07-20
Source/WebCore:

Reviewed by Jer Noble.

The CALayerHost is replaced with WebLayerHostView to be compatible with UIView animations.
Some animation is improved in the conversion.

WebAVPlayerLayerView and WebAVPictureInPicturePlayerLayerView derive from AVKit and UIKit respectively.
Because these frameworks are loaded at runtime, these classes must be generate using objc/runtime.h to
register them from c functions at runtime. The most important part of these UIViews is that their
backing layer is a WebAVPlayerLayer.

WebCALayerHostWrapper and WebAVVideoLayer are combined into WebAVPlayerLayer to simplify the hierarchy.
WebAVPlayerLayer is a stand-in for an AVPlayerLayer.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenLayer): -removeFromSuperlayer is redundant.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenGravity): syncTextTrackBounds on change.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setVideoFullscreenFrame):
We never want animation here, since all animation will happen in UIViews.
This is just for going into the final size after a transform based animation.

* platform/ios/WebVideoFullscreenControllerAVKit.mm:
(WebVideoFullscreenControllerContext::didSetupFullscreen): layer -> view
(WebVideoFullscreenControllerContext::didCleanupFullscreen): layer -> view
(WebVideoFullscreenControllerContext::setUpFullscreen): layer -> view

(WebVideoFullscreenControllerContext::setVideoLayerFrame): layer -> view
Use fence port to synchronize between the UIThread and the WebThread,
the same way WebKit2 uses a fence port to synchronize between processes.

(WebVideoFullscreenControllerContext::setVideoLayerGravity):
No longer necessary to cache videoGravity at this level.

* platform/ios/WebVideoFullscreenInterfaceAVKit.h:
* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:

(-[WebAVPlayerLayer init]):
(-[WebAVPlayerLayer dealloc]):
(-[WebAVPlayerLayer playerController]):
(-[WebAVPlayerLayer setBounds:]):
(-[WebAVPlayerLayer resolveBounds]):
(-[WebAVPlayerLayer setVideoGravity:]):
(-[WebAVPlayerLayer videoGravity]):
(-[WebAVPlayerLayer videoRect]):
(+[WebAVPlayerLayer keyPathsForValuesAffectingVideoRect]):
Added class WebAVPlayerLayer, replacing WebAVVideoLayer and WebCALayerHostWrapper.

(WebAVPictureInPicturePlayerLayerView_layerClass):
(getWebAVPictureInPicturePlayerLayerViewClass):
Added runtime class WebAVPictureInPicturePlayerLayerView

(WebAVPlayerLayerView_layerClass):
(WebAVPlayerLayerView_playerController):
(WebAVPlayerLayerView_setPlayerController):
(WebAVPlayerLayerView_videoView):
(WebAVPlayerLayerView_setVideoView):
(WebAVPlayerLayerView_startRoutingVideoToPictureInPicturePlayerLayerView):
(WebAVPlayerLayerView_stopRoutingVideoToPictureInPicturePlayerLayerView):
(WebAVPlayerLayerView_pictureInPicturePlayerLayerView):
(getWebAVPlayerLayerViewClass):
Added runtime class WebAVPlayerLayerView

(WebVideoFullscreenInterfaceAVKit::setVideoDimensions):
Dimensions are also stored in WebAVPlayerLayer so it can make decisions about
animating the video layer.

(WebVideoFullscreenInterfaceAVKit::setExternalPlayback):
(WebVideoFullscreenInterfaceAVKit::enterFullscreen):
(WebVideoFullscreenInterfaceAVKit::didStopPictureInPicture):
(WebVideoFullscreenInterfaceAVKit::cleanupFullscreen):
Straightforward layer to view conversion.

(WebVideoFullscreenInterfaceAVKit::preparedToReturnToInline):
Set view frame using the view hierarchy instead of assuming it is directly in a window.

(WebVideoFullscreenInterfaceAVKit::exitFullscreen):
Set view frame using the view hierarchy instead of assuming it is directly in a window.
dispatch_async before calling didExitFullscreen() to allows CATransactions to complete.

(WebVideoFullscreenInterfaceAVKit::setupFullscreen):
Set view frame using the view hierarchy instead of assuming it is directly in a window.
dispatch_async before calling didSetupFullscreen() to allows CATransactions to complete.

(-[WebCALayerHostWrapper dealloc]): Deleted.
(-[WebCALayerHostWrapper setVideoSublayer:]): Deleted.
(-[WebCALayerHostWrapper videoSublayer]): Deleted.
(-[WebCALayerHostWrapper setBounds:]): Deleted.
(-[WebCALayerHostWrapper resolveBounds]): Deleted.
Class WebCALayerHostWrapper deleted. Functionality rolled into WebAVPlayerLayer.

(+[WebAVVideoLayer videoLayer]): Deleted.
(-[WebAVVideoLayer init]): Deleted.
(-[WebAVVideoLayer setPlayerViewController:]): Deleted.
(-[WebAVVideoLayer setVideoSublayer:]): Deleted.
(-[WebAVVideoLayer setBounds:]): Deleted.
(-[WebAVVideoLayer setVideoLayerGravity:]): Deleted.
(-[WebAVVideoLayer videoLayerGravity]): Deleted.
(-[WebAVVideoLayer enterPIPModeRedirectingVideoToLayer:]): Deleted.
(-[WebAVVideoLayer leavePIPMode]): Deleted.
Class WebAVVideoLayer deleted. Functionality rolled into WebAVPlayerLayer.

* platform/ios/WebVideoFullscreenModel.h:
* platform/ios/WebVideoFullscreenModelVideoElement.h:
* platform/ios/WebVideoFullscreenModelVideoElement.mm:
No need to store frame and gravity in the model. It is stored in the UI where it is used.

(WebVideoFullscreenModelVideoElement::videoLayerFrame): Deleted.
(WebVideoFullscreenModelVideoElement::videoLayerGravity): Deleted.
* platform/spi/cocoa/AVKitSPI.h: Add AVPlayerLayerView.

Source/WebKit2:

Reviewed by Simon Fraser.

The CALayerHost is replaced with WebLayerHostView to be compatible with UIView animations.
videoLayerFrame and videoLayerGravity no longer need to be stored because they are stored
where they are used in the interface. Some animation is improved in the conversion.

* UIProcess/ios/WebVideoFullscreenManagerProxy.h:
* UIProcess/ios/WebVideoFullscreenManagerProxy.mm:
(+[WebLayerHostView layerClass]): Add class WebLayerHostView.
(-[WebLayerHostView contextID]):
(-[WebLayerHostView setContextID:]):
(-[WebLayerHostView layerHost]):
(WebKit::WebVideoFullscreenManagerProxy::invalidate): layer -> view
(WebKit::WebVideoFullscreenManagerProxy::setupFullscreenWithID):
Apply the hostingDeviceScaleFactor transform to -sublayerTransform instead of to
-transform. This more directly inverts the tranform WebProcess and allows -transform
to be used for animation in the UIProcess. This is important because UIView's actions
animate -transform, but not -sublayerTrasform.

(WebKit::WebVideoFullscreenManagerProxy::didCleanupFullscreen): layer -> view
(WebKit::WebVideoFullscreenModelContext::setVideoLayerFrame): Deleted.
(WebKit::WebVideoFullscreenModelContext::videoLayerFrame): Deleted.
(WebKit::WebVideoFullscreenModelContext::setVideoLayerGravity): Deleted.
(WebKit::WebVideoFullscreenModelContext::videoLayerGravity): Deleted.
* WebProcess/ios/WebVideoFullscreenManager.mm:
(WebKit::WebVideoFullscreenManager::enterVideoFullscreenForVideoElement):
Set initial video layer frame to fix start point of animation.

(WebKit::WebVideoFullscreenManager::didSetupFullscreen):
dispatch_async allows the CATransaction to complete before continuing with the animation.
This prevents a flash during animation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd PLATFORM #ifdefs for Mac SPI headers
andersca@apple.com [Mon, 20 Jul 2015 23:26:04 +0000 (23:26 +0000)]
Add PLATFORM #ifdefs for Mac SPI headers
https://bugs.webkit.org/show_bug.cgi?id=147129

Reviewed by Tim Horton.

* Configurations/WebCore.xcconfig:
Skip NPAPI headers on iOS.

* platform/mac/WebVideoFullscreenController.h:
* platform/spi/mac/DataDetectorsSPI.h:
* platform/spi/mac/NSEventSPI.h:
* platform/spi/mac/NSFontSPI.h:
* platform/spi/mac/NSMenuSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r174287): Flash of black when opening a new web view or navigating to...
timothy_horton@apple.com [Mon, 20 Jul 2015 22:33:16 +0000 (22:33 +0000)]
REGRESSION (r174287): Flash of black when opening a new web view or navigating to a new page
https://bugs.webkit.org/show_bug.cgi?id=147127
<rdar://problem/21474317>

Reviewed by Simon Fraser.

* rendering/RenderView.cpp:
(WebCore::RenderView::paintBoxDecorations):

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::snapshotAtSize):
Avoid using an invalid documentBackgroundColor, fall back to baseBackgroundColor
like we did before r174287.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWKSI support for blocking a plug-in for non-security reasons.
commit-queue@webkit.org [Mon, 20 Jul 2015 21:48:04 +0000 (21:48 +0000)]
WKSI support for blocking a plug-in for non-security reasons.
https://bugs.webkit.org/show_bug.cgi?id=145009

Patch by Gordon Sheridan <gordon_sheridan@apple.com> on 2015-07-20
Reviewed by Anders Carlsson.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceMavericks.a:
* libWebKitSystemInterfaceYosemite.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Unreviewed build fix after r187022.
achristensen@apple.com [Mon, 20 Jul 2015 21:43:13 +0000 (21:43 +0000)]
[Win] Unreviewed build fix after r187022.

* platform/win/WindowsTouch.h:
Undid changes from r187022

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAllow video to rotate when app doesnt allow rotation.
commit-queue@webkit.org [Mon, 20 Jul 2015 21:37:18 +0000 (21:37 +0000)]
Allow video to rotate when app doesnt allow rotation.
https://bugs.webkit.org/show_bug.cgi?id=147121

Patch by Jeremy Jones <jeremyj@apple.com> on 2015-07-20
Reviewed by Jer Noble.

Set an SPI bool on the fullscreen video root view controller to allow it to override app rotation restrictions.
This allows video to be played in landscape in portrait only apps.

* platform/ios/WebVideoFullscreenInterfaceAVKit.mm:
(WebVideoFullscreenInterfaceAVKit::setupFullscreen):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed assertion fix following r187031.
akling@apple.com [Mon, 20 Jul 2015 21:28:45 +0000 (21:28 +0000)]
Unreviewed assertion fix following r187031.

Just have GenericEventQueue::resume() return early if the queue isn't suspended.
Suspend/Resume calls are not always symmetrical in HTMLMediaElement.

* dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::resume):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnexpected ABI diffference between armv7 and armv7s in WebCore::GraphicsLayerCA:...
ddkilzer@apple.com [Mon, 20 Jul 2015 21:20:34 +0000 (21:20 +0000)]
Unexpected ABI diffference between armv7 and armv7s in WebCore::GraphicsLayerCA::~GraphicsLayerCA()
<http://webkit.org/b/147101>

Reviewed by Michael Saboff.

* platform/graphics/transforms/TransformationMatrix.h: Align
Matrix4 on both armv7 and armv7s.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago"let" scoping introduced incoherent story about symbol table cloning
saambarati1@gmail.com [Mon, 20 Jul 2015 21:16:41 +0000 (21:16 +0000)]
"let" scoping introduced incoherent story about symbol table cloning
https://bugs.webkit.org/show_bug.cgi?id=147046

Reviewed by Filip Pizlo.

This patch now establishes a clear set of rules for how SymbolTables
are owned by CodeBlock. Every SymbolTable that is used by a bytecode
instruction must live in CodeBlock's constant register pool. When CodeBlock
is being linked, it ensures that every SymbolTable in the constant pool is cloned.
This leaves no room for an un-cloned symbol table to be used by a bytecode instruction.
Some instructions may refer to SymbolTable's indirectly through a JSLexicalEnvironment.
This is fine, all JSLexicalEnvironment's are allocated with references to cloned symbol tables.

Another goal of this patch is to remove the notion that a SymbolTable is 1 to 1
with a CodeBlock. With lexical scoping, this view of the world is no longer
correct. This patch begins to remove this assumption by making CodeBlock's
symbolTable() getter method private. There is still one place where we need
to purge our codebase of this assumption and that is the type profiler. It
has not been updated for lexical scoping. After it is updated in
https://bugs.webkit.org/show_bug.cgi?id=145438
we will be able to remove CodeBlock's symbolTable() getter entirely.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::nameForRegister):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addStringSwitchJumpTable):
(JSC::CodeBlock::stringSwitchJumpTable):
(JSC::CodeBlock::evalCodeCache):
(JSC::CodeBlock::symbolTable):
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedFunctionExecutable::visitChildren):
(JSC::UnlinkedFunctionExecutable::link):
(JSC::UnlinkedFunctionExecutable::codeBlockFor):
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::addExceptionHandler):
(JSC::UnlinkedCodeBlock::exceptionHandler):
(JSC::UnlinkedCodeBlock::setSymbolTableConstantIndex):
(JSC::UnlinkedCodeBlock::symbolTableConstantIndex):
(JSC::UnlinkedCodeBlock::symbolTable): Deleted.
(JSC::UnlinkedCodeBlock::setSymbolTable): Deleted.
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::variableForLocalEntry):
(JSC::BytecodeGenerator::createVariable):
(JSC::BytecodeGenerator::resolveType):
(JSC::BytecodeGenerator::emitResolveScope):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::thisRegister):
(JSC::BytecodeGenerator::instructions):
(JSC::BytecodeGenerator::symbolTable): Deleted.
* dfg/DFGGraph.h:
(JSC::DFG::Graph::baselineCodeBlockFor):
(JSC::DFG::Graph::isStrictModeFor):
(JSC::DFG::Graph::symbolTableFor): Deleted.
* jit/AssemblyHelpers.h:
(JSC::AssemblyHelpers::baselineCodeBlock):
(JSC::AssemblyHelpers::argumentsStart):
(JSC::AssemblyHelpers::symbolTableFor): Deleted.
* runtime/CommonSlowPaths.cpp:
(JSC::SLOW_PATH_DECL):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::visitChildren):
(JSC::FunctionExecutable::clearUnlinkedCodeForRecompilation):
(JSC::FunctionExecutable::symbolTable): Deleted.
* runtime/Executable.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd the necessary platform checks to iOS SPI headers
andersca@apple.com [Mon, 20 Jul 2015 20:45:42 +0000 (20:45 +0000)]
Add the necessary platform checks to iOS SPI headers
https://bugs.webkit.org/show_bug.cgi?id=147120

Reviewed by Tim Horton.

* platform/spi/ios/GraphicsServicesSPI.h:
* platform/spi/ios/MediaPlayerSPI.h:
* platform/spi/ios/MobileGestaltSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImprove behavior of media elements in page cache.
akling@apple.com [Mon, 20 Jul 2015 20:16:18 +0000 (20:16 +0000)]
Improve behavior of media elements in page cache.
<https://webkit.org/b/147020>
<rdar://problem/21712311>

Reviewed by Chris Dumez.

Source/WebCore:

Make improvements for media elements when transitioning in/out of page cache:

- Events that were scheduled when going into cache will now be delivered
  when the page is restored from cache.

- Data buffering is turned off while in the cache. This reduces the memory
  cost of cached pages with media elements on iOS (where mediaserverd would
  keep upcoming video frames in memory for cached pages.)

Test: media/restore-from-page-cache.html (amended)

* dom/GenericEventQueue.h:
* dom/GenericEventQueue.cpp:
(WebCore::GenericEventQueue::enqueueEvent):
(WebCore::GenericEventQueue::suspend):
(WebCore::GenericEventQueue::resume):

    Add a simple suspend/resume mechanism to GenericEventQueue that can
    be used to support page caching.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::stop):
(WebCore::HTMLMediaElement::suspend):
(WebCore::HTMLMediaElement::resume):
(WebCore::HTMLMediaElement::stopWithoutDestroyingMediaPlayer):

    Adapt to event queueing changes and add calls to setShouldBufferData().

* html/HTMLSourceElement.h:
* html/HTMLSourceElement.cpp:
(WebCore::HTMLSourceElement::HTMLSourceElement):
(WebCore::HTMLSourceElement::create):
(WebCore::HTMLSourceElement::activeDOMObjectName):
(WebCore::HTMLSourceElement::canSuspendForPageCache):
(WebCore::HTMLSourceElement::suspend):
(WebCore::HTMLSourceElement::resume):
(WebCore::HTMLSourceElement::stop):

    Turn HTMLSourceElement into an ActiveDOMObject so it gets all the
    appropriate page cache notifications directly. Suspend the delayed
    error event delivery timer when cached.

LayoutTests:

Add some coverage for suspend/resume of queued events on cached media elements.

* media/restore-from-page-cache-expected.txt:
* media/restore-from-page-cache.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Seccomp] Should be easier to debug blocked syscalls
mcatanzaro@igalia.com [Mon, 20 Jul 2015 20:06:27 +0000 (20:06 +0000)]
[Seccomp] Should be easier to debug blocked syscalls
https://bugs.webkit.org/show_bug.cgi?id=142980

These should be printed even when not running in debug mode. There is no
value in hiding errors from release build users.

Reviewed by Žan Doberšek.

* Shared/linux/SeccompFilters/SeccompBroker.cpp:
(WebKit::SeccompBroker::runLoop): Don't close stderr et. al. in release builds.
* Shared/linux/SeccompFilters/Syscall.cpp:
(WebKit::write_uint): Added.
(WebKit::reportUnexpectedSyscall): Added.
(WebKit::Syscall::createFromContext): Call reportUnexpectedSyscall. Also, no need to crash
here in release builds.
* Shared/linux/SeccompFilters/SyscallPolicy.cpp:
(WebKit::SyscallPolicy::hasPermissionForPath): Print a warning when access is denied.
(WebKit::SyscallPolicy::permissionToString): Added.
* Shared/linux/SeccompFilters/SyscallPolicy.h: Add permissionToString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the !ENABLE(VIDEO) build after r186396
ossy@webkit.org [Mon, 20 Jul 2015 19:50:54 +0000 (19:50 +0000)]
Fix the !ENABLE(VIDEO) build after r186396
https://bugs.webkit.org/show_bug.cgi?id=147116

Reviewed by Brent Fulgham.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::didClose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION(186691): OSR entry is broken on loop headers that have no live variables
fpizlo@apple.com [Mon, 20 Jul 2015 19:04:19 +0000 (19:04 +0000)]
REGRESSION(186691): OSR entry is broken on loop headers that have no live variables
https://bugs.webkit.org/show_bug.cgi?id=147074
rdar://problem/21869970

Reviewed by Michael Saboff.

The OSR entry must-handle block/value widening introduced in r186691 would cause the
CFA to reexecute if it caused any live local variables to change value. But this fails
if the must-handle block has no live local variables, and the entry block otherwise
appears to be unreachable.

This fixes the bug by having the change detection include whether the block hadn't been
visited in addition to whether any local variable values got widened.

This is a ~4% speed-up on SunSpider in browser.

* dfg/DFGCFAPhase.cpp:
(JSC::DFG::CFAPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Certain Debug builds can take close to 3 hours to link
bfulgham@apple.com [Mon, 20 Jul 2015 18:51:41 +0000 (18:51 +0000)]
[Win] Certain Debug builds can take close to 3 hours to link
https://bugs.webkit.org/show_bug.cgi?id=147114
<rdar://problem/21882777>

Reviewed by Tim Horton.

Correct the 64-bit DebugSuffix link target to match the 32-bit version.

* WebKit.vcxproj/WebKit/WebKit.vcxproj: Turn off the REF and ICF
flags for the 64-bit DebugSuffix link target.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRollout r187020 and r187021: breaks JSC API tests on debug builds.
mark.lam@apple.com [Mon, 20 Jul 2015 18:12:56 +0000 (18:12 +0000)]
Rollout r187020 and r187021: breaks JSC API tests on debug builds.
https://bugs.webkit.org/show_bug.cgi?id=147110

Source/JavaScriptCore:

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
* runtime/JSLock.cpp:
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::willDestroyVM):
(JSC::JSLock::setExclusiveThread):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
(JSC::JSLock::dropAllLocks):
* runtime/JSLock.h:
(JSC::JSLock::vm):
(JSC::JSLock::hasExclusiveThread):
(JSC::JSLock::exclusiveThread):
* runtime/VM.h:
(JSC::VM::hasExclusiveThread):
(JSC::VM::exclusiveThread):
(JSC::VM::setExclusiveThread):

Source/WebCore:

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonVM):

Source/WTF:

* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
* wtf/WTFThreadData.h:
(WTF::WTFThreadData::stack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix deadlock between -[AVPlayerItem currentTime] and -[AVPlayer isExternalPlaybackActive]
adachan@apple.com [Mon, 20 Jul 2015 18:05:59 +0000 (18:05 +0000)]
Fix deadlock between -[AVPlayerItem currentTime] and -[AVPlayer isExternalPlaybackActive]
https://bugs.webkit.org/show_bug.cgi?id=147085
<rdar://problem/21878275>

Reviewed by Jer Noble.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::isPlayingAudioDidChange):
Call Document::updateIsPlayingMedia() on the main thread, since we could be on the audio I/O
thread here and the Document::updateIsPlayingMedia() call could block, causing a deadlock.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Add selection-changed signal to the WebKit2 API
commit-queue@webkit.org [Mon, 20 Jul 2015 17:42:01 +0000 (17:42 +0000)]
[GTK] Add selection-changed signal to the WebKit2 API
https://bugs.webkit.org/show_bug.cgi?id=137116

Patch by Tomas Popela <tpopela@redhat.com> on 2015-07-20
Reviewed by Carlos Garcia Campos.

Source/WebKit2:

Add a new object WebKitWebEditor where the editing capabilities of a
WebPage will be grouped and exposed. Add the selection-changed signal
there (we used the same name as in WK1 API).

* PlatformGTK.cmake:
* UIProcess/API/gtk/docs/webkit2gtk-4.0-sections.txt:
* WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.cpp: Added.
(didChangeSelection):
(webkitWebEditorCreate):
(webkit_web_editor_get_page):
* WebProcess/InjectedBundle/API/gtk/WebKitWebEditor.h: Added.
* WebProcess/InjectedBundle/API/gtk/WebKitWebEditorPrivate.h: Added.
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.cpp:
(webkitWebPageGetPage):
(webkit_web_page_get_editor):
* WebProcess/InjectedBundle/API/gtk/WebKitWebPage.h:
* WebProcess/InjectedBundle/API/gtk/WebKitWebPagePrivate.h:
* WebProcess/InjectedBundle/API/gtk/webkit-web-extension.h:

Tools:

Add a new WebProcess test TestEditor that is testing the WebKitWebEditor
(namely the selection-changed signal).

* TestWebKitAPI/Tests/WebKit2Gtk/CMakeLists.txt:
* TestWebKitAPI/Tests/WebKit2Gtk/EditorTest.cpp: Added.
(WebKitWebEditorTest::create):
(WebKitWebEditorTest::selectionChangedCallback):
(WebKitWebEditorTest::testSelectionSelectAll):
(WebKitWebEditorTest::testSelectionCollapse):
(WebKitWebEditorTest::testSelectionModifyMove):
(WebKitWebEditorTest::testSelectionModifyExtend):
(WebKitWebEditorTest::testSelectionUnselect):
(registerTests):
* TestWebKitAPI/Tests/WebKit2Gtk/TestEditor.cpp: Added.
(testWebKitWebEditorSelectionChanged):
(beforeAll):
(afterAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebsiteDataStore operations need to grab background assertions
andersca@apple.com [Mon, 20 Jul 2015 17:08:10 +0000 (17:08 +0000)]
WebsiteDataStore operations need to grab background assertions
https://bugs.webkit.org/show_bug.cgi?id=147015
rdar://problem/21799011

Reviewed by Sam Weinig.

* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::fetchWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteData):
(WebKit::NetworkProcessProxy::deleteWebsiteDataForOrigins):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::fetchWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteData):
(WebKit::WebProcessProxy::deleteWebsiteDataForOrigins):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoResurrect CMake build on Windows.
achristensen@apple.com [Mon, 20 Jul 2015 15:55:03 +0000 (15:55 +0000)]
Resurrect CMake build on Windows.
https://bugs.webkit.org/show_bug.cgi?id=147083

Reviewed by Gyuyoung Kim.

.:

* Source/cmake/OptionsCommon.cmake:
* Source/cmake/OptionsWindows.cmake:
Change features to get it to compile.  Still not a complete feature set.

Source/WebCore:

* CMakeLists.txt:
* PlatformWin.cmake:
* dom/Document.cpp:
(WebCore::Document::~Document):
* dom/Range.cpp:
* dom/Text.cpp:
* editing/CompositeEditCommand.cpp:
* platform/graphics/texmap/BitmapTexturePool.cpp:
(WebCore::BitmapTexturePool::createTexture):
* platform/win/WindowsTouch.h:
* rendering/RenderThemeWin.h:
Fixed some including and compiling quirks needed for different configurations.

Source/WebKit:

* PlatformWin.cmake: Added.
Based on original work by Patrick Gansterer and Mark Salisbury
in https://bugs.webkit.org/show_bug.cgi?id=72816

Source/WTF:

* wtf/PlatformWin.cmake:

Tools:

* DumpRenderTree/CMakeLists.txt:
* DumpRenderTree/PlatformWin.cmake: Added.
* WinLauncher/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed debug build fix after r187020.
peavo@outlook.com [Mon, 20 Jul 2015 12:04:20 +0000 (12:04 +0000)]
Unreviewed debug build fix after r187020.

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::addCurrentThread):
VM::exclusiveThread() has changed return type to ThreadIdentifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoJavaScriptCore performance is very bad on Windows
peavo@outlook.com [Mon, 20 Jul 2015 09:14:10 +0000 (09:14 +0000)]
JavaScriptCore performance is very bad on Windows
https://bugs.webkit.org/show_bug.cgi?id=146448

Reviewed by Mark Lam.

Source/JavaScriptCore:

Profiling shows that std::this_thread::get_id() is slow on Windows.
Use WTF::currentThread() instead, which calls GetCurrentThreadId().
This is faster on Windows. The issue has been reported to Microsoft,
https://connect.microsoft.com/VisualStudio/feedback/details/1558211.

* runtime/JSLock.cpp:
(JSC::JSLockHolder::~JSLockHolder):
(JSC::JSLock::JSLock):
(JSC::JSLock::willDestroyVM):
(JSC::JSLock::setExclusiveThread):
(JSC::JSLock::lock):
(JSC::JSLock::unlock):
(JSC::JSLock::currentThreadIsHoldingLock):
* runtime/JSLock.h:
(JSC::JSLock::vm):
(JSC::JSLock::hasExclusiveThread):
(JSC::JSLock::exclusiveThread):
* runtime/VM.h:
(JSC::VM::hasExclusiveThread):
(JSC::VM::exclusiveThread):
(JSC::VM::setExclusiveThread):

Source/WebCore:

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::commonVM): Compile fix.

Source/WTF:

Updating the stack bounds is time consuming.
Only update the stack bounds when a new fiber is running.

* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
* wtf/WTFThreadData.h:
(WTF::WTFThreadData::stack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUse isnan from std namespace in Stopwatch.h.
julien.brianceau@gmail.com [Mon, 20 Jul 2015 07:19:11 +0000 (07:19 +0000)]
Use isnan from std namespace in Stopwatch.h.
https://bugs.webkit.org/show_bug.cgi?id=146911

Reviewed by Žan Doberšek.

* wtf/Stopwatch.h:
(WTF::Stopwatch::isActive):
(WTF::Stopwatch::start):
(WTF::Stopwatch::stop):
(WTF::Stopwatch::elapsedTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMake shrink-wrapping test a ref-test instead of pixel-test
timothy_horton@apple.com [Mon, 20 Jul 2015 06:38:40 +0000 (06:38 +0000)]
Make shrink-wrapping test a ref-test instead of pixel-test
https://bugs.webkit.org/show_bug.cgi?id=147081

Reviewed by Sam Weinig.

Source/WebCore:

Nobody runs pixel tests.

* svg/SVGPathUtilities.cpp:
(WebCore::pathIteratorForBuildingString):
(WebCore::buildStringFromPath):
* svg/SVGPathUtilities.h:
Add a helper that turns a Path into a SVG path string.

* testing/Internals.cpp:
(WebCore::Internals::pathStringWithShrinkWrappedRects):
* testing/Internals.h:
* testing/Internals.idl:
Have the internals shrink-wrap method return an SVG path instead of a DOMPath.

LayoutTests:

* fast/shrink-wrap/rect-shrink-wrap-expected.html: Added.
* fast/shrink-wrap/rect-shrink-wrap-expected.png: Removed.
* fast/shrink-wrap/rect-shrink-wrap-expected.txt: Removed.
* fast/shrink-wrap/rect-shrink-wrap.html:
SVG all the things.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoIn strict mode, `Object.keys(arguments)` includes "length"
utatane.tea@gmail.com [Sun, 19 Jul 2015 23:37:45 +0000 (23:37 +0000)]
In strict mode, `Object.keys(arguments)` includes "length"
https://bugs.webkit.org/show_bug.cgi?id=147071

Reviewed by Darin Adler.

ClonedAguments didn't set the "length" with DontEnum.

* runtime/ClonedArguments.cpp:
(JSC::ClonedArguments::createWithInlineFrame):
(JSC::ClonedArguments::createByCopyingFrom):
* tests/stress/arguments-length-always-dont-enum.js: Added.
(shouldBe):
(argsSloppy):
(argsStrict):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agonew Date(NaN).toJSON() must return null instead of throwing a TypeError
commit-queue@webkit.org [Sun, 19 Jul 2015 23:10:07 +0000 (23:10 +0000)]
new Date(NaN).toJSON() must return null instead of throwing a TypeError
https://bugs.webkit.org/show_bug.cgi?id=141115

Patch by Jordan Harband <ljharb@gmail.com> on 2015-07-19
Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToJSON):

LayoutTests:

* js/dom/JSON-stringify-expected.txt:
* js/resources/JSON-stringify.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Enable seccomp filter API tests
mcatanzaro@igalia.com [Sun, 19 Jul 2015 22:27:00 +0000 (22:27 +0000)]
[GTK] Enable seccomp filter API tests
https://bugs.webkit.org/show_bug.cgi?id=140071

Reviewed by Žan Doberšek.

These tests will now be run by the run-gtk-tests script.

* TestWebKitAPI/PlatformGTK.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoParser::parseFunctionInfo hits RELEASE_ASSERT for Arrow Functions
saambarati1@gmail.com [Sun, 19 Jul 2015 19:31:36 +0000 (19:31 +0000)]
Parser::parseFunctionInfo hits RELEASE_ASSERT for Arrow Functions
https://bugs.webkit.org/show_bug.cgi?id=147090

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

ArrowFunction's have there ParserFunctionInfo "name" field to
be a non-null pointer. This is obviously allowed and valid except we
had a RELEASE_ASSERT that claimed otherwise. This is a mistake.

Note: ArrowFunction's will never actually have a function name;
there ParserFunctionInfo "name" field will be the empty string.
This is not be mistaken with the name field being a null pointer.

* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseFunctionInfo):

LayoutTests:

* js/arrowfunction-strict-mode-expected.txt: Added.
* js/arrowfunction-strict-mode.html: Added.
* js/script-tests/arrowfunction-strict-mode.js: Added.
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, placate -Wmismatched-tags after r187011
mcatanzaro@igalia.com [Sun, 19 Jul 2015 19:14:44 +0000 (19:14 +0000)]
Unreviewed, placate -Wmismatched-tags after r187011

It's basically bug #146990 again. Oops.

* WebProcess/gtk/SeccompFiltersWebProcessGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[ES6] Add support for block scope const
saambarati1@gmail.com [Sun, 19 Jul 2015 16:57:44 +0000 (16:57 +0000)]
[ES6] Add support for block scope const
https://bugs.webkit.org/show_bug.cgi?id=31813

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

'const' is now implemented in an ES6 spec compliant manner.
'const' variables are always block scoped and always live
either on the stack or in a JSLexicalEnvironment. 'const'
variables never live on the global object.

Inside the BytecodeGenerator, when assigning to a stack
'const' variable or a LocalClosureVar 'const' variable,
we will emit code that just throws a type error.
When assigning to a ClosureVar const variable, CodeBlock linking
will ensure that we perform a dynamic lookup of that variable so
that put_to_scope's slow path throws a type error.

The old 'const' implementation has been removed in this patch.

* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
(JSC::CodeBlock::CodeBlock):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::pushLexicalScope):
(JSC::BytecodeGenerator::prepareLexicalScopeForNextForLoopIteration):
(JSC::BytecodeGenerator::variable):
(JSC::BytecodeGenerator::variableForLocalEntry):
(JSC::BytecodeGenerator::createVariable):
(JSC::BytecodeGenerator::emitResolveScope):
(JSC::BytecodeGenerator::emitInstanceOf):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::isArgumentNumber):
(JSC::BytecodeGenerator::emitReadOnlyExceptionIfNeeded):
(JSC::BytecodeGenerator::emitEnumeration):
(JSC::BytecodeGenerator::variablePerSymbolTable): Deleted.
(JSC::BytecodeGenerator::emitInitGlobalConst): Deleted.
* bytecompiler/BytecodeGenerator.h:
(JSC::Variable::Variable):
(JSC::Variable::isReadOnly):
(JSC::Variable::isSpecial):
(JSC::Variable::isConst):
(JSC::BytecodeGenerator::thisRegister):
(JSC::BytecodeGenerator::emitTypeOf):
(JSC::BytecodeGenerator::emitIn):
* bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PrefixNode::emitResolve):
(JSC::ReadModifyResolveNode::emitBytecode):
(JSC::AssignResolveNode::emitBytecode):
(JSC::CommaNode::emitBytecode):
(JSC::BindingNode::bindValue):
(JSC::ConstDeclNode::emitCodeSingle): Deleted.
(JSC::ConstDeclNode::emitBytecode): Deleted.
(JSC::ConstStatementNode::emitBytecode): Deleted.
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* dfg/DFGCapabilities.cpp:
(JSC::DFG::capabilityLevel):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_to_arguments):
(JSC::JIT::emit_op_init_global_const): Deleted.
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_to_arguments):
(JSC::JIT::emit_op_init_global_const): Deleted.
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createDeclarationStatement):
(JSC::ASTBuilder::createEmptyVarExpression):
(JSC::ASTBuilder::createDebugger):
(JSC::ASTBuilder::appendStatement):
(JSC::ASTBuilder::createVarStatement): Deleted.
(JSC::ASTBuilder::createLetStatement): Deleted.
(JSC::ASTBuilder::createConstStatement): Deleted.
(JSC::ASTBuilder::appendConstDecl): Deleted.
* parser/NodeConstructors.h:
(JSC::CommaNode::CommaNode):
(JSC::SourceElements::SourceElements):
(JSC::SwitchNode::SwitchNode):
(JSC::BlockNode::BlockNode):
(JSC::ConstStatementNode::ConstStatementNode): Deleted.
(JSC::ConstDeclNode::ConstDeclNode): Deleted.
* parser/Nodes.h:
(JSC::ConstDeclNode::hasInitializer): Deleted.
(JSC::ConstDeclNode::ident): Deleted.
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseStatementListItem):
(JSC::Parser<LexerType>::parseVariableDeclaration):
(JSC::Parser<LexerType>::parseWhileStatement):
(JSC::Parser<LexerType>::parseVariableDeclarationList):
(JSC::Parser<LexerType>::createBindingPattern):
(JSC::Parser<LexerType>::parseDestructuringPattern):
(JSC::Parser<LexerType>::parseDefaultValueForDestructuringPattern):
(JSC::Parser<LexerType>::parseForStatement):
(JSC::Parser<LexerType>::parseTryStatement):
(JSC::Parser<LexerType>::parseFunctionInfo):
(JSC::Parser<LexerType>::parseFunctionDeclaration):
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseConstDeclaration): Deleted.
(JSC::Parser<LexerType>::parseConstDeclarationList): Deleted.
* parser/Parser.h:
(JSC::isEvalNode):
(JSC::isEvalNode<EvalNode>):
(JSC::isArguments):
(JSC::isEval):
(JSC::isEvalOrArgumentsIdentifier):
(JSC::Scope::Scope):
(JSC::Scope::declareCallee):
(JSC::Scope::declareVariable):
(JSC::Scope::declareLexicalVariable):
(JSC::Scope::hasDeclaredVariable):
(JSC::Scope::allowsVarDeclarations):
(JSC::Scope::allowsLexicalDeclarations):
(JSC::Scope::declareParameter):
(JSC::Scope::declareBoundParameter):
(JSC::Parser::destructuringKindFromDeclarationType):
(JSC::Parser::assignmentContextFromDeclarationType):
(JSC::Parser::isEvalOrArguments):
(JSC::Parser::currentScope):
(JSC::Parser::popScope):
(JSC::Parser::declareVariable):
(JSC::Parser::hasDeclaredVariable):
(JSC::Parser::setStrictMode):
(JSC::Parser::strictMode):
(JSC::Parser::isValidStrictMode):
(JSC::Parser::declareParameter):
(JSC::Parser::declareBoundParameter):
(JSC::Parser::breakIsValid):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createForInLoop):
(JSC::SyntaxChecker::createForOfLoop):
(JSC::SyntaxChecker::createEmptyStatement):
(JSC::SyntaxChecker::createDeclarationStatement):
(JSC::SyntaxChecker::createReturnStatement):
(JSC::SyntaxChecker::createBreakStatement):
(JSC::SyntaxChecker::createVarStatement): Deleted.
(JSC::SyntaxChecker::createLetStatement): Deleted.
* parser/VariableEnvironment.h:
(JSC::VariableEnvironmentEntry::isCaptured):
(JSC::VariableEnvironmentEntry::isConst):
(JSC::VariableEnvironmentEntry::isVar):
(JSC::VariableEnvironmentEntry::isLet):
(JSC::VariableEnvironmentEntry::setIsCaptured):
(JSC::VariableEnvironmentEntry::setIsConst):
(JSC::VariableEnvironmentEntry::setIsVar):
(JSC::VariableEnvironmentEntry::setIsLet):
(JSC::VariableEnvironmentEntry::isConstant): Deleted.
(JSC::VariableEnvironmentEntry::setIsConstant): Deleted.
* runtime/Executable.cpp:
(JSC::ProgramExecutable::initializeGlobalProperties):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::defineOwnProperty):
(JSC::JSGlobalObject::addGlobalVar):
(JSC::JSGlobalObject::addFunction):
(JSC::lastInPrototypeChain):
* runtime/JSGlobalObject.h:
(JSC::JSGlobalObject::finishCreation):
(JSC::JSGlobalObject::addVar):
(JSC::JSGlobalObject::addConst): Deleted.
* runtime/JSLexicalEnvironment.cpp:
(JSC::JSLexicalEnvironment::symbolTablePut):
* tests/stress/const-and-with-statement.js: Added.
(truth):
(assert):
(shouldThrowInvalidConstAssignment):
(.):
* tests/stress/const-exception-handling.js: Added.
(truth):
(assert):
(.):
* tests/stress/const-loop-semantics.js: Added.
(truth):
(assert):
(shouldThrowInvalidConstAssignment):
(.):
* tests/stress/const-not-strict-mode.js: Added.
(truth):
(assert):
(shouldThrowTDZ):
(.):
* tests/stress/const-semantics.js: Added.
(truth):
(assert):
(shouldThrowInvalidConstAssignment):
(.):
* tests/stress/const-tdz.js: Added.
(truth):
(assert):
(shouldThrowTDZ):
(.):

Source/WebInspectorUI:

"const" variables do not live on the global object and are only
accessible within the "Program" they're defined in. Therefore,
the WebInspector global must be defined as "var" and not "const".

* UserInterface/Base/WebInspector.js:

LayoutTests:

"const" variables do not live on the global object. They
are only available in the "Program" (read: JavaScript file or
script tag) that they're defined in. Tests have been updated
accordingly to switch the "const" variables assumed to be globals
into "var"s. "var" declared variables in the top level scope
of a program do live on the global object.

* fast/canvas/webgl/compressed-tex-image.html:
* fast/dom/event-handler-attributes.html:
* fast/forms/listbox-visible-size.html:
* js/arguments-expected.txt:
* js/arrowfunction-syntax-errors-expected.txt:
* js/const-expected.txt:
* js/const-without-initializer-expected.txt:
* js/constant-count-expected.txt:
* js/dom/inc-const-valueOf-expected.txt:
* js/dom/script-tests/inc-const-valueOf.js:
(testPreIncConstVarWithAssign):
* js/function-toString-parentheses-expected.txt:
* js/kde/const-expected.txt:
* js/kde/resources/const.js:
* js/parser-syntax-check-expected.txt:
* js/script-tests/arguments.js:
(argumentsVarUndefined):
(argumentsConst):
(argumentCalleeInException):
(argumentsConstUndefined): Deleted.
* js/script-tests/class-syntax-declaration.js:
(A):
* js/script-tests/class-syntax-expression.js:
* js/script-tests/const-without-initializer.js:
* js/script-tests/const.js:
(shouldThrowInvalidConstAssignment):
(assert):
(f):
(tryCatch1):
(tryCatch2):
(with1):
(with2):
(.):
* js/script-tests/constant-count.js:
(f):
* js/script-tests/function-dot-arguments.js:
(assignConstInitTest2.g):
(assignConstInitTest2):
* js/script-tests/function-toString-parentheses.js:
* js/script-tests/parser-syntax-check.js:
* sputnik/Conformance/07_Lexical_Conventions/7.5_Tokens/7.5.3_Future_Reserved_Words/S7.5.3_A1.6-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T7-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T8-expected.txt:
* sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A3.1_T9-expected.txt:
* sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A13_T3-expected.txt:
* sputnik/Conformance/08_Types/8.4_The_String_Type/S8.4_A14_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T1-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T2-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T3-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T4-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T6-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T7-expected.txt:
* sputnik/Conformance/12_Statement/12.2_Variable_Statement/S12.2_A8_T8-expected.txt:
* transforms/3d/hit-testing/composited-hit-test.html:
* transforms/3d/hit-testing/coplanar-with-camera.html:
* transforms/3d/hit-testing/hover-rotated-negative-z.html:
* transforms/3d/hit-testing/hover-rotated-with-children-negative-z.html:
* transforms/3d/hit-testing/negative-zoffset-hit-test.html:
* transforms/3d/hit-testing/overlapping-layers-hit-test.html:
* transforms/3d/hit-testing/perspective-clipped.html:
* transforms/3d/hit-testing/rotated-hit-test-with-child.html:
* transforms/3d/hit-testing/rotated-hit-test.html:
* transforms/3d/hit-testing/rotated-hit-test2.html:
* transitions/resources/transition-test-helpers.js:
(roundNumber):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Add seccomp filters support
mcatanzaro@igalia.com [Sun, 19 Jul 2015 16:32:58 +0000 (16:32 +0000)]
[GTK] Add seccomp filters support
https://bugs.webkit.org/show_bug.cgi?id=110014

Reviewed by Žan Doberšek.

.:

Find needed compiler and linker flags for libseccomp.

* Source/cmake/OptionsGTK.cmake:

Source/WebKit2:

Allow building with ENABLE_SECCOMP_FILTERS=ON. Based on work by Thiago Marcos P. Santos.

* PlatformGTK.cmake: Support ENABLE_SECCOMP_FILTERS build option.
* WebProcess/gtk/SeccompFiltersWebProcessGtk.cpp: Added.
(WebKit::SeccompFiltersWebProcessGtk::SeccompFiltersWebProcessGtk):
(WebKit::SeccompFiltersWebProcessGtk::platformInitialize):
* WebProcess/gtk/SeccompFiltersWebProcessGtk.h: Added.
* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::WebProcess::platformInitializeWebProcess): Initialize default
GTK+ web process seccomp filters.

Tools:

Add libseccomp to jhbuild modulesets.

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r187002): Broke the Windows build: Reduce PassRefPtr in WebKit2 - 3
ddkilzer@apple.com [Sun, 19 Jul 2015 13:16:54 +0000 (13:16 +0000)]
REGRESSION (r187002): Broke the Windows build: Reduce PassRefPtr in WebKit2 - 3
<https://bugs.webkit.org/show_bug.cgi?id=146995>

Attempt to fix the Windows build.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::createDocumentLoader):
(WebFrameLoaderClient::createFrame):
(WebFrameLoaderClient::createPlugin):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebDocumentLoader.cpp:
(WebDocumentLoader::create):
* WebDocumentLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoREGRESSION (r187008): CGPathCreateMutableCopyByTransformingPath() is not available...
ddkilzer@apple.com [Sun, 19 Jul 2015 12:35:12 +0000 (12:35 +0000)]
REGRESSION (r187008): CGPathCreateMutableCopyByTransformingPath() is not available on Windows
<https://bugs.webkit.org/show_bug.cgi?id=147077>

* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::transform): Restore less efficient code path
for Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSimplify Path(CG)::transform/translate
timothy_horton@apple.com [Sun, 19 Jul 2015 04:38:46 +0000 (04:38 +0000)]
Simplify Path(CG)::transform/translate
https://bugs.webkit.org/show_bug.cgi?id=147077

Reviewed by Simon Fraser.

No new tests; no behavior change.

* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::translate):
(WebCore::Path::transform):
Use CGPathCreateMutableCopyByTransformingPath to do the copy and transform
in a single call instead of two.

Make use of transform() to implement translate() instead of duplicating the code.
Move the two functions near each other.

(WebCore::Path::boundingRect):
Remove irrelevant reference to Snow Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@187008 268f45cc-cd09-0410-ab3c-d52691b4dbfc