WebKit-https.git
7 years ago<rdar://problem/12395187> REGRESSION (r121299): OS X Text Replacement forces cursor...
mitz@apple.com [Tue, 30 Oct 2012 18:05:45 +0000 (18:05 +0000)]
<rdar://problem/12395187> REGRESSION (r121299): OS X Text Replacement forces cursor out of text fields
https://bugs.webkit.org/show_bug.cgi?id=100768

Reviewed by Anders Carlsson.

Source/WebCore:

r121299 introduced code to restore the paragraph range by saving its length and start offset
relative to the document. The latter was obtained by iterating over the range starting at
the beginning of the document and ending at the beginning of the paragraph range. However,
such a range could not be constructed if the paragraph range was contained in a shadow DOM,
since a range must have both its endpoints within the same shadow tree (or not in a shadow
tree).

Test: platform/mac/editing/spelling/autocorrection-in-textarea.html

* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor): Changed paragraphStartIndex to be relative to the
root container of paragraphRange, using the same logic used by
checkForDifferentRootContainer() in Range.cpp.

LayoutTests:

* platform/mac/editing/spelling/autocorrection-in-textarea-expected.txt: Added.
* platform/mac/editing/spelling/autocorrection-in-textarea.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new crashing tests to paint the bot green.
ossy@webkit.org [Tue, 30 Oct 2012 17:25:45 +0000 (17:25 +0000)]
[Qt] Unreviewed gardening, skip new crashing tests to paint the bot green.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove ensureAuxiliaryContext
commit-queue@webkit.org [Tue, 30 Oct 2012 17:21:29 +0000 (17:21 +0000)]
Remove ensureAuxiliaryContext
https://bugs.webkit.org/show_bug.cgi?id=99975

Patch by Dan Carney <dcarney@google.com> on 2012-10-30
Reviewed by Adam Barth.

Source/WebCore:

Removed auxilliaryContext as use if it is problematic in IDB.

No new tests. No change in functionality.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::setValueReady):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::put):
(WebCore):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):
* bindings/v8/IDBBindingUtilities.h:
(WebCore):
* bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
(WebCore):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore):
* bindings/v8/V8PerIsolateData.h:

Source/WebKit/chromium:

Updated tests to use correct v8 context.

* tests/IDBBindingUtilitiesTest.cpp:
(WebKit::checkKeyFromValueAndKeyPathInternal):
(WebKit::checkKeyPathNullValue):
(WebKit::injectKey):
(WebKit::checkInjection):
(WebKit::checkInjectionFails):
(WebKit::checkKeyPathStringValue):
(WebKit::checkKeyPathNumberValue):
(WebKit::scriptExecutionContext):
(WebKit):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Unreviewed evening gardening, skip failing tests to paint the bot green.
ossy@webkit.org [Tue, 30 Oct 2012 17:16:20 +0000 (17:16 +0000)]
[Qt][WK2] Unreviewed evening gardening, skip failing tests to paint the bot green.

* platform/qt-5.0-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Add CustomFilterRenderer to reuse this class by Accelerated Compositing.
achicu@adobe.com [Tue, 30 Oct 2012 17:08:16 +0000 (17:08 +0000)]
[CSS Shaders] Add CustomFilterRenderer to reuse this class by Accelerated Compositing.
https://bugs.webkit.org/show_bug.cgi?id=98989

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-30
Reviewed by Dean Jackson.

Extract CustomFilterRenderer class from the rendering part of FECustomFilter.
FECustomFilter now plays a role in extending FilterEffect and delegates
rendering CSS Shaders to CustomFilterRenderer.

CustomFilterRenderer does not know Filter and FilterEffect. We can
create a CustomFilterRenderer instance with only GraphicsContext3D and
CustomFilterValidatedProgram. It means that Accelerated Compositing can
create the CustomFilterRenderer instance if Accelerated Compositing has
GraphicsContext3D and CustomFilterOperation, and it is already possible.

This patch prepares to enable CSS Shaders on Accelerated Compositing.

No new tests. Covered by css3/filters/custom

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/graphics/filters/CustomFilterRenderer.cpp: Added.
(WebCore):
(WebCore::orthogonalProjectionMatrix):
(WebCore::CustomFilterRenderer::create):
(WebCore::CustomFilterRenderer::CustomFilterRenderer):
(WebCore::CustomFilterRenderer::~CustomFilterRenderer):
(WebCore::CustomFilterRenderer::premultipliedAlpha):
(WebCore::CustomFilterRenderer::programNeedsInputTexture):
(WebCore::CustomFilterRenderer::draw):
(WebCore::CustomFilterRenderer::prepareForDrawing):
(WebCore::CustomFilterRenderer::initializeCompiledProgramIfNeeded):
(WebCore::CustomFilterRenderer::initializeMeshIfNeeded):
(WebCore::CustomFilterRenderer::bindVertexAttribute):
(WebCore::CustomFilterRenderer::unbindVertexAttribute):
(WebCore::CustomFilterRenderer::bindProgramArrayParameters):
(WebCore::CustomFilterRenderer::bindProgramNumberParameters):
(WebCore::CustomFilterRenderer::bindProgramTransformParameter):
(WebCore::CustomFilterRenderer::bindProgramParameters):
(WebCore::CustomFilterRenderer::bindProgramAndBuffers):
(WebCore::CustomFilterRenderer::unbindVertexAttributes):
* platform/graphics/filters/CustomFilterRenderer.h: Copied from Source/WebCore/platform/graphics/filters/FECustomFilter.h.
(WebCore):
(CustomFilterRenderer):
  CustomFilterRenderer renders custom filters in GPU using a
  GraphicsContext3D.
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
(WebCore::FECustomFilter::create):
(WebCore::FECustomFilter::deleteRenderBuffers):
(WebCore::FECustomFilter::drawFilterMesh):
(WebCore::FECustomFilter::prepareForDrawing):
(WebCore::FECustomFilter::applyShader):
(WebCore::FECustomFilter::resolveMultisampleBuffer):
(WebCore::FECustomFilter::resizeMultisampleBuffers):
(WebCore::FECustomFilter::resizeContext):
* platform/graphics/filters/FECustomFilter.h:
(WebCore):
(FECustomFilter):
* rendering/FilterEffectRenderer.cpp:
(WebCore::createCustomFilterEffect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][Qt] Enable hover and mouse events in flickable WebView
sergio@webkit.org [Tue, 30 Oct 2012 17:08:02 +0000 (17:08 +0000)]
[WK2][Qt] Enable hover and mouse events in flickable WebView
https://bugs.webkit.org/show_bug.cgi?id=100296

Reviewed by Kenneth Rohde Christiansen.

Flickable WebView is now allowed to handle both hover and mouse
events. Flickable was initially meant to be the mobile interface and
was only handling touch events, but now the idea is that it will be
the WebView for both mobile and desktop environments.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewPrivate::initialize): refactored hover and mouse
event handling from children classes.
(QQuickWebViewLegacyPrivate::initialize):
(QQuickWebViewFlickablePrivate::QQuickWebViewFlickablePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Associate console messages with the requests that caused them.
mkwst@chromium.org [Tue, 30 Oct 2012 16:49:31 +0000 (16:49 +0000)]
Web Inspector: Associate console messages with the requests that caused them.
https://bugs.webkit.org/show_bug.cgi?id=99941

Reviewed by Pavel Feldman.

The inspector currently supports the concept of a request's "initiator"
in order to add context to console messages that are generated in
response to a specific request. The initiator is used as the message's
anchor link iff a requestID is present, and no stack trace is present.

Currently, this functionality is only exposed to three specific
callsites: 'InspectorConsoleAgent::didFinishXHRLoading',
'InspectorConsoleAgent::didReceiveResponse', and
'InspectorConsoleAgent::didFailLoading'. This patch adds a generic
mechanism to associate requests with console messages by passing the
request's identifier through 'ScriptExecutionContext::addConsoleMessage'
or 'Console::addMessage' when relevant.

This patch should have no visible changes. It just installs some new
piping, and adjusts the three methods mentioned above to use it.
Existing tests shouldn't break.

* dom/Document.cpp:
(WebCore::Document::addMessage):
* dom/Document.h:
(Document):
    Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
    through to Console::addMessage.
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::addConsoleMessage):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
    Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
    through to the subclass' addMessage method.
* inspector/ConsoleMessage.cpp:
(WebCore::ConsoleMessage::ConsoleMessage):
    Accept an unsigned long instead of a string, and move the conversion
    from WebCore request identifiers to Inspector request identifiers
    into ConsoleMessage.
* inspector/ConsoleMessage.h:
(ConsoleMessage):
    Add 'requestIdentifier' (defaulting to 0) to the
    ConsoleMessage constructor that accepts a ScriptCallStack (it was
    already part of the constructor that accepted a line number).
* inspector/IdentifiersFactory.cpp:
(WebCore::IdentifiersFactory::requestId):
    If the provided request identifier is 0, return an empty string.
    This simplifies the logic at the callsite.
* inspector/InspectorConsoleAgent.cpp:
(WebCore::InspectorConsoleAgent::addMessageToConsole):
    Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
    through to the 'ConsoleMessage' constructor after converting it to
    an internal identifier via 'IdentifiersFactor::requestId'.
(WebCore::InspectorConsoleAgent::didFinishXHRLoading):
(WebCore::InspectorConsoleAgent::didReceiveResponse):
(WebCore::InspectorConsoleAgent::didFailLoading):
    Use the new 'requestIdentifier' parameter on addMessageToConsole
    rather than replicating the behavior in each of these three methods.
* inspector/InspectorConsoleAgent.h:
(InspectorConsoleAgent):
    Add a 'requestIdentifier' parameter (defaulting to 0).
* inspector/InspectorConsoleInstrumentation.h:
(WebCore::InspectorInstrumentation::addMessageToConsole):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
    Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
    through to lower levels of the stack.
* page/Console.cpp:
(WebCore::Console::addMessage):
* page/Console.h:
(Console):
    Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
    through to 'InspectorInstrumentation::addMessageToConsole'.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::addMessage):
(WebCore::WorkerContext::addMessageToWorkerConsole):
* workers/WorkerContext.h:
(WorkerContext):
    Add a 'requestIdentifier' parameter (defaulting to 0), and pipe it
    through to 'InspectorInstrumentation::addMessageToConsole'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][JHBUILD] Update EFL libraries to v1.7.1 stable release
commit-queue@webkit.org [Tue, 30 Oct 2012 16:34:23 +0000 (16:34 +0000)]
[EFL][JHBUILD] Update EFL libraries to v1.7.1 stable release
https://bugs.webkit.org/show_bug.cgi?id=100759

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Update Bump EFL libraries to the new stable release (v1.7.1)
in JHBuild to pull the latest bug fixes.

* efl/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoString::createCFString should return a RetainPtr
andersca@apple.com [Tue, 30 Oct 2012 16:10:14 +0000 (16:10 +0000)]
String::createCFString should return a RetainPtr
https://bugs.webkit.org/show_bug.cgi?id=100419

Reviewed by Andreas Kling.

Source/WebCore:

Update callers of String::createCFString.

* bridge/objc/objc_runtime.mm:
(JSC::Bindings::callObjCFallbackObject):
* html/HTMLMediaElement.cpp:
(WebCore::createFileURLForApplicationCacheResource):
* loader/archive/cf/LegacyWebArchive.cpp:
(WebCore::LegacyWebArchive::createPropertyListRepresentation):
* platform/LocalizedStrings.cpp:
(WebCore::formatLocalizedString):
(WebCore::contextMenuItemTagLookUpInDictionary):
(WebCore::keygenKeychainItemName):
(WebCore::imageTitle):
* platform/RuntimeApplicationChecks.cpp:
(WebCore::mainBundleIsEqualTo):
* platform/cf/FileSystemCF.cpp:
(WebCore::fileSystemRepresentation):
(WebCore::pathAsURL):
* platform/graphics/ca/win/PlatformCAAnimationWin.cpp:
(PlatformCAAnimation::PlatformCAAnimation):
* platform/graphics/ca/win/PlatformCALayerWin.cpp:
(resubmitAllAnimations):
(PlatformCALayer::addAnimationForKey):
(PlatformCALayer::removeAnimationForKey):
(PlatformCALayer::setName):
* platform/graphics/ca/win/PlatformCALayerWinInternal.cpp:
(PlatformCALayerWinInternal::updateTiles):
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::utiFromMIMEType):
* platform/graphics/cg/ImageSourceCGMac.mm:
(WebCore::MIMETypeForImageSourceType):
(WebCore::preferredExtensionForImageSourceType):
* platform/mac/ClipboardMac.mm:
(WebCore::cocoaTypeFromHTMLClipboardType):
(WebCore::utiTypeFromCocoaType):
* platform/mac/SSLKeyGeneratorMac.cpp:
(WebCore::signedPublicKeyAndChallengeString):
* platform/network/cf/AuthenticationCF.cpp:
(WebCore::createCF):
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::setCookies):
* platform/network/cf/DNSCFNet.cpp:
(WebCore::DNSResolveQueue::platformResolve):
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::cfError):
* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::setDefaultMIMEType):
(WebCore::willSendRequest):
(WebCore::ResourceHandle::didReceiveAuthenticationChallenge):
(WebCore::ResourceHandle::setPrivateBrowsingEnabled):
* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::setHeaderFields):
(WebCore::ResourceRequest::doUpdatePlatformRequest):
* platform/network/cf/ResourceResponseCFNet.cpp:
(WebCore::ResourceResponse::cfURLResponse):
* platform/network/cf/SocketStreamHandleCFNet.cpp:
(WebCore::SocketStreamHandle::createStreams):
(WebCore::SocketStreamHandle::addCONNECTCredentials):
(WebCore::SocketStreamHandle::copyCFStreamDescription):
* platform/network/mac/ResourceRequestMac.mm:
(WebCore::ResourceRequest::doUpdatePlatformRequest):
* platform/network/mac/WebCoreURLResponse.mm:
(WebCore::adjustMIMETypeIfNecessary):
* platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForKey):
* platform/text/cf/StringCF.cpp:
(WTF::String::createCFString):
* platform/text/cf/StringImplCF.cpp:
(WTF::StringImpl::createCFString):
* platform/text/mac/StringImplMac.mm:
(WTF::StringImpl::operator NSString *):
* platform/text/mac/TextCodecMac.cpp:
(WebCore::TextCodecMac::encode):
* platform/win/SearchPopupMenuWin.cpp:
(WebCore::autosaveKey):
(WebCore::SearchPopupMenuWin::saveRecentSearches):

Source/WebKit/cf:

Update callers of String::createCFString.

* WebCoreSupport/WebInspectorClientCF.cpp:
(createKeyForPreferences):
(populateSetting):
(storeSetting):

Source/WebKit/win:

Update callers of String::createCFString.

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchDidFailToStartPlugin):
* WebDatabaseManager.cpp:
(WebDatabaseManager::dispatchDidModifyDatabase):
* WebHistory.cpp:
(WebHistory::visitedURL):
(WebHistory::itemForURLString):
* WebHistoryItem.cpp:
(WebHistoryItem::dictionaryRepresentation):
* WebIconDatabase.cpp:
(WebIconDatabase::iconDatabaseNotificationUserInfoURLKey):
(postDidAddIconNotification):
* WebLocalizableStrings.cpp:
(createWebKitBundle):
(copyLocalizedStringFromBundle):
* WebPreferences.cpp:
(WebPreferences::initializeDefaultSettings):
* WebView.cpp:
(WebView::setCacheModel):
(WebView::notifyPreferencesChanged):

Source/WebKit2:

Update callers of String::createCFString.

* Platform/mac/ModuleMac.mm:
(WebKit::Module::load):
* PluginProcess/mac/PluginProcessMac.mm:
(WebKit::initializeSandbox):
* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::getPluginInfo):
(WebKit::NetscapePluginModule::createPluginMIMETypesPreferences):
* UIProcess/cf/WebBackForwardListCF.cpp:
(WebKit::WebBackForwardList::createCFDictionaryRepresentation):
* UIProcess/cf/WebPageProxyCF.cpp:
(WebKit::WebPageProxy::sessionStateData):
(WebKit::autosaveKey):
(WebKit::WebPageProxy::saveRecentSearches):
* WebProcess/ResourceCache/WebResourceCacheManager.cpp:
(WebKit::WebResourceCacheManager::clearCacheForOrigin):
* WebProcess/WebPage/win/WebPageWin.cpp:
(WebKit::cachedResponseForURL):
* WebProcess/win/WebProcessWin.cpp:
(WebKit::WebProcess::platformSetCacheModel):
(WebKit::WebProcess::platformInitializeWebProcess):

Source/WTF:

Make String::createCFString and StringImpl::createCFString return RetainPtrs.

* wtf/text/AtomicString.h:
* wtf/text/StringImpl.h:
* wtf/text/WTFString.h:

Tools:

Update callers of String::createCFString.

* WebKitTestRunner/InjectedBundle/mac/InjectedBundlePageMac.mm:
(WTR::InjectedBundlePage::platformDidStartProvisionalLoadForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX: Support embedded SVG objects in AX tree
cfleizach@apple.com [Tue, 30 Oct 2012 16:02:36 +0000 (16:02 +0000)]
AX: Support embedded SVG objects in AX tree
https://bugs.webkit.org/show_bug.cgi?id=97571

Reviewed by Tim Horton.

Source/WebCore:

This patch allows an SVG image from another resource to be hooked into the AX
hierarchy. This is done by creating an AX wrapper for the root SVG that holds onto
its native parent image. The SVGChromeClient is then used to connect to this SVG resource.

Test: accessibility/svg-remote-element.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* accessibility/AXObjectCache.cpp:
(WebCore::createFromRenderer):
* accessibility/AccessibilityAllInOne.cpp:
* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::isAccessibilitySVGRoot):
(AccessibilityObject):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::detach):
(WebCore::AccessibilityRenderObject::offsetBoundingBoxForRemoteSVGElement):
(WebCore::AccessibilityRenderObject::boundingBoxRect):
(WebCore::AccessibilityRenderObject::remoteSVGElementHitTest):
(WebCore::AccessibilityRenderObject::elementAccessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
(WebCore::AccessibilityRenderObject::isSVGImage):
(WebCore::AccessibilityRenderObject::detachRemoteSVGRoot):
(WebCore::AccessibilityRenderObject::remoteSVGRootElement):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
(WebCore::AccessibilityRenderObject::addChildren):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilitySVGRoot.cpp: Added.
(WebCore::AccessibilitySVGRoot::AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::~AccessibilitySVGRoot):
(WebCore::AccessibilitySVGRoot::create):
(WebCore::AccessibilitySVGRoot::parentObject):
* accessibility/AccessibilitySVGRoot.h: Added.
(AccessibilitySVGRoot): Class provides ability to wrap the SVG root of a remote accessibility element.
(WebCore::AccessibilitySVGRoot::setParent):
(WebCore::AccessibilitySVGRoot::isAccessibilitySVGRoot):
(WebCore::toAccessibilitySVGRoot):
* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper position]): The position of AX elements within a remote SVG element needs to be handled
in a special manner.
(createAccessibilityRoleMap):
* loader/EmptyClients.h:
(EmptyChromeClient): Expose isEmptyChromeClient() so Accessibility will know when to apply different policies for finding
the accessibility bounding rect of elements.
(WebCore::EmptyChromeClient::isEmptyChromeClient):
* page/ChromeClient.h:
(WebCore::ChromeClient::isEmptyChromeClient):
(ChromeClient):
* svg/graphics/SVGImage.cpp:
* svg/graphics/SVGImageChromeClient.h: Added.
(SVGImageChromeClient): Expose the SVGImageChromeClient so that Accessibility can reference its image.
(WebCore::SVGImageChromeClient::SVGImageChromeClient):
(WebCore::SVGImageChromeClient::isSVGImageChromeClient):
(WebCore::SVGImageChromeClient::image):
(WebCore::SVGImageChromeClient::chromeDestroyed):
(WebCore::SVGImageChromeClient::invalidateContentsAndRootView):
(WebCore::toSVGImageChromeClient):

LayoutTests:

Added a new test that links in an svg file. Accessibility of that remote svg file is tested.
Test skipped on chromium until clickPoint() is implemented in DRT.

* accessibility/svg-remote-element.html: Added.
* accessibility/resources/svg-face.svg: Added.
* platform/chromium/TestExpectations:
* platform/mac/accessibility/svg-remote-element-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][WTR] WebKitTestRunner needs testRunner.queueLoadHTMLString
commit-queue@webkit.org [Tue, 30 Oct 2012 15:50:52 +0000 (15:50 +0000)]
[WK2][WTR] WebKitTestRunner needs testRunner.queueLoadHTMLString
https://bugs.webkit.org/show_bug.cgi?id=100747

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Tools:

Added testRunner.queueLoadHTMLString implementation.

* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
(WTR::InjectedBundle::queueLoadHTMLString):
(WTR):
* WebKitTestRunner/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::queueLoadHTMLString):
(WTR):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
(TestRunner):
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveMessageFromInjectedBundle):
* WebKitTestRunner/WorkQueueManager.cpp:
(WTR::WorkQueueManager::queueLoadHTMLString):
(WTR):
* WebKitTestRunner/WorkQueueManager.h:
(WorkQueueManager):

LayoutTests:

Unskipped http/tests/navigation/go-back-to-error-page.html for WK2 ports.

* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoadd 7 bit strings capabilities to the v8 binding layer
commit-queue@webkit.org [Tue, 30 Oct 2012 15:47:44 +0000 (15:47 +0000)]
add 7 bit strings capabilities to the v8 binding layer
https://bugs.webkit.org/show_bug.cgi?id=91850

Patch by Dan Carney <dcarney@google.com> on 2012-10-30
Reviewed by Adam Barth.

This change enables the v8 binding layer to make use of webkit's
8 bit string capabilities. Using 8 bit strings leads to certain
benchmark performance improvemnts as can be seen in
https://bug-91850-attachments.webkit.org/attachment.cgi?id=163334.

No new tests. Test coverage already extensive.

* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::visitExternalStrings):
* bindings/v8/V8StringResource.cpp:
(StringTraits):
(WebCore::false):
(WebCore):
(WebCore::true):
(WebCore::v8StringToWebCoreString):
* bindings/v8/V8ValueCache.cpp:
(WebCore::makeExternalString):
(WebCore::WebCoreStringResourceBase::visitStrings):
* bindings/v8/V8ValueCache.h:
(WebCore::WebCoreStringResourceBase::WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::~WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::atomicString):
(WebCoreStringResourceBase):
(WebCore::WebCoreStringResourceBase::memoryConsumption):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r132647)-Enable WebGL in EwkView.
commit-queue@webkit.org [Tue, 30 Oct 2012 15:45:56 +0000 (15:45 +0000)]
Regression(r132647)-Enable WebGL in EwkView.
https://bugs.webkit.org/show_bug.cgi?id=100552.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

WebGL is enabled with following changeset: http://trac.webkit.org/changeset/132627.
Some changes are lost after the following changeset: http://trac.webkit.org/changeset/132647
i.e setWebGLEnabled(true);  in EwkViewImpl.cpp.
This patch re-applies the lost changes.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::EwkViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[AC] Fix compilation warnings when enabling Accelerated Compositing
commit-queue@webkit.org [Tue, 30 Oct 2012 15:45:35 +0000 (15:45 +0000)]
[AC] Fix compilation warnings when enabling Accelerated Compositing
https://bugs.webkit.org/show_bug.cgi?id=100741

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Fix a few compilation warnings when building EFL port
with accelerated compositing enabled.

No new tests, no behavior change.

* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::resolveGLMethods):
(WebCore::GraphicsSurface::platformCopyToGLTexture):
(WebCore::GraphicsSurface::platformLock):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Baseline search path should consider both WK1 and WK2 on layout test.
commit-queue@webkit.org [Tue, 30 Oct 2012 15:40:00 +0000 (15:40 +0000)]
[EFL] Baseline search path should consider both WK1 and WK2 on layout test.
https://bugs.webkit.org/show_bug.cgi?id=100755

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Current implementation doesn't consider WK1 case in baseline search path.
Therefore, this patch fixes it.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflPort.default_baseline_search_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rebaseline fast/sub-pixel/float-wrap-zoom.html.
podivilov@chromium.org [Tue, 30 Oct 2012 15:32:14 +0000 (15:32 +0000)]
Unreviewed, rebaseline fast/sub-pixel/float-wrap-zoom.html.

* platform/chromium-mac-lion/fast/sub-pixel/float-wrap-zoom-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/sub-pixel/float-wrap-zoom-expected.png: Added.
* platform/chromium-mac/fast/sub-pixel/float-wrap-zoom-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed, combine color profile failures to correct bug
commit-queue@webkit.org [Tue, 30 Oct 2012 14:14:01 +0000 (14:14 +0000)]
[EFL] Unreviewed, combine color profile failures to correct bug
https://bugs.webkit.org/show_bug.cgi?id=100746

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-10-30

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Animations jump when the page is suspended
noam.rosenthal@nokia.com [Tue, 30 Oct 2012 14:11:28 +0000 (14:11 +0000)]
[Qt] Animations jump when the page is suspended
https://bugs.webkit.org/show_bug.cgi?id=100673

Reviewed by Kenneth Rohde Christiansen.

GraphicsLayerAnimations::pause() should accept time from start and not an offset.

Source/WebCore:

We need to support the "freeze" API before this can be reliably tested.
See https://bugs.webkit.org/show_bug.cgi?id=100703.

* platform/graphics/GraphicsLayerAnimation.cpp:
(WebCore::GraphicsLayerAnimation::pause):

Source/WebKit2:

* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp:
(WebCore::CoordinatedGraphicsLayer::addAnimation):
(WebCore::CoordinatedGraphicsLayer::pauseAnimation):
(WebCore::CoordinatedGraphicsLayer::animationStartedTimerFired):
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h:
(CoordinatedGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][EFL][AC] While Using WebGL, MiniBrowser segfaults on Refreshing the page.
commit-queue@webkit.org [Tue, 30 Oct 2012 13:43:41 +0000 (13:43 +0000)]
[Qt][EFL][AC] While Using WebGL, MiniBrowser segfaults on Refreshing the page.
https://bugs.webkit.org/show_bug.cgi?id=100639.

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

TextureMapperSurfaceBackingStore can import textures from a GraphicSurface.
In such cases GraphicsSurfaceGLX creates an XPixmap to read texture content
from a given WindowId, but doesn't create any new window.
However, OffScreenRootWindow always tries to unmap window (in its destructor) resulting in segfault.
With this patch OffScreenRootWindow would check for a valid window before trying to unmap it.

* platform/graphics/surfaces/qt/GraphicsSurfaceGLX.cpp:
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Fix EFL build after r132887
commit-queue@webkit.org [Tue, 30 Oct 2012 13:37:52 +0000 (13:37 +0000)]
[EFL][WK2] Fix EFL build after r132887
https://bugs.webkit.org/show_bug.cgi?id=100748

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Fixed EFL build failure with WTF_USE_TILED_BACKING_STORE enabled caused by http://trac.webkit.org/changeset/132887.

* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pixel...
eae@chromium.org [Tue, 30 Oct 2012 13:36:31 +0000 (13:36 +0000)]
[subixel] Change LineWidth::shrinkAvailableWidthForNewFloatIfNeeded to not pixel snap
https://bugs.webkit.org/show_bug.cgi?id=100742

Reviewed by Levi Weintraub.

Source/WebCore:

As we no longer pixel snap values when computing the current width for a
line we should not do it in shrinkAvailableWidthForNewFloatIfNeeded
either.

Test: fast/sub-pixel/float-wrap-zoom.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::LineWidth::LineWidth): Remove unnecessary ifdef.
(WebCore::LineWidth::shrinkAvailableWidthForNewFloatIfNeeded): Use float values instead of pixel snapped/floored values as the line width calculations uses floats.

LayoutTests:

Add test for wrapping when combining float and inline elements.

* fast/sub-pixel/float-wrap-zoom-expected.html: Added.
* fast/sub-pixel/float-wrap-zoom.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Reject vertex shaders with custom attributes
commit-queue@webkit.org [Tue, 30 Oct 2012 13:21:21 +0000 (13:21 +0000)]
[CSS Shaders] Reject vertex shaders with custom attributes
https://bugs.webkit.org/show_bug.cgi?id=98973

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-10-30
Reviewed by Dean Jackson.

Source/WebCore:

Improved CSS Custom Filters shader validation. With this patch:
(1) Shaders with custom attributes do not execute (e.g. attribute float my_attribute;).
(2) Shaders with a_triangleCoord defined do not execute with an attached mesh.

Most of the changes are from renaming CustomFilterOperation::MeshType to
CustomFilterMeshType, and moving the enumeration to CustomFilterConstants.h. This avoids
pulling in CustomFilterOperation for classes that only care about the mesh type.

Note that in CSS Custom Filters, the a_triangleCoord attribute is only available in detached
meshes. In detached meshes, no vertices are shared between triangles. Thus, each vertex
belongs to a specific triangle, which a_triangleCoord identifies. In attached meshes,
vertices can belong to many triangles, which a_triangleCoord cannot identify because it's
only a vec3.

Tests:
Add two new checks to the test file:
    css3/filters/custom/invalid-custom-filter-attribute-types.html
Add two new shaders:
    css3/filters/resources/invalid-custom-attribute.vs
    css3/filters/resources/invalid-a-triangle-coord-with-attached-mesh.vs

* WebCore.xcodeproj/project.pbxproj:
    Update a broken reference to CustomFilterConstants.h in the Xcode project file.
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter):
    Replace CustomFilterOperation::MeshType with CustomFilterMeshType.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperation): Ditto.
* platform/graphics/filters/CustomFilterConstants.h:
    Add CustomFilterMeshType enum to share across the Custom Filters codebase, so that we
    don't have to include CustomFilterOperation just to access the old
    CustomFilterOperation::MeshType enum.
* platform/graphics/filters/CustomFilterMesh.cpp:
(WebCore::CustomFilterMesh::CustomFilterMesh):
    Replace CustomFilterOperation::MeshType with CustomFilterMeshType.
* platform/graphics/filters/CustomFilterMesh.h:
(WebCore::CustomFilterMesh::create): Ditto.
(WebCore::CustomFilterMesh::meshType): Ditto.
(CustomFilterMesh): Ditto.
* platform/graphics/filters/CustomFilterMeshGenerator.cpp: Ditto.
(WebCore::CustomFilterMeshGenerator::CustomFilterMeshGenerator): Ditto.
(WebCore::CustomFilterMeshGenerator::dumpBuffers): Ditto.
* platform/graphics/filters/CustomFilterMeshGenerator.h:
(CustomFilterMeshGenerator): Ditto.
(WebCore::CustomFilterMeshGenerator::floatsPerVertex): Ditto.
(WebCore::CustomFilterMeshGenerator::verticesCount): Ditto.
* platform/graphics/filters/CustomFilterOperation.cpp:
(WebCore::CustomFilterOperation::CustomFilterOperation): Ditto.
* platform/graphics/filters/CustomFilterOperation.h:
(WebCore::CustomFilterOperation::create): Ditto.
(WebCore::CustomFilterOperation::meshType): Ditto.
(CustomFilterOperation): Ditto.
* platform/graphics/filters/CustomFilterProgram.cpp:
(WebCore::CustomFilterProgram::CustomFilterProgram):
    Add a meshType constructor parameter because the program now needs to know the meshType
    to properly validate.
(WebCore::CustomFilterProgram::programInfo):
    Pass meshType to CustomFilterProgram constructor.
(WebCore::CustomFilterProgram::operator==):
    Check the meshType in the equals operator.
* platform/graphics/filters/CustomFilterProgram.h:
    Make vertexShaderString() and fragmentShaderString() public so that we don't have to ask
    for a programInfo object just to get the shader strings in
    CoordinatedGraphicsArgumentCoders.cpp.
* platform/graphics/filters/CustomFilterProgramInfo.cpp:
(WebCore::CustomFilterProgramInfo::CustomFilterProgramInfo):
    Add a meshType constructor parameter.
(WebCore::CustomFilterProgramInfo::hash):
    Include the meshType in the validated program hash, since the same shader code can pass
    or fail validation based on the meshType.
(WebCore::CustomFilterProgramInfo::operator==):
    Check the meshType in the equals operator.
* platform/graphics/filters/CustomFilterProgramInfo.h:
(CustomFilterProgramInfo):
    Update method prototype.
(WebCore::CustomFilterProgramInfo::meshType):
    Add meshType getter.
* platform/graphics/filters/CustomFilterValidatedProgram.cpp:
(WebCore::CustomFilterValidatedProgram::validateSymbols):
    If the author defines attribute that is is not found in the built-in attribute map,
    reject the shader.
    If the author defines a_triangleCoord without a detached mesh type, reject the shader.
    Also, make this previously file-static function into a method of
    CustomFilterValidatedProgram because it now needs to access the m_meshType.
* platform/graphics/filters/CustomFilterValidatedProgram.h:
(CustomFilterValidatedProgram):
    Add a meshType constructor parameter because the program now needs to know the meshType
    to properly validate.
* platform/graphics/filters/FECustomFilter.cpp:
(WebCore::FECustomFilter::FECustomFilter):
    Replace CustomFilterOperation::MeshType with CustomFilterMeshType.
(WebCore::FECustomFilter::create): Ditto.
(WebCore::FECustomFilter::bindProgramAndBuffers): Ditto.
(WebCore::FECustomFilter::unbindVertexAttributes): Ditto.
* platform/graphics/filters/FECustomFilter.h:
(FECustomFilter): Ditto.
* rendering/style/StyleCustomFilterProgram.h:
(WebCore::StyleCustomFilterProgram::create):
    Add a meshType constructor parameter.
(WebCore::StyleCustomFilterProgram::StyleCustomFilterProgram): Ditto.

Source/WebKit2:

Replace CustomFilterOperation::MeshType with CustomFilterMeshType from
CustomFilterConstants.h.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
(CoreIPC::::encode):
    Read the shader strings directly from the CustomFilterProgram instead of asking for a
    CustomFilterProgramInfo object. Also, encode the meshType earlier so that decoding can
    can use it to create a WebCustomFilterProgram, which now requires a meshType.
(CoreIPC::::decode):
    Decode the meshType earlier to pass it to the new WebCustomFilterProgram constructor.
* Shared/CoordinatedGraphics/WebCustomFilterProgram.h:
(WebKit::WebCustomFilterProgram::create):
    Add a meshType parameter to pass to the base class constructor.
(WebKit::WebCustomFilterProgram::WebCustomFilterProgram): Ditto.

LayoutTests:

Add checks to verify:
(1) Shaders with custom attributes do not execute (e.g. attribute float my_attribute;).
(2) Shaders with a_triangleCoord defined do not execute with an attached mesh.

Note that in CSS Custom Filters, the a_triangleCoord attribute is only available in detached
meshes. In detached meshes, no vertices are shared between triangles. Thus, each vertex
belongs to a specific triangle, which a_triangleCoord identifies. In attached meshes,
vertices can belong to many triangles, which a_triangleCoord cannot identify because it's
only a vec3.

CSS Filters Spec, Vertex Attributes:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/filters/index.html#vertex-attribute-variables

* css3/filters/custom/invalid-custom-filter-attribute-types-expected.html:
* css3/filters/custom/invalid-custom-filter-attribute-types.html:
    Add two checks for two new vertex shaders. Update the a_triangleCoord type check to use
    a detached mesh, so the vertex shader fails to validate because a_triangleCoord is
    defined with an incorrect type, not because it defines a_triangleCoord in an attached
    mesh.
* css3/filters/resources/invalid-a-triangle-coord-with-attached-mesh.vs:
    Added. This vertex shader defines a_triangleCoord with the correct type. However, this
    shader is run with an an attached mesh, so it should not execute.
* css3/filters/resources/invalid-custom-attribute.vs:
    Added. This vertex shader defines a custom attribute. The associated test verifies
    that it does not execute.
* css3/filters/resources/invalid-type-a-mesh-coord.vs:
    Remove some empty lines to improve readability.
* css3/filters/resources/invalid-type-a-position.vs: Ditto.
* css3/filters/resources/invalid-type-a-tex-coord.vs: Ditto.
* css3/filters/resources/invalid-type-a-triangle-coord.vs:
    Add a comment that this shader should be run with a detached mesh.
* css3/filters/resources/invalid-type-attribute-array.vs:
    Remove some empty lines to improve readability.
* css3/filters/resources/invalid-type-a-triangle-coord.vs: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: adds isOwnProperty to remote protocol
commit-queue@webkit.org [Tue, 30 Oct 2012 13:13:19 +0000 (13:13 +0000)]
Web Inspector: adds isOwnProperty to remote protocol
https://bugs.webkit.org/show_bug.cgi?id=100664

Patch by Andrey Lushnikov <lushnikov@google.com> on 2012-10-30
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector/runtime/runtime-getProperties-isOwnProperty.html

Adds requested 'isOwn' property to the 'PropertyDescriptor' class of the
remote debugging protocol.

* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:

LayoutTests:

* inspector/runtime/runtime-getProperties-isOwnProperty-expected.txt: Added.
* inspector/runtime/runtime-getProperties-isOwnProperty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, add baselines for exif-orientation-image-document.
podivilov@chromium.org [Tue, 30 Oct 2012 12:37:32 +0000 (12:37 +0000)]
Unreviewed, add baselines for exif-orientation-image-document.

* platform/chromium-linux/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.
* platform/chromium-mac-lion/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.
* platform/chromium-win/platform/chromium/virtual/deferred/fast/images/exif-orientation-image-document-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[QT][DRT] Remove unneeded testRunner.setMediaType() implementation
commit-queue@webkit.org [Tue, 30 Oct 2012 12:35:35 +0000 (12:35 +0000)]
[QT][DRT] Remove unneeded testRunner.setMediaType() implementation
https://bugs.webkit.org/show_bug.cgi?id=100740

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Removed unneeded testRunner.setMediaType() implementation, as tests use
cross-platform window.internals.settings.setMediaTypeOverride instead.

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Tools:

* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnrewieved, rebaseline audiobuffersource-loop-points.
podivilov@chromium.org [Tue, 30 Oct 2012 12:34:29 +0000 (12:34 +0000)]
Unrewieved, rebaseline audiobuffersource-loop-points.

* platform/chromium-linux/webaudio/audiobuffersource-loop-points-expected.wav: Renamed from LayoutTests/platform/chromium-win-xp/webaudio/audiobuffersource-loop-points-expected.wav.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Remove ViewportUpdateDeferrer from PageViewportController
abecsi@webkit.org [Tue, 30 Oct 2012 12:32:15 +0000 (12:32 +0000)]
[Qt][WK2] Remove ViewportUpdateDeferrer from PageViewportController
https://bugs.webkit.org/show_bug.cgi?id=100665

Reviewed by Jocelyn Turcotte.

Since the original use case of delayed viewport updates and the issue
of infinite loop conditions between the programmatic adjustmet of the
viewport and the Qt notification signals are not present any more the
ViewportUpdateDeferrer became an unnecessary legacy and can be removed.

* UIProcess/PageViewportController.cpp:
(WebKit::PageViewportController::PageViewportController):
(WebKit::PageViewportController::pageDidRequestScroll):
* UIProcess/PageViewportController.h:
(WebKit):
(PageViewportController):
* UIProcess/qt/PageViewportControllerClientQt.cpp:
(WebKit::PageViewportControllerClientQt::PageViewportControllerClientQt):
(WebKit::PageViewportControllerClientQt::animateContentRectVisible):
(WebKit::PageViewportControllerClientQt::flickMoveStarted):
(WebKit::PageViewportControllerClientQt::flickMoveEnded):
(WebKit::PageViewportControllerClientQt::scaleAnimationStateChanged):
(WebKit::PageViewportControllerClientQt::touchBegin):
(WebKit::PageViewportControllerClientQt::touchEnd):
(WebKit::PageViewportControllerClientQt::setContentsRectToNearestValidBounds):
(WebKit::PageViewportControllerClientQt::pinchGestureStarted):
(WebKit::PageViewportControllerClientQt::pinchGestureEnded):
(WebKit::PageViewportControllerClientQt::pinchGestureCancelled):
* UIProcess/qt/PageViewportControllerClientQt.h:
(PageViewportControllerClientQt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] BitmapTextureGL::updateContents() broken after r132019.
zeno.albisser@digia.com [Tue, 30 Oct 2012 12:23:15 +0000 (12:23 +0000)]
[Qt][Win] BitmapTextureGL::updateContents() broken after r132019.
https://bugs.webkit.org/show_bug.cgi?id=100680

When creating a temporary for swizzling the image data,
the temporary will have the target size.
Therefore no offset within the available image data
shall be applied in this case.

Reviewed by Noam Rosenthal.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unused code for old input[type=date] UI
tkent@chromium.org [Tue, 30 Oct 2012 12:10:07 +0000 (12:10 +0000)]
Remove unused code for old input[type=date] UI
https://bugs.webkit.org/show_bug.cgi?id=100734

Reviewed by Hajime Morita.

Source/WebCore:

The old input[type=date] UI used in Google Chrome 20-23 (text field with
a fixed placeholder) was replaced with ENABLE_INPUT_MULTIPLE_FIELDS_UI.

No new tests because of no behavior changes.

* html/DateInputType.cpp: Remove ENABLE_INPUT_TYPE_DATE_LEGACY_UI code path.
* html/DateInputType.h: Ditto.

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::supportsPlaceholder):
Remove fixed-placeholder feature.
* html/HTMLInputElement.h:
(HTMLInputElement): Ditto.
* html/HTMLTextFormControlElement.h:
(HTMLTextFormControlElement): isPlaceholderEmpty() is not needed to be virtual
* html/InputType.cpp: Remove fixed-placeholder feature.
* html/InputType.h: Ditto.
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::updatePlaceholderText): Ditto.

* platform/text/PlatformLocale.h:
(Locale): Remove dateFormatText.
* platform/text/LocaleICU.cpp: Ditto.
* platform/text/LocaleICU.h: Ditto.
* platform/text/LocaleNone.cpp: Ditto.
* platform/text/mac/LocaleMac.h: Ditto.
* platform/text/mac/LocaleMac.mm: Ditto.
* platform/text/win/LocaleWin.cpp: Ditto.
* platform/text/win/LocaleWin.h: Ditto.
* platform/LocalizedStrings.h:
(WebCore): Remove unused functions; calendarTodayText,
calendarClearText, dateFormatYearText, dateFormatMonthText,
dateFormatDayInMonthText

Source/WebKit/chromium:

* src/LocalizedStrings.cpp:
Follow the LocalizedStrings.h change.
* tests/LocaleMacTest.cpp:
(LocaleMacTest): Remove tests for Locale::dateFormatText.
* tests/LocaleWinTest.cpp:
(LocaleWinTest): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix crash by calendar picker or suggestion picker
tkent@chromium.org [Tue, 30 Oct 2012 12:07:38 +0000 (12:07 +0000)]
Fix crash by calendar picker or suggestion picker
https://bugs.webkit.org/show_bug.cgi?id=100728

Reviewed by Hajime Morita.

Source/WebCore:

Change DateTimeChooser so that it is ref-coutned.

Test: platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onchange.html

* platform/DateTimeChooser.h: Made DateTimeChooser RefCounted.
* page/ChromeClient.h:
(ChromeClient): openDateTimeChooser should return PassRefPtr<DateTimeChooser>.
* loader/EmptyClients.h:
(EmptyChromeClient): Follow the above change.
* loader/EmptyClients.cpp:
(WebCore::EmptyChromeClient::openDateTimeChooser): Ditto.

* html/shadow/PickerIndicatorElement.h:
(PickerIndicatorElement): Hold DateTimeChooser in RefPtr<DateTimeChooser>.
* html/shadow/PickerIndicatorElement.cpp:
(WebCore::PickerIndicatorElement::PickerIndicatorElement):
Remove unnecessary initialization.

Source/WebKit/chromium:

* src/DateTimeChooserImpl.h:
(DateTimeChooserImpl): Add a factory function, and made the constructor private.
* src/DateTimeChooserImpl.cpp:
(WebKit::DateTimeChooserImpl::create): Added.
(WebKit::DateTimeChooserImpl::setValueAndClosePopup):
Protect this because JavaScript code might run during didChooseValue.

* src/ChromeClientImpl.h:
(ChromeClientImpl): Follow the ChromeClient change.
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::openDateTimeChooser):
Use DateTimeChooserImpl::create.

LayoutTests:

* platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onchange-expected.txt: Added.
* platform/chromium/fast/forms/calendar-picker/calendar-picker-type-change-onchange.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Timeline: promote "cpu activity" out of experiment
commit-queue@webkit.org [Tue, 30 Oct 2012 12:01:48 +0000 (12:01 +0000)]
Web Inspector: Timeline: promote "cpu activity" out of experiment
https://bugs.webkit.org/show_bug.cgi?id=100726

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-10-30
Reviewed by Pavel Feldman.

1. CPU actibity bars redesigned
2. Experiment setting removed
3. Feature setting added

* English.lproj/localizedStrings.js: Updated setting label.
* inspector/front-end/Settings.js: Replaced experiment with setting.
* inspector/front-end/SettingsScreen.js: Added new setting.
* inspector/front-end/TimelinePanel.js: Update cpu bars appearance.
* inspector/front-end/timelinePanel.css: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix WTF to not install a few header files in bogus locations.
mrowe@apple.com [Tue, 30 Oct 2012 11:36:51 +0000 (11:36 +0000)]
Fix WTF to not install a few header files in bogus locations.

* WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Change the default compositing mode and the default CSS value for ...
michelangelo@webkit.org [Tue, 30 Oct 2012 11:23:52 +0000 (11:23 +0000)]
[CSS Shaders] Change the default compositing mode and the default CSS value for <fragmentShader>
https://bugs.webkit.org/show_bug.cgi?id=94020

Reviewed by Dean Jackson.

Source/WebCore:

The default compositing mode has been changed from "normal source-over" to
"normal source-atop". This applies to the default fragment shader that will
kick in when there is no explicit fragment shader or mix function defined.

This has required to update all the existing tests; the dummy empty fragment
shader has also been removed because not needed.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::valueForFilter): An existence check
for the fragment shader has been added.
* css/StyleResolver.cpp:
(WebCore::StyleResolver::createCustomFilterOperation): The default program
has been updated: PROGRAM_TYPE_BLENDS_TEXTURE (compositing enabled) now is
the default.
* platform/graphics/filters/CustomFilterProgramInfo.h:
(WebCore::CustomFilterProgramMixSettings::CustomFilterProgramMixSettings):
New CustomFilterProgramMixSettings defaults to "source-atop" composite
operator.

LayoutTests:

Existing tests have been modified to update them to the new default
compositing values (normal source-atop).

Also, the dummy empty shader has been removed: not needed.

* css3/filters/custom/custom-filter-property-computed-style-expected.txt:
* css3/filters/custom/custom-filter-shader-cache.html:
* css3/filters/custom/effect-custom-transform-parameters.html:
* css3/filters/custom/effect-custom.html:
* css3/filters/custom/filter-fallback-to-software.html:
* css3/filters/resources/empty-shader.fs: Removed.
* css3/filters/script-tests/custom-filter-property-computed-style.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Mac] Unreviewed build fix.
ossy@webkit.org [Tue, 30 Oct 2012 11:04:54 +0000 (11:04 +0000)]
[Qt][Mac] Unreviewed build fix.
https://bugs.webkit.org/show_bug.cgi?id=100727.

Speculative build fix after 132858. Include missing CoreFoundation/CoreFoundation.h header.

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-10-30

* platform/text/cf/AtomicStringCF.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOptimize vclip for NEON in VectorMath
rgabor@webkit.org [Tue, 30 Oct 2012 10:50:42 +0000 (10:50 +0000)]
Optimize vclip for NEON in VectorMath
https://bugs.webkit.org/show_bug.cgi?id=100737

Reviewed by Zoltan Herczeg.

Speed up vclip in VectorMath with NEON intrinsics.

* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vclip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Software and composited filters should have a common path
achicu@adobe.com [Tue, 30 Oct 2012 10:33:11 +0000 (10:33 +0000)]
[CSS Shaders] Software and composited filters should have a common path
https://bugs.webkit.org/show_bug.cgi?id=100532

Reviewed by Dean Jackson.

Added computeFilterOperations as a common method between the software filters
and hardware composited ones. The method rejects custom filters that are not
loaded yet. In bug 100533 it will also convert the CustomFilterOperation to a
ValidatedCustomFilterOperation. That will help us keep the loading and verification
code for the custom filters common across all the ports.

No new tests, just refactoring existing code.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::computeFilterOperations):
(WebCore):
(WebCore::RenderLayer::updateOrRemoveFilterEffect):
* rendering/RenderLayer.h:
(WebCore):
(RenderLayer):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateFilters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Implement native memory snapshot grid view
commit-queue@webkit.org [Tue, 30 Oct 2012 10:31:17 +0000 (10:31 +0000)]
Web Inspector: Implement native memory snapshot grid view
https://bugs.webkit.org/show_bug.cgi?id=100656

Native memory snapshots are now shown as an expandable tree form
using the grid control.

Patch by Alexei Filippov <alph@chromium.org> on 2012-10-30
Reviewed by Yury Semikhatsky.

* inspector/front-end/NativeMemorySnapshotView.js:
(WebInspector.NativeMemorySnapshotView):
(WebInspector.NativeSnapshotDataGrid):
(WebInspector.NativeSnapshotNode):
(WebInspector.NativeSnapshotNode.prototype.createCell):
(WebInspector.NativeSnapshotNode.prototype._createSizeCell):
(WebInspector.NativeSnapshotNode.prototype._populate):
(WebInspector.MemoryBlockViewProperties._initialize):
(WebInspector.MemoryBlockViewProperties._forMemoryBlock):
* inspector/front-end/dataGrid.css:
(.data-grid td):
* inspector/front-end/nativeMemoryProfiler.css:
(.memory-bar-chart-bar):
(.native-snapshot-view):
(.native-snapshot-view.visible):
(.native-snapshot-view .data-grid):
(.native-snapshot-view .data-grid table):
(.native-snapshot-view .data-grid div.size-text):
(.native-snapshot-view .data-grid div.size-bar):
(.native-snapshot-view .data-grid div.percent-text):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Simplify signal emitting API in EwkViewImpl
rakuco@webkit.org [Tue, 30 Oct 2012 09:58:56 +0000 (09:58 +0000)]
[EFL][WK2] Simplify signal emitting API in EwkViewImpl
https://bugs.webkit.org/show_bug.cgi?id=100506

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Now signal emitting API in EwkViewImpl is simplified so that
there is one EwkViewImpl::smartCallback template method
returning EwkViewCallbacks::CallBack class instance
which encapsulates Ewk_view callback info and also provide
arguments type checking.

* UIProcess/API/efl/EwkViewCallbacks.h: Added.
(EwkViewCallbacks):
(CallBackInfo):
(EwkViewCallbacks::CallBackInfo::name):
(EwkViewCallbacks::CallBackInfo::hasArguments):
(CallBack):
(EwkViewCallbacks::CallBack::CallBack):
(EwkViewCallbacks::CallBack::call):
* UIProcess/API/efl/EwkViewImpl.cpp:
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):
(EwkViewImpl::smartCallback):
* UIProcess/efl/DownloadManagerEfl.cpp:
(WebKit::DownloadManagerEfl::decideDestinationWithSuggestedFilename):
(WebKit::DownloadManagerEfl::didFail):
(WebKit::DownloadManagerEfl::didCancel):
(WebKit::DownloadManagerEfl::didFinish):
* UIProcess/efl/FindClientEfl.cpp:
(WebKit::FindClientEfl::didFindString):
(WebKit::FindClientEfl::didFailToFindString):
* UIProcess/efl/FormClientEfl.cpp:
(WebKit::FormClientEfl::willSubmitForm):
* UIProcess/efl/PageClientImpl.cpp:
(WebKit::PageClientImpl::processDidCrash):
(WebKit::PageClientImpl::toolTipChanged):
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveTitleForFrame):
(WebKit::PageLoadClientEfl::didReceiveIntentForFrame):
(WebKit::PageLoadClientEfl::registerIntentServiceForFrame):
(WebKit::PageLoadClientEfl::didChangeProgress):
(WebKit::PageLoadClientEfl::didFinishLoadForFrame):
(WebKit::PageLoadClientEfl::didFailLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didStartProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didReceiveServerRedirectForProvisionalLoadForFrame):
(WebKit::PageLoadClientEfl::didFailProvisionalLoadWithErrorForFrame):
(WebKit::PageLoadClientEfl::didCommitLoadForFrame):
(WebKit::PageLoadClientEfl::didChangeBackForwardList):
* UIProcess/efl/PagePolicyClientEfl.cpp:
(WebKit::PagePolicyClientEfl::decidePolicyForNavigationAction):
(WebKit::PagePolicyClientEfl::decidePolicyForNewWindowAction):
* UIProcess/efl/ResourceLoadClientEfl.cpp:
(WebKit::ResourceLoadClientEfl::didInitiateLoadForResource):
(WebKit::ResourceLoadClientEfl::didSendRequestForResource):
(WebKit::ResourceLoadClientEfl::didReceiveResponseForResource):
(WebKit::ResourceLoadClientEfl::didFinishLoadForResource):
(WebKit::ResourceLoadClientEfl::didFailLoadForResource):
(WebKit::ResourceLoadClientEfl::ResourceLoadClientEfl):
(WebKit::ResourceLoadClientEfl::~ResourceLoadClientEfl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago3d rotation with [0, 0, 0] direction vector should not be applied
commit-queue@webkit.org [Tue, 30 Oct 2012 09:43:46 +0000 (09:43 +0000)]
3d rotation with [0, 0, 0] direction vector should not be applied
https://bugs.webkit.org/show_bug.cgi?id=100733

Patch by Zoltan Nyul <zoltan.nyul@intel.com> on 2012-10-30
Reviewed by Levi Weintraub.

Source/WebCore:

As stated in the specification (http://dev.w3.org/csswg/css3-3d-transforms/#transform-functions),
a direction vector that cannot be normalized, such as [0, 0, 0], will cause the rotation to not be applied,
but webkit applies it with [1, 0, 0] direction vector.

Test: transforms/3d/general/3dtransform-values.html

* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::rotate3d):

LayoutTests:

Add test for 3d rotation with [0, 0, 0] direction vector.

* transforms/3d/general/3dtransform-values-expected.txt:
* transforms/3d/general/3dtransform-values.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Bitmap should show whole view area.
commit-queue@webkit.org [Tue, 30 Oct 2012 09:40:06 +0000 (09:40 +0000)]
[EFL][DRT] Bitmap should show whole view area.
https://bugs.webkit.org/show_bug.cgi?id=100642

Patch by Kangil Han <kangil.han@samsung.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Tools:

css sticky position test cases haven't been passed even though implementation has been landed by BUG 95182.
This is because current create bitmap implementation refers to geometry position that considers scroll movement even though
paint does it. Therefore, this patch always reflects current view size and remove duplicated graphic operation to dump correct bitmap image.

* DumpRenderTree/efl/PixelDumpSupportEfl.cpp:
(createBitmapContextFromWebView):

LayoutTests:

Unskip css sticky position as well as scroll and fixed position related test cases.

* platform/efl-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMemory instrumentation: report actual object address for CachedResourceClients
yurys@chromium.org [Tue, 30 Oct 2012 09:15:33 +0000 (09:15 +0000)]
Memory instrumentation: report actual object address for CachedResourceClients
https://bugs.webkit.org/show_bug.cgi?id=100659

Reviewed by Alexander Pavlov.

Skipped pointers to objects that are not allocated on the heap directly.

To test this we need to compare addresses of objects traversed by the memory
insrumentation with those allocated by the memory allocator. The latter set
should include the former one.

* css/StyleResolver.cpp:
(WTF): skip pointers to RuleData structures as they are stored by value in RuleSet
objects and should not be reported separately.
* loader/cache/CachedResource.cpp:
(WTF): do not report memory occupied by CachedResourceClients as objects implementing
the interface may have address which differ from CachedResourceClient*. The clients
should be reachable from their instrumented owners where we know exact type of the
clients and hence can figure correct address.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Unrelease adopted images
jocelyn.turcotte@digia.com [Tue, 30 Oct 2012 09:15:27 +0000 (09:15 +0000)]
Coordinated Graphics: Unrelease adopted images
https://bugs.webkit.org/show_bug.cgi?id=100671

Reviewed by Kenneth Rohde Christiansen.

Reloading could cause a crash since r132640 where the directly composited
image would be re-adopted with the same key before it was properly released
in the UI process.
Cancel the release when this happens rather than creating a new image.

* WebProcess/WebPage/CoordinatedGraphics/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::adoptImageBackingStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Unskip sputnik flaky tests.
commit-queue@webkit.org [Tue, 30 Oct 2012 09:07:51 +0000 (09:07 +0000)]
[EFL][WK2] Unskip sputnik flaky tests.
https://bugs.webkit.org/show_bug.cgi?id=100732

Unreviewed, EFL gardening.

These tests are always passing now.

sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A5.html
sputnik/Conformance/07_Lexical_Conventions/7.4_Comments/S7.4_A6.html
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.1_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A1.4_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.1_T2.html
sputnik/Conformance/07_Lexical_Conventions/7.8_Literals/7.8.5_Regular_Expression_Literals/S7.8.5_A2.4_T2.html

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-30

* platform/efl-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Refactor tooltip callback signal in WebKit1
commit-queue@webkit.org [Tue, 30 Oct 2012 09:00:05 +0000 (09:00 +0000)]
[EFL] Refactor tooltip callback signal in WebKit1
https://bugs.webkit.org/show_bug.cgi?id=100571

Patch by Jinwoo Song <jinwoo7.song@samsung.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Separate tooltip callback signal into 'tooltip,text,set'
and 'tooltip,text,unset' to be consistent with WebKit2.

Source/WebKit/efl:

* ewk/ewk_view.cpp:
(ewk_view_tooltip_text_set):
* ewk/ewk_view.h:

Tools:

* EWebLauncher/main.c:
(on_tooltip_text_set):
(on_tooltip_text_unset):
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Let Ecore_Evas own the cursor object
commit-queue@webkit.org [Tue, 30 Oct 2012 08:54:31 +0000 (08:54 +0000)]
[EFL][WK2] Let Ecore_Evas own the cursor object
https://bugs.webkit.org/show_bug.cgi?id=100731

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Ecore_Evas takes care of calling evas_object_del() on
the cursor object when it is no longer used (e.g. when
it is replaced by another cursor object). Therefore,
we don't need to keep a RefPtr to the cursor Evas
Object as a data member of EwkViewImpl. We pass
ownership of the cursor object to Ecore_Evas.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::setCursor):
* UIProcess/API/efl/EwkViewImpl.h:
(EwkViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Simplify getting impl from ewk_view evas object instance
commit-queue@webkit.org [Tue, 30 Oct 2012 08:43:01 +0000 (08:43 +0000)]
[EFL][WK2] Simplify getting impl from ewk_view evas object instance
https://bugs.webkit.org/show_bug.cgi?id=100505

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-10-30
Reviewed by Kenneth Rohde Christiansen.

Macros are removed from EwkViewImpl.h. New macro added to EwkViewImpl.cpp
so that it's possible to get impl directly from ewk view.

* UIProcess/API/efl/EwkViewImpl.cpp:
(EwkViewImpl::displayTimerFired):
* UIProcess/API/efl/EwkViewImpl.h:
* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_in):
(_ewk_view_smart_focus_out):
(mapToWebContent):
(_ewk_view_smart_mouse_wheel):
(_ewk_view_smart_mouse_down):
(_ewk_view_smart_mouse_up):
(_ewk_view_smart_mouse_move):
(_ewk_view_smart_key_down):
(_ewk_view_smart_key_up):
(_ewk_view_on_show):
(_ewk_view_on_hide):
(_ewk_view_smart_calculate):
(_ewk_view_smart_color_set):
(ewk_view_context_get):
(ewk_view_url_set):
(ewk_view_url_get):
(ewk_view_icon_url_get):
(ewk_view_reload):
(ewk_view_reload_bypass_cache):
(ewk_view_stop):
(ewk_view_settings_get):
(ewk_view_title_get):
(ewk_view_load_progress_get):
(ewk_view_scale_set):
(ewk_view_scale_get):
(ewk_view_device_pixel_ratio_set):
(ewk_view_device_pixel_ratio_get):
(ewk_view_theme_set):
(ewk_view_theme_get):
(ewk_view_back):
(ewk_view_forward):
(ewk_view_intent_deliver):
(ewk_view_back_possible):
(ewk_view_forward_possible):
(ewk_view_back_forward_list_get):
(ewk_view_html_string_load):
(ewk_view_setting_encoding_custom_get):
(ewk_view_setting_encoding_custom_set):
(ewk_view_text_find):
(ewk_view_text_find_highlight_clear):
(ewk_view_text_matches_count):
(ewk_view_mouse_events_enabled_set):
(ewk_view_mouse_events_enabled_get):
(ewk_view_feed_touch_event):
(ewk_view_touch_events_enabled_set):
(ewk_view_touch_events_enabled_get):
(ewk_view_inspector_show):
(ewk_view_inspector_close):
(ewk_view_pagination_mode_set):
(ewk_view_pagination_mode_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd files generated by Windows to ignore list for git repository
commit-queue@webkit.org [Tue, 30 Oct 2012 08:33:44 +0000 (08:33 +0000)]
Add files generated by Windows to ignore list for git repository
https://bugs.webkit.org/show_bug.cgi?id=100729

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Adding the additional files generated by windows port to the ignore list

* .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a test for reading exif orientation off image documents
thakis@chromium.org [Tue, 30 Oct 2012 08:02:35 +0000 (08:02 +0000)]
Add a test for reading exif orientation off image documents
https://bugs.webkit.org/show_bug.cgi?id=100698

Reviewed by Eric Seidel.

fast/images/exif-orientation.html tests <img> elements, but image documents were untested previously.

* fast/images/exif-orientation-image-document.html: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/images/exif-orientation-image-document-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add a configure option to build with -g1
carlosgc@webkit.org [Tue, 30 Oct 2012 07:47:25 +0000 (07:47 +0000)]
[GTK] Add a configure option to build with -g1
https://bugs.webkit.org/show_bug.cgi?id=100670

Reviewed by Martin Robinson.

Add min and full options to the --enable-debug-symbols configure
option. Using --enable-debug-symbols=min will use -g1 instead of
-g (which is actually -g2). The first level is enough for most of
the cases, like getting a backtrace, and it's the only way to
build WebKit with debug symbols in a 32 bit system. The option
full is actually the same than yes for backwards compatibility.

* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Remove incorrect use of preprocessor macro in API headers.
commit-queue@webkit.org [Tue, 30 Oct 2012 07:36:10 +0000 (07:36 +0000)]
[WK2] Remove incorrect use of preprocessor macro in API headers.
https://bugs.webkit.org/show_bug.cgi?id=100722

Patch by Byungwoo Lee <bw80.lee@samsung.com> on 2012-10-30
Reviewed by Gyuyoung Kim.

Remove the preprocessor macro ENABLE(INSPECTOR) from the WKAPICast.h
and WKInspector.h.

* UIProcess/API/C/WKAPICast.h:
(WebKit):
* UIProcess/API/C/WKInspector.cpp:
(WKInspectorGetTypeID):
(WKInspectorGetPage):
(WKInspectorIsVisible):
(WKInspectorIsFront):
(WKInspectorShow):
(WKInspectorClose):
(WKInspectorShowConsole):
(WKInspectorShowResources):
(WKInspectorShowMainResourceForFrame):
(WKInspectorIsAttached):
(WKInspectorAttach):
(WKInspectorDetach):
(WKInspectorIsDebuggingJavaScript):
(WKInspectorToggleJavaScriptDebugging):
(WKInspectorIsProfilingJavaScript):
(WKInspectorToggleJavaScriptProfiling):
(WKInspectorIsProfilingPage):
(WKInspectorTogglePageProfiling):
* UIProcess/API/C/WKInspector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refatoring] Remove ElementShadow::insertionPointFor
shinyak@chromium.org [Tue, 30 Oct 2012 07:00:26 +0000 (07:00 +0000)]
[Refatoring] Remove ElementShadow::insertionPointFor
https://bugs.webkit.org/show_bug.cgi?id=100625

Reviewed by Hajime Morita.

Now that ElementShadow::insertionPointFor does not do any special things, and it's only used in
ComposedShadowTreeWalker. So we can remove it.

No new tests, simple refactoring.

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::resolveReprojection):
(WebCore::AncestorChainWalker::parent):
* dom/ElementShadow.cpp:
* dom/ElementShadow.h:
(ElementShadow):
* dom/ShadowRoot.h: ShadowRoot has insertionPointFor declaration, but we don't have any implementation.
We should remove it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132819.
ossy@webkit.org [Tue, 30 Oct 2012 06:56:21 +0000 (06:56 +0000)]
Unreviewed, rolling out r132819.
http://trac.webkit.org/changeset/132819
https://bugs.webkit.org/show_bug.cgi?id=100388

It made layout testing 40% slower and storage tests assert

Tools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::reset):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):

LayoutTests:

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading...
jochen@chromium.org [Tue, 30 Oct 2012 06:43:43 +0000 (06:43 +0000)]
[chromium] TestRunner needs to compile ChromiumCurrentTime and ChromiumThreading in components build
https://bugs.webkit.org/show_bug.cgi?id=100658

Reviewed by Tony Chang.

Before, this was compiled into DumpRenderTree. I also dropped the
include_dirs and dependencies block as TestRunner already has them.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Null-check WebViewImpl::m_client before calling invalidateRect() on it
commit-queue@webkit.org [Tue, 30 Oct 2012 03:49:55 +0000 (03:49 +0000)]
[chromium] Null-check WebViewImpl::m_client before calling invalidateRect() on it
https://bugs.webkit.org/show_bug.cgi?id=100716

Patch by James Robinson <jamesr@chromium.org> on 2012-10-29
Reviewed by Dirk Pranke.

This check was accidentally removed in r132862 and the value is null in at least some unit tests.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::invalidateRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot
sergio@webkit.org [Tue, 30 Oct 2012 03:42:28 +0000 (03:42 +0000)]
REGRESSION(r130755): All WebKit2 unit tests are failing in WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=98864

Reviewed by Martin Robinson.

Use a dedicated directory to store WebKit2 generated resources.

* UIProcess/API/gtk/tests/GNUmakefile.am:
* UIProcess/API/gtk/tests/TestMain.cpp:
(registerGResource): load the resource from the new directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix a typo that caused SVG external resources to be blocked on
aestes@apple.com [Tue, 30 Oct 2012 03:34:12 +0000 (03:34 +0000)]
Fix a typo that caused SVG external resources to be blocked on
platforms other than Chromium.

* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNSLocale leaks in LocaleMac
keishi@webkit.org [Tue, 30 Oct 2012 02:39:35 +0000 (02:39 +0000)]
NSLocale leaks in LocaleMac
https://bugs.webkit.org/show_bug.cgi?id=97628

Reviewed by Kent Tamura.

We need to adopt the NSLocale object so it doesn't leak and
determineLocale() should return a NSLocale without additional retain.

No new tests.

* platform/text/mac/LocaleMac.mm:
(WebCore::determineLocale): Returns a RetainPtr<NSLocale>.
(WebCore::Locale::create):
(WebCore::LocaleMac::LocaleMac): m_locale should adopt the NSLocale object.
(WebCore::LocaleMac::create): LocaleMac constructor takes NSLocale without additional retain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Disable redirect to data scheme for potential fishing.
charles.wei@torchmobile.com.cn [Tue, 30 Oct 2012 02:37:49 +0000 (02:37 +0000)]
[BlackBerry] Disable redirect to data scheme for potential fishing.
https://bugs.webkit.org/show_bug.cgi?id=100713

Reviewed by George Staikos.

We will disable redirect to data scheme to avoid potential security concern,
described in klevjers.com/papers/phishing.pdf.

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::handleRedirect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdated ChangeLog.
tasak@google.com [Tue, 30 Oct 2012 01:58:43 +0000 (01:58 +0000)]
Updated ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdded myself as a committer.
tasak@google.com [Tue, 30 Oct 2012 01:58:28 +0000 (01:58 +0000)]
Added myself as a committer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r132845.
scheib@chromium.org [Tue, 30 Oct 2012 00:05:05 +0000 (00:05 +0000)]
Unreviewed, rolling out r132845.
http://trac.webkit.org/changeset/132845
https://bugs.webkit.org/show_bug.cgi?id=99975

Broke chromium builds, linker errors from
IDBBindingUtilitiesTest

Source/WebCore:

* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::IDBRequest):
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* Modules/indexeddb/IDBRequest.h:
(IDBRequest):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore):
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::idbKeyToScriptValue):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::ensureAuxiliaryContext):
(WebCore):
* bindings/v8/V8PerIsolateData.h:
(V8PerIsolateData):

Source/WebKit/chromium:

* tests/IDBBindingUtilitiesTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix Windows build.
andersca@apple.com [Mon, 29 Oct 2012 23:57:53 +0000 (23:57 +0000)]
Fix Windows build.

* platform/network/cf/ResourceRequestCFNet.cpp:
(WebCore::setHeaderFields):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Defer commits between page unload and first invalidation in threaded compo...
jamesr@google.com [Mon, 29 Oct 2012 23:49:00 +0000 (23:49 +0000)]
[chromium] Defer commits between page unload and first invalidation in threaded compositing mode
https://bugs.webkit.org/show_bug.cgi?id=100702

Reviewed by Adrienne Walker.

In threaded compositing mode, it's not terribly useful to commit after unloading a page and before receiving
the first invalidation for the new page since the document is likely not loaded enough to paint usefully.
This defers commits from the time compositing is deactivated (which in force compositing mode only happens
at FrameView destruction) until we get the first invalidation from WebCore.

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::invalidateContentsAndRootView):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::invalidateRect):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
(WebKit):
* src/WebViewImpl.h:
(WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCoordinated Graphics: Delete cached ShareableSurfaces when purging backingStores.
commit-queue@webkit.org [Mon, 29 Oct 2012 23:38:45 +0000 (23:38 +0000)]
Coordinated Graphics: Delete cached ShareableSurfaces when purging backingStores.
https://bugs.webkit.org/show_bug.cgi?id=100705

Patch by Huang Dongsung <luxtella@company100.net> on 2012-10-29
Reviewed by Noam Rosenthal.

LayerTreeCoordinatorProxy can be used after calling
LayerTreeCoordinatorProxy::purgeBackingStores(). So we should clear cached
ShareableSurfaces.

* UIProcess/CoordinatedGraphics/LayerTreeCoordinatorProxy.cpp:
(WebKit::LayerTreeCoordinatorProxy::purgeBackingStores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplify Xcode configuration settings that used to vary between OS versions.
mrowe@apple.com [Mon, 29 Oct 2012 23:36:03 +0000 (23:36 +0000)]
Simplify Xcode configuration settings that used to vary between OS versions.

Reviewed by Dan Bernstein.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/JavaScriptCore.xcconfig:

Source/ThirdParty:

* gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/WebCore.xcconfig:

Source/WebKit/mac:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:
* Configurations/WebKit.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:
* Configurations/WebKit2.xcconfig:

Source/WTF:

* Configurations/Base.xcconfig:
* Configurations/DebugRelease.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/DebugRelease.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove references to unsupported OS and Xcode versions.
mrowe@apple.com [Mon, 29 Oct 2012 23:35:56 +0000 (23:35 +0000)]
Remove references to unsupported OS and Xcode versions.

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Removed.
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* JavaScriptCore.xcodeproj/project.pbxproj:

Source/ThirdParty:

* gtest/xcode/Config/CompilerVersion.xcconfig: Removed.
* gtest/xcode/Config/General.xcconfig:

Source/ThirdParty/ANGLE:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Removed.
* Configurations/DebugRelease.xcconfig:

Source/WebCore:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Removed.
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* Configurations/WebCore.xcconfig:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Removed.
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:

Source/WebKit2:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Removed.
* Configurations/DebugRelease.xcconfig:
* Configurations/Version.xcconfig:
* DerivedSources.make:
* WebKit2.xcodeproj/project.pbxproj:

Source/WTF:

* Configurations/Base.xcconfig:
* Configurations/CompilerVersion.xcconfig: Removed.
* Configurations/DebugRelease.xcconfig:
* WTF.xcodeproj/project.pbxproj:

Tools:

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/mac/Configurations/Base.xcconfig:
* DumpRenderTree/mac/Configurations/CompilerVersion.xcconfig: Removed.
* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
* MiniBrowser/Configurations/Base.xcconfig:
* MiniBrowser/Configurations/CompilerVersion.xcconfig: Removed.
* MiniBrowser/Configurations/DebugRelease.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/CompilerVersion.xcconfig: Removed.
* TestWebKitAPI/Configurations/DebugRelease.xcconfig:
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* WebKitTestRunner/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/CompilerVersion.xcconfig: Removed.
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAtomicString(CFStringRef) shouldn't unconditionally create a StringImpl
andersca@apple.com [Mon, 29 Oct 2012 23:22:32 +0000 (23:22 +0000)]
AtomicString(CFStringRef) shouldn't unconditionally create a StringImpl
https://bugs.webkit.org/show_bug.cgi?id=100701

Reviewed by Dan Bernstein.

Source/WebCore:

* WebCore.exp.in:
Export AtomicString::add(CFStringRef).

* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Add AtomicStringCF.cpp

* platform/text/cf/AtomicStringCF.cpp: Added.
(WTF::AtomicString::add):
When trying to add the atomic string to the table, first try to get a Latin-1 pointer
from the string. Second, try to get a Unicode pointer from the string.
If that also fails, copy the string to a temporary unicode buffer and add it from there.

* platform/text/cf/HyphenationCF.cpp:
(WebCore::::createValueForKey):
Update for AtomicString::createCFString being removed.

Source/WTF:

* wtf/text/AtomicString.h:
(WTF::AtomicString::AtomicString):
Change the constructors that take a CFStringRef and an NSString * to call AtomicString::add(CFStringRef)
and remove AtomicString::createCFString.

(WTF::AtomicString::add):
Add new member function declaration. The definition is in a new file in WebCore, AtomicStringCF.cpp.
Also, fix the overload of add that takes a const char* to call the right other overload instead of itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] Add a NetworkingContext for NetworkProcess
ap@apple.com [Mon, 29 Oct 2012 23:18:26 +0000 (23:18 +0000)]
    [WK2] Add a NetworkingContext for NetworkProcess
        https://bugs.webkit.org/show_bug.cgi?id=100708

        Reviewed by Anders Carlsson.

        Each request will have a context, because these are so lightweight on Mac, and
        other platforms will need ResourceHandle refactored anyway to use NetworkProcess.

        * NetworkProcess/mac/RemoteNetworkingContext.h: Added.
        * NetworkProcess/mac/RemoteNetworkingContext.mm: Added.
        These go mac/ subdirectory, because NetworkingContext interface is different on
        each platform, as ResourceHandle needs dictate.

        * WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofeImage should not be allowed to self reference
schenney@chromium.org [Mon, 29 Oct 2012 23:15:35 +0000 (23:15 +0000)]
feImage should not be allowed to self reference
https://bugs.webkit.org/show_bug.cgi?id=94652

Reviewed by Eric Seidel.

Source/WebCore:

Add cycle detection for SVG filter application, and also fix a problem
with graphics context restore when filters are applied. This also
converts the flags in FilterData to a state tracking system, as the
number of flags was getting messy and only one flag is valid at any given time.

Test: svg/filters/feImage-self-and-other-referencing.html

* rendering/svg/RenderSVGResourceFilter.cpp: Convert to new FilterData
state management and enable cycle detection.
(WebCore):
(WebCore::RenderSVGResourceFilter::removeClientFromCache): Change isBuilt and markedForRemoval flags to state enums.
(WebCore::RenderSVGResourceFilter::applyResource): Change flags to state enums and detect cycles.
(WebCore::RenderSVGResourceFilter::postApplyResource): Change flags to state and add handling
for the various states.
(WebCore::RenderSVGResourceFilter::primitiveAttributeChanged): Change isBuilt flag to state enums.
* rendering/svg/RenderSVGResourceFilter.h:
(WebCore::FilterData::FilterData):
(FilterData): Convert to a state tracking system.
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced): Add a block around the
SVGRenderingContext so that it applies the filter and reverts the
context before the calling method restores the context.

LayoutTests:

Additional test case for situations when the filter is applied to multiple objects that it also references.

* svg/filters/feImage-self-and-other-referencing-expected.html: Added.
* svg/filters/feImage-self-and-other-referencing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
senorblanco@chromium.org [Mon, 29 Oct 2012 23:10:58 +0000 (23:10 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Correct my previous patch to disable external SVG
abarth@webkit.org [Mon, 29 Oct 2012 22:56:25 +0000 (22:56 +0000)]
Unreviewed. Correct my previous patch to disable external SVG
references only on PLATFORM(CHROMIUM).

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNon-special escape character sequences cause JSC::Lexer::parseString to create 16...
msaboff@apple.com [Mon, 29 Oct 2012 22:50:02 +0000 (22:50 +0000)]
Non-special escape character sequences cause JSC::Lexer::parseString to create 16 bit strings
https://bugs.webkit.org/show_bug.cgi?id=100576

Reviewed by Darin Adler.

Source/JavaScriptCore:

Changed singleEscape() processing to be based on a lookup of a static table.  The table
covers ASCII characters SPACE through DEL.  If a character can be a single character escape,
then the table provides the non-zero result of that escape.  Updated the result of
singleEscape to be an LChar to make the table as small as possible.
Added a new test fast/js/normal-character-escapes-in-string-literals.html to validated
the behavior.

* parser/Lexer.cpp:
(JSC::singleEscape):
(JSC::Lexer::parseString):
(JSC::Lexer::parseStringSlowCase):

LayoutTests:

Added a new test to validated the behavior of the corresponding changes to string processing
in the Lexer.

* fast/js/normal-character-escapes-in-string-literals-expected.txt: Added.
* fast/js/normal-character-escapes-in-string-literals.html: Added.
* fast/js/script-tests/normal-character-escapes-in-string-literals.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/12592716> REGRESSION (r132545): With full-page accelerated drawing, a
mitz@apple.com [Mon, 29 Oct 2012 22:35:50 +0000 (22:35 +0000)]
<rdar://problem/12592716> REGRESSION (r132545): With full-page accelerated drawing, a
reproducible hang occurs at <http://www.cbsnews.com/stories/2010/01/24/ftn/main6136386.shtml>.

Reviewed by Anders Carlsson.

Work around <rdar://problem/12584492> by limiting the scope of the fix for <http://webkit.org/b/100413>.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::clipOut): Reverted to using CGContextGetClipBoundingBox() rather
than CGRectInfinite when the context is accelerated and has a transform that is not just
a translation or a scale.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Simplify AuthenticationChallengeManager::instance
rwlbuis@webkit.org [Mon, 29 Oct 2012 21:53:53 +0000 (21:53 +0000)]
[BlackBerry] Simplify AuthenticationChallengeManager::instance
https://bugs.webkit.org/show_bug.cgi?id=100614

Reviewed by Yong Li.
Internally reviewed by Lyon Chen.

Source/WebCore:

Use a standard Singleton pattern here, this makes sure we create lazily.

* platform/blackberry/AuthenticationChallengeManager.cpp:
(WebCore):
* platform/blackberry/AuthenticationChallengeManager.h:
(AuthenticationChallengeManager):

Source/WebKit/blackberry:

No need to call AuthenticationChallengeManager::init anymore.

* Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Feature introduced in r132708 is chromium only. Skipping related tests.
roger_fong@apple.com [Mon, 29 Oct 2012 21:36:44 +0000 (21:36 +0000)]
Unreviewed. Feature introduced in r132708 is chromium only. Skipping related tests.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBlock SVG external references pending a security review
abarth@webkit.org [Mon, 29 Oct 2012 21:23:10 +0000 (21:23 +0000)]
Block SVG external references pending a security review
https://bugs.webkit.org/show_bug.cgi?id=100635

Reviewed by Eric Seidel.

Source/WebCore:

We need to do a security review of loading external SVG references
before we're sure that it is safe.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::createFilterOperations):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::canRequest):

Source/WTF:

We need to do a security review of loading external SVG references
before we're sure that it is safe.

* wtf/Platform.h:

LayoutTests:

Skip tests that depend on external SVG references.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Crash on checking version of corrupt backing store
jsbell@chromium.org [Mon, 29 Oct 2012 21:20:14 +0000 (21:20 +0000)]
IndexedDB: Crash on checking version of corrupt backing store
https://bugs.webkit.org/show_bug.cgi?id=100692

Reviewed by Tony Chang.

If the backing store fails to open (due to corruption, non-writeable disk, etc)
the subsequent schema version check dereferences a null pointer. Fix to only
do the schema check if the database opened.

Chromium tests will be included with crrev.com/11196029

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::IDBLevelDBBackingStore::open):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLet SVGElements have pending resources.
pdr@google.com [Mon, 29 Oct 2012 21:07:41 +0000 (21:07 +0000)]
Let SVGElements have pending resources.
https://bugs.webkit.org/show_bug.cgi?id=99694

Reviewed by Eric Seidel.

Our SVG pending resource tracking is used for handling dynamic id changes. For example,
if an SVG element references an id that is not yet in the document (or has been removed),
the SVG element will be 'pending' an id. When styled elements are inserted into
the document, buildPendingResourcesIfNeeded() is called to force any pending elements
to resolve their dependencies. Only SVGStyledElement targets can be referenced using
this infrastructure, and that is not changed with this patch.

Previously, only SVGStyledElements could have pending resources. Some examples of where
this is violated are SVGAnimateElement and SVGMPathElement which are not a styled elements
but which can have pending references (they can reference styled elements and
paths, respectively). This patch changes the pending resource handling to allow
any SVGElement to have pending resources.

This patch is only a refactoring of code in preparation for WK99694 and does not
affect existing functionality or tests.

* svg/SVGDocumentExtensions.cpp:
(WebCore::SVGDocumentExtensions::addPendingResource):
(WebCore::SVGDocumentExtensions::isElementPendingResources):
(WebCore::SVGDocumentExtensions::isElementPendingResource):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResources):
(WebCore::SVGDocumentExtensions::removeElementFromPendingResourcesForRemoval):
* svg/SVGDocumentExtensions.h:
(WebCore):
(SVGDocumentExtensions):
* svg/SVGElement.cpp:
(WebCore::SVGElement::~SVGElement):
(WebCore::SVGElement::removedFrom):
(WebCore::SVGElement::hasPendingResources):
(WebCore):
(WebCore::SVGElement::setHasPendingResources):
(WebCore::SVGElement::clearHasPendingResourcesIfPossible):
* svg/SVGElement.h:
(SVGElement):
(WebCore::SVGElement::buildPendingResource):
* svg/SVGStyledElement.cpp:
(WebCore):
(WebCore::SVGStyledElement::buildPendingResourcesIfNeeded):
(WebCore::SVGStyledElement::removedFrom):
* svg/SVGStyledElement.h:
(SVGStyledElement):
(WebCore::SVGStyledElement::selfHasRelativeLengths):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed rebaseline of webaudio/audiobuffersource-loop-points
crogers@google.com [Mon, 29 Oct 2012 21:06:33 +0000 (21:06 +0000)]
Unreviewed rebaseline of webaudio/audiobuffersource-loop-points

* platform/chromium-win-xp/webaudio/audiobuffersource-loop-points-expected.wav: Added.
* platform/chromium-win/webaudio/audiobuffersource-loop-points-expected.wav: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove ensureAuxiliaryContext
commit-queue@webkit.org [Mon, 29 Oct 2012 21:05:32 +0000 (21:05 +0000)]
Remove ensureAuxiliaryContext
https://bugs.webkit.org/show_bug.cgi?id=99975

Patch by Dan Carney <dcarney@google.com> on 2012-10-29
Reviewed by Adam Barth.

Source/WebCore:

Removed auxilliaryContext as use if it is problematic in IDB.

No new tests. No change in functionality.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::update):
(WebCore::IDBCursor::setValueReady):
* Modules/indexeddb/IDBCursor.h:
(IDBCursor):
* Modules/indexeddb/IDBObjectStore.cpp:
(WebCore::generateIndexKeysForValue):
(WebCore::IDBObjectStore::put):
(WebCore):
* Modules/indexeddb/IDBRequest.cpp:
(WebCore::IDBRequest::onSuccess):
(WebCore::IDBRequest::dispatchEvent):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::createIDBKeyFromScriptValueAndKeyPath):
(WebCore::deserializeIDBValue):
(WebCore::injectIDBKeyIntoScriptValue):
* bindings/v8/IDBBindingUtilities.h:
(WebCore):
* bindings/v8/V8Binding.cpp:
(WebCore::toV8Context):
(WebCore):
* bindings/v8/V8Binding.h:
(WebCore):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore):
* bindings/v8/V8PerIsolateData.h:

Source/WebKit/chromium:

Updated tests to use correct v8 context.

* tests/IDBBindingUtilitiesTest.cpp:
(WebKit::checkKeyFromValueAndKeyPathInternal):
(WebKit::checkKeyPathNullValue):
(WebKit::injectKey):
(WebKit::checkInjection):
(WebKit::checkInjectionFails):
(WebKit::checkKeyPathStringValue):
(WebKit::checkKeyPathNumberValue):
(WebKit::scriptExecutionContext):
(WebKit):
(WebKit::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[skia] Handle mask box image.
hclam@chromium.org [Mon, 29 Oct 2012 20:57:13 +0000 (20:57 +0000)]
[skia] Handle mask box image.
https://bugs.webkit.org/show_bug.cgi?id=100570

Reviewed by James Robinson.

Source/WebCore:

When drawing an image with source rectangle it should intersect with image rectangle.
This should be the case for drawing single image and tiling an image.

Test: fast/images/mask-box-image-crash.html

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::Image::drawPattern):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImageSingleFrameSkia::draw):

LayoutTests:

Added a test for -webkit-mask-box-image. Test should complete without crashes.
Output image should be blank.

* fast/images/mask-box-image-crash-expected.png: Added.
* fast/images/mask-box-image-crash-expected.txt: Added.
* fast/images/mask-box-image-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. LayoutTests/mathml/msubsup-fuzz.html passes locally but not on
dbarton@mathscribe.com [Mon, 29 Oct 2012 20:16:48 +0000 (20:16 +0000)]
Unreviewed gardening. LayoutTests/mathml/msubsup-fuzz.html passes locally but not on
cr-linux-ews. I need to see a stack trace to debug it. See webkit.org/b/100463.

* mathml/msubsup-fuzz-expected.txt: Added.
* mathml/msubsup-fuzz.html: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSupport captions when PLUGIN_PROXY_FOR_VIDEO
eric.carlson@apple.com [Mon, 29 Oct 2012 20:01:04 +0000 (20:01 +0000)]
Support captions when PLUGIN_PROXY_FOR_VIDEO
https://bugs.webkit.org/show_bug.cgi?id=100690

Reviewed by Simon Fraser.

When built with PLUGIN_PROXY_FOR_VIDEO, WebCore uses a plug-in for the media element's
platform media engine. Update this code path so the shadow DOM elements used to display
text tracks are created and configured correctly.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::configureMediaControls): Create media controls if necessary.

* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::layout): Set the position and size of the shadow DOM when the
    position of the embedded element changes.
* rendering/RenderEmbeddedObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agobuildHTTPHeaders() should use a StringBuilder.appendLiteral() for separator
msaboff@apple.com [Mon, 29 Oct 2012 19:59:27 +0000 (19:59 +0000)]
buildHTTPHeaders() should use a StringBuilder.appendLiteral() for separator
https://bugs.webkit.org/show_bug.cgi?id=100689

Reviewed by Darin Adler.

Changed from using a String temporary for the separator to using StringBuilder.appendLiteral(": ").

* WebProcess/Plugins/PluginView.cpp:
(WebKit::buildHTTPHeaders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy: change non-verbose log format for webkit-patch
dpranke@chromium.org [Mon, 29 Oct 2012 19:54:17 +0000 (19:54 +0000)]
webkitpy: change non-verbose log format for webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=100561

Reviewed by Ojan Vafai.

Logging the module name and the log level is annoying and nearly useless.
For starters, this change removes that unless you are doing verbose/
debug logging. In the future we should split out the concepts of
verbose and debug logging (like we did in test-webkitpy and
run-webkit-tests) so that you could get this in debug logging.

* Scripts/webkitpy/common/system/logutils.py:
(_default_handlers):
(configure_logging):
* Scripts/webkitpy/common/system/logutils_unittest.py:
(ConfigureLoggingTest.test_info_message):
(ConfigureLoggingTest):
(ConfigureLoggingTest.test_debug_message):
(ConfigureLoggingTest.test_two_messages):
(ConfigureLoggingVerboseTest):
(ConfigureLoggingVerboseTest._logging_level):
(ConfigureLoggingVerboseTest.test_info_message):
(ConfigureLoggingVerboseTest.test_debug_message):
(ConfigureLoggingCustomLevelTest.test_logged_message):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] flickering observed when copying 2D canvas to webGL texture
junov@google.com [Mon, 29 Oct 2012 19:37:19 +0000 (19:37 +0000)]
[Chromium] flickering observed when copying 2D canvas to webGL texture
https://bugs.webkit.org/show_bug.cgi?id=100691

Reviewed by Stephen White.

Source/WebCore:

Added a flush to the webgl context after texture upload from an image
buffer to ensure proper graphics context synchronization with respect
to subsequent changes to the source image.

Tests: fast/canvas/webgl/canvas-2d-webgl-texture.html

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyToPlatformTexture):

LayoutTests:

Modified test by adding a canvas draw imediately after webgl texture
upload in order to exercise graphics context synchronization between
the webGL and 2D canvas graphics contexts.

* fast/canvas/webgl/canvas-2d-webgl-texture.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSOM] Extraneous whitespace in CSSImportRule.cssText
commit-queue@webkit.org [Mon, 29 Oct 2012 19:00:41 +0000 (19:00 +0000)]
[CSSOM] Extraneous whitespace in CSSImportRule.cssText
https://bugs.webkit.org/show_bug.cgi?id=100657

Patch by Glenn Adams <glenn@skynav.com> on 2012-10-29
Reviewed by Simon Fraser.

Source/WebCore:

Remove extraneous whitespace when serializing CSSImportRule.cssText when
media list is empty.

Test: cssom/cssimportrule-media.html

* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::cssText):
Don't append extra whitespace if mediaText is empty.

LayoutTests:

Test (from CSS WG) that checks serializion of CSSImportRule.cssText.

* http/tests/css/shared-stylesheet-mutation-expected.txt:
* http/tests/css/shared-stylesheet-mutation-preconstruct-expected.txt:
Fix expected output to match removal of extraneous space.

* cssom/cssimportrule-media-expected.txt: Added.
* cssom/cssimportrule-media.html: Added.
* cssom/resources/import.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt
commit-queue@webkit.org [Mon, 29 Oct 2012 18:50:11 +0000 (18:50 +0000)]
[CMAKE] Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMakeLists.txt
https://bugs.webkit.org/show_bug.cgi?id=100681

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29
Reviewed by Anders Carlsson.

Add TestNetscapePlugIn/Tests/NPRuntimeCallsWithNullNPP.cpp to CMake since
it is needed by plugins/npruntime/npruntime-calls-with-null-npp.html
layout test.

* DumpRenderTree/TestNetscapePlugIn/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoString::split(UChar, Vector<String>&) shouldn't create a temporary String
msaboff@apple.com [Mon, 29 Oct 2012 18:18:56 +0000 (18:18 +0000)]
String::split(UChar, Vector<String>&) shouldn't create a temporary String
https://bugs.webkit.org/show_bug.cgi?id=100578

Reviewed by Anders Carlsson.

Changed split(UChar, Vector<String>&) to call split(UChar, bool, Vector<String>&) instead of creating a
string and calling the split(String,...) version and moved it to WTFString.h.  Also moved
split(const String& separator, Vector<String>& result) to WTFString.h.

* wtf/text/WTFString.cpp:
(WTF::String::split):
* wtf/text/WTFString.h:
(WTF::String::split):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Mon, 29 Oct 2012 18:11:05 +0000 (18:11 +0000)]
Unreviewed GTK gardening.

Adding flaky crash expectations for tests that crash after r132699
if the accessibility object cache is populated.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html test case
commit-queue@webkit.org [Mon, 29 Oct 2012 18:07:24 +0000 (18:07 +0000)]
[EFL] Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html test case
https://bugs.webkit.org/show_bug.cgi?id=100687

Unreviewed EFL gardening.

Skip fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html test case
since it is intrinsically flaky and cannot be fixed.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-10-29

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWKStringCopyCFString() should directly use 8 bit Strings data instead of up converting
msaboff@apple.com [Mon, 29 Oct 2012 18:05:23 +0000 (18:05 +0000)]
WKStringCopyCFString() should directly use 8 bit Strings data instead of up converting
https://bugs.webkit.org/show_bug.cgi?id=100579

Reviewed by Oliver Hunt.

Changed to use CFStringCreateWithBytes() for 8 bit strings using characters8() for an 8 bit argument string.
Changed the current call to characters16().

* Shared/API/c/cf/WKStringCF.cpp:
(WKStringCopyCFString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebview not redrawn as needed when accelerated compositing is enabled.
commit-queue@webkit.org [Mon, 29 Oct 2012 18:01:16 +0000 (18:01 +0000)]
webview not redrawn as needed when accelerated compositing is enabled.
https://bugs.webkit.org/show_bug.cgi?id=99109

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-10-29
Reviewed by Martin Robinson.

GL shared display is not in the gtk loop and therefore, its events are
not captured by gtk. So, we use gdk default instead.

No new tests, covered by existing tests.

* platform/gtk/RedirectedXCompositeWindow.cpp:
(WebCore::RedirectedXCompositeWindow::RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::~RedirectedXCompositeWindow):
(WebCore::RedirectedXCompositeWindow::resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.
commit-queue@webkit.org [Mon, 29 Oct 2012 17:51:41 +0000 (17:51 +0000)]
Web Inspector: Style toolbar to match Chromium toolbar on Chromium/Mac.
https://bugs.webkit.org/show_bug.cgi?id=100683

Patch by Patrick Dubroy <dubroy@chromium.org> on 2012-10-29
Reviewed by Pavel Feldman.

When in compact mode, style the Web Inspector toolbar using the same colors & gradients
as the Chromium toolbar (Chromium port only).

* src/js/devTools.css:
(body.compact.platform-mac #toolbar):
(body.compact.platform-mac.inactive #toolbar):
(body.platform-mac.inactive #toolbar .toolbar-label):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Flaky security tests
allan.jensen@digia.com [Mon, 29 Oct 2012 17:47:25 +0000 (17:47 +0000)]
[Qt] Flaky security tests
https://bugs.webkit.org/show_bug.cgi?id=100388

Reviewed by Jocelyn Turcotte.

Tools:

Disable text dumping and load a blank URL to ensure the documentLoader is cleared
before we start dumping text for the new page. Otherwise messages from the old page
may end up in the text output of the new test.

This matches what WebKitTestRunner does, and reuses the Qt code for waiting for flag.

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::DumpRenderTree::DumpRenderTree):
(WebCore::runUntil):
(WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
(WebCore::DumpRenderTree::finishedResetting):
(WebCore::DumpRenderTree::dump):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
(DumpRenderTree):
* DumpRenderTree/qt/TestRunnerQt.cpp:
(TestRunner::resetDumping):
(TestRunner::reset):
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):

LayoutTests:

Unskip no longer flaky tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTurn PageLoad tests into simple performancetests, commit #7 (last)
zoltan@webkit.org [Mon, 29 Oct 2012 17:30:56 +0000 (17:30 +0000)]
Turn PageLoad tests into simple performancetests, commit #7 (last)
https://bugs.webkit.org/show_bug.cgi?id=99899

Reviewed by Ryosuke Niwa.

We cannot provide an elegant way to measure the memory consumption of the PageLoad tests, but we can turn them into simple
performance tests and measure their memory footprint and performance that way. This change moves and renames the related files
to their new location and adds html/js wrappers for them.

This is the #7 (last) commit of the whole patch.

* PageLoad: Removed.
* PageLoad/svg: Removed.
* PageLoad/svg/LICENSES: Removed.
* PageLoad/svg/files: Removed.
* PageLoad/svg/files/33041-Samurai.svg: Removed.
* PageLoad/svg/files/42450-under the see.svg: Removed.
* PageLoad/svg/files/world-iso.svg: Removed.
* PageLoad/svg/svg.pltsuite: Removed.
* SVG/Samurai.html: Added.
* SVG/UnderTheSee.html: Added.
* SVG/WorldIso.html: Added.
* SVG/resources/LICENSES: Copied from PerformanceTests/PageLoad/svg/LICENSES.
* SVG/resources/Samurai.svg: Copied from PerformanceTests/PageLoad/svg/files/33041-Samurai.svg.
* SVG/resources/UnderTheSee.svg: Copied from PerformanceTests/PageLoad/svg/files/42450-under%20the%20see.svg.
* SVG/resources/WorldIso.svg: Copied from PerformanceTests/PageLoad/svg/files/world-iso.svg.
* SVG/resources/svg.pltsuite: Copied from PerformanceTests/PageLoad/svg/svg.pltsuite.
* Skipped: Rename the files on the skipped list also.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: bind redo to Ctrl+Y on non-mac platforms
pfeldman@chromium.org [Mon, 29 Oct 2012 17:26:59 +0000 (17:26 +0000)]
Web Inspector: bind redo to Ctrl+Y on non-mac platforms
https://bugs.webkit.org/show_bug.cgi?id=100685

Reviewed by Vsevolod Vlasov.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype._registerShortcuts):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ENABLE_USERSELECT_ALL feature flag.
enrica@apple.com [Mon, 29 Oct 2012 17:10:19 +0000 (17:10 +0000)]
Add ENABLE_USERSELECT_ALL feature flag.
https://bugs.webkit.org/show_bug.cgi?id=100559

Reviewed by Eric Seidel.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Shaders] Extract the CustomFilterParameterList to its own file
achicu@adobe.com [Mon, 29 Oct 2012 16:50:06 +0000 (16:50 +0000)]
[CSS Shaders] Extract the CustomFilterParameterList to its own file
https://bugs.webkit.org/show_bug.cgi?id=100548

Reviewed by Dean Jackson.

Moved all the CustomFilterParameterList related methods to their own file.
Also made CustomFilterParameterList inherit from Vector instead of typedefing it,
so that we can add a different operator== and a blend method to it.

No new tests, just refactoring existing code.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:
* css/StyleResolver.h:
* platform/graphics/filters/CustomFilterOperation.cpp:
(WebCore::CustomFilterOperation::CustomFilterOperation):
(WebCore::CustomFilterOperation::blend):
* platform/graphics/filters/CustomFilterOperation.h:
(WebCore):
(WebCore::CustomFilterOperation::operator==):
* platform/graphics/filters/CustomFilterParameterList.cpp: Added.
(WebCore):
(WebCore::CustomFilterParameterList::operator==):
(WebCore::CustomFilterParameterList::checkAlphabeticalOrder):
(WebCore::CustomFilterParameterList::blend):
* platform/graphics/filters/CustomFilterParameterList.h: Added.
(WebCore):
(CustomFilterParameterList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTry to fix 32-bit builds after my incompletely tested m_identifier change.
beidson@apple.com [Mon, 29 Oct 2012 16:42:48 +0000 (16:42 +0000)]
Try to fix 32-bit builds after my incompletely tested m_identifier change.

Not reviewed.

* loader/ResourceLoader.h:
(WebCore::ResourceLoader::identifier): Revert my "unsigned long" -> "uint64_t" change in two places.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@132807 268f45cc-cd09-0410-ab3c-d52691b4dbfc