WebKit-https.git
9 years ago Unreviewed, GTK rebaseline of 3 svg/custom/linking tests.
philn@webkit.org [Wed, 29 Jun 2011 09:18:18 +0000 (09:18 +0000)]
    Unreviewed, GTK rebaseline of 3 svg/custom/linking tests.

        * platform/gtk/svg/custom/linking-a-03-b-all-expected.txt:
        * platform/gtk/svg/custom/linking-a-03-b-transform-expected.txt:
        * platform/gtk/svg/custom/linking-a-03-b-viewBox-transform-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@90000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, GTK rebaseline of
philn@webkit.org [Wed, 29 Jun 2011 08:59:32 +0000 (08:59 +0000)]
    Unreviewed, GTK rebaseline of
        fast/html/details-open-javascript.html

        * platform/gtk/fast/html/details-open-javascript-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed, skip crashing tests on GTK because of
philn@webkit.org [Wed, 29 Jun 2011 08:30:34 +0000 (08:30 +0000)]
    Unreviewed, skip crashing tests on GTK because of
        https://bugs.webkit.org/show_bug.cgi?id=63611

        * platform/gtk/Skipped: skip 5 editing tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-29 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 29 Jun 2011 07:57:36 +0000 (07:57 +0000)]
2011-06-29  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: update the (hopefully) last ruby expectation stragglers in WebKit2

        * platform/win-wk2/fast/ruby/after-block-doesnt-crash-expected.txt:
        * platform/win-wk2/fast/ruby/after-table-doesnt-crash-expected.txt:
        * platform/win-wk2/fast/ruby/before-block-doesnt-crash-expected.txt:
        * platform/win-wk2/fast/ruby/before-table-doesnt-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-29 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 29 Jun 2011 07:21:05 +0000 (07:21 +0000)]
2011-06-29  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: more juggling with ruby expectation files, trying to
        find my way out of the expectations dependency jungle...

        * platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-mac/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * platform/chromium-win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
        * platform/win/fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * platform/win/fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * platform/win/fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-29 Darin Adler <darin@apple.com>
darin@apple.com [Wed, 29 Jun 2011 07:11:50 +0000 (07:11 +0000)]
2011-06-29  Darin Adler  <darin@apple.com>

        Reviewed by Adam Barth.

        Consolidate the fast/loader and fast/loading directories
        https://bugs.webkit.org/show_bug.cgi?id=63587

        * fast/loader/resources/subframe-that-removes-itself.html: Copied from LayoutTests/fast/loading/resources/subframe-that-removes-itself.html.
        * fast/loader/subframe-removes-itself-expected.txt: Copied from LayoutTests/fast/loading/subframe-removes-itself-expected.txt.
        * fast/loader/subframe-removes-itself.html: Copied from LayoutTests/fast/loading/subframe-removes-itself.html.
        * fast/loading/resources/subframe-that-removes-itself.html: Removed.
        * fast/loading/subframe-removes-itself-expected.txt: Removed.
        * fast/loading/subframe-removes-itself.html: Removed.

        * platform/gtk/Skipped: Updated for new location of test.
        * platform/mac-wk2/Skipped: Ditto.
        * platform/qt-wk2/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 29 Jun 2011 06:54:22 +0000 (06:54 +0000)]
2011-06-28  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGBoolean animation
        https://bugs.webkit.org/show_bug.cgi?id=63529

        Follow up of "SVGAnimation should use direct unit animation for SVGLength": https://bugs.webkit.org/show_bug.cgi?id=61368
        This patch continues the conversion to the new concept of SVGAnimatorFactory with SVGBoolean.

        The new animator does not affect any behavior, since it was animated with SVGAnimatedString before. The new animator is still needed
        to support animVal and baseVal later.

        Test: svg/animations/svgboolean-animation-1.html

        * CMakeLists.txt: Add new file to build system.
        * GNUmakefile.list.am: Ditto.
        * WebCore.gypi: Ditto.
        * WebCore.pro: Ditto.
        * WebCore.xcodeproj/project.pbxproj: Ditto.
        * svg/SVGAllInOne.cpp: Ditto.
        * svg/SVGAnimateElement.cpp: Make use of AnimatedBoolean.
        (WebCore::SVGAnimateElement::determineAnimatedAttributeType):
        (WebCore::SVGAnimateElement::calculateAnimatedValue):
        (WebCore::SVGAnimateElement::calculateFromAndToValues):
        (WebCore::SVGAnimateElement::calculateFromAndByValues):
        (WebCore::SVGAnimateElement::resetToBaseValue):
        (WebCore::SVGAnimateElement::applyResultsToTarget):
        (WebCore::SVGAnimateElement::calculateDistance):
        * svg/SVGAnimatedBoolean.cpp: Added. New animator for SVGBoolean.
        (WebCore::SVGAnimatedBooleanAnimator::SVGAnimatedBooleanAnimator):
        (WebCore::SVGAnimatedBooleanAnimator::constructFromString):
        (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndToValues):
        (WebCore::SVGAnimatedBooleanAnimator::calculateFromAndByValues):
        (WebCore::SVGAnimatedBooleanAnimator::calculateAnimatedValue):
        (WebCore::SVGAnimatedBooleanAnimator::calculateDistance):
        * svg/SVGAnimatedBoolean.h:
        (WebCore::SVGAnimatedBooleanAnimator::~SVGAnimatedBooleanAnimator):
        * svg/SVGAnimatedType.cpp: Use bool for SVGBoolean.
        (WebCore::SVGAnimatedType::~SVGAnimatedType):
        (WebCore::SVGAnimatedType::createBoolean):
        (WebCore::SVGAnimatedType::boolean):
        (WebCore::SVGAnimatedType::valueAsString):
        (WebCore::SVGAnimatedType::setValueAsString):
        * svg/SVGAnimatedType.h:
        * svg/SVGAnimatorFactory.h: New crate function for SVGAnimatedSVGBooleanAnimator.
        (WebCore::SVGAnimatorFactory::create):
2011-06-28  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVGAnimatedType should support SVGBoolean animation
        https://bugs.webkit.org/show_bug.cgi?id=63529

        Test animation of SVGBoolean. Add the test to the skip list of wk2.
        Convert animate-number-calcMode-discrete-keyTimes to common style, no change
        on the test itself.

        * platform/mac-wk2/Skipped:
        * svg/animations/animate-number-calcMode-discrete-keyTimes-expected.txt:
        * svg/animations/animate-number-calcMode-discrete-keyTimes.html:
        * svg/animations/script-tests/svgboolean-animation-1.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/svgboolean-animation-1-expected.txt: Added.
        * svg/animations/svgboolean-animation-1.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 29 Jun 2011 06:46:56 +0000 (06:46 +0000)]
2011-06-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Make applyAuthorSheets settable on ShadowRoot.
        https://bugs.webkit.org/show_bug.cgi?id=63599

        Refactoring and adding not-yet used function, tests to follow when API lands.

        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::ShadowRoot): Added initializer.
        (WebCore::ShadowRoot::applyAuthorSheets): Made to use member variable.
        (WebCore::ShadowRoot::setApplyAuthorSheets): Added.
        * dom/ShadowRoot.h: Tweaked, added decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Ilya Sherman <isherman@chromium.org>
isherman@chromium.org [Wed, 29 Jun 2011 06:35:41 +0000 (06:35 +0000)]
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * fast/forms/autocomplete-expected.txt: Added.
        * fast/forms/autocomplete.html: Added.
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        Rename the autoComplete() method for HTMLFormElement, HTMLFormControlElementWithState, and HTMLInputElement to shouldAutocomplete()
        Add the autocomplete attribute to HTMLFormElement.idl and HTMLInputElement.idl
        https://bugs.webkit.org/show_bug.cgi?id=35823

        Test: fast/forms/autocomplete.html

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElementWithState::shouldAutocomplete): Renamed from ::autoComplete()
        (WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState): Update callsite.
        * html/HTMLFormControlElement.h:
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::~HTMLFormElement): Update callsite.
        (WebCore::HTMLFormElement::parseMappedAttribute): Update callsite.
        (WebCore::HTMLFormElement::documentDidBecomeActive): Update callsite.
        (WebCore::HTMLFormElement::willMoveToNewOwnerDocument): Update callsite.
        (WebCore::HTMLFormElement::didMoveToNewOwnerDocument): Update callsite.
        (WebCore::HTMLFormElement::shouldAutocomplete): Renamed from ::autoComplete()
        * html/HTMLFormElement.h:
        * html/HTMLFormElement.idl: Bind the autocomplete attribute to a JavaScript property.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::shouldAutocomplete): Renamed from ::autoComplete()
        * html/HTMLInputElement.h:
        * html/HTMLInputElement.idl: Bind the autocomplete attribute to a JavaScript property.
        * WebCore.exp.in: Updated autoComplete() -> shouldAutocomplete()
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::autofill): Update callsite.
        * src/WebFormElement.cpp:
        (WebKit::WebFormElement::autoComplete): Update callsite.
        * src/WebInputElement.cpp:
        (WebKit::WebInputElement::autoComplete): Update callsite.
        * src/WebPasswordFormUtils.cpp:
        (WebKit::findPasswordFormFields): Update callsite.
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation elementDoesAutoComplete:]): Update callsite.
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::elementDoesAutoCompleteForElementWithId): Update callsite.
2011-06-28  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Adam Barth.

        form.autocomplete="off" does not work
        https://bugs.webkit.org/show_bug.cgi?id=35823

        * WebFrame.cpp:
        (WebFrame::elementDoesAutoComplete): Updated callsite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 29 Jun 2011 06:06:14 +0000 (06:06 +0000)]
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Unreviewed: change URLs in ruby layout tests to lower case in order
        to avoid having to have separate Chromium expectations.

        * fast/ruby/after-block-doesnt-crash-expected.txt:
        * fast/ruby/after-block-doesnt-crash.html:
        * fast/ruby/after-table-doesnt-crash-expected.txt:
        * fast/ruby/after-table-doesnt-crash.html:
        * fast/ruby/before-block-doesnt-crash-expected.txt:
        * fast/ruby/before-block-doesnt-crash.html:
        * fast/ruby/before-table-doesnt-crash-expected.txt:
        * fast/ruby/before-table-doesnt-crash.html:
        * fast/ruby/generated-after-counter-doesnt-crash-expected.txt:
        * fast/ruby/generated-after-counter-doesnt-crash.html:
        * fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt:
        * fast/ruby/generated-before-and-after-counter-doesnt-crash.html:
        * fast/ruby/generated-before-counter-doesnt-crash-expected.txt:
        * fast/ruby/generated-before-counter-doesnt-crash.html:
        * platform/chromium-mac/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
        * platform/chromium-mac/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
        * platform/chromium-mac/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
        * platform/chromium-mac/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.
        * platform/chromium-win/fast/ruby/after-block-doesnt-crash-expected.txt: Removed.
        * platform/chromium-win/fast/ruby/after-table-doesnt-crash-expected.txt: Removed.
        * platform/chromium-win/fast/ruby/before-block-doesnt-crash-expected.txt: Removed.
        * platform/chromium-win/fast/ruby/before-table-doesnt-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 29 Jun 2011 06:05:16 +0000 (06:05 +0000)]
2011-06-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Store shadowPseudoId in ElementRareData.
        https://bugs.webkit.org/show_bug.cgi?id=63604

        No new tests, because the code isn't yet used.

        * css/CSSSelector.cpp:
        (WebCore::CSSSelector::isUnknownPseudoType): Added convenience helper.
        * css/CSSSelector.h: Added decl.
        * dom/Element.cpp:
        (WebCore::Element::shadowPseudoId): Changed to use ElementRareData.
        (WebCore::Element::setShadowPseudoId): Ditto.
        * dom/Element.h: Added decls.
        * dom/ElementRareData.h: Added a member to keep shadowPseudoId.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Kenichi Ishibashi <bashi@chromium.org>
bashi@chromium.org [Wed, 29 Jun 2011 06:01:53 +0000 (06:01 +0000)]
2011-06-28  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Remove dependencies on harfbuzz from FontPlatformDataLinux and FontLinux
        https://bugs.webkit.org/show_bug.cgi?id=62530

        - Moved codes of FontLinux which depend on harfbuzz APIs to ComplexTextController.  Removed Some methods of ComplexTextController(advances() and logClusters()) since they are no longer needed.
        - Moved RefCountedHarfbuzzFace from FontPlatformDataLinux to HarfbuzzSkia and renamed it to HarfbuzzFace.

        No new tests because there is no behavior change (The existing tests should cover the changes).

        * platform/graphics/chromium/ComplexTextControllerLinux.cpp:
        (WebCore::ComplexTextController::ComplexTextController): Added arguments so eliminating setter invocations.
        (WebCore::ComplexTextController::setupForRTL): Added.
        (WebCore::ComplexTextController::setupFontForScriptRun): Adopt the change of HarfbuzzFace class.
        (WebCore::ComplexTextController::setGlyphPositions): Use m_item.log_clusters instead of removed method.
        (WebCore::ComplexTextController::glyphIndexForXPositionInScriptRun): Added.
        (WebCore::ComplexTextController::offsetForPosition): Ditto.
        (WebCore::ComplexTextController::selectionRect): Ditto.
        * platform/graphics/chromium/ComplexTextControllerLinux.h:
        (WebCore::ComplexTextController::width):
        * platform/graphics/chromium/FontLinux.cpp: Removed truncateFixedPointToInteger().
        (WebCore::Font::drawComplexText): Removed setter invocations of ComplexTextController.
        (WebCore::Font::floatWidthForComplexText): Ditto.
        (WebCore::Font::offsetForPositionForComplexText): Moved harfbuzz dependent code to ComplexTextController.
        (WebCore::Font::selectionRectForComplexText): Ditto.
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::harfbuzzFace): Wrapped up HB_FaceRec in HarfbuzzFace class.
        * platform/graphics/chromium/FontPlatformDataLinux.h: Moved RefCountedHarfbuzzFace class and renamed to HarfbuzzFace.
        * platform/graphics/chromium/HarfbuzzSkia.cpp:
        (WebCore::allocHarfbuzzFont): Moved from ComplexTextControllerLinux.cpp.
        (WebCore::HarfbuzzFace::HarfbuzzFace): Added.
        (WebCore::HarfbuzzFace::~HarfbuzzFace): Added.
        * platform/graphics/chromium/HarfbuzzSkia.h:
        (WebCore::HarfbuzzFace::create): Added.
        (WebCore::HarfbuzzFace::face): Added.
        * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp:
        (WebCore::substituteWithVerticalGlyphs): Adopt  the change of HarfbuzzFace class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 29 Jun 2011 04:34:38 +0000 (04:34 +0000)]
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Eric Seidel.

        Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Test that a generated block child + counter within a <ruby> doesn't crash.
        (Test as provided by original reporter).

        * fast/ruby/generated-after-counter-doesnt-crash-expected.txt: Added.
        * fast/ruby/generated-after-counter-doesnt-crash.html: Added.
        * fast/ruby/generated-before-and-after-counter-doesnt-crash-expected.txt: Added.
        * fast/ruby/generated-before-and-after-counter-doesnt-crash.html: Added.
        * fast/ruby/generated-before-counter-doesnt-crash-expected.txt: Added.
        * fast/ruby/generated-before-counter-doesnt-crash.html: Added.
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Eric Seidel.

        Bug 55930 - (CVE-2011-1440) Incorrect handling of 'display:' property within nested <ruby> tags
        https://bugs.webkit.org/show_bug.cgi?id=55930

        Don't set style type BEFORE/AFTER on anonymous wrapper block.
        Rather, check style type on generated wrapped child.

        Tests: fast/ruby/generated-after-counter-doesnt-crash.html
               fast/ruby/generated-before-and-after-counter-doesnt-crash.html
               fast/ruby/generated-before-counter-doesnt-crash.html

        * rendering/RenderRuby.cpp:
        (WebCore::isAnonymousRubyInlineBlock):
        (WebCore::isRubyBeforeBlock):
        (WebCore::isRubyAfterBlock):
        (WebCore::rubyBeforeBlock):
        (WebCore::rubyAfterBlock):
        (WebCore::createAnonymousRubyInlineBlock):
        (WebCore::RenderRubyAsInline::addChild):
        (WebCore::RenderRubyAsBlock::addChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDFG JIT lacks array.length caching.
barraclough@apple.com [Wed, 29 Jun 2011 03:18:58 +0000 (03:18 +0000)]
DFG JIT lacks array.length caching.
https://bugs.webkit.org/show_bug.cgi?id=63505

Patch by Filip Pizlo <fpizlo@apple.com> on 2011-06-28
Reviewed by Gavin Barraclough.

* bytecode/StructureStubInfo.h:
* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::JITCodeGenerator::cachedGetById):
(JSC::DFG::JITCodeGenerator::cachedPutById):
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::tryAllocate):
(JSC::DFG::JITCodeGenerator::selectScratchGPR):
(JSC::DFG::JITCodeGenerator::silentSpillAllRegisters):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::addPropertyAccess):
(JSC::DFG::JITCompiler::PropertyAccessRecord::PropertyAccessRecord):
* dfg/DFGRegisterBank.h:
(JSC::DFG::RegisterBank::tryAllocate):
* dfg/DFGRepatch.cpp:
(JSC::DFG::tryCacheGetByID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Pierre Rossi <pierre.rossi@gmail.com>
commit-queue@webkit.org [Wed, 29 Jun 2011 02:41:47 +0000 (02:41 +0000)]
2011-06-28  Pierre Rossi  <pierre.rossi@gmail.com>

        Reviewed by Eric Seidel.

        Warnings in JSC's JIT on 32 bit
        https://bugs.webkit.org/show_bug.cgi?id=63259

        Fairly straightforward, just use ASSERT_JIT_OFFSET_UNUSED when it applies.

        * jit/JITPropertyAccess32_64.cpp:
        (JSC::JIT::emit_op_method_check):
        (JSC::JIT::compileGetByIdHotPath):
        (JSC::JIT::emit_op_put_by_id):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Wed, 29 Jun 2011 01:28:51 +0000 (01:28 +0000)]
2011-06-28  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Switch RenderLayer position/size to to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63578

        Switch location and size methods for RenderLayer over to the new layout unit abstraction.

        No new tests, no functionality changes.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::resize):
        (WebCore::RenderLayer::visibleHeight):
        (WebCore::RenderLayer::visibleWidth):
        (WebCore::RenderLayer::offsetFromResizeCorner):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::location):
        (WebCore::RenderLayer::setLocation):
        (WebCore::RenderLayer::size):
        (WebCore::RenderLayer::setSize):
        (WebCore::RenderLayer::rect):
        (WebCore::RenderLayer::renderBoxLocation):
        (WebCore::RenderLayer::renderBoxX):
        (WebCore::RenderLayer::renderBoxY):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::visibleHeight):
        (WebCore::RenderListBox::visibleWidth):
        * rendering/RenderListBox.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 29 Jun 2011 01:06:00 +0000 (01:06 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintObject and paintReplaced to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63585

        Switching paintObject and paintReplaced to layout type abstractions from more integral types.

        No new tests as this is just moving to an abstraction.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paintObject):
        * rendering/RenderBlock.h:
        * rendering/RenderBox.h:
        (WebCore::RenderBox::paintObject):
        * rendering/RenderEmbeddedObject.cpp:
        (WebCore::RenderEmbeddedObject::paintReplaced):
        * rendering/RenderEmbeddedObject.h:
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::paintObject):
        * rendering/RenderFileUploadControl.h:
        * rendering/RenderHTMLCanvas.cpp:
        (WebCore::RenderHTMLCanvas::paintReplaced):
        * rendering/RenderHTMLCanvas.h:
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::paintReplaced):
        * rendering/RenderImage.h:
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintObject):
        * rendering/RenderListBox.h:
        * rendering/RenderReplaced.h:
        (WebCore::RenderReplaced::paintReplaced):
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintObject):
        * rendering/RenderTable.h:
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::paintObject):
        * rendering/RenderTableSection.h:
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::paintObject):
        * rendering/RenderTextControl.h:
        * rendering/RenderVideo.cpp:
        (WebCore::RenderVideo::paintReplaced):
        * rendering/RenderVideo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Adam Langley <agl@chromium.org>
agl@chromium.org [Wed, 29 Jun 2011 01:03:18 +0000 (01:03 +0000)]
2011-06-28  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Skip cache validation on back with HTTPS.
        https://bugs.webkit.org/show_bug.cgi?id=63537

        * http/tests/cache/history-only-cached-subresource-loads-max-age-https-expected.txt: Added.
        * http/tests/cache/history-only-cached-subresource-loads-max-age-https.html: Added.
        * http/tests/cache/resources/max-age-resource-forward.html: Added.
        * http/tests/cache/resources/max-age-resource-next.html: Added.
        * http/tests/cache/resources/max-age-resource.html: Added.
        * http/tests/cache/resources/random-max-age.cgi: Added.
2011-06-28  Adam Langley  <agl@chromium.org>

        Reviewed by Adam Barth.

        Skip cache validation on back with HTTPS.
        https://bugs.webkit.org/show_bug.cgi?id=63537

        For back navigations over HTTP, WebKit sets a flag to use cached data
        irrespective of whether it has expired. However, this isn't currently
        done for HTTPS.

        The logic in question was added in
        https://bugs.webkit.org/show_bug.cgi?id=33993 and appears to have been
        precautionary. However, both Firefox and IE will use this back
        navigation trick for HTTPS as well and so we should probably behave
        likewise.

        Test: http/tests/cache/history-only-cached-subresource-loads-max-age-https.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::addExtraFieldsToRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 29 Jun 2011 00:58:45 +0000 (00:58 +0000)]
2011-06-28  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Adam Barth.

        Remove errant isShadowBoundary on ShadowRoot.
        https://bugs.webkit.org/show_bug.cgi?id=63588

        Removing dead code, no tests for that.

        * dom/ShadowRoot.h: Removed a function that's no longer used.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Zeng Huiqing <huiqing.zeng@intel.com>
commit-queue@webkit.org [Wed, 29 Jun 2011 00:57:24 +0000 (00:57 +0000)]
2011-06-28  Zeng Huiqing  <huiqing.zeng@intel.com>

        Reviewed by Kenneth Russell.

        [chromium]Optimize GraphicsLayerChromium::setChildren()
        https://bugs.webkit.org/show_bug.cgi?id=62837

        No new tests.

        * platform/graphics/chromium/GraphicsLayerChromium.cpp:
        (WebCore::GraphicsLayerChromium::GraphicsLayerChromium):
        (WebCore::GraphicsLayerChromium::setChildren):
        (WebCore::GraphicsLayerChromium::addChild):
        * platform/graphics/chromium/GraphicsLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Wed, 29 Jun 2011 00:53:04 +0000 (00:53 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintBoxShadow and paintBoxDecorations to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63577

        Switching paintBoxShadow and paintBoxDecorations to layout type abstraction
        from more integral types.

        No new tests as this is just moving to an abstraction.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintBoxShadow):
        (WebCore::InlineFlowBox::paintBoxDecorations):
        * rendering/InlineFlowBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintBoxDecorations):
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintBoxShadow):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintBoxDecorations):
        * rendering/RenderFieldset.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintBoxDecorations):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBoxDecorations):
        * rendering/RenderTableCell.h:
        * rendering/RenderView.cpp:
        (WebCore::RenderView::paintBoxDecorations):
        * rendering/RenderView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Wed, 29 Jun 2011 00:49:05 +0000 (00:49 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Rolled DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Tue, 28 Jun 2011 23:56:01 +0000 (23:56 +0000)]
2011-06-28  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Switch RenderBox position/size to to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63571

        Switch location and size methods for RenderBox over to the new layout unit abstraction.

        No new tests, no functionality changes.

        * rendering/RenderBox.cpp:
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderInline.cpp:
        * rendering/RenderInline.h:
        * rendering/RenderVideo.cpp:
        * rendering/RenderVideo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build correction. Link to correct library for
bfulgham@webkit.org [Tue, 28 Jun 2011 23:52:14 +0000 (23:52 +0000)]
Unreviewed build correction.  Link to correct library for
the zlib1.dll.

* win/tools/vsprops/WinCairo.vsprops: Don't link to the static
zlib.lib when building for WinCairo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 28 Jun 2011 23:39:05 +0000 (23:39 +0000)]
2011-06-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89968.
        http://trac.webkit.org/changeset/89968
        https://bugs.webkit.org/show_bug.cgi?id=63581

        Broke chromium windows compile (Requested by jamesr on
        #webkit).

        * wtf/Platform.h:
2011-06-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89968.
        http://trac.webkit.org/changeset/89968
        https://bugs.webkit.org/show_bug.cgi?id=63581

        Broke chromium windows compile (Requested by jamesr on
        #webkit).

        * WebCore.gyp/WebCore.gyp:
        * loader/cache/CachedFont.cpp:
        * platform/chromium/DragImageRef.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontPlatformData.h:
        (WebCore::FontPlatformData::hash):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        (WebCore::GlyphBuffer::expandLastAdvance):
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/FloatPointCG.cpp:
        * platform/graphics/cg/FloatRectCG.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/IntPointCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/cg/IntSizeCG.cpp:
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/mac/FontCustomPlatformData.h:
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
2011-06-28  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r89968.
        http://trac.webkit.org/changeset/89968
        https://bugs.webkit.org/show_bug.cgi?id=63581

        Broke chromium windows compile (Requested by jamesr on
        #webkit).

        * WebKit.gyp:
        * features.gypi:
        * public/WebCommon.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 28 Jun 2011 23:36:28 +0000 (23:36 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch PaintMask* to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63576

        Switching paintMask* to layout type abstraction from more integral types.

        No new tests as this is just moving to an abstraction.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintMask):
        * rendering/InlineFlowBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintMask):
        (WebCore::RenderBox::paintMaskImages):
        * rendering/RenderBox.h:
        * rendering/RenderFieldset.cpp:
        (WebCore::RenderFieldset::paintMask):
        * rendering/RenderFieldset.h:
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::paintMask):
        * rendering/RenderTable.h:
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintMask):
        * rendering/RenderTableCell.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 28 Jun 2011 23:26:54 +0000 (23:26 +0000)]
2011-06-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Fix sampling build
        https://bugs.webkit.org/show_bug.cgi?id=63579

        Gets opcode sampling building again, doesn't seem to work alas

        * bytecode/SamplingTool.cpp:
        (JSC::SamplingTool::notifyOfScope):
        * bytecode/SamplingTool.h:
        (JSC::SamplingTool::SamplingTool):
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::enableSampler):
        * runtime/Executable.h:
        (JSC::ScriptExecutable::ScriptExecutable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Tue, 28 Jun 2011 23:11:30 +0000 (23:11 +0000)]
2011-06-27  Diego Gonzalez  <diegohcg@webkit.org>

    Reviewed by Kenneth Rohde Christiansen.

    [Qt] DRT support for setInteractiveFormValidationEnabled
    https://bugs.webkit.org/show_bug.cgi?id=63496

    Unskipped:
        fast/forms/interactive-validation-prevented.html
        fast/forms/interactive-validation-attach-assertion.html
        fast/forms/interactive-validation-assertion-by-validate-twice.html
        fast/forms/interactive-validation-select-crash.html
        fast/forms/interactive-validation-crash-by-style-override.html

    Source/WebKit/qt:

    * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
    (DumpRenderTreeSupportQt::setInteractiveFormValidationEnabled):
    * WebCoreSupport/DumpRenderTreeSupportQt.h:

    Tools:

    * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
    (WebCore::DumpRenderTree::DumpRenderTree):

    LayoutTests:

    * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 23:06:20 +0000 (23:06 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make new-run-webkit-tests -2 actually use WebKitTestRunner
        https://bugs.webkit.org/show_bug.cgi?id=63572

        new-run-webkit-tests -2 works with this change.  However a zillion
        tests fail since it can't find the right skipped lists for wk2.
        The Skipped-list fixing is covered in bug 63501.

        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 28 Jun 2011 22:41:36 +0000 (22:41 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Eric Seidel.

        Switch paintFillLayer* to new layout types
        https://bugs.webkit.org/show_bug.cgi?id=63570

        Switching painFillLayer* to layout type abstraction from more integral types.

        No new tests as this is just moving to an abstraction.

        * rendering/InlineFlowBox.cpp:
        (WebCore::InlineFlowBox::paintFillLayers):
        (WebCore::InlineFlowBox::paintFillLayer):
        * rendering/InlineFlowBox.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::paintFillLayers):
        (WebCore::RenderBox::paintFillLayer):
        * rendering/RenderBox.h:
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        * rendering/RenderBoxModelObject.h:
        * rendering/RenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Tue, 28 Jun 2011 22:33:06 +0000 (22:33 +0000)]
2011-06-28  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Use appropriate macro for CSSPropertyWebkitAppearance in CSSStyleSelector::applyProperty()
        https://bugs.webkit.org/show_bug.cgi?id=63197

        No new tests / no functionality changed.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Use HANDLE_INHERIT_AND_INITIAL_AND_PRIMITIVE macro and delete duplicate code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Cary Clark <caryclark@google.com>
commit-queue@webkit.org [Tue, 28 Jun 2011 22:27:15 +0000 (22:27 +0000)]
2011-06-28  Cary Clark  <caryclark@google.com>

        Reviewed by James Robinson.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        * wtf/Platform.h:
        Add switch to use Skia if, externally,
        Skia has been enabled by a gyp define.
2011-06-28  Cary Clark  <caryclark@google.com>

        Reviewed by James Robinson.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        No new tests. This does not affect existing
        functionality.

        * WebCore.gyp/WebCore.gyp:
        Include Skia and related files and exclude CG
        and related files when building Chromium for Skia
        on the Mac.

        * loader/cache/CachedFont.cpp:
        Rename CHROME to CHROMIUM.

        * platform/chromium/DragImageRef.h:
        * platform/graphics/FloatPoint.h:
        * platform/graphics/FloatRect.h:
        * platform/graphics/FloatSize.h:
        * platform/graphics/FontPlatformData.h:
        (WebCore::FontPlatformData::hash):
        * platform/graphics/GlyphBuffer.h:
        (WebCore::GlyphBuffer::advanceAt):
        (WebCore::GlyphBuffer::add):
        (WebCore::GlyphBuffer::expandLastAdvance):
        * platform/graphics/IntPoint.h:
        * platform/graphics/IntRect.h:
        * platform/graphics/IntSize.h:
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cg/FloatPointCG.cpp:
        * platform/graphics/cg/FloatRectCG.cpp:
        * platform/graphics/cg/FloatSizeCG.cpp:
        * platform/graphics/cg/IntPointCG.cpp:
        * platform/graphics/cg/IntRectCG.cpp:
        * platform/graphics/cg/IntSizeCG.cpp:
        * platform/graphics/mac/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::~FontCustomPlatformData):
        (WebCore::createFontCustomPlatformData):
        * platform/graphics/mac/FontCustomPlatformData.h:
        (WebCore::FontCustomPlatformData::FontCustomPlatformData):
        Ditto.
2011-06-28  Cary Clark  <caryclark@google.com>

        Reviewed by James Robinson.

        Use Skia if Skia on Mac Chrome is enabled
        https://bugs.webkit.org/show_bug.cgi?id=62999

        * WebKit.gyp:
        If building for Skia, exclude CG files.
        If not, exclude Skia files.

        * features.gypi:
        Enable Skia on Chromium Mac if so instructed by the gyp define.
        Allow Skia to be hardware accelerated on the Mac.

        * public/WebCommon.h:
        If Skia is defined on the Mac, define it in the WebXXX
        interfaces as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 28 Jun 2011 22:15:06 +0000 (22:15 +0000)]
2011-06-28  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium test update for r89951.

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-tref-03-b-change-href-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
        * platform/chromium-linux/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
        * platform/chromium-mac-leopard/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-change-href-expected.png: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
        * platform/chromium-win/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 28 Jun 2011 22:09:58 +0000 (22:09 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Roben.

        Add more machines to Chromium Mac Release and Chromium Mac Release (Tests)
        https://bugs.webkit.org/show_bug.cgi?id=63500

        Added google-mac-3 and google-mac-4.

        * BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 22:06:09 +0000 (22:06 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Dirk Pranke.

        Remove webkitpy's tiger support now that WebKit no longer supports tiger
        https://bugs.webkit.org/show_bug.cgi?id=63568

        I don't think our support actually fully worked anyway.  Regardless
        tiger is dead now (thankfully)!

        I also unwrapped some short lines and added a couple FIXMEs while
        touring the code.

        No new tests, only removing old ones which tested our Tiger support.

        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/builders.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/tool/commands/rebaseline.py:
        * Scripts/webkitpy/tool/commands/rebaselineserver_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 28 Jun 2011 21:51:36 +0000 (21:51 +0000)]
2011-06-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        ASSERT when launching debug builds with interpreter and jit enabled
        https://bugs.webkit.org/show_bug.cgi?id=63566

        Add appropriate guards to the various Executable's memory reporting
        logic.

        * runtime/Executable.cpp:
        (JSC::EvalExecutable::compileInternal):
        (JSC::ProgramExecutable::compileInternal):
        (JSC::FunctionExecutable::compileForCallInternal):
        (JSC::FunctionExecutable::compileForConstructInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 21:51:19 +0000 (21:51 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Unreviewed, just fixing a typo.

        Fix misspellings of "thead" to "thread".

        * Scripts/webkitpy/common/checkout/scm/git.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 21:44:17 +0000 (21:44 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests needs a --webkit-test-runner option
        https://bugs.webkit.org/show_bug.cgi?id=63439

        This was accidentally fixed in bug 63501 as well.
        The root problem here was that the webkit unit tests were not using
        enough mocks.  I've fixed them here to use more mocks
        which should unbreak windows.

        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=63563
barraclough@apple.com [Tue, 28 Jun 2011 21:33:38 +0000 (21:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63563
DFG JIT - add support for double arith to speculative path

Reviewed by Oliver Hunt.

Add integer support for div & mod, add double support for div, mod,
add, sub & mul, dynamically selecting based on operand types.

* dfg/DFGJITCodeGenerator.cpp:
(JSC::DFG::FPRTemporary::FPRTemporary):
* dfg/DFGJITCodeGenerator.h:
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::assembler):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculateDoubleOperand::SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::~SpeculateDoubleOperand):
(JSC::DFG::SpeculateDoubleOperand::index):
(JSC::DFG::SpeculateDoubleOperand::fpr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix interpreter build.
oliver@apple.com [Tue, 28 Jun 2011 21:18:31 +0000 (21:18 +0000)]
Fix interpreter build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 28 Jun 2011 21:13:25 +0000 (21:13 +0000)]
2011-06-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Use <QtX/x.h> style of headers for Qt tests which rely on it.
        https://bugs.webkit.org/show_bug.cgi?id=63562

        Some Qt auto-tests rely on <QtX/x.h> types of includes.

        * Api/qwebkitplatformplugin.h:
        * symbian/platformplugin/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=63561
barraclough@apple.com [Tue, 28 Jun 2011 21:06:49 +0000 (21:06 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=63561
DFG JIT - don't always assume integer in relational compare

Reviewed by Oliver Hunt.

If neither operand is known integer, or either is in double representation,
then at least use a function call (don't bail off the speculative path).

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleCall):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isDataFormatDouble):
(JSC::DFG::SpeculativeJIT::compareIsInteger):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake constant array optimisation less strict about what constitutes a constant
barraclough@apple.com [Tue, 28 Jun 2011 20:47:58 +0000 (20:47 +0000)]
Make constant array optimisation less strict about what constitutes a constant
https://bugs.webkit.org/show_bug.cgi?id=63554

Patch by Oliver Hunt <oliver@apple.com> on 2011-06-28
Reviewed by Gavin Barraclough.

Now allow string constants in array literals to actually be considered constant,
and so avoid codegen in array literals with strings in them.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::addConstantBuffer):
(JSC::CodeBlock::constantBuffer):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::addConstantBuffer):
(JSC::BytecodeGenerator::addStringConstant):
(JSC::BytecodeGenerator::emitNewArray):
* bytecompiler/BytecodeGenerator.h:
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 28 Jun 2011 20:34:25 +0000 (20:34 +0000)]
2011-06-28  Nate Chapin  <japhet@chromium.org>

        Unreviewed, chromium test update for r89946.

        * platform/chromium/fast/regex: Added.
        * platform/chromium/fast/regex/constructor-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Tue, 28 Jun 2011 20:21:37 +0000 (20:21 +0000)]
2011-06-28  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        Make constant array optimisation less strict about what constitutes a constant
        https://bugs.webkit.org/show_bug.cgi?id=63554

        Now allow string constants in array literals to actually be considered constant,
        and so avoid codegen in array literals with strings in them.

        * bytecode/CodeBlock.h:
        (JSC::CodeBlock::addConstantBuffer):
        (JSC::CodeBlock::constantBuffer):
        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::addConstantBuffer):
        (JSC::BytecodeGenerator::addStringConstant):
        (JSC::BytecodeGenerator::emitNewArray):
        * bytecompiler/BytecodeGenerator.h:
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        * jit/JITStubs.cpp:
        (JSC::DEFINE_STUB_FUNCTION):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 28 Jun 2011 20:09:55 +0000 (20:09 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Rolled DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 28 Jun 2011 20:07:31 +0000 (20:07 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Stop instantiating Position with PositionIsOffsetInAnchor in various files
        https://bugs.webkit.org/show_bug.cgi?id=63384

        Refactoring.

        Removed many if conditions that compared the anchor type to Position::PositionIsOffsetInAnchor
        because there were also checking that containerNode is a text node.

        Also added Position::containerText() to avoid manually casting containerNode().

        * dom/Position.cpp:
        (WebCore::Position::Position): Added an assertion to ensure BeforeChildren/AfterChildren
        anchor type won't be used for a node whose contents is ignored by editing.
        (WebCore::Position::containerText): Added.
        * dom/Position.h:
        * editing/ApplyBlockElementCommand.cpp:
        (WebCore::isNewLineAtPosition): Removed a redundant comparison of anchor type.
        (WebCore::ApplyBlockElementCommand::rangeForParagraphSplittingTextNodesIfNeeded): Since containerNode
        is always a text node when renderStyleOfEnclosingTextNode returns a render style, use new Position
        constructor that takes Text* and offset.
        (WebCore::ApplyBlockElementCommand::endOfNextParagrahSplittingTextNodesIfNeeded): Removed redundant
        comparison of anchor type and use new Position constructor that takes Text* and offset.
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::splitTextAtStart): Replaced an assertion that compared anchor type by
        an assertion that the container node is a text node; use new constructor.
        (WebCore::ApplyStyleCommand::splitTextAtEnd): Ditto; also added early exits in the case script
        modified DOM.
        (WebCore::ApplyStyleCommand::splitTextElementAtStart): Ditto.
        (WebCore::ApplyStyleCommand::splitTextElementAtEnd): Ditto.
        (WebCore::ApplyStyleCommand::joinChildTextNodes): Use new constructor.
        * editing/CompositeEditCommand.cpp:
        (WebCore::Editor::replaceSelectedTextInNode): Calls containerText instead of manually casting containerNode.
        * editing/Editor.cpp:
        (WebCore::Editor::canDeleteRange): Call Range::startPosition instead of manually instantiating Position
        by calling startContainer and startOffset.
        * editing/FrameSelection.cpp:
        (WebCore::FrameSelection::setSelectedRange): Ditto.
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::input): Calls containerText instead of manually casting containerNode.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply): Calls containerText instead of manually casting containerNode.
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::characterAfter): Removed a redundant anchor type comparison.
        (WebCore::startVisiblePosition): Call Range::startPosition instead of startContainer and startOffset.
        (WebCore::endVisiblePosition): Call Range::endPosition instead of endContainer and endOffset.
        * editing/htmlediting.cpp:
        (WebCore::firstInSpecialElement): Call containerNode() to address <rdar://problem/5027702>.
        (WebCore::lastInSpecialElement): Ditto; use new constructor.
        * editing/visible_units.cpp:
        (WebCore::endPositionForLine): Use new constructor.
        (WebCore::startOfParagraph): Ditto.
        (WebCore::endOfParagraph): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Tue, 28 Jun 2011 20:04:05 +0000 (20:04 +0000)]
2011-06-28  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        SVG1.1SE test text-tref-03-b.svg fails
        https://bugs.webkit.org/show_bug.cgi?id=63390

        Support tref on forward referenced content by listening to DOMSubtreeModified events. This also
        allows updating after modifications in the referenced content subtree.

        Tests: svg/W3C-SVG-1.1-SE/text-tref-03-b.svg
               svg/custom/text-tref-03-b-change-href-dom.svg
               svg/custom/text-tref-03-b-change-href.svg
               svg/custom/text-tref-03-b-dynamic.svg
               svg/custom/text-tref-03-b-dynamic2.svg
               svg/custom/text-tref-03-b-referenced-element-removal.svg
               svg/custom/text-tref-03-b-tref-removal.svg

        * svg/SVGTRefElement.cpp:
        (WebCore::SubtreeModificationEventListener::create):
        (WebCore::SubtreeModificationEventListener::cast):
        (WebCore::SubtreeModificationEventListener::removeFromTarget):
        (WebCore::SubtreeModificationEventListener::SubtreeModificationEventListener):
        (WebCore::SubtreeModificationEventListener::operator==):
        (WebCore::SubtreeModificationEventListener::handleEvent):
        (WebCore::SVGTRefElement::updateReferencedText):
        (WebCore::SVGTRefElement::parseMappedAttribute):
        (WebCore::SVGTRefElement::svgAttributeChanged):
        (WebCore::SVGTRefElement::buildPendingResource):
        (WebCore::SVGTRefElement::removedFromDocument):
        * svg/SVGTRefElement.h:
2011-06-28  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        SVG1.1SE test text-tref-03-b.svg fails
        https://bugs.webkit.org/show_bug.cgi?id=63390

        - text-tref-03-b.svg, the w3c SVG1.1 testcase mentioned in the bug.
        - text-tref-03-b-dynamic.svg, tests dynamically adding the tref.
        - text-tref-03-b-dynamic2.svg, tests dynamically adding the referenced content.
        - text-tref-03-b-tref-removal.svg, tests removal of tref.
        - text-tref-03-b-referenced-element-removal.svg, tests removal of referenced content.
        - text-tref-03-b-change-href.svg, tests changing href attribute dynamically through setAttribute.
        - text-tref-03-b-change-href-dom.svg, tests changing href attribute dynamically through href animated property.
        - foreignObject/text-tref-02-b.svg has improved result, but is still not perfect.

        * platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.png: Added.
        * platform/mac/svg/W3C-SVG-1.1-SE/text-tref-03-b-expected.txt: Added.
        * platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.png: Added.
        * platform/mac/svg/custom/text-tref-03-b-change-href-dom-expected.txt: Added.
        * platform/mac/svg/custom/text-tref-03-b-change-href-expected.png: Added.
        * platform/mac/svg/custom/text-tref-03-b-change-href-expected.txt: Added.
        * platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.png: Added.
        * platform/mac/svg/custom/text-tref-03-b-referenced-element-removal-expected.txt: Added.
        * platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.png: Added.
        * platform/mac/svg/custom/text-tref-03-b-tref-removal-expected.txt: Added.
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
        * platform/mac/svg/foreignObject/text-tref-02-b-expected.txt:
        * svg/W3C-SVG-1.1-SE/text-tref-03-b.svg: Added.
        * svg/custom/text-tref-03-b-change-href-dom.svg: Added.
        * svg/custom/text-tref-03-b-change-href.svg: Added.
        * svg/custom/text-tref-03-b-dynamic-expected.txt: Added.
        * svg/custom/text-tref-03-b-dynamic.svg: Added.
        * svg/custom/text-tref-03-b-dynamic2-expected.txt: Added.
        * svg/custom/text-tref-03-b-dynamic2.svg: Added.
        * svg/custom/text-tref-03-b-referenced-element-removal.svg: Added.
        * svg/custom/text-tref-03-b-tref-removal.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 28 Jun 2011 19:37:07 +0000 (19:37 +0000)]
2011-06-28  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Anders Carlsson.

        Split the string creation into a local (while creating text runs)
        so that it is not destroyed prematurely.
        https://bugs.webkit.org/show_bug.cgi?id=63543

        Run fast/forms/text-control-intrinsic-widths.html under valgrind/ASAN.
        * rendering/RenderFileUploadControl.cpp:
        (WebCore::RenderFileUploadControl::computePreferredLogicalWidths):
        this one is just done for caution, in case, we don't do the same
        mistake when adding legacy rounding hacks option.
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::getAvgCharWidth):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 28 Jun 2011 19:33:27 +0000 (19:33 +0000)]
2011-06-28  Eric Seidel  <eric@webkit.org>

        Reviewed by Tony Chang.

        new-run-webkit-tests should not run mthml tests when MHTML support is disabled
        https://bugs.webkit.org/show_bug.cgi?id=63549

        This way mhtml tests won't show up as "missing" results on all non-chromium platforms.
        I happen to go looking for what code was deciding that .mht was a supported
        extension, found test_files.py and then removed some redundant doc-strings and
        if branching.

        * Scripts/webkitpy/layout_tests/port/test_files.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Greg Simon <gregsimon@chromium.org>
commit-queue@webkit.org [Tue, 28 Jun 2011 19:19:33 +0000 (19:19 +0000)]
2011-06-28  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Update migration LayoutTest to include indexes and successful migration.
        https://bugs.webkit.org/show_bug.cgi?id=62780

        * storage/indexeddb/migrate-basics-expected.txt:
        * storage/indexeddb/migrate-basics.html:
2011-06-28  Greg Simon  <gregsimon@chromium.org>

        Reviewed by Dimitri Glazkov.

        Migrate SQLite backing store to LevelDB backing store for Indexeddb.
        https://bugs.webkit.org/show_bug.cgi?id=62780

        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::computeFileIdentifier):
        (WebCore::computeUniqueIdentifier):
        (WebCore::IDBFactoryBackendImpl::open):
        (WebCore::migrateObjectStores):
        (WebCore::IDBFactoryBackendImpl::migrateFromSQLiteToLevelDB):
        * storage/IDBLevelDBBackingStore.cpp:
        (WebCore::IDBLevelDBBackingStore::backingStoreExists):
        * storage/IDBLevelDBBackingStore.h:
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::populateIndex):
        * storage/IDBObjectStoreBackendImpl.h:
        * storage/IDBSQLiteBackingStore.cpp:
        (WebCore::IDBSQLiteBackingStore::backingStoreExists):
        * storage/IDBSQLiteBackingStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Chang Shu <cshu@webkit.org>
commit-queue@webkit.org [Tue, 28 Jun 2011 19:01:29 +0000 (19:01 +0000)]
2011-06-28  Chang Shu  <cshu@webkit.org>

        Reviewed by Andreas Kling.

        [Qt][WK2] Random crashes in fast/frames/ tests
        https://bugs.webkit.org/show_bug.cgi?id=63459

        Investigation on the crashes has revealed that sometimes, a frame could
        have been destroyed before it is removed from the hierachy in Qt WebKit2 UI process.
        The root cause lies in the fact that the order of the two contiguous asynchronous
        messages may not be respected on the receiving side. And it is Qt's implementation,
        which uses QTimer::startTimer(0), that causes the reverse order. This patch replaces
        the timer approach with QMetaObject::invokeMethod approach and no crash happens afterwards.

        * Platform/qt/WorkQueueQt.cpp:
        (WorkQueue::scheduleWork):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=55040
barraclough@apple.com [Tue, 28 Jun 2011 18:35:37 +0000 (18:35 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55040
RegExp constructor returns the argument regexp instead of a new object

Reviewed by Oliver Hunt.

Per 15.10.3.1, our current behaviour is correct if called as a function,
but incorrect when called as a constructor.

Source/JavaScriptCore:

* runtime/RegExpConstructor.cpp:
(JSC::constructRegExp):
(JSC::constructWithRegExpConstructor):
* runtime/RegExpConstructor.h:

LayoutTests:

* fast/regex/constructor-expected.txt: Added.
* fast/regex/constructor.html: Added.
* fast/regex/script-tests/constructor.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Tue, 28 Jun 2011 18:31:19 +0000 (18:31 +0000)]
2011-06-28  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Darin Adler.

        Create intermediate classes as a path towards getting off of pixel offsets
        https://bugs.webkit.org/show_bug.cgi?id=61896

        Creating three intermediate typedefs to aid in moving layout and hit testing from integers
        to floats. We'll transition the render tree over to these intermediate types and add
        infrastructure to support the new types behind USE(FLOAT_LAYOUT_OFFSETS). This allows the ultimate
        changeover to be easier.

        Switching LayoutState over to this abstraction to verify it works correctly.

        No new tests since this is creating a new abstraction, not changing current behavior.

        * GNUmakefile.list.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState):
        (WebCore::LayoutState::pageLogicalOffset):
        (WebCore::LayoutState::addForcedColumnBreak):
        * rendering/LayoutState.h:
        * rendering/LayoutTypes.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Tue, 28 Jun 2011 18:29:17 +0000 (18:29 +0000)]
2011-06-28  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Tony Chang.

        Fix filesystem_unittest.FileSystemTest test_read_and_write_file()
        https://bugs.webkit.org/show_bug.cgi?id=63514

        - change write_text_file to write_binary_file
        - check that text_path and binary_path are actually existant files
        - change cleanup block from 'except' to 'finally'

        * Scripts/webkitpy/common/system/filesystem_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Tue, 28 Jun 2011 18:26:06 +0000 (18:26 +0000)]
2011-06-28  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Darin Adler.

        Clean up integer clamping functions in MathExtras.h and support arbitrary numeric types and limits.
        https://bugs.webkit.org/show_bug.cgi?id=63469

        * wtf/MathExtras.h:
        (defaultMinimumForClamp):
        Version of std::numeric_limits::min() that returns the largest negative value for floating point types.
        (defaultMaximumForClamp):
        Symmetric alias for std::numeric_limits::max()
        (clampTo):
        New templated clamping function that supports arbitrary output types.
        (clampToInteger):
        Use new clampTo template.
        (clampToFloat):
        Use new clampTo template.
        (clampToPositiveInteger):
        Use new clampTo template.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd fullscreen.css and fullscreenQuickTime.css to the WebCore Visual Studio project...
jeffm@apple.com [Tue, 28 Jun 2011 18:24:06 +0000 (18:24 +0000)]
Add fullscreen.css and fullscreenQuickTime.css to the WebCore Visual Studio project for convenience.
Looks like Visual Studio also re-sorted one more file since my last checkin.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRe-sort the WebCore project with Visual Studio after recent changes that I assume...
jeffm@apple.com [Tue, 28 Jun 2011 18:21:15 +0000 (18:21 +0000)]
Re-sort the WebCore project with Visual Studio after recent changes that I assume were done by manually editing the XML.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Tue, 28 Jun 2011 17:55:38 +0000 (17:55 +0000)]
2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Rename 3D transforms to 3D rendering
        https://bugs.webkit.org/show_bug.cgi?id=63508

        WebKitGtk+ provides the 3D transforms feature, but it was
        renamed to 3D Rendering. This features supports CSS 3D trasnforms.

        * configure.ac: Rename ENABLE_3D_TRANSFORMS to ENABLE_3D_RENDERING.
2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Rename 3D transforms to 3D rendering
        https://bugs.webkit.org/show_bug.cgi?id=63508

        This patch allows to include ENABLE_3D_RENDERING to build WebKitGtk+.

        * GNUmakefile.am: Add ENABLE_3D_RENDERING

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 James Hawkins <jhawkins@chromium.org>
jhawkins@chromium.org [Tue, 28 Jun 2011 16:58:00 +0000 (16:58 +0000)]
2011-06-27  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Pass an optional WebNode that is the node receiving the context menu action.
        https://bugs.webkit.org/show_bug.cgi?id=63503

        * public/WebFrame.h:
        * src/WebFrameImpl.cpp:
        (WebKit::pluginContainerFromNode):
        (WebKit::WebFrameImpl::executeCommand):
        (WebKit::WebFrameImpl::printBegin):
        * src/WebFrameImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-22 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 28 Jun 2011 16:48:59 +0000 (16:48 +0000)]
2011-06-22  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: use column numbers when linking to script location in timeline and console.
        https://bugs.webkit.org/show_bug.cgi?id=63126

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleMessage.prototype._populateStackTraceTreeElement):
        * inspector/front-end/TimelinePanel.js:
        (WebInspector.TimelinePanel.FormattedRecord.prototype._getRecordDetails):
        (WebInspector.TimelinePanel.PopupContentHelper.prototype._appendStackTrace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Joone Hur <joone.hur@collabora.co.uk>
joone.hur@collabora.co.uk [Tue, 28 Jun 2011 16:27:46 +0000 (16:27 +0000)]
2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Allow to build WebKitGtk+ with accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=63404

        WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
        and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.

        * GNUmakefile.list.am:
        * platform/graphics/clutter/GraphicsLayerClutter.cpp: Added.
        (WebCore::GraphicsLayer::create): Not implemented yet.
        (WebCore::GraphicsLayerClutter::GraphicsLayerClutter):
        (WebCore::GraphicsLayerClutter::~GraphicsLayerClutter):
        (WebCore::GraphicsLayerClutter::setNeedsDisplay): Ditto.
        (WebCore::GraphicsLayerClutter::setNeedsDisplayInRect): Ditto.
        * platform/graphics/clutter/GraphicsLayerClutter.h: Added.
2011-06-28  Joone Hur  <joone.hur@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] Allow to build WebKitGtk+ with accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=63404

        WebKitGtk+ needs to implement accelerated compositing for running CSS3 3D transforms
        and animation through GPU acceleration. We could implement GraphicsLayer using Clutter.

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::attachRootGraphicsLayer): not implemented yet.
        (WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization): Ditto.
        (WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.
        (WebKit::ChromeClient::allowedCompositingTriggers): Ditto.
        * WebCoreSupport/ChromeClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBetter Windows rebaseline for the changes in r89864, with pixel results, to get the...
jberlin@webkit.org [Tue, 28 Jun 2011 16:23:46 +0000 (16:23 +0000)]
Better Windows rebaseline for the changes in r89864, with pixel results, to get the bots
green.

* platform/win/fast/text/international/unicode-bidi-plaintext-expected.png: Added.
* platform/win/fast/text/international/unicode-bidi-plaintext-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKitTestRunner needs to implement undo client (Windows).
jberlin@webkit.org [Tue, 28 Jun 2011 16:08:26 +0000 (16:08 +0000)]
WebKitTestRunner needs to implement undo client (Windows).
https://bugs.webkit.org/show_bug.cgi?id=58103

Add another undo test to the win-wk2 skipped list to get the bots green.

* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 28 Jun 2011 16:01:33 +0000 (16:01 +0000)]
2011-06-28  Stephen White  <senorblanco@chromium.org>

        Unreviewed.

        Remove some now-passing tests from Chromium's test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION (r89733): fast/text/zero-font-size.html is failing on Leopard
mitz@apple.com [Tue, 28 Jun 2011 15:56:42 +0000 (15:56 +0000)]
REGRESSION (r89733): fast/text/zero-font-size.html is failing on Leopard
https://bugs.webkit.org/show_bug.cgi?id=63512

Reviewed by Darin Adler.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::platformWidthForGlyph): Initialize the advance local variable, because
on Leopard wkGetGlyphTransformedAdvances can return successfully yet not update the variable when
the font size is 0. Presumably, r89733 exposed this by changing the values put on the stack just
before this function is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Brent Fulgham <bfulgham@webkit.org>
bfulgham@webkit.org [Tue, 28 Jun 2011 15:42:04 +0000 (15:42 +0000)]
2011-06-27  Brent Fulgham  <bfulgham@webkit.org>

        Reviewed by Adam Roben.

        Avoid attempt to create a zero-size DIB.
        https://bugs.webkit.org/show_bug.cgi?id=63484.

        * WebNodeHighlight.cpp:
        (WebNodeHighlight::update): Check for zero-height (or zero-width)
        region for DIB, and exit early if attempting to create a zero-size
        DIB/BITMAP.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-24 Vsevolod Vlasov <vsevik@chromium.org>
caseq@chromium.org [Tue, 28 Jun 2011 15:24:19 +0000 (15:24 +0000)]
2011-06-24  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        REGRESSION (r89449): http/tests/inspector/extensions-resources-redirect.html failing on SnowLeopard Intel Release (Tests), Windows 7 Release (Tests), Qt
        https://bugs.webkit.org/show_bug.cgi?id=63178

        * http/tests/inspector/extensions-resources-redirect-expected.txt:
        * platform/mac/http/tests/inspector/extensions-resources-redirect-expected.txt: Removed.
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 28 Jun 2011 15:15:01 +0000 (15:15 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Fix the test added by the previous commit. Also add it to the WebKit2's skipped list
        since it uses a eventSender method that hasn't been implemented by TestRunner.

        * fast/events/selectstart-prevent-selection-on-right-click.html:
        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 28 Jun 2011 15:09:11 +0000 (15:09 +0000)]
2011-06-28  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        Add a test for canceling selectstart when a word is selected by right click
        https://bugs.webkit.org/show_bug.cgi?id=63530

        Add a regression now that the bug no longer reproduces.

        * fast/events/selectstart-prevent-selection-on-right-click-expected.txt: Added.
        * fast/events/selectstart-prevent-selection-on-right-click.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Tue, 28 Jun 2011 14:51:44 +0000 (14:51 +0000)]
2011-06-28  Stephen White  <senorblanco@chromium.org>

        Unreviewed.

        Chromium test_expectations update.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows Debug build fix after r89885
aroben@apple.com [Tue, 28 Jun 2011 14:39:36 +0000 (14:39 +0000)]
Windows Debug build fix after r89885

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def: Exported
JSGlobalData::releaseExecutableMemory for jsc.exe's benefit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll out r89924 and r89925
aroben@apple.com [Tue, 28 Jun 2011 14:39:06 +0000 (14:39 +0000)]
Roll out r89924 and r89925

I didn't mean to commit them!

* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/LayoutTestHistoryAnalyzer.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/Utilities.js:
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/ViewController.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoKeep track of all builds
aroben@apple.com [Tue, 28 Jun 2011 14:34:34 +0000 (14:34 +0000)]
Keep track of all builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStart categorizing flaky tests
aroben@apple.com [Tue, 28 Jun 2011 14:33:39 +0000 (14:33 +0000)]
Start categorizing flaky tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Alexis Menard <alexis.menard@openbossa.org>
alexis.menard@openbossa.org [Tue, 28 Jun 2011 14:22:44 +0000 (14:22 +0000)]
2011-06-28  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Andreas Kling.

        [Qt] Use QtQuick imports in Api tests rather than old deprecated Qt 4.x imports.
        https://bugs.webkit.org/show_bug.cgi?id=63533

        We need to use the new QtQuick 1.x imports rather than the old deprecated
        version.

        * tests/qdeclarativewebview/resources/webviewbackgroundcolor.qml:
        * tests/qdeclarativewebview/resources/webviewtest.qml:
        * tests/qdeclarativewebview/resources/webviewtestdefault.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 28 Jun 2011 12:07:48 +0000 (12:07 +0000)]
2011-06-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
        https://bugs.webkit.org/show_bug.cgi?id=63446

        * inspector/styles/get-set-stylesheet-text.html:
        * inspector/styles/styles-new-API.html:
        * inspector/styles/styles-source-offsets.html:
2011-06-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Change the inspector model API and backend to allow CSS pseudoclass inspection
        https://bugs.webkit.org/show_bug.cgi?id=63446

        * inspector/Inspector.json:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::computePseudoClassMask):
        (WebCore::InspectorCSSAgent::getStylesForNode):
        * inspector/InspectorCSSAgent.h:
        * inspector/front-end/AuditRules.js:
        (WebInspector.AuditRules.ImageDimensionsRule.prototype.doRun.getStyles):
        * inspector/front-end/CSSStyleModel.js:
        (WebInspector.CSSStyleModel.prototype.getStylesAsync):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Tue, 28 Jun 2011 11:42:33 +0000 (11:42 +0000)]
2011-06-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [X11][WK2] X error with plugin tests
        https://bugs.webkit.org/show_bug.cgi?id=63520

        * platform/qt-wk2/Skipped:
2011-06-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [X11][WK2] X error with plugin tests
        https://bugs.webkit.org/show_bug.cgi?id=63520

        * WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
        Never create a pixmap with (0,0) dimensions.
        (WebKit::NetscapePlugin::platformGeometryDidChange):
        (WebKit::NetscapePlugin::platformPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Michal Pakula vel Rutka <m.pakula@samsung.com>
commit-queue@webkit.org [Tue, 28 Jun 2011 11:38:05 +0000 (11:38 +0000)]
2011-06-28  Michal Pakula vel Rutka  <m.pakula@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Implement EditorClientEfl::respondToChangedSelection
        https://bugs.webkit.org/show_bug.cgi?id=63525

        This patch:
        - implements EditorClientEfl::respondToChangedSelection,
        - adds ewk_frame_editor_client_selection_changed and
        - ewk_view_editor_client_selection_changed

        * WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::respondToChangedSelection):
        * ewk/ewk_frame.cpp:
        (ewk_frame_editor_client_selection_changed):
        * ewk/ewk_private.h:
        * ewk/ewk_view.cpp:
        (ewk_view_editor_client_selection_changed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 28 Jun 2011 09:59:11 +0000 (09:59 +0000)]
2011-06-28  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        Verify cloning elements with validation messages works.
        https://bugs.webkit.org/show_bug.cgi?id=61988

        * fast/forms/validation-message-clone-expected.txt: Added.
        * fast/forms/validation-message-clone.html: Added.
        * platform/gtk/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Wyatt Carss <wcarss@chromium.org>
commit-queue@webkit.org [Tue, 28 Jun 2011 09:54:48 +0000 (09:54 +0000)]
2011-06-28  Wyatt Carss  <wcarss@chromium.org>

        Reviewed by Hajime Morita.

        convert editing/deleting/4845371.html to runDumpAsTextEditingTest
        https://bugs.webkit.org/show_bug.cgi?id=63214

        Renamed editing/deleting/4845371.html to editing/deleting/delete-cell-contents.html
        and converted editing/deleting/delete-cell-contents.html to runDumpAsTextEditingTest; left
        it without a doctype, etc, because they changed functionality of the image test. Also
        added the rdar number.

        * editing/deleting/delete-cell-contents-expected.txt: Added.
        * editing/deleting/delete-cell-contents.html: Added.
        * editing/deleting/4845371.html: Removed.
        * platform/chromium-linux/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-mac-leopard/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-win/editing/deleting/4845371-expected.png: Removed.
        * platform/chromium-win/editing/deleting/4845371-expected.txt: Removed.
        * platform/gtk/editing/deleting/4845371-expected.png: Removed.
        * platform/gtk/editing/deleting/4845371-expected.txt: Removed.
        * platform/mac-leopard/editing/deleting/4845371-expected.png: Removed.
        * platform/mac/editing/deleting/4845371-expected.png: Removed.
        * platform/mac/editing/deleting/4845371-expected.txt: Removed.
        * platform/qt/editing/deleting/4845371-expected.png: Removed.
        * platform/qt/editing/deleting/4845371-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 28 Jun 2011 09:53:04 +0000 (09:53 +0000)]
2011-06-28  Kent Tamura  <tkent@chromium.org>

        Fix a build error on Mac by r89907.

        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::endListChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Tue, 28 Jun 2011 09:52:10 +0000 (09:52 +0000)]
2011-06-27  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Kent Tamura.

        [Chromium] SELECT or autofill popup is trimmed by screen edge on Windows
        https://bugs.webkit.org/show_bug.cgi?id=63438

        If the popup is calculated to be trimmed by a screen edge, an attempt is made
        to alter its vertical edge alignment (set to the right edge for LTR or to the left edge for RTL)
        to see if the trimmed portion becomes smaller than that with the original layout.
        The change involves remembering the original frameRect for the popup and restoring it in refresh().
        This is due to the fact that the frameRect originally set in showInRect() is overwritten
        by layoutAndGetRTLOffset(), which breaks the originally requested popup container layout metrics.
        The max width is reset on every layoutAndCalculateWidgetRect(), as it can be constrained by the screen edge,
        and thus should be re-checked every time the popup is displayed, in case the browser window has been moved.

        Tests: manual-tests/popup-width-restriction-within-screen.html partly covers the fix (should not regress).
        Other than that, there is no way to unit-test the platform-specific native code.

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupListBox::setMaxWidth): Added. Avoid duplicate popup content layouts (in contrast with setMaxWidthAndLayout()).
        (WebCore::PopupListBox::PopupListBox):
        (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Attempt a left-right popup alignment inversion
        to minimize the trimmed content. Also restore a default max popup width.
        (WebCore::PopupContainer::layoutAndGetRTLOffset): Always return the popup listbox offset for the RTL (right alignment) case.
        The method rename is due to the return value semantics change.
        (WebCore::PopupContainer::showInRect): Store the originally requested frameRect for the popup.
        (WebCore::PopupContainer::refresh): Restore the original popup frameRect to avoid layout artifacts on refresh.
        (WebCore::PopupContainer::isRTL): This check should be made by the layoutAndGetRTLOffset() clients.
        * platform/chromium/PopupMenuChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Kentaro Hara <haraken@google.com>
commit-queue@webkit.org [Tue, 28 Jun 2011 09:46:08 +0000 (09:46 +0000)]
2011-06-28  Kentaro Hara  <haraken@google.com>

        Reviewed by Kent Tamura.

        Allow spaces between e-mail addresses in 'email' input type.
        https://bugs.webkit.org/show_bug.cgi?id=55987

        Allowed spaces between e-mail addresses in 'email' input type,
        e.g. ' a@p.com , b@p.com ' is a valid value. Implemented the
        value sanitization algorithm for an e-mail value.  Added more unit
        tests that check the e-mail value parser.

        * fast/forms/ValidityState-typeMismatch-email-expected.txt:
        * fast/forms/resources/ValidityState-typeMismatch-email.js:
2011-06-28  Kentaro Hara  <haraken@google.com>

        Reviewed by Kent Tamura.

        Allow spaces between e-mail addresses in 'email' input type.
        https://bugs.webkit.org/show_bug.cgi?id=55987

        Allowed spaces between e-mail addresses in 'email' input type,
        e.g. ' a@p.com , b@p.com ' is a valid value. Implemented the
        value sanitization algorithm for an e-mail value.  Added more unit
        tests that check the e-mail value parser.

        Test: fast/forms/ValidityState-typeMismatch-email.html

        * html/EmailInputType.cpp:
        (WebCore::EmailInputType::typeMismatchFor):
        (WebCore::EmailInputType::sanitizeValue):
        * html/EmailInputType.h:
        * html/parser/HTMLParserIdioms.cpp:
        (WebCore::stripHTMLLineBreaks):
        * html/parser/HTMLParserIdioms.h:
        (WebCore::isHTMLLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoQt specific results committed in r89901, but some of them fail on Qt-WK2 and/or Qt...
ossy@webkit.org [Tue, 28 Jun 2011 09:44:49 +0000 (09:44 +0000)]
Qt specific results committed in r89901, but some of them fail on Qt-WK2 and/or Qt-Mac platform

* platform/qt-mac/Skipped: Skip failing tests and typo fix.
* platform/qt-wk2/Skipped: Skip failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 28 Jun 2011 09:30:58 +0000 (09:30 +0000)]
2011-06-28  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        Refactor RenderTextControl::text().
        https://bugs.webkit.org/show_bug.cgi?id=63519

        No new tests because this is just a refactoring.

        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::setInnerTextValue):
         Resuce the number of text() calls.
        (WebCore::finishText):
          - Use StringBuilder.
          - Make this a static function.
            This function doesn't access anything of RenderTextControl.
        (WebCore::RenderTextControl::text):
         Use emptyString() and StringBuilder.
        (WebCore::RenderTextControl::textWithHardLineBreaks): ditto.
        * rendering/RenderTextControl.h: Remove finishText().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 28 Jun 2011 09:28:20 +0000 (09:28 +0000)]
2011-06-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: console.group messages should never be coalesced
        https://bugs.webkit.org/show_bug.cgi?id=63521

        * inspector/console/console-nested-group-expected.txt:
        * inspector/console/console-nested-group.html:
2011-06-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: console.group messages should never be coalesced
        https://bugs.webkit.org/show_bug.cgi?id=63521

        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::isGroupMessage):
        (WebCore::InspectorConsoleAgent::addConsoleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 28 Jun 2011 09:26:07 +0000 (09:26 +0000)]
2011-06-28  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: console group boundaries should be more distinct in UI
        https://bugs.webkit.org/show_bug.cgi?id=63455

        Show grey bracket to on the left side of a console group message to highlight
        the group extent.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleGroup):
        * inspector/front-end/inspector.css:
        (#console-prompt):
        (.console-message, .console-user-command):
        (.console-message::before, .console-user-command::before, #console-prompt::before, .console-group-title::before):
        (.console-group-title::before):
        (.console-group):
        (.console-group-bracket):
        (.console-group.collapsed > .console-group-bracket):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 28 Jun 2011 09:20:58 +0000 (09:20 +0000)]
2011-06-28  Kent Tamura  <tkent@chromium.org>

        Reviewed by Hajime Morita.

        Use RefPtr for the HTMLElement data members of TextFieldInptType
        and SearchInputType.
        https://bugs.webkit.org/show_bug.cgi?id=63511

        No new tests because of no behavior change.

        * html/SearchInputType.cpp:
        (WebCore::SearchInputType::SearchInputType):
        No need to initialize the element members explicitly because
        RefPtr constructor works well.
        (WebCore::SearchInputType::createShadowSubtree):
        Substitute an element to a data member, and don't call RefPtr<>::release().
        (WebCore::SearchInputType::innerBlockElement):
        Moved from the header file, and adjustment for RefPtr<>.
        (WebCore::SearchInputType::resultsButtonElement): ditto.
        (WebCore::SearchInputType::cancelButtonElement): ditto.
        (WebCore::SearchInputType::destroyShadowSubtree):
         Adjustment for RefPtr<>.
        * html/SearchInputType.h:
         - Move accessor functions to the cpp file because they are virtual.
         - Change element data member types: HTMLElement* -> RefPtr<HTMLElement>.
        * html/TextFieldInputType.cpp:
        (WebCore::TextFieldInputType::TextFieldInputType):
        No need to initialize the element members explicitly because
        RefPtr constructor works well.
        (WebCore::TextFieldInputType::~TextFieldInputType):
        Explicityly defines the destructor in the cpp file to avoid to
        make it implicitly in the header file. If the destructor was made
        in the header file, we would need to include HTMLElement.h in the
        header file.
        (WebCore::TextFieldInputType::createShadowSubtree):
        - Don't call RenderTheme::themeForPage().
        - Substitute an element to a data member, and don't call RefPtr<>::release().
        (WebCore::TextFieldInputType::setInnerTextElement):
         Moved from the header file to avoid to include HTMLElement.h.
        (WebCore::TextFieldInputType::setSpeechButtonElement): ditto.
        (WebCore::TextFieldInputType::innerTextElement):
        Moved from the header file, and adjustment for RefPtr<>.
        (WebCore::TextFieldInputType::innerSpinButtonElement): ditto.
        (WebCore::TextFieldInputType::speechButtonElement): ditto.
        (WebCore::TextFieldInputType::destroyShadowSubtree):
         Adjustment for RefPtr<>.
        * html/TextFieldInputType.h:
         - Move accessor functions to the cpp file because they are virtual.
         - Change element data member types: HTMLElement* -> RefPtr<HTMLElement>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Pavel Feldman <pfeldman@google.com>
pfeldman@chromium.org [Tue, 28 Jun 2011 09:19:58 +0000 (09:19 +0000)]
2011-06-28  Pavel Feldman  <pfeldman@google.com>

        Not reviewed: added chromium test suppression.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Tue, 28 Jun 2011 09:12:14 +0000 (09:12 +0000)]
2011-06-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [X11][WK2] plugins/plugin-javascript-access fails
        https://bugs.webkit.org/show_bug.cgi?id=63464

        * platform/qt-wk2/Skipped:
2011-06-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [X11][WK2] plugins/plugin-javascript-access fails
        https://bugs.webkit.org/show_bug.cgi?id=63464

        * Shared/Plugins/Netscape/x11/NetscapePluginModuleX11.cpp:
        (WebKit::NetscapePluginModule::getPluginInfo):
        Determine the name of the plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Felician Marton <marton.felician.zoltan@stud.u-szeged.hu>
commit-queue@webkit.org [Tue, 28 Jun 2011 08:58:29 +0000 (08:58 +0000)]
2011-06-28  Felician Marton  <marton.felician.zoltan@stud.u-szeged.hu>

        Reviewed by Nikolas Zimmermann.

        SVG animation flickers when restarting
        https://bugs.webkit.org/show_bug.cgi?id=18450

        Add new parameter to the following methods. The new parameter is the time of adding a "begin" or "end" time to the SVG animation.
         - WebCore::SVGSMILElement::addBeginTime
         - WebCore::SVGSMILElement::beginListChanged
         - WebCore::SVGSMILElement::addEndTime
         - WebCore::SVGSMILElement::endListChanged
        In case of beginTime and beginListChanged it's necessary, because the delay between the event of adding a new begin time
        (in WebCore::SVGAnimationElement::beginElementAt) and the actual processing (in WebCore::SVGSMILElement::endListChanged)
        is significant. In lack of event time we can't decide that we should consider the new time or not.
        If the new begin time is smaller than the event time, we musn't begin the animation, else we shoud do further calculations.

        The following methods just modified for consistency:
         - WebCore::SVGSMILElement::addEndTime
         - WebCore::SVGSMILElement::endListChanged

        No new tests, because currently there is no way to test SVG flickering at zero time.

        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::beginElementAt):
        (WebCore::SVGAnimationElement::endElementAt):
        * svg/animation/SVGSMILElement.cpp:
        (WebCore::SVGSMILElement::attributeChanged):
        (WebCore::SVGSMILElement::addBeginTime):
        (WebCore::SVGSMILElement::addEndTime):
        (WebCore::SVGSMILElement::beginListChanged):
        (WebCore::SVGSMILElement::endListChanged):
          The body changed:
           - Use new parameter, the time of adding the new begin time.
           - Cancel some incorrect optimalization. We should also do further calculations when elapsed >= m_intervalBegin.
        (WebCore::SVGSMILElement::createInstanceTimesFromSyncbase):
        (WebCore::SVGSMILElement::handleConditionEvent):
        (WebCore::SVGSMILElement::beginByLinkActivation):
        * svg/animation/SVGSMILElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Shinya Kawanaka <shinyak@google.com>
commit-queue@webkit.org [Tue, 28 Jun 2011 08:53:59 +0000 (08:53 +0000)]
2011-06-28  Shinya Kawanaka  <shinyak@google.com>

        Reviewed by Kent Tamura.

        Add const to show() method in WTFString and AtomicString.
        https://bugs.webkit.org/show_bug.cgi?id=63515

        The lack of const in show() method is painful when
        doing something like printf-debug.

        * wtf/text/AtomicString.cpp:
        (WTF::AtomicString::show):
        * wtf/text/AtomicString.h:
        * wtf/text/WTFString.cpp:
        (String::show):
        * wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 28 Jun 2011 08:48:12 +0000 (08:48 +0000)]
2011-06-28  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Change permission of some ewk files.
        https://bugs.webkit.org/show_bug.cgi?id=63517

        Change some file's permission same with other file's.

        * ewk/ewk_tiled_backing_store.c:
        * ewk/ewk_tiled_model.c:
        * ewk/ewk_view_single.c:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdding MHTML reading support.
ossy@webkit.org [Tue, 28 Jun 2011 08:46:32 +0000 (08:46 +0000)]
Adding MHTML reading support.
https://bugs.webkit.org/show_bug.cgi?id=7168

Reviewed by Andreas Kling.

* features.pri: Disable MHTML on Qt by default in a proper way.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove ENABLE_XBL, because there aren't ENABLE(XBL) macros anymore.
ossy@webkit.org [Tue, 28 Jun 2011 08:46:17 +0000 (08:46 +0000)]
[Qt] Remove ENABLE_XBL, because there aren't ENABLE(XBL) macros anymore.

Reviewed by Andreas Kling.

* features.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] http/tests/misc/link-rel-icon-beforeload.html is flakey
ossy@webkit.org [Tue, 28 Jun 2011 08:02:23 +0000 (08:02 +0000)]
[Qt] http/tests/misc/link-rel-icon-beforeload.html is flakey
https://bugs.webkit.org/show_bug.cgi?id=63518

* platform/qt/Skipped: Add http/tests/misc/link-rel-icon-beforeload.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed daily gardening. Add platform specific expected files
ossy@webkit.org [Tue, 28 Jun 2011 07:55:17 +0000 (07:55 +0000)]
[Qt] Unreviewed daily gardening. Add platform specific expected files
for new passing tests and add failing new tests to the Skipped list.

* platform/qt/Skipped:
* platform/qt/editing/selection/extend-inside-transforms-backward-expected.png: Added.
* platform/qt/editing/selection/extend-inside-transforms-backward-expected.txt: Added.
* platform/qt/editing/selection/extend-inside-transforms-forward-expected.png: Added.
* platform/qt/editing/selection/extend-inside-transforms-forward-expected.txt: Added.
* platform/qt/fast/borders/only-one-border-with-width-expected.png: Added.
* platform/qt/fast/borders/only-one-border-with-width-expected.txt: Added.
* platform/qt/fast/css/color-leakage-expected.png: Added.
* platform/qt/fast/css/color-leakage-expected.txt: Added.
* platform/qt/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.png: Added.
* platform/qt/fast/dom/HTMLProgressElement/indeterminate-progress-001-expected.txt: Added.
* platform/qt/fast/inline/inline-wrap-with-parent-padding-expected.png: Added.
* platform/qt/fast/inline/inline-wrap-with-parent-padding-expected.txt: Added.
* platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.png: Added.
* platform/qt/fast/multicol/span/span-as-nested-inline-block-child-expected.txt: Added.
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added.
* platform/qt/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/interact-pointer-03-t-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/linking-uri-01-b-expected.txt: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Added.
* platform/qt/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Added.
* platform/qt/svg/custom/invalid-dasharray-expected.png: Added.
* platform/qt/svg/custom/invalid-dasharray-expected.txt: Added.
* platform/qt/svg/custom/linking-uri-01-b-expected.png: Added.
* platform/qt/svg/custom/linking-uri-01-b-expected.txt: Added.
* platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.png: Added.
* platform/qt/svg/text/text-overflow-ellipsis-svgfont-expected.txt: Added.
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Added.
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-28 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Tue, 28 Jun 2011 07:35:12 +0000 (07:35 +0000)]
2011-06-28  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        WebKitTestRunner needs layoutTestController.setCallCloseOnWebViews
        https://bugs.webkit.org/show_bug.cgi?id=46714

        Skip these tests via the mac list to make them skipped on every wk2 platform.
        * platform/mac-wk2/Skipped:
        * platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-06-27 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 28 Jun 2011 07:30:19 +0000 (07:30 +0000)]
2011-06-27  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        NRWT should wait for ReportCrash
        https://bugs.webkit.org/show_bug.cgi?id=63495

        When a test crashes on Mac, ReportCrash confuses us into thinking the
        test times out.

        I'm not sure how to test this in a meaningful way in our current test
        harness...

        * Scripts/webkitpy/common/system/crashlogs.py:
        * Scripts/webkitpy/common/system/crashlogs_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_result_writer.py:
        * Scripts/webkitpy/layout_tests/port/base.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/server_process.py:
        * Scripts/webkitpy/tool/commands/queries.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@89899 268f45cc-cd09-0410-ab3c-d52691b4dbfc