WebKit-https.git
10 years ago2009-10-03 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 4 Oct 2009 03:46:54 +0000 (03:46 +0000)]
2009-10-03  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        CSS Source View Should be Syntax Highlighted
        https://bugs.webkit.org/show_bug.cgi?id=14359

          Support for WebKit's CSS Variables @variables and var()

        * inspector/front-end/SourceFrame.js:
        (WebInspector.CSSSourceSyntaxHighligher):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-03 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 4 Oct 2009 03:14:18 +0000 (03:14 +0000)]
2009-10-03  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Inspector should remember preferences for docked/undocked etc
        https://bugs.webkit.org/show_bug.cgi?id=29089

        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._toggleLargerResources): toggle the preference
        * inspector/front-end/inspector.js:
        (WebInspector._loadPreferences): factored out loading preferences
        (WebInspector.loaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-03 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Sun, 4 Oct 2009 02:50:05 +0000 (02:50 +0000)]
2009-10-03  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        CSS Source View Should be Syntax Highlighted
        https://bugs.webkit.org/show_bug.cgi?id=14359

          Trigger the Syntax Highlighter for CSS files.

        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype.syntaxHighlightJavascript):
        (WebInspector.SourceFrame.prototype.syntaxHighlightCSS):
        * inspector/front-end/SourceView.js:
        (WebInspector.SourceView.prototype._contentLoaded):

          Factored out the Syntax Highlighting procedure into a "Class"
          Added CSSSourceSyntaxHighlighter and JavaScriptSourceSyntaxHighlighter

        (WebInspector.SourceSyntaxHighligher):
        (WebInspector.SourceSyntaxHighligher.prototype.createSpan):
        (WebInspector.SourceSyntaxHighligher.prototype.process.processChunk):
        (WebInspector.SourceSyntaxHighligher.prototype.process):
        (WebInspector.CSSSourceSyntaxHighligher): the CSS Highlighter
        (WebInspector.JavaScriptSourceSyntaxHighligher): the JS Highlighter

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Oct 2009 00:41:43 +0000 (00:41 +0000)]
2009-10-03  Adam Barth  <abarth@webkit.org>

        Unreview build fix.  I wish I had a try server...

        * Api/qwebpage.cpp:
        (QWebPagePrivate::updateAction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Oct 2009 00:36:35 +0000 (00:36 +0000)]
2009-10-03  Adam Barth  <abarth@webkit.org>

        More build fixing.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_go_back_or_forward):
        (webkit_web_view_can_go_back_or_forward):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Oct 2009 00:26:19 +0000 (00:26 +0000)]
2009-10-03  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix.

        * webkit/webkitwebview.cpp:
        (webkit_web_view_go_back_or_forward):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-03 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sun, 4 Oct 2009 00:17:08 +0000 (00:17 +0000)]
2009-10-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Factor back-forward list methods out of FrameLoader
        https://bugs.webkit.org/show_bug.cgi?id=30037

        This change moves these back-forward related methods from FrameLoader
        to Page.  It's possible we should move these methods into some kind of
        "page controller" object, but we can figure that out in a future patch.

        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::timerFired):
        * page/ContextMenuController.cpp:
        (WebCore::ContextMenuController::contextMenuItemSelected):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::close):
        * page/History.cpp:
        (WebCore::History::length):
        * page/Page.cpp:
        (WebCore::Page::canGoBackOrForward):
        (WebCore::Page::goBackOrForward):
        (WebCore::Page::getHistoryLength):
        * page/Page.h:
        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::populate):
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
2009-10-03  Adam Barth  <abarth@webkit.org>

        Reviewed by Sam Weinig.

        Factor PageController out of FrameLoader and Page
        https://bugs.webkit.org/show_bug.cgi?id=30037

        * webkit/webkitwebview.cpp:
        (webkit_web_view_can_go_back_or_forward):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-03 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Sat, 3 Oct 2009 20:50:18 +0000 (20:50 +0000)]
2009-10-03  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Remove 5 tests from the Skipped list that pass after the addition
        of layoutTestController.overridePreference().

        https://bugs.webkit.org/show_bug.cgi?id=29970

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoved the concept of a "fast access cutoff" in arrays, because it
ggaren@apple.com [Sat, 3 Oct 2009 17:01:14 +0000 (17:01 +0000)]
Removed the concept of a "fast access cutoff" in arrays, because it
punished some patterns of array access too much, and made things too
complex for inlining in some cases.

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-02
Reviewed by Sam Weinig.

1.3% speedup on SunSpider.

* jit/JITOpcodes.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_get_by_val):
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val):
(JSC::JIT::emitSlow_op_put_by_val):
* jit/JITStubs.cpp:
* jit/JITStubs.h:
(JSC::): Check m_vectorLength instead of m_fastAccessCutoff when
getting / putting from / to an array. Inline putting past the end of
the array.

* runtime/JSArray.cpp:
(JSC::JSArray::JSArray):
(JSC::JSArray::getOwnPropertySlot):
(JSC::JSArray::getOwnPropertyDescriptor):
(JSC::JSArray::put):
(JSC::JSArray::putSlowCase):
(JSC::JSArray::deleteProperty):
(JSC::JSArray::getOwnPropertyNames):
(JSC::JSArray::increaseVectorLength):
(JSC::JSArray::setLength):
(JSC::JSArray::pop):
(JSC::JSArray::push):
(JSC::JSArray::sort):
(JSC::JSArray::fillArgList):
(JSC::JSArray::copyToRegisters):
(JSC::JSArray::compactForSorting):
(JSC::JSArray::checkConsistency):
* runtime/JSArray.h:
(JSC::JSArray::canGetIndex):
(JSC::JSArray::canSetIndex):
(JSC::JSArray::setIndex):
(JSC::JSArray::markChildrenDirect): Removed m_fastAccessCutoff, and
replaced with checks for JSValue() to detect reads and writes from / to
uninitialized parts of the array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 3 Oct 2009 10:27:48 +0000 (10:27 +0000)]
2009-10-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: prepare InspectorController for being used from layout tests.
        This change adds evaluateForTestInFrontend method with the callback that
        allows evaluating arbitrary code in the frontend context.

        https://bugs.webkit.org/show_bug.cgi?id=30008

        * WebCore.Inspector.exp:
        * WebCore.order:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::didEvaluateForTestInFrontend):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::evaluateForTestInFrontend):
        (WebCore::InspectorController::didEvaluateForTestInFrontend):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::evaluateForTestInFrontend):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/inspector.js:
        (WebInspector.evaluateForTestInFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Sat, 3 Oct 2009 06:31:40 +0000 (06:31 +0000)]
2009-10-02  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Timothy Hatcher.

        Web Inspector: Node search mode is not getting reset on element selection.

        https://bugs.webkit.org/show_bug.cgi?id=30016

        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.this.treeOutline.focusedNodeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Sat, 3 Oct 2009 05:24:48 +0000 (05:24 +0000)]
2009-10-02  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        Fixes <https://bugs.webkit.org/show_bug.cgi?id=30036>
        Should be able to resize Cookie Columns.

        * inspector/front-end/CookieItemsView.js:
        (WebInspector.CookieItemsView.prototype.update.callback):
        (WebInspector.CookieItemsView.prototype.update):
        (WebInspector.CookieItemsView.prototype.resize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix.
sfalken@apple.com [Sat, 3 Oct 2009 05:10:00 +0000 (05:10 +0000)]
Windows build fix.
Re-apply lost changes to auto-version.sh.

* win/tools/scripts/auto-version.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake WebCore::PluginView participate in plug-in halting.
jhoneycutt@apple.com [Sat, 3 Oct 2009 02:51:49 +0000 (02:51 +0000)]
Make WebCore::PluginView participate in plug-in halting.

Reviewed by Sam Weinig.

WebCore:

Have plug-ins opt in to automatic halting.

Reviewed by NOBODY (OOPS!).

* platform/graphics/BitmapImage.h:
Declare a create() function that takes an HBITMAP.

* platform/graphics/win/ImageCGWin.cpp:
(WebCore::BitmapImage::create):
Use GetObject() to fill out a DIBSECTION structure for the given
HBITMAP. Call CGBitmapContextCreate() to create a CG context from the
bits of the bitmap. Create a CG image from the context, and pass this
when creating a new BitmapImage.

* plugins/PluginView.cpp:
(WebCore::PluginView::start):
If we successfully started, tell our parent frame's Page.
(WebCore::PluginView::stop):
Tell our parent frame's Page that we stopped.
(WebCore::PluginView::node):

* plugins/PluginView.h:
Inherit from HaltablePlugin.
(WebCore::PluginView::setPlatformPluginWidget):
On platforms where the platform plug-in widget is the WebCore::Widget's
platform widget, have setPlatformPluginWidget() call
setPlatformWidget().

* plugins/PluginViewNone.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

* plugins/gtk/PluginViewGtk.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

* plugins/mac/PluginViewMac.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::halt):
Stubbed.
(WebCore::PluginView::restart):
Stubbed.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::platformDestroy):
After destroying the window, set the platform plug-in widget to 0 to
ensure that Widget isn't holding a stale handle.
(WebCore::PluginView::halt):
Have our element's RenderWidget display a screenshot of the plug-in,
then stop the plug-in and destroy it.
(WebCore::PluginView::restart):
Clear the RenderWidget's substitute image, then start the plug-in.

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::showSubstituteImage):
Set m_substituteImage to the passed image, and repaint.
(WebCore::RenderWidget::paint):
If we have a substitute image, paint that instead of allowing the
widget to paint itself.

* rendering/RenderWidget.h:
Declare showSubstituteImage(). Added a member to store the substitute
image.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 3 Oct 2009 02:10:28 +0000 (02:10 +0000)]
2009-10-02  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Move PolicyCheck out of FrameLoader.{h,cpp}
        https://bugs.webkit.org/show_bug.cgi?id=30035

        Purely code motion (and adding a destructor).

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/PolicyCheck.cpp:
        * loader/PolicyCheck.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
jparent@chromium.org [Sat, 3 Oct 2009 01:47:18 +0000 (01:47 +0000)]
Unreviewed.

Patch by Julie Parent <jparent@chromium.org> on 2009-10-02
Adding myself and Ojan Vafai as committers, because we are committers.

* Scripts/modules/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r49044 as it breaks many tests.
mrowe@apple.com [Sat, 3 Oct 2009 00:47:32 +0000 (00:47 +0000)]
Roll out r49044 as it breaks many tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Jonni Rainisto <jonni.rainisto@nokia.com>
eric@webkit.org [Fri, 2 Oct 2009 23:35:31 +0000 (23:35 +0000)]
2009-10-02  Jonni Rainisto  <jonni.rainisto@nokia.com>

        Reviewed by Darin Adler.

        Math.random() gives too low values on Win32 when _CRT_RAND_S is not defined
        https://bugs.webkit.org/show_bug.cgi?id=29956

        * wtf/RandomNumber.cpp:
        (WTF::randomNumber): Added PLATFORM(WIN_OS) to handle 15bit rand()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Yuta Kitamura <yutak@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 23:27:31 +0000 (23:27 +0000)]
2009-10-02  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Darin Adler.

        Update pixel test image for fast/table/vertical-align-baseline.html.

        Expected render tree dump for this test was modified in r40146
        <http://trac.webkit.org/changeset/40146>, but the image was not updated with it.

        * platform/mac/fast/table/vertical-align-baseline-expected.checksum:
        * platform/mac/fast/table/vertical-align-baseline-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Fri, 2 Oct 2009 23:20:05 +0000 (23:20 +0000)]
2009-10-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] Add NPNVToolkit value quirk in plugins for nspluginwrapper.
        Plugin error message was:
        ERROR: failed to initialize brower-side RPC events listener
        https://bugs.webkit.org/show_bug.cgi?id=25053

        (WebCore::staticPluginQuirkRequiresGtkToolKit_NPN_GetValue):
        (WebCore::PluginPackage::load):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Jocelyn Turcotte <jocelyn.turcotte@nokia.com>
eric@webkit.org [Fri, 2 Oct 2009 23:12:18 +0000 (23:12 +0000)]
2009-10-02  Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>

        Reviewed by Tor Arne Vestbø.

        [Qt] X sync our XEmbed container window creation before sending the
        xid to plugins.
        https://bugs.webkit.org/show_bug.cgi?id=25053

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::setNPWindowIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 2 Oct 2009 23:02:45 +0000 (23:02 +0000)]
2009-10-02  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Setting zero size on a container of a video element doesn't hide the controller
        https://bugs.webkit.org/show_bug.cgi?id=30031

        Fix a logic error in enclosingCompositingLayer() when mixing normal flow and
        positioned layers. This resulted in enclosingCompositingLayer() giving back a different
        answer to the logic used to actually parent compositing layers, so layer positions
        and layer hierarchy would be out of agreement.

        Test: compositing/geometry/clipped-video-controller.html

        * rendering/RenderLayer.cpp:
        (WebCore::compositingContainer):
        (WebCore::RenderLayer::enclosingCompositingLayer):
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::setCompositingParent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Kent Tamura <tkent@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 22:49:29 +0000 (22:49 +0000)]
2009-10-02  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        - Move the following methods of HTMLInputElement and HTMLTextAreaElement
          to HTMLTextFormControlElement.
           setSelectionStart()
           setSelectionEnd()
           select()
           setSelectionRange()
           selectionStart()
           selectionEnd()
           selection()

        - Introduce cachedSelectionStart() and cachedSelectionEnd().

        - Unify HTMLInputElement::isTextFieldWithRenderer() and
         HTMLTextAreaElement::rendererAfterUpdateLayout() into textRendererAfterUpdateLayout().

        - Unify a part of parseMappedAttribute() of HTMLInputElement and HTMLTextAreaElement.

        https://bugs.webkit.org/show_bug.cgi?id=29782

        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLTextFormControlElement::textRendererAfterUpdateLayout):
        (WebCore::HTMLTextFormControlElement::setSelectionStart):
        (WebCore::HTMLTextFormControlElement::setSelectionEnd):
        (WebCore::HTMLTextFormControlElement::select):
        (WebCore::HTMLTextFormControlElement::setSelectionRange):
        (WebCore::HTMLTextFormControlElement::selectionStart):
        (WebCore::HTMLTextFormControlElement::selectionEnd):
        (WebCore::HTMLTextFormControlElement::selection):
        (WebCore::HTMLTextFormControlElement::parseMappedAttribute):
        * html/HTMLFormControlElement.h:
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::parseMappedAttribute):
        * html/HTMLInputElement.h:
        (WebCore::HTMLInputElement::select):
        (WebCore::HTMLInputElement::cachedSelectionStart):
        (WebCore::HTMLInputElement::cachedSelectionEnd):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::parseMappedAttribute):
        * html/HTMLTextAreaElement.h:
        (WebCore::HTMLTextAreaElement::cachedSelectionStart):
        (WebCore::HTMLTextAreaElement::cachedSelectionEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 22:40:59 +0000 (22:40 +0000)]
2009-10-02  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Disconnect event listeners on navigation.
        Fixes http://crbug.com/23597.
        https://bugs.webkit.org/show_bug.cgi?id=30027

        Added V8ListenerGuard that is shared by listeners and proxy. On
        navigation proxy sets a flag in the guard turning off listeners.

        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        * bindings/v8/V8AbstractEventListener.h:
        (WebCore::V8ListenerGuard::create):
        (WebCore::V8ListenerGuard::isDisconnected):
        (WebCore::V8ListenerGuard::disconnectListeners):
        (WebCore::V8ListenerGuard::V8ListenerGuard):
        (WebCore::V8AbstractEventListener::disconnected):
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getEventListener):
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::findOrCreateWrapper):
        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::V8LazyEventListener):
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::V8Proxy):
        (WebCore::V8Proxy::disconnectFrame):
        (WebCore::V8Proxy::disconnectEventListeners):
        (WebCore::V8Proxy::clearForNavigation):
        * bindings/v8/V8Proxy.h:
        (WebCore::V8Proxy::listenerGuard):
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::V8WorkerContextEventListener):
        * bindings/v8/V8WorkerContextEventListener.h:
        (WebCore::V8WorkerContextEventListener::create):
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::WorkerContextExecutionProxy):
        (WebCore::WorkerContextExecutionProxy::dispose):
        (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
        * bindings/v8/WorkerContextExecutionProxy.h:
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener):
        * bindings/v8/custom/V8CustomEventListener.h:
        (WebCore::V8EventListener::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Kenneth Russell <kbr@google.com>
eric@webkit.org [Fri, 2 Oct 2009 22:33:40 +0000 (22:33 +0000)]
2009-10-02  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        [chromium] Fix WebGL build after CustomGetter constructor changes
        https://bugs.webkit.org/show_bug.cgi?id=30020

        * page/DOMWindow.idl:
        Changed CustomGetter to JSCCustomGetter for CanvasArray constructors.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Patrick Mueller <Patrick_Mueller@us.ibm.com>
eric@webkit.org [Fri, 2 Oct 2009 22:23:36 +0000 (22:23 +0000)]
2009-10-02  Patrick Mueller  <Patrick_Mueller@us.ibm.com>

        Reviewed by Timothy Hatcher.

        Web Inspector: text in a "Request Payload" section disappears on selection
        https://bugs.webkit.org/show_bug.cgi?id=29967

        No new tests.

        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._refreshRequestPayload):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 22:15:23 +0000 (22:15 +0000)]
2009-10-02  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        Test that having infinite recursion in XMLHttpRequest event handler does not crash.
        https://bugs.webkit.org/show_bug.cgi?id=29974

        * fast/xmlhttprequest/xmlhttprequest-recursive-sync-event-expected.txt: Added.
        * fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html: Added.
2009-10-02  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Recursion guard for V8Proxy::callFunction.
        Fixes http://crbug.com/23278.
        https://bugs.webkit.org/show_bug.cgi?id=29974

        Test: fast/xmlhttprequest/xmlhttprequest-recursive-sync-event.html

        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::callFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoClean up the QNetworkReplyHandler to only apply HTTP headers
kenneth@webkit.org [Fri, 2 Oct 2009 21:59:21 +0000 (21:59 +0000)]
Clean up the QNetworkReplyHandler to only apply HTTP headers
for protocols in the HTTP family.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Victor Wang <victorw@chromium.org>
japhet@chromium.org [Fri, 2 Oct 2009 21:55:41 +0000 (21:55 +0000)]
2009-10-02  Victor Wang  <victorw@chromium.org>

        Reviewed by Adam Barth.

        https://bugs.webkit.org/show_bug.cgi?id=29619

        Patch http://trac.webkit.org/changeset/35290 adds win support for
        JPEG and GIF for toDataURL encoding canvases and the test was
        rewritten to not output the encoded image data, it should pass
        on Win now.

        * platform/win/Skipped:
        * platform/win/fast/canvas/toDataURL-supportedTypes-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit side of <rdar://problem/7179166>
andersca@apple.com [Fri, 2 Oct 2009 21:53:33 +0000 (21:53 +0000)]
WebKit side of <rdar://problem/7179166>

Reviewed by Kevin Decker and Dan Bernstein.

* Plugins/Hosted/NetscapePluginInstanceProxy.h:
Add an m_pluginIsWaitingForDraw member variable.

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::NetscapePluginInstanceProxy):
Initialize m_pluginIsWaitingForDraw.

(WebKit::NetscapePluginInstanceProxy::invalidateRect):
Set m_pluginIsWaitingForDraw to true.

(WebKit::NetscapePluginInstanceProxy::didDraw):
If m_pluginIsWaitingForDraw is true, call _WKPHPluginInstanceDidDraw.

* Plugins/Hosted/WebHostedNetscapePluginView.mm:
(-[WebHostedNetscapePluginView drawRect:]):
Call didDraw.

* Plugins/Hosted/WebKitPluginHost.defs:
Add PHPluginInstanceDidDraw.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 2 Oct 2009 21:49:56 +0000 (21:49 +0000)]
2009-10-02  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Jon Honeycutt.

        Fix test breakages by adding null checks, and putting inspector code in
        ENABLE(INSPECTOR).

        * dom/Document.cpp:
        (WebCore::Document::finishedParsing):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMove error check into sendResponseIfNeeded() as suggested
kenneth@webkit.org [Fri, 2 Oct 2009 21:39:24 +0000 (21:39 +0000)]
Move error check into sendResponseIfNeeded() as suggested
by Eric Seidel. Also, remove some dead code.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-02
Reviewed by Simon Hausmann.

* platform/network/qt/QNetworkReplyHandler.cpp:
(WebCore::QNetworkReplyHandler::finish):
(WebCore::QNetworkReplyHandler::sendResponseIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Assertion failure in CompositeEditCommand::moveParagraphs() and crash in...
adele@apple.com [Fri, 2 Oct 2009 21:34:03 +0000 (21:34 +0000)]
WebCore: Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
<rdar://problem/7148712>
https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

Test: editing/selection/replace-selection-crash.html

* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded): Handle properly the case of
the destination position matching the end of the paragraph to move.

LayoutTests: Added test case.
<rdar://problem/7148712> Assertion failure in CompositeEditCommand::moveParagraphs() and crash in Node::nodeIndex() when pasting.
https://bugs.webkit.org/show_bug.cgi?id=28992

Patch by Enrica Casucci <enrica@apple.com> on 2009-10-02
Reviewed by Adele Peterson.

* editing/selection/replace-selection-crash-expected.txt: Added.
* editing/selection/replace-selection-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 2 Oct 2009 21:15:41 +0000 (21:15 +0000)]
2009-10-02  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement per-storage-area quotas for LocalStorage
        https://bugs.webkit.org/show_bug.cgi?id=29991

        I put 90% of the code in StorageMap since the decision to allow an update is
        closely tied to quota tracking.  The quota is set via a page's Settings class.
        Like with the local storage path and whether it's enabled, it's assumed that
        all pages in the same group will have the same settings.  The setting defaults
        to 5mb which is what the spec suggests, but it can easily be changed to
        anything else--including StorageMap::noQuota.  Any values in LocalStorage are
        grandfathered in regarudless of quota, so importItem only tracks (and will
        never block) imports.

        I believe this change is a good transition to more complex quota management.
        For example, if we wanted to track quotas in the SQLite DB, then we'd just add
        a function to the StorageMap that sets the quota.  This would be fine since all
        use of LocalStorage is blocked on the import completing, so you'd never hit a
        quota error in the mean time.  Also, if embedders wanted to ask the user
        whether to expand the quota whenever it's hit (before deciding whether or not
        to raise an exception), a callback via the chrome client should be fairly easy.
        That said, I think it's best to add these features in steps rather than one
        huge patch.  (Both of these are on my TODO list, btw.)

        Included is a layout test that verifies the behavior.  It assumes the default
        quota is 5mb (since that's what Settings defaults to).

        Test: storage/domstorage/localstorage/quota.html

        * page/PageGroup.cpp:
        (WebCore::PageGroup::localStorage):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        (WebCore::Settings::setLocalStorageQuota):
        * page/Settings.h:
        (WebCore::Settings::localStorageQuota):
        * storage/StorageAreaImpl.cpp:
        (WebCore::StorageAreaImpl::create):
        (WebCore::StorageAreaImpl::StorageAreaImpl):
        (WebCore::StorageAreaImpl::setItem):
        (WebCore::StorageAreaImpl::clear):
        * storage/StorageAreaImpl.h:
        * storage/StorageMap.cpp:
        (WebCore::StorageMap::create):
        (WebCore::StorageMap::StorageMap):
        (WebCore::StorageMap::copy):
        (WebCore::StorageMap::setItem):
        (WebCore::StorageMap::removeItem):
        (WebCore::StorageMap::importItem):
        * storage/StorageMap.h:
        (WebCore::StorageMap::quota):
        * storage/StorageNamespace.cpp:
        (WebCore::StorageNamespace::localStorageNamespace):
        * storage/StorageNamespace.h:
        * storage/StorageNamespaceImpl.cpp:
        (WebCore::StorageNamespaceImpl::localStorageNamespace):
        (WebCore::StorageNamespaceImpl::sessionStorageNamespace):
        (WebCore::StorageNamespaceImpl::StorageNamespaceImpl):
        (WebCore::StorageNamespaceImpl::copy):
        (WebCore::StorageNamespaceImpl::storageArea):
        * storage/StorageNamespaceImpl.h:
2009-10-02  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Dimitri Glazkov.

        Implement per-storage-area quotas for LocalStorage
        https://bugs.webkit.org/show_bug.cgi?id=29991

        I put 90% of the code in StorageMap since the decision to allow an update is
        closely tied to quota tracking.  The quota is set via a page's Settings class.
        Like with the local storage path and whether it's enabled, it's assumed that
        all pages in the same group will have the same settings.  The setting defaults
        to 5mb which is what the spec suggests, but it can easily be changed to
        anything else--including StorageMap::noQuota.  Any values in LocalStorage are
        grandfathered in regarudless of quota, so importItem only tracks (and will
        never block) imports.

        I believe this change is a good transition to more complex quota management.
        For example, if we wanted to track quotas in the SQLite DB, then we'd just add
        a function to the StorageMap that sets the quota.  This would be fine since all
        use of LocalStorage is blocked on the import completing, so you'd never hit a
        quota error in the mean time.  Also, if embedders wanted to ask the user
        whether to expand the quota whenever it's hit (before deciding whether or not
        to raise an exception), a callback via the chrome client should be fairly easy.
        That said, I think it's best to add these features in steps rather than one
        huge patch.  (Both of these are on my TODO list, btw.)

        Included is a layout test that verifies the behavior.  It assumes the default
        quota is 5mb (since that's what Settings defaults to).

        * storage/domstorage/localstorage/quota-expected.txt: Added.
        * storage/domstorage/localstorage/quota.html: Added.
        * storage/domstorage/script-tests/quota.js: Added.
        (runTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Fri, 2 Oct 2009 20:09:02 +0000 (20:09 +0000)]
2009-10-02  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Timothy Hatcher.

        Database Inspector crashes Safari when table has more than 21 columns
        https://bugs.webkit.org/show_bug.cgi?id=29924

        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.dataGridForResult): adjust the minimum column width percentage to be flexible for many columns.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows bustage.
hyatt@apple.com [Fri, 2 Oct 2009 20:07:34 +0000 (20:07 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows bustage.
hyatt@apple.com [Fri, 2 Oct 2009 20:07:15 +0000 (20:07 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 2 Oct 2009 20:01:46 +0000 (20:01 +0000)]
2009-10-02  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Timothy Hatcher.

        Fixes <http://webkit.org/b/14370>.
        Inspector's timeline should record when certain DOM events fired.

        This patch adds calls into the Web Inspector when the main frame
        fires an load event, and when the document fires its DOMContent
        event. Once these values are passed in, they are sent to the Web Inspector
        as a timing change, and these are denoted by vertical lines in the resources
        panel (blue for DOM Content, red for load event).

        * English.lproj/localizedStrings.js: Added tooltip text.
        * dom/Document.cpp:
        (WebCore::Document::finishedParsing): Added an Inspector callback for DOM Content.
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::mainResourceFiredDOMContentEvent): Tell the main resource it got the event.
        (WebCore::InspectorController::mainResourceFiredLoadEvent): Ditto.
        * inspector/InspectorController.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::InspectorResource): Added new variables.
        (WebCore::InspectorResource::updateScriptObject): Send new variables to inspector.js.
        (WebCore::InspectorResource::markDOMContentEventTime): Send a TimingChange event.
        (WebCore::InspectorResource::markLoadEventTime): Ditto.
        * inspector/InspectorResource.h:
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.get mainResourceLoadTime):
        (WebInspector.ResourcesPanel.prototype.set mainResourceLoadTime):
        (WebInspector.ResourcesPanel.prototype.get mainResourceDOMContentTime):
        (WebInspector.ResourcesPanel.prototype.set mainResourceDOMContentTime):
        (WebInspector.ResourcesPanel.prototype.reset):
        (WebInspector.ResourcesPanel.prototype._updateGraphDividersIfNeeded): Draw dividers for event timings.
        (WebInspector.ResourceTimeCalculator.prototype.computePercentageFromEventTime):
        * inspector/front-end/inspector.css:
        * inspector/front-end/inspector.js:
        (WebInspector.updateResource):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::dispatchLoadEvent): Add an Inspector callback for the Load event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Windows bustage.
hyatt@apple.com [Fri, 2 Oct 2009 20:00:13 +0000 (20:00 +0000)]
Fix Windows bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate DUmpRenderTree to account for new API.
hyatt@apple.com [Fri, 2 Oct 2009 19:57:51 +0000 (19:57 +0000)]
Update DUmpRenderTree to account for new API.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd support for blacklist patterns to user stylesheets and scripts in addition to...
hyatt@apple.com [Fri, 2 Oct 2009 19:42:39 +0000 (19:42 +0000)]
Add support for blacklist patterns to user stylesheets and scripts in addition to whitelist patterns.

Reviewed by Adam Roben.

WebCore:

* WebCore.base.exp:
* dom/Document.cpp:
(WebCore::Document::pageGroupUserSheets):
* page/Frame.cpp:
(WebCore::Frame::injectUserScriptsForWorld):
* page/PageGroup.cpp:
(WebCore::PageGroup::addUserScript):
(WebCore::PageGroup::addUserStyleSheet):
(WebCore::PageGroup::removeUserContentWithURLForWorld):
(WebCore::PageGroup::removeUserContentForWorld):
* page/PageGroup.h:
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::matchesPatterns):
* page/UserContentURLPattern.h:
* page/UserScript.h:
(WebCore::UserScript::UserScript):
(WebCore::UserScript::whitelist):
(WebCore::UserScript::blacklist):
* page/UserStyleSheet.h:
(WebCore::UserStyleSheet::UserStyleSheet):
(WebCore::UserStyleSheet::whitelist):
(WebCore::UserStyleSheet::blacklist):

WebKit/mac:

* WebView/WebView.mm:
(toStringVector):
(+[WebView _addUserScriptToGroup:source:url:worldID:whitelist:blacklist:injectionTime:]):
(+[WebView _addUserStyleSheetToGroup:source:url:worldID:whitelist:blacklist:]):
* WebView/WebViewPrivate.h:

WebKit/win:

* Interfaces/IWebViewPrivate.idl:
* WebView.cpp:
(toStringVector):
(WebView::addUserScriptToGroup):
(WebView::addUserStyleSheetToGroup):
* WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 18:41:39 +0000 (18:41 +0000)]
2009-10-02  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added gyp_webkit that does a subset of the things gyp_chromium does
        plus some specialization for an upstream chromium build.

        https://bugs.webkit.org/show_bug.cgi?id=29986

        * chromium/DEPS: Points to gyp_webkit instead of gyp_chromium.
        * chromium/gyp_webkit: A new python file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Fri, 2 Oct 2009 18:08:14 +0000 (18:08 +0000)]
2009-10-02  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adam Roben.

        <rdar://problem/7271334>
        Rename MediaControllerThemeQT to MediaControllerThemeQuickTime

        * WebKitSystemInterface.h:
        MediaControllerThemeQT -> MediaControllerThemeQuickTime

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRolled back in r49004 with the debug 64bit build fixed
ggaren@apple.com [Fri, 2 Oct 2009 18:06:49 +0000 (18:06 +0000)]
Rolled back in r49004 with the debug 64bit build fixed

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 2 Oct 2009 18:02:48 +0000 (18:02 +0000)]
2009-10-02  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        Build fix when SVG is not enabled
        https://bugs.webkit.org/show_bug.cgi?id=30011

        Move TextRenderingMode related functions out from
        the ENABLE(SVG) guard.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
        (WebCore::CSSPrimitiveValue::operator TextRenderingMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Fri, 2 Oct 2009 17:57:37 +0000 (17:57 +0000)]
2009-10-02  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Adam Roben.

        svn-create-patch should have an --ignore-changelogs to not add ChangeLogs to the diff,
        this will help the patch merging process when TryBots are used.

        * Scripts/svn-create-patch:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago WebGL crashes with recent CanvasArray change
cmarrin@apple.com [Fri, 2 Oct 2009 17:49:33 +0000 (17:49 +0000)]
    WebGL crashes with recent CanvasArray change
        https://bugs.webkit.org/show_bug.cgi?id=30018

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<https://bugs.webkit.org/show_bug.cgi?id=29989>
sfalken@apple.com [Fri, 2 Oct 2009 17:22:33 +0000 (17:22 +0000)]
<https://bugs.webkit.org/show_bug.cgi?id=29989>
Safari version number shouldn't be exposed in WebKit code

Reviewed by Mark Rowe.

For a WebKit version of 532.3.4:
Product version is: 5.32.3.4 (was 4.0.3.0)
File version is: 5.32.3.4 (was 4.532.3.4)

JavaScriptCore:

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.rc:

WebCore:

* WebCore.vcproj/QTMovieWin.rc:

WebKit/win:

* WebKit.vcproj/WebKit.rc:

WebKitLibraries:

* win/tools/scripts/PRODUCTVERSION: Removed.
* win/tools/scripts/auto-version.sh: Re-worked script to remove references to PRODUCTVERSION.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoEnable two point radial gradients in Chromium/Skia.
senorblanco@chromium.org [Fri, 2 Oct 2009 17:19:44 +0000 (17:19 +0000)]
Enable two point radial gradients in Chromium/Skia.

Reviewed by Dimitri Glazkov.

https://bugs.webkit.org/show_bug.cgi?id=30017

Covered by the following tests:

LayoutTests/svg/W3C-SVG-1.1/pservers-grad-13-b.svg
LayoutTests/fast/backgrounds/svg-as-background-3.html
LayoutTests/fast/gradients/generated-gradients.html
LayoutTests/fast/gradients/simple-gradients.html

* platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::platformGradient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Fri, 2 Oct 2009 16:14:49 +0000 (16:14 +0000)]
2009-10-02  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Simon Hausmann.

        [Qt] Implement layoutTestController.overridePreference().
        https://bugs.webkit.org/show_bug.cgi?id=29970

        * DumpRenderTree/qt/DumpRenderTree.cpp:
        (WebCore::WebPage::WebPage):
        (WebCore::WebPage::resetSettings):
        (WebCore::DumpRenderTree::resetToConsistentStateBeforeTesting):
        * DumpRenderTree/qt/jsobjects.cpp:
        (LayoutTestController::reset):
        (LayoutTestController::setPrivateBrowsingEnabled):
        (LayoutTestController::setPopupBlockingEnabled):
        (LayoutTestController::overridePreference):
        * DumpRenderTree/qt/jsobjects.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Norbert Leser <norbert.leser@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 2 Oct 2009 15:49:27 +0000 (15:49 +0000)]
2009-10-02  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
        Otherwise, it is inconsistent with class declaration of QCursor.

        * Api/qgraphicswebview.cpp:
        * Api/qwebview.cpp:

2009-10-02  Norbert Leser  <norbert.leser@nokia.com>

        Reviewed by Simon Hausmann.

        Conditionally guard cursor code (cursor and updateCursor functions) with !QT_NO_CURSOR.
        Otherwise, it is inconsistent with class declaration of QCursor.

        No new tests.

        * platform/qt/QWebPageClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Qt on Mac OS X build.
vestbo@webkit.org [Fri, 2 Oct 2009 15:40:52 +0000 (15:40 +0000)]
Fix the Qt on Mac OS X build.

Rubber-stamped by Simon Hausmann.

* wtf/FastMalloc.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Fri, 2 Oct 2009 11:32:40 +0000 (11:32 +0000)]
2009-10-02  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] missing support for anamorphic PAR video size
        https://bugs.webkit.org/show_bug.cgi?id=29717

        cleanup of caps handling in the video sink

        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_set_caps):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago.: Disable a few more harmless MSVC warnings.
hausmann@webkit.org [Fri, 2 Oct 2009 11:18:06 +0000 (11:18 +0000)]
.: Disable a few more harmless MSVC warnings.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

* WebKit.pri:

WebCore: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

* bridge/qt/qt_class.h:
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
* dom/XMLTokenizerQt.cpp:
(WebCore::XMLTokenizer::initializeParserContext):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::getTraitsInFamily):
(WebCore::FontCache::getCachedFontPlatformData):
* platform/graphics/qt/FontFallbackListQt.cpp:
(WebCore::FontFallbackList::setPlatformFont):
* platform/graphics/qt/FontQt.cpp:
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::drawLineForText):
(WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::setURLForRect):
* platform/graphics/qt/IconQt.cpp:
(WebCore::Icon::createIconForFiles):
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBuffer::ImageBuffer):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoderQt::frameBufferAtIndex):
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::supportsType):
(WebCore::MediaPlayerPrivate::setEndTime):
* platform/graphics/qt/SimpleFontDataQt.cpp:
(WebCore::SimpleFontData::containsCharacters):
* platform/graphics/qt/StillImageQt.h:
(WebCore::StillImage::destroyDecodedData):
* platform/network/qt/DnsPrefetchHelper.h:
(WebCore::DnsPrefetchHelper::lookedUp):
* platform/qt/ContextMenuQt.cpp:
(WebCore::ContextMenu::setPlatformDescription):
* platform/qt/DragDataQt.cpp:
(WebCore::DragData::asURL):
* platform/qt/PopupMenuQt.cpp:
(WebCore::PopupMenu::populate):
* platform/qt/RenderThemeQt.cpp:
(WebCore::RenderThemeQt::supportsFocusRing):
(WebCore::RenderThemeQt::systemFont):
(WebCore::RenderThemeQt::adjustButtonStyle):
(WebCore::RenderThemeQt::adjustMenuListButtonStyle):
(WebCore::RenderThemeQt::paintMediaSeekBackButton):
(WebCore::RenderThemeQt::paintMediaSeekForwardButton):
* platform/qt/ScrollViewQt.cpp:
(WebCore::ScrollView::platformAddChild):
* platform/qt/SearchPopupMenuQt.cpp:
(WebCore::SearchPopupMenu::saveRecentSearches):
(WebCore::SearchPopupMenu::loadRecentSearches):
* platform/qt/TemporaryLinkStubs.cpp:
(WebCore::signedPublicKeyAndChallengeString):
* platform/qt/WidgetQt.cpp:
(WebCore::Widget::paint):
* xml/XSLStyleSheetQt.cpp:
(WebCore::XSLStyleSheet::loadChildSheet):
(WebCore::XSLStyleSheet::setParentStyleSheet):
* xml/XSLTProcessorQt.cpp:
(WebCore::XSLTMessageHandler::handleMessage):
(WebCore::XSLTProcessor::transformToString):

WebKit/qt: Fix compiler warnings about unused function arguments.

Patch by Prasanth Ullattil <prasanth.ullattil@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

* Api/qwebframe.cpp:
(QWebFrame::scrollBarMinimum):
* Api/qwebpage.cpp:
(QWebPagePrivate::focusInEvent):
(QWebPagePrivate::focusOutEvent):
(QWebPagePrivate::leaveEvent):
(QWebPage::javaScriptAlert):
(QWebPage::javaScriptConfirm):
(QWebPage::javaScriptPrompt):
(QWebPage::triggerAction):
(QWebPage::acceptNavigationRequest):
(QWebPage::chooseFile):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::repaint):
(WebCore::ChromeClientQt::mouseDidMoveOverElement):
(WebCore::ChromeClientQt::reachedMaxAppCacheSize):
* WebCoreSupport/ContextMenuClientQt.cpp:
(WebCore::ContextMenuClientQt::downloadURL):
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchWillPerformClientRedirect):
(WebCore::FrameLoaderClientQt::setMainFrameDocumentReady):
(WebCore::FrameLoaderClientQt::representationExistsForURLScheme):
(WebCore::FrameLoaderClientQt::generatedMIMETypeForURLScheme):
(WebCore::FrameLoaderClientQt::shouldGoToHistoryItem):
(WebCore::FrameLoaderClientQt::pluginWillHandleLoadError):
(WebCore::FrameLoaderClientQt::assignIdentifierToInitialRequest):
(WebCore::FrameLoaderClientQt::dispatchDidFinishLoading):
(WebCore::FrameLoaderClientQt::createJavaAppletWidget):
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientQt::setAttachedWindowHeight):
(WebCore::InspectorClientQt::highlight):
(WebCore::InspectorClientQt::removeSetting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Ben Murdoch <benm@google.com>
eric@webkit.org [Fri, 2 Oct 2009 11:14:58 +0000 (11:14 +0000)]
2009-10-02  Ben Murdoch  <benm@google.com>

        Reviewed by David Kilzer.

        Stale database version persists through browser refresh (changeVersion doesn't work)
        https://bugs.webkit.org/show_bug.cgi?id=27836

        Scale the cairo surface of the video sink depending on the
        pixel-aspect-ratio of the video buffer to paint. Also
        destruct/re-create the surface when setSize() is called with a new
        size.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::naturalSize):
        (WebCore::MediaPlayerPrivate::setSize):
        (WebCore::MediaPlayerPrivate::paint):
        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_idle_func):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStale database version persists through browser refresh (changeVersion doesn't work)
benm@google.com [Fri, 2 Oct 2009 10:19:45 +0000 (10:19 +0000)]
Stale database version persists through browser refresh (changeVersion doesn't work)
https://bugs.webkit.org/show_bug.cgi?id=27836

WebCore:

Reviewed by David Kilzer.

Tests: storage/change-version-handle-reuse.html
       storage/change-version.html

* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::CALLBACK_FUNC_DECL): Implement the V8 binding for database.changeVersion().
(WebCore::createTransaction): Fix a bug that was checking the wrong argument index to save the success callback.
* storage/Database.cpp:
(WebCore::updateGuidVersionMap): Safely update the Guid/version hash map.
(WebCore::Database::~Database): Remove code that removes the database from the guid->database and guid->version maps.
(WebCore::Database::setVersionInDatabase): Add a comment to explain some behaviour.
(WebCore::Database::close): Move the code that updates the maps from the destructor to here.
(WebCore::Database::performOpenAndVerify): Call updateGuidVersionMap instead of setting the hash map directly.
(WebCore::Database::setExpectedVersion): Update the in memory guid->version map when we want to update the database version.

LayoutTests:

Reviewed by  David Kilzer.

* storage/change-version-expected.txt: Added.
* storage/change-version-handle-reuse-expected.txt: Added.
* storage/change-version-handle-reuse.html: Added.
* storage/change-version.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPartial WINSCW build fix.
hausmann@webkit.org [Fri, 2 Oct 2009 08:34:11 +0000 (08:34 +0000)]
Partial WINSCW build fix.

Patch by Janne Koskinen <janne.p.koskinen@digia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Add parentheses around the function pointer declaration, similar to the
second hunk in r48825.

* loader/CachedResourceHandle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out accidential r49015 commit
hausmann@webkit.org [Fri, 2 Oct 2009 08:22:42 +0000 (08:22 +0000)]
Roll out accidential r49015 commit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agouse wtf/unicode/qt4/unicodeQt4.h for RVCT and WINSCW
hausmann@webkit.org [Fri, 2 Oct 2009 08:21:16 +0000 (08:21 +0000)]
use wtf/unicode/qt4/unicodeQt4.h for RVCT and WINSCW

Relative includes don't work properly with WINSCW

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 2 Oct 2009 08:20:58 +0000 (08:20 +0000)]
2009-10-02  Adam Barth  <abarth@webkit.org>

        Unreviewed attempted build fix by Xcode magic.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 2 Oct 2009 08:03:35 +0000 (08:03 +0000)]
2009-10-02  Adam Barth  <abarth@webkit.org>

        Unreviewed build fix.  Actually add the new files.

        * loader/RedirectScheduler.cpp: Added.
        (WebCore::ScheduledRedirection::):
        (WebCore::ScheduledRedirection::ScheduledRedirection):
        (WebCore::RedirectScheduler::RedirectScheduler):
        (WebCore::RedirectScheduler::~RedirectScheduler):
        (WebCore::RedirectScheduler::redirectScheduledDuringLoad):
        (WebCore::RedirectScheduler::clear):
        (WebCore::RedirectScheduler::scheduleRedirect):
        (WebCore::RedirectScheduler::mustLockBackForwardList):
        (WebCore::RedirectScheduler::scheduleLocationChange):
        (WebCore::RedirectScheduler::scheduleFormSubmission):
        (WebCore::RedirectScheduler::scheduleRefresh):
        (WebCore::RedirectScheduler::locationChangePending):
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        (WebCore::RedirectScheduler::timerFired):
        (WebCore::RedirectScheduler::schedule):
        (WebCore::RedirectScheduler::startTimer):
        (WebCore::RedirectScheduler::cancel):
        * loader/RedirectScheduler.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 2 Oct 2009 07:57:48 +0000 (07:57 +0000)]
2009-10-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Move RedirectScheduler to its own file
        https://bugs.webkit.org/show_bug.cgi?id=29952

        This change is purely code motion.

        No behavior change.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * loader/FrameLoader.cpp:
        * loader/FrameLoader.h:
        * loader/RedirectScheduler.cpp: Added.
        (WebCore::ScheduledRedirection::):
        (WebCore::ScheduledRedirection::ScheduledRedirection):
        (WebCore::RedirectScheduler::RedirectScheduler):
        (WebCore::RedirectScheduler::~RedirectScheduler):
        (WebCore::RedirectScheduler::redirectScheduledDuringLoad):
        (WebCore::RedirectScheduler::clear):
        (WebCore::RedirectScheduler::scheduleRedirect):
        (WebCore::RedirectScheduler::mustLockBackForwardList):
        (WebCore::RedirectScheduler::scheduleLocationChange):
        (WebCore::RedirectScheduler::scheduleFormSubmission):
        (WebCore::RedirectScheduler::scheduleRefresh):
        (WebCore::RedirectScheduler::locationChangePending):
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):
        (WebCore::RedirectScheduler::timerFired):
        (WebCore::RedirectScheduler::schedule):
        (WebCore::RedirectScheduler::startTimer):
        (WebCore::RedirectScheduler::cancel):
        * loader/RedirectScheduler.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-02 Dave MacLachlan <dmaclach@gmail.com>
eric@webkit.org [Fri, 2 Oct 2009 07:41:49 +0000 (07:41 +0000)]
2009-10-02  Dave MacLachlan  <dmaclach@gmail.com>

        Reviewed by David Levin.

        Clean up warnings in WebCore/bindings/v8/npruntime.cpp
        https://bugs.webkit.org/show_bug.cgi?id=29971

        Gets rid of warnings on gcc about using anonymous namespaces
          warning: 'StringKeyHashTraits' has a base
          'WTF::GenericHashTraits<<unnamed>::StringKey>'
          whose type uses the anonymous namespace
        and
          warning: 'WTF::PairHashTraits<StringKeyHashTraits,
          WTF::HashTraits<PrivateIdentifier*> >' has a base
          'WTF::GenericHashTraits<std::pair<<unnamed>::StringKey,
          PrivateIdentifier*> >' whose type uses the anonymous namespace

        No tests required.

        * bindings/v8/npruntime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAllow enabling and disabling of the JIT through a qmake variable.
hausmann@webkit.org [Fri, 2 Oct 2009 07:31:22 +0000 (07:31 +0000)]
Allow enabling and disabling of the JIT through a qmake variable.

Patch by Jørgen Lind <jorgen.lind@nokia.com> on 2009-10-02
Reviewed by Simon Hausmann.

Qt's configure may set this variable through .qmake.cache if a
commandline option is given and/or the compile test for hwcap.h
failed/succeeded.

* JavaScriptCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Drew Wilson <atwilson@chromium.org>
eric@webkit.org [Fri, 2 Oct 2009 04:01:38 +0000 (04:01 +0000)]
2009-10-01  Drew Wilson  <atwilson@chromium.org>

        Reviewed by David Levin.

        Remove clone count from worker-cloneport.html as it's flakey on multi-process ports like Chromium.
        https://bugs.webkit.org/show_bug.cgi?id=29698

        * fast/workers/worker-cloneport-expected.txt:
        * fast/workers/worker-cloneport.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix the Tiger build. Don't unconditionally enable 3D canvas as it is not supported...
mrowe@apple.com [Fri, 2 Oct 2009 02:50:27 +0000 (02:50 +0000)]
Fix the Tiger build.  Don't unconditionally enable 3D canvas as it is not supported on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 2 Oct 2009 00:58:45 +0000 (00:58 +0000)]
2009-10-01  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Unreviewed, build fix.

        [Qt] Symbian build break after r48976.
        unix is set for Symbian in the Qt build system.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=29906
cmarrin@apple.com [Fri, 2 Oct 2009 00:25:12 +0000 (00:25 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=29906
Turn on compile time switch for WebGL, but have runtime switch default to off

This also fixes LayoutTests which broke with the flag turned on, and
fixes a crash found in the LayoutTests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRoll out r49004 since it broke the debug build.
mrowe@apple.com [Thu, 1 Oct 2009 23:49:28 +0000 (23:49 +0000)]
Roll out r49004 since it broke the debug build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTake one branch instead of two to test for JSValue().
ggaren@apple.com [Thu, 1 Oct 2009 23:32:48 +0000 (23:32 +0000)]
Take one branch instead of two to test for JSValue().

Patch by Geoffrey Garen <ggaren@apple.com> on 2009-10-01
Reviewed by Sam Weinig.

1.1% SunSpider speedup.

* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_to_jsnumber):
(JSC::JIT::emit_op_create_arguments):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
(JSC::JIT::emit_op_put_by_val): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

* runtime/JSValue.cpp:
(JSC::JSValue::description): Added support for dumping the new empty value,
and deleted values, in debug builds.

* runtime/JSValue.h:
(JSC::JSValue::JSValue()): Construct JSValue() with the empty value tag.

(JSC::JSValue::JSValue(JSCell*)): Convert null pointer to the empty value
tag, to avoid having two different c++ versions of null / empty.

(JSC::JSValue::operator bool): Test for the empty value tag, instead
of testing for the cell tag with a 0 payload.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box-
bdakin@apple.com [Thu, 1 Oct 2009 23:00:22 +0000 (23:00 +0000)]
WebCore: Fix for <rdar://problem/7264725> Re-add a vendor prefix to box-
shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927

Reviewed by Dan Bernstein.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::ShadowParseContext::ShadowParseContext):
(WebCore::ShadowParseContext::commitValue):
(WebCore::ShadowParseContext::commitLength):
(WebCore::ShadowParseContext::commitColor):
(WebCore::cssPropertyID):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* page/animation/AnimationBase.cpp:
(WebCore::ensurePropertyMap):

LayoutTests: Updated test results for <rdar://problem/7264725> Re-add a vendor
prefix to box-shadow (29927)
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=29927

Reviewed by Dan Bernstein.

* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 22:21:34 +0000 (22:21 +0000)]
2009-10-01  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Make it possible to override the list of feature defines when building
        downstream.

        https://bugs.webkit.org/show_bug.cgi?id=29979

        * chromium/features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Thu, 1 Oct 2009 21:56:02 +0000 (21:56 +0000)]
2009-10-01  Brian Weinstein  <bweinstein@apple.com>

        Rubber-stamped by Adam Roben.

        Added fast/inline/relative-positioned-overflow.html to Skipped list because
        it hits an asssert in Windows debug builds. Assertion failure is being tracked
        by <https://bugs.webkit.org/show_bug.cgi?id=29966>.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Sam Weinig.
bdakin@apple.com [Thu, 1 Oct 2009 21:24:51 +0000 (21:24 +0000)]
Rubber-stamped by Sam Weinig.

Appeasing the Bot.

* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@49000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Brian Weinstein <bweinstein@apple.com>
bweinstein@apple.com [Thu, 1 Oct 2009 21:19:52 +0000 (21:19 +0000)]
2009-10-01  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Beth Dakin.

        Update expected Windows results after new CSS Text Kerning changes.

        * platform/win/fast/css/getComputedStyle/computed-style-expected.txt:
        * platform/win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
        * platform/win/fast/css/text-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Thu, 1 Oct 2009 20:46:45 +0000 (20:46 +0000)]
2009-10-01  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Set the type for the fake event, otherwise the test ASSERTs in
        debug builds.

        * tests/testhittestresult.c:
        (load_status_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 20:44:42 +0000 (20:44 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Disable HTTP loading tests that fail on the buildbot.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on...
atwilson@chromium.org [Thu, 1 Oct 2009 20:27:05 +0000 (20:27 +0000)]
REGRESSION: fast/workers/dedicated-worker-lifecycle.html failing intermittently on leopard bot
https://bugs.webkit.org/show_bug.cgi?id=29344

Reviewed by Eric Seidel.

* fast/workers/resources/dedicated-worker-lifecycle.js:
(runTests):
Allocate objects on the stack to try to force a GC to eliminate flakiness.
* fast/workers/resources/worker-util.js:
(gc):
Added an optional "forceAlloc" parameter which causes a more extensive stack-clobbering algorithm to be run.
(waitUntilThreadCountMatches):
Pass the forceAlloc flag to gc() to try to force unreferenced workers to get GC'd.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubber-stamped by Sam Weinig.
bdakin@apple.com [Thu, 1 Oct 2009 20:24:08 +0000 (20:24 +0000)]
Rubber-stamped by Sam Weinig.

At bad merge at some point in the development of my patch must have
put TextRenderMode.h in a weird spot in the xcodeproj. Moving it
back where it belongs!

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 1 Oct 2009 20:12:40 +0000 (20:12 +0000)]
2009-10-01  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Remove FrameLoader::schedule* APIs
        https://bugs.webkit.org/show_bug.cgi?id=29950

        Change clients of FrameLoader::schedule* to call redirectScheduler
        directly.

        No behavior change.

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::setLocation):
        (WebCore::createWindow):
        (WebCore::JSDOMWindow::open):
        * bindings/js/JSDocumentCustom.cpp:
        (WebCore::JSDocument::setLocation):
        * bindings/js/JSLocationCustom.cpp:
        (WebCore::navigateIfAllowed):
        (WebCore::JSLocation::reload):
        * bindings/v8/V8Utilities.cpp:
        (WebCore::navigateIfAllowed):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::createWindow):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8LocationCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * dom/Document.cpp:
        (WebCore::Document::implicitClose):
        (WebCore::Document::processHttpEquiv):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::write):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::requestFrame):
        (WebCore::FrameLoader::submitForm):
        (WebCore::FrameLoader::receivedFirstData):
        * loader/FrameLoader.h:
        * loader/appcache/ApplicationCacheGroup.cpp:
        (WebCore::ApplicationCacheGroup::selectCache):
        * page/History.cpp:
        (WebCore::History::back):
        (WebCore::History::forward):
        (WebCore::History::go):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoJust removing a comment I accidentally committed earlier.
bdakin@apple.com [Thu, 1 Oct 2009 20:08:11 +0000 (20:08 +0000)]
Just removing a comment I accidentally committed earlier.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-09-30 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Thu, 1 Oct 2009 19:54:25 +0000 (19:54 +0000)]
2009-09-30  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Adler.

        Clean up use of const and mutable in StorageMap
        https://bugs.webkit.org/show_bug.cgi?id=29933

        What's the point of having every single member variable be mutable and nearly
        every method be const?  Let's clean it up.

        * storage/StorageMap.cpp:
        (WebCore::StorageMap::setIteratorToIndex):
        (WebCore::StorageMap::key):
        (WebCore::StorageMap::importItem):
        * storage/StorageMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 19:32:26 +0000 (19:32 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable Local tests for Qt.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 19:21:36 +0000 (19:21 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP loading tests for Qt.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and
bdakin@apple.com [Thu, 1 Oct 2009 19:19:34 +0000 (19:19 +0000)]
WebCore: Fix for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136

Reviewed by Dave Hyatt.

This patch makes the SVG CSS property text-rendering work with any
HTML, much like it does in Firefox. It accepts four possible input
values: auto, optimizeSpeed, optimizeLegibility, and
geometricPrecision. Right now, in this implementation, here is what
those values correspond to:

auto = optimizeSpeed = what we normally when the value's not set
optimizeLegibility = geometricPrecision = ligatures + kerning

Add new file TextRenderingMode.h to the project files.
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:

CSS support for the new CSSPropertyTextRendering
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator TextRenderingMode):
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValueKeywords.in:

All the old SVG CSS support for this property can go away. When
it's used in SVG, it will just fall into the normal HTML case.
* css/SVGCSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getSVGPropertyCSSValue):
* css/SVGCSSParser.cpp:
(WebCore::CSSParser::parseSVGValue):
* css/SVGCSSPropertyNames.in:
* css/SVGCSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applySVGProperty):
* css/SVGCSSValueKeywords.in:

FontDescription stores the m_textRendering bit.
* platform/graphics/FontDescription.h:
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::textRenderingMode):
(WebCore::FontDescription::setTextRenderingMode):
(WebCore::FontDescription::operator==):

We want to fall into the complex text rendering code path if
kerning and ligatures have been enabled with this property.
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::canUseGlyphCache):

Now takes a TextRenderingMode as a parameter.
* platform/graphics/SimpleFontData.h:

New header for the enum.
* platform/graphics/TextRenderingMode.h: Added.
(WebCore::):

getCFStringAttributes() now takes a TextRenderingMode as an
attribute.
* platform/graphics/mac/CoreTextController.cpp:
(WebCore::CoreTextController::collectCoreTextRunsForCharacters):

Enable kerning and ligatures whenever the TextRenderingMode is
OptimizeLegibility or GeometricPrecision
* platform/graphics/mac/FontMacATSUI.mm:
(WebCore::disableLigatures):
(WebCore::initializeATSUStyle):
(WebCore::ATSULayoutParameters::initialize):
* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::SimpleFontData::getCFStringAttributes):

More SVG CSS stuff that isn't needed anymore since SVG will use the
new HTML CSS implementation.
* rendering/style/SVGRenderStyle.h:
(WebCore::SVGRenderStyle::InheritedFlags::operator==):
(WebCore::SVGRenderStyle::setBitDefaults):
* rendering/style/SVGRenderStyleDefs.h:

LayoutTests: Tests for <rdar://problem/6934421> Support CSS for Text Kerning and
ligature
-and corresponding-
https://bugs.webkit.org/show_bug.cgi?id=6136

Reviewed by Dave Hyatt.

New tests.
* fast/css/parsing-text-rendering-expected.txt: Added.
* fast/css/parsing-text-rendering.html: Added.
* fast/css/resources/parsing-text-rendering.js: Added.
(test):
* fast/css/text-rendering.html: Added.
* platform/mac/fast/css/text-rendering-expected.checksum: Added.
* platform/mac/fast/css/text-rendering-expected.png: Added.
* platform/mac/fast/css/text-rendering-expected.txt: Added.

New and improved results.
* platform/mac/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.checksum:
* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.png:
* platform/mac/svg/W3C-SVG-1.1/filters-conv-01-f-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Yongjun Zhang <yongjun.zhang@nokia.com>
eric@webkit.org [Thu, 1 Oct 2009 19:18:02 +0000 (19:18 +0000)]
2009-10-01  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=29187

        Don't inline ~ListRefPtr() to work around winscw compiler forward declaration
        bug regarding templated classes.

        The compiler bug is reported at:
        https://xdabug001.ext.nokia.com/bugzilla/show_bug.cgi?id=9812

        The change will be reverted when the above bug is fixed in winscw compiler.

        * wtf/ListRefPtr.h:
        (WTF::::~ListRefPtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 19:10:56 +0000 (19:10 +0000)]
Rubberstamped by Simon Hausmann.

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable URI tests for Qt, skip the single test we don't pass.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 1 Oct 2009 18:29:31 +0000 (18:29 +0000)]
2009-10-01  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Adler.

        Add baseline pngs for a couple of tests that currently only have checksums.

        https://bugs.webkit.org/show_bug.cgi?id=28322

        * platform/mac/fast/borders/border-radius-constraints-expected.png: Added.
        * platform/mac/fast/borders/border-radius-split-inline-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRubberstamped by Simon Hausmann.
kenneth@webkit.org [Thu, 1 Oct 2009 18:14:24 +0000 (18:14 +0000)]
Rubberstamped by Simon Hausmann.

WebKitTools:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt

* Scripts/run-webkit-tests:

LayoutTests:

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2009-10-01
Enable HTTP tests for Qt, and skip the subdirs we don't pass yet.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Yaar Schnitman <yaar@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 18:08:49 +0000 (18:08 +0000)]
2009-10-01  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        Added windows-specific dependencies, updated some revisions and
        re-organized file to make revision tracking easier. Also removed
        extensions/v8 dependency that is no longer needed upstream.

        https://bugs.webkit.org/show_bug.cgi?id=29973

        * chromium/DEPS:
2009-10-01  Yaar Schnitman  <yaar@chromium.org>

        Reviewed by Dimitri Glazkov.

        build-webkit --chromium now also works on cygwin.

        https://bugs.webkit.org/show_bug.cgi?id=29973

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Yury Semikhatsky <yurys@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 17:41:07 +0000 (17:41 +0000)]
2009-10-01  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Timothy Hatcher.

        Use isClosure property of scope proxy to decide whether the
        scope is a closure.

        https://bugs.webkit.org/show_bug.cgi?id=29965

        * inspector/front-end/ScopeChainSidebarPane.js:
        (WebInspector.ScopeChainSidebarPane.prototype.update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 1 Oct 2009 17:29:32 +0000 (17:29 +0000)]
2009-10-01  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Odd color transitions on anchors with transition-property: all
        https://bugs.webkit.org/show_bug.cgi?id=29911

        When transitioning maybe-invalid colors, if the source and destination
        color are both invalid, then don't animate.

        This fixes an issue where a child element of an element running a color
        transition, with -webkit-transition-property:all, would show a color change.
        This happened because the "maybe invalid color" logic copied the color style
        into -webkit-text-fill-color for both endpoints, causing -webkit-text-fill-color
        to animate while the transition ran, and to then to disappear when the transition
        finished.

        Test: transitions/color-transition-all.html

        * page/animation/AnimationBase.cpp:
        (WebCore::PropertyWrapperMaybeInvalidColor::equals):
        (WebCore::PropertyWrapperMaybeInvalidColor::blend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Victor Wang <victorw@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 17:25:36 +0000 (17:25 +0000)]
2009-10-01  Victor Wang  <victorw@chromium.org>

        Reviewed by Oliver Hunt.

        Allow dragging a node who has child nodes.

        https://bugs.webkit.org/show_bug.cgi?id=28632

        * fast/events/drag-parent-node-expected.txt: Added.
        * fast/events/drag-parent-node.html: Added.
        * fast/events/resources/bookmark.gif: Added.
2009-10-01  Victor Wang  <victorw@chromium.org>

        Reviewed by Oliver Hunt.

        Allow dragging a node who has child nodes.

        https://bugs.webkit.org/show_bug.cgi?id=28632

        Test: fast/events/drag-parent-node.html

        * page/EventHandler.cpp:
        (WebCore::EventHandler::shouldDragAutoNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Thu, 1 Oct 2009 17:17:12 +0000 (17:17 +0000)]
2009-10-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] media player: better mute support
        https://bugs.webkit.org/show_bug.cgi?id=29960

        Handle volume and mute state with the two corresponding properties
        of playbin2.

        * platform/graphics/gtk/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivate::setMuted):
        (WebCore::MediaPlayerPrivate::setVolume):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Philippe Normand <pnormand@igalia.com>
eric@webkit.org [Thu, 1 Oct 2009 17:09:36 +0000 (17:09 +0000)]
2009-10-01  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] video sink pad template colorspace is wrong
        https://bugs.webkit.org/show_bug.cgi?id=29953

        Set sink pad template colorspace depending on byte order.

        * platform/graphics/gtk/VideoSinkGStreamer.cpp:
        (webkit_video_sink_idle_func):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Vitaly Repeshko <vitalyr@chromium.org>
eric@webkit.org [Thu, 1 Oct 2009 17:01:50 +0000 (17:01 +0000)]
2009-10-01  Vitaly Repeshko  <vitalyr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [V8] Refactored V8 event listeners:
        (This change should fix http://crbug.com/21079 and
        https://bugs.webkit.org/show_bug.cgi?id=29093.)
         o All listeners use weak handles to JS objects to avoid creating
           cycles and leaking memory.
         o "Object" variants of listeners removed.
         o All event accessor callbacks are generated.
         o Custom event accessors removed.
         o All wrappers have hidden dependencies on their listeners to
           prevent listeners from being collected.
         o All variats of getEventListener function grouped in V8DOMWrapper.
         o Pointers to C++ EventListener wrappers are stored in JS objects
           instead of event listener lists.
        https://bugs.webkit.org/show_bug.cgi?id=29825

        * WebCore.gypi: Removed "Object" listeners.
        * bindings/scripts/CodeGeneratorV8.pm: Now handles event accessors.
        * bindings/v8/DOMObjectsInclude.h:

        V8AbstractEventListener manages weak JS handle:
        * bindings/v8/V8AbstractEventListener.cpp:
        (WebCore::weakEventListenerCallback):
        (WebCore::V8AbstractEventListener::V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::~V8AbstractEventListener):
        (WebCore::V8AbstractEventListener::handleEvent):
        (WebCore::V8AbstractEventListener::disposeListenerObject):
        (WebCore::V8AbstractEventListener::setListenerObject):
        * bindings/v8/V8AbstractEventListener.h:
        (WebCore::V8AbstractEventListener::cast):
        (WebCore::V8AbstractEventListener::isLazy):
        (WebCore::V8AbstractEventListener::getListenerObject):
        (WebCore::V8AbstractEventListener::getExistingListenerObject):
        (WebCore::V8AbstractEventListener::hasExistingListenerObject):
        (WebCore::V8AbstractEventListener::disconnectFrame):
        (WebCore::V8AbstractEventListener::disconnected):
        (WebCore::V8AbstractEventListener::prepareListenerObject):
        (WebCore::V8AbstractEventListener::lineNumber):
        (WebCore::V8AbstractEventListener::virtualisAttribute):

        Grouped getEventListener functions:
        * bindings/v8/V8DOMWrapper.cpp:
        (WebCore::V8DOMWrapper::getTemplate):
        (WebCore::V8DOMWrapper::getEventListener):
        * bindings/v8/V8DOMWrapper.h:

        Removed most event listener objects bookkeeping:
        * bindings/v8/V8EventListenerList.cpp:
        * bindings/v8/V8EventListenerList.h:
        (WebCore::V8EventListenerList::findWrapper):
        (WebCore::V8EventListenerList::clearWrapper):
        (WebCore::V8EventListenerList::doFindWrapper):
        (WebCore::V8EventListenerList::getHiddenProperty):
        (WebCore::V8EventListenerList::findOrCreateWrapper):

        Added hidden properties for storing EventListener wrappers:
        * bindings/v8/V8HiddenPropertyName.cpp:
        (WebCore::V8HiddenPropertyName::listener):
        (WebCore::V8HiddenPropertyName::attributeListener):
        * bindings/v8/V8HiddenPropertyName.h:

        * bindings/v8/V8LazyEventListener.cpp:
        (WebCore::V8LazyEventListener::V8LazyEventListener):
        (WebCore::V8LazyEventListener::callListenerFunction):
        (WebCore::V8LazyEventListener::prepareListenerObject):
        * bindings/v8/V8LazyEventListener.h:
        (WebCore::V8LazyEventListener::isLazy):
        * bindings/v8/V8ObjectEventListener.cpp: Removed.
        * bindings/v8/V8ObjectEventListener.h: Removed.
        * bindings/v8/V8Proxy.cpp:
        (WebCore::V8Proxy::disconnectFrame):
        (WebCore::V8Proxy::disconnectEventListeners):
        * bindings/v8/V8Proxy.h:
        * bindings/v8/V8WorkerContextEventListener.cpp:
        (WebCore::V8WorkerContextEventListener::reportError):
        (WebCore::V8WorkerContextEventListener::getReceiverObject):
        * bindings/v8/V8WorkerContextEventListener.h:
        * bindings/v8/V8WorkerContextObjectEventListener.cpp: Removed.
        * bindings/v8/V8WorkerContextObjectEventListener.h: Removed.
        * bindings/v8/WorkerContextExecutionProxy.cpp:
        (WebCore::WorkerContextExecutionProxy::dispose):
        (WebCore::WorkerContextExecutionProxy::initContextIfNeeded):
        (WebCore::WorkerContextExecutionProxy::findOrCreateEventListener):
        * bindings/v8/WorkerContextExecutionProxy.h:
        * bindings/v8/custom/V8AbstractWorkerCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8CustomEventListener.cpp:
        (WebCore::V8EventListener::V8EventListener):
        (WebCore::V8EventListener::getListenerFunction):
        (WebCore::V8EventListener::callListenerFunction):
        * bindings/v8/custom/V8CustomEventListener.h:
        * bindings/v8/custom/V8DOMApplicationCacheCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8DedicatedWorkerContextCustom.cpp:
        * bindings/v8/custom/V8MessagePortCustom.cpp:
        (WebCore::getEventListener):
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8NotificationCenterCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8SVGElementInstanceCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WebSocketCustom.cpp:
        * bindings/v8/custom/V8WorkerContextCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8WorkerCustom.cpp:
        * bindings/v8/custom/V8XMLHttpRequestConstructor.cpp:
        * bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
        (WebCore::CALLBACK_FUNC_DECL):
        * bindings/v8/custom/V8XMLHttpRequestUploadCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake Software Input Panel requests work with QGraphicsWebView
hausmann@webkit.org [Thu, 1 Oct 2009 16:59:28 +0000 (16:59 +0000)]
Make Software Input Panel requests work with QGraphicsWebView
_and_ QWebView by sharing the event code in handleSoftwareInputPanel().

Patch by Simon Hausmann <simon.hausmann@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.

* Api/qwebpage.cpp:
(QWebPagePrivate::mouseReleaseEvent):
(QWebPagePrivate::handleSoftwareInputPanel):
* Api/qwebpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2009-10-01 Zoltan Horvath <zoltan@webkit.org>
zoltan@webkit.org [Thu, 1 Oct 2009 16:22:43 +0000 (16:22 +0000)]
2009-10-01  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Allow custom memory allocation control for the whole JavaScriptCore
        https://bugs.webkit.org/show_bug.cgi?id=27029

        Since in JavaScriptCore almost every class which has been instantiated by operator new is
        inherited from FastAllocBase (bug #20422), we disable customizing global operator new for the Qt-port
        when USE_SYSTEM_MALLOC=0.

        Add #include <unistd.h> to FastMalloc.cpp because it's used by TCMalloc_PageHeap::scavengerThread().
        (It's needed for the functionality of TCmalloc.)

        Add TCSystemAlloc.cpp to JavaScriptCore.pri if USE_SYSTEM_MALLOC is disabled.

        * JavaScriptCore.pri:
        * wtf/FastMalloc.cpp:
        (WTF::sleep):
        * wtf/FastMalloc.h:

2009-10-01  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Don't use TCmalloc in DumpRenderTree
        https://bugs.webkit.org/show_bug.cgi?id=27029

        Add USE_SYSTEM_MALLOC macro to the DRT's profile to avoid using TCmalloc in Qt's DRT.

        * DumpRenderTree/qt/DumpRenderTree.pro:

2009-10-01  Zoltan Horvath  <zoltan@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Enable TCmalloc for the Linux, Mac and Windows Qt-port
        https://bugs.webkit.org/show_bug.cgi?id=27029

        Remove USE_SYSTEM_MALLOC for Linux, Mac and Windows Qt-port from WebKit.pri,
        so these Qt-ports will use TCmalloc as other ports.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoLand expected failure results for two tests on Windows
aroben@apple.com [Thu, 1 Oct 2009 15:35:08 +0000 (15:35 +0000)]
Land expected failure results for two tests on Windows

These failures are covered by <http://webkit.org/b/29963> and
<http://webkit.org/b/29964>.

Rubber-stamped in advance by Eric Carlson.

* platform/win/fast/events/mouse-drag-from-frame-to-other-frame-expected.txt:
Added.
* platform/win/fast/forms/basic-inputs-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename QWebGraphicsItem to QGraphicsWebView
vestbo@webkit.org [Thu, 1 Oct 2009 15:28:45 +0000 (15:28 +0000)]
Rename QWebGraphicsItem to QGraphicsWebView

Patch by Alexis Menard <alexis.menard@nokia.com> on 2009-10-01
Reviewed by Tor Arne Vestbø.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@48974 268f45cc-cd09-0410-ab3c-d52691b4dbfc