WebKit-https.git
2 years agoUnreviewed test gardening for High Sierra.
ryanhaddad@apple.com [Tue, 14 Nov 2017 22:26:21 +0000 (22:26 +0000)]
Unreviewed test gardening for High Sierra.

* platform/mac-sierra/http/tests/blink/sendbeacon/beacon-same-origin-expected.txt: Added.
* platform/mac-sierra/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Renamed from LayoutTests/platform/mac-wk2/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt.
* platform/mac/http/tests/blink/sendbeacon/beacon-same-origin-expected.txt: Added.
* platform/mac/imported/w3c/web-platform-tests/beacon/headers/header-content-type-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove Cocoa CFURLConnection loading code
achristensen@apple.com [Tue, 14 Nov 2017 22:20:42 +0000 (22:20 +0000)]
Remove Cocoa CFURLConnection loading code
https://bugs.webkit.org/show_bug.cgi?id=179688

Reviewed by Antti Koivisto.

Source/WebCore:

CFURLConnection is only used on the AppleWin port now.

* PlatformMac.cmake:
* SourcesCocoa.txt:
* SourcesIOS.txt:
* WebCore.xcodeproj/project.pbxproj:
* loader/DocumentLoader.h:
* loader/EmptyFrameLoaderClient.h:
* loader/FrameLoaderClient.h:
* loader/ResourceLoader.cpp:
* loader/ResourceLoader.h:
* loader/SubresourceLoader.h:
* loader/cf/ResourceLoaderCFNet.cpp:
* loader/cocoa/SubresourceLoaderCocoa.mm:
* loader/mac/DocumentLoaderMac.cpp:
* loader/mac/ResourceLoaderMac.mm:
* page/mac/PageMac.mm:
(WebCore::Page::platformInitialize):
(WebCore::Page::addSchedulePair):
(WebCore::Page::removeSchedulePair):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForResponseToAuthenticationChallenge):
(WebCore::WebCoreNSURLAuthenticationChallengeClient::create): Deleted.
(WebCore::WebCoreNSURLAuthenticationChallengeClient::WebCoreNSURLAuthenticationChallengeClient): Deleted.
(): Deleted.
* platform/network/ProtectionSpaceBase.cpp:
* platform/network/ResourceHandle.h:
* platform/network/ResourceHandleInternal.h:
* platform/network/cf/AuthenticationCF.cpp:
(WebCore::AuthenticationChallenge::AuthenticationChallenge):
(WebCore::createCF):
(WebCore::core):
(): Deleted.
* platform/network/cf/AuthenticationCF.h:
* platform/network/cf/CookieJarCFNet.cpp:
(WebCore::copyCookiesForURLWithFirstPartyURL):
(WebCore::createCookies):
(WebCore::deleteAllCookiesModifiedSince):
* platform/network/cf/CookieStorageCFNet.cpp:
* platform/network/cf/CredentialStorageCFNet.cpp:
(WebCore::CredentialStorage::getFromPersistentStorage):
* platform/network/cf/ResourceErrorCF.cpp:
(WebCore::ResourceError::setCertificate):
(WebCore::ResourceError::platformLazyInit):
(WebCore::ResourceError::doPlatformIsolatedCopy):
(WebCore::ResourceError::cfError const):
* platform/network/cf/ResourceHandleCFNet.cpp:
* platform/network/cf/ResourceHandleCFURLConnectionDelegate.cpp:
* platform/network/cf/ResourceHandleCFURLConnectionDelegateWithOperationQueue.cpp:
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupRequest):
(WebCore::installHookToRemoveCFNetworkMessageBlockingMainThread):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::setupConnectionScheduling):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::didReceiveResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::willCacheResponse):
(WebCore::ResourceHandleCFURLConnectionDelegateWithOperationQueue::canRespondToProtectionSpace):
* platform/network/cocoa/CredentialCocoa.mm:
(WebCore::Credential::cfCredential const): Deleted.
* platform/network/cocoa/ProtectionSpaceCocoa.mm:
(WebCore::ProtectionSpace::cfSpace const): Deleted.
* platform/network/cocoa/ResourceRequestCocoa.mm:
(WebCore::ResourceRequest::nsURLRequest const):
(WebCore::ResourceRequest::clearOrUpdateNSURLRequest): Deleted.
* platform/network/cocoa/ResourceResponseCocoa.mm:
(WebCore::ResourceResponse::platformCertificateInfo const):
(WebCore::ResourceResponse::ResourceResponse): Deleted.
* platform/network/ios/ResourceHandleIOS.mm: Removed.
* platform/network/mac/AuthenticationMac.mm:
(WebCore::AuthenticationChallenge::authenticationClient const):
(WebCore::mac):
(-[WebCoreAuthenticationClientAsChallengeSender setCFChallenge:]): Deleted.
(-[WebCoreAuthenticationClientAsChallengeSender cfChallenge]): Deleted.
* platform/network/mac/ResourceHandleMac.mm:
(WebCore::synchronousWillSendRequestEnabled):
* platform/network/mac/ResourceRequestMac.mm: Removed.

Source/WebKit:

* NetworkProcess/Downloads/Download.h:

Source/WebKitLegacy:

* WebCoreSupport/WebResourceLoadScheduler.cpp:
(WebResourceLoadScheduler::scheduleLoad):

Source/WebKitLegacy/mac:

* Misc/WebDownload.mm:
(-[WebDownload _initWithLoadingCFURLConnection:request:response:delegate:proxy:]): Deleted.
* Misc/WebDownloadInternal.h:
* Plugins/WebBaseNetscapePluginView.mm:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::convertMainResourceLoadToDownload):
* WebView/WebView.mm:
(-[WebView scheduleInRunLoop:forMode:]):
(-[WebView unscheduleFromRunLoop:forMode:]):

Source/WTF:

* wtf/SchedulePair.h:
* wtf/SchedulePairMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agowebkitpy: Use more verbose version info from simctl
jbedard@apple.com [Tue, 14 Nov 2017 22:19:46 +0000 (22:19 +0000)]
webkitpy: Use more verbose version info from simctl
https://bugs.webkit.org/show_bug.cgi?id=179687
<rdar://problem/35539392>

Reviewed by Tim Horton.

* Scripts/webkitpy/xcode/simulator.py:
(Simulator): Address FIXME, use more verbose version.
(Simulator._parse_runtimes): 'Internal' no longer stands along, check os for this
string instead.
* Scripts/webkitpy/xcode/simulator_unittest.py: Mock simctl output specifies iOS
8.4.1, not iOS 8.4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r224623) [MIPS] branchTruncateDoubleToInt32() doesn't set return register...
guijemont@igalia.com [Tue, 14 Nov 2017 21:53:41 +0000 (21:53 +0000)]
REGRESSION(r224623) [MIPS] branchTruncateDoubleToInt32() doesn't set return register when branching
https://bugs.webkit.org/show_bug.cgi?id=179563

Reviewed by Carlos Alberto Lopez Perez.

When run with BranchIfTruncateSuccessful,
branchTruncateDoubleToInt32() should set the destination register
before branching.
This change also removes branchTruncateDoubleToUInt32() as it is
deprecated (see r160205), merges branchOnTruncateResult() into
branchTruncateDoubleToInt32() and adds test cases in testmasm.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branchOnTruncateResult): Deleted.
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToInt32):
Properly set dest before branching.
(JSC::MacroAssemblerMIPS::branchTruncateDoubleToUInt32): Deleted.
* assembler/testmasm.cpp:
(JSC::testBranchTruncateDoubleToInt32):
(JSC::run):
Add tests for branchTruncateDoubleToInt32().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate comment in FeatureDefines.xcconfig to reflect location of Visual Studio proper...
dbates@webkit.org [Tue, 14 Nov 2017 21:30:07 +0000 (21:30 +0000)]
Update comment in FeatureDefines.xcconfig to reflect location of Visual Studio property files
for feature defines

Following r195498 and r201917 the Visual Studio property files for feature defines have
moved from directory WebKitLibraries/win/tools/vsprops to directory Source/cmake/tools/vsprops.
Update the comment in FeatureDefines.xcconfig to reflect the new location and names of these
files.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

* Configurations/FeatureDefines.xcconfig:

Tools:

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove StyleResolver::State::document()
antti@apple.com [Tue, 14 Nov 2017 21:26:48 +0000 (21:26 +0000)]
Remove StyleResolver::State::document()
https://bugs.webkit.org/show_bug.cgi?id=179678

Reviewed by Antoine Quint.

We don't need both StyleResolver::document() and StyleResolver::State::document().

* css/StyleResolver.cpp:
(WebCore::StyleResolver::State::updateConversionData):
(WebCore::StyleResolver::resolvedVariableValue):
(WebCore::StyleResolver::colorFromPrimitiveValue const):
(WebCore::StyleResolver::createFilterOperations):
* css/StyleResolver.h:
(WebCore::StyleResolver::State::document const): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove JSDollarVMPrototype.
mark.lam@apple.com [Tue, 14 Nov 2017 21:16:24 +0000 (21:16 +0000)]
Remove JSDollarVMPrototype.
https://bugs.webkit.org/show_bug.cgi?id=179685

Reviewed by Saam Barati.

1. Move the JSDollarVMPrototype C++ utility functions into VMInspector.cpp.

   This allows us to call these functions during lldb debugging sessions using
   VMInspector::foo() instead of JSDollarVMPrototype::foo().  It makes sense that
   VMInspector provides VM debugging utility methods.  It doesn't make sense to
   have a JSDollarVMPrototype object provide these methods.

   Plus, it's shorter to type VMInspector than JSDollarVMPrototype.

2. Move the JSDollarVMPrototype JS functions into JSDollarVM.cpp.

   JSDollarVM is a special object used only for debugging purposes.  There's no
   gain in requiring its methods to be stored in a prototype object other than to
   conform to typical JS convention.  We can remove this complexity.

* JavaScriptCore.xcodeproj/project.pbxproj:
* Sources.txt:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::init):
* tools/JSDollarVM.cpp:
(JSC::JSDollarVM::addFunction):
(JSC::functionCrash):
(JSC::functionDFGTrue):
(JSC::CallerFrameJITTypeFunctor::CallerFrameJITTypeFunctor):
(JSC::CallerFrameJITTypeFunctor::operator() const):
(JSC::CallerFrameJITTypeFunctor::jitType):
(JSC::functionLLintTrue):
(JSC::functionJITTrue):
(JSC::functionGC):
(JSC::functionEdenGC):
(JSC::functionCodeBlockForFrame):
(JSC::codeBlockFromArg):
(JSC::functionCodeBlockFor):
(JSC::functionPrintSourceFor):
(JSC::functionPrintBytecodeFor):
(JSC::functionPrint):
(JSC::functionPrintCallFrame):
(JSC::functionPrintStack):
(JSC::functionValue):
(JSC::functionGetPID):
(JSC::JSDollarVM::finishCreation):
* tools/JSDollarVM.h:
(JSC::JSDollarVM::create):
* tools/JSDollarVMPrototype.cpp: Removed.
* tools/JSDollarVMPrototype.h: Removed.
* tools/VMInspector.cpp:
(JSC::VMInspector::currentThreadOwnsJSLock):
(JSC::ensureCurrentThreadOwnsJSLock):
(JSC::VMInspector::gc):
(JSC::VMInspector::edenGC):
(JSC::VMInspector::isInHeap):
(JSC::CellAddressCheckFunctor::CellAddressCheckFunctor):
(JSC::CellAddressCheckFunctor::operator() const):
(JSC::VMInspector::isValidCell):
(JSC::VMInspector::isValidCodeBlock):
(JSC::VMInspector::codeBlockForFrame):
(JSC::PrintFrameFunctor::PrintFrameFunctor):
(JSC::PrintFrameFunctor::operator() const):
(JSC::VMInspector::printCallFrame):
(JSC::VMInspector::printStack):
(JSC::VMInspector::printValue):
* tools/VMInspector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWhitelist some IOKIt properties to avoid sandbox violations on YouTube
bfulgham@apple.com [Tue, 14 Nov 2017 21:14:57 +0000 (21:14 +0000)]
Whitelist some IOKIt properties to avoid sandbox violations on YouTube
https://bugs.webkit.org/show_bug.cgi?id=179683
<rdar://problem/35415368>

Reviewed by Dean Jackson.

YouTube video playback on some hardware (and some video encodings) generates sandbox violations. Add
whitelist entries for the relevant IOKit properties needed to support these activities.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoStub implementations of OffscreenCanvas getContext and transferToImageBitmap
dino@apple.com [Tue, 14 Nov 2017 21:11:18 +0000 (21:11 +0000)]
Stub implementations of OffscreenCanvas getContext and transferToImageBitmap
https://bugs.webkit.org/show_bug.cgi?id=179671
<rdar://problem/35534018>

Reviewed by Antoine Quint.

Source/WebCore:

Empty implementations of getContext and transferToImageBitmap. At the moment
only return a WebGLRenderingContext from getContext, since we don't
have an Offscreen 2d context type yet.

Tests: http/wpt/offscreen-canvas/getContext-webgl.html
       http/wpt/offscreen-canvas/transferToImageBitmap.html

* html/OffscreenCanvas.cpp:
(WebCore::OffscreenCanvas::getContext):
(WebCore::OffscreenCanvas::transferToImageBitmap):
* html/OffscreenCanvas.h:
* html/OffscreenCanvas.idl:
* html/canvas/GPUBasedCanvasRenderingContext.h: Drive-by parameter rename.
(WebCore::GPUBasedCanvasRenderingContext::GPUBasedCanvasRenderingContext):

LayoutTests:

* http/wpt/offscreen-canvas/getContext-webgl-expected.txt: Added.
* http/wpt/offscreen-canvas/getContext-webgl.html: Added.
* http/wpt/offscreen-canvas/transferToImageBitmap-expected.txt: Added.
* http/wpt/offscreen-canvas/transferToImageBitmap.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark WebChromeClient::requestStorageAccess() as final
dbates@webkit.org [Tue, 14 Nov 2017 20:48:49 +0000 (20:48 +0000)]
Mark WebChromeClient::requestStorageAccess() as final
https://bugs.webkit.org/show_bug.cgi?id=179673

Reviewed by Sam Weinig.

Mark WebChromeClient::requestStorageAccess() as final so that it overrides the virtual function
in ChromeClient with the same name and hence we actually call it through a ChromeClient pointer.

* WebProcess/WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed test gardening for High Sierra.
ryanhaddad@apple.com [Tue, 14 Nov 2017 20:38:55 +0000 (20:38 +0000)]
Unreviewed test gardening for High Sierra.

* platform/mac/TestExpectations:
* platform/mac/editing/deleting/delete-emoji-9-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoEnable Modern EME tests in DumpRenderTree
jer.noble@apple.com [Tue, 14 Nov 2017 20:29:05 +0000 (20:29 +0000)]
Enable Modern EME tests in DumpRenderTree
https://bugs.webkit.org/show_bug.cgi?id=179544

Reviewed by Alex Christensen.

Source/WebKitLegacy/mac:

Add a WebPreferences property to enable the (modern) EME API.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):
(-[WebPreferences encryptedMediaAPIEnabled]):
(-[WebPreferences setEncryptedMediaAPIEnabled:]):
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]):

Tools:

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):

LayoutTests:

* platform/mac-wk1/TestExpectations:
* platform/mac-wk1/fast/dom/navigator-detached-no-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebSWClientConnection should do IPC to StorageProcess if its WebSWOriginTable is...
commit-queue@webkit.org [Tue, 14 Nov 2017 20:28:34 +0000 (20:28 +0000)]
WebSWClientConnection should do IPC to StorageProcess if its WebSWOriginTable is not yet initialized
https://bugs.webkit.org/show_bug.cgi?id=179668

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-14
Reviewed by Chris Dumez.

Source/WebCore:

Covered by existing updated tests.

Removing hasServiceWorkerRegisteredForOrigin and using hasServiceWorkerRegistration instead.
The former is only checking the shared map which might not be initialized at the time the function is called.
The latter is going to the StorageProcess if the map is not yet initialized.

* testing/Internals.cpp:
(WebCore::Internals::hasServiceWorkerRegisteredForOrigin): Deleted.
* testing/Internals.h:
* testing/Internals.idl:
* workers/service/server/SWClientConnection.h:

Source/WebKit:

There may be cases where the origin table is not initialized and we would think there is no service worker registration.
In such a case, we should go to the StorageProcess.
StorageProcess is now sending an IPC message back to each registered SW connection so that WebProcess will know whether its map
is correctly initialized or not.

Renaming hasServiceWorkerRegisteredForOrigin in mayHaveServiceWorkerRegisteredForOrigin.

* WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::mayHaveServiceWorkerRegisteredForOrigin const):
(WebKit::WebSWClientConnection::matchRegistration):
(WebKit::WebSWClientConnection::hasServiceWorkerRegisteredForOrigin const): Deleted.
* WebProcess/Storage/WebSWClientConnection.h:
* WebProcess/Storage/WebSWOriginTable.h:
(WebKit::WebSWOriginTable::isInitialized const):
* WebProcess/Storage/WebServiceWorkerProvider.cpp:
(WebKit::shouldHandleFetch):

LayoutTests:

Updated tests to use hasServiceWorkerRegistration instead of hasServiceWorkerRegisteredForOrigin.
Since the latter is trying to match a registration and compares scopes, we need the scopes to be set right on the tests.

* http/tests/workers/service/basic-unregister.https-expected.txt:
* http/tests/workers/service/resources/basic-register.js:
* http/tests/workers/service/resources/basic-unregister.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r224800.
commit-queue@webkit.org [Tue, 14 Nov 2017 20:22:58 +0000 (20:22 +0000)]
Unreviewed, rolling out r224800.
https://bugs.webkit.org/show_bug.cgi?id=179684

"Broke CLoop test mozilla/js1_6/Array/regress-304828.js"
(Requested by mlam on #webkit).

Reverted changeset:

"Pass --useDollarVM=true to all JSC tests."
https://bugs.webkit.org/show_bug.cgi?id=179647
https://trac.webkit.org/changeset/224800

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoConsolidate sysctl-read rules in WebProcess sandbox
bfulgham@apple.com [Tue, 14 Nov 2017 20:09:55 +0000 (20:09 +0000)]
Consolidate sysctl-read rules in WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=179674
<rdar://problem/35367154>

Reviewed by Dean Jackson.

Consolidate the various calls to 'allow sysctl-read' imported during Bug 179548 into
the main function in the sandbox profile.

Remove the statement to grant global sysctl-read permissions that was copied into this
sandbox profile in an earlier checkin. We started blocking the blanket read permissions in
macOS 10.13, and want to continue to do so.

The earlier "grant global read access" in 'system.sb' apparently allowed some sysctl reads
to occur before we hit the block declaration in the WebContent sandbox. Now that we are
consistently blocking systcl reads from the start, we need to add whitelist entries for a
few more entries to avoid creating new sandbox violations.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rebaseline skipped / flaky service worker tests
cdumez@apple.com [Tue, 14 Nov 2017 20:06:28 +0000 (20:06 +0000)]
Unreviewed, rebaseline skipped / flaky service worker tests

* web-platform-tests/service-workers/service-worker/fetch-canvas-tainting-cache.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-canvas-tainting.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-cors-xhr.https-expected.txt:
* web-platform-tests/service-workers/service-worker/fetch-request-redirect.https-expected.txt:
* web-platform-tests/service-workers/service-worker/interfaces-sw.https-expected.txt:
* web-platform-tests/service-workers/service-worker/register-same-scope-different-script-url.https-expected.txt:
* web-platform-tests/service-workers/service-worker/registration-updateviacache.https-expected.txt:
* web-platform-tests/service-workers/service-worker/skip-waiting-without-using-registration.https-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove WebKit CFURLConnection code
achristensen@apple.com [Tue, 14 Nov 2017 19:54:01 +0000 (19:54 +0000)]
Remove WebKit CFURLConnection code
https://bugs.webkit.org/show_bug.cgi?id=179645

Reviewed by Alexey Proskuryakov.

The CFURLConnection code is Windows-specific now. Nobody can use it in modern WebKit.

* NetworkProcess/Downloads/Download.h:
* NetworkProcess/Downloads/mac/DownloadMac.mm:
* NetworkProcess/NetworkLoad.h:
* NetworkProcess/cocoa/NetworkDataTaskCocoa.mm:
(WebKit::serverTrustCredential):
* NetworkProcess/mac/NetworkLoadMac.mm:
* Shared/Authentication/AuthenticationManager.cpp:
(WebKit::AuthenticationManager::useCredentialForSingleChallenge):
(WebKit::AuthenticationManager::continueWithoutCredentialForSingleChallenge):
(WebKit::AuthenticationManager::cancelSingleChallenge):
(WebKit::AuthenticationManager::performDefaultHandlingForSingleChallenge):
(WebKit::AuthenticationManager::rejectProtectionSpaceAndContinueForSingleChallenge):
* Shared/Authentication/cocoa/AuthenticationManagerCocoa.mm:
* Shared/Authentication/mac/AuthenticationManager.mac.mm:
(WebKit::AuthenticationManager::tryUseCertificateInfoForChallenge):
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode const):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* Shared/mac/WebCoreArgumentCodersMac.mm:
(IPC::ArgumentCoder<ResourceRequest>::encodePlatformData):
(IPC::ArgumentCoder<ResourceRequest>::decodePlatformData):
* config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove assertions added in r224791
achristensen@apple.com [Tue, 14 Nov 2017 19:50:30 +0000 (19:50 +0000)]
Remove assertions added in r224791
https://bugs.webkit.org/show_bug.cgi?id=178751#c10

* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
I had added assertions that sandbox extension handle consumption succeeds.
In the API test IndexedDB.StructuredCloneBackwardCompatibility we get a sandbox extension handle
to give access to a directory that does not exist and consumption fails.  We want it to fail,
so my optimistic addition of a success assertion was incorrect.  The test passes without it
and behaves like it used to.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Add a ServiceWorker domain to get information about an inspected Servi...
joepeck@webkit.org [Tue, 14 Nov 2017 19:44:18 +0000 (19:44 +0000)]
Web Inspector: Add a ServiceWorker domain to get information about an inspected ServiceWorker
https://bugs.webkit.org/show_bug.cgi?id=179640
<rdar://problem/35517361>

Reviewed by Devin Rousso.

Source/JavaScriptCore:

* CMakeLists.txt:
* DerivedSources.make:
Gate the ServiceWorker domain on the ENABLE feature flag.

* inspector/protocol/ServiceWorker.json: Added.
New domain to be made available inside of a ServiceWorker target.

Source/WebCore:

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
New files.

* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::createLazyAgents):
Add a ServiceWorkerAgent when the Worker is a ServiceWorker.

* inspector/agents/worker/ServiceWorkerAgent.h: Added.
* inspector/agents/worker/ServiceWorkerAgent.cpp: Added.
(WebCore::ServiceWorkerAgent::ServiceWorkerAgent):
(WebCore::ServiceWorkerAgent::didCreateFrontendAndBackend):
(WebCore::ServiceWorkerAgent::willDestroyFrontendAndBackend):
(WebCore::ServiceWorkerAgent::getInitializationInfo):
Populate initialization info.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDon't use -[NSString stringWithFormat:] to build defaults keys
timothy_horton@apple.com [Tue, 14 Nov 2017 19:43:25 +0000 (19:43 +0000)]
Don't use -[NSString stringWithFormat:] to build defaults keys
https://bugs.webkit.org/show_bug.cgi?id=179680

Reviewed by Simon Fraser.

* UIProcess/mac/WebPreferencesMac.mm:
(WebKit::makeKey):
(WebKit::debugUserDefaultsValue):
Use string concatenation instead of stringWithFormat to build
preference keys. This wasn't a huge cost, but it shaves a few milliseconds
off process launch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove some accidentally checked-in commented-out code.
beidson@apple.com [Tue, 14 Nov 2017 19:40:02 +0000 (19:40 +0000)]
Remove some accidentally checked-in commented-out code.

Unreviewed.

* workers/service/server/SWServer.cpp:
(WebCore::SWServer::fireInstallEvent):
(WebCore::SWServer::fireActivateEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoClean up old URL parser remnants
achristensen@apple.com [Tue, 14 Nov 2017 19:15:23 +0000 (19:15 +0000)]
Clean up old URL parser remnants
https://bugs.webkit.org/show_bug.cgi?id=179573

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/url/url-setters-expected.txt:
We're more spec compliant!  Hooray!

Source/WebCore:

When we transitioned to the new URLParser, we kept the old character tables which were less spec-conformant.
Removing them and transitioning to URLParser's table makes more web platform tests pass!

* fileapi/BlobURL.cpp:
(WebCore::BlobURL::createBlobURL):
There's no need to percent-encode an origin.  It's already ascii, and if it's not, then the URLParser will escape it.
* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::createFileURL):
Removed comment that no longer applies.
* platform/URL.cpp:
(WebCore::URL::setProtocol):
(WebCore::percentEncodeCharacters):
(WebCore::URL::setUser):
(WebCore::URL::setPass):
Percent encode the userinfo character set from the URLParser according to https://url.spec.whatwg.org/#set-the-username and https://url.spec.whatwg.org/#set-the-password
(WebCore::URL::setPath):
A ? or a # are the only two characters that need to be pre-encoded when setting the path because they indicate the
beginning of a query or fragment.  All other characters will be encoded if necessary during parsing.
(WebCore::protocolIsInternal):
(): Deleted.
(WebCore::isSchemeFirstChar): Deleted.
(WebCore::isSchemeChar): Deleted.
(WebCore::isBadChar): Deleted.
(WebCore::isTabNewline): Deleted.
(WebCore::appendEscapedChar): Deleted.
(WebCore::encodeWithURLEscapeSequences):
Encode characters needed.  I used the user info set of characters because that was most similar to the BadChar set of the old parser.
This isn't standardized, and it's only used for the search context menu item which certainly isn't standardized.
(WebCore::isValidProtocol): Deleted.
Remove a bunch of old unused functions.
* platform/URLParser.cpp:
(WebCore::URLParser::isInUserInfoEncodeSet):
(WebCore::URLParser::parseAuthority):
* platform/URLParser.h:
Expose a few functions for URL.cpp to use.

Source/WebKit:

* WebProcess/WebCoreSupport/WebContextMenuClient.cpp:
(WebKit::WebContextMenuClient::searchWithGoogle):
Use https if we do end up searching with google.

Source/WebKitLegacy/win:

* WebCoreSupport/WebContextMenuClient.cpp:
(WebContextMenuClient::searchWithGoogle):
Use https if we do end up searching with google.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoEnable display:contents by default
antti@apple.com [Tue, 14 Nov 2017 19:01:22 +0000 (19:01 +0000)]
Enable display:contents by default
https://bugs.webkit.org/show_bug.cgi?id=179655

Reviewed by Sam Weinig.

Source/WebCore:

* page/RuntimeEnabledFeatures.h:

Source/WebKit:

* Shared/WebPreferences.yaml:

Make non-experimental and enabled.

Source/WebKitLegacy/mac:

* WebView/WebPreferences.mm:
(+[WebPreferences initialize]):

Tools:

No need to enable this specifically for tests anymore.

* DumpRenderTree/mac/DumpRenderTree.mm:
(enableExperimentalFeatures):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoConsolidate mach-lookup calls in WebProcess sandbox
bfulgham@apple.com [Tue, 14 Nov 2017 18:36:27 +0000 (18:36 +0000)]
Consolidate mach-lookup calls in WebProcess sandbox
https://bugs.webkit.org/show_bug.cgi?id=179650
<rdar://problem/35367154>

Reviewed by Dean Jackson.

Consolidate the various calls to 'allow mach-lookup' imported during Bug 179548 into the main
function in the sandbox profile. Remove some entries that are not needed by WebKit.

Remove the statement to grant global permission to perform mach-lookup for any xpc
service name that was copied into this sandbox profile in Bug 179548. We started blocking
this in macOS 10.13 and want to continue to do so.

The earlier "grant global permission" in 'system.sb' apparently allowed some xpc lookups to occur
before we hit the block declaration in the WebContent sandbox. Now that we are consistently blocking
mach lookups we need to add whitelist entries for a few more services to avoid creating new
sandbox violations.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move drawLine operation from GraphicsContextCairo to CairoOperations
zandobersek@gmail.com [Tue, 14 Nov 2017 18:02:41 +0000 (18:02 +0000)]
[Cairo] Move drawLine operation from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179669

Reviewed by Carlos Garcia Campos.

Move the drawLine operation implementation into the CairoOperations
implementation file, with the Cairo::drawLine() function only expecting
a PlatformContextCairo object, two FloatingPoints, and a const reference
to a GraphicsContextState object.

As with drawLinesForText(), the drawLine() implementation utilized a few
private GraphicsContext methods that we for now reimplement in the
Cairo namespace as static functions, providing necessary state values to
perform the computations. The GraphicsContext methods should be changed
to become static public functions -- after that we'll be able to remove
the new duplicated helper functions.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::dashedLineCornerWidthForStrokeWidth):
(WebCore::Cairo::dashedLinePatternWidthForStrokeWidth):
(WebCore::Cairo::dashedLinePatternOffsetForPatternAndStrokeWidth):
(WebCore::Cairo::centerLineAndCutOffCorners):
(WebCore::Cairo::drawLine):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoLong pressing a phone number with spaces in it results in a link sheet instead of...
timothy_horton@apple.com [Tue, 14 Nov 2017 17:44:17 +0000 (17:44 +0000)]
Long pressing a phone number with spaces in it results in a link sheet instead of a data detectors sheet
https://bugs.webkit.org/show_bug.cgi?id=179646
<rdar://problem/35337288>

Reviewed by Simon Fraser.

Source/WebCore:

* editing/cocoa/DataDetection.h:
* editing/cocoa/DataDetection.mm:
(WebCore::DataDetection::canBePresentedByDataDetectors):
(WebCore::DataDetection::isDataDetectorLink):
Expose canBePresentedByDataDetectors, which tests if the URL's
scheme is one of Data Detectors' known long-press schemes.

Source/WebKit:

* UIProcess/ios/WKActionSheetAssistant.mm:
(-[WKActionSheetAssistant showImageSheet]):
(-[WKActionSheetAssistant showLinkSheet]):
(-[WKActionSheetAssistant showDataDetectorsSheet]):
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _actionForLongPressFromPositionInformation:]):
(-[WKContentView _interactionShouldBeginFromPreviewItemController:forPosition:]):
Make use of canBePresentedByDataDetectors with our WebCore URL instead
of (sometimes unsucessfully) reparsing the URL with NSURL's parser.
Also, avoid a few unnecessary round-trips through String when converting
from URL to NSURL.

Tools:

* TestWebKitAPI/Tests/ios/ActionSheetTests.mm:
(-[ActionSheetObserver _dataDetectionContextForWebView:]):
(TestWebKitAPI::TEST):
Add a test that ensures that a phone number with spaces in it
invokes a data detectors sheet, not a normal link sheet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[DFG][FTL] Support Array::DirectArguments with OutOfBounds
utatane.tea@gmail.com [Tue, 14 Nov 2017 17:35:33 +0000 (17:35 +0000)]
[DFG][FTL] Support Array::DirectArguments with OutOfBounds
https://bugs.webkit.org/show_bug.cgi?id=179594

Reviewed by Saam Barati.

JSTests:

* stress/direct-arguments-in-bounds-to-out-of-bounds.js: Added.
(shouldBe):
(args):
* stress/direct-arguments-out-of-bounds-watchpoint.js: Added.
(shouldBe):
(args):

Source/JavaScriptCore:

Currently we handle OOB access to DirectArguments as GetByVal(Array::Generic).
If we can handle it as GetByVal(Array::DirectArguments+OutOfBounds), we can (1) optimize
`arguments[i]` accesses if i is in bound, and (2) encourage arguments elimination phase
to convert CreateDirectArguments and GetByVal(Array::DirectArguments+OutOfBounds) to
PhantomDirectArguments and GetMyArgumentOutOfBounds respectively.

This patch introduces Array::DirectArguments+OutOfBounds array mode. GetByVal can
accept this type, and emit optimized code compared to Array::Generic case.

We make OOB check failures in GetByVal(Array::DirectArguments+InBounds) as OutOfBounds
exit instead of ExoticObjectMode.

This change significantly improves SixSpeed rest.es5 since it uses OOB access.
Our arguments elimination phase can change CreateDirectArguments to PhantomDirectArguments.

    rest.es5                       59.6719+-2.2440     ^      3.1634+-0.5507        ^ definitely 18.8635x faster

* dfg/DFGArgumentsEliminationPhase.cpp:
* dfg/DFGArrayMode.cpp:
(JSC::DFG::ArrayMode::refine const):
* dfg/DFGClobberize.h:
(JSC::DFG::clobberize):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
(JSC::FTL::DFG::LowerDFGToB3::compileGetMyArgumentByVal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK][WPE] Don't require brotli
mcatanzaro@igalia.com [Tue, 14 Nov 2017 17:18:06 +0000 (17:18 +0000)]
[GTK][WPE] Don't require brotli
https://bugs.webkit.org/show_bug.cgi?id=178122

Reviewed by Frédéric Wang.

Remove stray remaining use of brotli CMake variable.

* CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r224799): WebKit crashes on Sierra due to sandbox violation
bfulgham@apple.com [Tue, 14 Nov 2017 16:37:29 +0000 (16:37 +0000)]
REGRESSION(r224799): WebKit crashes on Sierra due to sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=179656

Unreviewed build fix.

* WebProcess/com.apple.WebProcess.sb.in: Switch to Dan's recommended version check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd committer status for Emilio Cobos Álvarez.
emilio@crisal.io [Tue, 14 Nov 2017 15:47:11 +0000 (15:47 +0000)]
Add committer status for Emilio Cobos Álvarez.
https://bugs.webkit.org/show_bug.cgi?id=179667

Unreviewed.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move drawLinesForText operation from GraphicsContextCairo to CairoOperations
zandobersek@gmail.com [Tue, 14 Nov 2017 13:45:09 +0000 (13:45 +0000)]
[Cairo] Move drawLinesForText operation from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179661

Reviewed by Carlos Garcia Campos.

Encapsulate the drawLinesForText() operation in the WebCore::Cairo
namespace. Apart from moving gist of the code from GraphicsContextCairo
to CairoOperations, we also (for the moment) have to duplicate the
GraphicsContext::computeLineBoundsAndAntialiasingModeForText() code.
This is necessary because the given method is private on the
GraphicsContext class, and relies on an underlying GraphicsContext
object to retrieve the current CTM and stroke thickness values.

The adjusted reimplementation uses PlatformContextCairo to retrieve
the CTM (just like Cairo's GraphicsContext::getCTM() does), and
requires the stroke thickness value to be passed in as an argument.
Similar modifications will be proposed for the existing
GraphicsContext::computeLineBoundsAndAntialiasingModeForText() code,
and once that's approved the duplicated code will be eliminated.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::computeLineBoundsAndAntialiasingModeForText):
(WebCore::Cairo::drawLinesForText):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawLinesForText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move native image drawing operation to CairoOperations
zandobersek@gmail.com [Tue, 14 Nov 2017 13:42:14 +0000 (13:42 +0000)]
[Cairo] Move native image drawing operation to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179660

Reviewed by Carlos Garcia Campos.

Unify the native image drawing operation behavior between the
Cairo-specific GraphicsContext and drawNativeImage() implementations and
then move the code into the Cairo::drawNativeImage() function, inside
the CairoOperations implementation file.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::cairoSurfaceHasAlpha):
(WebCore::Cairo::drawNativeImage):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawNativeImage):
* platform/graphics/cairo/NativeImageCairo.cpp:
(WebCore::drawNativeImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd some bug numbers for failing XHR tests
Ms2ger@igalia.com [Tue, 14 Nov 2017 13:23:55 +0000 (13:23 +0000)]
Add some bug numbers for failing XHR tests
https://bugs.webkit.org/show_bug.cgi?id=179664

Unreviewed test gardening.

* TestExpectations:
* platform/gtk/TestExpectations:
  The two send-entity-body tests were not marked as failing anywhere,
  so the annotations here were superfluous.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake the gigacage runway 32GB
sbarati@apple.com [Tue, 14 Nov 2017 09:08:06 +0000 (09:08 +0000)]
Make the gigacage runway 32GB
https://bugs.webkit.org/show_bug.cgi?id=175062

Reviewed by Mark Lam.

Making the gigacage runway 32GB defends us against buffer overflows in the
cage reaching memory outside the cage assuming indices are 32-bit unsigned
integers and the type they're indexing into has size <= 8 bytes. This is
exactly the case for many things in JSC. For example, butterfly access in
JSC meet this criteria, as does typed array access.

The 32GB comes from 8 * 2^32 = 32GB.

* bmalloc/Gigacage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWe need to set topCallFrame when calling Wasm::Memory::grow from the JIT
sbarati@apple.com [Tue, 14 Nov 2017 09:05:33 +0000 (09:05 +0000)]
We need to set topCallFrame when calling Wasm::Memory::grow from the JIT
https://bugs.webkit.org/show_bug.cgi?id=179639
<rdar://problem/35513018>

Reviewed by JF Bastien.

JSTests:

* wasm/function-tests/grow-memory-cause-gc.js: Added.
(escape):
(i.func):

Source/JavaScriptCore:

Calling Wasm::Memory::grow from the JIT may cause us to GC. When we GC, we will
walk the stack for ShadowChicken (and maybe other things). We weren't updating
topCallFrame when calling grow from the Wasm JIT. This would cause the GC to
use stale topCallFrame bits in VM, often leading to crashes. This patch fixes
this bug by giving Wasm::Instance a lambda that is called when we need to store
the topCallFrame. Users of Wasm::Instance can provide a function to do this action.
Currently, JSWebAssemblyInstance passes in a lambda that stores to
VM.topCallFrame.

* wasm/WasmB3IRGenerator.cpp:
(JSC::Wasm::B3IRGenerator::addGrowMemory):
* wasm/WasmInstance.cpp:
(JSC::Wasm::Instance::Instance):
(JSC::Wasm::Instance::create):
* wasm/WasmInstance.h:
(JSC::Wasm::Instance::storeTopCallFrame):
* wasm/js/JSWebAssemblyInstance.cpp:
(JSC::JSWebAssemblyInstance::create):
* wasm/js/JSWebAssemblyInstance.h:
* wasm/js/WasmToJS.cpp:
(JSC::Wasm::wasmToJSException):
* wasm/js/WebAssemblyInstanceConstructor.cpp:
(JSC::constructJSWebAssemblyInstance):
* wasm/js/WebAssemblyPrototype.cpp:
(JSC::instantiate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Perform GraphicsContextPlatformPrivate method calls from CairoOperations
zandobersek@gmail.com [Tue, 14 Nov 2017 08:56:15 +0000 (08:56 +0000)]
[Cairo] Perform GraphicsContextPlatformPrivate method calls from CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179657

Reviewed by Carlos Garcia Campos.

To enable encapsulating remaining Cairo operations in static functions
inside the WebCore::Cairo namespace, we have to work around the
GraphicsContextPlatformPrivate methods that are invoked in the current
GraphicsContext implementation for Cairo.

A pointer to the GraphicsContextPlatformPrivate object is now kept on
the PlatformContextCairo instance, and we take care of setting it up
and clearing it out appropriate to the GraphicsContextPlatformPrivate
lifetime (as managed in Cairo-specific GraphicsContext implementation).
The GraphicsContextPlatformPrivate method invocations are then moved
to the appropriate CairoOperations functions.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::State::setCTM):
(WebCore::Cairo::save):
(WebCore::Cairo::restore):
(WebCore::Cairo::translate):
(WebCore::Cairo::rotate):
(WebCore::Cairo::scale):
(WebCore::Cairo::concatCTM):
(WebCore::Cairo::clip):
(WebCore::Cairo::clipPath):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::GraphicsContext):
(WebCore::GraphicsContext::platformInit):
(WebCore::GraphicsContext::platformDestroy):
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):
* platform/graphics/cairo/PlatformContextCairo.h:
(WebCore::PlatformContextCairo::graphicsContextPrivate):
(WebCore::PlatformContextCairo::setGraphicsContextPrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move simpler draw operations from GraphicsContextCairo to CairoOperations
zandobersek@gmail.com [Tue, 14 Nov 2017 08:50:12 +0000 (08:50 +0000)]
[Cairo] Move simpler draw operations from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179614

Reviewed by Carlos Garcia Campos.

Move operations that perform simpler drawing to the CairoOperations
file. This isolates the Cairo code and encapsulates operation work
into a limited scope. This patch only covers drawing patterns,
rectangles, document marker lines and ellipses. A missing forward
declaration for the drawGlyphs() function is also added in the
CairoOperations header.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawPattern):
(WebCore::Cairo::drawRect):
(WebCore::Cairo::drawLineForDocumentMarker):
(WebCore::Cairo::drawEllipse):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawRect):
(WebCore::GraphicsContext::drawEllipse):
(WebCore::GraphicsContext::drawLineForDocumentMarker):
(WebCore::GraphicsContext::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Cleanup navigation bar dividers and separators
mattbaker@apple.com [Tue, 14 Nov 2017 08:49:13 +0000 (08:49 +0000)]
Web Inspector: Cleanup navigation bar dividers and separators
https://bugs.webkit.org/show_bug.cgi?id=179654
<rdar://problem/35523734>

Reviewed by Devin Rousso.

Update path separator icon, and reduce number of dividers used in the
content browser's navigation bar, to more closely match modern Xcode.

* UserInterface/Images/HierarchicalNavigationItemChevron.svg:
Update icon, remove tapered arrow head.

* UserInterface/Views/ContentBrowser.js:
(WI.ContentBrowser):
Remove divider between back/forward buttons and item name.
(WI.ContentBrowser.prototype._updateContentViewNavigationItems):

* UserInterface/Views/HierarchicalPathComponent.css:
(.hierarchical-path-component > .separator):

* UserInterface/Views/LogContentView.js:
(WI.LogContentView.prototype.get navigationItems):
Remove dividers between buttons provided by the current content view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoGive a ServiceWorker WebContentProcess a different display name
commit-queue@webkit.org [Tue, 14 Nov 2017 07:34:06 +0000 (07:34 +0000)]
Give a ServiceWorker WebContentProcess a different display name
https://bugs.webkit.org/show_bug.cgi?id=179653

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-11-13
Reviewed by Brady Eidson.

Source/WebCore:

* English.lproj/Localizable.strings:

Source/WebKit:

* UIProcess/WebProcessProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::create):
Call connect after construction so virtual methods will use subclass implementations.

* UIProcess/ServiceWorkerProcessProxy.h:
* UIProcess/ServiceWorkerProcessProxy.cpp:
(WebKit::ServiceWorkerProcessProxy::create):
Copy the pattern from WebProcessProxy to ensure connect() gets called after construction.

(WebKit::ServiceWorkerProcessProxy::getLaunchOptions):
Set a launch option to signal this is a Service Worker process.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceInitializerDelegate::getExtraInitializationData):
* WebProcess/cocoa/WebProcessCocoa.mm:
(WebKit::WebProcess::initializeProcessName):
Consume the launch option to configuration the process name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r224799): WebKit crashes at launch on macOS Sierra due to a sandbox violation
rniwa@webkit.org [Tue, 14 Nov 2017 07:26:35 +0000 (07:26 +0000)]
REGRESSION(r224799): WebKit crashes at launch on macOS Sierra due to a sandbox violation
https://bugs.webkit.org/show_bug.cgi?id=179656

Unreviewed. Revert r224799 on macOS Sierra.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSend ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers
cdumez@apple.com [Tue, 14 Nov 2017 06:21:43 +0000 (06:21 +0000)]
Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers
https://bugs.webkit.org/show_bug.cgi?id=179649

Reviewed by Brady Eidson.

LayoutTests/imported/w3c:

Rebaseline a couple of WPT tests that are now passing.

* web-platform-tests/service-workers/service-worker/register-wait-forever-in-install-worker.https-expected.txt:
* web-platform-tests/service-workers/service-worker/skip-waiting.https-expected.txt:

Source/WebCore:

Send ServiceWorkerData structs to the WebProcesses instead of ServiceWorkerIdentifiers so that the
WebProcesses can correctly construct ServiceWorker objects, with the right attributes / state.

No new tests, rebaselined existing tests.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* workers/service/ServiceWorker.cpp:
(WebCore::ServiceWorker::getOrCreate):
(WebCore::ServiceWorker::ServiceWorker):
(WebCore::ServiceWorker::~ServiceWorker):
(WebCore::ServiceWorker::scheduleTaskToUpdateState):
(WebCore::ServiceWorker::postMessage):
* workers/service/ServiceWorker.h:
* workers/service/ServiceWorkerContainer.cpp:
(WebCore::ServiceWorkerContainer::scheduleTaskToUpdateRegistrationState):
* workers/service/ServiceWorkerContainer.h:
* workers/service/ServiceWorkerData.cpp: Copied from Source/WebCore/workers/service/ServiceWorkerRegistrationData.cpp.
(WebCore::ServiceWorkerData::isolatedCopy const):
* workers/service/ServiceWorkerData.h: Copied from Source/WebCore/workers/service/server/SWServerWorker.cpp.
(WebCore::ServiceWorkerData::encode const):
(WebCore::ServiceWorkerData::decode):
* workers/service/ServiceWorkerRegistration.cpp:
(WebCore::ServiceWorkerRegistration::ServiceWorkerRegistration):
(WebCore::ServiceWorkerRegistration::updateStateFromServer):
* workers/service/ServiceWorkerRegistration.h:
* workers/service/ServiceWorkerRegistrationData.cpp:
(WebCore::ServiceWorkerRegistrationData::isolatedCopy const):
* workers/service/ServiceWorkerRegistrationData.h:
(WebCore::ServiceWorkerRegistrationData::encode const):
(WebCore::ServiceWorkerRegistrationData::decode):
* workers/service/server/SWClientConnection.cpp:
(WebCore::SWClientConnection::postMessageToServiceWorkerClient):
(WebCore::SWClientConnection::updateRegistrationState):
* workers/service/server/SWClientConnection.h:
* workers/service/server/SWServer.h:
* workers/service/server/SWServerRegistration.cpp:
(WebCore::SWServerRegistration::updateRegistrationState):
(WebCore::SWServerRegistration::data const):
* workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::SWServerWorker):
(WebCore::m_script):
* workers/service/server/SWServerWorker.h:
(WebCore::SWServerWorker::scriptURL const):
(WebCore::SWServerWorker::type const):
(WebCore::SWServerWorker::identifier const):
(WebCore::SWServerWorker::state const):
(WebCore::SWServerWorker::setState):
(WebCore::SWServerWorker::data const):

Source/WebKit:

* Shared/WebCoreArgumentCoders.h:
* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::updateRegistrationStateInClient):
(WebKit::WebSWServerConnection::postMessageToServiceWorkerClient):
* StorageProcess/ServiceWorker/WebSWServerConnection.h:
* WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::postMessageToServiceWorkerClient):
* WebProcess/Storage/WebSWClientConnection.h:
* WebProcess/Storage/WebSWClientConnection.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoiOS: Enable release asserts in updateStyleIfNeeded() and updateLayout() for WebKit2
rniwa@webkit.org [Tue, 14 Nov 2017 06:03:07 +0000 (06:03 +0000)]
iOS: Enable release asserts in updateStyleIfNeeded() and updateLayout() for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=179651

Reviewed by Antti Koivisto.

r224604 disabled the release assertions on iOS entirely even though the underlying bug only affected iOS WebKit1 port
due to various time constraints. Enable them back on iOS WebKit2 port.

* dom/Document.cpp:
(WebCore::isSafeToUpdateStyleOrLayout):
(WebCore::Document::updateStyleIfNeeded):
(WebCore::Document::updateLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove pointer caging for HashMapImpl, JSLexicalEnvironment, DirectArguments, ScopedA...
sbarati@apple.com [Tue, 14 Nov 2017 05:33:30 +0000 (05:33 +0000)]
Remove pointer caging for HashMapImpl, JSLexicalEnvironment, DirectArguments, ScopedArguments, and ScopedArgumentsTable
https://bugs.webkit.org/show_bug.cgi?id=179203

Reviewed by Yusuke Suzuki.

This patch only removes the pointer caging for the described types in the title.
These types still allocate out of the gigacage. This is a just a cost vs benefit
tradeoff of performance vs security.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileGetByValOnDirectArguments):
(JSC::DFG::SpeculativeJIT::compileGetByValOnScopedArguments):
* ftl/FTLLowerDFGToB3.cpp:
(JSC::FTL::DFG::LowerDFGToB3::compileGetByVal):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitDirectArgumentsGetByVal):
(JSC::JIT::emitScopedArgumentsGetByVal):
* runtime/DirectArguments.h:
(JSC::DirectArguments::storage):
* runtime/HashMapImpl.cpp:
(JSC::HashMapImpl<HashMapBucket>::visitChildren):
* runtime/HashMapImpl.h:
* runtime/JSLexicalEnvironment.h:
(JSC::JSLexicalEnvironment::variables):
* runtime/ScopedArguments.h:
(JSC::ScopedArguments::overflowStorage const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMassive "Server-process-to-context-process" connection overhaul.
beidson@apple.com [Tue, 14 Nov 2017 03:58:01 +0000 (03:58 +0000)]
Massive "Server-process-to-context-process" connection overhaul.
https://bugs.webkit.org/show_bug.cgi?id=179554

Reviewed by Chris Dumez.

Source/WebCore:

No new tests (Refactor, no behavior change).

Having the SWServer::Connection object be overloaded to mean both client->server and server->context
was the wrong design and was starting to crumble under its own weight.

So this patch introduces a SWServerToContextConnection to manage the StorageProcess-side of connections
to context processes.

Any message that is specifically about the connection between the StorageProcess and context process
should use this connection going forward.

Right now there is only one context process, but this design keeps us ready for that to change.

This patch also gets rid of a lot of "server connection identifier" integers being passed amongst processes
that were actually pointless.

This patch is also a prerequisite for many things that are coming up soon, such as termination.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:

* workers/service/ServiceWorkerContextData.cpp:
(WebCore::ServiceWorkerContextData::isolatedCopy const):
* workers/service/ServiceWorkerContextData.h:
(WebCore::ServiceWorkerContextData::encode const):
(WebCore::ServiceWorkerContextData::decode):

* workers/service/ServiceWorkerGlobalScope.cpp:
(WebCore::ServiceWorkerGlobalScope::ServiceWorkerGlobalScope):
* workers/service/ServiceWorkerGlobalScope.h:
(WebCore::ServiceWorkerGlobalScope::serverConnectionIdentifier const): Deleted.

* workers/service/ServiceWorkerTypes.h:

* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::ServiceWorkerThread):
(WebCore::ServiceWorkerThread::createWorkerGlobalScope):
* workers/service/context/ServiceWorkerThread.h:
(WebCore::ServiceWorkerThread::serverConnectionIdentifier const): Deleted.

* workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::ServiceWorkerThreadProxy):
(WebCore::ServiceWorkerThreadProxy::create): Deleted.
* workers/service/context/ServiceWorkerThreadProxy.h:

* workers/service/server/SWServer.cpp:
(WebCore::generateServiceWorkerIdentifier):
(WebCore::SWServer::~SWServer):
(WebCore::SWServer::SWServer):
(WebCore::SWServer::scriptContextFailedToStart):
(WebCore::SWServer::scriptContextStarted):
(WebCore::SWServer::didFinishInstall):
(WebCore::SWServer::didFinishActivation):
(WebCore::SWServer::didResolveRegistrationPromise):
(WebCore::SWServer::updateWorker):
(WebCore::SWServer::serverToContextConnectionCreated):
(WebCore::SWServer::installContextData):
(WebCore::SWServer::fireInstallEvent):
(WebCore::SWServer::fireActivateEvent):
(WebCore::SWServer::Connection::didFinishInstall): Deleted.
(WebCore::SWServer::Connection::didFinishActivation): Deleted.
(WebCore::SWServer::Connection::setServiceWorkerHasPendingEvents): Deleted.
(WebCore::SWServer::Connection::scriptContextFailedToStart): Deleted.
(WebCore::SWServer::Connection::scriptContextStarted): Deleted.
(WebCore::SWServer::setServiceWorkerHasPendingEvents): Deleted.
* workers/service/server/SWServer.h:

* workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::scriptContextFailedToStart):
(WebCore::SWServerJobQueue::scriptContextStarted):
(WebCore::SWServerJobQueue::install):
(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
(WebCore::SWServerJobQueue::didFinishInstall):
(WebCore::SWServerJobQueue::tryActivate):
(WebCore::SWServerJobQueue::activate):
* workers/service/server/SWServerJobQueue.h:

* workers/service/server/SWServerRegistration.cpp:
(WebCore::generateServiceWorkerRegistrationIdentifier):

* workers/service/server/SWServerToContextConnection.cpp: Added.
(WebCore::generateServerToContextConnectionIdentifier):
(WebCore::SWServerToContextConnection::SWServerToContextConnection):
(WebCore::SWServerToContextConnection::~SWServerToContextConnection):
(WebCore::SWServerToContextConnection::connectionForIdentifier):
(WebCore::SWServerToContextConnection::globalServerToContextConnection):
(WebCore::SWServerToContextConnection::scriptContextFailedToStart):
(WebCore::SWServerToContextConnection::scriptContextStarted):
(WebCore::SWServerToContextConnection::didFinishInstall):
(WebCore::SWServerToContextConnection::didFinishActivation):
(WebCore::SWServerToContextConnection::setServiceWorkerHasPendingEvents):
* workers/service/server/SWServerToContextConnection.h: Copied from Source/WebCore/workers/service/server/SWServerWorker.h.
(WebCore::SWServerToContextConnection::identifier const):

* workers/service/server/SWServerWorker.cpp:
(WebCore::SWServerWorker::existingWorkerForIdentifier):
(WebCore::SWServerWorker::SWServerWorker):
(WebCore::SWServerWorker::~SWServerWorker):
(WebCore::SWServerWorker::scriptContextFailedToStart):
(WebCore::SWServerWorker::scriptContextStarted):
(WebCore::SWServerWorker::didFinishInstall):
(WebCore::SWServerWorker::didFinishActivation):
* workers/service/server/SWServerWorker.h:
(WebCore::SWServerWorker::create):
(WebCore::SWServerWorker::registrationKey const):
(WebCore::SWServerWorker::contextConnectionIdentifier const):

Source/WebKit:

* DerivedSources.make:
* WebKit.xcodeproj/project.pbxproj:

* Shared/WebCoreArgumentCoders.h:

* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::sendToContextProcess):
(WebKit::WebSWServerConnection::installServiceWorkerContext): Deleted.
(WebKit::WebSWServerConnection::fireInstallEvent): Deleted.
(WebKit::WebSWServerConnection::fireActivateEvent): Deleted.
(WebKit::WebSWServerConnection::setContextConnection): Deleted.
* StorageProcess/ServiceWorker/WebSWServerConnection.h:

* StorageProcess/ServiceWorker/WebSWServerToContextConnection.cpp: Copied from Source/WebCore/workers/service/server/SWServerWorker.cpp.
(WebKit::WebSWServerToContextConnection::WebSWServerToContextConnection):
(WebKit::WebSWServerToContextConnection::messageSenderConnection):
(WebKit::WebSWServerToContextConnection::messageSenderDestinationID):
(WebKit::WebSWServerToContextConnection::connectionClosed):
(WebKit::WebSWServerToContextConnection::installServiceWorkerContext):
(WebKit::WebSWServerToContextConnection::fireInstallEvent):
(WebKit::WebSWServerToContextConnection::fireActivateEvent):
* StorageProcess/ServiceWorker/WebSWServerToContextConnection.h: Copied from Source/WebCore/workers/service/ServiceWorkerTypes.h.
(WebKit::WebSWServerToContextConnection::create):
(WebKit::WebSWServerToContextConnection::ipcConnection const):
* StorageProcess/ServiceWorker/WebSWServerToContextConnection.messages.in: Copied from Source/WebKit/WebProcess/Storage/WebSWContextManagerConnection.messages.in.

* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::didClose):
(WebKit::StorageProcess::didReceiveMessage):
(WebKit::StorageProcess::globalServerToContextConnection):
(WebKit::StorageProcess::createServerToContextConnection):
(WebKit::StorageProcess::didGetWorkerContextProcessConnection):
(WebKit::StorageProcess::workerContextProcessConnection): Deleted.
(WebKit::StorageProcess::createWorkerContextProcessConnection): Deleted.
(WebKit::StorageProcess::serviceWorkerContextFailedToStart): Deleted.
(WebKit::StorageProcess::serviceWorkerContextStarted): Deleted.
(WebKit::StorageProcess::didFinishServiceWorkerInstall): Deleted.
(WebKit::StorageProcess::didFinishServiceWorkerActivation): Deleted.
(WebKit::StorageProcess::setServiceWorkerHasPendingEvents): Deleted.
* StorageProcess/StorageProcess.h:
* StorageProcess/StorageProcess.messages.in:

* StorageProcess/StorageToWebProcessConnection.cpp:
(WebKit::StorageToWebProcessConnection::didReceiveMessage):
(WebKit::StorageToWebProcessConnection::establishSWServerConnection):
(WebKit::StorageToWebProcessConnection::workerContextProcessConnectionCreated):

* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::installServiceWorker):
(WebKit::WebSWContextManagerConnection::serviceWorkerStartedWithMessage):
(WebKit::WebSWContextManagerConnection::fireInstallEvent):
(WebKit::WebSWContextManagerConnection::fireActivateEvent):
(WebKit::WebSWContextManagerConnection::didFinishInstall):
(WebKit::WebSWContextManagerConnection::didFinishActivation):
(WebKit::WebSWContextManagerConnection::setServiceWorkerHasPendingEvents):
* WebProcess/Storage/WebSWContextManagerConnection.h:
* WebProcess/Storage/WebSWContextManagerConnection.messages.in:

Source/WTF:

* wtf/ObjectIdentifier.h:
(WTF::generateObjectIdentifier):
(WTF::makeObjectIdentifier): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoPass --useDollarVM=true to all JSC tests.
mark.lam@apple.com [Tue, 14 Nov 2017 02:59:37 +0000 (02:59 +0000)]
Pass --useDollarVM=true to all JSC tests.
https://bugs.webkit.org/show_bug.cgi?id=179647

Reviewed by Saam Barati.

* Scripts/run-jsc-stress-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWebContent sandbox should not include 'system.sb'
bfulgham@apple.com [Tue, 14 Nov 2017 02:58:36 +0000 (02:58 +0000)]
WebContent sandbox should not include 'system.sb'
https://bugs.webkit.org/show_bug.cgi?id=179548
<rdar://problem/35367154>

Reviewed by Darin Adler.

Stop including 'system.sb', and just include the portions of that sandbox that we
actually use in WebContent Process. This is the first step in some further sandbox
tightening.

* WebProcess/com.apple.WebProcess.sb.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed build fix after r224791.
don.olmstead@sony.com [Tue, 14 Nov 2017 02:39:29 +0000 (02:39 +0000)]
Unreviewed build fix after r224791.

* platform/network/NetworkStorageSessionStub.cpp:
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMinor DisplayRefreshMonitor-related cleanup
simon.fraser@apple.com [Tue, 14 Nov 2017 02:28:36 +0000 (02:28 +0000)]
Minor DisplayRefreshMonitor-related cleanup
https://bugs.webkit.org/show_bug.cgi?id=179648

Reviewed by Alex Christensen.

Use more "#pragma once" and C++ initializers.

Make more member functions of DisplayRefreshMonitor protected.

Improve the ordering of member variables.

Don't mix member variables and member functions in the declaration of ScriptedAnimationController.

* dom/ScriptedAnimationController.h:
* platform/graphics/DisplayRefreshMonitor.cpp:
(WebCore::DisplayRefreshMonitor::DisplayRefreshMonitor):
(WebCore::DisplayRefreshMonitor::displayDidRefresh):
* platform/graphics/DisplayRefreshMonitor.h:
(WebCore::DisplayRefreshMonitor::mutex):
* platform/graphics/DisplayRefreshMonitorManager.h:
* platform/graphics/mac/DisplayRefreshMonitorMac.cpp:
(WebCore::DisplayRefreshMonitorMac::DisplayRefreshMonitorMac):
* platform/graphics/mac/DisplayRefreshMonitorMac.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWhen navigating back to a page, compositing layers may not use accelerated drawing
simon.fraser@apple.com [Tue, 14 Nov 2017 02:01:40 +0000 (02:01 +0000)]
When navigating back to a page, compositing layers may not use accelerated drawing
https://bugs.webkit.org/show_bug.cgi?id=178749
rdar://problem/35158946

Reviewed by Dean Jackson.
Source/WebCore:

There were two issues with setting GraphicsLayerCA's "acceleratesDrawing" state which
occurred on back navigation, related to the ordering of style recalcs and layout.

First, at style recalc time, we created a RenderLayerCompositor but hadn't yet called
its cacheAcceleratedCompositingFlags(), so any layers created during style update
didn't get accelerated drawing. Fix by making cacheAcceleratedCompositingFlags() internal
to RenderLayerCompositor and calling it from willRecalcStyle() and updateCompositingLayers().

We have to be careful to avoid m_forceCompositingMode flip-flopping between cacheAcceleratedCompositingFlags()
and cacheAcceleratedCompositingFlagsAfterLayout(), since, for subframes, it depends on layout.

Secondly, GraphicsLayerCA::commitLayerChangesBeforeSublayers() needs to updateAcceleratesDrawing()
before updating tiles, so that new tiles fetch the right acceleratesDrawing state from
the TileController.

Test: compositing/accelerated-layers-after-back.html

* page/FrameView.cpp:
(WebCore::FrameView::updateCompositingLayersAfterLayout):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::willRecalcStyle):
(WebCore::RenderLayerCompositor::didRecalcStyleWithNoPendingLayout):
(WebCore::RenderLayerCompositor::updateCompositingLayers):
* rendering/RenderLayerCompositor.h:

Source/WebKit:

Avoid assertions when a test enables accelerated drawing (which we can't support
in the iOS simulator).

* Shared/RemoteLayerTree/RemoteLayerBackingStore.mm:
(WebKit::RemoteLayerBackingStore::ensureBackingStore):

Tools:

Fix WTR and DRT to parse "useAcceleratedDrawing" out of "webkit-test-runner" options
and use it to set the state of the web view.

* DumpRenderTree/TestOptions.h:
* DumpRenderTree/TestOptions.mm:
(TestOptions::TestOptions):
* DumpRenderTree/mac/DumpRenderTree.mm:
(setWebPreferencesForTestOptions):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::resetPreferencesToConsistentValues):
(WTR::updateTestOptionsFromTestHeader):
* WebKitTestRunner/TestOptions.h:
(WTR::TestOptions::hasSameInitializationOptions const):

LayoutTests:

Moved iframes/resources/page-cache-helper.html up to compositing/resources/go-back.html.

* compositing/accelerated-layers-after-back-expected.txt: Added.
* compositing/accelerated-layers-after-back.html: Added.
* compositing/iframes/page-cache-layer-tree.html:
* compositing/page-cache-back-crash.html:
* compositing/resources/go-back.html: Renamed from LayoutTests/compositing/iframes/resources/page-cache-helper.html.
* platform/ios/compositing/accelerated-layers-after-back-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Windows] Fix Python error for subprocess.popen with close_fds
commit-queue@webkit.org [Tue, 14 Nov 2017 00:55:41 +0000 (00:55 +0000)]
[Windows] Fix Python error for subprocess.popen with close_fds
https://bugs.webkit.org/show_bug.cgi?id=179553

Patch by Basuke Suzuki <Basuke.Suzuki@sony.com> on 2017-11-13
Reviewed by Per Arne Vollan.

* Scripts/webkitpy/port/server_process.py:
(ServerProcess._start):
(ServerProcess._should_close_fds):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDisable two Modern EME LayoutTests on mac-wk1 until the feature is enabled in DumpRe...
ryanhaddad@apple.com [Tue, 14 Nov 2017 00:49:06 +0000 (00:49 +0000)]
Disable two Modern EME LayoutTests on mac-wk1  until the feature is enabled in DumpRenderTree.
https://bugs.webkit.org/show_bug.cgi?id=179544

Unreviewed test gardening.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Require woff2 1.0.2 and drop direct brotli dependency
mcatanzaro@igalia.com [Tue, 14 Nov 2017 00:42:20 +0000 (00:42 +0000)]
[GTK] Require woff2 1.0.2 and drop direct brotli dependency
https://bugs.webkit.org/show_bug.cgi?id=179630

Reviewed by Frédéric Wang.

.:

* Source/cmake/FindBrotliDec.cmake: Removed.
* Source/cmake/OptionsGTK.cmake:

Tools:

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agomatchRegistration does not need to go to StorageProcess if no service worker is regis...
commit-queue@webkit.org [Tue, 14 Nov 2017 00:20:25 +0000 (00:20 +0000)]
matchRegistration does not need to go to StorageProcess if no service worker is registered
https://bugs.webkit.org/show_bug.cgi?id=179480

Patch by Youenn Fablet <youenn@apple.com> on 2017-11-13
Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/service-workers/service-worker/activation.https-expected.txt:
* web-platform-tests/service-workers/service-worker/activation.https.html:
* web-platform-tests/service-workers/service-worker/registration-iframe.https.html:

Source/WebCore:

Covered by existing tests.

Moving the origin store in SWServer since they share the same session ID.
This allows updating the origin store based on each registration map update.
This also allows clearing the origin store when clearing the SWServer.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* workers/service/server/SWOriginStore.cpp: Added.
(WebCore::SWOriginStore::add):
(WebCore::SWOriginStore::remove):
(WebCore::SWOriginStore::clear):
(WebCore::SWOriginStore::clearAll):
* workers/service/server/SWOriginStore.h: Added.
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::addRegistration):
(WebCore::SWServer::removeRegistration):
(WebCore::SWServer::OriginStore::add):
(WebCore::SWServer::OriginStore::remove):
(WebCore::SWServer::OriginStore::clear):
(WebCore::SWServer::OriginStore::clearAll):
(WebCore::SWServer::clearAll):
(WebCore::SWServer::clear):
(WebCore::SWServer::SWServer):
* workers/service/server/SWServer.h:
(WebCore::SWServer::originStore):

Source/WebKit:

Removed origin store handling from StorageProcess since it is now handled within SWServer.
Updated clearing of web site data accordingly.
Optimized matchRegistration by looking at the origin store before doing any IPC.
Do IPC to the StorageProcess if the origin store is not yet initialized on the WebProcess.

* StorageProcess/ServiceWorker/WebSWOriginStore.h:
* StorageProcess/ServiceWorker/WebSWServerConnection.cpp:
(WebKit::WebSWServerConnection::resolveRegistrationJobInClient):
(WebKit::WebSWServerConnection::resolveUnregistrationJobInClient):
* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::deleteWebsiteData):
(WebKit::StorageProcess::deleteWebsiteDataForOrigins):
(WebKit::StorageProcess::swServerForSession):
(WebKit::StorageProcess::swOriginStoreForSession):
(WebKit::StorageProcess::registerSWServerConnection):
(WebKit::StorageProcess::unregisterSWServerConnection):
(WebKit::StorageProcess::ensureSWOriginStoreForSession): Deleted.
(WebKit::StorageProcess::swOriginStoreForSession const): Deleted.
* StorageProcess/StorageProcess.h:
* StorageProcess/ServiceWorker/WebSWOriginStore.cpp:
(WebKit::WebSWOriginStore::addToStore):
(WebKit::WebSWOriginStore::removeFromStore):
(WebKit::WebSWOriginStore::clearStore):
(WebKit::WebSWOriginStore::add): Deleted.
(WebKit::WebSWOriginStore::remove): Deleted.
(WebKit::WebSWOriginStore::clear): Deleted.
* StorageProcess/ServiceWorker/WebSWOriginStore.h:
* WebProcess/Storage/WebSWClientConnection.cpp:
(WebKit::WebSWClientConnection::matchRegistration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMerge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteData...
achristensen@apple.com [Mon, 13 Nov 2017 23:50:47 +0000 (23:50 +0000)]
Merge NetworkProcess::EnsurePrivateBrowsingSession and NetworkProcess::AddWebsiteDataStore into one message type
https://bugs.webkit.org/show_bug.cgi?id=178751

Reviewed by Brady Eidson.

Source/WebCore:

The creation of private browsing sessions and persistent browsing sessions has evolved to be the same thing
with differences in parameters, like no sandbox extensions or paths to persistent storage locations for private browsing.
These should be united to simplify future development of WebsiteDataStore construction.

* platform/network/NetworkStorageSession.h:
* platform/network/cf/NetworkStorageSessionCFNet.cpp:
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession): Deleted.
* platform/network/soup/NetworkStorageSessionSoup.cpp:
(WebCore::NetworkStorageSession::ensureSession):
(WebCore::NetworkStorageSession::ensurePrivateBrowsingSession): Deleted.

Source/WebKit:

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::ensureLegacyPrivateBrowsingSession):
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::initializeNetworkProcess):
(WebKit::NetworkProcess::ensurePrivateBrowsingSession): Deleted.
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* NetworkProcess/RemoteNetworkingContext.h:
* NetworkProcess/mac/RemoteNetworkingContext.mm:
(WebKit::RemoteNetworkingContext::ensureWebsiteDataStoreSession):
(WebKit::RemoteNetworkingContext::ensurePrivateBrowsingSession): Deleted.
* Shared/WebsiteDataStoreParameters.cpp:
(WebKit::WebsiteDataStoreParameters::legacyPrivateSessionParameters):
* Shared/WebsiteDataStoreParameters.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setAnyPageGroupMightHavePrivateBrowsingEnabled):
(WebKit::WebProcessPool::createNewWebProcess):
(WebKit::WebProcessPool::pageAddedToProcess):
* WebProcess/InjectedBundle/InjectedBundle.cpp:
(WebKit::InjectedBundle::setPrivateBrowsingEnabled):
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.mm:
(WebKit::WebFrameNetworkingContext::ensureWebsiteDataStoreSession):
(WebKit::WebFrameNetworkingContext::ensurePrivateBrowsingSession): Deleted.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::setSessionID):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::ensurePrivateBrowsingSession): Deleted.
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

Source/WebKitLegacy/mac:

* WebCoreSupport/WebFrameNetworkingContext.mm:
(WebFrameNetworkingContext::ensurePrivateBrowsingSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd logs to debug content extension test failures
achristensen@apple.com [Mon, 13 Nov 2017 23:25:00 +0000 (23:25 +0000)]
Add logs to debug content extension test failures
https://bugs.webkit.org/show_bug.cgi?id=179624

Reviewed by Chris Dumez.

* UIProcess/API/APIContentRuleListStore.cpp:
(API::compiledToFile):
Right now I'm seeing this log:
"Rule list compilation failed: Unspecified error during compile."
I need more information to debug what is failing on the bots.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Automation: inViewCenterPoint should not include topContentInset when computed...
bburg@apple.com [Mon, 13 Nov 2017 23:21:31 +0000 (23:21 +0000)]
Web Automation: inViewCenterPoint should not include topContentInset when computed in viewport coordinates
https://bugs.webkit.org/show_bug.cgi?id=179129
<rdar://problem/35297038>

Reviewed by Simon Fraser.

Source/WebCore:

Add or export some helpers needed to compute element layout for WebDriver.

* dom/Element.h: Export the non-DOM version of getClientBounds().
* page/FrameView.h:
* page/FrameView.cpp:
(WebCore::FrameView::clientToDocumentRect const):
Added. This does the same thing as clientToDocumentPoint. Export it, too.

Source/WebDriver:

Adjust code to use the proper coordinate system when requesting element layout.

* Session.cpp:
(WebDriver::Session::computeElementLayout):

Source/WebKit:

When computing the in view center point per W3C specification, the top content inset
is inadvertently added back in when converting to the root view coordinate system.

This patch reworks the protocol command so that it explicitly requests a coordinate
system, with options for "Page" (root / contents), "LayoutViewport", and "VisualViewport".
The latter is not implemented in this patch, since it is intended for use on iOS someday.

* UIProcess/Automation/Automation.json:
Change usesViewport to CoordinateSystem.
Add a new coordinate system enum type and use it.
Fix relevant comments for Automation.computElementLayout.

* UIProcess/Automation/WebAutomationSession.h:
* UIProcess/Automation/WebAutomationSession.cpp:
(WebKit::protocolStringToCoordinateSystem):
(WebKit::WebAutomationSession::computeElementLayout):
Parse the requested coordinate system and send it in the message to the web process.

* WebKit.xcodeproj/project.pbxproj:
* WebProcess/Automation/WebAutomationSessionProxy.messages.in:
* WebProcess/Automation/WebAutomationSessionProxy.h:
* WebProcess/Automation/WebAutomationSessionProxy.cpp:
(WebKit::WebAutomationSessionProxy::computeElementLayout):
Rework the implementation. Get the element bounds and in-view center point in
client coordinates and convert back to root view coordinates for CoordinateSystem::Page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Include a NetworkAgent in ServiceWorkers for network debugging
joepeck@webkit.org [Mon, 13 Nov 2017 23:15:57 +0000 (23:15 +0000)]
Web Inspector: Include a NetworkAgent in ServiceWorkers for network debugging
https://bugs.webkit.org/show_bug.cgi?id=179513
<rdar://problem/35456402>

Reviewed by Brian Burg.

In order to show Network requests for a ServiceWorker, we need to add
inspector networking hooks for Worker loads. While we show Network
requests for DedicatedWorkers, we do that through the Page during Page
inspection. In ServiceWorker inspection, the remote connection is
connected to the ServiceWorkerThreadProxy, and interacts with the
WorkerGlobalScope without making any assumptions about a Page existing.
We don't want to make any assumptions about a Page/Document being needed
for Network hooks, so we should add new hooks that will work in the
WorkerGlobalScope's context.

This patch adds InspectorInstrumentation networking hooks for workers inside
of the WorkerThreadableLoader bridge. This is where the majority of Worker
initiated network requests happen (Fetch/XHR, but not WebSockets). The hooks
are simpler versions of the existing network hooks for a Page, and allow for
complete inspector networking information (will send, did receive response,
did receive data, success, failure, and timing metrics).

This patch generalizes InspectorNetworkAgent to work for a Page and Worker.
Some of the existing functionality was specific to a Page (frameId/loaderId)
but did not make sense for a Worker. In order to handle these cases, all
of the unique logic was extracted out into virtual methods that subclasses
PageNetworkAgent and WorkerNetworkAgent provide as appropriate. The majority
of NetworkAgent remains unchanged and algorithms are shared.

We needed to change the existing InspectorInstrumentation networking hooks
to allow for an optional DocumentLoader. This way we can keep all of the
same hooks leading inside of NetworkAgent, but loads for a Page will have a
DocumentLoader, and loads for a ServiceWorker will not.

While the WorkerNetworkAgent would work for a DedicatedWorker, we still
only create it for a ServiceWorker. The existing behavior of showing Network
loads for a DedicatedWorker will continue to go through the Page inspector
so we can avoid creating a NetworkAgent for DedicatedWorkers. If we created
a way to directly inspect a DedicatedWorker we could look at making this
always available, but it would require extra work to function perfectly.

* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
Add new files.

* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
(WebCore::InspectorController::createLazyAgents):
Switch from InspectorNetworkAgent to PageNetworkAgent.

* inspector/WorkerInspectorController.h:
* inspector/WorkerInspectorController.cpp:
(WebCore::WorkerInspectorController::WorkerInspectorController):
(WebCore::WorkerInspectorController::workerAgentContext):
(WebCore::WorkerInspectorController::createLazyAgents):
Create a WorkerNetworkAgent when inside of a ServiceWorker.
Also start the lazy agent pattern for agents that can defer
creation until a frontend attached.

(WebCore::WorkerInspectorController::connectFrontend):
(WebCore::WorkerInspectorController::disconnectFrontend):
When frontends connect/disconnect toggle the necessary states.
Also start the execution stopwatch, otherwise it will always be at 0.

* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::willSendRequestImpl):
(WebCore::InspectorInstrumentation::willSendRequestOfTypeImpl):
(WebCore::InspectorInstrumentation::didLoadResourceFromMemoryCacheImpl):
(WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
(WebCore::InspectorInstrumentation::didFinishLoadingImpl):
(WebCore::InspectorInstrumentation::didFailLoadingImpl):
(WebCore::InspectorInstrumentation::frameDetachedFromParentImpl):
* inspector/InspectorInstrumentation.h:
(WebCore::InspectorInstrumentation::willSendRequest):
(WebCore::InspectorInstrumentation::didReceiveResourceResponse):
(WebCore::InspectorInstrumentation::didReceiveData):
(WebCore::InspectorInstrumentation::didFinishLoading):
(WebCore::InspectorInstrumentation::didFailLoading):
Add Worker networking hooks that pass through to the same general hooks.

* loader/WorkerThreadableLoader.cpp:
(WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveResponse):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didReceiveData):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishLoading):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFail):
(WebCore::WorkerThreadableLoader::MainThreadBridge::didFinishTiming):
* loader/WorkerThreadableLoader.h:
Use the new worker networking instrumentation hooks.

* loader/ThreadableLoader.cpp:
(WebCore::ThreadableLoader::create):
Drive-by: use a move.
* inspector/agents/InspectorNetworkAgent.h:
* inspector/agents/InspectorNetworkAgent.cpp:
(WebCore::InspectorNetworkAgent::InspectorNetworkAgent):
(WebCore::InspectorNetworkAgent::willSendRequest):
(WebCore::InspectorNetworkAgent::willSendRequestOfType):
(WebCore::InspectorNetworkAgent::didReceiveResponse):
(WebCore::InspectorNetworkAgent::didFinishLoading):
(WebCore::InspectorNetworkAgent::didFailLoading):
(WebCore::InspectorNetworkAgent::didLoadResourceFromMemoryCache):
(WebCore::InspectorNetworkAgent::buildInitiatorObject):
(WebCore::InspectorNetworkAgent::enable):
(WebCore::InspectorNetworkAgent::disable):
(WebCore::InspectorNetworkAgent::setResourceCachingDisabled):
(WebCore::InspectorNetworkAgent::loadResource):
(WebCore::InspectorNetworkAgent::webSocketForRequestId):
(WebCore::InspectorNetworkAgent::resolveWebSocket):
(WebCore::InspectorNetworkAgent::mainFrameNavigated):
Extract logic for subclasses. Transition to DocumentLoader being null.

* inspector/agents/page/PageNetworkAgent.h:
* inspector/agents/page/PageNetworkAgent.cpp: Added.
(WebCore::PageNetworkAgent::PageNetworkAgent):
(WebCore::PageNetworkAgent::loaderIdentifier):
(WebCore::PageNetworkAgent::frameIdentifier):
(WebCore::PageNetworkAgent::setResourceCachingDisabled):
(WebCore::PageNetworkAgent::scriptExecutionContext):
Extracted Page implementation. This is just moving from the original.

* inspector/agents/worker/WorkerNetworkAgent.h:
* inspector/agents/worker/WorkerNetworkAgent.cpp:
(WebCore::WorkerNetworkAgent::WorkerNetworkAgent):
(WebCore::WorkerNetworkAgent::loaderIdentifier):
(WebCore::WorkerNetworkAgent::frameIdentifier):
(WebCore::WorkerNetworkAgent::setResourceCachingDisabled):
(WebCore::WorkerNetworkAgent::scriptExecutionContext):
Implement for a worker.

* inspector/agents/worker/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::WorkerDebuggerAgent):
* inspector/agents/worker/WorkerConsoleAgent.cpp:
(WebCore::WorkerConsoleAgent::WorkerConsoleAgent):
* inspector/agents/worker/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::WorkerRuntimeAgent):
Add some assertions for all Worker agents for clarify.

* workers/WorkerDebuggerProxy.h:
* workers/WorkerGlobalScope.h:
(WebCore::WorkerGlobalScope::identifier const):
(WebCore::WorkerGlobalScope::createUniqueIdentifier):
Provide a way to get unique identifiers in a worker. For the Page
this is done through the Page's ProgressTracker. For a Worker we just
put this on the WorkerGlobalScope. This is used for request ids.

* workers/WorkerMessagingProxy.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::setResourceCachingDisabled):
* workers/service/context/ServiceWorkerThreadProxy.h:
* workers/service/context/ServiceWorkerThreadProxy.cpp:
(WebCore::ServiceWorkerThreadProxy::setResourceCachingDisabled):
Add a debug method for disabling the resource cache from a worker.
In service workers this sets the override flag on the hidden page.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAsync iteration should only fetch the next method once and add feature flag
keith_miller@apple.com [Mon, 13 Nov 2017 23:10:03 +0000 (23:10 +0000)]
Async iteration should only fetch the next method once and add feature flag
https://bugs.webkit.org/show_bug.cgi?id=179451

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Add feature flag for Async iteration. Also, change async iteration to match
the expected behavior of the proposal.

* Configurations/FeatureDefines.xcconfig:
* builtins/AsyncFromSyncIteratorPrototype.js:
(globalPrivate.createAsyncFromSyncIterator):
(globalPrivate.AsyncFromSyncIteratorConstructor):
* builtins/BuiltinNames.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitGetAsyncIterator):
* runtime/Options.h:

Source/WebCore:

Add feature flag for Async iteration.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore/PAL:

Add feature flag for Async iteration.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit:

Add feature flag for Async iteration.

* Configurations/FeatureDefines.xcconfig:

Source/WebKitLegacy/mac:

Add feature flag for Async iteration.

* Configurations/FeatureDefines.xcconfig:

Tools:

Add feature flag for Async iteration.

* TestWebKitAPI/Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoCall willPerformHTTPRedirection on WebCoreNSURLSession's delegate
achristensen@apple.com [Mon, 13 Nov 2017 23:00:38 +0000 (23:00 +0000)]
Call willPerformHTTPRedirection on WebCoreNSURLSession's delegate
https://bugs.webkit.org/show_bug.cgi?id=179539

Reviewed by Jer Noble.

This is now possible!
This will allow AVFoundation to fix redirect-related bugs.

* platform/network/cocoa/WebCoreNSURLSession.mm:
(-[WebCoreNSURLSession addDelegateOperation:]):
(-[WebCoreNSURLSession resetWithCompletionHandler:]):
(-[WebCoreNSURLSession flushWithCompletionHandler:]):
(WebCore::WebCoreNSURLSessionDataTaskClient::redirectReceived):
(-[WebCoreNSURLSessionDataTask resource:shouldCacheResponse:]):
(-[WebCoreNSURLSessionDataTask resource:receivedData:length:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:completionHandler:]):
(-[WebCoreNSURLSessionDataTask resource:receivedRedirect:request:]): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd some more assertions in SWServerJobQueue
cdumez@apple.com [Mon, 13 Nov 2017 23:00:04 +0000 (23:00 +0000)]
Add some more assertions in SWServerJobQueue
https://bugs.webkit.org/show_bug.cgi?id=179626

Reviewed by Alex Christensen.

Add some more assertions in SWServerJobQueue for extra safety.

* workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::didResolveRegistrationPromise):
(WebCore::SWServerJobQueue::didFinishInstall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd more overflow check book-keeping for MarkedArgumentBuffer.
mark.lam@apple.com [Mon, 13 Nov 2017 22:58:04 +0000 (22:58 +0000)]
Add more overflow check book-keeping for MarkedArgumentBuffer.
https://bugs.webkit.org/show_bug.cgi?id=179634
<rdar://problem/35492517>

Reviewed by Saam Barati.

JSTests:

* stress/regress-179634.js: Added.

Source/JavaScriptCore:

* runtime/ArgList.h:
(JSC::MarkedArgumentBuffer::overflowCheckNotNeeded):
* runtime/JSJob.cpp:
(JSC::JSJobMicrotask::run):
* runtime/ObjectConstructor.cpp:
(JSC::defineProperties):
* runtime/ReflectObject.cpp:
(JSC::reflectObjectConstruct):

Source/WebKit:

* WebProcess/Plugins/Netscape/NPJSObject.cpp:
(WebKit::NPJSObject::construct):
(WebKit::NPJSObject::invoke):

Source/WebKitLegacy/mac:

* Plugins/Hosted/NetscapePluginInstanceProxy.mm:
(WebKit::NetscapePluginInstanceProxy::invoke):
(WebKit::NetscapePluginInstanceProxy::invokeDefault):
(WebKit::NetscapePluginInstanceProxy::construct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[JSC] Remove ARM implementation of branchTruncateDoubleToUInt32
guijemont@igalia.com [Mon, 13 Nov 2017 22:52:55 +0000 (22:52 +0000)]
[JSC] Remove ARM implementation of branchTruncateDoubleToUInt32
https://bugs.webkit.org/show_bug.cgi?id=179542

Reviewed by Alex Christensen.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branchTruncateDoubleToUint32): Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAddress some post-landing review comments from r224728
timothy_horton@apple.com [Mon, 13 Nov 2017 22:49:15 +0000 (22:49 +0000)]
Address some post-landing review comments from r224728
https://bugs.webkit.org/show_bug.cgi?id=179576

* Platform/IPC/mac/MachMessage.h:
(IPC::MachMessage::setMessageReceiverName):
(IPC::MachMessage::setMessageName):
More moving!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoOccasional MobileSafari crash under -[WKPDFView web_setMinimumSize:]
timothy_horton@apple.com [Mon, 13 Nov 2017 22:22:28 +0000 (22:22 +0000)]
Occasional MobileSafari crash under -[WKPDFView web_setMinimumSize:]
https://bugs.webkit.org/show_bug.cgi?id=179628
<rdar://problem/34773037>

Reviewed by Simon Fraser.

* UIProcess/ios/WKPDFView.mm:
(-[WKPDFView _computePageAndDocumentFrames]):
Similar to r223444, avoid propagating null CGRects into the view hierarchy.
In this case, the null rect comes from applying margins to a rect that is
smaller than the margins. We could check for that specifically, but a
more-general check for a null rect seems reasonable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoThe css properties stroke-width/stroke-color and -webkit-text-stroke-width/-webkit...
pvollan@apple.com [Mon, 13 Nov 2017 22:13:34 +0000 (22:13 +0000)]
The css properties stroke-width/stroke-color and -webkit-text-stroke-width/-webkit-text-stroke-color should not be mixed.
https://bugs.webkit.org/show_bug.cgi?id=174737

Reviewed by Antti Koivisto.

Source/WebCore:

Previously, the stroke width and stroke color would independently fall back to the -webkit-text-stroke-width and
-webkit-text-stroke-color values if stroke-width and/or stroke-color were not explicitly specified. This is
problematic, since we might end up mixing the new stroke properties with the legacy Webkit stroke properties.
The new strategy is to use the stroke-width and stroke-color value combination only if stroke-color has been
explicitly specified. This should work well, since there will be no visible stroke when specifying only
stroke-width (because stroke-color by default is transparent). We can then safely fall back to the legacy Webkit
stroke value combination. In the case where only stroke-color is specified, we should use the stroke-width/
stroke-color combination, since stroke-width by default is 1, and we will then have a visible stroke.

No new tests, existing tests have been updated to reflect behavior changes.

* rendering/TextDecorationPainter.cpp:
(WebCore::decorationColor):
* rendering/TextPaintStyle.cpp:
(WebCore::computeTextPaintStyle):
(WebCore::computeTextSelectionPaintStyle):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::computedStrokeWidth const):
(WebCore::RenderStyle::hasPositiveStrokeWidth const):
(WebCore::RenderStyle::computedStrokeColor const):
* rendering/style/RenderStyle.h:

LayoutTests:

* fast/css/stroke-color-expected.html:
* fast/css/stroke-color-fallback-expected.html:
* fast/css/stroke-color-fallback.html:
* fast/css/stroke-color.html:
* fast/css/stroke-width-expected.html:
* fast/css/stroke-width-fallback-expected.html:
* fast/css/stroke-width-fallback.html:
* fast/css/stroke-width.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUse the real mach type instead of reinterpret_casting in MachMessage
timothy_horton@apple.com [Mon, 13 Nov 2017 22:05:27 +0000 (22:05 +0000)]
Use the real mach type instead of reinterpret_casting in MachMessage
https://bugs.webkit.org/show_bug.cgi?id=179629

Reviewed by Dan Bernstein.

* Platform/IPC/mac/MachMessage.cpp:
(IPC::MachMessage::header):
* Platform/IPC/mac/MachMessage.h:
Just use mach_msg_header_t proper, and avoid the reinterpret_cast.
This also corrects the alignment of the struct on platforms where
alignof(mach_msg_header_t) != alignof(uint8_t).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Automatically adjust font size when gtk-xft-dpi changes
commit-queue@webkit.org [Mon, 13 Nov 2017 21:42:54 +0000 (21:42 +0000)]
[GTK] Automatically adjust font size when gtk-xft-dpi changes
https://bugs.webkit.org/show_bug.cgi?id=142673

Patch by Gabriel Ivascu <givascu@igalia.com> on 2017-11-13
Reviewed by Michael Catanzaro.

Source/WebCore:

* platform/PlatformScreen.h:
* platform/gtk/PlatformScreenGtk.cpp:
(WebCore::gtkXftDPIChangedCallback):
(WebCore::setScreenDPIObserverHandler):
* platform/wpe/PlatformScreenWPE.cpp:
(WebCore::setScreenDPIObserverHandler):

Source/WebKit:

* UIProcess/API/glib/WebKitSettings.cpp:
(webKitSettingsDispose):
(webKitSettingsConstructed):
(webkit_settings_class_init):

Tools:

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed, rolling out r224763.
commit-queue@webkit.org [Mon, 13 Nov 2017 21:41:55 +0000 (21:41 +0000)]
Unreviewed, rolling out r224763.
https://bugs.webkit.org/show_bug.cgi?id=179632

test fails on iOS (Requested by alexchristensen on #webkit).

Reverted changeset:

"Add tests to ensure that <source> tags are only preloaded
when the `type`"
https://bugs.webkit.org/show_bug.cgi?id=179231
https://trac.webkit.org/changeset/224763

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUpdate safe area CSS for webkit.org
jond@apple.com [Mon, 13 Nov 2017 21:29:47 +0000 (21:29 +0000)]
Update safe area CSS for webkit.org
https://bugs.webkit.org/show_bug.cgi?id=179615

Reviewed by Alexey Proskuryakov.

* wp-content/themes/webkit/style.css:
(@media only screen and (max-height: 415px)):
(@supports(padding:max(0px))):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoDon't eliminate whitespace renderer if the previous sibling is a text renderer
antti@apple.com [Mon, 13 Nov 2017 21:14:46 +0000 (21:14 +0000)]
Don't eliminate whitespace renderer if the previous sibling is a text renderer
https://bugs.webkit.org/show_bug.cgi?id=179620

Reviewed by Zalan Bujtas.

Source/WebCore:

Currently whitespace elimination code doesn't consider runs of text renderers. We should always make whitespace
renderer if the previous renderer is a text renderer. The behavior should be the same as if those were a single
renderer with merged text. This situation can happen easily with display:contents.

This fixes the remaining flexbox failures in display:contents tests.

* style/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::textRendererIsNeeded):

We need a renderer if the previous rendere is RenderText.

LayoutTests:

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoImplement "Service Worker Has No Pending Events" / "Update Service Worker Extended...
cdumez@apple.com [Mon, 13 Nov 2017 21:06:23 +0000 (21:06 +0000)]
Implement "Service Worker Has No Pending Events" / "Update Service Worker Extended Events Set" algorithms
https://bugs.webkit.org/show_bug.cgi?id=179618

Reviewed by Brady Eidson.

Source/WebCore:

Implement "Service Worker Has No Pending Events" / "Update Service Worker Extended Events Set" algorithms:
- https://w3c.github.io/ServiceWorker/#service-worker-has-no-pending-events-algorithm
- https://w3c.github.io/ServiceWorker/#update-service-worker-extended-events-set-algorithm

Test: http/tests/workers/service/basic-unregister-then-register-again-reuse.html

* workers/service/context/SWContextManager.h:
* workers/service/context/ServiceWorkerFetch.cpp:
(WebCore::ServiceWorkerFetch::dispatchFetchEvent):
* workers/service/context/ServiceWorkerFetch.h:
* workers/service/context/ServiceWorkerThread.cpp:
(WebCore::ServiceWorkerThread::postFetchTask):
(WebCore::ServiceWorkerThread::postMessageToServiceWorkerGlobalScope):
(WebCore::ServiceWorkerThread::updateExtendedEventsSet):
* workers/service/context/ServiceWorkerThread.h:
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::Connection::setServiceWorkerHasPendingEvents):
(WebCore::SWServer::setServiceWorkerHasPendingEvents):
* workers/service/server/SWServer.h:
* workers/service/server/SWServerJobQueue.cpp:
(WebCore::SWServerJobQueue::tryActivate):
(WebCore::SWServerJobQueue::tryClearRegistration):
* workers/service/server/SWServerWorker.h:
(WebCore::SWServerWorker::hasPendingEvents const):
(WebCore::SWServerWorker::setHasPendingEvents):

Source/WebKit:

* StorageProcess/StorageProcess.cpp:
(WebKit::StorageProcess::setServiceWorkerHasPendingEvents):
* StorageProcess/StorageProcess.h:
* StorageProcess/StorageProcess.messages.in:
* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::WebSWContextManagerConnection::setServiceWorkerHasPendingEvents):
* WebProcess/Storage/WebSWContextManagerConnection.h:

LayoutTests:

Add layout test coverage.

* http/tests/workers/service/basic-unregister-then-register-again-reuse-expected.txt: Added.
* http/tests/workers/service/basic-unregister-then-register-again-reuse.html: Added.
* http/tests/workers/service/resources/basic-unregister-then-register-again-reuse-worker.js: Added.
(event.waitUntil.new.Promise):
(setTimeout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdjust TestExpectation for js/intl-datetimeformat.html.
ryanhaddad@apple.com [Mon, 13 Nov 2017 21:02:58 +0000 (21:02 +0000)]
Adjust TestExpectation for js/intl-datetimeformat.html.
https://bugs.webkit.org/show_bug.cgi?id=179208

Unreviewed test gardening.

* platform/mac-wk2/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake the jsc shell loadGetterFromGetterSetter() function more robust.
mark.lam@apple.com [Mon, 13 Nov 2017 20:18:15 +0000 (20:18 +0000)]
Make the jsc shell loadGetterFromGetterSetter() function more robust.
https://bugs.webkit.org/show_bug.cgi?id=179619
<rdar://problem/35492518>

Reviewed by Saam Barati.

JSTests:

* stress/regress-179619.js: Added.

Source/JavaScriptCore:

* jsc.cpp:
(functionLoadGetterFromGetterSetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Network Details Views - make section headers more prominent
joepeck@webkit.org [Mon, 13 Nov 2017 20:16:09 +0000 (20:16 +0000)]
Web Inspector: Network Details Views - make section headers more prominent
https://bugs.webkit.org/show_bug.cgi?id=179565
<rdar://problem/35510531>

Reviewed by Devin Rousso.

* UserInterface/Views/ResourceDetailsSection.css:
(.resource-details > section > .title):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Styles Redesign: make selector field inline-block when editing
nvasilyev@apple.com [Mon, 13 Nov 2017 19:59:49 +0000 (19:59 +0000)]
Web Inspector: Styles Redesign: make selector field inline-block when editing
https://bugs.webkit.org/show_bug.cgi?id=179588
<rdar://problem/35490915>

Reviewed by Brian Burg.

* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.css:
(.spreadsheet-css-declaration .header.editing-selector .origin):
When the selector field is multiline, it covers the source link entirely.
When the selector field takes only one line, the source link remains where it was before editing.

(.spreadsheet-css-declaration .selector):
Make it `position: relative` to cover the source link.

(.spreadsheet-css-declaration .selector.spreadsheet-selector-field.editing):
* UserInterface/Views/SpreadsheetCSSStyleDeclarationSection.js:
(WI.SpreadsheetCSSStyleDeclarationSection.prototype.initialLayout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r223856): Web Inspector: Cannot view Request Data
commit-queue@webkit.org [Mon, 13 Nov 2017 19:58:09 +0000 (19:58 +0000)]
REGRESSION(r223856): Web Inspector: Cannot view Request Data
https://bugs.webkit.org/show_bug.cgi?id=179567

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-11-13
Reviewed by Brian Burg.

* UserInterface/Views/ResourceClusterContentView.js:
(WI.ResourceClusterContentView.prototype._canShowRequestContentView):
This condition unintentionally got flipped in r223856.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Add CheckboxNavigationItem
mattbaker@apple.com [Mon, 13 Nov 2017 19:57:16 +0000 (19:57 +0000)]
Web Inspector: Add CheckboxNavigationItem
https://bugs.webkit.org/show_bug.cgi?id=179584
<rdar://problem/35490085>

Reviewed by Brian Burg.

* UserInterface/Main.html:
* UserInterface/Views/ButtonNavigationItem.css:
(.navigation-bar .item.button.text-only.checkbox):
(.navigation-bar .item.button.text-only.checkbox label):

* UserInterface/Views/ButtonNavigationItem.js:
Cleanup and some tweaks to the label to make it work with subclasses
regardless of how label is represented in the DOM.

(WI.ButtonNavigationItem):
(WI.ButtonNavigationItem.prototype.get toolTip):
(WI.ButtonNavigationItem.prototype.set toolTip):
(WI.ButtonNavigationItem.prototype.get label):
(WI.ButtonNavigationItem.prototype.set label):
(WI.ButtonNavigationItem.prototype.set image):
(WI.ButtonNavigationItem.prototype.get enabled):
(WI.ButtonNavigationItem.prototype.set enabled):
(WI.ButtonNavigationItem.prototype.updateButtonText):

* UserInterface/Views/CheckboxNavigationItem.js: Added.
New button item with a checkbox and label. Dispatches a Clicked evennt
whenever the checked state changes.

(WI.CheckboxNavigationItem):
(WI.CheckboxNavigationItem.prototype.get checked):
(WI.CheckboxNavigationItem.prototype.set checked):
(WI.CheckboxNavigationItem.prototype.get additionalClassNames):
(WI.CheckboxNavigationItem.prototype.updateButtonText):
(WI.CheckboxNavigationItem.prototype._checkboxChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agocheck-webkit-style cannot construct valid iOS version without an iOS SDK
jbedard@apple.com [Mon, 13 Nov 2017 19:55:17 +0000 (19:55 +0000)]
check-webkit-style cannot construct valid iOS version without an iOS SDK
https://bugs.webkit.org/show_bug.cgi?id=179616
<rdar://problem/35507018>

Reviewed by David Kilzer.

Instead of throwing an exception when we ask for an unavailable SDK on Mac,
we should return None.

* Scripts/webkitpy/common/system/platforminfo.py:
(PlatformInfo.xcode_sdk_version): Return 'None' version if the machine does not
have the requested SDK.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUninitialized variable in sort-Xcode-project-file
keith_miller@apple.com [Mon, 13 Nov 2017 19:47:34 +0000 (19:47 +0000)]
Uninitialized variable in sort-Xcode-project-file
https://bugs.webkit.org/show_bug.cgi?id=179581

Reviewed by Simon Fraser.

Previously all the unified source files were named
UnifiedSource<some-number>.mm. This was changed to
UnifiedSource<some-number>-mm.mm to stop Xcode from creating
hashes for mm and cpp unified source files with the same
number. This broke the expectations in sort-Xcode-project-file.

* Scripts/sort-Xcode-project-file:
(sortChildrenByFileName):
(sortFilesByFileName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoSource/WebCore:
achristensen@apple.com [Mon, 13 Nov 2017 19:33:19 +0000 (19:33 +0000)]
Source/WebCore:
Added mime type check to the picture source preloader to avoid downloading incompatible resources.
https://bugs.webkit.org/show_bug.cgi?id=179231

Patch by Colin Bendell <colin@bendell.ca> on 2017-11-13
Reviewed by Alex Christensen.

Test: http/tests/loading/preload-picture-type.html

* html/parser/HTMLPreloadScanner.cpp:
(WebCore::TokenPreloadScanner::StartTagScanner::processAttributes): include type match state when selecting candidate imgs
(WebCore::TokenPreloadScanner::StartTagScanner::processAttribute): added type attribute evaluation and matching

LayoutTests:
Add tests to ensure that <source> tags are only preloaded when the `type`
attribute matches.
https://bugs.webkit.org/show_bug.cgi?id=179231

Patch by Colin Bendell <colin@bendell.ca> on 2017-11-13
Reviewed by Alex Christensen.

* http/tests/preload/picture-type-expected.txt: Added.
* http/tests/preload/picture-type.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agostd::expected: fix and test move
jfbastien@apple.com [Mon, 13 Nov 2017 19:19:30 +0000 (19:19 +0000)]
std::expected: fix and test move
https://bugs.webkit.org/show_bug.cgi?id=179617

Reviewed by Alex Christensen.

Source/WTF:

Non-copyable move types should be able to be in an expected
properly.

* wtf/Expected.h:
(WTF::Expected::value const):
(WTF::Expected::error):
(WTF::Expected::error const):

Tools:

Test that unique_ptr can be moved around properly, both has a
value and an error (and in a <void, unique> specialization).

* TestWebKitAPI/Tests/WTF/Expected.cpp:
(TestWebKitAPI::snowflake::reset):
(TestWebKitAPI::snowflake::snowflake):
(TestWebKitAPI::snowflake::~snowflake):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoWeb Inspector: Give DataGrid/Table Header ContextMenu a section header to better...
commit-queue@webkit.org [Mon, 13 Nov 2017 19:17:09 +0000 (19:17 +0000)]
Web Inspector: Give DataGrid/Table Header ContextMenu a section header to better describe its functions
https://bugs.webkit.org/show_bug.cgi?id=179560

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2017-11-13
Reviewed by Matt Baker.

* Localizations/en.lproj/localizedStrings.js:
New string.

* UserInterface/Views/DataGrid.js:
(WI.DataGrid.prototype._contextMenuInHeader):
* UserInterface/Views/Table.js:
(WI.Table.prototype._handleHeaderContextMenu):
Include a disabled context menu item as a section header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Web Animations] Implement getAnimations()
graouts@webkit.org [Mon, 13 Nov 2017 19:14:47 +0000 (19:14 +0000)]
[Web Animations] Implement getAnimations()
https://bugs.webkit.org/show_bug.cgi?id=179535
<rdar://problem/34932475>

Reviewed by Simon Fraser.

Source/WebCore:

We now allow a list of animations for a document, with Document.getAnimations(), or for an
element, with Animatable.getAnimations(), to be returned. In order to support this, we maintain
a map on AnimationTimeline of all animations for a given element. This map is invalidated
when an animation's timeline changes and when an animation's effect changes. Note that the
Web Animations spec mandates that an AnimationEffect can only be a single animation's effect.

Tests: http/wpt/wk-web-animations/interfaces/document-get-animations.html
       http/wpt/wk-web-animations/interfaces/element-get-animations.html
       http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html

* CMakeLists.txt: Add Animatable.idl.
* DerivedSources.make: Add Animatable.idl.
* WebCore.xcodeproj/project.pbxproj: Add Animatable.idl.
* animation/Animatable.idl: A new interface that Element implements and which currently only exposes
getAnimations(), the animate() method will be added later.
* animation/AnimationEffect.h: Add a new m_animation member to reference the animation using this
effect. This relationship is required so we guarantee that an effect is associated with a single
animation at most.
(WebCore::AnimationEffect::animation const):
(WebCore::AnimationEffect::setAnimation):
* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::animationWasAddedToElement): New method to notify the timeline that an
animation registered with this timeline has been associated with a new element through its effect.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): New method to notify the timeline that an
animation registered with this timeline has been disassociated with an element through its effect.
(WebCore::AnimationTimeline::animationsForElement): New method returning all animations registered with
this timeline for a given element.
* animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::animations const): All animations registered with this timeline.
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::detachFromDocument): Clear the reference between this timeline and its document.
(WebCore::DocumentTimeline::currentTime): Protect against a null Document reference.
(WebCore::DocumentTimeline::createDisplayRefreshMonitor const): Protect against a null Document reference.
* animation/DocumentTimeline.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::create):
(WebCore::WebAnimation::setEffect): As an animation's effect changes, we need to ensure that the old
effect no longer has an associated animation, and that the new effect is associated with this animation.
Additionally, we update the element-to-animations map on the animation's timeline.
(WebCore::WebAnimation::setTimeline): Update the element-to-animations map on the former and new timeline.
* dom/Document.cpp:
(WebCore::Document::prepareForDestruction): Clear the relationship between this document and its timeline.
(WebCore::Document::getAnimations): Obtain all animations associated with this document's timeline.
* dom/Document.h:
* dom/Document.idl:
* dom/Element.cpp:
(WebCore::Element::getAnimations): Obtain all animations associated with this element.
* dom/Element.h:
* dom/Element.idl:
* testing/Internals.cpp:

* CMakeLists.txt:
* DerivedSources.make:
* WebCore.xcodeproj/project.pbxproj:
* animation/Animatable.idl:
* animation/AnimationEffect.h:
(WebCore::AnimationEffect::animation const):
(WebCore::AnimationEffect::setAnimation):
* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::animationWasAddedToElement):
(WebCore::AnimationTimeline::animationWasRemovedFromElement):
(WebCore::AnimationTimeline::animationsForElement):
* animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::animations const):
* animation/DocumentTimeline.cpp:
(WebCore::DocumentTimeline::DocumentTimeline):
(WebCore::DocumentTimeline::detachFromDocument):
(WebCore::DocumentTimeline::currentTime):
(WebCore::DocumentTimeline::createDisplayRefreshMonitor const):
* animation/DocumentTimeline.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::create):
(WebCore::WebAnimation::setEffect):
(WebCore::WebAnimation::setTimeline):
* dom/Document.cpp:
(WebCore::Document::prepareForDestruction):
(WebCore::Document::getAnimations):
* dom/Document.h:
* dom/Document.idl:
* dom/Element.cpp:
(WebCore::Element::getAnimations):
* dom/Element.h:
* dom/Element.idl:
* testing/Internals.cpp:

LayoutTests:

Update WPT expectations per new progressions and add three new tests that check the behavior of
Document.getAnimations(), Element.getAnimations() and the unique relationship between an Animation
and an AnimationEffect.

* http/wpt/web-animations/interfaces/Animatable/animate-expected.txt:
* http/wpt/web-animations/interfaces/Animatable/getAnimations-expected.txt:
* http/wpt/web-animations/interfaces/Document/getAnimations-expected.txt:
* http/wpt/wk-web-animations/interfaces/document-get-animations-expected.txt: Added.
* http/wpt/wk-web-animations/interfaces/document-get-animations.html: Added.
* http/wpt/wk-web-animations/interfaces/element-get-animations-expected.txt: Added.
* http/wpt/wk-web-animations/interfaces/element-get-animations.html: Added.
* http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship-expected.txt: Added.
* http/wpt/wk-web-animations/timing-model/animation-effect-unique-relationship.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Windows] Make the port's normalize_test_name() method platform independent.
commit-queue@webkit.org [Mon, 13 Nov 2017 18:55:20 +0000 (18:55 +0000)]
[Windows] Make the port's normalize_test_name() method platform independent.
https://bugs.webkit.org/show_bug.cgi?id=179572

Patch by Basuke Suzuki <Basuke.Suzuki@sony.com> on 2017-11-13
Reviewed by Alexey Proskuryakov.

* Scripts/webkitpy/port/base.py:
(Port.normalize_test_name):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMake DocumentLoader::willSendRequest asynchronous
achristensen@apple.com [Mon, 13 Nov 2017 18:32:00 +0000 (18:32 +0000)]
Make DocumentLoader::willSendRequest asynchronous
https://bugs.webkit.org/show_bug.cgi?id=179549

Reviewed by Tim Horton.

No change in behavior, except now redirects will wait for PolicyChecker::checkNavigationPolicy's completion handler.
Before, they would just continue in DocumentLoader::redirectReceived hoping the client had responded to
decidePolicyForNavigationAction synchronously or that the client would have been ok with continuing.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::redirectReceived):
(WebCore::DocumentLoader::willSendRequest):
(WebCore::DocumentLoader::startLoadingMainResource):
* loader/DocumentLoader.h:
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNavigationPolicy):
* loader/PolicyChecker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoAdd a new landing page design and site-wide design detail updates for webkit.org
jond@apple.com [Mon, 13 Nov 2017 17:40:31 +0000 (17:40 +0000)]
Add a new landing page design and site-wide design detail updates for webkit.org
https://bugs.webkit.org/show_bug.cgi?id=179558

Reviewed by Alexey Proskuryakov.

* wp-content/themes/webkit/404.php: Removed unnecessary prefixed CSS.
* wp-content/themes/webkit/444.php: Removed unnecessary prefixed CSS.
* wp-content/themes/webkit/css-status.php: Removed unnecessary prefixed CSS.
* wp-content/themes/webkit/footer.php: Added new page wrapper container.
* wp-content/themes/webkit/front-header.php: Redesigned landing hero.
* wp-content/themes/webkit/functions.php: Added support for configurable non-breaking words.
* wp-content/themes/webkit/header.php: Added viewport-fit, changed web font, changed logo title.
* wp-content/themes/webkit/images/chevron.svg: Added.
* wp-content/themes/webkit/images/circular.svg: Added.
* wp-content/themes/webkit/images/compass.svg: Added.
* wp-content/themes/webkit/images/download-white.svg: Added.
* wp-content/themes/webkit/images/template.svg: Added.
* wp-content/themes/webkit/loop.php: Updated "read more" link presentation.
* wp-content/themes/webkit/nightly-start.php: Adjusted header background colors.
* wp-content/themes/webkit/nightly-survey.php: Adjusted header background colors.
* wp-content/themes/webkit/nightly.php: Adjusted header background colors.
* wp-content/themes/webkit/page.php: Page clean up.
* wp-content/themes/webkit/single.php: Updated "read more" link presentation.
* wp-content/themes/webkit/status.php: Removed unnecessary prefixed CSS, improved page title.
* wp-content/themes/webkit/style.css: Redesigned.
(html):
(body):
(strong):
(em):
(code):
(main):
(h1,):
(input[type=text]):
(input[type=submit]):
(header):
(.home header):
(@supports ( -webkit-backdrop-filter: blur(10px) )):
(.sub-menu-layer):
(.nextrouter .link,):
(.pagination):
(.pagination::after):
(.pagination .page-numbers):
(.pagination .dots,):
(.pagination .next-button):
(.nextrouter):
(.nextrouter:hover):
(.nextrouter.previous):
(.nextrouter.previous:hover):
(.nextrouter .bodycopy):
(.nextrouter a):
(.nextrouter a:hover):
(.nextrouter-copy):
(.nextrouter .label):
(.nextrouter .title):
(.nextrouter .link):
(.nextrouter a:hover .link):
(footer):
(.tiles):
(.tile):
(.third-tile):
(.two-thirds-tile):
(.tile .background-image):
(.tile .background-image.has-featured-image):
(.tile .featured-image):
(.tile:not(.has-post-thumbnail) .background-image,):
(.tile h1):
(.tile h2):
(.tile .summary,):
(pre):
(article):
(article::after):
(article h1):
(article h2):
(article h3):
(article h4):
(article h5):
(article h6):
(article h2 + h3,):
(article figcaption):
(article figcaption::before):
(.table-of-contents):
(article .table-of-contents label):
(.table-of-contents ul):
(.table-of-contents ul li):
(.table-of-contents ul li > ul):
(.site-logo):
(footer nav):
(header nav li):
(header nav a,):
(header .menu-item-has-children .label-toggle::after):
(header .menu-item):
(@media only screen and (max-width: 1180px)):
(article .byline):
(@media only screen and (max-width: 920px)):
(.main-menu.label-toggle):
(header .menu):
(header nav a):
(header .menu-main-menu-container >  ul > li):
(header .sub-menu-layer):
(@media only screen and (max-width: 690px)):
(.third-tile,):
(@media only screen and (max-width: 600px)):
(.table-of-contents label:after):
(@media only screen and (max-width: 415px)):
(@media only screen and (max-height: 415px)):
(@supports(padding:max(0px))):
(header .menu .menu-item > .sub-menu):
(.sub-menu-layer .menu-item:first-child,):
(#template):
(#compass):
(.tile .featured-image,): Deleted.
(.site-logo .tagline): Deleted.
(.timeline): Deleted.
(.timeline:after): Deleted.
(.timeline *): Deleted.
(.timeline:before): Deleted.
(.timeline > li): Deleted.
(.timeline > li:before): Deleted.
(.timeline .content): Deleted.
(.timeline figure): Deleted.
(.timeline .time): Deleted.
(.timeline h2, .timeline h3): Deleted.
(.timeline .time::before): Deleted.
(.timeline img): Deleted.
(@media (min-width: 900px)): Deleted.
(.timeline > li.force-clear): Deleted.
(.timeline > li:nth-child(odd)): Deleted.
(.timeline > li:nth-child(even)): Deleted.
(.timeline > li:nth-child(2),): Deleted.
(.timeline li .time): Deleted.
(.timeline li:nth-child(odd) .time): Deleted.
(.timeline li:nth-child(even) .time): Deleted.
(.timeline li:nth-child(even) .time::before): Deleted.
(.timeline > li:nth-child(even):before): Deleted.
(@media (max-width: 900px)): Deleted.
(.timeline li .time::before): Deleted.
(.hero .logo,): Deleted.
(.home .hero): Deleted.
(.home.admin-bar .hero): Deleted.
(@media only screen and (max-width: 320px)): Deleted.
* wp-content/themes/webkit/widgets/post.php: Updated "read more" link presentation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoMark editing/execCommand/underline-selection-containing-image.html as failing on...
pvollan@apple.com [Mon, 13 Nov 2017 15:57:50 +0000 (15:57 +0000)]
Mark editing/execCommand/underline-selection-containing-image.html as failing on Windows.
https://bugs.webkit.org/show_bug.cgi?id=179613

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Attachment Support] Implement SPI for clients to request data for a given attachment
wenson_hsieh@apple.com [Mon, 13 Nov 2017 15:30:39 +0000 (15:30 +0000)]
[Attachment Support] Implement SPI for clients to request data for a given attachment
https://bugs.webkit.org/show_bug.cgi?id=179586
<rdar://problem/35355720>

Reviewed by Darin Adler.

Source/WebCore:

Adds support in WebCore for fetching data for a given attachment element. See per-method comments below for
more detail.

Test coverage by augmenting existing API tests in WKAttachmentTests, and adding 3 new tests.

* dom/Document.cpp:
(WebCore::Document::didInsertAttachmentElement):
(WebCore::Document::didRemoveAttachmentElement):
(WebCore::Document::attachmentForIdentifier const):

Fetches an attachment element matching the given identifier. Using the identifier => attachment element map here
allows us to avoid the cost of walking the DOM in search for HTMLAttachmentElements every time data is
requested.

* dom/Document.h:

Add a map of attachment identifier => HTMLAttachmentElement in Document. This map is updated when attachment
elements are connected to or disconnected from the document. Additionally, delegate attachment insertion and
removal out to the Editor if possible.

* editing/Editor.cpp:
(WebCore::Editor::insertAttachmentFromFile):
* editing/mac/WebContentReaderMac.mm:
(WebCore::WebContentReader::readFilenames):
* editing/markup.cpp:
(WebCore::createFragmentFromMarkup):

Tweak existing logic that transfers file-backed File objects when deserializing HTMLAttachmentElements from
markup to handle the case where the attachment element is not file-backed. In this case, we construct a new
File object using the deserializing constructor. To do this, we use the attachment element's blob URL to make
sure that the new File references an existing blob matching that URL.

* html/HTMLAttachmentElement.cpp:
(WebCore::AttachmentDataReader::create):
(WebCore::AttachmentDataReader::AttachmentDataReader):

Introduce AttachmentDataReader, a helper class local to HTMLAttachmentElement that is responsible for loading
an attachment element's file and invoking a given callback when loading has succeeded or failed.
Each AttachmentDataReader is retained exclusively by its HTMLAttachmentElement, through the
HTMLAttachmentElement's vector of unique_ptrs to AttachmentDataReaders.

(WebCore::HTMLAttachmentElement::~HTMLAttachmentElement):
(WebCore::HTMLAttachmentElement::blobURL const):

Add a convenience getter for the blob URL of the attachment's backing File object.

(WebCore::HTMLAttachmentElement::setFile):

When setting an attachment element's file, set the blob URL attribute as well to the blob URL. Also, tweak this
to take a RefPtr<File>&& instead of a raw File*.

(WebCore::HTMLAttachmentElement::insertedIntoAncestor):
(WebCore::HTMLAttachmentElement::removedFromAncestor):

Instead of delegating attachment insertion and removal to the Editor, just call out to the Document, which will
now call out to the Editor.

(WebCore::HTMLAttachmentElement::attachmentPath const):

Add a convenience getter for the attachment path attribute.

(WebCore::HTMLAttachmentElement::requestData):
(WebCore::HTMLAttachmentElement::destroyReader):

Called when a AttachmentDataReader has completed (either with success or failure), and is ready to be removed
from the attachment element's list of active data readers.

(WebCore::AttachmentDataReader::~AttachmentDataReader):
(WebCore::AttachmentDataReader::didFinishLoading):
(WebCore::AttachmentDataReader::didFail):
(WebCore::AttachmentDataReader::invokeCallbackAndFinishReading):

When the reader is done loading, or has failed, or is about to be destroyed, fire the callback with loaded data
(if any) and cancel the FileReaderLoader.

* html/HTMLAttachmentElement.h:
* html/HTMLAttributeNames.in:

Adds a new "webkitattachmentbloburl" attribute that keeps track of an attachment element's file's blob URL. This
is used to ensure that information about an attachment element's file is not lost between certain editing
operations (for instance, deleting a line break) that involve serializing and then deserializing markup into
DocumentFragments to then insert.

Source/WebKit:

Adds support in WebKit for fetching data for a given attachment element. See WebCore/ChangeLog for more details.
Most of the changes here are boilerplate plumbing of -requestAttachmentData through the client layers.

Test coverage by augmenting existing API tests in WKAttachmentTests, and adding 3 new tests.

* UIProcess/API/APIAttachment.cpp:
(API::Attachment::requestData):
* UIProcess/API/APIAttachment.h:
* UIProcess/API/Cocoa/_WKAttachment.h:
* UIProcess/API/Cocoa/_WKAttachment.mm:
(-[_WKAttachment requestData:]):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::sharedBufferCallback):

Add a new IPC callback helper type, SharedBufferCallback. This is similar to the existing DataCallback, but
instead of deserializing to an API::Data, we convert to a SharedBuffer instead. Additionally,
SharedBufferCallback is able to draw a distinction between null data and empty data. This allows -requestData:
to distinguish between cases where (for instance) the data for a given attachment is an empty blob, and when
the attachment doesn't exist at all.

(WebKit::WebPageProxy::dataCallback):
(WebKit::WebPageProxy::insertAttachment):
(WebKit::WebPage::invokeSharedBufferCallback):
(WebKit::WebPageProxy::requestAttachmentData):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::requestAttachmentData):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

Augments existing API tests in WKAttachmentTests to additionally check that -requestData: yields the correct
result when performing various editing operations. Also adds a new API test that cuts and pastes an attachment
inserted using WKWebView attachment SPI, and expects that the data of the attachment can still be fetched using
the _WKAttachment SPI, as well as another test that inserts an empty NSData and expects that requestData: also
yields an empty NSData result.

* TestWebKitAPI/Tests/WebKitCocoa/WKAttachmentTests.mm:
(-[NSData shortDescription]):
(-[_WKAttachment synchronouslyRequestData:]):
(-[_WKAttachment expectRequestedDataToBe:]):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Remove GraphicsContext::mustUseShadowBlur()
zandobersek@gmail.com [Mon, 13 Nov 2017 14:50:30 +0000 (14:50 +0000)]
[Cairo] Remove GraphicsContext::mustUseShadowBlur()
https://bugs.webkit.org/show_bug.cgi?id=179612

Reviewed by Michael Catanzaro.

Remove the Cairo-specific mustUseShadowBlur() method on the
GraphicsContext class. It can now be implemented as a static function
in CairoOperations, using only a PlatformContextCairo object and a
const reference to the relevant GraphicsContextState.

No new tests -- no change in behavior.

* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::mustUseShadowBlur const): Deleted.
* platform/graphics/GraphicsContext.h:
* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::mustUseShadowBlur):
(WebCore::Cairo::drawGlyphsShadow):
(WebCore::Cairo::fillRectWithRoundedHole):
(WebCore::Cairo::drawGlyphs):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::FontCascade::drawGlyphs):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillRectWithRoundedHole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move state change operations from GraphicsContextCairo to CairoOperations
zandobersek@gmail.com [Mon, 13 Nov 2017 13:41:41 +0000 (13:41 +0000)]
[Cairo] Move state change operations from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179610

Reviewed by Carlos Garcia Campos.

Move operations that perform Cairo state changes to the CairoOperations
file. This enforces only using the PlatformContextCairo object to
achieve the state change, leveraging the cairo_t and ShadowBlur objects
that are owned by PlatformContextCairo.

Along with state modification operations, various state query operations
are also placed under the Cairo::State namespace, again limited to the
PlatformContextCairo object.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::State::setStrokeThickness):
(WebCore::Cairo::State::setGlobalAlpha):
(WebCore::Cairo::State::setCompositeOperation):
(WebCore::Cairo::State::setShouldAntialias):
(WebCore::Cairo::State::setImageInterpolationQuality):
(WebCore::Cairo::State::setCTM):
(WebCore::Cairo::State::getCTM):
(WebCore::Cairo::State::setShadowValues):
(WebCore::Cairo::State::clearShadow):
(WebCore::Cairo::State::getClipBounds):
(WebCore::Cairo::State::roundToDevicePixels):
(WebCore::Cairo::State::isAcceleratedContext):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::getCTM const):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::clipBounds const):
(WebCore::GraphicsContext::roundToDevicePixels):
(WebCore::GraphicsContext::setPlatformStrokeThickness):
(WebCore::GraphicsContext::setCTM):
(WebCore::GraphicsContext::setPlatformShadow):
(WebCore::GraphicsContext::clearPlatformShadow):
(WebCore::GraphicsContext::setPlatformAlpha):
(WebCore::GraphicsContext::setPlatformCompositeOperation):
(WebCore::GraphicsContext::setPlatformShouldAntialias):
(WebCore::GraphicsContext::setPlatformImageInterpolationQuality):
(WebCore::GraphicsContext::isAcceleratedContext const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move glyph drawing operations from FontCairo to CairoOperations
zandobersek@gmail.com [Mon, 13 Nov 2017 13:33:07 +0000 (13:33 +0000)]
[Cairo] Move glyph drawing operations from FontCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179609

Reviewed by Carlos Garcia Campos.

Move operations that perform glyph drawing to the CairoOperations file.
This limits operations to only work with a PlatformContextCairo object,
along with other required parameters, and will help with future work
that will rely on isolated Cairo-specific code.

Along with moving the drawGlyphs() code, the helper functions are moved
and adjusted to work specifically on a PlatformContextCairo object and
a const GraphicsContextState reference, only using a GraphicsContext
reference for any required shadowed glyph drawing.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawGlyphsToContext):
(WebCore::Cairo::drawGlyphsShadow):
(WebCore::Cairo::drawGlyphs):
* platform/graphics/cairo/FontCairo.cpp:
(WebCore::FontCascade::drawGlyphs):
(WebCore::drawGlyphsToContext): Deleted.
(WebCore::drawGlyphsShadow): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed GTK+ gardening. Mark editing/execCommand/underline-selection-containing...
carlosgc@webkit.org [Mon, 13 Nov 2017 09:55:42 +0000 (09:55 +0000)]
Unreviewed GTK+ gardening. Mark editing/execCommand/underline-selection-containing-image.html as failing.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[GTK] Enable some passing XHR tests
Ms2ger@igalia.com [Mon, 13 Nov 2017 09:28:54 +0000 (09:28 +0000)]
[GTK] Enable some passing XHR tests
https://bugs.webkit.org/show_bug.cgi?id=179533

Reviewed by Alex Christensen.

* platform/gtk/TestExpectations: Remove failure expectations.
* platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/getallresponseheaders-expected.txt:
  Removed: the platform-neutral expectation file (two passes rather than
  one pass, one fail) matches the current output on GTK.
* platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-async-expected.txt:
  Added: the platform-neutral expectation file has subtests marked as
  failing, though they all pass on GTK.
* platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/send-entity-body-get-head-expected.txt:
  Added: the platform-neutral expectation file has subtests marked as
  failing, though they all pass on GTK.
* platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/send-redirect-expected.txt:
  Added: the platform-neutral expectation file has subtests marked as
  failing, though they all pass on GTK.
* platform/gtk/imported/w3c/web-platform-tests/XMLHttpRequest/setrequestheader-content-type-expected.txt:
  Added: some of the subtests marked as failing in the platform-neutral
  expectation file are passing on GTK.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move focus ring drawing operations from GraphicsContextCairo to CairoOperations
zandobersek@gmail.com [Mon, 13 Nov 2017 09:19:19 +0000 (09:19 +0000)]
[Cairo] Move focus ring drawing operations from GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179603

Reviewed by Carlos Garcia Campos.

Move operations that perform focus ring drawing to the CairoOperations
file. This limits operations to only work with a PlatformContextCairo
object, along with other required parameters, and will help with future
work in this area.

The Cairo::State namespace is introduced, with the setStrokeStyle()
function placed there. The namespace will be used for operations that
only change an aspect of the Cairo state. More functions will be added
soon, and existing line and miter operations will likely move there as
well.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::adjustFocusRingColor):
(WebCore::Cairo::adjustFocusRingLineWidth):
(WebCore::Cairo::focusRingStrokeStyle):
(WebCore::Cairo::State::setStrokeStyle):
(WebCore::Cairo::drawFocusRing):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawFocusRing):
(WebCore::GraphicsContext::setPlatformStrokeStyle):
(WebCore::adjustFocusRingColor): Deleted.
(WebCore::adjustFocusRingLineWidth): Deleted.
(WebCore::focusRingStrokeStyle): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoUnreviewed. Fix debug build with Touch Events enabled after r224740.
carlosgc@webkit.org [Mon, 13 Nov 2017 08:23:45 +0000 (08:23 +0000)]
Unreviewed. Fix debug build with Touch Events enabled after r224740.

* dom/EventContext.cpp:
(WebCore::TouchEventContext::checkReachability const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoRemove support for UTF-32 variant text encodings
mjs@apple.com [Mon, 13 Nov 2017 07:54:55 +0000 (07:54 +0000)]
Remove support for UTF-32 variant text encodings
https://bugs.webkit.org/show_bug.cgi?id=179435

Reviewed by Darin Adler.

LayoutTests/imported/w3c:

* web-platform-tests/encoding/unsupported-encodings-expected.txt: Update results now
that UTF-32 support is gone. Still not quite right since we don't sniff UTF-32LE as
UTF-16LE yet.
* web-platform-tests/encoding/utf-32-expected.txt: ditto

Source/WebCore:

Non-support for these encodings is covered by WPT tests.

* platform/text/TextCodecICU.cpp: Remove UTF-32 variants.
Technically, we should also ensure that UTF-32LE with a BOM
gets sniffed as UTF-16LE instead of windows-1252. Chrome
does this but Firefox doesn't yet. WPT tests cover it, and
we can fix it later.

LayoutTests:

* fast/encoding/legacy-utf-32-aliases.html: Added. Check that
we don't support our legacy aliases for utf-32, since WPT doesn't
either.
* fast/encoding/legacy-utf-32-aliases-expected.txt: Ditto.

Remove the following tests; we no longer want to support UTF-32.

imported/w3c/web-platform-tests/encoding already has tests for lack of support.

* fast/encoding/utf-32-big-endian-bom-expected.txt: Removed.
* fast/encoding/utf-32-big-endian-bom.html: Removed.
* fast/encoding/utf-32-big-endian-nobom-expected.txt: Removed.
* fast/encoding/utf-32-big-endian-nobom.xml: Removed.
* fast/encoding/utf-32-little-endian-bom-expected.txt: Removed.
* fast/encoding/utf-32-little-endian-bom.html: Removed.
* fast/encoding/utf-32-little-endian-nobom-expected.txt: Removed.
* fast/encoding/utf-32-little-endian-nobom.xml: Removed.
* http/tests/misc/submit-get-in-utf32be-expected.txt: Removed.
* http/tests/misc/submit-get-in-utf32be.html: Removed.
* http/tests/misc/submit-get-in-utf32le-expected.txt: Removed.
* http/tests/misc/submit-get-in-utf32le.html: Removed.
* http/tests/misc/submit-post-in-utf32be-expected.txt: Removed.
* http/tests/misc/submit-post-in-utf32be.html: Removed.
* http/tests/misc/submit-post-in-utf32le-expected.txt: Removed.
* http/tests/misc/submit-post-in-utf32le.html: Removed.
* http/tests/misc/url-in-utf32be-expected.txt: Removed.
* http/tests/misc/url-in-utf32be.html: Removed.
* http/tests/misc/url-in-utf32le-expected.txt: Removed.
* http/tests/misc/url-in-utf32le.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move rectangle and path filling, stroking, clearing operations in GraphicsCon...
zandobersek@gmail.com [Mon, 13 Nov 2017 07:43:22 +0000 (07:43 +0000)]
[Cairo] Move rectangle and path filling, stroking, clearing operations in GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179599

Reviewed by Carlos Garcia Campos.

Move operations that perform filling, stroking and clearing for
specified rectangles and paths to the CairoOperations file. This limits
operations to only work with a PlatformContextCairo object, along with
any required parameter, and will help with future work in this area.

Helper functions are copied along for the time being, but will later be
removed from the GraphicsContextCairo implementation file.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::fillRectWithColor):
(WebCore::Cairo::drawPathShadow):
(WebCore::Cairo::fillCurrentCairoPath):
(WebCore::Cairo::fillRect):
(WebCore::Cairo::fillRoundedRect):
(WebCore::Cairo::fillRectWithRoundedHole):
(WebCore::Cairo::fillPath):
(WebCore::Cairo::strokeRect):
(WebCore::Cairo::strokePath):
(WebCore::Cairo::clearRect):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GradientCairo.cpp:
(WebCore::Gradient::fill):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::fillRect):
(WebCore::GraphicsContext::clearRect):
(WebCore::GraphicsContext::strokeRect):
(WebCore::GraphicsContext::platformFillRoundedRect):
(WebCore::GraphicsContext::fillRectWithRoundedHole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years agoREGRESSION(r224566): [GTK] 26 new timeouts on inspector related tests.
carlosgc@webkit.org [Mon, 13 Nov 2017 07:41:18 +0000 (07:41 +0000)]
REGRESSION(r224566): [GTK] 26 new timeouts on inspector related tests.
https://bugs.webkit.org/show_bug.cgi?id=179471

Reviewed by Darin Adler.

Source/WebInspectorUI:

TestStub.html and TestStub.js was missing in resources bundle.

* Scripts/copy-user-interface-resources.pl: Also combine resources for TestStub.

LayoutTests:

Unskip tests that are passing now.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move state stack, CTM, transparency layer operations in GraphicsContextCairo...
zandobersek@gmail.com [Mon, 13 Nov 2017 07:37:45 +0000 (07:37 +0000)]
[Cairo] Move state stack, CTM, transparency layer operations in GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179598

Reviewed by Carlos Garcia Campos.

Move operations that save and restore state, adjust CTM and modify the
transparency layer stack to the CairoOperations file. This limits
operations to only work with a PlatformContextCairo object, along with
any required parameter, and will help with future work in this area.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::save):
(WebCore::Cairo::restore):
(WebCore::Cairo::translate):
(WebCore::Cairo::rotate):
(WebCore::Cairo::scale):
(WebCore::Cairo::concatCTM):
(WebCore::Cairo::beginTransparencyLayer):
(WebCore::Cairo::endTransparencyLayer):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::savePlatformState):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::translate):
(WebCore::GraphicsContext::concatCTM):
(WebCore::GraphicsContext::beginPlatformTransparencyLayer):
(WebCore::GraphicsContext::endPlatformTransparencyLayer):
(WebCore::GraphicsContext::rotate):
(WebCore::GraphicsContext::scale):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

2 years ago[Cairo] Move line, miter operations in GraphicsContextCairo to CairoOperations
zandobersek@gmail.com [Mon, 13 Nov 2017 07:32:03 +0000 (07:32 +0000)]
[Cairo] Move line, miter operations in GraphicsContextCairo to CairoOperations
https://bugs.webkit.org/show_bug.cgi?id=179597

Reviewed by Carlos Garcia Campos.

Move operations that adjust line cap, line dash, line join and miter
limit to the CairoOperations file. This limits operations to only work
with a PlatformContextCairo object, along with any required parameter,
and will help with future work in this area.

No new tests -- no change in behavior.

* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::setLineCap):
(WebCore::Cairo::setLineDash):
(WebCore::Cairo::setLineJoin):
(WebCore::Cairo::setMiterLimit):
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setLineCap):
(WebCore::GraphicsContext::setLineDash):
(WebCore::GraphicsContext::setLineJoin):
(WebCore::GraphicsContext::setMiterLimit):
(WebCore::isDashArrayAllZero): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@224743 268f45cc-cd09-0410-ab3c-d52691b4dbfc