WebKit-https.git
7 years agoUnreviewed. Rolled DEPS.
tony@chromium.org [Tue, 3 Jul 2012 17:49:41 +0000 (17:49 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Anonymous scripts (evals) should not be added to Workspace.
vsevik@chromium.org [Tue, 3 Jul 2012 17:47:24 +0000 (17:47 +0000)]
Web Inspector: Anonymous scripts (evals) should not be added to Workspace.
https://bugs.webkit.org/show_bug.cgi?id=90467

Reviewed by Pavel Feldman.

* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeAdded):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeReplaced):
(WebInspector.ResourceScriptMapping.prototype._uiSourceCodeRemoved):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel.prototype._createUISourceCodeForScript):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._uiSourceCodeAdded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSS 2.1 failure: floats-wrap-top-below-inline-* fail
robert@webkit.org [Tue, 3 Jul 2012 17:41:35 +0000 (17:41 +0000)]
CSS 2.1 failure: floats-wrap-top-below-inline-* fail
https://bugs.webkit.org/show_bug.cgi?id=88171

Reviewed by Eric Seidel.

Source/WebCore:

When shifting a line or element left or right to avoid a float use the height
of the line or element to determine whether the float is inside the element or
if it overlaps the bottom of the element.

Do this by passing the height of the element to the interval tree used to detect
the overlap with it's containing block's floats. The height is zero by default so
callers to logical[Left|Right]OffsetForLine will need to pass the height if they
want to use it to detect floats to avoid.

Tests: css2.1/20110323/floats-wrap-top-below-bfc-001l.htm
       css2.1/20110323/floats-wrap-top-below-bfc-001r.htm
       css2.1/20110323/floats-wrap-top-below-bfc-002l.htm
       css2.1/20110323/floats-wrap-top-below-bfc-002r.htm
       css2.1/20110323/floats-wrap-top-below-bfc-003l.htm
       css2.1/20110323/floats-wrap-top-below-bfc-003r.htm
       css2.1/20110323/floats-wrap-top-below-inline-001l.htm
       css2.1/20110323/floats-wrap-top-below-inline-001r.htm
       css2.1/20110323/floats-wrap-top-below-inline-002l.htm
       css2.1/20110323/floats-wrap-top-below-inline-002r.htm
       css2.1/20110323/floats-wrap-top-below-inline-003l.htm
       css2.1/20110323/floats-wrap-top-below-inline-003r.htm
       css2.1/20110323/floats-zero-height-wrap-001.htm
       css2.1/20110323/floats-zero-height-wrap-002.htm
       fast/block/float/floats-wrap-inside-inline-001.htm
       fast/block/float/floats-wrap-inside-inline-002.htm
       fast/block/float/floats-wrap-inside-inline-003.htm
       fast/block/float/floats-wrap-inside-inline-004.htm
       fast/block/float/floats-wrap-inside-inline-005.htm

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeStartPositionDeltaForChildAvoidingFloats):
(WebCore::::collectIfNeeded):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::getClearDelta):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::availableLogicalWidthForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::startOffsetForLine):
(WebCore::RenderBlock::endOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalLeftOffsetForLine):
(WebCore::RenderBlock::pixelSnappedLogicalRightOffsetForLine):
(RenderBlock):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::FloatIntervalSearchAdapter):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::lowValue):
(WebCore::RenderBlock::FloatIntervalSearchAdapter::highValue):
(FloatIntervalSearchAdapter):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::logicalBottomForLine):
(WebCore):
(WebCore::LineWidth::updateAvailableWidth):
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::containingBlockAvailableLineWidthInRegion):

LayoutTests:

* css2.1/20110323/floats-wrap-top-below-001l-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-001r-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-002l-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-002r-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-003l-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-003r-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-001l-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-001l.htm: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-001r-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-001r.htm: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-002l-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-002l.htm: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-002r-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-002r.htm: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-003l-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-003l.htm: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-003r-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-bfc-003r.htm: Added.
* css2.1/20110323/floats-wrap-top-below-inline-001l-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-inline-001l.htm: Added.
* css2.1/20110323/floats-wrap-top-below-inline-001r-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-inline-001r.htm: Added.
* css2.1/20110323/floats-wrap-top-below-inline-002l-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-inline-002l.htm: Added.
* css2.1/20110323/floats-wrap-top-below-inline-002r-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-inline-002r.htm: Added.
* css2.1/20110323/floats-wrap-top-below-inline-003l-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-inline-003l.htm: Added.
* css2.1/20110323/floats-wrap-top-below-inline-003r-expected.html: Added.
* css2.1/20110323/floats-wrap-top-below-inline-003r.htm: Added.
* css2.1/20110323/floats-zero-height-wrap-001-expected.html: Added.
* css2.1/20110323/floats-zero-height-wrap-001.htm: Added.
* css2.1/20110323/floats-zero-height-wrap-002.htm: Added.
* css2.1/20110323/floats-zero-height-wrap-002-expected.html: Added.
All of these are taken from the CSS test suite, including the expected.html files which have been renamed
from *-ref.html so that new-run-webkit-tests will parse use them.
* fast/block/float/floats-wrap-inside-inline-001-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-001.htm: Added.
The span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float starts and ends inside the span's first linebox.
* fast/block/float/floats-wrap-inside-inline-002-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-002.htm: Added.
The span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float overlaps the bottom of the span, but is below the span's first linebox.
* fast/block/float/floats-wrap-inside-inline-003-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-003.htm: Added.
An inline span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float starts and ends inside the span's first linebox.
* fast/block/float/floats-wrap-inside-inline-004-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-004.htm: Added.
The span should avoid a float even when its top and bottom does not overlap with the top of the span.
In this test the float overlaps inside the span and the span has height set by its style.
* fast/block/float/floats-wrap-inside-inline-005-expected.html: Added.
* fast/block/float/floats-wrap-inside-inline-005.htm: Added.
In this test the float starts and ends inside the span's second linebox, so only the second linebox should avoid the float.
* platform/chromium-win/css1/formatting_model/floating_elements-expected.txt:
This is a progression due to lineboxes now avoiding floats they overlap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WTR] Get rid of using DumpRenderTreeSupportQt
kbalazs@webkit.org [Tue, 3 Jul 2012 17:36:27 +0000 (17:36 +0000)]
[Qt][WTR] Get rid of using DumpRenderTreeSupportQt
https://bugs.webkit.org/show_bug.cgi?id=90262

Unreviewed build fix.

Reverting r121550 manually because it caused build
break on ARM and Mac. It turned out that the Qt build
system is too broken for this change now, first we have
to address two issues:
    * symbol hiding was forbidden accidentally on x86 Linux
    * Qt lacks a separate library for test support

* Tools.pro:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::resetAfterTest):
(WTR::InjectedBundlePage::didClearWindowForFrame):
* WebKitTestRunner/InjectedBundle/qt/ActivateFontsQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium rebaseline for r121728.
eae@chromium.org [Tue, 3 Jul 2012 17:30:44 +0000 (17:30 +0000)]
Unreviewed chromium rebaseline for r121728.

* platform/chromium-mac/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Added.
* platform/chromium-win/fast/multicol/vertical-rl/rules-with-border-before-expected.png:
* platform/chromium/fast/multicol/vertical-rl/rules-with-border-before-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Handle trailing backslash on %VSINSTALLDIR%
tony@chromium.org [Tue, 3 Jul 2012 17:28:32 +0000 (17:28 +0000)]
[chromium] Handle trailing backslash on %VSINSTALLDIR%
https://bugs.webkit.org/show_bug.cgi?id=90410

Reviewed by Ojan Vafai.

* Scripts/webkitdirs.pm:
(buildChromiumVisualStudioProject): Handle VSINSTALLDIR ending in a backslash, the backslash escapes the closing double quote.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake the skia_test_expectations.txt file optional.
ojan@chromium.org [Tue, 3 Jul 2012 17:21:52 +0000 (17:21 +0000)]
Make the skia_test_expectations.txt file optional.
https://bugs.webkit.org/show_bug.cgi?id=90400

Reviewed by Dirk Pranke.

It used to be optional. This regressed at some point. It's important that it be
optional so that webkit-patch commands work in a pure-webkit checkout for chromium bots.
Specifically, this was breaking webkit-patch rebaseline-test when it would go to update
TestExpectations.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumPort.expectations_files):
* Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
(ChromiumDriverTest.test_expectations_dict):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium rebaseline.
eae@chromium.org [Tue, 3 Jul 2012 17:17:12 +0000 (17:17 +0000)]
Unreviewed chromium rebaseline.

* platform/chromium-linux-x86/fast/line-grid: Added.
* platform/chromium-linux-x86/fast/line-grid/line-grid-into-columns-expected.txt: Added.
* platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.png:
* platform/chromium-linux/fast/line-grid/line-grid-into-columns-expected.txt: Added.
* platform/chromium-win-xp/fast/line-grid: Added.
* platform/chromium-win-xp/fast/line-grid/line-grid-into-columns-expected.txt: Added.
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.png:
* platform/chromium-win/fast/line-grid/line-grid-into-columns-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[jhbuild][EFL] Bump libffi dependency.
rakuco@webkit.org [Tue, 3 Jul 2012 17:15:50 +0000 (17:15 +0000)]
[jhbuild][EFL] Bump libffi dependency.
https://bugs.webkit.org/show_bug.cgi?id=85373

Reviewed by Gustavo Noronha Silva.

Update libffi to 3.0.11, which fixes the build on some platforms
where 3.0.10 had problems.

* efl/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium TestExpectations update, marked a couple of tests as flaky on...
eae@chromium.org [Tue, 3 Jul 2012 17:14:54 +0000 (17:14 +0000)]
Unreviewed chromium TestExpectations update, marked a couple of tests as flaky on windows.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium mac rebaseline.
eae@chromium.org [Tue, 3 Jul 2012 16:55:25 +0000 (16:55 +0000)]
Unreviewed chromium mac rebaseline.

* platform/chromium-linux-x86/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
* platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
* platform/chromium-mac/http/tests/misc/acid3-expected.txt:
* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.png:
* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:
* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.png:
* platform/chromium-mac/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-expected.txt:
* platform/chromium-win-xp/svg/custom/object-sizing-width-50p-height-75p-on-target-svg-absolute-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Enable microdata support for BlackBerry.
staikos@webkit.org [Tue, 3 Jul 2012 16:34:07 +0000 (16:34 +0000)]
[BlackBerry] Enable microdata support for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90429

Reviewed by Rob Buis.

.:

* Source/cmake/OptionsBlackBerry.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Introduce Workspace make it UISourceCode provider for ScriptsPanel.
vsevik@chromium.org [Tue, 3 Jul 2012 16:29:06 +0000 (16:29 +0000)]
Web Inspector: Introduce Workspace make it UISourceCode provider for ScriptsPanel.
https://bugs.webkit.org/show_bug.cgi?id=90466

Reviewed by Pavel Feldman.

Introduced WebInspector.Workspace as a model (UISourceCode provider) behind ScriptsPanel.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/ScriptsPanel.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/Workspace.js: Added.
(WebInspector.CompositeUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._registerUISourceCodeProvider):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeAdded):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeReplaced):
(WebInspector.CompositeUISourceCodeProvider.prototype._handleUISourceCodeRemoved):
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodes):
(WebInspector.Workspace):
(WebInspector.Workspace.prototype.registerUISourceCodeProvider):
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make use of .qmake.cache for caching features
vestbo@webkit.org [Tue, 3 Jul 2012 16:22:10 +0000 (16:22 +0000)]
[Qt] Make use of .qmake.cache for caching features

Instead of loading() features from the files that need them (and re-running
a bunch of checks), we now run feature detection as part of configure.pro,
and have build-webkit write the computed feature-defines and CONFIG to
.qmake.cache, which is then loaded by qmake _before_ even defaults_pre
when building WebKit.pro.

At some point we'll be able to selectivly prevent running of config tests
in configure.pro, which means we don't need a separate code-path for
the build-webkit --help case.

We should also move the code in build-webkit that now uses .webkit.config
to detect clean builds, to use .qmake.cache, since we now store the same
thing there.

Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>

https://bugs.webkit.org/show_bug.cgi?id=90461

Reviewed by Tor Arne Vestbø.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago-Wunused-private-field cleanup, linux edition
thakis@chromium.org [Tue, 3 Jul 2012 16:15:24 +0000 (16:15 +0000)]
-Wunused-private-field cleanup, linux edition
https://bugs.webkit.org/show_bug.cgi?id=90463

Reviewed by Stephen White.

* DumpRenderTree/chromium/DRTDevToolsAgent.h:
* DumpRenderTree/chromium/GamepadController.h:
(GamepadController):
* DumpRenderTree/chromium/NotificationPresenter.h:
(NotificationPresenter::NotificationPresenter):
(NotificationPresenter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r121766.
commit-queue@webkit.org [Tue, 3 Jul 2012 16:04:50 +0000 (16:04 +0000)]
Unreviewed, rolling out r121766.
http://trac.webkit.org/changeset/121766
https://bugs.webkit.org/show_bug.cgi?id=90465

It caused flakey build errors on the bots (Requested by Ossy
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-03

.:

* Source/QtWebKit.pro:
* Source/api.pri:
* Source/tests.pri:
* WebKit.pro:

Source/WebCore:

* DerivedSources.pri:
* WebCore.pri:

Source/WebKit/qt:

* declarative/declarative.pro:
* declarative/public.pri:
* tests/qgraphicswebview/qgraphicswebview.pro:

Source/WebKit2:

* DerivedSources.pri:
* Target.pri:

Source/WTF:

* WTF.pri:

Tools:

* DumpRenderTree/qt/DumpRenderTree.pro:
* QtTestBrowser/QtTestBrowser.pro:
* Scripts/webkitdirs.pm:
(qtFeatureDefaults):
(buildQMakeProjects):
* Tools.pro:
* WebKitTestRunner/InjectedBundle/DerivedSources.pri:
* WebKitTestRunner/InjectedBundle/Target.pri:
* WebKitTestRunner/Target.pri:
* qmake/.qmake.conf: Removed.
* qmake/configure.pro:
* qmake/mkspecs/features/default_post.prf:
* qmake/mkspecs/features/default_pre.prf:
* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
staikos@webkit.org [Tue, 3 Jul 2012 16:00:22 +0000 (16:00 +0000)]
[BlackBerry] Enable Custom Scheme Handlers for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90422

Reviewed by Rob Buis.

.:

* Source/cmake/OptionsBlackBerry.cmake:

Source/WebCore:

* page/NavigatorRegisterProtocolHandler.cpp:
(WebCore::initProtocolHandlerWhitelist): Disable the overrides as
                                         they're undesired by BlackBerry

Source/WebKit/blackberry:

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::isProtocolHandlerRegistered):
(WebCore::ChromeClientBlackBerry::unregisterProtocolHandler):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
staikos@webkit.org [Tue, 3 Jul 2012 15:53:31 +0000 (15:53 +0000)]
[BlackBerry] Enable RegisterProtocolHandler for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90422

Reviewed by Rob Buis.

.:

* Source/cmake/OptionsBlackBerry.cmake:

Source/WebKit/blackberry:

* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore):
(WebCore::ChromeClientBlackBerry::registerProtocolHandler):
* WebCoreSupport/ChromeClientBlackBerry.h:
(ChromeClientBlackBerry):

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Need to bump libsoup requirements (for `soup_cookie_jar_get_cookie_list`)
commit-queue@webkit.org [Tue, 3 Jul 2012 15:48:38 +0000 (15:48 +0000)]
[GTK] Need to bump libsoup requirements (for `soup_cookie_jar_get_cookie_list`)
https://bugs.webkit.org/show_bug.cgi?id=90332

Patch by Priit Laes <plaes@plaes.org> on 2012-07-03
Reviewed by Gustavo Noronha Silva.

* configure.ac: Bump libsoup requirements to 2.39.2

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add WebKitWebView::context-menu-dismissed signal to WebKit2 GTK+ API
carlosgc@webkit.org [Tue, 3 Jul 2012 15:43:42 +0000 (15:43 +0000)]
[GTK] Add WebKitWebView::context-menu-dismissed signal to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=90386

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:
(webkit_web_view_class_init): Add context-menu-dismissed signal.
(contextMenuDismissed): Emit context-menu-dismissed signal.
(webkitWebViewPopulateContextMenu): Connect to deactivate signal
of the GtkMenu and emit WebKitWebView::context-menu-dismissed when
the gtk menu is deactivated.
* UIProcess/API/gtk/WebKitWebView.h:
(_WebKitWebViewClass): Add virtual methos for
context-menu-dismissed signal.
* UIProcess/API/gtk/tests/TestContextMenu.cpp:
(testContextMenuDismissed):
(beforeAll):
* UIProcess/gtk/WebContextMenuProxyGtk.h:
(WebKit::WebContextMenuProxyGtk::gtkMenu): Get the GtkMenu built
for the context menu proxy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Added missing WebPageProxy::ViewIsFocused flag to WebPageProxy::viewStateD...
commit-queue@webkit.org [Tue, 3 Jul 2012 15:40:02 +0000 (15:40 +0000)]
[EFL][WK2] Added missing WebPageProxy::ViewIsFocused flag to WebPageProxy::viewStateDidChange()
call in _ewk_view_smart_focus_out() function.
https://bugs.webkit.org/show_bug.cgi?id=89877

Patch by Piotr Roguski <p.roguski@samsung.com> on 2012-07-03
Reviewed by Andreas Kling.

Although name of the flag suggest it should be used only on focus in,
omitting it in case of focus out will prevent WebPageProxy::viewStateDidChange()
from sending Messages::WebPage::SetFocused(false).

* UIProcess/API/efl/ewk_view.cpp:
(_ewk_view_smart_focus_out):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] API tests randomly asserts in QQuickWebPage::setContentsScale(qreal)
ostapenko.viatcheslav@nokia.com [Tue, 3 Jul 2012 15:34:54 +0000 (15:34 +0000)]
[Qt][WK2] API tests randomly asserts in QQuickWebPage::setContentsScale(qreal)
https://bugs.webkit.org/show_bug.cgi?id=88679

Reviewed by Csaba Osztrogonác.

Viewport parameters cannot be calculated while viewport is not visible and
viewport size is 0, so let's delay calculation of viewport parameters until view
becomes visible.

* UIProcess/qt/QtViewportHandler.cpp:
(WebKit::QtViewportHandler::pageContentsSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add run API tests as a step on the build bots
commit-queue@webkit.org [Tue, 3 Jul 2012 15:28:09 +0000 (15:28 +0000)]
[EFL] Add run API tests as a step on the build bots
https://bugs.webkit.org/show_bug.cgi?id=87252

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-03
Reviewed by Daniel Bates.

Run EFL API test suite on the build bots.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunEflAPITests):
(TestFactory.__init__):
(BuildAndTestFactory.__init__):
* Scripts/run-efl-tests: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Forward message loop instrumentation data to frontend.
caseq@chromium.org [Tue, 3 Jul 2012 15:27:06 +0000 (15:27 +0000)]
Web Inspector: Forward message loop instrumentation data to frontend.
https://bugs.webkit.org/show_bug.cgi?id=89584

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-07-03
Reviewed by Yury Semikhatsky.

Transmit collected message loop tasks to inspector frontend.
Now "Program" should be a top-level event on browsers that
support message loop instrumentation.
Frontend was changed so that user will not see any changes.

Source/WebCore:

* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
Added new event type - "Program"
(WebCore::InspectorTimelineAgent::willProcessTask):
Begin "Program" event.
(WebCore::InspectorTimelineAgent::didProcessTask):
Finish "Program" event.
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
Do not add counters to "Program" events.
(WebCore):
(WebCore::InspectorTimelineAgent::innerSetHeapSizeStatistic):
Renamed from "setHeapSizeStatistic"
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onRecordAdded):
Unwraps "Program" events.
(WebInspector.MemoryStatistics.prototype._innerRecordAdded):
Renamed from "_onRecordAdded"
* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
Unwraps "Program" events.
(WebInspector.TimelineFrameController.prototype._innerAddRecord):
Renamed from "_addRecord"
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord):
Filter out "Program" category.
(WebInspector.TimelineCategoryStrips.prototype.update):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
Filter out "Program" category.
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
Unwraps "Program" events.
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
Added "Program" category.
(WebInspector.TimelinePresentationModel.recordStyle):
Ditto.
(WebInspector.TimelinePresentationModel.prototype.addRecord):
Unwraps "Program" events.
(WebInspector.TimelinePresentationModel.prototype._addRecord):
Renamed from "addRecord"

LayoutTests:

* inspector/timeline/timeline-enum-stability-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Make use of .qmake.cache for caching features
vestbo@webkit.org [Tue, 3 Jul 2012 15:23:20 +0000 (15:23 +0000)]
[Qt] Make use of .qmake.cache for caching features

Instead of loading() features from the files that need them (and re-running
a bunch of checks), we now run feature detection as part of configure.pro,
and have build-webkit write the computed feature-defines and CONFIG to
.qmake.cache, which is then loaded by qmake _before_ even defaults_pre
when building WebKit.pro.

At some point we'll be able to selectivly prevent running of config tests
in configure.pro, which means we don't need a separate code-path for
the build-webkit --help case.

We should also move the code in build-webkit that now uses .webkit.config
to detect clean builds, to use .qmake.cache, since we now store the same
thing there.

Original patch by Oswald Buddenhagen <oswald.buddenhagen@nokia.com>

https://bugs.webkit.org/show_bug.cgi?id=90461

Reviewed by Tor Arne Vestbø.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinspector/debugger/script-snippet-model.html fails
vsevik@chromium.org [Tue, 3 Jul 2012 15:00:09 +0000 (15:00 +0000)]
inspector/debugger/script-snippet-model.html fails
https://bugs.webkit.org/show_bug.cgi?id=90385

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/ScriptSnippetModel.js:

LayoutTests:

* inspector/debugger/script-snippet-model-expected.txt:
* platform/chromium/inspector/debugger/script-snippet-model-expected.txt: Copied from LayoutTests/inspector/debugger/script-snippet-model-expected.txt.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[REGRESSION] Crash when copying a StyleRuleMedia with a NULL m_mediaQueries
apavlov@chromium.org [Tue, 3 Jul 2012 14:44:19 +0000 (14:44 +0000)]
[REGRESSION] Crash when copying a StyleRuleMedia with a NULL m_mediaQueries
https://bugs.webkit.org/show_bug.cgi?id=90459

Reviewed by Andreas Kling.

Source/WebCore:

Create StyleRuleMedia with a non-NULL MediaQuerySet. The respective NULL checks for it were all over the code,
except the copy constructor. Added the check, just in case.

* css/CSSParser.cpp:
(WebCore::CSSParser::createMediaRule):
* css/StyleRule.cpp:
(WebCore::StyleRuleMedia::StyleRuleMedia):

LayoutTests:

* inspector/styles/get-set-stylesheet-text-expected.txt:
* inspector/styles/resources/get-set-stylesheet-text.css:
(@media):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: display time intervals measured with console.time() and console.timeEn...
caseq@chromium.org [Tue, 3 Jul 2012 13:47:40 +0000 (13:47 +0000)]
Web Inspector: display time intervals measured with console.time() and console.timeEnd() in Timeline
https://bugs.webkit.org/show_bug.cgi?id=90442

Reviewed by Pavel Feldman.

Source/WebCore:

- added Time and TimeEnd record types produced by console.time() and console.timeEnd()
- connect Time to TimeEnd in "glue" mode to better visualize the interval;
- always make Time a top-level record;

* English.lproj/localizedStrings.js:
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::startConsoleTimingImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore::InspectorTimelineAgent::didStartTiming):
(WebCore):
(WebCore::InspectorTimelineAgent::didStopTiming):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelinePresentationModel.categoryForRecord):
(WebInspector.TimelinePresentationModel.prototype.reset):
(WebInspector.TimelinePresentationModel.prototype.addRecord):
(WebInspector.TimelinePresentationModel.prototype._findParentRecord):
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype.generatePopupContent):

LayoutTests:

- added Time & TimeEnd;

* inspector/timeline/timeline-enum-stability-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][Win] Fix broken QtWebKit5.lib linking
commit-queue@webkit.org [Tue, 3 Jul 2012 13:43:13 +0000 (13:43 +0000)]
[Qt][Win] Fix broken QtWebKit5.lib linking
https://bugs.webkit.org/show_bug.cgi?id=88321

Patch by Jocelyn Turcotte  <jocelyn.turcotte@nokia.com>  Joel Dillon <joel.dillon@codethink.co.uk> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.

Source/JavaScriptCore:

The goal is to have different ports build systems define STATICALLY_LINKED_WITH_WTF
when building JavaScriptCore, if both are packaged in the same DLL, instead
of relying on the code to handle this.
The effects of BUILDING_* and STATICALLY_LINKED_WITH_* are currently the same
except for a check in Source/JavaScriptCore/config.h.

Keeping the old way for the WX port as requested by the port's contributors.
For non-Windows ports there is no difference between IMPORT and EXPORT, no
change is needed.

* API/JSBase.h:
  JS symbols shouldn't be included by WTF objects anymore. Remove the export when BUILDING_WTF.
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreCommon.vsprops:
  Make sure that JavaScriptCore uses import symbols of WTF for the Win port.
* runtime/JSExportMacros.h:

Source/WebCore:

* platform/PlatformExportMacros.h:

Source/WTF:

Instead of letting a module's headers know which other modules depend on them,
have depending modules define explicitely that they want its symbols exported too.

JavaScriptCore should then be compiled with both BUILDING_JavaScriptCore and
STATICALLY_LINKED_WITH_WTF.

* wtf/ExportMacros.h:

Tools:

On windows the import/export definition is part of the symbol's signature.
Define STATICALLY_LINKED_WITH_$$library for each dependend module
that is being linked statically to make sure that they can be linked together
later on.

Also do not compile Assertions.cpp in DumpRenderTree anymore since all the
used symbols are exported and it would cause a duplicate symbols error.

* DumpRenderTree/qt/DumpRenderTree.pro:
* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] When calling accept() on the FilePickerContextObject with an empty list, early...
alexis.menard@openbossa.org [Tue, 3 Jul 2012 13:32:29 +0000 (13:32 +0000)]
[Qt] When calling accept() on the FilePickerContextObject with an empty list, early return and call reject().
https://bugs.webkit.org/show_bug.cgi?id=89755

Reviewed by Simon Hausmann.

When calling accept with an empty list of files we can just bailout
and call reject(). Any other processing is pointless.

       * UIProcess/API/qt/tests/qmltests/WebView/tst_singleFileUpload.qml:
       * UIProcess/qt/QtDialogRunner.cpp:
(WebKit::FilePickerContextObject::accept):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agomaster.cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
ossy@webkit.org [Tue, 3 Jul 2012 13:00:46 +0000 (13:00 +0000)]
cfg cleanup, pass BuildStep instances instead of BuildStep subclasses
https://bugs.webkit.org/show_bug.cgi?id=89001

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-03
Reviewed by Csaba Osztrogonác.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(UploadBuiltProduct.__init__):
(UploadTestResults.__init__):
(ExtractTestResults.__init__):
(Factory.__init__):
(BuildFactory.__init__):
(TestFactory.__init__):
(BuildAndTestFactory.__init__):
(BuildAndPerfTestFactory.__init__):
(BuildAndPerfTestWebKit2Factory.__init__):
(DownloadAndPerfTestFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate unit test after r121724.
commit-queue@webkit.org [Tue, 3 Jul 2012 12:38:20 +0000 (12:38 +0000)]
Update unit test after r121724.
https://bugs.webkit.org/show_bug.cgi?id=90444

Patch by Ádám Kallai <kadam@inf.u-szeged.hu> on 2012-07-03
Reviewed by Csaba Osztrogonác.

* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline_new_port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add new baselines after r121697, r121722 and r121728
commit-queue@webkit.org [Tue, 3 Jul 2012 12:37:50 +0000 (12:37 +0000)]
[EFL] Add new baselines after r121697, r121722 and r121728
https://bugs.webkit.org/show_bug.cgi?id=90446

Unreviewed gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-03

* platform/efl/fast/dom/Element/getBoundingClientRect-expected.txt:
* platform/efl/fast/multicol/column-break-with-balancing-expected.png:
* platform/efl/fast/multicol/column-break-with-balancing-expected.txt: Added.
* platform/efl/fast/multicol/column-rules-expected.png:
* platform/efl/fast/multicol/column-rules-expected.txt: Added.
* platform/efl/fast/multicol/column-rules-stacking-expected.txt: Added.
* platform/efl/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
* platform/efl/fast/multicol/nested-columns-expected.png:
* platform/efl/fast/multicol/nested-columns-expected.txt: Added.
* platform/efl/fast/multicol/shadow-breaking-expected.png:
* platform/efl/fast/multicol/shadow-breaking-expected.txt:
* platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.png:
* platform/efl/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
* platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.png:
* platform/efl/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt:
* platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.png:
* platform/efl/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.png:
* platform/efl/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
* platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.png:
* platform/efl/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
* platform/efl/fast/multicol/span/span-margin-collapsing-expected.png:
* platform/efl/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
* platform/efl/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
* platform/efl/fast/multicol/vertical-lr/column-rules-expected.png:
* platform/efl/fast/multicol/vertical-lr/column-rules-expected.txt:
* platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/efl/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/efl/fast/multicol/vertical-lr/nested-columns-expected.png:
* platform/efl/fast/multicol/vertical-lr/nested-columns-expected.txt: Copied from LayoutTests/platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt.
* platform/efl/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
* platform/efl/fast/multicol/vertical-rl/column-rules-expected.png:
* platform/efl/fast/multicol/vertical-rl/column-rules-expected.txt:
* platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/efl/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/efl/fast/multicol/vertical-rl/nested-columns-expected.png:
* platform/efl/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/efl/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, updating one baseline modified in r121745
zandobersek@gmail.com [Tue, 3 Jul 2012 11:40:29 +0000 (11:40 +0000)]
Unreviewed GTK gardening, updating one baseline modified in r121745
to more suitable content.

* platform/gtk/fast/multicol/nested-columns-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix text positioning with non-bmp characters.
pdr@google.com [Tue, 3 Jul 2012 10:29:08 +0000 (10:29 +0000)]
Fix text positioning with non-bmp characters.
https://bugs.webkit.org/show_bug.cgi?id=87681

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Previously when constructing metrics for tspans with non-bmp characters,
each non-bmp character treated as a skipped character in the same way that
spaces are ignored.
This made sense because the initial SVGCharacterDataMap for <text> is
indexed by character index (not string length) so the high portion of a
non-bmp character was treated as a skipped space. Unfortunately, this
led to a bug because skipped spaces lead to an offset in the positioning
values list but non-bmp characters do not.

This change switches the code to use a new offset for non-bmp characters,
surrogatePairCharacters, which does not affect the positioning values list.

Tests: svg/text/non-bmp-tspans-expected.svg
       svg/text/non-bmp-tspans.svg

* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):

LayoutTests:

* svg/text/non-bmp-tspans-expected.svg: Added.
* svg/text/non-bmp-tspans.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
commit-queue@webkit.org [Tue, 3 Jul 2012 10:25:36 +0000 (10:25 +0000)]
[CSS Regions] Enabling regions on Windows lead to crash-on-launch for WebKit.exe
https://bugs.webkit.org/show_bug.cgi?id=90435

Patch by Mihai Balan <mibalan@adobe.com> on 2012-07-03
Reviewed by Csaba Osztrogonác.

Initial patch for enabling regions led to WebKit crashing on launch. Moving the
IDL declarations for CSS regions getter/setter at the end of the file solves the
problem. As per http://trac.webkit.org/changeset/95650 seems it has to do with
binary compatibility.

* Interfaces/IWebPreferences.idl: Mover getter/setter for CSS regions at the end of file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove test cases for network information APIs
gyuyoung.kim@samsung.com [Tue, 3 Jul 2012 10:12:47 +0000 (10:12 +0000)]
Improve test cases for network information APIs
https://bugs.webkit.org/show_bug.cgi?id=90162

Reviewed by Adam Barth.

Existing implementation doesn't test port implementation in network info APIs.
This patch lets test cases use bandwidth and metered functions implemented by port layer.

In addition, expected results need to check return type instead of property name.

Source/WebCore:

No new tests. Covered by existing tests.

* Modules/networkinfo/NetworkInfoConnection.cpp:
(WebCore::NetworkInfoConnection::bandwidth):
(WebCore::NetworkInfoConnection::metered):

LayoutTests:

* networkinformation/add-listener-from-callback-expected.txt:
* networkinformation/basic-all-types-of-events-expected.txt:
* networkinformation/basic-operation-expected.txt:
* networkinformation/multiple-frames-expected.txt:
* networkinformation/script-tests/add-listener-from-callback.js:
(checkNetworkInformation):
* networkinformation/script-tests/basic-all-types-of-events.js:
(checkNetworkInformation):
* networkinformation/script-tests/basic-operation.js:
* networkinformation/script-tests/multiple-frames.js:
(checkNetworkInformation):
(checkChildNetworkInformation):
* networkinformation/script-tests/updates.js:
(checkNetworkInformation):
* networkinformation/updates-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r121749.
commit-queue@webkit.org [Tue, 3 Jul 2012 10:07:56 +0000 (10:07 +0000)]
Unreviewed, rolling out r121749.
http://trac.webkit.org/changeset/121749
https://bugs.webkit.org/show_bug.cgi?id=90441

Tests crash on the paralel NRWT Qt bot (Requested by Ossy on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-03

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._build_driver):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [WK2] Don't call eina_iterator_free() if iterator is NULL
commit-queue@webkit.org [Tue, 3 Jul 2012 10:04:12 +0000 (10:04 +0000)]
[EFL] [WK2] Don't call eina_iterator_free() if iterator is NULL
https://bugs.webkit.org/show_bug.cgi?id=90076

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.

Add a null check to prevent calling eina_iterator_free() when
iterator is NULL.

No new tests. This patch doesn't change behavior.

* platform/efl/FileSystemEfl.cpp:
(WebCore::listDirectory): Early return when iterator is NULL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Elements] Text formatting is not retained when editing <script> or...
apavlov@chromium.org [Tue, 3 Jul 2012 09:49:46 +0000 (09:49 +0000)]
Web Inspector: [Elements] Text formatting is not retained when editing <script> or <style> contents as text
https://bugs.webkit.org/show_bug.cgi?id=90440

Reviewed by Vsevolod Vlasov.

* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeElement.prototype._startEditingTextNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Save scroll selection and cursor position of SourceFrames in sources...
vsevik@chromium.org [Tue, 3 Jul 2012 09:28:41 +0000 (09:28 +0000)]
Web Inspector: Save scroll selection and cursor position of SourceFrames in sources panel.
https://bugs.webkit.org/show_bug.cgi?id=90294

Reviewed by Yury Semikhatsky.

Source/WebCore:

Scroll and selection change handling is now delegated from TextViewer to SourceFrame.
SourceFrame now dispatches ScrollChanged and SelectionChanged events.
TabbedEditorContainer now saves scroll and selection information together
with the url history and restores scroll and selection on resource opening.

* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._innerHighlightLineIfNeeded):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype._innerRevealLineIfNeeded):
(WebInspector.SourceFrame.prototype._clearLineToReveal):
(WebInspector.SourceFrame.prototype.scrollToLine):
(WebInspector.SourceFrame.prototype._innerScrollToLineIfNeeded):
(WebInspector.SourceFrame.prototype._clearLineToScrollTo):
(WebInspector.SourceFrame.prototype.setSelection):
(WebInspector.SourceFrame.prototype._innerSetSelectionIfNeeded):
(WebInspector.SourceFrame.prototype._wasShownOrLoaded):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.commitEditing):
(WebInspector.SourceFrame.prototype.selectionChanged):
(WebInspector.SourceFrame.prototype.scrollChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.selectionChanged):
(WebInspector.TextViewerDelegateForSourceFrame.prototype.scrollChanged):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer):
(WebInspector.TabbedEditorContainer.prototype._addScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._removeScrollAndSelectionListeners):
(WebInspector.TabbedEditorContainer.prototype._scrollChanged):
(WebInspector.TabbedEditorContainer.prototype._selectionChanged):
(WebInspector.TabbedEditorContainer.prototype._appendFileTab):
(WebInspector.TabbedEditorContainer.prototype._tabClosed):
(WebInspector.TabbedEditorContainer.HistoryItem):
(WebInspector.TabbedEditorContainer.HistoryItem.fromObject):
(WebInspector.TabbedEditorContainer.HistoryItem.prototype.serializeToObject):
(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.fromObject):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype.selectionRange):
(WebInspector.TabbedEditorContainer.History.prototype.updateSelectionRange):
(WebInspector.TabbedEditorContainer.History.prototype.scrollLineNumber):
(WebInspector.TabbedEditorContainer.History.prototype.updateScrollLineNumber):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):
(WebInspector.TabbedEditorContainer.History.prototype.save):
(WebInspector.TabbedEditorContainer.History.prototype.set _serializeToObject):
* inspector/front-end/TextEditorModel.js:
(WebInspector.TextRange.fromObject):
(WebInspector.TextRange.prototype.clone):
(WebInspector.TextRange.prototype.serializeToObject):
* inspector/front-end/TextViewer.js:
(WebInspector.TextViewer.prototype._handleScrollChanged):
(WebInspector.TextViewer.prototype.scrollToLine):
(WebInspector.TextViewer.prototype._handleSelectionChange):
(WebInspector.TextViewer.prototype.setSelection):
(WebInspector.TextViewer.prototype.wasShown):
(WebInspector.TextViewer.prototype._handleFocused):
(WebInspector.TextViewer.prototype.willHide):
(WebInspector.TextViewerDelegate.prototype.selectionChanged):
(WebInspector.TextViewerDelegate.prototype.scrollChanged):
(WebInspector.TextEditorChunkedPanel.prototype.scrollToLine):

LayoutTests:

* inspector/tabbed-editors-history-expected.txt:
* inspector/tabbed-editors-history.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[NRWT] XvfbDriver should choose the next free display
kkristof@inf.u-szeged.hu [Tue, 3 Jul 2012 09:26:19 +0000 (09:26 +0000)]
[NRWT] XvfbDriver should choose the next free display
https://bugs.webkit.org/show_bug.cgi?id=88414

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py:
(XvfbDriver.__init__):
(XvfbDriver._start):
(XvfbDriver._start.next_free_id):
(XvfbDriver.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Make DirectoryContentView sortable
commit-queue@webkit.org [Tue, 3 Jul 2012 09:17:23 +0000 (09:17 +0000)]
Web Inspector: Make DirectoryContentView sortable
https://bugs.webkit.org/show_bug.cgi?id=90361

Patch by Taiju Tsuiki <tzik@chromium.org> on 2012-07-03
Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/Inspector.json:
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
* inspector/front-end/DirectoryContentView.js:
(WebInspector.DirectoryContentView):
(WebInspector.DirectoryContentView.prototype.showEntries):
(WebInspector.DirectoryContentView.prototype._sort):
(WebInspector.DirectoryContentView.Node.comparator.isDirectoryCompare):
(WebInspector.DirectoryContentView.Node.comparator.nameCompare):
(WebInspector.DirectoryContentView.Node.comparator.typeCompare):
(WebInspector.DirectoryContentView.Node.comparator.sizeCompare):
(WebInspector.DirectoryContentView.Node.comparator):
(WebInspector.DirectoryContentView.Node.prototype._metadataReceived):

LayoutTests:

* http/tests/inspector/filesystem/get-metadata-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline: fast/box-sizing/box-sizing.html
yosin@chromium.org [Tue, 3 Jul 2012 08:58:49 +0000 (08:58 +0000)]
[Chromium] Rebaseline: fast/box-sizing/box-sizing.html

* platform/chromium-mac-snowleopard/fast/box-sizing/box-sizing-expected.txt: Copied from LayoutTests/platform/chromium-mac/fast/box-sizing/box-sizing-expected.txt.
* platform/chromium-mac/fast/box-sizing/box-sizing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: WebInspector.TextViewer should be renamed WebInspector.TextEditor
vsevik@chromium.org [Tue, 3 Jul 2012 08:45:08 +0000 (08:45 +0000)]
Web Inspector: WebInspector.TextViewer should be renamed WebInspector.TextEditor
https://bugs.webkit.org/show_bug.cgi?id=89939

Patch by Jan Keromnes <janx@linux.com> on 2012-07-03
Reviewed by Vsevolod Vlasov.

PerformanceTests:

* inspector/first-open-scripts.html.broken:

Source/WebCore:

Fixed LayoutTests and PerformanceTests accordingly.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/AdvancedSearchController.js:
(WebInspector.SearchView):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame):
(WebInspector.JavaScriptSourceFrame.prototype._onHidePopover):
(WebInspector.JavaScriptSourceFrame.prototype._addBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._removeBreakpointDecoration):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition.finishEditing):
(WebInspector.JavaScriptSourceFrame.prototype._editBreakpointCondition):
(WebInspector.JavaScriptSourceFrame.prototype.setExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.clearExecutionLine):
(WebInspector.JavaScriptSourceFrame.prototype.onTextEditorContentLoaded):
(WebInspector.JavaScriptSourceFrame.prototype.toggleBreakpointOnCurrentLine):
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.wasShown):
(WebInspector.SourceFrame.prototype.willHide):
(WebInspector.SourceFrame.prototype.defaultFocusedElement):
(WebInspector.SourceFrame.prototype.get textEditor):
(WebInspector.SourceFrame.prototype.clearMessages):
(WebInspector.SourceFrame.prototype.highlightLine):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype.revealLine):
(WebInspector.SourceFrame.prototype.setSelection):
(WebInspector.SourceFrame.prototype.setContent):
(WebInspector.SourceFrame.prototype.onTextEditorContentLoaded):
(WebInspector.SourceFrame.prototype._setTextEditorDecorations):
(WebInspector.SourceFrame.prototype.searchCanceled):
(WebInspector.SourceFrame.prototype.jumpToSearchResult):
(WebInspector.SourceFrame.prototype.addMessageToSource):
(WebInspector.SourceFrame.prototype.removeMessageFromSource):
(WebInspector.SourceFrame.prototype.inheritScrollPositions):
(WebInspector.TextEditorDelegateForSourceFrame):
* inspector/front-end/TextViewer.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
* inspector/front-end/textViewer.css: Removed.

Source/WebKit/blackberry:

* WebCoreSupport/inspectorBB.html:

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* http/tests/inspector/live-edit-test.js:
(initialize_LiveEditTest.InspectorTest.replaceInSource):
(initialize_LiveEditTest):
* http/tests/inspector/resources-test.js:
(initialize_ResourceTest.InspectorTest.showResource.showResourceCallback):
(initialize_ResourceTest.InspectorTest.showResource):
* inspector/debugger/pause-in-inline-script.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, updating baselines after r121697 and r121728
zandobersek@gmail.com [Tue, 3 Jul 2012 08:37:25 +0000 (08:37 +0000)]
Unreviewed GTK gardening, updating baselines after r121697 and r121728
and adding text and pixel baselines required after r121722.

* platform/gtk/fast/dom/Element/getBoundingClientRect-expected.txt:
* platform/gtk/fast/multicol/column-break-with-balancing-expected.txt: Added.
* platform/gtk/fast/multicol/column-rules-expected.txt: Added.
* platform/gtk/fast/multicol/column-rules-stacking-expected.txt: Added.
* platform/gtk/fast/multicol/columns-shorthand-parsing-expected.txt: Added.
* platform/gtk/fast/multicol/nested-columns-expected.txt: Added.
* platform/gtk/fast/multicol/shadow-breaking-expected.txt:
* platform/gtk/fast/multicol/span/anonymous-split-block-crash-expected.txt: Added.
* platform/gtk/fast/multicol/span/clone-anonymous-block-non-inline-child-crash-expected.txt: Added.
* platform/gtk/fast/multicol/span/generated-child-split-flow-crash-expected.txt:
* platform/gtk/fast/multicol/span/span-as-immediate-child-complex-splitting-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-immediate-columns-child-dynamic-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-immediate-columns-child-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-nested-columns-child-dynamic-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-as-nested-columns-child-expected.txt: Added.
* platform/gtk/fast/multicol/span/span-margin-collapsing-expected.txt: Added.
* platform/gtk/fast/multicol/vertical-lr/column-break-with-balancing-expected.txt: Added.
* platform/gtk/fast/multicol/vertical-lr/column-rules-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/vertical-lr/nested-columns-expected.txt: Added.
* platform/gtk/fast/multicol/vertical-rl/column-break-with-balancing-expected.txt: Added.
* platform/gtk/fast/multicol/vertical-rl/column-rules-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/float-avoidance-expected.txt:
* platform/gtk/fast/multicol/vertical-rl/nested-columns-expected.txt:
* platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/gtk/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Update text expectation for timeline-receive-response-event.html
yosin@chromium.org [Tue, 3 Jul 2012 08:31:39 +0000 (08:31 +0000)]
[Chromium] Update text expectation for timeline-receive-response-event.html

* platform/chromium/TestExpectations: Add "TEXT"

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
jochen@chromium.org [Tue, 3 Jul 2012 08:28:46 +0000 (08:28 +0000)]
[chromium] Unreviewed gardening.

platform/chromium/permissionclient/storage-permission.html consistently
passes

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: should make the LevelDB persistant to the directory indicated in PageGroup...
charles.wei@torchmobile.com.cn [Tue, 3 Jul 2012 08:28:44 +0000 (08:28 +0000)]
IndexedDB: should make the LevelDB persistant to the directory indicated in PageGroupSettings::indexedDBDataBasePath
https://bugs.webkit.org/show_bug.cgi?id=88338

Reviewed by David Levin.

Source/WebCore:

If the indexedDB runs in main thread it can access the GroupSettings via the document;
otherwise, we need to pass the page GroupSettings to the worker thread so that accessible
to the indexedDB running in WorkerContext.

* Modules/indexeddb/IDBFactory.cpp:
(WebCore::IDBFactory::open):
* workers/DedicatedWorkerThread.cpp:
(WebCore::DedicatedWorkerThread::create):
(WebCore::DedicatedWorkerThread::DedicatedWorkerThread):
* workers/DedicatedWorkerThread.h:
(DedicatedWorkerThread):
* workers/DefaultSharedWorkerRepository.cpp:
(SharedWorkerProxy):
(WebCore::SharedWorkerProxy::groupSettings):
(WebCore):
(WebCore::DefaultSharedWorkerRepository::workerScriptLoaded):
* workers/SharedWorkerThread.cpp:
(WebCore::SharedWorkerThread::create):
(WebCore::SharedWorkerThread::SharedWorkerThread):
* workers/SharedWorkerThread.h:
(SharedWorkerThread):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):
* workers/WorkerThread.cpp:
(WebCore::WorkerThreadStartupData::create):
(WorkerThreadStartupData):
(WebCore::WorkerThreadStartupData::WorkerThreadStartupData):
(WebCore::WorkerThread::WorkerThread):
(WebCore::WorkerThread::groupSettings):
(WebCore):
* workers/WorkerThread.h:
(WorkerThread):

Source/WebKit/chromium:

* src/WebSharedWorkerImpl.cpp:
(WebKit::WebSharedWorkerImpl::startWorkerContext):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening after r121728. Updated expectations to
kkristof@inf.u-szeged.hu [Tue, 3 Jul 2012 08:24:58 +0000 (08:24 +0000)]
[Qt] Unreviewed gardening after r121728. Updated expectations to
fast/multicol/span/span-as-immediate-child-generated-content.html.

Patch by Szilard Ledan <szledan@inf.u-szeged.hu> on 2012-07-03

* platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.png:
* platform/qt/fast/multicol/span/span-as-immediate-child-generated-content-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] fast/viewport/viewport-91.html still fails after r121555 and r121661
kbalazs@webkit.org [Tue, 3 Jul 2012 08:22:34 +0000 (08:22 +0000)]
[Qt][WK2] fast/viewport/viewport-91.html still fails after r121555 and r121661
https://bugs.webkit.org/show_bug.cgi?id=90376

Reviewed by Csaba Osztrogonác.

Source/WebCore:

No new tests, this is only a build alignment.

Export ViewportArguments::deprecatedTargetDPI since it is used in WebKit2.
* WebCore.exp.in:

Source/WebKit2:

layoutTestController.dumpConfigurationForViewport still need
to use the constant target DPI of 160.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewportConfigurationAsText):

LayoutTests:

Unskip passing test.
* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline for Mac10.6
yosin@chromium.org [Tue, 3 Jul 2012 08:20:09 +0000 (08:20 +0000)]
[Chromium] Rebaseline for Mac10.6

* platform/chromium-mac-snowleopard/fast/events/offsetX-offsetY-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Tests still crashing for Linux Release as well.
commit-queue@webkit.org [Tue, 3 Jul 2012 08:17:42 +0000 (08:17 +0000)]
[Chromium] Tests still crashing for Linux Release as well.
https://bugs.webkit.org/show_bug.cgi?id=89979

Patch by Michael Starzinger <mstarzinger@chromium.org> on 2012-07-03
Reviewed by Tony Chang.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline: Add missing expectation files introduced by r121722
yosin@chromium.org [Tue, 3 Jul 2012 08:10:15 +0000 (08:10 +0000)]
[Chromium] Rebaseline: Add missing expectation files introduced by r121722

* platform/chromium-mac-snowleopard/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
* platform/chromium-mac/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/chromium-mac/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
* platform/chromium-win-xp/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/chromium-win-xp/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.
* platform/chromium-win/fast/repaint/repaint-during-scroll-with-zoom-expected.png: Added.
* platform/chromium-win/fast/repaint/repaint-during-scroll-with-zoom-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed Gardening after r121697. Updated expected files.
kkristof@inf.u-szeged.hu [Tue, 3 Jul 2012 07:49:01 +0000 (07:49 +0000)]
[Qt] Unreviewed Gardening after r121697. Updated expected files.

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-03

* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/qt/fast/multicol/vertical-rl/float-avoidance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCalculate client positions from offsets.
hbono@chromium.org [Tue, 3 Jul 2012 07:06:06 +0000 (07:06 +0000)]
Calculate client positions from offsets.
https://bugs.webkit.org/show_bug.cgi?id=73640

Reviewed by Tony Chang.

This change calculates client positions from offset positions at run time to
remove platform-dependent constants from this test.

* fast/events/offsetX-offsetY-expected.txt:
* fast/events/offsetX-offsetY.html:
* platform/chromium-win/fast/events/offsetX-offsetY-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable MICRODATA support
commit-queue@webkit.org [Tue, 3 Jul 2012 07:01:58 +0000 (07:01 +0000)]
[EFL] Enable MICRODATA support
https://bugs.webkit.org/show_bug.cgi?id=90377

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.

.:

Turn on MICRODATA support by default for EFL port.

* Source/cmake/OptionsEfl.cmake:

Tools:

Turn on MICRODATA flag for EFL port by default.

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Unskip microdata test cases now that support has been
enabled for EFL port.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add API to deliver a Web Intent to a frame
commit-queue@webkit.org [Tue, 3 Jul 2012 06:54:42 +0000 (06:54 +0000)]
[EFL][WK2] Add API to deliver a Web Intent to a frame
https://bugs.webkit.org/show_bug.cgi?id=90067

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.

Add ewk_view_intent_deliver() method on the Ewk_View
to deliver a Web Intent to the view's main frame.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_deliver):
* UIProcess/API/efl/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add API to inspect a Web Intent service
commit-queue@webkit.org [Tue, 3 Jul 2012 06:27:10 +0000 (06:27 +0000)]
[EFL][WK2] Add API to inspect a Web Intent service
https://bugs.webkit.org/show_bug.cgi?id=90066

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-02
Reviewed by Kenneth Rohde Christiansen.

Add EFL API to inspect a Web Intent Service and emit
a signal on the view when a new intent service
registers.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_intent_service.cpp: Added.
(_Ewk_Intent_Service):
(ewk_intent_service_ref):
(ewk_intent_service_unref):
(ewk_intent_service_action_get):
(ewk_intent_service_type_get):
(ewk_intent_service_href_get):
(ewk_intent_service_title_get):
(ewk_intent_service_disposition_get):
(ewk_intent_service_new):
* UIProcess/API/efl/ewk_intent_service.h: Added.
* UIProcess/API/efl/ewk_intent_service_private.h: Copied from Source/WebKit2/UIProcess/API/efl/ewk_view_loader_client.cpp.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_intent_service_register):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(registerIntentServiceForFrame):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_private.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Free Ewk_Intent calloc'd memory with free() instead of delete
commit-queue@webkit.org [Tue, 3 Jul 2012 06:24:19 +0000 (06:24 +0000)]
[WK2][EFL] Free Ewk_Intent calloc'd memory with free() instead of delete
https://bugs.webkit.org/show_bug.cgi?id=90433

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-02
Reviewed by Kenneth Rohde Christiansen.

Free calloc'd memory with free() instead of delete in Ewk_Intent.
Add blank lines before return statements for consistency.

* UIProcess/API/efl/ewk_intent.cpp:
(ewk_intent_unref):
(ewk_intent_action_get):
(ewk_intent_type_get):
(ewk_intent_service_get):
(ewk_intent_suggestions_get):
(ewk_intent_extra_get):
(ewk_intent_extra_names_get):
(ewk_intent_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test inspector/timeline/timeline-receive-response-event.html is failing
yosin@chromium.org [Tue, 3 Jul 2012 04:42:46 +0000 (04:42 +0000)]
Layout Test inspector/timeline/timeline-receive-response-event.html is failing
https://bugs.webkit.org/show_bug.cgi?id=90430

Unreviewd build fix

* platform/chromium/TestExpectations: Mark timeline-receive-response-event.html flaky

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TextureMapper] The TextureMapper should support edge-distance anti-antialiasing
commit-queue@webkit.org [Tue, 3 Jul 2012 04:25:35 +0000 (04:25 +0000)]
[TextureMapper] The TextureMapper should support edge-distance anti-antialiasing
https://bugs.webkit.org/show_bug.cgi?id=90308

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-07-02
Reviewed by Noam Rosenthal.

Source/WebCore:

Add an edge-distance anti-aliasing implementation for the TextureMapper. Currently
this implementation is not active for tiled layers. This implementation is based
on the one in the Chromium compositor originally written by David Raveman.

When a layer is transformed in a way that leaves its edge dimensions across pixel
boundaries, edge distance anti-aliasing will do a cheaper form of anti-aliasing
than full-scene anti-aliasing to make the transition from the layer pixel
to the background pixel smoother.

No new tests. This will be covered by pixel tests for Qt and GTK+ accelerated
compositing and 3D transforms, when those test harnesses are capable of
producing pixel output (in progress).

* platform/graphics/texmap/TextureMapper.h: Add an enum which is used to tell
the texture mapper what edges of a texture are exposed. This will be used for
properly dealing with tiled layers in the future.
* platform/graphics/texmap/TextureMapperBackingStore.cpp: Properly pass information
about exposed layer edges to the TextureMapper while painting.
* platform/graphics/texmap/TextureMapperBackingStore.h:
(TextureMapperTile): Modified arguments include exposed edges.
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawQuad): Renamed from drawRect, this method can now
draw quads that have non unit-rect texture coordinates. This is necessary because
the edge distance approach draws such quad.
(WebCore::TextureMapperGL::drawBorder): Call drawQuad now instead of drawRect.
(WebCore::TextureMapperGL::drawTexture): Pass the exposedEdges argument down.
(WebCore::TextureMapperGL::drawTextureRectangleARB): Call drawQuad now instead of
drawRect.
(WebCore::viewportMatrix): Added this helper which can calculate the viewport
transform based on the current OpenGL viewport settings.
(WebCore::scaleLineEquationCoeffecientsToOptimizeDistanceCalculation): Added this
helper which optimizes the fragment shader by precalculating some constant parts
of the distance calculation.
(WebCore::getStandardEquationCoeffecientsForLine): Given two end points of line segment
get the coeffecients of the line in the standard form of the line equation.
(WebCore::quadToEdgeArray): Converts a FloatQuad to an array of four sets of pre-scaled
line coefficients so that they can be passed to OpenGL.
(WebCore::scaledVectorDifference): Helper which helps expand a quad of arbitrary
orientation.
(WebCore::inflateQuad): Inflate a quad of arbitrary orientation. The transform may
flip it so we have to look at neighboring points to expand the quad.
(WebCore::TextureMapperGL::drawTextureWithAntialiasing): Activate the anti-aliasing
program and set up all uniforms.
(WebCore::TextureMapperGL::drawTexturedQuadWithProgram): Abstract out common operations
from drawTexture to be used with drawTextureWithAntialiasing.
* platform/graphics/texmap/TextureMapperGL.h:
(WebCore::TextureMapperGL::DrawQuad::DrawQuad): Add this small type which stores information
necessary to draw a quad -- it's original destination rect and the final size mapped to
texture coordinates.
(TextureMapperGL):
* platform/graphics/texmap/TextureMapperImageBuffer.cpp: Add the new exposedEdges argument.
* platform/graphics/texmap/TextureMapperImageBuffer.h: Ditto.
* platform/graphics/texmap/TextureMapperShaderManager.cpp: Add the new fragment shader for
doing edge-distance AA and a program which uses that shader.
* platform/graphics/texmap/TextureMapperShaderManager.h: Ditto.

Source/WebKit2:

* UIProcess/texmap/LayerBackingStore.cpp:
(WebKit::LayerBackingStore::paintToTextureMapper): Update the method to call paint with
the new argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoColumn height and count calculation ignores most overflow
mitz@apple.com [Tue, 3 Jul 2012 04:08:04 +0000 (04:08 +0000)]
Column height and count calculation ignores most overflow
https://bugs.webkit.org/show_bug.cgi?id=90392

Reviewed by Dean Jackson.

Source/WebCore:

Test: fast/multicol/overflow-content.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::relayoutForPagination): Changed to compute the overflow from children
and use the layout overflow height rather the content height.

LayoutTests:

* fast/multicol/overflow-content-expected.html: Added.
* fast/multicol/overflow-content.html: Added.
* fast/multicol/vertical-rl/rules-with-border-before-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Refactor : move the implementation of getMIMETypeForExtension and getPre...
commit-queue@webkit.org [Tue, 3 Jul 2012 03:43:19 +0000 (03:43 +0000)]
[BlackBerry] Refactor : move the implementation of getMIMETypeForExtension and getPreferredExtensionForMIMEType into BlackBerry platform
https://bugs.webkit.org/show_bug.cgi?id=90360

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-07-02
Reviewed by Antonio Gomes.

We should have one implementation for getMIMETypeForExtension
and getPreferredExtensionForMIMEType for both webkit and platform,
so I move this implementation to BlackBerry platform.

No new test cases , because no behavior changed.

* platform/blackberry/MIMETypeRegistryBlackBerry.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForExtension):
(WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Enable scoped style for BlackBerry.
staikos@webkit.org [Tue, 3 Jul 2012 03:40:34 +0000 (03:40 +0000)]
[BlackBerry] Enable scoped style for BlackBerry.
https://bugs.webkit.org/show_bug.cgi?id=90418

Reviewed by Rob Buis.

.:

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmakeconfig.h.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
commit-queue@webkit.org [Tue, 3 Jul 2012 03:38:29 +0000 (03:38 +0000)]
[BlackBerry] Use PUBLIC_BUILD to enable/disable DRT
https://bugs.webkit.org/show_bug.cgi?id=90271

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-07-02
Reviewed by George Staikos.

RIM PR #154707

Currently DRT code will be compiled only if ENABLE_DRT is set, and it's not
defined by default.
We should enable DRT by default unless PUBLIC_BUILD is set. In this way we don't
need to rebuild webkit before running DRT.

.:

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebKit:

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::~WebPagePrivate):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::authenticationChallenge):
(BlackBerry::WebKit::WebPage::runLayoutTests):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::addMessageToConsole):
(WebCore::ChromeClientBlackBerry::runJavaScriptAlert):
(WebCore::ChromeClientBlackBerry::runJavaScriptConfirm):
(WebCore::ChromeClientBlackBerry::runJavaScriptPrompt):
(WebCore::ChromeClientBlackBerry::createWindow):
(WebCore::ChromeClientBlackBerry::runBeforeUnloadConfirmPanel):
(WebCore::ChromeClientBlackBerry::setStatusbarText):
(WebCore::ChromeClientBlackBerry::exceededDatabaseQuota):
(WebCore::ChromeClientBlackBerry::keyboardUIMode):

Tools:

* Scripts/webkitdirs.pm:
(blackberryCMakeArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-patch rebaseline-expectations should share code with rebaseline-all
ojan@chromium.org [Tue, 3 Jul 2012 03:36:05 +0000 (03:36 +0000)]
webkit-patch rebaseline-expectations should share code with rebaseline-all
https://bugs.webkit.org/show_bug.cgi?id=90413

Reviewed by Dirk Pranke.

Make them share code. In addition to reducing code duplication this makes
rebaseline-expectations considerably faster by rebaselining in parallel.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand):
(AbstractParallelRebaselineCommand._run_webkit_patch):
(AbstractParallelRebaselineCommand._rebaseline):
(RebaselineJson):
(RebaselineJson.execute):
(RebaselineExpectations):
(RebaselineExpectations._update_expectations_file):
(RebaselineExpectations._tests_to_rebaseline):
(RebaselineExpectations._add_tests_to_rebaseline_for_port):
(RebaselineExpectations.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_all):
(test_rebaseline_expectations.run_in_parallel):
(test_rebaseline_expectations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Update DumpRenderTree to have it work interactively in parallel
commit-queue@webkit.org [Tue, 3 Jul 2012 03:23:43 +0000 (03:23 +0000)]
[BlackBerry] Update DumpRenderTree to have it work interactively in parallel
https://bugs.webkit.org/show_bug.cgi?id=88326

Patch by Xiaobo Wang <xbwang@torchmobile.com.cn> on 2012-07-02
Reviewed by Rob Buis.

1. Test name is sent to torch-launcher via PPS message(from host machine).
   So we get test list by monitoring and receiving PPS message instead of
   reading file index.drt.
2. Torch-launcher create a <test file>.done file when it finished a test.
3. We don't need to search for Ref-tests in DumpRenderTree.cpp any more. NRWT
   will get them for us.

* DumpRenderTree/blackberry/DumpRenderTree.cpp:
(BlackBerry::WebKit::DumpRenderTree::DumpRenderTree):
(BlackBerry::WebKit::DumpRenderTree::doneDrt):
(BlackBerry::WebKit::DumpRenderTree::runRemainingTests):
(BlackBerry::WebKit::DumpRenderTree::ensurePPS):
(WebKit):
(BlackBerry::WebKit::DumpRenderTree::handlePPSData):
(BlackBerry::WebKit::DumpRenderTree::waitForTest):
(BlackBerry::WebKit::DumpRenderTree::runTests):
(BlackBerry::WebKit::DumpRenderTree::dump):
* DumpRenderTree/blackberry/DumpRenderTreeBlackBerry.h:
(DumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPosition replaced elements on pixel bounds
eae@chromium.org [Tue, 3 Jul 2012 02:22:46 +0000 (02:22 +0000)]
Position replaced elements on pixel bounds
https://bugs.webkit.org/show_bug.cgi?id=90354

Reviewed by Eric Seidel.

To avoid sizing and repaint issues we should layout replaced elements on
pixel bounds. We already ensure that replaced elements are sized in full
pixels and that they are painted on pixel bounds. By also ensuring that
they are placed on pixel bounds we avoid pixel having the size be
expanded by pixel snapping and repainting/invalidation rect issues when
scrolling.

Test: fast/repaint/repaint-during-scroll-with-zoom.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Tue, 3 Jul 2012 02:19:01 +0000 (02:19 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-02

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix new -Wunused-private-field violations
thakis@chromium.org [Tue, 3 Jul 2012 02:04:00 +0000 (02:04 +0000)]
Fix new -Wunused-private-field violations
https://bugs.webkit.org/show_bug.cgi?id=90417

Reviewed by Ryosuke Niwa.

No intended behavior change.

* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
(WebCore::CCPrioritizedTextureManager::CCPrioritizedTextureManager):
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
(CCPrioritizedTextureManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Chromium
yosin@chromium.org [Tue, 3 Jul 2012 01:34:42 +0000 (01:34 +0000)]
Build fix for Chromium

Fix webkit-lint failure.

* platform/chromium/TestExpectations: Got rid of "SLOW" modifier from fast/overflow/lots-of-sibling-inline-boxes.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Implement cancelVibration, and make sure it's canceled on
staikos@webkit.org [Tue, 3 Jul 2012 01:28:57 +0000 (01:28 +0000)]
[BlackBerry] Implement cancelVibration, and make sure it's canceled on
destruction.
https://bugs.webkit.org/show_bug.cgi?id=90406

Reviewed by Rob Buis.

* WebCoreSupport/VibrationClientBlackBerry.cpp:
(WebCore::VibrationClientBlackBerry::cancelVibration):
(WebCore::VibrationClientBlackBerry::vibrationDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG OSR exit value recoveries should be computed lazily
fpizlo@apple.com [Tue, 3 Jul 2012 01:27:16 +0000 (01:27 +0000)]
DFG OSR exit value recoveries should be computed lazily
https://bugs.webkit.org/show_bug.cgi?id=82155

Reviewed by Gavin Barraclough.

This change aims to reduce one aspect of DFG compile times: the fact
that we currently compute the value recoveries for each local and
argument on every speculation check. We compile many speculation checks,
so this can add up quick. The strategy that this change takes is to
have the DFG save just enough information about how the compiler is
choosing to represent state, that the DFG::OSRExitCompiler can reify
the value recoveries lazily.

This appears to be an 0.3% SunSpider speed-up and is neutral elsewhere.

I also took the opportunity to fix the sampling regions profiler (it
was missing an export macro) and to put in more sampling regions in
the DFG (which are disabled so long as ENABLE(SAMPLING_REGIONS) is
false).

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/CodeBlock.cpp:
(JSC):
(JSC::CodeBlock::shrinkDFGDataToFit):
* bytecode/CodeBlock.h:
(CodeBlock):
(JSC::CodeBlock::minifiedDFG):
(JSC::CodeBlock::variableEventStream):
(DFGData):
* bytecode/Operands.h:
(JSC::Operands::hasOperand):
(Operands):
(JSC::Operands::size):
(JSC::Operands::at):
(JSC::Operands::operator[]):
(JSC::Operands::isArgument):
(JSC::Operands::isVariable):
(JSC::Operands::argumentForIndex):
(JSC::Operands::variableForIndex):
(JSC::Operands::operandForIndex):
(JSC):
(JSC::dumpOperands):
* bytecode/SamplingTool.h:
(SamplingRegion):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::parse):
* dfg/DFGCFAPhase.cpp:
(JSC::DFG::performCFA):
* dfg/DFGCSEPhase.cpp:
(JSC::DFG::performCSE):
* dfg/DFGFixupPhase.cpp:
(JSC::DFG::performFixup):
* dfg/DFGGenerationInfo.h:
(JSC::DFG::GenerationInfo::GenerationInfo):
(JSC::DFG::GenerationInfo::initConstant):
(JSC::DFG::GenerationInfo::initInteger):
(JSC::DFG::GenerationInfo::initJSValue):
(JSC::DFG::GenerationInfo::initCell):
(JSC::DFG::GenerationInfo::initBoolean):
(JSC::DFG::GenerationInfo::initDouble):
(JSC::DFG::GenerationInfo::initStorage):
(GenerationInfo):
(JSC::DFG::GenerationInfo::noticeOSRBirth):
(JSC::DFG::GenerationInfo::use):
(JSC::DFG::GenerationInfo::spill):
(JSC::DFG::GenerationInfo::setSpilled):
(JSC::DFG::GenerationInfo::fillJSValue):
(JSC::DFG::GenerationInfo::fillCell):
(JSC::DFG::GenerationInfo::fillInteger):
(JSC::DFG::GenerationInfo::fillBoolean):
(JSC::DFG::GenerationInfo::fillDouble):
(JSC::DFG::GenerationInfo::fillStorage):
(JSC::DFG::GenerationInfo::appendFill):
(JSC::DFG::GenerationInfo::appendSpill):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
(JSC::DFG::JITCompiler::compile):
(JSC::DFG::JITCompiler::compileFunction):
* dfg/DFGMinifiedGraph.h: Added.
(DFG):
(MinifiedGraph):
(JSC::DFG::MinifiedGraph::MinifiedGraph):
(JSC::DFG::MinifiedGraph::at):
(JSC::DFG::MinifiedGraph::append):
(JSC::DFG::MinifiedGraph::prepareAndShrink):
(JSC::DFG::MinifiedGraph::setOriginalGraphSize):
(JSC::DFG::MinifiedGraph::originalGraphSize):
* dfg/DFGMinifiedNode.cpp: Added.
(DFG):
(JSC::DFG::MinifiedNode::fromNode):
* dfg/DFGMinifiedNode.h: Added.
(DFG):
(JSC::DFG::belongsInMinifiedGraph):
(MinifiedNode):
(JSC::DFG::MinifiedNode::MinifiedNode):
(JSC::DFG::MinifiedNode::index):
(JSC::DFG::MinifiedNode::op):
(JSC::DFG::MinifiedNode::hasChild1):
(JSC::DFG::MinifiedNode::child1):
(JSC::DFG::MinifiedNode::hasConstant):
(JSC::DFG::MinifiedNode::hasConstantNumber):
(JSC::DFG::MinifiedNode::constantNumber):
(JSC::DFG::MinifiedNode::hasWeakConstant):
(JSC::DFG::MinifiedNode::weakConstant):
(JSC::DFG::MinifiedNode::getIndex):
(JSC::DFG::MinifiedNode::compareByNodeIndex):
(JSC::DFG::MinifiedNode::hasChild):
* dfg/DFGNode.h:
(Node):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::OSRExit):
* dfg/DFGOSRExit.h:
(OSRExit):
* dfg/DFGOSRExitCompiler.cpp:
* dfg/DFGOSRExitCompiler.h:
(OSRExitCompiler):
* dfg/DFGOSRExitCompiler32_64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGOSRExitCompiler64.cpp:
(JSC::DFG::OSRExitCompiler::compileExit):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::performPredictionPropagation):
* dfg/DFGRedundantPhiEliminationPhase.cpp:
(JSC::DFG::performRedundantPhiElimination):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::SpeculativeJIT):
(DFG):
(JSC::DFG::SpeculativeJIT::fillStorage):
(JSC::DFG::SpeculativeJIT::noticeOSRBirth):
(JSC::DFG::SpeculativeJIT::compileMovHint):
(JSC::DFG::SpeculativeJIT::compile):
(JSC::DFG::SpeculativeJIT::computeValueRecoveryFor):
* dfg/DFGSpeculativeJIT.h:
(DFG):
(JSC::DFG::SpeculativeJIT::use):
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::spill):
(JSC::DFG::SpeculativeJIT::speculationCheck):
(JSC::DFG::SpeculativeJIT::forwardSpeculationCheck):
(JSC::DFG::SpeculativeJIT::recordSetLocal):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::fillInteger):
(JSC::DFG::SpeculativeJIT::fillDouble):
(JSC::DFG::SpeculativeJIT::fillJSValue):
(JSC::DFG::SpeculativeJIT::fillSpeculateIntInternal):
(JSC::DFG::SpeculativeJIT::fillSpeculateDouble):
(JSC::DFG::SpeculativeJIT::fillSpeculateCell):
(JSC::DFG::SpeculativeJIT::fillSpeculateBoolean):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGValueRecoveryOverride.h: Added.
(DFG):
(ValueRecoveryOverride):
(JSC::DFG::ValueRecoveryOverride::ValueRecoveryOverride):
* dfg/DFGValueSource.cpp: Added.
(DFG):
(JSC::DFG::ValueSource::dump):
* dfg/DFGValueSource.h: Added.
(DFG):
(JSC::DFG::dataFormatToValueSourceKind):
(JSC::DFG::valueSourceKindToDataFormat):
(JSC::DFG::isInRegisterFile):
(ValueSource):
(JSC::DFG::ValueSource::ValueSource):
(JSC::DFG::ValueSource::forPrediction):
(JSC::DFG::ValueSource::forDataFormat):
(JSC::DFG::ValueSource::isSet):
(JSC::DFG::ValueSource::kind):
(JSC::DFG::ValueSource::isInRegisterFile):
(JSC::DFG::ValueSource::dataFormat):
(JSC::DFG::ValueSource::valueRecovery):
(JSC::DFG::ValueSource::nodeIndex):
(JSC::DFG::ValueSource::nodeIndexFromKind):
(JSC::DFG::ValueSource::kindFromNodeIndex):
* dfg/DFGVariableEvent.cpp: Added.
(DFG):
(JSC::DFG::VariableEvent::dump):
(JSC::DFG::VariableEvent::dumpFillInfo):
(JSC::DFG::VariableEvent::dumpSpillInfo):
* dfg/DFGVariableEvent.h: Added.
(DFG):
(VariableEvent):
(JSC::DFG::VariableEvent::VariableEvent):
(JSC::DFG::VariableEvent::reset):
(JSC::DFG::VariableEvent::fillGPR):
(JSC::DFG::VariableEvent::fillPair):
(JSC::DFG::VariableEvent::fillFPR):
(JSC::DFG::VariableEvent::spill):
(JSC::DFG::VariableEvent::death):
(JSC::DFG::VariableEvent::setLocal):
(JSC::DFG::VariableEvent::movHint):
(JSC::DFG::VariableEvent::kind):
(JSC::DFG::VariableEvent::nodeIndex):
(JSC::DFG::VariableEvent::dataFormat):
(JSC::DFG::VariableEvent::gpr):
(JSC::DFG::VariableEvent::tagGPR):
(JSC::DFG::VariableEvent::payloadGPR):
(JSC::DFG::VariableEvent::fpr):
(JSC::DFG::VariableEvent::virtualRegister):
(JSC::DFG::VariableEvent::operand):
(JSC::DFG::VariableEvent::variableRepresentation):
* dfg/DFGVariableEventStream.cpp: Added.
(DFG):
(JSC::DFG::VariableEventStream::logEvent):
(MinifiedGenerationInfo):
(JSC::DFG::MinifiedGenerationInfo::MinifiedGenerationInfo):
(JSC::DFG::MinifiedGenerationInfo::update):
(JSC::DFG::VariableEventStream::reconstruct):
* dfg/DFGVariableEventStream.h: Added.
(DFG):
(VariableEventStream):
(JSC::DFG::VariableEventStream::appendAndLog):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::performVirtualRegisterAllocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove flashplugin-installer from the EWS image because it causes some tests to crash
abarth@webkit.org [Tue, 3 Jul 2012 01:24:18 +0000 (01:24 +0000)]
Remove flashplugin-installer from the EWS image because it causes some tests to crash
https://bugs.webkit.org/show_bug.cgi?id=90403

Reviewed by Tony Chang.

* EWSTools/cold-boot.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Chromimum
yosin@chromium.org [Tue, 3 Jul 2012 01:21:13 +0000 (01:21 +0000)]
Build fix for Chromimum

r121710 removed WebCore/platform/qt/GraphicsLayerQt.{cpp,h}.
However, that patch didn't remove them from WebCore.gypi.

* WebCore.gypi: Removed GraphicsLayerQt.{cpp,h}

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIDL overloads should not treat wrapper types as nullable by default
jsbell@chromium.org [Tue, 3 Jul 2012 01:08:24 +0000 (01:08 +0000)]
IDL overloads should not treat wrapper types as nullable by default
https://bugs.webkit.org/show_bug.cgi?id=90218

Reviewed by Kentaro Hara.

Wrapper types were being treated as Nullable by default during overloaded
method dispatching, which deviates from the WebIDL specification. This change
introduces the "?" type suffix into the parser, and treats wrapper types
only nullable if specified. (The behavior of array types and other non-wrapper
types are not changed, and only overloaded methods are checked.)

IDL files with affected overloads are modified to include the "?" suffix
so that no behavior changes are introduced by this patch - the JS and V8
generator results before/after the change show no diffs.

Test: bindings/scripts/test/TestObj.idl (a non-nullable overload)

* Modules/indexeddb/IDBDatabase.idl: Added "?" where necessary.
* Modules/indexeddb/IDBIndex.idl: Added "?" where necessary.
* Modules/indexeddb/IDBObjectStore.idl: Added "?" where necessary.
* Modules/webaudio/AudioContext.idl: Added "?" where necessary.
* Modules/webaudio/AudioNode.idl: Added "?" where necessary.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheckExpression): Add isNullable check.
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateParametersCheckExpression): Add isNullable check.
* bindings/scripts/IDLParser.pm: Parse/set isNullable.
(parseParameters):
* bindings/scripts/IDLStructure.pm: Add basic type suffix parsing.
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod8):
(WebCore):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
* bindings/scripts/test/TestObj.idl: Mark previous overload params with ?, add new one without.
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethod8Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::overloadedMethodCallback):
* dom/DataTransferItemList.idl: Added "?" where necessary.
* fileapi/WebKitBlobBuilder.idl: Added "?" where necessary.
* html/DOMURL.idl: Added "?" where necessary.
* html/canvas/CanvasRenderingContext2D.idl: Added "?" where necessary.
* html/canvas/WebGLRenderingContext.idl: Added "?" where necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Implement a Layout Test for editing/SurroundingText
leandrogracia@chromium.org [Tue, 3 Jul 2012 00:53:26 +0000 (00:53 +0000)]
[Chromium] Implement a Layout Test for editing/SurroundingText
https://bugs.webkit.org/show_bug.cgi?id=82461

Reviewed by Ryosuke Niwa.

Source/WebKit/chromium:

Allow passing nodes as arguments for layout test methods.

* public/WebBindings.h:
(WebBindings):
* src/WebBindings.cpp:
(WebKit::getNodeImpl):
(WebKit):
(WebKit::WebBindings::getNode):

Tools:

Add a new method to the layout test controller in order to retrieve the
text surrounding a provided element.

* DumpRenderTree/chromium/LayoutTestController.cpp:
(LayoutTestController::LayoutTestController):
(LayoutTestController::textSurroundingElement):
* DumpRenderTree/chromium/LayoutTestController.h:
(LayoutTestController):

LayoutTests:

Add a new layout test for the surrounding text feature.

* platform/chromium/editing/surrounding-text/surrounding-text-expected.txt: Added.
* platform/chromium/editing/surrounding-text/surrounding-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG::ArgumentsSimplificationPhase should assert that the PhantomArguments nodes it...
fpizlo@apple.com [Tue, 3 Jul 2012 00:10:08 +0000 (00:10 +0000)]
DFG::ArgumentsSimplificationPhase should assert that the PhantomArguments nodes it creates are not shouldGenerate()
https://bugs.webkit.org/show_bug.cgi?id=90407

Reviewed by Mark Hahnenberg.

* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium rebaseline.
eae@chromium.org [Mon, 2 Jul 2012 23:44:06 +0000 (23:44 +0000)]
Unreviewed chromium rebaseline.

* platform/chromium-linux/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
* platform/chromium-mac/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Get rid of GraphicsLayerQt
noam.rosenthal@nokia.com [Mon, 2 Jul 2012 22:44:32 +0000 (22:44 +0000)]
[Qt] Get rid of GraphicsLayerQt
https://bugs.webkit.org/show_bug.cgi?id=78598

Reviewed by Luiz Agostini.

Source/WebCore:

Remove GraphicsLayerQt.h/cpp, as well as references to the non-TextureMapper code paths
in GraphicsContext3DQt and MediaPlayerPrivateQt.

No new tests, removing unused code paths.

* Target.pri:
* platform/graphics/PlatformLayer.h:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
(GraphicsContext3DPrivate):
(WebCore):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore):
* platform/graphics/qt/GraphicsLayerQt.cpp: Removed.
* platform/graphics/qt/GraphicsLayerQt.h: Removed.
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::invalidateRect):
(WebCore::PluginView::platformStart):

Source/WebKit/qt:

Removed all references to GraphicsLayerQt, including #ifdef code paths that only apply
when TEXTURE_MAPPER is disabled.

* Api/qgraphicswebview.cpp:
(QGraphicsWebView::paint):
* Api/qwebframe.cpp:
(QWebFramePrivate::renderFromTiledBackingStore):
(QWebFramePrivate::renderRelativeCoords):
* Api/qwebframe_p.h:
(QWebFramePrivate::QWebFramePrivate):
(QWebFramePrivate):
* Api/qwebsettings.cpp:
(QWebSettingsPrivate::apply):
* WebCoreSupport/PageClientQt.cpp:
(WebCore):
(WebCore::PageClientQGraphicsWidget::~PageClientQGraphicsWidget):
(WebCore::PageClientQGraphicsWidget::update):
(WebCore::PageClientQGraphicsWidget::syncLayers):
(WebCore::PageClientQGraphicsWidget::setRootGraphicsLayer):
* WebCoreSupport/PageClientQt.h:
(WebCore):
(WebCore::PageClientQWidget::PageClientQWidget):
(PageClientQWidget):
(PageClientQGraphicsWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayoutUnit::epsilon() is wrong
commit-queue@webkit.org [Mon, 2 Jul 2012 22:41:33 +0000 (22:41 +0000)]
LayoutUnit::epsilon() is wrong
https://bugs.webkit.org/show_bug.cgi?id=90083

Patch by Behdad Esfahbod <behdad@behdad.org> on 2012-07-02
Reviewed by Eric Seidel.

Do division in floats, not integers.

No new tests. No code using the affected function.

* platform/FractionalLayoutUnit.h:
(WebCore::FractionalLayoutUnit::epsilon):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCompositing layer sync should cause deferred repaints to be fired immediately
timothy_horton@apple.com [Mon, 2 Jul 2012 22:14:54 +0000 (22:14 +0000)]
Compositing layer sync should cause deferred repaints to be fired immediately
https://bugs.webkit.org/show_bug.cgi?id=90401
<rdar://problem/11792028>

Reviewed by Simon Fraser and Antti Koivisto.

If we sync compositing layers and allow the repaint to be deferred, there is time for a
visible flash to occur. Instead, stop the deferred repaint timer and repaint immediately.

No new tests, configuration and timing dependent.

* page/FrameView.cpp:
(WebCore::FrameView::syncCompositingStateForThisFrame):
(WebCore::FrameView::checkStopDelayingDeferredRepaints):
(WebCore::FrameView::stopDelayingDeferredRepaints): Split off from checkStopDelayingDeferredRepaints.
* page/FrameView.h:
(FrameView): Add stopDelayingDeferredRepaints.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDo not do any logging initialization when logging is disabled
benjamin@webkit.org [Mon, 2 Jul 2012 21:47:42 +0000 (21:47 +0000)]
Do not do any logging initialization when logging is disabled
https://bugs.webkit.org/show_bug.cgi?id=90228

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-07-02
Reviewed by Simon Fraser.

Source/WebCore:

Initializating of the logging channels was taking time on startup. When logging is disabled
(and the LOG macro does nothing), we should aslo disable logging channels and initialization.

This patch #ifdef the Logging initialization with the macro LOG_DISABLED.

* WebCore.exp.in:
* make-export-file-generator: Explicitely adds Assertions.h so that LOG_DISABLED is defined.
* platform/Logging.cpp:
* platform/Logging.h:
* platform/blackberry/LoggingBlackBerry.cpp:
* platform/efl/LoggingEfl.cpp:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
* platform/gtk/LoggingGtk.cpp:
* platform/mac/LoggingMac.mm:
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ensureSessionIsInitialized):
* platform/qt/LoggingQt.cpp:
* platform/win/LoggingWin.cpp:
* platform/wx/LoggingWx.cpp:

Source/WebKit/blackberry:

* Api/BlackBerryGlobal.cpp:
(BlackBerry::WebKit::globalInitialize):

Source/WebKit/chromium:

* src/WebKit.cpp:
(WebKit::enableLogChannel):

Source/WebKit/efl:

* ewk/ewk_main.cpp:
(_ewk_init_body):

Source/WebKit/gtk:

* webkit/webkitglobals.cpp:
(webkitInit):

Source/WebKit/mac:

* Misc/WebIconDatabase.mm:
(-[WebIconDatabase _scaleIcon:toSize:]):
* Misc/WebKitLogging.h:
* Misc/WebKitLogging.m:
* WebView/WebHTMLView.mm:
(-[WebHTMLView _attributeStringFromDOMRange:]):
* WebView/WebView.mm:
(-[WebView _commonInitializationWithFrameName:groupName:]):

Source/WebKit/qt:

* WebCoreSupport/InitWebCoreQt.cpp:
(WebCore::initializeWebCoreQt):

Source/WebKit/win:

* WebView.cpp:
(WebView::initWithFrame):

Source/WebKit/wx:

* WebView.cpp:
(WebKit::WebView::Create):

Source/WebKit2:

* Platform/Logging.cpp:
* Platform/Logging.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDelete unused rebaseline method in gardeningserver.py
ojan@chromium.org [Mon, 2 Jul 2012 21:27:29 +0000 (21:27 +0000)]
Delete unused rebaseline method in gardeningserver.py
https://bugs.webkit.org/show_bug.cgi?id=90396

Reviewed by Eric Seidel.

As best I can tell, the only usage was in this unittest.

* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler.updateexpectations):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaseline_new_port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother crashing test on the EWS. We think this is because of the flash
abarth@webkit.org [Mon, 2 Jul 2012 20:48:00 +0000 (20:48 +0000)]
Another crashing test on the EWS. We think this is because of the flash
package we have installed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium rebaseline for r121697.
eae@chromium.org [Mon, 2 Jul 2012 20:44:19 +0000 (20:44 +0000)]
Unreviewed chromium rebaseline for r121697.

* platform/chromium-linux-x86/fast/multicol/vertical-lr: Added.
* platform/chromium-linux-x86/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
* platform/chromium-linux-x86/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
* platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-linux/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
* platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-linux/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/multicol/vertical-lr/float-avoidance-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/multicol/vertical-rl/float-avoidance-expected.png: Removed.
* platform/chromium-mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-win-xp/fast/multicol/vertical-lr: Added.
* platform/chromium-win-xp/fast/multicol/vertical-lr/float-avoidance-expected.txt: Added.
* platform/chromium-win-xp/fast/multicol/vertical-rl: Added.
* platform/chromium-win-xp/fast/multicol/vertical-rl/float-avoidance-expected.txt: Added.
* platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/chromium-win/fast/multicol/vertical-rl/float-avoidance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/box-decoration-break/box-decoration-break-rendering.html failing on mac bots
alexis.menard@openbossa.org [Mon, 2 Jul 2012 19:56:36 +0000 (19:56 +0000)]
fast/box-decoration-break/box-decoration-break-rendering.html failing on mac bots
https://bugs.webkit.org/show_bug.cgi?id=89620

Reviewed by Simon Fraser.

Remove the border-radius from the test case as it can produce differences between
the test case and the reference html. At first we thought the 3 pixels difference
was only happening on Mac but after investigation it also happens in Qt (at least).
It was not triggered because ImageDiff was called with some tolerance. Turning the
tolerance to 0 on Qt also trigger some pixel differences.

The differences on how the radius is drawn can be explained by the fact that
the reference html and the test case uses two different paths for drawing the border.
The reference on the slice case only draw three borders which leads into the contruction
of three different drawing paths that we use to clip and clip out. We then draw the border with
antialiasing off as we have constructed the outer and inner paths pretty accurately.
The test case in the other hand uses the fast path for drawing the borders. The slice effect
is in fact is happening because the graphics context is clipped to the current InlineFlowBox rect but still
the border has 4 edges and its drawing will happen using the following : create a path with
an outer rounded rectangle and an inner rounded rectangle. The path is then filled with RULE_EVENODD
and anti-aliasing turn on to achieve a nice looking effect.

To conclude the pixel differences are the fact of the two different drawing techniques used here. Fast
drawing and anti-aliasing to get a decent result or more accurate algorithm but slower. The original test
was not about testing the radiuses of the borders but rather if the borders are cloned or sliced. Even
removing the radius still cover the feature.

* fast/box-decoration-break/box-decoration-break-rendering-expected.html:
* fast/box-decoration-break/box-decoration-break-rendering.html:
* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][CMake] Integrate API unit tests with CTest
commit-queue@webkit.org [Mon, 2 Jul 2012 19:46:16 +0000 (19:46 +0000)]
[EFL][CMake] Integrate API unit tests with CTest
https://bugs.webkit.org/show_bug.cgi?id=87251

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-02
Reviewed by Daniel Bates.

.:

Enable CTest on the root CMakeLists.txt as it is expected
to be here. This will create a new build target ("make test")
to run all the API unit tests.

* CMakeLists.txt:

Source/WebKit:

Add every test to the test runner build target.

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r121497): It switched off and broke many unittests
dpranke@chromium.org [Mon, 2 Jul 2012 19:45:32 +0000 (19:45 +0000)]
REGRESSION(r121497): It switched off and broke many unittests
https://bugs.webkit.org/show_bug.cgi?id=90371

Patch by Csaba Osztrogonác <ossy@webkit.org> on 2012-07-02
Reviewed by Adam Barth.

* Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
(ChromiumMacPortTest): Use snowleopard as os_version instead of leopard, because it isn't supported anymore.
* Scripts/webkitpy/layout_tests/port/chromium_port_testcase.py:
(ChromiumPortTestCase.test_all_test_configurations): Remove leopard testcases, because it isn't supported anymore.
* Scripts/webkitpy/layout_tests/port/port_testcase.py:
(PortTestCase): Inherit class PortTestCase from unittest.TestCase instead of object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoArray.prototype.pop should throw if property is not configurable
barraclough@apple.com [Mon, 2 Jul 2012 19:25:59 +0000 (19:25 +0000)]
Array.prototype.pop should throw if property is not configurable
https://bugs.webkit.org/show_bug.cgi?id=75788

Rubber Stamped by Oliver Hunt.

No real bug here any more, but the error we throw sometimes has a misleading message.

* runtime/JSArray.cpp:
(JSC::JSArray::pop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove rebaseline-all command from the gardening-server down into webkit-patch
ojan@chromium.org [Mon, 2 Jul 2012 19:22:43 +0000 (19:22 +0000)]
Move rebaseline-all command from the gardening-server down into webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=90395

Reviewed by Adam Barth.

This is just moving code. It it in preparation for making rebaseline-expectations
use the same code in order to get the parallelism benefits and reduces the amount
of code we have for doing rebaselines.

* Scripts/webkitpy/common/checkout/checkout_unittest.py:
(CheckoutTest.test_apply_patch):
Updated due to the change to executive_mock.
* Scripts/webkitpy/common/system/executive_mock.py:
(MockExecutive.run_command):
Update to print out the input passed to stdin.
* Scripts/webkitpy/tool/commands/download_unittest.py:
Updated due to executive_mock change.
* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineAll):
(RebaselineAll._run_webkit_patch):
(RebaselineAll._builders_to_fetch_from):
(RebaselineAll._rebaseline_commands):
(RebaselineAll._files_to_add):
(RebaselineAll._optimize_baselines):
(RebaselineAll._rebaseline):
(RebaselineAll.execute):
All this code is just copy-pasted except for mechanical changes
(e.g. self.server.tool --> self._tool) and the reading in of the
JSON from stdin instead of the post body.
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_all):
Copied the test-case out of gardeningserver_unittest.py.
* Scripts/webkitpy/tool/servers/gardeningserver.py:
(GardeningHTTPRequestHandler):
(GardeningHTTPRequestHandler.rebaseline):
(GardeningHTTPRequestHandler.rebaselineall):
* Scripts/webkitpy/tool/servers/gardeningserver_unittest.py:
(GardeningServerTest.test_rebaselineall):
(GardeningServerTest.test_rebaselineall.run_command):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] New API tests introduced in r121620 fail
noam.rosenthal@nokia.com [Mon, 2 Jul 2012 19:12:23 +0000 (19:12 +0000)]
[Qt][WK2] New API tests introduced in r121620 fail
https://bugs.webkit.org/show_bug.cgi?id=90372

Reviewed by Luiz Agostini.

Updated the pixel comparison to produce more predictable results.

* UIProcess/API/qt/tests/qrawwebview/tst_qrawwebview.cpp:
(compareImages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/11787030> In vertical writing modes, child following float-clearing...
mitz@apple.com [Mon, 2 Jul 2012 19:11:31 +0000 (19:11 +0000)]
<rdar://problem/11787030> In vertical writing modes, child following float-clearing block has incorrect logical top
https://bugs.webkit.org/show_bug.cgi?id=90359

Reviewed by Anders Carlsson.

Source/WebCore:

Test: fast/writing-mode/logical-height-after-clear.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::clearFloatsIfNeeded): Changed to use logicalTop() and logicalHeight()
instead of y() and height().

LayoutTests:

* fast/writing-mode/logical-height-after-clear-expected.html: Added.
* fast/writing-mode/logical-height-after-clear.html: Added.
* platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.png:
* platform/mac/fast/multicol/vertical-lr/float-avoidance-expected.txt:
* platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.png:
* platform/mac/fast/multicol/vertical-rl/float-avoidance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Leopard support from the flakiness dashboard
ojan@chromium.org [Mon, 2 Jul 2012 18:25:12 +0000 (18:25 +0000)]
Remove Leopard support from the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=90390

Reviewed by Adam Barth.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(nonChromiumPlatform):
(chromiumPlatform):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):
* TestResultServer/static-dashboards/run-embedded-unittests.html:
* TestResultServer/static-dashboards/run-unittests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix posting from garden-o-matic. This broke in moving away from jquery's ajax method
ojan@chromium.org [Mon, 2 Jul 2012 18:08:00 +0000 (18:08 +0000)]
Fix posting from garden-o-matic. This broke in moving away from jquery's ajax method
in http://trac.webkit.org/changeset/121617.
* BuildSlaveSupport/build.webkit.org-config/public_html/TestFailures/scripts/net.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
zandobersek@gmail.com [Mon, 2 Jul 2012 17:56:09 +0000 (17:56 +0000)]
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Reviewed by Martin Robinson.

Create a new category for test failures that only fail on specific architecture. Tests
under this category are essentially marked as flaky, but in reality only fail on the
build architecture under which they are listed. This is a convenient workaround for
keeping tests from being recognized as newly-passing on architectures where the failure
does not occur.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClean up slow HTTP tests on GTK platform
zandobersek@gmail.com [Mon, 2 Jul 2012 17:50:35 +0000 (17:50 +0000)]
Clean up slow HTTP tests on GTK platform

Rubber-stamped by Martin Robinson.

Skip the HTTP tests that take half a minute to run, most oftenly failing
as well. These tests only extend the overall testing time.
Also group the tests failing due to missing authentication handling in DRT,
missing multipart/x-mixed-replace support in libsoup and open a new bug
for the failing http/tests/plugins/plugin-document-has-focus.html test.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMicrodata: Fix build failure after r121580.
arko@motorola.com [Mon, 2 Jul 2012 17:30:33 +0000 (17:30 +0000)]
Microdata: Fix build failure after r121580.
https://bugs.webkit.org/show_bug.cgi?id=90378

Reviewed by Ryosuke Niwa.

* html/HTMLElement.cpp:
(WebCore::HTMLElement::properties):
* html/HTMLElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Update MediaStreamTrackList to match the specification
tommyw@google.com [Mon, 2 Jul 2012 17:24:24 +0000 (17:24 +0000)]
MediaStream API: Update MediaStreamTrackList to match the specification
https://bugs.webkit.org/show_bug.cgi?id=90171

Reviewed by Adam Barth.

Source/Platform:

The latest update to the specification added add and remove methods with corresponding callbacks.
The callbacks can be triggered both from JS and from the platform layer.

* chromium/public/WebMediaStreamCenterClient.h:
(WebKit):
(WebMediaStreamCenterClient):

Source/WebCore:

The latest update to the specification added add and remove methods with corresponding callbacks.
The callbacks can be triggered both from JS and from the platform layer.

Test: fast/mediastream/MediaStreamTrackList.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/MediaStream.cpp:
(WebCore::MediaStream::MediaStream):
(WebCore::MediaStream::~MediaStream):
(WebCore::MediaStream::streamEnded):
(WebCore::MediaStream::addTrack):
(WebCore):
(WebCore::MediaStream::removeTrack):
* Modules/mediastream/MediaStream.h:
(MediaStream):
* Modules/mediastream/MediaStreamTrackEvent.cpp: Copied from Source/WebCore/Modules/mediastream/MediaStreamTrackList.cpp.
(WebCore):
(WebCore::MediaStreamTrackEvent::create):
(WebCore::MediaStreamTrackEvent::MediaStreamTrackEvent):
(WebCore::MediaStreamTrackEvent::~MediaStreamTrackEvent):
(WebCore::MediaStreamTrackEvent::track):
(WebCore::MediaStreamTrackEvent::interfaceName):
* Modules/mediastream/MediaStreamTrackEvent.h: Copied from Source/WebCore/Modules/mediastream/MediaStreamTrackList.h.
(WebCore):
(MediaStreamTrackEvent):
* Modules/mediastream/MediaStreamTrackEvent.idl: Copied from Source/WebCore/Modules/mediastream/MediaStreamTrackList.idl.
* Modules/mediastream/MediaStreamTrackList.cpp:
(WebCore::MediaStreamTrackList::create):
(WebCore::MediaStreamTrackList::MediaStreamTrackList):
(WebCore::MediaStreamTrackList::detachOwner):
(WebCore):
(WebCore::MediaStreamTrackList::add):
(WebCore::MediaStreamTrackList::remove):
(WebCore::MediaStreamTrackList::stop):
(WebCore::MediaStreamTrackList::interfaceName):
(WebCore::MediaStreamTrackList::scriptExecutionContext):
(WebCore::MediaStreamTrackList::eventTargetData):
(WebCore::MediaStreamTrackList::ensureEventTargetData):
* Modules/mediastream/MediaStreamTrackList.h:
(MediaStreamTrackList):
* Modules/mediastream/MediaStreamTrackList.idl:
* WebCore.gypi:
* dom/EventNames.h:
(WebCore):
* dom/EventNames.in:
* dom/EventTargetFactory.in:
* platform/mediastream/MediaStreamCenter.cpp:
(WebCore::MediaStreamCenter::addMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenter::removeMediaStreamTrack):
* platform/mediastream/MediaStreamCenter.h:
(MediaStreamCenter):
* platform/mediastream/MediaStreamDescriptor.h:
(MediaStreamDescriptorOwner):
* platform/mediastream/chromium/MediaStreamCenterChromium.cpp:
(WebCore::MediaStreamCenterChromium::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterChromium::didRemoveMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::addMediaStreamTrack):
(WebCore::MediaStreamCenterChromium::removeMediaStreamTrack):
* platform/mediastream/chromium/MediaStreamCenterChromium.h:
(WebKit):
(MediaStreamCenterChromium):
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.cpp:
(WebCore::MediaStreamCenterGStreamer::didAddMediaStreamTrack):
(WebCore):
(WebCore::MediaStreamCenterGStreamer::didRemoveMediaStreamTrack):
* platform/mediastream/gstreamer/MediaStreamCenterGStreamer.h:
(MediaStreamCenterGStreamer):

LayoutTests:

* fast/mediastream/MediaStreamTrackList-expected.txt: Added.
* fast/mediastream/MediaStreamTrackList.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121691 268f45cc-cd09-0410-ab3c-d52691b4dbfc