WebKit-https.git
7 years ago[EFL][WK2] Add ewk_view_reload_bypass_cache API.
commit-queue@webkit.org [Thu, 5 Jul 2012 08:36:39 +0000 (08:36 +0000)]
[EFL][WK2] Add ewk_view_reload_bypass_cache API.
https://bugs.webkit.org/show_bug.cgi?id=89413

Patch by Hyerim Bae <hyerim.bae@samsung.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Add API, which is for reloading documents without cache.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_reload_bypass_cache):
* UIProcess/API/efl/ewk_view.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [JSC] support JS execution in the context of an isolated world
commit-queue@webkit.org [Thu, 5 Jul 2012 08:19:51 +0000 (08:19 +0000)]
Web Inspector: [JSC] support JS execution in the context of an isolated world
https://bugs.webkit.org/show_bug.cgi?id=85709

Patch by Peter Wang <peter.wang@torchmobile.com.cn> on 2012-07-05
Reviewed by Gavin Barraclough.

No new test case for this bug.

* bindings/js/ScriptController.cpp:
(WebCore::ScriptController::collectIsolatedContexts):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Ewk_View needs API to load HTML data
commit-queue@webkit.org [Thu, 5 Jul 2012 08:14:58 +0000 (08:14 +0000)]
[WK2][EFL] Ewk_View needs API to load HTML data
https://bugs.webkit.org/show_bug.cgi?id=90540

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

Add method to Ewk_View to load provided HTML data.
This is used for e.g. when an URL cannot be reached
and we need to display an error page.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_html_load):
* UIProcess/API/efl/ewk_view.h:

Tools:

Update EFL MiniBrowser to catch the "load,error" signal
on the view and display an error page.

* MiniBrowser/efl/main.c:
(on_error):
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Ewk_View needs to report new resource requests
commit-queue@webkit.org [Thu, 5 Jul 2012 07:59:25 +0000 (07:59 +0000)]
[WK2][EFL] Ewk_View needs to report new resource requests
https://bugs.webkit.org/show_bug.cgi?id=90577

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-05
Reviewed by Kenneth Rohde Christiansen.

Add new "resource,request,new" signal to Ewk_View to
notify clients of the resource requests being initiated.
New Ewk_Url_Request and Ewk_Web_Resource types are
introduced in order to provide the clients with the
needed information regarding the resource requests.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_url_request.cpp: Added.
(_Ewk_Url_Request):
(ewk_url_request_ref):
(ewk_url_request_unref):
(ewk_url_request_url_get):
(ewk_request_first_party_get):
(ewk_url_request_http_method_get):
(ewk_url_request_new):
* UIProcess/API/efl/ewk_url_request.h: Added.
* UIProcess/API/efl/ewk_url_request_private.h: Added.
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):
(ewk_view_resource_load_initiated):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_private.h:
* UIProcess/API/efl/ewk_view_resource_load_client.cpp: Added.
(didInitiateLoadForResource):
(ewk_view_resource_load_client_attach):
* UIProcess/API/efl/ewk_view_resource_load_client_private.h: Added.
* UIProcess/API/efl/ewk_web_resource.cpp: Added.
(_Ewk_Web_Resource):
(ewk_web_resource_ref):
(ewk_web_resource_unref):
(ewk_web_resource_uri_get):
(ewk_web_resource_new):
(ewk_web_resource_main_get):
* UIProcess/API/efl/ewk_web_resource.h: Added.
* UIProcess/API/efl/ewk_web_resource_private.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, marking a test as a flaky crasher after r121869.
zandobersek@gmail.com [Thu, 5 Jul 2012 07:58:58 +0000 (07:58 +0000)]
Unreviewed GTK gardening, marking a test as a flaky crasher after r121869.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed buildfix after r121886. Typo fix.
zherczeg@webkit.org [Thu, 5 Jul 2012 07:53:51 +0000 (07:53 +0000)]
[Qt] Unreviewed buildfix after r121886. Typo fix.

* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHidden dirs are not copied when creating the built product archive
sergio@webkit.org [Thu, 5 Jul 2012 07:24:21 +0000 (07:24 +0000)]
Hidden dirs are not copied when creating the built product archive
https://bugs.webkit.org/show_bug.cgi?id=90559

Reviewed by Carlos Garcia Campos.

Hidden dirs are not copied inside the built product archive
because the recursive copy command was ignoring them. We need those
hidden directories for the GTK WebKit2 testing bot to work fine.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): replaced "*" by "." to include hidden
dirs/files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPort DFG JIT to traditional ARM
zherczeg@webkit.org [Thu, 5 Jul 2012 07:04:16 +0000 (07:04 +0000)]
Port DFG JIT to traditional ARM
https://bugs.webkit.org/show_bug.cgi?id=90198

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

This patch contains the macro assembler part of the
DFG JIT support on ARM systems with fixed 32 bit instruction
width. A large amount of old code was refactored, and the ARMv4
or lower support is removed from the macro assembler.

Sunspider is improved by 8%, and V8 is 92%.

* assembler/ARMAssembler.cpp:
(JSC::ARMAssembler::dataTransfer32):
(JSC::ARMAssembler::baseIndexTransfer32):
(JSC):
(JSC::ARMAssembler::dataTransfer16):
(JSC::ARMAssembler::baseIndexTransfer16):
(JSC::ARMAssembler::dataTransferFloat):
(JSC::ARMAssembler::baseIndexTransferFloat):
(JSC::ARMAssembler::executableCopy):
* assembler/ARMAssembler.h:
(JSC::ARMAssembler::ARMAssembler):
(JSC::ARMAssembler::emitInst):
(JSC::ARMAssembler::vmov_f64_r):
(ARMAssembler):
(JSC::ARMAssembler::vabs_f64_r):
(JSC::ARMAssembler::vneg_f64_r):
(JSC::ARMAssembler::ldr_imm):
(JSC::ARMAssembler::ldr_un_imm):
(JSC::ARMAssembler::dtr_u):
(JSC::ARMAssembler::dtr_ur):
(JSC::ARMAssembler::dtr_d):
(JSC::ARMAssembler::dtr_dr):
(JSC::ARMAssembler::dtrh_u):
(JSC::ARMAssembler::dtrh_ur):
(JSC::ARMAssembler::dtrh_d):
(JSC::ARMAssembler::dtrh_dr):
(JSC::ARMAssembler::fdtr_u):
(JSC::ARMAssembler::fdtr_d):
(JSC::ARMAssembler::push_r):
(JSC::ARMAssembler::pop_r):
(JSC::ARMAssembler::poke_r):
(JSC::ARMAssembler::peek_r):
(JSC::ARMAssembler::vmov_vfp64_r):
(JSC::ARMAssembler::vmov_arm64_r):
(JSC::ARMAssembler::vmov_vfp32_r):
(JSC::ARMAssembler::vmov_arm32_r):
(JSC::ARMAssembler::vcvt_u32_f64_r):
(JSC::ARMAssembler::vcvt_f64_f32_r):
(JSC::ARMAssembler::vcvt_f32_f64_r):
(JSC::ARMAssembler::clz_r):
(JSC::ARMAssembler::bkpt):
(JSC::ARMAssembler::bx):
(JSC::ARMAssembler::blx):
(JSC::ARMAssembler::labelIgnoringWatchpoints):
(JSC::ARMAssembler::labelForWatchpoint):
(JSC::ARMAssembler::label):
(JSC::ARMAssembler::getLdrImmAddress):
(JSC::ARMAssembler::replaceWithJump):
(JSC::ARMAssembler::maxJumpReplacementSize):
(JSC::ARMAssembler::getOp2Byte):
(JSC::ARMAssembler::getOp2Half):
(JSC::ARMAssembler::RM):
(JSC::ARMAssembler::RS):
(JSC::ARMAssembler::RD):
(JSC::ARMAssembler::RN):
* assembler/AssemblerBufferWithConstantPool.h:
(JSC::AssemblerBufferWithConstantPool::ensureSpaceForAnyInstruction):
* assembler/MacroAssemblerARM.cpp:
(JSC::MacroAssemblerARM::load32WithUnalignedHalfWords):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::add32):
(MacroAssemblerARM):
(JSC::MacroAssemblerARM::and32):
(JSC::MacroAssemblerARM::lshift32):
(JSC::MacroAssemblerARM::mul32):
(JSC::MacroAssemblerARM::neg32):
(JSC::MacroAssemblerARM::rshift32):
(JSC::MacroAssemblerARM::urshift32):
(JSC::MacroAssemblerARM::xor32):
(JSC::MacroAssemblerARM::load8):
(JSC::MacroAssemblerARM::load8Signed):
(JSC::MacroAssemblerARM::load16):
(JSC::MacroAssemblerARM::load16Signed):
(JSC::MacroAssemblerARM::load32):
(JSC::MacroAssemblerARM::load32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store32WithAddressOffsetPatch):
(JSC::MacroAssemblerARM::store8):
(JSC::MacroAssemblerARM::store16):
(JSC::MacroAssemblerARM::store32):
(JSC::MacroAssemblerARM::move):
(JSC::MacroAssemblerARM::jump):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::mull32):
(JSC::MacroAssemblerARM::branchMul32):
(JSC::MacroAssemblerARM::nearCall):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::sub32):
(JSC::MacroAssemblerARM::call):
(JSC::MacroAssemblerARM::loadFloat):
(JSC::MacroAssemblerARM::loadDouble):
(JSC::MacroAssemblerARM::storeFloat):
(JSC::MacroAssemblerARM::storeDouble):
(JSC::MacroAssemblerARM::moveDouble):
(JSC::MacroAssemblerARM::addDouble):
(JSC::MacroAssemblerARM::divDouble):
(JSC::MacroAssemblerARM::subDouble):
(JSC::MacroAssemblerARM::mulDouble):
(JSC::MacroAssemblerARM::absDouble):
(JSC::MacroAssemblerARM::negateDouble):
(JSC::MacroAssemblerARM::convertInt32ToDouble):
(JSC::MacroAssemblerARM::convertFloatToDouble):
(JSC::MacroAssemblerARM::convertDoubleToFloat):
(JSC::MacroAssemblerARM::branchTruncateDoubleToInt32):
(JSC::MacroAssemblerARM::branchTruncateDoubleToUint32):
(JSC::MacroAssemblerARM::truncateDoubleToInt32):
(JSC::MacroAssemblerARM::truncateDoubleToUint32):
(JSC::MacroAssemblerARM::branchConvertDoubleToInt32):
(JSC::MacroAssemblerARM::branchDoubleNonZero):
(JSC::MacroAssemblerARM::branchDoubleZeroOrNaN):
(JSC::MacroAssemblerARM::invert):
(JSC::MacroAssemblerARM::replaceWithJump):
(JSC::MacroAssemblerARM::maxJumpReplacementSize):
(JSC::MacroAssemblerARM::call32):
* assembler/SH4Assembler.h:
(JSC::SH4Assembler::label):
* dfg/DFGAssemblyHelpers.h:
(JSC::DFG::AssemblyHelpers::debugCall):
(JSC::DFG::AssemblyHelpers::boxDouble):
(JSC::DFG::AssemblyHelpers::unboxDouble):
* dfg/DFGCCallHelpers.h:
(CCallHelpers):
(JSC::DFG::CCallHelpers::setupArguments):
* dfg/DFGFPRInfo.h:
(DFG):
* dfg/DFGGPRInfo.h:
(DFG):
(GPRInfo):
* dfg/DFGOperations.cpp:
(JSC):
* dfg/DFGSpeculativeJIT.h:
(SpeculativeJIT):
(JSC::DFG::SpeculativeJIT::appendCallWithExceptionCheckSetResult):
(JSC::DFG::SpeculativeJIT::appendCallSetResult):
* jit/JITStubs.cpp:
(JSC):
* jit/JITStubs.h:
(JITStackFrame):
* jit/JSInterfaceJIT.h:
(JSInterfaceJIT):

Source/WTF:

Enabling DFG JIT on ARM systems with 32 bit instruction set.

* wtf/InlineASM.h:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
commit-queue@webkit.org [Thu, 5 Jul 2012 06:53:59 +0000 (06:53 +0000)]
Add virtual keyword to ~BitmapImage and ~StillImage because ~Image is virtual.
https://bugs.webkit.org/show_bug.cgi?id=90447

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-04
Reviewed by Alexey Proskuryakov.

No new tests. This patch doesn't change behavior.

* platform/graphics/BitmapImage.h:
(BitmapImage):
* platform/graphics/qt/StillImageQt.h:
(StillImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement the script-nonce Content Security Policy directive.
commit-queue@webkit.org [Thu, 5 Jul 2012 06:45:37 +0000 (06:45 +0000)]
Implement the script-nonce Content Security Policy directive.
https://bugs.webkit.org/show_bug.cgi?id=89577

Patch by Mike West <mkwst@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

Source/WebCore:

This patch implements the (experimental) script-nonce Content Security
Policy directive from the 1.1 spec, which allows for selective
execution of script by specifying a "nonce" attribute for the
script tag. Script is only loaded and executed if it both matches the
nonce and matches the script-src whitelist (if present).

The implementation is gated on the ENABLE_CSP_NEXT flag, which is
currently disabled for all ports other than Chromium.

Spec: https://dvcs.w3.org/hg/content-security-policy/raw-file/tip/csp-specification.dev.html#script-nonce--experimental

Tests: http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html
       http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html
       http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html
       http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html
       http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::requestScript):
(WebCore::ScriptElement::executeScript):
    Passing the nonce attribute through to check against CSP.
* html/HTMLAttributeNames.in:
* html/HTMLScriptElement.idl:
    Adding the `nonce` attribute to the script tag.
* page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::logInvalidNonce):
(WebCore):
(WebCore::CSPDirectiveList::checkNonceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
    If a nonce is set, deny JavaScript URLs and inline event handlers.
(WebCore::CSPDirectiveList::allowScriptNonce):
(WebCore::CSPDirectiveList::parseScriptNonce):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::isAllowedByAllWithNonce):
(WebCore::ContentSecurityPolicy::allowScriptNonce):
* page/ContentSecurityPolicy.h:
(WebCore):

LayoutTests:

* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-allowed.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-badnonce.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-emptynonce.html: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked-expected.txt: Added.
* http/tests/security/contentSecurityPolicy/1.1/scriptnonce-scriptsrc-blocked.html: Added.
* http/tests/security/contentSecurityPolicy/resources/echo-script-src.pl:
    Adding noncy goodness to the echo script.
* http/tests/security/contentSecurityPolicy/resources/multiple-iframe-test.js:
(test):
* platform/gtk/TestExpectations:
    Skipping 1.1 tests on GTK (missed it in r121879).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNotifications should be in Modules/notifications
gyuyoung.kim@samsung.com [Thu, 5 Jul 2012 06:02:37 +0000 (06:02 +0000)]
Notifications should be in Modules/notifications
https://bugs.webkit.org/show_bug.cgi?id=82121

Reviewed by Adam Barth.

The notifications directory is now self-contained. This patch moves it to the Modules directory.

No new tests, covered by existing tests.

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Modules/notifications/DOMWindowNotifications.cpp: Renamed from Source/WebCore/notifications/DOMWindowNotifications.cpp.
(WebCore):
(WebCore::DOMWindowNotifications::DOMWindowNotifications):
(WebCore::DOMWindowNotifications::~DOMWindowNotifications):
(WebCore::DOMWindowNotifications::from):
(WebCore::DOMWindowNotifications::webkitNotifications):
(WebCore::DOMWindowNotifications::disconnectFrameForPageCache):
(WebCore::DOMWindowNotifications::reconnectFrameFromPageCache):
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInCachedFrame):
(WebCore::DOMWindowNotifications::willDestroyGlobalObjectInFrame):
(WebCore::DOMWindowNotifications::willDetachGlobalObjectFromFrame):
* Modules/notifications/DOMWindowNotifications.h: Renamed from Source/WebCore/notifications/DOMWindowNotifications.h.
(WebCore):
(DOMWindowNotifications):
* Modules/notifications/DOMWindowNotifications.idl: Renamed from Source/WebCore/notifications/DOMWindowNotifications.idl.
* Modules/notifications/Notification.cpp: Renamed from Source/WebCore/notifications/Notification.cpp.
(WebCore):
(WebCore::Notification::Notification):
(WebCore::Notification::~Notification):
(WebCore::Notification::create):
(WebCore::getAndAddEventListener):
(WebCore::Notification::interfaceName):
(WebCore::Notification::show):
(WebCore::Notification::close):
(WebCore::Notification::eventTargetData):
(WebCore::Notification::ensureEventTargetData):
(WebCore::Notification::contextDestroyed):
(WebCore::Notification::finalize):
(WebCore::Notification::dispatchShowEvent):
(WebCore::Notification::dispatchClickEvent):
(WebCore::Notification::dispatchCloseEvent):
(WebCore::Notification::dispatchErrorEvent):
(WebCore::Notification::taskTimerFired):
(WebCore::Notification::permissionLevel):
(WebCore::Notification::permissionString):
(WebCore::Notification::requestPermission):
* Modules/notifications/Notification.h: Renamed from Source/WebCore/notifications/Notification.h.
(WebCore):
(Notification):
(WebCore::Notification::cancel):
(WebCore::Notification::isHTML):
(WebCore::Notification::setHTML):
(WebCore::Notification::url):
(WebCore::Notification::setURL):
(WebCore::Notification::iconURL):
(WebCore::Notification::title):
(WebCore::Notification::body):
(WebCore::Notification::dir):
(WebCore::Notification::setDir):
(WebCore::Notification::replaceId):
(WebCore::Notification::setReplaceId):
(WebCore::Notification::tag):
(WebCore::Notification::setTag):
(WebCore::Notification::direction):
(WebCore::Notification::scriptExecutionContext):
(WebCore::Notification::detachPresenter):
(WebCore::Notification::setBody):
(WebCore::Notification::refEventTarget):
(WebCore::Notification::derefEventTarget):
* Modules/notifications/Notification.idl: Renamed from Source/WebCore/notifications/Notification.idl.
* Modules/notifications/NotificationCenter.cpp: Renamed from Source/WebCore/notifications/NotificationCenter.cpp.
(WebCore):
(WebCore::NotificationCenter::create):
(WebCore::NotificationCenter::NotificationCenter):
(WebCore::NotificationCenter::checkPermission):
(WebCore::NotificationCenter::requestPermission):
(WebCore::NotificationCenter::stop):
(WebCore::NotificationCenter::requestTimedOut):
(WebCore::NotificationCenter::NotificationRequestCallback::createAndStartTimer):
(WebCore::NotificationCenter::NotificationRequestCallback::NotificationRequestCallback):
(WebCore::NotificationCenter::NotificationRequestCallback::startTimer):
(WebCore::NotificationCenter::NotificationRequestCallback::timerFired):
* Modules/notifications/NotificationCenter.h: Renamed from Source/WebCore/notifications/NotificationCenter.h.
(WebCore):
(NotificationCenter):
(WebCore::NotificationCenter::createHTMLNotification):
(WebCore::NotificationCenter::createNotification):
(WebCore::NotificationCenter::client):
(NotificationRequestCallback):
* Modules/notifications/NotificationCenter.idl: Renamed from Source/WebCore/notifications/NotificationCenter.idl.
* Modules/notifications/NotificationClient.h: Renamed from Source/WebCore/notifications/NotificationClient.h.
(WebCore):
(NotificationClient):
(WebCore::NotificationClient::clearNotifications):
(WebCore::NotificationClient::~NotificationClient):
* Modules/notifications/NotificationController.cpp: Renamed from Source/WebCore/notifications/NotificationController.cpp.
(WebCore):
(WebCore::NotificationController::NotificationController):
(WebCore::NotificationController::~NotificationController):
(WebCore::NotificationController::create):
(WebCore::NotificationController::clientFrom):
(WebCore::NotificationController::supplementName):
(WebCore::provideNotification):
* Modules/notifications/NotificationController.h: Renamed from Source/WebCore/notifications/NotificationController.h.
(WebCore):
(NotificationController):
(WebCore::NotificationController::from):
(WebCore::NotificationController::client):
* Modules/notifications/NotificationPermissionCallback.h: Renamed from Source/WebCore/notifications/NotificationPermissionCallback.h.
(WebCore):
(NotificationPermissionCallback):
(WebCore::NotificationPermissionCallback::~NotificationPermissionCallback):
* Modules/notifications/NotificationPermissionCallback.idl: Renamed from Source/WebCore/notifications/NotificationPermissionCallback.idl.
* Modules/notifications/WorkerContextNotifications.cpp: Renamed from Source/WebCore/notifications/WorkerContextNotifications.cpp.
(WebCore):
(WebCore::WorkerContextNotifications::WorkerContextNotifications):
(WebCore::WorkerContextNotifications::~WorkerContextNotifications):
(WebCore::WorkerContextNotifications::from):
(WebCore::WorkerContextNotifications::webkitNotifications):
* Modules/notifications/WorkerContextNotifications.h: Renamed from Source/WebCore/notifications/WorkerContextNotifications.h.
(WebCore):
(WorkerContextNotifications):
* Modules/notifications/WorkerContextNotifications.idl: Renamed from Source/WebCore/notifications/WorkerContextNotifications.idl.
* Target.pri:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcproj/WebCoreCommon.vsprops:
* WebCore.vcproj/copyForwardingHeaders.cmd:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening, Disable always failed python tests on Windows.
yosin@chromium.org [Thu, 5 Jul 2012 05:35:14 +0000 (05:35 +0000)]
Unreviewed Chromium gardening, Disable always failed python tests on Windows.
https://bugs.webkit.org/show_bug.cgi?id=90587

PortTest.qt_linux and mac_lion are always failed on Chromium Windows at
creating child process.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_qt_linux):
(PortTest.disabled_test_mac_lion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, Chromium gardening. Roll Chromium DEPS.
yosin@chromium.org [Thu, 5 Jul 2012 04:27:26 +0000 (04:27 +0000)]
Unreviewed, Chromium gardening. Roll Chromium DEPS.

* DEPS: chromium_rev: 145322 => 145501

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSkip CSP 1.1 tests on ports where it's disabled.
commit-queue@webkit.org [Thu, 5 Jul 2012 04:04:55 +0000 (04:04 +0000)]
Skip CSP 1.1 tests on ports where it's disabled.
https://bugs.webkit.org/show_bug.cgi?id=90564

Patch by Mike West <mkwst@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:
* platform/wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Tools] webkit_unittest.py got assertion
yosin@chromium.org [Thu, 5 Jul 2012 03:48:03 +0000 (03:48 +0000)]
[Tools] webkit_unittest.py got assertion
https://bugs.webkit.org/show_bug.cgi?id=90579

Reviewed by Hajime Morita.

This patch updates expectation of assertion in test_skipped_directories_for_symbols().
r121874 added new (exclude) directory (inspector/styles/variables), however it didn't
update one of two assertions.

* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode
commit-queue@webkit.org [Thu, 5 Jul 2012 03:30:32 +0000 (03:30 +0000)]
AudioNode test should cover numberOfInputs and numberOfOutputs of AudioDestinationNode
https://bugs.webkit.org/show_bug.cgi?id=90578

Patch by Li Yin <li.yin@intel.com> on 2012-07-04
Reviewed by Chris Rogers.

Spec: http://www.w3.org/TR/webaudio/#AudioDestinationNode-section
An AudioSourceNode has no inputs and a single output.
An AudioDestinationNode has one input and no outputs.
Currently, the test webaudio/audionode.html has covered AudioSourceNode,
it is still required to cover AudioDestinationNode.

* webaudio/audionode-expected.txt:
* webaudio/audionode.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed Chromium gardening, drop test expectations for
yosin@chromium.org [Thu, 5 Jul 2012 01:54:50 +0000 (01:54 +0000)]
Unreviewed Chromium gardening, drop test expectations for
Chromium-Linux and Chromium-Win.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove inline keywords from functions which can not be inlined in ComposedShadowTreeW...
hayato@chromium.org [Thu, 5 Jul 2012 01:25:08 +0000 (01:25 +0000)]
Remove inline keywords from functions which can not be inlined in ComposedShadowTreeWalker
https://bugs.webkit.org/show_bug.cgi?id=90432

Reviewed by Hajime Morita.

No new tests - no functional changes.

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseParent):
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInspector crashes when trying to inspect a page with CSS variables
macpherson@chromium.org [Thu, 5 Jul 2012 00:15:54 +0000 (00:15 +0000)]
Inspector crashes when trying to inspect a page with CSS variables
https://bugs.webkit.org/show_bug.cgi?id=89818

Reviewed by Antti Koivisto.

Patch works by fixing treating handling of CSSPropertyID == CSSPropertyVariable as a special case,
and looking up the author-defined property name from the CSSValue.

Added test inspector/styles/variables/css-variables.html that inspects an element using CSS variables.
Test is skipped when variables are compiled out.

* css/CSSProperty.cpp:
(WebCore::CSSProperty::cssName):
(WebCore):
(WebCore::CSSProperty::cssText):
* css/CSSProperty.h:
(CSSProperty):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::item):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::asText):
* inspector/InspectorStyleSheet.cpp:
(WebCore::InspectorStyle::populateAllProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
commit-queue@webkit.org [Wed, 4 Jul 2012 22:41:17 +0000 (22:41 +0000)]
webkit-patch should add reviewer if "Reviewed by NOBODY ..." is missing
https://bugs.webkit.org/show_bug.cgi?id=67935

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-07-04
Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLog.set_reviewer):
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_set_reviewer):
(test_set_short_description_and_bug_url):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Implement device metrics for blackberry.
commit-queue@webkit.org [Wed, 4 Jul 2012 22:06:39 +0000 (22:06 +0000)]
[BlackBerry] Implement device metrics for blackberry.
https://bugs.webkit.org/show_bug.cgi?id=90494
RIM PR #159034

Patch by Hanna Ma <Hanma@rim.com> on 2012-07-04
Reviewed by Rob Buis.

Implement calls to the application to change the device metrics for
the web inspector.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::applySizeOverride):
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::setTextZoomFactor):
* Api/WebPage_p.h:
(WebPagePrivate):
* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::InspectorClientBlackBerry):
(WebCore::InspectorClientBlackBerry::canOverrideDeviceMetrics):
(WebCore):
(WebCore::InspectorClientBlackBerry::overrideDeviceMetrics):
(WebCore::InspectorClientBlackBerry::supportsFrameInstrumentation):
* WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector [JSC]: Implement ScriptCallStack::stackTrace
commit-queue@webkit.org [Wed, 4 Jul 2012 21:36:52 +0000 (21:36 +0000)]
Web Inspector [JSC]: Implement ScriptCallStack::stackTrace
https://bugs.webkit.org/show_bug.cgi?id=40118

Patch by Anthony Scian <ascian@rim.com> on 2012-07-04
Reviewed by Yong Li.

Source/JavaScriptCore:

Added member functions to expose function name, urlString, and line #.
Refactored toString to make use of these member functions to reduce
duplicated code for future maintenance.

Manually tested refactoring of toString by tracing thrown exceptions.

* interpreter/Interpreter.h:
(JSC::StackFrame::toString):
(JSC::StackFrame::friendlySourceURL):
(JSC::StackFrame::friendlyFunctionName):
(JSC::StackFrame::friendlyLineNumber):

Source/WebCore:

Implemented stub for createScriptCallStack to call into
Interpreter and extract the current stack frames, iterate
through the frames and create the return result required.

No new tests, manually tested thrown exception and inspector
tracebacks.

* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):

LayoutTests:

Updated test results now that createScriptCallStack is functional.

* http/tests/inspector/console-resource-errors-expected.txt:
* http/tests/inspector/console-xhr-logging-async-expected.txt:
* http/tests/inspector/console-xhr-logging-expected.txt:
* http/tests/inspector/network/script-as-text-loading-expected.txt:
* inspector/timeline/timeline-animation-frame-expected.txt:
* inspector/timeline/timeline-layout-expected.txt:
* inspector/timeline/timeline-mark-timeline-expected.txt:
* inspector/timeline/timeline-network-resource-expected.txt:
* inspector/timeline/timeline-paint-expected.txt:
* inspector/timeline/timeline-parse-html-expected.txt:
* inspector/timeline/timeline-time-stamp-expected.txt:
* inspector/timeline/timeline-timer-expected.txt:
* platform/chromium/http/tests/inspector/console-xhr-logging-async-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Respect memory needed for RenderSurfaces when reserving contents textures
danakj@chromium.org [Wed, 4 Jul 2012 20:50:54 +0000 (20:50 +0000)]
[chromium] Respect memory needed for RenderSurfaces when reserving contents textures
https://bugs.webkit.org/show_bug.cgi?id=89901

Reviewed by Adrienne Walker.

Source/WebCore:

Treat the memory allocation given to a tab as an allocation for its
contents and surfaces. Then only use up contents memory such that
the surface textures will still fit within the limit. Report histograms
for the amount of contents and surface texture memory used by each
frame generated by the main thread.

In the context of ubercomp, each nested compositor will use less memory
for contents ensuring that the root compositor has space for surfaces
caused by that nested compositor.

Since surface memory can no longer be taken by contents, we remove the
preferred memory limit from the texture manager.

Tests: TiledLayerChromiumTest.dontAllocateContentsWhenTargetSurfaceCantBeAllocated
       CCPrioritizedTextureTest.renderSurfacesReduceMemoryAvailableOutsideRootSurface
       CCPrioritizedTextureTest.renderSurfacesReduceMemoryAvailableForRequestLate
       CCPrioritizedTextureTest.whenRenderSurfaceNotAvailableTexturesAlsoNotAvailable

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawBackgroundFilters):
* platform/graphics/chromium/ScrollbarLayerChromium.cpp:
(WebCore::ScrollbarLayerChromium::setTexturePriorities):
* platform/graphics/chromium/TiledLayerChromium.cpp:
(WebCore::TiledLayerChromium::setTexturePrioritiesInRect):
* platform/graphics/chromium/TiledLayerChromium.h:
(TiledLayerChromium):
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::initializeLayerRenderer):
(WebCore::CCLayerTreeHost::updateLayers):
(WebCore::CCLayerTreeHost::prioritizeTextures):
(WebCore::CCLayerTreeHost::paintLayerContents):
* platform/graphics/chromium/cc/CCOverdrawMetrics.cpp:
(WebCore::CCOverdrawMetrics::CCOverdrawMetrics):
(WebCore::CCOverdrawMetrics::didUseContentsTextureMemoryBytes):
(WebCore):
(WebCore::CCOverdrawMetrics::didUseRenderSurfaceTextureMemoryBytes):
(WebCore::CCOverdrawMetrics::recordMetricsInternal):
* platform/graphics/chromium/cc/CCOverdrawMetrics.h:
(CCOverdrawMetrics):
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.cpp:
(WebCore::CCPrioritizedTextureManager::CCPrioritizedTextureManager):
(WebCore::CCPrioritizedTextureManager::prioritizeTextures):
(WebCore::CCPrioritizedTextureManager::requestLate):
(WebCore::CCPrioritizedTextureManager::acquireBackingTextureIfNeeded):
(WebCore::CCPrioritizedTextureManager::reduceMemory):
* platform/graphics/chromium/cc/CCPrioritizedTextureManager.h:
(WebCore::CCPrioritizedTextureManager::create):
(WebCore::CCPrioritizedTextureManager::memoryForRenderSurfacesBytes):
(CCPrioritizedTextureManager):
* platform/graphics/chromium/cc/CCPriorityCalculator.cpp:
(WebCore::CCPriorityCalculator::uiPriority):
(WebCore::CCPriorityCalculator::visiblePriority):
(WebCore):
(WebCore::CCPriorityCalculator::renderSurfacePriority):
(WebCore::CCPriorityCalculator::priorityFromDistance):
(WebCore::CCPriorityCalculator::priorityFromVisibility):
* platform/graphics/chromium/cc/CCPriorityCalculator.h:
(CCPriorityCalculator):

Source/WebKit/chromium:

* tests/CCPrioritizedTextureTest.cpp:
(WTF::CCPrioritizedTextureTest::createManager):
(WTF::TEST_F):
(WTF):
* tests/CCTiledLayerTestCommon.cpp:
(WebKitTests::FakeTiledLayerChromium::setTexturePriorities):
(WebKitTests):
* tests/CCTiledLayerTestCommon.h:
(FakeTiledLayerChromium):
* tests/TiledLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Enable parallel GC
wingo@igalia.com [Wed, 4 Jul 2012 20:32:26 +0000 (20:32 +0000)]
[GTK] Enable parallel GC
https://bugs.webkit.org/show_bug.cgi?id=90568

Reviewed by Martin Robinson.

Source/JavaScriptCore:

* runtime/Options.cpp: Include <algorithm.h> for std::min.

Source/WTF:

* wtf/Platform.h: Add GTK to the ENABLE_PARALLEL_GC party.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, skip another two http tests that
zandobersek@gmail.com [Wed, 4 Jul 2012 19:23:21 +0000 (19:23 +0000)]
Unreviewed GTK gardening, skip another two http tests that
timeout and just extend the complete build cycle.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r121862.
commit-queue@webkit.org [Wed, 4 Jul 2012 17:47:41 +0000 (17:47 +0000)]
Unreviewed, rolling out r121862.
http://trac.webkit.org/changeset/121862
https://bugs.webkit.org/show_bug.cgi?id=90569

It broke built-product-archive for GTK, Qt and EFL (Requested
by svillar on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-04

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: Add basic framework
commit-queue@webkit.org [Wed, 4 Jul 2012 17:43:12 +0000 (17:43 +0000)]
Text Autosizing: Add basic framework
https://bugs.webkit.org/show_bug.cgi?id=88655

This adds a highly simplified foundation that subsequent Text Autosizing patches
can build upon. I've refactored this code (since the earlier combined diff
uploaded to http://webkit.org/b/84186) to touch as few files as possible.

Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

No new tests. I plan to add a test framework as my next Text Autosizing patch.

* WebCore.gypi:
* dom/Document.cpp:
(WebCore::Document::Document):
* dom/Document.h:
(WebCore):
(Document):
(WebCore::Document::textAutosizer):
* page/FrameView.cpp:
(WebCore::FrameView::layout):
* rendering/TextAutosizer.cpp: Added.
(WebCore):
(WebCore::TextAutosizer::TextAutosizer):
(WebCore::TextAutosizer::~TextAutosizer):
(WebCore::TextAutosizer::create):
(WebCore::TextAutosizer::boostSubtree):
(WebCore::TextAutosizer::boostBlock):
(WebCore::TextAutosizer::boostText):
(WebCore::TextAutosizer::treatAsInline):
(WebCore::TextAutosizer::traverseNext):
(WebCore::TextAutosizer::cloneRenderStyleWithState):
* rendering/TextAutosizer.h: Added.
(WebCore):
(TextAutosizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r121767.
caseq@chromium.org [Wed, 4 Jul 2012 17:39:26 +0000 (17:39 +0000)]
Unreviewed, rolling out r121767.
http://trac.webkit.org/changeset/121767
https://bugs.webkit.org/show_bug.cgi?id=89584

Crashes inspected page while recording timeline due to
conflict with BeginFrame in record stack

Source/WebCore:

* inspector/InspectorTimelineAgent.cpp:
(WebCore::InspectorTimelineAgent::willSendResourceRequest):
(WebCore::InspectorTimelineAgent::willProcessTask):
(WebCore::InspectorTimelineAgent::didProcessTask):
(WebCore::InspectorTimelineAgent::innerAddRecordToTimeline):
(WebCore::InspectorTimelineAgent::setHeapSizeStatistic):
* inspector/InspectorTimelineAgent.h:
(InspectorTimelineAgent):
* inspector/front-end/MemoryStatistics.js:
(WebInspector.MemoryStatistics.prototype._onRecordAdded):
* inspector/front-end/TimelineFrameController.js:
(WebInspector.TimelineFrameController.prototype._addRecord):
* inspector/front-end/TimelineModel.js:
* inspector/front-end/TimelineOverviewPane.js:
(WebInspector.TimelineCategoryStrips.prototype.update.appendRecord):
(WebInspector.TimelineCategoryStrips.prototype.update):
* inspector/front-end/TimelinePanel.js:
(WebInspector.TimelinePanel.prototype._createStatusbarButtons):
(WebInspector.TimelinePanel.prototype._innerAddRecordToTimeline):
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel.categories):
(WebInspector.TimelinePresentationModel.recordStyle):
(WebInspector.TimelinePresentationModel.categoryForRecord):
(WebInspector.TimelinePresentationModel.forAllRecords):
(WebInspector.TimelinePresentationModel.prototype.addRecord):

LayoutTests:

* inspector/timeline-dfs-expected.txt: Removed.
* inspector/timeline-dfs.html: Removed.
* inspector/timeline/timeline-enum-stability-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Clear RenderSurfaces still when no idle paint will be done
danakj@chromium.org [Wed, 4 Jul 2012 17:27:20 +0000 (17:27 +0000)]
[chromium] Clear RenderSurfaces still when no idle paint will be done
https://bugs.webkit.org/show_bug.cgi?id=90553

Reviewed by Adrienne Walker.

Source/WebCore:

Currently if idle painting is disabled, updateLayers() will early-out.
But this prevents it from doing cleanup and clearing all RenderSurface
pointers, leaving the layer tree in an unexpected state.

Tests: CCLayerTreeHostTestCompositeAndReadbackCleanup

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateLayers):

Source/WebKit/chromium:

* tests/CCLayerTreeHostTest.cpp:
(CCLayerTreeHostTestCompositeAndReadbackCleanup):
(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::CCLayerTreeHostTestCompositeAndReadbackCleanup):
(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::beginTest):
(WTF::CCLayerTreeHostTestCompositeAndReadbackCleanup::afterTest):
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Remove CCLayerTreeHostTestThreadOnly class to cleanup CCLayerTreeHostTests
danakj@chromium.org [Wed, 4 Jul 2012 17:18:17 +0000 (17:18 +0000)]
[chromium] Remove CCLayerTreeHostTestThreadOnly class to cleanup CCLayerTreeHostTests
https://bugs.webkit.org/show_bug.cgi?id=90556

Reviewed by Adrienne Walker.

Currently many tests that run both single and threaded versions subclass
from CCLayerTreeHostTestThreadOnly just from copy/pasting. The class
only adds a runTestThreaded() which calls runTest(true). Many other
tests do run only in threaded mode call runTest(true) themselves, making
for an inconsistent mess.

We remove CCLayerTreeHostTestThreadOnly class, so we don't have tests
inheriting it that are not thread-only. And now all tests that are
thread-only call runTest(true) consistently.

* tests/CCLayerTreeHostTest.cpp:
(WTF::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHidden dirs are not copied when creating the built product archive
sergio@webkit.org [Wed, 4 Jul 2012 16:43:03 +0000 (16:43 +0000)]
Hidden dirs are not copied when creating the built product archive
https://bugs.webkit.org/show_bug.cgi?id=90559

Reviewed by Carlos Garcia Campos.

Hidden dirs are not copied inside the built product archive because
the recursive copy command was ignoring them. We need those hidden
directories for the GTK WebKit2 testing bot to work fine.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): removed the trailing "*" from the copy
command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoText Autosizing: Add compile flag and runtime setting
commit-queue@webkit.org [Wed, 4 Jul 2012 16:16:01 +0000 (16:16 +0000)]
Text Autosizing: Add compile flag and runtime setting
https://bugs.webkit.org/show_bug.cgi?id=87394

.:

This patch renames Font Boosting to Text Autosizing.

Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

* configure.ac:

Source/JavaScriptCore:

This patch renames Font Boosting to Text Autosizing.

Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

This patch renames Font Boosting to Text Autosizing and adds compile guards around the runtime setting.

Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

No functionality yet, so no new tests.

* Configurations/FeatureDefines.xcconfig:
* GNUmakefile.am:
* Target.pri:
* page/Settings.cpp:
(WebCore::Settings::Settings):
(WebCore::Settings::setTextAutosizingEnabled):
* page/Settings.h:
(Settings):
(WebCore::Settings::textAutosizingEnabled):

Source/WebKit/chromium:

This patch renames Font Boosting to Text Autosizing and adds compile guards around the runtime setting.

Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

* features.gypi:
* public/WebSettings.h:
* src/WebSettingsImpl.cpp:
(WebKit::WebSettingsImpl::setTextAutosizingEnabled):
* src/WebSettingsImpl.h:
(WebSettingsImpl):

Source/WebKit/mac:

This patch renames Font Boosting to Text Autosizing.

Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

This patch renames Font Boosting to Text Autosizing.

Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

* Configurations/FeatureDefines.xcconfig:

Tools:

This patch renames Font Boosting to Text Autosizing.

Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

This patch renames Font Boosting to Text Autosizing.

Patch by John Mellor <johnme@chromium.org> on 2012-07-04
Reviewed by Adam Barth.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Emulate pseudo styles (hover etc.) of non-selected elements
apavlov@chromium.org [Wed, 4 Jul 2012 16:10:45 +0000 (16:10 +0000)]
Web Inspector: Emulate pseudo styles (hover etc.) of non-selected elements
https://bugs.webkit.org/show_bug.cgi?id=86630

Reviewed by Pavel Feldman.

Source/WebCore:

- A map of pseudo-states for all bound DOM nodes is maintained in the backend and queried whenever StyleResolver
calculates the effective element style.
- In the frontend, markers are introduced to distinguish elements that have forced pseudo styles set for them.
Additionally, dimmed markers are added for collapsed nodes, whose descendants have forced pseudo styles.
More ElementDecorator subtypes will be added for other types of markers.

Test: inspector/styles/force-pseudo-state.html

* English.lproj/localizedStrings.js:
* inspector/InspectorCSSAgent.cpp:
(WebCore::InspectorCSSAgent::InspectorCSSAgent):
(WebCore::InspectorCSSAgent::clearFrontend):
(WebCore::InspectorCSSAgent::reset):
(WebCore::InspectorCSSAgent::forcePseudoState):
(WebCore::InspectorCSSAgent::recalcStyleForPseudoStateIfNeeded):
(WebCore::InspectorCSSAgent::elementForId):
(WebCore::InspectorCSSAgent::didRemoveDocument):
(WebCore::InspectorCSSAgent::didRemoveDOMNode):
(WebCore::InspectorCSSAgent::resetPseudoStates):
* inspector/InspectorCSSAgent.h:
(InspectorCSSAgent):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::didRemoveDOMNode):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.get this):
(WebInspector.ElementsPanel):
(WebInspector.ElementsPanel.prototype._setPseudoClassForNodeId):
* inspector/front-end/ElementsTreeOutline.js:
(WebInspector.ElementsTreeOutline):
(WebInspector.ElementsTreeOutline.prototype._createNodeDecorators):
(WebInspector.ElementsTreeOutline.prototype.updateOpenCloseTags):
(WebInspector.ElementsTreeOutline.ElementDecorator):
(WebInspector.ElementsTreeOutline.ElementDecorator.prototype.decorate):
(WebInspector.ElementsTreeOutline.ElementDecorator.prototype.decorateAncestor):
(WebInspector.ElementsTreeOutline.PseudoStateDecorator):
(WebInspector.ElementsTreeOutline.PseudoStateDecorator.prototype.decorate):
(WebInspector.ElementsTreeOutline.PseudoStateDecorator.prototype.decorateAncestor):
(WebInspector.ElementsTreeElement.prototype._populateTagContextMenu):
(WebInspector.ElementsTreeElement.prototype._populateForcedPseudoStateItems):
(WebInspector.ElementsTreeElement.prototype.updateTitle):
(WebInspector.ElementsTreeElement.prototype._createDecoratorElement):
(WebInspector.ElementsTreeElement.prototype._updateDecorations):
* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylesSidebarPane):
(WebInspector.StylesSidebarPane.prototype.get forcedPseudoClasses):
(WebInspector.StylesSidebarPane.prototype._updateForcedPseudoStateInputs):
(WebInspector.StylesSidebarPane.prototype.update):
(WebInspector.StylesSidebarPane.prototype._refreshUpdate):
(WebInspector.StylesSidebarPane.prototype._rebuildUpdate):
(WebInspector.StylesSidebarPane.prototype._toggleElementStatePane):
(WebInspector.StylesSidebarPane.prototype._createElementStatePane.clickListener):
* inspector/front-end/elementsPanel.css:
(#elements-content .elements-gutter-decoration):
(#elements-content .elements-gutter-decoration.elements-has-decorated-children):

LayoutTests:

* inspector/styles/force-pseudo-state-expected.txt: Added.
* inspector/styles/force-pseudo-state.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix search on the network panel.
pfeldman@chromium.org [Wed, 4 Jul 2012 15:36:28 +0000 (15:36 +0000)]
Web Inspector: fix search on the network panel.
https://bugs.webkit.org/show_bug.cgi?id=90557

Reviewed by Vsevolod Vlasov.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._highlightNthMatchedRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop tracking line number in tokenizer
kseo@webkit.org [Wed, 4 Jul 2012 15:31:53 +0000 (15:31 +0000)]
Stop tracking line number in tokenizer
https://bugs.webkit.org/show_bug.cgi?id=90544

Reviewed by Adam Barth.

Because SegmentedString knows how to track the current line and column,
a tokenizer does not need to keep track of the current line by itself.
No behavior change, so no new tests.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
(WebCore::HTMLDocumentParser::lineNumber):
(WebCore::HTMLDocumentParser::textPosition):
* html/parser/HTMLTokenizer.cpp:
(WebCore::HTMLTokenizer::reset):
(WebCore::HTMLTokenizer::flushBufferedEndTag):
(WebCore):
(WebCore::HTMLTokenizer::nextToken):
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processScriptStartTag):
* html/track/WebVTTTokenizer.cpp:
(WebCore::WebVTTTokenizer::reset):
(WebCore::WebVTTTokenizer::nextToken):
* platform/text/SegmentedString.cpp:
(WebCore::SegmentedString::advanceAndUpdateLineNumberSlowCase):
* platform/text/SegmentedString.h:
(WebCore::SegmentedString::advancePastNewlineAndUpdateLineNumber):
(WebCore::SegmentedString::advanceAndUpdateLineNumber):
(SegmentedString):
* xml/parser/MarkupTokenizerBase.h:
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::peek):
(WebCore::MarkupTokenizerBase::InputStreamPreprocessor::advance):
(WebCore::MarkupTokenizerBase::emitAndResumeIn):
(WebCore::MarkupTokenizerBase::emitEndOfFile):
(WebCore::MarkupTokenizerBase::reset):
(MarkupTokenizerBase):
* xml/parser/MarkupTokenizerInlineMethods.h:
(WebCore):
* xml/parser/XMLTokenizer.cpp:
(WebCore::XMLTokenizer::nextToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CMAKE] Add GENERATE_BINDINGS macro to share the codes which use generate-bindings.pl.
ryuan.choi@samsung.com [Wed, 4 Jul 2012 15:25:35 +0000 (15:25 +0000)]
[CMAKE] Add GENERATE_BINDINGS macro to share the codes which use generate-bindings.pl.
https://bugs.webkit.org/show_bug.cgi?id=90258

Reviewed by Rob Buis.

.:

This new macro calls generate-bindings.pl and append generated sources
into proper source list.

* Source/cmake/WebKitMacros.cmake:

Source/WebCore:

Use GENERATE_BINDINGS instead of using generate-bindings.pl directly.

* UseJSC.cmake:
* UseV8.cmake:
* PlatformBlackBerry.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Replace deprecated IN_PWD with PWD
vestbo@webkit.org [Wed, 4 Jul 2012 15:19:33 +0000 (15:19 +0000)]
[Qt] Replace deprecated IN_PWD with PWD

Reviewed by Csaba Osztrogonác.

* qmake/mkspecs/features/default_pre.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: UISourceCode should take care of adding revision after committing...
vsevik@chromium.org [Wed, 4 Jul 2012 15:14:01 +0000 (15:14 +0000)]
Web Inspector: UISourceCode should take care of adding revision after committing working copy.
https://bugs.webkit.org/show_bug.cgi?id=90549

Reviewed by Pavel Feldman.

Revision is now added in UISourceCode.commitWorkingCopy synchronously even if saving to JS VM or CSS model failed.

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding.prototype.setStyleContent):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype._callOrSetTimeout):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.commitWorkingCopy):
* inspector/front-end/Workspace.js:
(WebInspector.CompositeUISourceCodeProvider.prototype.uiSourceCodeForURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Don't try to build WTR twice
vestbo@webkit.org [Wed, 4 Jul 2012 15:13:24 +0000 (15:13 +0000)]
[Qt] Don't try to build WTR twice

Reviewed by Csaba Osztrogonác.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: move settings button back to the right.
pfeldman@chromium.org [Wed, 4 Jul 2012 15:06:41 +0000 (15:06 +0000)]
Web Inspector: move settings button back to the right.
https://bugs.webkit.org/show_bug.cgi?id=90552

Reviewed by Vsevolod Vlasov.

* inspector/front-end/inspector.css:
(button.status-bar-item:active, button.status-bar-item.emulate-active):
(button.settings-status-bar-item):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r121821.
commit-queue@webkit.org [Wed, 4 Jul 2012 14:59:39 +0000 (14:59 +0000)]
Unreviewed, rolling out r121821.
http://trac.webkit.org/changeset/121821
https://bugs.webkit.org/show_bug.cgi?id=90551

This patch did not receive a high-quality review and has a
number of errors (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-04

* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Build.results_url):
* Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
(ChromiumBuilder.accumulated_results_url):
* Scripts/webkitpy/layout_tests/port/builders.py:
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand.__init__):
(Rebaseline):
(Rebaseline._builder_to_pull_from):
(Rebaseline._tests_to_update):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline.mock_builder_to_pull_from):
(test_rebaseline):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Get rid of un-needed QT += declarative for Qt 5
vestbo@webkit.org [Wed, 4 Jul 2012 14:21:59 +0000 (14:21 +0000)]
[Qt] Get rid of un-needed QT += declarative for Qt 5

The declarative module has been renamed to quick1 in Qt 5, and the
engine-only module for Qt 5 is named 'qml'. For many of the instances
we could just remove 'declarative', since the project file was only
used for Qt5/WebKit2 builds. In the other cases the module was wrapped
in a haveQt(4) scope.

Reviewed by Csaba Osztrogonác.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Get rid of ResourceDomainModelBinding and DebuggerResourceBinding...
vsevik@chromium.org [Wed, 4 Jul 2012 14:07:43 +0000 (14:07 +0000)]
Web Inspector: Get rid of ResourceDomainModelBinding and DebuggerResourceBinding, make Resource.setContent private.
https://bugs.webkit.org/show_bug.cgi?id=90531

Reviewed by Pavel Feldman.

Resource.setContent made private. It is delegating now to UISourceCodes which take care of domain specific actions.
DebuggerResourceBinding was be removed and DebuggerResourceBinding.setScriptSource was moved to JavaScriptSource.
ResourceDomainModelBinding was removed as well.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModelResourceBinding):
* inspector/front-end/DebuggerResourceBinding.js: Removed.
* inspector/front-end/JavaScriptSource.js:
(WebInspector.JavaScriptSource.prototype.workingCopyCommitted):
(WebInspector.JavaScriptSource.prototype._setScriptSource.didEditScriptSource):
(WebInspector.JavaScriptSource.prototype._setScriptSource):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._setContent):
(WebInspector.Resource.prototype.revertToOriginal):
(WebInspector.Resource.prototype.revertAndClearHistory):
(WebInspector.ResourceRevision.prototype.revertToThis):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype.isEditable):
* inspector/front-end/UISourceCode.js:
* inspector/front-end/WebKit.qrc:
* inspector/front-end/Workspace.js:
(WebInspector.Workspace):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNot reviewed: follow up to r121843, reduce inspector dock timeout to 200ms.
pfeldman@chromium.org [Wed, 4 Jul 2012 13:55:10 +0000 (13:55 +0000)]
Not reviewed: follow up to r121843, reduce inspector dock timeout to 200ms.

* inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseDown):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove a few un-needed load(features) after r121777
vestbo@webkit.org [Wed, 4 Jul 2012 13:54:43 +0000 (13:54 +0000)]
[Qt] Remove a few un-needed load(features) after r121777

The features are computed by configure.pro and cached in .qmake.cache.

Reviewed by Jocelyn Turcotte.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Use haveQtModule() in project files instead of manual checks
vestbo@webkit.org [Wed, 4 Jul 2012 13:48:44 +0000 (13:48 +0000)]
[Qt] Use haveQtModule() in project files instead of manual checks

Reviewed by Jocelyn Turcotte.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix haveQtModule() check
vestbo@webkit.org [Wed, 4 Jul 2012 13:44:15 +0000 (13:44 +0000)]
[Qt] Fix haveQtModule() check

Without {} brackets we were pulling out the value of the module.name variable.

Reviewed by Jocelyn Turcotte.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix broken OR-operator in project file
vestbo@webkit.org [Wed, 4 Jul 2012 13:41:19 +0000 (13:41 +0000)]
[Qt] Fix broken OR-operator in project file

Qmake expects |, not ||. The result was that the block was entered, even
if none of the two defines were set to 1.

Reviewed by Jocelyn Turcotte.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Correctly reject accelerated animations with certain rotations.
vollick@chromium.org [Wed, 4 Jul 2012 12:57:58 +0000 (12:57 +0000)]
[chromium] Correctly reject accelerated animations with certain rotations.
https://bugs.webkit.org/show_bug.cgi?id=89768

Reviewed by James Robinson.

Source/WebCore:

UnitTests:
  GraphicsLayerChromiumTest.createTransformAnimationWithBigRotation
  GraphicsLayerChromiumTest.createTransformAnimationWithRotationInvolvingNegativeAngles
  GraphicsLayerChromiumTest.createTransformAnimationWithSmallRotationInvolvingLargeAngles

* platform/graphics/chromium/AnimationTranslationUtil.cpp:
(WebCore::appendKeyframe):
(WebCore::isRotationType):
(WebCore):
(WebCore::causesRotationOfAtLeast180Degrees):
(WebCore::CCKeyframedTransformAnimationCurve):
(WebCore::createActiveAnimation):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::addAnimation):

Source/WebKit/chromium:

* tests/GraphicsLayerChromiumTest.cpp:
(WebKitTests::TEST_F):
(WebKitTests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: "Dock to right" shouldn't be in the settings dialog
pfeldman@chromium.org [Wed, 4 Jul 2012 12:53:48 +0000 (12:53 +0000)]
Web Inspector: "Dock to right" shouldn't be in the settings dialog
https://bugs.webkit.org/show_bug.cgi?id=76917

Reviewed by Vsevolod Vlasov.

Introduced 'long click-enabled' options for status bar buttons. Made dock/undock one of them.

* inspector/front-end/Images/statusbarButtonGlyphs.png:
* inspector/front-end/StatusBarButton.js:
(WebInspector.StatusBarButton.prototype._clicked):
(WebInspector.StatusBarButton.prototype.set visible):
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseDown):
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled.mouseUp):
(WebInspector.StatusBarButton.prototype.makeLongClickEnabled):
(WebInspector.StatusBarButton.prototype._showOptions.mouseOver):
(WebInspector.StatusBarButton.prototype._showOptions.mouseOut):
(WebInspector.StatusBarButton.prototype._showOptions.mouseUp):
(WebInspector.StatusBarButton.prototype._showOptions):
* inspector/front-end/UIUtils.js:
(WebInspector.elementDragStart):
(WebInspector.elementDragEnd):
(WebInspector.GlassPane):
(WebInspector.GlassPane.prototype.dispose):
* inspector/front-end/inspector.css:
(.long-click-glyph):
(.long-click-glyph.shadow):
(button.status-bar-item:active:not(.emulate-inactive), button.status-bar-item.emulate-active):
(.alternate-status-bar-buttons-bar):
(.alternate-status-bar-buttons-bar .status-bar-item):
* inspector/front-end/inspector.js:
(WebInspector._createGlobalStatusBarItems):
(WebInspector._createDockOptions.onClick.set else):
(WebInspector._createDockOptions.onClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r121792): inspector/extensions/extensions-resources.html fails
vsevik@chromium.org [Wed, 4 Jul 2012 12:32:57 +0000 (12:32 +0000)]
REGRESSION(r121792): inspector/extensions/extensions-resources.html fails
https://bugs.webkit.org/show_bug.cgi?id=90530

Reviewed by Pavel Feldman.

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.disableDebugger):
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest.debuggerDisabled):
(initialize_DebuggerTest.InspectorTest.finishDebuggerTest):
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest.completeTest):
(initialize_DebuggerTest.InspectorTest.completeDebuggerTest):
* inspector/extensions/extensions-resources-expected.txt:
* inspector/extensions/extensions-resources.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening, updating baselines after r121789.
zandobersek@gmail.com [Wed, 4 Jul 2012 12:09:52 +0000 (12:09 +0000)]
Unreviewed GTK gardening, updating baselines after r121789.

* platform/gtk/TestExpectations:
* platform/gtk/css1/formatting_model/floating_elements-expected.png: Added.
* platform/gtk/css1/formatting_model/floating_elements-expected.txt:
* platform/gtk/fast/block/float/010-expected.png:
* platform/gtk/fast/block/float/010-expected.txt:
* platform/gtk/fast/block/float/independent-align-positioning-expected.png:
* platform/gtk/fast/block/float/independent-align-positioning-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
sergio@webkit.org [Wed, 4 Jul 2012 11:06:47 +0000 (11:06 +0000)]
[WK2] [GTK] WK2 testing bot unable to find the InjectedBundle library
https://bugs.webkit.org/show_bug.cgi?id=90541

Reviewed by Carlos Garcia Campos.

We must add the contents of WebKitBuild/*/Libraries/ directory to
the file to be uploaded to b.w.o to successfully run WebKit2 tests
in the WebKit2 testing bot.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct): appended Libraries to the list of
neededDirectories.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skip failing test.
kkristof@inf.u-szeged.hu [Wed, 4 Jul 2012 09:02:41 +0000 (09:02 +0000)]
[Qt] Unreviewed gardening. Skip failing test.
https://bugs.webkit.org/show_bug.cgi?id=90530

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-07-04

* platform/qt/Skipped: skip inspector/extensions/extensions-resources.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening. Removed some tests from TestExpectations
sergio@webkit.org [Wed, 4 Jul 2012 08:31:23 +0000 (08:31 +0000)]
Unreviewed GTK gardening. Removed some tests from TestExpectations
as they were passing in the tree bots.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] WebKit2 testing bot unable to find the build directory
sergio@webkit.org [Wed, 4 Jul 2012 08:05:18 +0000 (08:05 +0000)]
[GTK] WebKit2 testing bot unable to find the build directory
https://bugs.webkit.org/show_bug.cgi?id=90523

Reviewed by Carlos Garcia Campos.

The presence of GNUmakefile was used to determine whether a given
directory was a valid build directory or not. That's not correct for
testing bots as we export only the minimum required stuff to run the
tests.

* gtk/common.py:
(get_build_path.is_valid_build_directory): added an extra check.:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r121813.
commit-queue@webkit.org [Wed, 4 Jul 2012 07:53:20 +0000 (07:53 +0000)]
Unreviewed, rolling out r121813.
http://trac.webkit.org/changeset/121813
https://bugs.webkit.org/show_bug.cgi?id=90522

Causes browser_tests failure:
ErrorPageTest.DNSError_GoBack2{Forward2,AndForward} on
Chromium {Linux,Mac,Win} (Requested by yosin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-04

Source/WebCore:

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData):
(WebCore::DocumentLoader::setupForReplaceByMIMEType):
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject):

LayoutTests:

* http/tests/multipart/multipart-replace-non-html-content-expected.txt: Removed.
* http/tests/multipart/multipart-replace-non-html-content.php: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Ewk_View should report load errors
commit-queue@webkit.org [Wed, 4 Jul 2012 07:33:41 +0000 (07:33 +0000)]
[EFL][WK2] Ewk_View should report load errors
https://bugs.webkit.org/show_bug.cgi?id=90479

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-04
Reviewed by Kenneth Rohde Christiansen.

The Ewk_View now emits a "load,error" signal when the
main frame fails loading. Information about the error
is provided via the new Ewk_Web_Error type.

* PlatformEfl.cmake:
* UIProcess/API/efl/EWebKit2.h:
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_load_error):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didFailLoadWithErrorForFrame):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_private.h:
* UIProcess/API/efl/ewk_web_error.cpp: Added.
(_Ewk_Web_Error):
(ewk_web_error_free):
(ewk_web_error_domain_get):
(ewk_web_error_url_get):
(ewk_web_error_code_get):
(ewk_web_error_description_get):
(ewk_web_error_cancellation_get):
(ewk_web_error_new):
* UIProcess/API/efl/ewk_web_error.h: Added.
* UIProcess/API/efl/ewk_web_error_private.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdding myself to committers list.
joethomas@motorola.com [Wed, 4 Jul 2012 07:30:11 +0000 (07:30 +0000)]
Adding myself to committers list.

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Change format of return value of navigator.language
commit-queue@webkit.org [Wed, 4 Jul 2012 07:29:30 +0000 (07:29 +0000)]
[EFL] Change format of return value of navigator.language
https://bugs.webkit.org/show_bug.cgi?id=89639

Patch by Kihong Kwon <kihong.kwon@samsung.com> on 2012-07-04
Reviewed by Kenneth Rohde Christiansen.

Source/WebCore:

Remove encoding type from return value of navigator.language.
For example, from en-US.UTF-8 to en-US.

Use exist test case (fast/js/navigator-language.html).

* platform/efl/LanguageEfl.cpp:
(WebCore::platformLanguage):

LayoutTests:

* platform/efl/TestExpectations: Remove fast/js/navigator-language.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening for Mac
yosin@chromium.org [Wed, 4 Jul 2012 07:03:24 +0000 (07:03 +0000)]
[Chromium] Unreviewed gardening for Mac
https://bugs.webkit.org/show_bug.cgi?id=90430

* platform/chromium/TestExpectations: Add TIMEOUT to inspector/timeline/timeline-receive-response-event.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening for Win build
yosin@chromium.org [Wed, 4 Jul 2012 06:52:33 +0000 (06:52 +0000)]
[Chromium] Unreviewed gardening for Win build
https://bugs.webkit.org/show_bug.cgi?id=90517

* platform/chromium/TestExpectations: Add svg/W3C-I18N/tspan-dirRTL-ubNone-in-default-context.svg as flaky on Windows

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Ewk_View should report the load progress
commit-queue@webkit.org [Wed, 4 Jul 2012 06:34:49 +0000 (06:34 +0000)]
[WK2][EFL] Ewk_View should report the load progress
https://bugs.webkit.org/show_bug.cgi?id=90457

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.

Source/WebKit2:

The Ewk_View now reports the estimated load progress
of the page via the new "load,progress".
A method is also added to Ewk_View in order to
retrieve the current load progress.

* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_load_progress_get):
(ewk_view_load_progress_changed):
* UIProcess/API/efl/ewk_view.h:
* UIProcess/API/efl/ewk_view_loader_client.cpp:
(didChangeProgress):
(ewk_view_loader_client_attach):
* UIProcess/API/efl/ewk_view_private.h:

Tools:

Update EFL MiniBrowser so that it listens for the
"load,progress" on the Ewk_View and updates its
window title accordingly.

* MiniBrowser/efl/main.c:
(title_set):
(on_title_changed):
(on_progress):
(browserCreate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Don't show accel labels in context menu items
carlosgc@webkit.org [Wed, 4 Jul 2012 06:18:20 +0000 (06:18 +0000)]
[GTK] Don't show accel labels in context menu items
https://bugs.webkit.org/show_bug.cgi?id=90437

Reviewed by Martin Robinson.

When a context menu item is created with a GtkMenuItem that has
been created from a GtkAction, if the action has an accelerator,
it's shown in the menu item label, like menu items in a menu
bar. In that case we should reset the accel closure of the menu
item label, like GtkUIManager does for popup menus, to make sure
the accelerator is not shown. This isn't needed for all other
ContextMenuIem constructors, because the GtkAction is created
without accelerator by webkit in those cases.

* platform/gtk/ContextMenuItemGtk.cpp:
(WebCore::ContextMenuItem::ContextMenuItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Move BatteryClientEfl from WebKit to WebCore
commit-queue@webkit.org [Wed, 4 Jul 2012 05:49:44 +0000 (05:49 +0000)]
[EFL] Move BatteryClientEfl from WebKit to WebCore
https://bugs.webkit.org/show_bug.cgi?id=90063

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.

Move BatteryClientEfl class from WebKit to WebCore
so that it can be reused in WebKit2.

Source/WebCore:

No new tests, no behavior change.

* PlatformEfl.cmake:
* platform/efl/BatteryClientEfl.cpp: Renamed from Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.cpp.
(WebCore):
(WebCore::BatteryClientEfl::BatteryClientEfl):
(WebCore::BatteryClientEfl::setController):
(WebCore::BatteryClientEfl::startUpdating):
(WebCore::BatteryClientEfl::stopUpdating):
(WebCore::BatteryClientEfl::batteryControllerDestroyed):
(WebCore::BatteryClientEfl::setBatteryStatus):
(WebCore::BatteryClientEfl::timerFired):
(WebCore::BatteryClientEfl::getBatteryStatus):
(WebCore::BatteryClientEfl::setBatteryClient):
* platform/efl/BatteryClientEfl.h: Renamed from Source/WebKit/efl/WebCoreSupport/BatteryClientEfl.h.
(WebCore):
(BatteryClientEfl):
(WebCore::BatteryClientEfl::~BatteryClientEfl):
(WebCore::BatteryClientEfl::batteryStatus):

Source/WebKit:

* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a comment in order to clarify why
commit-queue@webkit.org [Wed, 4 Jul 2012 05:19:27 +0000 (05:19 +0000)]
Add a comment in order to clarify why
BitmapImage::frameHasAlphaAtIndex returns true as default.
https://bugs.webkit.org/show_bug.cgi?id=90445

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-03
Reviewed by Eric Seidel.

No new tests. This patch doesn't change behavior.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameHasAlphaAtIndex):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening for Win build
yosin@chromium.org [Wed, 4 Jul 2012 05:00:22 +0000 (05:00 +0000)]
[Chromium] Unreviewed gardening for Win build

* platform/chromium/TestExpectations: Add TEXT to http/tests/misc/last-modified-parsing.htl

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agodisable failing mock-chromium-mac python unit tests
dpranke@chromium.org [Wed, 4 Jul 2012 03:27:50 +0000 (03:27 +0000)]
disable failing mock-chromium-mac python unit tests

Unreviewed, build fix.

Disable these tests until I can figure out why they're failing
on the bots.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest.disabled_test_chromium_mac_lion):
(PortTest.disabled_test_chromium_mac_lion_in_test_shell_mode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Checkerboard shown when clicking on error page buttons
leo.yang@torchmobile.com.cn [Wed, 4 Jul 2012 02:59:30 +0000 (02:59 +0000)]
[BlackBerry] Checkerboard shown when clicking on error page buttons
https://bugs.webkit.org/show_bug.cgi?id=90152
RIM PR #161867

Reviewed by George Staikos.

r121514 just made the race occur in lower possibility but can't avoid it.
This path is using another approach to fix the problem. When we are resetting
backingstore while committing a page we need to suspend backingstore and
screen update to make sure no other threads can update backingstore and screen.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::resetTiles):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::setLoadState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Avoid calling getUniformLocation??() in the compositor startup
commit-queue@webkit.org [Wed, 4 Jul 2012 02:34:16 +0000 (02:34 +0000)]
[chromium] Avoid calling getUniformLocation??() in the compositor startup
https://bugs.webkit.org/show_bug.cgi?id=90217

Patch by Alex Sakhartchouk <alexst@chromium.org> on 2012-07-03
Reviewed by Adrienne Walker.

Source/Platform:

Adding an entry point for bindUniformLocationCHROMIUM.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):
(WebKit::WebGraphicsContext3D::bindUniformLocationCHROMIUM):

Source/WebCore:

This change allows chrome compositor to bind uniform locations instead of querying
them from the graphics context by using GL_CHROMIUM_bind_uniform_location.

The extention itself is tested in chromium and the change in webkit simply adds
plumbing to allow its usage. Existing pixel tests would be able to verify proper behaviour.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::LayerRendererChromium):
(WebCore::LayerRendererChromium::initialize):
(WebCore::LayerRendererChromium::initializeSharedObjects):
(WebCore::LayerRendererChromium::tileCheckerboardProgram):
(WebCore::LayerRendererChromium::solidColorProgram):
(WebCore::LayerRendererChromium::headsUpDisplayProgram):
(WebCore::LayerRendererChromium::renderPassProgram):
(WebCore::LayerRendererChromium::renderPassProgramAA):
(WebCore::LayerRendererChromium::renderPassMaskProgram):
(WebCore::LayerRendererChromium::renderPassMaskProgramAA):
(WebCore::LayerRendererChromium::tileProgram):
(WebCore::LayerRendererChromium::tileProgramOpaque):
(WebCore::LayerRendererChromium::tileProgramAA):
(WebCore::LayerRendererChromium::tileProgramSwizzle):
(WebCore::LayerRendererChromium::tileProgramSwizzleOpaque):
(WebCore::LayerRendererChromium::tileProgramSwizzleAA):
(WebCore::LayerRendererChromium::textureProgram):
(WebCore::LayerRendererChromium::textureProgramFlip):
(WebCore::LayerRendererChromium::textureIOSurfaceProgram):
(WebCore::LayerRendererChromium::videoYUVProgram):
(WebCore::LayerRendererChromium::videoStreamTextureProgram):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/ProgramBinding.cpp:
(WebCore::ProgramBindingBase::ProgramBindingBase):
(WebCore::ProgramBindingBase::~ProgramBindingBase):
(WebCore::ProgramBindingBase::init):
(WebCore::ProgramBindingBase::link):
(WebCore):
(WebCore::ProgramBindingBase::cleanup):
(WebCore::ProgramBindingBase::createShaderProgram):
(WebCore::ProgramBindingBase::cleanupShaders):
* platform/graphics/chromium/ProgramBinding.h:
(ProgramBindingBase):
(WebCore::ProgramBinding::initialize):
* platform/graphics/chromium/ShaderChromium.cpp:
(WebCore::VertexShaderPosTex::init):
(WebCore::VertexShaderPosTexYUVStretch::init):
(WebCore::VertexShaderPos::init):
(WebCore::VertexShaderPosTexTransform::init):
(WebCore::VertexShaderQuad::init):
(WebCore::VertexShaderTile::init):
(WebCore::VertexShaderVideoTransform::init):
(WebCore::FragmentTexAlphaBinding::init):
(WebCore::FragmentTexOpaqueBinding::init):
(WebCore::FragmentShaderOESImageExternal::init):
(WebCore::FragmentShaderRGBATexAlphaAA::init):
(WebCore::FragmentTexClampAlphaAABinding::init):
(WebCore::FragmentShaderRGBATexAlphaMask::init):
(WebCore::FragmentShaderRGBATexAlphaMaskAA::init):
(WebCore::FragmentShaderYUVVideo::init):
(WebCore::FragmentShaderColor::init):
(WebCore::FragmentShaderCheckerboard::init):
* platform/graphics/chromium/ShaderChromium.h:
(VertexShaderPosTex):
(VertexShaderPosTexYUVStretch):
(VertexShaderPos):
(WebCore::VertexShaderPosTexIdentity::init):
(VertexShaderPosTexTransform):
(VertexShaderQuad):
(VertexShaderTile):
(VertexShaderVideoTransform):
(FragmentTexAlphaBinding):
(FragmentTexOpaqueBinding):
(FragmentShaderOESImageExternal):
(FragmentShaderRGBATexAlphaAA):
(FragmentTexClampAlphaAABinding):
(FragmentShaderRGBATexAlphaMask):
(FragmentShaderRGBATexAlphaMaskAA):
(FragmentShaderYUVVideo):
(FragmentShaderColor):
(FragmentShaderCheckerboard):
* platform/graphics/chromium/TextureCopier.cpp:
(WebCore::AcceleratedTextureCopier::AcceleratedTextureCopier):
(WebCore::AcceleratedTextureCopier::copyTexture):
* platform/graphics/chromium/TextureCopier.h:
(WebCore::AcceleratedTextureCopier::create):
(AcceleratedTextureCopier):

Source/WebKit/chromium:

Fixing the build error.

* tests/TextureCopierTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd vollick to the list of committers
vollick@chromium.org [Wed, 4 Jul 2012 02:23:15 +0000 (02:23 +0000)]
Add vollick to the list of committers
https://bugs.webkit.org/show_bug.cgi?id=90512

Reviewed by Adrienne Walker.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImprove webkit-patch rebaseline to work for more cases
ojan@chromium.org [Wed, 4 Jul 2012 02:13:13 +0000 (02:13 +0000)]
Improve webkit-patch rebaseline to work for more cases
https://bugs.webkit.org/show_bug.cgi?id=90504

Reviewed by Dirk Pranke.

-Makes it work for the build.chromium.org bots.
-Lets you rebaseline all builders instead of just one.
-Lets you pass in the builder or test to rebaseline.

* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(Build.results_url):
Make this work for build.chromium.org builders as well.

* Scripts/webkitpy/common/net/buildbot/chromiumbuildbot.py:
(ChromiumBuilder):
(ChromiumBuilder.latest_cached_build):
ChromiumBuilder doesn't support large parts of the Builder interface.
This provides the bare minimum for this patch to work. Eventually,
we should create a single interface that can be supported for both
sets of buildbots.

* Scripts/webkitpy/layout_tests/port/builders.py:
(builder_path_from_name):
(all_builder_names):
memoizing here is incorrect because the test override _exact_matches,
so these can return different values. In either case, I'm pretty sure these
are not remotely hot codepaths.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand.__init__):
(Rebaseline):
(Rebaseline.__init__):
(Rebaseline._builders_to_pull_from):
(Rebaseline._builder_with_name):
(Rebaseline._tests_to_update):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline.mock_builders_to_pull_from):
(test_rebaseline):
(test_rebaseline_command_line_flags):
(test_rebaseline_multiple_builders):
(test_rebaseline_multiple_builders.mock_builders_to_pull_from):
(test_rebaseline_multiple_builders.mock_tests_to_update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Rebaseline: svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml
yosin@chromium.org [Wed, 4 Jul 2012 02:05:49 +0000 (02:05 +0000)]
[Chromium] Rebaseline: svg/custom/pattern-userSpaceOnUse-userToBaseTransform.xhtml

* platform/chromium-win/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable CSS variables support at compile time
commit-queue@webkit.org [Wed, 4 Jul 2012 01:56:08 +0000 (01:56 +0000)]
[EFL] Enable CSS variables support at compile time
https://bugs.webkit.org/show_bug.cgi?id=90448

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Kenneth Rohde Christiansen.

Turn on CSS_VARIABLES flag by default on EFL port.

.:

* Source/cmake/OptionsEfl.cmake:
* Source/cmakeconfig.h.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Remove enableFasterDOMStoreAccess which is never used
arv@chromium.org [Wed, 4 Jul 2012 00:47:01 +0000 (00:47 +0000)]
[V8] Remove enableFasterDOMStoreAccess which is never used
https://bugs.webkit.org/show_bug.cgi?id=90489

Reviewed by Adam Barth.

Source/WebCore:

No new tests. Dead code removal.

* bindings/v8/V8DOMMap.cpp:
* bindings/v8/V8DOMMap.h:
(WebCore):

Source/WebKit/chromium:

* src/WebScriptController.cpp:
(WebKit::WebScriptController::enableV8SingleThreadMode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBinding: IDL type DOMString[] shouldn't match null
jsbell@chromium.org [Wed, 4 Jul 2012 00:23:35 +0000 (00:23 +0000)]
Binding: IDL type DOMString[] shouldn't match null
https://bugs.webkit.org/show_bug.cgi?id=84217

Reviewed by Kentaro Hara.

Similar to r121714, IDL overloads with T[] (which is only minimally supported)
were being treated as Nullable by default during overloaded method dispatching,
which deviates from the WebIDL specification. Extend the previous change to
look for Nullable (specified by "?" type suffix in the IDL) for array types.

Also, after inspection of the spec, use a strict "is this an Array?" test in
the JS generator rather than an "inherits from Array.prototype?" test, to
match the WebIDL spec.

IDL files with affected overloads are modified to include the "?" suffix
so that no behavior changes are introduced by this patch - the JS and V8
generator results before/after the change show no diffs apart from the stricter
isJSArray() test.

Test: bindings/scripts/test/TestObj.idl (a non-Nullable T[] overload)

* Modules/indexeddb/IDBDatabase.idl: Tag T[] overloads with ? suffix.
* Modules/indexeddb/IDBObjectStore.idl: Ditto.
* Modules/vibration/NavigatorVibration.idl: Ditto.
* bindings/scripts/CodeGeneratorJS.pm: Check isNullable for T[].
(GenerateParametersCheckExpression):
* bindings/scripts/CodeGeneratorV8.pm: Ditto.
(GenerateParametersCheckExpression):
* bindings/scripts/test/JS/JSTestObj.cpp: Rebaselined.
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod9):
(WebCore):
(WebCore::jsTestObjPrototypeFunctionOverloadedMethod):
* bindings/scripts/test/TestObj.idl: Tag existing T[] with ?, add non-? T[].
* bindings/scripts/test/V8/V8TestObj.cpp: Rebaselined.
(WebCore::TestObjV8Internal::overloadedMethod9Callback):
(TestObjV8Internal):
(WebCore::TestObjV8Internal::overloadedMethodCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: clean up exception handling and make sure we log some more failures
dpranke@chromium.org [Wed, 4 Jul 2012 00:14:25 +0000 (00:14 +0000)]
nrwt: clean up exception handling and make sure we log some more failures
https://bugs.webkit.org/show_bug.cgi?id=90503

Reviewed by Ojan Vafai.

There were several places where exceptions weren't getting
logged, most notably if you passed a bad value to --platform.
This change tests that and cleans things up a bit; more cleanup
will be possible when we rework the manager_worker_broker code.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(_BrokerConnection.raise_exception):
(_InlineWorkerConnection.raise_exception):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.run):
(Worker.kill_driver):
* Scripts/webkitpy/layout_tests/port/factory.py:
(PortFactory.get):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(run):
(main):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_unsupported_platfrom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoParameter 'id' is not used in getUserModifyProperty() of fast/dom/shadow/user-modify...
hayato@chromium.org [Wed, 4 Jul 2012 00:03:17 +0000 (00:03 +0000)]
Parameter 'id' is not used in getUserModifyProperty() of fast/dom/shadow/user-modify-inheritance.html.
https://bugs.webkit.org/show_bug.cgi?id=90434

Reviewed by Ryosuke Niwa.

* fast/dom/shadow/user-modify-inheritance.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoeventSender.beginDragWithFiles had been implemented in Windows, related tests should...
commit-queue@webkit.org [Wed, 4 Jul 2012 00:01:24 +0000 (00:01 +0000)]
eventSender.beginDragWithFiles had been implemented in Windows, related tests should be removed from Skipped.
https://bugs.webkit.org/show_bug.cgi?id=87610

Patch by Xueqing Huang <huangxueqing@baidu.com> on 2012-07-03
Reviewed by Jessie Berlin.

* platform/win/Skipped:
* platform/win/fast/dom/Window: Removed.
* platform/win/fast/dom/Window/window-postmessage-clone-frames-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: REGRESSION (r115654): Sometimes does not replace content for multipar...
japhet@chromium.org [Tue, 3 Jul 2012 23:54:03 +0000 (23:54 +0000)]
Source/WebCore: REGRESSION (r115654): Sometimes does not replace content for multipart/x-mixed-replace
https://bugs.webkit.org/show_bug.cgi?id=88436

Reviewed by Brady Eidson.

Test: http/tests/multipart/multipart-replace-non-html-content.php

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::commitData): We should only send receivedFirstData() once per main resource load,
    rather than multiple times in a multipart load.
(WebCore::DocumentLoader::setupForReplaceByMIMEType): m_gotFirstByte isn't set to true until data is
    actually committed, and multipart data is often not committed until the part is finished. Check
    whether the SharedBuffer is non-null instead.
* testing/js/WebCoreTestSupport.cpp:
(WebCoreTestSupport::resetInternalsObject): The JSInternals object my have already been cleared if the window shell
    was cleared as part of creation of a new Document. Check it before using it.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=88436.

Reviewed by Brady Eidson.

* http/tests/multipart/multipart-replace-non-html-content-expected.txt: Added.
* http/tests/multipart/multipart-replace-non-html-content.php: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: fix mock port
dpranke@chromium.org [Tue, 3 Jul 2012 23:53:26 +0000 (23:53 +0000)]
nrwt: fix mock port
https://bugs.webkit.org/show_bug.cgi?id=90500

Reviewed by Ojan Vafai.

The MockDRT code was never updated when we switched the chromium
ports to using "drt mode" by default. This change updates that
code, fixes a typo in the chromium port that went undetected
(default_test_timeout_ms -> default_timeout_ms), and adds tests
that actually exercise some of the mock ports. These tests are
useful in that they will exercise the port-specific code in an
end-to-end-manner, but they are a bit slow for some reason (>1s
each) that I need to look into.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.stop):
* Scripts/webkitpy/layout_tests/port/chromium_android.py:
(ChromiumAndroidPort.default_timeout_ms):
* Scripts/webkitpy/layout_tests/port/chromium_android_unittest.py:
(TestChromiumAndroidPort.test_default_timeout_ms):
* Scripts/webkitpy/layout_tests/port/mock_drt.py:
(main):
(parse_options):
(MockTestShell):
(MockTestShell.output_for_test):
* Scripts/webkitpy/layout_tests/port/mock_drt_unittest.py:
(MockDRTTest.assertTest):
(MockTestShellTest):
(MockTestShellTest.make_drt):
(MockTestShellTest.test_test_shell_parse_options):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(PortTest):
(PortTest.assert_mock_port_works):
(PortTest.test_chromium_mac_lion):
(PortTest.test_chromium_mac_lion_in_test_shell_mode):
(PortTest.test_qt_linux):
(PortTest.test_mac_lion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd AudioFIFO class and simplify AudioPullFIFO
commit-queue@webkit.org [Tue, 3 Jul 2012 23:40:50 +0000 (23:40 +0000)]
Add AudioFIFO class and simplify AudioPullFIFO
https://bugs.webkit.org/show_bug.cgi?id=90398

Patch by Raymond Toy <rtoy@google.com> on 2012-07-03
Reviewed by Chris Rogers.

No new tests. This code will be used in audio back-end implementation.

Add AudioFIFO class to implement main parts of FIFO.  Simplify
implementation of AudioPushFIFO by using AudioFIFO.

* WebCore.gypi: Add new files.

New AudioFIFO class
* platform/audio/AudioFIFO.cpp: Copied from Source/WebCore/platform/audio/AudioPullFIFO.cpp.
(WebCore):
(WebCore::AudioFIFO::AudioFIFO):
(WebCore::AudioFIFO::consume):
(WebCore::AudioFIFO::push):
(WebCore::AudioFIFO::findWrapLengths):
* platform/audio/AudioFIFO.h: Copied from Source/WebCore/platform/audio/AudioPullFIFO.h.
(WebCore):
(AudioFIFO):
(WebCore::AudioFIFO::framesInFifo):
(WebCore::AudioFIFO::updateIndex):

Use AudioFIFO
* platform/audio/AudioPullFIFO.cpp:
(WebCore::AudioPullFIFO::AudioPullFIFO):
(WebCore::AudioPullFIFO::consume):
(WebCore::AudioPullFIFO::fillBuffer):
* platform/audio/AudioPullFIFO.h:
(AudioPullFIFO):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: make the worker class stand alone with a cleaner interface
dpranke@chromium.org [Tue, 3 Jul 2012 23:31:57 +0000 (23:31 +0000)]
nrwt: make the worker class stand alone with a cleaner interface
https://bugs.webkit.org/show_bug.cgi?id=90409

Reviewed by Ojan Vafai.

Currently the Worker class derives from AbstractWorker, which is
kind of crufty and awkward; it would be better if we did not
rely on shared state.

This change changes that so that Worker derives from object, and
exposes the following interface:
  __init__() - called in the manager process
  safe_init() - called in the worker process to initialize
    unpicklable state
  handle() - a single routine to handle all messages
  cleanup() - called so the worker can clean up

Also, all of the "administrative" messages that are handled by
the worker (notification of start/stop/etc.) move into
manager_worker_broker - this reduces worker.py to just handling
the mechanics of actually running each test.

For the moment, we do this by creating Yet Another wrapper/proxy
class in manager_worker_broker, but this will get simpler
shortly when the rest of m_w_b is cleaned up.

With this change worker is now in its new form but there will be
a follow-on change that cleans up some names and other minor
things.

This change is again mostly just moving things around and should
be covered by the (updated) existing tests.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(get):
(AbstractWorker.__init__):
(AbstractWorker.run):
(AbstractWorker):
(AbstractWorker.handle_stop):
(AbstractWorker.handle_test_list):
(AbstractWorker.yield_to_broker):
(AbstractWorker.post_message):
(_WorkerConnection.__init__):
(_Process.run):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker):
(_TestWorker.__init__):
(_TestWorker.name):
(_TestWorker.cleanup):
(_TestWorker.handle):
(_TestWorker.safe_init):
(_TestWorker.stop):
(_TestsMixin.handle_finished_test):
(_TestsMixin.setUp):
(_TestsMixin.test_cancel):
(_TestsMixin.test_done):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker):
(Worker.__init__):
(Worker.safe_init):
(Worker.handle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2] Add support for Battery Status API
commit-queue@webkit.org [Tue, 3 Jul 2012 23:31:49 +0000 (23:31 +0000)]
[WK2] Add support for Battery Status API
https://bugs.webkit.org/show_bug.cgi?id=89558

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-07-03
Reviewed by Anders Carlsson.

Add support for Battery Status API to WebKit2.

* CMakeLists.txt:
* DerivedSources.pri:
* GNUmakefile.am:
* GNUmakefile.list.am:
* Platform/CoreIPC/MessageID.h:
* Shared/API/c/WKBase.h:
* Shared/APIObject.h:
* Shared/WebBatteryStatus.cpp: Added.
(WebKit):
(WebKit::WebBatteryStatus::WebBatteryStatus):
(WebKit::WebBatteryStatus::~WebBatteryStatus):
(WebKit::WebBatteryStatus::Data::encode):
(WebKit::WebBatteryStatus::Data::decode):
* Shared/WebBatteryStatus.h: Added.
(WebKit):
(WebBatteryStatus):
(Data):
(WebKit::WebBatteryStatus::create):
(WebKit::WebBatteryStatus::isCharging):
(WebKit::WebBatteryStatus::chargingTime):
(WebKit::WebBatteryStatus::dischargingTime):
(WebKit::WebBatteryStatus::level):
(WebKit::WebBatteryStatus::data):
(WebKit::WebBatteryStatus::type):
* Target.pri:
* UIProcess/API/C/WKAPICast.h:
(WebKit):
* UIProcess/API/C/WKBatteryManager.cpp: Added.
(WKBatteryManagerGetTypeID):
* UIProcess/API/C/WKBatteryManager.h: Added.
* UIProcess/WebBatteryManagerProxy.cpp: Added.
(WebKit):
(WebKit::WebBatteryManagerProxy::create):
(WebKit::WebBatteryManagerProxy::WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::~WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::invalidate):
(WebKit::WebBatteryManagerProxy::initializeProvider):
(WebKit::WebBatteryManagerProxy::didReceiveMessage):
(WebKit::WebBatteryManagerProxy::startUpdating):
(WebKit::WebBatteryManagerProxy::stopUpdating):
(WebKit::WebBatteryManagerProxy::providerDidChangeBatteryStatus):
(WebKit::WebBatteryManagerProxy::providerUpdateBatteryStatus):
* UIProcess/WebBatteryManagerProxy.h: Added.
(CoreIPC):
(WebKit):
(WebBatteryManagerProxy):
(WebKit::WebBatteryManagerProxy::clearContext):
(WebKit::WebBatteryManagerProxy::type):
* UIProcess/WebBatteryManagerProxy.messages.in: Added.
* UIProcess/WebBatteryProvider.cpp: Added.
(WebKit):
(WebKit::WebBatteryProvider::startUpdating):
(WebKit::WebBatteryProvider::stopUpdating):
* UIProcess/WebBatteryProvider.h: Added.
(WebKit):
(WebBatteryProvider):
* WebKit2.pri:
* WebProcess/Battery/WebBatteryManager.cpp: Added.
(WebKit):
(WebKit::WebBatteryManager::WebBatteryManager):
(WebKit::WebBatteryManager::~WebBatteryManager):
(WebKit::WebBatteryManager::didReceiveMessage):
(WebKit::WebBatteryManager::registerWebPage):
(WebKit::WebBatteryManager::unregisterWebPage):
(WebKit::WebBatteryManager::didChangeBatteryStatus):
(WebKit::WebBatteryManager::updateBatteryStatus):
* WebProcess/Battery/WebBatteryManager.h: Added.
(CoreIPC):
(WebKit):
(WebBatteryManager):
* WebProcess/Battery/WebBatteryManager.messages.in: Added.
* WebProcess/WebCoreSupport/WebBatteryClient.cpp: Added.
(WebKit):
(WebKit::WebBatteryClient::startUpdating):
(WebKit::WebBatteryClient::stopUpdating):
(WebKit::WebBatteryClient::batteryControllerDestroyed):
* WebProcess/WebCoreSupport/WebBatteryClient.h: Added.
(WebKit):
(WebBatteryClient):
(WebKit::WebBatteryClient::WebBatteryClient):
(WebKit::WebBatteryClient::~WebBatteryClient):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::didReceiveMessage):
* WebProcess/WebProcess.h:
(WebProcess):
(WebKit::WebProcess::batteryManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agonrwt: moving child process logging code into manager_worker_broker
dpranke@chromium.org [Tue, 3 Jul 2012 23:11:18 +0000 (23:11 +0000)]
nrwt: moving child process logging code into manager_worker_broker
https://bugs.webkit.org/show_bug.cgi?id=90408

Reviewed by Ojan Vafai.

Users of manager_worker_broker should not have to be aware of
whether they're in the same process or different processes and
configure logging themselves; mwb should hide this complexity.
We can't quite do this completely/correctly yet, since the
manager expects to get a list of messages to log, but this
change fixes the worker side of it, at least.

This is just moving code around, there is no new functionality
and this should be covered by existing tests.

* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker.py:
(AbstractWorker.__init__):
(_WorkerConnection.__init__):
(_WorkerConnection.post_message):
(_WorkerConnection):
(_WorkerConnection.set_up_logging):
(_WorkerConnection.clean_up_logging):
(_InlineWorkerConnection.run):
(_MultiProcessWorkerConnection.run):
(_WorkerLogHandler):
(_WorkerLogHandler.__init__):
(_WorkerLogHandler.emit):
* Scripts/webkitpy/layout_tests/controllers/manager_worker_broker_unittest.py:
(_TestWorker.run):
(_TestsMixin.handle_done):
* Scripts/webkitpy/layout_tests/controllers/worker.py:
(Worker.__init__):
(Worker.run):
(Worker._run_test):
(Worker.cleanup):
(Worker.run_single_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnh: Hash Const JSString in Backing Stores to Save Memory
msaboff@apple.com [Tue, 3 Jul 2012 22:57:00 +0000 (22:57 +0000)]
Enh: Hash Const JSString in Backing Stores to Save Memory
https://bugs.webkit.org/show_bug.cgi?id=86024

Reviewed by Oliver Hunt.

During garbage collection, each marking thread keeps a HashMap of
strings.  While visiting via MarkStack::copyAndAppend(), we check to
see if the string we are visiting is already in the HashMap.  If not
we add it. If so, we change the reference to the current string we're
visiting to the prior string.

To reduce the performance impact of this change, two throttles have
ben added.  1) We only try hash consting if a significant number of new
strings have been created since the last hash const.  Currently this is
set at 100 strings.  2) If a string is unique at the end of a marking
it will not be checked during further GC phases. In some cases this
won't catch all duplicates, but we are trying to catch the growth of
duplicate strings.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
* heap/MarkStack.cpp:
(JSC::MarkStackThreadSharedData::resetChildren):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::MarkStackThreadSharedData::reset):
(JSC::MarkStack::setup): Check to see if enough strings have been created
to hash const.
(JSC::MarkStack::reset): Added call to clear m_uniqueStrings.
(JSC::JSString::tryHashConstLock): New method to lock JSString for
hash consting.
(JSC::JSString::releaseHashConstLock): New unlock method.
(JSC::JSString::shouldTryHashConst): Set of checks to see if we should
try to hash const the string.
(JSC::MarkStack::internalAppend): New method that performs the hash consting.
(JSC::SlotVisitor::copyAndAppend): Changed to call the new hash
consting internalAppend().
* heap/MarkStack.h:
(MarkStackThreadSharedData):
(MarkStack):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
* runtime/JSGlobalData.h:
(JSGlobalData):
(JSC::JSGlobalData::haveEnoughNewStringsToHashConst):
(JSC::JSGlobalData::resetNewStringsSinceLastHashConst):
* runtime/JSString.h:
(JSString): Changed from using bool flags to using an unsigned
m_flags field.  This works better with the weakCompareAndSwap in
JSString::tryHashConstLock(). Changed the 8bitness setting and
checking to use new accessors.
(JSC::JSString::JSString):
(JSC::JSString::finishCreation):
(JSC::JSString::is8Bit): Updated for new m_flags.
(JSC::JSString::setIs8Bit): New setter.
New hash const flags accessors:
(JSC::JSString::isHashConstSingleton):
(JSC::JSString::clearHashConstSingleton):
(JSC::JSString::setHashConstSingleton):
(JSC::JSRopeString::finishCreation):
(JSC::JSRopeString::append):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed chromium mac rebaselines.
eae@chromium.org [Tue, 3 Jul 2012 21:56:05 +0000 (21:56 +0000)]
Unreviewed chromium mac rebaselines.

* platform/chromium-mac-snowleopard/css1/formatting_model/floating_elements-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/float/010-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/010-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/block/float/independent-align-positioning-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/independent-align-positioning-expected.txt: Added.
* platform/chromium-mac/fast/block/float/010-expected.png:
* platform/chromium-mac/fast/block/float/010-expected.txt: Added.
* platform/chromium-mac/fast/block/float/independent-align-positioning-expected.png:
* platform/chromium-mac/fast/block/float/independent-align-positioning-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Turn on DFGJIT in Platform.h
commit-queue@webkit.org [Tue, 3 Jul 2012 21:44:07 +0000 (21:44 +0000)]
[BlackBerry] Turn on DFGJIT in Platform.h
https://bugs.webkit.org/show_bug.cgi?id=90482

Set ENABLE_DFG_JIT for PLATFORM(BLACKBERRY).

Patch by Yong Li <yoli@rim.com> on 2012-07-03
Reviewed by Rob Buis.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProtect this DocumentThreadableLoader in cancel() to handle reentrancy properly.
japhet@chromium.org [Tue, 3 Jul 2012 21:37:28 +0000 (21:37 +0000)]
Protect this DocumentThreadableLoader in cancel() to handle reentrancy properly.
https://bugs.webkit.org/show_bug.cgi?id=90483

Reviewed by Abhishek Arya.

No new tests, covered by http/tests/xmlhttprequest/reentrant-cancel.html

* loader/DocumentThreadableLoader.cpp:
(WebCore::DocumentThreadableLoader::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Don't archive build files generated by VS2010
tony@chromium.org [Tue, 3 Jul 2012 21:02:29 +0000 (21:02 +0000)]
[chromium] Don't archive build files generated by VS2010
https://bugs.webkit.org/show_bug.cgi?id=90493

Reviewed by Ojan Vafai.

In particular, the pch (pre compiled header) files are gigantic, making
release.zip almost a 1gb in size.

* BuildSlaveSupport/built-product-archive:
(archiveBuiltProduct):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed, update .gitignore to handle VS2010 files.
tony@chromium.org [Tue, 3 Jul 2012 20:26:08 +0000 (20:26 +0000)]
[chromium] Unreviewed, update .gitignore to handle VS2010 files.

Source/JavaScriptCore:

* JavaScriptCore.gyp/.gitignore:

Source/Platform:

* Platform.gyp/.gitignore:

Source/ThirdParty:

* glu/.gitignore:

Source/WebCore:

* WebCore.gyp/.gitignore:

Source/WebKit/chromium:

* .gitignore:

Source/WTF:

* WTF.gyp/.gitignore:

Tools:

* .gitignore:
* DumpRenderTree/DumpRenderTree.gyp/.gitignore:
* TestWebKitAPI/TestWebKitAPI.gyp/.gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHave webkit-patch rebaseline use rebaseline-test-internal
ojan@chromium.org [Tue, 3 Jul 2012 20:23:41 +0000 (20:23 +0000)]
Have webkit-patch rebaseline use rebaseline-test-internal
https://bugs.webkit.org/show_bug.cgi?id=90491

Reviewed by Dirk Pranke.

This lets it handle new files, reduces duplicate code and lays the
groundwork for making rebaseline have a richer interface.

* Scripts/webkitpy/common/net/buildbot/buildbot_mock.py:
(MockBuild):
(MockBuild.__init__):
(MockBuilder.build):
* Scripts/webkitpy/tool/commands/rebaseline.py:
(AbstractParallelRebaselineCommand._files_to_add):
(Rebaseline):
(Rebaseline._builder_to_pull_from):
(Rebaseline._tests_to_update):
(Rebaseline.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_overrides_are_included_correctly):
(test_rebaseline):
(test_rebaseline.mock_builder_to_pull_from):
(test_rebaseline.mock_tests_to_update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRename rebaseline-test to rebaseline-test-internal
ojan@chromium.org [Tue, 3 Jul 2012 19:30:10 +0000 (19:30 +0000)]
Rename rebaseline-test to rebaseline-test-internal
https://bugs.webkit.org/show_bug.cgi?id=90485

Reviewed by Adam Barth.

It's now only used by other rebaseline commands. It's still useful to leave it
as it's own command to aid in debugging when something goes wrong. In a followup
patch, I'll make webkit-patch rebaseline cover any use-cases that rebaseline-test
might have covered.

We no longer need the --print-scm-changes option since the only caller always passes
that option in.

Also, make all the arguments command-line flags instead. Simplifies the code
a bit in my opinion.

* Scripts/webkitpy/tool/commands/rebaseline.py:
(RebaselineTest):
(RebaselineTest.__init__):
(RebaselineTest.execute):
(AbstractParallelRebaselineCommand._rebaseline_commands):
(RebaselineExpectations.execute):
* Scripts/webkitpy/tool/commands/rebaseline_unittest.py:
(test_rebaseline_all):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd ability to symbolically set and dump JSC VM options.
commit-queue@webkit.org [Tue, 3 Jul 2012 19:19:22 +0000 (19:19 +0000)]
Add ability to symbolically set and dump JSC VM options.
See comments in runtime/Options.h for details on how the options work.
https://bugs.webkit.org/show_bug.cgi?id=90420

Patch by Mark Lam <mark.lam@apple.com> on 2012-07-03
Reviewed by Filip Pizlo.

* assembler/LinkBuffer.cpp:
(JSC::LinkBuffer::finalizeCodeWithDisassembly):
* assembler/LinkBuffer.h:
(JSC):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::shouldOptimizeNow):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::likelyToTakeSlowCase):
(JSC::CodeBlock::couldTakeSlowCase):
(JSC::CodeBlock::likelyToTakeSpecialFastCase):
(JSC::CodeBlock::likelyToTakeDeepestSlowCase):
(JSC::CodeBlock::likelyToTakeAnySlowCase):
(JSC::CodeBlock::jitAfterWarmUp):
(JSC::CodeBlock::jitSoon):
(JSC::CodeBlock::reoptimizationRetryCounter):
(JSC::CodeBlock::countReoptimization):
(JSC::CodeBlock::counterValueForOptimizeAfterWarmUp):
(JSC::CodeBlock::counterValueForOptimizeAfterLongWarmUp):
(JSC::CodeBlock::optimizeSoon):
(JSC::CodeBlock::exitCountThresholdForReoptimization):
(JSC::CodeBlock::exitCountThresholdForReoptimizationFromLoop):
* bytecode/ExecutionCounter.h:
(JSC::ExecutionCounter::clippedThreshold):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleInlining):
* dfg/DFGCapabilities.h:
(JSC::DFG::mightCompileEval):
(JSC::DFG::mightCompileProgram):
(JSC::DFG::mightCompileFunctionForCall):
(JSC::DFG::mightCompileFunctionForConstruct):
(JSC::DFG::mightInlineFunctionForCall):
(JSC::DFG::mightInlineFunctionForConstruct):
* dfg/DFGCommon.h:
(JSC::DFG::shouldShowDisassembly):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGVariableAccessData.h:
(JSC::DFG::VariableAccessData::shouldUseDoubleFormatAccordingToVote):
* heap/MarkStack.cpp:
(JSC::MarkStackSegmentAllocator::allocate):
(JSC::MarkStackSegmentAllocator::shrinkReserve):
(JSC::MarkStackArray::MarkStackArray):
(JSC::MarkStackThreadSharedData::MarkStackThreadSharedData):
(JSC::SlotVisitor::donateKnownParallel):
(JSC::SlotVisitor::drain):
(JSC::SlotVisitor::drainFromShared):
* heap/MarkStack.h:
(JSC::MarkStack::mergeOpaqueRootsIfProfitable):
(JSC::MarkStack::addOpaqueRoot):
* heap/SlotVisitor.h:
(JSC::SlotVisitor::donate):
* jit/JIT.cpp:
(JSC::JIT::emitOptimizationCheck):
* jsc.cpp:
(printUsageStatement):
(parseArguments):
* runtime/InitializeThreading.cpp:
(JSC::initializeThreadingOnce):
* runtime/JSGlobalData.cpp:
(JSC::enableAssembler):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::JSGlobalObject):
* runtime/Options.cpp:
(JSC):
(JSC::overrideOptionWithHeuristic):
(JSC::Options::initialize):
(JSC::Options::setOption):
(JSC::Options::dumpAllOptions):
(JSC::Options::dumpOption):
* runtime/Options.h:
(JSC):
(Options):
(EntryInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk][Gamepads] 'warning: comparison is always true due to limited range of data...
zandobersek@gmail.com [Tue, 3 Jul 2012 19:12:13 +0000 (19:12 +0000)]
[Gtk][Gamepads] 'warning: comparison is always true due to limited range of data type [-Wtype-limits]' in GamepadsGtk.cpp
https://bugs.webkit.org/show_bug.cgi?id=90477

Reviewed by Martin Robinson.

Vector::find() returns value of type size_t, springing errors when
assigning the value to a variable of type unsigned. Use size_t type
for that variable instead.

No new tests - no changed functionality.

* platform/gtk/GamepadsGtk.cpp:
(WebCore::GamepadsGtk::unregisterDevice):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening, give a bug number to slow inspector tests and
tony@chromium.org [Tue, 3 Jul 2012 19:08:04 +0000 (19:08 +0000)]
Unreviewed gardening, give a bug number to slow inspector tests and
move into the slow section.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix LayoutUnit usage in RenderImage::imageDimensionsChanged
commit-queue@webkit.org [Tue, 3 Jul 2012 19:07:06 +0000 (19:07 +0000)]
Fix LayoutUnit usage in RenderImage::imageDimensionsChanged
https://bugs.webkit.org/show_bug.cgi?id=90173

Patch by Dominik Röttsches <dominik.rottsches@intel.com> on 2012-07-03
Reviewed by Eric Seidel.

The appropriate type should be used for storing width() and height() into local temporary variables.

No new tests, no change in behavior.

* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageDimensionsChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSuppress tests requiring rebaselining after r121789
robert@webkit.org [Tue, 3 Jul 2012 19:04:04 +0000 (19:04 +0000)]
Suppress tests requiring rebaselining after r121789

Unreviewed, gardening.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/Skipped:
* platform/qt/TestExpectations:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TextureMapper] Typo in edge-distance anti-aliasing code
commit-queue@webkit.org [Tue, 3 Jul 2012 18:59:52 +0000 (18:59 +0000)]
[TextureMapper] Typo in edge-distance anti-aliasing code
https://bugs.webkit.org/show_bug.cgi?id=90475

Patch by Sergio Villar Senin <svillar@igalia.com> on 2012-07-03
Reviewed by Martin Robinson.

No new tests. This just fixes a typo.

* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::TextureMapperGL::drawQuad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Extensions API] Resource manipulations should be based on UISourceCod...
vsevik@chromium.org [Tue, 3 Jul 2012 17:51:27 +0000 (17:51 +0000)]
Web Inspector: [Extensions API] Resource manipulations should be based on UISourceCode thus extending Sources Panel.
https://bugs.webkit.org/show_bug.cgi?id=89868

Reviewed by Pavel Feldman.

Source/WebCore:

Extensions API is now based on both ScriptsPanel acting as a UISourceCodeProvider and ResourceTreeModel.
Extensions API resource could be for any content provider now.
Extensions API resource.setContent implementation is now based on UISourceCode editing methods.
Drive-by StyleSource insremental editing timeout fix.

* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._makeResource):
(WebInspector.ExtensionServer.prototype._onGetPageResources):
(WebInspector.ExtensionServer.prototype._getResourceContent):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
(WebInspector.ExtensionServer.prototype._notifyResourceAdded):
(WebInspector.ExtensionServer.prototype._notifyResourceContentCommitted):
* inspector/front-end/JavaScriptSource.js:
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.uiSourceCodes):
(WebInspector.ScriptsPanel.prototype.uiSourceCodeForURL):
(WebInspector.ScriptsPanel.prototype._addUISourceCode):
(WebInspector.ScriptsPanel.prototype._reset):
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
* inspector/front-end/StylesPanel.js:
(WebInspector.StyleSource.prototype.workingCopyCommitted):
(WebInspector.StyleSource.prototype.workingCopyChanged):
(WebInspector.StyleSource.prototype._callOrSetTimeout):
(WebInspector.StyleSource.prototype._commitIncrementalEdit):
(WebInspector.StyleSource.prototype._clearIncrementalUpdateTimer):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.requestContent):
(WebInspector.UISourceCode.prototype.workingCopy):
(WebInspector.UISourceCode.prototype.setWorkingCopy):
(WebInspector.UISourceCode.prototype.isDirty):

LayoutTests:

* http/tests/inspector/extensions-test.js:
(initialize_ExtensionsTest):
(initialize_ExtensionsTest.completeTest):
(initialize_ExtensionsTest.InspectorTest.runExtensionTests):
* http/tests/inspector/resources/extension-main.js:
* inspector/extensions/extensions-resources.html:
* inspector/styles/styles-history.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@121792 268f45cc-cd09-0410-ab3c-d52691b4dbfc