WebKit-https.git
4 years agoSplit mixed font GlyphPage functionality to separate class
antti@apple.com [Wed, 9 Sep 2015 12:26:08 +0000 (12:26 +0000)]
Split mixed font GlyphPage functionality to separate class
https://bugs.webkit.org/show_bug.cgi?id=148965

Reviewed by Myles Maxfield.

Currently GlyphPage class is used for both immutable single font case (in Font) and
for caching mixed font mappings (in FontCascadeFonts). It is cleaner to use separate
classed for these cases. This will also make future improvements easier.

* platform/graphics/Font.cpp:
(WebCore::Font::~Font):
(WebCore::fillGlyphPage):
(WebCore::createAndFillGlyphPage):
(WebCore::Font::glyphPage):
(WebCore::Font::glyphForCharacter):
(WebCore::Font::glyphDataForCharacter):
* platform/graphics/Font.h:
* platform/graphics/FontCascadeFonts.cpp:
(WebCore::MixedFontGlyphPage::MixedFontGlyphPage):
(WebCore::MixedFontGlyphPage::glyphDataForCharacter):
(WebCore::MixedFontGlyphPage::setGlyphDataForCharacter):
(WebCore::MixedFontGlyphPage::setGlyphDataForIndex):

    Mixed font pages are now an implementation detail of FontCascadeFonts.

(WebCore::FontCascadeFonts::GlyphPageCacheEntry::glyphDataForCharacter):
(WebCore::FontCascadeFonts::GlyphPageCacheEntry::setGlyphDataForCharacter):
(WebCore::FontCascadeFonts::GlyphPageCacheEntry::setSingleFontPage):

    Cache entry is either shared single font GlyphPage or mutable MixedFontGlyphPage.

(WebCore::FontCascadeFonts::FontCascadeFonts):
(WebCore::FontCascadeFonts::glyphDataForCharacter):
(WebCore::FontCascadeFonts::pruneSystemFallbacks):
* platform/graphics/FontCascadeFonts.h:
(WebCore::FontCascadeFonts::GlyphPageCacheEntry::isNull):
(WebCore::FontCascadeFonts::GlyphPageCacheEntry::isMixedFont):
* platform/graphics/GlyphPage.h:

    GlyphPage is now for single font mappings only.
    Use regular allocation instead of variable size tricks.
    It is always immutable after initialization (though currently a setter is still needed).

(WebCore::GlyphPage::create):
(WebCore::GlyphPage::~GlyphPage):
(WebCore::GlyphPage::count):
(WebCore::GlyphPage::indexForCharacter):
(WebCore::GlyphPage::glyphDataForCharacter):
(WebCore::GlyphPage::glyphForCharacter):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::glyphForIndex):
(WebCore::GlyphPage::setGlyphForIndex):
(WebCore::GlyphPage::font):
(WebCore::GlyphPage::GlyphPage):
(WebCore::GlyphPage::createForMixedFonts): Deleted.
(WebCore::GlyphPage::createCopyForMixedFonts): Deleted.
(WebCore::GlyphPage::createForSingleFont): Deleted.
(WebCore::GlyphPage::isImmutable): Deleted.
(WebCore::GlyphPage::setImmutable): Deleted.
(WebCore::GlyphPage::glyphAt): Deleted.
(WebCore::GlyphPage::fontForCharacter): Deleted.
(WebCore::GlyphPage::setGlyphDataForCharacter): Deleted.
(WebCore::GlyphPage::setGlyphDataForIndex): Deleted.
(WebCore::GlyphPage::hasPerGlyphFontData): Deleted.
* platform/graphics/freetype/GlyphPageTreeNodeFreeType.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/mac/GlyphPageMac.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/opentype/OpenTypeVerticalData.cpp:
(WebCore::OpenTypeVerticalData::substituteWithVerticalGlyphs):
* platform/graphics/win/GlyphPageTreeNodeCGWin.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:
(WebCore::GlyphPage::fill):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::fillSVGGlyphPage):
(WebCore::SVGFontData::fillBMPGlyphs):
(WebCore::SVGFontData::fillNonBMPGlyphs):
* svg/SVGFontData.h:
(WebCore::SVGFontData::verticalAdvanceY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[css-grid] Percentage columns shouldn't include border and padding
rego@igalia.com [Wed, 9 Sep 2015 11:23:07 +0000 (11:23 +0000)]
[css-grid] Percentage columns shouldn't include border and padding
https://bugs.webkit.org/show_bug.cgi?id=148978

Reviewed by Sergio Villar Senin.

Source/WebCore:

Subtract border and padding when we're calculating the breadth of the
columns in LayoutGrid::computeUsedBreadthOfSpecifiedLength().

Added test to check the behavior for both columns and rows.

Test: fast/css-grid-layout/grid-percent-track-margin-border-padding.html

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):

LayoutTests:

* fast/css-grid-layout/grid-percent-track-margin-border-padding-expected.txt: Added.
* fast/css-grid-layout/grid-percent-track-margin-border-padding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoHTMLTableElement.tHead / tFoot / caption should be nullable
cdumez@apple.com [Wed, 9 Sep 2015 08:49:19 +0000 (08:49 +0000)]
HTMLTableElement.tHead / tFoot / caption should be nullable
https://bugs.webkit.org/show_bug.cgi?id=148991

Reviewed by Ryosuke Niwa.

Source/WebCore:

According to the specification, HTMLTableElement.tHead / tFoot / caption
should be nullable:
https://html.spec.whatwg.org/multipage/tables.html#htmltableelement

Upon assigning null, we are supposed to remove the existing tHead / tFoot
/ caption element. However, we had a bug causing us to throw an exception
after removing the element. This is because we would try to insert a null
element and ContainerNode::insertBefore() throws when doing so.

Also, as per the specification, setting tHead / tFoot to something else
than a thead / tfoot element should throw a HierarchyRequestError:
https://html.spec.whatwg.org/multipage/tables.html#dom-table-thead
https://html.spec.whatwg.org/multipage/tables.html#dom-table-tfoot

Previously, WebKit did not check the tag and was happy inserting the
element as long as it was an HTMLTableSectionElement. This means that
you could set a tfoot by assigning table.tHead.

This patch corrects both bugs and adds test coverage for it.

Test: fast/dom/HTMLTableElement/nullable-attributes.html

* html/HTMLTableElement.cpp:
(WebCore::HTMLTableElement::setCaption):
Only call insertBefore() if newCaption is not null as insertBefore()
will throw an exception otherwise.

(WebCore::HTMLTableElement::setTHead):
- Throw a HierarchyRequestError if the HTMLTableSectionElement is not
  null or a <thead> element, as per the specification.
- Only call insertBefore() if newHead is not null as insertBefore()
  will throw an exception otherwise.

(WebCore::HTMLTableElement::setTFoot):
- Throw a HierarchyRequestError if the HTMLTableSectionElement is not
  null or a <tfoot> element, as per the specification.
- Only call insertBefore() if newFoot is not null as insertBefore()
  will throw an exception otherwise.

* html/HTMLTableElement.idl:
Use [StrictTypeChecking] for these 3 attributes so that the bindings
will throw a TypeError if the JS tries to assign a value with the
wrong type. When the implementation is called with null, we now know
this is because the JS assigned null (and not an invalid value).
This is important as assigning null is valid since those attributes
are nullable.

LayoutTests:

Add new test that covers the behavior of the following HTMLTableElement
attributes: caption / tHead / tFoot.

* fast/dom/HTMLTableElement/nullable-attributes-expected.txt: Added.
* fast/dom/HTMLTableElement/nullable-attributes.html: Added.
* fast/dom/setter-type-enforcement-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agomin-width/height should default to auto for flexbox items
svillar@igalia.com [Wed, 9 Sep 2015 07:37:14 +0000 (07:37 +0000)]
min-width/height should default to auto for flexbox items
https://bugs.webkit.org/show_bug.cgi?id=146020

Reviewed by David Hyatt.

Based on Blink's r193665, r194062, r194887 and r195930 by <cbiesinger@chromium.org>.

Source/WebCore:

As specified here
http://dev.w3.org/csswg/css-flexbox/#min-size-auto the default
value of min-{width|height} is auto for flex items.

In case this patch breaks any website (as it's changing the
default value of those properties) the fix is likely to add:

min-width: 0;
min-height: 0;

to any relevant flexitems.

Test: css3/flexbox/min-size-auto.html

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::isFlexOrGrid): New helper method to identify grids and flexs.
(WebCore::ComputedStyleExtractor::propertyValue): Return auto
for flex items if min-width/height is auto.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* html/shadow/SliderThumbElement.cpp:
* rendering/RenderBox.cpp:
(WebCore::RenderBox::constrainLogicalHeightByMinMax):
(WebCore::RenderBox::constrainContentBoxLogicalHeightByMinMax):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::computeLogicalHeightUsing):
(WebCore::RenderBox::computeContentLogicalHeight):
(WebCore::RenderBox::computeContentAndScrollbarLogicalHeightUsing):
(WebCore::RenderBox::computeReplacedLogicalWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthRespectingMinMaxWidth):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightRespectingMinMaxHeight):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
* rendering/RenderBox.h:
* rendering/RenderButton.h:
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computeMainAxisExtentForChild):
(WebCore::RenderFlexibleBox::mainAxisExtentIsDefinite):
(WebCore::RenderFlexibleBox::mainAxisLengthIsIndefinite):
(WebCore::RenderFlexibleBox::adjustChildSizeForMinAndMax):
(WebCore::RenderFlexibleBox::mainAxisOverflowForChild):
* rendering/RenderFlexibleBox.h:
(WebCore::RenderFlexibleBox::isFlexibleBoxImpl):
* rendering/RenderFullScreen.h:
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computeUsedBreadthOfSpecifiedLength):
* rendering/RenderMediaControlElements.h:
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::adjustInnerStyle): Do not longer set
the min-width explicitly.
* rendering/RenderMenuList.h:
* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::calculateMaxColumnHeight):
* rendering/RenderNamedFlowFragment.cpp:
(WebCore::RenderNamedFlowFragment::maxPageLogicalHeight):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
(WebCore::RenderReplaced::computeReplacedLogicalHeight):
* rendering/RenderSlider.h:
* rendering/RenderTextControl.h:
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::createInnerBlockStyle): Do not longer set
the min-width explicitly.
* rendering/mathml/RenderMathMLBlock.h:
* rendering/style/RenderStyle.h:

LayoutTests:

* TestExpectations: Removed passing flexbox tests.
* css3/flexbox/csswg/flex-flow-007.html: Added min-height: 0px.
* css3/flexbox/flexbox-baseline.html: Ditto.
* css3/flexbox/min-size-auto-expected.txt: Added.
* css3/flexbox/min-size-auto.html: Added.
* css3/flexbox/preferred-widths-orthogonal.html: Added min-height: 0px.
* fast/css/auto-min-size-expected.txt: Check default computed
styles for min-width/height for flex items.
* fast/css/auto-min-size.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r189530 and r189534.
mmaxfield@apple.com [Wed, 9 Sep 2015 07:02:28 +0000 (07:02 +0000)]
Unreviewed, rolling out r189530 and r189534.
https://bugs.webkit.org/show_bug.cgi?id=148996

Caused assertion failures on Yosemite (Requested by litherum
on #webkit).

Reverted changesets:

"[WKTR] Allow changing the WKContextConfiguration between
successive tests"
https://bugs.webkit.org/show_bug.cgi?id=148833
http://trac.webkit.org/changeset/189530

"[Cocoa] Fix the tests after r189530"
http://trac.webkit.org/changeset/189534

Patch by Commit Queue <commit-queue@webkit.org> on 2015-09-09

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Cocoa] Fix the tests after r189530
mmaxfield@apple.com [Wed, 9 Sep 2015 05:12:37 +0000 (05:12 +0000)]
[Cocoa] Fix the tests after r189530

Unreviewed.

* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::initializeWebViewConfiguration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r189407 and r189424.
commit-queue@webkit.org [Wed, 9 Sep 2015 04:59:47 +0000 (04:59 +0000)]
Unreviewed, rolling out r189407 and r189424.
https://bugs.webkit.org/show_bug.cgi?id=148993

Broke some tests, and made others flakily time out (Requested
by ap on #webkit).

Reverted changesets:

"[WebGL] Update WebGL 1.0.3 conformance tests"
https://bugs.webkit.org/show_bug.cgi?id=148858
http://trac.webkit.org/changeset/189407

"REGRESSION (r189407): webgl/1.0.3/conformance/extensions
/webgl-draw-buffers.html"
http://trac.webkit.org/changeset/189424

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRefactor the test for the arithmetic instructions in WebAssembly
commit-queue@webkit.org [Wed, 9 Sep 2015 04:19:01 +0000 (04:19 +0000)]
Refactor the test for the arithmetic instructions in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148983

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-09-08
Reviewed by Mark Lam.

Pass the values into the test functions as Mark Lam suggested in
https://bugs.webkit.org/show_bug.cgi?id=148882#c3

* tests/stress/wasm-arithmetic-int32.js: Added.
(shouldBe):
(shouldThrow):
* tests/stress/wasm-arithmetic.js: Removed.
(shouldBe): Deleted.
(shouldThrow): Deleted.
* tests/stress/wasm/arithmetic-int32.wasm: Added.
* tests/stress/wasm/arithmetic.wasm: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[JSC] reduce the amount of memory access needed for LivenessAnalysisPhase
benjamin@webkit.org [Wed, 9 Sep 2015 04:02:24 +0000 (04:02 +0000)]
[JSC] reduce the amount of memory access needed for LivenessAnalysisPhase
https://bugs.webkit.org/show_bug.cgi?id=148414

Patch by Benjamin Poulain <bpoulain@apple.com> on 2015-09-08
Reviewed by Mark Lam.

LivenessAnalysisPhase still causes a huge number of cache miss.
This patch reduces the amount of accesses needed by the HashTables.

* dfg/DFGBasicBlock.h:
* dfg/DFGLivenessAnalysisPhase.cpp:
(JSC::DFG::LivenessAnalysisPhase::run):
(JSC::DFG::LivenessAnalysisPhase::process):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[WKTR] Allow changing the WKContextConfiguration between successive tests
mmaxfield@apple.com [Wed, 9 Sep 2015 03:27:48 +0000 (03:27 +0000)]
[WKTR] Allow changing the WKContextConfiguration between successive tests
https://bugs.webkit.org/show_bug.cgi?id=148833

Reviewed by Tim Horton.

Previously, we were creating a single WKContext and it lived for the life of the entire test runner.
However, there are certain tests which require specifying options in this object. This patch makes
our existing code for recreating the test runner web view also recreate the WKContext.

As such, our options to the view are now options to the WKContextConfiguration. This patch renames the
class.

* WebKitTestRunner/ContextConfigurationOptions.h: Renamed from Tools/WebKitTestRunner/ViewOptions.h.
* WebKitTestRunner/PlatformWebView.h:
(WTR::PlatformWebView::options):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize):
(WTR::TestController::generateContextConfiguration):
(WTR::TestController::generatePageConfiguration):
(WTR::TestController::createWebViewWithOptions):
(WTR::TestController::ensureViewSupportsOptionsForTest):
(WTR::updateContextConfigurationOptionsFromTestHeader):
(WTR::TestController::contextConfigurationOptionsForTest):
(WTR::TestController::platformCreateWebView):
(WTR::TestController::platformCreateOtherPage):
(WTR::updateViewOptionsFromTestHeader): Deleted.
(WTR::TestController::viewOptionsForTest): Deleted.
* WebKitTestRunner/TestController.h:
(WTR::TestController::injectedBundlePath):
(WTR::TestController::testPluginDirectory):
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj:
* WebKitTestRunner/cocoa/TestControllerCocoa.mm:
(WTR::TestController::platformCreateWebView):
(WTR::TestController::platformCreateOtherPage):
* WebKitTestRunner/efl/PlatformWebViewEfl.cpp:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
* WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
* WebKitTestRunner/gtk/TestControllerGtk.cpp:
(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
* WebKitTestRunner/ios/PlatformWebViewIOS.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
* WebKitTestRunner/ios/TestControllerIOS.mm:
(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.
* WebKitTestRunner/mac/PlatformWebViewMac.mm:
(WTR::PlatformWebView::PlatformWebView):
(WTR::PlatformWebView::viewSupportsOptions):
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::updatePlatformSpecificContextConfigurationOptionsForTest):
(WTR::TestController::updatePlatformSpecificViewOptionsForTest): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoProspective build fix after r189517
mmaxfield@apple.com [Wed, 9 Sep 2015 03:01:39 +0000 (03:01 +0000)]
Prospective build fix after r189517

Unreviewed.

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::captureStack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: No need for [Custom] Implementation of some InspectorFrontendHost...
commit-queue@webkit.org [Wed, 9 Sep 2015 02:40:40 +0000 (02:40 +0000)]
Web Inspector: No need for [Custom] Implementation of some InspectorFrontendHost methods
https://bugs.webkit.org/show_bug.cgi?id=148990

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-08
Reviewed by Timothy Hatcher.

* bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::platform): Deleted.
(WebCore::JSInspectorFrontendHost::port): Deleted.
* inspector/InspectorFrontendHost.cpp:
(WebCore::InspectorFrontendHost::platform):
(WebCore::InspectorFrontendHost::port):
* inspector/InspectorFrontendHost.h:
* inspector/InspectorFrontendHost.idl:
Uncustomize a few basic functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCrash when WebCore::SQLiteFileSystem::openDatabase is called from multiple threads
mcatanzaro@igalia.com [Wed, 9 Sep 2015 01:38:32 +0000 (01:38 +0000)]
Crash when WebCore::SQLiteFileSystem::openDatabase is called from multiple threads
https://bugs.webkit.org/show_bug.cgi?id=143245

Reviewed by Darin Adler.

sqlite3_initialize is documented to be thread-safe, and to be called automatically by the
library when needed, so applications should never need to call it directly. The problem is,
it's not thread-safe: we have documented instances of GNOME Builder, Devhelp, Epiphany, and
cinnamon-screensaver crashing when sqlite3_initialize is called simultaneously in separate
threads (usually inside sqlite3_open). So call it manually, guarded using std::call_once, to
make sure that the library is fully initialized before the first call to sqlite3_open. It's
a good idea to do this regardless, because the documentation says it could be required in
a future release of SQLite. (Though the use of std::call_once should not be needed, and is
only used to attempt to work around the crashes.)

This is a workaround for an SQLite bug that might have been fixed upstream, but the SQLite
developers are not really confident in the thread-safety of this function, and have advised
that we carry the workaround. Seems like a good idea.

* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::SQLiteDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSource/JavaScriptCore:
utatane.tea@gmail.com [Wed, 9 Sep 2015 01:32:51 +0000 (01:32 +0000)]
Source/JavaScriptCore:
Unify symbolTableGet and Put in JSLexicalEnvironment and JSSymbolTableObject
https://bugs.webkit.org/show_bug.cgi?id=148783

Reviewed by Geoffrey Garen.

Unify the symbolTableGet and symbolTablePut into JSSymbolTableObject's one.
Since symbolTablePutWithAttributes in JSLexicalEnvironment is not used, we drop that function.

* runtime/JSEnvironmentRecord.h:
(JSC::JSEnvironmentRecord::isValidScopeOffset):
(JSC::JSEnvironmentRecord::variableAt):
(JSC::JSEnvironmentRecord::isValid): Deleted.
* runtime/JSGlobalLexicalEnvironment.cpp:
(JSC::JSGlobalLexicalEnvironment::put):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::put):
* runtime/JSLexicalEnvironment.cpp:
(JSC::JSLexicalEnvironment::getOwnNonIndexPropertyNames):
(JSC::JSLexicalEnvironment::getOwnPropertySlot):
(JSC::JSLexicalEnvironment::put):
(JSC::JSLexicalEnvironment::symbolTableGet): Deleted.
(JSC::JSLexicalEnvironment::symbolTablePut): Deleted.
(JSC::JSLexicalEnvironment::symbolTablePutWithAttributes): Deleted.
* runtime/JSLexicalEnvironment.h:
* runtime/JSModuleRecord.cpp:
(JSC::JSModuleRecord::instantiateDeclarations):
* runtime/JSSegmentedVariableObject.h:
(JSC::JSSegmentedVariableObject::isValidScopeOffset):
* runtime/JSSymbolTableObject.h:
(JSC::symbolTableGet):
(JSC::symbolTablePut):
(JSC::symbolTablePutTouchWatchpointSet):
(JSC::symbolTablePutInvalidateWatchpointSet):
(JSC::symbolTablePutWithAttributesTouchWatchpointSet):
(JSC::symbolTablePutWithAttributes): Deleted.

Source/WebCore:
Unify symbolTablePut in JSLexicalEnvironment and JSSymbolTableObject
https://bugs.webkit.org/show_bug.cgi?id=148783

Reviewed by Geoffrey Garen.

No behavior change.

* bindings/js/JSDOMWindowBase.cpp:
(WebCore::JSDOMWindowBase::updateDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, rolling out r189516.
commit-queue@webkit.org [Wed, 9 Sep 2015 01:28:22 +0000 (01:28 +0000)]
Unreviewed, rolling out r189516.
https://bugs.webkit.org/show_bug.cgi?id=148989

broke tests on windows (Requested by alexchristensen on
#webkit).

Reverted changeset:

"GC should be able to discover new strong CodeBlock references
during marking"
https://bugs.webkit.org/show_bug.cgi?id=148981
http://trac.webkit.org/changeset/189516

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove unused DFG::dfgConvertJSValueToInt32()
commit-queue@webkit.org [Wed, 9 Sep 2015 01:03:18 +0000 (01:03 +0000)]
Remove unused DFG::dfgConvertJSValueToInt32()
https://bugs.webkit.org/show_bug.cgi?id=148986

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-09-08
Reviewed by Geoffrey Garen.

Remove unused DFG::dfgConvertJSValueToInt32() and also remove
DFG::JITCompiler::callOperation(D_JITOperation_EJ operation, ...) which
was introduced in Bug 69806 for dfgConvertJSValueToNumber() and is no
longer used.

* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFunction.prototype.bind: Bound functions must use the [[Prototype]] of their target...
commit-queue@webkit.org [Wed, 9 Sep 2015 01:01:06 +0000 (01:01 +0000)]
Function.prototype.bind: Bound functions must use the [[Prototype]] of their target function instead of Function.prototype
https://bugs.webkit.org/show_bug.cgi?id=145605

Patch by Matthew Hill <matthew.jh@outlook.com> on 2015-09-08
Reviewed by Geoffrey Garen.

* runtime/JSBoundFunction.cpp:
(JSC::JSBoundFunction::create):
* tests/es6.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[iOS] Unreviewed iOS gardening.
said@apple.com [Wed, 9 Sep 2015 00:46:30 +0000 (00:46 +0000)]
[iOS] Unreviewed iOS gardening.

* platform/ios-simulator/css3/filters/backdrop: Added.
* platform/ios-simulator/css3/filters/backdrop/blur-input-bounds-expected.txt: Added.
* platform/ios-simulator/css3/font-feature-settings-preinstalled-fonts-expected.txt: Added.
* platform/ios-simulator/fast/css/named-images-expected.txt: Added.
* platform/ios-simulator/fast/forms/select-element-focus-ring-expected.txt: Added.
* platform/ios-simulator/fast/text/font-weights-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFixed a bad comment r189517.
mark.lam@apple.com [Wed, 9 Sep 2015 00:26:16 +0000 (00:26 +0000)]
Fixed a bad comment r189517.

Not reviewed.

* heap/MachineStackMarker.cpp:
(JSC::osRedZoneAdjustment):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, drop imported/w3c/web-platform-tests/html/semantics/embedded-content...
cdumez@apple.com [Wed, 9 Sep 2015 00:20:16 +0000 (00:20 +0000)]
Unreviewed, drop imported/w3c/web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html.

This recently imported test is flaky.

* web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/location-of-the-media-resource/currentSrc.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoInlineCallFrames shouldn't be strongly marked by CodeBlock
ggaren@apple.com [Wed, 9 Sep 2015 00:20:12 +0000 (00:20 +0000)]
InlineCallFrames shouldn't be strongly marked by CodeBlock
https://bugs.webkit.org/show_bug.cgi?id=146613

Reviewed by Saam Barati.

This code was vestigial an unnecessary, so I removed it.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::stronglyVisitStrongReferences):
* bytecode/InlineCallFrame.cpp:
(JSC::InlineCallFrame::calleeConstant):
(JSC::InlineCallFrame::calleeForCallFrame):
(JSC::InlineCallFrame::visitAggregate): Deleted.
* bytecode/InlineCallFrame.h:
(JSC::InlineCallFrame::specializationKind):
* bytecode/InlineCallFrameSet.cpp:
(JSC::InlineCallFrameSet::add):
(JSC::InlineCallFrameSet::visitAggregate): Deleted.
* bytecode/InlineCallFrameSet.h:
(JSC::InlineCallFrameSet::begin):
(JSC::InlineCallFrameSet::end):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGC stack scan should include ABI red zone.
mark.lam@apple.com [Wed, 9 Sep 2015 00:19:15 +0000 (00:19 +0000)]
GC stack scan should include ABI red zone.
https://bugs.webkit.org/show_bug.cgi?id=148976

Reviewed by Geoffrey Garen and Benjamin Poulain.

Source/JavaScriptCore:

The x86_64 ABI section 3.2.2[1] and ARM64 ABI[2] both state that there is a
128 byte red zone below the stack pointer (reserved by the OS), and that
"functions may use this area for temporary data that is not needed across
function calls".

Hence, it is possible for a thread to store JSCell pointers in the red zone
area, and the conservative GC thread scanner needs to scan that area as well.

Note: the red zone should not be scanned for the GC thread itself (in
gatherFromCurrentThread()).  This because we're guaranteed that there will
be GC frames below the lowest (top of stack) frame that we need to scan.
Hence, we are guaranteed that there are no red zone areas there containing
JSObject pointers of relevance.

No test added for this issue because the issue relies on:
1. the compiler tool chain generating code that stores local variables
   containing the sole reference to a JS object (that needs to be kept
   alive) in the stack red zone, and
2. GC has to run on another thread while that red zone containing the
   JS object reference is in use.

These conditions require a race that cannot be reliably reproduced.

[1]: http://people.freebsd.org/~obrien/amd64-elf-abi.pdf
[2]: https://developer.apple.com/library/ios/documentation/Xcode/Conceptual/iPhoneOSABIReference/Articles/ARM64FunctionCallingConventions.html#//apple_ref/doc/uid/TP40013702-SW7

* heap/MachineStackMarker.cpp:
(JSC::MachineThreads::Thread::Thread):
(JSC::MachineThreads::Thread::createForCurrentThread):
(JSC::MachineThreads::Thread::freeRegisters):
(JSC::osRedZoneAdjustment):
(JSC::MachineThreads::Thread::captureStack):

Source/WTF:

* wtf/StackBounds.h:
(WTF::StackBounds::origin):
(WTF::StackBounds::end):
(WTF::StackBounds::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGC should be able to discover new strong CodeBlock references during marking
ggaren@apple.com [Wed, 9 Sep 2015 00:07:51 +0000 (00:07 +0000)]
GC should be able to discover new strong CodeBlock references during marking
https://bugs.webkit.org/show_bug.cgi?id=148981

Reviewed by Mark Lam.

Previously, we required a strong reference to register itself before the
first visit to a CodeBlock. Now, we can discover a strong reference at
any time during the marking phase.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock): Remove the two strong reference state
variables from CodeBlock. Now, a strong reference immediately marks
the CodeBlock and its references at the moment of its discovery, and no
separate state is required.

(JSC::CodeBlock::visitStrongly): New helper function for establishing
a strong reference to a CodeBlock.

(JSC::CodeBlock::visitAggregate): Adopt helper function above.

(JSC::CodeBlock::shouldImmediatelyAssumeLivenessDuringScan): Updated
for state removal.

(JSC::CodeBlock::isKnownToBeLiveDuringGC): Ditto.

(JSC::CodeBlock::stronglyVisitWeakReferences): Be sure to record that
we have proven liveness (by virtue of marking all the references the
proof would check). This is required so that the CodeBlock knows itself
to be live, and it is also an optimization to avoid testing weak references
after we have already visited them.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::clearMarks):
(JSC::CodeBlockSet::mark):
(JSC::CodeBlockSet::clearMarks): Deleted. Updated for state removal.

* dfg/DFGPlan.cpp:
(JSC::DFG::Plan::clearCodeBlockMarks):
(JSC::DFG::Plan::checkLivenessAndVisitChildren):
* dfg/DFGPlan.h: No need to use a CodeBlockSet in order to mark anymore.

* dfg/DFGWorklist.cpp:
(JSC::DFG::Worklist::completeAllPlansForVM):
(JSC::DFG::Worklist::clearCodeBlockMarks):
(JSC::DFG::Worklist::resumeAllThreads):
(JSC::DFG::Worklist::visitWeakReferences):
(JSC::DFG::completeAllPlansForVM):
(JSC::DFG::clearCodeBlockMarks):
* dfg/DFGWorklist.h:
(JSC::DFG::worklistForIndexOrNull): No need to use a CodeBlockSet in order
to mark anymore.

* heap/CodeBlockSet.cpp:
(JSC::CodeBlockSet::clearMarksForFullCollection):
(JSC::CodeBlockSet::clearMarksForEdenCollection):
(JSC::CodeBlockSet::deleteUnmarkedAndUnreferenced):
(JSC::CodeBlockSet::traceMarked):
(JSC::CodeBlockSet::rememberCurrentlyExecutingCodeBlocks):
(JSC::CodeBlockSet::dump):
* heap/CodeBlockSet.h: Keep the currently executing CodeBlocks in RefPtrs
since we can no longer rely on the m_currentlyExecuting bit to keep them
alive. (A currently executing CodeBlock may not be referenced by its
Executable because it may since have been replaced by another CodeBlock.
This is common in the cases of OSR entry and exit.)

* heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::visitCompilerWorklistWeakReferences):
(JSC::Heap::visitWeakHandles): No need to trace the list of CodeBlocks
on the stack in the weak reference fixpoint because we no longer overload
"on the stack" to include CodeBlocks referenced by the compiler.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[JSC] Remove unused Heap::getConservativeRegisterRoots().
akling@apple.com [Tue, 8 Sep 2015 23:10:57 +0000 (23:10 +0000)]
[JSC] Remove unused Heap::getConservativeRegisterRoots().
<https://webkit.org/b/148974>

Reviewed by Geoffrey Garen.

Spotted this unused stack root gathering helper in Heap. Let's lose it.

* heap/Heap.cpp:
(JSC::Heap::getConservativeRegisterRoots): Deleted.
* interpreter/JSStack.cpp:
(JSC::JSStack::gatherConservativeRoots): Deleted.
* interpreter/JSStack.h:
(JSC::JSStack::gatherConservativeRoots): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement control flow statements in WebAssembly
commit-queue@webkit.org [Tue, 8 Sep 2015 23:04:44 +0000 (23:04 +0000)]
Implement control flow statements in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148934

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-09-08
Reviewed by Geoffrey Garen.

This patch implements if, while, do, label, break, and continue
statements in WebAssembly. Switches will be implemented in a subsequent
patch.

* tests/stress/wasm-control-flow.js: Added.
(shouldBe):
* tests/stress/wasm/control-flow.wasm: Added.
* wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::linkTarget):
(JSC::WASMFunctionCompiler::jumpToTarget):
(JSC::WASMFunctionCompiler::jumpToTargetIf):
(JSC::WASMFunctionCompiler::startLoop):
(JSC::WASMFunctionCompiler::endLoop):
(JSC::WASMFunctionCompiler::startSwitch):
(JSC::WASMFunctionCompiler::endSwitch):
(JSC::WASMFunctionCompiler::startLabel):
(JSC::WASMFunctionCompiler::endLabel):
(JSC::WASMFunctionCompiler::breakTarget):
(JSC::WASMFunctionCompiler::continueTarget):
(JSC::WASMFunctionCompiler::breakLabelTarget):
(JSC::WASMFunctionCompiler::continueLabelTarget):
* wasm/WASMFunctionParser.cpp:
(JSC::WASMFunctionParser::parseIfStatement):
(JSC::WASMFunctionParser::parseIfElseStatement):
(JSC::WASMFunctionParser::parseWhileStatement):
(JSC::WASMFunctionParser::parseDoStatement):
(JSC::WASMFunctionParser::parseLabelStatement):
(JSC::WASMFunctionParser::parseBreakStatement):
(JSC::WASMFunctionParser::parseBreakLabelStatement):
(JSC::WASMFunctionParser::parseContinueStatement):
(JSC::WASMFunctionParser::parseContinueLabelStatement):
* wasm/WASMFunctionParser.h:
* wasm/WASMFunctionSyntaxChecker.h:
(JSC::WASMFunctionSyntaxChecker::linkTarget):
(JSC::WASMFunctionSyntaxChecker::jumpToTarget):
(JSC::WASMFunctionSyntaxChecker::jumpToTargetIf):
(JSC::WASMFunctionSyntaxChecker::startLoop):
(JSC::WASMFunctionSyntaxChecker::endLoop):
(JSC::WASMFunctionSyntaxChecker::startSwitch):
(JSC::WASMFunctionSyntaxChecker::endSwitch):
(JSC::WASMFunctionSyntaxChecker::startLabel):
(JSC::WASMFunctionSyntaxChecker::endLabel):
(JSC::WASMFunctionSyntaxChecker::breakTarget):
(JSC::WASMFunctionSyntaxChecker::continueTarget):
(JSC::WASMFunctionSyntaxChecker::breakLabelTarget):
(JSC::WASMFunctionSyntaxChecker::continueLabelTarget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
dbates@webkit.org [Tue, 8 Sep 2015 23:04:34 +0000 (23:04 +0000)]
[Mac] Expose Enable/Disable Accelerated Drawing in MiniBrowser
https://bugs.webkit.org/show_bug.cgi?id=148980

Reviewed by Alexey Proskuryakov.

Source/WebKit2:

Expose SPI web preference to enable/disable- and query the state of- accelerated drawing
so that we can toggle this setting in MiniBrowser on Mac.

* UIProcess/API/Cocoa/WKPreferences.mm:
(-[WKPreferences _acceleratedDrawingEnabled]): Added.
(-[WKPreferences _setAcceleratedDrawingEnabled:]): Added.
* UIProcess/API/Cocoa/WKPreferencesPrivate.h:

Tools:

Add setting to enable/disable accelerated drawing so as to support testing
this feature in MiniBrowser on Mac.

* MiniBrowser/mac/SettingsController.h:
* MiniBrowser/mac/SettingsController.m:
(-[SettingsController _populateMenu]): Add menu item.
(-[SettingsController validateMenuItem:]): Update setting when menu item is toggled.
(-[SettingsController toggleAcceleratedDrawingEnabled:]): Added.
(-[SettingsController acceleratedDrawingEnabled]): Added.
* MiniBrowser/mac/WK1BrowserWindowController.m:
(-[WK1BrowserWindowController didChangeSettings]): Apply setting in WebKit1.
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController didChangeSettings]): Apply setting in WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSeveral inspector-protocol tests are flaky with GuardMalloc
bburg@apple.com [Tue, 8 Sep 2015 22:38:44 +0000 (22:38 +0000)]
Several inspector-protocol tests are flaky with GuardMalloc
https://bugs.webkit.org/show_bug.cgi?id=136715

Reviewed by Joseph Pecoraro.

Sometimes, the async dispatch task can outlive its owning frontend client.
To avoid problems, make it refcounted instead and add a protector reference.

No new tests, covered by existing tests.

* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorBackendDispatchTask::create):
(WebCore::InspectorBackendDispatchTask::dispatch):
(WebCore::InspectorBackendDispatchTask::reset):
(WebCore::InspectorBackendDispatchTask::timerFired):
(WebCore::InspectorBackendDispatchTask::InspectorBackendDispatchTask):
(WebCore::InspectorFrontendClientLocal::InspectorFrontendClientLocal):
(WebCore::InspectorFrontendClientLocal::~InspectorFrontendClientLocal):
* inspector/InspectorFrontendClientLocal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFixup typo from r189510
jmarcell@apple.com [Tue, 8 Sep 2015 22:33:10 +0000 (22:33 +0000)]
Fixup typo from r189510

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed. Added myself as a commiter in contributors.json.
jmarcell@apple.com [Tue, 8 Sep 2015 22:28:37 +0000 (22:28 +0000)]
Unreviewed. Added myself as a commiter in contributors.json.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Remove unused file: WebInspectorFrontendClient.h
commit-queue@webkit.org [Tue, 8 Sep 2015 22:13:34 +0000 (22:13 +0000)]
Web Inspector: Remove unused file: WebInspectorFrontendClient.h
https://bugs.webkit.org/show_bug.cgi?id=148979

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2015-09-08
Reviewed by Brian Burg.

* WebProcess/WebCoreSupport/WebInspectorFrontendClient.h: Removed.
Unused now. WebInspectorUI subclasses InspectorFrontendClient itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: REGRESSION (r189189): Missing breakpoint context menu for debugger...
mattbaker@apple.com [Tue, 8 Sep 2015 22:12:11 +0000 (22:12 +0000)]
Web Inspector: REGRESSION (r189189): Missing breakpoint context menu for debugger sidebar tree elements
https://bugs.webkit.org/show_bug.cgi?id=148651

Reviewed by Timothy Hatcher.

* UserInterface/Base/Main.js:
(WebInspector.contentLoaded):
Create BreakpointPopoverController singleton, expose as public property of global WebInspector object.

* UserInterface/Views/BreakpointTreeElement.js:
(WebInspector.BreakpointTreeElement.prototype.oncontextmenu):
Use BreakpointPopoverController singleton.

* UserInterface/Views/SourceCodeTextEditor.js:
(WebInspector.SourceCodeTextEditor):
Don't create BreakpointPopoverController instance.
(WebInspector.SourceCodeTextEditor.prototype.textEditorGutterContextMenu):
Use BreakpointPopoverController singleton.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agonew Comment(undefined) / new Text(undefined) should use default's empty string
cdumez@apple.com [Tue, 8 Sep 2015 21:57:06 +0000 (21:57 +0000)]
new Comment(undefined) / new Text(undefined) should use default's empty string
https://bugs.webkit.org/show_bug.cgi?id=148973
<rdar://problem/22548042>

Reviewed by Ryosuke Niwa.

LayoutTests/imported/w3c:

* web-platform-tests/dom/nodes/Comment-constructor-expected.txt:
* web-platform-tests/dom/nodes/Text-constructor-expected.txt:
* web-platform-tests/html/dom/documents/dom-tree-accessors/document.title-07-expected.txt:
* web-platform-tests/html/semantics/embedded-content/the-audio-element/audio_constructor-expected.txt:
Rebaseline tests now that new checks are passing.

Source/WebCore:

new Comment(undefined) / new Text(undefined) should use default's empty string instead of converting
undefined to the "undefined" string:
- https://dom.spec.whatwg.org/#interface-comment (parameter is optional, default value is empty String)
- https://dom.spec.whatwg.org/#text (ditto)

undefined should be treated as if the parameter is missing, in the case the parameter is optional, as
per the Web IDL specification. This patch aligns WebKit's behavior with the specification and the
behavior of Firefox and Chrome.

No new tests, already covered by existing tests.

* bindings/scripts/CodeGeneratorJS.pm:
(GenerateParametersCheck):
* bindings/scripts/test/JS/JSTestNamedConstructor.cpp:
(WebCore::JSTestNamedConstructorNamedConstructor::constructJSTestNamedConstructor):
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjPrototypeFunctionMethodWithOptionalStringIsNullString):

LayoutTests:

Fix a couple of layout tests that were wrongly expecting undefined to
be converted to the "undefined" String for optional DOMString parameters.

* fast/dom/DOMImplementation/createHTMLDocument-optional-title-expected.txt:
* fast/dom/DOMImplementation/createHTMLDocument-optional-title.html:
* fast/dom/Window/custom-constructors-expected.txt:
* fast/dom/Window/custom-constructors.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Compile errors in inspector code.
peavo@outlook.com [Tue, 8 Sep 2015 21:56:22 +0000 (21:56 +0000)]
[Win] Compile errors in inspector code.
https://bugs.webkit.org/show_bug.cgi?id=148977

Reviewed by Alex Christensen.

Include definition of class FrontendRouter before use.

* inspector/InspectorBackendDispatcher.h:
* inspector/JSGlobalObjectInspectorController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix inspector/codemirror tests.
joepeck@webkit.org [Tue, 8 Sep 2015 20:50:16 +0000 (20:50 +0000)]
Fix inspector/codemirror tests.

Rubber-stamped by Brian Burg.

* UserInterface/Test.html:
Reorder includes to be more like Main.html. This ensures that CodeMirror
resources are loaded before Inspector sources use it, like CodeMirrorAdditions
which gets merged into TestCombined.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[ES6] Implement computed accessors
utatane.tea@gmail.com [Tue, 8 Sep 2015 19:43:58 +0000 (19:43 +0000)]
[ES6] Implement computed accessors
https://bugs.webkit.org/show_bug.cgi?id=147883

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

Implement the computed accessors functionality for class syntax and object literal syntax.
Added new opcodes, op_put_getter_by_val and op_put_setter_by_val. LLInt and baseline JIT support them.
As the same to the other accessor opcodes (like op_put_getter_by_id etc.), DFG / FTL does not support
them. This is handled here[1].

[1]: https://bugs.webkit.org/show_bug.cgi?id=148860

* bytecode/BytecodeList.json:
* bytecode/BytecodeUseDef.h:
(JSC::computeUsesForBytecodeOffset):
(JSC::computeDefsForBytecodeOffset):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dumpBytecode):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitPutGetterByVal):
(JSC::BytecodeGenerator::emitPutSetterByVal):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/NodesCodegen.cpp:
(JSC::PropertyListNode::emitBytecode):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITInlines.h:
(JSC::JIT::callOperation):
* jit/JITOperations.cpp:
* jit/JITOperations.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_put_getter_by_val):
(JSC::JIT::emit_op_put_setter_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_put_getter_by_val):
(JSC::JIT::emit_op_put_setter_by_val):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::LLINT_SLOW_PATH_DECL):
* llint/LLIntSlowPaths.h:
* llint/LowLevelInterpreter.asm:
* parser/ASTBuilder.h:
(JSC::ASTBuilder::createGetterOrSetterProperty):
* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseClass):
(JSC::Parser<LexerType>::parseGetterSetter):
* parser/SyntaxChecker.h:
(JSC::SyntaxChecker::createGetterOrSetterProperty):
* tests/es6.yaml:
* tests/stress/computed-accessor-parsing.js: Added.
(testShouldNotThrow):
(testShouldThrow):
(Val.prototype.get string_appeared_here):
(Val):
* tests/stress/computed-accessor.js: Added.
(shouldBe):
(.):
* tests/stress/duplicate-computed-accessors.js: Added.
(shouldBe):

LayoutTests:

Updated the existing tests.

* js/parser-syntax-check-expected.txt:
* js/script-tests/parser-syntax-check.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, added myself to the list of contributors.
keith_miller@apple.com [Tue, 8 Sep 2015 19:42:43 +0000 (19:42 +0000)]
Unreviewed, added myself to the list of contributors.

* Scripts/webkitpy/common/config/contributors.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agodocument.importNode(node, deep): deep's default value should be false
cdumez@apple.com [Tue, 8 Sep 2015 19:39:40 +0000 (19:39 +0000)]
document.importNode(node, deep): deep's default value should be false
https://bugs.webkit.org/show_bug.cgi?id=148959
<rdar://problem/22558915>

Reviewed by Alexey Proskuryakov.

LayoutTests/imported/w3c:

* web-platform-tests/dom/nodes/Document-importNode-expected.txt:
Rebaseline now that an additional check is passing.

Source/WebCore:

Switch deep parameter's default value for document.importNode() to
false, as per the latest DOM specification:
- https://dom.spec.whatwg.org/#interface-document
- https://dom.spec.whatwg.org/#dom-document-importnode

Firefox and Chrome follow the specification. However, WebKit was using
"true" for deep's default value.

No new tests, already covered by:
imported/w3c/web-platform-tests/dom/nodes/Document-importNode.html

* dom/Document.h:
(WebCore::Document::importNode):

LayoutTests:

* fast/dom/document-importNode-arguments.html:
Explicitly pass deep parameter as the test wants a deep clone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agobaseline JIT should emit better code for UnresolvedProperty in resolve_scope/get_from...
commit-queue@webkit.org [Tue, 8 Sep 2015 19:11:04 +0000 (19:11 +0000)]
baseline JIT should emit better code for UnresolvedProperty in resolve_scope/get_from_scope/put_to_scope
https://bugs.webkit.org/show_bug.cgi?id=148895

Patch by Saam barati <sbarati@apple.com> on 2015-09-08
Reviewed by Geoffrey Garen.

Previously, if a resolve_scope/get_from_scope/put_to_scope with
UnresolvedProperty made it to the baseline JIT, we would hard compile
a jump to the slow path. This is bad and slow. Because UnresolvedProperty
tries to update itself to something more useful, and succeeds at doing so
with high probability, we should be emitting code that checks to see if the
slow path has performed an update, and if it has, execute more efficient code
and not go to the slow path (unless it needs to for var injection check failure,
or other check failures). This increases the speed of this code greatly because
we may decide to compile a program/function before certain resolve_scope/get_from_scope/put_to_scope
operations ever execute. And now, the baseline JIT code better adapts to such
compilation scenarios.

* bytecode/Watchpoint.h:
(JSC::WatchpointSet::isBeingWatched):
(JSC::WatchpointSet::addressOfState):
(JSC::WatchpointSet::offsetOfState):
(JSC::WatchpointSet::addressOfSetIsNotEmpty):
* jit/JIT.cpp:
(JSC::JIT::emitNotifyWrite):
(JSC::JIT::assertStackPointerOffset):
* jit/JIT.h:
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emitGetVarFromIndirectPointer):
(JSC::JIT::emitGetClosureVar):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalProperty):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emitPutGlobalVariableIndirect):
(JSC::JIT::emitPutClosureVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emit_op_resolve_scope):
(JSC::JIT::emitSlow_op_resolve_scope):
(JSC::JIT::emitGetGlobalProperty):
(JSC::JIT::emitGetVarFromPointer):
(JSC::JIT::emitGetVarFromIndirectPointer):
(JSC::JIT::emitGetClosureVar):
(JSC::JIT::emit_op_get_from_scope):
(JSC::JIT::emitSlow_op_get_from_scope):
(JSC::JIT::emitPutGlobalProperty):
(JSC::JIT::emitPutGlobalVariable):
(JSC::JIT::emitPutGlobalVariableIndirect):
(JSC::JIT::emitPutClosureVar):
(JSC::JIT::emit_op_put_to_scope):
(JSC::JIT::emitSlow_op_put_to_scope):
* runtime/CommonSlowPaths.h:
(JSC::CommonSlowPaths::tryCachePutToScopeGlobal):
(JSC::CommonSlowPaths::tryCacheGetFromScopeGlobal):
* runtime/JSScope.cpp:
(JSC::abstractAccess):
* tests/stress/multiple-files-tests/global-lexical-variable-unresolved-property/first.js:
(foo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWeb Inspector: Move PrettyPrinting tests into LayoutTests
joepeck@webkit.org [Tue, 8 Sep 2015 18:47:45 +0000 (18:47 +0000)]
Web Inspector: Move PrettyPrinting tests into LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=148698

Reviewed by Timothy Hatcher.

Source/WebInspectorUI:

* Tools/PrettyPrinting/index.html:
Modify the relative path to the tests which are now in LayoutTests.

* UserInterface/Test.html:
Load CodeMirror and related resources for Formatting.

LayoutTests:

* inspector/codemirror/resources/prettyprinting/css-rule-tests/*: Renamed from Source/WebInspectorUI/Tools/PrettyPrinting/css-rule-tests/*.
* inspector/codemirror/resources/prettyprinting/css-tests/*: Renamed from Source/WebInspectorUI/Tools/PrettyPrinting/css-tests/*.
* inspector/codemirror/resources/prettyprinting/javascript-tests/*: Renamed from Source/WebInspectorUI/Tools/PrettyPrinting/js-tests/*.
Move tests from PrettyPrinting tools into LayoutTests.

* inspector/codemirror/prettyprinting-css-expected.txt: Added.
* inspector/codemirror/prettyprinting-css-rules-expected.txt: Added.
* inspector/codemirror/prettyprinting-css-rules.html: Added.
* inspector/codemirror/prettyprinting-css.html: Added.
* inspector/codemirror/prettyprinting-javascript-expected.txt: Added.
* inspector/codemirror/prettyprinting-javascript.html: Added.
Add tests per CodeMirror mode.

* inspector/codemirror/resources/prettyprinting/utilities.js: Added.
(TestPage.registerInitializer):
Shared code between the pretty printing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement all the arithmetic and logical instructions in WebAssembly
commit-queue@webkit.org [Tue, 8 Sep 2015 18:34:22 +0000 (18:34 +0000)]
Implement all the arithmetic and logical instructions in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148882

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-09-08
Reviewed by Mark Lam.

This patch implements all the arithmetic and logical instructions for
32-bit integers in WebAssembly.

* tests/stress/wasm-arithmetic.js:
* tests/stress/wasm/arithmetic.wasm:
* wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::buildUnaryI32):
(JSC::WASMFunctionCompiler::buildBinaryI32):
* wasm/WASMFunctionParser.cpp:
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseUnaryExpressionI32):
* wasm/WASMFunctionParser.h:
* wasm/WASMFunctionSyntaxChecker.h:
(JSC::WASMFunctionSyntaxChecker::buildUnaryI32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win][HighDPI] Video window placement is incorrect.
peavo@outlook.com [Tue, 8 Sep 2015 18:23:23 +0000 (18:23 +0000)]
[Win][HighDPI] Video window placement is incorrect.
https://bugs.webkit.org/show_bug.cgi?id=148954

Reviewed by Alex Christensen.

We need to scale window dimensions with device scale factor.

* platform/graphics/win/MediaPlayerPrivateMediaFoundation.cpp:
(WebCore::MediaPlayerPrivateMediaFoundation::setSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Win] Implement DOMNode::attributes.
peavo@outlook.com [Tue, 8 Sep 2015 18:18:51 +0000 (18:18 +0000)]
[Win] Implement DOMNode::attributes.
https://bugs.webkit.org/show_bug.cgi?id=148747

Reviewed by Brent Fulgham.

* DOMCoreClasses.cpp:
(DOMNode::attributes):
(DOMNode::ownerDocument):
(DOMRange::detach):
(DOMNamedNodeMap::DOMNamedNodeMap):
(DOMNamedNodeMap::~DOMNamedNodeMap):
(DOMNamedNodeMap::createInstance):
(DOMNamedNodeMap::QueryInterface):
(DOMNamedNodeMap::getNamedItem):
(DOMNamedNodeMap::setNamedItem):
(DOMNamedNodeMap::removeNamedItem):
(DOMNamedNodeMap::item):
(DOMNamedNodeMap::length):
(DOMNamedNodeMap::getNamedItemNS):
(DOMNamedNodeMap::setNamedItemNS):
(DOMNamedNodeMap::removeNamedItemNS):
* DOMCoreClasses.h:
(DOMNamedNodeMap::AddRef):
(DOMNamedNodeMap::Release):
(DOMNamedNodeMap::throwException):
(DOMNamedNodeMap::callWebScriptMethod):
(DOMNamedNodeMap::evaluateWebScript):
(DOMNamedNodeMap::removeWebScriptKey):
(DOMNamedNodeMap::stringRepresentation):
(DOMNamedNodeMap::webScriptValueAtIndex):
(DOMNamedNodeMap::setWebScriptValueAtIndex):
(DOMNamedNodeMap::setException):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, fix debug by removing an assertion that is not correct anymore.
fpizlo@apple.com [Tue, 8 Sep 2015 18:17:10 +0000 (18:17 +0000)]
Unreviewed, fix debug by removing an assertion that is not correct anymore.

* jit/Repatch.cpp:
(JSC::linkFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark animations/trigger-container-scroll-boundaries.html as failure on iOS
dbates@webkit.org [Tue, 8 Sep 2015 17:47:46 +0000 (17:47 +0000)]
Mark animations/trigger-container-scroll-boundaries.html as failure on iOS

According to Dean Jackson this feature is not supported on iOS at this time.

* platform/ios-simulator-wk1/TestExpectations: Move existing animation trigger failure expectations from here...
* platform/ios-simulator-wk2/TestExpectations: and here...
* platform/ios-simulator/TestExpectations: to here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd initial support for doubles in WebAssembly
commit-queue@webkit.org [Tue, 8 Sep 2015 17:39:35 +0000 (17:39 +0000)]
Add initial support for doubles in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148913

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-09-08
Reviewed by Filip Pizlo.

Implement the ConstantPoolIndex, Immediate, and GetLocal instructions
for doubles (float64) in WebAssembly.

* tests/stress/wasm-arithmetic-float64.js: Added.
(shouldBe):
* tests/stress/wasm/arithmetic-float64.wasm: Added.
* wasm/WASMConstants.h:
* wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::buildSetLocal):
(JSC::WASMFunctionCompiler::buildReturn):
(JSC::WASMFunctionCompiler::buildImmediateI32):
(JSC::WASMFunctionCompiler::buildImmediateF64):
(JSC::WASMFunctionCompiler::buildGetLocal):
* wasm/WASMFunctionParser.cpp:
(JSC::WASMFunctionParser::parseExpression):
(JSC::WASMFunctionParser::parseExpressionF64):
(JSC::WASMFunctionParser::parseConstantPoolIndexExpressionF64):
(JSC::WASMFunctionParser::parseImmediateExpressionF64):
(JSC::WASMFunctionParser::parseGetLocalExpressionF64):
* wasm/WASMFunctionParser.h:
* wasm/WASMFunctionSyntaxChecker.h:
(JSC::WASMFunctionSyntaxChecker::buildImmediateF64):
* wasm/WASMReader.cpp:
(JSC::WASMReader::readOpExpressionF64):
* wasm/WASMReader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoCallLinkInfo inside StructureStubInfo should not use polymorphic stubs
fpizlo@apple.com [Tue, 8 Sep 2015 17:25:28 +0000 (17:25 +0000)]
CallLinkInfo inside StructureStubInfo should not use polymorphic stubs
https://bugs.webkit.org/show_bug.cgi?id=148915

Reviewed by Mark Lam.

There is a subtle bug where if we reset a get_by_id IC that had a getter stub that in
turn had a polymorphic call stub, then the GC won't know to keep the getter stub alive.
This patch documents the bug in a FIXME and disables polymorphic call optimizations for
getters. It also just so happens that the polymorphic call optimizations usually don't
benefit getters, since it's hard to create polymorphism at the point of call without also
introducing polymorphism in the base object's structure.

The added test doesn't reproduce the problem, because it's hard to get the GC to delete
all of the stubs.

* bytecode/CallLinkInfo.h:
(JSC::CallLinkInfo::CallLinkInfo):
(JSC::CallLinkInfo::setCallLocations):
(JSC::CallLinkInfo::allowStubs):
(JSC::CallLinkInfo::disallowStubs):
(JSC::CallLinkInfo::setUpCallFromFTL):
* jit/Repatch.cpp:
(JSC::generateByIdStub):
(JSC::linkFor):
(JSC::linkPolymorphicCall):
* tests/stress/poly-call-stub-in-getter-stub.js: Added.
(foo):
(makeGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoThe put_by_id IC store barrier contract should benefit transition over replace
fpizlo@apple.com [Tue, 8 Sep 2015 17:00:05 +0000 (17:00 +0000)]
The put_by_id IC store barrier contract should benefit transition over replace
https://bugs.webkit.org/show_bug.cgi?id=148943

Reviewed by Mark Lam.

Previously, we would only emit a barrier if the value being stored was possibly a cell, so
the transition stub code generator would have to emit a barrier for the store of the
structure, just in case the structure was newer than the base object.

This changes the contract so that the put_by_id callsite would always have a barrier on the
base (except if it proved that the base was brand new). That way, the transition doesn't have
to have a barrier unless it allocates.

This is meant to be a perf-neutral change that I need for the IC refactoring in
https://bugs.webkit.org/show_bug.cgi?id=148717.

* dfg/DFGFixupPhase.cpp:
(JSC::DFG::FixupPhase::fixupNode):
* dfg/DFGStoreBarrierInsertionPhase.cpp:
* jit/Repatch.cpp:
(JSC::emitPutTransitionStub):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark fast/dom/rtl-scroll-to-leftmost-and-resize.html as a flaky timeout for
ap@apple.com [Tue, 8 Sep 2015 16:54:58 +0000 (16:54 +0000)]
Mark fast/dom/rtl-scroll-to-leftmost-and-resize.html as a flaky timeout for
https://bugs.webkit.org/show_bug.cgi?id=148951

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoConvert manual test added in http://trac.webkit.org/changeset/70321 to an automated...
dbates@webkit.org [Tue, 8 Sep 2015 16:01:47 +0000 (16:01 +0000)]
Convert manual test added in trac.webkit.org/changeset/70321 to an automated test
https://bugs.webkit.org/show_bug.cgi?id=74729
<rdar://problem/22550195>

Reviewed by Jon Honeycutt.

.:

* ManualTests/compositing/resources/composited-subframe.html: Removed.
* ManualTests/compositing/show-composited-iframe-on-back-button.html: Removed.

LayoutTests:

* compositing/resources/composited-subframe.html: Added.
* compositing/resources/show-composited-iframe-on-back-button.css: Added.
(.container):
(.box):
* compositing/show-composited-iframe-on-back-button-expected.html: Added.
* compositing/show-composited-iframe-on-back-button.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDashboard: Remove use of z-index for ring overlay; use DOM ordering
dbates@webkit.org [Tue, 8 Sep 2015 15:58:33 +0000 (15:58 +0000)]
Dashboard: Remove use of z-index for ring overlay; use DOM ordering
https://bugs.webkit.org/show_bug.cgi?id=148921

Reviewed by Alexey Proskuryakov.

The ring image is positioned above the platform icon in markup and we specify the CSS
property z-index for the ring image so that it is painted on top of the platform icon
instead of below it (by DOM ordering). Instead we can take advantage of the transparency
of the ring image, switch the order of these DOM elements and remove the use of the CSS
property z-index to achieve a similar effect.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/Main.js:
(documentReady): Create the platform icon image element before the ring image such that
the ring image is painted on top of the platform icon.
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(table.queue-grid td.logo img.ring): Removed property z-index.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoDashboard: Remove duplicate gear icon data URLs
dbates@webkit.org [Tue, 8 Sep 2015 15:57:58 +0000 (15:57 +0000)]
Dashboard: Remove duplicate gear icon data URLs
https://bugs.webkit.org/show_bug.cgi?id=148920

Reviewed by Alexey Proskuryakov.

Currently we duplicate the SVG data URL for the gear icon up to its fill color in the CSS property
background-image associated with each of the three gear icon states: collapsed (.settings), hover
(.settings:hover), and expanded (.settings-visible .settings). Instead we should use the gear icon
as a mask and make use of the CSS background-color to define the fill color for each of these three
states.

* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Styles/Main.css:
(.settings): Use gear icon as mask and define CSS background-color for collapsed state.
(.settings:hover): Override CSS background-color for hover state.
(.settings-visible .settings): Override CSS background-color for expanded state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Unreviewed GTK gardening.
clopez@igalia.com [Tue, 8 Sep 2015 15:43:19 +0000 (15:43 +0000)]
[GTK] Unreviewed GTK gardening.

Update some paths for tests that were renamed.
Remove some tests from the expectations that not longer exist.
Report new failures for the Debug build.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, land iOS baselines for a couple of html/dom tests.
cdumez@apple.com [Tue, 8 Sep 2015 15:25:53 +0000 (15:25 +0000)]
Unreviewed, land iOS baselines for a couple of html/dom tests.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-1-expected.txt: Added.
* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoReduce uses of PassRefPtr in fileapi
gyuyoung.kim@webkit.org [Tue, 8 Sep 2015 10:50:42 +0000 (10:50 +0000)]
Reduce uses of PassRefPtr in fileapi
https://bugs.webkit.org/show_bug.cgi?id=148952

Reviewed by Andreas Kling.

Remove all uses of PassRefPtr in return type. Argument uses of PassRefPtr will be
removed in near future.

* fileapi/FileError.h:
(WebCore::FileError::create):
* fileapi/FileReader.cpp:
(WebCore::FileReader::arrayBufferResult):
* fileapi/FileReader.h:
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::arrayBufferResult):
* fileapi/FileReaderLoader.h:
* fileapi/FileReaderSync.cpp:
(WebCore::FileReaderSync::readAsArrayBuffer):
* fileapi/FileReaderSync.h:
* fileapi/ThreadableBlobRegistry.cpp:
(WebCore::ThreadableBlobRegistry::getCachedOrigin):
* fileapi/ThreadableBlobRegistry.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLayoutTests/imported/w3c:
cdumez@apple.com [Tue, 8 Sep 2015 06:48:54 +0000 (06:48 +0000)]
LayoutTests/imported/w3c:
Unreviewed, fixup a few recently imported W3C HTML tests.

A few support files were missing.

* web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/blank.htm: Added.
* web-platform-tests/html/semantics/embedded-content/the-iframe-element/support/sandbox_allow_script.html: Added.
* web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/dirname-ltr.html:
* web-platform-tests/html/semantics/forms/attributes-common-to-form-controls/resources/dirname-ltr-iframe.html: Added.
* web-platform-tests/html/semantics/selectors/pseudo-classes/focus-expected.txt:
* web-platform-tests/html/semantics/selectors/pseudo-classes/focus.html:
* web-platform-tests/html/semantics/selectors/pseudo-classes/resources/focus-iframe.html: Added.

LayoutTests:
Unreviewed gardening.

Update Window baselines for a couple of W3C HTML tests.

* platform/win/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/sizes/parse-a-sizes-attribute-expected.txt:
* platform/win/imported/w3c/web-platform-tests/html/semantics/embedded-content/the-img-element/update-the-source-set-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
cfleizach@apple.com [Tue, 8 Sep 2015 06:24:21 +0000 (06:24 +0000)]
AX: Mavericks: Text cursor does not move along with VoiceOver cursor for text fields
https://bugs.webkit.org/show_bug.cgi?id=148891

Reviewed by Mario Sanchez Prada.

Source/WebCore:

Undo the asynchronous dispatch of accessibility setting values on pre El Capitan machines
because it causes focus to not sync correctly.

Test: accessibility/mac/focus-moves-cursor.html

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilitySetValue:forAttribute:]):
(-[WebAccessibilityObjectWrapper _accessibilitySetValue:forAttribute:]):

LayoutTests:

* accessibility/mac/focus-moves-cursor-expected.txt: Added.
* accessibility/mac/focus-moves-cursor.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, update iOS baseline for imported/w3c/web-platform-tests/html/dom/interfac...
cdumez@apple.com [Tue, 8 Sep 2015 06:20:56 +0000 (06:20 +0000)]
Unreviewed, update iOS baseline for imported/w3c/web-platform-tests/html/dom/interfaces.html.

* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, drop unfinished W3C DOM tests.
cdumez@apple.com [Tue, 8 Sep 2015 06:18:55 +0000 (06:18 +0000)]
Unreviewed, drop unfinished W3C DOM tests.

Those were not meant to be imported.

* web-platform-tests/dom/traversal/unfinished/001-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/001.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/002-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/002.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/003-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/003.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/004-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/004.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/005-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/005.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/006-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/006.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/007-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/007.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/008-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/008.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/009-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/009.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/010-expected.txt: Removed.
* web-platform-tests/dom/traversal/unfinished/010.xml: Removed.
* web-platform-tests/dom/traversal/unfinished/TODO: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, drop several W3C html media that were recently imported as they are flaky.
cdumez@apple.com [Tue, 8 Sep 2015 06:14:37 +0000 (06:14 +0000)]
Unreviewed, drop several W3C html media that were recently imported as they are flaky.

* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-insert-before-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-insert-before.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-moved-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-moved.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-addEventListener-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-no-listener-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-candidate-remove-no-listener.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor-no-src-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor-no-src.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-audio-constructor.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-in-sync-event-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-in-sync-event.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-fragment-into-document-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-fragment-into-document.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-into-document-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-into-document.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-parent-into-document-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-parent-into-document.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-in-div-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-in-div.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-in-namespace-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-in-namespace.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-networkState-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-networkState.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-not-in-document-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source-not-in-document.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-source.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-load-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-load.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-pause-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-pause-networkState-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-pause-networkState.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-pause.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-play-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-play.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document-networkState-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document-networkState.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-from-document.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-src-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-remove-src.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-in-namespace-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-in-namespace.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-networkState-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-networkState.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-control-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-control.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-br-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-br.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-source-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-source.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-insert-text.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-after-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-after.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-source.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-text-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-pointer-remove-text.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-source-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-source.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-src-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-remove-src.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-source-media.html: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/networkState_during_progress-expected.txt: Removed.
* web-platform-tests/html/semantics/embedded-content/media-elements/networkState_during_progress.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, skip imported/w3c/web-platform-tests/html/semantics/document-metadata...
cdumez@apple.com [Tue, 8 Sep 2015 05:43:39 +0000 (05:43 +0000)]
Unreviewed, skip imported/w3c/web-platform-tests/html/semantics/document-metadata/the-base-element/base_href_specified.sub.html

This test causes the next one to be flaky. The issue is tracked by
Bug 148950.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, drop W3C support files from http/
cdumez@apple.com [Tue, 8 Sep 2015 05:31:29 +0000 (05:31 +0000)]
Unreviewed, drop W3C support files from http/

Drop W3C support files from http/tests/resources/ and
http/tests/w3c/resources/. These were recently added and are not longer
needed that that the w3c web-platform-tests were moved to imported/w3c.

* http/tests/resources/WebIDLParser.js: Removed.
* http/tests/resources/idlharness.js: Removed.
* http/tests/resources/testharness.css: Removed.
* http/tests/resources/testharness.js: Removed.
* http/tests/resources/testharnessreport.js: Removed.
* http/tests/w3c/resources/css-red.txt: Removed.
* http/tests/w3c/resources/media.js: Removed.
* http/tests/w3c/resources/media/A4.mp4: Removed.
* http/tests/w3c/resources/media/A4.ogv: Removed.
* http/tests/w3c/resources/media/foo.vtt: Removed.
* http/tests/w3c/resources/media/foo.vtt.headers: Removed.
* http/tests/w3c/resources/media/green-at-15.mp4: Removed.
* http/tests/w3c/resources/media/green-at-15.ogv: Removed.
* http/tests/w3c/resources/media/movie_300.mp4: Removed.
* http/tests/w3c/resources/media/movie_300.ogv: Removed.
* http/tests/w3c/resources/media/movie_5.mp4: Removed.
* http/tests/w3c/resources/media/movie_5.ogv: Removed.
* http/tests/w3c/resources/media/poster.png: Removed.
* http/tests/w3c/resources/media/sound_5.mp3: Removed.
* http/tests/w3c/resources/media/sound_5.oga: Removed.
* http/tests/w3c/resources/media/white.mp4: Removed.
* http/tests/w3c/resources/media/white.webm: Removed.
* http/tests/w3c/resources/stringifiers.js: Removed.
* http/tests/w3c/resources/utils.js: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed fixup after r189471 and r189472.
cdumez@apple.com [Tue, 8 Sep 2015 05:23:40 +0000 (05:23 +0000)]
Unreviewed fixup after r189471 and r189472.

LayoutTests/imported/w3c:

* web-platform-tests/common/blank.html: Added.
Add missing file used by some tests.

* web-platform-tests/dom/nodes/Node-parentNode-iframe-expected.txt: Removed.
* web-platform-tests/dom/nodes/Node-parentNode.html:
* web-platform-tests/dom/nodes/resources/Node-parentNode-iframe.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/dom/nodes/Node-parentNode-iframe.html.
Move html file to resources folder so that WRT does not think it is a test.

LayoutTests:

* platform/win/TestExpectations:
Skip a couple of failing tests on Windows.

* platform/win/imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-1-expected.txt: Added.
* platform/win/imported/w3c/web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-2-expected.txt: Added.
Land Windows baselines.

* platform/win/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt:
Rebaseline for Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, move html/semantics W3C tests to imported/w3c/web-platform-tests/html...
cdumez@apple.com [Tue, 8 Sep 2015 05:08:45 +0000 (05:08 +0000)]
Unreviewed, move html/semantics W3C tests to imported/w3c/web-platform-tests/html/semantics
https://bugs.webkit.org/show_bug.cgi?id=148949

LayoutTests/imported/w3c:

* web-platform-tests/html/semantics/*: Added.

LayoutTests:

* TestExpectations:
* http/tests/w3c/html/semantics/*: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLayoutTests/imported/w3c:
cdumez@apple.com [Tue, 8 Sep 2015 03:52:01 +0000 (03:52 +0000)]
LayoutTests/imported/w3c:
Unreviewed, fix-up for r189472.

- Add a few missing test expectations.
- Rename ref-tests expected results to use proper format: -expected.html

* web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-1-expected.txt: Added.
* web-platform-tests/html/dom/dynamic-markup-insertion/document-write/nested-document-write-2-expected.txt: Added.
* web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/004-1-expected.txt: Added.
* web-platform-tests/html/dom/dynamic-markup-insertion/opening-the-input-stream/016-1-expected.txt: Added.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-EN-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-EN-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-EN-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-N-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-bdi-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-bdi-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-bdi-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-bdi-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-dir_auto-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-L-expected.txt: Removed.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-script-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-style-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-style-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-style-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-style-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-textarea-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-textarea-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-textarea-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-contained-textarea-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-EN-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-EN-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-EN-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-N-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-EN-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-EN-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-EN-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-L-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-L-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-N-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-R-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-input-script-R-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-isolate-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-isolate-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-EN-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-between-Rs-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-N-between-Rs-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-mixed-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-pre-mixed-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-EN-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-between-Rs-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-between-Rs-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-mixed-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-mixed-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-EN-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-N-EN-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-N-between-Rs-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-script-mixed-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/dir_auto-textarea-mixed-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/lang-xmllang-01-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/lang-xmllang-01-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/lang-xyzzy-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/lang-xyzzy-ref.html.
* web-platform-tests/html/dom/elements/global-attributes/style-01-expected.html: Renamed from LayoutTests/imported/w3c/web-platform-tests/html/dom/elements/global-attributes/style-01-ref.html.

LayoutTests:
Unreviewed, Skip again files that were wrongly unskipped in r189472.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Unreviewed gardening. tests of imported/w3c/css/ have been passed since r189358.
gyuyoung.kim@webkit.org [Tue, 8 Sep 2015 02:53:17 +0000 (02:53 +0000)]
[EFL] Unreviewed gardening. tests of imported/w3c/css/ have been passed since r189358.
Those tests seem to be failed on other ports though, those are passing on EFL port.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[CoordinatedGraphics] Remove ScrollingStateScrollingNodeCoordinatedGraphics.cpp
gyuyoung.kim@webkit.org [Tue, 8 Sep 2015 02:13:13 +0000 (02:13 +0000)]
[CoordinatedGraphics] Remove ScrollingStateScrollingNodeCoordinatedGraphics.cpp
https://bugs.webkit.org/show_bug.cgi?id=148931

Reviewed by Csaba Osztrogon√°c.

ScrollingStateScrollingNodeCoordinatedGraphics.cpp implements nothing. Removed it.

* PlatformEfl.cmake:
* PlatformGTK.cmake:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* page/scrolling/coordinatedgraphics/ScrollingStateScrollingNodeCoordinatedGraphics.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, move html/dom W3C tests to imported/w3c/web-platform-tests/html/dom/
cdumez@apple.com [Tue, 8 Sep 2015 02:07:49 +0000 (02:07 +0000)]
Unreviewed, move html/dom W3C tests to imported/w3c/web-platform-tests/html/dom/
https://bugs.webkit.org/show_bug.cgi?id=148948

LayoutTests/imported/w3c:

* web-platform-tests/html/dom/*: Added.

LayoutTests:

* TestExpectations:
* http/tests/w3c/html/dom/*: Removed.
* platform/efl/TestExpectations:
* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt: Renamed from LayoutTests/platform/ios-simulator/http/tests/w3c/html/dom/documents/dom-tree-accessors/document.getElementsByName/document.getElementsByName-newelements-expected.txt.
* platform/ios-simulator/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Renamed from LayoutTests/platform/ios-simulator/http/tests/w3c/html/dom/interfaces-expected.txt.
* platform/win/imported/w3c/web-platform-tests/html/dom/interfaces-expected.txt: Renamed from LayoutTests/platform/win/http/tests/w3c/html/dom/interfaces-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, move W3C DOM tests to imported/w3c/web-platform-tests/dom
cdumez@apple.com [Tue, 8 Sep 2015 01:09:45 +0000 (01:09 +0000)]
Unreviewed, move W3C DOM tests to imported/w3c/web-platform-tests/dom
https://bugs.webkit.org/show_bug.cgi?id=148947

Move W3C DOM tests with other web-platform-tests under:
imported/w3c/web-platform-tests/dom.

LayoutTests/imported/w3c:

* web-platform-tests/dom/*: Added.

LayoutTests:

* TestExpectations:
* http/tests/w3c/dom/collections/w3c-import.log: Removed.
* http/tests/w3c/dom/events/w3c-import.log: Removed.
* http/tests/w3c/dom/lists/w3c-import.log: Removed.
* http/tests/w3c/dom/nodes/Document-URL.sub-expected.txt: Removed.
* http/tests/w3c/dom/nodes/Document-characterSet-normalization-expected.txt: Removed.
* http/tests/w3c/dom/nodes/DocumentType-literal-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/Element-childElementCount-dynamic-add-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/Element-childElementCount-nochild-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/Element-firstElementChild-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/Element-nextElementSibling-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/Element-previousElementSibling-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/Node-isEqualNode-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/Node-lookupPrefix-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/ProcessingInstruction-literal-1-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/ProcessingInstruction-literal-2-xhtml-expected.txt: Removed.
* http/tests/w3c/dom/nodes/getElementsByClassName-10-expected.txt: Removed.
* http/tests/w3c/dom/nodes/getElementsByClassName-11-expected.txt: Removed.
* http/tests/w3c/dom/nodes/getElementsByClassName-31-expected.txt: Removed.
* http/tests/w3c/dom/nodes/w3c-import.log: Removed.
* http/tests/w3c/dom/ranges/w3c-import.log: Removed.
* http/tests/w3c/dom/traversal/w3c-import.log: Removed.
* http/tests/w3c/dom/w3c-import.log: Removed.
* platform/efl/TestExpectations:
* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a...
aestes@apple.com [Mon, 7 Sep 2015 23:05:28 +0000 (23:05 +0000)]
[Mac] DebugRelease builds should link against libWebKitSystemInterfaceElCapitan.a on 10.11
https://bugs.webkit.org/show_bug.cgi?id=148946
<rdar://problem/22603981>

Reviewed by Dan Bernstein.

Source/WebKit/mac:

* Configurations/DebugRelease.xcconfig:

Source/WebKit2:

* Configurations/DebugRelease.xcconfig:

Tools:

* DumpRenderTree/mac/Configurations/DebugRelease.xcconfig:
* WebKitTestRunner/Configurations/DebugRelease.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoASSERT_WITH_SECURITY_IMPLICATION in WebCore::DocumentOrderedMap::get(); update form
dbates@webkit.org [Mon, 7 Sep 2015 22:46:43 +0000 (22:46 +0000)]
ASSERT_WITH_SECURITY_IMPLICATION in WebCore::DocumentOrderedMap::get(); update form
association after subtree insertion
https://bugs.webkit.org/show_bug.cgi?id=148919
<rdar://problem/21868036>

Patch by Daniel Bates <dabates@apple.com> on 2015-09-07
Reviewed by Andy Estes.

Source/WebCore:

Currently we update the form association of a form control upon insertion into
the document. Instead we should update the form association of a form control
after its containing subtree is inserted into the document to avoid an assertion
failure when the containing subtree has an element whose id is identical to both
the id of some other element in the document and the name of the form referenced
by the inserted form control.

Tests: fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2.html
       fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3.html
       fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4.html
       fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html

* html/FormAssociatedElement.cpp:
(WebCore::FormAssociatedElement::insertedInto): Moved resetFormOwner() from here
to {HTMLFormControlElement, HTMLObjectElement}::finishedInsertingSubtree().
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::insertedInto): Return InsertionShouldCallFinishedInsertingSubtree
so that HTMLFormControlElement::finishedInsertingSubtree() is called.
(WebCore::HTMLFormControlElement::finishedInsertingSubtree): Added; turn around and
call FormAssociatedElement::resetFormOwner().
* html/HTMLFormControlElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::insertedInto): Return InsertionShouldCallFinishedInsertingSubtree so
that HTMLInputElement::finishedInsertingSubtree() is called and move logic to update radio button
group from here...
(WebCore::HTMLInputElement::finishedInsertingSubtree): to here.
* html/HTMLInputElement.h:
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::insertedInto): Return InsertionShouldCallFinishedInsertingSubtree so
that HTMLObjectElement::finishedInsertingSubtree() is called.
(WebCore::HTMLObjectElement::finishedInsertingSubtree): Added; turn around and
call FormAssociatedElement::resetFormOwner().
* html/HTMLObjectElement.h:
* html/HTMLSelectElement.cpp:
(WebCore::HTMLSelectElement::insertedInto): Modified to return the result of
HTMLFormControlElementWithState::insertedInto(), which may schedule a callback after subtree
insertion.
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::insertedInto): Ditto.

LayoutTests:

Add tests to ensure that updating the form association of a form control in a subtree
does not cause an assertion failure.

* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2-expected.txt: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-2.html: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3-expected.txt: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-3.html: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4-expected.txt: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-4.html: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure-expected.txt: Added.
* fast/forms/update-form-owner-in-moved-subtree-assertion-failure.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWindows non-cygwin build fix after r189333.
achristensen@apple.com [Mon, 7 Sep 2015 22:46:32 +0000 (22:46 +0000)]
Windows non-cygwin build fix after r189333.

SVN on Windows (non-cygwin) doesn't like having the * character in file names.
I replaced "*" with "star" in some of Geoff's new tests.

* tests/es6.yaml:
Changed all _*_ to _star_
* tests/es6/generators_yield_*_arrays.js: Removed.
* tests/es6/generators_yield_*_astral_plane_strings.js: Removed.
* tests/es6/generators_yield_*_generator_instances.js: Removed.
* tests/es6/generators_yield_*_generic_iterables.js: Removed.
* tests/es6/generators_yield_*_instances_of_iterables.js: Removed.
* tests/es6/generators_yield_*_iterator_closing.js: Removed.
* tests/es6/generators_yield_*_iterator_closing_via_throw.js: Removed.
* tests/es6/generators_yield_*_on_non-iterables_is_a_runtime_error.js: Removed.
* tests/es6/generators_yield_*_sparse_arrays.js: Removed.
* tests/es6/generators_yield_*_strings.js: Removed.
* tests/es6/generators_yield_star_arrays.js: Copied from tests/es6/generators_yield_*_arrays.js.
* tests/es6/generators_yield_star_astral_plane_strings.js: Copied from tests/es6/generators_yield_*_astral_plane_strings.js.
* tests/es6/generators_yield_star_generator_instances.js: Copied from tests/es6/generators_yield_*_generator_instances.js.
* tests/es6/generators_yield_star_generic_iterables.js: Copied from tests/es6/generators_yield_*_generic_iterables.js.
* tests/es6/generators_yield_star_instances_of_iterables.js: Copied from tests/es6/generators_yield_*_instances_of_iterables.js.
* tests/es6/generators_yield_star_iterator_closing.js: Copied from tests/es6/generators_yield_*_iterator_closing.js.
* tests/es6/generators_yield_star_iterator_closing_via_throw.js: Copied from tests/es6/generators_yield_*_iterator_closing_via_throw.js.
* tests/es6/generators_yield_star_on_non-iterables_is_a_runtime_error.js: Copied from tests/es6/generators_yield_*_on_non-iterables_is_a_runtime_error.js.
* tests/es6/generators_yield_star_sparse_arrays.js: Copied from tests/es6/generators_yield_*_sparse_arrays.js.
* tests/es6/generators_yield_star_strings.js: Copied from tests/es6/generators_yield_*_strings.js.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[GTK] Unreviewed GTK gardening.
clopez@igalia.com [Mon, 7 Sep 2015 20:12:59 +0000 (20:12 +0000)]
[GTK] Unreviewed GTK gardening.

Report and mark new failures on the GTK TestExpectations file.
Move back all the GTK baselines for the general accessibiliy tests to platform/gtk that r187777 wrongly moved inside accessibility/gtk.

* accessibility/gtk/disabled-controls-not-focusable-expected.txt: Removed. Same baseline than the general one so not need to move it back to platform/gtk/accessibility.
* platform/gtk/TestExpectations:
* platform/gtk/accessibility/aria-checkbox-sends-notification-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-checkbox-sends-notification-expected.txt.
* platform/gtk/accessibility/aria-fallback-roles-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-fallback-roles-expected.txt.
* platform/gtk/accessibility/aria-help-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-help-expected.txt.
* platform/gtk/accessibility/aria-hidden-false-works-in-subtrees-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-hidden-false-works-in-subtrees-expected.txt.
* platform/gtk/accessibility/aria-inherits-presentational-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-inherits-presentational-expected.txt.
* platform/gtk/accessibility/aria-menubar-menuitems-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-menubar-menuitems-expected.txt.
* platform/gtk/accessibility/aria-switch-text-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-switch-text-expected.txt.
* platform/gtk/accessibility/aria-table-hierarchy-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-table-hierarchy-expected.txt.
* platform/gtk/accessibility/aria-toggle-button-with-title-expected.txt: Renamed from LayoutTests/accessibility/gtk/aria-toggle-button-with-title-expected.txt.
* platform/gtk/accessibility/color-well-expected.txt: Renamed from LayoutTests/accessibility/gtk/color-well-expected.txt.
* platform/gtk/accessibility/css-content-attribute-expected.txt: Renamed from LayoutTests/accessibility/gtk/css-content-attribute-expected.txt.
* platform/gtk/accessibility/dimensions-include-descendants-expected.txt: Renamed from LayoutTests/accessibility/gtk/dimensions-include-descendants-expected.txt.
* platform/gtk/accessibility/file-upload-button-stringvalue-expected.txt: Renamed from LayoutTests/accessibility/gtk/file-upload-button-stringvalue-expected.txt.
* platform/gtk/accessibility/image-link-expected.txt: Renamed from LayoutTests/accessibility/gtk/image-link-expected.txt.
* platform/gtk/accessibility/image-map1-expected.txt: Renamed from LayoutTests/accessibility/gtk/image-map1-expected.txt.
* platform/gtk/accessibility/image-map2-expected.txt: Renamed from LayoutTests/accessibility/gtk/image-map2-expected.txt.
* platform/gtk/accessibility/image-with-alt-and-map-expected.txt: Renamed from LayoutTests/accessibility/gtk/image-with-alt-and-map-expected.txt.
* platform/gtk/accessibility/img-fallsback-to-title-expected.txt: Renamed from LayoutTests/accessibility/gtk/img-fallsback-to-title-expected.txt.
* platform/gtk/accessibility/inline-continuations-expected.txt: Renamed from LayoutTests/accessibility/gtk/inline-continuations-expected.txt.
* platform/gtk/accessibility/list-detection-expected.txt: Renamed from LayoutTests/accessibility/gtk/list-detection-expected.txt.
* platform/gtk/accessibility/lists-expected.txt: Renamed from LayoutTests/accessibility/gtk/lists-expected.txt.
* platform/gtk/accessibility/math-multiscript-attributes-expected.txt: Renamed from LayoutTests/accessibility/gtk/math-multiscript-attributes-expected.txt.
* platform/gtk/accessibility/math-text-expected.txt: Renamed from LayoutTests/accessibility/gtk/math-text-expected.txt.
* platform/gtk/accessibility/media-element-expected.txt: Renamed from LayoutTests/accessibility/gtk/media-element-expected.txt.
* platform/gtk/accessibility/menu-list-crash2-expected.txt: Renamed from LayoutTests/accessibility/gtk/menu-list-crash2-expected.txt.
* platform/gtk/accessibility/menu-list-sends-change-notification-expected.txt: Renamed from LayoutTests/accessibility/gtk/menu-list-sends-change-notification-expected.txt.
* platform/gtk/accessibility/meter-element-expected.txt: Renamed from LayoutTests/accessibility/gtk/meter-element-expected.txt.
* platform/gtk/accessibility/platform-name-expected.txt: Renamed from LayoutTests/accessibility/gtk/platform-name-expected.txt.
* platform/gtk/accessibility/plugin-expected.txt: Renamed from LayoutTests/accessibility/gtk/plugin-expected.txt.
* platform/gtk/accessibility/press-targets-center-point-expected.txt: Renamed from LayoutTests/accessibility/gtk/press-targets-center-point-expected.txt.
* platform/gtk/accessibility/radio-button-title-label-expected.txt: Renamed from LayoutTests/accessibility/gtk/radio-button-title-label-expected.txt.
* platform/gtk/accessibility/render-counter-text-expected.txt: Renamed from LayoutTests/accessibility/gtk/render-counter-text-expected.txt.
* platform/gtk/accessibility/roles-computedRoleString-expected.txt: Renamed from LayoutTests/accessibility/gtk/roles-computedRoleString-expected.txt.
* platform/gtk/accessibility/roles-exposed-expected.txt: Renamed from LayoutTests/accessibility/gtk/roles-exposed-expected.txt.
* platform/gtk/accessibility/spinbutton-value-expected.txt: Renamed from LayoutTests/accessibility/gtk/spinbutton-value-expected.txt.
* platform/gtk/accessibility/tabindex-elements-are-accessible-expected.txt: Renamed from LayoutTests/accessibility/gtk/tabindex-elements-are-accessible-expected.txt.
* platform/gtk/accessibility/table-attributes-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-attributes-expected.txt.
* platform/gtk/accessibility/table-cell-spans-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-cell-spans-expected.txt.
* platform/gtk/accessibility/table-cells-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-cells-expected.txt.
* platform/gtk/accessibility/table-column-headers-with-captions-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-column-headers-with-captions-expected.txt.
* platform/gtk/accessibility/table-detection-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-detection-expected.txt.
* platform/gtk/accessibility/table-hierarchy-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-hierarchy-expected.txt.
* platform/gtk/accessibility/table-one-cell-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-one-cell-expected.txt.
* platform/gtk/accessibility/table-roles-hierarchy-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-roles-hierarchy-expected.txt.
* platform/gtk/accessibility/table-sections-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-sections-expected.txt.
* platform/gtk/accessibility/table-with-rules-expected.txt: Renamed from LayoutTests/accessibility/gtk/table-with-rules-expected.txt.
* platform/gtk/accessibility/transformed-element-expected.txt: Renamed from LayoutTests/accessibility/gtk/transformed-element-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove GlyphPage::mayUseMixedFontsWhenFilling
antti@apple.com [Mon, 7 Sep 2015 18:26:46 +0000 (18:26 +0000)]
Remove GlyphPage::mayUseMixedFontsWhenFilling
https://bugs.webkit.org/show_bug.cgi?id=148928

Reviewed by Dan Bernstein.

http://trac.webkit.org/188566 removed support for composite fonts. We never need to use mixed
glyph pages for fonts anymore.

* platform/graphics/Font.cpp:
(WebCore::createAndFillGlyphPage):
* platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::GlyphPage):
(WebCore::GlyphPage::mayUseMixedFontsWhenFilling): Deleted.
* platform/graphics/mac/GlyphPageMac.cpp:
(WebCore::shouldUseCoreText):
(WebCore::GlyphPage::fill):
(WebCore::GlyphPage::mayUseMixedFontsWhenFilling): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove unneeded offset and length arguments from glyph page filling functions
antti@apple.com [Mon, 7 Sep 2015 17:42:50 +0000 (17:42 +0000)]
Remove unneeded offset and length arguments from glyph page filling functions
https://bugs.webkit.org/show_bug.cgi?id=148929

Reviewed by Andreas Kling.

They are always passed 0/GlyphPage::size.

* platform/graphics/Font.cpp:
(WebCore::Font::~Font):
(WebCore::fillGlyphPage):
(WebCore::createAndFillGlyphPage):
* platform/graphics/Font.h:
* platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::setGlyphDataForIndex):
* platform/graphics/mac/GlyphPageMac.cpp:
(WebCore::GlyphPage::mayUseMixedFontsWhenFilling):
(WebCore::GlyphPage::fill):
* platform/graphics/win/GlyphPageTreeNodeCGWin.cpp:
(WebCore::GlyphPage::fill):
* platform/graphics/win/GlyphPageTreeNodeCairoWin.cpp:
(WebCore::GlyphPage::fill):
* svg/SVGFontData.cpp:
(WebCore::SVGFontData::applySVGGlyphSelection):
(WebCore::SVGFontData::fillSVGGlyphPage):
(WebCore::SVGFontData::fillBMPGlyphs):
(WebCore::SVGFontData::fillNonBMPGlyphs):
* svg/SVGFontData.h:
(WebCore::SVGFontData::verticalAdvanceY):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years ago[EFL] Many of the css3/device-adapt/* tests failed after r188548.
commit-queue@webkit.org [Mon, 7 Sep 2015 12:34:42 +0000 (12:34 +0000)]
[EFL] Many of the css3/device-adapt/* tests failed after r188548.
https://bugs.webkit.org/show_bug.cgi?id=148927

Patch by Hunseop Jeong <hs85.jeong@samsung.com> on 2015-09-07
Reviewed by Csaba Osztrogon√°c.

device-adapt/* tests need the fixedLayout option but useFixedLayout option is
overwritten by updatePlatformSpecificViewOptionsForTest after r188548.

* WebKitTestRunner/TestController.cpp:
(WTR::shouldUseFixedLayout): Removed the unnecessary indentations.
* WebKitTestRunner/efl/TestControllerEfl.cpp:
(WTR::shouldUseFixedLayout): Return true if the test is related with 'device-adapt'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix the Production build after r189455.
aestes@apple.com [Mon, 7 Sep 2015 07:46:50 +0000 (07:46 +0000)]
Fix the Production build after r189455.

* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Somehow I added the All target using the
In-App Purchase template instead of the Aggregate template. Whoops.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebKit.xcworkspace should be be able to build iOS platforms
aestes@apple.com [Mon, 7 Sep 2015 07:09:21 +0000 (07:09 +0000)]
WebKit.xcworkspace should be be able to build iOS platforms
https://bugs.webkit.org/show_bug.cgi?id=148881

Reviewed by Daniel Bates.

Since we don't want to create platform-specific schemes, all projects in the workspace's schemes need to build
for all supported platforms.

.:

* WebKit.xcworkspace/xcshareddata/xcschemes/All Tools.xcscheme: Removed the DumpRenderTree target since its All
target was already included. Removed the WebKitTestRunner target and replaced it with its All target.

Source/WebInspectorUI:

* Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
* Configurations/WebInspectorUIFramework.xcconfig: Skipped installing on iOS.

Tools:

* MiniBrowser/Configurations/Base.xcconfig: Included iphoneos and iphonesimulator in SUPPORTED_PLATFORMS.
* MiniBrowser/Configurations/MiniBrowser.xcconfig: Excluded all source files on iOS, and linked Cocoa and WebKit on Mac.
* MiniBrowser/Configurations/MiniBrowserBundle.xcconfig: Ditto.
* MiniBrowser/MiniBrowser.xcodeproj/project.pbxproj: Stopped linking frameworks in Link Binaries With Libraries.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, EFL gardening. Many tests have been failed since r188692.
gyuyoung.kim@webkit.org [Mon, 7 Sep 2015 06:47:29 +0000 (06:47 +0000)]
Unreviewed, EFL gardening. Many tests have been failed since r188692.
Bug 148470 will try to fix this problem.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoGardening: fix broken Windows build after r189454.
mark.lam@apple.com [Mon, 7 Sep 2015 06:28:41 +0000 (06:28 +0000)]
Gardening: fix broken Windows build after r189454.

Not reviewed.

* JavaScriptCore.vcxproj/testapi/testapi.vcxproj:
* JavaScriptCore.vcxproj/testapi/testapi.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoAdd one more inspector test that flakily times out.
ap@apple.com [Mon, 7 Sep 2015 06:23:15 +0000 (06:23 +0000)]
Add one more inspector test that flakily times out.

* platform/mac/TestExpectations: Added inspector/indexeddb/requestDatabaseNames.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImplement the relational instructions in WebAssembly
commit-queue@webkit.org [Mon, 7 Sep 2015 06:17:53 +0000 (06:17 +0000)]
Implement the relational instructions in WebAssembly
https://bugs.webkit.org/show_bug.cgi?id=148838

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-09-06
Reviewed by Saam Barati.

This patch implements the relational instructions for 32-bit integers in
WebAssembly.

* tests/stress/wasm-arithmetic.js:
* tests/stress/wasm-locals.js:
* tests/stress/wasm-relational.js: Added.
(shouldBe):
* tests/stress/wasm/arithmetic.wasm: Renamed from Source/JavaScriptCore/tests/stress/wasm-arithmetic.wasm.
* tests/stress/wasm/locals.wasm: Renamed from Source/JavaScriptCore/tests/stress/wasm-locals.wasm.
* tests/stress/wasm/relational.wasm: Added.
* wasm/WASMFunctionCompiler.h:
(JSC::WASMFunctionCompiler::buildRelationalI32):
* wasm/WASMFunctionParser.cpp:
(JSC::WASMFunctionParser::parseExpressionI32):
(JSC::WASMFunctionParser::parseRelationalI32ExpressionI32):
* wasm/WASMFunctionParser.h:
* wasm/WASMFunctionSyntaxChecker.h:
(JSC::WASMFunctionSyntaxChecker::buildRelationalI32):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark svg/dom/svg-root-lengths.html as a flaky failure
ap@apple.com [Mon, 7 Sep 2015 06:14:38 +0000 (06:14 +0000)]
Mark svg/dom/svg-root-lengths.html as a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=148925

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark svg/as-object/svg-in-object-dynamic-attribute-change.html as a flaky failure
ap@apple.com [Mon, 7 Sep 2015 05:56:29 +0000 (05:56 +0000)]
Mark svg/as-object/svg-in-object-dynamic-attribute-change.html as a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=148922

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoWebKitTestRunner should build for iOS using the default target
aestes@apple.com [Mon, 7 Sep 2015 05:39:42 +0000 (05:39 +0000)]
WebKitTestRunner should build for iOS using the default target
https://bugs.webkit.org/show_bug.cgi?id=148918

Reviewed by Daniel Bates.

When WebKitTestRunner was ported to iOS, a separate target (WebKitTestRunnerApp) was created for building the
iOS variant. This is annoying because (1) all tools that invoke xcodebuild need to be taught to build this
non-default target, and (2) a single Xcode scheme cannot be used to build both Mac and iOS variants.

This change adds a new default target (All) and makes it work for both Mac and iOS. Files that were built for
both WebKitTestRunner and WebKitTestRunnerApp are now built in a static library target (WebKitTestRunner (Library)),
and both apps now link this library. Files that are specific to Mac or iOS are excluded on the other platform.
WebKitTestRunnerApp.app (which should be renamed to WebKitTestRunner.app) is skipped when installing on Mac, and
WebKitTestRunner is skipped when installing on iOS.

The target dependency graph now looks like this:

    All
        WebKitTestRunnerApp
            WebKitTestRunner (Library)
                WebKitTestRunnerInjectedBundle
                    Derived Sources
        WebKitTestRunner
            WebKitTestRunner (Library)
                WebKitTestRunnerInjectedBundle
                    Derived Sources

* Scripts/build-webkit: Stopped building the WebKitTestRunnerApp target on iOS.
* Scripts/build-webkittestrunner: Ditto.
* WebKitTestRunner/Configurations/Base.xcconfig: Set SUPPORTED_PLATFORMS to macosx, iphoneos, and iphonesimulator.
* WebKitTestRunner/Configurations/BaseTarget.xcconfig: Set INSTALL_PATH here since it is the same for all targets.
* WebKitTestRunner/Configurations/InjectedBundle.xcconfig: Stopped setting INSTALL_PATH.
* WebKitTestRunner/Configurations/WebKitTestRunner.xcconfig: Moved frameworks from the build phase to here,
excluded iOS-only files, and skipped installing on iOS.
* WebKitTestRunner/Configurations/WebKitTestRunnerApp.xcconfig: Moved frameworks from the build phase to here,
excluded Mac-only files, and skipped installing on Mac.
* WebKitTestRunner/Configurations/WebKitTestRunnerLibrary.xcconfig: Skipped installing always.
* WebKitTestRunner/Makefile: Stopped building the WebKitTestRunnerApp target on iOS.
* WebKitTestRunner/WebKitTestRunner.xcodeproj/project.pbxproj: Added new targets, removed frameworks from
Link Binary With Libraries builds phases, moved common files to the WebKitTestRunner (Library) target, and added
new configuration files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoStackOverflow stack unwinding should stop at native frames.
mark.lam@apple.com [Mon, 7 Sep 2015 05:19:28 +0000 (05:19 +0000)]
StackOverflow stack unwinding should stop at native frames.
https://bugs.webkit.org/show_bug.cgi?id=148749

Reviewed by Michael Saboff.

In the present code, after ping-pong'ing back and forth between native and JS
code a few times, if we have a stack overflow on re-entry into the VM to run
JS code's whose stack frame would overflow the JS stack, the code will end up
unwinding past the native function that is making the call to re-enter the VM.
As a result, any clean up code (e.g. destructors for stack variables) in the
skipped native function frame (and its chain of native function callers) will
not be called.

This patch is based on the Michael Saboff's fix of this issue landed on the
jsc-tailcall branch: http://trac.webkit.org/changeset/188555

We now check for the case where there are no JS frames to unwind since the
last native frame, and treat the exception as an unhandled exception.  The
native function is responsible for further propagating the exception if needed.

Other supporting work:
1. Remove vm->vmEntryFrameForThrow.  It should always be the same as
   vm->topVMEntryFrame.
2. Change operationThrowStackOverflowError() to use the throwStackOverflowError()
   helper function instead of rolling its own.
3. Added a test that exercises this edge case.  The test should not hang or crash.

* API/tests/PingPongStackOverflowTest.cpp: Added.
(PingPongStackOverflowObject_hasInstance):
(testPingPongStackOverflow):
* API/tests/PingPongStackOverflowTest.h: Added.
* API/tests/testapi.c:
(main):
* JavaScriptCore.xcodeproj/project.pbxproj:
* interpreter/CallFrame.h:
(JSC::ExecState::operator=):
(JSC::ExecState::callerFrame):
(JSC::ExecState::callerFrameOrVMEntryFrame):
(JSC::ExecState::argIndexForRegister):
(JSC::ExecState::callerFrameAndPC):
* interpreter/Interpreter.cpp:
(JSC::UnwindFunctor::UnwindFunctor):
(JSC::UnwindFunctor::operator()):
(JSC::Interpreter::unwind):
* interpreter/Interpreter.h:
(JSC::NativeCallFrameTracer::NativeCallFrameTracer):
(JSC::Interpreter::sampler):
* jit/CCallHelpers.h:
(JSC::CCallHelpers::jumpToExceptionHandler):
* jit/JITExceptions.cpp:
(JSC::genericUnwind):
* jit/JITExceptions.h:
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_catch):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_catch):
* jit/JITOperations.cpp:
* llint/LowLevelInterpreter32_64.asm:
* llint/LowLevelInterpreter64.asm:
* runtime/VM.h:
(JSC::VM::exceptionOffset):
(JSC::VM::callFrameForThrowOffset):
(JSC::VM::vmEntryFrameForThrowOffset): Deleted.
(JSC::VM::topVMEntryFrameOffset): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, disable module tests in Windows until name resolution is fixed
utatane.tea@gmail.com [Mon, 7 Sep 2015 03:10:31 +0000 (03:10 +0000)]
Unreviewed, disable module tests in Windows until name resolution is fixed
https://bugs.webkit.org/show_bug.cgi?id=148689

Until bug[1] is fixed, we disable the module tests.
Since the local file system name resolution is just implemented in jsc.cpp and
is intended to be used for the module tests, it does not affect JSC framework
and WebKit itself.

[1]: https://bugs.webkit.org/show_bug.cgi?id=148917

* tests/modules.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agodispatchEvent() should throw an InvalidStateError if the event's initialized flag...
cdumez@apple.com [Sun, 6 Sep 2015 20:41:48 +0000 (20:41 +0000)]
dispatchEvent() should throw an InvalidStateError if the event's initialized flag is not set
https://bugs.webkit.org/show_bug.cgi?id=148800
<rdar://problem/22565782>
<rdar://problem/22565485>

Reviewed by Geoffrey Garen.

Source/WebCore:

dispatchEvent() should throw an InvalidStateError if the event's
initialized flag is not set or its dispatch flag is set, and should
allow dispatching events with an empty type as long as it is
initialized:
https://dom.spec.whatwg.org/#dom-eventtarget-dispatchevent (step 1)

Previously, WebKit relied on the event type being empty to throw a
UNSPECIFIED_EVENT_TYPE_ERR: DOM Events Exception 0. However, this
exception type is outdated and initializing Event.type to an empty
string is legal.

No new tests, already covered by existing tests that were rebaselined.

* dom/Event.cpp:
(WebCore::Event::Event):
(WebCore::Event::initEvent):
* dom/Event.h:
(WebCore::Event::isInitialized):
* dom/EventTarget.cpp:
(WebCore::EventTarget::dispatchEvent):

LayoutTests:

* dom/html/level2/events/dispatchEvent02-expected.txt:
* dom/html/level2/events/dispatchEvent03-expected.txt:
* dom/html/level2/events/dispatchEvent04-expected.txt:
* dom/html/level2/events/dispatchEvent05-expected.txt:
* dom/html/level2/events/dispatchEvent06-expected.txt:
* dom/html/level2/events/dispatchEvent07-expected.txt:
* dom/xhtml/level2/events/dispatchEvent02-expected.txt:
* dom/xhtml/level2/events/dispatchEvent03-expected.txt:
* dom/xhtml/level2/events/dispatchEvent04-expected.txt:
* dom/xhtml/level2/events/dispatchEvent05-expected.txt:
* dom/xhtml/level2/events/dispatchEvent06-expected.txt:
* dom/xhtml/level2/events/dispatchEvent07-expected.txt:
Rebaseline, those tests are outdated and their expected results no
longer matches the behavior of the latest DOM specification.

* fast/dom/DOMException/EventException-expected.txt: Removed.
* fast/dom/DOMException/EventException.html: Removed.
* fast/dom/DOMException/resources/EventException.js: Removed.
Drop this test we no longer throw an EventException in this case.

* fast/dom/Window/dispatchEvent-expected.txt:
Rebaseline.

* fast/events/dispatch-event-being-dispatched-expected.txt:
* fast/events/dispatch-event-being-dispatched.html:
Fix the test to expect the new exception types.

* http/tests/w3c/dom/events/Event-type-empty-expected.txt:
* http/tests/w3c/dom/events/EventTarget-dispatchEvent-expected.txt:
Rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, drop a few more newly imported W3C media tests that are flaky.
cdumez@apple.com [Sun, 6 Sep 2015 20:34:33 +0000 (20:34 +0000)]
Unreviewed, drop a few more newly imported W3C media tests that are flaky.

* http/tests/w3c/html/semantics/embedded-content/media-elements/loading-the-media-resource/load-events-networkState-expected.txt: Removed.
* http/tests/w3c/html/semantics/embedded-content/media-elements/loading-the-media-resource/load-events-networkState.html: Removed.
* http/tests/w3c/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-not-in-document-expected.txt: Removed.
* http/tests/w3c/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-set-src-not-in-document.html: Removed.
* http/tests/w3c/html/semantics/embedded-content/media-elements/synchronising-multiple-media-elements/media-controllers/task-source-expected.txt: Removed.
* http/tests/w3c/html/semantics/embedded-content/media-elements/synchronising-multiple-media-elements/media-controllers/task-source.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, drop a couple of newly imported W3C media tests as they are flaky.
cdumez@apple.com [Sun, 6 Sep 2015 20:26:42 +0000 (20:26 +0000)]
Unreviewed, drop a couple of newly imported W3C media tests as they are flaky.

* http/tests/w3c/html/semantics/embedded-content/media-elements/loading-the-media-resource/load-removes-queued-error-event-expected.txt: Removed.
* http/tests/w3c/html/semantics/embedded-content/media-elements/loading-the-media-resource/load-removes-queued-error-event.html: Removed.
* http/tests/w3c/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-into-iframe-expected.txt: Removed.
* http/tests/w3c/html/semantics/embedded-content/media-elements/loading-the-media-resource/resource-selection-invoke-insert-into-iframe.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoMark a couple of new W3C ref-tests as failing on iOS.
cdumez@apple.com [Sun, 6 Sep 2015 20:23:12 +0000 (20:23 +0000)]
Mark a couple of new W3C ref-tests as failing on iOS.

* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, land iOS baselines for the newly imported W3C HTML tests.
cdumez@apple.com [Sun, 6 Sep 2015 20:17:45 +0000 (20:17 +0000)]
Unreviewed, land iOS baselines for the newly imported W3C HTML tests.

* platform/ios-simulator/http/tests/w3c/html/semantics/forms/constraints/form-validation-checkValidity-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/constraints/form-validation-reportValidity-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/constraints/form-validation-validity-badInput-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/constraints/form-validation-validity-rangeOverflow-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/constraints/form-validation-validity-rangeUnderflow-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/constraints/form-validation-validity-stepMismatch-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/constraints/form-validation-validity-valid-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/constraints/form-validation-validity-valueMissing-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/constraints/form-validation-willValidate-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/textfieldselection/selection-not-application-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/color-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/date-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/datetime-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/datetime-local-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/input-textselection-01-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/month-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/time-2-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/time-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/type-change-state-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/valueMode-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-input-element/week-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-label-element/labelable-elements-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/forms/the-meter-element/meter-expected.txt: Added.
* platform/ios-simulator/http/tests/w3c/html/semantics/interfaces-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, skip new media tests on iOS.
cdumez@apple.com [Sun, 6 Sep 2015 20:04:31 +0000 (20:04 +0000)]
Unreviewed, skip new media tests on iOS.

* platform/ios-simulator/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, skip http/tests/w3c/html/semantics/embedded-content/media-elements/*...
cdumez@apple.com [Sun, 6 Sep 2015 19:59:31 +0000 (19:59 +0000)]
Unreviewed, skip http/tests/w3c/html/semantics/embedded-content/media-elements/* on Win/Release

Skip http/tests/w3c/html/semantics/embedded-content/media-elements/* on Win/Release
as well. Apparently, the "AQMEIOManager::FindIOUnit: error -1" messages can show
up on release builds as well.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoXHR2 timeout property should allow late updates
youenn.fablet@crf.canon.fr [Sun, 6 Sep 2015 18:40:21 +0000 (18:40 +0000)]
XHR2 timeout property should allow late updates
https://bugs.webkit.org/show_bug.cgi?id=98156

Reviewed by Darin Adler.

Source/WebCore:

Adding a timer within XMLHttpRequest to handle timeouts for asynchronous requests.
This allows easy update of the timeout even after request is sent.
Timeout is still handled by the network backend for synchronous requests (Web worker context).

Covered by updated tests.

* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::XMLHttpRequest): Adding timeout timer initialization.
(WebCore::XMLHttpRequest::setTimeout): Updating timeout timer state if request is sent.
(WebCore::XMLHttpRequest::createRequest): Starting timeout timer if needed.
(WebCore::XMLHttpRequest::internalAbort): Stopping timeout timer if needed.
(WebCore::XMLHttpRequest::didFail): Adding comment.
(WebCore::XMLHttpRequest::didFinishLoading): Stopping timeout timer if needed.
* xml/XMLHttpRequest.h:

LayoutTests:

Activating test checking that timeout can be updated after request is sent.

* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides-expected.txt:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-overrides.js:
* http/tests/xmlhttprequest/timeout/xmlhttprequest-timeout-worker-overrides-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoSimplify JIT::emit_op_mod()
commit-queue@webkit.org [Sun, 6 Sep 2015 14:38:12 +0000 (14:38 +0000)]
Simplify JIT::emit_op_mod()
https://bugs.webkit.org/show_bug.cgi?id=148908

Patch by Sukolsak Sakshuwong <sukolsak@gmail.com> on 2015-09-06
Reviewed by Michael Saboff.

The IDIV instruction on x86 divides the value in the EDX:EAX registers
by the source operand and stores the quotient in EAX and the remainder
in EDX. Therefore, we store the values that we don't want to be
overwritten by IDIV in registers that are not EAX or EDX. This patch
makes the intention clearer and makes the code easier to read.

* jit/JITArithmetic.cpp:
(JSC::JIT::emit_op_mod):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoFix JSDollarVMPrototype after r189160.
mark.lam@apple.com [Sun, 6 Sep 2015 06:30:44 +0000 (06:30 +0000)]
Fix JSDollarVMPrototype after r189160.
https://bugs.webkit.org/show_bug.cgi?id=148900

Reviewed by Michael Saboff.

JSDollarVMPrototype needs to be updated to match http://trac.webkit.org/changeset/189160 i.e.
remove the use of JSC::Function bit in its property attributes.

* tools/JSDollarVMPrototype.cpp:
(JSC::JSDollarVMPrototype::finishCreation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoLeak in WebContextInjectedBundleClient::getInjectedBundleInitializationUserData
mcatanzaro@igalia.com [Sun, 6 Sep 2015 02:33:35 +0000 (02:33 +0000)]
Leak in WebContextInjectedBundleClient::getInjectedBundleInitializationUserData
https://bugs.webkit.org/show_bug.cgi?id=148769

Fix suggested by Zan Dobersek.

Reviewed by Darin Adler.

* UIProcess/WebContextInjectedBundleClient.cpp:
(WebKit::WebContextInjectedBundleClient::getInjectedBundleInitializationUserData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoRemove unused macros from StyleResolver.cpp
ljaehun.lim@samsung.com [Sun, 6 Sep 2015 01:50:13 +0000 (01:50 +0000)]
Remove unused macros from StyleResolver.cpp
https://bugs.webkit.org/show_bug.cgi?id=148163

Reviewed by Andreas Kling.

HANDLE_INHERIT and HANDLE_INHERIT_AND_INITIAL are not used after
StyleBuilder refactoring.

No new tests because there is no behavior change.

* css/StyleResolver.cpp:
Remove HANDLE_INHERIT and HANDLE_INHERIT_AND_INITIAL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoImport a couple of Chromium accesskey tests.
jhoneycutt@apple.com [Sat, 5 Sep 2015 20:54:31 +0000 (20:54 +0000)]
Import a couple of Chromium accesskey tests.
https://bugs.webkit.org/show_bug.cgi?id=148865

Reviewed by Daniel Bates.

* fast/forms/access-key-case-insensitive-expected.txt: Added.
* fast/forms/access-key-case-insensitive.html: Added.
* fast/forms/access-key-mutated-expected.txt: Added.
* fast/forms/access-key-mutated.html: Added.
* platform/ios-simulator/TestExpectations:
These tests are asynchronous and use unsupported features; skip them on
iOS so they don't time out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

4 years agoUnreviewed, fix the module name resolution in Windows
utatane.tea@gmail.com [Sat, 5 Sep 2015 19:45:58 +0000 (19:45 +0000)]
Unreviewed, fix the module name resolution in Windows
https://bugs.webkit.org/show_bug.cgi?id=148689

Attempt to fix the module name resolution in Windows.
A module name is represented as the UNIX path under the current module tests.
This fix split the module name with '/' instead of pathSeparator().

This is only utilized by the jsc.cpp for the local module tests.
So, WebKit production and JavaScriptCore framework are not affected by this change.

* jsc.cpp:
(ModuleName::startsWithRoot):
(ModuleName::ModuleName):
(resolvePath):
(GlobalObject::moduleLoaderResolve):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@189439 268f45cc-cd09-0410-ab3c-d52691b4dbfc