WebKit-https.git
9 years agoinspector/console/command-line-api.html timing out on Windows 7 Release (WebKit2...
jberlin@webkit.org [Fri, 18 Mar 2011 16:36:57 +0000 (16:36 +0000)]
inspector/console/command-line-api.html timing out on Windows 7 Release (WebKit2 Tests).
https://bugs.webkit.org/show_bug.cgi?id=56633

Unreviewed, skip command-line-api-inspect.html instead of command-line-api.html, since the
former appears to be causing the latter (and probably console-clear.html as well) to time
out.

* platform/win-wk2/Skipped:
* platform/win-wk2/inspector: Removed.
* platform/win-wk2/inspector/console: Removed.
* platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Fri, 18 Mar 2011 16:36:51 +0000 (16:36 +0000)]
2011-03-18  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, fixed compilation after r81208.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 18 Mar 2011 16:09:26 +0000 (16:09 +0000)]
2011-03-18  Sergio Villar Senin  <svillar@igalia.com>

        Added new GTK+ test expectations.

        * platform/gtk/fast/text/emphasis-combined-text-expected.checksum: Added.
        * platform/gtk/fast/text/emphasis-combined-text-expected.png: Added.
        * platform/gtk/fast/text/emphasis-combined-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Fri, 18 Mar 2011 15:51:39 +0000 (15:51 +0000)]
2011-03-18  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        Remove unnecessary brackets around my email address.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTwo inspector tests failing due to SECURITY_ERR exceptions on Windows 7 Release ...
jberlin@webkit.org [Fri, 18 Mar 2011 15:31:40 +0000 (15:31 +0000)]
Two inspector tests failing due to SECURITY_ERR exceptions on Windows 7 Release (WebKit2
Tests).
https://bugs.webkit.org/show_bug.cgi?id=56632

Unreviewed, landing expected failing results in order to get the Windows 7 Release
WebKit2 bots green.

* platform/win-wk2/http: Added.
* platform/win-wk2/http/tests: Added.
* platform/win-wk2/http/tests/inspector-enabled: Added.
* platform/win-wk2/http/tests/inspector-enabled/database-open-expected.txt: Added.
* platform/win-wk2/inspector: Added.
* platform/win-wk2/inspector/console: Added.
* platform/win-wk2/inspector/console/command-line-api-inspect-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=56645
sullivan@apple.com [Fri, 18 Mar 2011 15:29:39 +0000 (15:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56645
Assertion fires when hidden Find-on-Page matches are encountered in WebKit2

Reviewed by Dan Bernstein.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):
Bail out if the selection rect is empty, before trying to generate an appropriately-sized
bitmap. (Previously it was bailing out afterwards, but encountering an assertion in debug
builds along the way.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Fri, 18 Mar 2011 15:27:14 +0000 (15:27 +0000)]
2011-03-18  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] console.log not being exposed to QmlViewer
        https://bugs.webkit.org/show_bug.cgi?id=56536

        The documentation is bogus the feature does not exist.

        * declarative/qdeclarativewebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 18 Mar 2011 15:21:55 +0000 (15:21 +0000)]
2011-03-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement inspector session storage.
        https://bugs.webkit.org/show_bug.cgi?id=56643

        We would like to enable debugger/profiler from frontend side only.
        However, when user clicks "Start Debugging JavaScript" in Safari, we
        need to enable debugger when frontend is opened or re-opened for the
        same page. The idea is to store debugger-enabled setting in session
        storage and check it on frontend load.

        * inspector/InspectorFrontendClient.h:
        (WebCore::InspectorFrontendClient::saveSessionSetting):
        (WebCore::InspectorFrontendClient::loadSessionSetting):
        * inspector/InspectorFrontendHost.cpp:
        (WebCore::InspectorFrontendHost::saveSessionSetting):
        (WebCore::InspectorFrontendHost::loadSessionSetting):
        * inspector/InspectorFrontendHost.h:
        * inspector/InspectorFrontendHost.idl:
2011-03-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement inspector session storage.
        https://bugs.webkit.org/show_bug.cgi?id=56643

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::saveSessionSetting):
        (WebInspectorClient::loadSessionSetting):
        (WebInspectorFrontendClient::saveSessionSetting):
        (WebInspectorFrontendClient::loadSessionSetting):
        (-[WebInspectorWindowController inspectorClient]):
2011-03-18  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement inspector session storage.
        https://bugs.webkit.org/show_bug.cgi?id=56643

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::saveSessionSetting):
        (WebInspectorClient::loadSessionSetting):
        (WebInspectorFrontendClient::saveSessionSetting):
        (WebInspectorFrontendClient::loadSessionSetting):
        * WebCoreSupport/WebInspectorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 18 Mar 2011 14:31:20 +0000 (14:31 +0000)]
2011-03-18  Alexander Pavlov  <apavlov@chromium.org>

        [Chromium] Unreviewed, suppress editing/deleting/5206311-1.html crashes on Mac Debug

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
commit-queue@webkit.org [Fri, 18 Mar 2011 14:28:04 +0000 (14:28 +0000)]
2011-03-18  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Enable GraphicsContext3D only when the window surface support OpenGL
        https://bugs.webkit.org/show_bug.cgi?id=56555

        Allow creation of WebGLRenderingContext in the HTMLCanvasElement
        only if accelerated compositing is enabled. In GraphicsContext3D,
        while blitting the surface check that viewport hasn't changed from
        creation and painter is associated to the viewport.

        * html/HTMLCanvasElement.cpp:
        (WebCore::HTMLCanvasElement::getContext):
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3DInternal::GraphicsContext3DInternal):
        (WebCore::GraphicsContext3DInternal::getViewportGLWidget):
        (WebCore::GraphicsContext3DInternal::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Fri, 18 Mar 2011 14:11:57 +0000 (14:11 +0000)]
2011-03-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract content loading logic from scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=55237

        * inspector/debugger/debug-inlined-scripts.html:
2011-03-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract content loading logic from scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=55237

        Encapsulate source files creation logic in debugger presentation model
        to support source mappings in a pluggable way.

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.sourceFile):
        (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource):
        (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
        (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished):
        (WebInspector.DebuggerPresentationModel.prototype._addScript):
        (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded):
        (WebInspector.DebuggerPresentationModel.prototype._resourceForURL):
        (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
        (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded):
        (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
        (WebInspector.DebuggerPresentationModel.prototype.reset):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._sourceFileAdded):
        (WebInspector.ScriptsPanel.prototype._showSourceFrame):
        (WebInspector.ScriptsPanel.prototype._sourceFileChanged):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 18 Mar 2011 13:48:19 +0000 (13:48 +0000)]
2011-03-18  Alexander Pavlov  <apavlov@chromium.org>

        [Chromium] Unreviewed, rebaseline GPU tests after r81414

        * platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.checksum:
        * platform/chromium-gpu-linux/compositing/geometry/clipped-video-controller-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.checksum:
        * platform/chromium-gpu-linux/compositing/geometry/video-fixed-scrolling-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.checksum:
        * platform/chromium-gpu-linux/compositing/geometry/video-opacity-overlay-expected.png:
        * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.checksum:
        * platform/chromium-gpu-linux/compositing/layers-inside-overflow-scroll-expected.png:
        * platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.checksum:
        * platform/chromium-gpu-linux/compositing/overflow/overflow-compositing-descendant-expected.png:
        * platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.checksum:
        * platform/chromium-gpu-linux/compositing/overflow/scroll-ancestor-update-expected.png:
        * platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.checksum:
        * platform/chromium-gpu-linux/compositing/reflections/load-video-in-reflection-expected.png:
        * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.checksum:
        * platform/chromium-gpu-linux/compositing/self-painting-layers-expected.png:
        * platform/chromium-gpu-linux/media/video-canvas-alpha-expected.checksum: Added.
        * platform/chromium-gpu-linux/media/video-canvas-alpha-expected.png: Added.
        * platform/chromium-gpu-linux/media/video-display-toggle-expected.checksum:
        * platform/chromium-gpu-linux/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-linux/media/video-no-audio-expected.checksum:
        * platform/chromium-gpu-linux/media/video-no-audio-expected.png:
        * platform/chromium-gpu-linux/media/video-volume-slider-expected.checksum:
        * platform/chromium-gpu-linux/media/video-volume-slider-expected.png:
        * platform/chromium-gpu-linux/media/video-zoom-expected.checksum:
        * platform/chromium-gpu-linux/media/video-zoom-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.checksum:
        * platform/chromium-gpu-win/compositing/geometry/clipped-video-controller-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.checksum:
        * platform/chromium-gpu-win/compositing/geometry/video-fixed-scrolling-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.checksum:
        * platform/chromium-gpu-win/compositing/geometry/video-opacity-overlay-expected.png:
        * platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.checksum:
        * platform/chromium-gpu-win/compositing/layers-inside-overflow-scroll-expected.png:
        * platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.checksum:
        * platform/chromium-gpu-win/compositing/overflow/overflow-compositing-descendant-expected.png:
        * platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.checksum:
        * platform/chromium-gpu-win/compositing/overflow/scroll-ancestor-update-expected.png:
        * platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.checksum:
        * platform/chromium-gpu-win/compositing/reflections/load-video-in-reflection-expected.png:
        * platform/chromium-gpu-win/compositing/self-painting-layers-expected.checksum:
        * platform/chromium-gpu-win/compositing/self-painting-layers-expected.png:
        * platform/chromium-gpu-win/media/video-canvas-alpha-expected.checksum:
        * platform/chromium-gpu-win/media/video-canvas-alpha-expected.png:
        * platform/chromium-gpu-win/media/video-display-toggle-expected.checksum:
        * platform/chromium-gpu-win/media/video-display-toggle-expected.png:
        * platform/chromium-gpu-win/media/video-no-audio-expected.checksum:
        * platform/chromium-gpu-win/media/video-no-audio-expected.png:
        * platform/chromium-gpu-win/media/video-volume-slider-expected.checksum:
        * platform/chromium-gpu-win/media/video-volume-slider-expected.png:
        * platform/chromium-gpu-win/media/video-zoom-expected.checksum:
        * platform/chromium-gpu-win/media/video-zoom-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9153929> PluginProcess fails to launch due to PluginProcessShim.dylib...
mrowe@apple.com [Fri, 18 Mar 2011 12:08:26 +0000 (12:08 +0000)]
<rdar://problem/9153929> PluginProcess fails to launch due to PluginProcessShim.dylib building for 64-bit only

Rubber-stamped by Jon Honeycutt.

Fix a bogus change from r81392 that made PluginProcessShim.xcconfig import DebugRelease.xcconfig.
As its name suggests, DebugRelease.xcconfig is only applicable for the debug and release configurations.
It overrides the valid build architectures and also restricts the build to only the active architecture.

* Configurations/PluginProcessShim.xcconfig: Import BaseTarget.xcconfig instead. This is what
each target-specific .xcconfig file should import.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 18 Mar 2011 11:18:08 +0000 (11:18 +0000)]
2011-03-18  Alexander Pavlov  <apavlov@chromium.org>

        [Chromium] Unreviewed, fix custom expectation after r81438

        * platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 18 Mar 2011 10:26:56 +0000 (10:26 +0000)]
2011-03-18  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: console doesn&apos;t scroll when multiline expression is being evaluated
        https://bugs.webkit.org/show_bug.cgi?id=56639

        Always scoll in the console when command result is received.

        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype.addMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 18 Mar 2011 10:09:01 +0000 (10:09 +0000)]
2011-03-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed fix for chromium test_expectations.txt.

        There was a duplicate for inspector/mutate-unknown-node.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Fri, 18 Mar 2011 09:36:53 +0000 (09:36 +0000)]
2011-03-18  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        http/tests/inspector/resource-parameters.html is flakey
        https://bugs.webkit.org/show_bug.cgi?id=55867

        Fixed test flakiness by not finishing test before proper resource arrives.

        * http/tests/inspector/resource-parameters.html: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html-disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove some files I accidentally added in r81454
aroben@apple.com [Fri, 18 Mar 2011 09:14:29 +0000 (09:14 +0000)]
Remove some files I accidentally added in r81454

* WebKitTestRunner/Configurations/WebKitTestRunnerCoreGraphics.vsprops: Removed.
* WebKitTestRunner/cg/TestInvocationCG.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-18 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 18 Mar 2011 09:12:05 +0000 (09:12 +0000)]
2011-03-18  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: chromium: cleanup Web Inspector expectations.
        https://bugs.webkit.org/show_bug.cgi?id=56635

        Many Inspector tests are passing now but they still have expectations.
        I've removed unnecessary expectations and grouped the remainings.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows WebKit2 expected failure results for a media test
aroben@apple.com [Fri, 18 Mar 2011 09:08:44 +0000 (09:08 +0000)]
Add Windows WebKit2 expected failure results for a media test

The failure is tracked by <http://webkit.org/b/56636>.

* platform/win-wk2/media/controls-without-preload-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip some timing out tests in WebKit2 on Windows
aroben@apple.com [Fri, 18 Mar 2011 09:07:00 +0000 (09:07 +0000)]
Skip some timing out tests in WebKit2 on Windows

Tracked by <http://webkit.org/b/56633> and <http://webkit.org/b/56634>.

* platform/win-wk2/Skipped: Added inspector/console/command-line-api.html and
http/tests/xmlhttprequest/cross-origin-authorization.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd expected failure results for WebKit2 tests failing on Windows due to font differences
aroben@apple.com [Fri, 18 Mar 2011 09:05:16 +0000 (09:05 +0000)]
Add expected failure results for WebKit2 tests failing on Windows due to font differences

<http://webkit.org/b/56617> tracks the failures.

* platform/win-wk2/css2.1/t0905-c5525-flthw-00-c-g-expected.txt: Added.
* platform/win-wk2/css2.1/t0905-c5526-flthw-00-c-g-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt: Added.
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt: Added.
* platform/win-wk2/svg/text/bidi-text-query-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a test in that is probably causing the next test to crash in WebKit2
aroben@apple.com [Fri, 18 Mar 2011 09:03:27 +0000 (09:03 +0000)]
Skip a test in that is probably causing the next test to crash in WebKit2

<http://webkit.org/b/55780> tracks the failure.

* platform/win-wk2/Skipped: Skip platform/win/plugins/draws-gradient.html instead of
platform/win/plugins/get-value-netscape-window.html. The former was probably causing the
latter to crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable a flakey inspector test
aroben@apple.com [Fri, 18 Mar 2011 09:01:41 +0000 (09:01 +0000)]
Disable a flakey inspector test

<http://webkit.org/b/56565> tracks the failure.

* inspector/elements/elements-panel-xhtml-structure.xhtml-disabled: Renamed from LayoutTests/inspector/elements/elements-panel-xhtml-structure.xhtml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoIgnore an NSNumberFormatter leak on SnowLeopard
aroben@apple.com [Fri, 18 Mar 2011 07:39:33 +0000 (07:39 +0000)]
Ignore an NSNumberFormatter leak on SnowLeopard

* Scripts/old-run-webkit-tests:
(countAndPrintLeaks): Ignore leaks in -[NSNumberFormatter
getObjectValue:forString:errorDescription:].

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a CFNumber leak seen on the leaks bot
aroben@apple.com [Fri, 18 Mar 2011 07:37:42 +0000 (07:37 +0000)]
Fix a CFNumber leak seen on the leaks bot

Reviewed by Gavin Barraclough.

* platform/network/mac/FormDataStreamMac.mm:
(WebCore::advanceCurrentStream): Use a RetainPtr to cause the CFNumber we allocate to be
released.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix a leak beneath LayoutTestController::authenticateSession seen on the bots
aroben@apple.com [Fri, 18 Mar 2011 07:19:24 +0000 (07:19 +0000)]
Fix a leak beneath LayoutTestController::authenticateSession seen on the bots

Rubber-stamped by Mark Rowe.

* DumpRenderTree/mac/LayoutTestControllerMac.mm:
(LayoutTestController::authenticateSession): Use a RetainPtr to cause the NSURLRequest to be
released.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAddress a review comment I missed in r81445
aroben@apple.com [Fri, 18 Mar 2011 07:09:55 +0000 (07:09 +0000)]
Address a review comment I missed in r81445

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
(LeaksParserWorker.prototype._parseLeaks): Anchor the RegExp used to find the number of
leaked bytes to speed up searching on long lines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMark leaky builds orange, even if all regression tests passed
aroben@apple.com [Fri, 18 Mar 2011 07:01:43 +0000 (07:01 +0000)]
Mark leaky builds orange, even if all regression tests passed

Fixes <http://webkit.org/b/56609> SnowLeopard Intel Leaks bot appears green on
build.webkit.org when all tests pass even though there are still leaks

Reviewed by Dan Bernstein.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(RunWebKitLeakTests): Set the warnOnWarnings property to True so that the entire build will
be marked orange if this build step generates warnings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow values in Leaks Viewer to be shown as percentages
aroben@apple.com [Fri, 18 Mar 2011 06:59:58 +0000 (06:59 +0000)]
Allow values in Leaks Viewer to be shown as percentages

Double-clicking on a column will toggle between showing percentages and showing real values.

Fixes <http://webkit.org/b/56628> Would like to view values as percentages of the total
number of leaked bytes in Leaks Viewer

Reviewed by Joe Pecoraro.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
(LeaksParserWorker.prototype._incorporateLeaks): Calculate the (never-shown) top-level
node's totalTime, which is used in calculating percentages.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
(monkeyPatchInspectorObjects): Only format values as bytes if we aren't supposed to be
showing them as percentages.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShow the number of leaked bytes, not just leaked allocations, in Leaks Viewer
aroben@apple.com [Fri, 18 Mar 2011 06:58:10 +0000 (06:58 +0000)]
Show the number of leaked bytes, not just leaked allocations, in Leaks Viewer

The Self and Total columns now report the number of leaked bytes. The new Calls column shows
the number of leaked allocations. And the new Average column shows the average number of
leaked bytes per call.

Fixes <http://webkit.org/b/56344> Leaks Viewer should show how many bytes were leaked, not
just how many allocations

Reviewed by Joe Pecoraro.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/LeaksParserWorker.js:
(LeaksParserWorker.prototype._parseLeaks): Parse the number of leaked bytes from the "Leak:"
line and store it with the leak stack.
(LeaksParserWorker.prototype._createNode): Initialize the averageTime and numberOfCalls
properties.
(LeaksParserWorker.prototype._incorporateLeaks): Updated to get the stack from the .stack
property, and changed to store the number of leaked bytes in .selfTime/.totalTime.
.numberOfCalls now holds the number of leaked allocations.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/WebInspectorShims.js:
(Preferences): Set samplingCPUProfiler to false so that the Average and Calls columns will
appear.
(monkeyPatchInspectorObjects): Format the values as bytes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a test that is likely causing later tests to assert
aroben@apple.com [Fri, 18 Mar 2011 05:39:42 +0000 (05:39 +0000)]
Skip a test that is likely causing later tests to assert

<http://webkit.org/b/56599> tracks the failure.

* platform/win/Skipped: Replaced editing/deleting/5206311-1.html with
editing/deleting/5168598.html, which is likely causing the former to assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd Windows XP results for test added in r81404
aroben@apple.com [Fri, 18 Mar 2011 05:19:56 +0000 (05:19 +0000)]
Add Windows XP results for test added in r81404

The differences from Windows 7 seem to be due to different fonts being used.

* platform/win-xp/fast/text/emphasis-combined-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake Leaks Viewer able to count leaks in builds that didn't fail any regression tests
aroben@apple.com [Fri, 18 Mar 2011 05:18:09 +0000 (05:18 +0000)]
Make Leaks Viewer able to count leaks in builds that didn't fail any regression tests

Fixes <http://webkit.org/b/56626> Leaks Viewer omits recent builds which didn't fail any
regression tests

Reviewed by James Robinson.

* BuildSlaveSupport/build.webkit.org-config/public_html/LeaksViewer/RecentBuildsLoader.js:
(RecentBuildsLoader.prototype.start): Get the number of leaks out of the "text" array, which
is always populated, even when all regression tests pass.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-10 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Fri, 18 Mar 2011 05:09:20 +0000 (05:09 +0000)]
2011-03-10  Hayato Ito  <hayato@chromium.org>

        Reviewed by Tony Chang.

        Add a check logic for reftests in case that a reftest is marked AS REBASELINE.

        https://bugs.webkit.org/show_bug.cgi?id=56076

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Andreas Kling <kling@webkit.org>
commit-queue@webkit.org [Fri, 18 Mar 2011 04:10:32 +0000 (04:10 +0000)]
2011-03-17  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QML WebView emits iconChanged() when the page title changes
        https://bugs.webkit.org/show_bug.cgi?id=56570

        * declarative/qdeclarativewebview.cpp:
        (QDeclarativeWebView::setPage): Don't forward the frame's titleChanged
        signal to the view's iconChanged signal.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 18 Mar 2011 04:03:35 +0000 (04:03 +0000)]
2011-03-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add some of the remaining platform/mac files to WebCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=56616

        These files used to be hard, but are now magically easy.  76 link errors.

        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Fri, 18 Mar 2011 03:53:43 +0000 (03:53 +0000)]
2011-03-17  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
        https://bugs.webkit.org/show_bug.cgi?id=56502

        Leaving the file names as-is for now to avoid svn-apply's
        handling of move-and-modify.

        * fast/filesystem/directory-entry-to-uri-expected.txt:
        * fast/filesystem/file-entry-to-uri-expected.txt:
        * fast/filesystem/resources/directory-entry-to-uri.js:
        * fast/filesystem/resources/file-entry-to-uri-sync.js:
        * fast/filesystem/resources/file-entry-to-uri.js:
        * fast/filesystem/workers/file-entry-to-uri-sync-expected.txt:
        * http/tests/filesystem/resolve-uri-expected.txt:
        * http/tests/filesystem/script-tests/resolve-uri.js:
2011-03-17  Adam Klein  <adamk@chromium.org>

        Reviewed by Adam Barth.

        [filesystem] Rename toURI->toURL, resolveLocalFileSystemURI->resolveLocalFileSystemURL
        https://bugs.webkit.org/show_bug.cgi?id=56502

        * fileapi/Entry.idl:
        * fileapi/EntryBase.cpp:
        (WebCore::EntryBase::toURL):
        * fileapi/EntryBase.h:
        * fileapi/EntrySync.idl:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::resolveLocalFileSystemURL):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix the build.
mrowe@apple.com [Fri, 18 Mar 2011 02:43:33 +0000 (02:43 +0000)]
Fix the build.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Fri, 18 Mar 2011 02:14:53 +0000 (02:14 +0000)]
2011-03-17  James Simonsen  <simonjam@chromium.org>

        Unreviewed, rebaseline a bunch of chromium tests.

        * platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-lr/007-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/positioning/auto/vertical-rl/007-expected.png: Added.
        * platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/Kusa-Makura-background-canvas-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/border-vertical-lr-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/english-lr-text-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-selection-expected.png: Added.
        * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-lr-text-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-selection-expected.png:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.checksum:
        * platform/chromium-mac-leopard/fast/blockflow/japanese-rl-text-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.checksum:
        * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-clear-expected.png:
        * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.checksum:
        * platform/chromium-mac-leopard/fast/repaint/japanese-rl-selection-repaint-expected.png:
        * platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/ruby/base-shorter-than-text-expected.png: Added.
        * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.checksum:
        * platform/chromium-mac-leopard/fast/text/international/text-combine-image-test-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 18 Mar 2011 01:58:18 +0000 (01:58 +0000)]
2011-03-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Update CSP directive parser to match spec
        https://bugs.webkit.org/show_bug.cgi?id=56582

        Test some error-handling cases.

        * http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/directive-parsing.html: Added.
2011-03-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Update CSP directive parser to match spec
        https://bugs.webkit.org/show_bug.cgi?id=56582

        Brandon updated the CSP spec.  I've updated our implementation to
        match.  In the process, I found a couple bugs in the spec, which I've
        sent to the working group.  This patch assumes that the bugs will be
        fixed in the way I suggested.  If they get fixed a different way, we
        might need to update the parser again.

        Test: http/tests/security/contentSecurityPolicy/directive-parsing.html

        * page/ContentSecurityPolicy.cpp:
        (WebCore::isDirectiveNameCharacter):
        (WebCore::isDirectiveValueCharacter):
        (WebCore::advanceUntil):
        (WebCore::ContentSecurityPolicy::parse):
        (WebCore::ContentSecurityPolicy::parseDirective):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 18 Mar 2011 01:36:22 +0000 (01:36 +0000)]
2011-03-17  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebCore GYP build should have PrivateHeaders
        https://bugs.webkit.org/show_bug.cgi?id=56604

        I've manually verified that this produces the correct set of
        PrivateHeaders (modulo the ForwardingHeaders and icu issue).
        Unforunately, this patch breakes compile slightly, but I'll fix that
        in a followup patch.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Fri, 18 Mar 2011 01:31:28 +0000 (01:31 +0000)]
2011-03-17  James Simonsen  <simonjam@chromium.org>

        Unreviewed, update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Alexey Marinichev <amarinichev@chromium.org>
kbr@google.com [Fri, 18 Mar 2011 01:17:41 +0000 (01:17 +0000)]
2011-03-17  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Kenneth Russell.

        chromium: uninitialized field in WebViewImpl
        https://bugs.webkit.org/show_bug.cgi?id=56620

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 18 Mar 2011 01:11:10 +0000 (01:11 +0000)]
2011-03-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement PluginProcessProxy::setFullscreenWindowIsShowing
        https://bugs.webkit.org/show_bug.cgi?id=56618

        * UIProcess/Plugins/PluginProcessProxy.cpp:
        (WebKit::PluginProcessProxy::PluginProcessProxy):
        Initialize m_fullscreenWindowIsShowing.

        (WebKit::PluginProcessProxy::didClose):
        if m_fullscreenWindowIsShowing is true, call exitFullscreen.

        * UIProcess/Plugins/PluginProcessProxy.h:
        * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
        (WebKit::PluginProcessProxy::getPluginProcessSerialNumber):
        Add helper function for getting a PSN for the plug-in process.

        (WebKit::PluginProcessProxy::makePluginProcessTheFrontProcess):
        Make the plug-in process the front process.

        (WebKit::PluginProcessProxy::makeUIProcessTheFrontProcess):
        Make the current process (the UI process) the front process.

        (WebKit::PluginProcessProxy::setFullscreenWindowIsShowing):
        Call enterFullscreen or exitFullscreen.

        (WebKit::PluginProcessProxy::enterFullscreen):
        Make the plug-in process the front process and hide the menu bar.

        (WebKit::PluginProcessProxy::exitFullscreen):
        Show the menu bar and if necessary make the UI process the front process.

        (WebKit::PluginProcessProxy::endModal):
        call makeUIProcessTheFrontProcess.

        (WebKit::PluginProcessProxy::applicationDidBecomeActive):
        Call makePluginProcessTheFrontProcess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 18 Mar 2011 01:11:06 +0000 (01:11 +0000)]
2011-03-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Mark Rowe.

        Fixed some string leaks seen on the buildbot
        https://bugs.webkit.org/show_bug.cgi?id=56619

        * runtime/PropertyMapHashTable.h:
        (JSC::PropertyTable::~PropertyTable): DEref!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake bidi text in <select> menus in WebKit2 on Windows match WebKit1
aroben@apple.com [Fri, 18 Mar 2011 00:52:01 +0000 (00:52 +0000)]
Make bidi text in <select> menus in WebKit2 on Windows match WebKit1

Fixes <http://webkit.org/b/56614> 3 <select> bidi tests failing on Windows 7 Release
(WebKit2 Tests)

Reviewed by Sam Weinig.

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::selectItemWritingDirectionIsNatural):
(WebKit::WebChromeClient::selectItemAlignmentFollowsMenuWritingDirection):
On Windows, return the same values we return in WebKit1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 18 Mar 2011 00:45:24 +0000 (00:45 +0000)]
2011-03-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Implement PluginProcessProxy::setModalWindowIsShowing
        https://bugs.webkit.org/show_bug.cgi?id=56615

        * UIProcess/Plugins/PluginProcessProxy.cpp:
        (WebKit::PluginProcessProxy::PluginProcessProxy):
        Initialize m_modalWindowIsShowing.

        (WebKit::PluginProcessProxy::didClose):
        If m_modalWindowIsShowing is true, we must call endModal.

        * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
        (-[WKPlaceholderModalWindow _wantsUserAttention]):
        Add a WKPlaceholderModalWindow.

        (WebKit::PluginProcessProxy::setModalWindowIsShowing):
        Call beginModal or endModal depending on whether we're showing a modal window or not.

        (WebKit::PluginProcessProxy::beginModal):
        Create a fake window and start a nested run loop. Listen for NSApplicationWillBecomeActiveNotification notifications.

        (WebKit::PluginProcessProxy::endModal):
        Tear down the window and the run loop.

        (WebKit::PluginProcessProxy::applicationDidBecomeActive):
        Make sure that the plug-in process is frontmost.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMisc clean-up (see files for details).
levin@chromium.org [Fri, 18 Mar 2011 00:18:01 +0000 (00:18 +0000)]
Misc clean-up (see files for details).

* platform/chromium-mac-leopard/media/controls-after-reload-expected.checksum: Due to r81300.
* platform/chromium-mac-leopard/media/controls-after-reload-expected.png: Ditto.
* platform/chromium-mac-leopard/media/controls-without-preload-expected.checksum: Due to r81280.
* platform/chromium-mac-leopard/media/controls-without-preload-expected.png: Ditto.
* platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.checksum: Due to r81285.
* platform/chromium-mac-leopard/media/media-document-audio-repaint-expected.png: Ditto.
* platform/chromium-win-xp/media/controls-without-preload-expected.checksum: Due to r81280.
* platform/chromium-win-xp/media/controls-without-preload-expected.png: Ditto.
* platform/chromium/test_expectations.txt: Replace BUG_LEVIN with a bug number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Jeff Miller <jeffm@apple.com>
jeffm@apple.com [Fri, 18 Mar 2011 00:11:45 +0000 (00:11 +0000)]
2011-03-17  Jeff Miller  <jeffm@apple.com>

        Reviewed by Adam Roben.

        Web page shouldn't swallow alt-key combinations on Windows
        https://bugs.webkit.org/show_bug.cgi?id=56612

        Make Alt+Left Arrow and Alt+Right Arrow go back and forward, but make
        sure any alt-key combinations bubble up to the client.

        * WebProcess/WebPage/win/WebPageWin.cpp:
        (WebKit::WebPage::performDefaultBehaviorForKeyEvent): Make Alt+Left Arrow and Alt+Right Arrow go back and forward, ignore any other alt-key combinations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdded platform-specific expected results for fast/text/emphasis-combined-text.html
mitz@apple.com [Fri, 18 Mar 2011 00:11:17 +0000 (00:11 +0000)]
Added platform-specific expected results for fast/text/emphasis-combined-text.html

* platform/mac-leopard/fast/text/emphasis-combined-text-expected.txt: Added.
* platform/win/fast/text/emphasis-combined-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Victoria Kirst <vrk@google.com>
commit-queue@webkit.org [Fri, 18 Mar 2011 00:10:53 +0000 (00:10 +0000)]
2011-03-17  Victoria Kirst  <vrk@google.com>

        Reviewed by Kenneth Russell.

        [chromium] Video colors have wrong brightness/contrast
        https://bugs.webkit.org/show_bug.cgi?id=56598

        This patch changes the YUV to RGB color conversion matrix
        to have brighter whites and darker blacks in accordance to
        the BT.601 standard.

        * platform/graphics/chromium/ShaderChromium.cpp:
        (WebCore::FragmentShaderYUVVideo::FragmentShaderYUVVideo):
        (WebCore::FragmentShaderYUVVideo::init):
        (WebCore::FragmentShaderYUVVideo::getShaderString):
        * platform/graphics/chromium/ShaderChromium.h:
        (WebCore::FragmentShaderYUVVideo::yuvAdjLocation):
        * platform/graphics/chromium/VideoLayerChromium.cpp:
        (WebCore::VideoLayerChromium::drawYUV):
        * platform/graphics/chromium/VideoLayerChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a compositing-sensitive test when accelerated compositing is disabled
aroben@apple.com [Fri, 18 Mar 2011 00:08:39 +0000 (00:08 +0000)]
Skip a compositing-sensitive test when accelerated compositing is disabled

Reviewed by Sam Weinig.

Tools:

* Scripts/old-run-webkit-tests: Skip media/media-document-audio-repaint.html when
accelerated compositing is disabled.

LayoutTests:

Remove some non-compositing results for a test that is now skipped in non-compositing builds

* platform/win-xp/media/media-document-audio-repaint-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 18 Mar 2011 00:08:09 +0000 (00:08 +0000)]
2011-03-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Send SetModalWindowIsShowing and SetFullscreenWindowIsShowing messages to the UI process
        https://bugs.webkit.org/show_bug.cgi?id=56610

        * PluginProcess/mac/PluginProcessMac.mm:
        (WebKit::FullscreenWindowTracker::FullscreenWindowTracker):
        Add fullscreen window tracker class.

        (WebKit::rectCoversAnyScreen):
        Return whether the given rect covers any screen.

        (WebKit::windowCoversAnyScreen):
        Return whether the given window covers any screen.

        (WebKit::FullscreenWindowTracker::windowShown):
        If we're showing a fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.

        (WebKit::FullscreenWindowTracker::windowHidden):
        If we're hiding the last fullscreen window, call PluginProcess::setFullscreenWindowIsShowing.

        (WebKit::cocoaWindowShown):
        (WebKit::cocoaWindowHidden):
        (WebKit::carbonWindowShown):
        (WebKit::carbonWindowHidden):
        Call the window tracking functions.

        (WebKit::setModal):
        Call PluginProcess::setModalWindowIsShowing.

        (WebKit::PluginProcess::setModalWindowIsShowing):
        (WebKit::PluginProcess::setFullscreenWindowIsShowing):
        Send CoreIPC messages.

        * UIProcess/Plugins/PluginProcessProxy.h:
        * UIProcess/Plugins/PluginProcessProxy.messages.in:
        Add new messages.

        * UIProcess/Plugins/mac/PluginProcessProxyMac.mm:
        (WebKit::PluginProcessProxy::setModalWindowIsShowing):
        (WebKit::PluginProcessProxy::setFullscreenWindowIsShowing):
        Add stubs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 17 Mar 2011 23:57:56 +0000 (23:57 +0000)]
2011-03-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Geoffrey Garen.

        Crash in  JSC::MarkStack::drain Under Stress
        https://bugs.webkit.org/show_bug.cgi?id=56470

        We perform a number of gc allocations while when
        we are setting up new globals in a piece of global
        code.  We do this by adding new properties to the
        symbol table, and then expanding the storage to fit
        at the end.

        If a GC happens during this time we will report an
        incorrect size for the global object's symbol table
        storage.

        This patch corrects this by growing the storage size
        before we starting adding entries to the symbol table.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::BytecodeGenerator):
        * runtime/JSGlobalObject.cpp:
        (JSC::JSGlobalObject::resizeRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 17 Mar 2011 23:46:58 +0000 (23:46 +0000)]
2011-03-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        1 Structure leaked beneath JSGlobalData::storeVPtrs()
        https://bugs.webkit.org/show_bug.cgi?id=56595

        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::storeVPtrs): Take local ownership of the Structure
        we're using, since the Executable is not designed to own the Structure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRubber Stamped by Sam Weinig.
barraclough@apple.com [Thu, 17 Mar 2011 23:27:14 +0000 (23:27 +0000)]
Rubber Stamped by Sam Weinig.

Add missing register-register branchTest8 to MacroAssemblerX86Common/X86Assembler.

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branchTest8):
* assembler/X86Assembler.h:
(JSC::X86Assembler::testb_rr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Zhenyao Mo <zmo@google.com>
zmo@google.com [Thu, 17 Mar 2011 23:26:27 +0000 (23:26 +0000)]
2011-03-17  Zhenyao Mo  <zmo@google.com>

        Reviewed by Adam Barth.

        RequestAnimationFrame callbacks prevent Document from being released on detach
        https://bugs.webkit.org/show_bug.cgi?id=56607

        * dom/Document.cpp:
        (WebCore::Document::removedLastRef): Remove RequestAnimationFrame callbacks.
        (WebCore::Document::detach): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=56596 Overlay scrollbars sometimes
bdakin@apple.com [Thu, 17 Mar 2011 23:22:20 +0000 (23:22 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=56596 Overlay scrollbars sometimes
fail to appear
-and corresponding-
<rdar://problem/8953779>

Reviewed by Darin Adler.

* platform/mac/ScrollAnimatorMac.mm:
(-[ScrollbarPainterDelegate setUpAnimation:scrollerPainter:part:WebCore::animateAlphaTo:duration:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Thu, 17 Mar 2011 23:16:10 +0000 (23:16 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/9052166> Emphasis marks appear over combined text rather than beside it
mitz@apple.com [Thu, 17 Mar 2011 23:11:48 +0000 (23:11 +0000)]
<rdar://problem/9052166> Emphasis marks appear over combined text rather than beside it
https://bugs.webkit.org/show_bug.cgi?id=56480

Reviewed by Beth Dakin.

Source/WebCore:

Test: fast/text/emphasis-combined-text.html

* rendering/InlineTextBox.cpp:
(WebCore::rotation): Added this helper.
(WebCore::InlineTextBox::paint): Paint a single emphasis mark beside the combined text,
centered vertically.

LayoutTests:

* fast/text/emphasis-combined-text.html: Added.
* platform/mac/fast/text/emphasis-combined-text-expected.checksum: Added.
* platform/mac/fast/text/emphasis-combined-text-expected.png: Added.
* platform/mac/fast/text/emphasis-combined-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 56603 - DFG JIT related cleanup
barraclough@apple.com [Thu, 17 Mar 2011 23:11:47 +0000 (23:11 +0000)]
Bug 56603 - DFG JIT related cleanup
Move node generation out to separate function, move binarySearch algorithm out
to StdLibExtras, fix Graph::dump() to print comma between non-node children,
even if there are no node children.

Reviewed by Sam Weinig.

* bytecode/CodeBlock.h:
(JSC::getCallReturnOffset):
(JSC::CodeBlock::getStubInfo):
(JSC::CodeBlock::getCallLinkInfo):
(JSC::CodeBlock::getMethodCallLinkInfo):
(JSC::CodeBlock::bytecodeOffset):
    - Move binaryChop to binarySearch in StdLibExtras
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::ByteCodeParser):
(JSC::DFG::ByteCodeParser::parse):
(JSC::DFG::parse):
    - Make m_noArithmetic a member, initialize m_currentIndex in the constructor.
* dfg/DFGByteCodeParser.h:
    - Change parse() to not take a start index (always 0).
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::dump):
    - Fix Graph::dump() to print comma between non-node children, even if there are no node children.
* dfg/DFGJITCodeGenerator.h:
(JSC::DFG::JITCodeGenerator::JITCodeGenerator):
    - Initialize m_compileIndex in constructor.
* dfg/DFGNonSpeculativeJIT.cpp:
(JSC::DFG::NonSpeculativeJIT::compile):
* dfg/DFGNonSpeculativeJIT.h:
    - Spilt out compilation of individual node.
* dfg/DFGOperations.cpp:
(JSC::DFG::operationConvertThis):
* dfg/DFGOperations.h:
    - Cleanup parameter name.
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
    - Spilt out compilation of individual node.
* runtime/Executable.cpp:
(JSC::tryDFGCompile):
    - Change parse() to not take a start index (always 0).
* wtf/StdLibExtras.h:
(WTF::binarySearch):
    - Move binaryChop to binarySearch in StdLibExtras

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 17 Mar 2011 23:07:48 +0000 (23:07 +0000)]
2011-03-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Fixed a leak seen on the buildbot.

        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::openInspectorFrontend): Smart pointers are smart.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow passing a certificate chain as a user message
weinig@apple.com [Thu, 17 Mar 2011 23:07:14 +0000 (23:07 +0000)]
Allow passing a certificate chain as a user message
<rdar://problem/8951709>
https://bugs.webkit.org/show_bug.cgi?id=56605

Reviewed by Brady Eidson.

* Shared/API/c/mac/WKCertificateInfoMac.h:
* Shared/API/c/mac/WKCertificateInfoMac.mm:
(WKCertificateInfoCreateWithCertficateChain):
Added. Creates a WKCertificate from a certificate chain.

* Shared/UserMessageCoders.h:
(WebKit::UserMessageEncoder::baseEncode):
(WebKit::UserMessageDecoder::baseDecode):
Add encoding/decoding of WebCertificateInfo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBlob URL should not be allow to get created from the code running from data URI
jianli@chromium.org [Thu, 17 Mar 2011 23:06:55 +0000 (23:06 +0000)]
Blob URL should not be allow to get created from the code running from data URI
https://bugs.webkit.org/show_bug.cgi?id=56600

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/fileapi/create-blob-url-from-data-url.html

* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::createPublicBlobURL):
* fileapi/BlobURL.cpp:
(WebCore::BlobURL::createBlobURL):
* fileapi/EntryBase.cpp:
(WebCore::EntryBase::toURI):
* fileapi/FileReaderLoader.cpp:
(WebCore::FileReaderLoader::start):

LayoutTests:

* http/tests/fileapi/create-blob-url-from-data-url-expected.txt: Added.
* http/tests/fileapi/create-blob-url-from-data-url.html: Added.
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix clang build.
andersca@apple.com [Thu, 17 Mar 2011 22:29:16 +0000 (22:29 +0000)]
Fix clang build.

Reviewed by Geoffrey Garen.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::storeVPtrs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 17 Mar 2011 22:21:19 +0000 (22:21 +0000)]
2011-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Skip an editing test that hits assertion on non-Mac platforms.
        The bug is tracked by https://bugs.webkit.org/show_bug.cgi?id=56599.

        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 22:18:24 +0000 (22:18 +0000)]
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r80064.
        http://trac.webkit.org/changeset/80064
        https://bugs.webkit.org/show_bug.cgi?id=56588

        the original test was correct (Requested by rniwa on #webkit).

        * platform/mac/editing/input/selection-change-closes-typing.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 17 Mar 2011 22:17:17 +0000 (22:17 +0000)]
2011-03-17  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Turn off accelerated compositing for RTL style pages.
        https://bugs.webkit.org/show_bug.cgi?id=56585

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::layout):
        (WebKit::WebViewImpl::pageHasRTLStyle):
        (WebKit::WebViewImpl::setRootGraphicsLayer):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 17 Mar 2011 22:15:37 +0000 (22:15 +0000)]
2011-03-17  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        1 Structure leaked beneath JSGlobalData::storeVPtrs()
        https://bugs.webkit.org/show_bug.cgi?id=56595

        * JavaScriptCore.xcodeproj/project.pbxproj:
        * runtime/JSGlobalData.cpp:
        (JSC::JSGlobalData::storeVPtrs): Now that we have an executable, we need
        to explicitly run its destructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Alexis Menard <alexis.menard@openbossa.org>
commit-queue@webkit.org [Thu, 17 Mar 2011 22:14:15 +0000 (22:14 +0000)]
2011-03-17  Alexis Menard  <alexis.menard@openbossa.org>

        Reviewed by Benjamin Poulain.

        [Qt] Videos look ugly when using QGraphicsWebView.
        https://bugs.webkit.org/show_bug.cgi?id=56580

        We need to set QPainter::SmoothPixmapTransform on the painter for a proper rendering of the video.
        QWebView does it but not QGraphicsWebView because the API does not exist. This patch is fixing it
        by introducing the same API as QWebView to control the renderHints of the item. Unlike QWebView
        QGraphicsWebView inherits the painter from QGraphicsScene and those flags are not set. This patch
        ensure that before rendering the item we add QPainter::SmoothPixmapTransform and QPainter::TextAntialiasing
        in addition of what could be set on the painter. In order to not break the rendering of all the items in the
        scene we set back the painter to its original state when QGraphicsWebView is rendered.

        * Api/qgraphicswebview.cpp:
        (QGraphicsWebViewPrivate::QGraphicsWebViewPrivate):
        (QGraphicsWebView::paint):
        (QGraphicsWebView::renderHints):
        (QGraphicsWebView::setRenderHints):
        (QGraphicsWebView::setRenderHint):
        * Api/qgraphicswebview.h:
        * tests/qgraphicswebview/tst_qgraphicswebview.cpp:
        (tst_QGraphicsWebView::renderHints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Mar 2011 22:04:35 +0000 (22:04 +0000)]
2011-03-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Add PluginProcessShim hooks for when windows are shown and hidden
        https://bugs.webkit.org/show_bug.cgi?id=56597

        * Configurations/PluginProcessShim.xcconfig:
        Add HEADER_SEARCH_PATHS so we can find WebKitSystemInterface.h.

        * PluginProcess/mac/PluginProcessMac.mm:
        (WebKit::cocoaWindowShown):
        (WebKit::cocoaWindowHidden):
        (WebKit::carbonWindowShown):
        (WebKit::carbonWindowHidden):
        (WebKit::setModal):
        (WebKit::PluginProcess::initializeShim):
        Add empty stubs.

        * PluginProcess/mac/PluginProcessShim.h:
        * PluginProcess/mac/PluginProcessShim.mm:
        (WebKit::beginModal):
        (WebKit::endModal):
        Keep a modal count and call setModal accordingly.

        (WebKit::shim_NSApplication_RunModalForWindow):
        (WebKit::shimModalDialog):
        (WebKit::shimAlert):
        Call beginModal/endModal.

        (WebKit::shimShowWindow):
        (WebKit::shimHideWindow):
        Call the shim functions.

        (WebKit::WebKitPluginProcessShimInitialize):
        Listen for notifications and call the necessary shim functions.

        * WebKit2.xcodeproj/project.pbxproj:
        Link the plug-in process shim with AppKit and QuartzCore and WKSI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable http/tests/inspector/network tests
aroben@apple.com [Thu, 17 Mar 2011 22:02:05 +0000 (22:02 +0000)]
Disable http/tests/inspector/network tests

They are known to be flaky. <http://webkit.org/b/56578> tracks the issue.

* http/tests/inspector/network/network-size.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-size.html.
* http/tests/inspector/network/network-timing.html-disabled: Renamed from LayoutTests/http/tests/inspector/network/network-timing.html.

* platform/mac/Skipped: Removed a now-disabled test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStart using PlatformSpecificScheduler for the Mac builders
aroben@apple.com [Thu, 17 Mar 2011 22:00:24 +0000 (22:00 +0000)]
Start using PlatformSpecificScheduler for the Mac builders

The current set of file/directory patterns should work for Mac builders. We may discover
that there are more files and directories we can exclude from the Mac builds, but they can
be added later.

Fixes <http://webkit.org/b/56593> Mac builders do lots of unnecessary builds

Reviewed by Mark Rowe.

* BuildSlaveSupport/build.webkit.org-config/config.json: Moved the Mac builders into two
PlatformSpecificSchedulers: one for Leopard, and one for SnowLeopard.

* Scripts/webkitpy/common/config/build.py:
(_should_file_trigger_build): Allow "mac-leopard" and "mac-snowleopard" platforms, and
cleaned up patterns a little bit.

* Scripts/webkitpy/common/config/build_unittest.py:
(ShouldBuildTest): Fixed some expected results.
(ShouldBuildTest.test_should_build): Start testing "mac-leopard" and "mac-snowleopard"
platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse a consistent set of file patterns in the svn:ignore property for all .xcodeproj...
jeffm@apple.com [Thu, 17 Mar 2011 21:51:06 +0000 (21:51 +0000)]
Use a consistent set of file patterns in the svn:ignore property for all .xcodeproj directories, specifically:

*.mode*
*.pbxuser
*.perspective*
project.xcworkspace
xcuserdata

Examples:

* NetscapeCocoaPlugin/NetscapeCocoaPlugin.xcodeproj: Modified property svn:ignore.
* NetscapeCoreAnimationMoviePlugin/NetscapeCoreAnimationMoviePlugin.xcodeproj: Modified property svn:ignore.
* NetscapeCoreAnimationPlugin/NetscapeCoreAnimationPlugin.xcodeproj: Modified property svn:ignore.
* NetscapeInputMethodPlugin/NetscapeInputMethodPlugin.xcodeproj: Modified property svn:ignore.

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj: Modified property svn:ignore.

Source/JavaScriptGlue:

* JavaScriptGlue.xcodeproj: Modified property svn:ignore.

Source/ThirdParty/ANGLE:

* ANGLE.xcodeproj: Modified property svn:ignore.
* src/build_angle.xcodeproj: Modified property svn:ignore.

Source/WebCore:

* WebCore.xcodeproj: Modified property svn:ignore.
* manual-tests/NPN_Invoke/NPN_Invoke.xcodeproj: Modified property svn:ignore.

Source/WebKit:

* WebKit.xcodeproj: Modified property svn:ignore.

Source/WebKit2:

* WebKit2.xcodeproj: Modified property svn:ignore.

Tools:

* DumpRenderTree/DumpRenderTree.xcodeproj: Modified property svn:ignore.
* MiniBrowser/MiniBrowser.xcodeproj: Modified property svn:ignore.
* TestWebKitAPI/TestWebKitAPI.xcodeproj: Modified property svn:ignore.
* WebKitLauncher/WebKitLauncher.xcodeproj: Modified property svn:ignore.
* WebKitTestRunner/WebKitTestRunner.xcodeproj: Modified property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Mac build.
weinig@apple.com [Thu, 17 Mar 2011 21:45:46 +0000 (21:45 +0000)]
Fix Mac build.

* WebCore.exp.in:
Add missing symbol.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWKErrors need the PeerCertificateChain for certificate errors
weinig@apple.com [Thu, 17 Mar 2011 21:25:27 +0000 (21:25 +0000)]
WKErrors need the PeerCertificateChain for certificate errors
<rdar://problem/8951784>
https://bugs.webkit.org/show_bug.cgi?id=56592

Reviewed by Anders Carlsson.

* Shared/WebCoreArgumentCoders.h:
Special case encoding/decoding of ResourceErrors for the mac.

* Shared/mac/PlatformCertificateInfo.h:
* Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::PlatformCertificateInfo):
Add constructor that take the PeerCertificateChain as CFArrayRef.

* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::encodeResourceError):
(CoreIPC::decodeResourceError):
Add encode/decode for ResourceError using the underlying NSError
and encoding/decoding as much of the userInfo as we know how to.
Right now this includes all string values and the PeerCertificateChain.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMake old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on...
aroben@apple.com [Thu, 17 Mar 2011 21:21:08 +0000 (21:21 +0000)]
Make old-run-webkit-tests pick up mac-wk2 results when running in WebKit2 mode on Windows

Fixes <http://webkit.org/b/56563> Running WebKit2 tests on Windows should use results from
mac-wk2

Reviewed by Anders Carlsson.

* Scripts/old-run-webkit-tests:
(expectedDirectoryForTest): Clean up the code to search in extra Mac platform result
directories on Windows. Add mac-wk2 to the set of extra platforms we look in on Windows when
we're running in WebKit2 mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WKWindowWillOrderOffScreenNotification.
andersca@apple.com [Thu, 17 Mar 2011 21:03:53 +0000 (21:03 +0000)]
Add WKWindowWillOrderOffScreenNotification.

* WebKitSystemInterface.h:
* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 17 Mar 2011 20:49:11 +0000 (20:49 +0000)]
2011-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adele Peterson and Enrica Casucci.

        Assert that editing does not ignore position's anchorNode if position is an offset in anchor
        https://bugs.webkit.org/show_bug.cgi?id=56027

        Debug build fix.

        * dom/Element.cpp:
        (WebCore::Element::updateFocusAppearance): "this" can be an input element so can't always instantiate
        a position inside the node. Call firstPositionInOrBeforeNode instead.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::positionAvoidingPrecedingNodes): Exit early when a node's content is ignored by editing instead
        of just when the node is br.
        * editing/htmlediting.cpp:
        (WebCore::lastEditablePositionBeforePositionInRoot): The shadow ancestor node is usually an input element
        so don't instantiate a position inside it. Call firstPositionInOrBeforeNode instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, update test_expectations.txt
dimich@chromium.org [Thu, 17 Mar 2011 20:44:51 +0000 (20:44 +0000)]
[Chromium] Unreviewed, update test_expectations.txt

Mark some tests as SLOW in DEBUG since they are on a borderline of shorter timeout.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip a flaky test on Mac
aroben@apple.com [Thu, 17 Mar 2011 20:43:11 +0000 (20:43 +0000)]
Skip a flaky test on Mac

<http://webkit.org/b/56578> tracks the failure.

* platform/mac/Skipped: Added http/tests/inspector/network/network-size.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip some flaky tests on the SnowLeopard WebKit2 bot
aroben@apple.com [Thu, 17 Mar 2011 20:30:25 +0000 (20:30 +0000)]
Skip some flaky tests on the SnowLeopard WebKit2 bot

Tracked by <http://webkit.org/b/56530> and <http://webkit.org/b/56584>.

* platform/mac-wk2/Skipped: Added http/tests/inspector/resource-har-conversion.html and
inspector/debugger/debug-inlined-scripts.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReverting r81197, breaks JIT + INTERPRETER build.
barraclough@apple.com [Thu, 17 Mar 2011 20:22:10 +0000 (20:22 +0000)]
Reverting r81197, breaks JIT + INTERPRETER build.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::hasGlobalResolveInstructionAtBytecodeOffset):
(JSC::CodeBlock::hasGlobalResolveInfoAtBytecodeOffset):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::addPropertyAccessInstruction):
(JSC::CodeBlock::addGlobalResolveInstruction):
(JSC::CodeBlock::addStructureStubInfo):
* bytecode/Opcode.h:
* bytecode/StructureStubInfo.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitResolve):
(JSC::BytecodeGenerator::emitResolveWithBase):
(JSC::BytecodeGenerator::emitGetById):
(JSC::BytecodeGenerator::emitPutById):
(JSC::BytecodeGenerator::emitDirectPutById):
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitConstruct):
(JSC::BytecodeGenerator::emitCatch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Ben Taylor <bentaylor.solx86@gmail.com>
commit-queue@webkit.org [Thu, 17 Mar 2011 20:07:14 +0000 (20:07 +0000)]
2011-03-17  Ben Taylor  <bentaylor.solx86@gmail.com>

        Reviewed by Alexey Proskuryakov.

        Add a COMPILER(SUNCC) define for Sun Studio 12.
        https://bugs.webkit.org/show_bug.cgi?56444
        derived from patch 1 of 16 originally from https://bugs.webkit.org/show_bug.cgi?id=24932

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Thu, 17 Mar 2011 19:50:50 +0000 (19:50 +0000)]
2011-03-17  James Simonsen  <simonjam@chromium.org>

        Unreviewed, update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Thu, 17 Mar 2011 19:49:26 +0000 (19:49 +0000)]
2011-03-17  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Adding a contains method to Vector.
        https://bugs.webkit.org/show_bug.cgi?id=55859

        * wtf/Vector.h:
        (WTF::::operator):
        (WTF::::contains):
2011-03-17  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Moving the method that is used to retrieve all the resources in
        a page from the Chromium code (dom_operations.cc) to WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=55859

        * WebKit.gyp:
        * public/WebPageSerializer.h:
        * public/WebURL.h:
        (WebKit::operator==):
        (WebKit::operator!=):
        * public/WebVector.h:
        (WebKit::WebVector::contains):
        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::WebDataSourceImpl):
        * src/WebPageSerializer.cpp:
        (WebCore::getSubResourceURLFromElement):
        (WebCore::retrieveResourcesForElement):
        (WebCore::retrieveResourcesForFrame):
        (WebKit::WebPageSerializer::retrieveAllResources):
        * tests/WebFrameTest.cpp:
        * tests/WebPageSerializerTest.cpp: Added.
        * tests/data/pageserialization: Added.
        * tests/data/pageserialization/awesome.png: Added.
        * tests/data/pageserialization/embed_iframe.html: Added.
        * tests/data/pageserialization/object_iframe.html: Added.
        * tests/data/pageserialization/simple_iframe.html: Added.
        * tests/data/pageserialization/simple_page.html: Added.
        * tests/data/pageserialization/top_frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Thu, 17 Mar 2011 19:14:58 +0000 (19:14 +0000)]
2011-03-17  James Simonsen  <simonjam@chromium.org>

        Unreviewed, update chromium test expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Sheriff Bot <webkit.review.bot@gmail.com>
podivilov@chromium.org [Thu, 17 Mar 2011 19:05:34 +0000 (19:05 +0000)]
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81369.
        http://trac.webkit.org/changeset/81369
        https://bugs.webkit.org/show_bug.cgi?id=56579

        breaks debugger test (Requested by podivilov on #webkit).

        * inspector/debugger/debug-inlined-scripts.html:
2011-03-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81369.
        http://trac.webkit.org/changeset/81369
        https://bugs.webkit.org/show_bug.cgi?id=56579

        breaks debugger test (Requested by podivilov on #webkit).

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
        (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._encodeSourceLocation):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
        (WebInspector.DebuggerPresentationModel.prototype.reset):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._parsedScriptSource):
        (WebInspector.ScriptsPanel.prototype._failedToParseScriptSource):
        (WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
        (WebInspector.ScriptsPanel.prototype._addScript):
        (WebInspector.ScriptsPanel.prototype._resourceForURL):
        (WebInspector.ScriptsPanel.prototype._resourceLoadingFinished):
        (WebInspector.ScriptsPanel.prototype._addOptionToFilesSelectAndShowSourceFrameIfNeeded):
        (WebInspector.ScriptsPanel.prototype._showSourceFrame):
        (WebInspector.ScriptsPanel.prototype._recreateSourceFrame):
        (WebInspector.ScriptsPanel.prototype._sourceFileIdForScript):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 17 Mar 2011 19:02:50 +0000 (19:02 +0000)]
2011-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Justin Garcia.

        Assert that editing does not ignore position's anchorNode if position is an offset in anchor
        https://bugs.webkit.org/show_bug.cgi?id=56027

        Added a test to ensure WebKit lets users edit contents inside a button element properly.

        * editing/execCommand/button-expected.txt: Added.
        * editing/execCommand/button.html: Added.
2011-03-17  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Justin Garcia.

        Assert that editing does not ignore position's anchorNode if position is an offset in anchor
        https://bugs.webkit.org/show_bug.cgi?id=56027

        Added the assertion in Position::Position and Position::moveToPosition. This assertion catches
        places where we instantiate positions inside a node on which editingIgnoresContent returns true.

        Test: editing/execCommand/button.html

        * dom/Position.cpp:
        (WebCore::Position::Position): Added an assertion.
        (WebCore::Position::moveToPosition): Ditto.
        * dom/PositionIterator.cpp:
        (WebCore::PositionIterator::operator Position): Avoid creating a position immediately below
        a node whose content is ignored by editing. While this does not avoid creation of positions
        inside ignored contents completely, it works in most cases. Filed the bug 56027 to resolve
        the underlying problem. Without this change, the assertion hits in existing layout tests.
        cannot be tested directly.
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded): Call firstPositionInOrBeforeNode
        instead of firstPositionInNode because startNode may as well be a br element. Without this change,
        the assertion hits in existing layout tests.
        * editing/htmlediting.cpp:
        (WebCore::canHaveChildrenForEditing): button is editable so content is not ignored. Added a test
        for this.
        * editing/visible_units.cpp:
        (WebCore::previousBoundary): Added a FIXME.
        (WebCore::startPositionForLine): Because br can also have an inline text box, checking that
        startBox is an inline text box isn't an adequate to instantiate a position inside startNode.
        Call startNode->isTextNode() instead. Without this change, the assertion hits in existing layout
        tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip three tests that fail on one Windows WebKit2 slave but not the other
aroben@apple.com [Thu, 17 Mar 2011 18:45:12 +0000 (18:45 +0000)]
Skip three tests that fail on one Windows WebKit2 slave but not the other

The failures are tracked by <http://webkit.org/b/56550>.

* platform/win-wk2/Skipped: Added fast/events/tabindex-focus-blur-all.html,
fast/forms/button-align.html, and media/audio-mpeg4-supported.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=56574
sullivan@apple.com [Thu, 17 Mar 2011 18:41:03 +0000 (18:41 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56574
Dealloc'ing a WKView can leave a stale reference to it in NSWindow

Reviewed by Adam Roben.

* UIProcess/API/mac/WKView.mm:
(-[WKView viewWillMoveToWindow:]):
Clear the outgoing window's growBoxOwner if it is this view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename PluginProcessShim.cpp to PluginProcessShim.mm.
andersca@apple.com [Thu, 17 Mar 2011 18:39:32 +0000 (18:39 +0000)]
Rename PluginProcessShim.cpp to PluginProcessShim.mm.

Rubber-stamped by John Sullivan.

* PluginProcess/mac/PluginProcessShim.cpp: Removed.
* PluginProcess/mac/PluginProcessShim.mm: Copied from PluginProcess/mac/PluginProcessShim.cpp.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 17 Mar 2011 18:28:52 +0000 (18:28 +0000)]
2011-03-17  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Invalidate all NPObjects for a plug-in when that plug-in is destroyed
        https://bugs.webkit.org/show_bug.cgi?id=56511
        <rdar://problem/8993491>

        Before this change, we would invalidate NPObjectProxy objects and delete NPObjectMessageReceiver
        objects when the last plug-in of a certain type was destroyed. Doing so caused us to hold on to memory
        which we don't need, and could also lead to crashes if the NPObjectMessageReceiver would get a message and
        tried to invoke it on a already deallocated NPObject.

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::initialize):
        If we fail to initialize, call removePluginControllerProxy instead of having WebProcessConnection do so.

        (WebKit::PluginControllerProxy::destroy):
        Pass the plug-in to removePluginControllerProxy.

        * PluginProcess/WebProcessConnection.cpp:
        (WebKit::WebProcessConnection::removePluginControllerProxy):
        Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.

        (WebKit::WebProcessConnection::createPlugin):
        Don't call removePluginControllerProxy if the plug-in fails to initialize. PluginControllerProxy::initialize now
        takes care of doing this.

        * Shared/Plugins/NPObjectMessageReceiver.cpp:
        (WebKit::NPObjectMessageReceiver::NPObjectMessageReceiver):
        (WebKit::NPObjectMessageReceiver::~NPObjectMessageReceiver):
        * Shared/Plugins/NPObjectMessageReceiver.h:
        Remove m_shouldReleaseObjectWhenInvalidating, we now know that no NPObjects will have been deallocated
        by the time the NPObjectMessageReceiver is destroyed.

        (WebKit::NPObjectMessageReceiver::plugin):
        Add getter.

        * Shared/Plugins/NPObjectProxy.h:
        (WebKit::NPObjectProxy::plugin):
        Add getter.

        * Shared/Plugins/NPRemoteObjectMap.cpp:
        (WebKit::NPRemoteObjectMap::NPRemoteObjectMap):
        Remove m_isInvalidating.

        (WebKit::NPRemoteObjectMap::npObjectProxyDestroyed):
        Simplify code.

        (WebKit::NPRemoteObjectMap::pluginDestroyed):
        Rename invalidate to pluginDestroyed. Only invalidate/delete objects that belong to the given plug-in.

        * Shared/Plugins/NPRemoteObjectMap.h:
        Remove m_isInvalidating.

        * WebProcess/Plugins/PluginProcessConnection.cpp:
        (WebKit::PluginProcessConnection::removePluginProxy):
        Call NPRemoteObjectMap::pluginDestroyed when the plug-in has been destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 17 Mar 2011 18:14:28 +0000 (18:14 +0000)]
2011-03-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract content loading logic from scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=55237

        * inspector/debugger/debug-inlined-scripts.html:
2011-03-17  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: extract content loading logic from scripts panel.
        https://bugs.webkit.org/show_bug.cgi?id=55237

        Encapsulate source files creation logic in debugger presentation model
        to support source mappings in a pluggable way.

        * inspector/front-end/DebuggerPresentationModel.js:
        (WebInspector.DebuggerPresentationModel.prototype.sourceFile):
        (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent.else.didRequestSource):
        (WebInspector.DebuggerPresentationModel.prototype.requestSourceFileContent):
        (WebInspector.DebuggerPresentationModel.prototype._parsedScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._failedToParseScriptSource):
        (WebInspector.DebuggerPresentationModel.prototype._addScript.else.resourceFinished):
        (WebInspector.DebuggerPresentationModel.prototype._addScript):
        (WebInspector.DebuggerPresentationModel.prototype._ensureSourceFileAdded):
        (WebInspector.DebuggerPresentationModel.prototype._resourceForURL):
        (WebInspector.DebuggerPresentationModel.prototype._scriptSourceChanged):
        (WebInspector.DebuggerPresentationModel.prototype._sourceFileAdded):
        (WebInspector.DebuggerPresentationModel.prototype.breakpointsForSourceFileId):
        (WebInspector.DebuggerPresentationModel.prototype.findBreakpoint):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointAdded):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointRemoved):
        (WebInspector.DebuggerPresentationModel.prototype._breakpointResolved):
        (WebInspector.DebuggerPresentationModel.prototype._restoreBreakpoints):
        (WebInspector.DebuggerPresentationModel.prototype.set selectedCallFrame):
        (WebInspector.DebuggerPresentationModel.prototype._actualLocationToSourceLocation):
        (WebInspector.DebuggerPresentationModel.prototype.reset):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype._sourceFileAdded):
        (WebInspector.ScriptsPanel.prototype._showSourceFrame):
        (WebInspector.ScriptsPanel.prototype._sourceFileChanged):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        (WebInspector.SourceFrameDelegateForScriptsPanel.prototype.requestContent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 17 Mar 2011 18:10:15 +0000 (18:10 +0000)]
2011-03-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add types markup to the IDL, remove Value types from the protocol.
        https://bugs.webkit.org/show_bug.cgi?id=56562

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):
        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::evaluate):
        (WebCore::InjectedScript::evaluateOn):
        (WebCore::InjectedScript::evaluateOnCallFrame):
        (WebCore::InjectedScript::getProperties):
        (WebCore::InjectedScript::setPropertyValue):
        (WebCore::InjectedScript::callFrames):
        (WebCore::InjectedScript::makeCall):
        (WebCore::InjectedScript::makeObjectCall):
        * inspector/InjectedScript.h:
        * inspector/InjectedScriptSource.js:
        (.):
        * inspector/Inspector.idl:
        * inspector/InspectorApplicationCacheAgent.cpp:
        (WebCore::InspectorApplicationCacheAgent::getApplicationCaches):
        * inspector/InspectorApplicationCacheAgent.h:
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getStylesForNode):
        (WebCore::InspectorCSSAgent::getInlineStyleForNode):
        (WebCore::InspectorCSSAgent::getComputedStyleForNode):
        (WebCore::InspectorCSSAgent::getStyleSheet):
        (WebCore::InspectorCSSAgent::setPropertyText):
        (WebCore::InspectorCSSAgent::toggleProperty):
        (WebCore::InspectorCSSAgent::setRuleSelector):
        (WebCore::InspectorCSSAgent::addRule):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::resolveNode):
        * inspector/InspectorDOMAgent.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::editScriptSource):
        (WebCore::InspectorDebuggerAgent::evaluateOnCallFrame):
        (WebCore::InspectorDebuggerAgent::currentCallFrames):
        * inspector/InspectorDebuggerAgent.h:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        * inspector/InspectorRuntimeAgent.cpp:
        (WebCore::InspectorRuntimeAgent::evaluate):
        (WebCore::InspectorRuntimeAgent::evaluateOn):
        (WebCore::InspectorRuntimeAgent::getProperties):
        (WebCore::InspectorRuntimeAgent::setPropertyValue):
        * inspector/InspectorRuntimeAgent.h:
        * inspector/ScriptCallStack.cpp:
        (WebCore::ScriptCallStack::buildInspectorArray):
        * inspector/ScriptCallStack.h:
        * inspector/TimelineRecordFactory.cpp:
        (WebCore::TimelineRecordFactory::createGenericRecord):
        * inspector/front-end/NetworkManager.js:
        (WebInspector.NetworkDispatcher.prototype._createResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agochangelog
simonjam@chromium.org [Thu, 17 Mar 2011 18:07:09 +0000 (18:07 +0000)]
changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofirst changes
simonjam@chromium.org [Thu, 17 Mar 2011 18:07:04 +0000 (18:07 +0000)]
first changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2011-03-17 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 17 Mar 2011 17:53:28 +0000 (17:53 +0000)]
2011-03-17  Tony Chang  <tony@chromium.org>

        Reviewed by Pavel Feldman.

        [chromium] don't concatenate devtools files when debug_devtools=1
        https://bugs.webkit.org/show_bug.cgi?id=56572

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable http/tests/inspector/resource-parameters.html
aroben@apple.com [Thu, 17 Mar 2011 17:35:04 +0000 (17:35 +0000)]
Disable http/tests/inspector/resource-parameters.html

It is flaky. The flakiness is tracked by <http://webkit.org/b/55867>.

* http/tests/inspector/resource-parameters.html-disabled: Renamed from LayoutTests/http/tests/inspector/resource-parameters.html.

* platform/qt/Skipped: Removed the test from this Skipped file since it has been disabled.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81363 268f45cc-cd09-0410-ab3c-d52691b4dbfc