WebKit-https.git
9 years agoMoved previous link error fix to Base.xcconfig
cmarrin@apple.com [Tue, 17 Aug 2010 17:24:14 +0000 (17:24 +0000)]
Moved previous link error fix to Base.xcconfig

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRestore intrinsic size of video elements after loading poster
vestbo@webkit.org [Tue, 17 Aug 2010 17:18:22 +0000 (17:18 +0000)]
Restore intrinsic size of video elements after loading poster

Reviewed by Eric Carlson.

The element might already have the instrinsic size of the video, in
which case we don't want to override it witht that of the image.

* rendering/RenderVideo.cpp: call updateIntrinsicSize() to restore size

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Steve Block <steveblock@google.com>
steveblock@google.com [Tue, 17 Aug 2010 17:13:22 +0000 (17:13 +0000)]
2010-08-17  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        [Qt] fast/dom/Geolocation/disconnected-frame-permission-denied.html fails
        https://bugs.webkit.org/show_bug.cgi?id=44059

        * fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt:
        * fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js:
        (onIframeLoaded):
        ():
        * platform/chromium/test_expectations.txt:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed link errors in WebCore build on Mac
cmarrin@apple.com [Tue, 17 Aug 2010 17:05:30 +0000 (17:05 +0000)]
Fixed link errors in WebCore build on Mac

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
commit-queue@webkit.org [Tue, 17 Aug 2010 16:54:23 +0000 (16:54 +0000)]
2010-08-17  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Steve Block.

        Geolocation preemptive permissions policy is buggy
        https://bugs.webkit.org/show_bug.cgi?id=42811

        Adds cases where permission is niether denied or granted immediately and multiple
        requests are waiting.

        * fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests-expected.txt: Added.
        * fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html: Added.
        * fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests-expected.txt: Added.
        * fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html: Added.
        * fast/dom/Geolocation/script-tests/delayed-permission-allowed-for-multiple-requests.js: Added.
        (allowPermission):
        ():
        (maybeFinishTest):
        * fast/dom/Geolocation/script-tests/delayed-permission-denied-for-multiple-requests.js: Added.
        (denyPermission):
        (maybeFinishTest):
        * platform/gtk/Skipped:
        * platform/qt/Skipped:
2010-08-17  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Steve Block.

        Geolocation preemptive permissions policy is buggy
        https://bugs.webkit.org/show_bug.cgi?id=42811

        While waiting for permission, m_startRequestPermissionNotifier was
        used to consider only one pending request. This patch implements a set
        m_pendingForPermissionNotifiers to maintain set of pending requests.
        When user grants/denies permission all listeners will be notified.
        Also fixed issue with hasZeroTimeout() where startTimerIfNeeded() has
        to start irrespective of permission state

        Tests: fast/dom/Geolocation/delayed-permission-allowed-for-multiple-requests.html
               fast/dom/Geolocation/delayed-permission-denied-for-multiple-requests.html

        * WebCore.pro:
        * page/Geolocation.cpp:
        (WebCore::Geolocation::startRequest):
        (WebCore::Geolocation::setIsAllowed):
        (WebCore::Geolocation::startUpdating):
        (WebCore::Geolocation::handlePendingPermissionNotifiers):
        * page/Geolocation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Kelly Norton <knorton@google.com>
knorton@google.com [Tue, 17 Aug 2010 16:27:42 +0000 (16:27 +0000)]
2010-08-17  Kelly Norton  <knorton@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: Fixes a crash in addTimelineRecord when InspectorTimelineAgent
        is enabled through WebDevToolsAgentImpl::setApuEnabled.
        https://bugs.webkit.org/show_bug.cgi?id=44105

        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::setApuAgentEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-09 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 17 Aug 2010 16:18:21 +0000 (16:18 +0000)]
2010-08-09  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Beginnings of IndexedDB persistance + IDBDatabase.description fleshed out
        https://bugs.webkit.org/show_bug.cgi?id=43744

        Add a layout test for IDBDatabase.description.

        * storage/indexeddb/database-description-expected.txt: Added.
        * storage/indexeddb/database-description.html: Added.
        * storage/indexeddb/script-tests/database-description.js: Added.
        (test):
        (firstSuccess):
        (secondSuccess):
        (thirdSuccess):
2010-08-11  Jeremy Orlow  <jorlow@chromium.org>

        Beginnings of IndexedDB persistance + IDBDatabase.description fleshed out
        https://bugs.webkit.org/show_bug.cgi?id=43744

        The beginnings of a SQLite backend for IndexedDB.  Right now, only persists
        meta-data for the database.  The rest is coming in future patches.  Adds
        a manual test to verify persistance.

        Test: storage/indexeddb/database-description.html
              + a manual test

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * manual-tests/indexed-database.html: Added.
        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::databaseIdentifier):
        * platform/FileSystem.cpp: Added.
        (WebCore::):
        (WebCore::shouldEscapeUChar):
        (WebCore::encodeForFileName):
        * platform/FileSystem.h:
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::IDBDatabase):
        * storage/IDBDatabase.h:
        (WebCore::IDBDatabase::description):
        * storage/IDBDatabaseBackendImpl.cpp:
        (WebCore::extractMetaData):
        (WebCore::setMetaData):
        (WebCore::IDBDatabaseBackendImpl::IDBDatabaseBackendImpl):
        (WebCore::IDBDatabaseBackendImpl::setDescription):
        * storage/IDBDatabaseBackendImpl.h:
        (WebCore::IDBDatabaseBackendImpl::create):
        * storage/IDBFactory.h:
        * storage/IDBFactory.idl:
        * storage/IDBFactoryBackendImpl.cpp:
        (WebCore::IDBFactoryBackendImpl::IDBFactoryBackendImpl):
        (WebCore::IDBFactoryBackendImpl::~IDBFactoryBackendImpl):
        (WebCore::openSQLiteDatabase):
        (WebCore::createTables):
        (WebCore::IDBFactoryBackendImpl::open):
        * storage/IDBFactoryBackendImpl.h:
        (WebCore::IDBFactoryBackendImpl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 17 Aug 2010 16:15:17 +0000 (16:15 +0000)]
2010-08-17  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Eliminate extra traversal of the tree when determining ability to lazy-attach a Node.
        https://bugs.webkit.org/show_bug.cgi?id=43749

        Neither SVG nor inputs/counters shadow DOM are traveling down this path (they home-bake their attachment),
        so the check for shadow tree existence isn't needed.

        Gives a small, but consisten win in Dromaeo's DOM Modification test.

        * dom/Node.cpp: Removed canLazyAttach declaration.
        * dom/Node.h:
        (WebCore::Node::canLazyAttach): Changed to always return true.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 17 Aug 2010 15:59:46 +0000 (15:59 +0000)]
2010-08-17  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Revert r41142. Unskipped tests are still failing.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 17 Aug 2010 15:55:56 +0000 (15:55 +0000)]
2010-08-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [CRASH] Console formatting crashes after cross-domain navigation.
        https://bugs.webkit.org/show_bug.cgi?id=44103

        * http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html:
2010-08-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [CRASH] Console formatting crashes after cross-domain navigation.
        https://bugs.webkit.org/show_bug.cgi?id=44103

        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::injectedScriptFor):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::addToFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 17 Aug 2010 15:41:03 +0000 (15:41 +0000)]
2010-08-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: upstream Chromium debugger step tests
        https://bugs.webkit.org/show_bug.cgi?id=44106

        * http/tests/inspector-enabled/console-log-before-frame-navigation.html:
        * http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Added.
        (doit.callback):
        (doit):
        (receiveMessage):
        (frontend_dumpConsoleMessages):
        * http/tests/inspector/debugger-test.js:
        (frontend_captureStackTrace):
        * inspector/debugger-step-in-expected.txt: Added.
        * inspector/debugger-step-in.html: Added.
        * inspector/debugger-step-out-expected.txt: Added.
        * inspector/debugger-step-out.html: Added.
        * inspector/debugger-step-over-expected.txt: Added.
        * inspector/debugger-step-over.html: Added.
2010-08-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: upstream Chromium debugger step tests
        https://bugs.webkit.org/show_bug.cgi?id=44106

        Tests: inspector/debugger-step-in.html
               inspector/debugger-step-out.html
               inspector/debugger-step-over.html

        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::returnEvent): check that debugger is still attached after continue to ensure
        that current call frame is not 0.
2010-08-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: upstream Chromium debugger step tests
        https://bugs.webkit.org/show_bug.cgi?id=44106

        * src/js/Tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Tue, 17 Aug 2010 15:35:29 +0000 (15:35 +0000)]
2010-08-17  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by David Levin.

        Trivial fix removing the self-inclusion of a couple of header files.

        Self inclusion in Document.h and RenderTheme.h
        https://bugs.webkit.org/show_bug.cgi?id=44065

        * dom/Document.h:
        * rendering/RenderTheme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 17 Aug 2010 15:03:07 +0000 (15:03 +0000)]
2010-08-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        [Qt] Web Inspector: inspector/debugger-pause-on-debugger-statement.html times out on Qt
        https://bugs.webkit.org/show_bug.cgi?id=41142

        * platform/qt/Skipped: the tests should pass after r65315

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Tue, 17 Aug 2010 14:54:31 +0000 (14:54 +0000)]
2010-08-17  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Move the accelerated compositing build flag to the right place
        https://bugs.webkit.org/show_bug.cgi?id=43882

        * wtf/Platform.h:
2010-08-17  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Move the accelerated compositing build flag to the right place
        https://bugs.webkit.org/show_bug.cgi?id=43882

        No new tests: build fix.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Tue, 17 Aug 2010 14:49:31 +0000 (14:49 +0000)]
2010-08-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65500.
        http://trac.webkit.org/changeset/65500
        https://bugs.webkit.org/show_bug.cgi?id=44108

        Qt bots failed to compile. (Requested by loislo on #webkit).

        * GNUmakefile.am:
2010-08-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65500.
        http://trac.webkit.org/changeset/65500
        https://bugs.webkit.org/show_bug.cgi?id=44108

        Qt bots failed to compile. (Requested by loislo on #webkit).

        * platform/gtk/Skipped:
2010-08-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65500.
        http://trac.webkit.org/changeset/65500
        https://bugs.webkit.org/show_bug.cgi?id=44108

        Qt bots failed to compile. (Requested by loislo on #webkit).

        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/copyInspectorFiles.cmd:
        * WebCore.xcodeproj/project.pbxproj:
        * combine-javascript-resources:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/front-end/InspectorBackendStub.js: Added.
        (WebInspector.InspectorBackendStub):
        (WebInspector.InspectorBackendStub.prototype._registerDelegate):
        (WebInspector.InspectorBackendStub.prototype.sendMessageToBackend):
        * inspector/front-end/InspectorBackendStub.qrc: Removed.
        * inspector/front-end/WebKit.qrc:
2010-08-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65500.
        http://trac.webkit.org/changeset/65500
        https://bugs.webkit.org/show_bug.cgi?id=44108

        Qt bots failed to compile. (Requested by loislo on #webkit).

        * WebKit.gyp:
2010-08-17  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65500.
        http://trac.webkit.org/changeset/65500
        https://bugs.webkit.org/show_bug.cgi?id=44108

        Qt bots failed to compile. (Requested by loislo on #webkit).

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::openInspectorFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 17 Aug 2010 14:33:53 +0000 (14:33 +0000)]
2010-08-16  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: replace hand written InspectorBackendStub.js by generated one.
        New command-line flag was added to combine-javascript-resources.
        It specifies the location of generated scripts.
        https://bugs.webkit.org/show_bug.cgi?id=43791

        * GNUmakefile.am:
        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * combine-javascript-resources:
        * inspector/CodeGeneratorInspector.pm:
        * inspector/front-end/InspectorBackendStub.js: Removed.
        * inspector/front-end/WebKit.qrc:

2010-08-16  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: replace hand written InspectorBackendStub.js by generated one.
        https://bugs.webkit.org/show_bug.cgi?id=43791

        * GNUmakefile.am:

2010-08-17  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        WebInspector: inspector tests for GTK were added to Skip list.
        They should be enabled later.
        Bug for GTK https://bugs.webkit.org/show_bug.cgi?id=43977
        https://bugs.webkit.org/show_bug.cgi?id=43791

        * platform/gtk/Skipped:

2010-08-17  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: replace hand written InspectorBackendStub.js by generated one.
        https://bugs.webkit.org/show_bug.cgi?id=43791

        * WebKit.gyp:

2010-08-17  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: replace hand written InspectorBackendStub.js by generated one.
        https://bugs.webkit.org/show_bug.cgi?id=43791

        * WebCoreSupport/InspectorClientGtk.cpp:
        (WebKit::InspectorClient::openInspectorFrontend):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 17 Aug 2010 13:30:43 +0000 (13:30 +0000)]
2010-08-17  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: get rid of node and scoped object-specific ids.
        https://bugs.webkit.org/show_bug.cgi?id=44097

        * inspector/front-end/ConsoleView.js:
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        * inspector/front-end/EventListenersSidebarPane.js:
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor.):
        (injectedScriptConstructor):
        * inspector/front-end/InjectedScriptAccess.js:
        (InjectedScriptAccess):
        (InjectedScriptAccess.getForNode):
        (InjectedScriptAccess._installHandler.InjectedScriptAccess.prototype.methodName):
        (InjectedScriptAccess._installHandler):
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObjectId):
        (WebInspector.RemoteObject.resolveNode):
        * inspector/front-end/ScriptsPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 17 Aug 2010 13:09:57 +0000 (13:09 +0000)]
2010-08-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] GSettings support adds annoying warnings on systems with older glib versions
        https://bugs.webkit.org/show_bug.cgi?id=44056

        Add file containing GLIB_GSETTINGS macro so that
        configure doesn't spit warnings in older systems.

        * autotools/gsettings.m4: Added.
        * .gitignore: Ignore files that are generated inside autotools
        explicitely, because we have some that are kept in version
        control.

WebKit/gtk

2010-08-17  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Martin Robinson.

        [GTK] GSettings support adds annoying warnings on systems with older glib versions
        https://bugs.webkit.org/show_bug.cgi?id=44056

        Use #ifdef instead of #if for HAVE_GSETTINGS to avoid warnings
        when it is not defined.

        * WebCoreSupport/InspectorClientGtk.cpp:
        * webkit/webkitprivate.cpp:
        (webkit_init):
        * webkit/webkitprivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 17 Aug 2010 12:23:00 +0000 (12:23 +0000)]
2010-08-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        [GTK] Fix wrapping of core Events in the bindings
        https://bugs.webkit.org/show_bug.cgi?id=44095

        Return the proper GObject type instead of hardcoding
        WebKitDOMEvent for all Event types.

        * bindings/gobject/GObjectEventListener.cpp:
        (WebCore::GObjectEventListener::handleEvent):
        * bindings/gobject/WebKitDOMBinding.cpp:
        (WebKit::kit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Tue, 17 Aug 2010 12:22:46 +0000 (12:22 +0000)]
2010-08-17  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Gustavo Noronha.

        Revert supposed build-fix which was in fact reverting a previous
        build fix which was correct (oh dear).

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add media element support for preload=none
vestbo@webkit.org [Tue, 17 Aug 2010 12:15:25 +0000 (12:15 +0000)]
[Qt] Add media element support for preload=none

Reviewed by Antonio Gomes.

* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
* platform/graphics/qt/MediaPlayerPrivateQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Pre-roll media when loading media elements
vestbo@webkit.org [Tue, 17 Aug 2010 12:15:04 +0000 (12:15 +0000)]
[Qt] Pre-roll media when loading media elements

Reviewed by Antonio Gomes.

This ensures we get correct size-hints from QtMultimedia, as well as
the media states Buffering and Buffered instead of Loading and Loaded,
which we use to transition into MediaPlayer::HaveEnoughData.

* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
* platform/graphics/qt/MediaPlayerPrivateQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Yuta Kitamura <yutak@chromium.org>
commit-queue@webkit.org [Tue, 17 Aug 2010 11:54:39 +0000 (11:54 +0000)]
2010-08-17  Yuta Kitamura  <yutak@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Avoid uninitialized memory read in StringImpl::find().

        REGRESSION(r65468): Crashes in StringImpl::find
        https://bugs.webkit.org/show_bug.cgi?id=44099

        * wtf/text/StringImpl.cpp:
        (WTF::StringImpl::find):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix missing default controls for stand-alone media elements
vestbo@webkit.org [Tue, 17 Aug 2010 11:38:43 +0000 (11:38 +0000)]
[Qt] Fix missing default controls for stand-alone media elements

Reviewed by Kenneth Christiansen.

https://bugs.webkit.org/show_bug.cgi?id=35427

* css/mediaControlsQt.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement ChromeClient's windowToScreen() and screenToWindow()
vestbo@webkit.org [Tue, 17 Aug 2010 11:18:41 +0000 (11:18 +0000)]
[Qt] Implement ChromeClient's windowToScreen() and screenToWindow()

Reviewed by Kenneth Christiansen.

* WebCoreSupport/ChromeClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Tue, 17 Aug 2010 09:05:20 +0000 (09:05 +0000)]
2010-08-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: upstream Chromium console tests
        https://bugs.webkit.org/show_bug.cgi?id=44057

        * inspector/console-eval-expected.txt: Added.
        * inspector/console-eval-global-expected.txt: Added.
        * inspector/console-eval-global.html: Added.
        * inspector/console-eval.html: Added.
        * platform/chromium/inspector/console-eval-global-expected.txt: Added.
2010-08-17  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: upstream Chromium console tests and remove a couple
        of tests that have already been covered with layout tests.
        https://bugs.webkit.org/show_bug.cgi?id=44057

        * src/js/Tests.js:
        (.TestSuite.prototype.testConsoleEval):
        (.TestSuite.prototype.testConsoleLog):
        (.TestSuite.prototype.testEvalGlobal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Tue, 17 Aug 2010 08:55:17 +0000 (08:55 +0000)]
2010-08-17  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Ariya Hidayat.

        [Qt] tests whose bug was closed but are still skipped
        https://bugs.webkit.org/show_bug.cgi?id=44068

        Enable tests whose bugs have been fixed already:

          https://bugs.webkit.org/show_bug.cgi?id=35350 (fixed)
          https://bugs.webkit.org/show_bug.cgi?id=28952 (fixed)
          https://bugs.webkit.org/show_bug.cgi?id=38502 (see discussion at the end)
          https://bugs.webkit.org/show_bug.cgi?id=38604 (fixed)

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Tue, 17 Aug 2010 08:32:54 +0000 (08:32 +0000)]
2010-08-17  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Reduce the size of the shadow buffer to the clip region
        https://bugs.webkit.org/show_bug.cgi?id=44091

        Instead of allocating the buffer image (for the blur support) as big
        as the rectangle which casts the shadow, we limit the size to the
        current clip region.

        * platform/graphics/qt/ContextShadow.cpp:
        (WebCore::ContextShadow::drawShadowRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd/correct a few items in the WebKitTestRunner Skipped list.
mjs@apple.com [Tue, 17 Aug 2010 07:08:21 +0000 (07:08 +0000)]
Add/correct a few items in the WebKitTestRunner Skipped list.

Rubber stamped by Sam Weinig.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 17 Aug 2010 06:48:24 +0000 (06:48 +0000)]
2010-08-17  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] media/invalid-media-url-crash.html fails
        https://bugs.webkit.org/show_bug.cgi?id=42960

        Implemented two ResourceHandleClient callbacks that need to notify
        downstream GStreamer elements of errors while accessing the
        resource.

        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
        (StreamingClient::wasBlocked):
        (StreamingClient::cannotShowURL):

LayoutTests:

2010-08-17  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GStreamer] media/invalid-media-url-crash.html fails
        https://bugs.webkit.org/show_bug.cgi?id=42960

        * platform/gtk/Skipped: Unskip fixed test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 17 Aug 2010 04:27:30 +0000 (04:27 +0000)]
2010-08-16  Kinuko Yasuda  <kinuko@chromium.org>

        Unreviewed; attempt to fix Chromium Windows build.

        * public/WebFileUtilities.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAllow some tests to pass in WebKitTestRunner before SharedMemory and
jhoneycutt@apple.com [Tue, 17 Aug 2010 04:07:58 +0000 (04:07 +0000)]
Allow some tests to pass in WebKitTestRunner before SharedMemory and
PluginInfoStore are implemented on Windows.

Reviewed by Sam Weinig.

* Platform/win/SharedMemoryWin.cpp:
Disable not implemented warnings.
* UIProcess/Plugins/win/PluginInfoStoreWin.cpp:
Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Yuta Kitamura <yutak@chromium.org>
morrita@google.com [Tue, 17 Aug 2010 03:59:32 +0000 (03:59 +0000)]
2010-08-16  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed test expectation update.

        Update Chromium test expectations.
        https://bugs.webkit.org/show_bug.cgi?id=44090

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 17 Aug 2010 03:53:40 +0000 (03:53 +0000)]
2010-08-16  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Jian Li.

        [chromium] Prepare to rename WebFileSystem interface to WebFileUtilities
        https://bugs.webkit.org/show_bug.cgi?id=44077

        We are going to have an implementation for HTML5 FileSystem API and
        it would probably be less confusing to use the name "WebFileSystem"
        for an WebKit API for the HTML5 API.

        This patch adds WebFileUtilities interface that is meant to replace
        the existing WebFileSystem.

        * WebKit.gyp:
        * public/WebFileSystem.h:
        * public/WebFileUtilities.h: Added.
        * public/WebKitClient.h:
        (WebKit::WebKitClient::fileUtilities): Added.
        * src/ChromiumBridge.cpp:
        (WebCore::ChromiumBridge::fileExists):
        (WebCore::ChromiumBridge::deleteFile):
        (WebCore::ChromiumBridge::deleteEmptyDirectory):
        (WebCore::ChromiumBridge::getFileSize):
        (WebCore::ChromiumBridge::getFileModificationTime):
        (WebCore::ChromiumBridge::directoryName):
        (WebCore::ChromiumBridge::pathByAppendingComponent):
        (WebCore::ChromiumBridge::makeAllDirectories):
        (WebCore::ChromiumBridge::getAbsolutePath):
        (WebCore::ChromiumBridge::isDirectory):
        (WebCore::ChromiumBridge::filePathToURL):
        (WebCore::ChromiumBridge::openFile):
        (WebCore::ChromiumBridge::closeFile):
        (WebCore::ChromiumBridge::seekFile):
        (WebCore::ChromiumBridge::truncateFile):
        (WebCore::ChromiumBridge::readFromFile):
        (WebCore::ChromiumBridge::writeToFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 17 Aug 2010 03:42:57 +0000 (03:42 +0000)]
2010-08-16  Kinuko Yasuda  <kinuko@chromium.org>

        Unreviewed; build fix attempt for Windows.

        * DefaultDownloadDelegate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd some tests that fail in WebKitTestRunner to the Skipped lists.
jhoneycutt@apple.com [Tue, 17 Aug 2010 03:39:40 +0000 (03:39 +0000)]
Add some tests that fail in WebKitTestRunner to the Skipped lists.

Rubber-stamped by Sam Weinig.

* platform/mac-wk2/Skipped:
* platform/win-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd VectorTraits to String & DefaultHash traits to UString to unify behaviour.
barraclough@apple.com [Tue, 17 Aug 2010 02:21:26 +0000 (02:21 +0000)]
Add VectorTraits to String & DefaultHash traits to UString to unify behaviour.

Rubber stamped by Sam Weinig

* runtime/UString.h:
(JSC::UStringHash::hash):
(JSC::UStringHash::equal):
(WTF::):
* wtf/text/WTFString.h:
(WTF::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary includes from UString.h, add new includes as necessary.
barraclough@apple.com [Tue, 17 Aug 2010 02:13:02 +0000 (02:13 +0000)]
Remove unnecessary includes from UString.h, add new includes as necessary.

Rubber stamped by Sam Weinig

JavaScriptCore:

* profiler/CallIdentifier.h:
* profiler/ProfileNode.h:
* runtime/DateConversion.cpp:
* runtime/Identifier.h:
(JSC::IdentifierRepHash::hash):
* runtime/RegExpCache.h:
* runtime/RegExpKey.h:
* runtime/UString.cpp:
(JSC::UString::substr):
* runtime/UString.h:
* wtf/text/WTFString.h:

WebCore:

* dom/ScriptExecutionContext.h:
* loader/appcache/ApplicationCache.cpp:

WebKit2:

* WebProcess/Plugins/Netscape/NetscapePlugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Tue, 17 Aug 2010 01:54:18 +0000 (01:54 +0000)]
2010-08-16  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Ariya Hidayat.

        [Qt] REGRESSION: editing/selection/shrink-selection-after-shift-pagedown.html fails after 56567
        https://bugs.webkit.org/show_bug.cgi?id=36628

        Just enabling the test, it's not failing anymore.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Ademar de Souza Reis Jr <ademar.reis@openbossa.org>
commit-queue@webkit.org [Tue, 17 Aug 2010 01:19:45 +0000 (01:19 +0000)]
2010-08-16  Ademar de Souza Reis Jr  <ademar.reis@openbossa.org>

        Reviewed by Ariya Hidayat.

        [Qt] qt/Skipped needs cleanup on outdaded comments
        https://bugs.webkit.org/show_bug.cgi?id=44066

        Minor improvements/fixes to the list of Skipped Qt tests

         - move bug reference to the right place (#35145)
         - remove outdated bug reference (#32922)
         - move inspector testcase to the right place
         - add reference to bug closed on qt-4.7 (QTBUG-9618)

        * platform/qt/Skipped: cleanups only, no logical changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 17 Aug 2010 01:09:46 +0000 (01:09 +0000)]
2010-08-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        CSS: Add fast-path for rgba() color parsing
        https://bugs.webkit.org/show_bug.cgi?id=42965

        Test: fast/canvas/rgba-parsing.html

        * css/CSSParser.cpp:
        (WebCore::CSSParser::parseColor): Extended with support for rgba().
        (WebCore::parseAlphaValue): Added, parses an alpha value using
        WTF::strtod() (if necessary) and clamps between 0 and 1.
        (WebCore::isTenthAlpha):
2010-08-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        CSS: Add fast-path for rgba() color parsing
        https://bugs.webkit.org/show_bug.cgi?id=42965

        Add a test of rgba() color parsing.

        * fast/canvas/rgba-parsing-expected.txt: Added.
        * fast/canvas/rgba-parsing.html: Added.
        * fast/canvas/script-tests/rgba-parsing.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Kinuko Yasuda <kinuko@chromium.org>
kinuko@chromium.org [Tue, 17 Aug 2010 01:07:04 +0000 (01:07 +0000)]
2010-08-16  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Dumitru Daniliuc.

        Add idl and mock classes for FileSystem API's {File,Directory}Entry and related interfaces
        https://bugs.webkit.org/show_bug.cgi?id=43993

        Adding DirectoryEntry, DirectoryReader, EntriesCallback and FileEntry as defined in HTML5 FileSystem API.
        http://dev.w3.org/2009/dap/file-system/file-dir-sys.html

        Also adding Makefile entries for idl and mock classes added in changeset 64414 (except for Android platforms).

        Tests will be added when we add underlying implementation.

        * CMakeLists.txt:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * storage/DOMFileSystem.cpp:
        (WebCore::DOMFileSystem::root):
        * storage/DOMFileSystem.h:
        * storage/DOMFileSystem.idl:
        * storage/DirectoryEntry.cpp: Added.
        * storage/DirectoryEntry.h: Added.
        * storage/DirectoryEntry.idl: Added.
        * storage/DirectoryReader.cpp: Added.
        * storage/DirectoryReader.h: Added.
        * storage/DirectoryReader.idl: Added.
        * storage/EntriesCallback.h: Added.
        * storage/EntriesCallback.idl: Added.
        * storage/EntryArray.cpp: Added.
        * storage/EntryArray.h: Added.
        * storage/EntryArray.idl: Added.
        * storage/Entry.cpp:
        (WebCore::Entry::Entry):
        (WebCore::Entry::getMetadata):
        (WebCore::Entry::moveTo):
        (WebCore::Entry::copyTo):
        (WebCore::Entry::remove):
        (WebCore::Entry::getParent):
        * storage/Entry.h:
        (WebCore::Entry::isFile):
        (WebCore::Entry::isDirectory):
        * storage/Entry.idl:
        * storage/FileEntry.cpp: Added.
        * storage/FileEntry.h: Added.
        * storage/FileEntry.idl: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd WebKit2 Mac tester to buildbot.
weinig@apple.com [Tue, 17 Aug 2010 00:46:14 +0000 (00:46 +0000)]
Add WebKit2 Mac tester to buildbot.

Reviewed by Mark Rowe.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Andreas Kling <andreas.kling@nokia.com>
andreas.kling@nokia.com [Tue, 17 Aug 2010 00:41:17 +0000 (00:41 +0000)]
2010-08-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Path::closeSubpath() should only close the last subpath if it has >1 point
        https://bugs.webkit.org/show_bug.cgi?id=44061

        Spec link:
        http://www.whatwg.org/specs/web-apps/current-work/#dom-context-2d-closepath

        Test: fast/canvas/canvas-closePath-single-point.html

        * platform/graphics/Path.h: Add a Qt-only member to track the last subpath.
        * platform/graphics/qt/PathQt.cpp:
        (WebCore::Path::closeSubpath): Only close the last subpath if it
        has more than 1 point. Otherwise behave as moveTo(first point in last subpath)
        (WebCore::Path::Path):
        (WebCore::Path::operator=):
        (WebCore::Path::moveTo):
        (WebCore::Path::transform):
2010-08-16  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Ariya Hidayat.

        [Qt] Path::closeSubpath() should only close the last subpath if it has >1 point
        https://bugs.webkit.org/show_bug.cgi?id=44061

        Add a test to verify behavior of closePath() when path has only 1 point.

        * fast/canvas/canvas-closePath-single-point-expected.txt: Added.
        * fast/canvas/canvas-closePath-single-point.html: Added.
        * fast/canvas/script-tests/canvas-closePath-single-point.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 17 Aug 2010 00:20:55 +0000 (00:20 +0000)]
2010-08-16  Nate Chapin  <japhet@chromium.org>

        Unreviewed, build fix.

        Don't include TilingDataTest.cpp, since it doesn't
        compile on mac.

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 16 Aug 2010 23:57:18 +0000 (23:57 +0000)]
2010-08-16  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium expectations update.

        Mark 3 tests failing on Chromium Win/Linux after r65449.
        They appear to have same root cause as
        bugs.webkit.org/show_bug.cgi?id=43912.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 16 Aug 2010 23:37:12 +0000 (23:37 +0000)]
2010-08-16  Nate Chapin  <japhet@chromium.org>

        Unreviewed, Chromium mac build fix (with help from jamesr).

        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::ScrollbarThemeChromiumMac::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBug 44080 - String find/reverseFind methods need tidying up
barraclough@apple.com [Mon, 16 Aug 2010 23:31:33 +0000 (23:31 +0000)]
Bug 44080 - String find/reverseFind methods need tidying up
These methods have a couple of problems with their interface, and implementation.

Reviewed by Sam Weinig

These methods take and int index, and return an int - however this is problematic
since on 64-bit string indices may have a full 32-bit range.  This spills out into
surrounding code, which unsafely casts string indices from unsigned to int. Code
checking the result of these methods check for a mix of "== -1", "< 0", and
"== notFound".  Clean this up by changing these methods to take an unsigned
starting index, and return a size_t. with a failed match indicated by notFound.
reverseFind also has a special meaning for the starting index argument, in that a
negative index is interpreted as an offset back from the end of the string. Remove
this functionality, in the (1!) case where it is used we should just calculate the
offset by subtracting from the string's length.

The implementation has a few problems too.  The code is not in webkit style, in
using assorted abbreviations in variable names, and implementations of similar
find methods with differing argument types were unnecessarily inconsistent. When
find is passed const char* data the string would be handled as latin1 (zero
extended to UTF-16) for all characters but the first; this is sign extended.
Case-insensitive find is broken for unicode strings; the hashing optimization is
not unicode safe, and could result in false negatives.

Unify UString find methods to match String.

JavaScriptCore:

* JavaScriptCore.exp:
* bytecode/CodeBlock.cpp:
(JSC::escapeQuotes):
* bytecompiler/NodesCodegen.cpp:
(JSC::substitute):
* runtime/JSString.cpp:
(JSC::JSString::replaceCharacter):
* runtime/RegExp.cpp:
(JSC::RegExp::RegExp):
* runtime/RegExpKey.h:
(JSC::RegExpKey::getFlagsValue):
* runtime/StringPrototype.cpp:
(JSC::substituteBackreferencesSlow):
(JSC::substituteBackreferences):
(JSC::stringProtoFuncReplace):
(JSC::stringProtoFuncIndexOf):
(JSC::stringProtoFuncLastIndexOf):
(JSC::stringProtoFuncSplit):
* runtime/UString.cpp:
* runtime/UString.h:
(JSC::UString::find):
(JSC::UString::reverseFind):
* wtf/text/AtomicString.h:
(WTF::AtomicString::find):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::find):
(WTF::StringImpl::findCaseInsensitive):
(WTF::StringImpl::reverseFind):
(WTF::StringImpl::reverseFindCaseInsensitive):
(WTF::StringImpl::endsWith):
(WTF::StringImpl::replace):
* wtf/text/StringImpl.h:
(WTF::StringImpl::startsWith):
* wtf/text/WTFString.cpp:
(WTF::String::split):
* wtf/text/WTFString.h:
(WTF::String::find):
(WTF::String::reverseFind):
(WTF::String::findCaseInsensitive):
(WTF::String::reverseFindCaseInsensitive):
(WTF::String::contains):
(WTF::find):
(WTF::reverseFind):

WebCore:

* css/CSSSelector.cpp:
(WebCore::CSSSelector::RareData::parseNth):
* css/CSSStyleDeclaration.cpp:
(WebCore::CSSStyleDeclaration::setProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* dom/Document.cpp:
(WebCore::Document::getImageMap):
* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::inputText):
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::input):
* editing/TextIterator.cpp:
(WebCore::TextIterator::handleTextBox):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::insertText):
* editing/markup.cpp:
(WebCore::fillContainerFromString):
(WebCore::createFragmentFromText):
* html/File.cpp:
(WebCore::File::Init):
* html/HTMLAnchorElement.cpp:
(WebCore::HTMLAnchorElement::setHost):
* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::parseMappedAttribute):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::isPlaceholderEmpty):
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::performSearch):
* loader/CrossOriginPreflightResultCache.cpp:
(WebCore::parseAccessControlAllowList):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::substituteMIMETypeFromPluginDatabase):
* loader/appcache/ApplicationCacheStorage.cpp:
(WebCore::parseHeader):
(WebCore::parseHeaders):
* loader/icon/IconFetcher.cpp:
(WebCore::parseIconLink):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::parseModalDialogFeatures):
* page/SecurityOrigin.cpp:
(WebCore::SecurityOrigin::createFromDatabaseIdentifier):
* page/UserContentURLPattern.cpp:
(WebCore::UserContentURLPattern::parse):
* page/XSSAuditor.cpp:
(WebCore::XSSAuditor::findInRequest):
* platform/ContentType.cpp:
(WebCore::ContentType::parameter):
(WebCore::ContentType::type):
* platform/KURL.cpp:
(WebCore::KURL::lastPathComponent):
(WebCore::KURL::setProtocol):
(WebCore::decodeURLEscapeSequences):
(WebCore::substituteBackslashes):
(WebCore::mimeTypeFromDataURL):
* platform/Length.cpp:
(WebCore::newCoordsArray):
(WebCore::newLengthArray):
* platform/LinkHash.cpp:
(WebCore::findSlashDotDotSlash):
(WebCore::findSlashSlash):
(WebCore::findSlashDotSlash):
(WebCore::cleanPath):
* platform/MIMETypeRegistry.cpp:
(WebCore::MIMETypeRegistry::getMIMETypeForPath):
* platform/SchemeRegistry.cpp:
(WebCore::SchemeRegistry::shouldTreatURLAsLocal):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::load):
* platform/mac/DragImageMac.mm:
(WebCore::createDragImageIconForCachedImage):
* platform/network/CredentialStorage.cpp:
(WebCore::protectionSpaceMapKeyFromURL):
(WebCore::findDefaultProtectionSpaceForURL):
* platform/network/HTTPParsers.cpp:
(WebCore::skipWhiteSpace):
(WebCore::skipToken):
(WebCore::parseHTTPRefresh):
(WebCore::filenameFromHTTPContentDisposition):
(WebCore::findCharsetInMediaType):
(WebCore::parseXSSProtectionHeader):
(WebCore::extractReasonPhraseFromHTTPStatusLine):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::isAttachment):
(WebCore::parseCacheHeader):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::updateWidget):
* storage/Entry.cpp:
(WebCore::Entry::Entry):
* svg/SVGFont.cpp:
(WebCore::isCompatibleGlyph):
* svg/SVGURIReference.cpp:
(WebCore::SVGURIReference::getTarget):
* svg/animation/SVGSMILElement.cpp:
(WebCore::SVGSMILElement::parseClockValue):
(WebCore::SVGSMILElement::parseCondition):
* xml/XPathFunctions.cpp:
(WebCore::XPath::FunSubstringBefore::evaluate):
(WebCore::XPath::FunSubstringAfter::evaluate):
(WebCore::XPath::FunTranslate::evaluate):
(WebCore::XPath::FunLang::evaluate):
* xml/XPathParser.cpp:
(WebCore::XPath::Parser::expandQName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 16 Aug 2010 23:23:10 +0000 (23:23 +0000)]
2010-08-16  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium
        https://bugs.webkit.org/show_bug.cgi?id=44070

        The crash was caused by start or end node being removed in pushDownInlineStyleAroundNode.
        It made start and end orphaned, and caused s.node() to be detached from the document.
        Fixed the crash by using nodes passed to pushDownInlineStyleAroundNode for start and end if the original
        start and end are orphaned because pushDownInlineStyleAroundNode won't prune targetNode.

        Test: editing/pasteboard/smart-paste-003-trailing-whitespace.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::removeInlineStyle):
2010-08-16  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        REGRESSION(r65208): editing/pasteboard/smart-paste-003.html and smart-paste-004.html crash on Windows Chromium
        https://bugs.webkit.org/show_bug.cgi?id=44070

        The bug only reproduced on Windows when trailing space is selected only on Windows.
        Added a crash test to copy & paste a word with trailing space.

        * editing/pasteboard/smart-paste-003-trailing-whitespace-expected.txt: Added.
        * editing/pasteboard/smart-paste-003-trailing-whitespace.html: Added.
        * platform/chromium/test_expectations.txt: editing/pasteboard/smart-paste-003.html and smart-paste-004.html should not crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix windows build.
weinig@apple.com [Mon, 16 Aug 2010 23:06:55 +0000 (23:06 +0000)]
Fix windows build.

* Shared/win/CommandLineWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove #includes of <WebCore/PlatformString.h> in favor of <wtf/text/WTFString.h>
weinig@apple.com [Mon, 16 Aug 2010 23:00:34 +0000 (23:00 +0000)]
Remove #includes of <WebCore/PlatformString.h> in favor of <wtf/text/WTFString.h>

Reviewed by Gavin Barraclough.

* Platform/Module.cpp:
* Platform/Module.h:
* Shared/CommandLine.h:
* Shared/WebCoreArgumentCoders.h:
* Shared/WebEvent.h:
* Shared/WebNavigationDataStore.h:
* Shared/WebPreferencesStore.h:
* Shared/WebString.h:
* Shared/WebURL.h:
* Shared/mac/CommandLineMac.cpp:
* Shared/qt/UpdateChunk.cpp:
* UIProcess/API/C/WKContext.cpp:
* UIProcess/API/C/cf/WKStringCF.cpp:
* UIProcess/API/C/cf/WKURLCF.cpp:
* UIProcess/API/cpp/qt/WKStringQt.cpp:
* UIProcess/API/cpp/qt/WKURLQt.cpp:
* UIProcess/API/mac/PageClientImpl.mm:
* UIProcess/API/qt/qgraphicswkview.cpp:
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
* UIProcess/Launcher/win/ProcessLauncherWin.cpp:
* UIProcess/WebBackForwardListItem.cpp:
* UIProcess/WebBackForwardListItem.h:
* UIProcess/WebContext.h:
* UIProcess/WebContextInjectedBundleClient.cpp:
* UIProcess/WebFrameProxy.cpp:
* UIProcess/WebFrameProxy.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPolicyClient.cpp:
* UIProcess/WebProcessProxy.cpp:
* UIProcess/WebUIClient.cpp:
* UIProcess/win/WebView.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
* WebProcess/InjectedBundle/InjectedBundle.h:
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
* WebProcess/InjectedBundle/mac/InjectedBundleMac.cpp:
* WebProcess/Plugins/JSNPObject.cpp:
* WebProcess/Plugins/NPJSObject.cpp:
* WebProcess/Plugins/Netscape/NetscapePluginModule.cpp:
* WebProcess/Plugins/Netscape/NetscapePluginModule.h:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebKitMain.cpp:
* WebProcess/win/WebProcessMainWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Mon, 16 Aug 2010 22:54:18 +0000 (22:54 +0000)]
2010-08-16  Nate Chapin  <japhet@chromium.org>

        Chromium win rebaseline + test expectations tweaks.

        * platform/chromium-win/svg/custom/absolute-sized-content-with-resources-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofix build
jamesr@google.com [Mon, 16 Aug 2010 22:48:20 +0000 (22:48 +0000)]
fix build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium/Qt bustage.
hyatt@apple.com [Mon, 16 Aug 2010 22:35:36 +0000 (22:35 +0000)]
Fix Chromium/Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium Bustage.
hyatt@apple.com [Mon, 16 Aug 2010 22:32:18 +0000 (22:32 +0000)]
Fix Chromium Bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Chromium Bustage.
hyatt@apple.com [Mon, 16 Aug 2010 22:30:20 +0000 (22:30 +0000)]
Fix Chromium Bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNull CFURLRef returned from provisionalURL after searching on zillow.com
weinig@apple.com [Mon, 16 Aug 2010 22:22:36 +0000 (22:22 +0000)]
Null CFURLRef returned from provisionalURL after searching on zillow.com
<rdar://problem/8261812>
https://bugs.webkit.org/show_bug.cgi?id=44072

Reviewed by Gavin Barraclough.

Conversion from WKURLRef to CFRURLRef was breaking on URLs using characters
such as '{'.

* UIProcess/API/C/cf/WKURLCF.cpp:
(WKURLCopyCFURL): Use code similar to that found in KURLCFNet.cpp for conversion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt bustage.
hyatt@apple.com [Mon, 16 Aug 2010 21:48:55 +0000 (21:48 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove unnecessary copy constructor, assignment operator and swap function.
weinig@apple.com [Mon, 16 Aug 2010 21:43:19 +0000 (21:43 +0000)]
Remove unnecessary copy constructor, assignment operator and swap function.
The defaults (for all except swap) should do just fine.

Reviewed by Gavin Barraclough.

* Shared/WebPreferencesStore.cpp:
* Shared/WebPreferencesStore.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt build bustage.
hyatt@apple.com [Mon, 16 Aug 2010 21:37:07 +0000 (21:37 +0000)]
Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Vincent Scheib <scheib@chromium.org>
commit-queue@webkit.org [Mon, 16 Aug 2010 21:36:52 +0000 (21:36 +0000)]
2010-08-16  Vincent Scheib  <scheib@chromium.org>

        Reviewed by Dimitri Glazkov.

        Canvas2D does not support images larger than system's GPU max texture size
        https://bugs.webkit.org/show_bug.cgi?id=43864

        A new class "TilingData" has been created that provides logic for
        splitting a large image into a series of smaller tiles.

        GLES2Texture and CLES2Canvas are modified to use the TilingData to
        split images on texture upload and render one logical image as many smaller
        images.

        TilingData is tested via unit tests in WebKit/chromium/tests/TilingDataTest.cpp

        * WebCore.gypi:
        * platform/graphics/chromium/GLES2Canvas.cpp:
        (WebCore::GLES2Canvas::drawTexturedRect):
        (WebCore::GLES2Canvas::drawTexturedRectTile):
        * platform/graphics/chromium/GLES2Canvas.h:
        * platform/graphics/chromium/GLES2Texture.cpp:
        (WebCore::GLES2Texture::GLES2Texture):
        (WebCore::GLES2Texture::~GLES2Texture):
        (WebCore::GLES2Texture::create):
        (WebCore::copySubRect):
        (WebCore::GLES2Texture::load):
        (WebCore::GLES2Texture::bindTile):
        * platform/graphics/chromium/GLES2Texture.h:
        (WebCore::GLES2Texture::tiles):
        * platform/graphics/chromium/TilingData.cpp: Added.
        (WebCore::computeNumTiles):
        (WebCore::TilingData::TilingData):
        (WebCore::TilingData::tileXIndexFromSrcCoord):
        (WebCore::TilingData::tileYIndexFromSrcCoord):
        (WebCore::TilingData::tileBounds):
        (WebCore::TilingData::tileBoundsWithBorder):
        (WebCore::TilingData::tileBoundsNormalized):
        (WebCore::TilingData::tilePositionX):
        (WebCore::TilingData::tilePositionY):
        (WebCore::TilingData::tileSizeX):
        (WebCore::TilingData::tileSizeY):
        (WebCore::TilingData::overlappedTileIndices):
        (WebCore::TilingData::intersectDrawQuad):
        * platform/graphics/chromium/TilingData.h: Added.
        (WebCore::TilingData::maxTextureSize):
        (WebCore::TilingData::totalSizeX):
        (WebCore::TilingData::totalSizeY):
        (WebCore::TilingData::numTiles):
        (WebCore::TilingData::numTilesX):
        (WebCore::TilingData::numTilesY):
        (WebCore::TilingData::tileIndex):
        (WebCore::TilingData::tileXIndex):
        (WebCore::TilingData::tileYIndex):
        (WebCore::TilingData::TilingData):
        (WebCore::TilingData::assertTile):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::BitmapImage::draw):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::uploadSoftwareToHardware):
2010-08-16  Vincent Scheib  <scheib@chromium.org>

        Reviewed by Dimitri Glazkov.

        Canvas2D does not support images larger than system's GPU max texture size
        https://bugs.webkit.org/show_bug.cgi?id=43864

        Unit tests for TilingData class.

        * WebKit.gyp:
        * tests/TilingDataTest.cpp: Added.
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix GTK build bustage.
hyatt@apple.com [Mon, 16 Aug 2010 21:34:22 +0000 (21:34 +0000)]
Fix GTK build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix GTK build bustage.
hyatt@apple.com [Mon, 16 Aug 2010 21:31:16 +0000 (21:31 +0000)]
Fix GTK build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix Qt build bustage.
hyatt@apple.com [Mon, 16 Aug 2010 21:28:06 +0000 (21:28 +0000)]
Fix Qt build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix GTK build bustage.
hyatt@apple.com [Mon, 16 Aug 2010 21:26:28 +0000 (21:26 +0000)]
Fix GTK build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPut ANGLE include inside PLATFORM(MAC) to fix Chrome and Qt builds
cmarrin@apple.com [Mon, 16 Aug 2010 21:21:18 +0000 (21:21 +0000)]
Put ANGLE include inside PLATFORM(MAC) to fix Chrome and Qt builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=43507, stop ImageBuffer from copying its...
hyatt@apple.com [Mon, 16 Aug 2010 20:44:01 +0000 (20:44 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=43507, stop ImageBuffer from copying its data when rendering after canvas changes happen.

Reviewed by Anders Carlsson.

This patch renames ImageBuffer::image() to ImageBuffer::copyImage(). The new method always returns a new copy that is a current
snapshot of the ImageBuffer.

To draw an ImageBuffer, you now use new GraphicsContext calls: drawImageBuffer.  Platforms can then optimize these calls to draw
efficiently without having to copy the bits of the ImageBuffer into an Image.

* WebCore.xcodeproj/project.pbxproj:
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::image):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::willDraw):
(WebCore::HTMLCanvasElement::reset):
(WebCore::HTMLCanvasElement::paint):
(WebCore::HTMLCanvasElement::setSurfaceSize):
(WebCore::HTMLCanvasElement::copiedImage):
(WebCore::HTMLCanvasElement::clearCopiedImage):
* html/HTMLCanvasElement.h:
* html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::CanvasPattern):
* html/canvas/CanvasPattern.h:
(WebCore::CanvasPattern::create):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::drawImage):
(WebCore::CanvasRenderingContext2D::createPattern):
(WebCore::CanvasRenderingContext2D::drawTextInternal):
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
(WebCore::WebGLRenderingContext::reshape):
(WebCore::WebGLRenderingContext::texImage2D):
(WebCore::WebGLRenderingContext::texSubImage2D):
* html/canvas/WebGLRenderingContext.h:
(WebCore::WebGLRenderingContext::paintsIntoCanvasBuffer):
* platform/graphics/GeneratedImage.cpp:
(WebCore::GeneratedImage::drawPattern):
* platform/graphics/GraphicsContext.cpp:
(WebCore::GraphicsContext::drawImageBuffer):
(WebCore::GraphicsContext::clipToImageBuffer):
* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContext3D.h:
(WebCore::GraphicsContext3D::paintsIntoCanvasBuffer):
* platform/graphics/Image.h:
* platform/graphics/ImageBuffer.h:
(WebCore::ImageBuffer::width):
(WebCore::ImageBuffer::height):
* platform/graphics/Pattern.cpp:
(WebCore::Pattern::Pattern):
* platform/graphics/Pattern.h:
(WebCore::Pattern::create):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
* platform/graphics/cg/GraphicsContextCG.cpp:
* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::clip):
* platform/graphics/cg/ImageBufferData.h:
* platform/graphics/filters/FEColorMatrix.cpp:
(WebCore::FEColorMatrix::apply):
* platform/graphics/filters/FEComposite.cpp:
(WebCore::FEComposite::apply):
* platform/graphics/filters/SourceAlpha.cpp:
(WebCore::SourceAlpha::apply):
* platform/graphics/filters/SourceGraphic.cpp:
(WebCore::SourceGraphic::apply):
* platform/graphics/mac/GraphicsContext3DMac.mm:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
* platform/graphics/qt/GraphicsContextQt.cpp:
* platform/graphics/qt/ImageBufferData.h:
* platform/graphics/qt/ImageBufferQt.cpp:
(WebCore::ImageBufferData::ImageBufferData):
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
(WebCore::ImageBuffer::clip):
* platform/graphics/skia/GraphicsContextSkia.cpp:
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::):
* platform/graphics/wx/GraphicsContextWx.cpp:
* platform/graphics/wx/ImageBufferWx.cpp:
(WebCore::ImageBuffer::drawsUsingCopy):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarThemeMac::paint):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
* rendering/RenderSVGResourceClipper.cpp:
(WebCore::RenderSVGResourceClipper::applyClippingToContext):
* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):
* rendering/RenderSVGResourceGradient.cpp:
(WebCore::clipToTextMask):
* rendering/RenderSVGResourceMasker.cpp:
(WebCore::RenderSVGResourceMasker::applyResource):
* rendering/RenderSVGResourcePattern.cpp:
(WebCore::RenderSVGResourcePattern::buildPattern):
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintProgressBar):
* svg/SVGFEImageElement.cpp:
(WebCore::SVGFEImageElement::build):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::nativeImageForCurrentFrame):
* svg/graphics/SVGImage.h:
* svg/graphics/filters/SVGFEMerge.cpp:
(WebCore::FEMerge::apply):
* svg/graphics/filters/SVGFEOffset.cpp:
(WebCore::FEOffset::apply):
* svg/graphics/filters/SVGFETile.cpp:
(WebCore::FETile::apply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFixed a warning in ANGLEWebKitBridge.cpp
cmarrin@apple.com [Mon, 16 Aug 2010 20:19:06 +0000 (20:19 +0000)]
Fixed a warning in ANGLEWebKitBridge.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild ANGLE for all versions of Mac to fix Leopard build
cmarrin@apple.com [Mon, 16 Aug 2010 20:15:14 +0000 (20:15 +0000)]
Build ANGLE for all versions of Mac to fix Leopard build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Paul Sawaya <psawaya@apple.com>
cmarrin@apple.com [Mon, 16 Aug 2010 19:18:45 +0000 (19:18 +0000)]
2010-08-16  Paul Sawaya  <psawaya@apple.com>

        Reviewed by Chris Marrin.

        Added shader validation via ANGLE
        https://bugs.webkit.org/show_bug.cgi?id=42405

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, do not build WebCore as a convenience library as this leads to
kevino@webkit.org [Mon, 16 Aug 2010 19:12:19 +0000 (19:12 +0000)]
[wx] Build fix, do not build WebCore as a convenience library as this leads to
errors in the Win build w/export symbols and causes problems with DOM bindings
debugging in gdb.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Mon, 16 Aug 2010 19:00:33 +0000 (19:00 +0000)]
2010-08-16  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Nate Chapin.

        Some http/tests/history tests now pass on Chromium after r65340
        https://bugs.webkit.org/show_bug.cgi?id=44033

        Remove expected failures.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Mon, 16 Aug 2010 18:24:17 +0000 (18:24 +0000)]
2010-08-16  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Adam Roben.

        Current implementation of WebCore post-build step on windows platform is error prone.
        It would be better to extract the script into external file.
        https://bugs.webkit.org/show_bug.cgi?id=44058

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/copyForwardingHeaders.cmd: Added.
        * WebCore.vcproj/copyInspectorFiles.cmd: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Fix typo in previous build fix.
kevino@webkit.org [Mon, 16 Aug 2010 18:09:06 +0000 (18:09 +0000)]
[wx] Fix typo in previous build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Alex Milowski <alex@milowski.com>
commit-queue@webkit.org [Mon, 16 Aug 2010 18:04:40 +0000 (18:04 +0000)]
2010-08-16  Alex Milowski  <alex@milowski.com>

        Reviewed by David Levin.

        Added the configuration of the MathML related files.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
2010-08-16  Alex Milowski  <alex@milowski.com>

        Reviewed by David Levin.

        Added the ENABLE_MATHML=1 to the feature_defines.

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 Aug 2010 17:39:48 +0000 (17:39 +0000)]
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: fix Leopard Release inspector tests.

        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 16 Aug 2010 17:30:58 +0000 (17:30 +0000)]
2010-08-16  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Implements IDBKeyPath extractor.
        https://bugs.webkit.org/show_bug.cgi?id=43276

        Unit-test IDBKeyPathExtractorTest.cpp.
        LayoutTests will arrive as IndexedDB infrastructure is fleshed out.

        * bindings/v8/IDBBindingUtilities.cpp:
        (WebCore::getValueFrom):
        (WebCore::createIDBKeyFromSerializedValueAndKeyPath):
        * bindings/v8/IDBBindingUtilities.h:
2010-08-16  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Jeremy Orlow.

        Implements IDBKeyPath extractor.
        https://bugs.webkit.org/show_bug.cgi?id=43276

        Unit-test IDBKeyPathExtractorTest.cpp.
        LayoutTests will arrive as IndexedDB infrastructure is fleshed out.

        * WebKit.gyp:
        * public/WebIDBKey.h:
        * public/WebIDBKeyPath.h: Added.
        (WebKit::WebIDBKeyPath::WebIDBKeyPath):
        (WebKit::WebIDBKeyPath::~WebIDBKeyPath):
        * public/WebPrivateOwnPtr.h: Added.
        (WebKit::WebPrivateOwnPtr::WebPrivateOwnPtr):
        (WebKit::WebPrivateOwnPtr::~WebPrivateOwnPtr):
        (WebKit::WebPrivateOwnPtr::reset):
        (WebKit::WebPrivateOwnPtr::get):
        (WebKit::WebPrivateOwnPtr::operator->):
        * src/WebIDBKey.cpp:
        (WebKit::WebIDBKey::createFromValueAndKeyPath):
        * src/WebIDBKeyPath.cpp: Added.
        (WebKit::WebIDBKeyPath::create):
        (WebKit::WebIDBKeyPath::WebIDBKeyPath):
        (WebKit::WebIDBKeyPath::parseError):
        (WebKit::WebIDBKeyPath::assign):
        (WebKit::WebIDBKeyPath::reset):
        (WebKit::WebIDBKeyPath::operator const WTF::Vector<WebCore::IDBKeyPathElement, 0>&):
        * tests/IDBBindingUtilitiesTest.cpp: Added.
        (WebCore::LocalContext::LocalContext):
        (WebCore::LocalContext::~LocalContext):
        (WebCore::checkKeyFromValueAndKeyPathInternal):
        (WebCore::checkKeyPathNullValue):
        (WebCore::checkKeyPathStringValue):
        (WebCore::checkKeyPathNumberValue):
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Mon, 16 Aug 2010 17:10:38 +0000 (17:10 +0000)]
2010-08-13  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Reviewed by Kenneth Rohde Christiansen and Martin Robinson.

        [GTK] GTK+ drawing idle starved
        https://bugs.webkit.org/show_bug.cgi?id=43994

        Tune down the priority of the shared timers to guarantee GTK+ has
        an opportunity to redraw.

        * platform/gtk/SharedTimerGtk.cpp:
        (WebCore::setSharedTimerFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Mon, 16 Aug 2010 16:44:46 +0000 (16:44 +0000)]
2010-08-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix after r65366.

        * CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if
        they're empty.
        * jsc/CMakeLists.txt: Ditto.
        * wtf/CMakeLists.txt: Ditto.
2010-08-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix after r65366.

        * CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if
        they're empty.
2010-08-16  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Build fix after r65366.

        EFL port does not support automated tests yet.

        * CMakeLists.txt: Use if (VAR) instead of if (${VAR}) to check if
        they're empty.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix.
steveblock@google.com [Mon, 16 Aug 2010 16:40:36 +0000 (16:40 +0000)]
Unreviewed build fix.

Add fast/dom/Geolocation/disconnected-frame-permission-denied.html to failing tests for Chromium
https://bugs.webkit.org/show_bug.cgi?id=44059

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix.
mitz@apple.com [Mon, 16 Aug 2010 16:35:55 +0000 (16:35 +0000)]
Build fix.

* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage): Initialize the contentsSizeChanged member.
(WTR::TestController::initialize): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 Aug 2010 16:33:36 +0000 (16:33 +0000)]
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Make InjectedScript proto-based.
        https://bugs.webkit.org/show_bug.cgi?id=44028

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):

2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Make InjectedScript proto-based.
        https://bugs.webkit.org/show_bug.cgi?id=44028
        Drive-by test fix.

        * http/tests/inspector-enabled/console-log-before-frame-navigation.html:
        * http/tests/inspector-enabled/resources/console-log-before-frame-navigation.js: Removed.
        * http/tests/inspector-enabled/resources/console-log-frame-before-navigation.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agowxMSW build fix. Don't build the Python DOM bindings until we get the export issues
kevino@webkit.org [Mon, 16 Aug 2010 16:31:03 +0000 (16:31 +0000)]
wxMSW build fix. Don't build the Python DOM bindings until we get the export issues
sorted out.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix warning in WebCore/plugins/win/PluginPackageWin.cpp
ossy@webkit.org [Mon, 16 Aug 2010 16:29:59 +0000 (16:29 +0000)]
Fix warning in WebCore/plugins/win/PluginPackageWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=43920

Reviewed by Adam Roben.

* plugins/win/PluginPackageWin.cpp:
(WebCore::PluginPackage::fetchInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed.
ossy@webkit.org [Mon, 16 Aug 2010 16:19:54 +0000 (16:19 +0000)]
Unreviewed.

[Qt] fast/dom/Geolocation/disconnected-frame-permission-denied.html fails
https://bugs.webkit.org/show_bug.cgi?id=44059

* platform/qt/Skipped: fast/dom/Geolocation/disconnected-frame-permission-denied.html skipped until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 16 Aug 2010 16:15:02 +0000 (16:15 +0000)]
2010-08-16  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Touch inspector file to force frontend deployment.

        * inspector/InspectorController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix for non-Win ports on Windows.
kevino@webkit.org [Mon, 16 Aug 2010 16:06:10 +0000 (16:06 +0000)]
[wx] Build fix for non-Win ports on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Adam Langley <agl@chromium.org>
agl@chromium.org [Mon, 16 Aug 2010 15:16:46 +0000 (15:16 +0000)]
2010-08-16  Adam Langley  <agl@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Improve spacing support for complex text on Linux

        https://bugs.webkit.org/show_bug.cgi?id=39014

        Previously, our complex text support ignored word-spacing,
        justification and letter-spacing. This fixes the first two issues and
        allows us to render Scribd's HTML5 documents much better.

        Test: fast/text/atsui-spacing-features.html

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::TextRunWalker):
        (WebCore::TextRunWalker::setWordSpacingAdjustment):
        (WebCore::TextRunWalker::setLetterSpacingAdjustment):
        (WebCore::TextRunWalker::setPadding):
        (WebCore::TextRunWalker::setGlyphXPositions):
        (WebCore::TextRunWalker::isCodepointSpace):
        (WebCore::Font::drawComplexText):
        (WebCore::Font::floatWidthForComplexText):
        (WebCore::Font::offsetForPositionForComplexText):
        (WebCore::Font::selectionRectForComplexText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix warnings: unknown conversion type character 'l' in format
ossy@webkit.org [Mon, 16 Aug 2010 15:14:14 +0000 (15:14 +0000)]
Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359

Reviewed by Kenneth Rohde Christiansen.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::performURLImport): Replace %zu with %lu, because Windows doesn't understand z modifier.
(WebCore::IconDatabase::pruneUnretainedIcons): Use %I64i intsead of %lli on Windows.
* platform/graphics/qt/MediaPlayerPrivatePhonon.cpp:
(WebCore::MediaPlayerPrivate::totalTimeChanged): Use %I64d intsead of %lld on Windows.
* platform/sql/SQLiteDatabase.cpp:
(WebCore::SQLiteDatabase::setMaximumSize): Use %I64i intsead of %lli on Windows.
* storage/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::setQuota): Use %I64u intsead of %llu on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix warnings: unknown conversion type character 'l' in format
ossy@webkit.org [Mon, 16 Aug 2010 15:02:45 +0000 (15:02 +0000)]
Fix warnings: unknown conversion type character 'l' in format
https://bugs.webkit.org/show_bug.cgi?id=43359

Reviewed by Kenneth Rohde Christiansen.

* loader/FTPDirectoryParser.cpp: Use %I64u format specifier instead of %llu on Windows.
(WebCore::parseOneFTPLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Shadow blur for rectangle fill
ariya@webkit.org [Mon, 16 Aug 2010 14:32:25 +0000 (14:32 +0000)]
[Qt] Shadow blur for rectangle fill
https://bugs.webkit.org/show_bug.cgi?id=44025

Patch by Ariya Hidayat <ariya@sencha.com> on 2010-08-16
Reviewed by Kenneth Rohde Christiansen.

WebCore:

The blur implementation follows the approximation of Gaussian blur
with three successive box blurs, working on the alpha channel only.
(see http://www.w3.org/TR/SVG/filters.html#feGaussianBlur).

* WebCore.pro: Refer to ContexShadow.* files.
* platform/graphics/qt/ContextShadow.cpp: Added.
(WebCore::ContextShadow::ContextShadow):
(WebCore::ContextShadow::clear):
(WebCore::blurHorizontal): Box blurs in horizontal direction, working
on QImage (in-place).
(WebCore::shadowBlur): Main blur function which just calls the
above blurHorizontal function twice, once with transposed image
(equivalent as it would have done vertical box blurs).
(WebCore::ContextShadow::drawShadowRect):
* platform/graphics/qt/ContextShadow.h: Added.
(WebCore::ContextShadow::):
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContextPlatformPrivate::hasShadow):
(WebCore::GraphicsContext::restorePlatformState):
(WebCore::GraphicsContext::fillRect): Use ContextShadow for the shadow.
(WebCore::GraphicsContext::setPlatformShadow):

LayoutTests:

Update pixel test reference after the blur support.

* platform/qt/fast/box-shadow/basic-shadows-expected.checksum:
* platform/qt/fast/box-shadow/basic-shadows-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Mon, 16 Aug 2010 14:09:36 +0000 (14:09 +0000)]
2010-08-16  Andras Becsi  <abecsi@webkit.org>

        Rubber-stamped by Gustavo Noronha Silva.

        [GTK] Build fix for MathML code generation.

        No new tests needed.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 16 Aug 2010 13:58:16 +0000 (13:58 +0000)]
2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65414.
        http://trac.webkit.org/changeset/65414
        https://bugs.webkit.org/show_bug.cgi?id=44055

        GTL & QT tests failing. (Requested by pfeldman on #webkit).

        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        (injectedScriptConstructor.):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Mon, 16 Aug 2010 13:39:56 +0000 (13:39 +0000)]
2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        Handle content size change in WebKit2
        Re-landing after fix.

        https://bugs.webkit.org/show_bug.cgi?id=43198

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        Handle content size change in WebKit2
        Re-landing after fix.

        https://bugs.webkit.org/show_bug.cgi?id=43198

        Based on the work of Antti Koivisto.
        Send message to the UI client when the contents size has changed through the WebChromeClient
        and propagate it to the WKPageUIClient.

        * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
        (WebPageProxyMessage::): Added ContentsSizeChanged message kind.
        * UIProcess/API/C/WKPage.h: Added WKPageContentsSizeChangedCallback callback to the WKPageUIClient.
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage): Initialize the new callback to 0.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage): Handle ContentsSizeChanged message. Calls contetsSizeChanged.
        (WebKit::WebPageProxy::contentsSizeChanged): Added. Propagate the event to the the UI client.
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::contentsSizeChanged): Added. Propagate the event forward to the WKPageUIClient.
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::contentsSizeChanged): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 16 Aug 2010 13:28:06 +0000 (13:28 +0000)]
2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65419.
        http://trac.webkit.org/changeset/65419
        https://bugs.webkit.org/show_bug.cgi?id=44053

        Broke the Windows build (Requested by bbandix on #webkit).

        * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
        (WebPageProxyMessage::):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebUIClient.cpp:
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::contentsSizeChanged):
2010-08-16  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r65419.
        http://trac.webkit.org/changeset/65419
        https://bugs.webkit.org/show_bug.cgi?id=44053

        Broke the Windows build (Requested by bbandix on #webkit).

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]):
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Ariya Hidayat <ariya@sencha.com>
ariya@webkit.org [Mon, 16 Aug 2010 12:58:48 +0000 (12:58 +0000)]
2010-08-16  Ariya Hidayat  <ariya@sencha.com>

        Reviewed by Antonio Gomes.

        [Qt] Save and restore shadow state in GraphicsContextQt
        https://bugs.webkit.org/show_bug.cgi?id=44031

        This is needed after r65362.
        Use a new class ContextShadowParameter to track and keep the shadow
        state. We use this rather than using GraphicsContextState to allow
        possible optimizations (right now only to determine the shadow type,
        but in future it might cover things like cached scratch image,
        persistent shader, etc).

        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::ContextShadowParameter::):
        (WebCore::ContextShadowParameter::ContextShadowParameter):
        (WebCore::ContextShadowParameter::clear):
        (WebCore::GraphicsContextPlatformPrivate::hasShadow):
        (WebCore::GraphicsContextPlatformPrivate::GraphicsContextPlatformPrivate):
        (WebCore::GraphicsContext::savePlatformState):
        (WebCore::GraphicsContext::restorePlatformState):
        (WebCore::GraphicsContext::drawRect):
        (WebCore::GraphicsContext::drawLine):
        (WebCore::GraphicsContext::strokeArc):
        (WebCore::GraphicsContext::drawConvexPolygon):
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::strokePath):
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::setPlatformShadow):
        (WebCore::GraphicsContext::clearPlatformShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-16 Balazs Kelemen <kb@inf.u-szeged.hu>
abecsi@webkit.org [Mon, 16 Aug 2010 12:52:20 +0000 (12:52 +0000)]
2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        Handle content size change in WebKit2

        https://bugs.webkit.org/show_bug.cgi?id=43198

        * MiniBrowser/mac/BrowserWindowController.m:
        (-[BrowserWindowController awakeFromNib]): Initialize WKPageUICallback::contetsSizeChanged to 0.
        * MiniBrowser/win/BrowserView.cpp:
        (BrowserView::create): Initialize WKPageUICallback::contetsSizeChanged to 0.
2010-08-16  Balazs Kelemen  <kb@inf.u-szeged.hu>

        Reviewed by Kenneth Rohde Christiansen.

        Handle content size change in WebKit2

        https://bugs.webkit.org/show_bug.cgi?id=43198

        Based on the work of Antti Koivisto.
        Send message to the UI client when the contents size has changed through the WebChromeClient
        and propagate it to the WKPageUIClient.

        * Shared/CoreIPCSupport/WebPageProxyMessageKinds.h:
        (WebPageProxyMessage::): Added ContentsSizeChanged message kind.
        * UIProcess/API/C/WKPage.h: Added WKPageContentsSizeChangedCallback callback to the WKPageUIClient.
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage): Initialize the new callback to 0.
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::didReceiveMessage): Handle ContentsSizeChanged message. Calls contetsSizeChanged.
        (WebKit::WebPageProxy::contentsSizeChanged): Added. Propagate the event to the the UI client.
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::contentsSizeChanged): Added. Propagate the event forward to the WKPageUIClient.
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::contentsSizeChanged): Implemented.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd my new email address to committers.py.
ariya@webkit.org [Mon, 16 Aug 2010 12:44:58 +0000 (12:44 +0000)]
Add my new email address to committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-07-28 Marcus Bulach <bulach@chromium.org>
bulach@chromium.org [Mon, 16 Aug 2010 12:43:54 +0000 (12:43 +0000)]
2010-07-28  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Adam Barth.

        Implement IDBKeyPath parser.
        https://bugs.webkit.org/show_bug.cgi?id=42976

        IDBKeyPath is an internal class, exposed only for unit tests for now.
        It'll allow indexed database implementation to traverse a given key path and obtain the corresponding properties
        from a SerializedScriptValue.

        * WebCore.gypi:
        * storage/IDBKeyPath.cpp: Added.
        (WebCore::IDBKeyPath::create):
        (WebCore::IDBKeyPath::IDBKeyPath):
        (WebCore::IDBKeyPath::~IDBKeyPath):
        (WebCore::IDBKeyPath::hasNext):
        (WebCore::IDBKeyPath::next):
        (WebCore::IDBKeyPath::identifier):
        (WebCore::IDBKeyPath::hasIndex):
        (WebCore::IDBKeyPath::indexValue):
        (WebCore::IDBKeyPath::parserError):
        (WebCore::IDBKeyPath::parse):
        (WebCore::IDBKeyPath::Lexer::lex):
        (WebCore::isSafeIdentifierStartCharacter):
        (WebCore::isSafeIdentifierCharacter):
        (WebCore::IDBKeyPath::Lexer::lexIdentifier):
        (WebCore::IDBKeyPath::Lexer::lexNumber):
        * storage/IDBKeyPath.h: Added.
        (WebCore::IDBKeyPath::Token::Token):
        (WebCore::IDBKeyPath::):
        (WebCore::IDBKeyPath::Lexer::Lexer):
        (WebCore::IDBKeyPath::Lexer::next):
        (WebCore::IDBKeyPath::Lexer::currentToken):
2010-07-28  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Adam Barth.

        Implement IDBKeyPath parser.
        https://bugs.webkit.org/show_bug.cgi?id=42976

        IDBKeyPath is an internal class, exposed only for unit tests for now.
        It'll allow indexed database implementation to traverse a given key path and obtain the corresponding properties
        from a SerializedScriptValue.

        * WebKit.gyp:
        * tests/IDBKeyPathTest.cpp: Added.
        (WebCore::ExpectedToken::ExpectedToken):
        (WebCore::checkKeyPath):
        (WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-13 Steve Block <steveblock@google.com>
steveblock@google.com [Mon, 16 Aug 2010 12:30:05 +0000 (12:30 +0000)]
2010-08-13  Steve Block  <steveblock@google.com>

        Reviewed by Alexey Proskuryakov.

        Geolocation requests in progress when the frame is disconnected should invoke the error callback
        https://bugs.webkit.org/show_bug.cgi?id=43974

        If requests are ongoing when the Frame is disconnected, we abort them with a fatal error.
        To do this, when Geolocation::disconnectFrame() is called we call cancelAllRequests() to
        set a fatal error on all ongoing requests. Once the requests have made their error
        callbacks, they are deleted. Note that we check at callback time that the script
        execution context for the callback is still valid, so it's safe to attempt these
        callbacks even after the Geolocation object's Frame has gone.

        This requires a change to allow multiple calls to GeoNotifier::setFatalError().
        For repeated calls, we do not replace the existing error. This ensures that when
        permission has been denied and the frame is then disconnected, the error callback
        reports the permission error, as required by the spec.

        Tests: fast/dom/Geolocation/disconnected-frame.html
               fast/dom/Geolocation/disconnected-frame-permission-denied.html

        * page/Geolocation.cpp:
        (WebCore::Geolocation::GeoNotifier::setFatalError):
        (WebCore::Geolocation::disconnectFrame):
        (WebCore::Geolocation::startRequest):
        (WebCore::Geolocation::cancelAllRequests):
        * page/Geolocation.h:
2010-08-13  Steve Block  <steveblock@google.com>

        Reviewed by Alexey Proskuryakov.

        Geolocation requests in progress when the frame is disconnected should invoke the error callback
        https://bugs.webkit.org/show_bug.cgi?id=43974

        Added new tests to GTK skipped list.

        * fast/dom/Geolocation/disconnected-frame.html: Added.
        * fast/dom/Geolocation/disconnected-frame-expected.txt: Added.
        * fast/dom/Geolocation/script-tests/disconnected-frame.js: Added.
        * fast/dom/Geolocation/resources/disconnected-frame-inner.html: Added.
        * fast/dom/Geolocation/disconnected-frame-permission-denied.html: Added.
        * fast/dom/Geolocation/disconnected-frame-permission-denied-expected.txt: Added.
        * fast/dom/Geolocation/script-tests/disconnected-frame-permission-denied.js: Added.
        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@65416 268f45cc-cd09-0410-ab3c-d52691b4dbfc