WebKit-https.git
8 years agoMake TextTrackCue more mutable
eric.carlson@apple.com [Fri, 6 Jan 2012 21:12:40 +0000 (21:12 +0000)]
Make TextTrackCue more mutable
https://bugs.webkit.org/show_bug.cgi?id=72555

Reviewed by Anders Carlsson.

Source/WebCore:

Test: media/track/track-cue-mutable.html

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::updateActiveTextTrackCues): Do nothing if the "ignore cue updates"
    flag is set
(WebCore::HTMLMediaElement::textTrackAddCues): Block cue updates until all of the new cues have
    been added, then call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackRemoveCues): Block cue updates until all of the new cues have
    been removed, then call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackAddCue): Call updateActiveTextTrackCues so update the display if necessary.
(WebCore::HTMLMediaElement::textTrackRemoveCue): Ditto.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::ignoreTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::beginIgnoringTrackDisplayUpdateRequests):
(WebCore::HTMLMediaElement::endIgnoringTrackDisplayUpdateRequests):

* html/TextTrack.cpp:
(WebCore::TextTrack::cueWillChange): New, remove the cue from the media element because its
    position in the interval tree is based on start and end times.
(WebCore::TextTrack::cueDidChange): Add the cue to the media element.
* html/TextTrack.h:

* html/TextTrackCue.cpp:
(WebCore::startKeyword): New, use a static String for the constant.
(WebCore::middleKeyword): Ditto.
(WebCore::endKeyword): Ditto.
(WebCore::horizontalKeyword): Ditto.
(WebCore::verticalKeyword): Ditto.
(WebCore::verticallrKeyword): Ditto.
(WebCore::TextTrackCue::cueWillChange): New, tell the track the cue is about to change.
(WebCore::TextTrackCue::cueDidChange): New, tell the track the cue has changed.
(WebCore::TextTrackCue::setId): New, attribute is mutable.
(WebCore::TextTrackCue::setStartTime): Ditto.
(WebCore::TextTrackCue::setEndTime): Ditto.
(WebCore::TextTrackCue::setPauseOnExit): Ditto.
(WebCore::TextTrackCue::direction): Ditto.
(WebCore::TextTrackCue::setDirection): Ditto.
(WebCore::TextTrackCue::setSnapToLines): Ditto.
(WebCore::TextTrackCue::setLinePosition): Ditto.
(WebCore::TextTrackCue::setTextPosition): Ditto.
(WebCore::TextTrackCue::setSize): Ditto.
(WebCore::TextTrackCue::alignment): Ditto.
(WebCore::TextTrackCue::setAlignment): Ditto.
(WebCore::TextTrackCue::parseSettings): Use the static strings.
* html/TextTrackCue.h:
(WebCore::TextTrackCue::id):
(WebCore::TextTrackCue::startTime):
(WebCore::TextTrackCue::endTime):
(WebCore::TextTrackCue::pauseOnExit):
* html/TextTrackCue.idl:

LayoutTests:

* media/track/track-cue-mutable-expected.txt: Added.
* media/track/track-cue-mutable.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build.
fpizlo@apple.com [Fri, 6 Jan 2012 20:44:50 +0000 (20:44 +0000)]
Fix build.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG no longer optimises CanvasPixelArray
oliver@apple.com [Fri, 6 Jan 2012 20:38:42 +0000 (20:38 +0000)]
DFG no longer optimises CanvasPixelArray
https://bugs.webkit.org/show_bug.cgi?id=75729

Reviewed by Gavin Barraclough.

Source/JavaScriptCore:

Rename ByteArray (in its ClassInfo) to Uint8ClampedArray to match
the future name when we switch over to the new typed-array based
ImageData specification.

* runtime/JSByteArray.cpp:

Source/WebCore:

Remove the custom ClassInfo for CanvasPixelArray as that is
defeating ByteArray optimisation, and is no longer needed
anyway as it was only there to change the visible name.

* bindings/js/JSImageDataCustom.cpp:
(WebCore::toJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Sort the resources of WTF.xcodeproj
benjamin@webkit.org [Fri, 6 Jan 2012 20:31:05 +0000 (20:31 +0000)]
[Mac] Sort the resources of WTF.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75639

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

* WTF.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoASSERT failure due to combine-text with preceding spaces
commit-queue@webkit.org [Fri, 6 Jan 2012 20:30:15 +0000 (20:30 +0000)]
ASSERT failure due to combine-text with preceding spaces
https://bugs.webkit.org/show_bug.cgi?id=65147

Patch by Ken Buchanan <kenrb@chromium.org> on 2012-01-06
Reviewed by David Hyatt.

Source/WebCore:

A couple of ASSERTs were failing due to a parsing problem when
advancing an inline iterator to the next linebreak in a
RenderCombineText. skipLeadingWhitespace advances the iterator
over leading whitespace but when searching for the line break
nextLineBreak would call RenderCombineText::combineText(),
collapsing the text so that the iterator is pointing past the
end of it.

This patch causes combineText() to be called during
skipLeadingWhiteSpace before iteration over the RenderCombineText
begins.

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextLineBreak):
(WebCore::RenderBlock::LineBreaker::skipLeadingWhitespace):

LayoutTests:

New test with combine-text that begins with mutiple spaces,
showing ASSERT failures in bug 65147.

* fast/text/international/spaces-combined-in-vertical-text.html: Added
* fast/text/international/spaces-combined-in-vertical-text-expected.txt: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake ScrollAnimatorMac::snapRubberBandTimerFired use m_scrollElasticityController...
andersca@apple.com [Fri, 6 Jan 2012 20:25:40 +0000 (20:25 +0000)]
Make ScrollAnimatorMac::snapRubberBandTimerFired use m_scrollElasticityController in more places
https://bugs.webkit.org/show_bug.cgi?id=75726

Reviewed by Sam Weinig.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::canScrollHorizontally):
(WebCore::ScrollAnimatorMac::canScrollVertically):
(WebCore::ScrollAnimatorMac::snapRubberBandTimerFired):
* platform/mac/ScrollElasticityController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit1 fails to compile with USE(CFNETWORK) and HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
psolanki@apple.com [Fri, 6 Jan 2012 20:22:53 +0000 (20:22 +0000)]
WebKit1 fails to compile with USE(CFNETWORK) and HAVE(NETWORK_CFDATA_ARRAY_CALLBACK)
https://bugs.webkit.org/show_bug.cgi?id=75675

Reviewed by Oliver Hunt.

* platform/network/cf/ResourceHandleCFNet.cpp:
(WebCore::willCacheResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Need to allow SCNetworkReachability service in sandbox profile
ap@apple.com [Fri, 6 Jan 2012 20:21:23 +0000 (20:21 +0000)]
    Need to allow SCNetworkReachability service in sandbox profile
        https://bugs.webkit.org/show_bug.cgi?id=75724
        <rdar://problem/10652415>

        Reviewed by Mark Rowe.

        * WebProcess/com.apple.WebProcess.sb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse HashMap<OwnPtr> for SourceProviderCache items
caio.oliveira@openbossa.org [Fri, 6 Jan 2012 20:20:24 +0000 (20:20 +0000)]
Use HashMap<OwnPtr> for SourceProviderCache items
https://bugs.webkit.org/show_bug.cgi?id=75346

Reviewed by Daniel Bates.

* parser/Parser.cpp:
* parser/SourceProviderCache.cpp:
(JSC::SourceProviderCache::clear):
(JSC::SourceProviderCache::add):
* parser/SourceProviderCache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash with range selection across different documents.
inferno@chromium.org [Fri, 6 Jan 2012 20:15:59 +0000 (20:15 +0000)]
Crash with range selection across different documents.
https://bugs.webkit.org/show_bug.cgi?id=74285

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/Range/range-selection-across-documents-crash.html

* page/DOMSelection.cpp:
(WebCore::DOMSelection::addRange):

LayoutTests:

* fast/dom/Range/range-selection-across-documents-crash-expected.txt: Added.
* fast/dom/Range/range-selection-across-documents-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed; fixing expectation error.
dslomov@google.com [Fri, 6 Jan 2012 20:12:50 +0000 (20:12 +0000)]
Unreviewed; fixing expectation error.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove unused OwnFastMallocPtr class.
weinig@apple.com [Fri, 6 Jan 2012 20:09:26 +0000 (20:09 +0000)]
Remove unused OwnFastMallocPtr class.
https://bugs.webkit.org/show_bug.cgi?id=75722

Reviewed by Geoffrey Garen.

../JavaScriptCore:

* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/WTF/WTF.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/OwnFastMallocPtr.h: Removed.
* wtf/text/StringImpl.h:
* wtf/wtf.pro:

../JavaScriptGlue:

* ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.

../WebCore:

* ForwardingHeaders/wtf/OwnFastMallocPtr.h: Removed.
* bindings/js/JSWebGLRenderingContextCustom.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert overflow-in-uniform-regions to a reftest
commit-queue@webkit.org [Fri, 6 Jan 2012 20:07:33 +0000 (20:07 +0000)]
Convert overflow-in-uniform-regions to a reftest
https://bugs.webkit.org/show_bug.cgi?id=74765

Replaced the bitmap version of the test with a "reftest" version.   Use of text
has been revised a little to mitigate the possibility that small differences in
the platform's default font will change the location of line breaks.

Patch by Hans Muller <hmuller@adobe.com> on 2012-01-06
Reviewed by Anders Carlsson.

* fast/regions/overflow-in-uniform-regions-expected.html: Added.
* fast/regions/overflow-in-uniform-regions.html:
* platform/efl/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
* platform/efl/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.png: Removed.
* platform/mac/fast/regions/overflow-in-uniform-regions-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNeed to relayout when stretching the height of a flex item
tony@chromium.org [Fri, 6 Jan 2012 20:05:06 +0000 (20:05 +0000)]
Need to relayout when stretching the height of a flex item
https://bugs.webkit.org/show_bug.cgi?id=75661

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/flexbox/flex-align-stretch.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredMainAxisExtent): Always clear the override size since
it may be set when aligning.
(WebCore::RenderFlexibleBox::alignChildren): Only relayout if the height changed.

LayoutTests:

* css3/flexbox/flex-align-stretch-expected.txt: Added.
* css3/flexbox/flex-align-stretch.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ScrollElasticityControllerClient::immediateScrollBy
andersca@apple.com [Fri, 6 Jan 2012 20:01:55 +0000 (20:01 +0000)]
Add ScrollElasticityControllerClient::immediateScrollBy
https://bugs.webkit.org/show_bug.cgi?id=75720

Reviewed by Andreas Kling.

Add a new ScrollElasticityControllerClient::immediateScrollBy client member function.
Also, make ScrollAnimatorMac::smoothScrollWithEvent calls go through the ScrollElasticityController
in preparation for moving that function to ScrollElasticityController.

* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::smoothScrollWithEvent):
* platform/mac/ScrollElasticityController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Sort the resources of WebKit2.xcodeproj
benjamin@webkit.org [Fri, 6 Jan 2012 20:00:06 +0000 (20:00 +0000)]
[Mac] Sort the resources of WebKit2.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75636

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2012-01-06 Dmitry Lomov <dslomov@google.com>
dslomov@google.com [Fri, 6 Jan 2012 19:52:18 +0000 (19:52 +0000)]
2012-01-06  Dmitry Lomov  <dslomov@google.com>

Unreviewed: [Chromium] rebaselining IMAGE expectations after http://trac.webkit.org/changeset/104240/

        * platform/chromium-cg-mac-leopard/editing/input/caret-at-the-edge-of-input-expected.png:
        * platform/chromium-cg-mac-leopard/editing/inserting/before-after-input-element-expected.png: Added.
        * platform/chromium-cg-mac-leopard/editing/pasteboard/4806874-expected.png:
        * platform/chromium-cg-mac-leopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
        * platform/chromium-cg-mac-leopard/editing/pasteboard/input-field-1-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/3690703-2-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/3690703-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/3690719-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/4895428-3-expected.png: Added.
        * platform/chromium-cg-mac-leopard/editing/selection/4975120-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/drag-select-1-expected.png: Added.
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-1-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-2-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-3-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-4-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-across-readonly-input-5-expected.png:
        * platform/chromium-cg-mac-leopard/editing/selection/select-from-textfield-outwards-expected.png:
        * platform/chromium-cg-mac-leopard/fast/block/margin-collapse/103-expected.png:
        * platform/chromium-cg-mac-leopard/fast/css/input-search-padding-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/css/line-height-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/dom/isindex-001-expected.png:
        * platform/chromium-cg-mac-leopard/fast/dom/isindex-002-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/events/autoscroll-expected.png:
        * platform/chromium-cg-mac-leopard/fast/events/context-no-deselect-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/basic-inputs-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/encoding-test-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/fieldset-align-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/floating-textfield-relayout-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-appearance-bkcolor-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-appearance-default-bkcolor-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-appearance-visibility-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-appearance-width-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-baseline-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-field-text-truncated-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-1-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-placeholder-visibility-3-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-readonly-dimmed-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-readonly-empty-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-spaces-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-table-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-click-outside-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-double-click-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-drag-down-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-option-delete-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-type-text-min-width-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/input-width-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/minWidthPercent-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-number-rtl-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/placeholder-position-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/placeholder-pseudo-style-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/plaintext-mode-2-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/tabbing-input-iframe-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/text-style-color-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/textfield-focus-ring-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/textfield-overflow-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-cg-mac-leopard/fast/forms/visual-hebrew-text-field-expected.png:
        * platform/chromium-cg-mac-leopard/fast/frames/take-focus-from-iframe-expected.png: Added.
        * platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png:
        * platform/chromium-cg-mac-leopard/fast/html/details-open-javascript-expected.png:
        * platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png:
        * platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png:
        * platform/chromium-cg-mac-snowleopard/editing/input/caret-at-the-edge-of-input-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/inserting/before-after-input-element-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/pasteboard/4806874-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/pasteboard/drop-text-without-selection-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/pasteboard/input-field-1-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/3690703-2-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/3690703-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/3690719-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/4895428-3-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/4975120-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/drag-select-1-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-1-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-2-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-3-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-4-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-across-readonly-input-5-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/editing/selection/select-from-textfield-outwards-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/block/margin-collapse/103-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/css/input-search-padding-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/css/line-height-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/dom/isindex-001-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/dom/isindex-002-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/events/autoscroll-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/events/context-no-deselect-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/basic-inputs-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/encoding-test-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/fieldset-align-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/floating-textfield-relayout-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-bkcolor-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-default-bkcolor-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-visibility-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-appearance-width-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-baseline-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-field-text-truncated-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-1-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-placeholder-visibility-3-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-dimmed-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-readonly-empty-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-spaces-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-table-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-click-outside-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-double-click-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-drag-down-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-option-delete-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-text-self-emptying-click-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-type-text-min-width-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/input-width-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/minWidthPercent-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-number-rtl-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/number/input-appearance-spinbutton-layer-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-position-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/placeholder-pseudo-style-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/plaintext-mode-2-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/tabbing-input-iframe-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/text-style-color-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/textfield-focus-ring-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/textfield-overflow-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/forms/validation-message-appearance-expected.png:
        * platform/chromium-cg-mac-snowleopard/fast/forms/visual-hebrew-text-field-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/frames/take-focus-from-iframe-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/html/details-no-summary4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-no-summary4-expected.png.
        * platform/chromium-cg-mac-snowleopard/fast/html/details-open-javascript-expected.png: Added.
        * platform/chromium-cg-mac-snowleopard/fast/html/details-open2-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open2-expected.png.
        * platform/chromium-cg-mac-snowleopard/fast/html/details-open4-expected.png: Copied from LayoutTests/platform/chromium-cg-mac-leopard/fast/html/details-open4-expected.png.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUse VectorMath lib when possible to optimize the processing in WebAudio AudioBus
commit-queue@webkit.org [Fri, 6 Jan 2012 19:51:19 +0000 (19:51 +0000)]
Use VectorMath lib when possible to optimize the processing in WebAudio AudioBus
https://bugs.webkit.org/show_bug.cgi?id=75334

Patch by Wei James <james.wei@intel.com> on 2012-01-06
Reviewed by Kenneth Russell.

* platform/audio/AudioBus.cpp:
(WebCore::AudioBus::processWithGainFromMonoStereo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Sort the resources of WebKit.xcodeproj
benjamin@webkit.org [Fri, 6 Jan 2012 19:47:02 +0000 (19:47 +0000)]
[Mac] Sort the resources of WebKit.xcodeproj
https://bugs.webkit.org/show_bug.cgi?id=75634

Patch by Benjamin Poulain <bpoulain@apple.com> on 2012-01-06
Reviewed by Andreas Kling.

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFullscreen video controller can't be dragged the first time I enter fullscreen
jer.noble@apple.com [Fri, 6 Jan 2012 19:38:46 +0000 (19:38 +0000)]
Fullscreen video controller can't be dragged the first time I enter fullscreen
https://bugs.webkit.org/show_bug.cgi?id=75709

Reviewed by Eric Carlson.

Source/WebCore:

No new tests; updated video-controls-drag.html.

When the media controls are created, check to see if we are full screen, and pass
that information to the newly created controls.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::createMediaControls):

LayoutTests:

Update the test to cover the case where the controls do not yet exist when entering
fullscreen.

* fullscreen/video-controls-drag.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate test expectations with rebaseline of fast/forms/listbox-clip.html from r104299.
jonlee@apple.com [Fri, 6 Jan 2012 19:30:16 +0000 (19:30 +0000)]
Update test expectations with rebaseline of fast/forms/listbox-clip.html from r104299.

Unreviewed.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Sort the resources of JavaScriptCore.xcodeproj and remove duplicates
benjamin@webkit.org [Fri, 6 Jan 2012 19:21:41 +0000 (19:21 +0000)]
[Mac] Sort the resources of JavaScriptCore.xcodeproj and remove duplicates
https://bugs.webkit.org/show_bug.cgi?id=75631

Patch by Benjamin Poulain <bpoulain@webkit.org> on 2012-01-06
Reviewed by Andreas Kling.

* JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMedia Element: scrubbing in full-screen mode breaks playback.
jer.noble@apple.com [Fri, 6 Jan 2012 19:13:02 +0000 (19:13 +0000)]
Media Element: scrubbing in full-screen mode breaks playback.
https://bugs.webkit.org/show_bug.cgi?id=75650

Reviewed by John Sullivan.

Source/WebCore:

Test: fullscreen/video-controls-timeline.html

Only begin scrubbing if the panel itself is the mousedown event target.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::defaultEventHandler):

LayoutTests:

* fullscreen/video-controls-timeline-expected.txt: Added.
* fullscreen/video-controls-timeline.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd new (failing) test to Chromium test_expectations. Fix tracked by
jer.noble@apple.com [Fri, 6 Jan 2012 19:03:04 +0000 (19:03 +0000)]
Add new (failing) test to Chromium test_expectations.  Fix tracked by
https://bugs.webkit.org/show_bug.cgi?id=75716

Unreviewed; test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r90797): Full screen video HUD cannot be dragged horizontally
jer.noble@apple.com [Fri, 6 Jan 2012 18:28:43 +0000 (18:28 +0000)]
REGRESSION (r90797): Full screen video HUD cannot be dragged horizontally
https://bugs.webkit.org/show_bug.cgi?id=75200

Reviewed by Eric Carlson.

Source/WebCore:

Test: fullscreen/video-controls-drag.html

The !important rules in fullscreenQuickTime.css are overriding the styles added by the
drag operation in MediaControlElements.cpp.  Give the panel a "dragged" class in setPosition
(clearing it in resetPosition) that allows the !important rules to apply only when the
panel is not dragged.

* css/fullscreenQuickTime.css:
(video:-webkit-full-screen::-webkit-media-controls-panel):
(video:-webkit-full-screen::-webkit-media-controls-panel:not(.dragged)):
* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlPanelElement::setPosition):
(WebCore::MediaControlPanelElement::resetPosition):

LayoutTests:

* fullscreen/video-controls-drag-expected.txt: Added.
* fullscreen/video-controls-drag.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Remove fast/files/domurl-script-execution-context-crash.html
senorblanco@chromium.org [Fri, 6 Jan 2012 18:06:50 +0000 (18:06 +0000)]
[Chromium] Remove fast/files/domurl-script-execution-context-crash.html
from test_expectations (no longer crashing).

Unreviewed; test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTools: Update DRT on Mac to draw resize handles on text areas.
jonlee@apple.com [Fri, 6 Jan 2012 17:50:10 +0000 (17:50 +0000)]
Tools: Update DRT on Mac to draw resize handles on text areas.

Reviewed by John Sullivan.

Enable resize handles on text areas so that we don't have to create two different sets of pixel test results,
between WK1 and WK2. This will require rebaselining existing textarea pixel tests.

* DumpRenderTree/mac/DumpRenderTree.mm:
(resetDefaultsToConsistentValues):

LayoutTests: Rebaseline fast/forms
Rebaseline pixel tests involving textarea.

Reviewed by John Sullivan.

Moved from mac to mac-snowleopard:

* platform/mac-snowleopard/fast/forms/001
* platform/mac-snowleopard/fast/forms/HTMLOptionElement_label02
* platform/mac-snowleopard/fast/forms/HTMLOptionElement_label03
* platform/mac-snowleopard/fast/forms/HTMLOptionElement_label04
* platform/mac-snowleopard/fast/forms/basic-buttons-expected
* platform/mac-snowleopard/fast/forms/basic-inputs-expected
* platform/mac-snowleopard/fast/forms/basic-selects-expected
* platform/mac-snowleopard/fast/forms/basic-textareas-expected
* platform/mac-snowleopard/fast/forms/basic-textareas-quirks-expected
* platform/mac-snowleopard/fast/forms/box-shadow-override
* platform/mac-snowleopard/fast/forms/button-align
* platform/mac-snowleopard/fast/forms/button-generated-content
* platform/mac-snowleopard/fast/forms/button-sizes
* platform/mac-snowleopard/fast/forms/button-style-color
* platform/mac-snowleopard/fast/forms/button-table-styles
* platform/mac-snowleopard/fast/forms/button-text-transform
* platform/mac-snowleopard/fast/forms/button-white-space
* platform/mac-snowleopard/fast/forms/control-restrict-line-height
* platform/mac-snowleopard/fast/forms/disabled-select-change-index
* platform/mac-snowleopard/fast/forms/fieldset-align
* platform/mac-snowleopard/fast/forms/file/file-input-direction
* platform/mac-snowleopard/fast/forms/form-element-geometry
* platform/mac-snowleopard/fast/forms/form-hides-table
* platform/mac-snowleopard/fast/forms/input-appearance-height
* platform/mac-snowleopard/fast/forms/input-button-sizes
* platform/mac-snowleopard/fast/forms/input-table
* platform/mac-snowleopard/fast/forms/input-value
* platform/mac-snowleopard/fast/forms/menulist-style-color
* platform/mac-snowleopard/fast/forms/option-strip-whitespace
* platform/mac-snowleopard/fast/forms/placeholder-position
* platform/mac-snowleopard/fast/forms/radio_checked
* platform/mac-snowleopard/fast/forms/radio_checked_dynamic
* platform/mac-snowleopard/fast/forms/range/slider-padding
* platform/mac-snowleopard/fast/forms/select-align
* platform/mac-snowleopard/fast/forms/select-baseline-expected
* platform/mac-snowleopard/fast/forms/select-disabled-appearance
* platform/mac-snowleopard/fast/forms/select-initial-position
* platform/mac-snowleopard/fast/forms/select-style
* platform/mac-snowleopard/fast/forms/select-writing-direction-natural-expected
* platform/mac-snowleopard/fast/forms/textAreaLineHeight
* platform/mac-snowleopard/fast/forms/textarea-align
* platform/mac-snowleopard/fast/forms/textarea-scroll-height
* platform/mac-snowleopard/fast/forms/textarea-width
* platform/mac-snowleopard/fast/overflow/overflow-x-y

New pixel test results:

* platform/mac/fast/forms/001-expected.png:
* platform/mac/fast/forms/HTMLOptionElement_label02-expected.png:
* platform/mac/fast/forms/HTMLOptionElement_label03-expected.png:
* platform/mac/fast/forms/HTMLOptionElement_label04-expected.png:
* platform/mac/fast/forms/basic-buttons-expected.png:
* platform/mac/fast/forms/basic-inputs-expected.png:
* platform/mac/fast/forms/basic-selects-expected.png:
* platform/mac/fast/forms/basic-textareas-expected.png:
* platform/mac/fast/forms/basic-textareas-quirks-expected.png:
* platform/mac/fast/forms/box-shadow-override-expected.png:
* platform/mac/fast/forms/button-align-expected.png:
* platform/mac/fast/forms/button-generated-content-expected.png:
* platform/mac/fast/forms/button-sizes-expected.png:
* platform/mac/fast/forms/button-style-color-expected.png:
* platform/mac/fast/forms/button-table-styles-expected.png:
* platform/mac/fast/forms/button-text-transform-expected.png:
* platform/mac/fast/forms/button-white-space-expected.png:
* platform/mac/fast/forms/control-restrict-line-height-expected.png:
* platform/mac/fast/forms/disabled-select-change-index-expected.png:
* platform/mac/fast/forms/fieldset-align-expected.png:
* platform/mac/fast/forms/file/file-input-direction-expected.png:
* platform/mac/fast/forms/form-element-geometry-expected.png:
* platform/mac/fast/forms/form-hides-table-expected.png:
* platform/mac/fast/forms/input-appearance-height-expected.png:
* platform/mac/fast/forms/input-button-sizes-expected.png:
* platform/mac/fast/forms/input-table-expected.png:
* platform/mac/fast/forms/input-value-expected.png:
* platform/mac/fast/forms/menulist-style-color-expected.png:
* platform/mac/fast/forms/option-strip-whitespace-expected.png:
* platform/mac/fast/forms/placeholder-position-expected.png:
* platform/mac/fast/forms/radio_checked-expected.png:
* platform/mac/fast/forms/radio_checked_dynamic-expected.png:
* platform/mac/fast/forms/range/slider-padding-expected.png:
* platform/mac/fast/forms/select-align-expected.png:
* platform/mac/fast/forms/select-baseline-expected.png:
* platform/mac/fast/forms/select-disabled-appearance-expected.png:
* platform/mac/fast/forms/select-initial-position-expected.png:
* platform/mac/fast/forms/select-style-expected.png:
* platform/mac/fast/forms/select-writing-direction-natural-expected.png:
* platform/mac/fast/forms/textAreaLineHeight-expected.png:
* platform/mac/fast/forms/textarea-align-expected.png:
* platform/mac/fast/forms/textarea-scroll-height-expected.png:
* platform/mac/fast/forms/textarea-width-expected.png:
* platform/mac/fast/overflow/overflow-x-y-expected.png:

Added new results:

* platform/mac/fast/forms/selectlist-minsize-expected.png: Added. Needs Snow Leopard baseline.
* platform/mac/fast/forms/basic-selects-expected.txt: Rebaseline since fix of bug 74270.
* platform/mac/fast/forms/listbox-clip-expected.png: Fix was made to have default # of options in list box to 4, instead of 5. Needed
brand new baseline, and so does Snow Leopard.
* platform/mac/fast/forms/listbox-clip-expected.txt:
* platform/mac/test_expectations.txt: New expectations for basic-selects.html, since the fix of bug 74270.

New baselines that were not moved to mac-snowleopard because the difference was just the resize handle.

* platform/mac/fast/table/003-expected.png:
* platform/mac/tables/mozilla/bugs/bug194024-expected.png:
* platform/mac/tables/mozilla/bugs/bug30692-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix.
jberlin@webkit.org [Fri, 6 Jan 2012 17:19:12 +0000 (17:19 +0000)]
Windows build fix.

* Interfaces/IWebViewPrivate.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Expectations for svg/carto.net/button.svg can be updated
commit-queue@webkit.org [Fri, 6 Jan 2012 17:13:42 +0000 (17:13 +0000)]
[Chromium] Expectations for svg/carto.net/button.svg can be updated
https://bugs.webkit.org/show_bug.cgi?id=75621

Unreviewed update to Chromium test_expectations

Patch by Stephen Chenney <schenney@chromium.org> on 2012-01-06

* platform/chromium/test_expectations.txt: Removed flakiness line for carto.net/button.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Set baseline for new test plugins/npruntime/object-from-destroyed-plugin...
jknotten@chromium.org [Fri, 6 Jan 2012 17:03:49 +0000 (17:03 +0000)]
[Chromium] Set baseline for new test plugins/npruntime/object-from-destroyed-plugin-in-subframe.html
https://bugs.webkit.org/show_bug.cgi?id=75706

Unreviewed.

* platform/chromium/plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agomake canvas-lineWidth test pass even if pixel values vary a tiny bit
commit-queue@webkit.org [Fri, 6 Jan 2012 15:42:57 +0000 (15:42 +0000)]
make canvas-lineWidth test pass even if pixel values vary a tiny bit
https://bugs.webkit.org/show_bug.cgi?id=75627

Patch by Elliot Poger <epoger@google.com> on 2012-01-06
Reviewed by Stephen White.

* fast/canvas/canvas-lineWidth.js:
(compareRows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRebaseline mac results after r104240.
jknotten@chromium.org [Fri, 6 Jan 2012 15:37:57 +0000 (15:37 +0000)]
Rebaseline mac results after r104240.

https://bugs.webkit.org/show_bug.cgi?id=75654 changed the way
text fields are drawn on Mac.

Unreviewed.

* platform/chromium-cg-mac-leopard/fast/forms/input-align-expected.png:
* platform/chromium-cg-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-cg-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-cg-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-cg-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-cg-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-cg-mac-leopard/fast/table/003-expected.png: Added.
* platform/chromium-cg-mac-leopard/fast/table/text-field-baseline-expected.png: Added.
* platform/chromium-cg-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-cg-mac-leopard/svg/hixie/mixed/003-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/45621-expected.png: Added.
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-cg-mac-leopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/forms/input-align-expected.txt: Added.
* platform/chromium-cg-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/chromium-cg-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-cg-mac-snowleopard/fast/table/003-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-cg-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/chromium-cg-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
* platform/chromium-cg-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
* platform/chromium-cg-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
* platform/chromium-cg-mac/svg/hixie/mixed/003-expected.png: Removed.
* platform/chromium-cg-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
* platform/chromium-mac-leopard/fast/forms/input-align-expected.png:
* platform/chromium-mac-leopard/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-mac-leopard/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-mac-leopard/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-mac-leopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-leopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac-leopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac-leopard/fast/table/003-expected.png:
* platform/chromium-mac-leopard/fast/table/text-field-baseline-expected.png:
* platform/chromium-mac-leopard/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-mac-leopard/svg/hixie/mixed/003-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-mac-leopard/tables/mozilla/other/move_row-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/input-align-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/lists/dynamic-marker-crash-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
* platform/chromium-mac-snowleopard/fast/replaced/replaced-breaking-mixture-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-mac-snowleopard/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-mac-snowleopard/fast/table/003-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/spanOverlapRepaint-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png.
* platform/chromium-mac-snowleopard/fast/table/text-field-baseline-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/transforms/transformed-focused-text-input-expected.png: Added.
* platform/chromium-mac-snowleopard/http/tests/navigation/javascriptlink-frames-expected.png: Added.
* platform/chromium-mac-snowleopard/svg/hixie/mixed/003-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/45621-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug1188-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-2-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-2-expected.png.
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug2479-3-expected.png: Renamed from LayoutTests/platform/chromium-mac/tables/mozilla/bugs/bug2479-3-expected.png.
* platform/chromium-mac-snowleopard/tables/mozilla/dom/tableDom-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla/other/move_row-expected.png: Added.
* platform/chromium-mac/fast/forms/input-align-expected.png: Removed.
* platform/chromium-mac/fast/lists/dynamic-marker-crash-expected.png: Removed.
* platform/chromium-mac/fast/replaced/replaced-breaking-mixture-expected.png: Removed.
* platform/chromium-mac/fast/replaced/width100percent-textfield-expected.png: Removed.
* platform/chromium-mac/fast/table/003-expected.png: Removed.
* platform/chromium-mac/fast/table/text-field-baseline-expected.png: Removed.
* platform/chromium-mac/fast/transforms/transformed-focused-text-input-expected.png: Removed.
* platform/chromium-mac/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
* platform/chromium-mac/svg/hixie/mixed/003-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/45621-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/bugs/bug1188-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/dom/tableDom-expected.png: Removed.
* platform/chromium-mac/tables/mozilla/other/move_row-expected.png: Removed.
* platform/chromium-win-vista/http/tests/navigation/javascriptlink-frames-expected.png: Removed.
* platform/chromium-win/http/tests/inspector/network/download-expected.txt: Added.
* platform/chromium/fast/replaced/width100percent-textfield-expected.png: Added.
* platform/chromium/fast/table/colspanMinWidth-expected.png: Copied from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
* platform/chromium/fast/table/colspanMinWidth-vertical-expected.png: Renamed from LayoutTests/platform/chromium-mac/fast/table/spanOverlapRepaint-expected.png.
* platform/chromium/http/tests/inspector/network/download-expected.txt: Added.
* platform/chromium/plugins/mouse-click-plugin-clears-selection-expected.png:
* platform/mac/plugins/mouse-click-plugin-clears-selection-expected.txt: Renamed from LayoutTests/plugins/mouse-click-plugin-clears-selection-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Fix compilation of app code against QtWebKit master header file
hausmann@webkit.org [Fri, 6 Jan 2012 15:28:47 +0000 (15:28 +0000)]
[Qt] Fix compilation of app code against QtWebKit master header file

Unreviewed trivial build fix.

* Source/sync.profile: Exclude util.h and testwindow.h from the master header
file, because it cannot be used outside of the WebKit source tree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r104060): fast/forms/textarea-metrics.html is failing
antti@apple.com [Fri, 6 Jan 2012 14:48:23 +0000 (14:48 +0000)]
REGRESSION (r104060): fast/forms/textarea-metrics.html is failing
https://bugs.webkit.org/show_bug.cgi?id=75644

Reviewed by Alexey Proskuryakov.

We need to clear the style selector on doc type change as the doc type
may affect interpretation of the stylesheets. r104060 extended the life
of the style selector in some cases, exposing this problem.

* dom/Document.cpp:
(WebCore::Document::setDocType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the new WTF module build on Gtk
kov@webkit.org [Fri, 6 Jan 2012 14:25:39 +0000 (14:25 +0000)]
Make the new WTF module build on Gtk
https://bugs.webkit.org/show_bug.cgi?id=75669

Patch by Eric Seidel  <eric@webkit.org> and Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2012-01-06

Source/JavaScriptCore:

* GNUmakefile.am:

Source/WTF:

* GNUmakefile.am: Added.
* GNUmakefile.list.am: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Upstream BlackBerry WebCoreSupport cache client
commit-queue@webkit.org [Fri, 6 Jan 2012 14:21:14 +0000 (14:21 +0000)]
[BlackBerry] Upstream BlackBerry WebCoreSupport cache client
https://bugs.webkit.org/show_bug.cgi?id=75649

Patch by Jacky Jiang <zhajiang@rim.com> on 2012-01-06
Reviewed by Antonio Gomes.

Initial upstream, no new tests.

* blackberry/WebCoreSupport/CacheClientBlackBerry.cpp: Added.
* blackberry/WebCoreSupport/CacheClientBlackBerry.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] QQuickWebView breaks when an empty url is loaded
commit-queue@webkit.org [Fri, 6 Jan 2012 13:34:27 +0000 (13:34 +0000)]
[Qt][WK2] QQuickWebView breaks when an empty url is loaded
https://bugs.webkit.org/show_bug.cgi?id=75445

Patch by Rafael Brandao <rafael.lobo@openbossa.org> on 2012-01-06
Reviewed by Tor Arne Vestbø.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebView::load):
* UIProcess/API/qt/tests/qmltests/WebView/tst_loadUrl.qml: Check if a request to load
an empty url is ignored. 'about:blank' should be used instead to load an empty page.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Remove un-needed VPATHs from project includes
vestbo@webkit.org [Fri, 6 Jan 2012 13:18:09 +0000 (13:18 +0000)]
[Qt] Remove un-needed VPATHs from project includes

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Move listing of include paths and libs to pri files in sources
vestbo@webkit.org [Fri, 6 Jan 2012 12:53:33 +0000 (12:53 +0000)]
[Qt] Move listing of include paths and libs to pri files in sources

Includepaths are sometimes modified by non-Qt contributors so keeping
them in files inside Sources makes it more likely that they are updated
along with project files for the other ports.

Using pri files instead of prf files for this also has the benefit that
the include() from the main target file can be parsed and followed by
Qt Creator -- something that does not work with load().

Dependency from a target to a library through the WEBKIT variable are
handled through forwarding-files in Tools/qmake/mkspecs/modules, which
set the source root of the module and include the right pri file.

Ideally we'd use the variant of include() that takes an optional
namespace to read the variables into, or the fromfile() function,
but both of these add an overhead of about 40% on the total qmake
runtime, due to making a deep copy of all the variables in the
project or re-reading all the prf files from scratch.

Reviewed by Simon Hausmann.
Reviewed by Ossy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Add a few more files ot OTHER_FILES
vestbo@webkit.org [Fri, 6 Jan 2012 12:44:11 +0000 (12:44 +0000)]
[Qt] Add a few more files ot OTHER_FILES

Rubber-stamped by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Skip a new failing test.
ossy@webkit.org [Fri, 6 Jan 2012 12:27:33 +0000 (12:27 +0000)]
[Qt] Unreviewed gardening. Skip a new failing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebKit/efl: [EFL] Add new pre-rendering code.
commit-queue@webkit.org [Fri, 6 Jan 2012 11:25:24 +0000 (11:25 +0000)]
Source/WebKit/efl: [EFL] Add new pre-rendering code.
https://bugs.webkit.org/show_bug.cgi?id=73430

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.

Add new pre-rendering code to pre-render the view area more efficiently.
At first find centered view position where backing store starts to queuing the render request from.
And append the request into the tiled backing store in spiral order.

* ewk/ewk_private.h:
* ewk/ewk_tiled_backing_store.cpp:
(ewk_tiled_backing_store_pre_render_tile_add):
(ewk_tiled_backing_store_pre_render_spiral_queue):
* ewk/ewk_tiled_backing_store.h:
* ewk/ewk_view.cpp:
(_ewk_view_smart_pre_render_start):
(ewk_view_base_smart_set):
(ewk_view_pre_render_start):
* ewk/ewk_view.h:
* ewk/ewk_view_tiled.cpp:
(_ewk_view_tiled_rect_collision_check):
(_ewk_view_tiled_rect_collision_resolve):
(_ewk_view_tiled_smart_pre_render_start):
(ewk_view_tiled_smart_set):

Tools: [EFL] Add pre-render handling code in EWebLauncher.
https://bugs.webkit.org/show_bug.cgi?id=73430

Patch by JungJik Lee <jungjik.lee@samsung.com> on 2012-01-06
Reviewed by Zoltan Herczeg.

Add pre-render handling code by pressing Insert key.

* EWebLauncher/main.c:
(on_key_down):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Update test expectations.
jknotten@chromium.org [Fri, 6 Jan 2012 10:55:22 +0000 (10:55 +0000)]
[Chromium] Update test expectations.
https://bugs.webkit.org/show_bug.cgi?id=75698

Unreviewed.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Add test for application URL schemes.
zeno.albisser@nokia.com [Fri, 6 Jan 2012 10:31:36 +0000 (10:31 +0000)]
[Qt][WK2] Add test for application URL schemes.
https://bugs.webkit.org/show_bug.cgi?id=74933

Reviewed by Kenneth Rohde Christiansen.

* UIProcess/API/qt/tests/qmltests/WebView/tst_applicationScheme.qml: Added.
* UIProcess/API/qt/tests/qmltests/qmltests.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFrameDestructionObserver should be more full-service
abarth@webkit.org [Fri, 6 Jan 2012 10:28:24 +0000 (10:28 +0000)]
FrameDestructionObserver should be more full-service
https://bugs.webkit.org/show_bug.cgi?id=75690

Reviewed by Eric Seidel.

This patch moves code common to both subclasses of
FrameDestructionObserver into FrameDestructionObserver itself.  As we
add more subclasses, we don't want to keep copy/pasting this code.

* page/Frame.cpp:
(WebCore::FrameDestructionObserver::FrameDestructionObserver):
(WebCore::FrameDestructionObserver::~FrameDestructionObserver):
(WebCore::FrameDestructionObserver::frameDestroyed):
* page/Frame.h:
(WebCore::FrameDestructionObserver::frame):
* plugins/DOMMimeType.cpp:
(WebCore::DOMMimeType::DOMMimeType):
(WebCore::DOMMimeType::~DOMMimeType):
* plugins/DOMMimeType.h:
* plugins/DOMPlugin.cpp:
(WebCore::DOMPlugin::DOMPlugin):
(WebCore::DOMPlugin::~DOMPlugin):
* plugins/DOMPlugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove MediaDocument styles into CSS. Set black background for chromium.
commit-queue@webkit.org [Fri, 6 Jan 2012 09:43:44 +0000 (09:43 +0000)]
Move MediaDocument styles into CSS. Set black background for chromium.
https://bugs.webkit.org/show_bug.cgi?id=74123

Source/WebCore:

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

Test: platform/chromium/media/video-black-bg-in-media-document.html

* css/mediaControls.css:
(body:-webkit-full-page-media):
(video:-webkit-full-page-media):
* css/mediaControlsChromium.css:
(body:-webkit-full-page-media):
* html/MediaDocument.cpp:
(WebCore::MediaDocumentParser::createDocumentStructure):

LayoutTests:

Adds a new chromium specific test for ensuring the background is set
properly.

Rebaselines the text portions of media-document-audio-repaint.

Patch by Dale Curtis <dalecurtis@chromium.org> on 2012-01-06
Reviewed by Eric Seidel.

* platform/chromium-gpu-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium-gpu/media/media-document-audio-repaint-expected.txt:
* platform/chromium-win/media/media-document-audio-repaint-expected.txt:
* platform/chromium/media/media-document-audio-repaint-expected.txt:
* platform/chromium/media/video-black-bg-in-media-document-expected.txt: Added.
* platform/chromium/media/video-black-bg-in-media-document.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Update Qt specific expected results after r104208.
ossy@webkit.org [Fri, 6 Jan 2012 09:03:23 +0000 (09:03 +0000)]
[Qt] Unreviewed gardening. Update Qt specific expected results after r104208.

* platform/qt/fast/table/032-expected.png:
* platform/qt/fast/table/032-expected.txt:
* platform/qt/fast/writing-mode/table-percent-width-quirk-expected.png: Added.
* platform/qt/fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
* platform/qt/tables/mozilla/bugs/bug55694-expected.png:
* platform/qt/tables/mozilla/bugs/bug55694-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReport correct line number for non-native editable text elements.
aboxhall@chromium.org [Fri, 6 Jan 2012 08:53:12 +0000 (08:53 +0000)]
Report correct line number for non-native editable text elements.
https://bugs.webkit.org/show_bug.cgi?id=71263

Reviewed by Ryosuke Niwa.

Source/WebCore:

A non-native editable text element is an element with an ARIA role of "textbox", which is
set on an element which behaves like an editable text element (such as a textarea, text
input field or contenteditable text), but whose behaviour is controlled by the author rather
than the browser.

This change makes certain methods on Node, and related methods in htmlediting and
visible_units, aware of the notion that an element may be editable only from the point of
view of assistive technology (via the ARIA textbox role), via the EditableType enum added to
EditingBoundary.h.

This is so that AccessibilityObject::lineForPosition() can use previousLinePosition(), and
AccessibilityRenderObject::indexForVisiblePosition() can use highestEditableRoot(), in a way
that respects non-native editability.

Test: accessibility/textbox-role-reports-line-number.html

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::rootAXEditableElement): Returns the root element which is
editable from the point of view of assistive technology, whether natively or otherwise.
(WebCore::AXObjectCache::nodeIsTextControl): Whether the given node is considered an
editable text element by assistive technology, natively or otherwise.
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::lineForPosition): Modified to request the previous line
position in an element which is editable to Accessibility.
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::indexForVisiblePosition): Modified to request the
highest root element which is editable to Accessibility.
* dom/Node.cpp:
(WebCore::Node::rendererIsEditableToAccessibility): Whether this node is editable to
Accessibility for the given EditableLevel.
(WebCore::Node::rootEditableElement): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.
* dom/Node.h:
(WebCore::Node::rendererIsEditable): Overloaded version of this method which takes an
EditableType enum value indicating whether non-native editability is to be respected.
(WebCore::Node::rendererIsRichlyEditable):  Overloaded version of this method which takes
an EditableType enum value indicating whether non-native editability is to be respected.
* editing/EditingBoundary.h:
* editing/htmlediting.cpp:
(WebCore::highestEditableRoot): Added optional EditableType parameter.
(WebCore::isEditablePosition): Added optional EditableType parameter.
(WebCore::isRichlyEditablePosition): Added optional EditableType parameter.
(WebCore::editableRootForPosition): Added optional EditableType parameter.
* editing/htmlediting.h:
* editing/visible_units.cpp:
(WebCore::previousLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::previousLinePosition): Added optional EditableType parameter.
(WebCore::nextLeafWithSameEditability): Added optional EditableType parameter.
(WebCore::nextLinePosition): Added optional EditableType parameter.
* editing/visible_units.h:

LayoutTests:

* accessibility/textbox-role-reports-line-number-expected.txt: Added.
* accessibility/textbox-role-reports-line-number.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a crash by importing an element of which local name ends with ":input".
tkent@chromium.org [Fri, 6 Jan 2012 08:47:18 +0000 (08:47 +0000)]
Fix a crash by importing an element of which local name ends with ":input".
https://bugs.webkit.org/show_bug.cgi?id=75103

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/dom/importNode-confusing-localName.html

* dom/Document.cpp:
(WebCore::Document::importNode): Pass QualifiedName of the source elemnt
to createElement() in order to avoid unnecessary serialization and
parsing of the qualified name

LayoutTests:

* fast/dom/importNode-confusing-localName-expected.txt: Added.
* fast/dom/importNode-confusing-localName.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove HTMLFormControlElementWithState class in its own header file.
tkent@chromium.org [Fri, 6 Jan 2012 08:33:24 +0000 (08:33 +0000)]
Move HTMLFormControlElementWithState class in its own header file.
https://bugs.webkit.org/show_bug.cgi?id=75482

Patch by Alexis Menard <alexis.menard@openbossa.org> on 2012-01-06
Reviewed by Kent Tamura.

Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.

No new tests : the existing ones should cover the refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLFormControlElement.cpp:
* html/HTMLFormControlElement.h:
* html/HTMLKeygenElement.h:
* html/HTMLSelectElement.h:
* html/HTMLTextFormControlElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNRWT should use test_expectation.txt on wk2 platforms
ossy@webkit.org [Fri, 6 Jan 2012 08:14:02 +0000 (08:14 +0000)]
NRWT should use test_expectation.txt on wk2 platforms
https://bugs.webkit.org/show_bug.cgi?id=75417

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/webkit.py:
(path_to_test_expectations_file):
* Scripts/webkitpy/layout_tests/port/webkit_unittest.py:
(test_path_to_test_expectations_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r104268.
ossy@webkit.org [Fri, 6 Jan 2012 08:09:16 +0000 (08:09 +0000)]
Unreviewed, rolling out r104268.
http://trac.webkit.org/changeset/104268
https://bugs.webkit.org/show_bug.cgi?id=75689

It broke the mac build (Requested by Ossy on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElementWithState::HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::~HTMLFormControlElementWithState):
(WebCore::HTMLFormControlElementWithState::didMoveToNewDocument):
(WebCore::HTMLFormControlElementWithState::shouldAutocomplete):
(WebCore::HTMLFormControlElementWithState::shouldSaveAndRestoreFormControlState):
(WebCore::HTMLFormControlElementWithState::finishParsingChildren):
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElementWithState::canContainRangeEndPoint):
(WebCore::HTMLFormControlElementWithState::saveFormControlState):
(WebCore::HTMLFormControlElementWithState::restoreFormControlState):
* html/HTMLFormControlElementWithState.cpp: Removed.
* html/HTMLFormControlElementWithState.h: Removed.
* html/HTMLKeygenElement.h:
* html/HTMLSelectElement.h:
* html/HTMLTextFormControlElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r104259 and r104261.
commit-queue@webkit.org [Fri, 6 Jan 2012 08:07:42 +0000 (08:07 +0000)]
Unreviewed, rolling out r104259 and r104261.
http://trac.webkit.org/changeset/104259
http://trac.webkit.org/changeset/104261
https://bugs.webkit.org/show_bug.cgi?id=75688

Caused assertion failures (Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-06

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
* dom/DOMAllInOne.cpp:
* dom/Document.cpp:
(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):
* dom/Element.cpp:
(WebCore::Element::removeShadowRoot):
* dom/Node.cpp:
(WebCore::Node::setDocument):
(WebCore::Node::setTreeScopeRecursively):
(WebCore::Node::setDocumentRecursively):
(WebCore::Node::didMoveToNewDocument):
* dom/Node.h:
* dom/TreeScope.cpp:
* dom/TreeScope.h:
* dom/TreeScopeAdopter.cpp: Removed.
* dom/TreeScopeAdopter.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE
commit-queue@webkit.org [Fri, 6 Jan 2012 08:04:29 +0000 (08:04 +0000)]
WTF::String: Inline method shouldn't have WTF_EXPORT_PRIVATE
https://bugs.webkit.org/show_bug.cgi?id=75612

Patch by Hajime Morrita <morrita@chromium.org> on 2012-01-06
Reviewed by Kevin Ollivier.

* wtf/text/WTFString.h:
(WTF::String::findIgnoringCase):
(WTF::String::append):
(WTF::String::fromUTF8):
(WTF::String::fromUTF8WithLatin1Fallback):
(WTF::String::isHashTableDeletedValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/10633760> Update copyright strings
mitz@apple.com [Fri, 6 Jan 2012 06:41:04 +0000 (06:41 +0000)]
<rdar://problem/10633760> Update copyright strings

Reviewed by Mark Rowe.

Source/JavaScriptCore:

* Info.plist:

Source/JavaScriptGlue:

* Info.plist:

Source/WebCore:

* Info.plist:

Source/WebKit/mac:

* Info.plist:

Source/WebKit2:

* Info.plist:
* PluginProcess/Info.plist:
* WebProcess/Info.plist:

WebKitLibraries:

* win/tools/scripts/COPYRIGHT-END-YEAR:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMove HTMLFormControlElementWithState class in its own header file.
alexis.menard@openbossa.org [Fri, 6 Jan 2012 05:36:37 +0000 (05:36 +0000)]
Move HTMLFormControlElementWithState class in its own header file.
https://bugs.webkit.org/show_bug.cgi?id=75482

Reviewed by Kent Tamura.

Move HTMLFormControlElementWithState class which was mixed in HTMLFormControlElement
files into its own header file and its own implementation file.

No new tests : the existing ones should cover the refactoring.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* html/HTMLElementsAllInOne.cpp:
* html/HTMLFormControlElement.cpp:
* html/HTMLFormControlElement.h:
* html/HTMLKeygenElement.h:
* html/HTMLSelectElement.h:
* html/HTMLTextFormControlElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDate constructor handles infinite values incorrectly.
barraclough@apple.com [Fri, 6 Jan 2012 05:29:28 +0000 (05:29 +0000)]
Date constructor handles infinite values incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=70998

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

* runtime/DateConstructor.cpp:
(JSC::constructDate):
    - should be checking !finite rather then isnan.

LayoutTests:

* fast/js/date-constructor-expected.txt:
* fast/js/script-tests/date-constructor.js:
    - Added test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agodate.toISOString produces incorrect results for dates with ms prior to 1970
barraclough@apple.com [Fri, 6 Jan 2012 04:48:14 +0000 (04:48 +0000)]
date.toISOString produces incorrect results for dates with ms prior to 1970
https://bugs.webkit.org/show_bug.cgi?id=75684

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* runtime/DatePrototype.cpp:
(JSC::dateProtoFuncToISOString):

LayoutTests:

* fast/js/date-toisostring-expected.txt:
* fast/js/script-tests/date-toisostring.js:
    - Added test case

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOptimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis
commit-queue@webkit.org [Fri, 6 Jan 2012 04:01:23 +0000 (04:01 +0000)]
Optimize with memcpy instead of copying frame by frame in Realtimeanalyser::doFFTAnalysis
https://bugs.webkit.org/show_bug.cgi?id=74693

Patch by Wei James <james.wei@intel.com> on 2012-01-05
Reviewed by Kenneth Russell.

* webaudio/RealtimeAnalyser.cpp:
(WebCore::RealtimeAnalyser::doFFTAnalysis):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDon't hardcode expected file URIs in as they depend on the platform
jochen@chromium.org [Fri, 6 Jan 2012 03:20:50 +0000 (03:20 +0000)]
Don't hardcode expected file URIs in as they depend on the platform
https://bugs.webkit.org/show_bug.cgi?id=75666

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/win.py:
(WinPort.show_results_html_file):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_unexpected_failures):
(MainTest.test_results_directory_default):
(MainTest.test_results_directory_relative):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(r104210): Dromaeo DOM test score is lower
rniwa@webkit.org [Fri, 6 Jan 2012 03:14:05 +0000 (03:14 +0000)]
REGRESSION(r104210): Dromaeo DOM test score is lower
https://bugs.webkit.org/show_bug.cgi?id=75679

Reviewed by Andreas Kling.

The regression was caused by isDomVersionConsistent not being able to obtain the tree version
inside isLengthCacheValid when m_cachedItem is null. Fix the regression by always setting
m_cachedItem to some node when caching the length so that we can obtain the tree version later.

Also address Antti's review comment to fit m_cachedLength, m_isLengthCacheValid, and
m_isItemCacheValid all in 32-bit.

* dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMore chromium expected results after r104208.
ojan@chromium.org [Fri, 6 Jan 2012 03:10:09 +0000 (03:10 +0000)]
More chromium expected results after r104208.

* platform/chromium-cg-mac-leopard/fast/table/032-expected.png: Added.
* platform/chromium-mac-leopard/fast/table/032-expected.txt: Removed.
* platform/chromium-win-xp/fast/table/032-expected.png:
* platform/chromium-win-xp/fast/table/032-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed bad merge fix for r104259 which dropped a line from r104210.
morrita@google.com [Fri, 6 Jan 2012 02:46:13 +0000 (02:46 +0000)]
Unreviewed bad merge fix for r104259 which dropped a line from r104210.

* dom/TreeScopeAdopter.cpp:
(WebCore::TreeScopeAdopter::moveTreeToNewScope):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=75593
commit-queue@webkit.org [Fri, 6 Jan 2012 02:13:29 +0000 (02:13 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75593
Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-01-05
Reviewed by Alexey Proskuryakov.

Null-check 'page' variable before use, to follow the common usage pattern of m_frame->page()
throughout the rest of FrameView.cpp.

* page/FrameView.cpp:
(WebCore::FrameView::notifyPageThatContentAreaWillPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Refactoring] Moving between TreeScopes should be done by its own class.
morrita@google.com [Fri, 6 Jan 2012 01:58:34 +0000 (01:58 +0000)]
[Refactoring] Moving between TreeScopes should be done by its own class.
https://bugs.webkit.org/show_bug.cgi?id=75290

Reviewed by Ryosuke Niwa.

This change extracted Node::setTreeScopeRecursively(),
setDocumentRecursively() and a part of setDocument() into a new
class called TreeScopeAdopter. By doing this, the idea of
moving a node from scope to scope, that was originally hidden
behind the forest of Node APIs, has become clearer.

Note that this change is a preparation for Bug 59816.

No new tests. No behavioral change.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/ContainerNode.cpp: Followed the renaming.
(WebCore::ContainerNode::takeAllChildrenFrom):
(WebCore::ContainerNode::insertBefore):
(WebCore::ContainerNode::replaceChild):
(WebCore::ContainerNode::removeBetween):
(WebCore::ContainerNode::removeChildren):
(WebCore::ContainerNode::appendChild):
(WebCore::ContainerNode::parserAddChild):
* dom/DOMAllInOne.cpp:
* dom/Document.cpp: Followed te renaming.
(WebCore::Document::setDocType):
(WebCore::Document::adoptNode):
* dom/Element.cpp: Followed te renaming.
(WebCore::Element::removeShadowRoot):
* dom/Node.cpp:
(WebCore::Node::setDocument):
(WebCore::Node::setTreeScope):
(WebCore::Node::didMoveToNewDocument):
* dom/Node.h:
* dom/TreeScope.h:
* dom/TreeScope.cpp:
(WebCore::TreeScope::adoptIfNeeded): moved from setTreeScopeRecursively()
* dom/TreeScopeAdopter.cpp: Added.
(WebCore::TreeScopeAdopter::TreeScopeAdopter):
(WebCore::TreeScopeAdopter::moveTreeToNewScope):
(WebCore::TreeScopeAdopter::moveTreeToNewDocument):
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::moveNodeToNewDocument):
* dom/TreeScopeAdopter.h: Added.
(WebCore::TreeScopeAdopter::ensureDidMoveToNewDocumentWasCalled):
(WebCore::TreeScopeAdopter::execute):
(WebCore::TreeScopeAdopter::needsScopeChange()):
(WebCore::TreeScopeAdopter::shadowRootFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoArray.prototype.lastIndexOf ignores undefined fromIndex.
barraclough@apple.com [Fri, 6 Jan 2012 01:37:39 +0000 (01:37 +0000)]
Array.prototype.lastIndexOf ignores undefined fromIndex.
https://bugs.webkit.org/show_bug.cgi?id=75678

Reviewed by Sam Weinig.

Source/JavaScriptCore:

array.lastIndexOf(x, undefined) is equivalent to array.lastIndexOf(x, 0), not array.lastIndexOf(x)

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncLastIndexOf):
    - should check argumnet count, rather than checking agument value for undefined.

LayoutTests:

* ietestcenter/Javascript/15.4.4.15-5-4-expected.txt:
    - check in passing result

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: Disallow access to DOM storage from detached frames.
jochen@chromium.org [Fri, 6 Jan 2012 01:32:45 +0000 (01:32 +0000)]
Source/WebCore: Disallow access to DOM storage from detached frames.
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

* storage/StorageAreaImpl.cpp:
(WebCore::StorageAreaImpl::disabledByPrivateBrowsingInFrame):

Source/WebKit/chromium: Check whether a WebView exists before accessing it in StorageAreaProxy. This is not necessarily the case, e.g. for detached iframes.
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

* src/StorageAreaProxy.cpp:
(WebCore::StorageAreaProxy::canAccessStorage):

LayoutTests: Unskip fast/storage/storage-detached-iframe.html on chromium
https://bugs.webkit.org/show_bug.cgi?id=61326

Reviewed by Adam Barth.

* fast/storage/storage-detached-iframe-expected.txt:
* fast/storage/storage-detached-iframe.html:
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
lforschler@apple.com [Fri, 6 Jan 2012 01:32:00 +0000 (01:32 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][Texmap] Convert shaders in TextureMapperGL to use a macro
noam.rosenthal@nokia.com [Fri, 6 Jan 2012 01:29:15 +0000 (01:29 +0000)]
[Qt][Texmap] Convert shaders in TextureMapperGL to use a macro
https://bugs.webkit.org/show_bug.cgi?id=75598

Use VERTEX_SHADER() and FRAGMENT_SHADER() macros, instead of quoted string literals when
declaring shaders in TextureMapperGL.

We need two macros to account for the differences between OpenGL and OpenGL ES2.

Reviewed by Martin Robinson.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agosizeof(CSSRule) is 20 instead of 12 on Windows
rniwa@webkit.org [Fri, 6 Jan 2012 01:19:42 +0000 (01:19 +0000)]
sizeof(CSSRule) is 20 instead of 12 on Windows
https://bugs.webkit.org/show_bug.cgi?id=75665

Reviewed by Darin Fisher.

Unlike gcc and clang, MSVC pads each consecutive member variables of the same type
in bitfields. e.g. if you have:

sturct AB {
unsigned m_1 : 31;
bool m_2 : 1;
}

then MSVC pads m_1 and allocates sizeof(unsigned) * 2 for AB whereas gcc and clang
only allocate sizeof(unsigned) * 1 for AB.

Fix the bloat by turning all bitfields in CSSRule either signed or unsigned integers.

* css/CSSRule.cpp:
* css/CSSRule.h:
(WebCore::CSSRule::sourceLine):
(WebCore::CSSRule::setSourceLine):
(WebCore::CSSRule::hasCachedSelectorText):
(WebCore::CSSRule::setHasCachedSelectorText):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::CSSStyleRule):
(WebCore::CSSStyleRule::cleanup):
(WebCore::CSSStyleRule::selectorText):
(WebCore::CSSStyleRule::setSelectorText):
* css/CSSStyleRule.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/WebCore: IndexedDB: fix cursor prefetch crash
dgrogan@chromium.org [Fri, 6 Jan 2012 01:15:29 +0000 (01:15 +0000)]
Source/WebCore: IndexedDB: fix cursor prefetch crash
http://crbug.com/108071
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

Test: storage/indexeddb/prefetch-bugfix-108071.html
Note: DumpRenderTree doesn't exercise the bug, it only occurs in
multi-process chromium.  The layout test will soon be run as a
chromium ui test: http://codereview.chromium.org/9108004

* storage/IDBCursorBackendImpl.cpp:
(WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
(WebCore::IDBCursorBackendImpl::~IDBCursorBackendImpl): Destroy
cursors before their objectstores.
(WebCore::IDBCursorBackendImpl::prefetchReset): Don't run continue if
the cursor is closed.
(WebCore::IDBCursorBackendImpl::close): Set a closed flag.
* storage/IDBCursorBackendImpl.h:

LayoutTests: IndexedDB: fix cursor prefetch crash
https://bugs.webkit.org/show_bug.cgi?id=75596

Reviewed by Tony Chang.

* storage/indexeddb/prefetch-bugfix-108071-expected.txt: Added.
* storage/indexeddb/prefetch-bugfix-108071.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDate parsing is too restrictive.
barraclough@apple.com [Fri, 6 Jan 2012 01:08:34 +0000 (01:08 +0000)]
Date parsing is too restrictive.
https://bugs.webkit.org/show_bug.cgi?id=75671

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

ES5 date parsing currently requires all fields to be present, which does not match the spec (ES5.1 15.9.1.15).
The spec allow a date to be date only, or date + time.

The date portion on the should match: (pseudocode!:)
    [(+|-)YY]YYYY[-MM[-DD]]
though we are slightly more liberal (permitted by the spec), allowing:
    [+|-]Y+[-MM[-DD]]
The time portion should match:
    THH:mm[:ss[.sss]][Z|(+|-)HH:mm]
again we're slightly more liberal, allowing:
    THH:mm[:ss[.s+]][Z|(+|-)HH:mm]

* wtf/DateMath.cpp:
(WTF::parseES5DatePortion):
    - Month/day fields are optional, default to 01.
(WTF::parseES5TimePortion):
    - Hours/Minutes are requires, seconds/timezone are optional.
(WTF::parseES5DateFromNullTerminatedCharacters):
    - Dates may be date only, or date + time.

LayoutTests:

* fast/js/date-parse-test-expected.txt:
* fast/js/script-tests/date-parse-test.js:
    - Add more test cases for Date.parse.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Route all animate calls through CCLayerTreeHost in composited mode to...
jamesr@google.com [Fri, 6 Jan 2012 01:01:33 +0000 (01:01 +0000)]
[chromium] Route all animate calls through CCLayerTreeHost in composited mode to simplify rate limiting logic
https://bugs.webkit.org/show_bug.cgi?id=75577

Reviewed by Darin Fisher.

Source/WebCore:

This internalizes the animation rate limiting logic to CCLayerTreeHost and removes the setters/getters for the
m_animating flag. This requires that all animation updates have to go through CCLayerTreeHost to get the right
rate limiting behavior, regardless of which proxy is being used.

* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::updateAnimations):
(WebCore::CCLayerTreeHost::layout):
(WebCore::CCLayerTreeHost::startRateLimiter):
* platform/graphics/chromium/cc/CCLayerTreeHost.h:
* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::beginFrameAndCommit):

Source/WebKit/chromium:

Routes WebWidget-initiated animate() calls through the CCLayerTreeHost in composited mode. CCLayerTreeHost's
rate limiting logic needs to be aware of when requestAnimationFrame callbacks are run. In threaded mode, the
animate calls are driven from CCThreadProxy and so the CCLayerTreeHost can set whatever state it needs. This
makes the single-threaded mode where the animate calls are driven through the WebWidget interface outside of the
CCProxy's control.

This is a small step towards inverting the scheduling control from the WebWidget to the compositor.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animate):
(WebKit::WebViewImpl::updateAnimations):
* src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] NativeImageSkia should mark SkBitmaps as immutable
commit-queue@webkit.org [Fri, 6 Jan 2012 00:44:16 +0000 (00:44 +0000)]
[Chromium] NativeImageSkia should mark SkBitmaps as immutable
https://bugs.webkit.org/show_bug.cgi?id=74962

Removed m_isDataComplete from class NativeImageSkia. Instead, data
completeness will be tracked through SkBitmap::setImmutable/
isImmutable.  The immutable state signifies that the pixel data
will no longer change for the lifetime of the bitmap, which corresponds
to the semantic of the old m_isDataComplete member. setImmutable is
also called on the cached resized bitmap, since it too is invariant for
its life time. Temporary resized bitmaps are also marked as immutable
since they technically are.

Patch by Justin Novosad <junov@chromium.org> on 2012-01-05
Reviewed by Stephen White.

* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::resizedBitmap):
(WebCore::NativeImageSkia::shouldCacheResampling):
* platform/graphics/skia/NativeImageSkia.h:
(WebCore::NativeImageSkia::setDataComplete):
(WebCore::NativeImageSkia::isDataComplete):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMark flaky test as flaky. Filed
abarth@webkit.org [Fri, 6 Jan 2012 00:42:10 +0000 (00:42 +0000)]
Mark flaky test as flaky.  Filed
https://bugs.webkit.org/show_bug.cgi?id=75647 about making it not
flaky.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r104231.
abarth@webkit.org [Fri, 6 Jan 2012 00:39:16 +0000 (00:39 +0000)]
Unreviewed, rolling out r104231.
http://trac.webkit.org/changeset/104231
https://bugs.webkit.org/show_bug.cgi?id=75668

Breaks the Qt build (Requested by abarth on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-05

Source/WebCore:

* platform/SchemeRegistry.cpp:
* platform/SchemeRegistry.h:

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::acceptNavigationRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Resize requests at the view level should be ignored when in autoresize...
levin@chromium.org [Fri, 6 Jan 2012 00:32:25 +0000 (00:32 +0000)]
[chromium] Resize requests at the view level should be ignored when in autoresize mode.
https://bugs.webkit.org/show_bug.cgi?id=75651

Reviewed by Dmitry Titov.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::resize): The assert was here to catch a view that
tried to do a resize after setting autoresize. However, we found that generic
code tries to do resizes as well. Rather than special case each caller,
we'll just make this code ignore the resize call.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=75654
bdakin@apple.com [Fri, 6 Jan 2012 00:30:50 +0000 (00:30 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=75654
Text fields should draw using NSTextFieldCell instead of WebKitSystemInterface

Reviewed by John Sullivan.

This change should not have any affect on tests or real web sites. It just changed
the implementation under the hood to the more modern NSCell approach.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintTextField):
(WebCore::RenderThemeMac::textField):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
andersca@apple.com [Fri, 6 Jan 2012 00:29:14 +0000 (00:29 +0000)]
Crash when trying to invalidate the NPRuntimeObjectMap for a plug-in in a subframe
https://bugs.webkit.org/show_bug.cgi?id=75667
<rdar://problem/10389454>

Reviewed by Kevin Decker.

Source/WebKit2:

NPRuntimeObjectMap::invalidate is called whenever a plug-in view is destroyed. If invalidate is called for an object map
whose plug-in has a null frame, we'd crash.

The plug-in will have a null frame if the plug-in view is destroyed because its containing frame has been removed from the document,
and if the plug-in view is being destroyed asynchronously due to the plug-in itself calling JavaScript that will remove the frame
(see PluginView::unprotectPluginFromDestruction).

The reason NPRuntimeObjectMap::invalidate will crash when the frame is null is because we were trying to access the frame's global
object, causing a null dereference. The reason we were trying to get at the frame's global object was to create a Strong handle to
a JSNPObject so we could stick the object in a vector so we could later iterate over the vector elements and call invalidate() on
each JSNPObject which will end up releasing the underlying NPObject.

However, it turns out that we don't need to stick the JSNPObject in a vector; we can just get the underlying NPObject directly and
stick that in a vector and then iterate over the NPObjects, releasing them.

* WebProcess/Plugins/Netscape/NPRuntimeObjectMap.cpp:
(WebKit::NPRuntimeObjectMap::invalidate):

Tools:

Add an evaluate method to the plug-in test scriptable object that can be used to evaluate a given JS string.

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::executeScript):
* DumpRenderTree/TestNetscapePlugIn/PluginTest.h:
* DumpRenderTree/TestNetscapePlugIn/Tests/NPRuntimeObjectFromDestroyedPlugin.cpp:
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasMethod):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::invoke):
(NPRuntimeObjectFromDestroyedPlugin::ScriptableObject::hasProperty):

LayoutTests:

* plugins/npruntime/object-from-destroyed-plugin-in-subframe-expected.txt: Added.
* plugins/npruntime/object-from-destroyed-plugin-in-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a compile-time assertion for the size of CSSValue
rniwa@webkit.org [Fri, 6 Jan 2012 00:01:07 +0000 (00:01 +0000)]
Add a compile-time assertion for the size of CSSValue
https://bugs.webkit.org/show_bug.cgi?id=75635

Reviewed by Tony Chang.

Tightened the compile-time assertion.

* css/CSSValue.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Undefined references to ICU_I18N symbols on WTF
commit-queue@webkit.org [Thu, 5 Jan 2012 23:59:31 +0000 (23:59 +0000)]
[EFL] Undefined references to ICU_I18N symbols on WTF
https://bugs.webkit.org/show_bug.cgi?id=75642

Unreviewed build fix.

Add ${ICU_I18N_LIBRARIES} to WTF_LIBRARIES on wtf efl platform cmake.
Some undefined references were ucol_setAttribute_44, ucol_close_44,
ucol_getAttribute_44...

Patch by Bruno Dilly <bdilly@profusion.mobi> on 2012-01-05

* wtf/PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[V8] CodeGeneration for SerializedScriptValue doesn't play nice with [Constructor]
abarth@webkit.org [Thu, 5 Jan 2012 23:57:26 +0000 (23:57 +0000)]
[V8] CodeGeneration for SerializedScriptValue doesn't play nice with [Constructor]
https://bugs.webkit.org/show_bug.cgi?id=75641

Reviewed by David Levin.

Rather than generate getters for SerializedScriptValues, we eagerly
deserialize them into JavaScript objects.  However, previously, we were
only doing that for DOM wrappers created by taking an existing C++
object and wrapping it.  For objects created with Constructors (e.g.,
those with the [Constructor] attribute), we need to do this eager
deserialization during the constructor as well.

This bug isn't observable yet, but it is causing the WebIntent test
being added in Bug 73051 to fail.

Test: TestSerializedScriptValueInterface.idl
      webintents/web-intents-api.html (after Bug 73051 lands)

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateEagerDeserialization):
(GenerateConstructorCallback):
(GenerateNamedConstructorCallback):
(GenerateImplementation):
(GenerateToV8Converters):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.cpp:
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::constructJSTestSerializedScriptValueInterface):
(WebCore::JSTestSerializedScriptValueInterfaceConstructor::getConstructData):
* bindings/scripts/test/JS/JSTestSerializedScriptValueInterface.h:
* bindings/scripts/test/TestSerializedScriptValueInterface.idl:
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::constructorCallback):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructorConstructorCallback):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::constructorCallback):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::constructorCallback):
(WebCore::ConfigureV8TestSerializedScriptValueInterfaceTemplate):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNew chromium expected results after r104208.
ojan@chromium.org [Thu, 5 Jan 2012 23:45:08 +0000 (23:45 +0000)]
New chromium expected results after r104208.

* platform/chromium-linux/fast/table/032-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug55694-expected.png:
* platform/chromium-mac-leopard/fast/table/032-expected.png:
* platform/chromium-mac-leopard/fast/table/032-expected.txt: Added.
* platform/chromium-mac-leopard/tables/mozilla/bugs/bug55694-expected.png:
* platform/chromium-mac-snowleopard/tables/mozilla/bugs/bug55694-expected.png: Added.
* platform/chromium-mac/tables/mozilla/bugs/bug55694-expected.png: Removed.
* platform/chromium-win-xp/fast/table/032-expected.png: Added.
* platform/chromium-win-xp/fast/table/032-expected.txt: Renamed from LayoutTests/platform/chromium-win/fast/table/032-expected.txt.
* platform/chromium-win/fast/table/032-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug55694-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug55694-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce Platform namespace for WebCore/platform
abarth@webkit.org [Thu, 5 Jan 2012 23:11:45 +0000 (23:11 +0000)]
Introduce Platform namespace for WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=75653

Reviewed by Eric Seidel.

Source/WebCore:

This patch introduces the Platform namespace for WebCore/platform.
Introducing this namespace will help us find and fix layering
violations in preparation for moving WebCore/platform to Platform.

* platform/SchemeRegistry.cpp:
* platform/SchemeRegistry.h:

Source/WebKit/qt:

* Api/qwebpage.cpp:
(QWebPage::acceptNavigationRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkitpy: clean up port factory methods
dpranke@chromium.org [Thu, 5 Jan 2012 23:07:33 +0000 (23:07 +0000)]
webkitpy: clean up port factory methods
https://bugs.webkit.org/show_bug.cgi?id=75590

Reviewed by Eric Seidel.

This change consolidates much of the "factory method" logic
of determining which port objects to create for a given set
of configurations by merging the separate factory methods in
chromium_gpu and google_chrome into PortFactory so that at least
all of the logic is in one place.

* Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
* Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
* Scripts/webkitpy/layout_tests/port/factory.py:
(_port_name_from_arguments_and_options):
(get):
* Scripts/webkitpy/layout_tests/port/factory_unittest.py:
(test_google_chrome):
* Scripts/webkitpy/layout_tests/port/google_chrome.py:
(GoogleChromeLinux32Port):
(GoogleChromeLinux32Port.baseline_search_path):
(test_expectations_overrides):
(architecture):
(GoogleChromeLinux64Port):
(GoogleChromeLinux64Port.baseline_search_path):
(GoogleChromeMacPort):
(GoogleChromeMacPort.baseline_search_path):
(GoogleChromeWinPort):
(GoogleChromeWinPort.baseline_search_path):
* Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
(_verify_baseline_path):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r98912-r99538): Crash in WebKit::WebFrameLoaderClient::didDetectXSS
ap@apple.com [Thu, 5 Jan 2012 23:04:25 +0000 (23:04 +0000)]
REGRESSION (r98912-r99538): Crash in WebKit::WebFrameLoaderClient::didDetectXSS
https://bugs.webkit.org/show_bug.cgi?id=75578

Reviewed by Daniel Bates.

* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didDetectXSSForFrame):
Check for a correct struct member existence.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefined the fast path for StringImpl::hash()
ggaren@apple.com [Thu, 5 Jan 2012 22:30:50 +0000 (22:30 +0000)]
Refined the fast path for StringImpl::hash()
https://bugs.webkit.org/show_bug.cgi?id=75178

Reviewed by Darin Adler.

Moved the hash calculation code into an out-of-line function to clean up
the hot path.

No measurable benchmark change, but this knocks some samples off in
Instruments, and I think this is a step toward removing -fomit-frame-pointer.

* wtf/text/StringImpl.cpp:
(WTF::StringImpl::hashSlowCase):
* wtf/text/StringImpl.h:
(WTF::StringImpl::hash): The patch.

* wtf/text/StringStatics.cpp:
(WTF::StringImpl::hashSlowCase): Abide by the cockamamie Windows build
scheme, which requires all out-of-line StringImpl functions used by
WebCore be defined in this file instead of StringImpl.cpp. (See http://trac.webkit.org/changeset/59187.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed: Updating expecxtations for fast/media/viewport-media-query.
dslomov@google.com [Thu, 5 Jan 2012 22:29:07 +0000 (22:29 +0000)]
Unreviewed: Updating expecxtations for fast/media/viewport-media-query.
My understanding of the semantics was a bit off.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoLiteral tab in JSONString fails
barraclough@apple.com [Thu, 5 Jan 2012 21:56:26 +0000 (21:56 +0000)]
Literal tab in JSONString fails
https://bugs.webkit.org/show_bug.cgi?id=71772

Reviewed by Oliver Hunt.

rfc4627 does not allow literal tab characters in JSON source.

Source/JavaScriptCore:

* runtime/LiteralParser.cpp:
(JSC::isSafeStringCharacter):
    - do not allow literal tab in StrictJSON mode.

LayoutTests:

* fast/js/JSON-parse-expected.txt:
* fast/js/resources/JSON-parse.js:
(createTests.result):
    - Updated expected results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInserting nodes is slow due to Node::notifyNodeListsAttributeChanged (20%+)
rniwa@webkit.org [Thu, 5 Jan 2012 21:48:50 +0000 (21:48 +0000)]
Inserting nodes is slow due to Node::notifyNodeListsAttributeChanged (20%+)
https://bugs.webkit.org/show_bug.cgi?id=73853

Reviewed by Antti Koivisto.

Lazily invalidate the node list caches instead of invaliding them at the time of modification. We use
the DOM tree version to detect whether caches need to be invalidated or not. We now invalidate caches more
frequently after this patch (in particular, invalidates caches that are stored on nodes not present in
the ancestry of the modified nodes); however, our study on major Web sites such as Gmail, Facebook, Twitter,
etc... indicate that about 1% of real-world usage benefits from keeping the caches alive across different
DOM tree versions.

In order to invalidate caches lazily, this patch adds replaces the type of m_caches in DynamicSubtreeNodeList
by DynamicSubtreeNodeList::SubtreeCaches which encapsulates member variables in DynamicNodeList::Caches and
invalidates values as needed. Also this change allows m_caches to be allocated as a part of
DynamicSubtreeNodeList instead of a separate ref-counted object.

* dom/Attr.cpp:
(WebCore::Attr::setValue):
(WebCore::Attr::childrenChanged):
* dom/DynamicNodeList.cpp:
(WebCore::DynamicSubtreeNodeList::DynamicSubtreeNodeList):
(WebCore::DynamicSubtreeNodeList::length):
(WebCore::DynamicSubtreeNodeList::itemForwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::itemBackwardsFromCurrent):
(WebCore::DynamicSubtreeNodeList::item):
(WebCore::DynamicSubtreeNodeList::invalidateCache):
(WebCore::DynamicNodeList::Caches::create):
(WebCore::DynamicNodeList::Caches::reset):
* dom/DynamicNodeList.h:
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::SubtreeCaches): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isLengthCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::isItemCacheValid): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedLength): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItem): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::cachedItemOffset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setLengthCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::setItemCache): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::reset): Added.
(WebCore::DynamicSubtreeNodeList::SubtreeCaches::domVersionIsConsistent): Added.
* dom/Element.cpp:
(WebCore::Element::updateAfterAttributeChanged):
* dom/Node.cpp:
(WebCore::Node::setTreeScopeRecursively): Clear caches when a node moves from one document to another.
(WebCore::Node::invalidateNodeListsCacheAfterAttributeChanged): Only clears child node list of Attr.
(WebCore::Node::invalidateNodeListsCacheAfterChildrenChanged): Only clears child node list.
(WebCore::NodeListsNodeData::invalidateCaches): Merged with invalidateCachesThatDependOnAttributes.
* dom/Node.h:
* dom/NodeRareData.h:
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute):
* html/HTMLLabelElement.cpp:
* html/HTMLLabelElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium][aura] WebExternalTextureLayerImpl::drawsContent() returns incorrect value...
wjmaclean@chromium.org [Thu, 5 Jan 2012 21:41:04 +0000 (21:41 +0000)]
[chromium][aura] WebExternalTextureLayerImpl::drawsContent() returns incorrect value, causing accelerated content to not display in Aura desktop
https://bugs.webkit.org/show_bug.cgi?id=75551

Reviewed by James Robinson.

* WebKit.gypi:
* src/WebExternalTextureLayerImpl.cpp:
(WebKit::WebExternalTextureLayerImpl::WebExternalTextureLayerImpl):
* tests/WebExternalTextureLayerImplTest.cpp: Copied from Source/WebKit/chromium/src/WebExternalTextureLayerImpl.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIE quirk for percentage size on a table element doesn't work with orthogonal writing...
ojan@chromium.org [Thu, 5 Jan 2012 21:39:02 +0000 (21:39 +0000)]
IE quirk for percentage size on a table element doesn't work with orthogonal writing modes
https://bugs.webkit.org/show_bug.cgi?id=70195

Reviewed by Eric Seidel.

Source/WebCore:

Remove this quirk entirely. Mozilla and Opera don't implement it and IE
doesn't restrict the quirk to standards mode. As it's unlikely for
webkit-only content to hit this quirk (e.g. use tables for layout),
it should be relatively safe to match Mozilla/Opera here.

Test: fast/writing-mode/table-percent-width-quirk.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeBlockPreferredLogicalWidths):

LayoutTests:

* fast/table/032.html:
* fast/writing-mode/table-percent-width-quirk-expected.png: Added.
* fast/writing-mode/table-percent-width-quirk-expected.txt: Added.
* fast/writing-mode/table-percent-width-quirk.html: Added.
* platform/mac/fast/table/032-expected.png:
* platform/mac/fast/table/032-expected.txt:
* platform/mac/tables/mozilla/bugs/bug55694-expected.png:
* platform/mac/tables/mozilla/bugs/bug55694-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.syste...
jochen@chromium.org [Thu, 5 Jan 2012 21:25:23 +0000 (21:25 +0000)]
Replace webkitpy.common.system.filesystem.file_path_as_url with webkitpy.common.system.path.abspath_to_uri
https://bugs.webkit.org/show_bug.cgi?id=75617

Reviewed by Dirk Pranke.

* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.exists):
* Scripts/webkitpy/common/system/filesystem_mock.py:
(MockFileSystem.exists):
* Scripts/webkitpy/common/system/filesystem_unittest.py:
(GenericFileSystemTests.teardown_generic_test_dir):
* Scripts/webkitpy/layout_tests/port/base.py:
(Port.to.show_results_html_file):
* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_results_directory_absolute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Add CCTimer class for the compositor
nduca@chromium.org [Thu, 5 Jan 2012 20:53:18 +0000 (20:53 +0000)]
[chromium] Add CCTimer class for the compositor
https://bugs.webkit.org/show_bug.cgi?id=74769

Patch by Tien Ren Chen <trchen@chromium.org> on 2012-01-05
Reviewed by James Robinson.

Add a simple timer class for CCThread that the timered task can be
manually cancelled.

Source/WebCore:

* WebCore.gypi:
* platform/graphics/chromium/cc/CCTimer.cpp: Added.
(WebCore::CCTimerTask::CCTimerTask):
(WebCore::CCTimerTask::~CCTimerTask):
(WebCore::CCTimerTask::performTask):
(WebCore::CCTimer::CCTimer):
(WebCore::CCTimer::~CCTimer):
(WebCore::CCTimer::startOneShot):
(WebCore::CCTimer::stop):
* platform/graphics/chromium/cc/CCTimer.h: Added.
(WebCore::CCTimerClient::~CCTimerClient):
(WebCore::CCTimer::isActive):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/CCTimerTest.cpp: Added.
(WebKitTests::CCTimerTest::CCTimerTest):
(WebKitTests::CCTimerTest::onTimerFired):
(WebKitTests::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago WK2: Safari fails to open a PostScript file in Preview from context menu
ap@apple.com [Thu, 5 Jan 2012 20:48:17 +0000 (20:48 +0000)]
    WK2: Safari fails to open a PostScript file in Preview from context menu
        https://bugs.webkit.org/show_bug.cgi?id=75643
        <rdar://problem/9823430>

        Reviewed by Dan Bernstein.

        * UIProcess/API/mac/PDFViewController.mm: (WebKit::PDFViewController::setPDFDocumentData):
        Append ".pdf" to file name when converting data, as suggested file name is created for
        original MIME type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement temporal dimension portion of Media Fragments URI specification for video...
eric.carlson@apple.com [Thu, 5 Jan 2012 20:44:57 +0000 (20:44 +0000)]
Implement temporal dimension portion of Media Fragments URI specification for video/audio
https://bugs.webkit.org/show_bug.cgi?id=65838

Reviewed by Sam Weinig.

Source/WebCore:

Tests: media/media-fragments/TC0001-TC0009.html
       media/media-fragments/TC0010-TC0019.html
       media/media-fragments/TC0020-TC0029.html
       media/media-fragments/TC0030-TC0039.html
       media/media-fragments/TC0040-TC0049.html
       media/media-fragments/TC0050-TC0059.html
       media/media-fragments/TC0060-TC0069.html
       media/media-fragments/TC0070-TC0079.html
       media/media-fragments/TC0080-TC0089.html
       media/media-fragments/TC0090-TC0099.html

* CMakeLists.txt: Add fragment parser files.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_fragmentStartTime and m_fragmentEndTime.
(WebCore::HTMLMediaElement::setReadyState): Check for and parse a media fragment once readyState
    reaches HAVE_METADATA, apply it once it reaches HAVE_CURRENT_DATA.
(WebCore::HTMLMediaElement::initialTime): Return the fragment start time if possible.
(WebCore::HTMLMediaElement::playbackProgressTimerFired): Pause if the time is >= the fragment
    end time.
(WebCore::HTMLMediaElement::prepareMediaFragmentURI): Look for a temporal fragment.
(WebCore::HTMLMediaElement::applyMediaFragmentURI): Apply the fragment, if any.
* html/HTMLMediaElement.h:

* html/MediaFragmentURIParser.cpp: Added.
(WebCore::skipWhiteSpace):
(WebCore::collectDigits):
(WebCore::collectFraction):
(WebCore::MediaFragmentURIParser::invalidTimeValue):
(WebCore::MediaFragmentURIParser::MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::startTime):
(WebCore::MediaFragmentURIParser::endTime):
(WebCore::MediaFragmentURIParser::parseFragments):
(WebCore::MediaFragmentURIParser::parseTimeFragment):
(WebCore::MediaFragmentURIParser::parseNPTFragment):
(WebCore::MediaFragmentURIParser::parseNPTTime):
* html/MediaFragmentURIParser.h: Added.
(WebCore::MediaFragmentURIParser::~MediaFragmentURIParser):
(WebCore::MediaFragmentURIParser::create):

LayoutTests:

* media/media-fragments: Added.
* media/media-fragments/TC0001-TC0009-expected.txt: Added.
* media/media-fragments/TC0001-TC0009.html: Added.
* media/media-fragments/TC0010-TC0019-expected.txt: Added.
* media/media-fragments/TC0010-TC0019.html: Added.
* media/media-fragments/TC0020-TC0029-expected.txt: Added.
* media/media-fragments/TC0020-TC0029.html: Added.
* media/media-fragments/TC0030-TC0039-expected.txt: Added.
* media/media-fragments/TC0030-TC0039.html: Added.
* media/media-fragments/TC0040-TC0049-expected.txt: Added.
* media/media-fragments/TC0040-TC0049.html: Added.
* media/media-fragments/TC0050-TC0059-expected.txt: Added.
* media/media-fragments/TC0050-TC0059.html: Added.
* media/media-fragments/TC0060-TC0069-expected.txt: Added.
* media/media-fragments/TC0060-TC0069.html: Added.
* media/media-fragments/TC0070-TC0079-expected.txt: Added.
* media/media-fragments/TC0070-TC0079.html: Added.
* media/media-fragments/TC0080-TC0089-expected.txt: Added.
* media/media-fragments/TC0080-TC0089.html: Added.
* media/media-fragments/TC0090-TC0099-expected.txt: Added.
* media/media-fragments/TC0090-TC0099.html: Added.

* media/media-fragments/media-fragments.js: Added.
(canplaythrough):
(setupNextTest):
(nextTestName):
(start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[v8] Null pointer exception if a typed array constructor set to a primitive value.
commit-queue@webkit.org [Thu, 5 Jan 2012 20:41:16 +0000 (20:41 +0000)]
[v8] Null pointer exception if a typed array constructor set to a primitive value.
https://bugs.webkit.org/show_bug.cgi?id=75532

Make sure that V8ArrayBufferViewCustomScript.js does not throw exception.

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-01-05
Reviewed by Kenneth Russell.

* LayoutTests/fast/canvas/webgl/array-buffer-view-crash-when-reassigned-expected.txt: Added.
* LayoutTests/fast/canvas/webgl/array-buffer-view-crash-when-reassigned.html: Added.
* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
* Source/WebCore/bindings/v8/custom/V8ArrayBufferViewCustomScript.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove some unnecessary code from old-run-webkit-tests
aroben@apple.com [Thu, 5 Jan 2012 20:28:48 +0000 (20:28 +0000)]
Remove some unnecessary code from old-run-webkit-tests

Thanks to r104187/r104188, we no longer need to set PATH before launching DumpRenderTree or
WebKitTestRunner.

Fixes <http://webkit.org/b/75640> ORWT unnecessarily sets PATH before launching DRT/WTR on
Windows

Reviewed by Eric Seidel.

* Scripts/old-run-webkit-tests:
(top level):
(openDumpTool):
Removed calls to setPathForRunningWebKitApp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] [AC] Introduce AcceleratedCompositingContext to isolate different accelerated...
mrobinson@webkit.org [Thu, 5 Jan 2012 20:18:59 +0000 (20:18 +0000)]
[GTK] [AC] Introduce AcceleratedCompositingContext to isolate different accelerated compositing implementations
https://bugs.webkit.org/show_bug.cgi?id=75519

Reviewed by Alejandro G. Castro.

Add an AcceleratedCompositingContext which will isolate all the different accelerated compositing
implementations from one another. For right now this just includes the Clutter version.

* GNUmakefile.am: Add the new files to the source list.
* WebCoreSupport/AcceleratedCompositingContext.h: Added.
* WebCoreSupport/AcceleratedCompositingContextClutter.cpp: Added. Existing
clutter AC code has moved here.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::attachRootGraphicsLayer): Use the new AccleratedCompositingContext now
instead of calling into the WebView.
(WebKit::ChromeClient::setNeedsOneShotDrawingSynchronization):Ditto.
(WebKit::ChromeClient::scheduleCompositingLayerSync): Ditto.
* webkit/webkitwebview.cpp:
(webkit_web_view_size_allocate): Call in the ACContext.
(webkit_web_view_init): Initialize the ACContext.
* webkit/webkitwebviewprivate.h: Add the ACContext as a private member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Implement custom URL schemes defined in QML.
zeno.albisser@nokia.com [Thu, 5 Jan 2012 20:04:33 +0000 (20:04 +0000)]
[Qt][WK2] Implement custom URL schemes defined in QML.
https://bugs.webkit.org/show_bug.cgi?id=74931

.:

Add new classes to the export map.

Reviewed by Kenneth Rohde Christiansen.

* Source/qtwebkit-export.map:

Source/WebKit/qt:

Make classes QQuickUrlSchemeDelegate, QQuickNetworkRequest
and QQuickNetworkReply accessible from QML.

Reviewed by Kenneth Rohde Christiansen.

* declarative/experimental/experimental.pri:
* declarative/experimental/plugin.cpp:
* declarative/public.pri:

Source/WebKit2:

Allow creation of custom UrlSchemeDelegates from QML.
A UrlSchemeDelegate contains a handler signal that is triggered
when a url matching the defined scheme is requested.
To allow for this a derivation of QNetworkAccessManager
is necessary.
The request is then handled in QML/JS and a reply
is sent back from the UIProcess to the WebProcess.

Reviewed by Kenneth Rohde Christiansen.

* Shared/qt/QtNetworkReplyData.cpp: Added.
(WebKit::QtNetworkReplyData::QtNetworkReplyData):
(WebKit::QtNetworkReplyData::encode):
(WebKit::QtNetworkReplyData::decode):
* Shared/qt/QtNetworkReplyData.h: Added.
* Shared/qt/QtNetworkRequestData.cpp: Added.
(WebKit::QtNetworkRequestData::QtNetworkRequestData):
(WebKit::QtNetworkRequestData::encode):
(WebKit::QtNetworkRequestData::decode):
* Shared/qt/QtNetworkRequestData.h: Added.
* Target.pri:
* UIProcess/API/qt/qquicknetworkreply.cpp: Added.
(QQuickNetworkReply::QQuickNetworkReply):
(QQuickNetworkReply::contentType):
(QQuickNetworkReply::setContentType):
(QQuickNetworkReply::operation):
(QQuickNetworkReply::setOperation):
(QQuickNetworkReply::contentDisposition):
(QQuickNetworkReply::setContentDisposition):
(QQuickNetworkReply::location):
(QQuickNetworkReply::setLocation):
(QQuickNetworkReply::lastModified):
(QQuickNetworkReply::setLastModified):
(QQuickNetworkReply::cookie):
(QQuickNetworkReply::setCookie):
(QQuickNetworkReply::userAgent):
(QQuickNetworkReply::setUserAgent):
(QQuickNetworkReply::server):
(QQuickNetworkReply::setServer):
(QQuickNetworkReply::data):
(QQuickNetworkReply::setData):
(QQuickNetworkReply::send):
(QQuickNetworkReply::networkRequestData):
(QQuickNetworkReply::setNetworkRequestData):
(QQuickNetworkReply::networkReplyData):
* UIProcess/API/qt/qquicknetworkreply_p.h: Added.
* UIProcess/API/qt/qquicknetworkrequest_p.h: Added.
* UIProcess/API/qt/qquickurlschemedelegate.cpp: Added.
(QQuickUrlSchemeDelegate::QQuickUrlSchemeDelegate):
(QQuickUrlSchemeDelegate::scheme):
(QQuickUrlSchemeDelegate::setScheme):
(QQuickUrlSchemeDelegate::request):
(QQuickUrlSchemeDelegate::reply):
* UIProcess/API/qt/qquickurlschemedelegate_p.h: Added.
* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::QQuickWebViewExperimental):
(QQuickWebViewExperimental::schemeDelegates_At):
(QQuickWebViewExperimental::schemeDelegates_Append):
(QQuickWebViewExperimental::schemeDelegates_Count):
(QQuickWebViewExperimental::schemeDelegates_Clear):
(QQuickWebViewExperimental::schemeDelegates):
(QQuickWebViewExperimental::invokeApplicationSchemeHandler):
(QQuickWebViewExperimental::sendApplicationSchemeReply):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/qt/QtPageClient.cpp:
(QtPageClient::handleApplicationSchemeRequest):
* UIProcess/qt/QtPageClient.h:
* UIProcess/qt/WebPageProxyQt.cpp:
(WebKit::WebPageProxy::registerApplicationScheme):
(WebKit::WebPageProxy::resolveApplicationSchemeRequest):
(WebKit::WebPageProxy::sendApplicationSchemeReply):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createNetworkingContext):
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.cpp:
* WebProcess/WebCoreSupport/qt/WebFrameNetworkingContext.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/qt/WebPageQt.cpp:
(WebKit::WebPage::registerApplicationScheme):
(WebKit::WebPage::receivedApplicationSchemeRequest):
(WebKit::WebPage::applicationSchemeReply):
* WebProcess/qt/QtNetworkAccessManager.cpp: Added.
(WebKit::QtNetworkAccessManager::QtNetworkAccessManager):
(WebKit::QtNetworkAccessManager::obtainOriginatingWebPage):
(WebKit::QtNetworkAccessManager::createRequest):
(WebKit::QtNetworkAccessManager::registerApplicationScheme):
* WebProcess/qt/QtNetworkAccessManager.h: Added.
* WebProcess/qt/QtNetworkReply.cpp: Added.
(WebKit::QtNetworkReply::QtNetworkReply):
(WebKit::QtNetworkReply::setData):
(WebKit::QtNetworkReply::setReplyData):
(WebKit::QtNetworkReply::readData):
(WebKit::QtNetworkReply::bytesAvailable):
(WebKit::QtNetworkReply::setHeader):
(WebKit::QtNetworkReply::abort):
(WebKit::QtNetworkReply::close):
(WebKit::QtNetworkReply::setReadBufferSize):
(WebKit::QtNetworkReply::canReadLine):
(WebKit::QtNetworkReply::finalize):
* WebProcess/qt/QtNetworkReply.h: Added.
* WebProcess/qt/WebProcessQt.cpp:
(WebKit::WebProcess::platformInitializeWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104193 268f45cc-cd09-0410-ab3c-d52691b4dbfc