WebKit-https.git
7 years agoRemove --shark* support from sunspider/run-sunspider now that Shark is dead
eric@webkit.org [Wed, 16 Jan 2013 19:25:40 +0000 (19:25 +0000)]
Remove --shark* support from sunspider/run-sunspider now that Shark is dead
https://bugs.webkit.org/show_bug.cgi?id=99512

Reviewed by Darin Adler.

PerformanceTests/SunSpider:

I tried to use --instruments, but that also seems broken (in the same way before/after this patch).

* sunspider:
(runTestsOnce):

Tools:

* Scripts/run-sunspider:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove webkitpy Visual Studio files, as core developers are not interested in maintai...
eric@webkit.org [Wed, 16 Jan 2013 19:23:08 +0000 (19:23 +0000)]
Remove webkitpy Visual Studio files, as core developers are not interested in maintaining them
https://bugs.webkit.org/show_bug.cgi?id=106036

Reviewed by Darin Adler.

* Scripts/webkitpy/webkitpy.pyproj: Removed.
* Scripts/webkitpy/webkitpy.sln: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Make a creationContext parameter of toV8() mandatory
haraken@chromium.org [Wed, 16 Jan 2013 19:21:40 +0000 (19:21 +0000)]
[V8] Make a creationContext parameter of toV8() mandatory
https://bugs.webkit.org/show_bug.cgi?id=107020

Reviewed by Adam Barth.

Source/WebCore:

Currently a creationContext parameter of toV8() is optional:

  Handle<Value> toV8(..., Handle<Object> creationContext = Handle<Object>(), ...) {
    ...;
  }

On the other hand, looking at the implementation of
V8WrapperInstantiationScope:

    explicit V8WrapperInstantiationScope(v8::Handle<v8::Object> creationContext)
        : m_didEnterContext(false)
        , m_context(v8::Context::GetCurrent())
    {
        if (creationContext.IsEmpty()) // We do nothing for this case!
            return;
        v8::Handle<v8::Context> contextForWrapper = creationContext->CreationContext();
        if (contextForWrapper == m_context)
            return;
        m_context = v8::Local<v8::Context>::New(contextForWrapper);
        m_didEnterContext = true;
        m_context->Enter();
    }

we're assuming that a creationContext parameter is passed
to toV8() when a creationContext exists. In other words,
if we forget to pass a creationContext parameter, we will
end up with creating an object on the current context, which
is wrong. To avoid the mistake, we should make the
creationContext parameter mandatory. When we really do not
have a creationContext, we can pass Handle<Object>() explicitly.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
* bindings/scripts/test/V8/V8Float64Array.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestException.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestInterface.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestNode.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestObj.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(WebCore::toV8):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(WebCore::toV8):
* bindings/v8/IDBBindingUtilities.cpp:
(WebCore::injectIDBKeyIntoScriptValue):
(WebCore::idbKeyToScriptValue):
* bindings/v8/ScriptController.cpp:
(WebCore::createScriptObject):
(WebCore::ScriptController::createScriptObjectForPluginElement):
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::currentCallFrame):
* bindings/v8/ScriptObject.cpp:
(WebCore::ScriptGlobalObject::set):
* bindings/v8/V8AbstractEventListener.cpp:
(WebCore::V8AbstractEventListener::handleEvent):
(WebCore::V8AbstractEventListener::getReceiverObject):
* bindings/v8/V8DOMWindowShell.cpp:
(WebCore::V8DOMWindowShell::updateDocumentProperty):
* bindings/v8/V8LazyEventListener.cpp:
(WebCore::toObjectWrapper):
* bindings/v8/V8MutationCallback.cpp:
(WebCore::V8MutationCallback::handleEvent):
* bindings/v8/V8NodeFilterCondition.cpp:
(WebCore::V8NodeFilterCondition::acceptNode):
* bindings/v8/V8WorkerContextEventListener.cpp:
(WebCore::V8WorkerContextEventListener::handleEvent):
(WebCore::V8WorkerContextEventListener::getReceiverObject):
* bindings/v8/custom/V8CustomSQLStatementErrorCallback.cpp:
(WebCore::V8SQLStatementErrorCallback::handleEvent):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::nodeAsScriptValue):
* css/MediaQueryListListener.cpp:
(WebCore::MediaQueryListListener::queryChanged):
* testing/v8/WebCoreTestSupport.cpp:
(WebCoreTestSupport::injectInternalsObject):

Source/WebKit/chromium:

We pass Handle<Object>() to a creationContext parameter of
toV8() when we do not have a creationContext.

No tests. No change in behavior.

* src/InspectorFrontendClientImpl.cpp:
(WebKit::InspectorFrontendClientImpl::windowObjectCleared):
* src/WebArrayBuffer.cpp:
(WebKit::WebArrayBuffer::toV8Value):
* src/WebBlob.cpp:
(WebKit::WebBlob::toV8Value):
* src/WebFrameImpl.cpp:
(WebKit::WebFrameImpl::createFileSystem):
(WebKit::WebFrameImpl::createSerializableFileSystem):
(WebKit::WebFrameImpl::createFileEntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd a Setting to disable QTKit media engine.
jer.noble@apple.com [Wed, 16 Jan 2013 19:19:59 +0000 (19:19 +0000)]
Add a Setting to disable QTKit media engine.
https://bugs.webkit.org/show_bug.cgi?id=106972

Reviewed by Eric Carlson.

Source/WebCore:

Allow the MediaPlayerPrivateQTKit engine to be disabled by adding a
runtime setting to Settings. Make the setting 'live' by requerying the
installed media engines when the setting changes.

* WebCore.exp.in: Add new symbols to export list.
* page/Settings.cpp: Add new gQTKitEnabled global.
(WebCore::Settings::setAVFoundationEnabled): Requery media engines.
(WebCore::Settings::setQTKitEnabled): Ditto. Setter for global setting variable.
* page/Settings.h:
(WebCore::Settings::isQTKitEnabled): Getter for same.
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Check isQTKitEnabled() before adding
    MediaPlayerPrivateQTKit engine.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::requeryMediaEngines): Pass through to MediaPlayer.
* html/HTMLMediaElement.h:
* platform/graphics/MediaPlayer.cpp:
(WebCore::installedMediaEngines): Take an optional requery options parameter.
(WebCore::MediaPlayer::requeryMediaEngines): Pass through to installedMediaEngines().
* platform/graphics/MediaPlayer.h:

Source/WebKit/mac:

Add WebKit API to set QTKit enabled setting from user defaults.

* WebView/WebPreferenceKeysPrivate.h:
* WebView/WebPreferences.mm:
(+[WebPreferences initialize]): Set WebCore settings based on user defaults.
(-[WebPreferences setQTKitEnabled:]): Pass through to WebCore.
(-[WebPreferences isQTKitEnabled]): Ditto.
* WebView/WebPreferencesPrivate.h:
* WebView/WebView.mm:
(-[WebView _preferencesChanged:]): Synchronize WebKit/WebCore settings.

Source/WebKit2:

Add a WebKit2 API to access WebCore QTKitEnabled settings.

* Shared/WebPreferencesStore.h:
* UIProcess/API/C/WKPreferences.cpp:
(WKPreferencesSetQTKitEnabled): Pass through to WebCore.
(WKPreferencesGetQTKitEnabled): Ditto.
* UIProcess/API/C/WKPreferences.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Synchronize WebKit2/WebCore settings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
pilgrim@chromium.org [Wed, 16 Jan 2013 19:04:23 +0000 (19:04 +0000)]
[Chromium] Move WebArrayBufferView and WebSerializedScriptValue out of public/platform/
https://bugs.webkit.org/show_bug.cgi?id=106863

Reviewed by Adam Barth.

These are not being moved into the new top-level Platform
directory, so into public they go.

* WebKit.gyp:
* public/WebArrayBufferView.h: Added.
(v8):
(WebKit):
(WebArrayBufferView):
(WebKit::WebArrayBufferView::~WebArrayBufferView):
(WebKit::WebArrayBufferView::WebArrayBufferView):
* public/WebSerializedScriptValue.h: Added.
(v8):
(WebKit):
(WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::~WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::WebSerializedScriptValue):
(WebKit::WebSerializedScriptValue::operator=):
(WebKit::WebSerializedScriptValue::isNull):
* public/platform/WebArrayBufferView.h:
* public/platform/WebSerializedScriptValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[gstreamer] Some media tests occasionally crash with gstreamer 1.0 backend
christophe.dumez@intel.com [Wed, 16 Jan 2013 18:44:18 +0000 (18:44 +0000)]
[gstreamer] Some media tests occasionally crash with gstreamer 1.0 backend
https://bugs.webkit.org/show_bug.cgi?id=106551

Reviewed by Philippe Normand.

ImageGStreamerCairo was passing mapped memory to
cairo_image_surface_create_for_data() and then unmapping it straight
away even though the cairo_surface_t is still used. The cairo
documentation states:
"The output buffer must be kept around until the cairo_surface_t is
destroyed or cairo_surface_finish() is called on the surface."

This patch keeps the GstBuffer memory mapped until the ImageGStreamer
is destroyed so that the internal cairo_surface_t stays valid while
avoiding copying the image data.

No new tests, already covered by existing tests.

* platform/graphics/gstreamer/GRefPtrGStreamer.cpp:
(WTF::adoptGRef):
(WTF):
(WTF::GstBuffer):
* platform/graphics/gstreamer/GRefPtrGStreamer.h:
(WTF): Add support for using GRefPtr with GstBuffer.
* platform/graphics/gstreamer/ImageGStreamer.h:
(ImageGStreamer):
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
(ImageGStreamer::~ImageGStreamer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Remove hardcoded chromium_*.jar in gyp files
commit-queue@webkit.org [Wed, 16 Jan 2013 18:37:48 +0000 (18:37 +0000)]
[Chromium] Remove hardcoded chromium_*.jar in gyp files
https://bugs.webkit.org/show_bug.cgi?id=104049

Patch by Chris Hopman <cjhopman@chromium.org> on 2013-01-16
Reviewed by Eric Seidel.

Targets with dependencies (direct/indirect) on a java target receive
the chromium_*.jar paths in the variable input_jars_paths. Targets
should use that rather than hardcoding where they think the jar will
be. These can be passed directly to ant as INPUT_JARS_PATHS rather
than as --jars to generate_native_test.py.

Source/WebKit/chromium:

* WebKitUnitTests.gyp:

Tools:

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* TestWebKitAPI/TestWebKitAPI.gyp/TestWebKitAPI.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse SkMatrix::I() when we need to pass identity, rather than constructing a new matrix.
reed@google.com [Wed, 16 Jan 2013 18:32:46 +0000 (18:32 +0000)]
Use SkMatrix::I() when we need to pass identity, rather than constructing a new matrix.
https://bugs.webkit.org/show_bug.cgi?id=107016

Reviewed by James Robinson.

No new tests. existing tests exercise this code.

The default constructor is being deprecated, so this change is also part of that effort,
though it is a perf-improvement regardless, since we avoid making a new (temp) matrix.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::updateLayerPreserves3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Marking several tests as crashing on Debug builds following
leviw@chromium.org [Wed, 16 Jan 2013 18:32:23 +0000 (18:32 +0000)]
Unreviewed gardening. Marking several tests as crashing on Debug builds following
r139853.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreveiwed gardening. Updating expectations following r139865.
leviw@chromium.org [Wed, 16 Jan 2013 18:23:16 +0000 (18:23 +0000)]
Unreveiwed gardening. Updating expectations following r139865.

* platform/chromium-linux/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-lion/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac-snowleopard/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium-win/fast/forms/time/time-appearance-basic-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139892 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderListMarker::computePreferredLogicalWidth should not be public
ojan@chromium.org [Wed, 16 Jan 2013 18:02:46 +0000 (18:02 +0000)]
RenderListMarker::computePreferredLogicalWidth should not be public
https://bugs.webkit.org/show_bug.cgi?id=106956

Reviewed by Tony Chang.

RenderListItem was calling computePreferredLogicalWidths for the side
effects of updating the marker content and margins. Instead, call
updateMarginsAndContent directly.

* rendering/RenderListItem.cpp:
(WebCore::RenderListItem::updateMarkerLocation):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::layout):
The isImage() codepath never calls computePreferredLogicalWidths, so we need to make
sure the content and margins are updated.

(WebCore::RenderListMarker::updateContent):
(WebCore::RenderListMarker::computePreferredLogicalWidths):
(WebCore::RenderListMarker::updateMarginsAndContent):
* rendering/RenderListMarker.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Safeguard against possible NULL-dereference
commit-queue@webkit.org [Wed, 16 Jan 2013 18:00:17 +0000 (18:00 +0000)]
[GTK] Safeguard against possible NULL-dereference
https://bugs.webkit.org/show_bug.cgi?id=104931

Patch by Claudio Saavedra <csaavedra@igalia.com> on 2013-01-16
Reviewed by Martin Robinson.

* accessibility/atk/WebKitAccessibleWrapperAtk.cpp:
(webkitAccessibleGetIndexInParent): Move the NULL-safeguard to a
place where it actually makes sense.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWest-panning cursor does not match resize cursor, unlike all other directions
commit-queue@webkit.org [Wed, 16 Jan 2013 17:49:03 +0000 (17:49 +0000)]
West-panning cursor does not match resize cursor, unlike all other directions
https://bugs.webkit.org/show_bug.cgi?id=89405

Patch by Avi Drissman <avi@google.com> on 2013-01-16
Reviewed by Alexey Proskuryakov.

Existing manual tests.

* platform/mac/CursorMac.mm:
(WebCore::Cursor::ensurePlatformCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGroundwork to enable process suppression by default on Mac
commit-queue@webkit.org [Wed, 16 Jan 2013 17:44:57 +0000 (17:44 +0000)]
Groundwork to enable process suppression by default on Mac
https://bugs.webkit.org/show_bug.cgi?id=106513

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-01-16
Reviewed by Alexey Proskuryakov.

Process suppression has so far been controlled by a user default and
disabled by default.  This patch provides the groundwork to enable it by
default and adds a private API to enable/disable it on a per-context
basis.

* Shared/mac/ChildProcessMac.mm:
(WebKit::ChildProcess::platformInitialize): Add comment about
initilization of application occlusion state.
* UIProcess/API/C/mac/WKContextPrivateMac.cpp: Added.
(WKContextGetProcessSuppressionEnabled):
(WKContextSetProcessSuppressionEnabled):
Add private API to enable/disable process suppression on a per-context
basis.
* UIProcess/API/C/mac/WKContextPrivateMac.h: Added.
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::didFinishLaunching): Check if owning
context has process suppression enabled before updating application
occlusion state.
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didFinishLaunching): Ditto.
* UIProcess/Plugins/PluginProcessProxy.cpp:
(WebKit::PluginProcessProxy::didFinishLaunching): Check if
process suppression is enabled for global child processes before
updating application occlusion state.
* UIProcess/SharedWorkers/SharedWorkerProcessProxy.cpp:
(WebKit::SharedWorkerProcessProxy::didFinishLaunching): Ditto.
* UIProcess/WebContext.cpp:
(WebKit::WebContext::create): Remove call to
initializeProcessSuppressionSupport, since platformInitialize has been
modified to perform initialization.
(WebKit::WebContext::WebContext): Initialize new member variable
m_processSuppressionEnabled to false.
* UIProcess/WebContext.h:
(WebKit::WebContext::processSuppressionEnabled): Remove "Support"
from the method name.
* UIProcess/mac/WebContextMac.mm:
(WebKit::updateGlobalChildProcessesApplicationOcclusionState):
(WebKit::applicationOcclusionStateChanged): Update the application
occlusion state of child processes having process suppresion enabled.
(WebKit::applicationBecameVisible):
(WebKit::applicationBecameOccluded):
Simplify by moving code to applicationOcclusionStateChanged.
(WebKit::registerOcclusionNotificationHandlers): Fix typos.
(WebKit::unregisterOcclusionNotificationHandlers): Add
method to unregister occlusion notification handlers when no context
has process suppression enabled.
(WebKit::enableOcclusionNotifications):
(WebKit::disableOcclusionNotifications):
(WebKit::enableProcessSuppressionForGlobalChildProcesses):
(WebKit::disableProcessSuppressionForGlobalChildProcesses):
(WebKit::processSuppressionIsEnabledForAnyContext):
(WebKit::processSuppressionIsEnabledForAllContexts):
(WebKit::WebContext::platformInitialize): Disable process suppression
for global child processes since process suppression is disabled for a
context on construction.
(WebKit::WebContext::setProcessSuppressionEnabled):
(WebKit::WebContext::updateChildProcessesApplicationOcclusionState):
(WebKit::WebContext::applicationIsOccluded):
(WebKit::WebContext::processSuppressionEnabledForGlobalChildProcesses):
(WebKit::WebContext::processSuppressionEnabledChanged): Update child
processes application occlusion state, enable/disable occlusion
notifications and enable/disable process suppression for global child
processes.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: array grouping does not work for float number keys
aandrey@chromium.org [Wed, 16 Jan 2013 16:56:17 +0000 (16:56 +0000)]
Web Inspector: array grouping does not work for float number keys
https://bugs.webkit.org/show_bug.cgi?id=106998

Reviewed by Pavel Feldman.

Source/WebCore:

Now we do the array index check according to the ECMAScript 5, section 15.4:
"A property name P (in the form of a String value) is an array index if and only if ToString(ToUint32(P)) is equal to P and ToUint32(P) is not equal to 2^32-1."

* inspector/front-end/ObjectPropertiesSection.js:
(.buildObjectFragment):

LayoutTests:

* inspector/console/console-big-array-expected.txt:
* inspector/console/console-big-array.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139887 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Show formatted content of JSON request
commit-queue@webkit.org [Wed, 16 Jan 2013 16:54:49 +0000 (16:54 +0000)]
Web Inspector: Show formatted content of JSON request
https://bugs.webkit.org/show_bug.cgi?id=106900

Patch by Sergey Ryazanov <serya@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.

"Request payload" section showed raw content for POST requests.
This change show it in structured format if it's JSON parsable.
Raw format is also available.

* inspector/front-end/RequestHeadersView.js:
(WebInspector.RequestHeadersView.prototype._refreshQueryString):
(WebInspector.RequestHeadersView.prototype._refreshFormData):
(WebInspector.RequestHeadersView.prototype.toggleViewSource):
(WebInspector.RequestHeadersView.prototype._refreshParams):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139886 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: UISourceCode scriptFile / styleFile should be reset on navigation...
vsevik@chromium.org [Wed, 16 Jan 2013 16:48:30 +0000 (16:48 +0000)]
Web Inspector: UISourceCode scriptFile / styleFile should be reset on navigation (debugger or css model reset).
https://bugs.webkit.org/show_bug.cgi?id=107008

Reviewed by Pavel Feldman.

ScriptFiles and styleFiles are now reset and disposed on UISourceCodes on corresponding models reset.
StyleSourceMapping now tries to setup mapping for newly added resource as well as for uiSourceCodes previously.

* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel):
(WebInspector.CSSStyleModel.prototype._mainFrameCreatedOrNavigated):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping):
(WebInspector.ResourceScriptMapping.prototype._unbindUISourceCodeFromScripts):
(WebInspector.ResourceScriptMapping.prototype._initialize):
(WebInspector.ResourceScriptMapping.prototype._debuggerReset):
(WebInspector.ResourceScriptFile.prototype.dispose):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel.prototype._addFrame):
(WebInspector.ResourceTreeModel.prototype._frameNavigated):
* inspector/front-end/ScriptSnippetModel.js:
(WebInspector.ScriptSnippetModel):
(WebInspector.ScriptSnippetModel.prototype._debuggerReset):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype._resourceAdded):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._bindUISourceCode):
(WebInspector.StylesSourceMapping.prototype._projectWillReset):
(WebInspector.StylesSourceMapping.prototype._initialize):
(WebInspector.StylesSourceMapping.prototype._mainFrameCreatedOrNavigated):
(WebInspector.StyleFile.prototype.dispose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139885 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid...
kov@webkit.org [Wed, 16 Jan 2013 16:26:10 +0000 (16:26 +0000)]
[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552

Reverting 139877. It made a couple of API tests fail.

* platform/graphics/gstreamer/GStreamerVersioning.cpp:
* platform/graphics/gstreamer/GStreamerVersioning.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient):
(_WebKitWebSrcPrivate):
(webKitWebSrcFinalize):
(webKitWebSrcStop):
(StreamingClient::didReceiveData):
* platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal):
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation):
(WebCore::nextMultipartResponsePartCallback):
(WebCore::sendRequestCallback):
(WebCore::readCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139884 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: cookies with empty value are parsed incorrectly
caseq@chromium.org [Wed, 16 Jan 2013 16:00:38 +0000 (16:00 +0000)]
Web Inspector: cookies with empty value are parsed incorrectly
https://bugs.webkit.org/show_bug.cgi?id=107012

Reviewed by Pavel Feldman.

Source/WebCore:

Require cookie value to be a string, not a non-empty string, before
employing legacy compatibility hack of treating bare token as value
for the cookie with an empty name.

* inspector/front-end/CookieParser.js:
(WebInspector.CookieParser.prototype._addCookie):

LayoutTests:

* inspector/cookie-parser-expected.txt:
* inspector/cookie-parser.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL build fix after r139877.
g.czajkowski@samsung.com [Wed, 16 Jan 2013 15:35:19 +0000 (15:35 +0000)]
Unreviewed EFL build fix after r139877.

* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(getGstBufferDataPointer): Add const modifier to webkitGstMapInfoQuarkString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139882 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: create helper InspectorTest method to dump editor HTML
pfeldman@chromium.org [Wed, 16 Jan 2013 15:26:14 +0000 (15:26 +0000)]
Web Inspector: create helper InspectorTest method to dump editor HTML
https://bugs.webkit.org/show_bug.cgi?id=107007

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Pavel Feldman.

Add helper method to dump textEditor HTML.

* inspector/editor/editor-test.js:
(initialize_EditorTests.InspectorTest.dumpEditorHTML): Added.
* inspector/editor/text-editor-highlight-regexp.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139881 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Extensions API] remove inspectedWindow.onReset event
caseq@chromium.org [Wed, 16 Jan 2013 15:20:24 +0000 (15:20 +0000)]
Web Inspector: [Extensions API] remove inspectedWindow.onReset event
https://bugs.webkit.org/show_bug.cgi?id=107009

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/ExtensionAPI.js:
(defineCommonExtensionSymbols):
(injectedExtensionAPI.InspectorExtensionAPI):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype.initExtensions):

LayoutTests:

* inspector/extensions/extensions-api-expected.txt: removed webInspector.onReset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139880 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix text-editor-highlight-regexp test
pfeldman@chromium.org [Wed, 16 Jan 2013 15:13:10 +0000 (15:13 +0000)]
Web Inspector: fix text-editor-highlight-regexp test
https://bugs.webkit.org/show_bug.cgi?id=107006

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.

Source/WebCore:

Use 'height: 100%' instead of pixel values on highlight spans to bring in some platform independency in test expectations.

No new tests: no changes in behaviour.

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype._measureRegex):
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
* inspector/front-end/textEditor.css:
(.text-editor-overlay-highlight):
(.webkit-line-content):

LayoutTests:

Fixing test expectations: no more height style.

* inspector/editor/text-editor-highlight-regexp-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Use the shared HistoryItem serialization for QWebHistory
jocelyn.turcotte@digia.com [Wed, 16 Jan 2013 15:06:46 +0000 (15:06 +0000)]
[Qt] Use the shared HistoryItem serialization for QWebHistory
https://bugs.webkit.org/show_bug.cgi?id=106671

Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

This allows a few things missing from the previous serialization code
to function while using commonly maintained code:
- The itemSequenceNumber and documentSequenceNumber that were needed
  to properly restore same-document navigations
- The form data
- The navigation hierarchy mapping the frame tree

* history/HistoryItem.h:
(HistoryItem):
* history/qt/HistoryItemQt.cpp:
(QDataStreamCoder):
(WebCore):
(WebCore::QDataStreamCoder::QDataStreamCoder):
(WebCore::QDataStreamCoder::encodeBytes):
(WebCore::QDataStreamCoder::encodeBool):
(WebCore::QDataStreamCoder::encodeUInt32):
(WebCore::QDataStreamCoder::encodeUInt64):
(WebCore::QDataStreamCoder::encodeInt32):
(WebCore::QDataStreamCoder::encodeInt64):
(WebCore::QDataStreamCoder::encodeFloat):
(WebCore::QDataStreamCoder::encodeDouble):
(WebCore::QDataStreamCoder::encodeString):
(WebCore::QDataStreamCoder::decodeBytes):
(WebCore::QDataStreamCoder::decodeBool):
(WebCore::QDataStreamCoder::decodeUInt32):
(WebCore::QDataStreamCoder::decodeUInt64):
(WebCore::QDataStreamCoder::decodeInt32):
(WebCore::QDataStreamCoder::decodeInt64):
(WebCore::QDataStreamCoder::decodeFloat):
(WebCore::QDataStreamCoder::decodeDouble):
(WebCore::QDataStreamCoder::decodeString):
(WebCore::HistoryItem::restoreState):
(WebCore::WebCore::HistoryItem::saveState):

Source/WebKit/qt:

Bump the serialization version and change the code to abort the
restore of a previous stream version rather than trying to keep the
support of restoring previous versions. This is mainly to simplify
things given that HistoryItem itself aborts in that case.

* Api/qwebhistory.cpp:
(operator<<):
(operator>>):
* tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::serialize_2): Modify the test to cover same-document navigations.
(tst_QWebHistory::restoreIncompatibleVersion1): Add a previous version
hard-coded stream to verify that the deserialization doesn't hang or
crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid...
kov@webkit.org [Wed, 16 Jan 2013 14:15:58 +0000 (14:15 +0000)]
[GStreamer][Soup] Let GStreamer provide the buffer data is downloaded to, to avoid copying
https://bugs.webkit.org/show_bug.cgi?id=105552

Patch by Gustavo Noronha Silva <gustavo.noronha@collabora.com> on 2013-01-15
Reviewed by Philippe Normand.

Makes it possible for the GStreamer media backend to provide the buffer to which
the Soup networking backend will use to download data to. This makes copying
memory unnecessary when ResourceHandle hands data over to the media player's
StreamingClient. Thanks to Dan Winship for help designing the interface.

No behaviour change, covered by existing tests.

* platform/graphics/gstreamer/GStreamerVersioning.cpp:
(getGstBufferSize): Abstract obtaining the size of the buffer, so the code
is cleaner while still working for both GST 0.10 and 1.0.
(setGstBufferSize): Ditto, but for setting the size.
(getGstBufferDataPointer): Ditto, but for grabbing the data pointer.
(mapGstBuffer): Convenience method to take care of mapping the buffer so that
we can provide the data pointer to ResourceHandle.
(unmapGstBuffer): Convenience method which takes care of unmapping the buffer
and properly freeing the GstMapInfo.
* platform/graphics/gstreamer/GStreamerVersioning.h:
* platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
(StreamingClient): New methods.
(_WebKitWebSrcPrivate): We now store the GstBuffer we provided the data pointer from
so we can later unmap it and push it to the pipeline.
(webKitWebSrcDispose): Deal with the GstBuffer in case it exists when the source is
destroyed.
(webKitWebSrcStop): Also clear the GstBuffer in this case.
(StreamingClient::didReceiveData): Handle the hand-over of the buffer.
(StreamingClient::getBuffer): Provide ResourceHandle with a new GstBuffer's data pointer.
* platform/network/ResourceHandleClient.h:
(ResourceHandleClient):
(WebCore::ResourceHandleClient::ResourceHandleClient): Constructor to initialize the buffer
member variable to 0.
(WebCore::ResourceHandleClient::~ResourceHandleClient): Destructor to free the buffer if it
has been allocated.
(WebCore::ResourceHandleClient::getBuffer): Default implementation which returns a
newly allocated char pointer.
* platform/network/ResourceHandleInternal.h:
(WebCore::ResourceHandleInternal::ResourceHandleInternal):
(ResourceHandleInternal): Store actual buffer size, which is no longer a constant.
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::cleanupSoupRequestOperation): Clear the buffer pointer, the life-cycle of the
buffer is handled by the ResourceHandleClient.
(WebCore::nextMultipartResponsePartCallback): Get a new buffer from the client before reading.
(WebCore::sendRequestCallback): Ditto.
(WebCore::readCallback): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Crash in WebCore::CachedFrame::destroy
jocelyn.turcotte@digia.com [Wed, 16 Jan 2013 13:55:49 +0000 (13:55 +0000)]
[Qt] Crash in WebCore::CachedFrame::destroy
https://bugs.webkit.org/show_bug.cgi?id=104525

Reviewed by Adam Barth.

Source/WebCore:

Add an assert to increase the chances of catching this crash
early on in the future.

* dom/Document.cpp:
(WebCore::Document::takeDOMWindowFrom):

Source/WebKit/qt:

Remove the call to HistoryController::setCurrentItem which is ultimately
causing the initial empty document of a page to be added to the page cache.

This re-introduce the bug that was fixed by this line, which will be
properly fixed in a follow-up patch.

* Api/qwebhistory.cpp:
(operator>>):
* tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::saveAndRestore_crash_4): Cover the crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] move setMockDeviceOrientation to TestRunner library
commit-queue@webkit.org [Wed, 16 Jan 2013 13:50:31 +0000 (13:50 +0000)]
[chromium] move setMockDeviceOrientation to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=106895

Patch by Dan Carney <dcarney@google.com> on 2013-01-16
Reviewed by Jochen Eisinger.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestRunner::WebTestDelegate::setDeviceOrientation):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::setMockDeviceOrientation):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setDeviceOrientation):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139875 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 16 Jan 2013 13:17:25 +0000 (13:17 +0000)]
Unreviewed GTK gardening.

Updating or removing a few stale expectations.
Adding two failure expectations for MicroData tests that are
failing after r139673.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix Сlosure warnings in devTools front-end
commit-queue@webkit.org [Wed, 16 Jan 2013 13:11:28 +0000 (13:11 +0000)]
Web Inspector: fix Сlosure warnings in devTools front-end
https://bugs.webkit.org/show_bug.cgi?id=106993

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.

Add missing annotations and rename Element.remove() method to avoid collision with HTMLSelectElement.remove() method.

No new tests: no change in behaviour.

* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode.prototype.hasChildNodes):
(WebInspector.DOMNode.prototype.getChildNodes):
* inspector/front-end/DOMExtension.js:
(Element.prototype.removeSelf):
(removeSubsequentNodes):
* inspector/front-end/DefaultTextEditor.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.OverridesSettingsTab):
* inspector/front-end/SourceTokenizer.js:
(WebInspector.SourceTokenizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
jochen@chromium.org [Wed, 16 Jan 2013 12:41:47 +0000 (12:41 +0000)]
[chromium] route more webkit_support and webviewhost callbacks through WebTestDelegate
https://bugs.webkit.org/show_bug.cgi?id=106904

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::notifyDone):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::setDeviceScaleFactor):
(WebTestRunner::WebTestDelegate::setFocus):
(WebTestRunner::WebTestDelegate::setAcceptAllCookies):
(WebTestRunner::WebTestDelegate::pathToLocalResource):
(WebTestRunner::WebTestDelegate::setLocale):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setAlwaysAcceptCookies):
(WebTestRunner):
(WebTestRunner::TestRunner::setWindowIsKey):
(WebTestRunner::TestRunner::pathToLocalResource):
(WebTestRunner::TestRunner::setBackingScaleFactor):
(WebTestRunner::TestRunner::setPOSIXLocale):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebTestRunner::TestRunner::taskList):
(TestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setDeviceScaleFactor):
(WebViewHost::setFocus):
(WebViewHost::setAcceptAllCookies):
(WebViewHost::pathToLocalResource):
(WebViewHost::setLocale):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix backward compatibility issues with Element.remove() method
commit-queue@webkit.org [Wed, 16 Jan 2013 12:16:41 +0000 (12:16 +0000)]
Web Inspector: fix backward compatibility issues with Element.remove() method
https://bugs.webkit.org/show_bug.cgi?id=106996

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Vsevolod Vlasov.

Add javascript implementations for CharacterData.prototype.remove and DocumentType.prototype.remove.

No new tests: no change in behaviour.

* inspector/front-end/DOMExtension.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGraphicsSurfaceGLX is leaking an XWindow
zeno.albisser@digia.com [Wed, 16 Jan 2013 12:13:45 +0000 (12:13 +0000)]
GraphicsSurfaceGLX is leaking an XWindow
https://bugs.webkit.org/show_bug.cgi?id=107002

The XWindow created as a backing surface for
the GraphicsSurfaceGLX needs to be destroyed
together with the GraphicsSurface.

Reviewed by Noam Rosenthal.

* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore::GraphicsSurfacePrivate::clear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 16 Jan 2013 12:02:43 +0000 (12:02 +0000)]
[EFL] Unreviewed gardening.

Marking compositing/layer-creation/overlap-animation-container as failure
after it started failing in r139794, might just need a rebaseline but first let's have
someone familiar with AC look at it.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] build-webkit fails if the jhbuild wrapper is not used
sergio@webkit.org [Wed, 16 Jan 2013 12:00:50 +0000 (12:00 +0000)]
[GTK] build-webkit fails if the jhbuild wrapper is not used
https://bugs.webkit.org/show_bug.cgi?id=106769

Reviewed by Martin Robinson.

Return an empty array instead of "" in
jhbuildWrapperPrefixIfNeeded() because otherwise that empty string
will not be recognized as a valid command when the returned array
is directly passed to perl's system() call.

* Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDoesn't build with GCC 4.7+
allan.jensen@digia.com [Wed, 16 Jan 2013 11:51:32 +0000 (11:51 +0000)]
Doesn't build with GCC 4.7+
https://bugs.webkit.org/show_bug.cgi?id=106999

Reviewed by Csaba Osztrogonác.

Correct __GNU_C_MINOR__ macro to __GNUC_MINOR__.

* src/compiler/preprocessor/ExpressionParser.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement CSSSupportsRule
commit-queue@webkit.org [Wed, 16 Jan 2013 11:30:50 +0000 (11:30 +0000)]
Implement CSSSupportsRule
https://bugs.webkit.org/show_bug.cgi?id=104822

Patch by Pablo Flouret <pablof@motorola.com> on 2013-01-16
Reviewed by Allan Sandfeld Jensen.

Source/WebCore:

http://dev.w3.org/csswg/css3-conditional/#the-csssupportsrule-interface

Right now, @supports is not implemented as a proper CSSRule. Apart from
the CSSOM implications it gives wrong results when, for instance, an
@supports rule is nested inside a @media rule.

Test: css3/supports-cssom.html

* CMakeLists.txt:
* DerivedSources.cpp:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.exp.in:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
    Add CSSSupportsRule.* and associated files.

* bindings/js/JSCSSRuleCustom.cpp:
(WebCore::toJS):
* bindings/objc/DOMCSS.mm:
(kitClass):
* bindings/v8/custom/V8CSSRuleCustom.cpp:
(WebCore::wrap):
    Create the correct wrappers for the rule.

* css/CSSGrammar.y.in:
* css/CSSParser.cpp:
(WebCore::CSSParser::createSupportsRule):
(WebCore::CSSParser::markSupportsRuleHeaderStart):
(WebCore::CSSParser::markSupportsRuleHeaderEnd):
* css/CSSParser.h:
    Create the supports rule when parsing and add it where it corresponds,
    instead of directly adding the child rules to the stylesheet.

* css/CSSPropertySourceData.h:
* css/CSSRule.h:
* css/CSSRule.idl:
    Add SUPPORTS_RULE type to enums.

* css/CSSSupportsRule.cpp: Added.
(WebCore::CSSSupportsRule::CSSSupportsRule):
(WebCore::CSSSupportsRule::~CSSSupportsRule):
(WebCore::CSSSupportsRule::cssText):
(WebCore::CSSSupportsRule::conditionText):
* css/CSSSupportsRule.h: Added.
(WebCore::CSSSupportsRule::create):
* css/CSSSupportsRule.idl: Added.
    DOM interface.

* css/RuleSet.cpp:
(WebCore::RuleSet::addChildRules):
    Add rules included in the @supports rule.

* css/StyleResolver.cpp:
(WebCore::collectCSSOMWrappers):
    Collect CSSSupportsRule wrappers.

* css/StyleRule.cpp:
(WebCore::StyleRuleBase::reportMemoryUsage):
(WebCore::StyleRuleBase::destroy):
(WebCore::StyleRuleBase::copy):
(WebCore::StyleRuleBase::createCSSOMWrapper):
(WebCore::StyleRuleSupports::StyleRuleSupports):
* css/StyleRule.h:
(StyleRuleBase):
(WebCore::StyleRuleBase::isSupportsRule):
(StyleRuleSupports):
(WebCore::StyleRuleSupports::create):
(WebCore::StyleRuleSupports::conditionText):
(WebCore::StyleRuleSupports::conditionIsSupported):
(WebCore::StyleRuleSupports::copy):
(WebCore::toStyleRuleSupports):
    New subclass of StyleRuleBlock: StyleRuleSupports.

* css/StyleSheetContents.cpp:
(WebCore::childRulesHaveFailedOrCanceledSubresources):
* inspector/InspectorStyleSheet.cpp:
(flattenSourceData):
(WebCore::asCSSRuleList):
    Handle @supports rules where needed.

LayoutTests:

* css3/supports-cssom-expected.txt: Added.
* css3/supports-cssom.html: Added.
* css3/supports-expected.txt:
* css3/supports.html:

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
* platform/wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoINPUT_MULTIPLE_FIELDS_UI: Unable to edit a time field with step=86400, and confusing...
tkent@chromium.org [Wed, 16 Jan 2013 11:04:36 +0000 (11:04 +0000)]
INPUT_MULTIPLE_FIELDS_UI: Unable to edit a time field with step=86400, and confusing appearance
https://bugs.webkit.org/show_bug.cgi?id=106983

Reviewed by Kentaro Hara.

Source/WebCore:

For example, we show a read-only hour field and a read-only minutes
field for <input type=time min="17:00" step=86400> because the step
value is 24 hours and the hour field can be only 17. However, we need to
provide a way to clear the value of the time field in such case. We
shouldn't make the hour field read-only if no other fields are editable.

- We don't make hour fields read-only for input[type=time].

- We make hour fields read-only for input[type=datetime-local] only if
  year, month, or day field is editable. e.g.
  <input type=datetime-local min=2013-01-16T17:00 step=86400>:
    The hour field is read-only, and year/month/day fields are editable.
  <input type=datetime-local min=2013-01-16T17:00 max=2013-01-16T18:00 step=86400>:
    The hour field is editable, and year/month/day fields are read-only.

Test: fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html

* html/shadow/DateTimeEditElement.cpp:
(DateTimeEditBuilder): Declare new functions.
(WebCore::DateTimeEditBuilder::getRangeOfDayOfMonthField):
Added a function by extracting some code from visitField.
(WebCore::DateTimeEditBuilder::visitField):
(WebCore::DateTimeEditBuilder::shouldDayOfMonthFieldReadOnly):
Added a function by extracting some code from visitField.
(WebCore::DateTimeEditBuilder::shouldHourFieldReadOnly):
If the type is "time", we don't make hour fields read-only.
Otherwise, we don't make hour fields read-only if year/month/day fields
are read-only. Note that we don't need to check read-only status of year
and month fields explicitly here because a day field can be read-only
only if the year field and the month field are read-only.

LayoutTests:

Note: We don't add tests for input[type=datetime] now because the WHATWG
specification might be changed.

* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield-expected.txt: Added.
* fast/forms/datetimelocal-multiple-fields/datetimelocal-multiple-fields-readonly-subfield.html: Added.

* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield-expected.txt:
* fast/forms/time-multiple-fields/time-multiple-fields-readonly-subfield.html:
Update test cases for new behavior. We should not make hour fields
read-only for input[type=time].
* platform/chromium-mac/fast/forms/time/time-appearance-basic-expected.png: Ditto.
* platform/chromium/TestExpectations: Add time-appearance-basic.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[TexMap] Composited CSS shaders crash when using non-GL TextureMapper
allan.jensen@digia.com [Wed, 16 Jan 2013 10:59:33 +0000 (10:59 +0000)]
[TexMap] Composited CSS shaders crash when using non-GL TextureMapper
https://bugs.webkit.org/show_bug.cgi?id=106796

Reviewed by Noam Rosenthal.

Fail gracefully when FilterEffectRenderer fails to build the filter effects.

* platform/graphics/texmap/TextureMapperImageBuffer.cpp:
(WebCore::BitmapTextureImageBuffer::applyFilters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Wed, 16 Jan 2013 10:47:17 +0000 (10:47 +0000)]
[Qt] Unreviewed gardening.

Patch by Nandor Huszka <hnandor@inf.u-szeged.hu> on 2013-01-16

* platform/qt-5.0-wk1/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png: Added. Rebaseline after r139798.
* platform/qt-5.0-wk1/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added. Rebaseline after r139798.
* platform/qt/compositing/layer-creation/overlap-animation-container-expected.txt: Added. Rebaseline after r139794.
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png: Rebaseline after r139798.
* platform/qt/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Rebaseline after r139798.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Store project UISourceCodes in a map with uri as a key for faster...
vsevik@chromium.org [Wed, 16 Jan 2013 10:43:52 +0000 (10:43 +0000)]
Web Inspector: Store project UISourceCodes in a map with uri as a key for faster lookup.
https://bugs.webkit.org/show_bug.cgi?id=106911

Reviewed by Pavel Feldman.

* inspector/front-end/Workspace.js:
(WebInspector.Project):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype._fileRemoved):
(WebInspector.Project.prototype._reset):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Project.prototype.uiSourceCodeForURI):
(WebInspector.Project.prototype.uiSourceCodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
dominik.rottsches@intel.com [Wed, 16 Jan 2013 10:42:03 +0000 (10:42 +0000)]
[EFL] Unreviewed gardening.

Removed fast/events/drag-and-drop-autoscroll from Test expectations after rollout in r139503.
ScrollingCoordinator tests moved to TestExpectations after r139686.
Border size rendering change in r139798 requires a rebaseline for
svg/zoom/page/zoom-replaced-intrinsic-ratio-001.htm &
http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm
but they fail to generate pixel results - see bug 106992.
PropertyCollection tests skipped for now after r139756

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Introduce file mapping allowing to map network loaded scripts and...
vsevik@chromium.org [Wed, 16 Jan 2013 10:26:36 +0000 (10:26 +0000)]
Web Inspector: Introduce file mapping allowing to map network loaded scripts and stylesheets to file system files.
https://bugs.webkit.org/show_bug.cgi?id=106795

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced file mapping for inspector.
FileMapping is essentially an array of MappingEntries where each MappingEntry is a pair of urlPrefix and pathPrefix.
When scripts and stylesheets are mapped to uiSourceCodes FileMapping methods are used to establish
prefix based matching with file system uiSourceCodes if possible.

Test: inspector/file-mapping.html

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.py:
* inspector/front-end/CompilerScriptMapping.js:
(WebInspector.CompilerScriptMapping):
(WebInspector.CompilerScriptMapping.prototype.rawLocationToUILocation):
(WebInspector.CompilerScriptMapping.prototype.uiLocationToRawLocation):
(WebInspector.CompilerScriptMapping.prototype.get addScript.get this):
(WebInspector.CompilerScriptMapping.prototype.get addScript):
(WebInspector.CompilerScriptMapping.prototype._bindUISourceCode):
(WebInspector.CompilerScriptMapping.prototype._uiSourceCodeAddedToWorkspace):
* inspector/front-end/FileMapping.js: Added.
(WebInspector.FileMapping):
(WebInspector.FileMapping.prototype.hasMappingForURL):
(WebInspector.FileMapping.prototype.uriForURL):
(WebInspector.FileMapping.prototype.urlForURI):
(WebInspector.FileMapping.prototype.setMappings):
(WebInspector.FileMapping.prototype.mappings):
(WebInspector.FileMapping.prototype._deserialize):
(WebInspector.FileMapping.prototype._serialize):
(WebInspector.FileMapping.MappingEntry):
(WebInspector.FileMapping.MappingEntry.deserialize):
(WebInspector.FileMapping.MappingEntry.prototype.matchesURL):
(WebInspector.FileMapping.MappingEntry.prototype.matchesURI):
(WebInspector.FileMapping.MappingEntry.prototype.uriForURL):
(WebInspector.FileMapping.MappingEntry.prototype.urlForURI):
(WebInspector.FileMapping.MappingEntry.prototype.serialize):
* inspector/front-end/NetworkUISourceCodeProvider.js:
(WebInspector.NetworkUISourceCodeProvider.prototype._addFile):
* inspector/front-end/ResourceScriptMapping.js:
(WebInspector.ResourceScriptMapping.prototype._workspaceUISourceCodeForScript):
(WebInspector.ResourceScriptMapping.prototype._scriptsForUISourceCode):
* inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL):
* inspector/front-end/SASSSourceMapping.js:
(WebInspector.SASSSourceMapping):
(WebInspector.SASSSourceMapping.prototype._reloadCSS):
(_addURLMapping):
(rawLocationToUILocation):
(_reset):
(WebInspector.SASSSourceMapping.MappingEntry):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping):
(WebInspector.StylesSourceMapping.prototype.rawLocationToUILocation):
(WebInspector.StylesSourceMapping.prototype._uiSourceCodeAddedToWorkspace):
(WebInspector.StylesSourceMapping.prototype._projectWillReset):
(WebInspector.StyleContentBinding.prototype.):
(WebInspector.StyleContentBinding.prototype._innerStyleSheetChanged):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/Workspace.js:
* inspector/front-end/inspector.html:
* inspector/front-end/inspector.js:

LayoutTests:

* inspector/file-mapping-expected.txt: Added.
* inspector/file-mapping.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Introduce UISourceCode.originURL().
vsevik@chromium.org [Wed, 16 Jan 2013 10:19:13 +0000 (10:19 +0000)]
Web Inspector: Introduce UISourceCode.originURL().
https://bugs.webkit.org/show_bug.cgi?id=106909

Reviewed by Pavel Feldman.

Source/WebCore:

Introduced originURL on UISourceCode showing where UISourceCode in workspace was loaded from.
This is neeeded to distinguish it from network request url used by mappings.

* inspector/front-end/AdvancedSearchController.js:
(WebInspector.FileBasedSearchResultsPane.prototype._createAnchor):
(WebInspector.FileBasedSearchResultsPane.prototype.addSearchResult):
* inspector/front-end/BreakpointsSidebarPane.js:
(WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
* inspector/front-end/CallStackSidebarPane.js:
(WebInspector.CallStackSidebarPane.Placard.prototype._update):
* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._handleOpenURL):
(WebInspector.ExtensionServer.prototype._onGetResourceContent):
(WebInspector.ExtensionServer.prototype._onSetResourceContent):
* inspector/front-end/JavaScriptSourceFrame.js:
(WebInspector.JavaScriptSourceFrame.prototype._setBreakpoint):
* inspector/front-end/Linkifier.js:
(WebInspector.Linkifier.prototype._updateAnchor):
(WebInspector.Linkifier.DefaultFormatter.prototype.formatLiveAnchor):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorSourceTreeElement):
* inspector/front-end/SASSSourceMapping.js:
(uiLocationToRawLocation):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype.canShowAnchorLocation):
(WebInspector.ScriptsPanel.prototype._showSourceLine):
(WebInspector.ScriptsPanel.prototype._toggleFormatSource):
* inspector/front-end/ScriptsSearchScope.js:
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes):
(WebInspector.ScriptsSearchScope.prototype._sortedUISourceCodes.comparator):
* inspector/front-end/SimpleWorkspaceProvider.js:
(WebInspector.SimpleWorkspaceProvider.prototype.addFile):
* inspector/front-end/StyleSheetOutlineDialog.js:
(WebInspector.StyleSheetOutlineDialog.prototype.requestItems):
* inspector/front-end/StylesSourceMapping.js:
(WebInspector.StylesSourceMapping.prototype.uiLocationToRawLocation):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._tooltipForFile):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.originURL):
(WebInspector.UISourceCode.prototype.urlChanged):
(WebInspector.UISourceCode.prototype.contentURL):
(WebInspector.Revision.prototype.contentURL):
* inspector/front-end/Workspace.js:
(WebInspector.FileDescriptor):
(WebInspector.Project.prototype._fileAdded):
(WebInspector.Project.prototype.uiSourceCodeForOriginURL):
(WebInspector.Workspace.prototype.uiSourceCodeForOriginURL):

LayoutTests:

* http/tests/inspector/compiler-script-mapping.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* http/tests/inspector/network/network-request-revision-content.html:
* http/tests/inspector/workspace-test.js:
* inspector/debugger/breakpoint-manager.html:
* inspector/debugger/dynamic-script-tag.html:
* inspector/debugger/linkifier.html:
* inspector/debugger/live-edit-breakpoints.html:
* inspector/debugger/script-snippet-model.html:
* inspector/debugger/scripts-file-selector.html:
* inspector/debugger/scripts-panel.html:
* inspector/debugger/scripts-sorting.html:
* inspector/debugger/source-frame-count.html:
* inspector/debugger/source-url-comment.html:
* inspector/debugger/ui-source-code-display-name.html:
* inspector/debugger/ui-source-code.html:
* inspector/styles/styles-history.html:
* inspector/uisourcecode-revisions.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Move 'DefaultTheme' folder to WebCore/platform/efl
gyuyoung.kim@samsung.com [Wed, 16 Jan 2013 10:16:38 +0000 (10:16 +0000)]
[EFL] Move 'DefaultTheme' folder to WebCore/platform/efl
https://bugs.webkit.org/show_bug.cgi?id=106969

Reviewed by Benjamin Poulain.

.:

* Source/PlatformEfl.cmake: Change DefaultTheme path.
* Source/cmake/OptionsEfl.cmake: ditto.

Source/WebCore:

DefaultTheme is used by both EFL WK1 and WK2 ports. So, WebCore/platform/efl is appropriate place for it.

* platform/efl/DefaultTheme/CMakeLists.txt: Renamed from Source/WebKit/efl/DefaultTheme/CMakeLists.txt.
* platform/efl/DefaultTheme/default.edc: Renamed from Source/WebKit/efl/DefaultTheme/default.edc.
* platform/efl/DefaultTheme/widget/button/button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/button.edc.
* platform/efl/DefaultTheme/widget/button/img_button_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_focus.png.
* platform/efl/DefaultTheme/widget/button/img_button_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_hover.png.
* platform/efl/DefaultTheme/widget/button/img_button_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_normal.png.
* platform/efl/DefaultTheme/widget/button/img_button_press.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/button/img_button_press.png.
* platform/efl/DefaultTheme/widget/check/check.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/check.edc.
* platform/efl/DefaultTheme/widget/check/img_check_bg_disabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_disabled.png.
* platform/efl/DefaultTheme/widget/check/img_check_bg_enabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_bg_enabled.png.
* platform/efl/DefaultTheme/widget/check/img_check_off.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_off.png.
* platform/efl/DefaultTheme/widget/check/img_check_off_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_off_focus.png.
* platform/efl/DefaultTheme/widget/check/img_check_off_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_off_hover.png.
* platform/efl/DefaultTheme/widget/check/img_check_on.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_on.png.
* platform/efl/DefaultTheme/widget/check/img_check_on_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_on_focus.png.
* platform/efl/DefaultTheme/widget/check/img_check_on_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/check/img_check_on_hover.png.
* platform/efl/DefaultTheme/widget/combo/combo.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo.edc.
* platform/efl/DefaultTheme/widget/combo/combo_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_focus.png.
* platform/efl/DefaultTheme/widget/combo/combo_focus_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_focus_button.png.
* platform/efl/DefaultTheme/widget/combo/combo_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_hover.png.
* platform/efl/DefaultTheme/widget/combo/combo_hover_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_hover_button.png.
* platform/efl/DefaultTheme/widget/combo/combo_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_normal.png.
* platform/efl/DefaultTheme/widget/combo/combo_normal_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_normal_button.png.
* platform/efl/DefaultTheme/widget/combo/combo_press.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_press.png.
* platform/efl/DefaultTheme/widget/combo/combo_press_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/combo_press_button.png.
* platform/efl/DefaultTheme/widget/combo/icon.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/combo/icon.png.
* platform/efl/DefaultTheme/widget/entry/entry.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/entry.edc.
* platform/efl/DefaultTheme/widget/entry/img_focused.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/img_focused.png.
* platform/efl/DefaultTheme/widget/entry/img_hovered.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/img_hovered.png.
* platform/efl/DefaultTheme/widget/entry/img_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/entry/img_normal.png.
* platform/efl/DefaultTheme/widget/file/file.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file.edc.
* platform/efl/DefaultTheme/widget/file/file_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_focus.png.
* platform/efl/DefaultTheme/widget/file/file_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_hover.png.
* platform/efl/DefaultTheme/widget/file/file_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_normal.png.
* platform/efl/DefaultTheme/widget/file/file_press.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/file/file_press.png.
* platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/enterfullscreenbutton.png.
* platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/exitfullscreenbutton.png.
* platform/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/fullscreenbutton/fullscreen_button.edc.
* platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/mutebutton/mute_button.edc.
* platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/mutebutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/mutebutton/mutebutton.png.
* platform/efl/DefaultTheme/widget/mediacontrol/mutebutton/unmutebutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/mutebutton/unmutebutton.png.
* platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/pausebutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/playpausebutton/pausebutton.png.
* platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playbutton.png.
* platform/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/playpausebutton/playpause_button.edc.
* platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackward_button.edc.
* platform/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackwardbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekbackwardbutton/seekbackwardbutton.png.
* platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforward_button.edc.
* platform/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforwardbutton.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/seekforwardbutton/seekforwardbutton.png.
* platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption.png.
* platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption_disabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/closedcaption_disabled.png.
* platform/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/mediacontrol/togglecaptionsbutton/toggle_captions_button.edc.
* platform/efl/DefaultTheme/widget/progressbar/bt_base.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/progressbar/bt_base.png.
* platform/efl/DefaultTheme/widget/progressbar/progressbar.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/progressbar/progressbar.edc.
* platform/efl/DefaultTheme/widget/progressbar/shelf_inset.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/progressbar/shelf_inset.png.
* platform/efl/DefaultTheme/widget/radio/img_radio_bg_disabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_disabled.png.
* platform/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_bg_enabled.png.
* platform/efl/DefaultTheme/widget/radio/img_radio_off.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_off.png.
* platform/efl/DefaultTheme/widget/radio/img_radio_off_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_off_focus.png.
* platform/efl/DefaultTheme/widget/radio/img_radio_off_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_off_hover.png.
* platform/efl/DefaultTheme/widget/radio/img_radio_on.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_on.png.
* platform/efl/DefaultTheme/widget/radio/img_radio_on_focus.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_on_focus.png.
* platform/efl/DefaultTheme/widget/radio/img_radio_on_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/img_radio_on_hover.png.
* platform/efl/DefaultTheme/widget/radio/radio.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/radio/radio.edc.
* platform/efl/DefaultTheme/widget/scrollbar/scrollbar.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar.edc.
* platform/efl/DefaultTheme/widget/scrollbar/scrollbar_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_h.png.
* platform/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_h.png.
* platform/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_knob_v.png.
* platform/efl/DefaultTheme/widget/scrollbar/scrollbar_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/scrollbar/scrollbar_v.png.
* platform/efl/DefaultTheme/widget/search/cancel/cancel_normal_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/cancel/cancel_normal_button.png.
* platform/efl/DefaultTheme/widget/search/cancel/cancel_normal_button2.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/cancel/cancel_normal_button2.png.
* platform/efl/DefaultTheme/widget/search/cancel/search_cancel.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/cancel/search_cancel.edc.
* platform/efl/DefaultTheme/widget/search/decoration/decoration_normal_button.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/decoration/decoration_normal_button.png.
* platform/efl/DefaultTheme/widget/search/decoration/search_decoration.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/decoration/search_decoration.edc.
* platform/efl/DefaultTheme/widget/search/field/field_focused.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/field_focused.png.
* platform/efl/DefaultTheme/widget/search/field/field_hovered.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/field_hovered.png.
* platform/efl/DefaultTheme/widget/search/field/field_normal.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/field_normal.png.
* platform/efl/DefaultTheme/widget/search/field/search_field.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/search/field/search_field.edc.
* platform/efl/DefaultTheme/widget/slider/slider.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider.edc.
* platform/efl/DefaultTheme/widget/slider/slider_fill_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_fill_h.png.
* platform/efl/DefaultTheme/widget/slider/slider_fill_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_fill_v.png.
* platform/efl/DefaultTheme/widget/slider/slider_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_h.png.
* platform/efl/DefaultTheme/widget/slider/slider_thumb_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_h.png.
* platform/efl/DefaultTheme/widget/slider/slider_thumb_press_h.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_press_h.png.
* platform/efl/DefaultTheme/widget/slider/slider_thumb_press_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_press_v.png.
* platform/efl/DefaultTheme/widget/slider/slider_thumb_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_thumb_v.png.
* platform/efl/DefaultTheme/widget/slider/slider_v.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/slider/slider_v.png.
* platform/efl/DefaultTheme/widget/spinner/sp_bg.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_bg.png.
* platform/efl/DefaultTheme/widget/spinner/sp_down_default.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_down_default.png.
* platform/efl/DefaultTheme/widget/spinner/sp_down_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_down_hover.png.
* platform/efl/DefaultTheme/widget/spinner/sp_down_pressed.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_down_pressed.png.
* platform/efl/DefaultTheme/widget/spinner/sp_up_default.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_up_default.png.
* platform/efl/DefaultTheme/widget/spinner/sp_up_hover.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_up_hover.png.
* platform/efl/DefaultTheme/widget/spinner/sp_up_pressed.png: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/sp_up_pressed.png.
* platform/efl/DefaultTheme/widget/spinner/spinner.edc: Renamed from Source/WebKit/efl/DefaultTheme/widget/spinner/spinner.edc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r139835): fast/js/integer-division-neg2tothe32-by-neg1.html is failing
ossy@webkit.org [Wed, 16 Jan 2013 10:07:14 +0000 (10:07 +0000)]
REGRESSION(r139835): fast/js/integer-division-neg2tothe32-by-neg1.html is failing
https://bugs.webkit.org/show_bug.cgi?id=106991

Unreviewed gardening, updated expected file.

* fast/js/integer-division-neg2tothe32-by-neg1-expected.txt:
* platform/chromium/fast/js/integer-division-neg2tothe32-by-neg1-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 10:06:59 +0000 (10:06 +0000)]
[Chromium] Unreviewed gardening.

Roll Chromium to 177117.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 16 Jan 2013 10:05:58 +0000 (10:05 +0000)]
Unreviewed GTK gardening.

Adding a failure expectation for fast/js/integer-division-neg2tothe32-by-neg1.html.
The test started failing after r139835.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize()
haraken@chromium.org [Wed, 16 Jan 2013 10:02:13 +0000 (10:02 +0000)]
[V8] Make an Isolate parameter mandatory in SerializedScriptValue::deserialize()
https://bugs.webkit.org/show_bug.cgi?id=106916

Reviewed by Adam Barth.

This is one of steps to remove optional Isolate parameters.

No tests. No change in behavior.

* bindings/v8/SerializedScriptValue.cpp:
(WebCore::SerializedScriptValue::deserialize):
(WebCore):
(WebCore::SerializedScriptValue::deserializeForInspector):
* bindings/v8/SerializedScriptValue.h:
(SerializedScriptValue):
* bindings/v8/custom/V8HistoryCustom.cpp:
(WebCore::V8History::stateAccessorGetter):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAccessorGetter):
* bindings/v8/custom/V8PopStateEventCustom.cpp:
(WebCore::V8PopStateEvent::stateAccessorGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Inspector] Add events for tracking page loads and scheduled navigations.
commit-queue@webkit.org [Wed, 16 Jan 2013 09:50:19 +0000 (09:50 +0000)]
[Inspector] Add events for tracking page loads and scheduled navigations.
https://bugs.webkit.org/show_bug.cgi?id=104168

Patch by Ken Kania <kkania@chromium.org> on 2013-01-16
Reviewed by Pavel Feldman.

These events are needed for clients who need to be aware of when a page is
navigating or about to navigate. Some clients may wish to prevent interaction
with the page during this time. Two of the new events track loading start and
stop, as measured by the ProgressTracker. The other two events track when a
page has a new scheduled navigation and when it no longer has a scheduled
navigation. These latter two events won't allow the client to determine if
a load is going to happen in all circumstances, but is sufficient for many cases.

Source/WebCore:

Tests: inspector-protocol/page/frameScheduledNavigation.html
       inspector-protocol/page/frameStartedLoading.html

* inspector/Inspector.json:
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::frameStartedLoadingImpl):
(WebCore::InspectorInstrumentation::frameStoppedLoadingImpl):
(WebCore::InspectorInstrumentation::frameScheduledNavigationImpl):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigationImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::frameStartedLoading):
(WebCore):
(WebCore::InspectorInstrumentation::frameStoppedLoading):
(WebCore::InspectorInstrumentation::frameScheduledNavigation):
(WebCore::InspectorInstrumentation::frameClearedScheduledNavigation):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::frameStartedLoading):
(WebCore):
(WebCore::InspectorPageAgent::frameStoppedLoading):
(WebCore::InspectorPageAgent::frameScheduledNavigation):
(WebCore::InspectorPageAgent::frameClearedScheduledNavigation):
* inspector/InspectorPageAgent.h:
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameDetached):
(WebInspector.PageDispatcher.prototype.frameStartedLoading):
(WebInspector.PageDispatcher.prototype.frameStoppedLoading):
(WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
(WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
* loader/NavigationScheduler.cpp:
(WebCore::NavigationScheduler::clear):
(WebCore::NavigationScheduler::timerFired):
(WebCore::NavigationScheduler::startTimer):
(WebCore::NavigationScheduler::cancel):
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):

LayoutTests:

* inspector-protocol/page/frameScheduledNavigation-expected.txt: Added.
* inspector-protocol/page/frameScheduledNavigation.html: Added.
* inspector-protocol/page/frameStartedLoading-expected.txt: Added.
* inspector-protocol/page/frameStartedLoading.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Wed, 16 Jan 2013 09:47:24 +0000 (09:47 +0000)]
Unreviewed GTK gardening.

Rebaselining after r139798.

* platform/gtk/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/gtk/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 09:45:41 +0000 (09:45 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline this test on Linux after r139798:

http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm

* platform/chromium-linux/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] add title text direction attribute to TestRunner
jochen@chromium.org [Wed, 16 Jan 2013 09:42:33 +0000 (09:42 +0000)]
[chromium] add title text direction attribute to TestRunner
https://bugs.webkit.org/show_bug.cgi?id=106907

Reviewed by Adam Barth.

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::reset):
* DumpRenderTree/chromium/DRTTestRunner.h:
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner::WebTestRunner::setTitleTextDirection):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setTitleTextDirection):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::didReceiveTitle):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::didReceiveTitle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Update MediaStreamTrack::readyState to match specification
tommyw@google.com [Wed, 16 Jan 2013 09:34:29 +0000 (09:34 +0000)]
MediaStream API: Update MediaStreamTrack::readyState to match specification
https://bugs.webkit.org/show_bug.cgi?id=106781

Reviewed by Kentaro Hara.

Source/WebCore:

MediaStreamTrack::readyState now returns a string like the rest of the RTC classes.

Existing tests expanded to cover patch.

* Modules/mediastream/MediaStream.cpp:
(WebCore::processTrack):
* Modules/mediastream/MediaStreamTrack.cpp:
(WebCore::MediaStreamTrack::readyState):
(WebCore::MediaStreamTrack::ended):
(WebCore):
* Modules/mediastream/MediaStreamTrack.h:
(MediaStreamTrack):
* Modules/mediastream/MediaStreamTrack.idl:

LayoutTests:

* fast/mediastream/MediaStreamTrack-expected.txt:
* fast/mediastream/MediaStreamTrack.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: array grouping does not work for big and negative number keys
aandrey@chromium.org [Wed, 16 Jan 2013 09:24:26 +0000 (09:24 +0000)]
Web Inspector: array grouping does not work for big and negative number keys
https://bugs.webkit.org/show_bug.cgi?id=106891

Reviewed by Pavel Feldman.

Source/WebCore:

Fixing array grouping for arrays that contain big or negative number representations as object keys.

* inspector/front-end/ObjectPropertiesSection.js:
(.buildObjectFragment):

LayoutTests:

* inspector/console/console-big-array-expected.txt:
* inspector/console/console-big-array.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 09:13:23 +0000 (09:13 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline this test after r139835:

fast/js/integer-division-neg2tothe32-by-neg1.html

* platform/chromium/fast/js/integer-division-neg2tothe32-by-neg1-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening.
zandobersek@gmail.com [Wed, 16 Jan 2013 09:07:30 +0000 (09:07 +0000)]
Unreviewed gardening.

Adjusting failure expectations for fast/harness/sample-fail-mismatch-reftest.html
on all ports. The expectation for the test is now marked as a WontFix image failure.

r139786 reintroduced the possibility of running tests marked as WontFix if there is
another expectation (like Failure, ImageOnlyFailure) listed for the test.

This specific test tests that the harness correctly behaves in a case of a mismatch
reftest that matches with its baseline (i.e. that an image failure is reported). As
such every port should run it to ensure correct behavior of the ImageDiff tool in combination
with NRWT.

* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 09:01:42 +0000 (09:01 +0000)]
[Chromium] Unreviewed gardening.

Baseline (and rebaseline on Linux) these tests introduced in
r139836:

fast/gradients/unprefixed-color-stop-units.html
fast/gradients/unprefixed-color-stops.html
fast/gradients/unprefixed-generated-gradients.html
fast/gradients/unprefixed-gradient-parsing.html
fast/gradients/unprefixed-linear-angle-gradients.html
fast/gradients/unprefixed-linear-right-angle-gradients.html
fast/gradients/unprefixed-list-item-gradient.html
fast/gradients/unprefixed-radial-gradients.html
fast/gradients/unprefixed-radial-gradients2.html
fast/gradients/unprefixed-radial-gradients3.html
fast/gradients/unprefixed-repeating-end-fill.html
fast/gradients/unprefixed-repeating-linear-gradient.html
fast/gradients/unprefixed-repeating-radial-gradients.html
fast/gradients/unprefixed-zero-range-repeating-gradient-hang.html

* platform/chromium-linux/fast/gradients/unprefixed-color-stop-units-expected.png:
* platform/chromium-linux/fast/gradients/unprefixed-color-stops-expected.png: Removed.
* platform/chromium-linux/fast/gradients/unprefixed-generated-gradients-expected.png: Removed.
* platform/chromium-linux/fast/gradients/unprefixed-linear-angle-gradients-expected.png:
* platform/chromium-linux/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png:
* platform/chromium-linux/fast/gradients/unprefixed-radial-gradients-expected.png:
* platform/chromium-linux/fast/gradients/unprefixed-radial-gradients2-expected.png:
* platform/chromium-linux/fast/gradients/unprefixed-radial-gradients3-expected.png: Removed.
* platform/chromium-linux/fast/gradients/unprefixed-repeating-linear-gradient-expected.png:
* platform/chromium-linux/fast/gradients/unprefixed-repeating-radial-gradients-expected.png:
* platform/chromium-linux/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Removed.
* platform/chromium-mac-lion/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-color-stops-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-list-item-gradient-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-radial-gradients2-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-repeating-end-fill-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
* platform/chromium-mac/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-color-stops-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-list-item-gradient-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/gradients/unprefixed-list-item-gradient-expected.png.
* platform/chromium-win/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-radial-gradients2-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-repeating-end-fill-expected.png: Renamed from LayoutTests/platform/chromium-linux/fast/gradients/unprefixed-repeating-end-fill-expected.png.
* platform/chromium-win/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
* platform/chromium-win/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: highlight regexp API for DefaultTextEditor
pfeldman@chromium.org [Wed, 16 Jan 2013 08:48:56 +0000 (08:48 +0000)]
Web Inspector: highlight regexp API for DefaultTextEditor
https://bugs.webkit.org/show_bug.cgi?id=106801

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-01-16
Reviewed by Pavel Feldman.

Source/WebCore:

Add highlightRegexp and removeRegexpHighlight methods to DefaultTextEditor that highlight
all occurrences of given regexp in text with given css class.
Highlight is done via spans positioned absolutely over the regexp occurences in text.

Test: inspector/editor/text-editor-highlight-regexp.html

* inspector/front-end/DefaultTextEditor.js:
(WebInspector.DefaultTextEditor.prototype.highlightRegex):
(WebInspector.DefaultTextEditor.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel):
(WebInspector.TextEditorMainPanel.prototype.highlightRegex):
(WebInspector.TextEditorMainPanel.prototype.removeRegexHighlight):
(WebInspector.TextEditorMainPanel.prototype._repaintVisibleChunks):
(WebInspector.TextEditorMainPanel.prototype._findRegexOccurrences):
(WebInspector.TextEditorMainPanel.prototype._measureRegex):
(WebInspector.TextEditorMainPanel.prototype._appendOverlayHighlight):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
* inspector/front-end/TextEditor.js:
(WebInspector.TextEditor.prototype.highlightRegex):
(WebInspector.TextEditor.prototype.removeRegexHighlight):
* inspector/front-end/textEditor.css:
(.text-editor-overlay-highlight):
(.debug-fadeout):

LayoutTests:

New layout test to verify DefaultTextEditor highlight regexp API.

* inspector/editor/text-editor-highlight-regexp-expected.txt: Added.
* inspector/editor/text-editor-highlight-regexp.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 08:05:55 +0000 (08:05 +0000)]
[Chromium] Unreviewed gardening.

Roll Chromium to r177080.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNRWT still confused about test count with --repeat-each and --iterations
commit-queue@webkit.org [Wed, 16 Jan 2013 08:02:33 +0000 (08:02 +0000)]
NRWT still confused about test count with --repeat-each and --iterations
https://bugs.webkit.org/show_bug.cgi?id=106562

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2013-01-16
Reviewed by Dirk Pranke.

Fix the printed unique test count and skipped count. This
seems to have broken in r127688 ("NRWT lies about the number
of tests that it's skipping when used with --repeat-each").

Also add a test for print_found()

* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.test_details):
(Testprinter):
(Testprinter.test_found):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed follow-up to r139769.
zandobersek@gmail.com [Wed, 16 Jan 2013 07:53:21 +0000 (07:53 +0000)]
Unreviewed follow-up to r139769.

Note that omitting the WebKit1 code from the build now
works for GTK as well.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of Node::createRareData
rniwa@webkit.org [Wed, 16 Jan 2013 07:36:55 +0000 (07:36 +0000)]
Get rid of Node::createRareData
https://bugs.webkit.org/show_bug.cgi?id=106981

Reviewed by Benjamin Poulain.

Deleted Node::createRareData. Node::ensureRareData() instantiates NodeRareData
or ElementRareData according to the node type. Also encapsulate new by create
functions in NodeRareData and ElementRareData.

* dom/Element.cpp:
(WebCore):
* dom/Element.h:
(Element):
* dom/ElementRareData.h:
(WebCore::ElementRareData::create):
(ElementRareData):
(WebCore::ElementRareData::ElementRareData):
* dom/Node.cpp:
(WebCore::Node::ensureRareData):
(WebCore):
* dom/Node.h:
(WebCore::NodeRareDataBase::NodeRareDataBase):
* dom/NodeRareData.h:
(NodeRareData):
(WebCore::NodeRareData::create):
(WebCore::NodeRareData::NodeRareData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGTK+ and Qt build fix after r139833.
rniwa@webkit.org [Wed, 16 Jan 2013 06:52:40 +0000 (06:52 +0000)]
GTK+ and Qt build fix after r139833.
Explicitly cast NodeRareDataBase to NodeRareData before deleting it.

* dom/Node.cpp:
(WebCore::Node::clearRareData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove extra space in CustomFilterRenderer.h
commit-queue@webkit.org [Wed, 16 Jan 2013 06:46:33 +0000 (06:46 +0000)]
Remove extra space in CustomFilterRenderer.h
https://bugs.webkit.org/show_bug.cgi?id=105783

Patch by Qiankun Miao <qiankun.miao@intel.com> on 2013-01-15
Reviewed by Dean Jackson.

* platform/graphics/filters/CustomFilterRenderer.h:
(CustomFilterRenderer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Update CSS3 gradient support to the latest spec version and unprefix.
commit-queue@webkit.org [Wed, 16 Jan 2013 06:15:31 +0000 (06:15 +0000)]
Source/WebCore: Update CSS3 gradient support to the latest spec version and unprefix.
https://bugs.webkit.org/show_bug.cgi?id=67166

Patch by Tab Atkins <tabatkins@google.com> on 2013-01-15
Reviewed by Dean Jackson.

Tests: fast/gradients/unprefixed-color-stop-units.html
       fast/gradients/unprefixed-color-stops.html
       fast/gradients/unprefixed-generated-gradients.html
       fast/gradients/unprefixed-gradient-parsing.html
       fast/gradients/unprefixed-linear-angle-gradients.html
       fast/gradients/unprefixed-linear-right-angle-gradients.html
       fast/gradients/unprefixed-list-item-gradient.html
       fast/gradients/unprefixed-radial-gradients.html
       fast/gradients/unprefixed-radial-gradients2.html
       fast/gradients/unprefixed-radial-gradients3.html
       fast/gradients/unprefixed-repeating-end-fill.html
       fast/gradients/unprefixed-repeating-linear-gradient.html
       fast/gradients/unprefixed-repeating-radial-gradients.html
       fast/gradients/unprefixed-zero-range-repeating-gradient-hang.html

* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::computeEndPoint): Rename parameters to make more sense.
(WebCore::CSSLinearGradientValue::customCssText):
(WebCore::CSSLinearGradientValue::createGradient):
(WebCore::CSSRadialGradientValue::customCssText):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSGradientValue.h:
(CSSGradientValue):
(CSSRadialGradientValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseLinearGradient):
(WebCore::CSSParser::parseRadialGradient):
(WebCore::CSSParser::isGeneratedImageValue):
(WebCore::CSSParser::parseGeneratedImage):
* css/CSSParser.h:

LayoutTests: Update CSS3 gradient support to the latest spec version
https://bugs.webkit.org/show_bug.cgi?id=67166

Patch by Tab Atkins <jackalmage@gmail.com> on 2013-01-15
Reviewed by Dean Jackson.

* fast/gradients/unprefixed-color-stop-units-expected.txt: Added.
* fast/gradients/unprefixed-color-stop-units.html: Added.
* fast/gradients/unprefixed-color-stops-expected.txt: Added.
* fast/gradients/unprefixed-color-stops.html: Added.
* fast/gradients/unprefixed-generated-gradients-expected.txt: Added.
* fast/gradients/unprefixed-generated-gradients.html: Added.
* fast/gradients/unprefixed-gradient-parsing-expected.txt: Added.
* fast/gradients/unprefixed-gradient-parsing.html: Added.
* fast/gradients/unprefixed-linear-angle-gradients-expected.txt: Added.
* fast/gradients/unprefixed-linear-angle-gradients.html: Added.
* fast/gradients/unprefixed-linear-right-angle-gradients-expected.txt: Added.
* fast/gradients/unprefixed-linear-right-angle-gradients.html: Added.
* fast/gradients/unprefixed-list-item-gradient-expected.txt: Added.
* fast/gradients/unprefixed-list-item-gradient.html: Added.
* fast/gradients/unprefixed-radial-gradients-expected.txt: Added.
* fast/gradients/unprefixed-radial-gradients.html: Added.
* fast/gradients/unprefixed-radial-gradients2-expected.txt: Added.
* fast/gradients/unprefixed-radial-gradients2.html: Added.
* fast/gradients/unprefixed-radial-gradients3-expected.txt: Added.
* fast/gradients/unprefixed-radial-gradients3.html: Added.
* fast/gradients/unprefixed-repeating-end-fill-expected.txt: Added.
* fast/gradients/unprefixed-repeating-end-fill.html: Added.
* fast/gradients/unprefixed-repeating-linear-gradient-expected.txt: Added.
* fast/gradients/unprefixed-repeating-linear-gradient.html: Added.
* fast/gradients/unprefixed-repeating-radial-gradients-expected.txt: Added.
* fast/gradients/unprefixed-repeating-radial-gradients.html: Added.
* fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.txt: Added.
* fast/gradients/unprefixed-zero-range-repeating-gradient-hang.html: Added.
* platform/chromium-linux/fast/gradients/unprefixed-color-stop-units-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-color-stops-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-generated-gradients-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-linear-angle-gradients-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-linear-right-angle-gradients-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-list-item-gradient-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-radial-gradients-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-radial-gradients2-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-radial-gradients3-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-repeating-end-fill-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-repeating-linear-gradient-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-repeating-radial-gradients-expected.png: Added.
* platform/chromium-linux/fast/gradients/unprefixed-zero-range-repeating-gradient-hang-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG X86: division in the used-as-int case doesn't correctly check for -2^31/-1
msaboff@apple.com [Wed, 16 Jan 2013 05:47:09 +0000 (05:47 +0000)]
DFG X86: division in the used-as-int case doesn't correctly check for -2^31/-1
https://bugs.webkit.org/show_bug.cgi?id=106978

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Changed the numerator equal to -2^31 check to just return if we expect an integer
result, since the check is after we have determined that the denominator is -1.
The int result of -2^31 / -1 is -2^31, so just return the numerator as the result.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileIntegerArithDivForX86):

LayoutTests:

Added a new DFG check for -2^31 / -1 when we expect and integer result.

* fast/js/integer-division-neg2tothe32-by-neg1-expected.txt:
* fast/js/script-tests/integer-division-neg2tothe32-by-neg1.js:
(myDivExpectingInt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 05:25:37 +0000 (05:25 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline this test on Win after r139798:

http/tests/misc/object-embedding-svg-delayed-size-negotiation-2.htm

* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.png:
* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNodeRareData doesn't need to have a vtable pointer
rniwa@webkit.org [Wed, 16 Jan 2013 05:23:04 +0000 (05:23 +0000)]
NodeRareData doesn't need to have a vtable pointer
https://bugs.webkit.org/show_bug.cgi?id=106965

Reviewed by Benjamin Poulain.

Made the destructor and reportMemoryUsage of NodeRareDataBase and NodeRareData
respectively and their subclasses non-virtual.

* dom/ElementRareData.cpp:
(SameSizeAsElementRareData): Added.
(WebCore): Added a compile assertion for the size of ElementRareData.
* dom/ElementRareData.h:
(ElementRareData):
* dom/Node.cpp:
(WebCore::Node::clearRareData): Explicitely delete NodeRareData or ElementRareData.
(WebCore::Node::reportMemoryUsage): Explicitely add NodeRareData or ElementRareData.
* dom/Node.h:
(NodeRareDataBase): Deleted the virtual destructor.
* dom/NodeRareData.cpp:
(SameSizeAsNodeRareData): Removed one pointer.
* dom/NodeRareData.h:
(NodeRareData): Removed the virtual destructor.
(NodeRareData::reportMemoryUsage): Made non-virtual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 05:10:13 +0000 (05:10 +0000)]
[Chromium] Unreviewed gardening.

Rebaseline this test after r139798:

svg/zoom/page/zoom-replaced-intrinsic-ratio-001.html

* platform/chromium-mac-lion/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:
* platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.png:
* platform/chromium/TestExpectations:
* platform/chromium/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt: Generalize LayoutTests/platform/chromium-win/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotest-webkitpy: truncate output to the terminal width when necessary
dpranke@chromium.org [Wed, 16 Jan 2013 04:44:48 +0000 (04:44 +0000)]
test-webkitpy: truncate output to the terminal width when necessary
https://bugs.webkit.org/show_bug.cgi?id=106973

Reviewed by Ojan Vafai.

this implements the same logic for test-webkitpy that we have
for run-webkit-tests (and ninja).

No tests written as this is exercised by running test-webkitpy itself.

* Scripts/webkitpy/test/printer.py:
(Printer.configure):
(Printer._test_line):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoremove extraneous output in test-webkitpy
dpranke@chromium.org [Wed, 16 Jan 2013 04:42:47 +0000 (04:42 +0000)]
remove extraneous output in test-webkitpy
https://bugs.webkit.org/show_bug.cgi?id=106971

Reviewed by Ojan Vafai.

We weren't ignoring or capturing the echoed output from
these two tests, and getting noise in the logs as a result.

* Scripts/webkitpy/common/system/executive_unittest.py:
(ExecutiveTest.test_auto_stringify_args):
(ExecutiveTest.test_popen_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Create GraphicsLayerChromiums using a factory
vollick@chromium.org [Wed, 16 Jan 2013 04:36:33 +0000 (04:36 +0000)]
[chromium] Create GraphicsLayerChromiums using a factory
https://bugs.webkit.org/show_bug.cgi?id=103635

Reviewed by James Robinson.

Refactor graphics layer creation for chromium to go through a factory.

Source/WebCore:

No new tests, no change in functionality.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayer::create):

Source/WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebCore):
(GraphicsLayerFactoryChromium):
(WebCore::GraphicsLayerFactoryChromium::~GraphicsLayerFactoryChromium):
(WebKit::ChromeClientImpl::ChromeClientImpl):
(WebKit::ChromeClientImpl::graphicsLayerFactory):
(WebKit):
* src/ChromeClientImpl.h:
(WebCore):
(ChromeClientImpl):
* src/NonCompositedContentHost.cpp:
(WebKit::NonCompositedContentHost::NonCompositedContentHost):
* src/NonCompositedContentHost.h:
(WebCore):
(WebKit::NonCompositedContentHost::create):
(NonCompositedContentHost):
* src/PageOverlay.cpp:
(WebKit::PageOverlay::update):
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::graphicsLayerFactory):
(WebKit):
(WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
* src/WebViewImpl.h:
(WebCore):
(WebViewImpl):
* tests/GraphicsLayerChromiumTest.cpp:
(WebKit::GraphicsLayerChromiumTest::GraphicsLayerChromiumTest):
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] LayerRenderingResults doesn't need to maintain the hole punch rect
charles.wei@torchmobile.com.cn [Wed, 16 Jan 2013 03:53:35 +0000 (03:53 +0000)]
[BlackBerry]  LayerRenderingResults doesn't need to maintain the hole punch rect
https://bugs.webkit.org/show_bug.cgi?id=106896

Reviewed by George Staikos.
Internally reviewed by Arvid Nilsson and John Griggs.

No new tests,clean up code which is not used anymore.

* platform/graphics/blackberry/LayerRenderer.cpp:
(WebCore::LayerRenderer::drawHolePunchRect):
* platform/graphics/blackberry/LayerRenderer.h:
(LayerRenderingResults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agowebkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_an...
dpranke@chromium.org [Wed, 16 Jan 2013 03:44:37 +0000 (03:44 +0000)]
webkitpy.layout_tests.servers.http_server_unittest.TestHttpServer.test_win32_start_and_stop is flaky
https://bugs.webkit.org/show_bug.cgi?id=106974

Reviewed by Ryosuke Niwa.

I forgot to stub out the call to check to ensure that the ports were
available, so this test could fail if something was listening on 8000 or
8443 on the machine.

* Scripts/webkitpy/layout_tests/servers/http_server_unittest.py:
(TestHttpServer.test_win32_start_and_stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 03:20:01 +0000 (03:20 +0000)]
[Chromium] Unreviewed gardening.

Add expectations for this test:

scrollingcoordinator/non-fast-scrollable-region-scaled-iframe.html

On the Chromium Mac Debug bot it is drawn with system scrollbars;
see <https://bugs.webkit.org/show_bug.cgi?id=106858>

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMerge LayerTreeHostCA and LayerTreeHostMac
andersca@apple.com [Wed, 16 Jan 2013 03:12:01 +0000 (03:12 +0000)]
Merge LayerTreeHostCA and LayerTreeHostMac
https://bugs.webkit.org/show_bug.cgi?id=106967

Reviewed by Sam Weinig.

There's no need to have a LayerTreeHostCA base class anymore, just merge it into LayerTreeHostMac.

* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/ca/LayerTreeHostCA.cpp: Removed.
* WebProcess/WebPage/ca/LayerTreeHostCA.h: Removed.
* WebProcess/WebPage/mac/LayerTreeHostMac.h:
(LayerTreeHostMac):
* WebProcess/WebPage/mac/LayerTreeHostMac.mm:
(WebKit::LayerTreeHostMac::LayerTreeHostMac):
(WebKit::LayerTreeHostMac::~LayerTreeHostMac):
(WebKit::LayerTreeHostMac::layerTreeContext):
(WebKit::LayerTreeHostMac::setShouldNotifyAfterNextScheduledLayerFlush):
(WebKit):
(WebKit::LayerTreeHostMac::setRootCompositingLayer):
(WebKit::LayerTreeHostMac::invalidate):
(WebKit::LayerTreeHostMac::setNonCompositedContentsNeedDisplay):
(WebKit::LayerTreeHostMac::scrollNonCompositedContents):
(WebKit::LayerTreeHostMac::forceRepaint):
(WebKit::LayerTreeHostMac::sizeDidChange):
(WebKit::LayerTreeHostMac::deviceScaleFactorDidChange):
(WebKit::LayerTreeHostMac::didInstallPageOverlay):
(WebKit::LayerTreeHostMac::didUninstallPageOverlay):
(WebKit::LayerTreeHostMac::setPageOverlayNeedsDisplay):
(WebKit::LayerTreeHostMac::pauseRendering):
(WebKit::LayerTreeHostMac::resumeRendering):
(WebKit::LayerTreeHostMac::setLayerHostingMode):
(WebKit::LayerTreeHostMac::notifyAnimationStarted):
(WebKit::LayerTreeHostMac::notifyFlushRequired):
(WebKit::LayerTreeHostMac::paintContents):
(WebKit::LayerTreeHostMac::deviceScaleFactor):
(WebKit::LayerTreeHostMac::flushLayers):
(WebKit::LayerTreeHostMac::initialize):
(WebKit::LayerTreeHostMac::performScheduledLayerFlush):
(WebKit::LayerTreeHostMac::flushPendingLayerChanges):
(WebKit::LayerTreeHostMac::createPageOverlayLayer):
(WebKit::LayerTreeHostMac::destroyPageOverlayLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFullscreen element should not share styles with it's siblings.
charles.wei@torchmobile.com.cn [Wed, 16 Jan 2013 03:02:58 +0000 (03:02 +0000)]
Fullscreen element should not share styles with it's siblings.
https://bugs.webkit.org/show_bug.cgi?id=106888

Reviewed by George Staikos.

Source/WebCore:

Test: fullscreen/full-screen-no-style-sharing.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::canShareStyleWithElement):

LayoutTests:

* fullscreen/full-screen-no-style-sharing-expected.txt: Added.
* fullscreen/full-screen-no-style-sharing.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 03:00:27 +0000 (03:00 +0000)]
[Chromium] Unreviewed gardening.

Rebaselining this test on Windows:

svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource.html

The Chromium XP and Win7 bots' results look consistent and the
spurious grey areas are already being tracked by bug 80517.

* platform/chromium-win/svg/dynamic-updates/SVGFESpecularLightingElement-remove-lightSource-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoClamp TileCache visibleRect to WKView's visibleRect
timothy_horton@apple.com [Wed, 16 Jan 2013 02:51:17 +0000 (02:51 +0000)]
Clamp TileCache visibleRect to WKView's visibleRect
https://bugs.webkit.org/show_bug.cgi?id=106601
<rdar://problem/12843164>

Reviewed by Simon Fraser.

Some clients expand the WKView to be much larger than what is visible on screen, and
control scrolling with their own view. Currently, we will create tiles for the entire
view, consuming a great deal of memory, and can sometimes factor scrollbars which can
never exist into layout. Piggyback on WKView SPI (the property minimumWidthForAutoLayout,
renamed from minimumLayoutWidth) to drop into a mode where we disable main frame scrolling
and respect the WKView's visibleRect when creating tiles.

* UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]): Update the page's viewExposedRect from our visibleRect.
(-[WKView _updateWindowAndViewFrames]): Update the page's viewExposedRect from our visibleRect.
(-[WKView initWithFrame:contextRef:pageGroupRef:relatedToPage:]): The main frame is scrollable by default.
(-[WKView enableFrameSizeUpdates]): If frame size updates become enabled, update the
page's viewExposedRect from our visibleRect.
(-[WKView setMinimumLayoutWidth:]): Rename minimumLayoutWidth property to minimumWidthForAutoLayout.
Warn once if the old one is used.
(-[WKView minimumWidthForAutoLayout]):
(-[WKView setMinimumWidthForAutoLayout:]): Adjust the minimum layout width, whether the main frame
is scrollable, and update the page's viewExposedRect if needed.
* UIProcess/API/mac/WKViewPrivate.h: Added minimumWidthForAutoLayout property.
* UIProcess/WebPageProxy.h:
(WebPageProxy): Add viewExposedRectChanged/setMainFrameIsScrollable.
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged): Forward viewExposedRectChanged to WebPage.
(WebKit::WebPageProxy::setMainFrameIsScrollable): Forward setMainFrameIsScrollable to WebPage.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::transitionToCommittedForNewPage): Disable scrollbars and scrolling if
main frame scrollability is disabled.
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setExposedRect): Added empty default implementation.
(WebKit::DrawingArea::mainFrameScrollabilityChanged): Added empty default implementation.
(DrawingArea):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::windowAndViewFramesChanged): We don't need the WebCore:: namespace.
(WebKit::WebPage::viewExposedRectChanged): Forward exposed rect changes to DrawingArea (only TiledCoreAnimationDrawingArea cares, for now).
(WebKit::WebPage::setMainFrameIsScrollable): Forward scrollability changes to DrawingArea and the main FrameView.
(WebKit::WebPage::drawRectToImage): We don't need the WebCore:: namespace.
* WebProcess/WebPage/WebPage.h:
(WebPage): Add mainFrameIsScrollable, viewExposedRectChanged, setMainFrameIsScrollable, and storage for m_mainFrameIsScrollable.
(WebKit::WebPage::mainFrameIsScrollable):
* WebProcess/WebPage/WebPage.messages.in: Add ViewExposedRectChanged and SetMainFrameIsScrollable messages.
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect): Forward new exposed rect to TiledBacking (only TileCache cares, for now).
(WebKit::TiledCoreAnimationDrawingArea::mainFrameScrollabilityChanged): Ask TiledBacking to clip to the exposedRect if main frame scrolling is disabled.
(WebKit::TiledCoreAnimationDrawingArea::updateGeometry): Use size instead of viewSize in case we've changed it because of m_minimumLayoutWidth.
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer): Update exposedRect and clipsToExposedRect.

* platform/graphics/TiledBacking.h:
(TiledBacking): Add setExposedRect and setClipsToExposedRect.
* platform/graphics/ca/mac/TileCache.h:
(TileCache): Add setExposedRect, setClipsToExposedRect, and storage for their respective values.
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::TileCache): Initialize m_clipsToExposedRect to false.
(WebCore::TileCache::setExposedRect): Update exposedRect and revalidate tiles.
(WebCore::TileCache::setClipsToExposedRect): Update clipsToExposedRect and revalidate tiles;
if we're going from unclipped to clipped, we already have tiles, so we can skip tile revalidation.
(WebCore::TileCache::computeTileCoverageRect): Intersect exisiting visible rect with
exposed rect to get the visible rect we actually care about.
(WebCore::TileCache::revalidateTiles): Ditto.
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::requiresOverhangAreasLayer): Don't create an overhang layer if the frame isn't scrollable.
(WebCore::RenderLayerCompositor::requiresContentShadowLayer): Don't create a shadow layer if the frame isn't scrollable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r139792.
leviw@chromium.org [Wed, 16 Jan 2013 02:39:17 +0000 (02:39 +0000)]
Unreviewed, rolling out r139792.
http://trac.webkit.org/changeset/139792
https://bugs.webkit.org/show_bug.cgi?id=106970

Broke the windows build.

Source/JavaScriptCore:

* bytecode/GlobalResolveInfo.h: Removed property svn:mergeinfo.

Tools:

* DumpRenderTree/chromium/DRTTestRunner.cpp:
(DRTTestRunner::DRTTestRunner):
(DRTTestRunner::notifyDone):
(DRTTestRunner::reset):
(DRTTestRunner::setAlwaysAcceptCookies):
(DRTTestRunner::setWindowIsKey):
(DRTTestRunner::pathToLocalResource):
(DRTTestRunner::setPOSIXLocale):
(InvokeCallbackTask):
(InvokeCallbackTask::InvokeCallbackTask):
(InvokeCallbackTask::runIfValid):
(DRTTestRunner::setBackingScaleFactor):
* DumpRenderTree/chromium/DRTTestRunner.h:
(DRTTestRunner):
(DRTTestRunner::taskList):
* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner::WebTestDelegate::setDatabaseQuota):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
(WebTestRunner::TestRunner::setDatabaseQuota):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::setPendingExtraData):
(WebViewHost::setDeviceScaleFactor):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139821 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening.
dominicc@chromium.org [Wed, 16 Jan 2013 02:38:07 +0000 (02:38 +0000)]
[Chromium] Unreviewed gardening.

Add expectations for this test:

inspector/extensions/extensions-reload.html

This is flakily slow on the Chromium Win7 Release bot.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet rid of a straggling dependency on SafariThemeConstants in RenderThemeWin.
roger_fong@apple.com [Wed, 16 Jan 2013 02:21:45 +0000 (02:21 +0000)]
Get rid of a straggling dependency on SafariThemeConstants in RenderThemeWin.

Rubberstamped by Timothy Horton.

* rendering/RenderThemeWin.cpp:
(WebCore::RenderThemeWin::supportsClosedCaptioning):
* rendering/RenderThemeWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.
rniwa@webkit.org [Wed, 16 Jan 2013 02:12:33 +0000 (02:12 +0000)]
Build fix after r139357. The port name of MacWK2EWS should be 'mac-wk2'.

* Scripts/webkitpy/common/config/ports.py:
(MacWK2Port):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGroup all request parameters which are used to match CSS Rules into a parameter object.
hayato@chromium.org [Wed, 16 Jan 2013 02:06:05 +0000 (02:06 +0000)]
Group all request parameters which are used to match CSS Rules into a parameter object.
https://bugs.webkit.org/show_bug.cgi?id=106879

Reviewed by Dimitri Glazkov.

Introduces a MatchRequest which groups all request parameters to match CSS rules.

Factoring, no change in behavior.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
* css/StyleResolver.h:
(WebCore::StyleResolver::MatchRequest::MatchRequest):
(MatchRequest):
(StyleResolver):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix build break by r139796.
gyuyoung.kim@samsung.com [Wed, 16 Jan 2013 02:02:52 +0000 (02:02 +0000)]
Unreviewed. Fix build break by r139796.

* ewk/ewk_frame.cpp:
(ewk_frame_text_matches_mark):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd the ability for a RenderLayerBacking to have a layer that renders backgrounds.
simon.fraser@apple.com [Wed, 16 Jan 2013 02:01:39 +0000 (02:01 +0000)]
Add the ability for a RenderLayerBacking to have a layer that renders backgrounds.
https://bugs.webkit.org/show_bug.cgi?id=106961

Reviewed by Dean Jackson.

In some cases we need a compositing layer to render its background into
a separate GraphicsLayer (e.g. for background-attachment: fixed in some scenarios).

To support this, have RenderLayer optionally create a GraphicsLayer for the background.
Currently nothing causes background layers to get created.

Having a background layer requires that we add an additional containment layer
which encloses the background, primary and foreground layers, since the
background layer has to be composited behind the primary content. This containment
layer gets any transform, including page scale on the RenderView's layer.

No new tests; there's no way to create a background layer yet. This was tested during
development by forcing a background layer.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::updateDebugIndicators): Show borders on both new layers
and repaint counters on the background layer.
(WebCore::RenderLayerBacking::destroyGraphicsLayers): Clear the two new layers.
(WebCore::RenderLayerBacking::updateTransform): If we have a containment layer, it
takes the transform (and clear the transform on the primary layer).
(WebCore::RenderLayerBacking::updateGraphicsLayerConfiguration): Make the background
layer if we need one (currently never).
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Position and size
the containment layer if we have one. If we do, then the m_graphicsLayer will
be at 0,0 in that containment layer. The background layer is also sized similarly
to the foreground layer.
(WebCore::RenderLayerBacking::updateInternalHierarchy): Adapt to the new hierarchy
with containment and background layers if we have them.
(WebCore::RenderLayerBacking::updateBackgroundLayer): Here's where we create the background
and containment layers.
(WebCore::RenderLayerBacking::childForSuperlayers): If we have a containment layer, that's
what gets attached to our parent.
(WebCore::RenderLayerBacking::getCurrentTransform): The containment layer gets the transform
if we have one, so check that here.
(WebCore::RenderLayerBacking::backingStoreMemoryEstimate):
(WebCore::RenderLayerBacking::reportMemoryUsage):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::deviceOrPageScaleFactorChanged): We need to start notifying
about page/device scale on the containment layer if there is one (since it takes page scale), so
use childForSuperlayers() rather than just getting the primary layer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove Key3 and Challenge Response fields from Websocket implementation and Web Inspe...
commit-queue@webkit.org [Wed, 16 Jan 2013 01:48:37 +0000 (01:48 +0000)]
Remove Key3 and Challenge Response fields from Websocket implementation and Web Inspector.
https://bugs.webkit.org/show_bug.cgi?id=105738.

Patch by Pan Deng <pan.deng@intel.com> on 2013-01-15
Reviewed by Kent Tamura.

Key3 and Challenge Response fields were obsoleted in IETF websocket spec, this patch removes related
code in Websocket and Web Inspector

No new tests as no new functionality added.

* Modules/websockets/WebSocketHandshakeRequest.cpp: remove Key3 related code
* Modules/websockets/WebSocketHandshakeRequest.h:
(WebSocketHandshakeRequest):
* Modules/websockets/WebSocketHandshakeResponse.cpp: remove Challenge response related code
* Modules/websockets/WebSocketHandshakeResponse.h:
(WebSocketHandshakeResponse):
* inspector/Inspector.json: remove Key3 and Challenge response fields definition
* inspector/InspectorResourceAgent.cpp: remove Key3 and Challenge response field from inspector agent
(WebCore):
(WebCore::InspectorResourceAgent::willSendWebSocketHandshakeRequest):
(WebCore::InspectorResourceAgent::didReceiveWebSocketHandshakeResponse):
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkDispatcher.prototype.webSocketWillSendHandshakeRequest):
(WebInspector.NetworkDispatcher.prototype.webSocketHandshakeResponseReceived):
* inspector/front-end/RequestHeadersView.js: remove Key3 and Challenge response item from front-end.
(WebInspector.RequestHeadersView.prototype._refreshRequestHeaders):
(WebInspector.RequestHeadersView.prototype._refreshResponseHeaders):
(WebInspector.RequestHeadersView.prototype._refreshHeaders):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse MADV_FREE_REUSABLE to return JIT memory to OS
psolanki@apple.com [Wed, 16 Jan 2013 01:33:30 +0000 (01:33 +0000)]
Use MADV_FREE_REUSABLE to return JIT memory to OS
https://bugs.webkit.org/show_bug.cgi?id=106830
<rdar://problem/11437701>

Reviewed by Geoffrey Garen.

Use MADV_FREE_REUSABLE to return JIT memory on OSes that have the underlying madvise bug
fixed.

* jit/ExecutableAllocatorFixedVMPool.cpp:
(JSC::FixedVMPoolExecutableAllocator::notifyPageIsFree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT(!m_queue.killed() && m_threadID) hit in StorageThread::scheduleTask on low...
antti@apple.com [Wed, 16 Jan 2013 01:07:31 +0000 (01:07 +0000)]
ASSERT(!m_queue.killed() && m_threadID) hit in StorageThread::scheduleTask on low memory warning
https://bugs.webkit.org/show_bug.cgi?id=106960

Reviewed by Mark Rowe.

We were scheduling a memory clearing task to terminated StorageThreads.

Remove thread from the active thread list when terminate is scheduled. Add when thread is started.

* storage/StorageThread.cpp:
(WebCore::activeStorageThreads):
(WebCore::StorageThread::StorageThread):
(WebCore::StorageThread::~StorageThread):
(WebCore::StorageThread::start):
(WebCore::StorageThread::terminate):
(WebCore::StorageThread::releaseFastMallocFreeMemoryInAllThreads):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed mac rebaseline for r139798.
eae@chromium.org [Wed, 16 Jan 2013 00:45:22 +0000 (00:45 +0000)]
Unreviewed mac rebaseline for r139798.

* http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Added.
* platform/mac-wk2/svg/zoom/page: Removed.
* platform/mac/TestExpectations:
* platform/mac/http/tests/misc/object-embedding-svg-delayed-size-negotiation-2-expected.txt: Removed.
* platform/mac/svg/zoom/page/zoom-replaced-intrinsic-ratio-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix typos in WebKitFeatures.cmake
commit-queue@webkit.org [Wed, 16 Jan 2013 00:18:07 +0000 (00:18 +0000)]
Fix typos in WebKitFeatures.cmake
https://bugs.webkit.org/show_bug.cgi?id=106952

Patch by Alberto Garcia <agarcia@igalia.com> on 2013-01-15
Reviewed by Martin Robinson.

* Source/cmake/WebKitFeatures.cmake:
Replace "Toogle" with "Toggle".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't do indiscriminate cast & call in StylePropertySet::PropertyReference::cssName...
macpherson@chromium.org [Wed, 16 Jan 2013 00:16:22 +0000 (00:16 +0000)]
Don't do indiscriminate cast & call in StylePropertySet::PropertyReference::cssName() on release builds.
https://bugs.webkit.org/show_bug.cgi?id=106867

Reviewed by Darin Adler.

Check CSSValue::isVariableValue() before casting to CSSVariableValue.

Covered by existing variables tests.

* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::PropertyReference::cssName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Sub pixel layout] RTL cells with padding wraps
eae@chromium.org [Wed, 16 Jan 2013 00:14:57 +0000 (00:14 +0000)]
[Sub pixel layout] RTL cells with padding wraps
https://bugs.webkit.org/show_bug.cgi?id=106843

Source/WebCore:

Reviewed by Levi Weintraub.

At certain zoom levels table cells with padding wraps for rtl
content.

Test: fast/sub-pixel/table-rtl-padding.html

* rendering/RenderTable.h: Override paddingStart/End to return
integer values for padding as we do elsewhere in the table code.

LayoutTests:

Reviewed by Levi Weintraub.

Add test for rtl tables with padding.

* fast/sub-pixel/input-caret-on-subpixel-bound-expected.html:
* fast/sub-pixel/table-rtl-padding-expected.html: Added.
* fast/sub-pixel/table-rtl-padding.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse-after-free in AXObjectCache::notificationPostTimerFired
dmazzoni@google.com [Wed, 16 Jan 2013 00:13:15 +0000 (00:13 +0000)]
Use-after-free in AXObjectCache::notificationPostTimerFired
https://bugs.webkit.org/show_bug.cgi?id=106106

Reviewed by Ryosuke Niwa.

Source/WebCore:

Fixes a crash that occurs when a Node is adopted by another document,
in particular one that isn't part of the page, and then deleted,
which wasn't triggering the code that removed the Node from
AXObjectCache. Now, a Node is removed from the AXObjectCache whenever
its Document changes.

Test: accessibility/crash-adopt-node-from-new-document.html

* dom/Node.cpp:
(WebCore::Node::didMoveToNewDocument):

LayoutTests:

Test that demonstrates the crash when a Node with an
AccessibilityObject changes its document and then isn't removed from
the AXObjectCache when it's deleted.

* accessibility/crash-adopt-node-from-new-document-expected.txt: Added.
* accessibility/crash-adopt-node-from-new-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExtend sheriffbot's "help" command to be able to get help on individual commands
commit-queue@webkit.org [Wed, 16 Jan 2013 00:02:22 +0000 (00:02 +0000)]
Extend sheriffbot's "help" command to be able to get help on individual commands
https://bugs.webkit.org/show_bug.cgi?id=106629

Patch by Alan Cutter <alancutter@chromium.org> on 2013-01-15
Reviewed by Eric Seidel.

Added a help command to sheriffbot.
Fixed some style issues and ordered the commands alphabetically.

* Scripts/webkitpy/tool/bot/irc_command.py:
(IRCCommand):
(IRCCommand.execute):
(IRCCommand.usage):
(IRCCommand.help):
(CreateBug):
(CreateBug.execute):
(Help):
(Help.execute):
(Help._post_command_help):
(Hi):
(Hi.execute):
(Restart):
(RollChromiumDEPS):
(RollChromiumDEPS._parse_args):
(RollChromiumDEPS._expand_irc_nickname):
(RollChromiumDEPS.execute):
(Rollout):
(Rollout._extract_revisions):
(Rollout.execute):
(Sheriffs):
(Sheriffs.execute):
(Whois):
(Whois.execute):
* Scripts/webkitpy/tool/bot/ircbot_unittest.py:
(IRCBotTest.test_help):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd Canvas blend modes to Cairo
commit-queue@webkit.org [Tue, 15 Jan 2013 23:58:42 +0000 (23:58 +0000)]
Add Canvas blend modes to Cairo
https://bugs.webkit.org/show_bug.cgi?id=105074

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2013-01-15
Reviewed by Martin Robinson.

Source/WebCore:

Blend mode implementation for cairo. If BlendMode is normal, use
CompositeOperator; otherwise, consider CompositeOperator is
source-over.

Add toCairoOperator(BlendMode) to translate BlendMode to matching
cairo_operator_t.

* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::draw):
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::toCairoOperator):
* platform/graphics/cairo/CairoUtilities.h:
(WebCore):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::setPlatformCompositeOperation):

LayoutTests:

Unskip fast/canvas/canvas-blend-image.html and
fast/canvas/canvas-blend-solid.html

Add platform specific expected files because currently, expected
results are not correct.

* platform/gtk/TestExpectations:
* platform/gtk/fast/canvas/canvas-blend-image-expected.txt: Added.
* platform/gtk/fast/canvas/canvas-blend-solid-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement matching by the voice attribute for WebVTT ::cue pseudo element
commit-queue@webkit.org [Tue, 15 Jan 2013 23:49:31 +0000 (23:49 +0000)]
Implement matching by the voice attribute for WebVTT ::cue pseudo element
https://bugs.webkit.org/show_bug.cgi?id=106762

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-15
Reviewed by Eric Carlson.

Source/WebCore:

Implemented matching cue WebVTT elements by a voice attribute by adding a WebVTT specific voice attribute.
For DOM trees title attribute is used instead as this is required by specs.

* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree): set a title argument instead of a voice attribute for the DOM tree.
* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::voiceAttributeName):
* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):

LayoutTests:

* media/track/captions-webvtt/styling.vtt:
* media/track/track-css-matching-expected.txt:
* media/track/track-css-matching.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSome ScrollingCoördinator-related cleanup in RenderLayerBacking
simon.fraser@apple.com [Tue, 15 Jan 2013 23:46:18 +0000 (23:46 +0000)]
Some ScrollingCoördinator-related cleanup in RenderLayerBacking
https://bugs.webkit.org/show_bug.cgi?id=106950

Reviewed by Beth Dakin.

Wrap up code that gets the ScrollingCoordinator into a utility function.
Pull code out of updateGraphicsLayerGeometry() that registers layers with
the ScrollingCoordinator, for cleanliness.

* rendering/RenderLayerBacking.cpp:
(WebCore::scrollingCoordinatorFromLayer):
(WebCore::RenderLayerBacking::adjustTileCacheCoverage):
(WebCore::RenderLayerBacking::updateGraphicsLayerGeometry):
(WebCore::RenderLayerBacking::registerScrollingLayers):
(WebCore::RenderLayerBacking::attachToScrollingCoordinatorWithParent):
(WebCore::RenderLayerBacking::detachFromScrollingCoordinator):
* rendering/RenderLayerBacking.h:
(RenderLayerBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash when saving history with no items in it.
commit-queue@webkit.org [Tue, 15 Jan 2013 23:45:14 +0000 (23:45 +0000)]
Crash when saving history with no items in it.
https://bugs.webkit.org/show_bug.cgi?id=104261

Patch by peavo@outlook.com <peavo@outlook.com> on 2013-01-15
Reviewed by Darin Adler.

* WebHistory.cpp:
(WebHistory::saveHistoryGuts): Added null pointer check

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=106940
bdakin@apple.com [Tue, 15 Jan 2013 23:43:27 +0000 (23:43 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=106940
Suspend CSS animations for background tabs

Reviewed by Simon Fraser.

* page/Page.cpp:
(WebCore::Page::setVisibilityState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@139800 268f45cc-cd09-0410-ab3c-d52691b4dbfc