WebKit-https.git
7 years agoRemove uses of ASSERT(false)
aestes@apple.com [Sat, 5 May 2012 00:54:03 +0000 (00:54 +0000)]
Remove uses of ASSERT(false)
https://bugs.webkit.org/show_bug.cgi?id=85686

Reviewed by Dean Jackson.

Replace uses of ASSERT(false) with ASSERT_NOT_REACHED(). Also, in two places, there was code structured like:

if (expr) {
    // do something
} else {
    ASSERT(false);
}

Replace this with:

ASSERT(expr);
if (!expr)
    return;

// do something

* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::deleteOrigin):
(WebCore::DatabaseTracker::doneCreatingDatabase):
(WebCore::DatabaseTracker::doneDeletingDatabase):
(WebCore::DatabaseTracker::deleteDatabase):
* bridge/objc/objc_instance.mm:
(ObjcInstance::invokeObjcMethod):
* bridge/objc/objc_utility.mm:
(JSC::Bindings::convertObjcValueToValue):
(JSC::Bindings::objcValueTypeForType):
* dom/Node.cpp:
(WebCore::Node::createRenderer):
* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::setIconURLForPageURLInSQLDatabase):
(WebCore::IconDatabase::setIconIDForPageURLInSQLDatabase):
* platform/graphics/GraphicsContext3D.cpp:
(WebCore::doPacking):
* platform/text/BidiResolver.h:
(WebCore::::createBidiRunsForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline chromium after r116069 (bug 85031)
commit-queue@webkit.org [Sat, 5 May 2012 00:54:01 +0000 (00:54 +0000)]
Rebaseline chromium after r116069 (bug 85031)
https://bugs.webkit.org/show_bug.cgi?id=85626

Patch by David Barr <davidbarr@chromium.org> on 2012-05-04
Reviewed by Ojan Vafai.

* fast/block/float/016-expected.txt: Renamed from LayoutTests/platform/efl/fast/block/float/016-expected.txt.
* platform/chromium-linux/fast/block/float/016-expected.png:
* platform/chromium-linux/fast/css/border-solid-single-edge-antialias-expected.png: Added.
* platform/chromium-mac-leopard/fast/block/float/016-expected.png:
* platform/chromium-mac-snowleopard/fast/block/float/016-expected.png:
* platform/chromium-mac/fast/block/float/016-expected.png:
* platform/chromium-win/fast/block/float/016-expected.png:
* platform/chromium-win/fast/css/border-solid-single-edge-antialias-expected.png: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/fast/block/float/016-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CG] Minor refactor of ImageBuffer::CGImageToDataURL and its callers
noel.gordon@gmail.com [Sat, 5 May 2012 00:49:42 +0000 (00:49 +0000)]
[CG] Minor refactor of ImageBuffer::CGImageToDataURL and its callers
https://bugs.webkit.org/show_bug.cgi?id=85280

Reviewed by Kenneth Russell.

This patch means to simplify the diff of an upcoming patch. Refactoring
here in preparation for that patch.

No new tests. No behavioral change. Covered by canvas 2d and 3d tests:
  canvas/philip/tests/*toDataURL*.html
  fast/canvas/webgl/premultiplyalpha-test.html

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::CGImageToDataURL): Move the invalid image (!image) test here.
The comments are about JPEG images; say that. Rename out to base64Data.
(WebCore::ImageBuffer::toDataURL): Remove the !image test.
(WebCore::ImageDataToDataURL): Move and define variables where used and
make the code flow read similarly to toDataURL. Remove the !image test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Changes to layer tree structure need to be tracked properly
shawnsingh@chromium.org [Sat, 5 May 2012 00:38:03 +0000 (00:38 +0000)]
[chromium] Changes to layer tree structure need to be tracked properly
https://bugs.webkit.org/show_bug.cgi?id=85421

Reviewed by Adrienne Walker.

Unit test added: TreeSynchronizerTest.syncSimpleTreeAndTrackStackingOrderChange

Source/WebCore:

Earlier, we were relying on WebCore behavior that always called
setNeedsDisplay whenever the layer tree structure changed.
However, in general it is more correct to consider layer tree
changes even when things don't need repainting; for example Aura
code is encountring this bug now. This patch corrects the
compositor so that layer tree structural changes are considered
property changes, without requiring that layers needed to be
repainted.

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
(WebCore::LayerChromium::insertChild):
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::setStackingOrderChanged):
(WebCore):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):

Source/WebKit/chromium:

* tests/TreeSynchronizerTest.cpp:
(WebKitTests):
(WebKitTests::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed; build fix after r116191.
jpfau@apple.com [Sat, 5 May 2012 00:10:37 +0000 (00:10 +0000)]
Unreviewed; build fix after r116191.

* bindings/js/JSEventListener.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake capitalization and descriptions in FeatureList.pm more consistent to make easier...
eric@webkit.org [Sat, 5 May 2012 00:04:28 +0000 (00:04 +0000)]
Make capitalization and descriptions in FeatureList.pm more consistent to make easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85583

Reviewed by Daniel Bates.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION: Cursor jumps to the first line after deleting the last word.
enrica@apple.com [Fri, 4 May 2012 23:55:40 +0000 (23:55 +0000)]
REGRESSION: Cursor jumps to the first line after deleting the last word.
https://bugs.webkit.org/show_bug.cgi?id=85334
<rdar://problem/11210059>

Reviewed by Ryosuke Niwa.

Source/WebCore:

This regression was introduced with the work to remove redundant divs.
When we decide to remove a DIV, we need to adjust the selection, if it is
expressed in terms of the node being removed. The new position was computed
using updatePositionForNodeRemoval that was not designed for the case where we
remove preserving children.
This patch adds a new method to CompositeEditCommand to do this properly.

Test: editing/deleting/delete-word-from-unstyled-div.html

* editing/CompositeEditCommand.cpp:
(WebCore::CompositeEditCommand::isRemovableBlock): Code clenup.
(WebCore::CompositeEditCommand::updatePositionForNodeRemovalPreservingChildren): Added.
 * editing/CompositeEditCommand.h:
* editing/DeleteSelectionCommand.cpp:
(WebCore::DeleteSelectionCommand::removeRedundantBlocks): Uses updatePositionForNodeRemovalPreservingChildren.

LayoutTests:

* editing/deleting/delete-word-from-unstyled-div-expected.txt: Added.
* editing/deleting/delete-word-from-unstyled-div.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrevent early EventListener deletion
jpfau@apple.com [Fri, 4 May 2012 23:42:56 +0000 (23:42 +0000)]
Prevent early EventListener deletion
https://bugs.webkit.org/show_bug.cgi?id=73970

Reviewed by Oliver Hunt.

Source/WebCore:

Test: fast/events/attribute-listener-deletion-crash.html

* bindings/js/JSEventListener.h:
(WebCore::JSEventListener::jsFunction):

LayoutTests:

* fast/events/attribute-listener-deletion-crash-expected.txt: Added.
* fast/events/attribute-listener-deletion-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] enable msvs_error_on_missing_sources at gyp time
tony@chromium.org [Fri, 4 May 2012 23:42:33 +0000 (23:42 +0000)]
[chromium] enable msvs_error_on_missing_sources at gyp time
https://bugs.webkit.org/show_bug.cgi?id=85683

Reviewed by Adam Barth.

This flag checks for missing files, which cause compile times to be
slow on Windows. Since this flag is on by default for the
build.chromium.org bots, we should add it here too so everyone can fix
these errors.

* DEPS: Roll to a chromium version that has no missing files.
* gyp_webkit: Add the flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd "combining short stroke overlay character (u0335)" to lookalike characters blacklist.
joepeck@webkit.org [Fri, 4 May 2012 23:34:25 +0000 (23:34 +0000)]
Add "combining short stroke overlay character (u0335)" to lookalike characters blacklist.
https://bugs.webkit.org/show_bug.cgi?id=85440

Patch by Yongjun Zhang <yongjun_zhang@apple.com> on 2012-05-04
Reviewed by David Kilzer.

We should add u0335 to the characters blacklist.

* platform/mac/WebCoreNSURLExtras.mm:
(WebCore::isLookalikeCharacter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFlash of white when exiting full screen HTML5 video
jer.noble@apple.com [Fri, 4 May 2012 23:31:14 +0000 (23:31 +0000)]
Flash of white when exiting full screen HTML5 video
https://bugs.webkit.org/show_bug.cgi?id=85438

.:

Reviewed by Sam Weinig.

* ManualTests/fullscreen/full-screen-flash.html: Added.

Source/WebKit2:

Reviewed by Maciej Stachowiak.

Force a repaint before displaying the newly exited WebView window.  This gives the window
a chance to seamlessly repaint before enabling screen updates.

Also, send the WebProcess the didExitFullScreen and setAnimatingFullScreen(false) messages
after swapping the WebView back into its original window. Doing otherwise seems to cause
forceRepaint to paint a white frame.

* UIProcess/mac/WKFullScreenWindowController.mm:
(-[WKFullScreenWindowController finishedExitFullScreenAnimation:]):
(-[WKFullScreenWindowController completeFinishExitFullScreenAnimationAfterRepaint]):
(completeFinishExitFullScreenAnimationAfterRepaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSort entries in FeaturesList.pm to make them easier to autogenerate
eric@webkit.org [Fri, 4 May 2012 23:11:06 +0000 (23:11 +0000)]
Sort entries in FeaturesList.pm to make them easier to autogenerate
https://bugs.webkit.org/show_bug.cgi?id=85584

Reviewed by Daniel Bates.

No functional changes, only sorting.

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add plumbing for file display names for drag and drop
commit-queue@webkit.org [Fri, 4 May 2012 22:59:34 +0000 (22:59 +0000)]
[chromium] Add plumbing for file display names for drag and drop
https://bugs.webkit.org/show_bug.cgi?id=85673

Patch by Satoru Takabayashi <satorux@chromium.org> on 2012-05-04
Reviewed by Darin Fisher.

Source/WebCore:

No new tests: this change itself shouldn't change existing behavior.

* platform/chromium/ChromiumDataObject.cpp:
(WebCore::ChromiumDataObject::addFilename):
* platform/chromium/ChromiumDataObject.h:
(ChromiumDataObject):

Source/WebKit/chromium:

* public/platform/WebDragData.h:
* src/WebDragData.cpp:
(WebKit::WebDragData::items):
(WebKit::WebDragData::addItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCorrect pixel snapping in RenderSVGRoot::paintReplaced
leviw@chromium.org [Fri, 4 May 2012 22:55:01 +0000 (22:55 +0000)]
Correct pixel snapping in RenderSVGRoot::paintReplaced
https://bugs.webkit.org/show_bug.cgi?id=85671

Reviewed by Eric Seidel.

SVG root elements are still painted on pixel boundaries, so their children should
apply transforms based on their actual painted location, not their sub-pixel
one. This corrects a clipping and painting issue where these sub-pixel units are
incorrectly applied to the graphics context.

Covered by existing tests when sub-pixel layout is enabled.

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::paintReplaced):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning.
lforschler@apple.com [Fri, 4 May 2012 22:54:25 +0000 (22:54 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdated Spanish translation
kov@webkit.org [Fri, 4 May 2012 22:25:19 +0000 (22:25 +0000)]
Updated Spanish translation
https://bugs.webkit.org/show_bug.cgi?id=83995

Patch by Daniel Mustieles <daniel.mustieles@gmail.com> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

* es.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
aestes@apple.com [Fri, 4 May 2012 22:19:21 +0000 (22:19 +0000)]
REGRESSION (r115752): WebKit2.NewFirstVisuallyNonEmptyLayout API test times out
https://bugs.webkit.org/show_bug.cgi?id=85675

* TestWebKitAPI/Tests/WebKit2/NewFirstVisuallyNonEmptyLayout.cpp:
(TestWebKitAPI::TEST): Disable the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r116127-r116165): 6 tests failing on Lion Debug (Tests)
jer.noble@apple.com [Fri, 4 May 2012 22:08:30 +0000 (22:08 +0000)]
REGRESSION (r116127-r116165): 6 tests failing on Lion Debug (Tests)
https://bugs.webkit.org/show_bug.cgi?id=85674

Reviewed by Oliver Hunt.

Null check the results of core([frame DOMDocument]).

* WebView/WebView.mm:
(-[WebView _didStartProvisionalLoadForFrame:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSet the right device scale factor when creating the web page
andersca@apple.com [Fri, 4 May 2012 22:01:07 +0000 (22:01 +0000)]
Set the right device scale factor when creating the web page
https://bugs.webkit.org/show_bug.cgi?id=85667
<rdar://problem/11376611>

Reviewed by Oliver Hunt.

* UIProcess/API/mac/WKView.mm:
(-[WKView initWithFrame:contextRef:pageGroupRef:]):
Set the scale factor before initializing the page, to ensure that the WebPageCreationParameters struct gets the right scale factor.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::setIntrinsicDeviceScaleFactor):
This can now be called with a null drawing area. Also, remove the isValid() check since we still want to update the scale factor even if the web process has crashed.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):
Set the device scale factor from the creation parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRefactor CSP state to prepare for having both a ReportOnly and an Enforced policy
abarth@webkit.org [Fri, 4 May 2012 21:40:48 +0000 (21:40 +0000)]
Refactor CSP state to prepare for having both a ReportOnly and an Enforced policy
https://bugs.webkit.org/show_bug.cgi?id=85662

Reviewed by Eric Seidel.

Source/WebCore:

This patch refactors the ContentSecurityPolicy state into a separate
DirectiveList class to prepare for
https://bugs.webkit.org/show_bug.cgi?id=85561, which will cause us to
need two directive lists: one for enforcement and one for monitoring.

This patch shouldn't cause any change in behavior.

* page/ContentSecurityPolicy.cpp:
(CSPDirectiveList):
(WebCore::CSPDirectiveList::header):
(WebCore::CSPDirectiveList::headerType):
(WebCore::CSPDirectiveList::denyIfEnforcingPolicy):
(WebCore):
(WebCore::CSPDirectiveList::CSPDirectiveList):
(WebCore::CSPDirectiveList::create):
(WebCore::CSPDirectiveList::reportViolation):
(WebCore::CSPDirectiveList::logUnrecognizedDirective):
(WebCore::CSPDirectiveList::checkEval):
(WebCore::CSPDirectiveList::operativeDirective):
(WebCore::CSPDirectiveList::checkInlineAndReportViolation):
(WebCore::CSPDirectiveList::checkEvalAndReportViolation):
(WebCore::CSPDirectiveList::checkSourceAndReportViolation):
(WebCore::CSPDirectiveList::allowJavaScriptURLs):
(WebCore::CSPDirectiveList::allowInlineEventHandlers):
(WebCore::CSPDirectiveList::allowInlineScript):
(WebCore::CSPDirectiveList::allowInlineStyle):
(WebCore::CSPDirectiveList::allowEval):
(WebCore::CSPDirectiveList::allowScriptFromSource):
(WebCore::CSPDirectiveList::allowObjectFromSource):
(WebCore::CSPDirectiveList::allowChildFrameFromSource):
(WebCore::CSPDirectiveList::allowImageFromSource):
(WebCore::CSPDirectiveList::allowStyleFromSource):
(WebCore::CSPDirectiveList::allowFontFromSource):
(WebCore::CSPDirectiveList::allowMediaFromSource):
(WebCore::CSPDirectiveList::allowConnectFromSource):
(WebCore::CSPDirectiveList::parse):
(WebCore::CSPDirectiveList::parseDirective):
(WebCore::CSPDirectiveList::parseReportURI):
(WebCore::CSPDirectiveList::createCSPDirective):
(WebCore::CSPDirectiveList::applySandboxPolicy):
(WebCore::CSPDirectiveList::addDirective):
(WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::~ContentSecurityPolicy):
(WebCore::ContentSecurityPolicy::copyStateFrom):
(WebCore::ContentSecurityPolicy::didReceiveHeader):
(WebCore::ContentSecurityPolicy::setOverrideAllowInlineStyle):
(WebCore::ContentSecurityPolicy::header):
(WebCore::ContentSecurityPolicy::headerType):
(WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
(WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
(WebCore::ContentSecurityPolicy::allowInlineScript):
(WebCore::ContentSecurityPolicy::allowInlineStyle):
(WebCore::ContentSecurityPolicy::allowEval):
(WebCore::ContentSecurityPolicy::allowScriptFromSource):
(WebCore::ContentSecurityPolicy::allowObjectFromSource):
(WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
(WebCore::ContentSecurityPolicy::allowImageFromSource):
(WebCore::ContentSecurityPolicy::allowStyleFromSource):
(WebCore::ContentSecurityPolicy::allowFontFromSource):
(WebCore::ContentSecurityPolicy::allowMediaFromSource):
(WebCore::ContentSecurityPolicy::allowConnectFromSource):
* page/ContentSecurityPolicy.h:
(WebCore):
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerMessagingProxy::startWorkerContext):

Source/WebKit/chromium:

Update callers to the new function name.

* src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::notifyFinished):
* src/WebWorkerClientImpl.cpp:
(WebKit::WebWorkerClientImpl::startWorkerContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, updating expectations.
fpizlo@apple.com [Fri, 4 May 2012 21:38:10 +0000 (21:38 +0000)]
Unreviewed, updating expectations.

* platform/mac/fast/block/float/overhanging-tall-block-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, checking in new expectation file.
fpizlo@apple.com [Fri, 4 May 2012 21:34:44 +0000 (21:34 +0000)]
Unreviewed, checking in new expectation file.

* platform/mac/fast/images/png-suite/test-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoASSERT(beforeChildAnonymousContainer->isTable()); fails in RenderBlock::addChildIgnor...
inferno@chromium.org [Fri, 4 May 2012 21:33:51 +0000 (21:33 +0000)]
ASSERT(beforeChildAnonymousContainer->isTable()); fails in RenderBlock::addChildIgnoringAnonymousColumnBlocks.
https://bugs.webkit.org/show_bug.cgi?id=84606

Reviewed by Julien Chaffraix.

Source/WebCore:

RenderBlock::removeChild forgot to set display on the anonymous block, causing it
to display as INLINE. To prevent this kind of failure in future, we replace
createAnonymousStyle with createAnonymousStyleWithDisplay to make everyone explictly
pass display as the argument.

Test: fast/block/block-add-child-crash.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild):
(WebCore::RenderBlock::createAnonymousWithParentRendererAndDisplay):
(WebCore::RenderBlock::createAnonymousColumnsWithParentRenderer):
(WebCore::RenderBlock::createAnonymousColumnSpanWithParentRenderer):
* rendering/RenderInline.cpp:
(WebCore::updateStyleOfAnonymousBlockContinuations):
(WebCore::RenderInline::addChildIgnoringContinuation):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::propagateStyleToAnonymousChildren):
* rendering/RenderRuby.cpp:
(WebCore::createAnonymousRubyInlineBlock):
* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::createRubyBase):
(WebCore::RenderRubyRun::staticCreateRubyRun):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::createAnonymousWithParentRenderer):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::createAnonymousWithParentRenderer):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::createAnonymousWithParentRenderer):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::createAnonymousWithParentRenderer):
* rendering/mathml/RenderMathMLBlock.cpp:
(WebCore::RenderMathMLBlock::createAlmostAnonymousBlock):
* rendering/mathml/RenderMathMLRow.cpp:
(WebCore::RenderMathMLRow::createAnonymousWithParentRenderer):
* rendering/mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::addChild):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::createAnonymousStyleWithDisplay):
* rendering/style/RenderStyle.h:

LayoutTests:

* fast/block/block-add-child-crash-expected.txt: Added.
* fast/block/block-add-child-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTaking a visibility:hidden element full screen causes full screen window to disappear.
jer.noble@apple.com [Fri, 4 May 2012 21:30:52 +0000 (21:30 +0000)]
Taking a visibility:hidden element full screen causes full screen window to disappear.
https://bugs.webkit.org/show_bug.cgi?id=85432

Reviewed by Maciej Stachowiak.

.:

* ManualTests/fullscreen/full-screen-zero-width.html: Added.

Source/WebKit/mac:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

* WebView/WebFullScreenController.mm:
(windowFrameFromApparentFrames):

Source/WebKit2:

When given an initial or final frame with a zero width or height, return a rect representing
the entire screen, rather than a rect with a zero or infinite size. Doing otherwise will
confuse the window server when it's instructed to scale the full screen window to that size.

* UIProcess/mac/WKFullScreenWindowController.mm:
(windowFrameFromApparentFrames):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebKit IDL does not use exception syntax
arv@chromium.org [Fri, 4 May 2012 21:23:15 +0000 (21:23 +0000)]
WebKit IDL does not use exception syntax
https://bugs.webkit.org/show_bug.cgi?id=85100

Reviewed by Dimitri Glazkov.

This adds support for exception ExceptionName { ... } which currently sets a flag
on the domClass.

Binding tests updated.

* Modules/indexeddb/IDBDatabaseException.idl:
* Modules/webdatabase/SQLException.idl:
* bindings/scripts/IDLParser.pm:
(ParseInterface):
(DetermineParseMode):
(ProcessSection):
* bindings/scripts/IDLStructure.pm:
* bindings/scripts/test/CPP/WebDOMTestException.cpp: Added.
(WebDOMTestException::WebDOMTestExceptionPrivate::WebDOMTestExceptionPrivate):
(WebDOMTestException::WebDOMTestExceptionPrivate):
(WebDOMTestException::WebDOMTestException):
(WebDOMTestException::operator=):
(WebDOMTestException::impl):
(WebDOMTestException::~WebDOMTestException):
(WebDOMTestException::name):
(toWebCore):
(toWebKit):
* bindings/scripts/test/CPP/WebDOMTestException.h: Added.
(WebCore):
(WebDOMTestException):
* bindings/scripts/test/GObject/WebKitDOMTestException.cpp: Added.
(WebKit):
(WebKit::kit):
(WebKit::core):
(WebKit::wrapTestException):
(webkit_dom_test_exception_finalize):
(webkit_dom_test_exception_set_property):
(webkit_dom_test_exception_get_property):
(webkit_dom_test_exception_constructed):
(webkit_dom_test_exception_class_init):
(webkit_dom_test_exception_init):
(webkit_dom_test_exception_get_name):
* bindings/scripts/test/GObject/WebKitDOMTestException.h: Added.
(_WebKitDOMTestException):
(_WebKitDOMTestExceptionClass):
* bindings/scripts/test/GObject/WebKitDOMTestExceptionPrivate.h: Added.
(WebKit):
* bindings/scripts/test/JS/JSTestException.cpp: Added.
(WebCore):
(WebCore::JSTestExceptionConstructor::JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::finishCreation):
(WebCore::JSTestExceptionConstructor::getOwnPropertySlot):
(WebCore::JSTestExceptionConstructor::getOwnPropertyDescriptor):
(WebCore::JSTestExceptionPrototype::self):
(WebCore::JSTestException::JSTestException):
(WebCore::JSTestException::finishCreation):
(WebCore::JSTestException::createPrototype):
(WebCore::JSTestException::destroy):
(WebCore::JSTestException::~JSTestException):
(WebCore::JSTestException::getOwnPropertySlot):
(WebCore::JSTestException::getOwnPropertyDescriptor):
(WebCore::jsTestExceptionName):
(WebCore::jsTestExceptionConstructor):
(WebCore::JSTestException::getConstructor):
(WebCore::isObservable):
(WebCore::JSTestExceptionOwner::isReachableFromOpaqueRoots):
(WebCore::JSTestExceptionOwner::finalize):
(WebCore::toJS):
(WebCore::toTestException):
* bindings/scripts/test/JS/JSTestException.h: Added.
(WebCore):
(JSTestException):
(WebCore::JSTestException::create):
(WebCore::JSTestException::createStructure):
(WebCore::JSTestException::impl):
(WebCore::JSTestException::releaseImpl):
(WebCore::JSTestException::releaseImplIfNotNull):
(JSTestExceptionOwner):
(WebCore::wrapperOwner):
(WebCore::wrapperContext):
(JSTestExceptionPrototype):
(WebCore::JSTestExceptionPrototype::create):
(WebCore::JSTestExceptionPrototype::createStructure):
(WebCore::JSTestExceptionPrototype::JSTestExceptionPrototype):
(JSTestExceptionConstructor):
(WebCore::JSTestExceptionConstructor::create):
(WebCore::JSTestExceptionConstructor::createStructure):
* bindings/scripts/test/ObjC/DOMTestException.h: Added.
* bindings/scripts/test/ObjC/DOMTestException.mm: Added.
(-[DOMTestException dealloc]):
(-[DOMTestException finalize]):
(-[DOMTestException name]):
(core):
(kit):
* bindings/scripts/test/ObjC/DOMTestExceptionInternal.h: Added.
(WebCore):
* bindings/scripts/test/TestException.idl: Copied from Source/WebCore/xml/XPathException.idl.
* bindings/scripts/test/V8/V8TestException.cpp: Added.
(WebCore):
(TestExceptionV8Internal):
(WebCore::TestExceptionV8Internal::V8_USE):
(WebCore::TestExceptionV8Internal::nameAttrGetter):
(WebCore::ConfigureV8TestExceptionTemplate):
(WebCore::V8TestException::GetRawTemplate):
(WebCore::V8TestException::GetTemplate):
(WebCore::V8TestException::HasInstance):
(WebCore::V8TestException::wrapSlow):
(WebCore::V8TestException::derefObject):
* bindings/scripts/test/V8/V8TestException.h: Added.
(WebCore):
(V8TestException):
(WebCore::V8TestException::toNative):
(WebCore::V8TestException::wrap):
(WebCore::toV8):
* dom/DOMCoreException.idl:
* dom/EventException.idl:
* dom/RangeException.idl:
* fileapi/FileException.idl:
* fileapi/OperationNotAllowedException.idl:
* svg/SVGException.idl:
* xml/XMLHttpRequestException.idl:
* xml/XPathException.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoV8RecursionScope not declared in V8Proxy::newInstance which causes ASSERT() failure...
rafaelw@chromium.org [Fri, 4 May 2012 21:21:52 +0000 (21:21 +0000)]
V8RecursionScope not declared in V8Proxy::newInstance which causes ASSERT() failure from NPAPI
https://bugs.webkit.org/show_bug.cgi?id=85659

Reviewed by Ojan Vafai.

Added a stack-allocted V8RecursionScope to the newInstance call.

No new tests. No change in observable behavior.

* bindings/v8/V8Proxy.cpp:
(WebCore::V8Proxy::newInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Remove all index metadata records when deleting an index
jsbell@chromium.org [Fri, 4 May 2012 21:20:23 +0000 (21:20 +0000)]
IndexedDB: Remove all index metadata records when deleting an index
https://bugs.webkit.org/show_bug.cgi?id=85557

Reviewed by Tony Chang.

An assert is hit when re-loading database from backing store due to stale index
metadata entry. Do a range delete to clear all metadata entries when deleting an
index. Define metadata entries as enum and limits as consts instead of hardcoded ints.

No new tests - issue does not repro as layout test. Will land test in Chromium.

* Modules/indexeddb/IDBLevelDBBackingStore.cpp:
(WebCore::getBool): Helper functions; replaces pattern of putInt()/read only lead byte.
(WebCore):
(WebCore::putBool):
(WebCore::IDBLevelDBBackingStore::getObjectStores): Skip stale data. Use enums, helpers.
(WebCore::IDBLevelDBBackingStore::createObjectStore): Use enums.
(WebCore::IDBLevelDBBackingStore::deleteObjectStore): Use enums.
(WebCore::getNewVersionNumber): Use enums.
(WebCore::IDBLevelDBBackingStore::getIndexes): Skip stale data. Use enums, helpers.
(WebCore::getNewIndexId): Use enums.
(WebCore::IDBLevelDBBackingStore::createIndex): Use enums.
(WebCore::IDBLevelDBBackingStore::deleteIndex): Delete metadata by range.
* Modules/indexeddb/IDBLevelDBCoding.cpp:
(IDBLevelDBCoding): Add constants for metadata maximum values.
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::decodeBool):
(WebCore::IDBLevelDBCoding::ObjectStoreMetaDataKey::encodeMaxKey): Use consts.
(WebCore::IDBLevelDBCoding::IndexMetaDataKey::encodeMaxKey): Use consts.
* Modules/indexeddb/IDBLevelDBCoding.h:
(IDBLevelDBCoding): Expose enums for metadata types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] IETC flexbox reference tests have pixel differences (due to embedded color...
aestes@apple.com [Fri, 4 May 2012 21:19:17 +0000 (21:19 +0000)]
[Mac] IETC flexbox reference tests have pixel differences (due to embedded color profiles?)
https://bugs.webkit.org/show_bug.cgi?id=85666

* platform/mac/Skipped: Skip the tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG should not Flush GetLocal's
fpizlo@apple.com [Fri, 4 May 2012 21:18:25 +0000 (21:18 +0000)]
DFG should not Flush GetLocal's
https://bugs.webkit.org/show_bug.cgi?id=85663
<rdar://problem/11373600>

Reviewed by Oliver Hunt.

Source/JavaScriptCore:

* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::flushArgument):
(JSC::DFG::ByteCodeParser::handleCall):

LayoutTests:

* fast/js/dfg-flush-get-local-expected.txt: Added.
* fast/js/dfg-flush-get-local.html: Added.
* fast/js/script-tests/dfg-flush-get-local.js: Added.
(foo):
(fuzz):
(bar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove markPagesForFullStyleRecalc to PageCache
andersca@apple.com [Fri, 4 May 2012 21:16:30 +0000 (21:16 +0000)]
Move markPagesForFullStyleRecalc to PageCache
https://bugs.webkit.org/show_bug.cgi?id=85664

Reviewed by Dan Bernstein.

Instead of going through all the history items in the back/forward list looking for cached pages, just iterate over the cached pages in the page.

* history/BackForwardController.cpp:
* history/BackForwardController.h:
* history/HistoryItem.cpp:
* history/HistoryItem.h:
* history/PageCache.cpp:
(WebCore::PageCache::markPagesForFullStyleRecalc):
(WebCore):
* history/PageCache.h:
(PageCache):
* page/Frame.cpp:
(WebCore::Frame::setPageAndTextZoomFactors):
* page/Page.cpp:
(WebCore::Page::setDeviceScaleFactor):
(WebCore::Page::setPagination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe computed style of flex-item-align should never be auto.
tony@chromium.org [Fri, 4 May 2012 21:15:13 +0000 (21:15 +0000)]
The computed style of flex-item-align should never be auto.
https://bugs.webkit.org/show_bug.cgi?id=85656

Reviewed by Ojan Vafai.

Source/WebCore:

If the node lacks a parent and flex-item-align is auto, we should
return stretch. This was recently clarified in the spec.

New testcase in css3/flexbox/css-properties.html.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/css-properties.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFull screen will exit during a provisional load of a non-ancestor iframe.
jer.noble@apple.com [Fri, 4 May 2012 21:00:37 +0000 (21:00 +0000)]
Full screen will exit during a provisional load of a non-ancestor iframe.
https://bugs.webkit.org/show_bug.cgi?id=85230

Reviewed by Maciej Stachowiak .

Source/WebKit/mac:

Only exit full screen mode if the frame being loaded contains the full
screen element.

* WebView/WebView.mm:
(-[WebView _didStartProvisionalLoadForFrame:]): Give the UIDelegate a first crack at handling the
request to close the full screen window when a provisional load occurs.

Source/WebKit2:

Only exit full screen mode if the frame being loaded contains the full
screen element:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidStartProvisionalLoad):

Move the full screen exiting logic up into WebFrameLoaderClient in the
WebProcess:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didStartProvisionalLoadForFrame):

Add a WebFullScreenManager "close" method & message:
* UIProcess/WebFullScreenManagerProxy.messages.in:
* WebProcess/FullScreen/WebFullScreenManager.cpp:
(WebKit::WebFullScreenManager::close):
* WebProcess/FullScreen/WebFullScreenManager.h:

Add support for this new message to the WKBundlePage and client:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.cpp:
(WebKit::InjectedBundlePageFullScreenClient::closeFullScreen):
* WebProcess/InjectedBundle/InjectedBundlePageFullScreenClient.h:

Tools:

Add support for the new UIDelegate webView:closeFullScreenWithListener: method:
* DumpRenderTree/mac/UIDelegate.mm:
(-[UIDelegate webView:closeFullScreenWithListener:]):

Add support for the new closeFullScreen injected bundle method:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):
(WTR::InjectedBundlePage::closeFullScreen):
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

LayoutTests:

* fullscreen/non-ancestor-iframe-expected.txt: Added.
* fullscreen/non-ancestor-iframe.html: Added.
* fullscreen/resources/empty.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove WebKitFullScreenListener into its own file.
jer.noble@apple.com [Fri, 4 May 2012 20:59:02 +0000 (20:59 +0000)]
Move WebKitFullScreenListener into its own file.
https://bugs.webkit.org/show_bug.cgi?id=85640

Source/WebKit:

Reviewed by Maciej Stachowiak .

Pull WebKitFullScreenListener into its own file.

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Reviewed by Maciej Stachowiak.

Move WebKitFullScreenListener into its own file, so it can be used by multiple classes.

* WebCoreSupport/WebKitFullScreenListener.h: Added.
* WebCoreSupport/WebKitFullScreenListener.mm: Added.
(-[WebKitFullScreenListener webkitWillEnterFullScreen]):
(-[WebKitFullScreenListener webkitDidEnterFullScreen]):
(-[WebKitFullScreenListener webkitWillExitFullScreen]):
(-[WebKitFullScreenListener webkitDidExitFullScreen]):
* WebCoreSupport/WebChromeClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix test naming to be camel-case like the methods they are testing.
ojan@chromium.org [Fri, 4 May 2012 20:54:50 +0000 (20:54 +0000)]
Fix test naming to be camel-case like the methods they are testing.

* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoShow the results links in the embedded flakiness dashboard
ojan@chromium.org [Fri, 4 May 2012 20:50:41 +0000 (20:50 +0000)]
Show the results links in the embedded flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85660

Reviewed by Adam Barth.

Turns out these links don't add much visual noise and it's annoying
to have to go to the dashboard from garden-o-matic just to view the
results for a test.

This is useful for cases where garden-o-matic doesn't properly show the
results (e.g. missing tests). If we address all those cases, then
we could easily hide the results links again if we wanted to.

* TestResultServer/static-dashboards/flakiness_dashboard.js:
(showUpdateInfoForTest):
(htmlForIndividualTestOnAllBuildersWithResultsLinks):
* TestResultServer/static-dashboards/flakiness_dashboard_unittests.js:
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRevert to using chromium --test-shell mode on SL in NRWT
dpranke@chromium.org [Fri, 4 May 2012 20:46:17 +0000 (20:46 +0000)]
Revert to using chromium --test-shell mode on SL in NRWT

https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, build fix.

We seem to be seeing a lot more flakiness on the bot since
I switched NRWT to "DRT" mode. We'll try reverting back and
see if this helps things.

* Scripts/webkitpy/layout_tests/port/chromium.py:
(ChromiumDriver.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[soup] URL of the ResourceResponse passed to willSendRequest is incorrect
commit-queue@webkit.org [Fri, 4 May 2012 20:28:16 +0000 (20:28 +0000)]
[soup] URL of the ResourceResponse passed to willSendRequest is incorrect
https://bugs.webkit.org/show_bug.cgi?id=85072

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-04
Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Store the response message by catching the "got-headers" signal so
that it can be passed later to willSendRequest() in case of
redirection. This is required because the SoupMessage headers and URL
have already been updated once restartedCallback() is called.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore):
(WebCore::gotHeadersCallback):
(WebCore::restartedCallback):
(WebCore::sendRequestCallback):
(WebCore::startHTTPRequest):

LayoutTests:

Unskip http/tests/misc/will-send-request-returns-null-on-redirect.html
and http/tests/loading/307-after-303-after-post.html now that the
response passed to willSendRequest is correct and now that the right
redirect URL is being printed in EFL port.

Unfortunately, http/tests/loading/redirect-methods.html cannot be
unskipped yet due to bug 66873.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r116134): It made 3 inspector tests fail
ossy@webkit.org [Fri, 4 May 2012 20:20:04 +0000 (20:20 +0000)]
REGRESSION(r116134): It made 3 inspector tests fail
https://bugs.webkit.org/show_bug.cgi?id=85654

Unreviewed gardening, skip failing tests until proper fix.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
commit-queue@webkit.org [Fri, 4 May 2012 20:14:58 +0000 (20:14 +0000)]
[EFL] Implement layoutTestController.dumpResourceResponseMIMETypes
https://bugs.webkit.org/show_bug.cgi?id=84941

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-04
Reviewed by Martin Robinson.

Source/WebKit/efl:

Extend Ewk_Frame_Resource_Response structure to pass resource MIME type
information.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
* ewk/ewk_frame.h:

Tools:

Print MIME type detection messages in EFL's DumpRenderTree if
LayoutTestController's dumpResourceResponseMIMETypes() returns true.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::onResponseReceived):

LayoutTests:

* platform/efl/Skipped: Unskip test cases which require MIME type
detection messages now that is is implemented in EFL port.
* platform/efl/fast/preloader/script-expected.txt: Added. Use same
EFL expectation as in chromium and mac ports (MIME type is
"application/javascript" instead of "application/x-javascript").

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Implement numberOfProcessorCores() for QNX
commit-queue@webkit.org [Fri, 4 May 2012 20:13:10 +0000 (20:13 +0000)]
[BlackBerry] Implement numberOfProcessorCores() for QNX
https://bugs.webkit.org/show_bug.cgi?id=85638

Patch by Jeff Rogers <jrogers@rim.com> on 2012-05-04
Reviewed by Antonio Gomes.

* wtf/NumberOfCores.cpp:
(WTF::numberOfProcessorCores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix expectation for test after http://trac.webkit.org/changeset/116143.
ojan@chromium.org [Fri, 4 May 2012 20:12:43 +0000 (20:12 +0000)]
Fix expectation for test after trac.webkit.org/changeset/116143.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAll the inspector tests are skipped on chromium-mac. We should
ojan@chromium.org [Fri, 4 May 2012 20:10:42 +0000 (20:10 +0000)]
All the inspector tests are skipped on chromium-mac. We should
skip the new ones in platform/chromium as well.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSuppress yet more Chromium Mac SL timeouts; hopefully close to end
dpranke@chromium.org [Fri, 4 May 2012 20:08:51 +0000 (20:08 +0000)]
Suppress yet more Chromium Mac SL timeouts; hopefully close to end
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] CCProxy's shouldn't try to draw if there is no layer renderer
commit-queue@webkit.org [Fri, 4 May 2012 20:06:14 +0000 (20:06 +0000)]
[chromium] CCProxy's shouldn't try to draw if there is no layer renderer
https://bugs.webkit.org/show_bug.cgi?id=85218

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-04
Reviewed by Adrienne Walker.

* platform/graphics/chromium/cc/CCThreadProxy.cpp:
(WebCore::CCThreadProxy::scheduledActionDrawAndSwapInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, test_expectations update.
commit-queue@webkit.org [Fri, 4 May 2012 20:01:17 +0000 (20:01 +0000)]
Unreviewed, test_expectations update.
Remove media/W3C/video/events/event_order_canplay_canplaythrough.html.
The crash is not happening anymore.

Patch by Shadi Khalek <shadi@chromium.org> on 2012-05-04

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSuppress more Chromium Mac SL timeouts ...
dpranke@chromium.org [Fri, 4 May 2012 19:58:12 +0000 (19:58 +0000)]
Suppress more Chromium Mac SL timeouts ...
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRebaseline some SVG Snow Leopard results
rwlbuis@webkit.org [Fri, 4 May 2012 19:57:20 +0000 (19:57 +0000)]
Rebaseline some SVG Snow Leopard results
https://bugs.webkit.org/show_bug.cgi?id=85637

Reviewed by Nikolas Zimmermann.

Remove batik expected pngs for Snow Leopard since the generic mac ones match.
Fix types-dom-01-b-expected.txt to expect RenderSVGEllipse.

* platform/mac-snowleopard/svg/W3C-SVG-1.1-SE/types-dom-01-b-expected.txt:
* platform/mac-snowleopard/svg/batik/filters/feTile-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/filters/filterRegions-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/masking/maskRegions-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/paints/gradientLimit-expected.png:
* platform/mac-snowleopard/svg/batik/paints/patternPreserveAspectRatioA-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/paints/patternRegionA-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/paints/patternRegions-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/paints/patternRegions-positioned-objects-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/longTextOnPath-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/smallFonts-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textAnchor-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textAnchor2-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textAnchor3-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textDecoration-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textDecoration2-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textEffect-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textEffect2-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textEffect3-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textFeatures-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textGlyphOrientationHorizontal-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textLayout-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textLayout2-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textLength-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textOnPath-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textOnPath2-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textOnPath3-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textOnPathSpaces-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textPCDATA-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textPosition-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textPosition2-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textProperties-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textProperties2-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/textStyles-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/verticalText-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/verticalTextOnPath-expected.png: Removed.
* platform/mac-snowleopard/svg/batik/text/xmlSpace-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLayout Test media/track/track-cues-pause-on-exit.html is flaky on chromium debug...
commit-queue@webkit.org [Fri, 4 May 2012 19:53:55 +0000 (19:53 +0000)]
Layout Test media/track/track-cues-pause-on-exit.html is flaky on chromium debug builds
https://bugs.webkit.org/show_bug.cgi?id=80067

Patch by Victor Carbune <vcarbune@adobe.com> on 2012-05-04
Reviewed by Eric Carlson.

Trying a different approach, blocking on waitForEvent for the video element.

* media/track/track-cues-pause-on-exit-expected.txt: Updated.
* media/track/track-cues-pause-on-exit.html: Changed to use
waitForEvent and listen to exit events right after.
* media/video-test.js: Updated waitForEvent to enable listening for
events on other elements as well.
(waitForEvent._eventCallback):
(waitForEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ...
commit-queue@webkit.org [Fri, 4 May 2012 19:45:03 +0000 (19:45 +0000)]
[GTK] DRT needs an implementation of LayoutTestController::setDefersLoading and ::goBack
https://bugs.webkit.org/show_bug.cgi?id=85134

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04
Reviewed by Martin Robinson.

Source/WebKit/gtk:

Add support for setDefersLoading in DumpRenderTreeSupportGtk.

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
(DumpRenderTreeSupportGtk::setDefersLoading):
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Tools:

Add missing implementation setDefersLoading and goBack to GTK's
LayoutTestController so that the test case rely on these methods
can be enabled.

* DumpRenderTree/gtk/DumpRenderTree.cpp:
(resetDefaultsToConsistentValues):
* DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
(LayoutTestController::goBack):
(LayoutTestController::setDefersLoading):

LayoutTests:

Unskip loader/navigation-while-deferring-loads.html and disable
loader/load-defer-resume-crash.html as it triggers an assertion
failure.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Rendering bmp file as text file when Content-Type:image/x-ms-bmp from...
rwlbuis@webkit.org [Fri, 4 May 2012 19:44:47 +0000 (19:44 +0000)]
[BlackBerry] Rendering bmp file as text file when Content-Type:image/x-ms-bmp from apache web server.
https://bugs.webkit.org/show_bug.cgi?id=85036

Reviewed by Antonio Gomes.

Source/WebCore:

Move getNormalizedMIMEType from WebKit into MIMETypeRegistry. This way we support uncommon mime types like image/pjpeg
and image/x-ms-bmp out of the box since we map to the more common image/jpeg and image/bmp respectively.

* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
(WebCore::MIMETypeRegistry::isSupportedImageResourceMIMEType):
(WebCore):
(WebCore::mimeTypeAssociationMap):
(WebCore::MIMETypeRegistry::getNormalizedMIMEType):
* platform/MIMETypeRegistry.h:
(MIMETypeRegistry):

Source/WebKit/blackberry:

Move getNormalizedMIMEType into WebCore::MIMETypeRegistry.

* Api/WebSettings.cpp:
(WebKit):
(BlackBerry::WebKit::WebSettings::isSupportedObjectMIMEType):
* Api/WebSettings.h:
* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::createPlugin):
(WebCore::FrameLoaderClientBlackBerry::canShowMIMEType):
(WebCore::FrameLoaderClientBlackBerry::objectContentType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r116009): image no longer visible on fast/block/float/float-not-removed...
aestes@apple.com [Fri, 4 May 2012 19:35:11 +0000 (19:35 +0000)]
REGRESSION (r116009): image no longer visible on fast/block/float/float-not-removed-from-next-sibling4.html
https://bugs.webkit.org/show_bug.cgi?id=85651

Check in failing results for platform/mac/.

* platform/mac/fast/block/float/float-not-removed-from-next-sibling4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Revert compositor layer scrolling
commit-queue@webkit.org [Fri, 4 May 2012 19:25:58 +0000 (19:25 +0000)]
[chromium] Revert compositor layer scrolling
https://bugs.webkit.org/show_bug.cgi?id=85644

Patch by Sami Kyostila <skyostil@chromium.org> on 2012-05-04
Reviewed by Steve Block.

Source/WebCore:

This patch reverts the following commits because they were found to
trigger crashes. See discussion at http://code.google.com/p/chromium/issues/detail?id=124393.

    [chromium] Allow scrolling non-root layers in the compositor thread
    http://trac.webkit.org/changeset/114651

    [chromium] Don't crash when scrolling empty layer tree
    http://trac.webkit.org/changeset/114761

    [chromium] Don't keep pointers to released layer tree
    http://trac.webkit.org/changeset/115080

* platform/graphics/chromium/ContentLayerChromium.cpp:
* platform/graphics/chromium/ContentLayerChromium.h:
(ContentLayerChromium):
* platform/graphics/chromium/GraphicsLayerChromium.h:
(GraphicsLayerChromium):
* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::pushPropertiesTo):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
* platform/graphics/chromium/cc/CCLayerImpl.h:
* platform/graphics/chromium/cc/CCLayerTreeHost.cpp:
(WebCore::CCLayerTreeHost::applyScrollAndScale):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.h:
(CCLayerTreeHostCommon):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.cpp:
(WebCore::CCLayerTreeHostImpl::CCLayerTreeHostImpl):
(WebCore::CCLayerTreeHostImpl::startPageScaleAnimation):
(WebCore::CCLayerTreeHostImpl::calculateRenderSurfaceLayerList):
(WebCore::CCLayerTreeHostImpl::contentSize):
(WebCore::CCLayerTreeHostImpl::prepareToDraw):
(WebCore::findScrollLayer):
(WebCore::CCLayerTreeHostImpl::setRootLayer):
(WebCore::CCLayerTreeHostImpl::setPageScaleFactorAndLimits):
(WebCore):
(WebCore::CCLayerTreeHostImpl::adjustScrollsForPageScaleChange):
(WebCore::CCLayerTreeHostImpl::setPageScaleDelta):
(WebCore::CCLayerTreeHostImpl::applyPageScaleDeltaToScrollLayer):
(WebCore::CCLayerTreeHostImpl::updateMaxScrollPosition):
(WebCore::CCLayerTreeHostImpl::scrollBegin):
(WebCore::CCLayerTreeHostImpl::scrollBy):
(WebCore::CCLayerTreeHostImpl::scrollEnd):
(WebCore::CCLayerTreeHostImpl::pinchGestureUpdate):
(WebCore::CCLayerTreeHostImpl::computePinchZoomDeltas):
(WebCore::CCLayerTreeHostImpl::makeScrollAndScaleSet):
(WebCore::CCLayerTreeHostImpl::processScrollDeltas):
(WebCore::CCLayerTreeHostImpl::animatePageScale):
* platform/graphics/chromium/cc/CCLayerTreeHostImpl.h:
(WebCore::CCLayerTreeHostImpl::releaseRootLayer):
(WebCore::CCLayerTreeHostImpl::scrollLayer):
(CCLayerTreeHostImpl):

Source/WebKit/chromium:

* src/WebContentLayerImpl.cpp:
* src/WebContentLayerImpl.h:
(WebContentLayerImpl):
* tests/CCLayerTreeHostCommonTest.cpp:
* tests/CCLayerTreeHostImplTest.cpp:
(WebKitTests::TEST_F):
* tests/CCLayerTreeHostTest.cpp:
(WTF::MockContentLayerDelegate::paintContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark editing tests as slow.
dpranke@chromium.org [Fri, 4 May 2012 19:25:00 +0000 (19:25 +0000)]
Mark editing tests as slow.
https://bugs.webkit.org/show_bug.cgi?id=85649

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark a few more tests as flaky across all macs.
dpranke@chromium.org [Fri, 4 May 2012 19:10:27 +0000 (19:10 +0000)]
Mark a few more tests as flaky across all macs.

Unreviewed, expectations change.

fast/loader/javascript-url-in-embed.html = TEXT PASS (Release only)
http/tests/security/sandboxed-iframe-modify-self.html = TEXT PASS
media/video-poster-blocked-by-willsendrequest.html = TEXT PASS
userscripts/user-style-all-frames.html = TEXT PASS

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix path to external JS file that was not updated when the file
ojan@chromium.org [Fri, 4 May 2012 19:05:59 +0000 (19:05 +0000)]
Fix path to external JS file that was not updated when the file
was moved in http://trac.webkit.org/changeset/116128/.

* platform/chromium/inspector/styles/device-metrics-fit-window.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMark tests as flaky timeouts on chromium Mac 10.6
dpranke@chromium.org [Fri, 4 May 2012 19:00:48 +0000 (19:00 +0000)]
Mark tests as flaky timeouts on chromium Mac 10.6
https://bugs.webkit.org/show_bug.cgi?id=83076

Unreviewed, expectations change.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the GTK+ debug build after the r116114.
mrobinson@webkit.org [Fri, 4 May 2012 18:58:02 +0000 (18:58 +0000)]
Fix the GTK+ debug build after the r116114.

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::handleInputMethodKeyboardEvent): Update an
assertion to reflect a real method name in PlatformKeyboardEvent
and remove an unnecessary call to preventDefault() which triggered
an assertion failure higher in the call stack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][NRWT] Run each DRT in it's own xvfb
ossy@webkit.org [Fri, 4 May 2012 18:44:46 +0000 (18:44 +0000)]
[Qt][NRWT] Run each DRT in it's own xvfb
https://bugs.webkit.org/show_bug.cgi?id=77335

Patch by Kristóf Kosztyó <kkristof@inf.u-szeged.hu> on 2012-05-04
Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort._driver_class):
* Scripts/webkitpy/layout_tests/port/qt.py:
(QtPort._driver_class):
* Scripts/webkitpy/layout_tests/port/xvfbdriver.py: Added.
(XvfbDriver):
(XvfbDriver._start):
(XvfbDriver._start.x_filter):
(XvfbDriver.stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening, marking a test added in r116127 as failing.
zandobersek@gmail.com [Fri, 4 May 2012 18:42:11 +0000 (18:42 +0000)]
Unreviewed gardening, marking a test added in r116127 as failing.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCSP: Eval isn't blocked in about:blank subframes
abarth@webkit.org [Fri, 4 May 2012 18:38:03 +0000 (18:38 +0000)]
CSP: Eval isn't blocked in about:blank subframes
https://bugs.webkit.org/show_bug.cgi?id=85553

Reviewed by Eric Seidel.

This patch fixes a race condition in this test.  We need to wait for
the load event to ensure that the iframe has finished loading.

* http/tests/security/contentSecurityPolicy/eval-blocked-in-about-blank-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove file that was deleted in http://trac.webkit.org/changeset/116085/.
ojan@chromium.org [Fri, 4 May 2012 18:31:36 +0000 (18:31 +0000)]
Remove file that was deleted in trac.webkit.org/changeset/116085/.
For some reason, this was breaking the chromium build (probably a gyp bug
since chromium shouldn't be pulling in this file).

* WebCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTiledCoreAnimationDrawingArea should handle visibility changes
andersca@apple.com [Fri, 4 May 2012 18:30:58 +0000 (18:30 +0000)]
TiledCoreAnimationDrawingArea should handle visibility changes
https://bugs.webkit.org/show_bug.cgi?id=85645
<rdar://problem/11247192>

Reviewed by Oliver Hunt.

Replicate the visibility handling logic from DrawingAreaImpl and LayerTreeHostCAMac.

* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.h:
(TiledCoreAnimationDrawingAreaProxy):
* UIProcess/mac/TiledCoreAnimationDrawingAreaProxy.mm:
(WebKit::TiledCoreAnimationDrawingAreaProxy::visibilityDidChange):
(WebKit):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::suspendPainting):
(WebKit):
(WebKit::TiledCoreAnimationDrawingArea::resumePainting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofix bit packing in FillLayer on Windows
tony@chromium.org [Fri, 4 May 2012 18:28:05 +0000 (18:28 +0000)]
fix bit packing in FillLayer on Windows
https://bugs.webkit.org/show_bug.cgi?id=85636

Reviewed by Ryosuke Niwa.

Use unsigned for all bit packed types. I manually verified that
the current uses of these member variables always assign true or false.

No new tests, adding a compile assert to verify bit packing.

* rendering/style/FillLayer.cpp:
(SameSizeAsFillLayer): Added compile assert.
(WebCore):
(WebCore::FillLayer::FillLayer): Reorder m_sizeLength so bit packed fields are adjacent.
(WebCore::FillLayer::operator=): Ditto.
* rendering/style/FillLayer.h:
(FillLayer): Convert bools to unsigned to match other bit packed fields.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, build fix.
apavlov@chromium.org [Fri, 4 May 2012 17:57:51 +0000 (17:57 +0000)]
Unreviewed, build fix.
Move Chromium-specific test into platform/chromium.

* platform/chromium/inspector/styles/device-metrics-fit-window-expected.txt: Renamed from LayoutTests/inspector/styles/device-metrics-fit-window-expected.txt.
* platform/chromium/inspector/styles/device-metrics-fit-window.html: Renamed from LayoutTests/inspector/styles/device-metrics-fit-window.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMediaStream API: Make PeerConnection00's API fully compliant with the draft
tommyw@google.com [Fri, 4 May 2012 17:55:20 +0000 (17:55 +0000)]
MediaStream API: Make PeerConnection00's API fully compliant with the draft
https://bugs.webkit.org/show_bug.cgi?id=85491

Reviewed by Adam Barth.

Source/Platform:

* chromium/public/WebPeerConnection00HandlerClient.h:

Source/WebCore:

Mainly making the relevant API's use objects (aka Dictionaries) instead of the temporary strings,
but also making a few API's exception aware and changing the name of a flag.

Test: fast/mediastream/peerconnection-iceoptions.html

* Modules/mediastream/PeerConnection00.cpp:
(WebCore::PeerConnection00::createMediaHints):
(WebCore::PeerConnection00::createOffer):
(WebCore):
(WebCore::PeerConnection00::createAnswer):
(WebCore::PeerConnection00::createIceOptions):
(WebCore::PeerConnection00::createDefaultIceOptions):
(WebCore::PeerConnection00::startIce):
(WebCore::PeerConnection00::addStream):
(WebCore::PeerConnection00::changeReadyState):
* Modules/mediastream/PeerConnection00.h:
(WebCore):
(PeerConnection00):
* Modules/mediastream/PeerConnection00.idl:
* platform/mediastream/chromium/PeerConnection00HandlerInternal.cpp:
(WebCore::PeerConnection00HandlerInternal::startIce):

Source/WebKit/chromium:

* src/AssertMatchingEnums.cpp:

LayoutTests:

* fast/mediastream/peerconnection-Attributes-expected.txt:
* fast/mediastream/peerconnection-iceoptions-expected.txt: Added.
* fast/mediastream/peerconnection-iceoptions.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUse destructuring assingment for the return values of the
zandobersek@gmail.com [Fri, 4 May 2012 17:52:29 +0000 (17:52 +0000)]
Use destructuring assingment for the return values of the
port.diff_image() method call.

Rubber-stamped by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/test_result_writer.py:
(write_test_result):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChromium should include MenuListPopups' and MenuListOptions' within the ax tree.
commit-queue@webkit.org [Fri, 4 May 2012 17:47:36 +0000 (17:47 +0000)]
Chromium should include MenuListPopups' and MenuListOptions' within the ax tree.
https://bugs.webkit.org/show_bug.cgi?id=85541

Patch by David Tseng <dtseng@google.com> on 2012-05-04
Reviewed by Chris Fleizach.

Covered by existing tests.
LayoutTests/accessibility/menu-list-sends-change-notification.html

* accessibility/AccessibilityMockObject.h:
(WebCore::AccessibilityMockObject::accessibilityIsIgnored):
* accessibility/chromium/AccessibilityObjectChromium.cpp:
(WebCore::AccessibilityObject::accessibilityPlatformIncludesObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/11312853> and https://bugs.webkit.org/show_bug.cgi?id=85635 Exception...
beidson@apple.com [Fri, 4 May 2012 17:44:57 +0000 (17:44 +0000)]
<rdar://problem/11312853> and https://bugs.webkit.org/show_bug.cgi?id=85635 Exception in [WebFrame loadRequest:] breaks some WebKit apps

Reviewed by Alexey Proskuryakov.

Some API clients pass in nil requests or requests with nil URLs.
In r112571 we started rewriting these URLs resulting in an exception.
Since we've supported nil requests until now, we should not try to rewrite these URLs.

* WebView/WebFrame.mm:
(-[WebFrame loadRequest:]): Don't try to rewrite invalid URLs if they are also null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStore fewer runs by default in the flakiness dashboard
ojan@chromium.org [Fri, 4 May 2012 17:44:08 +0000 (17:44 +0000)]
Store fewer runs by default in the flakiness dashboard
https://bugs.webkit.org/show_bug.cgi?id=85568

Reviewed by Dirk Pranke.

This will greatly shrink the size of the json files we load,
resulting in a much faster initial load. People rarely care
about more than 100 runs. For the cases they do, they can still click
the show all runs checkbox to show 500 runs.

* TestResultServer/model/jsonresults.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
zandobersek@gmail.com [Fri, 4 May 2012 17:41:39 +0000 (17:41 +0000)]
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Reviewed by Martin Robinson.

Remove incorrect test expectations for tests that are lately consistently
passing on all the Gtk builders but only turned out to be passing after
the Gtk port moved from using Skipped list to test_expectations.txt.
Their proper bug entries will be handled later, after all the tests are
confirmed to still pass. If any test backfires the correct test expectation
will be renewed and bug entries refreshed with latest information.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't require FrameLoaderClient to manufacture a commitData() call for empty documents.
japhet@chromium.org [Fri, 4 May 2012 17:31:03 +0000 (17:31 +0000)]
Don't require FrameLoaderClient to manufacture a commitData() call for empty documents.
https://bugs.webkit.org/show_bug.cgi?id=85533

Reviewed by Alexey Proskuryakov.

Source/WebKit/blackberry:

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::finishedLoading):

Source/WebKit/chromium:

* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::FrameLoaderClientImpl):
(WebKit):
(WebKit::FrameLoaderClientImpl::finishedLoading):
* src/FrameLoaderClientImpl.h:
(WebKit::FrameLoaderClientImpl::makeRepresentation):
(WebKit::FrameLoaderClientImpl::revertToProvisionalState):
(FrameLoaderClientImpl):

Source/WebKit/efl:

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::FrameLoaderClientEfl):
(WebCore):
(WebCore::FrameLoaderClientEfl::finishedLoading):
* WebCoreSupport/FrameLoaderClientEfl.h:
(WebCore::FrameLoaderClientEfl::makeRepresentation):
(WebCore::FrameLoaderClientEfl::revertToProvisionalState):
(FrameLoaderClientEfl):

Source/WebKit/gtk:

* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::FrameLoaderClient):
(WebKit):
(WebKit::FrameLoaderClient::finishedLoading):
* WebCoreSupport/FrameLoaderClientGtk.h:
(WebKit::FrameLoaderClient::makeRepresentation):
(WebKit::FrameLoaderClient::revertToProvisionalState):
(FrameLoaderClient):

Source/WebKit/mac:

* WebView/WebHTMLRepresentation.mm:
(-[WebHTMLRepresentation finishedLoadingWithDataSource:]): Calling commitData when finishing is no longer necessary,
    as WebCore will take care of simulating the receipt of data and ensuring the requisite work gets done in the blank document case.

Source/WebKit/qt:

* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::FrameLoaderClientQt):
(WebCore):
(WebCore::FrameLoaderClientQt::finishedLoading):
* WebCoreSupport/FrameLoaderClientQt.h:
(WebCore::FrameLoaderClientQt::makeRepresentation):
(WebCore::FrameLoaderClientQt::revertToProvisionalState):
(FrameLoaderClientQt):

Source/WebKit/win:

* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::finishedLoading):

Source/WebKit/wince:

* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::finishedLoading):

Source/WebKit/wx:

* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::finishedLoading):
(WebCore::FrameLoaderClientWx::setMainDocumentError):
(WebCore::FrameLoaderClientWx::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientWx::dispatchDidFailLoading):
* WebKitSupport/FrameLoaderClientWx.h:
(FrameLoaderClientWx):

Source/WebKit2:

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::finishedLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fixing ChangeLog conflict markers after 116009.
leviw@chromium.org [Fri, 4 May 2012 17:23:58 +0000 (17:23 +0000)]
Unreviewed. Fixing ChangeLog conflict markers after 116009.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Frame load callbacks output is missing for redirections
commit-queue@webkit.org [Fri, 4 May 2012 17:22:59 +0000 (17:22 +0000)]
[EFL] Frame load callbacks output is missing for redirections
https://bugs.webkit.org/show_bug.cgi?id=85173

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-04
Reviewed by Antonio Gomes.

Source/WebKit/efl:

Add a few redirection-related signals on the ewk_frame so that EFL's
DumpRenderTree can print the expected output when
LayoutTestController's dumpFrameLoadCallbacks() returns true.

* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchWillSendRequest):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveResponse):
(WebCore::FrameLoaderClientEfl::dispatchDidReceiveServerRedirectForProvisionalLoad):
(WebCore::FrameLoaderClientEfl::dispatchWillPerformClientRedirect):
* ewk/ewk_frame.cpp:
(ewk_frame_redirect_provisional_load):
(ewk_frame_redirect_requested):
* ewk/ewk_frame.h:
* ewk/ewk_private.h:

Tools:

Catch the new ewk_frame signals to print the expected output in case
of redirections, when LayoutTestController's dumpFrameLoadCallbacks()
returns true.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::createView):
(DumpRenderTreeChrome::onWillSendRequest):
(DumpRenderTreeChrome::onFrameCreated):
(DumpRenderTreeChrome::onFrameRedirectForProvisionalLoad):
(DumpRenderTreeChrome::onFrameRedirectRequested):
(DumpRenderTreeChrome::onResponseReceived):
* DumpRenderTree/efl/DumpRenderTreeChrome.h:
(DumpRenderTreeChrome):

LayoutTests:

Update test_expectations.txt now that EFL's DumpRenderTree is
correctly printing frame load callbacks information in case of
redirections.

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] [DRT] Gardening some failure cases on EFL port
commit-queue@webkit.org [Fri, 4 May 2012 17:19:53 +0000 (17:19 +0000)]
[EFL] [DRT] Gardening some failure cases on EFL port
https://bugs.webkit.org/show_bug.cgi?id=85605

Unreviewed, EFL gardening.

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-04

* platform/efl/fast/canvas/fillText-shadow-expected.txt: Added.
* platform/efl/fast/dom/Window/window-lookup-precedence-expected.txt: Added.
* platform/efl/fast/dom/Window/window-properties-performance-expected.txt: Added.
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] ASSERTION FAILED: shouldLoadAsEmptyDocument(r.url()) ||
danw@gnome.org [Fri, 4 May 2012 17:12:28 +0000 (17:12 +0000)]
[GTK] ASSERTION FAILED: shouldLoadAsEmptyDocument(r.url()) ||
!defersLoading() in MainResourceLoader.cpp:382

Remove a soup_session_pause_message() call that got left behind,
update the defersLoading stuff to handle this case.

https://bugs.webkit.org/show_bug.cgi?id=85159

Reviewed by Martin Robinson.

No new tests. Now passes loader/load-defer-resume-crash.html under
debug build.

* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::sendRequestCallback):
(WebCore::ResourceHandle::platformSetDefersLoading):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Device Metrics] With "Fit window" option on, page contents are downsc...
apavlov@chromium.org [Fri, 4 May 2012 17:05:38 +0000 (17:05 +0000)]
Web Inspector: [Device Metrics] With "Fit window" option on, page contents are downscaled incorrectly
https://bugs.webkit.org/show_bug.cgi?id=85510

Reviewed by Pavel Feldman.

Source/WebKit/chromium:

Use the RenderView width rather than FrameView contents width whenever possible.
Drive-by: add protection from division-by-zero (for some weird rendering states).
Test: inspector/styles/device-metrics-fit-window.html

* src/WebDevToolsAgentImpl.cpp:
(WebKit::DeviceMetricsSupport::ensureOriginalZoomFactor):
(WebKit::DeviceMetricsSupport::scaledEmulatedFrameSize):

LayoutTests:

* inspector/styles/device-metrics-fit-window-expected.txt: Added.
* inspector/styles/device-metrics-fit-window.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix up warning about missing GLib/Gio/GStreamer
vestbo@webkit.org [Fri, 4 May 2012 16:57:23 +0000 (16:57 +0000)]
[Qt] Fix up warning about missing GLib/Gio/GStreamer

We don't actually fall back.

Rubber-stamped by Csaba Osztrogonác.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Rework IME handling to fix bugs and prepare for WebKit2
mrobinson@webkit.org [Fri, 4 May 2012 16:49:39 +0000 (16:49 +0000)]
[GTK] Rework IME handling to fix bugs and prepare for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=84556

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

No new tests. This change is already covered by a suite of keyboard
handling unit tests in WebKitGTK+. There are some changes in behavior,
but they are difficult to test without mocking out an entire GtkIMContext.

Add a struct, CompositionResults, which is used by PlatformKeyboardEvent
to package composition information with a keyboard event. Also add some logic
to PlatformKeyboardEvent to give the right information when it has composition
results.

* GNUmakefile.list.am: Added new sources to the list.
* platform/PlatformKeyboardEvent.h:  Added a new CompositionResults member,
getter, and argument to the constructor.
* platform/gtk/CompositionResults.h: Added.
* platform/gtk/GtkInputMethodFilter.cpp: Added.
* platform/gtk/GtkInputMethodFilter.h: Added.
* platform/gtk/PlatformKeyboardEventGtk.cpp:
(WebCore::PlatformKeyboardEvent::windowsKeyCodeForGdkKeyCode): When
the key value is void return the VK_PROCESS keycode, which is the keycode
that web content expects with keystrokes that trigger composition events.
(WebCore::eventTypeForGdkKeyEvent): Abstract out this helper.
(WebCore::modifiersForGdkKeyEvent): Abstract out this helper.
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): When a PlatformKeyEvent
has composition results, use VK_PROCESS as the keycode for this event.
(WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent): When this event is
transformed into a Char event, the PlatformKeyboardEvent used for DOM keypress
events, and it has composition results clear the text members. This forces the
EventHandler code to drop the keypress event. Platform events that change the
composition states do not have corresponding keypress DOM events (only keydown
and keyup events), so this is necessary to ensure web compatibility.

Source/WebKit/gtk:

Rework input method handling logic into a class called GtkInputMethodFilter.
This filter now runs before WebCore event handling, allowing the code to more
easily fake simple compositions that should be seen as keystrokes. We can also
filter keypresses that should not go to web content at all, such as key up events
related to key down events that were filtered.

Also added is a WebViewInputMethodFilter which is a concrete implementation of
GtkInputMethodFilter. This class contains logic for actually sending events to
WebCore. In WebKit2 an implementation of GtkInputMethodFilter will send events
across the IPC channel.

* GNUmakefile.am: Add new files to the source list.
* WebCoreSupport/ContextMenuClientGtk.cpp:
(WebKit::inputMethodsMenuItem): Access the input method context via the filter.
* WebCoreSupport/EditorClientGtk.cpp: Remove the tricky logic of input method
events from this class, because it's now in the GtkInputMethodFilter.
(WebKit::EditorClient::setInputMethodState): Call into the filter.
(WebKit::EditorClient::shouldBeginEditing): We no longer need to update the composition here.
This is handled by the focus in and focus out logic in the filter.
(WebKit::EditorClient::shouldEndEditing): Ditto.
(WebKit::EditorClient::respondToChangedSelection): Call into the filter now.
(WebKit::EditorClient::handleInputMethodKeyboardEvent): Added this helper which executes
any pending composition confirmation or preedit update actions as the default action of
the keydown event.
(WebKit::EditorClient::handleKeyboardEvent): Call handleInputMethodKeyboardEvent to do
any pending composition action.
(WebKit::EditorClient::handleInputMethodKeydown): Remove all the logic from this method.
Keys are filtered before they are sent to WebCore now and the actual action of input method
events happens in the keydown default action to increase compatibility with other browsers.
(WebKit::EditorClient::EditorClient): Remove context signal management.
(WebKit::EditorClient::~EditorClient): Ditto.
* WebCoreSupport/EditorClientGtk.h:
(EditorClient): No longer has some members that tracked IME status.
* WebCoreSupport/WebViewInputMethodFilter.cpp: Added.
* WebCoreSupport/WebViewInputMethodFilter.h: Added.
* webkit/webkitwebview.cpp:
(webkit_web_view_get_property): Get the context from the filter now.
(webkit_web_view_key_press_event): Just send events straight to the filter.
The filter will decide whether or not to send them to WebCore.
(webkit_web_view_key_release_event): Ditto.
(webkit_web_view_button_press_event): Use the filter to handle button press
events related to IME.
(webkit_web_view_focus_in_event): Notify the filter now.
(webkit_web_view_focus_out_event): Ditto.
(webkit_web_view_realize): The filter takes care of listening for realize now.
(webkit_web_view_init): Set the WebView widget on the filter.
* webkit/webkitwebviewprivate.h: Change the GtkIMContext member to be a GtkInputMethodFilter member.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCorrectly update the outgoing referrer when navigating back from an history item...
jochen@chromium.org [Fri, 4 May 2012 16:43:03 +0000 (16:43 +0000)]
Correctly update the outgoing referrer when navigating back from an history item created by pushState/replaceState
https://bugs.webkit.org/show_bug.cgi?id=85374

Reviewed by Nate Chapin.

Source/WebCore:

Test: http/tests/history/history-navigations-set-referrer.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadInSameDocument):

LayoutTests:

* http/tests/history/history-navigations-set-referrer-expected.txt: Added.
* http/tests/history/history-navigations-set-referrer.html: Added.
* http/tests/history/resources/check-referrer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Web Timing tests gardening
commit-queue@webkit.org [Fri, 4 May 2012 16:35:25 +0000 (16:35 +0000)]
[EFL] Web Timing tests gardening
https://bugs.webkit.org/show_bug.cgi?id=85619

Unreviewed, EFL gardening.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-05-04

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION: http/tests/xmlhttprequest/basic-auth-nopassword.html started to...
ossy@webkit.org [Fri, 4 May 2012 16:32:51 +0000 (16:32 +0000)]
[Qt] REGRESSION: http/tests/xmlhttprequest/basic-auth-nopassword.html started to crash with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85632

Unreviewed gardening, skip the new _crashing_ test to paint the bot green.

* platform/qt-5.0-wk1/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Clarify warning about missing GLib/Gio/GStreamer for media support
vestbo@webkit.org [Fri, 4 May 2012 16:32:10 +0000 (16:32 +0000)]
[Qt] Clarify warning about missing GLib/Gio/GStreamer for media support

And only print it once.

Reviewed by Csaba Osztrogonác.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION: 350 tests started to fail with newer Qt5-WK1
ossy@webkit.org [Fri, 4 May 2012 16:25:35 +0000 (16:25 +0000)]
[Qt] REGRESSION: 350 tests started to fail with newer Qt5-WK1
https://bugs.webkit.org/show_bug.cgi?id=85631

Unreviewed gardening, skip new failing tests to paint the bot green.

* platform/qt-5.0-wk1/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] REGRESSION: 10 tests started to fail with newer Qt5
ossy@webkit.org [Fri, 4 May 2012 16:17:25 +0000 (16:17 +0000)]
[Qt] REGRESSION: 10 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85629

Unreviewed fix after r116106.

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Clean up and split features.prf into a static list of defaults
vestbo@webkit.org [Fri, 4 May 2012 16:09:33 +0000 (16:09 +0000)]
[Qt] Clean up and split features.prf into a static list of defaults

The static list of feature defaults is used as a fallback for any
feature that's not dynamically detected or overriden on the command
line (though build-webkit or passing DEFINES+= to qmake).

The static list is complete, which allows for auto-generation based
on Features.py (see bug https://bugs.webkit.org/show_bug.cgi?id=85456)

https://bugs.webkit.org/show_bug.cgi?id=85611

Reviewed by Simon Hausmann.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] REGRESSION: 10 tests started to fail with newer Qt5
ossy@webkit.org [Fri, 4 May 2012 15:43:50 +0000 (15:43 +0000)]
[Qt][WK2] REGRESSION: 10 tests started to fail with newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85629

Unreviewed gardening, skip new failing tests to paint the bot green.

* platform/qt-5.0-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r116085, r116091, and r116095.
zoltan@webkit.org [Fri, 4 May 2012 15:27:44 +0000 (15:27 +0000)]
Unreviewed, rolling out r116085, r116091, and r116095.
http://trac.webkit.org/changeset/116085
http://trac.webkit.org/changeset/116091
http://trac.webkit.org/changeset/116095
https://bugs.webkit.org/show_bug.cgi?id=85628

We are not ready with dependencies on all platform yet (mac) +
problems with debug builds. (Requested by Zoltan on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-04

Source/WebCore:

* Target.pri:
* WebCore.pri:
* platform/MIMETypeRegistry.cpp:
(WebCore::initializeSupportedImageMIMETypes):
(WebCore::initializeSupportedImageMIMETypesForEncoding):
* platform/graphics/ImageSource.cpp:
* platform/graphics/ImageSource.h:
(WebCore):
* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageDecoder::create):
(WebCore):
(WebCore::ImageDecoderQt::filenameExtension):
(WebCore::ImageDecoderQt::internalHandleCurrentImage):
(WebCore::ImageDecoderQt::clearPointers):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageDecoder::create):
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::getAddr):
(ImageFrame):
* platform/image-decoders/qt/ImageFrameQt.cpp: Added.
(WebCore):
(WebCore::ImageFrame::ImageFrame):
(WebCore::ImageFrame::operator=):
(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
(WebCore::ImageFrame::asNewNativeImage):
(WebCore::ImageFrame::hasAlpha):
(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setColorProfile):
(WebCore::ImageFrame::setStatus):
(WebCore::ImageFrame::setPixmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataEnableFeatures.in:

Tools:

* qmake/mkspecs/features/features.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: eliminate temporaryProfile property from ProfilesPanel.
loislo@chromium.org [Fri, 4 May 2012 15:24:38 +0000 (15:24 +0000)]
Web Inspector: eliminate temporaryProfile property from ProfilesPanel.
https://bugs.webkit.org/show_bug.cgi?id=85623

We can run different profilers at the same time therefore we have to keep temorary profile per profiler type.

Reviewed by Yury Semikhatsky.

* inspector/front-end/CSSSelectorProfileView.js:
(WebInspector.CSSSelectorProfileType.prototype.createView):
(WebInspector.CSSSelectorProfileType.prototype.createTemporaryProfile):
(WebInspector.CSSSelectorProfileType.prototype.createProfile):
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotProfileType.prototype.createView):
(WebInspector.HeapSnapshotProfileType.prototype.createTemporaryProfile):
(WebInspector.HeapSnapshotProfileType.prototype.createProfile):
* inspector/front-end/ProfileView.js:
(WebInspector.CPUProfileType.prototype.startRecordingProfile):
(WebInspector.CPUProfileType.prototype.createView):
(WebInspector.CPUProfileType.prototype.createTemporaryProfile):
(WebInspector.CPUProfileType.prototype.createProfile):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileType.prototype.createSidebarTreeElementForProfile):
(WebInspector.ProfileType.prototype.createTemporaryProfile):
(WebInspector.ProfileType.prototype.createProfile):
(WebInspector.ProfileHeader):
(WebInspector.HeapProfileHeader):
(WebInspector.ProfilesPanel.prototype.addProfileHeader):
(WebInspector.ProfilesPanel.prototype.findTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._removeTemporaryProfile):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback.var):
(WebInspector.ProfilesPanel.prototype._populateProfiles.populateCallback):
(WebInspector.ProfilesPanel.prototype._populateProfiles):
(WebInspector.ProfilesPanel.prototype.setRecordingProfile):
(WebInspector.ProfilesPanel.prototype.takeHeapSnapshot):
(WebInspector.ProfilesPanel.prototype._reportHeapSnapshotProgress):
(WebInspector.ProfilerDispatcher.prototype.addProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [chromium] ScriptGCEvent should not be static.
loislo@chromium.org [Fri, 4 May 2012 15:14:16 +0000 (15:14 +0000)]
Web Inspector: [chromium] ScriptGCEvent should not be static.
https://bugs.webkit.org/show_bug.cgi?id=80788

The static members of ScriptGCEvent were moved into per isolate data structure.
Drive by fix: Sometimes the used heap size after a GC is slightly more than it was before.

Reviewed by Yury Semikhatsky.

* bindings/v8/ScriptGCEvent.cpp:
(WebCore::ScriptGCEvent::gcPrologueCallback):
(WebCore::ScriptGCEvent::gcEpilogueCallback):
* bindings/v8/V8Binding.h:
(WebCore::GCEventData::GCEventData):
(WebCore::GCEventData::clear):
(GCEventData):
(WebCore):
(WebCore::V8BindingPerIsolateData::gcEventData):
(V8BindingPerIsolateData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Update Qt bridge after changes to QMetaMethod
ossy@webkit.org [Fri, 4 May 2012 14:52:30 +0000 (14:52 +0000)]
[Qt] Update Qt bridge after changes to QMetaMethod
https://bugs.webkit.org/show_bug.cgi?id=85478

Patch by Kent Hansen <kent.hansen@nokia.com> on 2012-05-04
Reviewed by Tor Arne Vestbø.

QMetaMethod::signature() has been renamed to methodSignature() and
returns a QByteArray.

The new function QMetaMethod::name() gives direct access to a
method's name. returnType(), parameterCount(), and parameterType()
give direct access to type information.

Ported the custom QtConnectionObject meta-object to revision 7;
revision 6 and below aren't supported (and don't compile) with Qt5.

Source/WebCore:

* Target.pri:
* bridge/qt/qt_class.cpp:
(JSC::Bindings::QtClass::fallbackObject):
* bridge/qt/qt_instance.cpp:
(JSC::Bindings::QtInstance::getPropertyNames):
* bridge/qt/qt_runtime.cpp:
(JSC::Bindings::findMethodIndex):
(Bindings):
(qt_meta_stringdata_QtConnectionObject_t):
(JSC::Bindings::QtConnectionObject::qt_static_metacall):
(JSC::Bindings::QtConnectionObject::qt_metacast):
(JSC::Bindings::QtConnectionObject::qt_metacall):
(JSC::Bindings::QtConnectionObject::execute):
* bridge/qt/qt_runtime.h:
(QtConnectionObject):
* bridge/qt/qt_runtime_qt4.cpp: Copied from Source/WebCore/bridge/qt/qt_runtime.cpp.
(Bindings):
(QWKNoDebug):
(JSC::Bindings::QWKNoDebug::QWKNoDebug):
(JSC::Bindings::QWKNoDebug::~QWKNoDebug):
(JSC::Bindings::QWKNoDebug::operator<<):
(JSC::Bindings::operator<<):
(RuntimeConversion):
(JSC::Bindings::registerCustomType):
(JSC::Bindings::isJSUint8ClampedArray):
(JSC::Bindings::valueRealType):
(JSC::Bindings::convertValueToQVariantMap):
(JSC::Bindings::convertValueToQVariant):
(JSC::Bindings::convertQVariantToValue):
(JSC::Bindings::QtRuntimeMethod::QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::finishCreation):
(JSC::Bindings::QtRuntimeMethod::~QtRuntimeMethod):
(JSC::Bindings::QtRuntimeMethod::destroy):
(JSC::Bindings::QtRuntimeMethodData::~QtRuntimeMethodData):
(JSC::Bindings::QtRuntimeMethodData::finalize):
(JSC::Bindings::QtRuntimeMetaMethodData::~QtRuntimeMetaMethodData):
(JSC::Bindings::QtRuntimeConnectionMethodData::~QtRuntimeConnectionMethodData):
(QtMethodMatchType):
(JSC::Bindings::QtMethodMatchType::QtMethodMatchType):
(JSC::Bindings::QtMethodMatchType::kind):
(JSC::Bindings::QtMethodMatchType::isValid):
(JSC::Bindings::QtMethodMatchType::isVariant):
(JSC::Bindings::QtMethodMatchType::isMetaType):
(JSC::Bindings::QtMethodMatchType::isUnresolved):
(JSC::Bindings::QtMethodMatchType::isMetaEnum):
(JSC::Bindings::QtMethodMatchType::enumeratorIndex):
(JSC::Bindings::QtMethodMatchType::variant):
(JSC::Bindings::QtMethodMatchType::metaType):
(JSC::Bindings::QtMethodMatchType::metaEnum):
(JSC::Bindings::QtMethodMatchType::unresolved):
(JSC::Bindings::QtMethodMatchType::typeId):
(JSC::Bindings::QtMethodMatchType::name):
(QtMethodMatchData):
(JSC::Bindings::QtMethodMatchData::QtMethodMatchData):
(JSC::Bindings::QtMethodMatchData::isValid):
(JSC::Bindings::QtMethodMatchData::firstUnresolvedIndex):
(JSC::Bindings::indexOfMetaEnum):
(JSC::Bindings::findMethodIndex):
(JSC::Bindings::findSignalIndex):
(JSC::Bindings::QtRuntimeMetaMethod::QtRuntimeMetaMethod):
(JSC::Bindings::QtRuntimeMetaMethod::finishCreation):
(JSC::Bindings::QtRuntimeMetaMethod::visitChildren):
(JSC::Bindings::QtRuntimeMetaMethod::call):
(JSC::Bindings::QtRuntimeMetaMethod::getCallData):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeMetaMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeMetaMethod::lengthGetter):
(JSC::Bindings::QtRuntimeMetaMethod::connectGetter):
(JSC::Bindings::QtRuntimeMetaMethod::disconnectGetter):
(JSC::Bindings::QtRuntimeConnectionMethod::QtRuntimeConnectionMethod):
(JSC::Bindings::QtRuntimeConnectionMethod::finishCreation):
(JSC::Bindings::QtRuntimeConnectionMethod::call):
(JSC::Bindings::QtRuntimeConnectionMethod::getCallData):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertySlot):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyDescriptor):
(JSC::Bindings::QtRuntimeConnectionMethod::getOwnPropertyNames):
(JSC::Bindings::QtRuntimeConnectionMethod::lengthGetter):
(JSC::Bindings::QtConnectionObject::QtConnectionObject):
(JSC::Bindings::QtConnectionObject::~QtConnectionObject):
(JSC::Bindings::QtConnectionObject::metaObject):
(JSC::Bindings::QtConnectionObject::qt_metacast):
(JSC::Bindings::QtConnectionObject::qt_metacall):
(JSC::Bindings::isJavaScriptFunction):
(JSC::Bindings::QtConnectionObject::execute):
(JSC::Bindings::QtConnectionObject::match):
(JSC::Bindings::QtConnectionObject::createWithInternalJSC):
(JSC::Bindings::::QtArray):
(JSC::Bindings::::~QtArray):
(JSC::Bindings::::rootObject):
(JSC::Bindings::::setValueAt):
(JSC::Bindings::::valueAt):

Source/WebKit2:

* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:
(gatherAPI):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Don't pass viewport-create function to quick_test_main.
ossy@webkit.org [Fri, 4 May 2012 14:50:55 +0000 (14:50 +0000)]
[Qt] Don't pass viewport-create function to quick_test_main.
https://bugs.webkit.org/show_bug.cgi?id=85478

Patch by Tor Arne Vestbø <tor.arne.vestbo@nokia.com> on 2012-05-04
Reviewed by Csaba Osztrogonác.

* UIProcess/API/qt/tests/qmltests/tst_qmltests.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Buildfix for newer Qt5
ossy@webkit.org [Fri, 4 May 2012 14:49:46 +0000 (14:49 +0000)]
[Qt] Buildfix for newer Qt5
https://bugs.webkit.org/show_bug.cgi?id=85478

Reviewed by Tor Arne Vestbø.

* Shared/qt/ProcessExecutablePathQt.cpp:
(WebKit::executablePath):
* UIProcess/API/qt/qwebiconimageprovider_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: use single method for retrieving evaluation context in the runtime...
yurys@chromium.org [Fri, 4 May 2012 14:36:43 +0000 (14:36 +0000)]
Web Inspector: use single method for retrieving evaluation context in the runtime agent
https://bugs.webkit.org/show_bug.cgi?id=85621

Reviewed by Pavel Feldman.

Merged two script state retrieval methods into one. Moved Page specific logic
into PageRuntimeAgent.

* inspector/InspectorRuntimeAgent.cpp:
(WebCore::InspectorRuntimeAgent::evaluate):
* inspector/InspectorRuntimeAgent.h:
(InspectorRuntimeAgent):
* inspector/PageRuntimeAgent.cpp:
(WebCore::PageRuntimeAgent::scriptStateForEval):
* inspector/PageRuntimeAgent.h:
(PageRuntimeAgent):
* inspector/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::scriptStateForEval):
* inspector/WorkerRuntimeAgent.h:
(WorkerRuntimeAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r115549.
jochen@chromium.org [Fri, 4 May 2012 14:33:18 +0000 (14:33 +0000)]
Unreviewed, rolling out r115549.
http://trac.webkit.org/changeset/115549
https://bugs.webkit.org/show_bug.cgi?id=83894

The newly added CRASH() statements are triggered too often

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::init):
(WebCore::FrameLoader::setupForReplace):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::clearProvisionalLoad):
(WebCore::FrameLoader::continueFragmentScrollAfterNavigationPolicy):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
commit-queue@webkit.org [Fri, 4 May 2012 14:32:42 +0000 (14:32 +0000)]
[EFL] LayoutTestController does not support overriding WebKitLoadSiteIconsKey
https://bugs.webkit.org/show_bug.cgi?id=85171

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-04
Reviewed by Andreas Kling.

Source/WebKit/efl:

Add a helper function to DumpRenderTreeSupportEfl to override the
"WebKitLoadSiteIconsKey" setting on the view page.

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
(DumpRenderTreeSupportEfl::setLoadsSiteIconsIgnoringImageLoadingSetting):
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Tools:

Implement support for overriding "WebKitLoadSiteIconsKey" setting in
EFL's LayoutTestController.

* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::overridePreference):

LayoutTests:

Unskip http/tests/misc/favicon-loads-with-icon-loading-override.html
now that EFL's LayoutTestController support overriding
WebKitLoadSiteIconsKey.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Gardening away remaining SVG failures
commit-queue@webkit.org [Fri, 4 May 2012 14:29:52 +0000 (14:29 +0000)]
[EFL][DRT] Gardening away remaining SVG failures
https://bugs.webkit.org/show_bug.cgi?id=85600

Unreviewed, EFL gardening.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-05-04

* platform/efl/svg/batik/filters/feTile-expected.png: Added.
* platform/efl/svg/batik/filters/feTile-expected.txt:
* platform/efl/svg/batik/filters/filterRegions-expected.png: Added.
* platform/efl/svg/batik/filters/filterRegions-expected.txt:
* platform/efl/svg/carto.net/button-expected.txt:
* platform/efl/svg/carto.net/colourpicker-expected.txt:
* platform/efl/svg/carto.net/slider-expected.txt:
* platform/efl/svg/carto.net/window-expected.txt:
* platform/efl/svg/css/stars-with-shadow-expected.txt: Added.
* platform/efl/svg/hixie/error/014-expected.png: Added.
* platform/efl/svg/hixie/error/014-expected.txt:
* platform/efl/svg/hixie/perf/003-expected.png: Added.
* platform/efl/svg/hixie/perf/003-expected.txt:
* platform/efl/svg/hixie/shapes/path/001-expected.png: Added.
* platform/efl/svg/hixie/shapes/path/001-expected.txt: Added.
* platform/efl/svg/hixie/use/002-expected.png: Added.
* platform/efl/svg/hixie/use/002-expected.txt:
* platform/efl/svg/repaint/filter-child-repaint-expected.png: Added.
* platform/efl/svg/repaint/filter-child-repaint-expected.txt:
* platform/efl/svg/repaint/filter-repaint-expected.png: Added.
* platform/efl/svg/repaint/filter-repaint-expected.txt:
* platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.png: Added.
* platform/efl/svg/transforms/text-with-mask-with-svg-transform-expected.txt:
* platform/efl/svg/zoom/page/zoom-foreignObject-expected.png: Added.
* platform/efl/svg/zoom/page/zoom-foreignObject-expected.txt:
* platform/efl/svg/zoom/text/zoom-foreignObject-expected.png: Added.
* platform/efl/svg/zoom/text/zoom-foreignObject-expected.txt:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Error message fix after r116091
zoltan@webkit.org [Fri, 4 May 2012 14:24:46 +0000 (14:24 +0000)]
[Qt] Error message fix after r116091
https://bugs.webkit.org/show_bug.cgi?id=85614

Reviewed by Alexis Menard.

No new tests : error message fix.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
zandobersek@gmail.com [Fri, 4 May 2012 14:16:40 +0000 (14:16 +0000)]
[Gtk] Many tests revealed as passing after moving from Skipped to test_expectations.txt
https://bugs.webkit.org/show_bug.cgi?id=85591

Unreviewed, removing incorrect test expectations for tests that turned
to be passing on all the Gtk builders after moving from using Skipped
to test_expectations.txt and have the generic BUGWKGTK modifier.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening, refined specifiers for unexpectedly passing tests.
caseq@chromium.org [Fri, 4 May 2012 14:01:21 +0000 (14:01 +0000)]
Unreviewed gardening, refined specifiers for unexpectedly passing tests.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDoesn't build with ENABLE_JIT=0
commit-queue@webkit.org [Fri, 4 May 2012 13:57:09 +0000 (13:57 +0000)]
Doesn't build with ENABLE_JIT=0
https://bugs.webkit.org/show_bug.cgi?id=85042

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-05-04
Reviewed by Gavin Barraclough.

* bytecode/Operands.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@116092 268f45cc-cd09-0410-ab3c-d52691b4dbfc