abecsi@webkit.org [Fri, 23 Jul 2010 14:36:54 +0000 (14:36 +0000)]
2010-07-23 Andras Becsi <abecsi@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable the build of MiniBrowser.
* WebKit.pro: add MiniBrowser.pro to SUBDIRS.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63973
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Jul 2010 14:34:26 +0000 (14:34 +0000)]
2010-07-23 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Kenneth Rohde Christiansen.
[EFL] Set proxy address for Soup
https://bugs.webkit.org/show_bug.cgi?id=42721
Sets the given proxy URI for libsoup network backend. This method will
support libcurl network backend later.
* EWebLauncher/main.c:
(main): Invoke proxy set method
* ewk/ewk_settings.cpp:
(ewk_settings_proxy_uri_set): Sets proxy URI.
* ewk/ewk_settings.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63972
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Fri, 23 Jul 2010 14:27:11 +0000 (14:27 +0000)]
[Qt] Build fix for Qt apps
Add webkit to QT_CONFIG. qconfig.pri will read qt_webkit_version.pri and
that's how it will pick up webkit in QT_CONFIG.
* qt_webkit_version.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63971
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Fri, 23 Jul 2010 14:19:18 +0000 (14:19 +0000)]
2010-07-23 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Inline HTMLTokenizer::InputStreamPreprocessor::peek
https://bugs.webkit.org/show_bug.cgi?id=42880
According to sampling HTMLTokenizer::InputStreamPreprocessor::peek is
the hotest function in the tokenizer. Inlining this function is about
a 2.2% speedup on the parser benchmark. Turns out the tokenizer is
much hotter than the tree builder. :)
* html/HTMLTokenizer.h:
(WebCore::HTMLTokenizer::InputStreamPreprocessor::peek):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63970
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Fri, 23 Jul 2010 14:04:16 +0000 (14:04 +0000)]
2010-07-23 Andras Becsi <abecsi@webkit.org>
Unreviewed build fix.
[Qt] Fix WebKit2 linkage.
No new tests needed.
* WebCore.pro: add InjectedBundlePageEditorClient.cpp to WK2 sources
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63969
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Fri, 23 Jul 2010 13:39:33 +0000 (13:39 +0000)]
2010-07-23 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Setup the QtWebProcess
https://bugs.webkit.org/show_bug.cgi?id=42623
* WebCore.pro: Added WebProcessMainQt.cpp to SOURCES.
2010-07-23 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Setup the QtWebProcess
https://bugs.webkit.org/show_bug.cgi?id=42623
* WebKit.pro: Add WebKit2.pro to the build guarded by webkit2 config variable.
2010-07-19 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Setup the QtWebProcess
https://bugs.webkit.org/show_bug.cgi?id=42623
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
Remove the framework entry point from here to WebProcess/qt/WebProcessMainQt.cpp to match with with the mac and the win port.
* WebKit2.pro: Added.
* WebProcess/qt/WebProcessMainQt.cpp: Added.
(WebKit::WebProcessMainQt): Framework entry point for Qt.
* qt/MainQt.cpp: Added.
(main):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63968
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 23 Jul 2010 13:19:18 +0000 (13:19 +0000)]
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: Chromium tests fix.
* inspector/CodeGeneratorInspector.pm:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63967
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Jul 2010 12:54:29 +0000 (12:54 +0000)]
2010-07-23 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Buildfix for PluginDatabaseWin.cpp
https://bugs.webkit.org/show_bug.cgi?id=41887
Define KEY_ENUMERATE_SUB_KEYS only if not defined.
* plugins/win/PluginDatabaseWin.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63966
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 23 Jul 2010 12:46:19 +0000 (12:46 +0000)]
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.
https://bugs.webkit.org/show_bug.cgi?id=42883
* bindings/v8/ScriptProfile.cpp:
(WebCore::ScriptProfile::title):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::getProfile):
* inspector/front-end/InjectedScriptAccess.js:
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Reviewed by Yury Semikhatsky.
Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.
https://bugs.webkit.org/show_bug.cgi?id=42883
* src/ToolsAgent.h:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:
* src/js/DevToolsHostStub.js:
* src/js/InspectorControllerImpl.js:
(devtools.InspectorBackendImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63965
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 23 Jul 2010 12:20:21 +0000 (12:20 +0000)]
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Not reviewed: rolling out r63963.
* bindings/v8/ScriptProfile.cpp:
(WebCore::ScriptProfile::title):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::getProfile):
* inspector/front-end/InjectedScriptAccess.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63964
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 23 Jul 2010 12:12:00 +0000 (12:12 +0000)]
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.
https://bugs.webkit.org/show_bug.cgi?id=42883
* bindings/v8/ScriptProfile.cpp:
(WebCore::ScriptProfile::title):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::getProfile):
* inspector/front-end/InjectedScriptAccess.js:
(InjectedScriptAccess.get if):
(InjectedScriptAccess):
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Reviewed by Yury Semikhatsky.
Chromium DevTools: migrate from utility context-based injected
script dispatch to upstream schema.
https://bugs.webkit.org/show_bug.cgi?id=42883
* src/ToolsAgent.h:
* src/WebDevToolsAgentImpl.cpp:
* src/WebDevToolsAgentImpl.h:
* src/js/DevToolsHostStub.js:
* src/js/InspectorControllerImpl.js:
(devtools.InspectorBackendImpl):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63963
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 23 Jul 2010 11:58:54 +0000 (11:58 +0000)]
2010-07-23 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: error info propagation in InspectorBackendDispatch should be improved
https://bugs.webkit.org/show_bug.cgi?id=42873
* inspector/CodeGeneratorInspector.pm: report wrong parameter count and wrong
parametere type errror to the dispatch method caller
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63962
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Fri, 23 Jul 2010 11:42:51 +0000 (11:42 +0000)]
2010-07-23 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: injectedScriptId is missing in the stack frame wrappers.
https://bugs.webkit.org/show_bug.cgi?id=42889
* inspector/front-end/InjectedScript.js:
(injectedScriptConstructor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63961
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 23 Jul 2010 11:24:22 +0000 (11:24 +0000)]
Unreviewed.
[Qt] Search input field doesn't have cancel button
https://bugs.webkit.org/show_bug.cgi?id=42887
* platform/qt/Skipped: fast/forms/search-cancel-button-events.html skipped until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63960
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bulach@chromium.org [Fri, 23 Jul 2010 10:02:51 +0000 (10:02 +0000)]
2010-07-23 Marcus Bulach <bulach@chromium.org>
Unreviewed. Adds expectations for chromium.
[chromium] Updates baselines following changes in history (http://trac.webkit.org/changeset/63925)
https://bugs.webkit.org/show_bug.cgi?id=42884
* platform/chromium-mac/fast/history/history-replace-illegal-expected.txt: Added.
* platform/chromium-win/fast/history/history-replace-illegal-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63959
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bulach@chromium.org [Fri, 23 Jul 2010 09:02:17 +0000 (09:02 +0000)]
2010-07-22 Marcus Bulach <bulach@chromium.org>
Reviewed by Dimitri Glazkov.
[chromium] Updates baselines following changes in border drawing code (http://trac.webkit.org/changeset/63864).
https://bugs.webkit.org/show_bug.cgi?id=42822
* platform/chromium-linux/fast/borders/different-color-borders-expected.checksum: Added.
* platform/chromium-linux/fast/borders/different-color-borders-expected.png: Added.
* platform/chromium-linux/fast/borders/different-color-borders-expected.txt: Added.
* platform/chromium-mac/fast/borders/border-radius-constraints-expected.checksum:
* platform/chromium-mac/fast/borders/border-radius-constraints-expected.png:
* platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.checksum:
* platform/chromium-mac/fast/borders/border-radius-huge-assert-expected.png:
* platform/chromium-mac/fast/borders/border-radius-split-inline-expected.checksum:
* platform/chromium-mac/fast/borders/border-radius-split-inline-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.checksum:
* platform/chromium-mac/fast/borders/borderRadiusAllStylesAllCorners-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusArcs01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.checksum:
* platform/chromium-mac/fast/borders/borderRadiusDashed01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.checksum:
* platform/chromium-mac/fast/borders/borderRadiusDashed04-expected.png: Added.
* platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum:
* platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Added.
* platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusDouble02-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusDouble03-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusGroove01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusGroove02-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusInset01-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusInset01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.checksum:
* platform/chromium-mac/fast/borders/borderRadiusInvalidColor-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusOutset01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusRidge01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusSolid01-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusSolid02-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusSolid03-expected.png:
* platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/borderRadiusSolid04-expected.png:
* platform/chromium-mac/fast/borders/different-color-borders-expected.checksum: Added.
* platform/chromium-mac/fast/borders/different-color-borders-expected.png: Added.
* platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.checksum: Removed.
* platform/chromium-mac/fast/borders/fieldsetBorderRadius-expected.png:
* platform/chromium-mac/fast/css/nested-rounded-corners-expected.checksum: Added.
* platform/chromium-mac/fast/css/nested-rounded-corners-expected.png: Added.
* platform/chromium-mac/fast/forms/basic-selects-expected.checksum:
* platform/chromium-mac/fast/forms/basic-selects-expected.png:
* platform/chromium-mac/fast/forms/menulist-clip-expected.checksum:
* platform/chromium-mac/fast/forms/menulist-clip-expected.png:
* platform/chromium-mac/fast/forms/menulist-narrow-width-expected.checksum:
* platform/chromium-mac/fast/forms/menulist-narrow-width-expected.png:
* platform/chromium-mac/fast/forms/menulist-option-wrap-expected.checksum:
* platform/chromium-mac/fast/forms/menulist-option-wrap-expected.png:
* platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.checksum:
* platform/chromium-mac/fast/forms/menulist-restrict-line-height-expected.png:
* platform/chromium-mac/fast/forms/menulist-separator-painting-expected.checksum:
* platform/chromium-mac/fast/forms/menulist-separator-painting-expected.png:
* platform/chromium-mac/fast/forms/menulist-style-color-expected.checksum:
* platform/chromium-mac/fast/forms/menulist-style-color-expected.png:
* platform/chromium-mac/fast/forms/select-baseline-expected.checksum:
* platform/chromium-mac/fast/forms/select-baseline-expected.png:
* platform/chromium-mac/fast/overflow/border-radius-clipping-expected.checksum:
* platform/chromium-mac/fast/overflow/border-radius-clipping-expected.png:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/chromium-mac/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win-xp/fast/css/nested-rounded-corners-expected.png: Added.
* platform/chromium-win/fast/css/nested-rounded-corners-expected.checksum: Added.
* platform/chromium-win/fast/css/nested-rounded-corners-expected.png: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63958
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Fri, 23 Jul 2010 08:37:15 +0000 (08:37 +0000)]
2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Kent Tamura.
Backslash isn't transcoded in <input>
https://bugs.webkit.org/show_bug.cgi?id=42878
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Kent Tamura.
Backslash isn't transcoded in <input>
https://bugs.webkit.org/show_bug.cgi?id=42878
* editing/selection/find-yensign-and-backslash-expected.txt:
* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum:
* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png:
* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63957
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 23 Jul 2010 07:28:24 +0000 (07:28 +0000)]
2010-07-23 Kent Tamura <tkent@chromium.org>
Reviewed by Shinichiro Hamaji.
Roll Chromium revision
https://bugs.webkit.org/show_bug.cgi?id=42876
* DEPS: Roll Chromium revision to r53434 in order to have the
logger initialization change (r53303)
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63956
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Fri, 23 Jul 2010 07:17:34 +0000 (07:17 +0000)]
2010-07-23 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Put a failing result for now.
Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654
* editing/selection/find-yensign-and-backslash-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63955
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Fri, 23 Jul 2010 07:03:14 +0000 (07:03 +0000)]
Unreviewed rolling out r63947 and r63948, because they broke Qt Windows build.
* jit/JITStubs.cpp:
* jit/JITStubs.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63954
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
philn@webkit.org [Fri, 23 Jul 2010 06:47:03 +0000 (06:47 +0000)]
2010-07-22 Philippe Normand <pnormand@igalia.com>
Reviewed by Eric Carlson.
media/video-duration-known-after-eos.html test is slow
https://bugs.webkit.org/show_bug.cgi?id=42809
Seek near the end of the media to speed the test up.
* media/video-duration-known-after-eos-expected.txt:
* media/video-duration-known-after-eos.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63953
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
loislo@chromium.org [Fri, 23 Jul 2010 06:39:07 +0000 (06:39 +0000)]
2010-07-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: CodeGeneratorInspector was extended and now it can
generate InspectorBackedDispatcher's code. This dispatcher will
validate and dispatch incoming inspector commands only by native
code without using javaScript. That is necessary step for
RemoteDebugging support.
https://bugs.webkit.org/show_bug.cgi?id=42588
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* WebCore.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/CodeGeneratorInspector.pm:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorController.h:
(WebCore::InspectorController::inspectorBackendDispatcher):
* inspector/front-end/ElementsPanel.js:
(WebInspector.ElementsPanel.prototype.setDocument):
2010-07-22 Ilya Tikhonovsky <loislo@chromium.org>
Reviewed by Yury Semikhatsky.
WebInspector: CodeGeneratorInspector was extended and now it can
generate InspectorBackedDispatcher's code. This dispatcher will
validate and dispatch incoming inspector commands only by native
code without using javaScript. That is necessary step for
RemoteDebugging support.
https://bugs.webkit.org/show_bug.cgi?id=42588
* src/ToolsAgent.h:
* src/WebDevToolsAgentImpl.cpp:
(WebKit::WebDevToolsAgentImpl::dispatchOnInspectorController):
* src/WebDevToolsAgentImpl.h:
* src/js/InspectorControllerImpl.js:
(devtools.InspectorBackendImpl.prototype.callInspectorController_):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63952
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Fri, 23 Jul 2010 06:26:09 +0000 (06:26 +0000)]
2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>
Unreviewed. Add expectations for Qt and Gtk.
Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654
* platform/gtk/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
* platform/qt/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63951
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hamaji@chromium.org [Fri, 23 Jul 2010 05:39:21 +0000 (05:39 +0000)]
2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Kent Tamura.
Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654
* fast/text/backslash-to-yen-sign-euc.html: Added.
* platform/chromium/test_expectations.txt:
* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.checksum: Added.
* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.png: Added.
* platform/mac/fast/text/backslash-to-yen-sign-euc-expected.txt: Added.
2010-07-22 Shinichiro Hamaji <hamaji@chromium.org>
Reviewed by Kent Tamura.
Backslash is transcoded into yen sign even when non japanese font is specified
https://bugs.webkit.org/show_bug.cgi?id=39654
Test: fast/text/backslash-to-yen-sign-euc.html
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty): Call FontDescriptor::setIsSpecifiedFont.
* platform/graphics/Font.cpp:
(WebCore::Font::Font):
* platform/graphics/FontDescription.h: Added m_isSpecifiedFont and its accessors.
(WebCore::FontDescription::FontDescription):
(WebCore::FontDescription::isSpecifiedFont):
(WebCore::FontDescription::setIsSpecifiedFont):
(WebCore::FontDescription::operator==):
* platform/text/transcoder/FontTranscoder.cpp:
(WebCore::FontTranscoder::converterType): Don't transcode backslashes if a font family is explicitly specified.
(WebCore::FontTranscoder::convert):
(WebCore::FontTranscoder::needsTranscoding):
* platform/text/transcoder/FontTranscoder.h: Change the arguments from AtomicString fontFamily to Font.
* rendering/RenderText.cpp:
(WebCore::RenderText::updateNeedsTranscoding):
(WebCore::RenderText::setTextInternal):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63950
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Fri, 23 Jul 2010 03:46:35 +0000 (03:46 +0000)]
Eliminate unneeded WKBundleFrameCopyInnerText function from WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42847
Reviewed by Sam Weinig.
WebKit2:
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp: Removed WKBundleFrameCopyInnerText.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
* WebProcess/WebPage/WebFrame.cpp: Removed innerText.
* WebProcess/WebPage/WebFrame.h: Ditto.
WebKitTools:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::operator<<): Replaced the WKStringToUTF8 function with
a set of overloaded stream operators.
(WTR::dumpPath): Changed to use ostringstream and return a string.
(WTR::propertyValue): Added.
(WTR::propertyObject): Added.
(WTR::propertyString): Added.
(WTR::numericWindowPropertyValue): Changed to call propertyValue.
(WTR::dumpFrameScrollPosition): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::dumpFrameText): Use propertyObject and propertyString instead of
WKBundleFrameCopyInnerText.
(WTR::dumpDescendantFramesText): Removed now unneeded WKStringToUTF8 sequence
since we now have suitable streaming functions.
(WTR::InjectedBundlePage::dump): Ditto.
(WTR::InjectedBundlePage::willAddMessageToConsole): Ditto.
(WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63949
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 23 Jul 2010 03:43:51 +0000 (03:43 +0000)]
Eeeep! r63947 hosed all non-x86 builds!
* jit/JITStubs.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63948
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
barraclough@apple.com [Fri, 23 Jul 2010 03:28:34 +0000 (03:28 +0000)]
Bug 42818 - [Qt] REGRESSION(63348): jsc is broken
Speculative fix, need fastcall conventions on Qt/Win.
Reviewed by Oliver Hunt.
* jit/JITStubs.cpp:
* jit/JITStubs.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63947
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
oliver@apple.com [Fri, 23 Jul 2010 03:24:53 +0000 (03:24 +0000)]
2010-07-22 Oliver Hunt <oliver@apple.com>
Reviewed by Gavin Barraclough.
Do more constant folding
https://bugs.webkit.org/show_bug.cgi?id=42867
Constant fold a few more operations. SunSpider says this is
a win but I suspect that's just code motion at play.
* parser/ASTBuilder.h:
(JSC::ASTBuilder::makeModNode):
(JSC::ASTBuilder::makeURightShiftNode):
(JSC::ASTBuilder::makeBitOrNode):
(JSC::ASTBuilder::makeBitAndNode):
(JSC::ASTBuilder::makeBitXOrNode):
(JSC::ASTBuilder::makeBinaryNode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63946
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Fri, 23 Jul 2010 03:20:31 +0000 (03:20 +0000)]
Windows build fix.
Commit some changes missed by the commit-queue in r63944.
* platform/win/BitmapInfo.h:
(WebCore::BitmapInfo::is16bit):
(WebCore::BitmapInfo::is32bit):
(WebCore::BitmapInfo::width):
(WebCore::BitmapInfo::height):
(WebCore::BitmapInfo::size):
(WebCore::BitmapInfo::paddedWidth):
(WebCore::BitmapInfo::numPixels):
(WebCore::BitmapInfo::paddedBytesPerLine):
(WebCore::BitmapInfo::bytesPerLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63945
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Jul 2010 02:55:21 +0000 (02:55 +0000)]
2010-07-22 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WINCE] Add additonal methods to BitmapInfo.
https://bugs.webkit.org/show_bug.cgi?id=42071
Added a parameter to create 16bit BitmapInfo and
some additional accessors for the WinCE port.
Set bmiHeader.biSize only at constructor.
* platform/win/BitmapInfo.cpp: Added property svn:eol-style.
(WebCore::bitmapInfoForSize):
(WebCore::BitmapInfo::create):
(WebCore::BitmapInfo::createBottomUp):
* platform/win/BitmapInfo.h: Added property svn:eol-style.
(WebCore::BitmapInfo::is16bit):
(WebCore::BitmapInfo::is32bit):
(WebCore::BitmapInfo::width):
(WebCore::BitmapInfo::height):
(WebCore::BitmapInfo::size):
(WebCore::BitmapInfo::paddedWidth):
(WebCore::BitmapInfo::numPixels):
(WebCore::BitmapInfo::paddedBytesPerLine):
(WebCore::BitmapInfo::bytesPerLine):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63944
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Fri, 23 Jul 2010 02:36:02 +0000 (02:36 +0000)]
2010-07-22 MORITA Hajime <morrita@google.com>
Reviewed by Ojan Vafai.
Autoscroll on selection should take scrollbars into account as outside of the content.
https://bugs.webkit.org/show_bug.cgi?id=40403
ScrollView's scroll-bar was considered as a part of content rect,
that prevents autoscroll to happen when the pointer is over the
scroll-bar. This change excluded scroll-bar region from scrolling
delta calculation.
Test: WebCore/manual-tests/autoscroll-over-scrollbar.html
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollRectToVisible):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63943
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 23 Jul 2010 02:29:32 +0000 (02:29 +0000)]
maxLength should not be applied to non-text types
https://bugs.webkit.org/show_bug.cgi?id=42814
Reviewed by Darin Adler.
WebCore:
According to the HTML5 specification, maxLength attribute should
be applied to text, search, url, tel, email, and password types.
Test: fast/forms/input-maxlength-unsupported.html
* dom/InputElement.cpp:
(WebCore::InputElement::handleBeforeTextInsertedEvent):
Apply maxLength() only if supportsMaxLength() is true.
* dom/InputElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::patternMismatch):
Code cleanup by isTextType().
(WebCore::HTMLInputElement::tooLong):
ditto.
(WebCore::HTMLInputElement::isTextType):
Added. This returns true for types with maxLength/pattern/placeholder.
* html/HTMLInputElement.h:
(WebCore::HTMLInputElement::supportsMaxLength):
Added. Just calls isTextType().
(WebCore::HTMLInputElement::supportsPlaceholder):
Code cleanup by isTextType().
* wml/WMLInputElement.h:
(WebCore::WMLInputElement::supportsMaxLength):
Added. Always returns true.
LayoutTests:
* fast/forms/input-maxlength-unsupported-expected.txt: Added.
* fast/forms/input-maxlength-unsupported.html: Added.
* fast/forms/script-tests/input-maxlength-unsupported.js: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63942
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Fri, 23 Jul 2010 02:26:47 +0000 (02:26 +0000)]
[cleanup] logic to extract adjacent lists and list children in listifyParagraph and unlistifyParagraph should be isolated
https://bugs.webkit.org/show_bug.cgi?id=42841
Reviewed by Kent Tamura.
Added enclosingListChild that takes the list node containing the node for the second argument
to ensure that it only returns the enclosing list child of the specified list node.
Added adjacentEnclosingList that finds adjacent lists of the specified position.
It takes the current position, the adjacent position that may or may not have a list, and the list type,
and avoids a list that belongs to a different table cell or an outer list that contains the current position.
No new tests needed.
* editing/InsertListCommand.cpp:
(WebCore::enclosingListChild): Added. See above.
(WebCore::InsertListCommand::unlistifyParagraph): Uses enclosingListChild.
(WebCore::adjacentEnclosingList): Added. See above.
(WebCore::InsertListCommand::listifyParagraph): Uses adjacentEnclosingList.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63941
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Jul 2010 02:15:09 +0000 (02:15 +0000)]
2010-07-22 Patrick Gansterer <paroga@paroga.com>
Reviewed by Adam Roben.
[WIN] Correct DeleteObject usage in PasteboardWin
https://bugs.webkit.org/show_bug.cgi?id=41956
Call DeleteObject() if OpenClipboard() fails and don't
call DeleteObject() on objects returned from SelectObject().
* platform/win/PasteboardWin.cpp:
(WebCore::Pasteboard::writeImage):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63940
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Jul 2010 02:02:57 +0000 (02:02 +0000)]
2010-07-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Log function is incorrectly used.
r63804 used LOG function, but it should receive one more parameter.
Used LOG_ERROR instead, since this is an error message.
https://bugs.webkit.org/show_bug.cgi?id=42842
* platform/efl/WidgetEfl.cpp:
(WebCore::Widget::applyFallbackCursor): use LOG_ERROR in place of LOG
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63939
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 23 Jul 2010 01:56:20 +0000 (01:56 +0000)]
More Windows build fixing.
* win/WebKit2Generated.make: Copy the new public headers to $(WEBKITOUTPUTDIR)\include\WebKit2.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63938
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 23 Jul 2010 01:30:00 +0000 (01:30 +0000)]
Windows build fix.
* win/WebKit2.vcproj: Added new files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63937
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Jul 2010 01:24:09 +0000 (01:24 +0000)]
2010-07-22 Cosmin Truta <ctruta@chromium.org>
Reviewed by Darin Adler.
SVG: Temporarily disable the layout test for the bug 41175 on Leopard.
https://bugs.webkit.org/show_bug.cgi?id=42802
* platform/mac-leopard/Skipped: svg/filters/filter-empty-g.svg skipped until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63935
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Fri, 23 Jul 2010 01:11:17 +0000 (01:11 +0000)]
2010-07-22 Lucas De Marchi <lucas.demarchi@profusion.mobi>
Reviewed by Antonio Gomes.
[EFL] Implement input method notification
https://bugs.webkit.org/show_bug.cgi?id=42640
Notify browser when keyboard should be shown/hidden. Input method
hints are updated before sending the signal. Client should be able to
determine the input type by calling ewk_view_imh_get().
* efl/EWebLauncher/main.c:
(on_inputmethod_changed): example implementation that just prints to
stdout if keyboard should be shown or hidden and the imh flags.
(browserCreate): listen to signal about input method changing its
state.
* efl/WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::setInputMethodState): call new function
responsible for implementing this notification.
* efl/ewk/ewk_private.h: ewk_view_input_method_state_set() is called
only from inside WebKit.
* efl/ewk/ewk_view.cpp: implement setters and getters
(ewk_view_imh_get):
(ewk_view_input_method_state_set):
* efl/ewk/ewk_view.h: introduce Ewk_Imh enum which contains the
possible input types.
(_Ewk_View_Smart_Class::):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63933
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Fri, 23 Jul 2010 00:59:06 +0000 (00:59 +0000)]
2010-07-22 John Gregg <johnnyg@google.com>
Unreviewed; chromium test expectation change.
fast/forms/input-file-directory-upload.html passes on windows after r63914
https://bugs.webkit.org/show_bug.cgi?id=42768
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63932
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ap@apple.com [Fri, 23 Jul 2010 00:49:55 +0000 (00:49 +0000)]
Reviewed by Sam Weinig and Darin Adler.
https://bugs.webkit.org/show_bug.cgi?id=42193
Support layoutTestController.dumpEditingDelegates in WebKitTestRunner
Step 1: Add the method, and implement one actual delegate call as proof of concept. No tests
fixed, but this makes difference one line smaller on many editing tests.
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:
* WebProcess/InjectedBundle/API/c/WKBundleBase.h:
* WebProcess/InjectedBundle/API/c/WKBundleNode.cpp: Added.
(WKBundleNodeCopyNodeName):
(WKBundleNodeGetParent):
* WebProcess/InjectedBundle/API/c/WKBundleNode.h: Added.
* WebProcess/InjectedBundle/API/c/WKBundlePage.cpp:
(WKBundlePageSetEditorClient):
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/API/c/WKBundleRange.cpp: Added.
(WKBundleRangeGetStartOffset):
(WKBundleRangeGetStartContainer):
(WKBundleRangeGetEndOffset):
(WKBundleRangeGetEndContainer):
* WebProcess/InjectedBundle/API/c/WKBundleRange.h: Added.
Added WKBundleRangeRef and WKBundleNodeRef types for injected bundles. These are just pointers
to respective WebCore objects, without any WebKit2 wrappers.
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.cpp: Added.
(WebKit::InjectedBundlePageEditorClient::InjectedBundlePageEditorClient):
(WebKit::InjectedBundlePageEditorClient::initialize):
(WebKit::InjectedBundlePageEditorClient::shouldBeginEditing):
* WebProcess/InjectedBundle/InjectedBundlePageEditorClient.h: Added.
* WebProcess/WebCoreSupport/WebEditorClient.cpp:
(WebKit::WebEditorClient::shouldBeginEditing):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::initializeInjectedBundleEditorClient):
* WebProcess/WebPage/WebPage.h:
(WebKit::WebPage::injectedBundleEditorClient):
Added the plumbing for invoking injected bundle code for editor client. There is no real API
for editor client yet.
WebKitTools:
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added dumpEditingCallbacks() and setAcceptsEditing().
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpPath): Dump path to a node in a format that's compatible with DumpRenderTree.
(WTR::operator<<): Print a range.
(WTR::InjectedBundlePage::InjectedBundlePage): Set editor client in addition to existing
clients.
(WTR::InjectedBundlePage::_shouldBeginEditing): The only client method implemented so far.
(WTR::InjectedBundlePage::shouldBeginEditing): Ditto.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added a section for editor client
calls.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController):
* WebKitTestRunner/InjectedBundle/LayoutTestController.h:
(WTR::LayoutTestController::dumpEditingCallbacks):
(WTR::LayoutTestController::setAcceptsEditing):
(WTR::LayoutTestController::acceptsEditing):
(WTR::LayoutTestController::shouldDumpEditingCallbacks):
Store m_acceptsEditing and m_dumpEditingCallbacks.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63930
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 23 Jul 2010 00:43:29 +0000 (00:43 +0000)]
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
Cancel button of search input field should fire input/change events
https://bugs.webkit.org/show_bug.cgi?id=34393
* fast/forms/script-tests/search-cancel-button-events.js: Added.
* fast/forms/search-cancel-button-events-expected.txt: Added.
* fast/forms/search-cancel-button-events.html: Added.
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
Cancel button of search input field should fire input/change events
https://bugs.webkit.org/show_bug.cgi?id=34393
Test: fast/forms/search-cancel-button-events.html
* rendering/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63929
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Fri, 23 Jul 2010 00:37:03 +0000 (00:37 +0000)]
Fix for <rdar://problem/8222626>
Send textDidChangeInTextField delegate callback only in response to typing or other forms of user text input.
Reviewed by Maciej Stachowiak.
WebCore:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
Update project files.
* dom/UserTypingGestureIndicator.cpp: Copied from dom/UserGestureIndicator.cpp.
(WebCore::UserTypingGestureIndicator::processingUserTypingGesture):
(WebCore::focusedNode):
(WebCore::UserTypingGestureIndicator::focusedElementAtGestureStart):
(WebCore::UserTypingGestureIndicator::UserTypingGestureIndicator):
(WebCore::UserTypingGestureIndicator::~UserTypingGestureIndicator):
* dom/UserTypingGestureIndicator.h: Copied from dom/UserGestureIndicator.h.
Version of UserGestureIndicator that just tracks keyboard gestures and the focused
node they were targeting.
* editing/Editor.cpp:
(WebCore::Editor::confirmComposition):
(WebCore::Editor::setComposition):
* page/EventHandler.cpp:
(WebCore::EventHandler::keyEvent):
Put UserTypingGestureIndicator on the stack for user generated keyboard events.
WebKit/mac:
The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
should migrate to a new function name eventually
* WebCoreSupport/WebEditorClient.mm:
(WebEditorClient::textDidChangeInTextField):
WebKit/win:
The function name no longer perfectly matches the behavior, but I didn't want to break any existing clients. Maybe we
should migrate to a new function name eventually
* WebCoreSupport/WebEditorClient.cpp:
(WebEditorClient::textDidChangeInTextField):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63927
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Fri, 23 Jul 2010 00:32:24 +0000 (00:32 +0000)]
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
<input type=number> stepper buttons should dispatch input/change events
https://bugs.webkit.org/show_bug.cgi?id=42440
* fast/forms/input-number-events-expected.txt: Added.
* fast/forms/input-number-events.html: Added.
* fast/forms/script-tests/input-number-events.js: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Ojan Vafai.
<input type=number> stepper buttons should dispatch input/change events
https://bugs.webkit.org/show_bug.cgi?id=42440
Test: fast/forms/input-number-events.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::stepUpFromRenderer):
Sets a flag to dispatch 'change' event and dispatches 'input' event
if the value is changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63926
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Fri, 23 Jul 2010 00:29:11 +0000 (00:29 +0000)]
2010-07-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Make history state methods validate against document URL
https://bugs.webkit.org/show_bug.cgi?id=42858
Test: fast/history/history-replace-illegal.html
* page/History.cpp:
(WebCore::History::urlForState):
2010-07-22 Justin Schuh <jschuh@chromium.org>
Reviewed by Adam Barth.
Make history state methods validate against document URL
https://bugs.webkit.org/show_bug.cgi?id=42858
* fast/history/history-replace-illegal-expected.txt: Added.
* fast/history/history-replace-illegal.html: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63925
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aestes@apple.com [Fri, 23 Jul 2010 00:25:17 +0000 (00:25 +0000)]
When there are no beforeload listeners on a document,
HTMLLinkElement::process() should be called immediately when the node is
inserted into the document, rather than waiting until after attach is
performed.
<https://bugs.webkit.org/show_bug.cgi?id=42859>
<rdar://problem/8194528>
Reviewed by Maciej Stachowiak.
No new tests.
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::insertedIntoDocument): If there are no
beforeload listeners, call process() immediately. Otherwise, add it as
a post-attach callback.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63924
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jamesr@google.com [Fri, 23 Jul 2010 00:18:58 +0000 (00:18 +0000)]
2010-07-22 James Robinson <jamesr@chromium.org>
Reviewed by Simon Fraser.
REGRESSION: box shadows on WebGL canvas elements repainted every frame
https://bugs.webkit.org/show_bug.cgi?id=42852
Avoid calling HTMLCanvasElement::willDraw() every time a WebGL canvas'
contents update. This call is only needed in the non-compositing
rendering path.
Covered by fast/canvas/webgl/canvas-test.html
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::markContextChanged):
(WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63923
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Fri, 23 Jul 2010 00:05:51 +0000 (00:05 +0000)]
2010-07-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Joseph Pecoraro.
Web Inspector: test that inspector will log syntax error in console without crashing
https://bugs.webkit.org/show_bug.cgi?id=42831
* inspector/console-log-syntax-error-expected.txt: Added.
* inspector/console-log-syntax-error.html: Added.
* inspector/resources/syntax-error.js: Added.
* platform/chromium/inspector/console-log-syntax-error-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63922
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yael.aharon@nokia.com [Thu, 22 Jul 2010 23:52:15 +0000 (23:52 +0000)]
2010-07-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413
Add a DRT API to set a flag so that notification requests are ignored,
and add a test for cancelling a pending notification request.
New API and test are disabled for Chromium port.
* fast/notifications/notifications-cancel-request-permission-expected.txt: Added.
* fast/notifications/notifications-cancel-request-permission.html: Added.
* fast/notifications/resources: Added.
* fast/notifications/resources/notifications-cancel-request-permission.html: Added.
* platform/chromium/test_expectations.txt:
2010-07-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413
Remove DumpRenderTree private API and introduce new API.
Also add support for informing the UI when a notification request is cancelled.
* Api/qwebpage.cpp:
(QWebPage::setUserPermission):
* Api/qwebpage.h:
* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:
* WebCoreSupport/NotificationPresenterClientQt.cpp:
(WebCore::NotificationPresenterClientQt::requestPermission):
(WebCore::NotificationPresenterClientQt::checkPermission):
(WebCore::NotificationPresenterClientQt::cancelRequestsForPermission):
(WebCore::NotificationPresenterClientQt::allowNotificationForFrame):
(WebCore::NotificationPresenterClientQt::toPage):
(WebCore::NotificationPresenterClientQt::toFrame):
* WebCoreSupport/NotificationPresenterClientQt.h:
2010-07-22 Yael Aharon <yael.aharon@nokia.com>
Reviewed by Laszlo Gombos.
[Qt] QtWebKit needs public API for Notifications.
https://bugs.webkit.org/show_bug.cgi?id=41413
Update DumpRenderTree and QtTestBrowser to use the new API.
Add new DRT API to flag that notifications permission requests should be ignored.
* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
(WebCore::WebPage::WebPage):
(WebCore::WebPage::requestPermission):
(WebCore::WebPage::checkPermission):
(WebCore::WebPage::cancelRequestsForPermission):
* DumpRenderTree/qt/DumpRenderTreeQt.h:
* DumpRenderTree/qt/LayoutTestControllerQt.cpp:
(LayoutTestController::reset):
(LayoutTestController::ignoreDesktopNotificationPermissionRequests):
(LayoutTestController::checkDesktopNotificationPermission):
* DumpRenderTree/qt/LayoutTestControllerQt.h:
(LayoutTestController::ignoreReqestForPermission):
* QtTestBrowser/main.cpp:
(LauncherWindow::LauncherWindow):
* QtTestBrowser/webpage.cpp:
(WebPage::WebPage):
(WebPage::requestPermission):
(WebPage::checkPermission):
(WebPage::cancelRequestsForPermission):
* QtTestBrowser/webpage.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63921
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Jul 2010 23:32:17 +0000 (23:32 +0000)]
Adapt sandbox for new WebProcess bootstrap service naming scheme.
<rdar://problem/8225000>
Patch by Ivan Krstić <ike@apple.com> on 2010-07-22
Reviewed by Anders Carlsson.
* WebProcess/com.apple.WebProcess.sb:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63920
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Jul 2010 23:16:37 +0000 (23:16 +0000)]
2010-07-22 Patrick Gansterer <paroga@paroga.com>
Reviewed by Ojan Vafai.
Remove useless PlatformScrollBar
https://bugs.webkit.org/show_bug.cgi?id=41911
* WebCore.gypi:
* platform/win/PlatformScrollBar.h: Removed.
* platform/win/PlatformScrollBarWin.cpp: Removed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63919
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 22 Jul 2010 22:55:21 +0000 (22:55 +0000)]
[Windows] Home hey doesn't work in first DIV inside a TABLE
https://bugs.webkit.org/show_bug.cgi?id=42767
Reviewed by Ojan Vafai.
WebCore:
The bug was caused by positionAvoidingFirstPositionInTable moving outside of the editing region.
Added a check so that it avoids the first position in the table only if the table is editable.
Test: editing/selection/home-inside-noneditable-table.html
* editing/visible_units.cpp:
(WebCore::positionAvoidingFirstPositionInTable):
LayoutTests:
Added a test to move caret backwards to the line boundary inside a content-editable div
inside a non-editable table.
* editing/selection/home-inside-noneditable-table-expected.txt: Added.
* editing/selection/home-inside-noneditable-table.html: Added.
* resources/dump-as-markup.js: Modified to support multiple calls to dump
(Markup.dump.get if):
(Markup.dump):
(Markup.notifyDone):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63918
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Jul 2010 22:18:50 +0000 (22:18 +0000)]
It should be possible to attach to the WebProcess in gdb during startup
https://bugs.webkit.org/show_bug.cgi?id=42853
Reviewed by Adam Roben.
Create an unique bootstrap service name and pass it to the web process, instead of registering a per process
name (which was incorrect anyway). This lets us get rid of the requirement that the UI process always should be
the parent process of the web process, something which is false when running under the debugger.
* UIProcess/Launcher/mac/ProcessLauncherMac.mm:
(WebKit::ProcessLauncher::launchProcess):
* WebProcess/mac/WebProcessMainMac.mm:
(WebKit::WebProcessMain):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63917
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Thu, 22 Jul 2010 21:58:17 +0000 (21:58 +0000)]
Don't assert when Connection::invalidate is called before Connection::dispatchConnectionDidClose
https://bugs.webkit.org/show_bug.cgi?id=42851
Reviewed by Sam Weinig.
* Platform/CoreIPC/Connection.cpp:
(CoreIPC::Connection::dispatchConnectionDidClose):
Just return early if m_client is 0.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63916
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonikitoo@webkit.org [Thu, 22 Jul 2010 21:34:13 +0000 (21:34 +0000)]
Fix build warning for missing parentheses.
Reviewed by Laszlo Gombos.
Patch by Antonio Gomes <tonikitoo@webkit.org>
WebCore/html/HTMLInputElement.cpp:113: warning: suggest parentheses around '&&' within '||'
* html/HTMLInputElement.cpp:
(WebCore::isNumberCharacter):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63915
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
johnnyg@google.com [Thu, 22 Jul 2010 21:26:55 +0000 (21:26 +0000)]
2010-07-22 John Gregg <johnnyg@google.com>
Reviewed by Kent Tamura.
[chromium] fast/forms/input-file-directory-upload.html fails on win after r63454
https://bugs.webkit.org/show_bug.cgi?id=42768
Normalize path separators for the script API by convering \'s to /'s.
Covered by input-file-directory-upload.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setFileListFromRenderer):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63914
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Jul 2010 21:25:32 +0000 (21:25 +0000)]
Use ::MessageBox instead of ::DebugBreak to make the web process wait for a debugger
While ::DebugBreak can make it easier to attach a debugger (because it
brings up the Just-in-Time debugger window), using ::MessageBox has
two advantages:
1) It explains to the user what's going on, so it's harder to
mistake this debugging aid for a bug.
2) It allows you to debug the UI process and the web process using
the same debugger, if desired.
Special thanks to John Sullivan for help with the text that's shown in
the alert.
Fixes <http://webkit.org/b/42848> WebKit2's wait-for-debugger
debugging aid should explain to the user what's happening
Reviewed by John Sullivan and Anders Carlsson.
* WebProcess/WebKitMain.cpp:
(WebKitMain): Use a ::MessageBox instead of a ::DebugBreak to wait for
the debugger. The alert explains to the user what's going on.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63913
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Jul 2010 21:25:13 +0000 (21:25 +0000)]
Make WorkQueue aware of potential errors with ::WaitForMultipleObjects
Fixes <http://webkit.org/b/42846> WorkQueue should detect
::WaitForMultipleObject failures
Reviewed by Anders Carlsson.
* Platform/win/WorkQueueWin.cpp:
(WorkQueue::workQueueThreadBody): Added some assertions about the
various things that can fail with ::WaitForMultipleObjects,
specifically:
- Passing too many objects
- Timeouts (which shouldn't happen since we pass a timeout interval
of INFINITE)
- Abandoned mutexes (which shouldn't happen since we don't wait on
any mutexes currently)
- Miscellaneous failures
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63912
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dimich@chromium.org [Thu, 22 Jul 2010 21:06:00 +0000 (21:06 +0000)]
Rubberstamped by Simon Fraser.
* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::PlatformStrategies): Add initialization of m_localizationStrategy.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63911
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
dumi@chromium.org [Thu, 22 Jul 2010 20:56:49 +0000 (20:56 +0000)]
WebCore: Make db.changeVersion()'s third parameter optional, as required by the spec.
https://bugs.webkit.org/show_bug.cgi?id=42787
Reviewed by Ojan Vafai.
* bindings/js/JSDatabaseCustom.cpp:
(WebCore::JSDatabase::changeVersion):
* bindings/js/JSDatabaseSyncCustom.cpp:
(WebCore::JSDatabaseSync::changeVersion):
* bindings/v8/custom/V8DatabaseCustom.cpp:
(WebCore::V8Database::changeVersionCallback):
* bindings/v8/custom/V8DatabaseSyncCustom.cpp:
(WebCore::V8DatabaseSync::changeVersionCallback):
* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
* storage/SQLTransactionSync.cpp:
(WebCore::SQLTransactionSync::execute):
LayoutTests: Simplify some tests, and make sure db.changeVersion()'s third parameter is optional.
https://bugs.webkit.org/show_bug.cgi?id=42787
Reviewed by Ojan Vafai.
* fast/workers/storage/resources/change-version-sync-1.js:
* fast/workers/storage/resources/change-version-sync-2.js:
* storage/change-version.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63910
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
senorblanco@chromium.org [Thu, 22 Jul 2010 20:43:06 +0000 (20:43 +0000)]
2010-07-22 Stephen White <senorblanco@chromium.org>
Unreviewed; test expectations fix.
* platform/chromium/test_expectations.txt:
Updated expectations to match reality on the bots.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63909
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Thu, 22 Jul 2010 20:33:08 +0000 (20:33 +0000)]
2010-07-20 Jessie Berlin <jberlin@apple.com>
Reviewed by Darin Adler.
Code Generator: Allow negative and string constants.
Also add tests for hexadecimal numbers.
* bindings/scripts/CodeGeneratorJS.pm:
If it is a string, do not try to cast it to an int.
* bindings/scripts/IDLStructure.pm:
Add a regex just for constant values that allows strings, hexadecimal numbers, and integral numbers.
* bindings/scripts/test/CPP/WebDOMTestObj.h:
Update the tests.
* bindings/scripts/test/JS/JSTestObj.cpp:
Ditto.
* bindings/scripts/test/JS/JSTestObj.h:
Ditto.
* bindings/scripts/test/ObjC/DOMTestObj.h:
Ditto.
* bindings/scripts/test/TestObj.idl:
Add tests for negative numbers, strings, and hexadecimal numbers.
* bindings/scripts/test/V8/V8TestObj.cpp:
Update the tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63908
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Thu, 22 Jul 2010 20:17:38 +0000 (20:17 +0000)]
2010-07-22 Simon Fraser <simon.fraser@apple.com>
Reviewed by Darin Adler.
Composited layers don't scroll in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42771
More prep work: make a single scrollPositionChanged() bottleneck method, and use it to
send the scroll event, repaint fixed elements, and update compositing layers.
* page/FrameView.cpp:
(WebCore::FrameView::scrollPositionChangedViaPlatformWidget):
(WebCore::FrameView::scrollPositionChanged):
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore::FrameView::valueChanged):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::valueChanged):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63907
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 22 Jul 2010 20:00:39 +0000 (20:00 +0000)]
2010-07-22 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
https://bugs.webkit.org/show_bug.cgi?id=42325
* platform/mac-wk2/Skipped: Removed a duplicate and sorted lists of tests.
Added some tests to the pasteboard list. Removed the tests from the
dumpChildFramesAsText list that now pass, and moved others to other lists.
2010-07-22 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs to support layoutTestController.dumpChildFramesAsText
https://bugs.webkit.org/show_bug.cgi?id=42325
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
Added dumpChildFramesAsText.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::dumpFrameText): Added.
(WTR::dumpDescendantFramesText): Added.
(WTR::InjectedBundlePage::dumpAllFramesText): Added.
(WTR::InjectedBundlePage::dump): Changed to use the new whatToDump function
instead of the shouldDumpAsText function, and added a case for AllFramesText.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Added dumpAllFramesText.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): Replaced m_dumpAsText with
m_whatToDump.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Added
dumpChildFramesAsText. Removed shouldDumpAsText, shouldDumpDOMAsWebArchive,
and shouldDumpSourceAsWebArchive. Added whatToDump.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63906
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Thu, 22 Jul 2010 18:39:31 +0000 (18:39 +0000)]
2010-07-22 Darin Fisher <darin@chromium.org>
Reviewed by David Levin.
[Chromium] Propagate return value of EventHandler::handleMouseWheelEvent
to caller of WebViewImpl::handleInputEvent.
https://bugs.webkit.org/show_bug.cgi?id=42835
* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::mouseWheel):
(WebKit::WebViewImpl::handleInputEvent):
* src/WebViewImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63905
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Thu, 22 Jul 2010 18:18:26 +0000 (18:18 +0000)]
Patch for https://bugs.webkit.org/show_bug.cgi?id=42836
Add localized strings stubs for WebKit2.
Reviewed by Anders Carlsson.
WebCore:
- Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
for localized strings.
Gets us below 200 tests failing in WebKitTestRunner.
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* page/mac/WebCoreViewFactory.h:
* platform/LocalizationStrategy.h: Added.
(WebCore::LocalizationStrategy::~LocalizationStrategy):
* platform/PlatformStrategies.h:
(WebCore::PlatformStrategies::pluginStrategy):
(WebCore::PlatformStrategies::localizationStrategy):
(WebCore::PlatformStrategies::PlatformStrategies):
(WebCore::PlatformStrategies::~PlatformStrategies):
* platform/mac/LocalizedStringsMac.mm:
WebKit/mac:
- Convert WebKit (mac) to use a LocalizationStrategy rather than the WebCoreViewFactory
for localized strings.
Gets us below 200 tests failing in WebKitTestRunner.
* WebCoreSupport/WebContextMenuClient.mm:
(fixMenusReceivedFromOldClients): Use LocalizedStrings rather than the factory.
* WebCoreSupport/WebPlatformStrategies.h:
* WebCoreSupport/WebPlatformStrategies.mm:
* WebCoreSupport/WebViewFactory.mm:
WebKit2:
Gets us below 200 tests failing in WebKitTestRunner.
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
* WebProcess/WebCoreSupport/WebPlatformStrategies.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63904
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 22 Jul 2010 18:08:17 +0000 (18:08 +0000)]
Unreviewed trivial build fix.
[Qt] Mend remaining issues to fix the WebKit2 build.
* Shared/qt/UpdateChunk.h: add missing function
(WebKit::UpdateChunk::isEmpty):
* UIProcess/API/qt/qwkpage_p.h: Add stub implementation
(QWKPagePrivate::pageDidEnterAcceleratedCompositing):
(QWKPagePrivate::pageDidLeaveAcceleratedCompositing):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63903
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 22 Jul 2010 18:01:32 +0000 (18:01 +0000)]
2010-07-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42830
No new tests needed.
* WebCore.pri: add ApplicationCacheStorage.h to wk2 headers
* WebCore.pro: add WebContextQt.cpp to sources
2010-07-22 Andras Becsi <abecsi@webkit.org>
Reviewed by Antonio Gomes.
[Qt] Implement WebContext::applicationCacheDirectory() for the Qt port of WebKit2.
https://bugs.webkit.org/show_bug.cgi?id=42830
* UIProcess/qt/WebContextQt.cpp: Added.
(WebKit::WebContext::applicationCacheDirectory):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63902
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Jul 2010 17:48:36 +0000 (17:48 +0000)]
2010-07-22 Joone Hur <joone.hur@samsung.com>
Reviewed by Antonio Gomes.
[EFL] add support for logging
https://bugs.webkit.org/show_bug.cgi?id=40807
Enable to turn log channels on for EFL port
* platform/efl/LoggingEfl.cpp:
(WebCore::InitializeLoggingChannelsIfNecessary):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63901
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Jul 2010 17:04:12 +0000 (17:04 +0000)]
Unreviewed.
[Qt] Add platform specific expected results for tests introduced in r62200.
* platform/qt/fast/borders/border-radius-circle-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-circle-expected.txt.
* platform/qt/fast/borders/border-radius-groove-01-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-01-expected.txt.
* platform/qt/fast/borders/border-radius-groove-02-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-02-expected.txt.
* platform/qt/fast/borders/border-radius-groove-03-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-groove-03-expected.txt.
* platform/qt/fast/borders/border-radius-wide-border-01-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-01-expected.txt.
* platform/qt/fast/borders/border-radius-wide-border-02-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-02-expected.txt.
* platform/qt/fast/borders/border-radius-wide-border-03-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-03-expected.txt.
* platform/qt/fast/borders/border-radius-wide-border-04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/border-radius-wide-border-04-expected.txt.
* platform/qt/fast/borders/borderRadiusDashed04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed04-expected.txt.
* platform/qt/fast/borders/borderRadiusDashed05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed05-expected.txt.
* platform/qt/fast/borders/borderRadiusDashed06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDashed06-expected.txt.
* platform/qt/fast/borders/borderRadiusDotted04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted04-expected.txt.
* platform/qt/fast/borders/borderRadiusDotted05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted05-expected.txt.
* platform/qt/fast/borders/borderRadiusDotted06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDotted06-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble04-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble04-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble05-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble05-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble06-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble06-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble07-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble07-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble08-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble08-expected.txt.
* platform/qt/fast/borders/borderRadiusDouble09-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/borderRadiusDouble09-expected.txt.
* platform/qt/fast/borders/different-color-borders-expected.txt: Copied from LayoutTests/platform/mac/fast/borders/different-color-borders-expected.txt and updated.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63900
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Jul 2010 17:02:14 +0000 (17:02 +0000)]
2010-07-22 Jamey Hicks <jamey.hicks@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Enable binding of QObjects to JavaScript environment for inspector frontend
This patch enables QObjects to be bound to global variables in the
javascript environment of the inspector frontend. This is useful
for writing alternate inspector frontends in javascript which need
additional native functionality. It's a lighter-weight alternative
than using an NPAPI plugin.
The code which instantiates QWebInspector uses this by setting the
dynamic property "q_inspectorJavaScriptWindowObjects" on the
QWebInspector. The value of this property should be a
QMap<QString,QVariant> mapping global variable name to QObject.
I have used this to add support for eclipse/chrome remote
debugging in QtTestBrowser.
https://bugs.webkit.org/show_bug.cgi?id=41995
* WebCoreSupport/InspectorClientQt.cpp:
(WebCore::InspectorClientWebPage::InspectorClientWebPage):
(WebCore::InspectorClientWebPage::javaScriptWindowObjectCleared):
(WebCore::InspectorClientQt::openInspectorFrontend):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63899
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Thu, 22 Jul 2010 17:00:12 +0000 (17:00 +0000)]
WebCore: Ureviewed build fix.
Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-07-22
[Qt] Fix WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=42638
* WebCore.pri:
* WebCore.pro:
WebKit2: Unreviewed build fix.
Patch by Balazs Kelemen <kb@inf.u-szeged.hu> on 2010-07-22
[Qt] Fix WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=42638
* UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::setCursor): Added empty implementation.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63898
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@chromium.org [Thu, 22 Jul 2010 16:42:43 +0000 (16:42 +0000)]
2010-07-22 Darin Fisher <darin@chromium.org>
Reviewed by Kent Tamura.
https://bugs.webkit.org/show_bug.cgi?id=42808
Pass context menu events through WebInputEvent to WebPlugin::handleInputEvent.
The DOM treats a context menu event as a type of mouse event. We therefore
do the same here, and reuse the WebMouseEvent subclass. This makes sense
since a context menu event has (x,y)-coordinates.
* public/WebInputEvent.h:
(WebKit::WebInputEvent::):
(WebKit::WebInputEvent::isMouseEventType):
* src/WebInputEventConversion.cpp:
(WebKit::WebMouseEventBuilder::WebMouseEventBuilder):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63897
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Jul 2010 16:39:38 +0000 (16:39 +0000)]
2010-07-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Stop granting universal access to inspector front-end page.
https://bugs.webkit.org/show_bug.cgi?id=42817
* inspector/InspectorFrontendClientLocal.cpp:
(WebCore::InspectorFrontendClientLocal::windowObjectCleared):
2010-07-22 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Stop granting universal access to inspector front-end page.
https://bugs.webkit.org/show_bug.cgi?id=42817
* src/WebDevToolsFrontendImpl.cpp:
(WebKit::WebDevToolsFrontendImpl::frontendLoaded):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63896
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 22 Jul 2010 16:03:21 +0000 (16:03 +0000)]
2010-07-22 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Fix inspector console tests crashes.
* bindings/v8/ScriptValue.cpp:
(WebCore::v8ToInspectorValue):
(WebCore::ScriptValue::toInspectorValue): enter v8 context before calling GetPropertyNames
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63895
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
leandro@webkit.org [Thu, 22 Jul 2010 15:19:56 +0000 (15:19 +0000)]
2010-07-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Unreviewed build fix.
[EFL] Build break for SVN r63881
https://bugs.webkit.org/show_bug.cgi?id=42813
* CMakeLists.txt: Add platform/SchemeRegistry.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63894
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Jul 2010 15:03:51 +0000 (15:03 +0000)]
2010-07-22 Balazs Kelemen <kb@inf.u-szeged.hu>
Reviewed by Antonio Gomes.
Lazy cursor creation should be guarded by #if USE(LAZY_NATIVE_CURSOR) in WebKit2
https://bugs.webkit.org/show_bug.cgi?id=42622
* Shared/WebCoreArgumentCoders.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::setCursor):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63893
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Thu, 22 Jul 2010 14:43:09 +0000 (14:43 +0000)]
2010-07-22 Hayato Ito <hayato@chromium.org>
Reviewed by Darin Adler.
Refactor CSSSelector's destructor and make it inline.
https://bugs.webkit.org/show_bug.cgi?id=42726
Refactor with no behavior change, thus no new tests.
* css/CSSSelector.cpp:
(WebCore::CSSSelectorBag::~CSSSelectorBag): Make sure the bag is empty.
(WebCore::CSSSelectorBag::add): Renamed from append().
(WebCore::CSSSelector::releaseOwnedSelectorsToBag):
(WebCore::CSSSelector::deleteReachableSelectors):
* css/CSSSelector.h:
(WebCore::CSSSelector::~CSSSelector):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63892
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Thu, 22 Jul 2010 14:33:54 +0000 (14:33 +0000)]
2010-07-22 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: should be possible to convert console message arguments to InspectorValues
https://bugs.webkit.org/show_bug.cgi?id=42457
Now it is possible to convert simple JavaScript objects to
InspectorValues.
* bindings/js/ScriptValue.cpp:
(WebCore::jsToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):
* bindings/js/ScriptValue.h:
* bindings/v8/ScriptValue.cpp:
(WebCore::v8ToInspectorValue):
(WebCore::ScriptValue::toInspectorValue):
* bindings/v8/ScriptValue.h:
* inspector/ConsoleMessage.cpp: console notifications are pushed to RemoteInspectorFrontend instead of InspectorFrontend.
(WebCore::ConsoleMessage::CallFrame::buildInspectorObject):
(WebCore::ConsoleMessage::addToFrontend):
(WebCore::ConsoleMessage::updateRepeatCountInConsole):
* inspector/ConsoleMessage.h:
* inspector/InjectedScript.cpp:
(WebCore::InjectedScript::wrapForConsole): return InspectorValue instead of SerializedScriptValue
* inspector/InjectedScript.h:
* inspector/Inspector.idl:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::clearConsoleMessages): send response directly from the backend
(WebCore::InspectorBackend::remoteFrontend):
* inspector/InspectorBackend.h:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::addConsoleMessage):
(WebCore::InspectorController::clearConsoleMessages): don't send notification to the front end,
it will be send either from InspectorBackend.cpp if it was a user request or reset message will
be send to the front end if the messages are cleared due to page navigation.
(WebCore::InspectorController::populateScriptObjects):
* inspector/front-end/ConsoleView.js:
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63891
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Thu, 22 Jul 2010 14:26:45 +0000 (14:26 +0000)]
Unreviewed.
[Qt] REGRESSION(63862): animations/play-state.html fails intermittently
https://bugs.webkit.org/show_bug.cgi?id=42821
* platform/qt/Skipped: animations/play-state.html skipped until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63890
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 22 Jul 2010 14:23:27 +0000 (14:23 +0000)]
2010-07-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Modifying settings actually modifies defaultValues
https://bugs.webkit.org/show_bug.cgi?id=42816
Avoid using live modifiable objects as property default values.
* inspector/front-end/Settings.js:
(WebInspector.Settings):
(WebInspector.Settings.prototype.reset):
(WebInspector.Settings.prototype._load):
(WebInspector.Settings.prototype.installSetting):
(WebInspector.Settings.prototype._get):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63889
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
benm@google.com [Thu, 22 Jul 2010 14:07:18 +0000 (14:07 +0000)]
2010-07-22 Ben Murdoch <benm@google.com>
Reviewed by Simon Fraser.
Touch events do not affect the :active CSS state
https://bugs.webkit.org/show_bug.cgi?id=39493
Clean the code up by using a typedef based on comments
post landing of the original patch.
No change in functionality so no new tests.
* rendering/HitTestRequest.h: Typedef the HitTestRequestType to unsigned.
* WebCore.exp.in: Update export signature.
* WebCore.order: Ditto.
* page/EventHandler.cpp: use the new typedef.
* page/EventHandler.h: ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63888
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
hausmann@webkit.org [Thu, 22 Jul 2010 13:36:13 +0000 (13:36 +0000)]
[Qt] Library versioning.
2.1 is branched, trunk will become 2.2.
* Api/qwebkitglobal.h:
* qt_webkit_version.pri:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63887
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
apavlov@chromium.org [Thu, 22 Jul 2010 13:26:22 +0000 (13:26 +0000)]
2010-07-22 Alexander Pavlov <apavlov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: Rename method for CSS rule source range retrieval and fix return object format
https://bugs.webkit.org/show_bug.cgi?id=42379
WebCore:
* inspector/Inspector.idl:
* inspector/InspectorBackend.cpp:
(WebCore::InspectorBackend::getRuleRanges):
* inspector/InspectorBackend.h:
* inspector/InspectorBackend.idl:
* inspector/InspectorCSSStore.cpp:
(WebCore::InspectorCSSStore::getRuleRanges):
* inspector/InspectorCSSStore.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::getRuleRanges):
* inspector/InspectorDOMAgent.h:
* inspector/front-end/DOMAgent.js:
WebKit/chromium:
* src/js/InspectorControllerImpl.js:
(devtools.InspectorBackendImpl):
LayoutTests:
* inspector/styles-source-offsets.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63886
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Thu, 22 Jul 2010 13:01:14 +0000 (13:01 +0000)]
Windows build fix
Inspired by r63881.
* MiniBrowser/MiniBrowser.vcproj:
* WebKitTestRunner/InjectedBundle/win/InjectedBundle.vcproj:
Removed pre- and post-build events so they will be inherited from the
vsprops files.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63885
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Thu, 22 Jul 2010 12:52:35 +0000 (12:52 +0000)]
2010-07-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium Dev Tools: Separators are missing in the context menu.
https://bugs.webkit.org/show_bug.cgi?id=42761
* bindings/js/JSInspectorFrontendHostCustom.cpp:
(WebCore::JSInspectorFrontendHost::showContextMenu):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::showContextMenuCallback):
* platform/ContextMenuItem.h:
(WebCore::):
2010-07-21 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Chromium Dev Tools: Separators are missing in the context menu.
https://bugs.webkit.org/show_bug.cgi?id=42761
* src/ContextMenuClientImpl.cpp:
(WebKit::ContextMenuClientImpl::populateCustomMenuItems):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63884
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zherczeg@webkit.org [Thu, 22 Jul 2010 12:41:58 +0000 (12:41 +0000)]
SVGFilterElement & SVGFE*Element don't support dynamic invalidation, when attributes change
https://bugs.webkit.org/show_bug.cgi?id=42244
Reviewed by Nikolas Zimmermann.
WebCore:
Implementing svgAttributeChanged and childrenChanged for the base class of all filters,
called SVGFilterPrimitiveStandardAttributes.
Tests: svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.html
svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.html
* svg/SVGFilterPrimitiveStandardAttributes.cpp:
(WebCore::SVGFilterPrimitiveStandardAttributes::svgAttributeChanged):
(WebCore::SVGFilterPrimitiveStandardAttributes::childrenChanged):
* svg/SVGFilterPrimitiveStandardAttributes.h:
(WebCore::SVGFilterPrimitiveStandardAttributes::invalidateFilter):
LayoutTests:
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.png: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.checksum: Added.
* platform/mac/svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.png: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-height-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-result-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-width-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-x-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-dom-y-attr.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.html: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop-expected.txt: Added.
* svg/dynamic-updates/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.html: Added.
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-height-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-result-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-width-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-x-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-dom-y-attr.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-height-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-result-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-width-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-x-prop.js: Added.
(executeTest):
* svg/dynamic-updates/script-tests/SVGFilterPrimitiveStandardAttributes-svgdom-y-prop.js: Added.
(executeTest):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63883
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kent.hansen@nokia.com [Thu, 22 Jul 2010 12:08:50 +0000 (12:08 +0000)]
2010-07-22 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Kent Tamura.
Error properties of the Global Object are missing the DontEnum attribute
https://bugs.webkit.org/show_bug.cgi?id=28771
Add the attributes to become spec compliant.
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
2010-07-22 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Kent Tamura.
Error properties of the Global Object are missing the DontEnum attribute
https://bugs.webkit.org/show_bug.cgi?id=28771
Update expected results for tests that now pass.
* fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.1_T3-expected.txt:
* fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.2_T3-expected.txt:
* fast/js/sputnik/Conformance/10_Execution_Contexts/10.1_Definitions/10.1.5_Global_Object/S10.1.5_A2.3_T3-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63882
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jhoneycutt@apple.com [Thu, 22 Jul 2010 09:36:42 +0000 (09:36 +0000)]
Build fix. Unreviewed.
* win/WebKit2WebProcess.vcproj:
Remove the pre- and post-build events, so that they will use the value
inherited from the vsprops.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63881
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kent.hansen@nokia.com [Thu, 22 Jul 2010 08:52:40 +0000 (08:52 +0000)]
2010-07-22 Kent Hansen <kent.hansen@nokia.com>
Reviewed by Sam Weinig.
Improve coverage of fast/dom/prototype-inheritance test
https://bugs.webkit.org/show_bug.cgi?id=42354
Use Object.getOwnPropertyNames rather than for..in to enumerate
the window object's properties, so that non-enumerable (ECMA)
properties are covered as well.
* fast/dom/prototype-inheritance-expected.txt:
* fast/dom/script-tests/prototype-inheritance.js:
(propertiesOnObject):
* platform/chromium-mac/fast/dom/prototype-inheritance-expected.txt:
* platform/chromium-win/fast/dom/prototype-inheritance-expected.txt:
* platform/chromium/fast/dom/prototype-inheritance-expected.txt:
* platform/gtk/fast/dom/prototype-inheritance-expected.txt:
* platform/qt/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63880
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 22 Jul 2010 08:20:47 +0000 (08:20 +0000)]
2010-07-22 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Small refactoring for input value sanitization
https://bugs.webkit.org/show_bug.cgi?id=42807
Rename some functions to clarify their roles.
* dom/InputElement.cpp:
(WebCore::replaceEOLAndLimitLength):
Renamed from sanitizeUserInputValue().
(WebCore::InputElement::sanitizeValueForTextField):
Renamed from sanitizeValue(), and call replaceEOLAndLimitLength()
instead of sanitizeUserInputValue().
(WebCore::InputElement::sanitizeUserInputValue):
Just call replaceEOLAndLimitLength().
(WebCore::InputElement::updateValueIfNeeded):
Use non-static sanitizeValue() for consistency.
* dom/InputElement.h:
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInputType):
Revert the change of r63876. It is not needed because of the
updateValueIfNeeded() change.
(WebCore::HTMLInputElement::sanitizeValue):
Apply the sanitizeValue() renaming.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63879
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tonyg@chromium.org [Thu, 22 Jul 2010 07:40:52 +0000 (07:40 +0000)]
2010-07-22 Tony Gentilcore <tonyg@chromium.org>
Reviewed by Darin Fisher.
webkitPerformance.timing.responseEnd should not include document parse time
https://bugs.webkit.org/show_bug.cgi?id=42797
No new tests because timing based test would be flaky.
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::finishedLoading): finishedLoading() is called by the platform at the right time, but didReceiveData() synchronously invokes parsing without returning to the event loop prior to this. So by the time the didFinishLoading() method is executed, parsing is finished. The solution is to move this time to didReceiveData() prior to parsing.
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::didReceiveData): Update the time each time didReceiveData() is called.
(WebCore::MainResourceLoader::didFinishLoading): When finished, and after parsing, set responseEnd appropriately.
* loader/MainResourceLoader.h:
* page/Timing.cpp:
(WebCore::Timing::resourceLoadTimeRelativeToAbsolute): Now that responseEnd is set correctly, it can be much shorter for very fast loads (like local files). This exposed the fact that this skew check was not tight enough. We need to make sure that the whole range of values from the ResourceLoadTiming API fit within fetchStart-responseEnd, not just that requestTime fits in this range.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63878
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
darin@apple.com [Thu, 22 Jul 2010 06:52:51 +0000 (06:52 +0000)]
2010-07-21 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
* platform/mac-wk2/Skipped: Moved some tests into the correct section
now that dumpChildFrameScrollPositions is no longer the reason they
fail. Removed now-passing test. Resorted some of the tests.
2010-07-21 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
* WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::numericWindowPropertyValue): Renamed this and moved it up higher in the file.
(WTR::dumpFrameScrollPosition): Added argument telling whether to dump the frame name.
Changed to a file-internal function instead of a member function.
(WTR::dumpDescendantFrameScrollPositions): Added.
(WTR::InjectedBundlePage::dumpAllFrameScrollPositions): Added.
(WTR::InjectedBundlePage::dump): Changed to call dumpAllFrameScrollPositions when
appropriate. Also streamlined all the WKStringToUTF8 call sites.
(WTR::InjectedBundlePage::willAddMessageToConsole): Streamlined use of WKStringToUTF8.
(WTR::InjectedBundlePage::willSetStatusbarText): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptAlert): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptConfirm): Ditto.
(WTR::InjectedBundlePage::willRunJavaScriptPrompt): Ditto.
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.h: Updated for above changes.
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
(WTR::LayoutTestController::LayoutTestController): Initialize
m_shouldDumpAllFrameScrollPositions.
(WTR::LayoutTestController::shouldDumpMainFrameScrollPosition): Renamed from
shouldDumpFrameScrollPositions.
* WebKitTestRunner/InjectedBundle/LayoutTestController.h: Reorganized the file a
bit, added dumpChildFrameScrollPositions and shouldDumpAllFrameScrollPositions,
and renamed shouldDumpFrameScrollPositions to shouldDumpMainFrameScrollPosition.
2010-07-21 Darin Adler <darin@apple.com>
Reviewed by Sam Weinig.
WebKitTestRunner needs layoutTestController.dumpChildFrameScrollPositions
https://bugs.webkit.org/show_bug.cgi?id=42548
Added WKBundleFrameCopyName.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
(WKBundleFrameCopyName): Added.
* WebProcess/InjectedBundle/API/c/WKBundleFrame.h: Ditto.
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::name): Added.
* WebProcess/WebPage/WebFrame.h: Ditto.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63877
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 22 Jul 2010 03:08:59 +0000 (03:08 +0000)]
2010-07-21 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Assertion failure by changing the type of an input element with a
non-number value to 'range'.
https://bugs.webkit.org/show_bug.cgi?id=42643
* fast/forms/input-value-sanitization-expected.txt: Added.
* fast/forms/input-value-sanitization.html: Added.
* fast/forms/script-tests/input-value-sanitization.js: Added.
2010-07-21 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Adler.
Assertion failure by changing the type of an input element with a
non-number value to 'range'.
https://bugs.webkit.org/show_bug.cgi?id=42643
Test: fast/forms/input-value-sanitization.html
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::setInputType):
Update the value by HTMLInputElement::sanitizeValue() in a case that
storesValueSeparateFromAttribute() state is not changed.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63876
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jschuh@chromium.org [Thu, 22 Jul 2010 02:12:15 +0000 (02:12 +0000)]
2010-07-21 Justin Schuh <jschuh@chromium.org>
Unreviewed. Build fix.
Added platform test to account for qt's xml parser
* platform/qt/svg/custom/use-invalid-html-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63875
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Thu, 22 Jul 2010 01:54:42 +0000 (01:54 +0000)]
2010-07-21 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[DRT/Chromium] Copy the test plugin into DumpRenderTree.app/
https://bugs.webkit.org/show_bug.cgi?id=42733
This was dropped in plugin copy refactoring.
* WebKit.gyp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63874
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Thu, 22 Jul 2010 01:27:51 +0000 (01:27 +0000)]
dumpAsMarkup test conversion: create-list-from-range-selection.html and insert-list-empty-div.html
https://bugs.webkit.org/show_bug.cgi?id=42608
Reviewed by Ojan Vafai.
Converted the tests and removed the platform specific expected results.
* editing/execCommand/create-list-from-range-selection-expected.txt: Added.
* editing/execCommand/create-list-from-range-selection.html: Use dumpAsMarkup
* editing/execCommand/insert-list-empty-div-expected.txt: Added.
* editing/execCommand/insert-list-empty-div.html: Use dumpAsMarkup
* platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
* platform/chromium-linux/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
* platform/chromium-linux/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
* platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
* platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
* platform/chromium-win/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
* platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
* platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.png: Removed.
* platform/chromium-win/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
* platform/gtk/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
* platform/mac/editing/execCommand/create-list-from-range-selection-expected.checksum: Removed.
* platform/mac/editing/execCommand/create-list-from-range-selection-expected.png: Removed.
* platform/mac/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
* platform/mac/editing/execCommand/insert-list-empty-div-expected.checksum: Removed.
* platform/mac/editing/execCommand/insert-list-empty-div-expected.png: Removed.
* platform/mac/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
* platform/qt/editing/execCommand/create-list-from-range-selection-expected.txt: Removed.
* platform/qt/editing/execCommand/insert-list-empty-div-expected.txt: Removed.
* resources/dump-as-markup.js: Added setNodeToDump.
(Markup.setNodeToDump):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63873
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 22 Jul 2010 01:10:34 +0000 (01:10 +0000)]
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Darin Adler.
incorrect tabindex parsing
https://bugs.webkit.org/show_bug.cgi?id=21076
Add a test showing that our parsing of unquoted attributes in
self-closing tags complies with the spec.
* html5lib/resources/webkit02.dat: Added.
* html5lib/runner-expected-html5.txt:
* html5lib/runner-expected.txt:
* html5lib/runner.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63872
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 22 Jul 2010 01:08:36 +0000 (01:08 +0000)]
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Let's pass the doctype01.dat tests again, please
https://bugs.webkit.org/show_bug.cgi?id=42794
The upstream results check the publicId and the systemId, so we need to
make dom2string smarter and print them.
* html5lib/resources/dom2string.js:
(dom2string):
* html5lib/runner-expected-html5.txt:
* html5lib/runner-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63871
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abarth@webkit.org [Thu, 22 Jul 2010 01:04:59 +0000 (01:04 +0000)]
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement spec changes for basefont and bgsound
https://bugs.webkit.org/show_bug.cgi?id=42792
* html/HTMLTreeBuilder.cpp:
(WebCore::HTMLTreeBuilder::processStartTagForInBody):
(WebCore::HTMLTreeBuilder::processStartTag):
(WebCore::HTMLTreeBuilder::processStartTagForInHead):
2010-07-21 Adam Barth <abarth@webkit.org>
Reviewed by Eric Seidel.
Implement spec changes for basefont and bgsound
https://bugs.webkit.org/show_bug.cgi?id=42792
* html5lib/runner-expected-html5.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@63870
268f45cc-cd09-0410-ab3c-
d52691b4dbfc