WebKit-https.git
8 years ago2011-01-21 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Fri, 21 Jan 2011 11:31:15 +0000 (11:31 +0000)]
2011-01-21  Adam Klein  <adamk@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Rename ChromiumBridge to PlatformBridge
        https://bugs.webkit.org/show_bug.cgi?id=52471

        No tests added as this is a rename; no change in behavior.

        * WebCore.gypi:
        * bindings/v8/V8DOMWindowShell.cpp:
        (WebCore::reportFatalErrorInV8):
        * page/PageGroup.cpp:
        (WebCore::PageGroup::isLinkVisited):
        * platform/android/PlatformBridge.h:
        * platform/audio/chromium/AudioBusChromium.cpp:
        (WebCore::createBusFromInMemoryAudioFile):
        * platform/chromium/ChromiumBridge.h: Removed.
        * platform/chromium/ChromiumDataObjectLegacy.cpp:
        (WebCore::ChromiumDataObjectLegacy::getData):
        * platform/chromium/DragDataChromium.cpp:
        (WebCore::DragData::asURL):
        * platform/chromium/FileSystemChromium.cpp:
        (WebCore::deleteFile):
        (WebCore::deleteEmptyDirectory):
        (WebCore::getFileSize):
        (WebCore::getFileModificationTime):
        (WebCore::revealFolderInOS):
        (WebCore::directoryName):
        (WebCore::pathByAppendingComponent):
        (WebCore::makeAllDirectories):
        (WebCore::fileExists):
        (WebCore::openFile):
        (WebCore::closeFile):
        (WebCore::seekFile):
        (WebCore::truncateFile):
        (WebCore::readFromFile):
        (WebCore::writeToFile):
        * platform/chromium/LanguageChromium.cpp:
        (WebCore::platformDefaultLanguage):
        * platform/chromium/LinkHashChromium.cpp:
        (WebCore::visitedLinkHash):
        * platform/chromium/MIMETypeRegistryChromium.cpp:
        (WebCore::MIMETypeRegistry::getMIMETypeForExtension):
        (WebCore::MIMETypeRegistry::getPreferredExtensionForMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedImageMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedJavaScriptMIMEType):
        (WebCore::MIMETypeRegistry::isSupportedNonImageMIMEType):
        * platform/chromium/PasteboardChromium.cpp:
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writePlainText):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::canSmartReplace):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):
        * platform/chromium/PlatformBridge.h:
        * platform/chromium/PlatformScreenChromium.cpp:
        (WebCore::screenDepth):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::screenRect):
        (WebCore::screenAvailableRect):
        * platform/chromium/ReadableDataObject.cpp:
        (WebCore::ReadableDataObject::getData):
        (WebCore::ReadableDataObject::urlTitle):
        (WebCore::ReadableDataObject::htmlBaseUrl):
        (WebCore::ReadableDataObject::filenames):
        (WebCore::ReadableDataObject::ensureTypeCacheInitialized):
        * platform/chromium/SSLKeyGeneratorChromium.cpp:
        (WebCore::signedPublicKeyAndChallengeString):
        * platform/chromium/ScrollbarThemeChromium.cpp:
        * platform/chromium/ScrollbarThemeChromiumLinux.cpp:
        (WebCore::ScrollbarThemeChromiumLinux::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumLinux::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumLinux::paintButton):
        (WebCore::ScrollbarThemeChromiumLinux::paintThumb):
        (WebCore::ScrollbarThemeChromiumLinux::buttonSize):
        (WebCore::ScrollbarThemeChromiumLinux::minimumThumbLength):
        * platform/chromium/ScrollbarThemeChromiumMac.mm:
        (WebCore::scrollbarStateToThemeState):
        (WebCore::ScrollbarThemeChromiumMac::paint):
        * platform/chromium/ScrollbarThemeChromiumWin.cpp:
        (WebCore::ScrollbarThemeChromiumWin::scrollbarThickness):
        (WebCore::ScrollbarThemeChromiumWin::paintTrackPiece):
        (WebCore::ScrollbarThemeChromiumWin::paintButton):
        (WebCore::ScrollbarThemeChromiumWin::paintThumb):
        (WebCore::ScrollbarThemeChromiumWin::buttonSize):
        * platform/chromium/SharedTimerChromium.cpp:
        (WebCore::setSharedTimerFiredFunction):
        (WebCore::setSharedTimerFireTime):
        (WebCore::stopSharedTimer):
        * platform/chromium/SuddenTerminationChromium.cpp:
        (WebCore::disableSuddenTermination):
        (WebCore::enableSuddenTermination):
        * platform/chromium/SystemTimeChromium.cpp:
        (WebCore::currentTime):
        * platform/chromium/WritableDataObject.cpp:
        (WebCore::WritableDataObject::setData):
        * platform/graphics/chromium/CrossProcessFontLoading.mm:
        * platform/graphics/chromium/FontCacheChromiumWin.cpp:
        (WebCore::fontContainsCharacter):
        (WebCore::FillLogFont):
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):
        * platform/graphics/chromium/FontChromiumWin.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/graphics/chromium/FontPlatformDataChromiumWin.cpp:
        (WebCore::FontPlatformData::scriptFontProperties):
        * platform/graphics/chromium/FontPlatformDataLinux.cpp:
        (WebCore::FontPlatformData::querySystemForRenderStyle):
        * platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp:
        (WebCore::fillBMPGlyphs):
        * platform/graphics/chromium/ImageChromium.cpp:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/ImageChromiumMac.mm:
        (WebCore::Image::loadPlatformResource):
        * platform/graphics/chromium/SimpleFontDataChromiumWin.cpp:
        (WebCore::SimpleFontData::platformInit):
        (WebCore::SimpleFontData::determinePitch):
        (WebCore::SimpleFontData::platformWidthForGlyph):
        * platform/graphics/chromium/UniscribeHelperTextRun.cpp:
        (WebCore::UniscribeHelperTextRun::tryToPreloadFont):
        * platform/graphics/skia/FontCustomPlatformData.cpp:
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/network/chromium/CookieJarChromium.cpp:
        (WebCore::setCookies):
        (WebCore::cookies):
        (WebCore::cookieRequestHeaderFieldValue):
        (WebCore::cookiesEnabled):
        (WebCore::getRawCookies):
        (WebCore::deleteCookie):
        * platform/network/chromium/DNSChromium.cpp:
        (WebCore::prefetchDNS):
        * platform/qt/PlatformBridge.h:
        * platform/sql/chromium/SQLiteFileSystemChromium.cpp:
        (WebCore::SQLiteFileSystem::deleteDatabaseFile):
        (WebCore::SQLiteFileSystem::getDatabaseFileSize):
        * platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:
        (chromiumOpen):
        (chromiumDelete):
        (chromiumAccess):
        * platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp:
        * plugins/chromium/PluginDataChromium.cpp:
        (WebCore::PluginCache::plugins):
        * rendering/RenderThemeChromiumMac.mm:
        (WebCore::RenderThemeChromiumMac::usesTestModeFocusRingColor):
        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::caretBlinkInterval):
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformInactiveSelectionBackgroundColor):
        (WebCore::RenderThemeChromiumWin::platformActiveSelectionForegroundColor):
        (WebCore::RenderThemeChromiumWin::systemColor):
        (WebCore::RenderThemeChromiumWin::paintButton):
        (WebCore::RenderThemeChromiumWin::paintSliderTrack):
        (WebCore::menuListButtonWidth):
        (WebCore::RenderThemeChromiumWin::paintMenuList):
        (WebCore::RenderThemeChromiumWin::paintTextFieldInternal):
        (WebCore::RenderThemeChromiumWin::paintInnerSpinButton):
        (WebCore::RenderThemeChromiumWin::paintProgressBar):
        * storage/chromium/IDBFactoryBackendInterface.cpp:
        (WebCore::IDBFactoryBackendInterface::create):
        (WebCore::IDBFactoryBackendInterface::~IDBFactoryBackendInterface):
        * storage/chromium/IDBKeyPathBackendImpl.cpp:
        (WebCore::IDBKeyPathBackendImpl::createIDBKeysFromSerializedValuesAndKeyPath):
2011-01-21  Adam Klein  <adamk@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Rename ChromiumBridge to PlatformBridge
        https://bugs.webkit.org/show_bug.cgi?id=52471

        * WebKit.gyp:
        * src/AssertMatchingEnums.cpp:
        * src/PlatformBridge.cpp:
        (WebCore::toChromeClientImpl):
        (WebCore::toWebWidgetClient):
        (WebCore::getCookieJar):
        (WebCore::PlatformBridge::cacheMetadata):
        (WebCore::PlatformBridge::clipboardIsFormatAvailable):
        (WebCore::PlatformBridge::clipboardReadPlainText):
        (WebCore::PlatformBridge::clipboardReadHTML):
        (WebCore::PlatformBridge::clipboardWriteSelection):
        (WebCore::PlatformBridge::clipboardWritePlainText):
        (WebCore::PlatformBridge::clipboardWriteURL):
        (WebCore::PlatformBridge::clipboardWriteImage):
        (WebCore::PlatformBridge::clipboardWriteData):
        (WebCore::PlatformBridge::clipboardReadAvailableTypes):
        (WebCore::PlatformBridge::clipboardReadData):
        (WebCore::PlatformBridge::clipboardReadFilenames):
        (WebCore::PlatformBridge::setCookies):
        (WebCore::PlatformBridge::cookies):
        (WebCore::PlatformBridge::cookieRequestHeaderFieldValue):
        (WebCore::PlatformBridge::rawCookies):
        (WebCore::PlatformBridge::deleteCookie):
        (WebCore::PlatformBridge::cookiesEnabled):
        (WebCore::PlatformBridge::prefetchDNS):
        (WebCore::PlatformBridge::fileExists):
        (WebCore::PlatformBridge::deleteFile):
        (WebCore::PlatformBridge::deleteEmptyDirectory):
        (WebCore::PlatformBridge::getFileSize):
        (WebCore::PlatformBridge::revealFolderInOS):
        (WebCore::PlatformBridge::getFileModificationTime):
        (WebCore::PlatformBridge::directoryName):
        (WebCore::PlatformBridge::pathByAppendingComponent):
        (WebCore::PlatformBridge::makeAllDirectories):
        (WebCore::PlatformBridge::getAbsolutePath):
        (WebCore::PlatformBridge::isDirectory):
        (WebCore::PlatformBridge::filePathToURL):
        (WebCore::PlatformBridge::openFile):
        (WebCore::PlatformBridge::closeFile):
        (WebCore::PlatformBridge::seekFile):
        (WebCore::PlatformBridge::truncateFile):
        (WebCore::PlatformBridge::readFromFile):
        (WebCore::PlatformBridge::writeToFile):
        (WebCore::PlatformBridge::ensureFontLoaded):
        (WebCore::PlatformBridge::getFontFamilyForCharacters):
        (WebCore::PlatformBridge::getRenderStyleForStrike):
        (WebCore::PlatformBridge::loadFont):
        (WebCore::PlatformBridge::databaseOpenFile):
        (WebCore::PlatformBridge::databaseDeleteFile):
        (WebCore::PlatformBridge::databaseGetFileAttributes):
        (WebCore::PlatformBridge::databaseGetFileSize):
        (WebCore::PlatformBridge::idbFactory):
        (WebCore::PlatformBridge::idbShutdown):
        (WebCore::PlatformBridge::createIDBKeysFromSerializedValuesAndKeyPath):
        (WebCore::PlatformBridge::signedPublicKeyAndChallengeString):
        (WebCore::PlatformBridge::computedDefaultLanguage):
        (WebCore::PlatformBridge::layoutTestMode):
        (WebCore::PlatformBridge::isSupportedImageMIMEType):
        (WebCore::PlatformBridge::isSupportedJavaScriptMIMEType):
        (WebCore::PlatformBridge::isSupportedNonImageMIMEType):
        (WebCore::PlatformBridge::mimeTypeForExtension):
        (WebCore::PlatformBridge::mimeTypeFromFile):
        (WebCore::PlatformBridge::preferredExtensionForMIMEType):
        (WebCore::PlatformBridge::plugins):
        (WebCore::PlatformBridge::pluginScriptableObject):
        (WebCore::PlatformBridge::loadPlatformImageResource):
        (WebCore::PlatformBridge::loadPlatformAudioResource):
        (WebCore::PlatformBridge::decodeAudioFileData):
        (WebCore::PlatformBridge::sandboxEnabled):
        (WebCore::PlatformBridge::setSharedTimerFiredFunction):
        (WebCore::PlatformBridge::setSharedTimerFireTime):
        (WebCore::PlatformBridge::stopSharedTimer):
        (WebCore::PlatformBridge::decrementStatsCounter):
        (WebCore::PlatformBridge::incrementStatsCounter):
        (WebCore::PlatformBridge::histogramCustomCounts):
        (WebCore::PlatformBridge::histogramEnumeration):
        (WebCore::PlatformBridge::suddenTerminationChanged):
        (WebCore::PlatformBridge::currentTime):
        (WebCore::PlatformBridge::paintButton):
        (WebCore::PlatformBridge::paintMenuList):
        (WebCore::PlatformBridge::paintScrollbarArrow):
        (WebCore::PlatformBridge::paintScrollbarThumb):
        (WebCore::PlatformBridge::paintScrollbarTrack):
        (WebCore::PlatformBridge::paintSpinButton):
        (WebCore::PlatformBridge::paintTextField):
        (WebCore::PlatformBridge::paintTrackbar):
        (WebCore::PlatformBridge::paintProgressBar):
        (WebCore::WebThemePart):
        (WebCore::WebThemeState):
        (WebCore::GetWebThemeExtraParams):
        (WebCore::PlatformBridge::getThemePartSize):
        (WebCore::PlatformBridge::paintThemePart):
        (WebCore::PlatformBridge::traceEventBegin):
        (WebCore::PlatformBridge::traceEventEnd):
        (WebCore::PlatformBridge::visitedLinkHash):
        (WebCore::PlatformBridge::isLinkVisited):
        (WebCore::PlatformBridge::notifyJSOutOfMemory):
        (WebCore::PlatformBridge::memoryUsageMB):
        (WebCore::PlatformBridge::actualMemoryUsageMB):
        (WebCore::PlatformBridge::screenDepth):
        (WebCore::PlatformBridge::screenDepthPerComponent):
        (WebCore::PlatformBridge::screenIsMonochrome):
        (WebCore::PlatformBridge::screenRect):
        (WebCore::PlatformBridge::screenAvailableRect):
        (WebCore::PlatformBridge::popupsAllowed):
        (WebCore::WorkerContextProxy::create):
        * src/ResourceHandle.cpp:
        (WebCore::ResourceHandle::cacheMetadata):
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::WebFrameImpl):
        (WebKit::WebFrameImpl::~WebFrameImpl):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 21 Jan 2011 11:23:39 +0000 (11:23 +0000)]
2011-01-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Split Host object off from WebKitPatch for easier re-use
        https://bugs.webkit.org/show_bug.cgi?id=52284

        new-run-webkit-tests and other tools are eventually going to want one of these.
        Basically you need to inherit from this class if you want to pretend to be a
        self.tool object for Steps/Commands.

        * Scripts/webkitpy/common/host.py: Added.
        * Scripts/webkitpy/tool/main.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-21 Helder Correia <helder@sencha.com>
commit-queue@webkit.org [Fri, 21 Jan 2011 11:14:52 +0000 (11:14 +0000)]
2011-01-21  Helder Correia  <helder@sencha.com>

        Reviewed by Andreas Kling.

        [Qt] svg/css/text-gradient-shadow.svg needs expected results
        https://bugs.webkit.org/show_bug.cgi?id=52724

        * platform/qt/svg/css/text-gradient-shadow-expected.checksum: Added.
        * platform/qt/svg/css/text-gradient-shadow-expected.png: Added.
        * platform/qt/svg/css/text-gradient-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-21 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Fri, 21 Jan 2011 10:06:52 +0000 (10:06 +0000)]
2011-01-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r76335.
        http://trac.webkit.org/changeset/76335
        https://bugs.webkit.org/show_bug.cgi?id=52875

        profiler tests were broken (Requested by loislo on #webkit).

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addProfile):
        (WebCore::InspectorController::getCurrentUserInitiatedProfileName):
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
        (WebCore::InspectorInstrumentation::inspectorControllerWithFrontendForPage):
        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-21 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 21 Jan 2011 09:34:29 +0000 (09:34 +0000)]
2011-01-21  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Make userscripts/window-onerror-for-isolated-world-*.html give consistent output
        https://bugs.webkit.org/show_bug.cgi?id=52870

        Call setTimeout from "load" event listener to make sure exception in the setTimeout
        callback happens after the one in the listener.

        * platform/chromium/userscripts/window-onerror-for-isolated-world-1-expected.txt:
        * platform/chromium/userscripts/window-onerror-for-isolated-world-2-expected.txt:
        * userscripts/window-onerror-for-isolated-world-1-expected.txt:
        * userscripts/window-onerror-for-isolated-world-1.html:
        * userscripts/window-onerror-for-isolated-world-2-expected.txt:
        * userscripts/window-onerror-for-isolated-world-2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-21 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 21 Jan 2011 09:24:44 +0000 (09:24 +0000)]
2011-01-21  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: switch page/Console implementation from InspectorController to InspectorInstrumentation.

        There are some places in WebCore where we still using direct InspectorController calls.
        The idea is to pass all the Inspector related calls via InspectorInstrumentaion which is the
        Inspector facade for WebCore.

        https://bugs.webkit.org/show_bug.cgi?id=52869

        * inspector/InspectorController.cpp:
        * inspector/InspectorController.h:
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::addProfileImpl):
        (WebCore::InspectorInstrumentation::profilerEnabledImpl):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileNameImpl):
        * inspector/InspectorInstrumentation.h:
        (WebCore::InspectorInstrumentation::addProfile):
        (WebCore::InspectorInstrumentation::profilerEnabled):
        (WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
        * page/Console.cpp:
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 21 Jan 2011 06:10:42 +0000 (06:10 +0000)]
2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Maciej Stachowiak.

        Added OwnPtrCommon.h because OwnArrayPtr::set calls deleteOwnedPtr.

        * wtf/OwnArrayPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 21 Jan 2011 05:25:44 +0000 (05:25 +0000)]
2011-01-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Dan Bernstein.

        Skip a few more tests that are failing on the bots
        https://bugs.webkit.org/show_bug.cgi?id=52865

        * platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 21 Jan 2011 04:58:20 +0000 (04:58 +0000)]
2011-01-20  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Oliver Hunt.

        [WINCE] Remove obsolete JSVALUE32 code
        https://bugs.webkit.org/show_bug.cgi?id=52450

        Remove the "offset hack" in create_jit_stubs, since we
        only support JSVALUE32_64 in the meantime.

        * create_jit_stubs: Removed offset argument
        * jit/JITStubs.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 21 Jan 2011 04:07:38 +0000 (04:07 +0000)]
2011-01-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        When marking conservatively, guard against reviving dead objects.
        https://bugs.webkit.org/show_bug.cgi?id=52840

        SunSpider and v8 say no change.

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::markCallFrames): Updated to use the ConservativeSet API.

        * runtime/Heap.cpp:
        (JSC::Heap::recordExtraCost): No need to guard against conservative
        marking reviving dead objects anymore, since the conservative marking
        mechanism guards against this now.

        (JSC::Heap::markConservatively):
        (JSC::Heap::markProtectedObjects):
        (JSC::Heap::markTempSortVectors): Don't drain the mark stack inside a
        marking function. We want to establish a separation of concerns between
        visiting roots and draining the mark stack.

        (JSC::Heap::markRoots): Gather the set of conservative references before
        clearning mark bits, because conservative marking now uses the mark bits
        to determine if a reference is valid, and avoid reviving dead objects.

        (JSC::Heap::collectAllGarbage): No need to guard against conservative
        marking reviving dead objects anymore, since the conservative marking
        mechanism guards against this now.

        * runtime/Heap.h: Updated to use the ConservativeSet API.

        * runtime/MachineStackMarker.cpp:
        (JSC::MachineStackMarker::markCurrentThreadConservativelyInternal):
        (JSC::MachineStackMarker::markCurrentThreadConservatively):
        (JSC::MachineStackMarker::markOtherThreadConservatively):
        (JSC::MachineStackMarker::markMachineStackConservatively):
        * runtime/MachineStackMarker.h: Ditto.

        * runtime/MarkStack.h:
        (JSC::ConservativeSet::add):
        (JSC::ConservativeSet::mark): Added ConservativeSet, for gathering the
        set of conservative references. This is different from MarkStack, since
        we don't mark the set until it is completely gathered.

        * runtime/MarkedSpace.cpp:
        (JSC::MarkedSpace::freeBlock):
        (JSC::MarkedSpace::resizeBlocks):
        (JSC::MarkedSpace::markConservatively):
        * runtime/MarkedSpace.h: When marking conservatively, guard against
        reviving dead objects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix failing tests from r76291.
weinig@apple.com [Fri, 21 Jan 2011 03:46:13 +0000 (03:46 +0000)]
Fix failing tests from r76291.

Reviewed by Gavin Barraclough.

* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::updateScrollbars):
Take the scroll origin into account in more places.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Fri, 21 Jan 2011 03:41:11 +0000 (03:41 +0000)]
2011-01-20  Kent Tamura  <tkent@chromium.org>

        Unreviewed, sorting an Xcode project file.

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 21 Jan 2011 03:34:27 +0000 (03:34 +0000)]
2011-01-20  Ojan Vafai  <ojan@chromium.org>

        Fix the review tool for image diffs. We would get a javascript error
        because image diffs don't have line numbers.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Not reviewed, add a bug number to disabled test.
dimich@chromium.org [Fri, 21 Jan 2011 03:29:44 +0000 (03:29 +0000)]
[Chromium] Not reviewed, add a bug number to disabled test.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 21 Jan 2011 03:09:37 +0000 (03:09 +0000)]
2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        Disable the tests that start and stop the http server and web
        server, so that we don't have to worry about port collisions on
        the bots.

        https://bugs.webkit.org/show_bug.cgi?id=52861

        * Scripts/webkitpy/layout_tests/port/port_testcase.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Fri, 21 Jan 2011 02:40:33 +0000 (02:40 +0000)]
2011-01-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Darin Adler.

        Skip some tests that are failing on the WebKit2 bot
        https://bugs.webkit.org/show_bug.cgi?id=52858

        * platform/mac-wk2/Skipped: skip or re-skip some tests that fail
        on the bot for various reasons.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ben Vanik <ben.vanik@gmail.com>
commit-queue@webkit.org [Fri, 21 Jan 2011 02:35:52 +0000 (02:35 +0000)]
2011-01-20  Ben Vanik  <ben.vanik@gmail.com>

        Reviewed by Kenneth Russell.

        Implementation of the OES_standard_derivatives WebGL extension.
        https://bugs.webkit.org/show_bug.cgi?id=51678

        Changes are modeled off of the existing OESTextureFloat extension. New files,
        extension retrieval, etc all match the existing code.

        Changed ANGLEWebKitBridge to allow for multiple sets of the ANGLE shader compiler
        options. This supports the enabling of the standard derivatives flag when the
        extension is enabled. Refactored the cleanup code to make the destruction of the
        compilers (if they had been created) cleaner.

        Tested with the WebGL conformance test:
        https://cvs.khronos.org/svn/repos/registry/trunk/public/webgl/sdk/tests/conformance/oes-standard-derivatives.html
        Passes on WebKit/OSX, Chromium/OSX, and Chromium/Windows.

        * CMakeLists.txt:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSWebGLRenderingContextCustom.cpp:
        (WebCore::toJS):
        * bindings/v8/custom/V8WebGLRenderingContextCustom.cpp:
        (WebCore::toV8Object):
        * html/canvas/OESStandardDerivatives.cpp: Added.
        (WebCore::OESStandardDerivatives::OESStandardDerivatives):
        (WebCore::OESStandardDerivatives::~OESStandardDerivatives):
        (WebCore::OESStandardDerivatives::getName):
        (WebCore::OESStandardDerivatives::create):
        * html/canvas/OESStandardDerivatives.h: Added.
        * html/canvas/OESStandardDerivatives.idl: Added.
        * html/canvas/WebGLExtension.h:
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getExtension): Enable and return the new extension.
        (WebCore::WebGLRenderingContext::getParameter): Support extension enum when enabled.
        (WebCore::WebGLRenderingContext::getSupportedExtensions):
        (WebCore::WebGLRenderingContext::hint): Validate extension enum when enabled.
        (WebCore::WebGLRenderingContext::getNumberOfExtensions):
        (WebCore::WebGLRenderingContext::getExtensionNumber):
        * html/canvas/WebGLRenderingContext.h:
        * platform/graphics/ANGLEWebKitBridge.cpp:
        (WebCore::ANGLEWebKitBridge::~ANGLEWebKitBridge): Cleaned up compiler cleanup.
        (WebCore::ANGLEWebKitBridge::cleanupCompilers): Destruct compilers.
        (WebCore::ANGLEWebKitBridge::setResources): Cleanup existing compilers when changing
        ANGLE settings.
        (WebCore::ANGLEWebKitBridge::validateShaderSource): Cleaned up compiler cleanup on error.
        * platform/graphics/ANGLEWebKitBridge.h:
        (WebCore::ANGLEWebKitBridge::getResources):
        * platform/graphics/Extensions3D.h: Added enumeration for the extension.
        * platform/graphics/GraphicsContext3D.h: lumbing for GraphicsContext3D.
        * platform/graphics/opengl/Extensions3DOpenGL.cpp:
        (WebCore::Extensions3DOpenGL::Extensions3DOpenGL): Plumbed through a pointer to the
        GraphicsContext3D to handle resetting the shader compilers.
        (WebCore::Extensions3DOpenGL::supports): Desktop GL always supports this extension,
        so always return true.
        (WebCore::Extensions3DOpenGL::ensureEnabled): Reset shader compilers as required.
        * platform/graphics/opengl/Extensions3DOpenGL.h: Plumbing for GraphicsContext3D.
        * platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
        (WebCore::GraphicsContext3D::getExtensions): Plumbing for GraphicsContext3D to
        Extensions3DOpenGL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 21 Jan 2011 02:30:55 +0000 (02:30 +0000)]
2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        nrwt: rewrite google_chrome_unittest to use mock filesystem.

        https://bugs.webkit.org/show_bug.cgi?id=52772

        * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 21 Jan 2011 02:30:17 +0000 (02:30 +0000)]
2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Siedel.

        nrwt: clean up almost all remaining port references, remove
        unnecessary import clauses. The only remaining references are
        in places where a mock filesystem makes no sense or can't be
        used, and in one routine in port/google_chrome_unittest that
        I'll rewrite in a separate patch.

        https://bugs.webkit.org/show_bug.cgi?id=52771

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome.py:
        * Scripts/webkitpy/layout_tests/port/google_chrome_unittest.py:
        * Scripts/webkitpy/layout_tests/port/gtk.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/qt.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/port/win.py:
        * Scripts/webkitpy/layout_tests/test_types/image_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 21 Jan 2011 02:26:54 +0000 (02:26 +0000)]
2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        remove fs refs from run_webkit_tests, rebaseline_chromium_webkit_tests

        https://bugs.webkit.org/show_bug.cgi?id=52762

        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed Qt Skipped list update.
jer.noble@apple.com [Fri, 21 Jan 2011 02:18:47 +0000 (02:18 +0000)]
Unreviewed Qt Skipped list update.

Skip the test added in r76296 for platform/qt/.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Fri, 21 Jan 2011 02:09:48 +0000 (02:09 +0000)]
2011-01-20  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix regression(r71566): PDF in RTL block might messes up text directionality.
        https://bugs.webkit.org/show_bug.cgi?id=52776

        Test: fast/dom/52776.html

        * platform/text/BidiResolver.h:
        (WebCore::::checkDirectionInLowerRaiseEmbeddingLevel):
        (WebCore::::lowerExplicitEmbeddingLevel):
        (WebCore::::raiseExplicitEmbeddingLevel):
        (WebCore::::createBidiRunsForLine):
2011-01-20  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix regression(r71566): PDF in RTL block might messes up text directionality.
        https://bugs.webkit.org/show_bug.cgi?id=52776

        * fast/dom/52776.html: Added.
        * platform/mac/fast/dom/52776-expected.checksum: Added.
        * platform/mac/fast/dom/52776-expected.png: Added.
        * platform/mac/fast/dom/52776-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFollow-on for <rdar://problem/8890255>
bdakin@apple.com [Fri, 21 Jan 2011 01:59:14 +0000 (01:59 +0000)]
Follow-on for <rdar://problem/8890255>

Reviewed by Anders Carlsson.

This fixes a painting error with ScrollbarPainter scrollers
and the new drawing area code path.
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::updateArrowPlacement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Updating test expectations after fixing the bug:
dimich@chromium.org [Fri, 21 Jan 2011 01:43:49 +0000 (01:43 +0000)]
[chromium] Updating test expectations after fixing the bug:
https://bugs.webkit.org/show_bug.cgi?id=52062

Patch by Jenn Braithwaite <jennb@chromium.org> on 2011-01-20
Reviewed by Dmitry Titov.

* platform/chromium/test_expectations.txt:
iframe-reparenting-plugins.html is now passing on Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 21 Jan 2011 01:40:49 +0000 (01:40 +0000)]
2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, rebaseline a test added in
        http://trac.webkit.org/changeset/76274

        * platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
        * platform/chromium-linux/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
        * platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
        * platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
        * platform/chromium-win/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Fri, 21 Jan 2011 01:31:52 +0000 (01:31 +0000)]
2011-01-20  Levi Weintraub  <leviw@chromium.org>

        Unreviewed.

        Fixing build breakage.

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::willBeModified):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 21 Jan 2011 01:28:03 +0000 (01:28 +0000)]
2011-01-20  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        [chromium] fix the paths used for the rebaseline tool
        https://bugs.webkit.org/show_bug.cgi?id=52857

        Some of the bots were renamed so the path to grab the results zip
        file has changed.

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Fri, 21 Jan 2011 01:22:50 +0000 (01:22 +0000)]
2011-01-20  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt][Symbian] Smaller debug symbol size when using RVCT 4.x
        https://bugs.webkit.org/show_bug.cgi?id=52835

        * WebKit.pri: Use --remove_unneeded_entities for RVCT 4.x compilers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Fri, 21 Jan 2011 01:21:11 +0000 (01:21 +0000)]
2011-01-20  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
        https://bugs.webkit.org/show_bug.cgi?id=49511

        Test: editing/selection/rtl-move-selection-right-left.html

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::willBeModified):
        Respecting the direction of the containing block when switching selection base and extent in
        RTL content.

        (WebCore::SelectionController::modifyMovingRight):
        (WebCore::SelectionController::modifyMovingLeft):
        Using directionOfEnclosingBlock when deciding to use the selection start or end to do the
        correct thing for RTL.
2011-01-20  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Ryosuke Niwa.

        RTL: Caret goes to the opposite direction when pressing an arrow key after selection is made
        https://bugs.webkit.org/show_bug.cgi?id=49511

        * editing/editing.js:
        (execMoveSelectionLeftByCharacterCommand):
        (moveSelectionLeftByCharacterCommand):
        (execMoveSelectionRightByCharacterCommand):
        (moveSelectionRightByCharacterCommand):
        (execExtendSelectionLeftByCharacterCommand):
        (extendSelectionLeftByCharacterCommand):
        (execExtendSelectionRightByCharacterCommand):
        (extendSelectionRightByCharacterCommand):
        Adding some left/right selection convenience methods for use with RTL tests.

        * editing/selection/rtl-move-selection-right-left-expected.txt: Added.
        * editing/selection/rtl-move-selection-right-left.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Fri, 21 Jan 2011 01:06:47 +0000 (01:06 +0000)]
2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        Fix bug introduced in r72688 / bug 52768 that broke the
        generation of the output filename links in the results.html
        output. Apparently none of the unit tests actually checked to
        make sure the generated links were correct :(

        https://bugs.webkit.org/show_bug.cgi?id=52854

        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_failures_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 21 Jan 2011 00:58:50 +0000 (00:58 +0000)]
2011-01-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Oliver Hunt.

        Could review tool include style failure info?
        https://bugs.webkit.org/show_bug.cgi?id=49049

        This does not handle patches that have old paths (e.g. without the Source prefix).
        Although that would be fairly straightforward to workaround.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 21 Jan 2011 00:22:36 +0000 (00:22 +0000)]
2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, mark some rtl scrolling tests as failing to green the chromium bots.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Reviewed by Darin Adler.
ap@apple.com [Fri, 21 Jan 2011 00:19:33 +0000 (00:19 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=52849
        Make window.print work with WebKit2

        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPage::QWKPage):
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::printFrame):
        * UIProcess/WebPageProxy.h:
        * UIProcess/WebPageProxy.messages.in:
        * UIProcess/WebUIClient.cpp:
        (WebKit::WebUIClient::printFrame):
        * UIProcess/WebUIClient.h:
        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
        (WebKit::WebChromeClient::print):
        Just pass through deelagte call to a WebKit2 client.

        * UIProcess/API/C/WKPage.h: Also added "Callback" suffix to other printing related function
        types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Fri, 21 Jan 2011 00:13:32 +0000 (00:13 +0000)]
2011-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Darin Adler.

        Keep track of the latest update timestamp in the backing store
        https://bugs.webkit.org/show_bug.cgi?id=52848

        * Shared/UpdateInfo.h:
        (WebKit::UpdateInfo::UpdateInfo):
        Initialize timestamp to 0.

        * UIProcess/BackingStore.cpp:
        (WebKit::BackingStore::BackingStore):
        Initialize m_latestUpdateTimestamp to 0.

        (WebKit::BackingStore::incorporateUpdate):
        If the update is too old, discard it. Otherwise, create a bitmap
        and pass it to platformIncorporateUpdate. Finally update the timestamp.

        * UIProcess/BackingStore.h:
        Add m_latestUpdateTimestamp.

        * UIProcess/mac/BackingStoreMac.mm:
        (WebKit::BackingStore::platformIncorporateUpdate):
        Update now that we are already given the shareable bitmap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 21 Jan 2011 00:08:49 +0000 (00:08 +0000)]
2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, chromium test expectation updates.

        * platform/chromium-gpu/test_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Fri, 21 Jan 2011 00:05:35 +0000 (00:05 +0000)]
2011-01-20  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Test for https://bugs.webkit.org/show_bug.cgi?id=52769.

        * fast/dom/Window/Location/resources/set-location-after-close-new-window.html: Added.
        * fast/dom/Window/Location/set-location-after-close-expected.txt: Added.
        * fast/dom/Window/Location/set-location-after-close.html: Added.
2011-01-20  Nate Chapin  <japhet@chromium.org>

        Reviewed by Adam Barth.

        Null-check m_frame in DOMWindow::setLocation(), since it's
        possible to reach this point without it having been checked
        already.
        https://bugs.webkit.org/show_bug.cgi?id=52769

        Test: fast/dom/Window/Location/set-location-after-close.html

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::setLocation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 21 Jan 2011 00:04:53 +0000 (00:04 +0000)]
2011-01-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        handle cases where PrettyPatch.rb doesn't linkify filenames
        https://bugs.webkit.org/show_bug.cgi?id=52834

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Thu, 20 Jan 2011 23:57:46 +0000 (23:57 +0000)]
2011-01-20  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        setContentEditable with invalid string should throw exception.
        https://bugs.webkit.org/show_bug.cgi?id=52057

        Updated expected results after the fix. Also corrected test cases.

        * editing/editability/set-invalid-value-expected.txt:
        * editing/editability/set-invalid-value.html: 1. Fixed the getAttribute expectation as "abc" was failed to set. 2. Added additional check for setting empty string.
        * editing/editability/set-value-caseinsensitive-expected.txt:
        * editing/editability/set-value-caseinsensitive.html: Fixed the getAttribute expectations as all strings should be converted to lower cases.
        * fast/dom/element-attribute-js-null-expected.txt:
        * fast/dom/element-attribute-js-null.html: Fixed this existing test as the expectation for setting with null should throw exception instead of "false". Also added handling code when exception was thrown.
2011-01-20  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Darin Adler.

        setContentEditable with invalid string should throw exception.
        https://bugs.webkit.org/show_bug.cgi?id=52057

        Implemented exception throwing for setContentEditable according to the following spec:
        http://www.whatwg.org/specs/web-apps/current-work/multipage/editing.html#attr-contenteditable
        Related quotas: "On setting, if the new value is an ASCII case-insensitive match for the
        string 'inherit' then the content attribute must be removed, if the new value is an ASCII
        case-insensitive match for the string 'true' then the content attribute must be set to the
        string 'true', if the new value is an ASCII case-insensitive match for the string 'false'
        then the content attribute must be set to the string 'false', and otherwise the attribute
        setter must raise a SYNTAX_ERR exception."

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::setContentEditable): Throw exception on invalid input strings; Make setting values case-insensitive and also convert them to lower cases according to the spec.
        * html/HTMLElement.h: Add additional parameter ExceptionCode& for function setContentEditable.
        * html/HTMLElement.idl: Add exception throwing support for contentEditable setter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoShift-tab doesn't cycle through fields in http authentication panel
sullivan@apple.com [Thu, 20 Jan 2011 23:55:48 +0000 (23:55 +0000)]
Shift-tab doesn't cycle through fields in http authentication panel
https://bugs.webkit.org/show_bug.cgi?id=52850

Reviewed by Mark Rowe.

* Panels/English.lproj/WebAuthenticationPanel.nib/designable.nib:
* Panels/English.lproj/WebAuthenticationPanel.nib/keyedobjects.nib:
Re-wired the key loop so that there aren't two views with the same nextKeyView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Adrienne Walker <enne@google.com>
enne@google.com [Thu, 20 Jan 2011 23:53:44 +0000 (23:53 +0000)]
2011-01-20  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Add a test for a render surface that the uses alpha channel.
        https://bugs.webkit.org/show_bug.cgi?id=52766

        * platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.checksum: Added.
        * platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.png: Added.
        * platform/chromium-gpu/platform/chromium/compositing/render-surface-alpha-blending-expected.txt: Added.
        * platform/chromium/compositing/render-surface-alpha-blending.html: Added.
2011-01-19  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Composited render surfaces should allow writes to alpha channel.
        https://bugs.webkit.org/show_bug.cgi?id=52766

        Test: LayoutTests/platform/chromium/compositing

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::drawLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Siddharth Mathur <siddharth.mathur@nokia.com>
commit-queue@webkit.org [Thu, 20 Jan 2011 23:49:22 +0000 (23:49 +0000)]
2011-01-20  Siddharth Mathur  <siddharth.mathur@nokia.com>

        Reviewed by Geoffrey Garen.

        [Symbian] Fix StackBounds::initialize()
        https://bugs.webkit.org/show_bug.cgi?id=52842

        * wtf/StackBounds.cpp:
        (WTF::StackBounds::initialize): Use TThreadStackInfo.iLimit for stack limit

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-14 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 20 Jan 2011 23:45:05 +0000 (23:45 +0000)]
2011-01-14  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION (r71842): Compass video is not playing in Safari welcome page
        https://bugs.webkit.org/show_bug.cgi?id=52506

        Test that a delay between loading and playing video does not break playback.

        * media/video-currentTime-delay-expected.txt: Added.
        * media/video-currentTime-delay.html: Added.
2011-01-14  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION (r71842): Compass video is not playing in Safari welcome page
        https://bugs.webkit.org/show_bug.cgi?id=52506

        New test: LayoutTests/media/video-currentTime-delay.html

        Call invalidateCachedTime() every time one of the cached property dependencies changes,
        i.e. m_paused and m_playbackRate.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::prepareForLoad):
        (WebCore::HTMLMediaElement::setReadyState):
        (WebCore::HTMLMediaElement::setPlaybackRate):
        (WebCore::HTMLMediaElement::mediaPlayerRateChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build.
weinig@apple.com [Thu, 20 Jan 2011 23:41:01 +0000 (23:41 +0000)]
Fix build.

* Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Thu, 20 Jan 2011 23:37:22 +0000 (23:37 +0000)]
2011-01-20  Adam Klein  <adamk@chromium.org>

        Reviewed by Andreas Kling.

        [chromium] Remove deprecated WebKit::nameOfInputElement function
        https://bugs.webkit.org/show_bug.cgi?id=52824

        * src/DOMUtilitiesPrivate.cpp:
        * src/DOMUtilitiesPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix build.
weinig@apple.com [Thu, 20 Jan 2011 23:19:08 +0000 (23:19 +0000)]
Fix build.

* Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix for <rdar://problem/8890255>
bdakin@apple.com [Thu, 20 Jan 2011 23:18:35 +0000 (23:18 +0000)]
Fix for <rdar://problem/8890255>

Reviewed by Geoffrey Garen.

Source/WebCore:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.
* WebCore.exp.in:
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::scrollbarMap):
(+[ScrollbarPrefsObserver appearancePrefsChanged:]):
(WebCore::ScrollbarThemeMac::registerScrollbar):
(WebCore::ScrollbarThemeMac::unregisterScrollbar):
(WebCore::ScrollbarThemeMac::paint):
* platform/mac/WebCoreSystemInterface.h:
* platform/mac/WebCoreSystemInterface.mm:

Source/WebKit/mac:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.
* WebCoreSupport/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

Source/WebKit2:

Allow WebKitSystemInterface to draw scrollbars
when appropriate.
* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCleanup Scrollbar/ScrollbarClient relationship
weinig@apple.com [Thu, 20 Jan 2011 23:14:47 +0000 (23:14 +0000)]
Cleanup Scrollbar/ScrollbarClient relationship
https://bugs.webkit.org/show_bug.cgi?id=52779

Reviewed by Dave Hyatt.

Source/WebCore:

Pipe all scrolling through the ScrollbarClient/ScrollAnimator
rather than through the Scrollbar. The Scrollbar now is just
a "view" on the scroll position of the scrollable area it is
attached to.

There are now two ways to scroll a scrollable area:
- ScrollbarClient::scroll()
- ScrollbarClient::scrollToOffsetWithoutAnimation()

Both of these go through the ScrollAnimator (updating its state
or starting an animation). The ScrollAnimator, in turn, now calls
ScrollbarClient::setScrollOffsetFromAnimation, which tells the
Scrollbars to pull a new offset (via Scrollbar::offsetDidChange)
and tells the class that derives from ScrollbarClient to scroll
its contents (via ScrollbarClient::setScrollOffset).

* WebCore.xcodeproj/project.pbxproj:
Move Scrollbar.cpp to the right place.

* accessibility/AccessibilityScrollbar.cpp:
(WebCore::AccessibilityScrollbar::setValue):
Initiate the scroll through the scrollbar client, rather than the
scrollbar itself.

* page/FrameView.cpp:
(WebCore::FrameView::scrollTo):
* page/FrameView.h:
Condense the two valueChanged overrides to a single override of the
scrollTo function.

* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimator::currentPosition):
(WebCore::ScrollAnimator::notityPositionChanged):
* platform/ScrollAnimator.h:
* platform/ScrollAnimatorWin.cpp:
(WebCore::ScrollAnimatorWin::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorWin::animateScroll):
* platform/ScrollAnimatorWin.h:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorMac::immediateScrollToPoint):
Change setScrollPositionAndStopAnimation to scrollToOffsetWithoutAnimation
and bottleneck all client notification of changed position through a new
notityPositionChanged() function.

* platform/ScrollView.cpp:
(WebCore::ScrollView::setScrollOffset):
(WebCore::ScrollView::scrollTo):
(WebCore::ScrollView::scrollPosition):
(WebCore::ScrollView::scroll):
(WebCore::ScrollView::updateScrollbars):
(WebCore::ScrollView::wheelEvent):
* platform/ScrollView.h:
(WebCore::ScrollView::horizontalScrollbar):
(WebCore::ScrollView::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.

* platform/Scrollbar.cpp:
(WebCore::Scrollbar::offsetDidChange):
(WebCore::Scrollbar::autoscrollPressedPart):
(WebCore::Scrollbar::moveThumb):
(WebCore::Scrollbar::mouseMoved):
* platform/Scrollbar.h:
(WebCore::Scrollbar::setPressedPos):
Change the scrollbar to only updates its offset in response to
an offsetDidChange call.

* platform/ScrollbarClient.cpp:
(WebCore::ScrollbarClient::scroll):
(WebCore::ScrollbarClient::scrollToOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToXOffsetWithoutAnimation):
(WebCore::ScrollbarClient::scrollToYOffsetWithoutAnimation):
(WebCore::ScrollbarClient::setScrollOffsetFromAnimation):
* platform/ScrollbarClient.h:
(WebCore::ScrollbarClient::horizontalScrollbar):
(WebCore::ScrollbarClient::verticalScrollbar):
Make the increasingly misnamed ScrollbarClient responsible for
scrolling.

* platform/efl/ScrollbarEfl.cpp:
(scrollbarEflEdjeMessage):
* platform/gtk/MainFrameScrollbarGtk.cpp:
(MainFrameScrollbarGtk::gtkValueChanged):
* platform/qt/ScrollbarQt.cpp:
(WebCore::Scrollbar::contextMenu):
Update to move scrolling through the client.

* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::scrollToRevealSelection):
(WebCore::PopupMenuWin::scrollPosition):
(WebCore::PopupMenuWin::setScrollOffset):
(WebCore::PopupMenuWin::scrollTo):
(WebCore::PopupMenuWin::wndProc):
* platform/win/PopupMenuWin.h:
(WebCore::PopupMenuWin::verticalScrollbar):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::scrollToOffset):
(WebCore::RenderLayer::scrollTo):
(WebCore::RenderLayer::setScrollOffset):
(WebCore::RenderLayer::scrollPosition):
(WebCore::RenderLayer::updateScrollInfoAfterLayout):
(WebCore::RenderLayer::scroll):
* rendering/RenderLayer.h:
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::scrollToRevealElementAtListIndex):
(WebCore::RenderListBox::scroll):
(WebCore::RenderListBox::logicalScroll):
(WebCore::RenderListBox::scrollPosition):
(WebCore::RenderListBox::setScrollOffset):
(WebCore::RenderListBox::scrollTo):
(WebCore::RenderListBox::setScrollTop):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::verticalScrollbar):
Update to scroll via the ScrollbarClient rather than the Scrollbar.

* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::start):
Simplify initial paint to just do an immediate scroll to the position.

Source/WebKit/chromium:

* src/WebScrollbarImpl.cpp:
(WebKit::WebScrollbarImpl::WebScrollbarImpl):
(WebKit::WebScrollbarImpl::value):
(WebKit::WebScrollbarImpl::setValue):
(WebKit::WebScrollbarImpl::scroll):
(WebKit::WebScrollbarImpl::onMouseDown):
(WebKit::WebScrollbarImpl::onMouseMove):
(WebKit::WebScrollbarImpl::onMouseWheel):
(WebKit::WebScrollbarImpl::onKeyDown):
(WebKit::WebScrollbarImpl::scrollPosition):
(WebKit::WebScrollbarImpl::setScrollOffset):
* src/WebScrollbarImpl.h:

Source/WebKit/qt:

* Api/qwebframe.cpp:
(QWebFrame::setScrollBarValue):

Source/WebKit/win:

* WebScrollBar.cpp:
(WebScrollBar::WebScrollBar):
(WebScrollBar::setValue):
(WebScrollBar::value):
(WebScrollBar::scroll):
(WebScrollBar::scrollPosition):
(WebScrollBar::setScrollOffset):
* WebScrollBar.h:

Source/WebKit2:

* UIProcess/win/WebPopupMenuProxyWin.cpp:
(WebKit::WebPopupMenuProxyWin::scrollPosition):
(WebKit::WebPopupMenuProxyWin::setScrollOffset):
(WebKit::WebPopupMenuProxyWin::scrollTo):
(WebKit::WebPopupMenuProxyWin::onMouseWheel):
(WebKit::WebPopupMenuProxyWin::scrollToRevealSelection):
* UIProcess/win/WebPopupMenuProxyWin.h:
(WebKit::WebPopupMenuProxyWin::verticalScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 20 Jan 2011 23:14:02 +0000 (23:14 +0000)]
2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectations fix.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 20 Jan 2011 23:10:14 +0000 (23:10 +0000)]
2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, another attempt at making the chromium gpu tests go green.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 20 Jan 2011 23:05:30 +0000 (23:05 +0000)]
2011-01-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        nrwt: remove fs refs from printing, test_failures, test_expectations, text_diff

        https://bugs.webkit.org/show_bug.cgi?id=52756

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_expectations_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_failures.py:
        * Scripts/webkitpy/layout_tests/test_types/text_diff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 20 Jan 2011 22:53:02 +0000 (22:53 +0000)]
2011-01-20  James Robinson  <jamesr@chromium.org>

        Update expectations for tests that need chromium-side changes.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Mansi Mithal <mansi.mithal@nokia.com>
commit-queue@webkit.org [Thu, 20 Jan 2011 22:50:46 +0000 (22:50 +0000)]
2011-01-20  Mansi Mithal  <mansi.mithal@nokia.com>

        Reviewed by Antonio Gomes.

        QtTestBrowser should have a seperate menu for Settings
        https://bugs.webkit.org/show_bug.cgi?id=52817

        Added a new menu item named "Settings"
        and moved the "Enable interrupting js scripts" and "Enable js pop up windows" under the "Settings" menu

        * QtTestBrowser/launcherwindow.cpp:
        (LauncherWindow::createChrome):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 20 Jan 2011 22:48:40 +0000 (22:48 +0000)]
2011-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Adam Roben.

        Add a timestamp to UpdateInfo
        https://bugs.webkit.org/show_bug.cgi?id=52844

        * Shared/UpdateInfo.cpp:
        (WebKit::UpdateInfo::encode):
        (WebKit::UpdateInfo::decode):
        * Shared/UpdateInfo.h:
        * WebProcess/WebPage/DrawingAreaImpl.cpp:
        (WebKit::DrawingAreaImpl::setSize):
        (WebKit::DrawingAreaImpl::display):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 20 Jan 2011 22:44:35 +0000 (22:44 +0000)]
2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium test expectation update.

        Merged test_expectations.txt in the Chromium tree and
        added slow to fast/text/large-text-composed-char-dos.html.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 20 Jan 2011 22:30:58 +0000 (22:30 +0000)]
2011-01-20  Tony Chang  <tony@chromium.org>

        Unreviewed, updating gpu expectations.
        These two tests were added to the regular chromiumg test_expectations.txt
        in r76228.

        * platform/chromium-gpu/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Thu, 20 Jan 2011 22:12:33 +0000 (22:12 +0000)]
2011-01-20  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed WinCE build fix for r76170.

        * platform/graphics/wince/FontWinCE.cpp: Added a missing include.
        * platform/graphics/wince/ImageBufferData.h: Added a missing include and fixed style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUpdate update-webkit-localizable-strings with new path to WebKit.
weinig@apple.com [Thu, 20 Jan 2011 22:07:18 +0000 (22:07 +0000)]
Update update-webkit-localizable-strings with new path to WebKit.

Reviewed by John Sullivan.

* Scripts/update-webkit-localizable-strings:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 20 Jan 2011 22:04:21 +0000 (22:04 +0000)]
2011-01-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Beth Dakin.

        Add Connection::waitForAndDispatchImmediately
        https://bugs.webkit.org/show_bug.cgi?id=52841

        * Platform/CoreIPC/Connection.h:
        (CoreIPC::Connection::waitForAndDispatchImmediately):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 20 Jan 2011 22:01:46 +0000 (22:01 +0000)]
2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; Another Chromium rebaseline for r76236.

        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.checksum: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 20 Jan 2011 21:50:34 +0000 (21:50 +0000)]
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Implement mozilla's requestAnimationFrame API
        https://bugs.webkit.org/show_bug.cgi?id=51218

        Tests for window.webkitRequestAnimationFrame().  The new tests
        are in the Skipped lists for platforms that do not set
        ENABLE(REQUEST_ANIMATION_FRAME) - which is currently all but chromium.

        * fast/animation/request-animation-frame-cancel-expected.txt: Added.
        * fast/animation/request-animation-frame-cancel.html: Added.
            Tests cancelling a callback within a webkitRequestAnimationFrame() callback.
        * fast/animation/request-animation-frame-cancel2-expected.txt: Added.
        * fast/animation/request-animation-frame-cancel2.html: Added.
            Tests interactions between multiple webkitRequestAnimationFrame() callbacks.
        * fast/animation/request-animation-frame-display-expected.txt: Added.
        * fast/animation/request-animation-frame-display.html: Added.
            Tests changing the display: property of an element within a callback.
        * fast/animation/request-animation-frame-expected.txt: Added.
        * fast/animation/request-animation-frame.html: Added.
            Tests the basic use of window.webkitRequestAnimationFrame().
        * fast/animation/request-animation-frame-within-callback-expected.txt: Added.
        * fast/animation/request-animation-frame-within-callback.html: Added.
            Tests setting one webkit.webkitRequestAnimationFrame() callback within another.
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Implement mozilla's requestAnimationFrame API
        https://bugs.webkit.org/show_bug.cgi?id=51218

        This implements mozilla's proposed requestAnimationFrame API.  The idea with this API is that
        an author driving an animation from script could use window.requestAnimationFrame(callback)
        instead of window.setTimeout(callback, 0) to schedule their update logic and let the browser
        decide when to update the animations.  This avoids doing unnecessary work when the page content
        is offscreen or is being displayed at a different framerate than what the page author expects.

        Mozilla's proposal is here: https://developer.mozilla.org/en/DOM/window.mozRequestAnimationFrame
        This implements window.mozRequestAnimationFrame as window.webkitRequestAnimationFrame with the
        following changes:
        *) Only the callback syntax is supported, there is no before paint event
        *) webkitRequestAnimationFrame supports a second parameter Element to let the author indicate
            what content they intend to animate.  That way if the page is being displayed but the element
            in question is offscreen, we can avoid invoking the callback.
        *) No timestamp is provided to the caller and there is no window.animationStartTime property
            (see https://bugs.webkit.org/show_bug.cgi?id=51952 for discussion of this property)
        *) window.webkitRequestAnimationFrame returns a numerical id that can be used to cancel the callback
            using window.cancelWebkitRequestAnimationFrame, to parallel window.setTimeout()/window.clearTime().

        The implementation depends on the embedder scheduling the callbacks since the callback invocation
        depends on the page's visibility and the embedder's paint scheduling, neither of which are exposed
        to WebCore.  The expectation for the embedder is that at some point Chrome::scheduleAnimation() is
        called FrameView::serviceScriptedAnimations() should be called for the associated Page's main frame.
        Ideally serviceScriptedAnimations() would be called prior to rendering - although in practice the
        embedder has to rate limit callbacks and may not be able to tie the callback directly to the
        rendering loop.

        Tests: fast/animation/request-animation-frame-cancel.html
               fast/animation/request-animation-frame-cancel2.html
               fast/animation/request-animation-frame-display.html
               fast/animation/request-animation-frame-within-callback.html
               fast/animation/request-animation-frame.html

        * WebCore.gypi:
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::webkitRequestAnimationFrame):
        (WebCore::Document::webkitCancelRequestAnimationFrame):
        (WebCore::Document::serviceScriptedAnimations):
        * dom/Document.h:
        * dom/RequestAnimationFrameCallback.h: Added.
        (WebCore::RequestAnimationFrameCallback::~RequestAnimationFrameCallback):
        * dom/RequestAnimationFrameCallback.idl: Added.
        * loader/EmptyClients.h:
        (WebCore::EmptyChromeClient::scheduleAnimation):
        * page/Chrome.cpp:
        (WebCore::Chrome::scheduleAnimation):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::webkitRequestAnimationFrame):
        (WebCore::DOMWindow::webkitCancelRequestAnimationFrame):
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
        * page/FrameView.cpp:
        (WebCore::FrameView::scheduleAnimation):
        (WebCore::FrameView::serviceScriptedAnimations):
        * page/FrameView.h:
        * platform/HostWindow.h:
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Implement mozilla's requestAnimationFrame API
        https://bugs.webkit.org/show_bug.cgi?id=51218

        Chromium WebKit API support for window.webkitRequestAnimationFrame()

        * features.gypi:
        * public/WebWidget.h:
        * public/WebWidgetClient.h:
        (WebKit::WebWidgetClient::scheduleAnimation):
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::scheduleAnimation):
        * src/ChromeClientImpl.h:
        * src/WebPopupMenuImpl.cpp:
        (WebKit::WebPopupMenuImpl::animate):
        (WebKit::WebPopupMenuImpl::scheduleAnimation):
        * src/WebPopupMenuImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::animate):
        * src/WebViewImpl.h:
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Fisher.

        Implement mozilla's requestAnimationFrame API
        https://bugs.webkit.org/show_bug.cgi?id=51218

        Chromium DumpRenderTree support for window.webkitRequestAnimationFrame.

        * DumpRenderTree/chromium/WebViewHost.cpp:
        (invokeScheduleComposite):
        (WebViewHost::scheduleAnimation):
        (WebViewHost::paintInvalidatedRegion):
        * DumpRenderTree/chromium/WebViewHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 20 Jan 2011 21:39:52 +0000 (21:39 +0000)]
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Nate Chapin.

        [v8] CodeGeneratorV8 generates incorrect code for callbacks with no parameters
        https://bugs.webkit.org/show_bug.cgi?id=52837

        When generating code to invoke a callback with no parameters CodeGeneratorV8.pm was generating the following:
        v8::Handle<v8::Value> argv[] = {}; which does not compile in visual studio.  Instead, if the argument count
        is 0, we can just pass a NULL pointer for the argv parameter.

        Test added to bindings/scripts/test/TestCallback.idl and covered by run-bindings-tests.  This
        patch also includes some spurious changes to the bindings tests golden files (mostly GObject)
        because the old golden files were out of date.

        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/scripts/test/CPP/WebDOMTestCallback.cpp:
        (WebDOMTestCallback::callbackWithNoParam):
        * bindings/scripts/test/CPP/WebDOMTestCallback.h:
        * bindings/scripts/test/GObject/WebKitDOMTestCallback.cpp:
        (webkit_dom_test_callback_callback_with_no_param):
        * bindings/scripts/test/GObject/WebKitDOMTestCallback.h:
        * bindings/scripts/test/GObject/WebKitDOMTestInterface.cpp:
        * bindings/scripts/test/GObject/WebKitDOMTestMediaQueryListListener.cpp:
        * bindings/scripts/test/GObject/WebKitDOMTestObj.cpp:
        * bindings/scripts/test/JS/JSTestCallback.cpp:
        (WebCore::JSTestCallback::callbackWithNoParam):
        * bindings/scripts/test/JS/JSTestCallback.h:
        * bindings/scripts/test/JS/JSTestInterface.cpp:
        * bindings/scripts/test/JS/JSTestMediaQueryListListener.cpp:
        * bindings/scripts/test/JS/JSTestObj.cpp:
        * bindings/scripts/test/ObjC/DOMTestCallback.h:
        * bindings/scripts/test/ObjC/DOMTestCallback.mm:
        (-[DOMTestCallback callbackWithNoParam]):
        * bindings/scripts/test/TestCallback.idl:
        * bindings/scripts/test/V8/V8TestCallback.cpp:
        (WebCore::V8TestCallback::callbackWithNoParam):
        * bindings/scripts/test/V8/V8TestCallback.h:
        * bindings/scripts/test/V8/V8TestObj.cpp:
        (WebCore::TestObjInternal::reflectedUnsignedIntegralAttrAttrGetter):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 20 Jan 2011 21:34:34 +0000 (21:34 +0000)]
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        RenderTableSection's setNeedsCellRecalc needs to null check table()
        https://bugs.webkit.org/show_bug.cgi?id=52770

        Tests ::-webkit-scrollbar-corner inside a table.

        * fast/css-generated-content/table-with-scrollbar-corner-expected.txt: Added.
        * fast/css-generated-content/table-with-scrollbar-corner.html: Added.
2011-01-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric "Baller" Seidel.

        RenderTableSection's setNeedsCellRecalc needs to null check table()
        https://bugs.webkit.org/show_bug.cgi?id=52770

        Null checks table() before deferencing it in RenderTableSection::setNeedsCellRecalc.
        This can be null during detach().  Test constructed by Eric Seidel.

        Test: fast/css-generated-content/table-with-scrollbar-corner.html

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::setNeedsCellRecalc):
        * rendering/RenderTableSection.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Michael Saboff <msaboff@apple.com>
msaboff@apple.com [Thu, 20 Jan 2011 21:31:21 +0000 (21:31 +0000)]
2011-01-20  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
        https://bugs.webkit.org/show_bug.cgi?id=52773

        Fixed case where an existing DataLabelPtr is overwritten.  The
        replacing DataLabelPtr is now resolved immediately in
        linkDataLabelToBacktrackIfExists().  Cleanup - eliminated bool
        return value for the routine as it was never used.

        * yarr/YarrJIT.cpp:
        (JSC::Yarr::YarrGenerator::TermGenerationState::linkDataLabelToBacktrackIfExists):
2011-01-20  Michael Saboff  <msaboff@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/8890203> [RegexFuzz] Crash in generated code (52773)
        https://bugs.webkit.org/show_bug.cgi?id=52773

        New test to validate fix.

        * fast/regex/parentheses-expected.txt:
        * fast/regex/script-tests/parentheses.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Thu, 20 Jan 2011 21:26:37 +0000 (21:26 +0000)]
2011-01-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Rob Buis.

        SVG Pattern doesn't take preserveAspectRatio of references Pattern
        https://bugs.webkit.org/show_bug.cgi?id=52802

        SVGPattern didn't take preserveAspectRatio of a referenced SVGPattern into account. Store preserveAspectRatio
        in PatternAttributes as well, if the attribute was set on the referenced SVGPattern element.

        Test: svg/custom/pattern-referencing-preserve-aspect-ratio.svg

        * rendering/svg/RenderSVGResourcePattern.cpp:
        (WebCore::RenderSVGResourcePattern::buildTileImageTransform):
        * svg/PatternAttributes.h:
        (WebCore::PatternAttributes::PatternAttributes):
        (WebCore::PatternAttributes::preserveAspectRatio):
        (WebCore::PatternAttributes::setPreserveAspectRatio):
        (WebCore::PatternAttributes::hasPreserveAspectRatio):
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::collectPatternAttributes):
2011-01-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Rob Buis.

        SVG Pattern doesn't take preserveAspectRatio of references Pattern
        https://bugs.webkit.org/show_bug.cgi?id=52802

        Added a test case to check that we take preserveAspectRatio of a referenced SVGPattern into account.

        * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.checksum: Added.
        * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.png: Added.
        * platform/mac/svg/custom/pattern-referencing-preserve-aspect-ratio-expected.txt: Added.
        * svg/custom/pattern-referencing-preserve-aspect-ratio.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/8765498> REGRESSION (r72141): Cannot order prints with Aperture 3.1
mitz@apple.com [Thu, 20 Jan 2011 20:47:50 +0000 (20:47 +0000)]
<rdar://problem/8765498> REGRESSION (r72141): Cannot order prints with Aperture 3.1

Reviewed by Adele Peterson.

<rdar://problem/8884648> REGRESSION (r72141): Safari hangs when visiting a page on www.bfmtv.com
https://bugs.webkit.org/show_bug.cgi?id=52765

<rdar://problem/8890909> REGRESSION (r72141): Very Slow Rendering With Certain Markup
https://bugs.webkit.org/show_bug.cgi?id=52265

Source/WebCore:

Test: fast/block/line-layout/negative-max-height.html

Integer overflow detection led to a block having a huge height. This manifested as broken layout
in the first bug and as extreme slowness in the latter bugs because of
https://bugs.webkit.org/show_bug.cgi?id=52832

* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection): Clamp maxHeight to 0 so the next line
cannot start above this line. The negative maxHeight also caused the integer overflow detection
logic to give the block a huge height.

LayoutTests:

* fast/block/line-layout: Added.
* fast/block/line-layout/negative-max-height-expected.checksum: Added.
* fast/block/line-layout/negative-max-height-expected.png: Added.
* fast/block/line-layout/negative-max-height-expected.txt: Added.
* fast/block/line-layout/negative-max-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Thu, 20 Jan 2011 20:41:40 +0000 (20:41 +0000)]
2011-01-20  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Eric Carlson.

        Clean up the Media Controls CSS for Qt
        https://bugs.webkit.org/show_bug.cgi?id=52822

        Split the audio::-webkit-media-xxx and video::-webkit-media-xxx rules
        in mediaControlsQt.css, and remove the duplicate audio::-webkit-media-xxx
        rules from mediaControlsQtFullscreen.css.

        * css/mediaControlsQt.css:
        (audio::-webkit-media-controls-panel):
        (video::-webkit-media-controls-panel):
        (audio::-webkit-media-controls-mute-button):
        (video::-webkit-media-controls-mute-button):
        (audio::-webkit-media-controls-play-button):
        (video::-webkit-media-controls-play-button):
        (audio::-webkit-media-controls-timeline-container):
        (video::-webkit-media-controls-timeline-container):
        (audio::-webkit-media-controls-current-time-display):
        (video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-time-remaining-display):
        (video::-webkit-media-controls-time-remaining-display):
        (audio::-webkit-media-controls-timeline):
        (video::-webkit-media-controls-timeline):
        (audio::-webkit-media-controls-volume-slider-container):
        (video::-webkit-media-controls-volume-slider-container):
        (audio::-webkit-media-controls-volume-slider):
        (video::-webkit-media-controls-volume-slider):
        (audio::-webkit-media-controls-seek-back-button):
        (video::-webkit-media-controls-seek-back-button):
        (audio::-webkit-media-controls-seek-forward-button):
        (video::-webkit-media-controls-seek-forward-button):
        (audio::-webkit-media-controls-fullscreen-button):
        (video::-webkit-media-controls-fullscreen-button):
        (audio::-webkit-media-controls-rewind-button):
        (video::-webkit-media-controls-rewind-button):
        (audio::-webkit-media-controls-return-to-realtime-button):
        (video::-webkit-media-controls-return-to-realtime-button):
        (audio::-webkit-media-controls-toggle-closed-captions-button):
        (video::-webkit-media-controls-toggle-closed-captions-button):
        * css/mediaControlsQtFullscreen.css:
        (video::-webkit-media-controls-time-remaining-display):
        (video::-webkit-media-controls-seek-back-button):
        (video::-webkit-media-controls-seek-forward-button):
        (video::-webkit-media-controls-rewind-button):
        (video::-webkit-media-controls-return-to-realtime-button):
        (video::-webkit-media-controls-toggle-closed-captions-button):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 20 Jan 2011 20:32:22 +0000 (20:32 +0000)]
2011-01-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        fix goofup in http://trac.webkit.org/changeset/76082
        https://bugs.webkit.org/show_bug.cgi?id=52830

        We were showing the revision number of the patch at the bottom
        of the diff and expanding from the bottom of the diff would fail.

        Also, removed an unused variable and scoped queries appropriatly
        to the file_diff they should have been operating on.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 20 Jan 2011 20:30:49 +0000 (20:30 +0000)]
2011-01-19  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        [reviewtool] Add a link for annotated trac page on review page
        https://bugs.webkit.org/show_bug.cgi?id=52747

        -add line numbers to all trac links to the first line in the file diff
        -add annotate/review log links
        -make file-diff links other than the file name only show when you mouseover the filediff
        -fix white-space to only wrap the .text element and it's childen, any of it's siblings/parents

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Thu, 20 Jan 2011 20:30:10 +0000 (20:30 +0000)]
2011-01-20  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed Chromium rebaseline for r76236.

        * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Thu, 20 Jan 2011 19:21:40 +0000 (19:21 +0000)]
2011-01-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        make line selection have a extend only from where you start the selection in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=52485

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago Reviewed by Anders Carlsson.
kdecker@apple.com [Thu, 20 Jan 2011 19:07:20 +0000 (19:07 +0000)]
    Reviewed by Anders Carlsson.

        <rdar://problem/8880689> need a way to obtain the rendered rectangle for box elements
        https://bugs.webkit.org/show_bug.cgi?id=52823

        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
        (WKBundleNodeHandleGetRenderRect): Added new method that will return a rendered rectangle for box elements
        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h: Ditto.
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp: Ditto.
        (WebKit::InjectedBundleNodeHandle::renderRect): Ditto.
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 20 Jan 2011 18:31:01 +0000 (18:31 +0000)]
2011-01-20  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [REGRESSION] Canceling of CSS numeric values increment/decrement is broken
        https://bugs.webkit.org/show_bug.cgi?id=52816

        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylePropertyTreeElement.prototype):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Dawit Alemayehu <adawit@kde.org>
commit-queue@webkit.org [Thu, 20 Jan 2011 18:24:11 +0000 (18:24 +0000)]
2011-01-20  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Andreas Kling.

        [Qt] Fix Layering violation in MediaPlayerPrivateQt.
        https://bugs.webkit.org/show_bug.cgi?id=52733

        No new tests. no behavioral change.

       * platform/graphics/qt/MediaPlayerPrivateQt.cpp:
        (WebCore::MediaPlayerPrivateQt::commitLoad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 20 Jan 2011 18:20:12 +0000 (18:20 +0000)]
2011-01-20  Nate Chapin  <japhet@chromium.org>

        Reviewed by Darin Fisher.

        [V8] Call malloc and memcpy directly instead of
        of strdup in convertV8ObjectToNPVariant() when
        converting strings. If there is a null character
        in the string, our use of strdup causes us to allocate
        too little memory, leading to out of bounds reads.

        https://bugs.webkit.org/show_bug.cgi?id=52631

        * bindings/v8/V8NPUtils.cpp:
        (WebCore::convertV8ObjectToNPVariant):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Andras Becsi <abecsi@webkit.org>
abecsi@webkit.org [Thu, 20 Jan 2011 18:13:55 +0000 (18:13 +0000)]
2011-01-20  Andras Becsi  <abecsi@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt][WK2] WebKit2 enabled build fails to link

        Work around undefined reference linking issues until the buildsystem gets redesigned.
        These issues first occured in minimal builds (see BUG 50519).

        * JavaScriptCore.pri: link as whole-archive for WebKit2 builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
commit-queue@webkit.org [Thu, 20 Jan 2011 18:08:49 +0000 (18:08 +0000)]
2011-01-20  Kimmo Kinnunen  <kimmo.t.kinnunen@nokia.com>

        Reviewed by Andreas Kling.

        Remove null ptr deref that happens when reattaching to
        a new web process.

        Implement didRelaunchProcess that sets the drawing area size
        after the drawing area is re-instantiated.

        [Qt][WK2] Null ptr deref in UI process after web process has crashed
        https://bugs.webkit.org/show_bug.cgi?id=52796

        * UIProcess/API/qt/qgraphicswkview.cpp:
        (QGraphicsWKView::QGraphicsWKView):
        * UIProcess/API/qt/qwkpage.cpp:
        (QWKPagePrivate::QWKPagePrivate):
        (QWKPagePrivate::init):
        (QWKPagePrivate::createDrawingAreaProxy):
        (QWKPagePrivate::didRelaunchProcess): Reset drawing area size after crash.
        * UIProcess/API/qt/qwkpage_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 20 Jan 2011 18:07:12 +0000 (18:07 +0000)]
2011-01-20  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, remove GTK result for window-onerror2 as it's the same
        as the generic results file.

        * platform/gtk/fast/events/window-onerror2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 20 Jan 2011 17:49:10 +0000 (17:49 +0000)]
2011-01-20  Andreas Kling  <kling@webkit.org>

        Reviewed by Ariya Hidayat.

        [Qt] Fill shadow scratch buffer with proper transparent pixels

        QImage::fill() has no Qt::GlobalColor overload in Qt 4.7 (coming in 4.8)
        so doing QImage::fill(Qt::transparent) will actually fill all pixels with
        the RGBA value 0x00000013.

        * platform/graphics/qt/ContextShadowQt.cpp:
        (WebCore::ShadowBuffer::scratchImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 20 Jan 2011 17:15:50 +0000 (17:15 +0000)]
2011-01-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
        https://bugs.webkit.org/show_bug.cgi?id=42327

        * platform/mac-wk2/Skipped: Unskip the tests that needed this.
2011-01-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
        https://bugs.webkit.org/show_bug.cgi?id=42327

        Added a new API call, WKBundleFrameForJavaScriptContext, that gets the WKBundleFrameRef
        that corresponds to a JSContextRef (or null if none).

        * WebProcess/InjectedBundle/API/c/WKBundleFrame.cpp:
        (WKBundleFrameForJavaScriptContext): Simple wrapper, defers to a WebFrame
        static method.
        * WebProcess/InjectedBundle/API/c/WKBundleFrame.h:
        * WebProcess/WebPage/WebFrame.cpp:
        (WebKit::WebFrame::frameForContext): Follow the maze of twisty pointers.
        * WebProcess/WebPage/WebFrame.h:
2011-01-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Adam Roben.

        WebKitTestRunner needs to support layoutTestController.evaluateScriptInIsolatedWorld
        https://bugs.webkit.org/show_bug.cgi?id=42327

        * WebKitTestRunner/InjectedBundle/Bindings/CodeGeneratorTestRunner.pm: Add support
        for methods that take their normal arguments but also a JSContextRef.
        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl: IDL definition
        for evaluateScriptInIsolatedWorld.
        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::didClearWindowForFrame): Set a magic variable only if
        this call is for an isolated world.
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::worldMap): Helper to create a world map.
        (WTR::LayoutTestController::worldIDForWorld): Map from an ID to a world.
        (WTR::LayoutTestController::evaluateScriptInIsolatedWorld): The newly
        added LayoutTestController API.
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove WKCACFContextFlusher
aroben@apple.com [Thu, 20 Jan 2011 17:12:56 +0000 (17:12 +0000)]
Remove WKCACFContextFlusher

It wasn't doing anything.

Fixes <http://webkit.org/b/52752> WKCACFContextFlusher is unused

Reviewed by Simon Fraser.

* WebCore.vcproj/WebCore.vcproj: Removed WKCACFContextFlusher. Also let VS have its way with
the file.

* platform/graphics/win/WKCACFContextFlusher.cpp: Removed.
* platform/graphics/win/WKCACFContextFlusher.h: Removed.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::~WKCACFLayerRenderer):
(WebCore::WKCACFLayerRenderer::layerTreeDidChange):
Stop telling WKCACFContextFlusher about our context, since it never did anything with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOnly flush our own context when we get resized
aroben@apple.com [Thu, 20 Jan 2011 17:12:24 +0000 (17:12 +0000)]
Only flush our own context when we get resized

Fixes <http://webkit.org/b/52751> All WKCACFContexts with uncommitted
changes get flushed whenever any composited page is resized

Reviewed by Simon Fraser.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::resize): Just flush our own context, not all contexts
WKCACFContextFlusher knows about. After all, ours is the only one that just got resized!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake WKCACFLayerRenderer ref-counted
aroben@apple.com [Thu, 20 Jan 2011 17:11:55 +0000 (17:11 +0000)]
Make WKCACFLayerRenderer ref-counted

This will be needed to handle cases where the client might release its reference to us while
we're calling out to it.

WKCACFLayerRenderer now has a setClient function, which is used rather than passing the
client to create(). This allows clients to null out the client pointer when they're done
with the renderer.

Fixes <http://webkit.org/b/52749> WKCACFLayerRenderer should be
ref-counted

Reviewed by Simon Fraser.

Source/WebCore:

* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.cpp:
(WebCore::MediaPlayerPrivateFullscreenWindow::MediaPlayerPrivateFullscreenWindow):
* platform/graphics/win/MediaPlayerPrivateFullscreenWindow.h:
Updated for WKCACFLayerRenderer changes.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable): Updated for changes to
create().
(WebCore::WKCACFLayerRenderer::create): No longer takes a WKCACFLayerRendererClient. Now
returns a PassOwnPtr.
(WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer): No longer takes a
WKCACFLayerRendererClient.

* platform/graphics/win/WKCACFLayerRenderer.h: Made WKCACFLayerRenderer inherit from
RefCounted.
(WebCore::WKCACFLayerRenderer::setClient): Added this simple setter.

Source/WebKit/win:

Update for WKCACFLayerRenderer changes

* WebView.cpp:
(WebView::~WebView): Added some assertions to make sure we've gotten rid of our
compositing-related members. My biggest concern was making sure that m_layerRenderer was
gone, which would also mean we had nulled out its client pointer.
(WebView::setAcceleratedCompositing): Changed to call WKCACFLayerRenderer::setClient instead
of passing the client into create(), and to clear out the client before nulling out
m_layerRenderer.

* WebView.h: Changed m_layerRenderer from an OwnPtr to a RefPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoConvert paths in environment variables back to msys-style inside commit-log-editor
aroben@apple.com [Thu, 20 Jan 2011 17:11:18 +0000 (17:11 +0000)]
Convert paths in environment variables back to msys-style inside commit-log-editor

When this script gets run from inside git commit, msys-style paths in the environment will
have been turned into Windows-style paths with forward slashes. This screws up functions
like File::Spec->rel2abs, which seem to rely on $PWD having an msys-style path. We convert
the paths back to msys-style before doing anything else.

Fixes <http://webkit.org/b/48527> commit-log-editor uses full paths for section headers when
using msysgit's Perl and multiple ChangeLogs have been edited

Reviewed by David Kilzer.

* Scripts/commit-log-editor: Call fixEnvironment before doing anything else.
(fixEnvironment): Added. When run in msys in conjunction with git (i.e., when invoked from
inside git commit), convert Windows-style paths in the environment back to msys-style paths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTeach WebView::scrollBackingStore about compositing mode
aroben@apple.com [Thu, 20 Jan 2011 17:10:34 +0000 (17:10 +0000)]
Teach WebView::scrollBackingStore about compositing mode

Test:
    compositing/scroll-painted-composited-content.html

Fixes <http://webkit.org/b/52720> REGRESSION (r75987): Assertion failure in
WebView::scrollBackingStore when scrolling page with composited content

Reviewed by Anders Carlsson.

Source/WebKit/win:

* WebView.cpp:
(WebView::scrollBackingStore): Do something sensible (though naive) when in compositing
mode, rather than incorrectly asserting that this function is never called in that case. For
now we just repaint the entire scrolled region; someday hopefully we can avoid having to
repaint the areas that have just been moved.

LayoutTests:

Add a test that scrolls composited content that has already been painted

* compositing/scroll-painted-composited-content.html: Added.
* compositing/scroll-painted-composited-content-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Win] Unreviewed build fix after r76248.
zoltan@webkit.org [Thu, 20 Jan 2011 17:08:35 +0000 (17:08 +0000)]
[Win] Unreviewed build fix after r76248.

* DumpRenderTree/ForwardingHeaders/wtf/FastAllocBase.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 20 Jan 2011 16:55:35 +0000 (16:55 +0000)]
2011-01-20  Alejandro G. Castro  <alex@igalia.com>

        Fix compilation error in GTK WebKit2.

        * Platform/CoreIPC/gtk/ConnectionGtk.cpp:
        (CoreIPC::readBytesFromSocket):
        (CoreIPC::writeBytesToSocket):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][V8] Unreviewed buildfix after r76248.
ossy@webkit.org [Thu, 20 Jan 2011 16:54:13 +0000 (16:54 +0000)]
[Qt][V8] Unreviewed buildfix after r76248.

* bindings/v8/ScriptCachedFrameData.h: Add missing include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 20 Jan 2011 16:53:05 +0000 (16:53 +0000)]
2011-01-20  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Andreas Kling.

        [GTK] Fix typo in the webkit2 section of the configure.ac file
        https://bugs.webkit.org/show_bug.cgi?id=52801

        Fixed typo in the GTK WebKit2 compilation.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 20 Jan 2011 16:49:11 +0000 (16:49 +0000)]
2011-01-20  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: enable resource agent upon request.
        https://bugs.webkit.org/show_bug.cgi?id=52815

        We should not send network-related notifications unless front-end
        is interested.

        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreInspectorStateFromCookie):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::resourceAgent):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::consoleAgent):
        (WebCore::InspectorController::cssAgent):
        (WebCore::InspectorController::domAgent):
        (WebCore::InspectorController::injectedScriptAgent):
        (WebCore::InspectorController::runtimeAgent):
        (WebCore::InspectorController::databaseAgent):
        (WebCore::InspectorController::domStorageAgent):
        (WebCore::InspectorController::fileSystemAgent):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::retrieveResourceAgent):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::restore):
        (WebCore::InspectorResourceAgent::~InspectorResourceAgent):
        (WebCore::InspectorResourceAgent::InspectorResourceAgent):
        * inspector/InspectorResourceAgent.h:
        (WebCore::InspectorResourceAgent::create):
        * inspector/InspectorState.cpp:
        (WebCore::InspectorState::InspectorState):
        * inspector/InspectorState.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRefactoring of the custom allocation framework
ossy@webkit.org [Thu, 20 Jan 2011 16:30:54 +0000 (16:30 +0000)]
Refactoring of the custom allocation framework
https://bugs.webkit.org/show_bug.cgi?id=49897

Patch by Zoltan Horvath <zoltan@webkit.org> on 2011-01-20
Reviewed by Csaba Osztrogon√°c.

Source/JavaScriptCore:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

* wtf/FastAllocBase.h: Turn FastAllocBase's implementation into a macro.

Source/WebCore:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

Source/WebKit:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

Source/WebKit2:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

Tools:

Inheriting from FastAllocBase can result in objects getting larger (bug #33896, #46589).
The modification replaces Noncopyable and FastAllocBase classes and these inherits with their
equivalent macro implementation at the necessary places.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Thu, 20 Jan 2011 16:21:35 +0000 (16:21 +0000)]
2011-01-20  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: [Chromium] CPU Profiles are cleared when navigating back and forth.

        Profiles are now not cleared unless renderer instance was changed.

        https://bugs.webkit.org/show_bug.cgi?id=52807

        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::restoreProfiler):
        * inspector/InspectorProfilerAgent.cpp:
        (WebCore::InspectorProfilerAgent::resetState):
        (WebCore::InspectorProfilerAgent::resetFrontendProfiles):
        * inspector/InspectorProfilerAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 20 Jan 2011 15:59:51 +0000 (15:59 +0000)]
2011-01-20  Alexander Pavlov  <apavlov@chromium.org>

        Unreviewed, add new JS file refs missing from r76116.

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Thu, 20 Jan 2011 15:46:28 +0000 (15:46 +0000)]
2011-01-20  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Crash when adding a rule for an ImageDocument
        https://bugs.webkit.org/show_bug.cgi?id=52811

        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::addRule2):
        (WebCore::InspectorCSSAgent::viaInspectorStyleSheet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 20 Jan 2011 15:38:09 +0000 (15:38 +0000)]
2011-01-20  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Make fast/events/window-onerror2.html throw exception in deterministic order
        https://bugs.webkit.org/show_bug.cgi?id=52813

        * fast/events/window-onerror2-expected.txt:
        * fast/events/window-onerror2.html: call setTimeout from onload handler to make sure exception
        in the onload handler will be processed before the one in the setTimeout callback
        * platform/chromium/fast/events/window-onerror2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Yi Shen <yi.4.shen@nokia.com>
yi.4.shen@nokia.com [Thu, 20 Jan 2011 15:32:29 +0000 (15:32 +0000)]
2011-01-20  Yi Shen  <yi.4.shen@nokia.com>

        Unreviewed.

        Adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 20 Jan 2011 15:00:21 +0000 (15:00 +0000)]
2011-01-20  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, new GTK svg test baselines as follow-up of r76236.

        * platform/gtk/svg/W3C-SVG-1.1-SE/pservers-pattern-04-f-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 20 Jan 2011 14:52:31 +0000 (14:52 +0000)]
2011-01-20  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, update window-onerror2.html baselines as follow-up of r76216.

        * platform/gtk/fast/events/window-onerror2-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Thu, 20 Jan 2011 14:50:36 +0000 (14:50 +0000)]
2011-01-20  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: cleanup InspectorController's friends list.
        We have a plan to extract InspectorAgent from InspectorController.
        InspectorAgent will be accessible only from InspectorController.
        As result we can simply made some methods public and remove long
        friends list.

        https://bugs.webkit.org/show_bug.cgi?id=52806

        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::databaseForId):
        (WebCore::InjectedScriptHost::selectDatabase):
        (WebCore::InjectedScriptHost::selectDOMStorage):
        (WebCore::InjectedScriptHost::inspectorDOMAgent):
        (WebCore::InjectedScriptHost::frontend):
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::setDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::removeDOMBreakpoint):
        (WebCore::InspectorBrowserDebuggerAgent::willInsertDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willRemoveDOMNode):
        (WebCore::InspectorBrowserDebuggerAgent::willModifyDOMAttr):
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        (WebCore::InspectorBrowserDebuggerAgent::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorBrowserDebuggerAgent::willSendXMLHttpRequest):
        * inspector/InspectorController.h:
        (WebCore::InspectorController::frontend):
        * inspector/InspectorInstrumentation.cpp:
        (WebCore::InspectorInstrumentation::willInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didInsertDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::didRemoveDOMNodeImpl):
        (WebCore::InspectorInstrumentation::willModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::didModifyDOMAttrImpl):
        (WebCore::InspectorInstrumentation::characterDataModifiedImpl):
        (WebCore::InspectorInstrumentation::willSendXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::didReceiveResourceResponseImpl):
        (WebCore::InspectorInstrumentation::didFailLoadingImpl):
        (WebCore::InspectorInstrumentation::resourceRetrievedByXMLHttpRequestImpl):
        (WebCore::InspectorInstrumentation::addStartProfilingMessageToConsoleImpl):
        (WebCore::InspectorInstrumentation::pauseOnNativeEventIfNeeded):
        (WebCore::InspectorInstrumentation::cancelPauseOnNativeEvent):
        (WebCore::InspectorInstrumentation::retrieveTimelineAgent):
        (WebCore::InspectorInstrumentation::retrieveResourceAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-19 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Thu, 20 Jan 2011 14:47:00 +0000 (14:47 +0000)]
2011-01-19  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: implement JavaScriptBreakpointsSidebarPane based on events from debugger model.
        https://bugs.webkit.org/show_bug.cgi?id=52723

        Extract all breakpoints-related presentation code from debugger model to JavaScriptBreakpointSidebarPane.

        * inspector/front-end/Breakpoint.js:
        (WebInspector.Breakpoint):
        (WebInspector.Breakpoint.prototype.get data):
        (WebInspector.Breakpoint.prototype.remove):
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.JavaScriptBreakpointsSidebarPane):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointAdded):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointRemoved):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointEnableChanged):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointItemCheckboxClicked):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._contextMenuEventFired):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerResumed):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._addListElement):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeListElement):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._projectChanged):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compare):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._compareBreakpoints):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement.didGetSourceLine):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setupBreakpointElement):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._breakpointIdForDebuggerPausedEvent):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._setBreakpointEnabled):
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._removeBreakpoint):
        (WebInspector.NativeBreakpointsSidebarPane):
        (WebInspector.XHRBreakpointsSidebarPane.prototype.addBreakpointItem):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.removeBreakpoint):
        (WebInspector.DebuggerModel.prototype.breakpointForId):
        (WebInspector.DebuggerModel.prototype._pausedScript):
        (WebInspector.DebuggerModel.prototype._resumedScript):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-20 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 20 Jan 2011 14:28:14 +0000 (14:28 +0000)]
2011-01-20  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, new GTK baselines for 2 new tests.

        * platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt: Added.
        * platform/gtk/svg/css/text-gradient-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76238 268f45cc-cd09-0410-ab3c-d52691b4dbfc