andreas.kling@nokia.com [Tue, 25 Jan 2011 12:43:02 +0000 (12:43 +0000)]
2011-01-25 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt][WK2] Add QWKPage::processCrashed() signal
https://bugs.webkit.org/show_bug.cgi?id=53076
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::processDidCrash):
* UIProcess/API/qt/qwkpage.h:
* UIProcess/API/qt/qwkpage_p.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76585
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kov@webkit.org [Tue, 25 Jan 2011 11:43:11 +0000 (11:43 +0000)]
2011-01-25 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
Reviewed by Andreas Kling.
[GTK] Remove 64 bits release bot from the buildbot master
https://bugs.webkit.org/show_bug.cgi?id=52899
Removes the 64 bits release slave from the buildbot configuration,
so that we can use it as an EWS.
* BuildSlaveSupport/build.webkit.org-config/config.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76584
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 25 Jan 2011 11:38:27 +0000 (11:38 +0000)]
2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
editing/selection/extend-selection-bidi.html test is flaky
https://bugs.webkit.org/show_bug.cgi?id=53074
* platform/gtk/Skipped: Skipped test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76583
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mario@webkit.org [Tue, 25 Jan 2011 11:09:46 +0000 (11:09 +0000)]
2011-01-25 Mario Sanchez Prada <msanchez@igalia.com>
Unreviewed, skipping flaky test on GTK debug bots.
fast/spatial-navigation/snav-unit-overflow-and-scroll-in-direction.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=53073
* platform/gtk/Skipped: Skipped test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76582
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 25 Jan 2011 09:44:30 +0000 (09:44 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: debugger and browser debugger agents should manage sticky breakpoints independently.
https://bugs.webkit.org/show_bug.cgi?id=52999
* inspector/Inspector.idl:
* inspector/InspectorAgent.cpp:
(WebCore::InspectorAgent::didCommitLoad):
(WebCore::InspectorAgent::enableDebugger):
(WebCore::InspectorAgent::inspectedURLWithoutFragment):
* inspector/InspectorAgent.h:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::setAllBrowserBreakpoints):
(WebCore::InspectorBrowserDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
* inspector/InspectorBrowserDebuggerAgent.h:
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::InspectorDebuggerAgent):
(WebCore::InspectorDebuggerAgent::setAllJavaScriptBreakpoints):
(WebCore::InspectorDebuggerAgent::inspectedURLChanged):
(WebCore::InspectorDebuggerAgent::restoreBreakpoints):
* inspector/InspectorDebuggerAgent.h:
* inspector/InspectorState.cpp:
(WebCore::InspectorState::InspectorState):
* inspector/InspectorState.h:
* inspector/front-end/BreakpointManager.js:
(WebInspector.BreakpointManager):
(WebInspector.BreakpointManager.prototype._projectChanged):
(WebInspector.BreakpointManager.prototype._saveBreakpoints):
(WebInspector.BreakpointManager.prototype._pushBreakpointsToBackend):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76581
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 25 Jan 2011 09:19:00 +0000 (09:19 +0000)]
2011-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Nikolas Zimmermann.
Skip some new tests for WebKit2 that use eventSender
https://bugs.webkit.org/show_bug.cgi?id=53068
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76580
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Tue, 25 Jan 2011 09:15:14 +0000 (09:15 +0000)]
2011-01-25 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, trivial debugger test fix.
* src/js/Tests.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76579
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 25 Jan 2011 08:43:48 +0000 (08:43 +0000)]
2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Crash in some pages containing flash
https://bugs.webkit.org/show_bug.cgi?id=53016
Flash plugin can produce X errors that are handled by the GDK X
error handler, which exits the process. Since we don't want to
crash due to flash bugs, we install a custom error handler to show
a warning when a X error happens without aborting.
* plugins/gtk/PluginPackageGtk.cpp:
(WebCore::webkitgtkXError):
(WebCore::PluginPackage::load):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76578
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
carlosgc@webkit.org [Tue, 25 Jan 2011 08:33:59 +0000 (08:33 +0000)]
2011-01-25 Carlos Garcia Campos <cgarcia@igalia.com>
Reviewed by Martin Robinson.
[GTK] Implement spin buttons in RenderThemeGtk
https://bugs.webkit.org/show_bug.cgi?id=51454
Paint inner up/down buttons for spin button elements when building
with GTK+ 3.x.
Test results will land with the GTK+ 2.x version of this patch.
* platform/gtk/RenderThemeGtk.h:
* platform/gtk/RenderThemeGtk2.cpp:
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
* platform/gtk/RenderThemeGtk3.cpp:
(WebCore::spinButtonArrowSize):
(WebCore::RenderThemeGtk::adjustInnerSpinButtonStyle):
(WebCore::paintSpinArrowButton):
(WebCore::RenderThemeGtk::paintInnerSpinButton):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76577
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 25 Jan 2011 06:44:20 +0000 (06:44 +0000)]
2011-01-24 Mihai Parparita <mihaip@chromium.org>
Unreviewed. Missed move of one m_deleted use to be outside NDEBUG block
in r76575.
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76576
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mihaip@chromium.org [Tue, 25 Jan 2011 06:17:25 +0000 (06:17 +0000)]
2011-01-24 Mihai Parparita <mihaip@chromium.org>
Reviewed by Tony Chang.
Add runtime checks for invariants in memory cache
https://bugs.webkit.org/show_bug.cgi?id=53059
To help track down bug 53045, add some CRASH calls in addition to
ASSERTs, so that we can track down failures in reliability bots.
Just some checks, no new tests necessary.
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::cachedImage):
* loader/cache/CachedResource.h:
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::~CachedResource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76575
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 25 Jan 2011 06:15:01 +0000 (06:15 +0000)]
2011-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Dan Bernstein.
Implement database quota callback to fix storage tests on WebKit2 bot
https://bugs.webkit.org/show_bug.cgi?id=53064
* WebKitTestRunner/TestController.cpp:
(WTR::exceededDatabaseQuota):
(WTR::TestController::createOtherPage):
(WTR::TestController::initialize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76574
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 25 Jan 2011 06:09:06 +0000 (06:09 +0000)]
2011-01-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Dan Bernstein.
Leaking CSSRuleDataList objects
https://bugs.webkit.org/show_bug.cgi?id=53062
Fix leaked CSSRuleDataLists added to the m_pseudoRules hash.
* css/CSSStyleSelector.cpp:
(WebCore::CSSRuleSet::~CSSRuleSet):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76573
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 25 Jan 2011 06:05:54 +0000 (06:05 +0000)]
2011-01-24 Kent Tamura <tkent@chromium.org>
Unreviewed, test expectation update.
Chromium-Linux rebaseline for r76567.
* platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.checksum:
* platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.png:
* platform/chromium-linux/fast/forms/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.checksum:
* platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-linux/fast/speech/input-appearance-numberandspeech-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76572
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 25 Jan 2011 05:52:29 +0000 (05:52 +0000)]
2011-01-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Eric Seidel.
Refcount Images used in rendering code
https://bugs.webkit.org/show_bug.cgi?id=52701
Change StyleImage::image(RenderObject*, const IntSize&) and
CSSImageGeneratorValue::image(RenderObject*, const IntSize&) to
return PassRefPtr<Image>, and adjust other code accordingly.
This allows us to return one-time images, for example for CSS gradients
whose appearance may change depending on factors other than the renderer
and the destination size.
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::image):
* css/CSSCanvasValue.h:
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::image):
* css/CSSGradientValue.h:
* css/CSSImageGeneratorValue.h:
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::paintFillLayerExtended):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
* rendering/RenderImage.cpp:
(WebCore::RenderImage::paintReplaced):
(WebCore::RenderImage::paintIntoRect):
* rendering/RenderImageResource.h:
(WebCore::RenderImageResource::image):
* rendering/RenderImageResourceStyleImage.h:
(WebCore::RenderImageResourceStyleImage::image):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::paint):
* rendering/style/StyleCachedImage.cpp:
(WebCore::StyleCachedImage::image):
* rendering/style/StyleCachedImage.h:
* rendering/style/StyleGeneratedImage.cpp:
(WebCore::StyleGeneratedImage::image):
* rendering/style/StyleGeneratedImage.h:
* rendering/style/StyleImage.h:
* rendering/style/StylePendingImage.h:
(WebCore::StylePendingImage::image):
* rendering/svg/RenderSVGImage.cpp:
(WebCore::RenderSVGImage::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76571
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 25 Jan 2011 05:38:06 +0000 (05:38 +0000)]
2011-01-24 Martin Robinson <mrobinson@igalia.com>
Skip a slightly different set of tests after r76555. Seems that some of these
failures are cascading.
* platform/gtk/Skipped: Update the skipped list.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76570
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Tue, 25 Jan 2011 05:17:09 +0000 (05:17 +0000)]
2011-01-24 Tony Chang <tony@chromium.org>
Unreviewed, reverting 5 changes of baselines that are incorrect for Linux.
Mark win tests as failing for now.
* platform/chromium-linux/fast/css/acid2-expected.txt: Removed.
* platform/chromium-linux/fast/css/acid2-pixel-expected.checksum:
* platform/chromium-linux/fast/css/acid2-pixel-expected.png:
* platform/chromium-linux/fast/css/acid2-pixel-expected.txt: Removed.
* platform/chromium-linux/fast/forms/button-sizes-expected.checksum:
* platform/chromium-linux/fast/forms/button-sizes-expected.png:
* platform/chromium-linux/fast/forms/button-sizes-expected.txt:
* platform/chromium-linux/fast/forms/input-button-sizes-expected.checksum:
* platform/chromium-linux/fast/forms/input-button-sizes-expected.png:
* platform/chromium-linux/fast/forms/input-button-sizes-expected.txt:
* platform/chromium-linux/http/tests/misc/acid2-expected.txt: Removed.
* platform/chromium-linux/http/tests/misc/acid2-pixel-expected.checksum:
* platform/chromium-linux/http/tests/misc/acid2-pixel-expected.png:
* platform/chromium-linux/http/tests/misc/acid2-pixel-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/interact-zoom-01-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Removed.
* platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Removed.
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Removed.
* platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
* platform/chromium-linux/svg/hixie/perf/003-expected.txt: Added.
* platform/chromium-linux/svg/hixie/perf/004-expected.txt: Added.
* platform/chromium-linux/svg/hixie/perf/005-expected.txt: Added.
* platform/chromium-linux/svg/hixie/perf/006-expected.txt: Added.
* platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/001-expected.txt: Added.
* platform/chromium-linux/svg/hixie/viewbox/preserveAspectRatio/002-expected.txt: Added.
* platform/chromium-linux/svg/text/text-hkern-expected.txt: Removed.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Removed.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Removed.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
* platform/chromium-linux/svg/text/text-text-01-b-expected.checksum:
* platform/chromium-linux/svg/text/text-text-01-b-expected.png:
* platform/chromium-linux/svg/text/text-text-01-b-expected.txt:
* platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Removed.
* platform/chromium-linux/svg/text/text-vkern-expected.checksum: Removed.
* platform/chromium-linux/svg/text/text-vkern-expected.txt: Removed.
* platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Removed.
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-04-t-expected.txt:
* platform/chromium-win/svg/batik/text/xmlSpace-expected.txt:
* platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Removed.
* platform/chromium-win/svg/text/text-hkern-expected.txt: Removed.
* platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
* platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
* platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Removed.
* platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
* platform/chromium-win/svg/text/text-text-04-t-expected.png:
* platform/chromium-win/svg/text/text-text-04-t-expected.txt:
* platform/chromium-win/svg/text/text-vkern-expected.checksum:
* platform/chromium-win/svg/text/text-vkern-expected.png:
* platform/chromium-win/svg/text/text-vkern-expected.txt: Removed.
* platform/chromium-win/svg/text/text-vkern-on-horizontal-text-expected.txt: Removed.
* platform/chromium/test_expectations.txt:
2011-01-24 Tony Chang <tony@chromium.org>
Unreviewed, round ascent and descent to match old code.
* platform/graphics/chromium/SimpleFontDataLinux.cpp:
(WebCore::SimpleFontData::platformInit):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76569
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
simon.fraser@apple.com [Tue, 25 Jan 2011 05:15:56 +0000 (05:15 +0000)]
2011-01-24 Simon Fraser <simon.fraser@apple.com>
Reviewed by Chris Marrin.
perspective() transform function should take lengths
https://bugs.webkit.org/show_bug.cgi?id=52683
The argument to the perspective() transform function should
be a Length, rather than a bare number. Bare numbers are still
accepted (and treated as px), but this behavior is deprecated.
Test: animations/3d/transform-perspective.html
transforms/3d/general/3dtransform-values.html
* css/CSSParser.cpp:
(WebCore::CSSParser::parseTransform): Check the units for the perspective()
function. Allow bare numbers for backwards compatibility.
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::createTransformOperations): Convert
value to Length.
* platform/graphics/transforms/PerspectiveTransformOperation.cpp:
(WebCore::clampToPostiveInteger): Helper.
(WebCore::PerspectiveTransformOperation::blend): Blend via Lengths.
* platform/graphics/transforms/PerspectiveTransformOperation.h:
(WebCore::PerspectiveTransformOperation::create): double -> Length.
(WebCore::PerspectiveTransformOperation::perspective): Ditto.
(WebCore::PerspectiveTransformOperation::isIdentity): Ditto.
(WebCore::PerspectiveTransformOperation::apply): Ditto.
(WebCore::PerspectiveTransformOperation::PerspectiveTransformOperation): Assert
that the Length is a fixed type.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76568
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 25 Jan 2011 04:38:29 +0000 (04:38 +0000)]
2011-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Windows] Textfield <input>s have different widths.
https://bugs.webkit.org/show_bug.cgi?id=48405
* fast/forms/input-widths-expected.txt: Added.
* fast/forms/input-widths.html: Added.
2011-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
[Windows] Textfield <input>s have different widths.
https://bugs.webkit.org/show_bug.cgi?id=48405
- Apply the padding override for type=text to other textfield types too.
- Reset margin value of outer spin button, which is not used in Windows.
- Don't add inner spin button width to the preferred text field width.
Text fields should have the identical widths regardless of the
existence of spin buttons.
Test: fast/forms/input-widths.html
* css/themeWin.css:
(input[type="week"]):
(input[type="week"]:disabled):
(input[type="search"]::-webkit-search-cancel-button):
(input::-webkit-outer-spin-button):
* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::preferredContentWidth):
Don't add inner spin button width to the preferred width.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76567
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Tue, 25 Jan 2011 04:36:26 +0000 (04:36 +0000)]
2011-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Some bugs of search cancel button and spin button about state change in
an event handler.
https://bugs.webkit.org/show_bug.cgi?id=46950
* fast/forms/input-number-change-type-on-focus-expected.txt: Added.
* fast/forms/input-number-change-type-on-focus.html: Added.
* fast/forms/search-hide-cancel-on-cancel-expected.txt: Added.
* fast/forms/search-hide-cancel-on-cancel.html: Added.
2011-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Dimitri Glazkov.
Some bugs of search cancel button and spin button about state change in
an event handler.
https://bugs.webkit.org/show_bug.cgi?id=46950
Fix the following problems:
* Type=search field didn't release event capturing
* Assertion failure when an input field with spin buttons was changed
to another type on focus event.
* A input field with spin button didn't release event capturing when it
was changed to another type on focus event.
Tests: fast/forms/input-number-change-type-on-focus.html
fast/forms/search-hide-cancel-on-cancel.html
* rendering/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler):
- Make the variable 'input' RefPtr. It makes the code simpler.
- Remove visibility check on mouseup event. We should release capturing
anyway because the cancel button may be invisible if JavaScript code
called by the focus event removes the input value.
(WebCore::SpinButtonElement::detach):
- Release capturing on detach because it is possible that a spin button
node is detached while it is capturing events.
(WebCore::SpinButtonElement::defaultEventHandler):
Take a reference to this and check renderer() after some functions which
may run JavaScript code.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
Make the variable 'input' RefPtr to align other functions in this file.
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.
* rendering/TextControlInnerElements.h: Declare SpinButtonElement::detach().
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76566
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 25 Jan 2011 03:27:14 +0000 (03:27 +0000)]
2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
https://bugs.webkit.org/show_bug.cgi?id=52781
The test was rebaselined to have interleaved space and non-breaking space.
* editing/inserting/insert-composition-whitespace-expected.txt:
* editing/inserting/insert-composition-whitespace.html:
2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Ojan Vafai.
Inserting multiple whitespace using text composition (IME) should insert interleaved nbsp and whitespace.
https://bugs.webkit.org/show_bug.cgi?id=52781
The bug was caused by stringWithRebalancedWhitespace's replacing the space at the beginning of a paragraph
and the end of a paragraph by a non-breaking space after it replaced two consecutive spaces by a space and
non-breaking space pattern, thereby replacing more spaces by non-breaking spaces than needed.
Rewrote the function using Vector<UChar> to fix the bug. New function no longer calls String::replace
multiple times but instead it traverses through the string and replaces a space that immediately follows
another space or appears at the beginning of a paragraph or at the end of a paragraph by a non-break space.
* editing/CompositeEditCommand.cpp:
* editing/htmlediting.cpp:
(WebCore::stringWithRebalancedWhitespace): Written.
* editing/htmlediting.h:
(WebCore::isWhitespace): Removed from CompositeEditCommand.cpp
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76565
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 25 Jan 2011 02:56:50 +0000 (02:56 +0000)]
2011-01-24 Martin Robinson <mrobinson@igalia.com>
Skip one more crashing test.
* platform/gtk/Skipped: Skip a test.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76564
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Jan 2011 02:48:51 +0000 (02:48 +0000)]
Fix build.
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76563
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbr@google.com [Tue, 25 Jan 2011 02:39:50 +0000 (02:39 +0000)]
2011-01-24 Kenneth Russell <kbr@google.com>
Reviewed by James Robinson.
Web Audio API: port FFTFrame to FFTW
https://bugs.webkit.org/show_bug.cgi?id=52989
Ported FFTFrame class to the open-source FFTW library. Tested with
unit tests from Chris Rogers. Made preliminary changes to GYP
files for conditional compilation of these files; will need to be
adjusted once FFTW is integrated as third-party source.
* WebCore.gyp/WebCore.gyp:
* WebCore.gypi:
* platform/audio/FFTFrame.h:
* platform/audio/fftw: Added.
* platform/audio/fftw/FFTFrameFFTW.cpp: Added.
(WebCore::FFTFrame::FFTFrame):
(WebCore::FFTFrame::~FFTFrame):
(WebCore::FFTFrame::multiply):
(WebCore::FFTFrame::doFFT):
(WebCore::FFTFrame::doInverseFFT):
(WebCore::FFTFrame::cleanup):
(WebCore::FFTFrame::realData):
(WebCore::FFTFrame::imagData):
(WebCore::FFTFrame::fftwPlanForSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76562
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Tue, 25 Jan 2011 02:38:10 +0000 (02:38 +0000)]
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Reset the page scale factor on standard frame loads
https://bugs.webkit.org/show_bug.cgi?id=53058
<rdar://problem/8908844>
Add a symbol needed by WebKit2.
* WebCore.exp.in:
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by Dan Bernstein.
Reset the page scale factor on standard frame loads
https://bugs.webkit.org/show_bug.cgi?id=53058
<rdar://problem/8908844>
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::scaleWebView):
Don't set m_viewScaleFactor here. It will be set in viewScaleFactorDidChange.
(WebKit::WebPageProxy::viewScaleFactorDidChange):
Update m_viewScaleFactor.
* UIProcess/WebPageProxy.h:
Add viewScaleFactorDidChange.
* UIProcess/WebPageProxy.messages.in:
Add ViewScaleFactorDidChange message.
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchDidCommitLoad):
Set the scale factor.
(WebKit::WebFrameLoaderClient::restoreViewState):
Inform the UI process about the new view scale factor.
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::scaleWebView):
Send a ViewScaleFactorDidChange message.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76561
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 25 Jan 2011 02:21:49 +0000 (02:21 +0000)]
2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
Reviewed by Eric Seidel.
Stop instantiating legacy editing positions in InsertTextCommand, MoveSelectionCommand,
ReplaceSelectionCommand, SelectionController, SpellChecker, TypingCommand, and markup.cpp
https://bugs.webkit.org/show_bug.cgi?id=52676
Stop instantiating legacy editing positions in the following files.
* editing/InsertTextCommand.cpp:
(WebCore::InsertTextCommand::prepareForTextInsertion):
(WebCore::InsertTextCommand::performTrivialReplace):
(WebCore::InsertTextCommand::input):
(WebCore::InsertTextCommand::insertTab):
* editing/MoveSelectionCommand.cpp:
(WebCore::MoveSelectionCommand::doApply):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::removeUnrenderedTextNodesAtEnds):
(WebCore::ReplaceSelectionCommand::mergeEndIfNeeded):
(WebCore::ReplaceSelectionCommand::doApply):
(WebCore::ReplaceSelectionCommand::shouldRemoveEndBR):
(WebCore::ReplaceSelectionCommand::performTrivialReplace):
* editing/SelectionController.cpp:
(WebCore::SelectionController::setSelectionFromNone):
* editing/SpellChecker.cpp:
(WebCore::SpellChecker::didCheck):
* editing/TypingCommand.cpp:
(WebCore::TypingCommand::makeEditableRootEmpty):
(WebCore::TypingCommand::deleteKeyPressed):
(WebCore::TypingCommand::forwardDeleteKeyPressed):
* editing/markup.cpp:
(WebCore::StyledMarkupAccumulator::appendText):
(WebCore::StyledMarkupAccumulator::serializeNodes):
(WebCore::highestAncestorToWrapMarkup):
(WebCore::createMarkup):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76560
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Tue, 25 Jan 2011 02:08:52 +0000 (02:08 +0000)]
2011-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Use designated temp directory for the database for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=53052
Adopt the new WK2 API for this.
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::libraryPathForTesting):
(WTR::TestController::initialize):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/mac/TestControllerMac.mm:
(WTR::TestController::platformLibraryPathForTesting):
* WebKitTestRunner/qt/TestControllerQt.cpp:
(WTR::TestController::platformLibraryPathForTesting):
* WebKitTestRunner/win/TestControllerWin.cpp:
(WTR::TestController::platformLibraryPathForTesting):
2011-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Anders Carlsson.
Use designated temp directory for the database for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=53052
Add the API necessary to support this. Database path is now
determined on the UI process side and passed to the Web process.
Reviewed by Anders Carlsson.
* GNUmakefile.am:
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::encode):
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetDatabaseDirectory):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::ensureWebProcess):
(WebKit::WebContext::databaseDirectory):
* UIProcess/WebContext.h:
(WebKit::WebContext::setDatabaseDirectory):
* UIProcess/mac/WebContextMac.mm:
(WebKit::WebContext::platformDefaultDatabaseDirectory):
* UIProcess/qt/WebContextQt.cpp:
(WebKit::WebContext::platformDefaultDatabaseDirectory):
* UIProcess/win/WebContextWin.cpp:
(WebKit::WebContext::platformDefaultDatabaseDirectory):
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/WebDatabaseManager.cpp:
(WebKit::WebDatabaseManager::initialize):
(WebKit::WebDatabaseManager::WebDatabaseManager):
* WebProcess/WebCoreSupport/WebDatabaseManager.h:
* WebProcess/WebCoreSupport/gtk/WebDatabaseManagerGtk.cpp: Removed.
* WebProcess/WebCoreSupport/mac/WebDatabaseManagerMac.mm: Removed.
* WebProcess/WebCoreSupport/qt/WebDatabaseManagerQt.cpp: Removed.
* WebProcess/WebCoreSupport/win/WebDatabaseManagerWin.cpp: Removed.
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::WebProcess):
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/com.apple.WebProcess.sb:
* WebProcess/mac/WebProcessMac.mm:
(WebKit::initializeSandbox):
* win/WebKit2.vcproj:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76559
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 25 Jan 2011 02:05:30 +0000 (02:05 +0000)]
2011-01-24 Martin Robinson <mrobinson@igalia.com>
Skipping failing tests after r76555.
* platform/gtk/Skipped: Skip failing tests.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76558
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Tue, 25 Jan 2011 01:36:51 +0000 (01:36 +0000)]
2011-01-24 Peter Kasting <pkasting@google.com>
Reviewed by Darin Adler.
Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733
* fast/events/mouse-click-events-expected.txt:
* fast/events/script-tests/mouse-click-events.js:
2011-01-24 Peter Kasting <pkasting@google.com>
Reviewed by Darin Adler.
Roll back r67261 ("Don't fire onclick on middle clicks") due to
regressions.
https://bugs.webkit.org/show_bug.cgi?id=46733
* html/HTMLAnchorElement.cpp:
(WebCore::isLinkClick):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::preDispatchEventHandler):
(WebCore::HTMLInputElement::postDispatchEventHandler):
(WebCore::HTMLInputElement::defaultEventHandler):
* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseDoubleClickEvent):
(WebCore::EventHandler::handleMouseReleaseEvent):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76557
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Tue, 25 Jan 2011 00:58:57 +0000 (00:58 +0000)]
2011-01-24 Xiaomei Ji <xji@chromium.org>
Unreviewed.
Skip cjk-segmentation.html (introduced in r76548) in QT.
QT skipped range-expand.html, skip cjk-segmentation as well.
* platform/qt/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76556
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mrobinson@webkit.org [Tue, 25 Jan 2011 00:47:18 +0000 (00:47 +0000)]
2011-01-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Many DOM XHTML tests time out
https://bugs.webkit.org/show_bug.cgi?id=52553
* platform/gtk/Skipped: Unskip tests which are no longer timing out.
2011-01-24 Martin Robinson <mrobinson@igalia.com>
Reviewed by Eric Seidel.
[GTK] Many DOM XHTML tests time out
https://bugs.webkit.org/show_bug.cgi?id=52553
Properly handle the situation where a synchronous load fails before the inner
event loop has started. In this case, we simply do not run the inner event loop,
or else it will block indefinitely (since no GIO or libsoup callbacks will fire).
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::ResourceHandle::loadResourceSynchronously): Bail out of a synchronous
load if it fails up front.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76555
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
lforschler@apple.com [Tue, 25 Jan 2011 00:46:02 +0000 (00:46 +0000)]
Add a new Leopard test bot.
Reviewed by Stephanie Lewis.
* BuildSlaveSupport/build.webkit.org-config/config.json:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76554
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
gyuyoung.kim@samsung.com [Tue, 25 Jan 2011 00:35:38 +0000 (00:35 +0000)]
2011-01-24 Gyuyoung Kim <gyuyoung.kim@samsung.com>
Reviewed by Adam Barth.
Add EFL Builder to core waterfall
https://bugs.webkit.org/show_bug.cgi?id=52704
Add EFL Builder to the core waterfall again.
* Scripts/webkitpy/common/net/buildbot/buildbot.py:
* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76553
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
rniwa@webkit.org [Tue, 25 Jan 2011 00:09:22 +0000 (00:09 +0000)]
2011-01-24 Ryosuke Niwa <rniwa@webkit.org>
Unreviewed Chromium test expectation update for r76548.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76552
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
bfulgham@webkit.org [Mon, 24 Jan 2011 23:40:38 +0000 (23:40 +0000)]
Unreviewed build fix.
* win/WebKit2.vcproj: Don't build the CG Utilities when building
without CG support.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76551
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 24 Jan 2011 23:16:26 +0000 (23:16 +0000)]
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by John Sullivan.
Don't use the timeout checker for non-user-interaction messages
https://bugs.webkit.org/show_bug.cgi?id=53046
* UIProcess/ChunkedUpdateDrawingAreaProxy.cpp:
(WebKit::ChunkedUpdateDrawingAreaProxy::didSetSize):
(WebKit::ChunkedUpdateDrawingAreaProxy::sendSetSize):
* UIProcess/LayerBackedDrawingAreaProxy.cpp:
(WebKit::LayerBackedDrawingAreaProxy::sizeDidChange):
(WebKit::LayerBackedDrawingAreaProxy::didSetSize):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76550
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zmo@google.com [Mon, 24 Jan 2011 22:42:12 +0000 (22:42 +0000)]
2011-01-24 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Adler.
Remove sizeInBytes from GraphicsContext3D's various implementations
https://bugs.webkit.org/show_bug.cgi?id=52339
* src/GraphicsContext3DChromium.cpp:
* src/GraphicsContext3DInternal.h:
2011-01-24 Zhenyao Mo <zmo@google.com>
Reviewed by Darin Adler.
Remove sizeInBytes from GraphicsContext3D's various implementations
https://bugs.webkit.org/show_bug.cgi?id=52339
* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::sizeInBytes):
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/opengl/GraphicsContext3DOpenGL.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76549
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
xji@chromium.org [Mon, 24 Jan 2011 22:25:07 +0000 (22:25 +0000)]
2011-01-24 Xiaomei Ji <xji@chromium.org>
Reviewed by Ryosuke Niwa.
Add test for Chinese Segmentation.
https://bugs.webkit.org/show_bug.cgi?id=52926
The CJK segmentation currently does not work in other ports except Chromium.
Please refer to https://bugs.webkit.org/show_bug.cgi?id=53044 for detail.
* fast/text/international/cjk-segmentation-expected.txt: Added.
* fast/text/international/cjk-segmentation.html: Added.
* platform/chromium/fast/text/international: Added.
* platform/chromium/fast/text/international/cjk-segmentation-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76548
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 22:22:42 +0000 (22:22 +0000)]
2011-01-24 Xianzhu Wang <wangxianzhu@google.com>
Reviewed by Tony Chang.
new-run-webkit-tests fails to start HTTP server if there are proxy settings
https://bugs.webkit.org/show_bug.cgi?id=52872
Force disabling proxy to resolve the problem.
* Scripts/webkitpy/layout_tests/port/http_server_base.py:
* Scripts/webkitpy/layout_tests/port/websocket_server.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76547
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
aroben@apple.com [Mon, 24 Jan 2011 22:17:39 +0000 (22:17 +0000)]
Windows Production build fix
Source/JavaScriptCore:
* JavaScriptCore.vcproj/JavaScriptCore.make: Update for move of JavaScriptCore into Source.
Source/WebCore:
* WebCore.vcproj/WebCore.make: Update for move of WebCore into Source.
Source/WebKit/win:
* WebKit.vcproj/WebKit.make: Update for move of WebKit into Source.
Source/WebKit2:
* win/WebKit2.make: Update for move of WebKit2 into Source.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76546
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
wsiegrist@apple.com [Mon, 24 Jan 2011 22:01:56 +0000 (22:01 +0000)]
2011-01-24 William Siegrist <wsiegrist@apple.com>
Apply fix for https://bugzilla.mozilla.org/show_bug.cgi?id=621591
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76545
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mjs@apple.com [Mon, 24 Jan 2011 21:33:24 +0000 (21:33 +0000)]
2011-01-24 Maciej Stachowiak <mjs@apple.com>
Reviewed by Eric Seidel.
Skip a newly added test that uses textInputController
https://bugs.webkit.org/show_bug.cgi?id=53027
* platform/mac-wk2/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76544
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
jberlin@webkit.org [Mon, 24 Jan 2011 21:02:03 +0000 (21:02 +0000)]
WebKit2: LayoutTests: The UNIMPLEMENTED warnings in TextCheckerWin should be disabled
https://bugs.webkit.org/show_bug.cgi?id=53029
Reviewed by Adam Roben.
* UIProcess/win/TextCheckerWin.cpp:
Disable the warnings for this file.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76543
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Mon, 24 Jan 2011 20:31:09 +0000 (20:31 +0000)]
2011-01-24 Andrei Popescu <andreip@google.com>
Unreviewed, build fix.
LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
https://bugs.webkit.org/show_bug.cgi?id=53032
Fix the expected output, which still had an error.
* storage/indexeddb/objectstore-autoincrement-expected.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76542
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
antonm@chromium.org [Mon, 24 Jan 2011 20:22:28 +0000 (20:22 +0000)]
2011-01-24 Anton Muhin <antonm@chromium.org>
Reviewed by Nate Chapin.
[v8] Refactoring: extract IntrusiveDOMWrapperMap into a seprate class and files.
https://bugs.webkit.org/show_bug.cgi?id=52911
Plain refactoring, covered by the existing tests.
* WebCore.gypi: IntrusiveDOMWrapperMap.h added.
* bindings/v8/DOMDataStore.cpp: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
* bindings/v8/DOMDataStore.h: IntrusiveDOMWrapperMap is moved out of DOMDataStore class.
* bindings/v8/IntrusiveDOMWrapperMap.h: Added.
(WebCore::ChunkedTable::ChunkedTable):
(WebCore::ChunkedTable::add):
(WebCore::ChunkedTable::remove):
(WebCore::ChunkedTable::clear):
(WebCore::ChunkedTable::visit):
(WebCore::ChunkedTable::Chunk::Chunk):
(WebCore::ChunkedTable::clearEntries):
(WebCore::ChunkedTable::visitEntries):
(WebCore::IntrusiveDOMWrapperMap::IntrusiveDOMWrapperMap):
(WebCore::IntrusiveDOMWrapperMap::get):
(WebCore::IntrusiveDOMWrapperMap::set):
(WebCore::IntrusiveDOMWrapperMap::contains):
(WebCore::IntrusiveDOMWrapperMap::visit):
(WebCore::IntrusiveDOMWrapperMap::removeIfPresent):
(WebCore::IntrusiveDOMWrapperMap::clear):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::move):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::clear):
(WebCore::IntrusiveDOMWrapperMap::ChunkedTableTraits::visit):
* bindings/v8/StaticDOMDataStore.h: include added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76541
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 20:11:02 +0000 (20:11 +0000)]
2011-01-24 Kenji Imasaki <imasaki@chromium.org>
Reviewed by Jian Li.
[chromium] Remove non-flaky tests from test expectation file
https://bugs.webkit.org/show_bug.cgi?id=53022
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76540
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Mon, 24 Jan 2011 19:43:59 +0000 (19:43 +0000)]
2011-01-24 Andrei Popescu <andreip@google.com>
Reviewed by Jeremy Orlow.
LayoutTest/storage/indexeddb/objectstore-autoincrement.html is failing after r76533
https://bugs.webkit.org/show_bug.cgi?id=53032
This fixes the layout test by modifying the arguments to IDBDatabase::transaction.
* storage/indexeddb/objectstore-autoincrement-expected.txt:
* storage/indexeddb/objectstore-autoincrement.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76538
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 19:42:08 +0000 (19:42 +0000)]
2011-01-24 Shane Stephens <shanestephens@google.com>
Reviewed by Chris Marrin.
TransformationMatrix multiply operations apply operands in wrong order.
https://bugs.webkit.org/show_bug.cgi?id=52780
Rename TranformationMatrix::multLeft into multiply (the method does a multRight,
not a multLeft).
Remove TransformationMatrix::multiply, which was actually doing a multLeft.
Fix TransformationMatrix::operator* and operator*= such that the operand is
applied to the right-hand side of the matrix that the method is called on.
i.e., previously "a * b" used to compute "b * a", and "a *= b" used to store
"b * a" in "a". This has now been fixed so "a * b" computes "a * b" and
"a *= b" stores "a * b" in "a".
Convert all call sites for these methods to provide operands in the correct order.
No new tests as patch adds no new functionality.
* css/WebKitCSSMatrix.cpp:
(WebCore::WebKitCSSMatrix::multiply):
* platform/graphics/transforms/Matrix3DTransformOperation.h:
(WebCore::Matrix3DTransformOperation::apply):
* platform/graphics/transforms/MatrixTransformOperation.h:
(WebCore::MatrixTransformOperation::apply):
* platform/graphics/transforms/TransformationMatrix.cpp:
(WebCore::TransformationMatrix::scaleNonUniform):
(WebCore::TransformationMatrix::scale3d):
(WebCore::TransformationMatrix::rotate3d):
(WebCore::TransformationMatrix::skew):
(WebCore::TransformationMatrix::applyPerspective):
(WebCore::TransformationMatrix::multiply):
(WebCore::TransformationMatrix::recompose):
* platform/graphics/transforms/TransformationMatrix.h:
(WebCore::TransformationMatrix::operator*=):
(WebCore::TransformationMatrix::operator*):
* rendering/RenderLayer.cpp:
(WebCore::transparencyClipBox):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTransformFromContainer):
* rendering/TransformState.cpp:
(WebCore::TransformState::applyTransform):
(WebCore::HitTestingTransformState::applyTransform):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76537
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 24 Jan 2011 19:33:52 +0000 (19:33 +0000)]
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Wait for half a second if we're asked to paint when receiving a DidSetSize message
https://bugs.webkit.org/show_bug.cgi?id=53028
* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::paint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76536
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 24 Jan 2011 19:18:43 +0000 (19:18 +0000)]
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Implement forceRedisplay in the new drawing area
https://bugs.webkit.org/show_bug.cgi?id=53026
* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::forceRepaint):
* WebProcess/WebPage/DrawingAreaImpl.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76535
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andersca@apple.com [Mon, 24 Jan 2011 19:11:58 +0000 (19:11 +0000)]
2011-01-24 Anders Carlsson <andersca@apple.com>
Reviewed by Sam Weinig.
Fill unpainted rects with the background color.
https://bugs.webkit.org/show_bug.cgi?id=53025
* UIProcess/API/mac/WKView.mm:
(drawPageBackground):
Add new helper function.
(-[WKView drawRect:]):
Iterate over the unpainted rects and fill them with the background color.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76533
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreip@google.com [Mon, 24 Jan 2011 19:01:45 +0000 (19:01 +0000)]
2011-01-24 Andrei Popescu <andreip@google.com>
Reviewed by Nate Chapin.
IndexedDatabase methods should not take arguments of type OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=53012
* storage/indexeddb/create-object-store-options-expected.txt:
* storage/indexeddb/create-object-store-options.html:
* storage/indexeddb/cursor-delete-expected.txt:
* storage/indexeddb/cursor-delete.html:
* storage/indexeddb/cursor-index-delete-expected.txt:
* storage/indexeddb/cursor-index-delete.html:
* storage/indexeddb/data-corruption-expected.txt:
* storage/indexeddb/data-corruption.html:
* storage/indexeddb/database-quota-expected.txt:
* storage/indexeddb/database-quota.html:
* storage/indexeddb/index-cursor.html:
* storage/indexeddb/objectstore-basics-expected.txt:
* storage/indexeddb/objectstore-basics.html:
* storage/indexeddb/objectstore-cursor.html:
* storage/indexeddb/open-cursor-expected.txt:
* storage/indexeddb/open-cursor.html:
* storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
* storage/indexeddb/transaction-and-objectstore-calls.html:
* storage/indexeddb/tutorial.html:
2011-01-24 Andrei Popescu <andreip@google.com>
Reviewed by Nate Chapin.
IndexedDatabase methods should not take arguments of type OptionsObject
https://bugs.webkit.org/show_bug.cgi?id=53012
This patch reverts all IDB methods, except IDBDatabase::createObjectStore and
IDBObjectStore::createIndex, to using a plain list of arguments instead of
grouping the various parameters inside a single OptionsObject argument.
This decision was made on public-webapps@w3.org mailing list.
We also add support (v8 only for now) for passing DOMStringList objects as arguments to native
methods. The code for obtaining a DOMStringList object from a JS array of strings existed already
in OptionsObject.cpp, I just copied it to V8Bindings.cpp and taught the v8 code generator how to
use it.
* bindings/scripts/CodeGeneratorV8.pm:
* bindings/v8/V8Binding.cpp:
(WebCore::v8ValueToWebCoreDOMStringList):
* bindings/v8/V8Binding.h:
* storage/IDBDatabase.cpp:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.h:
(WebCore::IDBDatabase::transaction):
* storage/IDBDatabase.idl:
* storage/IDBIndex.cpp:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* storage/IDBIndex.h:
(WebCore::IDBIndex::openCursor):
(WebCore::IDBIndex::openKeyCursor):
* storage/IDBIndex.idl:
* storage/IDBObjectStore.cpp:
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.h:
(WebCore::IDBObjectStore::openCursor):
* storage/IDBObjectStore.idl:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76531
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 18:33:04 +0000 (18:33 +0000)]
2011-01-24 Andreas Kling <kling@webkit.org>
Reviewed by Darin Adler.
check-webkit-style: Update exemptions following Source/ move.
https://bugs.webkit.org/show_bug.cgi?id=53017
* Scripts/webkitpy/style/checker.py:
* Scripts/webkitpy/style/checker_unittest.py:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76530
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mitz@apple.com [Mon, 24 Jan 2011 17:54:10 +0000 (17:54 +0000)]
WebKit2 version of <rdar://problem/6097826> Mail's cursor does not become a resize cursor when moving mouse from scrolled email to the horizontal splitter
Reviewed by John Sullivan.
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::setCursor): If the current cursor comes from a cursor rect, do not override it.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76529
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
chang.shu@nokia.com [Mon, 24 Jan 2011 17:40:37 +0000 (17:40 +0000)]
2011-01-24 Chang Shu <chang.shu@nokia.com>
Reviewed by Darin Adler.
Move contentEditable related test cases to the right place as they are DOM
related instead of editing related.
https://bugs.webkit.org/show_bug.cgi?id=53010
* editing/editability: Removed.
* editing/editability/attr-empty-string-expected.txt: Removed.
* editing/editability/attr-empty-string.html: Removed.
* editing/editability/attr-false-string-expected.txt: Removed.
* editing/editability/attr-false-string.html: Removed.
* editing/editability/attr-invalid-string-expected.txt: Removed.
* editing/editability/attr-invalid-string.html: Removed.
* editing/editability/attr-missing-ancestor-false-expected.txt: Removed.
* editing/editability/attr-missing-ancestor-false.html: Removed.
* editing/editability/attr-missing-ancestor-true-expected.txt: Removed.
* editing/editability/attr-missing-ancestor-true.html: Removed.
* editing/editability/attr-missing-parent-ancestor-missing-expected.txt: Removed.
* editing/editability/attr-missing-parent-ancestor-missing.html: Removed.
* editing/editability/attr-missing-parent-false-expected.txt: Removed.
* editing/editability/attr-missing-parent-false.html: Removed.
* editing/editability/attr-missing-parent-true-expected.txt: Removed.
* editing/editability/attr-missing-parent-true.html: Removed.
* editing/editability/attr-true-string-expected.txt: Removed.
* editing/editability/attr-true-string.html: Removed.
* editing/editability/set-false-expected.txt: Removed.
* editing/editability/set-false.html: Removed.
* editing/editability/set-inherit-parent-false-expected.txt: Removed.
* editing/editability/set-inherit-parent-false.html: Removed.
* editing/editability/set-inherit-parent-true-expected.txt: Removed.
* editing/editability/set-inherit-parent-true.html: Removed.
* editing/editability/set-invalid-value-expected.txt: Removed.
* editing/editability/set-invalid-value.html: Removed.
* editing/editability/set-true-expected.txt: Removed.
* editing/editability/set-true.html: Removed.
* editing/editability/set-value-caseinsensitive-expected.txt: Removed.
* editing/editability/set-value-caseinsensitive.html: Removed.
* fast/dom/HTMLElement/attr-empty-string-expected.txt: Copied from LayoutTests/editing/editability/attr-empty-string-expected.txt.
* fast/dom/HTMLElement/attr-empty-string.html: Copied from LayoutTests/editing/editability/attr-empty-string.html.
* fast/dom/HTMLElement/attr-false-string-expected.txt: Copied from LayoutTests/editing/editability/attr-false-string-expected.txt.
* fast/dom/HTMLElement/attr-false-string.html: Copied from LayoutTests/editing/editability/attr-false-string.html.
* fast/dom/HTMLElement/attr-invalid-string-expected.txt: Copied from LayoutTests/editing/editability/attr-invalid-string-expected.txt.
* fast/dom/HTMLElement/attr-invalid-string.html: Copied from LayoutTests/editing/editability/attr-invalid-string.html.
* fast/dom/HTMLElement/attr-missing-ancestor-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false-expected.txt.
* fast/dom/HTMLElement/attr-missing-ancestor-false.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-false.html.
* fast/dom/HTMLElement/attr-missing-ancestor-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true-expected.txt.
* fast/dom/HTMLElement/attr-missing-ancestor-true.html: Copied from LayoutTests/editing/editability/attr-missing-ancestor-true.html.
* fast/dom/HTMLElement/attr-missing-parent-ancestor-missing-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing-expected.txt.
* fast/dom/HTMLElement/attr-missing-parent-ancestor-missing.html: Copied from LayoutTests/editing/editability/attr-missing-parent-ancestor-missing.html.
* fast/dom/HTMLElement/attr-missing-parent-false-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-false-expected.txt.
* fast/dom/HTMLElement/attr-missing-parent-false.html: Copied from LayoutTests/editing/editability/attr-missing-parent-false.html.
* fast/dom/HTMLElement/attr-missing-parent-true-expected.txt: Copied from LayoutTests/editing/editability/attr-missing-parent-true-expected.txt.
* fast/dom/HTMLElement/attr-missing-parent-true.html: Copied from LayoutTests/editing/editability/attr-missing-parent-true.html.
* fast/dom/HTMLElement/attr-true-string-expected.txt: Copied from LayoutTests/editing/editability/attr-true-string-expected.txt.
* fast/dom/HTMLElement/attr-true-string.html: Copied from LayoutTests/editing/editability/attr-true-string.html.
* fast/dom/HTMLElement/set-false-expected.txt: Copied from LayoutTests/editing/editability/set-false-expected.txt.
* fast/dom/HTMLElement/set-false.html: Copied from LayoutTests/editing/editability/set-false.html.
* fast/dom/HTMLElement/set-inherit-parent-false-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-false-expected.txt.
* fast/dom/HTMLElement/set-inherit-parent-false.html: Copied from LayoutTests/editing/editability/set-inherit-parent-false.html.
* fast/dom/HTMLElement/set-inherit-parent-true-expected.txt: Copied from LayoutTests/editing/editability/set-inherit-parent-true-expected.txt.
* fast/dom/HTMLElement/set-inherit-parent-true.html: Copied from LayoutTests/editing/editability/set-inherit-parent-true.html.
* fast/dom/HTMLElement/set-invalid-value-expected.txt: Copied from LayoutTests/editing/editability/set-invalid-value-expected.txt.
* fast/dom/HTMLElement/set-invalid-value.html: Copied from LayoutTests/editing/editability/set-invalid-value.html.
* fast/dom/HTMLElement/set-true-expected.txt: Copied from LayoutTests/editing/editability/set-true-expected.txt.
* fast/dom/HTMLElement/set-true.html: Copied from LayoutTests/editing/editability/set-true.html.
* fast/dom/HTMLElement/set-value-caseinsensitive-expected.txt: Copied from LayoutTests/editing/editability/set-value-caseinsensitive-expected.txt.
* fast/dom/HTMLElement/set-value-caseinsensitive.html: Copied from LayoutTests/editing/editability/set-value-caseinsensitive.html.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76528
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tony@chromium.org [Mon, 24 Jan 2011 17:37:45 +0000 (17:37 +0000)]
2011-01-24 Tony Chang <tony@chromium.org>
Reviewed by James Robinson.
[chromium] turn off gyp circular dependency checking and roll chromium deps
https://bugs.webkit.org/show_bug.cgi?id=52935
* DEPS:
* gyp_webkit: Turn off gyp circular dependency checking on Linux
and Win since we don't do these checks in gyp_chromium. It's
just making it harder for us to roll DEPS and have something
explode.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76527
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
satish@chromium.org [Mon, 24 Jan 2011 17:35:21 +0000 (17:35 +0000)]
2011-01-24 Satish Sampath <satish@chromium.org>
Reviewed by Csaba Osztrogonác.
Remove obsolete public/API method in chromium port
https://bugs.webkit.org/show_bug.cgi?id=53015
* public/WebSpeechInputController.h:
(WebKit::WebSpeechInputController::startRecognition): Removed obsolete method
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76526
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 24 Jan 2011 17:29:27 +0000 (17:29 +0000)]
2011-01-24 Andras Becsi <abecsi@webkit.org>
Rubber-stamped by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* DumpRenderTree/qt/ImageDiff.pro: Add missing "Source" to WebKit.pri path
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76525
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
weinig@apple.com [Mon, 24 Jan 2011 17:25:40 +0000 (17:25 +0000)]
Add editing/inserting/insert-composition-whitespace.html to the windows
skipped list.
* platform/win/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76524
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 16:56:12 +0000 (16:56 +0000)]
Unreviewed.
Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 3)
* platform/qt/editing/selection/ [...]:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76523
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 16:50:00 +0000 (16:50 +0000)]
Unreviewed.
Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 2)
* platform/qt/editing/selection/ [...]:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76522
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 16:37:56 +0000 (16:37 +0000)]
Unreviewed.
Add Qt specific expected results for passing editing/selections tests.
Compared to Mac png files and Mac expected files. (part 1)
* platform/qt/editing/selection/ [...]:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76521
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
kbalazs@webkit.org [Mon, 24 Jan 2011 16:20:00 +0000 (16:20 +0000)]
Typo fix.
Rubber-stamped by Csaba Osztrogonác.
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::ProcessLauncher::launchProcess): Move the bracket to the right place.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76520
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pfeldman@chromium.org [Mon, 24 Jan 2011 15:28:01 +0000 (15:28 +0000)]
2011-01-24 Pavel Feldman <pfeldman@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: extract dispatch API from network manager.
https://bugs.webkit.org/show_bug.cgi?id=53009
* WebCore.xcodeproj/project.pbxproj:
* inspector/front-end/NetworkManager.js:
(WebInspector.NetworkManager):
(WebInspector.NetworkManager.prototype.reset):
(WebInspector.NetworkManager.prototype.requestContent):
(WebInspector.NetworkManager.prototype._processCachedResources):
(WebInspector.NetworkDispatcher):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithRequest):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithResponse):
(WebInspector.NetworkDispatcher.prototype._updateResourceWithCachedResource):
(WebInspector.NetworkDispatcher.prototype.identifierForInitialRequest):
(WebInspector.NetworkDispatcher.prototype.willSendRequest):
(WebInspector.NetworkDispatcher.prototype.didReceiveResponse):
(WebInspector.NetworkDispatcher.prototype.didLoadResourceFromMemoryCache):
(WebInspector.NetworkDispatcher.prototype.didCommitLoadForFrame):
(WebInspector.NetworkDispatcher.prototype.didCreateWebSocket):
(WebInspector.NetworkDispatcher.prototype._appendRedirect):
(WebInspector.NetworkDispatcher.prototype._startResource):
(WebInspector.NetworkDispatcher.prototype._updateResource):
(WebInspector.NetworkDispatcher.prototype._finishResource):
(WebInspector.NetworkDispatcher.prototype._addFramesRecursively):
(WebInspector.NetworkDispatcher.prototype._dispatchEventToListeners):
(WebInspector.NetworkDispatcher.prototype._createResource):
* inspector/front-end/Resource.js:
(WebInspector.Resource.prototype._innerRequestContent):
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.ResourceTreeModel):
(WebInspector.ResourceTreeModel.prototype.reset):
(WebInspector.ResourceTreeModel.prototype.unbindResourceURL):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76519
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 24 Jan 2011 15:20:30 +0000 (15:20 +0000)]
2011-01-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [JSC] remove ScriptDebugServer::pageCreated
https://bugs.webkit.org/show_bug.cgi?id=53007
It's impossible to create "provisional" inspector for pages which are
not yet created so there is no need to listen for page creation in ScriptDebugServer.
* bindings/js/ScriptDebugServer.cpp:
* bindings/js/ScriptDebugServer.h:
* page/Page.cpp:
(WebCore::Page::Page):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76518
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 15:11:30 +0000 (15:11 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [REGRESSION] AppCache view on resources panel is broken.
https://bugs.webkit.org/show_bug.cgi?id=53002
* inspector/front-end/ApplicationCacheItemsView.js:
(WebInspector.ApplicationCacheItemsView.prototype._update):
* inspector/front-end/DOMAgent.js:
(WebInspector.ApplicationCacheDispatcher.getApplicationCachesAsync):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76517
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
reni@webkit.org [Mon, 24 Jan 2011 15:01:30 +0000 (15:01 +0000)]
[Qt] QWebFramePrivate::renderRelativeCoords() calls QPainter::save/restore more than necessary
https://bugs.webkit.org/show_bug.cgi?id=49915
Reviewed by Andreas Kling.
In the first loop of renderRelativeCoords() the call of QPainter::save/restore is useless, because
the context is saved/stored within the loop.
In the second loop the calls are also avoidable by using inverse translation on context.
* Api/qwebframe.cpp:
(QWebFramePrivate::renderRelativeCoords):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76516
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 24 Jan 2011 14:46:15 +0000 (14:46 +0000)]
2011-01-24 Andreas Kling <kling@webkit.org>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Fix warnings about unregistering an invalid timer
https://bugs.webkit.org/show_bug.cgi?id=53006
The ShadowBuffer's purge timer ID was initialized with 0 which lead
to us calling QObject::killTimer(0), causing some qWarnings.
* platform/graphics/qt/ContextShadowQt.cpp:
(WebCore::ShadowBuffer::ShadowBuffer):
(WebCore::ShadowBuffer::schedulePurge):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76515
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Mon, 24 Jan 2011 14:39:58 +0000 (14:39 +0000)]
2011-01-21 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: [Chromium] Fix heap snapshot table sorting.
Fix table sorting to avoid qsort instability artefacts.
https://bugs.webkit.org/show_bug.cgi?id=52914
* inspector/front-end/HeapSnapshotView.js:
(WebInspector.HeapSnapshotView.prototype._sortData):
(WebInspector.HeapSnapshotDataGridList.propertyComparator.comparator):
(WebInspector.HeapSnapshotDataGridList.propertyComparator):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76514
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 14:24:10 +0000 (14:24 +0000)]
Unreviewed.
RTL: selection.modify("move", "forward", "line") when cursor is at start of a line does not move down a line
https://bugs.webkit.org/show_bug.cgi?id=51517
* platform/qt-linux/editing: Removed.
* platform/qt-linux/editing/selection: Removed.
* platform/qt-linux/editing/selection/extend-to-line-boundary-expected.txt: Removed.
* platform/qt/Skipped: Add editing/selection/extend-to-line-boundary.html until fix.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76513
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 14:16:00 +0000 (14:16 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r76509.
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setBreakpoint):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76512
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
mnaganov@chromium.org [Mon, 24 Jan 2011 14:06:33 +0000 (14:06 +0000)]
2011-01-24 Mikhail Naganov <mnaganov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: Find duplicate strings in localizedStrings.js, update it.
https://bugs.webkit.org/show_bug.cgi?id=53005
* English.lproj/localizedStrings.js:
* Scripts/check-inspector-strings:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76511
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 14:05:06 +0000 (14:05 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, build fix for r76509.
* bindings/js/ScriptDebugServer.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76510
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 13:55:59 +0000 (13:55 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Yury Semikhatsky.
Web Inspector: set breakpoints by line:column.
https://bugs.webkit.org/show_bug.cgi?id=52615
* CMakeLists.txt:
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
(WebCore::ScriptDebugServer::removeBreakpoint):
(WebCore::ScriptDebugServer::hasBreakpoint):
(WebCore::ScriptDebugServer::clearBreakpoints):
* bindings/js/ScriptDebugServer.h:
* bindings/v8/DebuggerScript.js:
():
* bindings/v8/ScriptDebugServer.cpp:
(WebCore::ScriptDebugServer::setBreakpoint):
* bindings/v8/ScriptDebugServer.h:
* inspector/Inspector.idl:
* inspector/InspectorBrowserDebuggerAgent.cpp:
(WebCore::InspectorBrowserDebuggerAgent::restoreStickyBreakpoint):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::setStickyBreakpoint):
(WebCore::InspectorDebuggerAgent::setBreakpoint):
(WebCore::InspectorDebuggerAgent::restoreBreakpoint):
(WebCore::InspectorDebuggerAgent::didParseSource):
* inspector/InspectorDebuggerAgent.h:
* inspector/ScriptBreakpoint.cpp: Removed.
* inspector/ScriptBreakpoint.h:
(WebCore::ScriptBreakpoint::ScriptBreakpoint):
* inspector/front-end/Breakpoint.js:
(WebInspector.Breakpoint):
(WebInspector.Breakpoint.prototype.get url):
* inspector/front-end/BreakpointManager.js:
(WebInspector.JavaScriptBreakpoint.prototype._serializeToJSON):
* inspector/front-end/DebuggerModel.js:
(WebInspector.DebuggerModel.prototype.continueToLine):
(WebInspector.DebuggerModel.prototype.setBreakpoint):
(WebInspector.DebuggerModel.prototype._breakpointSetOnBackend):
(WebInspector.DebuggerDispatcher.prototype.breakpointResolved):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76509
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 13:05:35 +0000 (13:05 +0000)]
* runtime: Removed. It was accidentally created by r76457.
Rubber-stamped by Csaba Osztrogonác.
Patch by Peter Gal <galpater@inf.u-szeged.hu> on 2011-01-24
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76508
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 12:58:32 +0000 (12:58 +0000)]
2011-01-24 Kimmo Kinnunen <kimmo.t.kinnunen@nokia.com>
Reviewed by Kenneth Rohde Christiansen.
[Qt] Remove CleanupHandler by passing file descriptors.
Deleting files in signal handler of UI process is not a good idea,
because the memory where filenames are stored might not be valid
after a crash.
To avoid the need of using signal handlers for cleanup,
change following:
1) Avoid passing filenames between processes, pass fds
2) When mmap'ing files, delete them immediately after
opening and mmap'ing them.
3) Pass sockets with fds during fork+exec instead of
passing them via the filesystem.
4) Use mmap'ed files for implementation of SharedMemory.
QSharedMemory does not support cleanup correctly.
Consquences:
- Move MappedMemory to SharedMemory, make UpdateChunk use this.
- Implement CoreIPC::Attachment using mmaped files.
- Send messages using datagram socket. This solution works
similiarly to Mach ports on Mac.
- Send big messages out-of-line and thus avoid increasing
the receive buffer.
- Remove MemoryMappedPool and rely on libc/kernel caching
of mmapped areas.
- Unmap memory areas after use.
- When UI process crashes, kill the web process using SIGKILL.
This is possible again because cleanup handler is not needed.
[WK2][Qt] Multiple problems with MemoryMappedPool
https://bugs.webkit.org/show_bug.cgi?id=51984
* Platform/CoreIPC/Attachment.cpp:
(CoreIPC::Attachment::Attachment):
* Platform/CoreIPC/Attachment.h:
(CoreIPC::Attachment::size):
(CoreIPC::Attachment::releaseFileDescriptor):
(CoreIPC::Attachment::fileDescriptor):
* Platform/CoreIPC/Connection.h:
* Platform/CoreIPC/qt/ConnectionQt.cpp:
(CoreIPC::MessageInfo::MessageInfo):
(CoreIPC::MessageInfo::setMessageBodyOOL):
(CoreIPC::MessageInfo::isMessageBodyOOL):
(CoreIPC::MessageInfo::bodySize):
(CoreIPC::MessageInfo::messageID):
(CoreIPC::MessageInfo::attachmentCount):
(CoreIPC::Connection::platformInitialize):
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::SocketNotifierDisableGuard::SocketNotifierDisableGuard):
(CoreIPC::SocketNotifierDisableGuard::~SocketNotifierDisableGuard):
(CoreIPC::Connection::readyReadHandler):
(CoreIPC::Connection::open):
(CoreIPC::Connection::platformCanSendOutgoingMessages):
(CoreIPC::Connection::sendOutgoingMessage):
* Platform/SharedMemory.h:
* Platform/WorkQueue.h:
* Platform/qt/MappedMemoryPool.cpp: Removed.
* Platform/qt/MappedMemoryPool.h: Removed.
* Platform/qt/SharedMemoryQt.cpp:
(WebKit::SharedMemory::Handle::Handle):
(WebKit::SharedMemory::Handle::~Handle):
(WebKit::SharedMemory::Handle::isNull):
(WebKit::SharedMemory::Handle::encode):
(WebKit::SharedMemory::Handle::decode):
(WebKit::SharedMemory::Handle::releaseToAttachment):
(WebKit::SharedMemory::Handle::adoptFromAttachment):
(WebKit::SharedMemory::create):
(WebKit::accessModeMMap):
(WebKit::SharedMemory::~SharedMemory):
(WebKit::accessModeFile):
(WebKit::SharedMemory::createHandle):
* Platform/qt/WorkQueueQt.cpp:
(WorkQueue::registerSocketEventHandler):
* Shared/qt/UpdateChunk.cpp:
(WebKit::UpdateChunk::UpdateChunk):
(WebKit::UpdateChunk::~UpdateChunk):
(WebKit::UpdateChunk::encode):
(WebKit::UpdateChunk::decode):
(WebKit::UpdateChunk::createImage):
* Shared/qt/UpdateChunk.h:
* UIProcess/Launcher/ProcessLauncher.h:
* UIProcess/Launcher/qt/ProcessLauncherQt.cpp:
(WebKit::QtWebProcess::QtWebProcess):
(WebKit::QtWebProcess::setupChildProcess):
(WebKit::ProcessLauncher::launchProcess):
(WebKit::ProcessLauncher::platformInvalidate):
* UIProcess/Launcher/qt/ThreadLauncherQt.cpp:
(WebKit::webThreadBody):
(WebKit::ThreadLauncher::createWebThread):
* WebKit2.pro:
* WebProcess/qt/WebProcessMainQt.cpp:
(WebKit::WebProcessMainQt):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76507
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 24 Jan 2011 12:56:15 +0000 (12:56 +0000)]
2011-01-24 Yury Semikhatsky <yurys@chromium.org>
Unreviewed. Update Chromium test expectations.
* platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
* platform/chromium-mac/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
* platform/chromium-mac/http/tests/security/xss-DENIED-frame-name-expected.txt:
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76506
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 12:46:05 +0000 (12:46 +0000)]
2011-01-24 Peter Beverloo <peter@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: recognize application/x-font-woff as a valid mime-type.
https://bugs.webkit.org/show_bug.cgi?id=52977
No new tests.
* inspector/front-end/inspector.js:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76505
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 11:55:17 +0000 (11:55 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, fix for r76497.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76504
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
zoltan@webkit.org [Mon, 24 Jan 2011 11:53:29 +0000 (11:53 +0000)]
[Qt] Regroup MiniBrowser's menubar and add open file action
https://bugs.webkit.org/show_bug.cgi?id=53000
Reviewed by Andreas Kling.
Add File and Develop menu to MiniBrowser's menubar and add open file action to File menu.
* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::openFile):
(BrowserWindow::~BrowserWindow):
* MiniBrowser/qt/BrowserWindow.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76503
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
pvarga@webkit.org [Mon, 24 Jan 2011 11:52:43 +0000 (11:52 +0000)]
2011-01-24 Peter Varga <pvarga@inf.u-szeged.hu>
Reviewed by Oliver Hunt.
Optimize regex patterns which contain empty alternatives
https://bugs.webkit.org/show_bug.cgi?id=51395
Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.
* fast/regex/script-tests/slow.js:
* fast/regex/slow-expected.txt:
2011-01-24 Peter Varga <pvarga@webkit.org>
Reviewed by Oliver Hunt.
Optimize regex patterns which contain empty alternatives
https://bugs.webkit.org/show_bug.cgi?id=51395
Eliminate the empty alternatives from the regex pattern and convert it to do
the matching in an easier way.
* yarr/YarrPattern.cpp:
(JSC::Yarr::YarrPatternConstructor::atomParenthesesEnd):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76502
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
andreas.kling@nokia.com [Mon, 24 Jan 2011 11:51:17 +0000 (11:51 +0000)]
2011-01-24 Andreas Kling <kling@webkit.org>
Reviewed by Tor Arne Vestbø.
[Qt] Use rad2deg() from WTF instead of rolling our own.
https://bugs.webkit.org/show_bug.cgi?id=52993
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76501
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 11:35:07 +0000 (11:35 +0000)]
2011-01-24 Pavel Podivilov <podivilov@chromium.org>
Unreviewed, test fix for r76497.
* http/tests/inspector/debugger-test2.js:
(initialize_DebuggerTest.InspectorTest.setBreakpointInVisibleView):
(initialize_DebuggerTest.InspectorTest._showScriptSource):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76500
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
ossy@webkit.org [Mon, 24 Jan 2011 11:22:49 +0000 (11:22 +0000)]
Unreviewed fix after r76496
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* BuildSlaveSupport/build.webkit.org-config/master.cfg: Remove unnecessary "Source" from the path.
* BuildSlaveSupport/built-product-archive: Remove unnecessary "Source" from the path.
* Scripts/webkitdirs.pm: Add the accidentally removed slash to the path.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76499
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
sergio@webkit.org [Mon, 24 Jan 2011 10:57:08 +0000 (10:57 +0000)]
2011-01-24 Sergio Villar Senin <svillar@igalia.com>
Reviewed by Martin Robinson.
[Gtk] ResourceHandleSoup: do not wait for streams to close to issue didFinishLoading
https://bugs.webkit.org/show_bug.cgi?id=52885
No new tests as it does not change functionality. We will not wait for
the the input stream to close to issue didFinishLoading to
WebCore. We expect a subtle performance improvement with this
patch when loading complex web pages, as we wouldn't have to wait
for the stream to close (which involves creating a thread among
other things).
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::closeCallback):
(WebCore::readCallback):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76498
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 10:38:43 +0000 (10:38 +0000)]
2011-01-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: eliminate SourceView and ScriptView classes.
https://bugs.webkit.org/show_bug.cgi?id=52896
SourceView and ScriptView delegate everything to SourceFrame and should be eliminated.
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog.prototype._highlightSelectedLine):
* inspector/front-end/ResourceView.js:
(WebInspector.ResourceView.createResourceView):
(WebInspector.ResourceView.resourceViewTypeMatchesResource):
(WebInspector.SourceFrameContentProviderForResource): Moved from SourceView.
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel.prototype.show):
(WebInspector.ResourcesPanel.prototype._applyDiffMarkup):
(WebInspector.FrameResourceTreeElement.prototype._errorsWarningsUpdated):
* inspector/front-end/ScriptView.js: Removed.
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._scriptSourceChanged):
(WebInspector.ScriptsPanel.prototype._sourceFrameForScriptOrResource):
(WebInspector.ScriptsPanel.prototype._showScriptOrResource):
(WebInspector.ScriptsPanel.prototype._setPauseOnExceptions):
(WebInspector.ScriptsPanel.prototype._formatScript):
(WebInspector.SourceFrameContentProviderForScript): Moved from ScriptView.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame):
(WebInspector.SourceFrame.prototype.show):
(WebInspector.SourceFrame.prototype.hide):
(WebInspector.SourceFrame.prototype.hasContent):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
* inspector/front-end/SourceView.js: Removed.
* inspector/front-end/WebKit.qrc:
* inspector/front-end/inspector.html:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76497
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
abecsi@webkit.org [Mon, 24 Jan 2011 10:36:47 +0000 (10:36 +0000)]
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* Source/DerivedSources.pro: Copied from DerivedSources.pro.
* Source/WebKit.pri: Renamed from WebKit.pri.
* Source/WebKit.pro: Added.
* Source/common.pri: Renamed from common.pri.
* WebKit.pro: Removed.
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* JavaScriptCore.pri:
* JavaScriptCore.pro:
* jsc.pro:
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
No new tests needed.
* WebCore.pri:
* WebCore.pro:
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* declarative/declarative.pro:
* docs/docs.pri:
* tests/tests.pri:
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* DerivedSources.pro:
* WebKit2.pro:
* WebProcess.pro:
2011-01-24 Andras Becsi <abecsi@webkit.org>
Reviewed by Csaba Osztrogonác.
[Qt] Move project files into Source
https://bugs.webkit.org/show_bug.cgi?id=52891
* DerivedSources.pro: Renamed from DerivedSources.pro.
* DumpRenderTree/qt/DumpRenderTree.pro:
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* MiniBrowser/DerivedSources.pro:
* MiniBrowser/qt/MiniBrowser.pro:
* QtTestBrowser/QtTestBrowser.pro:
* Scripts/webkitdirs.pm:
* Tools.pro: Added.
* WebKitTestRunner/DerivedSources.pro:
* WebKitTestRunner/InjectedBundle/qt/InjectedBundle.pro:
* WebKitTestRunner/qt/WebKitTestRunner.pro:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76496
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 24 Jan 2011 10:32:30 +0000 (10:32 +0000)]
Unreviewed, trivial fix.
Fix a Chromium-only assertion failure by r76491.
https://bugs.webkit.org/show_bug.cgi?id=38982
Separate icon loading from the FileChooser constructor in order to avoid
ref() before adoptRef().
* platform/FileChooser.cpp:
(WebCore::FileChooser::FileChooser):
(WebCore::FileChooser::initialize):
(WebCore::FileChooser::create):
* platform/FileChooser.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76495
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 24 Jan 2011 10:27:07 +0000 (10:27 +0000)]
2011-01-24 MORITA Hajime <morrita@google.com>
Reviewed by Kent Tamura.
TextControlInnerElement::m_shadowParent should be removed.
https://bugs.webkit.org/show_bug.cgi?id=52998
No new tests. No behavioral change.
* rendering/TextControlInnerElements.cpp:
(WebCore::TextControlInnerElement::TextControlInnerElement):
* rendering/TextControlInnerElements.h:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76494
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yurys@chromium.org [Mon, 24 Jan 2011 10:20:57 +0000 (10:20 +0000)]
2011-01-24 Yury Semikhatsky <yurys@chromium.org>
Reviewed by Pavel Feldman.
REGRESSION (r72895): console.trace crashes
https://bugs.webkit.org/show_bug.cgi?id=52981
- Use local RefPtr variable for accessing PassRefPtr arguments to make sure the PassRefPtr has
non-null value.
- Use PassRefPtr for objects whos ownership is passed to the inspector.
* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorConsoleInstrumentation.h: Added. Extract inline methods called from the console into their
own header to reduce compilation time of other classes that depend on the inspector instrumentation.
(WebCore::InspectorInstrumentation::addMessageToConsole):
(WebCore::InspectorInstrumentation::consoleCount):
(WebCore::InspectorInstrumentation::startConsoleTiming):
(WebCore::InspectorInstrumentation::stopConsoleTiming):
(WebCore::InspectorInstrumentation::consoleMarkTimeline):
(WebCore::InspectorInstrumentation::addStartProfilingMessageToConsole):
(WebCore::InspectorInstrumentation::addProfile):
(WebCore::InspectorInstrumentation::profilerEnabled):
(WebCore::InspectorInstrumentation::getCurrentUserInitiatedProfileName):
* inspector/InspectorDatabaseInstrumentation.h: Added. Extract inline methods called from the datanase code into their
own header to reduce compilation time of other classes that depend on the inspector instrumentation.
(WebCore::InspectorInstrumentation::didOpenDatabase):
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::addMessageToConsoleImpl):
(WebCore::InspectorInstrumentation::consoleCountImpl):
(WebCore::InspectorInstrumentation::stopConsoleTimingImpl):
(WebCore::InspectorInstrumentation::consoleMarkTimelineImpl):
(WebCore::InspectorInstrumentation::addProfileImpl):
(WebCore::InspectorInstrumentation::didOpenDatabaseImpl):
* inspector/InspectorInstrumentation.h:
* page/Console.cpp: use RefPtr local variable instead of accessing PassRefPtr argument directly.
(WebCore::Console::addMessage):
(WebCore::Console::trace):
(WebCore::Console::count):
(WebCore::Console::markTimeline):
(WebCore::Console::profileEnd):
(WebCore::Console::timeEnd):
(WebCore::Console::group):
(WebCore::Console::groupCollapsed):
* storage/Database.cpp:
(WebCore::Database::openDatabase):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76493
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 24 Jan 2011 09:16:25 +0000 (09:16 +0000)]
2011-01-24 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Update Chromim test expectations (LINUX/SVG) in response to r76442, again.
* platform/chromium-linux/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt: Added.
* platform/chromium-linux/svg/custom/svg-fonts-in-html-expected.txt: Added.
* platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
* platform/chromium-linux/svg/text/text-hkern-expected.txt: Added.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.checksum: Added.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.png: Added.
* platform/chromium-linux/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
* platform/chromium-linux/svg/text/text-text-04-t-expected.txt: Added.
* platform/chromium-linux/svg/text/text-vkern-expected.checksum: Added.
* platform/chromium-linux/svg/text/text-vkern-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76492
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
tkent@chromium.org [Mon, 24 Jan 2011 09:15:37 +0000 (09:15 +0000)]
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982
An icon data in Chromium port is represented as WebCore::Image. We
don't need OS-specific code anymore.
* WebCore.gypi:
* platform/graphics/Icon.h:
(WebCore::Icon::create): Add Chromium-specific factory.
* platform/graphics/chromium/IconChromium.cpp: Added.
* platform/graphics/chromium/IconChromiumLinux.cpp: Removed.
* platform/graphics/chromium/IconChromiumMac.cpp: Removed.
* platform/graphics/chromium/IconChromiumWin.cpp: Removed.
* platform/graphics/chromium/PlatformIcon.h:
2010-01-24 Kent Tamura <tkent@chromium.org>
Reviewed by Darin Fisher.
[Chromium] Support icon loading for <input type=file>
https://bugs.webkit.org/show_bug.cgi?id=38982
Implement ChromeClientImpl::chooseIconForFiles(). It delegates loading
to WebViewClient::queryIconForFiles(), and an implementation of
WebViewClient::queryIconForFiles() loads an icon and passes it to a
FileChooser through WebIconLoadingCompletion.
* WebKit.gyp:
* public/WebIconLoadingCompletion.h: Added.
(WebKit::WebIconLoadingCompletion::~WebIconLoadingCompletion):
* public/WebViewClient.h:
(WebKit::WebViewClient::queryIconForFiles):
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::chooseIconForFiles):
* src/WebIconLoadingCompletionImpl.cpp: Added.
(WebKit::WebIconLoadingCompletionImpl::WebIconLoadingCompletionImpl):
(WebKit::WebIconLoadingCompletionImpl::~WebIconLoadingCompletionImpl):
(WebKit::WebIconLoadingCompletionImpl::didLoadIcon):
* src/WebIconLoadingCompletionImpl.h: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76491
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 24 Jan 2011 09:10:40 +0000 (09:10 +0000)]
2011-01-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, GTK still does not have TestInputController support. Opened
a bug to follow the issue:
https://bugs.webkit.org/show_bug.cgi?id=52997
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76490
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
morrita@google.com [Mon, 24 Jan 2011 09:05:09 +0000 (09:05 +0000)]
2011-01-24 MORITA Hajime <morrita@google.com>
Unreviewed, skipped insert-composition-whitespace.html due to missing DRT feature.
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76489
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
podivilov@chromium.org [Mon, 24 Jan 2011 08:44:20 +0000 (08:44 +0000)]
2011-01-21 Pavel Podivilov <podivilov@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: move search functions from SourceView to SourceFrame.
https://bugs.webkit.org/show_bug.cgi?id=52895
This is the last step before eliminating SourceView and ScriptView since
this classes just delegate everything to SourceFrame.
* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype.set visible):
(WebInspector.SourceFrame.prototype._clearLineHighlight):
(WebInspector.SourceFrame.prototype._createTextViewer):
(WebInspector.SourceFrame.prototype.performSearch.doFindSearchMatches):
(WebInspector.SourceFrame.prototype.performSearch):
(WebInspector.SourceFrame.prototype.searchCanceled):
(WebInspector.SourceFrame.prototype.jumpToFirstSearchResult):
(WebInspector.SourceFrame.prototype.jumpToLastSearchResult):
(WebInspector.SourceFrame.prototype.jumpToNextSearchResult):
(WebInspector.SourceFrame.prototype.jumpToPreviousSearchResult):
(WebInspector.SourceFrame.prototype.showingFirstSearchResult):
(WebInspector.SourceFrame.prototype.showingLastSearchResult):
(WebInspector.SourceFrame.prototype._jumpToSearchResult):
* inspector/front-end/SourceView.js:
(WebInspector.SourceView.prototype.hide):
(WebInspector.SourceView.prototype.searchCanceled):
(WebInspector.SourceView.prototype.performSearch):
(WebInspector.SourceView.prototype.jumpToFirstSearchResult):
(WebInspector.SourceView.prototype.jumpToLastSearchResult):
(WebInspector.SourceView.prototype.jumpToNextSearchResult):
(WebInspector.SourceView.prototype.jumpToPreviousSearchResult):
(WebInspector.SourceView.prototype.showingFirstSearchResult):
(WebInspector.SourceView.prototype.showingLastSearchResult):
(WebInspector.SourceView.prototype.clearMessages):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76488
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
commit-queue@webkit.org [Mon, 24 Jan 2011 08:33:57 +0000 (08:33 +0000)]
2011-01-24 Sheriff Bot <webkit.review.bot@gmail.com>
Unreviewed, rolling out r76463.
http://trac.webkit.org/changeset/76463
https://bugs.webkit.org/show_bug.cgi?id=52993
It broke canvas/philip/tests/2d.path.stroke.skew.html
(Requested by Ossy on #webkit).
* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::GraphicsContext::rotate):
* platform/graphics/qt/PathQt.cpp:
(WebCore::Path::addArc):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76487
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
alex@webkit.org [Mon, 24 Jan 2011 08:33:42 +0000 (08:33 +0000)]
2011-01-24 Alejandro G. Castro <alex@igalia.com>
Unreviewed, skipped tests failing the 64bits bot and passing in the
32bits bots. Bug following the issue:
https://bugs.webkit.org/show_bug.cgi?id=52996
* platform/gtk/Skipped:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76486
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 24 Jan 2011 07:52:50 +0000 (07:52 +0000)]
2011-01-23 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Update Chromim test expectations (LINUX/SVG) in response to r76442.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/filters-image-03-f-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1-SE/pservers-pattern-03-f-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-03-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-24-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-36-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-40-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-desc-02-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-05-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-elem-06-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/fonts-glyph-02-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/masking-mask-01-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/text-text-04-t-expected.txt: Added.
* platform/chromium-linux/svg/text/text-vkern-on-horizontal-text-expected.txt: Added.
* platform/chromium/test_expectations.txt:
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76485
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
yuzo@google.com [Mon, 24 Jan 2011 07:19:13 +0000 (07:19 +0000)]
2011-01-23 Yuzo Fujishima <yuzo@google.com>
Unreviewed Chromium test expectation change.
Update Chromim test expectations (WIN/SVG) in response to r76442.
* platform/chromium-win/svg/custom/scrolling-embedded-svg-file-image-repaint-problem-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.checksum:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-in-html-expected.txt:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.txt: Added.
* platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.checksum:
* platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.png:
* platform/chromium-win/svg/text/text-hkern-on-vertical-text-expected.txt: Added.
* platform/chromium-win/svg/text/text-text-04-t-expected.checksum:
* platform/chromium-win/svg/text/text-text-04-t-expected.png:
* platform/chromium-win/svg/text/text-text-04-t-expected.txt:
* platform/chromium-win/svg/text/text-vkern-expected.checksum:
* platform/chromium-win/svg/text/text-vkern-expected.png:
* platform/chromium-win/svg/text/text-vkern-expected.txt: Added.
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76484
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
caseq@chromium.org [Mon, 24 Jan 2011 07:13:16 +0000 (07:13 +0000)]
2011-01-23 Andrey Kosyakov <caseq@chromium.org>
Reviewed by Pavel Feldman.
Web Inspector: summary bar is not resized properly with the rest of net
https://bugs.webkit.org/show_bug.cgi?id=52881
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkPanel.prototype.updateSidebarWidth):
(WebInspector.NetworkPanel.prototype._positionSummaryBar):
(WebInspector.NetworkPanel.prototype._toggleGridMode):
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@76483
268f45cc-cd09-0410-ab3c-
d52691b4dbfc
git://git.webkit.org / WebKit-https.git / log