WebKit-https.git
6 months ago[ macOS ] legacy-animation-engine/fast/animation/request-animation-frame-iframe.html...
tsavell@apple.com [Tue, 4 Feb 2020 23:25:35 +0000 (23:25 +0000)]
[ macOS ] legacy-animation-engine/fast/animation/request-animation-frame-iframe.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207235

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-04

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoPartial revert of r248734 to fix leak of StorageAreaMaps
cdumez@apple.com [Tue, 4 Feb 2020 23:22:41 +0000 (23:22 +0000)]
Partial revert of r248734 to fix leak of StorageAreaMaps
https://bugs.webkit.org/show_bug.cgi?id=207073

Reviewed by Alex Christensen.

Do a partial revert of r248734 so that the StorageNamespaceImpl no longer holds a strong
reference to its StorageAreaMap objects. The code for removing entries from
StorageNamespaceImpl::m_storageAreaMaps (StorageNamespaceImpl::didDestroyStorageAreaMap())
was dead code after r248734 and thus StorageAreaMap were never destroyed.

* WebProcess/WebStorage/StorageAreaImpl.cpp:
(WebKit::StorageAreaImpl::create):
(WebKit::StorageAreaImpl::StorageAreaImpl):
(WebKit::StorageAreaImpl::length):
(WebKit::StorageAreaImpl::key):
(WebKit::StorageAreaImpl::item):
(WebKit::StorageAreaImpl::setItem):
(WebKit::StorageAreaImpl::removeItem):
(WebKit::StorageAreaImpl::clear):
(WebKit::StorageAreaImpl::contains):
(WebKit::StorageAreaImpl::storageType const):
* WebProcess/WebStorage/StorageAreaImpl.h:
* WebProcess/WebStorage/StorageAreaMap.cpp:
(WebKit::StorageAreaMap::create):
(WebKit::StorageAreaMap::~StorageAreaMap):
* WebProcess/WebStorage/StorageAreaMap.h:
* WebProcess/WebStorage/StorageNamespaceImpl.cpp:
(WebKit::StorageNamespaceImpl::storageArea):
* WebProcess/WebStorage/StorageNamespaceImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed, follow-up assertion fix after r255662.
cdumez@apple.com [Tue, 4 Feb 2020 23:09:36 +0000 (23:09 +0000)]
Unreviewed, follow-up assertion fix after r255662.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS iOS ] imported/w3c/web-platform-tests/fetch/stale-while-revalidate/fetch...
tsavell@apple.com [Tue, 4 Feb 2020 23:02:44 +0000 (23:02 +0000)]
[ macOS iOS ] imported/w3c/web-platform-tests/fetch/stale-while-revalidate/fetch.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207230

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-04

* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[JSC] Use PackedRefPtr in UnlinkedCodeBlock
ysuzuki@apple.com [Tue, 4 Feb 2020 22:54:16 +0000 (22:54 +0000)]
[JSC] Use PackedRefPtr in UnlinkedCodeBlock
https://bugs.webkit.org/show_bug.cgi?id=207229

Reviewed by Mark Lam.

Use PackedRefPtr in UnlinkedCodeBlock to compact it from 168 to 160, which saves 16 bytes (10%) per UnlinkedCodeBlock since
we have 16 bytes alignment for GC cells.

* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::sourceURLDirective const):
(JSC::UnlinkedCodeBlock::sourceMappingURLDirective const):
(JSC::UnlinkedCodeBlock::setSourceURLDirective):
(JSC::UnlinkedCodeBlock::setSourceMappingURLDirective):
* runtime/CachedTypes.cpp:
(JSC::CachedCodeBlock::sourceURLDirective const):
(JSC::CachedCodeBlock::sourceMappingURLDirective const):
(JSC::CachedCodeBlock<CodeBlockType>::encode):
* runtime/CodeCache.cpp:
(JSC::CodeCache::getUnlinkedGlobalCodeBlock):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS ] http/tests/misc/image-blocked-src-change.html is flaky failing
tsavell@apple.com [Tue, 4 Feb 2020 22:49:42 +0000 (22:49 +0000)]
[ macOS ] http/tests/misc/image-blocked-src-change.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207226

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-04

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoresults.webkit.org: Support branches in run-javascriptcore-tests
jbedard@apple.com [Tue, 4 Feb 2020 22:17:43 +0000 (22:17 +0000)]
results.webkit.org: Support branches in run-javascriptcore-tests
https://bugs.webkit.org/show_bug.cgi?id=204094

Rubber-stamped by Aakash Jain.

* Scripts/run-javascriptcore-tests:
(uploadResults): Use webkitdirs function to generate commit information.
* Scripts/VCSUtils.pm:
(commitForDirectory): Generate commit information for SVN repository, including
branch name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoReplace bot677 due to hardware failure
jlewis3@apple.com [Tue, 4 Feb 2020 22:14:03 +0000 (22:14 +0000)]
Replace bot677 due to hardware failure
https://bugs.webkit.org/show_bug.cgi?id=207224

Reviewed by Aakash Jain.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS iOS ] imported/w3c/web-platform-tests/service-workers/service-worker/extendab...
ryanhaddad@apple.com [Tue, 4 Feb 2020 22:12:53 +0000 (22:12 +0000)]
[ macOS iOS ] imported/w3c/web-platform-tests/service-workers/service-worker/extendable-event-waituntil.https.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207225

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-04

* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoTestWebKitAPI: Handle case where test result does not contain path
jbedard@apple.com [Tue, 4 Feb 2020 22:05:35 +0000 (22:05 +0000)]
TestWebKitAPI: Handle case where test result does not contain path
https://bugs.webkit.org/show_bug.cgi?id=207216

Reviewed by Tim Horton.

* TestWebKitAPI/TestsController.cpp:
(TestWebKitAPI::Printer::OnTestPartResult): It's possible that the TestPartResult
will not contain a file name. We should handle this case.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoresults.webkit.org: Better order upload callbacks
jbedard@apple.com [Tue, 4 Feb 2020 22:02:08 +0000 (22:02 +0000)]
results.webkit.org: Better order upload callbacks
https://bugs.webkit.org/show_bug.cgi?id=207219

Reviewed by Aakash Jain.

Order upload callbacks more deliberately so that the quickest callbacks
that are least likely to link to information from unfinished callbacks are
executed first.

* resultsdbpy/resultsdbpy/model/model.py:
(Model.__init__): Generate buildbot links first, then generate a failure
list, then generate the collective suite results and finally, individual
test results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoTighten up stylesheet loading
commit-queue@webkit.org [Tue, 4 Feb 2020 21:42:07 +0000 (21:42 +0000)]
Tighten up stylesheet loading
https://bugs.webkit.org/show_bug.cgi?id=189913

Patch by Rob Buis <rbuis@igalia.com> on 2020-02-04
Reviewed by Antti Koivisto.

LayoutTests/imported/w3c:

Update improved test results.

* web-platform-tests/html/semantics/document-metadata/the-link-element/link-load-error-events-expected.txt:
* web-platform-tests/html/semantics/document-metadata/the-link-element/link-load-error-events.https-expected.txt:
* web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01-expected.txt:
* web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks-expected.txt:
* web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-quirks-expected.txt:

Source/WebCore:

Content-Type metadata for link stylesheet is determined using MIME
sniffing[1]. This can result in no Content-Type metadata.
If there is no Content-Type metadata, but the external resource link
type has a default type defined, then the user agent must assume that
the resource is of that type [2]. For link stylesheet the default is
text/css. This means invalid MIME type will default to text/css and
load and valid MIME types other than text/css will result in load error.

[1] https://mimesniff.spec.whatwg.org/
[2] https://html.spec.whatwg.org/multipage/semantics.html#fetch-and-process-the-linked-resource

Tests: imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-load-error-events.html
       imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-load-error-events.https.html
       imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-01.html
       imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-limited-quirks.html
       imported/w3c/web-platform-tests/html/semantics/document-metadata/the-link-element/link-style-error-quirks.html

* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::parseAuthorStyleSheet):
* css/StyleSheetContents.h:
* html/HTMLLinkElement.cpp:
(WebCore::HTMLLinkElement::setCSSStyleSheet):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::canUseSheet const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk2 ] webgpu/whlsl/zero-initialize-values-2.html is a flaky failure
ryanhaddad@apple.com [Tue, 4 Feb 2020 21:39:46 +0000 (21:39 +0000)]
[ macOS wk2 ] webgpu/whlsl/zero-initialize-values-2.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=207222

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-04

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[macCatalyst] Missing custom cursors in subframes that are offset from the origin...
wenson_hsieh@apple.com [Tue, 4 Feb 2020 21:35:36 +0000 (21:35 +0000)]
[macCatalyst] Missing custom cursors in subframes that are offset from the origin of the root view
https://bugs.webkit.org/show_bug.cgi?id=207215
<rdar://problem/59157625>

Reviewed by Tim Horton.

<https://trac.webkit.org/r255046> added support for custom cursor styles when hovering over subframes. However,
we currently try to hit-test content in the subframe using the interaction information request's point, which is
in root view coordinates; as such, we only get the correct custom cursor styles when hovering over elements in a
subframe, if the subframe is also at the origin of the root view.

To fix this, simply convert from root view coordinates to frame coordinates when performing the hit-test.
Unfortunately, this change is currently untestable; see <rdar://problem/59158410>.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::lineCaretExtent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoRegression: (252273) [ Mac wk2 ] inspector/heap/getPreview.html is flaky failing.
tsavell@apple.com [Tue, 4 Feb 2020 20:01:42 +0000 (20:01 +0000)]
Regression: (252273) [ Mac wk2 ] inspector/heap/getPreview.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207209

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-04

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoQuantifiers after lookahead assertions should be syntax errors in Unicode patterns...
shvaikalesh@gmail.com [Tue, 4 Feb 2020 19:45:21 +0000 (19:45 +0000)]
Quantifiers after lookahead assertions should be syntax errors in Unicode patterns only
https://bugs.webkit.org/show_bug.cgi?id=206988

Reviewed by Darin Adler and Ross Kirsling.

JSTests:

* test262/expectations.yaml: Mark 10 test cases as passing.

Source/JavaScriptCore:

This change adds SyntaxError for quantifiable assertions in Unicode patterns,
aligning JSC with V8 and SpiderMonkey.

Grammar: https://tc39.es/ecma262/#prod-annexB-Term
(/u flag precludes the use of QuantifiableAssertion)

Return value of parseParenthesesEnd() now matches with parseEscape() and
parseAtomEscape().

* yarr/YarrParser.h:
(JSC::Yarr::Parser::parseParenthesesBegin):
(JSC::Yarr::Parser::parseParenthesesEnd):
(JSC::Yarr::Parser::parseTokens):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoFixed Deprecated API
megan_gardner@apple.com [Tue, 4 Feb 2020 19:06:25 +0000 (19:06 +0000)]
Fixed Deprecated API
https://bugs.webkit.org/show_bug.cgi?id=207179

Reviewed by Tim Horton.

Fixing deprecated API for MacCatalyst.

No new tests - build fix.

* Shared/UserInterfaceIdiom.mm:
(WebKit::userInterfaceIdiomIsPad):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[JSC] Introduce UnlinkedCodeBlockGenerator and reduce sizeof(UnlinkedCodeBlock)
ysuzuki@apple.com [Tue, 4 Feb 2020 19:05:17 +0000 (19:05 +0000)]
[JSC] Introduce UnlinkedCodeBlockGenerator and reduce sizeof(UnlinkedCodeBlock)
https://bugs.webkit.org/show_bug.cgi?id=207087

Reviewed by Tadeu Zagallo.

Source/JavaScriptCore:

While UnlinkedCodeBlock is immutable once it is created from BytecodeGenerator, it has many mutable Vectors.
This is because we are using UnlinkedCodeBlock as a builder of UnlinkedCodeBlock itself too in BytecodeGenerator.
Since Vector takes 16 bytes to allow efficient expansions, it is nice if we can use RefCountedArray instead when
we know this Vector is immutable.

In this patch, we introduce UnlinkedCodeBlockGenerator wrapper. BytecodeGenerator, BytecodeRewriter, BytecodeDumper,
and BytecodeGeneratorification interact with UnlinkedCodeBlockGenerator instead of UnlinkedCodeBlock. And UnlinkedCodeBlockGenerator
will generate the finalized UnlinkedCodeBlock. This design allows us to use RefCountedArray for data in UnlinkedCodeBlock,
which is (1) smaller and (2) doing shrinkToFit operation when creating it from Vector.

This patch reduces sizeof(UnlinkedCodeBlock) from 256 to 168, 88 bytes reduction.

* JavaScriptCore.xcodeproj/project.pbxproj:
* Sources.txt:
* bytecode/BytecodeBasicBlock.cpp:
(JSC::BytecodeBasicBlock::compute):
* bytecode/BytecodeBasicBlock.h:
* bytecode/BytecodeDumper.cpp:
* bytecode/BytecodeGeneratorification.cpp:
(JSC::BytecodeGeneratorification::BytecodeGeneratorification):
(JSC::GeneratorLivenessAnalysis::run):
(JSC::BytecodeGeneratorification::run):
(JSC::performGeneratorification):
* bytecode/BytecodeGeneratorification.h:
* bytecode/BytecodeRewriter.h:
(JSC::BytecodeRewriter::BytecodeRewriter):
* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finishCreation):
(JSC::CodeBlock::setConstantIdentifierSetRegisters):
(JSC::CodeBlock::setConstantRegisters):
(JSC::CodeBlock::handlerForIndex):
(JSC::CodeBlock::insertBasicBlockBoundariesForControlFlowProfiler):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::numberOfSwitchJumpTables const):
(JSC::CodeBlock::numberOfStringSwitchJumpTables const):
(JSC::CodeBlock::addSwitchJumpTable): Deleted.
(JSC::CodeBlock::addStringSwitchJumpTable): Deleted.
* bytecode/HandlerInfo.h:
(JSC::HandlerInfoBase::handlerForIndex):
* bytecode/JumpTable.h:
(JSC::SimpleJumpTable::add): Deleted.
* bytecode/PreciseJumpTargets.cpp:
(JSC::computePreciseJumpTargets):
(JSC::recomputePreciseJumpTargets):
(JSC::findJumpTargetsForInstruction):
* bytecode/PreciseJumpTargets.h:
* bytecode/UnlinkedCodeBlock.cpp:
(JSC::UnlinkedCodeBlock::UnlinkedCodeBlock):
(JSC::UnlinkedCodeBlock::visitChildren):
(JSC::UnlinkedCodeBlock::dumpExpressionRangeInfo):
(JSC::UnlinkedCodeBlock::expressionRangeForBytecodeIndex const):
(JSC::UnlinkedCodeBlock::handlerForIndex):
(JSC::UnlinkedCodeBlock::addExpressionInfo): Deleted.
(JSC::UnlinkedCodeBlock::addTypeProfilerExpressionInfo): Deleted.
(JSC::UnlinkedCodeBlock::setInstructions): Deleted.
(JSC::UnlinkedCodeBlock::applyModification): Deleted.
(JSC::UnlinkedCodeBlock::shrinkToFit): Deleted.
(JSC::UnlinkedCodeBlock::addOutOfLineJumpTarget): Deleted.
* bytecode/UnlinkedCodeBlock.h:
(JSC::UnlinkedCodeBlock::expressionInfo):
(JSC::UnlinkedCodeBlock::setNumParameters):
(JSC::UnlinkedCodeBlock::numberOfIdentifiers const):
(JSC::UnlinkedCodeBlock::identifiers const):
(JSC::UnlinkedCodeBlock::bitVector):
(JSC::UnlinkedCodeBlock::constantRegisters):
(JSC::UnlinkedCodeBlock::constantsSourceCodeRepresentation):
(JSC::UnlinkedCodeBlock::constantIdentifierSets):
(JSC::UnlinkedCodeBlock::numberOfJumpTargets const):
(JSC::UnlinkedCodeBlock::numberOfSwitchJumpTables const):
(JSC::UnlinkedCodeBlock::numberOfStringSwitchJumpTables const):
(JSC::UnlinkedCodeBlock::numberOfFunctionDecls):
(JSC::UnlinkedCodeBlock::numberOfExceptionHandlers const):
(JSC::UnlinkedCodeBlock::opProfileControlFlowBytecodeOffsets const):
(JSC::UnlinkedCodeBlock::createRareDataIfNecessary):
(JSC::UnlinkedCodeBlock::addParameter): Deleted.
(JSC::UnlinkedCodeBlock::addIdentifier): Deleted.
(JSC::UnlinkedCodeBlock::addBitVector): Deleted.
(JSC::UnlinkedCodeBlock::addSetConstant): Deleted.
(JSC::UnlinkedCodeBlock::addConstant): Deleted.
(JSC::UnlinkedCodeBlock::addJumpTarget): Deleted.
(JSC::UnlinkedCodeBlock::addSwitchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::addStringSwitchJumpTable): Deleted.
(JSC::UnlinkedCodeBlock::addFunctionDecl): Deleted.
(JSC::UnlinkedCodeBlock::addFunctionExpr): Deleted.
(JSC::UnlinkedCodeBlock::addExceptionHandler): Deleted.
(JSC::UnlinkedCodeBlock::addOpProfileControlFlowBytecodeOffset): Deleted.
(JSC::UnlinkedCodeBlock::replaceOutOfLineJumpTargets): Deleted.
* bytecode/UnlinkedCodeBlockGenerator.cpp: Added.
(JSC::UnlinkedCodeBlockGenerator::getLineAndColumn const):
(JSC::UnlinkedCodeBlockGenerator::addExpressionInfo):
(JSC::UnlinkedCodeBlockGenerator::addTypeProfilerExpressionInfo):
(JSC::UnlinkedCodeBlockGenerator::finalize):
(JSC::UnlinkedCodeBlockGenerator::handlerForBytecodeIndex):
(JSC::UnlinkedCodeBlockGenerator::handlerForIndex):
(JSC::UnlinkedCodeBlockGenerator::applyModification):
(JSC::UnlinkedCodeBlockGenerator::addOutOfLineJumpTarget):
(JSC::UnlinkedCodeBlockGenerator::outOfLineJumpOffset):
(JSC::UnlinkedCodeBlockGenerator::dump const):
* bytecode/UnlinkedCodeBlockGenerator.h: Added.
(JSC::UnlinkedCodeBlockGenerator::UnlinkedCodeBlockGenerator):
(JSC::UnlinkedCodeBlockGenerator::vm):
(JSC::UnlinkedCodeBlockGenerator::isConstructor const):
(JSC::UnlinkedCodeBlockGenerator::constructorKind const):
(JSC::UnlinkedCodeBlockGenerator::superBinding const):
(JSC::UnlinkedCodeBlockGenerator::scriptMode const):
(JSC::UnlinkedCodeBlockGenerator::needsClassFieldInitializer const):
(JSC::UnlinkedCodeBlockGenerator::isStrictMode const):
(JSC::UnlinkedCodeBlockGenerator::usesEval const):
(JSC::UnlinkedCodeBlockGenerator::parseMode const):
(JSC::UnlinkedCodeBlockGenerator::isArrowFunction):
(JSC::UnlinkedCodeBlockGenerator::derivedContextType const):
(JSC::UnlinkedCodeBlockGenerator::evalContextType const):
(JSC::UnlinkedCodeBlockGenerator::isArrowFunctionContext const):
(JSC::UnlinkedCodeBlockGenerator::isClassContext const):
(JSC::UnlinkedCodeBlockGenerator::numCalleeLocals const):
(JSC::UnlinkedCodeBlockGenerator::numVars const):
(JSC::UnlinkedCodeBlockGenerator::numParameters const):
(JSC::UnlinkedCodeBlockGenerator::thisRegister const):
(JSC::UnlinkedCodeBlockGenerator::scopeRegister const):
(JSC::UnlinkedCodeBlockGenerator::wasCompiledWithDebuggingOpcodes const):
(JSC::UnlinkedCodeBlockGenerator::hasCheckpoints const):
(JSC::UnlinkedCodeBlockGenerator::hasTailCalls const):
(JSC::UnlinkedCodeBlockGenerator::setHasCheckpoints):
(JSC::UnlinkedCodeBlockGenerator::setHasTailCalls):
(JSC::UnlinkedCodeBlockGenerator::setNumCalleeLocals):
(JSC::UnlinkedCodeBlockGenerator::setNumVars):
(JSC::UnlinkedCodeBlockGenerator::setThisRegister):
(JSC::UnlinkedCodeBlockGenerator::setScopeRegister):
(JSC::UnlinkedCodeBlockGenerator::setNumParameters):
(JSC::UnlinkedCodeBlockGenerator::metadata):
(JSC::UnlinkedCodeBlockGenerator::addOpProfileControlFlowBytecodeOffset):
(JSC::UnlinkedCodeBlockGenerator::numberOfJumpTargets const):
(JSC::UnlinkedCodeBlockGenerator::addJumpTarget):
(JSC::UnlinkedCodeBlockGenerator::jumpTarget const):
(JSC::UnlinkedCodeBlockGenerator::lastJumpTarget const):
(JSC::UnlinkedCodeBlockGenerator::numberOfSwitchJumpTables const):
(JSC::UnlinkedCodeBlockGenerator::addSwitchJumpTable):
(JSC::UnlinkedCodeBlockGenerator::switchJumpTable):
(JSC::UnlinkedCodeBlockGenerator::numberOfStringSwitchJumpTables const):
(JSC::UnlinkedCodeBlockGenerator::addStringSwitchJumpTable):
(JSC::UnlinkedCodeBlockGenerator::stringSwitchJumpTable):
(JSC::UnlinkedCodeBlockGenerator::numberOfExceptionHandlers const):
(JSC::UnlinkedCodeBlockGenerator::exceptionHandler):
(JSC::UnlinkedCodeBlockGenerator::addExceptionHandler):
(JSC::UnlinkedCodeBlockGenerator::bitVector):
(JSC::UnlinkedCodeBlockGenerator::addBitVector):
(JSC::UnlinkedCodeBlockGenerator::numberOfConstantIdentifierSets const):
(JSC::UnlinkedCodeBlockGenerator::constantIdentifierSets):
(JSC::UnlinkedCodeBlockGenerator::addSetConstant):
(JSC::UnlinkedCodeBlockGenerator::constantRegister const):
(JSC::UnlinkedCodeBlockGenerator::constantRegisters):
(JSC::UnlinkedCodeBlockGenerator::getConstant const):
(JSC::UnlinkedCodeBlockGenerator::constantsSourceCodeRepresentation):
(JSC::UnlinkedCodeBlockGenerator::addConstant):
(JSC::UnlinkedCodeBlockGenerator::addFunctionDecl):
(JSC::UnlinkedCodeBlockGenerator::addFunctionExpr):
(JSC::UnlinkedCodeBlockGenerator::numberOfIdentifiers const):
(JSC::UnlinkedCodeBlockGenerator::identifier const):
(JSC::UnlinkedCodeBlockGenerator::addIdentifier):
(JSC::UnlinkedCodeBlockGenerator::outOfLineJumpOffset):
(JSC::UnlinkedCodeBlockGenerator::replaceOutOfLineJumpTargets):
(JSC::UnlinkedCodeBlockGenerator::metadataSizeInBytes):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::generate):
(JSC::BytecodeGenerator::BytecodeGenerator):
(JSC::BytecodeGenerator::initializeNextParameter):
(JSC::BytecodeGenerator::emitPushFunctionNameScope):
(JSC::prepareJumpTableForSwitch):
(JSC::ForInContext::finalize):
(JSC::StructureForInContext::finalize):
(JSC::IndexedForInContext::finalize):
* bytecompiler/BytecodeGenerator.h:
* bytecompiler/BytecodeGeneratorBaseInlines.h:
(JSC::BytecodeGeneratorBase<Traits>::newRegister):
(JSC::BytecodeGeneratorBase<Traits>::addVar):
* runtime/CachedTypes.cpp:
(JSC::CachedVector::encode):
(JSC::CachedVector::decode const):
* wasm/WasmFunctionCodeBlock.h:
(JSC::Wasm::FunctionCodeBlock::setNumVars):
(JSC::Wasm::FunctionCodeBlock::setNumCalleeLocals):

Source/WTF:

Add more useful methods for RefCountedArray.

* wtf/RefCountedArray.h:
(WTF::RefCountedArray::operator=):
(WTF::RefCountedArray::isEmpty const):
(WTF::RefCountedArray::front):
(WTF::RefCountedArray::front const):
(WTF::RefCountedArray::last):
(WTF::RefCountedArray::last const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[EWS] Do not remove TestWebKitAPI prefix from api test failures
aakash_jain@apple.com [Tue, 4 Feb 2020 19:01:40 +0000 (19:01 +0000)]
[EWS] Do not remove TestWebKitAPI prefix from api test failures
https://bugs.webkit.org/show_bug.cgi?id=207210

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(AnalyzeAPITestsResults.analyzeResults):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[PlayStation] Add WebKit API files
don.olmstead@sony.com [Tue, 4 Feb 2020 18:43:38 +0000 (18:43 +0000)]
[PlayStation] Add WebKit API files
https://bugs.webkit.org/show_bug.cgi?id=207168

Reviewed by Darin Adler.

Add PlayStation WebKit API files and expose them in the root header. Fix up the
build to copy them over. Also make sure that the playstation directory is listed
as a platform in the forwarding headers script.

* PlatformPlayStation.cmake:
* Scripts/generate-forwarding-headers.pl:
* Shared/API/c/WKBase.h:
* Shared/API/c/playstation/WKBasePlayStation.h: Added.
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/playstation/WKAPICastPlayStation.h: Added.
* UIProcess/API/C/playstation/WKView.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[EWS] Do not remove webkitpy prefix from test failures
aakash_jain@apple.com [Tue, 4 Feb 2020 18:21:34 +0000 (18:21 +0000)]
[EWS] Do not remove webkitpy prefix from test failures
https://bugs.webkit.org/show_bug.cgi?id=207206

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/steps.py:
(WebKitPyTest.getResultSummary): Do not remove 'webkitpy' from test name. Also handled the
case when json output doesn't have failures/errors key.
* BuildSlaveSupport/ews-build/steps_unittest.py: Added unit-tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk2 ] inspector/canvas/shaderProgram-add-remove-webgl2.html is flaky crashing
tsavell@apple.com [Tue, 4 Feb 2020 17:47:26 +0000 (17:47 +0000)]
[ macOS wk2 ] inspector/canvas/shaderProgram-add-remove-webgl2.html is flaky crashing
https://bugs.webkit.org/show_bug.cgi?id=206718

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-04

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ Mac wk2 ] webgpu/whlsl/textures-sample-grad.html is flaky failing.
tsavell@apple.com [Tue, 4 Feb 2020 17:02:09 +0000 (17:02 +0000)]
[ Mac wk2 ] webgpu/whlsl/textures-sample-grad.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207202

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-04

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoNetworkProcess should be notified by UIProcess when its service worker process connec...
youenn@apple.com [Tue, 4 Feb 2020 17:02:06 +0000 (17:02 +0000)]
NetworkProcess should be notified by UIProcess when its service worker process connection should be on
https://bugs.webkit.org/show_bug.cgi?id=207122
<rdar://problem/59089780>

Reviewed by Chris Dumez.

Source/WebCore:

Add a completion handler to the create context connection callback.
This is called when the context connection should have been created.
In case there is a context connection, completion handler does nothing.
Otherwise, SWServer will retry creating a context connection if needed.

The pending connection map entry is now removed in the completion handler instead of addContextConnection.
This ensures that only one connection request is sent by network process at a time.

Add extra logging to monitor creation of a context connection.

* workers/service/context/SWContextManager.h:
* workers/service/server/SWServer.cpp:
(WebCore::SWServer::addContextConnection):
(WebCore::SWServer::removeContextConnection):
(WebCore::SWServer::createContextConnectionFinished):
* workers/service/server/SWServer.h:

Source/WebKit:

Add completion handlers to the messaging from NetworkProcess -> UIProcess -> WebProcess -> NetworkProcess
used to create a service worker context connection.

This allows NetworkProcess to ask again for a connection if the connection is still needed but NetworkProcess did not find the context connection.

This is difficult to test since we would need for the process selected to host service workers to exit between the
time it is selected and the time it sends the message to Networking process.

To ensure that the context connection is created by WebProcess, WebProcessProxy takes a background assertion until WebProcess finishes
creating the context connection to Network process.

* NetworkProcess/NetworkConnectionToWebProcess.cpp:
(WebKit::NetworkConnectionToWebProcess::establishSWContextConnection):
* NetworkProcess/NetworkConnectionToWebProcess.h:
* NetworkProcess/NetworkConnectionToWebProcess.messages.in:
* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::swServerForSession):
* NetworkProcess/NetworkProcess.h:
* UIProcess/Network/NetworkProcessProxy.cpp:
(WebKit::NetworkProcessProxy::establishWorkerContextConnectionToNetworkProcess):
* UIProcess/Network/NetworkProcessProxy.h:
* UIProcess/Network/NetworkProcessProxy.messages.in:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::establishWorkerContextConnectionToNetworkProcess):
* UIProcess/WebProcessPool.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::establishServiceWorkerContext):
* UIProcess/WebProcessProxy.h:
* WebProcess/Storage/WebSWContextManagerConnection.cpp:
(WebKit::m_userAgent):
(WebKit::WebSWContextManagerConnection::establishConnection):
* WebProcess/Storage/WebSWContextManagerConnection.h:
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::establishWorkerContextConnectionToNetworkProcess):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoCheck for callback being null in Notification.requestPermission
youenn@apple.com [Tue, 4 Feb 2020 16:55:15 +0000 (16:55 +0000)]
Check for callback being null in Notification.requestPermission
https://bugs.webkit.org/show_bug.cgi?id=207192
<rdar://problem/59130804>

Reviewed by Chris Dumez.

Source/WebCore:

Covered by updated test.

* Modules/notifications/Notification.cpp:
(WebCore::Notification::requestPermission):
Callback can be null if no function is given to requestPermission.
Check this before calling the callback.

LayoutTests:

* http/tests/notifications/notification-in-non-secure-context.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed, follow-up assertion fix after r255662.
cdumez@apple.com [Tue, 4 Feb 2020 16:29:47 +0000 (16:29 +0000)]
Unreviewed, follow-up assertion fix after r255662.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ Mac wk2 ] webgpu/whlsl/while-loop-continue.html flaky failing.
tsavell@apple.com [Tue, 4 Feb 2020 16:26:26 +0000 (16:26 +0000)]
[ Mac wk2 ] webgpu/whlsl/while-loop-continue.html flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207200

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-04

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoREGRESSION(r255595): page not closed after beforeunload handler returns true
cdumez@apple.com [Tue, 4 Feb 2020 16:17:39 +0000 (16:17 +0000)]
REGRESSION(r255595): page not closed after beforeunload handler returns true
https://bugs.webkit.org/show_bug.cgi?id=207189

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2020-02-04
Reviewed by Chris Dumez.

We are assuming the try close did timeout in that case, because the timer is stopped before running the
beforeunload dialog.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::runBeforeUnloadConfirmPanel): Start the try close timer again when the beforeunload
dialog replies.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoRegression: (252334?) [ iOS wk2 ] http/tests/resourceLoadStatistics/cookie-deletion...
tsavell@apple.com [Tue, 4 Feb 2020 16:09:01 +0000 (16:09 +0000)]
Regression: (252334?) [ iOS wk2 ] http/tests/resourceLoadStatistics/cookie-deletion.html is flaky failing and crashing.
https://bugs.webkit.org/show_bug.cgi?id=207197

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-04

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoWeb Inspector: REGRESSION(r248287): Console: function objects saved to a $n will...
drousso@apple.com [Tue, 4 Feb 2020 15:59:42 +0000 (15:59 +0000)]
Web Inspector: REGRESSION(r248287): Console: function objects saved to a $n will be invoked instead of just referenced when evaluating in the Console
https://bugs.webkit.org/show_bug.cgi?id=207180
<rdar://problem/58860268>

Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

* inspector/InjectedScriptSource.js:
(CommandLineAPI):
Instead of deciding whether to wrap the value given for a `$n` getter based on if the value
is already a function, always wrap getter values in a function so that if the value being
stored in the getter is already a function, it isn't used as the callback for the getter and
therefore invoked when the getter is referenced.

LayoutTests:

* inspector/runtime/saveResult.html:
* inspector/runtime/saveResult-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk2 ] webgpu/whlsl/loops.html is flaky failing
tsavell@apple.com [Tue, 4 Feb 2020 15:56:36 +0000 (15:56 +0000)]
[ macOS wk2 ] webgpu/whlsl/loops.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207199

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-04

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoBuild error with -DENABLE_VIDEO=OFF after r253923
psaavedra@igalia.com [Tue, 4 Feb 2020 15:48:32 +0000 (15:48 +0000)]
Build error with -DENABLE_VIDEO=OFF after r253923
https://bugs.webkit.org/show_bug.cgi?id=207101

Reviewed by Youenn Fablet.

No new tests, only build error fix up

* page/Page.cpp:
(WebCore::Page::forEachMediaElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoRegression: (252234?) [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html...
tsavell@apple.com [Tue, 4 Feb 2020 15:42:04 +0000 (15:42 +0000)]
Regression: (252234?) [ iOS wk2 ] fast/scrolling/ios/scroll-events-back-forward.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207194

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-04

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoCSS Rules with the same selector from several large stylesheets are applied in the...
antti@apple.com [Tue, 4 Feb 2020 15:30:53 +0000 (15:30 +0000)]
CSS Rules with the same selector from several large stylesheets are applied in the wrong order
https://bugs.webkit.org/show_bug.cgi?id=204687
<rdar://problem/57522566>

Reviewed by Zalan Bujtas.

Source/WebCore:

Original test by Anton Khlynovskiy.

Test: fast/css/many-rules.html

* style/RuleData.h:

We overflow the 18 bit m_position field with > 256k CSS rules, confusing the rule order.
Since we have unused bits it costs nothing to increase the field size to 22 bits.

4M rules should be enough for anybody.

LayoutTests:

* TestExpectations:
* fast/css/many-rules-expected.html: Added.
* fast/css/many-rules.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[CMake] Add Cairo::Cairo target
ross.kirsling@sony.com [Tue, 4 Feb 2020 13:52:03 +0000 (13:52 +0000)]
[CMake] Add Cairo::Cairo target
https://bugs.webkit.org/show_bug.cgi?id=207159

Reviewed by Konstantin Tokarev.

.:

* Source/cmake/FindCairo.cmake:
* Source/cmake/OptionsPlayStation.cmake:

Source/WebCore:

* PlatformWinCairo.cmake:
* platform/Cairo.cmake:

Source/WebKit:

* PlatformGTK.cmake:
* PlatformWPE.cmake:
* PlatformWin.cmake:

Source/WebKitLegacy:

* PlatformWin.cmake:

Tools:

* DumpRenderTree/PlatformWin.cmake:
* ImageDiff/Cairo.cmake:
* TestWebKitAPI/PlatformWPE.cmake:
* TestWebKitAPI/PlatformWin.cmake:
* TestWebKitAPI/glib/CMakeLists.txt:
* WebKitTestRunner/PlatformGTK.cmake:
* WebKitTestRunner/PlatformWPE.cmake:
* WebKitTestRunner/PlatformWin.cmake:
* wpe/backends/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoMediaDevices should handle changes of iframe allow attribute value
youenn@apple.com [Tue, 4 Feb 2020 10:57:44 +0000 (10:57 +0000)]
MediaDevices should handle changes of iframe allow attribute value
https://bugs.webkit.org/show_bug.cgi?id=207112

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

* web-platform-tests/mediacapture-streams/MediaStream-default-feature-policy.https-expected.txt:
* web-platform-tests/mediacapture-streams/MediaStream-feature-policy-none.https-expected.txt:

Source/WebCore:

MediaDevices was computing whether it could access camera or microphone at creation time.
Since the iframe allow attribute can be modified, we cannot do that.
Instead, we get the feature policy everytime this is needed.

Refactor code to use the newly added routine to check for feature policy.
Update logging to give origin and allow attribute value of the frame that fail the feature policy check.

Test: http/tests/webrtc/enumerateDevicesInFrames.html

* Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::MediaDevices):
(WebCore::MediaDevices::refreshDevices):
(WebCore::MediaDevices::enumerateDevices):
(WebCore::MediaDevices::listenForDeviceChanges):
* Modules/mediastream/MediaDevices.h:
* Modules/mediastream/UserMediaController.cpp:
(WebCore::UserMediaController::logGetUserMediaDenial):
(WebCore::UserMediaController::logGetDisplayMediaDenial):
(WebCore::UserMediaController::logEnumerateDevicesDenial):
* Modules/mediastream/UserMediaController.h:
* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::start):
* html/FeaturePolicy.cpp:
(WebCore::policyTypeName):
(WebCore::isFeaturePolicyAllowedByDocumentAndAllOwners):
* html/FeaturePolicy.h:
* page/DOMWindow.cpp:
(WebCore::DOMWindow::printErrorMessage const):
* page/DOMWindow.h:

LayoutTests:

* TestExpectations:
* fullscreen/full-screen-enabled-expected.txt:
* fullscreen/full-screen-enabled-prefixed-expected.txt:
* fullscreen/full-screen-iframe-not-allowed-expected.txt:
* fullscreen/full-screen-iframe-without-allow-attribute-allowed-from-parent-expected.txt:
* fullscreen/full-screen-restrictions-expected.txt:
* http/tests/fullscreen/fullscreen-feature-policy-expected.txt:
* http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt:
* http/tests/media/media-stream/get-display-media-iframe-allow-attribute-expected.txt:
* http/tests/ssl/media-stream/get-user-media-different-host-expected.txt:
* http/tests/ssl/media-stream/get-user-media-nested-expected.txt:
* http/tests/webrtc/enumerateDevicesInFrames-expected.txt: Added.
* http/tests/webrtc/enumerateDevicesInFrames.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[Win][Clang] WebProcessMain.h(28,14): error: token is not a valid binary operator...
Hironori.Fujii@sony.com [Tue, 4 Feb 2020 08:28:09 +0000 (08:28 +0000)]
[Win][Clang] WebProcessMain.h(28,14): error: token is not a valid binary operator in a preprocessor subexpression
https://bugs.webkit.org/show_bug.cgi?id=207188

Unreviewed build fix for WinCairo port.

* NetworkProcess/EntryPoint/win/NetworkProcessMain.cpp:
* WebProcess/EntryPoint/win/WebProcessMain.cpp:
Added #include "config.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[WinCairo][curl][Clang] error: member access into incomplete type 'WebCore::Synchrono...
Hironori.Fujii@sony.com [Tue, 4 Feb 2020 08:04:08 +0000 (08:04 +0000)]
[WinCairo][curl][Clang] error: member access into incomplete type 'WebCore::SynchronousLoaderMessageQueue' in ~CurlRequest
https://bugs.webkit.org/show_bug.cgi?id=207187

Unreviewed build fix for clang-cl builds of WinCairo port.

SynchronousLoaderMessageQueue couldn't be destructed in inlined
~CurlRequest because it's a incomplete type. Moved the dtor from
CurlRequest.h to CurlRequest.cpp.

* platform/network/curl/CurlRequest.cpp:
* platform/network/curl/CurlRequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdd a WebKitAdditions hook to provide additional customizations to UIDragInteraction
wenson_hsieh@apple.com [Tue, 4 Feb 2020 06:04:12 +0000 (06:04 +0000)]
Add a WebKitAdditions hook to provide additional customizations to UIDragInteraction
https://bugs.webkit.org/show_bug.cgi?id=207177
<rdar://problem/59121266>

Reviewed by Tim Horton.

Add a WebKitAdditions extension point that runs immediately after setting up UIDragInteraction and
UIDropInteraction.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView setupDragAndDropInteractions]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAccelerated animations freeze on render tree rebuild
antti@apple.com [Tue, 4 Feb 2020 05:56:04 +0000 (05:56 +0000)]
Accelerated animations freeze on render tree rebuild
https://bugs.webkit.org/show_bug.cgi?id=201048
<rdar://problem/54612621>

Reviewed by Antoine Quint.

Source/WebCore:

If there is an accelerated animation in progress for a renderer and the render tree is rebuild the animation
does not continue with the new renderer.

To fix, make sure that the animation leaves the accelerated state when the renderer is removed. The new renderer
will then become accelerated automatically.

Original test case by Tim Guan-tin Chien.

Test: webanimations/accelerated-animation-renderer-change.html

* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::willChangeRendererForElement):
* animation/AnimationTimeline.h:
* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::willChangeRenderer):
* animation/KeyframeEffect.h:
* animation/WebAnimation.cpp:
(WebCore::WebAnimation::willChangeRenderer):
* animation/WebAnimation.h:
* rendering/updating/RenderTreeUpdater.cpp:
(WebCore::RenderTreeUpdater::tearDownRenderers):

LayoutTests:

* webanimations/accelerated-animation-renderer-change-expected.html: Added.
* webanimations/accelerated-animation-renderer-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoStop relying on ResponsivenessTimer to keep the WebProcess from suspending during...
cdumez@apple.com [Tue, 4 Feb 2020 05:46:57 +0000 (05:46 +0000)]
Stop relying on ResponsivenessTimer to keep the WebProcess from suspending during initialization
https://bugs.webkit.org/show_bug.cgi?id=207144

Reviewed by Brady Eidson.

Stop relying on ResponsivenessTimer to keep the WebProcess from suspending during initialization. Instead, make the
WebProcess::InitializeWebProcess IPC async with a reply and take a process assertion on behalf of the WebContent
process until we get a response back.

This avoids sending an extra WebProcess::MainThreadPing IPC to the WebProcess for no reason (since we're already
sending the WebProcess::InitializeWebProcess IPC) and this is also more reliable since the ResponsivenessTimer can
actually time out and cause the process to get suspended during initialization still.

* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::initializeNewWebProcess):
* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::initializeWebProcess):
* WebProcess/WebProcess.h:
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[WebAccessibilityObjectWrapper detach] should detach either the wrapped AXObject...
andresg_22@apple.com [Tue, 4 Feb 2020 05:37:30 +0000 (05:37 +0000)]
[WebAccessibilityObjectWrapper detach] should detach either the wrapped AXObject or the IsolatedObject but not both.
https://bugs.webkit.org/show_bug.cgi?id=207178

Reviewed by Chris Fleizach.

Detach either the AXObject or the IsolatedObject depending on the thread that the method is invoed on.

* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase detachAXObject]):
(-[WebAccessibilityObjectWrapperBase detachIsolatedObject]):
(-[WebAccessibilityObjectWrapperBase detach]): Detach one or the other depending on the thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoPass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
jiewen_tan@apple.com [Tue, 4 Feb 2020 05:29:51 +0000 (05:29 +0000)]
Pass a hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy
https://bugs.webkit.org/show_bug.cgi?id=207079
<rdar://problem/48290464>

Reviewed by Brent Fulgham.

Source/WebCore/PAL:

* pal/cocoa/AppSSOSoftLink.h:
* pal/cocoa/AppSSOSoftLink.mm:
* pal/spi/cocoa/AppSSOSPI.h:
Adds macros for classes that are used in the tests.

Source/WebKit:

Pass a localized human readable hint from the extension to decidePolicyForSOAuthorizationLoadWithCurrentPolicy,
such that clients can display it to tell users what the extension is trying to do. Hints could be something
like "Sign In With Apple".

Covered new test contents within existing tests.

* UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.h:
* UIProcess/Cocoa/SOAuthorization/SOAuthorizationSession.mm:
(WebKit::SOAuthorizationSession::start):
(WebKit::SOAuthorizationSession::continueStartAfterGetAuthorizationHints):
(WebKit::SOAuthorizationSession::continueStartAfterDecidePolicy):

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/TestSOAuthorization.mm:
(-[TestSOAuthorizationDelegate _webView:decidePolicyForSOAuthorizationLoadWithCurrentPolicy:forExtension:completionHandler:]):
(overrideGetAuthorizationHintsWithURL):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[JSC] Use PackedPtr for VariableEnvironment
ysuzuki@apple.com [Tue, 4 Feb 2020 04:22:29 +0000 (04:22 +0000)]
[JSC] Use PackedPtr for VariableEnvironment
https://bugs.webkit.org/show_bug.cgi?id=207172

Reviewed by Mark Lam.

Since VariableEnvironment's KeyValue is key: pointer + value: 2 byte, using PackedPtr can make it 8 bytes, 50% reduction.

* parser/VariableEnvironment.h:
* runtime/CachedTypes.cpp:
(JSC::CachedRefPtr::encode):
(JSC::CachedRefPtr::decode const): CachedTypes should handle PackedPtr too since VariableEnvironment starts using it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed, fix the internal build after <rdar://problem/59132944>
wenson_hsieh@apple.com [Tue, 4 Feb 2020 03:59:08 +0000 (03:59 +0000)]
Unreviewed, fix the internal build after <rdar://problem/59132944>

* UIProcess/ios/WKContentViewInteraction.h: Declare this helper in the header, now that it's consulted by some
WebKitAdditions code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoAdd a WebKitAdditions hook to override the behavior of -[WKContentView gestureRecogni...
wenson_hsieh@apple.com [Tue, 4 Feb 2020 01:51:21 +0000 (01:51 +0000)]
Add a WebKitAdditions hook to override the behavior of -[WKContentView gestureRecognizer:shouldReceiveTouch:]
https://bugs.webkit.org/show_bug.cgi?id=207162
<rdar://problem/59129739>

Reviewed by Tim Horton.

Allow an internal implementation of `-_allowGestureRecognizer:toReceiveTouch:` to prevent touches from being
routed to certain gesture recognizers, if necessary.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView gestureRecognizer:shouldReceiveTouch:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoresults.webkit.org: Support jsc stress tests
jbedard@apple.com [Tue, 4 Feb 2020 01:47:26 +0000 (01:47 +0000)]
results.webkit.org: Support jsc stress tests
https://bugs.webkit.org/show_bug.cgi?id=204096

Rubber-stamped by Aakash Jain.

* Scripts/run-javascriptcore-tests:
(runJSCStressTests): Add pass and failures to reported results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoMake Bugzilla._find_select_element_for_flag more robust
shvaikalesh@gmail.com [Tue, 4 Feb 2020 01:32:06 +0000 (01:32 +0000)]
Make Bugzilla._find_select_element_for_flag more robust
https://bugs.webkit.org/show_bug.cgi?id=207148

Reviewed by Jonathan Bedard.

This patch resolves two FIXMEs:
1. _find_select_element_for_flag() is now used in _fill_attachment_form() method.
2. _find_select_element_for_flag() now does not rely on order of <select> elements.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla._fill_attachment_form):
(Bugzilla._find_select_element_for_flag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] inspector/unit-tests/server-timing-entry.html is flaky timeout
tsavell@apple.com [Tue, 4 Feb 2020 01:03:06 +0000 (01:03 +0000)]
[ macOS wk1 ] inspector/unit-tests/server-timing-entry.html is flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=207167

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ Mac wk2 ] http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuproc...
tsavell@apple.com [Tue, 4 Feb 2020 01:00:24 +0000 (01:00 +0000)]
[ Mac wk2 ] http/wpt/mediarecorder/MediaRecorder-AV-audio-video-dataavailable-gpuprocess.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207166

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ Mac wk2 ] tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html...
tsavell@apple.com [Tue, 4 Feb 2020 00:50:11 +0000 (00:50 +0000)]
[ Mac wk2 ] tiled-drawing/scrolling/scroll-snap/scroll-snap-mandatory-padding.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207165

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoLayoutTest inspector/controller/runtime-controller-import.html is a flaky timeout
tsavell@apple.com [Tue, 4 Feb 2020 00:49:13 +0000 (00:49 +0000)]
LayoutTest inspector/controller/runtime-controller-import.html is a flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=168926

Updating because the test is also flaky failing.

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] inspector/heap/imported-snapshot.html is flaky timeout
ryanhaddad@apple.com [Tue, 4 Feb 2020 00:36:18 +0000 (00:36 +0000)]
[ macOS wk1 ] inspector/heap/imported-snapshot.html is flaky timeout
https://bugs.webkit.org/show_bug.cgi?id=207163

Updating to include an exclude for timeouts.

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[iOS wk2 Debug] legacy-animation-engine/animations/play-state-in-shorthand.html is...
tsavell@apple.com [Tue, 4 Feb 2020 00:34:56 +0000 (00:34 +0000)]
[iOS wk2 Debug] legacy-animation-engine/animations/play-state-in-shorthand.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207164

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoCrash in WebCore::IDBServer::IDBServer::createIndex
sihui_liu@apple.com [Tue, 4 Feb 2020 00:31:02 +0000 (00:31 +0000)]
Crash in WebCore::IDBServer::IDBServer::createIndex
https://bugs.webkit.org/show_bug.cgi?id=207137
<rdar://problem/59096231>

Reviewed by Darin Adler.

Source/WebCore:

Export IDBIndexInfo::isolatedCopy so it can be used in WebKitLegacy framework code.

* Modules/indexeddb/shared/IDBIndexInfo.h:

Source/WebKitLegacy:

* Storage/InProcessIDBServer.cpp:
(InProcessIDBServer::createIndex): Create an isolated copy of IDBIndexInfo before passing it to IDB thread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoRegression: (254414?) [ iOS wk2 ] imported/w3c/web-platform-tests/2dcontext/imagebitm...
tsavell@apple.com [Tue, 4 Feb 2020 00:28:44 +0000 (00:28 +0000)]
Regression: (254414?) [ iOS wk2 ] imported/w3c/web-platform-tests/2dcontext/imagebitmap/createImageBitmap-transfer.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207161

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] css2.1/20110323/replaced-intrinsic-ratio-001.htm is flaky failing
ryanhaddad@apple.com [Tue, 4 Feb 2020 00:15:03 +0000 (00:15 +0000)]
[ macOS wk1 ] css2.1/20110323/replaced-intrinsic-ratio-001.htm is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207160

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoREGRESSION: [ macOS wk1 ] inspector/debugger/tail-deleted-frames/tail-deleted-frames...
tsavell@apple.com [Mon, 3 Feb 2020 23:54:53 +0000 (23:54 +0000)]
REGRESSION: [ macOS wk1 ] inspector/debugger/tail-deleted-frames/tail-deleted-frames-scopes.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207157

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoReduce size of HashMap and HashSet
achristensen@apple.com [Mon, 3 Feb 2020 23:48:29 +0000 (23:48 +0000)]
Reduce size of HashMap and HashSet
https://bugs.webkit.org/show_bug.cgi?id=207138

Reviewed by Yusuke Suzuki.

Source/WTF:

This reduces sizeof(HashMap) and sizeof(HashSet) from 24 to 8 on 64-bit systems.
I measured that the overwhelming majority of HashMaps and HashSets never see more than 0 elements,
so I moved the table metadata (tableSize, tableSizeMask, keyCount, deletedCount) to inside the
dynamically allocated memory.  This makes another branch in size() for non-empty tables
and an additional read and write when rehashing in exchange for fewer writes in the constructor
and increased cache locality of everything that uses HashMap and HashSet, which is basically everything.

* wtf/HashTable.h:
(WTF::HashTable::~HashTable):
(WTF::HashTable::end):
(WTF::HashTable::end const):
(WTF::HashTable::random):
(WTF::HashTable::size const):
(WTF::HashTable::capacity const):
(WTF::HashTable::isEmpty const):
(WTF::HashTable::reserveInitialCapacity):
(WTF::HashTable::shouldExpand const):
(WTF::HashTable::mustRehashInPlace const):
(WTF::HashTable::shouldShrink const):
(WTF::HashTable::shrink):
(WTF::HashTable::makeIterator):
(WTF::HashTable::makeConstIterator const):
(WTF::HashTable::makeKnownGoodIterator):
(WTF::HashTable::makeKnownGoodConstIterator const):
(WTF::HashTable::tableSize const):
(WTF::HashTable::setTableSize const):
(WTF::HashTable::tableSizeMask const):
(WTF::HashTable::setTableSizeMask):
(WTF::HashTable::keyCount const):
(WTF::HashTable::setKeyCount const):
(WTF::HashTable::deletedCount const):
(WTF::HashTable::setDeletedCount const):
(WTF::KeyTraits>::HashTable):
(WTF::KeyTraits>::inlineLookup):
(WTF::KeyTraits>::lookupForWriting):
(WTF::KeyTraits>::fullLookupForWriting):
(WTF::KeyTraits>::addUniqueForInitialization):
(WTF::KeyTraits>::add):
(WTF::KeyTraits>::addPassingHashCode):
(WTF::KeyTraits>::remove):
(WTF::KeyTraits>::removeIf):
(WTF::KeyTraits>::allocateTable):
(WTF::KeyTraits>::deallocateTable):
(WTF::KeyTraits>::expand):
(WTF::KeyTraits>::shrinkToBestSize):
(WTF::KeyTraits>::deleteReleasedWeakBuckets):
(WTF::KeyTraits>::rehash):
(WTF::KeyTraits>::clear):
(WTF::KeyTraits>::swap):
(WTF::KeyTraits>::checkTableConsistencyExceptSize const):

Tools:

* TestWebKitAPI/Tests/WTF/HashMap.cpp:
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WTF/HashSet.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[WK2] Use per-UIProcess default cookie storage for Mac Catalyst apps
cdumez@apple.com [Mon, 3 Feb 2020 23:40:44 +0000 (23:40 +0000)]
[WK2] Use per-UIProcess default cookie storage for Mac Catalyst apps
https://bugs.webkit.org/show_bug.cgi?id=207139
<rdar://problem/59047014>

Reviewed by Brent Fulgham.

Use per-UIProcess default cookie storage for Mac Catalyst apps, similarly to what
we do for regular macOS apps.

* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode const):
(WebKit::NetworkProcessCreationParameters::decode):
* NetworkProcess/NetworkProcessCreationParameters.h:
* NetworkProcess/cocoa/NetworkProcessCocoa.mm:
(WebKit::NetworkProcess::platformInitializeNetworkProcessCocoa):
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::platformInitializeNetworkProcess):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed iOS build fix; lambdas need an arrow operator between the paramaters and...
jer.noble@apple.com [Mon, 3 Feb 2020 23:38:57 +0000 (23:38 +0000)]
Unreviewed iOS build fix; lambdas need an arrow operator between the paramaters and return type.

* page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ iOS wk2 Release ] http/tests/websocket/tests/hybi/workers/close.html is flaky failing.
ryanhaddad@apple.com [Mon, 3 Feb 2020 23:38:48 +0000 (23:38 +0000)]
[ iOS wk2 Release ] http/tests/websocket/tests/hybi/workers/close.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207156

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] inspector/canvas/recording-2d-full.html is flaky timing out
ryanhaddad@apple.com [Mon, 3 Feb 2020 23:33:09 +0000 (23:33 +0000)]
[ macOS wk1 ] inspector/canvas/recording-2d-full.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207154

Updating expectations for newer OS

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ iOS wk2 ] animations/animation-callback-timestamp.html is flaky failing.
ryanhaddad@apple.com [Mon, 3 Feb 2020 23:31:33 +0000 (23:31 +0000)]
[ iOS wk2 ] animations/animation-callback-timestamp.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207153

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/ios-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoobsolete_attachment should not fail when flags do not exist
shvaikalesh@gmail.com [Mon, 3 Feb 2020 23:31:31 +0000 (23:31 +0000)]
obsolete_attachment should not fail when flags do not exist
https://bugs.webkit.org/show_bug.cgi?id=171121

Reviewed by Jonathan Bedard.

Before this change, an error occured if a contributor without EditBugs privileges tried
to obsolete not their own attachment. With this patch, uploading routine continues with
friendly console warning like we have in reassign_bug() method.

* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla):
(Bugzilla.obsolete_attachment):
(Bugzilla.reassign_bug): Use NO_EDIT_BUGS_MESSAGE constant.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[iOS 13] Dragging on-screen volume control on a YouTube video selects text around...
wenson_hsieh@apple.com [Mon, 3 Feb 2020 23:09:19 +0000 (23:09 +0000)]
[iOS 13] Dragging on-screen volume control on a YouTube video selects text around the panel
https://bugs.webkit.org/show_bug.cgi?id=207140
<rdar://problem/58852938>

Reviewed by Tim Horton.

Source/WebKit:

This bug occurs on iPadOS when long pressing the volume controls on the desktop version of YouTube, and then
performing a pan gesture; this activates the highlight text selection gesture recognizer added in iOS 13,
causing text to be selected while adjusting the volume using these custom controls. On macOS, we avoid this
because `Node::canStartSelection()` returns `false`, due to a container node having both `user-drag: element`
and `user-select: none`; in this scenario, we allow dragging to take precendence over text selection, so the
volume slider can be moved using a mouse without simultaneously selecting text.

This logic is currently absent on iOS, where UIKit text interaction gesture recognizers ask us for information
about the DOM at given locations, and we determine whether to allow text interaction gestures (such as long
pressing) to begin in `-textInteractionGesture:shouldBeginAtPoint:` and `-hasSelectablePositionAtPoint:`.
Ideally, we'd want to eventually unify these two codepaths for triggering text selection (and preferably just
have both go through EventHandler); in lieu of this, simply make the iOS codepath behave a little more like
macOS by adding a bit to allow text interaction gestures to bail in the case where at least one container of the
hit-tested element is both draggable and unselectable.

Test: editing/selection/ios/prefer-drag-over-text-selection.html

* Shared/ios/InteractionInformationAtPosition.h:
* Shared/ios/InteractionInformationAtPosition.mm:
(WebKit::InteractionInformationAtPosition::encode const):
(WebKit::InteractionInformationAtPosition::decode):

Add the new bit to InteractionInformationAtPosition.

* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView textInteractionGesture:shouldBeginAtPoint:]):

Avoid beginning text selection if the bit is set.

* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::selectionPositionInformation):

Move a comment about the ">= 97% of the document's visible area" heuristic next to the relevant code, and also
leave a FIXME mentioning that we should reconsider whether this is really needed; it seems that this was
originally intended to avoid ending up with an excessively large block selection, but block selection has been
removed entirely since iOS 12. That said, this logic may still be helping avoid situations where the text
selection is too aggressive on iOS and ends up selecting too much text.

LayoutTests:

Add a layout test to verify that we don't allow text selection gestures inside of containers that have both
`user-drag: element` and `user-select: none`.

* editing/selection/ios/prefer-drag-over-text-selection-expected.txt: Added.
* editing/selection/ios/prefer-drag-over-text-selection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS iOS ] fast/dom/connected-subframe-counter-overflow.html is flaky timing out
tsavell@apple.com [Mon, 3 Feb 2020 23:04:20 +0000 (23:04 +0000)]
[ macOS iOS ] fast/dom/connected-subframe-counter-overflow.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207152

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/ios/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ Mac wk2 Release ] fast/dom/navigator-detached-no-crash.html flaky failing.
tsavell@apple.com [Mon, 3 Feb 2020 22:58:47 +0000 (22:58 +0000)]
[ Mac wk2 Release ] fast/dom/navigator-detached-no-crash.html flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207151

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is flaky...
tsavell@apple.com [Mon, 3 Feb 2020 22:52:34 +0000 (22:52 +0000)]
[ macOS wk1 ] platform/mac/webrtc/captureCanvas-webrtc-software-encoder.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207150

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ Mojave wk2 ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html...
tsavell@apple.com [Mon, 3 Feb 2020 22:45:36 +0000 (22:45 +0000)]
[ Mojave wk2 ] imported/w3c/web-platform-tests/webrtc/RTCDtlsTransport-state.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207149

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago [iOS] Layout Test animations/duplicate-keys.html is a flaky failure
tsavell@apple.com [Mon, 3 Feb 2020 22:44:11 +0000 (22:44 +0000)]
   [iOS] Layout Test animations/duplicate-keys.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=185332

Updating on macOS wk1 because the same failure is also seen there

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ Mac ] legacy-animation-engine/compositing/geometry/partial-layout-update.html is...
tsavell@apple.com [Mon, 3 Feb 2020 22:34:25 +0000 (22:34 +0000)]
[ Mac ] legacy-animation-engine/compositing/geometry/partial-layout-update.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207147

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] media/media-source/media-source-seek-redundant-append.html is flaky...
tsavell@apple.com [Mon, 3 Feb 2020 22:26:31 +0000 (22:26 +0000)]
[ macOS wk1 ] media/media-source/media-source-seek-redundant-append.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207146

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoRegression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling...
cdumez@apple.com [Mon, 3 Feb 2020 22:21:54 +0000 (22:21 +0000)]
Regression(r253224) WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView
https://bugs.webkit.org/show_bug.cgi?id=207121
<rdar://problem/58880177>

Reviewed by Alex Christensen.

Source/WebKit:

WKUIDelegate.webViewDidClose may get called twice after calling _tryClose on the WKWebView, in case we time out
while waiting for an answer from the WebProcess but the WebProcess eventually responds.

Change is covered by new API test.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::tryClose):

Tools:

Add API test coverage.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit/beforeunload-slow.html: Added.
* TestWebKitAPI/Tests/WebKitCocoa/ModalAlerts.mm:
(-[SlowBeforeUnloadHandlerUIDelegate _webView:runBeforeUnloadConfirmPanelWithMessage:initiatedByFrame:completionHandler:]):
(-[SlowBeforeUnloadHandlerUIDelegate webViewDidClose:]):
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ Mojave wk2 ] media/media-fragments/TC0087.html is flaky failing.
tsavell@apple.com [Mon, 3 Feb 2020 22:19:31 +0000 (22:19 +0000)]
[ Mojave wk2 ] media/media-fragments/TC0087.html is flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207143

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[Web Animations] Accelerated animations don't run until their natural completion
graouts@webkit.org [Mon, 3 Feb 2020 22:16:46 +0000 (22:16 +0000)]
[Web Animations] Accelerated animations don't run until their natural completion
https://bugs.webkit.org/show_bug.cgi?id=207130
<rdar://problem/59106047>

Reviewed by Dean Jackson.

Source/WebCore:

Tests: webanimations/transform-accelerated-animation-finishes-before-removal.html
       webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html

Ensure we don't tear down a composited renderer until all of its runnning accelerated animations are completed.
The accelerated animations will be queued for removal in the next animation frame.

* animation/KeyframeEffect.cpp:
(WebCore::KeyframeEffect::isRunningAcceleratedAnimationForProperty const):
* animation/KeyframeEffect.h:
* animation/KeyframeEffectStack.cpp:
(WebCore::KeyframeEffectStack::isCurrentlyAffectingProperty const):

LayoutTests:

Add two new tests that ensures that an accelerated animation still yields compositing on an element when
its finished promise is resolved, but that it's no longer the case on the next frame.

This required an existing test to be updated to wait until the next frame before checking the composited
status of an element on which an animation had just completed.

* compositing/geometry/limit-layer-bounds-opacity-transition.html:
* webanimations/transform-accelerated-animation-finishes-before-removal-expected.txt: Added.
* webanimations/transform-accelerated-animation-finishes-before-removal.html: Added.
* webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise-expected.txt: Added.
* webanimations/transform-accelerated-animation-removed-one-frame-after-finished-promise.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[iPad] Videos on nhl.com can't be scrubbed when loaded with desktop UA.
jer.noble@apple.com [Mon, 3 Feb 2020 22:15:20 +0000 (22:15 +0000)]
[iPad] Videos on nhl.com can't be scrubbed when loaded with desktop UA.
https://bugs.webkit.org/show_bug.cgi?id=207058

Reviewed by Darin Adler.

The video controls on nhl.com listen for mousedown/mousemove/mouseup events, not
touchstart/touchmove/touchend events. Until nhl.com can update their site to support touch
events, add them to the quirks list for simplated mouse events.

Drive-by fix: There's no need to re-parse the entire URL and walk through all the cases
every time shouldDispatchSimulatedMouseEvents() is called. Save the results of the initial
pass so that subsequent checks are just a simple bool check.

* page/Quirks.cpp:
(WebCore::Quirks::shouldDispatchSimulatedMouseEvents const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] inspector/canvas/recording-webgl-full.html is flaky timing out
tsavell@apple.com [Mon, 3 Feb 2020 22:13:57 +0000 (22:13 +0000)]
[ macOS wk1 ] inspector/canvas/recording-webgl-full.html  is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207145

Updating expectations

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[WebKitTestRunner] setOpenPanelFiles support in non-local tests
lmoura@igalia.com [Mon, 3 Feb 2020 21:54:54 +0000 (21:54 +0000)]
[WebKitTestRunner] setOpenPanelFiles support in non-local tests
https://bugs.webkit.org/show_bug.cgi?id=206517

Reviewed by Carlos Alberto Lopez Perez.

Tools:

* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setOpenPanelFiles): Use file:// if the passed path
starts with a leading slash instead of using the test URL, which could
cause input forms with invalid file data.

LayoutTests:

* platform/gtk/TestExpectations: Update expectations after fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoLayout Test svg/custom/object-sizing-explicit-width.xhtml is a flaky failure.
tsavell@apple.com [Mon, 3 Feb 2020 21:49:11 +0000 (21:49 +0000)]
Layout Test svg/custom/object-sizing-explicit-width.xhtml is a flaky failure.
https://bugs.webkit.org/show_bug.cgi?id=181058

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] media/modern-media-controls/compact-media-controls/compact-media-contro...
tsavell@apple.com [Mon, 3 Feb 2020 21:41:23 +0000 (21:41 +0000)]
[ macOS wk1 ] media/modern-media-controls/compact-media-controls/compact-media-controls-constructor.html is flaky failing (192974)
https://bugs.webkit.org/show_bug.cgi?id=192974

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ Mac ] requestidlecallback/requestidlecallback-is-called.html flaky failing.
tsavell@apple.com [Mon, 3 Feb 2020 21:39:49 +0000 (21:39 +0000)]
[ Mac ] requestidlecallback/requestidlecallback-is-called.html flaky failing.
https://bugs.webkit.org/show_bug.cgi?id=207142

Unreviewed test gardening.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoReplace the custom allocator in AudioArray::allocate() with fastAlignedMalloc().
jer.noble@apple.com [Mon, 3 Feb 2020 21:35:16 +0000 (21:35 +0000)]
Replace the custom allocator in AudioArray::allocate() with fastAlignedMalloc().
https://bugs.webkit.org/show_bug.cgi?id=206504

Reviewed by Filip Pizlo.

AudioArray wants to have its data aligned at 16-byte boundaries, as that's a requirement for
some of the accelerated math frameworks used by Web Audio. Now that we have fastAlignedMalloc(),
there's no need to use a custom aligned allocator.

Drive-by fixes: clean up the constructors a bit to use the modern initialization syntax.

* platform/audio/AudioArray.h:
(WebCore::AudioArray::AudioArray):
(WebCore::AudioArray::~AudioArray):
(WebCore::AudioArray::allocate):
(WebCore::AudioArray::data):
(WebCore::AudioArray::data const):
(WebCore::AudioArray::alignedAddress): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoREGRESSION: [ macOS wk2 ] inspector/canvas/create-context-bitmaprenderer.html is...
tsavell@apple.com [Mon, 3 Feb 2020 21:33:06 +0000 (21:33 +0000)]
REGRESSION: [ macOS wk2 ] inspector/canvas/create-context-bitmaprenderer.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207141

Unreviewed test gardening.

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago\0 identity escapes should be syntax errors in Unicode patterns only
shvaikalesh@gmail.com [Mon, 3 Feb 2020 21:23:20 +0000 (21:23 +0000)]
\0 identity escapes should be syntax errors in Unicode patterns only
https://bugs.webkit.org/show_bug.cgi?id=207114

Reviewed by Darin Adler.

JSTests:

* test262/expectations.yaml: Mark 2 test cases as passing.

Source/JavaScriptCore:

This change adds a separate check for null character because `strchr`
always returns a non-null pointer when called with '\0' as second argument.

Grammar: https://tc39.es/ecma262/#prod-annexB-IdentityEscape
(/u flag precludes the use of SourceCharacterIdentityEscape)

* yarr/YarrParser.h:
(JSC::Yarr::Parser::isIdentityEscapeAnError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ iOS wk2 ] compositing/backing/page-scale-overlap-in-iframe.html failing.
tsavell@apple.com [Mon, 3 Feb 2020 21:12:43 +0000 (21:12 +0000)]
[ iOS wk2 ] compositing/backing/page-scale-overlap-in-iframe.html failing.
https://bugs.webkit.org/show_bug.cgi?id=207116

Unreviewed test gardening.

Added an expectation file for iPad.

Patch by Jason Lawrence <lawrence.j@apple.com> on 2020-02-03

* platform/ipad/TestExpectations:
* platform/ipad/compositing/backing/page-scale-overlap-in-iframe-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk2 ] http/tests/media/media-stream/get-display-media-prompt.html is flaky...
youenn@apple.com [Mon, 3 Feb 2020 20:44:49 +0000 (20:44 +0000)]
[ macOS wk2 ] http/tests/media/media-stream/get-display-media-prompt.html is flaky failure
https://bugs.webkit.org/show_bug.cgi?id=206958
<rdar://problem/59003765>

Reviewed by Eric Carlson.

We added a rule to only allow one getDisplayMedia call per gesture.
For that reason, we were storing a pointer to the gesture event and
resetting in case the current gesture event was equal to the stored pointer.
Instead, store a WeakPtr which ensures that if the previous event is destroyed,
the weak pointer will be null and so will not have the same value as the new gesture event.
Covered by existing tests no longer being flaky.

* Modules/mediastream/MediaDevices.cpp:
(WebCore::MediaDevices::computeUserGesturePriviledge):
* Modules/mediastream/MediaDevices.h:
* dom/UserGestureIndicator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[macOS] AirPlay sometimes stops after 60 minutes of playback
eric.carlson@apple.com [Mon, 3 Feb 2020 20:19:44 +0000 (20:19 +0000)]
[macOS] AirPlay sometimes stops after 60 minutes of playback
https://bugs.webkit.org/show_bug.cgi?id=207056
Source/WebCore:

<rdar://problem/53649508>

Reviewed by Jer Noble.

No new tests, this only reproduces when playing to an AirPlay device.

AVPlayerItem.tracks is empty during AirPlay. If AirPlay is activated immediately
after the item is created, as is typically the case when switching from an MSE to
a url based player, MediaPlayerPrivateAVFoundationObjC doesn't know if the AVPlayerItem
has audio or video so the state reported to the WebMediaSessionManager is incorrect.
AirPlay can't actually be active if an item doesn't have audio or video, so always claim
to have both during AirPlay.

Converted WebMediaSessionManager logging from debug-only to runtime to make it easier
to diagnose problems in the future.

* Modules/mediasession/WebMediaSessionManager.cpp:
(WebCore::mediaProducerStateString):
(WebCore::WebMediaSessionLogger::create):
(WebCore::WebMediaSessionLogger::WebMediaSessionLogger):
(WebCore::WebMediaSessionLogger::log const):
(WebCore::WebMediaSessionManager::logger):
(WebCore::WebMediaSessionManager::alwaysOnLoggingAllowed const):
(WebCore::WebMediaSessionManager::setMockMediaPlaybackTargetPickerEnabled):
(WebCore::WebMediaSessionManager::setMockMediaPlaybackTargetPickerState):
(WebCore::WebMediaSessionManager::mockMediaPlaybackTargetPickerDismissPopup):
(WebCore::WebMediaSessionManager::addPlaybackTargetPickerClient):
(WebCore::WebMediaSessionManager::removePlaybackTargetPickerClient):
(WebCore::WebMediaSessionManager::removeAllPlaybackTargetPickerClients):
(WebCore::WebMediaSessionManager::showPlaybackTargetPicker):
(WebCore::WebMediaSessionManager::clientStateDidChange):
(WebCore::WebMediaSessionManager::setPlaybackTarget):
(WebCore::WebMediaSessionManager::externalOutputDeviceAvailableDidChange):
(WebCore::WebMediaSessionManager::playbackTargetPickerWasDismissed):
(WebCore::WebMediaSessionManager::configurePlaybackTargetClients):
(WebCore::WebMediaSessionManager::configurePlaybackTargetMonitoring):
(WebCore::WebMediaSessionManager::configureWatchdogTimer):
(WebCore::WebMediaSessionManager::watchdogTimerFired):
(WebCore::ClientState::logAlways const): Deleted.
* Modules/mediasession/WebMediaSessionManager.h:
* Modules/mediasession/WebMediaSessionManagerClient.h:
(WebCore::WebMediaSessionManagerClient::alwaysOnLoggingAllowed):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaState const):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasVideo const):
(WebCore::MediaPlayerPrivateAVFoundationObjC::hasAudio const):

Source/WebKit:

Reviewed by Jer Noble.

* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ews] Set custom build summary for webkitpy tests
aakash_jain@apple.com [Mon, 3 Feb 2020 19:41:41 +0000 (19:41 +0000)]
[ews] Set custom build summary for webkitpy tests
https://bugs.webkit.org/show_bug.cgi?id=207027

Reviewed by Jonathan Bedard.

* BuildSlaveSupport/ews-build/factories.py:
* BuildSlaveSupport/ews-build/steps.py:
(WebKitPyTest.setBuildSummary):
(WebKitPyTest.getResultSummary):
* BuildSlaveSupport/ews-build/factories_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agorun-javascriptcore-tests: Don't split binary results
jbedard@apple.com [Mon, 3 Feb 2020 19:37:40 +0000 (19:37 +0000)]
run-javascriptcore-tests: Don't split binary results
https://bugs.webkit.org/show_bug.cgi?id=207118

Rubber-stamped by Aakash Jain.

* Scripts/run-javascriptcore-tests:
(runTest): Only report aggregated binary results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoStart splitting platform specific overrides of default enable behavior into their...
commit-queue@webkit.org [Mon, 3 Feb 2020 19:29:22 +0000 (19:29 +0000)]
Start splitting platform specific overrides of default enable behavior into their own files
https://bugs.webkit.org/show_bug.cgi?id=207105

Patch by Sam Weinig <weinig@apple.com> on 2020-02-03
Reviewed by Dean Jackson.

Source/WebKit:

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::shouldPlugInAutoStartFromOrigin):
Switch to using the ENABLE() helper macro to correctly guard against the case that
ENABLE_PRIMARY_SNAPSHOTTED_PLUGIN_HEURISTIC is defined and equal to 0.

Source/WTF:

Splits out platform specific overrides of default enable behavior into separate files,
starting with one for all of the Cocoa related ports, one for Apple's Windows port, and
one for the WinCario port.

The rule is now that all ENABLE_* macros should have a default defined in PlatformEnable.h,
but platforms are allowed to override it via their PlatformEnable*.h file. For now, I manually
ensured that all the defines in PlatformEnableCocoa.h, PlatformEnableWinApple.h and PlatformEnableWinCairo.h
also had defaults in PlatformEnable.h, but going forward this needs be validated either through
some sort of macro-based validation, through the style checker or something else.

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/PlatformEnable.h:
* wtf/PlatformEnableCocoa.h: Copied from Source/WTF/wtf/PlatformEnable.h.
* wtf/PlatformEnableWinApple.h: Copied from Source/WTF/wtf/PlatformEnable.h.
* wtf/PlatformEnableWinCairo.h: Copied from Source/WTF/wtf/PlatformEnable.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoREGRESSION: [ macOS wk1 ] css3/selectors3/xml/css3-modsel-d2.xml is flaky failing
tsavell@apple.com [Mon, 3 Feb 2020 19:00:20 +0000 (19:00 +0000)]
REGRESSION: [ macOS wk1 ] css3/selectors3/xml/css3-modsel-d2.xml is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207133

Unreviewed test gardening

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk2 ] inspector/canvas/create-context-2d.html is flaky failing
tsavell@apple.com [Mon, 3 Feb 2020 18:41:39 +0000 (18:41 +0000)]
[ macOS wk2 ] inspector/canvas/create-context-2d.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207132

Unreviewed test gardening

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoFix expectation after r255561 that needed to be just iPad
tsavell@apple.com [Mon, 3 Feb 2020 18:36:54 +0000 (18:36 +0000)]
Fix expectation after r255561 that needed to be just iPad
https://bugs.webkit.org/show_bug.cgi?id=207116

Unreviewed test gardening.

* platform/ios-wk2/TestExpectations:
* platform/ipad/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoFlaky Test: inspector/worker/debugger-pause.html
tsavell@apple.com [Mon, 3 Feb 2020 18:25:35 +0000 (18:25 +0000)]
Flaky Test: inspector/worker/debugger-pause.html
https://bugs.webkit.org/show_bug.cgi?id=206285

Unreviewed test gardening

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoinspector/heap/getRemoteObject.html is a flaky crash
tsavell@apple.com [Mon, 3 Feb 2020 17:54:23 +0000 (17:54 +0000)]
inspector/heap/getRemoteObject.html is a flaky crash
https://bugs.webkit.org/show_bug.cgi?id=206903

Updating expectations for an existing bug

Unreviewed test gardening

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk2 ] webgpu/whlsl/buffer-vertex.html is flaky failing
tsavell@apple.com [Mon, 3 Feb 2020 17:43:42 +0000 (17:43 +0000)]
[ macOS wk2 ] webgpu/whlsl/buffer-vertex.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207127

Unreviewed test gardening

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk2/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] transitions/start-transform-transition.html is flaky failing
tsavell@apple.com [Mon, 3 Feb 2020 17:36:19 +0000 (17:36 +0000)]
[ macOS wk1 ] transitions/start-transform-transition.html is flaky failing
https://bugs.webkit.org/show_bug.cgi?id=207125

Unreviewed test gardening

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months ago[ macOS wk1 ] compositing/backing/animate-into-view.html is flaky timing out
tsavell@apple.com [Mon, 3 Feb 2020 17:21:27 +0000 (17:21 +0000)]
[ macOS wk1 ] compositing/backing/animate-into-view.html is flaky timing out
https://bugs.webkit.org/show_bug.cgi?id=207124

Unreviewed test gardening

Patch by Jacob Uphoff <jacob_uphoff@apple.com> on 2020-02-03

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 months agoUnreviewed watchOS build fix after r255559- add missing semi-colon.
krollin@apple.com [Mon, 3 Feb 2020 17:21:17 +0000 (17:21 +0000)]
Unreviewed watchOS build fix after r255559- add missing semi-colon.

* UIProcess/ios/forms/WKFocusedFormControlView.mm:
(-[WKFocusedFormControlView scrollOffsetForCrownInputOffset:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@255567 268f45cc-cd09-0410-ab3c-d52691b4dbfc