WebKit-https.git
7 years agoChange class_as_selector-expected.html to be a ref-test
benjamin@webkit.org [Fri, 5 Apr 2013 02:51:23 +0000 (02:51 +0000)]
Change class_as_selector-expected.html to be a ref-test
https://bugs.webkit.org/show_bug.cgi?id=113970

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.

The test checks style can be applied to text with a CSS class.
The reference is done by applying a style attribute directly
on each element.

* css1/basic/class_as_selector-expected.html: Added.
* platform/efl/css1/basic/class_as_selector-expected.png: Removed.
* platform/efl/css1/basic/class_as_selector-expected.txt: Removed.
* platform/gtk/css1/basic/class_as_selector-expected.txt: Removed.
* platform/mac/css1/basic/class_as_selector-expected.png: Removed.
* platform/mac/css1/basic/class_as_selector-expected.txt: Removed.
* platform/qt/css1/basic/class_as_selector-expected.png: Removed.
* platform/qt/css1/basic/class_as_selector-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnskip 3 backface-visibility tests on OS X
benjamin@webkit.org [Fri, 5 Apr 2013 02:48:14 +0000 (02:48 +0000)]
Unskip 3 backface-visibility tests on OS X

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04

* platform/mac/TestExpectations:
The 3 pixel tests pass on WebKit1 and WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdate WebKit.org's contact page
benjamin@webkit.org [Fri, 5 Apr 2013 02:43:56 +0000 (02:43 +0000)]
Update WebKit.org's contact page
https://bugs.webkit.org/show_bug.cgi?id=113968

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-04
Reviewed by Geoffrey Garen.

* contact.html:
-Add a direct link to our archives on Gmane.
-References the ports mailing-lists. This may reduces the emails
 erroneously sent to webkit-dev.
-Add a link to our "reporting bug page".
-Get rid of the link to CIA. The website is dead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove the rebaseline queue server since nobody except maybe one person from Google...
rniwa@webkit.org [Fri, 5 Apr 2013 02:39:17 +0000 (02:39 +0000)]
Remove the rebaseline queue server since nobody except maybe one person from Google uses it.

Rubber stamped by Benjamin Poulain.

* RebaselineQueueServer: Removed.
* RebaselineQueueServer/app.yaml: Removed.
* RebaselineQueueServer/handlers: Removed.
* RebaselineQueueServer/handlers/__init__.py: Removed.
* RebaselineQueueServer/handlers/builderqueue.py: Removed.
* RebaselineQueueServer/handlers/pages.py: Removed.
* RebaselineQueueServer/index.yaml: Removed.
* RebaselineQueueServer/main.py: Removed.
* RebaselineQueueServer/model: Removed.
* RebaselineQueueServer/model/__init__.py: Removed.
* RebaselineQueueServer/model/queueentry.py: Removed.
* RebaselineQueueServer/static: Removed.
* RebaselineQueueServer/static/builder-frame-empty.html: Removed.
* RebaselineQueueServer/static/styles.css: Removed.
* RebaselineQueueServer/templates: Removed.
* RebaselineQueueServer/templates/builder-picker.html: Removed.
* RebaselineQueueServer/templates/builder-queue-edit.html: Removed.
* RebaselineQueueServer/templates/builder-queue-list.html: Removed.
* RebaselineQueueServer/templates/home.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix setup-commit-queue and temporarily disable testing on commit-queue
rniwa@webkit.org [Fri, 5 Apr 2013 02:35:53 +0000 (02:35 +0000)]
Fix setup-commit-queue and temporarily disable testing on commit-queue
https://bugs.webkit.org/show_bug.cgi?id=113979

Reviewed by Benjamin Poulain.

Use commit-queue@webkit.org instead of webkit.bot.review@gmail.com in commit-queue,
and temporarily disable tests in commit-queue as we don't have enough resources at the moment.

* EWSTools/setup-commit-queue.sh:
* Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWork around a bug in the bindings generation script.
andersca@apple.com [Fri, 5 Apr 2013 01:29:57 +0000 (01:29 +0000)]
Work around a bug in the bindings generation script.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't dispatch delayed click if snapshotted plugin was triggered by a click on the...
dino@apple.com [Fri, 5 Apr 2013 01:25:05 +0000 (01:25 +0000)]
Don't dispatch delayed click if snapshotted plugin was triggered by a click on the label
https://bugs.webkit.org/show_bug.cgi?id=113982

Reviewed by Tim Horton.

We regressed the way clicks were sent on to restarted plugins when we moved to a
Shadow Root - we were always sending the click. We should only send the click
on if the user clicked on the main plugin content, and not send it when you
click directly on the label.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Keep a reference to the container and label.
(WebCore::HTMLPlugInImageElement::partOfSnapshotLabel): New method that detects if a Node was part
    of the snapshot label.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Only record the event if you should forward it on.
* html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New parameter to userDidClickSnapshot and member variables for shadow content.
* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::handleEvent): Ask the plugin if the clicked target was the snapshot label.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL build fix.
ch.dumez@sisa.samsung.com [Fri, 5 Apr 2013 00:59:25 +0000 (00:59 +0000)]
Unreviewed EFL build fix.

Add missing include for FloatRect.h.

* platform/efl/PlatformScreenEfl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed build fix.
timothy_horton@apple.com [Fri, 5 Apr 2013 00:54:47 +0000 (00:54 +0000)]
Unreviewed build fix.

* platform/graphics/GlyphPageTreeNode.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed EFL build fix.
ch.dumez@sisa.samsung.com [Fri, 5 Apr 2013 00:44:28 +0000 (00:44 +0000)]
Unreviewed EFL build fix.

We had undefined reference to `JSC::CodeOrigin::maximumBytecodeIndex'.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAnother build fix.
andersca@apple.com [Fri, 5 Apr 2013 00:37:08 +0000 (00:37 +0000)]
Another build fix.

* platform/graphics/FontCache.cpp:
* platform/graphics/SimpleFontData.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix build.
andersca@apple.com [Fri, 5 Apr 2013 00:28:58 +0000 (00:28 +0000)]
Fix build.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Adjust fatfinger result priority
commit-queue@webkit.org [Fri, 5 Apr 2013 00:26:29 +0000 (00:26 +0000)]
[BlackBerry] Adjust fatfinger result priority
https://bugs.webkit.org/show_bug.cgi?id=113957

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-04
Reviewed by Rob Buis.

RIM PR 224781
Internally Reviewed by Genevieve Mak.

Change fatfigner algorithm, return the clickable element rather than
its parent anchor. Modify taphighlight and context menu node selection
accordingly.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::findBestPoint):
* WebKitSupport/FatFingers.h:
* WebKitSupport/TouchEventHandler.cpp:
(BlackBerry::WebKit::elementForTapHighlight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved empty files from the build
ggaren@apple.com [Fri, 5 Apr 2013 00:15:10 +0000 (00:15 +0000)]
Removed empty files from the build
https://bugs.webkit.org/show_bug.cgi?id=113978

Reviewed by Anders Carlsson.

Anders made a list of all the empty files that are slowing down the Mac
build, and I grepped them away.

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotemporarily make flakiness dashboard work again webkit.org bots
dpranke@chromium.org [Fri, 5 Apr 2013 00:08:27 +0000 (00:08 +0000)]
temporarily make flakiness dashboard work again webkit.org bots
https://bugs.webkit.org/show_bug.cgi?id=113972

Reviewed by Ojan Vafai.

This patch disables the chromium.org layout test bots TestExpectations
parsing temporarily until we can work out the right way to split into
two instances for webkit.org and chromium.org and figure out which
code to delete where :).

* TestResultServer/static-dashboards/flakiness_dashboard.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrune unneeded header #includes
andersca@apple.com [Fri, 5 Apr 2013 00:08:09 +0000 (00:08 +0000)]
Prune unneeded header #includes
https://bugs.webkit.org/show_bug.cgi?id=113973

Reviewed by Geoffrey Garen.

Reduce the amount of headers included by other headers by:
- Moving implicit and explicit constructors and destructors into .cpp files so member variable constructors/destructors
  don't have to be declared.
- Move CachedResourceClient subclasses out into separate headers so that their respective CachedResource subclasses don't
  have to be included by the classes that derive from those subclasses.
- Remove headers that were never needed in the first place.

* Modules/webaudio/AudioContext.h:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMWindowCustom.cpp:
* css/CSSFontFaceSource.h:
* html/canvas/CanvasPattern.cpp:
(WebCore::CanvasPattern::create):
(WebCore::CanvasPattern::CanvasPattern):
(WebCore::CanvasPattern::~CanvasPattern):
* html/canvas/CanvasPattern.h:
(WebCore::CanvasPattern::pattern):
(WebCore::CanvasPattern::originClean):
* html/parser/HTMLScriptRunner.h:
* loader/ImageLoader.h:
* loader/LinkLoader.h:
* loader/TextTrackLoader.h:
* loader/cache/CachedFont.cpp:
* loader/cache/CachedFont.h:
* loader/cache/CachedFontClient.h: Added.
(WebCore::CachedFontClient::~CachedFontClient):
(WebCore::CachedFontClient::expectedType):
(WebCore::CachedFontClient::resourceClientType):
(WebCore::CachedFontClient::fontLoaded):
* loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::~CachedResourceHandleBase):
(WebCore::CachedResourceHandleBase::setResource):
* loader/cache/CachedResourceHandle.h:
(WebCore::CachedResourceHandleBase::get):
(WebCore::CachedResourceHandleBase::operator!):
(WebCore::CachedResourceHandleBase::operator UnspecifiedBoolType):
(WebCore::CachedResourceHandleBase::operator=):
(WebCore::CachedResourceHandle::CachedResourceHandle):
(WebCore::CachedResourceHandle::get):
(WebCore::CachedResourceHandle::operator->):
(WebCore::CachedResourceHandle::operator=):
(WebCore::CachedResourceHandle::operator==):
(WebCore::CachedResourceHandle::operator!=):
(WebCore::operator==):
(WebCore::operator!=):
* loader/cache/CachedSVGDocument.h:
* loader/cache/CachedSVGDocumentReference.h:
* loader/cache/CachedSVGDocumentClient.h: Added.
(WebCore::CachedSVGDocumentClient::~CachedSVGDocumentClient):
(WebCore::CachedSVGDocumentClient::expectedType):
(WebCore::CachedSVGDocumentClient::resourceClientType):
* loader/cache/CachedStyleSheetClient.h:
* platform/PlatformScreen.h:
* platform/audio/HRTFElevation.cpp:
* platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::fftSize):
* platform/audio/HRTFKernel.h:
* platform/audio/ReverbConvolverStage.cpp:
(WebCore::ReverbConvolverStage::~ReverbConvolverStage):
* platform/audio/ReverbConvolverStage.h:
* platform/graphics/FontPlatformData.h:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/Path.cpp:
* platform/graphics/Path.h:
* platform/graphics/Pattern.cpp:
* platform/graphics/Pattern.h:
* platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::~ReferenceFilterOperation):
(WebCore::ReferenceFilterOperation::setCachedSVGDocumentReference):
* platform/graphics/filters/FilterOperation.h:
* platform/graphics/transforms/AffineTransform.h:
* plugins/DOMMimeType.h:
* rendering/RenderLayerFilterInfo.h:
* rendering/style/StyleCachedShader.h:
* svg/SVGFEImageElement.h:
* svg/SVGFontFaceUriElement.h:
* svg/SVGUseElement.h:
* xml/parser/XMLDocumentParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] Stop passing raw pointers to BitmapImage::create()
ch.dumez@sisa.samsung.com [Thu, 4 Apr 2013 23:59:12 +0000 (23:59 +0000)]
[Cairo] Stop passing raw pointers to BitmapImage::create()
https://bugs.webkit.org/show_bug.cgi?id=113945

Reviewed by Martin Robinson.

Source/WebCore:

BitmapImage::create() was updated in r147643 to take a PassRefPtr<cairo_surface_t>
in argument instead of a cairo_surface_t*. This patch updates several call sites
so that they now pass in a smart pointer instead of a raw one to avoid silent
converting from cairo_surface_t* to PassRefPtr<cairo_surface_t>.

No new tests, no behavior change.

* platform/graphics/cairo/ImageBufferCairo.cpp:
(WebCore::ImageBufferData::ImageBufferData): Use RefPtr to m_surface to avoid manual
memory handling.
(WebCore::ImageBuffer::ImageBuffer):
(WebCore::ImageBuffer::~ImageBuffer):
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::clip):
(WebCore::ImageBuffer::platformTransformColorSpace):
(WebCore::getImageData):
(WebCore::ImageBuffer::putByteArray):
* platform/graphics/cairo/ImageBufferDataCairo.h:
(ImageBufferData):
* platform/graphics/gstreamer/ImageGStreamerCairo.cpp:
(ImageGStreamer::ImageGStreamer):
* platform/graphics/gtk/ImageBufferGtk.cpp:
(WebCore::ImageBuffer::toDataURL):

Source/WebKit2:

Pass a smart pointer in to BitmapImage::create() instead of a raw one
for the cairo surface. The factory method prototype was updated for
cairo in r147643.

* Shared/cairo/ShareableBitmapCairo.cpp:
(WebKit::ShareableBitmap::createImage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPage content missing when flipping from an empty layer to a tiled layer
simon.fraser@apple.com [Thu, 4 Apr 2013 23:57:33 +0000 (23:57 +0000)]
Page content missing when flipping from an empty layer to a tiled layer
https://bugs.webkit.org/show_bug.cgi?id=113977
<rdar://problem/13444219>

Source/WebCore:

Reviewed by Tim Horton.

Some articles on USA Today were missing content on load, when a large GraphicsLayer
which did not draw content needed to draw content (and become tiled in the process).

The bug was an ordering dependency in GraphicsLayerCA::commitLayerChangesBeforeSublayers().
swapFromOrToTiledLayer() sets some dirty flags, but for some properties which have
already been committed in the current flush cycle.

Fix by moving the swapFromOrToTiledLayer() to the top of the commit, which is
safe since it only consults GraphicsLayer properties, not CALayer properties.

Test: compositing/tiling/empty-to-tiled.html

* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::commitLayerChangesBeforeSublayers):
(WebCore::GraphicsLayerCA::updateGeometry):
(WebCore::GraphicsLayerCA::updateLayerDrawsContent):
(WebCore::GraphicsLayerCA::updateContentsScale):
* platform/graphics/ca/GraphicsLayerCA.h:
(GraphicsLayerCA):

LayoutTests:

Reviewed by Tim Horton.

Ref test that adds visible content to a larger layer.

* compositing/tiling/empty-to-tiled-expected.html: Added.
* compositing/tiling/empty-to-tiled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r147639) Causes assertion hit in HashTable
ch.dumez@sisa.samsung.com [Thu, 4 Apr 2013 23:56:13 +0000 (23:56 +0000)]
Regression(r147639) Causes assertion hit in HashTable
https://bugs.webkit.org/show_bug.cgi?id=113954

Reviewed by Benjamin Poulain.

Lookup the key in the hash table again after the recursive call to
getCachedFontPlatformData() as it may have altered the hash map and
invalidated the previous iterator we had.

No new tests, covered by existing tests.

* platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix webkitpy tests after r147678.
rniwa@webkit.org [Thu, 4 Apr 2013 23:52:54 +0000 (23:52 +0000)]
Fix webkitpy tests after r147678.

* Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest.test_commit_queue):
(test_manual_reject_during_processing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, fix a test and some results missed in r147675
eric.carlson@apple.com [Thu, 4 Apr 2013 23:35:40 +0000 (23:35 +0000)]
Unreviewed, fix a test and some results missed in r147675

* media/media-captions-expected.txt:
* media/video-controls-captions-trackmenu-localized.html:
* platform/mac/media/video-controls-captions-trackmenu-localized-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe commit queue should use Mac MountainLion port
rniwa@webkit.org [Thu, 4 Apr 2013 23:18:16 +0000 (23:18 +0000)]
The commit queue should use Mac MountainLion port
https://bugs.webkit.org/show_bug.cgi?id=113971

Reviewed by Lucas Forschler.

* EWSTools/setup-commit-queue.sh: Copied from Tools/EWSTools/GoogleComputeEngine/build-commit-queue.sh.
* Scripts/webkitpy/tool/commands/queues.py:
(CommitQueue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoStop pretending that statements return a value
ggaren@apple.com [Thu, 4 Apr 2013 23:16:20 +0000 (23:16 +0000)]
Stop pretending that statements return a value
https://bugs.webkit.org/show_bug.cgi?id=113969

Reviewed by Oliver Hunt.

Expressions have an intrinsic value, which they return to their parent
in the AST.

Statements just execute for effect in sequence.

This patch moves emitBytecode into the ExpressionNode and StatementNode
subclasses, and changes the SatementNode subclass to return void. This
eliminates some cruft where we used to return 0, or try to save a bogus
register and return it, as if a statement had a consuming parent in the
AST.

* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::emitNode):
(BytecodeGenerator):
(JSC::BytecodeGenerator::emitNodeInConditionContext):
* bytecompiler/NodesCodegen.cpp:
(JSC::ConstStatementNode::emitBytecode):
(JSC::BlockNode::emitBytecode):
(JSC::EmptyStatementNode::emitBytecode):
(JSC::DebuggerStatementNode::emitBytecode):
(JSC::ExprStatementNode::emitBytecode):
(JSC::VarStatementNode::emitBytecode):
(JSC::IfNode::emitBytecode):
(JSC::IfElseNode::emitBytecode):
(JSC::DoWhileNode::emitBytecode):
(JSC::WhileNode::emitBytecode):
(JSC::ForNode::emitBytecode):
(JSC::ForInNode::emitBytecode):
(JSC::ContinueNode::emitBytecode):
(JSC::BreakNode::emitBytecode):
(JSC::ReturnNode::emitBytecode):
(JSC::WithNode::emitBytecode):
(JSC::CaseClauseNode::emitBytecode):
(JSC::CaseBlockNode::emitBytecodeForBlock):
(JSC::SwitchNode::emitBytecode):
(JSC::LabelNode::emitBytecode):
(JSC::ThrowNode::emitBytecode):
(JSC::TryNode::emitBytecode):
(JSC::ScopeNode::emitStatementsBytecode):
(JSC::ProgramNode::emitBytecode):
(JSC::EvalNode::emitBytecode):
(JSC::FunctionBodyNode::emitBytecode):
(JSC::FuncDeclNode::emitBytecode):
* parser/NodeConstructors.h:
(JSC::PropertyListNode::PropertyListNode):
(JSC::ArgumentListNode::ArgumentListNode):
* parser/Nodes.h:
(Node):
(ExpressionNode):
(StatementNode):
(ConstStatementNode):
(BlockNode):
(EmptyStatementNode):
(DebuggerStatementNode):
(ExprStatementNode):
(VarStatementNode):
(IfNode):
(IfElseNode):
(DoWhileNode):
(WhileNode):
(ForNode):
(ForInNode):
(ContinueNode):
(BreakNode):
(ReturnNode):
(WithNode):
(LabelNode):
(ThrowNode):
(TryNode):
(ProgramNode):
(EvalNode):
(FunctionBodyNode):
(FuncDeclNode):
(CaseBlockNode):
(SwitchNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake fast/events/tabindex-focus-blur-all.html disallow Java so the test runs the...
benjamin@webkit.org [Thu, 4 Apr 2013 22:57:30 +0000 (22:57 +0000)]
Make fast/events/tabindex-focus-blur-all.html disallow Java so the test runs the same regardless of platform/port
https://bugs.webkit.org/show_bug.cgi?id=113950

Patch by Dave Michael <dmichael@chromium.org> on 2013-04-04
Reviewed by Jer Noble.

This hopefully fixes the test failure seen on Apple Mountain Lion WK2:
http://build.webkit.org/results/Apple%20MountainLion%20Release%20WK2%20(Tests)/r147640%20(7636)/results.html
that was introduced in https://bugs.webkit.org/show_bug.cgi?id=32292

* fast/events/resources/tabindex-focus-blur-all.js: Make the test disallow Java execution. Otherwise, <applet> is focusible on platforms that support Java by default and not focusible elsewhere.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] add "automatic" text track menu item
eric.carlson@apple.com [Thu, 4 Apr 2013 22:23:47 +0000 (22:23 +0000)]
[Mac] add "automatic" text track menu item
https://bugs.webkit.org/show_bug.cgi?id=113822

Reviewed by Jer Noble.

Source/WebCore:

No new tests, existing tests updated.

* English.lproj/Localizable.strings: Add new track menu item.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Initialize m_captionDisplayMode.
(WebCore::HTMLMediaElement::finishParsingChildren): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::scheduleDelayedAction): Ditto.
(WebCore::HTMLMediaElement::loadTimerFired): Ditto.
(WebCore::HTMLMediaElement::loadInternal): Ditto. Flag the caption menu as invalid so it will
    be rebuilt again.
(WebCore::HTMLMediaElement::mediaPlayerDidAddTrack): LoadTextTrackResource -> ConfigureTextTracks.
(WebCore::HTMLMediaElement::didAddTrack): Ditto.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Deal with new track display modes.
(WebCore::HTMLMediaElement::HTMLMediaElement::hasClosedCaptions): Minor cleanup.
(WebCore::HTMLMediaElement::configureTextTrackGroup): Add some logging.
(WebCore::HTMLMediaElement::configureTextTracks): Call updateActiveTextTrackCues so cue display
    is updated.
(WebCore::HTMLMediaElement::captionPreferencesChanged): Deal with new track display modes.
(WebCore::HTMLMediaElement::markCaptionAndSubtitleTracksAsUnconfigured): Add some logging.
* html/HTMLMediaElement.h: Ditto.

* html/shadow/MediaControlElementTypes.cpp: Remove trackIndexAttributeName and trackListIndexForElement.
* html/shadow/MediaControlElementTypes.h: Ditto.

* html/shadow/MediaControlElements.cpp:
(WebCore::MediaControlClosedCaptionsTrackListElement::defaultEventHandler): Don't use track index,
    everything we need is in the track<->element map now.
(WebCore::MediaControlClosedCaptionsTrackListElement::updateDisplay): Ditto. Always rebuild the
    track list because clear the map each time the menu goes away because it refs every track.
(WebCore::MediaControlClosedCaptionsTrackListElement::rebuildTrackListMenu): Don't set the track
    index attribute on the menu items, just use the map.
* html/shadow/MediaControlElements.h:

* html/shadow/MediaControlsApple.cpp:
(WebCore::MediaControlsApple::changedClosedCaptionsVisibility): resetTrackListMenu is gone.
(WebCore::MediaControlsApple::reset): Ditto.
(WebCore::MediaControlsApple::closedCaptionTracksChanged): Ditto.

* html/track/TextTrack.cpp:
(WebCore::TextTrack::captionMenuOffItem): New, static TextTrack used for the menu "Off" item.
(WebCore::TextTrack::captionMenuAutomaticItem): New, static TextTrack used for the menu "Automatic" item.
* html/track/TextTrack.h:

* page/CaptionUserPreferences.cpp:
(WebCore::CaptionUserPreferences::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferences::captionDisplayMode): New.
(WebCore::CaptionUserPreferences::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferences::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferences::textTrackSelectionScore): Return 0 if the user doesn't want
    captions or subtitles.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
    instead of assuming that it is always the entire language list.
* page/CaptionUserPreferences.h:

* page/CaptionUserPreferencesMac.h:
* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::shouldShowCaptions): Removed, we use captionDisplayMode instead.
(WebCore::CaptionUserPreferencesMac::captionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setCaptionDisplayMode): New.
(WebCore::CaptionUserPreferencesMac::setPreferredLanguage): Make the parameter a const reference.
(WebCore::CaptionUserPreferencesMac::textTrackSelectionScore): Deal with "Automatic" mode.
    captions or subtitles.
(WebCore::CaptionUserPreferences::textTrackLanguageSelectionScore): Take language as a parameter
    instead of assuming that it is always the entire language list.
(WebCore::CaptionUserPreferencesMac::sortedTrackListForMenu): Insert "Off" and "Automatic" items.

* platform/LocalizedStrings.cpp:
(WebCore::textTrackAutomaticMenuItemText): New.
* platform/LocalizedStrings.h:

* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::languageOfPrimaryAudioTrack): New.
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::languageOfPrimaryAudioTrack): Return the language
    of the main audio track.

LayoutTests:

* media/media-captions.html: Opportunistic fix - don't look at state until we get the 'canplaythrough'
    event because the media engine state may not have been processed until that time.
* media/track/track-cue-container-rendering-position.html: Don't assume that a cue has been
    rendered immediately when the 'canplaythrough' event comes through.
* media/track/track-cue-rendering-mode-changed.html: Ditto.
* media/track/track-in-band-expected.txt: Don't check if cues have loaded, it doesn't matter
    for this test.
* media/track/track-in-band.html: Ditto.
* media/track/track-user-preferences-expected.txt: Changed name of utility function from
    menuIndexForLanguage to indexOfMenuItemBeginningWith.
* media/track/track-user-preferences.html: Move menuIndexForLanguage to trackmenu-test.js and
    change name to indexOfMenuItemBeginningWith. Clarify the message logged when a track loads
    but it should not.
* media/trackmenu-test.js: Move some functions here from track-user-preferences.html
(trackMenuList):
(indexOfMenuItemBeginningWith):
(selectCaptionMenuItem):
* media/video-controls-captions-trackmenu-sorted.html: Update for new menu item.
* media/video-controls-captions-trackmenu.html: Ditto.
* platform/mac/media/video-controls-captions-trackmenu-expected.txt: Ditto.
* platform/mac/media/video-controls-captions-trackmenu-sorted-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening. Rebaseline after r147588. Remove overridden pixel results.
glenn@skynav.com [Thu, 4 Apr 2013 22:20:49 +0000 (22:20 +0000)]
[EFL] Unreviewed gardening. Rebaseline after r147588. Remove overridden pixel results.

* platform/efl/fast/text/international/003-expected.png: Removed.
* platform/efl/fast/text/international/text-combine-image-test-expected.png: Removed.
* platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening. Rebaseline after r147588. Update pixel expectations.
glenn@skynav.com [Thu, 4 Apr 2013 22:01:17 +0000 (22:01 +0000)]
[EFL] Unreviewed gardening. Rebaseline after r147588. Update pixel expectations.

* platform/efl-wk1/fast/text/international/003-expected.png: Added.
* platform/efl-wk1/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/efl-wk2/fast/text/international/003-expected.png: Added.
* platform/efl-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoturn off running tests on chromium linux EWS bots
dpranke@chromium.org [Thu, 4 Apr 2013 21:57:59 +0000 (21:57 +0000)]
turn off running tests on chromium linux EWS bots
https://bugs.webkit.org/show_bug.cgi?id=113959

Reviewed by Geoffrey Garen.

Now that the Chromium port is no longer being maintained
there's little point in running the tests. Soon we should
just shut this bot off altogether.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(ChromiumLinuxEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago REGRESSION (r146580): Assertion using SecurityOrigin::create, URL string...
ap@apple.com [Thu, 4 Apr 2013 21:57:58 +0000 (21:57 +0000)]
    REGRESSION (r146580): Assertion using SecurityOrigin::create, URL string is not valid
        https://bugs.webkit.org/show_bug.cgi?id=113961

        Reviewed by Geoff Garen.

        * page/SecurityOrigin.cpp:
        (WebCore::SecurityOrigin::createFromDatabaseIdentifier):
        (WebCore::SecurityOrigin::create):
        Don't use ParsedURLString, because http://host:80/ is normalized to http://host/,
        so it's not a parsed URL string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoException stack unwinding doesn't handle inline callframes correctly
oliver@apple.com [Thu, 4 Apr 2013 21:25:26 +0000 (21:25 +0000)]
Exception stack unwinding doesn't handle inline callframes correctly
https://bugs.webkit.org/show_bug.cgi?id=113952

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

The basic problem here is that the exception stack unwinding was
attempting to be "clever" and avoid doing a correct stack walk
as it "knew" inline callframes couldn't have exception handlers.

This used to be safe as the exception handling machinery was
designed to fail gently and just claim that no handler existed.
This was "safe" and even "correct" inasmuch as we currently
don't run any code with exception handlers through the dfg.

This patch fixes the logic by simply making everything uniformly
use the safe stack walking machinery, and making the correct
boundary checks occur everywhere that they should.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::findClosureCallForReturnPC):
(JSC::CodeBlock::bytecodeOffset):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::retrieveCallerFromVMCode):

LayoutTests:

Yay tests!

* fast/js/js-correct-exception-handler-expected.txt: Added.
* fast/js/js-correct-exception-handler.html: Added.
* fast/js/script-tests/js-correct-exception-handler.js: Added.
(throwEventually):
(f.g):
(f):
(test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved a defunct comment
ggaren@apple.com [Thu, 4 Apr 2013 21:16:43 +0000 (21:16 +0000)]
Removed a defunct comment
https://bugs.webkit.org/show_bug.cgi?id=113948

Reviewed by Oliver Hunt.

This is also a convenient way to test the EWS.

* bytecompiler/BytecodeGenerator.cpp:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening. Rebaseline after r147588.
glenn@skynav.com [Thu, 4 Apr 2013 21:08:08 +0000 (21:08 +0000)]
[EFL] Unreviewed gardening. Rebaseline after r147588.

* platform/efl-wk1/fast/text/international: Added.
* platform/efl-wk1/fast/text/international/003-expected.txt: Added.
* platform/efl-wk1/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/efl-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/efl-wk2/fast/text/international/003-expected.txt: Added.
* platform/efl-wk2/fast/text/international/text-combine-image-test-expected.txt: Added.
* platform/efl-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.
* platform/efl/fast/text/international/003-expected.txt: Removed.
* platform/efl/fast/text/international/text-combine-image-test-expected.txt: Removed.
* platform/efl/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r147662.
commit-queue@webkit.org [Thu, 4 Apr 2013 20:52:51 +0000 (20:52 +0000)]
Unreviewed, rolling out r147662.
http://trac.webkit.org/changeset/147662
https://bugs.webkit.org/show_bug.cgi?id=113955

The change r147662  breaks fast/regions/fixed-pos-elem-in-
region.html (Requested by benjaminp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-04

Source/WebCore:

* rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth):

LayoutTests:

* fast/inline/inline-with-empty-inline-children-expected.txt:
* fast/inline/inline-with-empty-inline-children.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. AppleWin port gardening.
roger_fong@apple.com [Thu, 4 Apr 2013 20:46:43 +0000 (20:46 +0000)]
Unreviewed. AppleWin port gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. AppleWin port gardening.
roger_fong@apple.com [Thu, 4 Apr 2013 20:19:32 +0000 (20:19 +0000)]
Unreviewed. AppleWin port gardening.

* platform/win/TestExpectations:
* platform/win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
timothy_horton@apple.com [Thu, 4 Apr 2013 19:58:45 +0000 (19:58 +0000)]
REGRESSION (r147373): Auto-sizing doesn't always respect minimum width changes
https://bugs.webkit.org/show_bug.cgi?id=113947
<rdar://problem/13579024>

Reviewed by Anders Carlsson.

Reset the FrameView size to the minimum auto-sizing size
before performing auto-sizing. We were already resetting the height,
but not the width, instead using the FrameView's current width.

This means that changing the minimum width without also manually
resizing the FrameView will never see the width change.

Auto-sizing tests are not working on Mac yet.

* page/FrameView.cpp:
(WebCore::FrameView::autoSizeIfEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Remove the gyp build
mrobinson@webkit.org [Thu, 4 Apr 2013 19:26:55 +0000 (19:26 +0000)]
[GTK] Remove the gyp build
https://bugs.webkit.org/show_bug.cgi?id=113942

Reviewed by Gustavo Noronha Silva.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCoreGTK.gyp: Removed.
* JavaScriptCore.gyp/redirect-stdout.sh: Removed.

Source/ThirdParty/ANGLE:

* ANGLE.gyp/ANGLE.gyp: Removed.
* ANGLE.gypi: Removed.

Source/WebCore:

* WebCore.gyp/WebCoreGTK.gyp: Removed.

Source/WebKit/gtk:

* gyp/Configuration.gypi.in: Removed.
* gyp/Dependencies.gyp: Removed.
* gyp/GNUmakefile: Removed.
* gyp/autogen.sh: Removed.
* gyp/configure.ac: Removed.
* gyp/run-gyp: Removed.

Source/WTF:

* WTF.gyp/WTFGTK.gyp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION(r142152): Text wraps in menu
robert@webkit.org [Thu, 4 Apr 2013 19:23:03 +0000 (19:23 +0000)]
REGRESSION(r142152): Text wraps in menu
https://bugs.webkit.org/show_bug.cgi?id=113706

Reviewed by David Hyatt.

Source/WebCore:

* rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)

LayoutTests:

* fast/inline/inline-with-empty-inline-children-expected.txt:
* fast/inline/inline-with-empty-inline-children.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChanging typing style with font size delta overrides the previous font size delta
rniwa@webkit.org [Thu, 4 Apr 2013 19:15:52 +0000 (19:15 +0000)]
Changing typing style with font size delta overrides the previous font size delta
https://bugs.webkit.org/show_bug.cgi?id=113923

Reviewed by Andreas Kling.

The bug was caused by a new font size delta value overriding the old one as
opposed to being added to the old value. Fixed that in overrideWithStyle.

Also made overrideWithStyle share code with mergeStyle since there is already
code to merge text-decorations there.

Unfortunately, adding a test for this fix proved to be hard because we don't
expose any API to directly set typing style.

* editing/EditingStyle.cpp:
(WebCore::EditingStyle::overrideWithStyle): Use mergeStyle.
(WebCore::EditingStyle::mergeStyle): Add font size deltas as opposed to simply
using the new value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAX:File upload button has wrong label
cfleizach@apple.com [Thu, 4 Apr 2013 19:05:22 +0000 (19:05 +0000)]
AX:File upload button has wrong label
https://bugs.webkit.org/show_bug.cgi?id=113924

Reviewed by David Kilzer.

Source/WebCore:

Allow the label and value to be returned for file upload controls on iOS.
Due to the different AX APIs, we can expose a bit more information on iOS.

Test: platform/iphone-simulator/accessibility/file-upload-button.html

* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper stringValueShouldBeUsedInLabel]):
(-[WebAccessibilityObjectWrapper fileUploadButtonReturnsValueInTitle]):
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(-[WebAccessibilityObjectWrapperBase fileUploadButtonReturnsValueInTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):

LayoutTests:

* platform/iphone-simulator/accessibility/file-upload-button-expected.txt: Added.
* platform/iphone-simulator/accessibility/file-upload-button.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoExpose settings to disable plugin snapshotting autostart and primary detection
dino@apple.com [Thu, 4 Apr 2013 18:52:27 +0000 (18:52 +0000)]
Expose settings to disable plugin snapshotting autostart and primary detection
https://bugs.webkit.org/show_bug.cgi?id=113918

Reviewed by Tim Horton.

Source/WebCore:

Three new settings:
- snapshotAllPlugIns: Do not apply any heuristics - immediately snapshot a plugin.
- primaryPlugInSnapshotDetectionEnabled: Toggle snapshotting the "main" plugin in the page.
- autostartOriginPlugInSnapshottingEnabled: Toggle snapshotting based on URL origins.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): Don't tell the host that we've started
    if the autostartOriginPlugInSnapshottingEnabled is false.
(WebCore::HTMLPlugInImageElement::setIsPrimarySnapshottedPlugIn): Don't restart a primary
    plugin if primaryPlugInSnapshotDetectionEnabled is false.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Snapshot immediately if
    snapshotAllPlugIns is true. Also, don't test for autostart if
    autostartOriginPlugInSnapshottingEnabled is false.
* page/Settings.in: Three new settings values.

Source/WebKit2:

Three new settings: snapshotAllPlugIns, primaryPlugInSnapshotDetectionEnabled and
autostartOriginPlugInSnapshottingEnabled.
These are exposed via WKPreferences (WebKit2 only, since that's the only port actively
using the feature).

* Shared/WebPreferencesStore.h: Add macros for new settings.
* UIProcess/API/C/WKPreferences.cpp: Getters and setters for new settings.
(WKPreferencesSetSnapshotAllPlugIns):
(WKPreferencesGetSnapshotAllPlugIns):
(WKPreferencesSetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesGetAutostartOriginPlugInSnapshottingEnabled):
(WKPreferencesSetPrimaryPlugInSnapshotDetectionEnabled):
(WKPreferencesGetPrimaryPlugInSnapshotDetectionEnabled):
* UIProcess/API/C/WKPreferencesPrivate.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::updatePreferences): Forward settings updates.
(WebKit::WebPage::addPluginView): Don't run primary plugin detection if the setting is false.
(WebKit::WebPage::didFinishLoad): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSimplified bytecode generation by merging prefix and postfix nodes
ggaren@apple.com [Thu, 4 Apr 2013 18:31:37 +0000 (18:31 +0000)]
Simplified bytecode generation by merging prefix and postfix nodes
https://bugs.webkit.org/show_bug.cgi?id=113925

Reviewed by Filip Pizlo.

PostfixNode now inherits from PrefixNode, so when we detect that we're
in a context where postifx and prefix are equivalent, PostFixNode can
just call through to PrefixNode codegen, instead of duplicating the
logic.

* bytecompiler/NodesCodegen.cpp:
(JSC::PostfixNode::emitResolve):
(JSC::PostfixNode::emitBracket):
(JSC::PostfixNode::emitDot):
* parser/NodeConstructors.h:
(JSC::PostfixNode::PostfixNode):
* parser/Nodes.h:
(JSC):
(PrefixNode):
(PostfixNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.
scherkus@chromium.org [Thu, 4 Apr 2013 18:25:35 +0000 (18:25 +0000)]
Unreviewed. Removing feature-media-reviews@chromium.org from Media watchlist.

* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results. Reviewed by Anders Carlsson. I'm using a...
ggaren@apple.com [Thu, 4 Apr 2013 18:22:21 +0000 (18:22 +0000)]
Removed Chromium layout test results.  Reviewed by Anders Carlsson.  I'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results. Reviewed by Anders Carlsson. I'm using a...
ggaren@apple.com [Thu, 4 Apr 2013 18:22:18 +0000 (18:22 +0000)]
Removed Chromium layout test results.  Reviewed by Anders Carlsson.  I'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Remove skia code from PluginViewBlackBerry
commit-queue@webkit.org [Thu, 4 Apr 2013 18:22:17 +0000 (18:22 +0000)]
[BlackBerry] Remove skia code from PluginViewBlackBerry
https://bugs.webkit.org/show_bug.cgi?id=113936

Patch by Carlos Garcia Campos <cgarcia@igalia.com> on 2013-04-04
Reviewed by Rob Buis.

Skia is not used anymore by the BlackBerry port.

* plugins/blackberry/PluginViewBlackBerry.cpp:
(WebCore::PluginView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results. Reviewed by Anders Carlsson. I'm using a...
ggaren@apple.com [Thu, 4 Apr 2013 18:22:16 +0000 (18:22 +0000)]
Removed Chromium layout test results.  Reviewed by Anders Carlsson.  I'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results. Reviewed by Anders Carlsson. I'm using a...
ggaren@apple.com [Thu, 4 Apr 2013 18:19:33 +0000 (18:19 +0000)]
Removed Chromium layout test results.  Reviewed by Anders Carlsson.  I'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results. Reviewed by Anders Carlsson. I'm using a...
ggaren@apple.com [Thu, 4 Apr 2013 18:19:28 +0000 (18:19 +0000)]
Removed Chromium layout test results.  Reviewed by Anders Carlsson.  I'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results. Reviewed by Anders Carlsson. I'm using a...
ggaren@apple.com [Thu, 4 Apr 2013 18:19:24 +0000 (18:19 +0000)]
Removed Chromium layout test results.  Reviewed by Anders Carlsson.  I'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results. Reviewed by Anders Carlsson. I'm using a...
ggaren@apple.com [Thu, 4 Apr 2013 18:19:20 +0000 (18:19 +0000)]
Removed Chromium layout test results.  Reviewed by Anders Carlsson.  I'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results. Reviewed by Anders Carlsson. I'm using a...
ggaren@apple.com [Thu, 4 Apr 2013 18:19:17 +0000 (18:19 +0000)]
Removed Chromium layout test results.  Reviewed by Anders Carlsson.  I'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results. Reviewed by Anders Carlsson. I'm using a...
ggaren@apple.com [Thu, 4 Apr 2013 18:19:15 +0000 (18:19 +0000)]
Removed Chromium layout test results.  Reviewed by Anders Carlsson.  I'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemoved Chromium layout test results.\n\nReviewed by Anders Carlsson.\n\nI'm using...
ggaren@apple.com [Thu, 4 Apr 2013 18:17:56 +0000 (18:17 +0000)]
Removed Chromium layout test results.\n\nReviewed by Anders Carlsson.\n\nI'm using a direct svn http command to try to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
eae@chromium.org [Thu, 4 Apr 2013 18:10:07 +0000 (18:10 +0000)]
Source/WebCore: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825

Reviewed by Eric Seidel.

Tests: fast/frames/invalid-frameset-compute-edge.html

* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::computeEdgeInfo):

LayoutTests: Change RenderFrameSet::computeEdgeInfo to use m-rows/m_cols directly
https://bugs.webkit.org/show_bug.cgi?id=113825

Reviewed by Eric Seidel.

Add test for accessing an invalid frame.

* fast/frames/invalid-frameset-compute-edge-expected.html: Added.
* fast/frames/invalid-frameset-compute-edge.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][AC] Invalid clear ClutterContent of ClutterActor
commit-queue@webkit.org [Thu, 4 Apr 2013 18:00:52 +0000 (18:00 +0000)]
[GTK][AC] Invalid clear ClutterContent of ClutterActor
https://bugs.webkit.org/show_bug.cgi?id=113758

Patch by ChangSeok Oh <changseok.oh@collabora.com> on 2013-04-04
Reviewed by Gustavo Noronha Silva.

Using clutter_actor_set_content(actor, 0) is better to clear ClutterContent of ClutterActor.
Actually the ClutterContent referece is cleared in the API if we set 0.

No new tests since no functionality changed.

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(graphicsLayerActorUpdateTexture):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
ch.dumez@sisa.samsung.com [Thu, 4 Apr 2013 17:59:37 +0000 (17:59 +0000)]
[Cairo] Fix canvas drawing of SVG-based patterns and remove NativeImageCairo
https://bugs.webkit.org/show_bug.cgi?id=113929

Reviewed by Martin Robinson.

Source/WebCore:

Make (Pass)NativeImagePtr typedefs to (Pass)RefPtr<cairo_surface_t> instead
of NativeImageCairo*. Now that we switch to using smart pointers,
NativeImageCairo is removed as it made no sense to make it ref counted when
it merely held a single ref counted member.

Now that Cairo is using smart pointers for (Pass)NativeImagePtr, this patch
also enables the implementation of SVGImage::nativeImageForCurrentFrame()
for USE(CAIRO) as well. This effectively fixes canvas drawing of SVG-based
patterns for Cairo-based ports.

No new tests, covered by svg/canvas/canvas-pattern-svg.html.

* GNUmakefile.list.am: Remove NativeImageCairo.* for GTK.

* PlatformEfl.cmake: Remove NativeImageCairo.* for EFL.

* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
Remove NativeImageCairo.* for Win.

* platform/graphics/BitmapImage.cpp:
(WebCore::FrameData::reportMemoryUsage):
Update MemoryClassInfo::addRawBuffer() call now that m_frame is a RefPtr
for USE(CAIRO).

* platform/graphics/BitmapImage.h:
(BitmapImage):
Remove factory method taking a cairo_surface_t* in argument. This is useless
now that PassNativeImagePtr is a typedef to PassRefPtr<cairo_surface_t> and
there is already a factory method taking a PassNativeImagePtr in argument.

* platform/graphics/NativeImagePtr.h:
(WebCore):
Make PassNativeImagePtr a typedef to PassRefPtr<cairo_surface_t> and
NativeImagePtr a typedef to RefPtr<cairo_surface_t>, instead of
NativeImageCairo*. Moving to smart pointers is needed to enable implementation
of SVGImage::nativeImageForCurrentFrame() for Cairo.

* platform/graphics/cairo/BitmapImageCairo.cpp:
(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::draw):
(WebCore::BitmapImage::checkForSolidColor):
(WebCore::FrameData::clear):
* platform/graphics/cairo/GraphicsContext3DCairo.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
* platform/graphics/cairo/ImageCairo.cpp:
(WebCore::Image::drawPattern):
Update Cairo graphics code to reflect the (Pass)NativeImagePtr type changes.

* platform/graphics/cairo/NativeImageCairo.cpp: Removed.
* platform/graphics/cairo/NativeImageCairo.h: Removed.

* platform/graphics/cairo/PatternCairo.cpp:
(WebCore::Pattern::createPlatformPattern):
* platform/graphics/efl/GraphicsContext3DEfl.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
* platform/graphics/efl/ImageEfl.cpp:
(WebCore::BitmapImage::getEvasObject):
* platform/graphics/gtk/ImageGtk.cpp:
(WebCore::BitmapImage::getGdkPixbuf):
* platform/graphics/texmap/TextureMapperGL.cpp:
(WebCore::BitmapTextureGL::updateContents):
* platform/graphics/win/ImageCairoWin.cpp:
(WebCore::BitmapImage::create):
(WebCore::BitmapImage::drawFrameMatchingSourceSize):
* platform/gtk/DragImageGtk.cpp:
(WebCore::createDragImageFromImage):
* platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
* platform/win/DragImageCairoWin.cpp:
(WebCore::createDragImageFromImage):
Update code to reflect the (Pass)NativeImagePtr type changes.

* svg/graphics/SVGImage.cpp:
(WebCore):
* svg/graphics/SVGImage.h:
Enable SVGImage::nativeImageForCurrentFrame() for USE(CAIRO).

Source/WebKit:

Remove outdated symbols now that NativeImageCairo was removed.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

Source/WebKit/efl:

Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.

* ewk/ewk_history.cpp:
(ewk_history_item_icon_surface_get):
(ewk_history_item_icon_object_add):
* ewk/ewk_settings.cpp:
(ewk_settings_icon_database_icon_surface_get):
(ewk_settings_icon_database_icon_object_get):

Source/WebKit/gtk:

Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.

* webkit/webkitfavicondatabase.cpp:
(getIconPixbufSynchronously):

Source/WebKit/win:

Remove outdated symbols now that NativeImageCairo was removed.

* WebKit.vcproj/WebKitExports.def.in:

Source/WebKit2:

Update code now that PassNativeImagePtr is now a typedef to PassRefPtr<cairo_surface_t>
instead of NativeImageCairo*.

* Shared/gtk/ArgumentCodersGtk.cpp:
(CoreIPC::decodeImage):
* UIProcess/API/C/cairo/WKIconDatabaseCairo.cpp:
(WKIconDatabaseTryGetCairoSurfaceForURL):
* UIProcess/API/gtk/WebKitFaviconDatabase.cpp:
(getIconSurfaceSynchronously):

LayoutTests:

Add EFL / GTK pixels results for svg/canvas/canvas-pattern-svg.html now that
the test passes for cairo-based ports.

* platform/efl/svg/canvas/canvas-pattern-svg-expected.png: Added.
* platform/gtk/svg/canvas/canvas-pattern-svg-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] --minimal build fails with 'error: unused variable'
commit-queue@webkit.org [Thu, 4 Apr 2013 17:48:50 +0000 (17:48 +0000)]
[EFL] --minimal build fails with 'error: unused variable'
https://bugs.webkit.org/show_bug.cgi?id=113903

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gustavo Noronha Silva.

Moved variable definition under #if where it's used
* platform/network/soup/ResourceHandleSoup.cpp:
(WebCore::restartedCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoObjcRuntimeExtras.h should use variadic templates
andersca@apple.com [Thu, 4 Apr 2013 17:30:12 +0000 (17:30 +0000)]
ObjcRuntimeExtras.h should use variadic templates
https://bugs.webkit.org/show_bug.cgi?id=113941

Reviewed by Andreas Kling.

Reimplement wtfObjcMsgSend and wtfCallIMP as variadic function templates.

* wtf/ObjcRuntimeExtras.h:
(wtfObjcMsgSend):
(wtfCallIMP):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix the build with GCC 4.8
abecsi@webkit.org [Thu, 4 Apr 2013 16:40:41 +0000 (16:40 +0000)]
Fix the build with GCC 4.8
https://bugs.webkit.org/show_bug.cgi?id=113147

Reviewed by Allan Sandfeld Jensen.

Source/JavaScriptCore:

Initialize JSObject* exception to suppress warnings that make
the build fail because of -Werror=maybe-uninitialized.

* runtime/Executable.cpp:
(JSC::FunctionExecutable::compileForCallInternal):
(JSC::FunctionExecutable::compileForConstructInternal):

Source/WTF:

Disable diagnostic warning -Wunused-local-typedefs for GCC 4.8
since dummy typedefs are commonly used in the codebase.

* wtf/Compiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGlobal FontPlatformData cache should use OwnPtr.
akling@apple.com [Thu, 4 Apr 2013 16:37:08 +0000 (16:37 +0000)]
Global FontPlatformData cache should use OwnPtr.
<http://webkit.org/b/111939>

Reviewed by Anders Carlsson.

Let the global FontPlatformData use OwnPtr instead of raw pointers + deleteAllValues().

* platform/graphics/FontCache.cpp:
(WebCore::FontCache::getCachedFontPlatformData):
(WebCore::FontCache::purgeInactiveFontData):
(WebCore::FontCache::invalidate):

    Tweaked code for OwnPtr. Also made getCachedFontPlatformData() do one hash lookup
    instead of two.

* platform/graphics/FontCache.h:
* platform/graphics/blackberry/FontCacheBlackBerry.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/chromium/FontCacheAndroid.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/freetype/FontCacheFreeType.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/qt/FontCacheQt.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/skia/FontCacheSkia.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/win/FontCacheWin.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/wince/FontCacheWinCE.cpp:
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/wx/FontCacheWx.cpp:
(WebCore::FontCache::createFontPlatformData):

    FontCache::createFontPlatformData() now returns a PassOwnPtr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRender images with low-quality scaling while FrameView is being resized.
akling@apple.com [Thu, 4 Apr 2013 16:28:43 +0000 (16:28 +0000)]
Render images with low-quality scaling while FrameView is being resized.
<http://webkit.org/b/113764>
<rdar://problem/13555154>

Reviewed by Antti Koivisto.

Have ImageQualityController ask the renderer's containing FrameView if it's currently in live
resize, and if so, paint all images with low-quality scaling. A high-quality repaint will happen
~0.5 sec after live resizing ends, piggybacking on the same mechanism we use to do JS-animated
resizing with low-quality scaling.

This reduces CPU time spent generating new tiles during live window resize, especially on Retina
systems where a lot of upscaling happens on legacy web content.

* rendering/RenderBoxModelObject.cpp:
(ImageQualityController):

    Added an m_liveResizeOptimizationIsActive flag that tracks whether the ImageQualityController
    is painting everything in low quality due to live window resize. It gets unset when the HQ
    repaint timer fires and everything has been repainted properly.

(WebCore::ImageQualityController::highQualityRepaintTimerFired):

    When the HQ repaint timer fires, check if the renderer's containing FrameView is still in
    live resize, and if so, abort HQ repaint for now and reschedule the timer.

(WebCore::ImageQualityController::ImageQualityController):
(WebCore::ImageQualityController::objectDestroyed):
(WebCore::ImageQualityController::shouldPaintAtLowQuality):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] docs: Fix module name format
commit-queue@webkit.org [Thu, 4 Apr 2013 16:18:30 +0000 (16:18 +0000)]
[Qt] docs: Fix module name format
https://bugs.webkit.org/show_bug.cgi?id=113209

Patch by Sze Howe Koh <szehowe.koh@gmail.com> on 2013-04-04
Reviewed by Jocelyn Turcotte.

Make QDoc-generated documentation follow the conventions at
http://qt-project.org/wiki/Spelling_Module_Names_in_Qt_Documentation

Source/WebKit/qt:

* Api/qwebdatabase.cpp:
* Api/qwebkitglobal.cpp:
* Api/qwebpluginfactory.cpp:
* Api/qwebsettings.cpp:
* WidgetApi/qgraphicswebview.cpp:
* WidgetApi/qwebframe.cpp:
* WidgetApi/qwebpage.cpp:
* WidgetApi/qwebview.cpp:
* docs/qtwebkit-bridge.qdoc:
* docs/qtwebkit-goes-mobile.qdoc:
* docs/qtwebkit.qdoc:

Source/WebKit2:

* UIProcess/API/qt/qquickwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix closure compiler warnings in IndexedDBModel.js
commit-queue@webkit.org [Thu, 4 Apr 2013 16:17:00 +0000 (16:17 +0000)]
Web Inspector: fix closure compiler warnings in IndexedDBModel.js
https://bugs.webkit.org/show_bug.cgi?id=113926

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-04
Reviewed by Alexander Pavlov.

No new tests: no change in behaviour.

* inspector/front-end/IndexedDBModel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoREGRESSION (r145870): Can't get insertion point to appear in some input and textareas...
commit-queue@webkit.org [Thu, 4 Apr 2013 16:01:49 +0000 (16:01 +0000)]
REGRESSION (r145870): Can't get insertion point to appear in some input and textareas on wordpress
https://bugs.webkit.org/show_bug.cgi?id=113591

Patch by Xidorn Quan <quanxunzhen@gmail.com> on 2013-04-04
Reviewed by Simon Fraser.

Source/WebCore:

Since a child node could overflow its ancestor, it is not wise to check
one's radii boundary before checking whether the given point intersects
its children. This patch moves the related code down to fix the bug.

Test: fast/borders/border-radius-child.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::nodeAtPoint):

LayoutTests:

* fast/borders/border-radius-child-expected.txt: Added.
* fast/borders/border-radius-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndentation fix to get webkit-patch working again after r147625
pierre.rossi@gmail.com [Thu, 4 Apr 2013 15:53:14 +0000 (15:53 +0000)]
Indentation fix to get webkit-patch working again after r147625

Unreviewed.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
(MacWK2EWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GStreamer] Virtual modifier for MediaPlayer::simulateAudioInterruption must go
commit-queue@webkit.org [Thu, 4 Apr 2013 15:15:15 +0000 (15:15 +0000)]
[GStreamer] Virtual modifier for MediaPlayer::simulateAudioInterruption must go
https://bugs.webkit.org/show_bug.cgi?id=113851

Patch by Xabier Rodriguez Calvar <calvaris@igalia.com> on 2013-04-04
Reviewed by Eric Carlson.

.:

* Source/autotools/symbols.filter: Added
_ZN7WebCore11MediaPlayer25simulateAudioInterruptionEv symbol.

Source/WebCore:

* platform/graphics/MediaPlayer.h:
(MediaPlayer): Removed virtual modifier to
simulateAudioInterruption.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTurn tests back on for Mac WK1/WK2 EWS.
lforschler@apple.com [Thu, 4 Apr 2013 15:06:33 +0000 (15:06 +0000)]
Turn tests back on for Mac WK1/WK2 EWS.

Unreviewed.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(MacEWS):
(MacWK2EWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK][WK2] MiniBrowser custom URI scheme support
commit-queue@webkit.org [Thu, 4 Apr 2013 13:26:22 +0000 (13:26 +0000)]
[GTK][WK2] MiniBrowser custom URI scheme support
https://bugs.webkit.org/show_bug.cgi?id=112419

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-04-04
Reviewed by Carlos Garcia Campos.

Add support for about URIs in MiniBrowser. An example about page is show
with URI "about:minibrowser", the rest of the cases it will show a
proper message explaining that the about page didn't exist.

Internally it uses "minibrowser-about" prefix instead of "about", but
from the user point of view it works with "about" prefix.

* MiniBrowser/gtk/BrowserWindow.c: Add miniBrowserAboutScheme constant.
(getInternalURI): Method to convert URIs from "about" prefix to
"minibrowser-about".
(getExternalURI): Opposite method.
(webViewURIChanged): Use "about" prefix to show the URI to users.
(webViewEnterFullScreen): Ditto.
(browser_window_load_uri): Use "minibrowser-about" prefix internally.
* MiniBrowser/gtk/main.c: Add miniBrowserAboutScheme constant.
(aboutURISchemeRequestCallback): Callback to manage about calls.
(main): Register the URI scheme to manage about URIs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Support -webkit-font-smoothing
allan.jensen@digia.com [Thu, 4 Apr 2013 13:20:17 +0000 (13:20 +0000)]
[Qt] Support -webkit-font-smoothing
https://bugs.webkit.org/show_bug.cgi?id=106009

Reviewed by Jocelyn Turcotte.

Remove false dependency on Qt 5.1 for the -webkit-font-smoothing property.
For now we are still keeping the dependency on Font::shouldUseSmoothing().

* platform/graphics/qt/FontPlatformDataQt.cpp:
(WebCore::FontPlatformData::FontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRegression(r142765) Broke Custom SVG cursors and SVG canvas drawing for Chromium
ch.dumez@sisa.samsung.com [Thu, 4 Apr 2013 12:05:27 +0000 (12:05 +0000)]
Regression(r142765) Broke Custom SVG cursors and SVG canvas drawing for Chromium
https://bugs.webkit.org/show_bug.cgi?id=113420

Reviewed by Stephen White.

Source/WebCore:

Introduce a PassNativeImagePtr typedef that is used in place of NativeImagePtr
for method arguments and return values. This is needed as Skia now maps
NativeImagePtr to RefPtr<NativeImageSkia> and PassNativeImagePtr to
PassRefPtr<NativeImageSkia>. We move towards ref counted smart pointers so that
SVGImage::nativeImageForCurrentFrame() can transfer ownership of the native
image to the caller if needed (e.g. for SVGImage).

Provide nativeImageForCurrentFrame() implementation for SVGImage. SVGImage no
longer holds the native image internally, to save memory. It is therefore created
when nativeImageForCurrentFrame() is called and ownership is passed to the
caller. For now, this implementation is only enabled for Skia as others are using
raw pointers for PassNativeImagePtr.

Test: svg/canvas/canvas-pattern-svg.html

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.

* loader/icon/IconDatabase.h:
(IconDatabase):
* loader/icon/IconDatabaseBase.h:
(WebCore::IconDatabaseBase::synchronousNativeIconForPageURL):
Return a PassNativeImagePtr instead of NativeImagePtr.

* platform/chromium/DragImageChromiumSkia.cpp:
(WebCore::createDragImageFromImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw
one.

* platform/chromium/PasteboardChromium.cpp:
(WebCore::Pasteboard::writeImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr<NativeImageSkia>
instead of a NativeImagePtr. While these are equivalent, the former is more
readable in Skia-specific code.

* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::frameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.

(WebCore::BitmapImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.

* platform/graphics/BitmapImage.h:
(WebCore::BitmapImage::create):
Take a PassNativeImagePtr in argument instead of a NativeImagePtr.

(BitmapImage): Ditto.

* platform/graphics/GraphicsContext.h:
(GraphicsContext): Ditto.

* platform/graphics/GraphicsContext3D.h:
(ImageExtractor):
Keep NativeImageSkia in a RefPtr instead of OwnPtr, now that it is refcounted.

* platform/graphics/Image.h:
(WebCore::Image::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.

* platform/graphics/ImageBuffer.h:
(ImageBuffer):
Have copyNativeImage() return a PassNativeImagePtr instead of a NativeImagePtr.

* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::createFrameAtIndex):
Return a PassNativeImagePtr instead of a NativeImagePtr.

* platform/graphics/ImageSource.h:
Have createFrameAtIndex() return a PassNativeImagePtr instead of a NativeImagePtr.

* platform/graphics/NativeImagePtr.h:
Map NativeImagePtr to a RefPtr<NativeImageSkia> instead of NativeImageSkia* for Skia.
Introduce new PassNativeImagePtr that maps to PassRefPtr<NativeImageSkia> for Skia
and is equivalent to NativeImagePtr for other ports. We now use smart pointers for
the native image so that SVGImage::nativeImageForCurrentFrame() can pass ownership
of the native image to the caller, unlike BitmapImage::nativeImageForCurrentFrame().

* platform/graphics/blackberry/ImageBlackBerry.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

(WebCore::BitmapImage::BitmapImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.

* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawNativeImage): Ditto.

* platform/graphics/cg/ImageBufferCG.cpp:
(WebCore::ImageBuffer::copyNativeImage):
Take a PassNativeImagePtr instead of a NativeImagePtr in argument.

* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::setContentsToImage):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead of a raw one.

* platform/graphics/filters/skia/FEBlendSkia.cpp:
(WebCore::FEBlend::platformApplySkia): Ditto.

* platform/graphics/filters/skia/FEColorMatrixSkia.cpp:
(WebCore::FEColorMatrix::platformApplySkia): Ditto.

* platform/graphics/filters/skia/FEComponentTransferSkia.cpp:
(WebCore::FEComponentTransfer::platformApplySkia): Ditto.

* platform/graphics/filters/skia/FEDisplacementMapSkia.cpp:
(WebCore::FEDisplacementMap::platformApplySkia): Ditto.

* platform/graphics/filters/skia/FELightingSkia.cpp:
(WebCore::FELighting::platformApplySkia): Ditto.

* platform/graphics/qt/ImageDecoderQt.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

* platform/graphics/qt/StillImageQt.cpp:
(WebCore::StillImage::nativeImageForCurrentFrame):
Return a PassNativeImagePtr instead of a NativeImagePtr.

* platform/graphics/qt/StillImageQt.h:
(StillImage): Ditto.

* platform/graphics/skia/GraphicsContext3DSkia.cpp:
(WebCore::GraphicsContext3D::ImageExtractor::extractImage):
No longer need to adopt the return value of asNewNativeImage() now
that it returns a PassRefPtr instead of a raw one.

* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBuffer::copyImage):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
Call NativeImageSkia::create() factory method now that the constructor
is private.

* platform/graphics/skia/ImageSkia.cpp:
(WebCore::FrameData::clear):
Just call clear() on m_frame instead of explicitely deleting it now
that it is a RefPtr.

(WebCore::Image::drawPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.

(WebCore::BitmapImage::BitmapImage):
(WebCore::BitmapImage::checkForSolidColor):
Store return value of frameAtIndex() in a RefPtr instead of a raw one.

(WebCore::BitmapImage::draw):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.

* platform/graphics/skia/NativeImageSkia.cpp:
Add new constructor taking all members in argument. This is used for
cloning a NativeImageSkia object.

(WebCore::NativeImageSkia::NativeImageSkia):
(WebCore::NativeImageSkia::deepSkBitmapCopy):
Add convenience function to make a deep copy of a SkBitmap.

* platform/graphics/skia/NativeImageSkia.h:
(WebCore):
(WebCore::NativeImageSkia::create):
(NativeImageSkia):
Make NativeImageSkia subclass RefCounted. Make the constructor private
and add a factory method instead that returns a PassRefPtr.

(WebCore::NativeImageSkia::clone):
Add a clone() method now that NativeImageSkia is refcounted and is no
longer copyable.

* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformPattern):
Store return value of nativeImageForCurrentFrame() in a RefPtr instead
of a raw one.

* platform/graphics/wince/ImageWinCE.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

* platform/image-decoders/ImageDecoder.h:
(ImageFrame):
Have asNewNativeImage() return a PassNativeImagePtr instead of a
NativeImagePtr.

(WebCore::ImageFrame::getAddr):
(WebCore::ImageFrame::setSkBitmap):
(WebCore::ImageFrame::getSkBitmap):
(WebCore::ImageFrame::width):
(WebCore::ImageFrame::height):
Update use of m_bitmap now that it is a pointer type and call
NativeImageSkia::create() to construct a NativeImageSkia object now
that the constructor is private.

* platform/image-decoders/cairo/ImageDecoderCairo.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

* platform/image-decoders/openvg/ImageDecoderOpenVG.cpp:
(WebCore::ImageFrame::asNewNativeImage): Ditto.

* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::ImageFrame):
Initialize m_bitmap in the constructor now that it is a pointer
type and we need NativeImageSkia's default constructor to be
called.

(WebCore::ImageFrame::operator=):
Call NativeImageSkia's new clone() method to copy m_bitmap as
NativeImageSkia is now RefCounted and no longer copyable.

(WebCore::ImageFrame::clearPixelData):
(WebCore::ImageFrame::zeroFillPixelData):
(WebCore::ImageFrame::copyBitmapData):
(WebCore::ImageFrame::setSize):
Update use of m_bitmap now that it is a pointer type.

(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.
Call NativeImageSkia's clone method now that it is no longer
copyable.

(WebCore::ImageFrame::setHasAlpha):
(WebCore::ImageFrame::setStatus):
Update use of m_bitmap now that it is a pointer type.

* platform/image-decoders/wx/ImageDecoderWx.cpp:
(WebCore::ImageFrame::asNewNativeImage):
Return a PassNativeImagePtr instead of a NativeImagePtr.

* svg/graphics/SVGImage.cpp:
(WebCore):
(WebCore::SVGImage::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() for SVGImage as
it is needed for SVG custom cursor support and Canvas drawing of
patterns containing SVG images. As SVGImage no longer keep the
native image internally to save memory, the implementation creates
the native image when nativeImageForCurrentFrame() and passes
its ownership to the caller.

* svg/graphics/SVGImage.h:
Override Image::nativeImageForCurrentFrame() and remove dummy
implementation of frameAtIndex() as it is not needed / used.

* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::nativeImageForCurrentFrame):
Add implementation of nativeImageForCurrentFrame() which merely
forwards the call to the Image being contained.

* svg/graphics/SVGImageForContainer.h:
Override Image::nativeImageForCurrentFrame().

Source/WebKit/chromium:

Update code now that Image::nativeImageForCurrentFrame() and
ImageFrame::asNewNativeImage() return a smart pointer instead
of a raw one.

* src/WebImageDecoder.cpp:
(WebKit::WebImageDecoder::getFrameAtIndex):
* src/WebImageSkia.cpp:
(WebKit::WebImage::fromData):
(WebKit::WebImage::framesFromData):
(WebKit::WebImage::operator=):
* tests/DeferredImageDecoderTest.cpp:
(WebCore::TEST_F):
* tests/DragImageTest.cpp:
(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):
* tests/ImageLayerChromiumTest.cpp:
(WebCore::TestImage::TestImage):
(WebCore::TestImage::nativeImageForCurrentFrame):
(TestImage):
* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):

LayoutTests:

Add layout test to check that drawing canvas patterns containing SVG images works.

* platform/chromium-linux/svg/canvas/canvas-pattern-svg-expected.png: Added.
* svg/canvas/canvas-pattern-svg-expected.txt: Added.
* svg/canvas/canvas-pattern-svg.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SOUP] inspector/timeline/timeline-receive-response-event.html fails
commit-queue@webkit.org [Thu, 4 Apr 2013 11:11:07 +0000 (11:11 +0000)]
[SOUP] inspector/timeline/timeline-receive-response-event.html fails
https://bugs.webkit.org/show_bug.cgi?id=113860

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-04
Reviewed by Xan Lopez.

Copy the results of inspector/timeline/timeline-receive-response-event.html
to the efl and gtk platform dir.
Because test files are bigger than buffer size of ResourceHandleSoup.

* platform/efl/TestExpectations:
* platform/efl/inspector/timeline/timeline-receive-response-event-expected.txt: Added.
* platform/gtk/TestExpectations:
* platform/gtk/inspector/timeline/timeline-receive-response-event-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSSRegions] RenderFlowThread::renderRegionForLine should use a faster search method
abucur@adobe.com [Thu, 4 Apr 2013 11:10:19 +0000 (11:10 +0000)]
[CSSRegions] RenderFlowThread::renderRegionForLine should use a faster search method
https://bugs.webkit.org/show_bug.cgi?id=66921

Reviewed by David Hyatt.

The RenderFlowThread::regionAtBlockOffset() function is a hot path for the code using
flow threads because it translates from block coordinates to regions.
Currently the method is O(n), using a linear search through the regions chain to find the
region where a block offset lands.
The patch improves this search by using an interval tree (PODIntervalTree). Before a flow
thread is laid out, each region is updated to hold the size of the portion of the flow it
will receive. This information is gathered inside the interval tree and used to speedup the
search in RenderFlowThread::regionAtBlockOffset(). The algorithm uses a custom adapter
simplified for looking up offsets inside the interval tree.
For now, the interval tree is cleared every time the flow thread portions list is updated.
The implementation can be improved but induces some cmplexity as we'd have to manually manage
the life cycle of the tree's nodes. The performance gains are good enough as is to make this
only optional.
Another important change is now the flow thread portion rectangles will not overflow when
using auto-height regions (or very large regions). The maximum size of the flow is set to
LayoutUnit::max()/2. Any region forcing a greater size will be capped so the thread
won't overflow.

Performance test results:
/Layout/RegionsAuto:Time            ms 699.95   181.20  74.11% Better
/Layout/RegionsAutoMaxHeight:Time   ms 2083.00  308.55  85.19% Better
/Layout/RegionsFixed:Time           ms 726.10   223.65  69.20% Better
/Layout/RegionsFixedShort:Time      ms 869.60   288.25  66.85% Better

Tests: See PerformanceTests/Layout/Regions*

* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::regionAtBlockOffset):
(WebCore::RenderFlowThread::updateRegionsFlowThreadPortionRect):
(WebCore::RenderFlowThread::RegionSearchAdapter::collectIfNeeded):
(WebCore):
* rendering/RenderFlowThread.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][Qt] The layout test fast/loader/url-selected-user-gesture.html is failing.
jochen@chromium.org [Thu, 4 Apr 2013 11:07:16 +0000 (11:07 +0000)]
[EFL][Qt] The layout test fast/loader/url-selected-user-gesture.html is failing.
https://bugs.webkit.org/show_bug.cgi?id=113930

Reviewed by Antti Koivisto.

* fast/loader/url-selected-user-gesture.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] WebSocket errors should be logged to console
commit-queue@webkit.org [Thu, 4 Apr 2013 10:52:08 +0000 (10:52 +0000)]
[Qt] WebSocket errors should be logged to console
https://bugs.webkit.org/show_bug.cgi?id=113842

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-04
Reviewed by Jocelyn Turcotte.

Source/WebCore:

Pass the reason of a failure to SocketStreamError instance
and notify it via SocketStreamHandleClient::didFailSocketStream().

Test : http/tests/inspector/console-websocket-error.html

* platform/network/qt/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):
* platform/network/qt/SocketStreamHandleQt.cpp:
(WebCore::SocketStreamHandlePrivate::SocketStreamHandlePrivate):
(WebCore::SocketStreamHandlePrivate::socketErrorCallback):

LayoutTests:

* platform/qt/TestExpectations:
* platform/qt/http/tests/inspector/console-websocket-error-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] WebView should own view size
mikhail.pozdnyakov@intel.com [Thu, 4 Apr 2013 10:47:46 +0000 (10:47 +0000)]
[WK2][EFL] WebView should own view size
https://bugs.webkit.org/show_bug.cgi?id=110753

Reviewed by Andreas Kling.

WebView owns view size. WKViewGetSize and WKViewSetSize API
is exposed accordingly. Usage of EFL-specific ewkView inside
toolkit-agnostic WebView class is reduced.

* UIProcess/API/C/efl/WKView.cpp:
(WKViewGetSize):
(WKViewSetSize):
* UIProcess/API/C/efl/WKView.h:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::setDeviceScaleFactor):
(EwkView::size):
(EwkView::deviceSize):
(EwkView::scheduleUpdateDisplay):
(EwkView::handleEvasObjectCalculate):
* UIProcess/API/efl/EwkView.h:
(EwkView):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::setSize):
(WebKit):
(WebKit::WebView::paintToCurrentGLContext):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::viewSize):
(WebKit::WebView::dipSize):
* UIProcess/efl/WebView.h:
(WebView):
(WebKit::WebView::size):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
kadam@inf.u-szeged.hu [Thu, 4 Apr 2013 09:40:45 +0000 (09:40 +0000)]
[Qt] Unreviewed gardening.

* platform/qt/TestExpectations: Skipped some failing tests.
* platform/qt/fast/borders/rtl-border-04-expected.png: Updated after r147588.
* platform/qt/fast/borders/rtl-border-04-expected.txt: Updated after r147588.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[ATK] build fails when accessibility is turned off
commit-queue@webkit.org [Thu, 4 Apr 2013 08:39:23 +0000 (08:39 +0000)]
[ATK] build fails when accessibility is turned off
https://bugs.webkit.org/show_bug.cgi?id=113699

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-04
Reviewed by Gyuyoung Kim.

* editing/atk/FrameSelectionAtk.cpp: Wrapped accessibility code in #if HAVE(ACCESSIBILITY)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: fix closure compiler warnings in the profiler code HeapSnapshotDataGri...
commit-queue@webkit.org [Thu, 4 Apr 2013 07:59:47 +0000 (07:59 +0000)]
Web Inspector: fix closure compiler warnings in the profiler code HeapSnapshotDataGrids.js
https://bugs.webkit.org/show_bug.cgi?id=113922

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-04
Reviewed by Yury Semikhatsky.

No new tests: no change in behaviour.

* inspector/front-end/HeapSnapshotDataGrids.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Mac] Unreviewed gardening. Rebaseline after r147588.
glenn@skynav.com [Thu, 4 Apr 2013 07:30:13 +0000 (07:30 +0000)]
[Mac] Unreviewed gardening. Rebaseline after r147588.

* platform/mac-lion/fast/text/international/text-combine-image-test-expected.png:
* platform/mac-lion/fast/text/international/text-combine-image-test-expected.txt:
* platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/mac-wk2/fast/text: Added.
* platform/mac-wk2/fast/text/international: Added.
* platform/mac-wk2/fast/text/international/003-expected.png: Added.
* platform/mac-wk2/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/mac-wk2/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Added.
* platform/mac/fast/text/international/003-expected.png:
* platform/mac/fast/text/international/003-expected.txt:
* platform/mac/fast/text/international/text-combine-image-test-expected.png: Added.
* platform/mac/fast/text/international/text-combine-image-test-expected.txt:
* platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVersioning.
lforschler@apple.com [Thu, 4 Apr 2013 06:02:44 +0000 (06:02 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Add a decoration image to search input field
gyuyoung.kim@samsung.com [Thu, 4 Apr 2013 03:52:37 +0000 (03:52 +0000)]
[EFL] Add a decoration image to search input field
https://bugs.webkit.org/show_bug.cgi?id=113552

Reviewed by Laszlo Gombos.

Source/WebCore:

Though EFL port has a decoration image for search input field, we didn't use it.
Start to show it.

Tests: fast/forms/search-cancel-button-style-sharing.html
       fast/forms/search-rtl.html
       fast/css/input-search-padding.html
       fast/css/text-input-with-webkit-border-radius.html
       fast/css/text-overflow-input.html
       fast/forms/box-shadow-override.html
       fast/forms/control-restrict-line-height.html
       fast/forms/input-appearance-height.html
       fast/forms/placeholder-position.html
       fast/forms/placeholder-pseudo-style.html
       fast/forms/search-styled.html
       fast/forms/search-vertical-alignment.html
       fast/forms/searchfield-heights.html
       fast/repaint/search-field-cancel.html
       fast/replaced/width100percent-searchfield.html

* platform/efl/RenderThemeEfl.cpp:
(WebCore):
(WebCore::RenderThemeEfl::supportsDataListUI):
(WebCore::RenderThemeEfl::adjustSearchFieldDecorationStyle):

LayoutTests:

Rebaseline related to input search field.

* platform/efl/fast/css/input-search-padding-expected.png:
* platform/efl/fast/css/input-search-padding-expected.txt:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/efl/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/efl/fast/css/text-overflow-input-expected.png:
* platform/efl/fast/css/text-overflow-input-expected.txt:
* platform/efl/fast/forms/box-shadow-override-expected.png:
* platform/efl/fast/forms/box-shadow-override-expected.txt:
* platform/efl/fast/forms/control-restrict-line-height-expected.png:
* platform/efl/fast/forms/control-restrict-line-height-expected.txt:
* platform/efl/fast/forms/input-appearance-height-expected.png:
* platform/efl/fast/forms/input-appearance-height-expected.txt:
* platform/efl/fast/forms/placeholder-position-expected.png:
* platform/efl/fast/forms/placeholder-position-expected.txt:
* platform/efl/fast/forms/placeholder-pseudo-style-expected.png:
* platform/efl/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/efl/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/efl/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/efl/fast/forms/searchfield-heights-expected.png:
* platform/efl/fast/forms/searchfield-heights-expected.txt:
* platform/efl/fast/repaint/search-field-cancel-expected.png:
* platform/efl/fast/repaint/search-field-cancel-expected.txt:
* platform/efl/fast/replaced/width100percent-searchfield-expected.png:
* platform/efl/fast/replaced/width100percent-searchfield-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening. Below tests aren't related to bug 87619. It just needs to do...
gyuyoung.kim@samsung.com [Thu, 4 Apr 2013 02:16:47 +0000 (02:16 +0000)]
Unreviewed gardening. Below tests aren't related to bug 87619. It just needs to do rebaseline.

* platform/efl/TestExpectations:
* platform/efl/fast/forms/number/number-appearance-rtl-expected.png:
* platform/efl/fast/forms/number/number-appearance-rtl-expected.txt:
* platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.png:
* platform/efl/fast/forms/number/number-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.png:
* platform/efl/fast/forms/number/number-appearance-spinbutton-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRe-enable WinEWS tests.
roger_fong@apple.com [Thu, 4 Apr 2013 01:39:07 +0000 (01:39 +0000)]
Re-enable WinEWS tests.

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoInput value/placeholder is not redrawn when the input height grows
tkent@chromium.org [Thu, 4 Apr 2013 01:16:55 +0000 (01:16 +0000)]
Input value/placeholder is not redrawn when the input height grows
https://bugs.webkit.org/show_bug.cgi?id=113845

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/forms/text/text-height-grow.html

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::styleDidChange):
We need relayout of the inner text element.

LayoutTests:

* fast/forms/text/text-height-grow-expected.html: Added.
* fast/forms/text/text-height-grow.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Unreviewed gardening. Rebaseline after r147588.
glenn@skynav.com [Thu, 4 Apr 2013 01:10:05 +0000 (01:10 +0000)]
[GTK] Unreviewed gardening. Rebaseline after r147588.

* platform/gtk-wk1/fast/writing-mode: Added.
* platform/gtk-wk1/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd comment to clarify isStackingContext() in RenderLayer.h
shawnsingh@chromium.org [Thu, 4 Apr 2013 01:02:57 +0000 (01:02 +0000)]
Add comment to clarify isStackingContext() in RenderLayer.h
https://bugs.webkit.org/show_bug.cgi?id=113909

Reviewed by Simon Fraser.

It was not obvious how the implementation of isStackingContext()
was correct, a comment is appropriate here for anyone who reads
this code in the future.

Just a change in comment, no test needed.

* rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed gardening. Rebaseline after r147588.
glenn@skynav.com [Thu, 4 Apr 2013 00:58:14 +0000 (00:58 +0000)]
[Chromium] Unreviewed gardening. Rebaseline after r147588.

* platform/chromium-mac-lion/fast/text/international/003-expected.png:
* platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.png:
* platform/chromium-mac-lion/fast/text/international/text-combine-image-test-expected.txt:
* platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac-lion/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/text/international/text-combine-image-test-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac/fast/text/international/003-expected.png:
* platform/chromium-mac/fast/text/international/003-expected.txt: Added.
* platform/chromium-mac/fast/text/international/text-combine-image-test-expected.png:
* platform/chromium-mac/fast/text/international/text-combine-image-test-expected.txt:
* platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-mac/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/chromium-win/fast/text/international/003-expected.png:
* platform/chromium-win/fast/text/international/003-expected.txt:
* platform/chromium-win/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt:
* platform/chromium/TestExpectations:
* platform/chromium/fast/text/international/003-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDon't try to set the exception port for server connections
andersca@apple.com [Thu, 4 Apr 2013 00:45:23 +0000 (00:45 +0000)]
Don't try to set the exception port for server connections
https://bugs.webkit.org/show_bug.cgi?id=113910
<rdar://problem/11248925>

Reviewed by Darin Adler.

Treat a SetExceptionPort message to the server connection as an invalid message.

* Platform/CoreIPC/mac/ConnectionMac.cpp:
(CoreIPC::Connection::receiveSourceEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Exclusions] Removed ExclusionShape dead code
hmuller@adobe.com [Thu, 4 Apr 2013 00:05:54 +0000 (00:05 +0000)]
[CSS Exclusions] Removed ExclusionShape dead code
https://bugs.webkit.org/show_bug.cgi?id=113904

Reviewed by Dirk Schulze.

No new tests, just removing dead code.

* rendering/ExclusionShape.cpp:
(WebCore::ExclusionShape::createExclusionShape):
* rendering/ExclusionShape.h:
(ExclusionShape):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. AppleWin port gardening.
roger_fong@apple.com [Wed, 3 Apr 2013 23:44:09 +0000 (23:44 +0000)]
Unreviewed. AppleWin port gardening.

* platform/win/TestExpectations:
* platform/win/fast/lists/inlineBoxWrapperNullCheck-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable HAVE_MADV_FREE_REUSE on iOS
psolanki@apple.com [Wed, 3 Apr 2013 23:16:47 +0000 (23:16 +0000)]
Enable HAVE_MADV_FREE_REUSE on iOS
https://bugs.webkit.org/show_bug.cgi?id=113892
<rdar://problem/12787563>

Reviewed by Mark Rowe.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Switch MediaPlayerPrivateBlackBerry.cpp's timer to use CLOCK_MONOTONIC
commit-queue@webkit.org [Wed, 3 Apr 2013 22:58:32 +0000 (22:58 +0000)]
[BlackBerry] Switch MediaPlayerPrivateBlackBerry.cpp's timer to use CLOCK_MONOTONIC
https://bugs.webkit.org/show_bug.cgi?id=113900

Patch by Otto Derek Cheung <otcheung@rim.com> on 2013-04-03
Reviewed by Rob Buis.
Internally Reviewed by Jeff Rogers.

Timers should use CLOCK_MONOTONIC to avoid undesirable effects when
the user switches the system time.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::drawBufferingAnimation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<http://webkit.org/b/113898> Eliminate some code duplication by introducing an array...
mrowe@apple.com [Wed, 3 Apr 2013 22:54:56 +0000 (22:54 +0000)]
<webkit.org/b/113898> Eliminate some code duplication by introducing an array of handlers to register / unregister.

Reviewed by Antti Koivisto.

* UIProcess/mac/WebContextMac.mm:
(OcclusionNotificationHandler): Structure containing the notification name, type and handler.
(WebKit::registerOcclusionNotificationHandlers): Register all of the handlers in the array.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister all of the handlers in the array.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable process suppression when no windows in the application have drawn recently.
mrowe@apple.com [Wed, 3 Apr 2013 22:54:51 +0000 (22:54 +0000)]
Enable process suppression when no windows in the application have drawn recently.
<http://webkit.org/b/113854> / <rdar://problem/13540351>

Reviewed by Darin Adler.

* UIProcess/mac/WebContextMac.mm:
(WebKit::applicationWindowModificationsStarted): Note that modifications are no longer stopped.
(WebKit::applicationWindowModificationsStopped): Note that modifications have stopped.
(WebKit::registerOcclusionNotificationHandlers): Register handlers for the start and stop notifications.
(WebKit::unregisterOcclusionNotificationHandlers): Unregister handlers for the start and stop notifications.
(WebKit::WebContext::canEnableProcessSuppressionForNetworkProcess): Allow suppression if the application is occluded
or the application has not drawn recently.
(WebKit::WebContext::canEnableProcessSuppressionForWebProcess): Ditto.
(WebKit::WebContext::canEnableProcessSuppressionForGlobalChildProcesses): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnable to focus on embedded plugins such as Flash via javascript focus()
commit-queue@webkit.org [Wed, 3 Apr 2013 22:35:36 +0000 (22:35 +0000)]
Unable to focus on embedded plugins such as Flash via javascript focus()
https://bugs.webkit.org/show_bug.cgi?id=32292

Patch by Dave Michael <dmichael@chromium.org> on 2013-04-03
Reviewed by Ryosuke Niwa.

Source/WebCore:

Make embed, object, and applet elements support focus() when
appropriate. Prior to this patch, javascript focus() had no effect on
embed, object, or applet elements unless tabindex or contenteditable is
set. With this patch, focus() will focus the element unless the plugin
content has failed to load (i.e., we are showing either fallback content
or an unavailable plugin indicator).

Test: plugins/focus.html
      java/focus.html

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::supportsFocus):
Overridden to return true except when the plugin content has failed to load.
* html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInElement::useFallbackContent):
Moved up from HTMLPlugInImageElement.
(WebCore::HTMLPlugInElement::supportsFocus):
* html/HTMLPlugInElement.h:
(WebCore::HTMLPlugInImageElement::useFallbackContent):
Removed. Now the implementation is inherited from HTMLPlugInElement.

LayoutTests:

Add/update testing to ensure embed, object, and applet tags now support
focus except when plugin content did not load.

* fast/events/resources/tabindex-focus-blur-all-frame1.html: Change embed and object
    elements to reference an invalid plugin, to be consistent with applet. These
    element types are not focusable when there is valid plugin content.
* fast/events/resources/tabindex-focus-blur-all-frame2.html: Same as above.
* fast/events/resources/tabindex-focus-blur-all-iframe1.html: Same as above.
* fast/events/resources/tabindex-focus-blur-all-iframe2.html: Same as above.
* java/focus-expected.txt: Added.
* java/focus.html: Added.
* plugins/focus-expected.txt: Added.
* plugins/focus.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoElement boundaries prevent Japanese line break opportunities
glenn@skynav.com [Wed, 3 Apr 2013 21:53:49 +0000 (21:53 +0000)]
Element boundaries prevent Japanese line break opportunities
https://bugs.webkit.org/show_bug.cgi?id=105692

Reviewed by Darin Adler.

Source/WebCore:

Introduce use of prior context when using text break iterators
in non-ASCII path through nextBreakablePosition(). This enables
the use of line break context across an element boundary for
the non-ASCII path. Use of this context with the ASCII path was
enabled by https://bugs.webkit.org/show_bug.cgi?id=17427.

Performance tests of line layout and html5 parsing show that this
patch provides an approximately 4% improvement with Japanese and
no statistically significant regression with ASCII path. Parsing
(html5-full-render) performance is not significantly affected.

Tests: fast/text/line-break-between-text-nodes-cjk.html
       fast/text/line-break-between-text-nodes-latin1.html

Expect rebaselines will be needed due to different line breaks:
       fast/text/international/003.html
       fast/text/international/text-combine-image-test-expected.html
       fast/text/writing-mode/Kusa-Makura-background-canvas.html

* platform/text/TextBreakIterator.cpp:
(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.
* platform/text/TextBreakIterator.h:
(WebCore::LazyLineBreakIterator::priorContextLength): Added.
(WebCore::LazyLineBreakIterator::get): Pass prior context to ICU path.
(WebCore::LazyLineBreakIterator::resetStringAndReleaseIterator): Editorial.
* platform/text/TextBreakIteratorICU.cpp:
Use prior context from line break iterators. Requires
adding new UTF16 (UChar*) text provider and reimplementing
Latin1 (LChar*) text provider. Implementation is optimized
by using generic functionality that applies to both string
sources.
(WebCore::textPinIndex): Added.
(WebCore::textNativeLength): Added.
(WebCore::textFixPointer): Added.
(WebCore::textClone): Added.
(WebCore::textExtract): Added.
(WebCore::textClose): Added.
(WebCore::textGetContext): Added.
(WebCore::textLatin1GetCurrentContext): Added.
(WebCore::textLatin1MoveInPrimaryContext): Added.
(WebCore::textLatin1SwitchToPrimaryContext): Added.
(WebCore::textLatin1MoveInPriorContext): Added.
(WebCore::textLatin1SwitchToPriorContext): Added.
(WebCore::textInChunkOrOutOfRange): Added.
(WebCore::textLatin1Access): Added.
(WebCore::textInit): Added.
(WebCore::textOpenLatin1): Added.
(WebCore::textUTF16GetCurrentContext): Added.
(WebCore::textUTF16MoveInPrimaryContext): Added.
(WebCore::textUTF16SwitchToPrimaryContext): Added.
(WebCore::textUTF16MoveInPriorContext): Added.
(WebCore::textUTF16SwitchToPriorContext): Added.
(WebCore::textUTF16Access): Added.
(WebCore::textOpenUTF16): Added.
(WebCore::acquireLineBreakIterator): Use new text providers with prior context.
* platform/text/wchar/TextBreakIteratorWchar.cpp:
(WebCore::acquireLineBreakIterator): Pass prior context to non-ICU path.
* rendering/break_lines.cpp:
(WebCore::nextBreakablePosition): Use prior context in ICU path.

LayoutTests:

* fast/text/line-break-between-text-nodes-cjk-expected.html: Added.
* fast/text/line-break-between-text-nodes-cjk.html: Added.
* fast/text/line-break-between-text-nodes-latin1-expected.html: Added.
* fast/text/line-break-between-text-nodes-latin1.html: Added.
* platform/chromium-linux/fast/text/international/003-expected.png: Rebaselined.
* platform/chromium-linux/fast/text/international/003-expected.txt: Rebaselined.
* platform/chromium-linux/fast/text/international/text-combine-image-test-expected.png: Rebaselined.
* platform/chromium-linux/fast/text/international/text-combine-image-test-expected.txt: Added (previously missing).
* platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png: Rebaselined.
* platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.txt: Rebaselined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoget_by_pname can become confused when iterating over objects with static properties
mhahnenberg@apple.com [Wed, 3 Apr 2013 21:35:12 +0000 (21:35 +0000)]
get_by_pname can become confused when iterating over objects with static properties
https://bugs.webkit.org/show_bug.cgi?id=113831

Reviewed by Jer Noble.

Improving the test results to make it more obvious why something failed. Also removed
absolute paths from the test.

* fast/js/dom-static-property-for-in-iteration-expected.txt:
* fast/js/dom-static-property-for-in-iteration.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed VS2010 build fix.
roger_fong@apple.com [Wed, 3 Apr 2013 21:21:12 +0000 (21:21 +0000)]
Unreviewed VS2010 build fix.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Bad cast from BitmapImageSingleFrameSkia to BitmapImage
ch.dumez@sisa.samsung.com [Wed, 3 Apr 2013 21:08:30 +0000 (21:08 +0000)]
[Chromium] Bad cast from BitmapImageSingleFrameSkia to BitmapImage
https://bugs.webkit.org/show_bug.cgi?id=113492

Reviewed by Stephen White.

Source/WebCore:

Remove BitmapImageSingleFrameSkia and have ImageBufferSkia construct
BitmapImage objects instead via an intermediate NativeImageSkia.

No new tests, covered by existing tests.

* WebCore.gypi:
* platform/graphics/filters/skia/FEGaussianBlurSkia.cpp: Remove
include for BitmapImageSingleFrameSkia.h header.
* platform/graphics/skia/BitmapImageSingleFrameSkia.cpp: Removed.
* platform/graphics/skia/BitmapImageSingleFrameSkia.h: Removed.
* platform/graphics/skia/ImageBufferSkia.cpp: Construct BitmapImage
objects instead of BitmapImageSingleFrameSkia ones.
(WebCore::ImageBuffer::copyImage):
(WebCore::drawNeedsCopy):
(WebCore::ImageBuffer::draw):
(WebCore::ImageBuffer::drawPattern):
* platform/graphics/skia/ImageSkia.cpp:
(WebCore::BitmapImage::BitmapImage): Implement BitmapImage constructor
that takes an NativeImageSkia* in argument.
(WebCore):
(WebCore::BitmapImage::draw): Remove m_source.initialized() check as
this will return false for BitmapImage objects constructed from a
NativeImageSkia, due to the lack of decoder.
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::NativeImageSkia): Add parameter to the
NativeImageSkia constructor so that the caller can request a deep copy
instead of a shallow one. This is needed by the ImageBuffer.
* platform/graphics/skia/NativeImageSkia.h:
* platform/image-decoders/ImageDecoder.h:
(WebCore::ImageFrame::setSkBitmap):

Source/WebKit/chromium:

Update test now that BitmapImageSingleFrameSkia no longer exists.
BitmapImage is now used instead.

* tests/PlatformContextSkiaTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147583 268f45cc-cd09-0410-ab3c-d52691b4dbfc