WebKit-https.git
9 years ago2010-06-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 14 Jun 2010 01:47:54 +0000 (01:47 +0000)]
2010-06-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        -webkit-transition font-size and font-family
        https://bugs.webkit.org/show_bug.cgi?id=33429

        When animating font-size, update the font with a saved
        version of the font selector to ensure that we don't clobber
        the font family.

        Test: transitions/font-family-during-transition.html

        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::setBlendedFontSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-13 Adam Barth <abarth@webkit.org>
eric@webkit.org [Mon, 14 Jun 2010 01:37:21 +0000 (01:37 +0000)]
2010-06-13  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        webkit-patch should add a bug URL to ChangeLogs if they don't have one yet
        https://bugs.webkit.org/show_bug.cgi?id=39550

        This can cause an extra request to bugs.webkit.org durig upload, but it
        shouldn't be too bad.  Also, this won't work if you remove the
        boilerplate created by prepare-ChangeLog.

        * Scripts/webkitpy/common/checkout/changelog.py:
        * Scripts/webkitpy/common/checkout/changelog_unittest.py:
        * Scripts/webkitpy/common/net/bugzilla.py:
        * Scripts/webkitpy/tool/steps/abstractstep.py:
        * Scripts/webkitpy/tool/steps/preparechangelog.py:
        * Scripts/webkitpy/tool/steps/preparechangelog_unittest.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-13 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 14 Jun 2010 00:58:29 +0000 (00:58 +0000)]
2010-06-13  Tony Chang  <tony@chromium.org>

        Build fix, not reviewed.

        fix chromium compile after r61094 (id attribute refactor)
        https://bugs.webkit.org/show_bug.cgi?id=40553

        * bindings/v8/custom/V8NamedNodesCollection.cpp:
        (WebCore::V8NamedNodesCollection::itemWithName):
2010-06-13  Tony Chang  <tony@chromium.org>

        Build fix, not reviewed.

        fix chromium compile after r61094 (id attribute refactor)
        https://bugs.webkit.org/show_bug.cgi?id=40553

        * src/ChromeClientImpl.cpp:
        * src/WebFormControlElement.cpp:
        (WebKit::WebFormControlElement::nameForAutofill):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated Windows-platform results for the fix for bug 40394.
darin@apple.com [Sun, 13 Jun 2010 19:01:01 +0000 (19:01 +0000)]
Updated Windows-platform results for the fix for bug 40394.
The patch fixed the cross-platform results, GTK results, and Qt results,
but there were Windows results too.

* platform/win/fast/dom/Window/window-property-descriptors-expected.txt:
* platform/win/fast/dom/prototype-inheritance-2-expected.txt:
* platform/win/fast/dom/prototype-inheritance-expected.txt:
* platform/win/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPartly done support for alternate ID attributes should be removed
darin@apple.com [Sun, 13 Jun 2010 17:50:59 +0000 (17:50 +0000)]
Partly done support for alternate ID attributes should be removed
https://bugs.webkit.org/show_bug.cgi?id=39692

Reviewed by Alexey Proskuryakov.

Removed the include of "HTMLNames.h" from "Element.h". This prevents
near-world-rebuilds every time you change HTMLTagNames.in.

Renamed the getIDAttribute function in the Element class to
idForStyleResolution, since it returns a value of the id attribute
that has been lowercased as appropriate for style matching, not the
actual value of the attribute. With the old name it was easy to
misuse it in non-style contexts.

Got rid of the idAttributeName function on Element, since it is
easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
and setIdAttribute functions, which are a good fit for the needs of
most call sites that were dealing with the id attribute.

Added an idAttributeName function to Document. This is for a future
where a document can have a custom id attribute name specified in its
doctype. It's possible this will be insufficient because the same
document might have XHTML or SVG elements in it, and it's possible
that on those elements we will want the attribute named "id" with
no namespace to still work. We can deal with that when we implement
the actual feature, though. For now, it seems OK to fetch the name
of the id attribute from the document.

* dom/DynamicNodeList.cpp:
(WebCore::DynamicNodeList::itemWithName):
* dom/StaticNodeList.cpp:
(WebCore::StaticNodeList::itemWithName):
* rendering/RenderSVGResourceContainer.h:
(WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
(WebCore::RenderSVGResourceContainer::idChanged):
* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::handleDeepUseReferencing):
* svg/animation/SMILTimeContainer.cpp:
(WebCore::SMILTimeContainer::updateAnimations):
Use the new idForStyleResolution function, which is the new name of
the getIDAttribute function. There's a good chance these call sites are
incorrect, which is something we should investigate later, so there's
a FIXME at each call site.

* dom/Document.cpp:
(WebCore::Document::Document): Initialize m_idAttributeName to the
standard id attribute from HTML.
(WebCore::Document::getElementById): Use Element::getIdAttribute.
* dom/Document.h: Added Document::idAttributeName.

* dom/Element.cpp:
(WebCore::Element::setAttribute): Use Document::idAttributeName.
(WebCore::Element::setAttributeMap): Use Element::isIdAttributeName.
(WebCore::Element::insertedIntoDocument): Use Document::idAttributeName.
(WebCore::Element::removedFromDocument): Ditto.
(WebCore::Element::formatForDebugger): Use Element::getIdAttribute.
* dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute,
idForStyleResolution. Removed rareIDAttributeName.

* dom/ElementRareData.h: Removed m_idAttributeName.

* dom/NamedNodeMap.cpp:
(WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.
* dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution,
setIdForStyleResolution, and m_idForStyleResolution since this is not the
value of the id attribute because it gets lowercased for compatibility-mode
documents.

* rendering/RenderIFrame.cpp:
* rendering/RenderLayerCompositor.cpp:
* rendering/RenderProgress.cpp:
Added include of HTMLNames.h now that Element.h no longer includes it.

* editing/SetNodeAttributeCommand.h:
* editing/markup.cpp:
* html/HTMLParser.cpp:
Removed unneeded includes.

* html/HTMLParser.h: Sorted includes.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution.
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.
* dom/Attr.cpp:
(WebCore::Attr::isId): Use Document::idAttributeName.
* dom/StyledElement.cpp:
(WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName,
and setIdForStyleResolution.
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.
* editing/EditorCommand.cpp:
(WebCore::executeInsertHorizontalRule): Ditto.
* html/HTMLAppletElement.cpp:
(WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.
* html/HTMLCollection.cpp:
(WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute.
(WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.
* html/HTMLDataGridColElement.cpp:
(WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute.
(WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.
* html/HTMLElement.cpp:
(WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.
* html/HTMLFormCollection.cpp:
(WebCore::HTMLFormCollection::nextNamedItem): Added missing braces.
(WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.
* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName.
(WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.
* html/HTMLMapElement.cpp:
(WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName.
Also restructured the function a bit to make its structure clearer and added
a comment pointing out that it can't be quite right.
* html/HTMLNameCollection.cpp:
(WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.
* html/HTMLObjectElement.cpp:
(WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.
* html/HTMLParamElement.cpp:
(WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.
* loader/CachedFont.cpp:
(WebCore::CachedFont::getSVGFontById): Use getIdAttribute.
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.
* rendering/SVGRenderTreeAsText.cpp:
(WebCore::writeSVGPaintingResource): Use getIdAttribute.
(WebCore::writeSVGResourceContainer): Ditto.
* svg/SVGElement.cpp:
(WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.
* svg/SVGStyledElement.cpp:
(WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName.
(WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.
* wml/WMLElement.cpp:
(WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Darin Adler <darin@apple.com>
darin@apple.com [Sun, 13 Jun 2010 17:29:10 +0000 (17:29 +0000)]
2010-06-12  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Partly done support for alternate ID attributes should be removed
        https://bugs.webkit.org/show_bug.cgi?id=39692

        Removed the include of "HTMLNames.h" from "Element.h". This prevents
        near-world-rebuilds every time you change HTMLTagNames.in.

        Renamed the getIDAttribute function in the Element class to
        idForStyleResolution, since it returns a value of the id attribute
        that has been lowercased as appropriate for style matching, not the
        actual value of the attribute. With the old name it was easy to
        misuse it in non-style contexts.

        Got rid of the idAttributeName function on Element, since it is
        easy to use it wrong. Replace it with isIdAttributeName, getIdAttribute,
        and setIdAttribute functions, which are a good fit for the needs of
        most call sites that were dealing with the id attribute.

        Added an idAttributeName function to Document. This is for a future
        where a document can have a custom id attribute name specified in its
        doctype. It's possible this will be insufficient because the same
        document might have XHTML or SVG elements in it, and it's possible
        that on those elements we will want the attribute named "id" with
        no namespace to still work. We can deal with that when we implement
        the actual feature, though. For now, it seems OK to fetch the name
        of the id attribute from the document.

        * dom/DynamicNodeList.cpp:
        (WebCore::DynamicNodeList::itemWithName):
        * dom/StaticNodeList.cpp:
        (WebCore::StaticNodeList::itemWithName):
        * rendering/RenderSVGResourceContainer.h:
        (WebCore::RenderSVGResourceContainer::RenderSVGResourceContainer):
        (WebCore::RenderSVGResourceContainer::idChanged):
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::handleDeepUseReferencing):
        * svg/animation/SMILTimeContainer.cpp:
        (WebCore::SMILTimeContainer::updateAnimations):
        Use the new idForStyleResolution function, which is the new name of
        the getIDAttribute function. There's a good chance these call sites are
        incorrect, which is something we should investigate later, so there's
        a FIXME at each call site.

        * dom/Document.cpp:
        (WebCore::Document::Document): Initialize m_idAttributeName to the
        standard id attribute from HTML.
        (WebCore::Document::getElementById): Use Element::getIdAttribute.
        * dom/Document.h: Added Document::idAttributeName.

        * dom/Element.cpp:
        (WebCore::Element::setAttribute): Use Document::idAttributeName.
        (WebCore::Element::setAttributeMap): Use Element::isIdAttributeName.
        (WebCore::Element::insertedIntoDocument): Use Document::idAttributeName.
        (WebCore::Element::removedFromDocument): Ditto.
        (WebCore::Element::formatForDebugger): Use Element::getIdAttribute.
        * dom/Element.h: Added isIdAttributeName, getIdAttribute, setIdAttribute,
        idForStyleResolution. Removed rareIDAttributeName.

        * dom/ElementRareData.h: Removed m_idAttributeName.

        * dom/NamedNodeMap.cpp:
        (WebCore::NamedNodeMap::setAttributes): Use Document::idAttributeName.
        * dom/NamedNodeMap.h: Renamed id, setID, and m_id to idForStyleResolution,
        setIdForStyleResolution, and m_idForStyleResolution since this is not the
        value of the id attribute because it gets lowercased for compatibility-mode
        documents.

        * rendering/RenderIFrame.cpp:
        * rendering/RenderLayerCompositor.cpp:
        * rendering/RenderProgress.cpp:
        Added include of HTMLNames.h now that Element.h no longer includes it.

        * editing/SetNodeAttributeCommand.h:
        * editing/markup.cpp:
        * html/HTMLParser.cpp:
        Removed unneeded includes.

        * html/HTMLParser.h: Sorted includes.

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchRules): Use idForStyleResolution.
        (WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector): Use idForStyleResolution.
        * dom/Attr.cpp:
        (WebCore::Attr::isId): Use Document::idAttributeName.
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::parseMappedAttribute): Use isIdAttributeName,
        and setIdForStyleResolution.
        * editing/DeleteButtonController.cpp:
        (WebCore::DeleteButtonController::createDeletionUI): Use setIdAttribute.
        * editing/EditorCommand.cpp:
        (WebCore::executeInsertHorizontalRule): Ditto.
        * html/HTMLAppletElement.cpp:
        (WebCore::HTMLAppletElement::parseMappedAttribute): Use isIdAttributeName.
        (WebCore::HTMLAppletElement::createRenderer): Use getIdAttribute.
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::checkForNameMatch): Use getIdAttribute.
        (WebCore::HTMLCollection::updateNameCache): Use getIdAttribute.
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::ensureColumn): Use getIdAttribute.
        (WebCore::HTMLDataGridColElement::parseMappedAttribute): Use isIdAttributeName.
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::parseMappedAttribute): Use isIdAttributeName.
        * html/HTMLFormCollection.cpp:
        (WebCore::HTMLFormCollection::nextNamedItem): Added missing braces.
        (WebCore::HTMLFormCollection::updateNameCache): Use getIdAttribute.
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::parseMappedAttribute): Use isIdAttributeName.
        (WebCore::HTMLFrameElementBase::setName): Use getIdAttribute.
        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::parseMappedAttribute): Use isIdAttributeName.
        * html/HTMLMapElement.cpp:
        (WebCore::HTMLMapElement::parseMappedAttribute): Use isIdAttributeName.
        Also restructured the function a bit to make its structure clearer and added
        a comment pointing out that it can't be quite right.
        * html/HTMLNameCollection.cpp:
        (WebCore::HTMLNameCollection::itemAfter): Use getIdAttribute.
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::parseMappedAttribute): Use isIdAttributeName.
        * html/HTMLParamElement.cpp:
        (WebCore::HTMLParamElement::parseMappedAttribute): Use isIdAttributeName.
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::getSVGFontById): Use getIdAttribute.
        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::nameForLayer): Use getIdAttribute.
        * rendering/SVGRenderTreeAsText.cpp:
        (WebCore::writeSVGPaintingResource): Use getIdAttribute.
        (WebCore::writeSVGResourceContainer): Ditto.
        * svg/SVGElement.cpp:
        (WebCore::SVGElement::insertedIntoDocument): Use getIdAttribute.
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::isKnownAttribute): Use isIdAttributeName.
        (WebCore::SVGStyledElement::svgAttributeChanged): Use isIdAttributeName.
        * wml/WMLElement.cpp:
        (WebCore::WMLElement::parseMappedAttribute): Use isIdAttributeName.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdated results after r61092.
mitz@apple.com [Sun, 13 Jun 2010 17:22:05 +0000 (17:22 +0000)]
Updated results after r61092.

* fast/events/continuous-platform-wheelevent-in-scrolling-div-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8087385> REGRESSION (r60974): Continuous wheel scrolling is too fast...
mitz@apple.com [Sun, 13 Jun 2010 16:40:34 +0000 (16:40 +0000)]
<rdar://problem/8087385> REGRESSION (r60974): Continuous wheel scrolling is too fast in list boxes and in Safari Reader
https://bugs.webkit.org/show_bug.cgi?id=40537

Reviewed by Darin Adler.

* platform/mac/WheelEventMac.mm:
(WebCore::PlatformWheelEvent::PlatformWheelEvent): Only multiply by pixelsPerLineStep() if the
event is not continuous, as was before r56012.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCentralize the gperf code generation commands into make-hash-tools.pl
abecsi@webkit.org [Sun, 13 Jun 2010 13:54:07 +0000 (13:54 +0000)]
Centralize the gperf code generation commands into make-hash-tools.pl
to avoid redundancy across multiple build systems.
Do this in preparation of refactoring the usage of these generated
sources to fix the debug linking error on Linux with gcc >= 4.4.0.

WebCore:

Reviewed by Darin Adler.

webkit.org/b/29244

No functionality change, so no new tests needed.

* DerivedSources.make:
* GNUmakefile.am:
* WebCore.gyp/WebCore.gyp:
* WebCore.gyp/scripts/rule_gperf.py: Removed.
* WebCore.pri:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSParser.cpp:
(WebCore::cssPropertyID):
(WebCore::cssValueKeywordID):
* css/makeprop.pl:
* css/makevalues.pl:
* html/DocTypeStrings.gperf:
* html/HTML5EntityParser.cpp:
* html/HTMLDocumentParser.cpp:
* html/HTMLEntityNames.gperf:
* html/PreloadScanner.cpp:
* make-hash-tools.pl: Added.
* platform/ColorData.gperf:
* platform/graphics/Color.cpp:

WebKit/chromium:

Patch by Andras Becsi <abecsi@inf.u-szeged.hu> on 2010-06-13
Reviewed by Darin Adler.

webkit.org/b/29244

* src/WebEntities.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-08 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sun, 13 Jun 2010 13:29:34 +0000 (13:29 +0000)]
2010-06-08  Robert Hogan  <robert@webkit.org>

        Reviewed by Eric Seidel.

        [Qt] Add support for callShouldCloseOnWebView() to DRT
        https://bugs.webkit.org/show_bug.cgi?id=40330

        * platform/qt/Skipped: Unskip fast/events/onbeforeunload-focused-iframe.html
2010-06-08  Robert Hogan  <robert@webkit.org>

        Reviewed by Eric Seidel.

        [Qt] Add support for callShouldCloseOnWebView() to DRT
        https://bugs.webkit.org/show_bug.cgi?id=40330

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::shouldClose):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-06-08  Robert Hogan  <robert@webkit.org>

        Reviewed by Eric Seidel.

        [Qt] Add support for callShouldCloseOnWebView() to DRT
        https://bugs.webkit.org/show_bug.cgi?id=40330

        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::callShouldCloseOnWebView):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::setCallCloseOnWebViews):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sun, 13 Jun 2010 13:05:10 +0000 (13:05 +0000)]
2010-06-13  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] tests/hybridPixmap fails
        https://bugs.webkit.org/show_bug.cgi?id=37316

        The problem was that JSC::Instance::createRuntimeObject was never called.
        This is fixed by overloading newRuntimeObject and calling Instance::createRuntimeObject
        in between, instead of creating the runtime object directly inside the static function
        QtPixmapInstance::createRuntimeObject, which had to be renamed as to not overshadow the virtual function.

        This fixes an existing test, tests/hybridPixmap

        * bridge/qt/qt_pixmapruntime.cpp:
        (JSC::Bindings::QtPixmapInstance::newRuntimeObject):
        (JSC::Bindings::QtPixmapInstance::createPixmapRuntimeObject):
        * bridge/qt/qt_pixmapruntime.h:
        * bridge/qt/qt_runtime.cpp:
        (JSC::Bindings::convertQVariantToValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Unreviewed fix for a linking error with WebKit2LocalizableStringsBundle for...
adachan@apple.com [Sun, 13 Jun 2010 09:11:19 +0000 (09:11 +0000)]
    Unreviewed fix for a linking error with WebKit2LocalizableStringsBundle for Windows release build.

        * WebProcess/win/WebLocalizableStrings.cpp:
        (findCachedString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sun, 13 Jun 2010 08:33:18 +0000 (08:33 +0000)]
2010-06-13  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Darin Adler.

        GraphicsContext3D.h in the Qt port includes too many unnecessary files
        https://bugs.webkit.org/show_bug.cgi?id=40536

        Removed unncessary includes.

        No new tests; Compilation improvement.

        * platform/graphics/GraphicsContext3D.h:
        * platform/graphics/qt/GraphicsContext3DQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-13 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sun, 13 Jun 2010 08:20:22 +0000 (08:20 +0000)]
2010-06-13  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Eric Seidel.

        [Qt] GraphicsLayer: recaching images creates an unnecessary deep copy
        https://bugs.webkit.org/show_bug.cgi?id=40535

        Made sure the painter ends its operation before copying the pixmap.

        No new tests: this is an optimization.

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::recache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-13 Clemmitt Sigler <cmsigler@gmail.com>
eric@webkit.org [Sun, 13 Jun 2010 07:54:21 +0000 (07:54 +0000)]
2010-06-13  Clemmitt Sigler  <cmsigler@gmail.com>

        Reviewed by Eric Seidel.

        Patch to fix missing references to RenderMathMLRoot,
        RenderMathMLSquareRoot when building GtkLauncher.
        https://bugs.webkit.org/show_bug.cgi?id=40326

        No change in functionality so no new tests.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, update Chromium expected result following r61071.
dimich@chromium.org [Sun, 13 Jun 2010 05:50:41 +0000 (05:50 +0000)]
Not reviewed, update Chromium expected result following r61071.

* platform/chromium/fast/dom/prototype-inheritance-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Brian Weinstein <bweinstein@apple.com>
adachan@apple.com [Sun, 13 Jun 2010 05:49:15 +0000 (05:49 +0000)]
2010-06-12  Brian Weinstein  <bweinstein@apple.com>

        Reviewed by Dan Bernstein.

        https://bugs.webkit.org/show_bug.cgi?id=40538

        Some machines have started to see the return of the dreaded: WebCore.lib : fatal error LNK1106: invalid
        file or disk full. Since we don't have the hotfix for VS2005, work around this in the meantime
        by creating an EditingAllInOne file, that includes all of the cpp files in the editing subdirectory.

        * WebCore.vcproj/WebCore.vcproj: Prevnt the editing cpp from building, so we only compile EditingAllInOne.
        * editing/EditingAllInOne.cpp: Added. Includes all of the editing cpp files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Sun, 13 Jun 2010 05:39:00 +0000 (05:39 +0000)]
2010-06-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r61031.
        http://trac.webkit.org/changeset/61031
        https://bugs.webkit.org/show_bug.cgi?id=40539

        Crashes Dromaeo jslib test in Release Chromium (Requested by
        dimich_ on #webkit).

        * bindings/v8/V8Binding.cpp:
        (WebCore::v8ExternalString):
        * bindings/v8/V8Binding.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 13 Jun 2010 05:36:23 +0000 (05:36 +0000)]
2010-06-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Rename the last few *Tokenizer classes (which don't have their own files) to *DocumentParser
        https://bugs.webkit.org/show_bug.cgi?id=40508

        This was a very simple do-webcore-rename-generated patch.

        PluginTokenizer => PluginDocumentParser
        TextTokenizer => TextDocumentParser
        SinkTokenizer => SinkDocumentParser
        MediaTokenizer => MediaDocumentParser
        FTPDirectoryTokenizer => FTPDirectoryDocumentParser

        No functional changes, thus no tests.

        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createTokenizer):
        * html/HTMLViewSourceDocument.h:
        * loader/FTPDirectoryDocument.cpp:
        (WebCore::FTPDirectoryDocumentParser::FTPDirectoryDocumentParser):
        (WebCore::FTPDirectoryDocumentParser::appendEntry):
        (WebCore::FTPDirectoryDocumentParser::createTDForFilename):
        (WebCore::FTPDirectoryDocumentParser::parseAndAppendOneLine):
        (WebCore::FTPDirectoryDocumentParser::loadDocumentTemplate):
        (WebCore::FTPDirectoryDocumentParser::createBasicDocument):
        (WebCore::FTPDirectoryDocumentParser::write):
        (WebCore::FTPDirectoryDocumentParser::finish):
        (WebCore::FTPDirectoryDocument::createTokenizer):
        * loader/MediaDocument.cpp:
        (WebCore::MediaDocumentParser::MediaDocumentParser):
        (WebCore::MediaDocumentParser::write):
        (WebCore::MediaDocumentParser::createDocumentStructure):
        (WebCore::MediaDocumentParser::writeRawData):
        (WebCore::MediaDocumentParser::finish):
        (WebCore::MediaDocumentParser::isWaitingForScripts):
        (WebCore::MediaDocument::createTokenizer):
        * loader/PluginDocument.cpp:
        (WebCore::PluginDocumentParser::PluginDocumentParser):
        (WebCore::PluginDocumentParser::pluginWidgetFromDocument):
        (WebCore::PluginDocumentParser::write):
        (WebCore::PluginDocumentParser::createDocumentStructure):
        (WebCore::PluginDocumentParser::writeRawData):
        (WebCore::PluginDocumentParser::finish):
        (WebCore::PluginDocumentParser::isWaitingForScripts):
        (WebCore::PluginDocument::createTokenizer):
        (WebCore::PluginDocument::pluginWidget):
        * loader/SinkDocument.cpp:
        (WebCore::SinkDocumentParser::SinkDocumentParser):
        (WebCore::SinkDocumentParser::finish):
        (WebCore::SinkDocument::createTokenizer):
        * loader/TextDocument.cpp:
        (WebCore::TextDocumentParser::TextDocumentParser):
        (WebCore::TextDocumentParser::~TextDocumentParser):
        (WebCore::TextDocumentParser::write):
        (WebCore::TextDocumentParser::finish):
        (WebCore::TextDocumentParser::isWaitingForScripts):
        (WebCore::TextDocument::createTokenizer):
        (WebCore::createTextTokenizer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 13 Jun 2010 05:19:33 +0000 (05:19 +0000)]
2010-06-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Daniel Bates.

        do-webcore-rename should have a --verbose option
        https://bugs.webkit.org/show_bug.cgi?id=40497

        * Scripts/do-webcore-rename:
         - Unified how we handle skipping files/directories
           this will allow us to "black list" certain files and
           directories when performing renames.
         - Made do-webcore-rename log what it's skipping when passed --verbose.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago* Scripts/run-bindings-tests: Fixed a typo in a message.
darin@apple.com [Sun, 13 Jun 2010 04:52:19 +0000 (04:52 +0000)]
* Scripts/run-bindings-tests: Fixed a typo in a message.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Sun, 13 Jun 2010 04:46:58 +0000 (04:46 +0000)]
2010-06-12  Anders Bakken  <agbakken@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] EventHandlerQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=40259

        Coding style change only.

        * page/qt/EventHandlerQt.cpp:
        (WebCore::EventHandler::eventActivatedView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Sun, 13 Jun 2010 04:29:06 +0000 (04:29 +0000)]
2010-06-12  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Darin Adler.

        Unify fileSystemRepresentation and filenameFromString
        https://bugs.webkit.org/show_bug.cgi?id=40201

        Remove filenameFromString and use fileSystemRepresentation instead
        as they do the same job.

        * platform/FileSystem.cpp: Removed.
        * platform/FileSystem.h:
        * platform/efl/FileSystemEfl.cpp:
        (WebCore::fileSystemRepresentation):
        * platform/gtk/FileChooserGtk.cpp:
        (WebCore::FileChooser::basenameForWidth):
        * platform/gtk/FileSystemGtk.cpp:
        (WebCore::fileSystemRepresentation):
        (WebCore::filenameForDisplay):
        (WebCore::fileExists):
        (WebCore::deleteFile):
        (WebCore::deleteEmptyDirectory):
        (WebCore::getFileSize):
        (WebCore::getFileModificationTime):
        (WebCore::makeAllDirectories):
        (WebCore::pathGetFileName):
        (WebCore::directoryName):
        (WebCore::listDirectory):
        * platform/gtk/SharedBufferGtk.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::startHttp):
        * platform/posix/SharedBufferPOSIX.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Patrick Gansterer <paroga@paroga.com>
eric@webkit.org [Sun, 13 Jun 2010 04:15:45 +0000 (04:15 +0000)]
2010-06-12  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Eric Seidel.

        [Haiku] Cleanup SharedBuffer::createWithContentsOfFile
        https://bugs.webkit.org/show_bug.cgi?id=39003

        * platform/haiku/SharedBufferHaiku.cpp:
        (WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Anders Bakken <agbakken@gmail.com>
eric@webkit.org [Sun, 13 Jun 2010 04:04:17 +0000 (04:04 +0000)]
2010-06-12  Anders Bakken  <agbakken@gmail.com>

        Reviewed by Eric Seidel.

        [Qt] WheelEventQt.cpp has coding-style errors
        https://bugs.webkit.org/show_bug.cgi?id=39760

        * platform/qt/WheelEventQt.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Sun, 13 Jun 2010 03:41:18 +0000 (03:41 +0000)]
2010-06-12  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Don't include POSIX headers in WebCorePrefix.h
        https://bugs.webkit.org/show_bug.cgi?id=39411

        When building for BREW MP, don't include POSIX headers:
        <fcntl.h>, <pthread.h> and <sys/types.h>.

        * WebCorePrefix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sun, 13 Jun 2010 02:16:46 +0000 (02:16 +0000)]
2010-06-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Rename the rest of the *Tokenizer classes to *DocumentParser
        https://bugs.webkit.org/show_bug.cgi?id=40507

        * wtf/Platform.h:
         - fixed a comment to match new names.
2010-06-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Rename the rest of the *Tokenizer classes to *DocumentParser
        https://bugs.webkit.org/show_bug.cgi?id=40507

        This search/replace was done by do-webcore-rename.
        Just looking for a rubber stamp.

        XMLTokenizer => XMLDocumentParser
        XMLTokenizerLibxml2 => XMLDocumentParserLibxml2
        XMLTokenizerQt => XMLDocumentParserQt
        XMLTokenizerScope => XMLDocumentParserScope
        HTML5Tokenizer => HTML5DocumentParser
        HTMLTokenizer => HTMLDocumentParser

        No functional change, thus no tests.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::checkLoaded):
        * dom/Document.cpp:
        (WebCore::Document::createTokenizer):
        (WebCore::Document::write):
        * dom/Document.h:
        (WebCore::Document::setXMLEncoding):
        * dom/DocumentParser.h:
        (WebCore::DocumentParser::asHTMLTokenizer):
        * dom/Element.cpp:
        * dom/ProcessingInstruction.cpp:
        * dom/XMLDocumentParser.cpp: Added.
        (WebCore::XMLDocumentParser::isWMLDocument):
        (WebCore::XMLDocumentParser::pushCurrentNode):
        (WebCore::XMLDocumentParser::popCurrentNode):
        (WebCore::XMLDocumentParser::clearCurrentNodeStack):
        (WebCore::XMLDocumentParser::write):
        (WebCore::XMLDocumentParser::handleError):
        (WebCore::XMLDocumentParser::enterText):
        (WebCore::toString):
        (WebCore::XMLDocumentParser::exitText):
        (WebCore::XMLDocumentParser::end):
        (WebCore::XMLDocumentParser::finish):
        (WebCore::createXHTMLParserErrorHeader):
        (WebCore::XMLDocumentParser::insertErrorMessageBlock):
        (WebCore::XMLDocumentParser::notifyFinished):
        (WebCore::XMLDocumentParser::isWaitingForScripts):
        (WebCore::XMLDocumentParser::pauseParsing):
        * dom/XMLDocumentParser.h: Added.
        (WebCore::XMLParserContext::context):
        (WebCore::XMLParserContext::XMLParserContext):
        (WebCore::XMLDocumentParser::):
        (WebCore::XMLDocumentParser::setIsXHTMLDocument):
        (WebCore::XMLDocumentParser::isXHTMLDocument):
        (WebCore::XMLDocumentParser::setIsXHTMLMPDocument):
        (WebCore::XMLDocumentParser::isXHTMLMPDocument):
        (WebCore::XMLDocumentParser::wellFormed):
        (WebCore::XMLDocumentParser::context):
        * dom/XMLDocumentParserLibxml2.cpp: Added.
        (WebCore::PendingCallbacks::~PendingCallbacks):
        (WebCore::PendingCallbacks::appendStartElementNSCallback):
        (WebCore::PendingCallbacks::appendEndElementNSCallback):
        (WebCore::PendingCallbacks::appendCharactersCallback):
        (WebCore::PendingCallbacks::appendProcessingInstructionCallback):
        (WebCore::PendingCallbacks::appendCDATABlockCallback):
        (WebCore::PendingCallbacks::appendCommentCallback):
        (WebCore::PendingCallbacks::appendInternalSubsetCallback):
        (WebCore::PendingCallbacks::appendErrorCallback):
        (WebCore::PendingCallbacks::callAndRemoveFirstCallback):
        (WebCore::PendingCallbacks::isEmpty):
        (WebCore::PendingCallbacks::PendingCallback::~PendingCallback):
        (WebCore::PendingCallbacks::PendingStartElementNSCallback::~PendingStartElementNSCallback):
        (WebCore::PendingCallbacks::PendingStartElementNSCallback::call):
        (WebCore::PendingCallbacks::PendingEndElementNSCallback::call):
        (WebCore::PendingCallbacks::PendingCharactersCallback::~PendingCharactersCallback):
        (WebCore::PendingCallbacks::PendingCharactersCallback::call):
        (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::~PendingProcessingInstructionCallback):
        (WebCore::PendingCallbacks::PendingProcessingInstructionCallback::call):
        (WebCore::PendingCallbacks::PendingCDATABlockCallback::~PendingCDATABlockCallback):
        (WebCore::PendingCallbacks::PendingCDATABlockCallback::call):
        (WebCore::PendingCallbacks::PendingCommentCallback::~PendingCommentCallback):
        (WebCore::PendingCallbacks::PendingCommentCallback::call):
        (WebCore::PendingCallbacks::PendingInternalSubsetCallback::~PendingInternalSubsetCallback):
        (WebCore::PendingCallbacks::PendingInternalSubsetCallback::call):
        (WebCore::PendingCallbacks::):
        (WebCore::matchFunc):
        (WebCore::OffsetBuffer::OffsetBuffer):
        (WebCore::OffsetBuffer::readOutBytes):
        (WebCore::shouldAllowExternalLoad):
        (WebCore::openFunc):
        (WebCore::readFunc):
        (WebCore::writeFunc):
        (WebCore::closeFunc):
        (WebCore::errorFunc):
        (WebCore::XMLParserContext::createStringParser):
        (WebCore::XMLParserContext::createMemoryParser):
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLParserContext::~XMLParserContext):
        (WebCore::XMLDocumentParser::~XMLDocumentParser):
        (WebCore::XMLDocumentParser::doWrite):
        (WebCore::toString):
        (WebCore::handleElementNamespaces):
        (WebCore::handleElementAttributes):
        (WebCore::XMLDocumentParser::startElementNs):
        (WebCore::XMLDocumentParser::endElementNs):
        (WebCore::XMLDocumentParser::characters):
        (WebCore::XMLDocumentParser::error):
        (WebCore::XMLDocumentParser::processingInstruction):
        (WebCore::XMLDocumentParser::cdataBlock):
        (WebCore::XMLDocumentParser::comment):
        (WebCore::XMLDocumentParser::startDocument):
        (WebCore::XMLDocumentParser::endDocument):
        (WebCore::XMLDocumentParser::internalSubset):
        (WebCore::getTokenizer):
        (WebCore::hackAroundLibXMLEntityBug):
        (WebCore::startElementNsHandler):
        (WebCore::endElementNsHandler):
        (WebCore::charactersHandler):
        (WebCore::processingInstructionHandler):
        (WebCore::cdataBlockHandler):
        (WebCore::commentHandler):
        (WebCore::warningHandler):
        (WebCore::fatalErrorHandler):
        (WebCore::normalErrorHandler):
        (WebCore::):
        (WebCore::sharedXHTMLEntity):
        (WebCore::getXHTMLEntity):
        (WebCore::getEntityHandler):
        (WebCore::startDocumentHandler):
        (WebCore::endDocumentHandler):
        (WebCore::internalSubsetHandler):
        (WebCore::externalSubsetHandler):
        (WebCore::ignorableWhitespaceHandler):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::doEnd):
        (WebCore::xmlDocPtrForString):
        (WebCore::XMLDocumentParser::lineNumber):
        (WebCore::XMLDocumentParser::columnNumber):
        (WebCore::XMLDocumentParser::stopParsing):
        (WebCore::XMLDocumentParser::resumeParsing):
        (WebCore::parseXMLDocumentFragment):
        (WebCore::attributesStartElementNsHandler):
        (WebCore::parseAttributes):
        * dom/XMLDocumentParserQt.cpp: Added.
        (WebCore::EntityResolver::resolveUndeclaredEntity):
        (WebCore::XMLDocumentParser::XMLDocumentParser):
        (WebCore::XMLDocumentParser::~XMLDocumentParser):
        (WebCore::XMLDocumentParser::doWrite):
        (WebCore::XMLDocumentParser::initializeParserContext):
        (WebCore::XMLDocumentParser::doEnd):
        (WebCore::XMLDocumentParser::lineNumber):
        (WebCore::XMLDocumentParser::columnNumber):
        (WebCore::XMLDocumentParser::stopParsing):
        (WebCore::XMLDocumentParser::resumeParsing):
        (WebCore::parseXMLDocumentFragment):
        (WebCore::attributesStartElementNsHandler):
        (WebCore::parseAttributes):
        (WebCore::prefixFromQName):
        (WebCore::handleElementNamespaces):
        (WebCore::handleElementAttributes):
        (WebCore::XMLDocumentParser::parse):
        (WebCore::XMLDocumentParser::startDocument):
        (WebCore::XMLDocumentParser::parseStartElement):
        (WebCore::XMLDocumentParser::parseEndElement):
        (WebCore::XMLDocumentParser::parseCharacters):
        (WebCore::XMLDocumentParser::parseProcessingInstruction):
        (WebCore::XMLDocumentParser::parseCdata):
        (WebCore::XMLDocumentParser::parseComment):
        (WebCore::XMLDocumentParser::endDocument):
        (WebCore::XMLDocumentParser::hasError):
        (WebCore::XMLDocumentParser::parseDtd):
        * dom/XMLDocumentParserScope.cpp: Added.
        (WebCore::XMLDocumentParserScope::XMLDocumentParserScope):
        (WebCore::XMLDocumentParserScope::~XMLDocumentParserScope):
        * dom/XMLDocumentParserScope.h: Added.
        * dom/XMLTokenizer.cpp: Removed.
        * dom/XMLTokenizer.h: Removed.
        * dom/XMLTokenizerLibxml2.cpp: Removed.
        * dom/XMLTokenizerQt.cpp: Removed.
        * dom/XMLTokenizerScope.cpp: Removed.
        * dom/XMLTokenizerScope.h: Removed.
        * html/HTML5DocumentParser.cpp: Added.
        (WebCore::):
        (WebCore::HTML5DocumentParser::HTML5DocumentParser):
        (WebCore::HTML5DocumentParser::~HTML5DocumentParser):
        (WebCore::HTML5DocumentParser::begin):
        (WebCore::HTML5DocumentParser::pumpLexerIfPossible):
        (WebCore::HTML5DocumentParser::pumpLexer):
        (WebCore::HTML5DocumentParser::write):
        (WebCore::HTML5DocumentParser::end):
        (WebCore::HTML5DocumentParser::attemptToEnd):
        (WebCore::HTML5DocumentParser::endIfDelayed):
        (WebCore::HTML5DocumentParser::finish):
        (WebCore::HTML5DocumentParser::executingScript):
        (WebCore::HTML5DocumentParser::lineNumber):
        (WebCore::HTML5DocumentParser::columnNumber):
        (WebCore::HTML5DocumentParser::htmlParser):
        (WebCore::HTML5DocumentParser::isWaitingForScripts):
        (WebCore::HTML5DocumentParser::resumeParsingAfterScriptExecution):
        (WebCore::HTML5DocumentParser::watchForLoad):
        (WebCore::HTML5DocumentParser::stopWatchingForLoad):
        (WebCore::HTML5DocumentParser::shouldLoadExternalScriptFromSrc):
        (WebCore::HTML5DocumentParser::executeScript):
        (WebCore::HTML5DocumentParser::notifyFinished):
        (WebCore::HTML5DocumentParser::executeScriptsWaitingForStylesheets):
        (WebCore::HTML5DocumentParser::script):
        * html/HTML5DocumentParser.h: Added.
        (WebCore::HTML5DocumentParser::InputStream::InputStream):
        (WebCore::HTML5DocumentParser::InputStream::appendToEnd):
        (WebCore::HTML5DocumentParser::InputStream::insertAtCurrentInsertionPoint):
        (WebCore::HTML5DocumentParser::InputStream::close):
        (WebCore::HTML5DocumentParser::InputStream::current):
        (WebCore::HTML5DocumentParser::InputStream::splitInto):
        (WebCore::HTML5DocumentParser::InputStream::mergeFrom):
        (WebCore::HTML5DocumentParser::InsertionPointRecord::InsertionPointRecord):
        (WebCore::HTML5DocumentParser::InsertionPointRecord::~InsertionPointRecord):
        (WebCore::HTML5DocumentParser::inWrite):
        * html/HTML5Lexer.h:
        (WebCore::HTML5Lexer::columnNumber):
        * html/HTML5Tokenizer.cpp: Removed.
        * html/HTML5Tokenizer.h: Removed.
        * html/HTML5TreeBuilder.cpp:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createTokenizer):
        * html/HTMLDocumentParser.cpp: Added.
        (WebCore::):
        (WebCore::fixUpChar):
        (WebCore::tagMatch):
        (WebCore::Token::addAttribute):
        (WebCore::HTMLDocumentParser::HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::reset):
        (WebCore::HTMLDocumentParser::begin):
        (WebCore::HTMLDocumentParser::setForceSynchronous):
        (WebCore::HTMLDocumentParser::processListing):
        (WebCore::HTMLDocumentParser::parseNonHTMLText):
        (WebCore::HTMLDocumentParser::scriptHandler):
        (WebCore::HTMLDocumentParser::scriptExecution):
        (WebCore::HTMLDocumentParser::parseComment):
        (WebCore::HTMLDocumentParser::parseServer):
        (WebCore::HTMLDocumentParser::parseProcessingInstruction):
        (WebCore::HTMLDocumentParser::parseText):
        (WebCore::HTMLDocumentParser::parseEntity):
        (WebCore::HTMLDocumentParser::parseDoctype):
        (WebCore::HTMLDocumentParser::parseTag):
        (WebCore::HTMLDocumentParser::continueProcessing):
        (WebCore::HTMLDocumentParser::advance):
        (WebCore::HTMLDocumentParser::willWriteHTML):
        (WebCore::HTMLDocumentParser::didWriteHTML):
        (WebCore::HTMLDocumentParser::write):
        (WebCore::HTMLDocumentParser::stopParsing):
        (WebCore::HTMLDocumentParser::processingData):
        (WebCore::HTMLDocumentParser::timerFired):
        (WebCore::HTMLDocumentParser::end):
        (WebCore::HTMLDocumentParser::finish):
        (WebCore::HTMLDocumentParser::processToken):
        (WebCore::HTMLDocumentParser::processDoctypeToken):
        (WebCore::HTMLDocumentParser::~HTMLDocumentParser):
        (WebCore::HTMLDocumentParser::enlargeBuffer):
        (WebCore::HTMLDocumentParser::enlargeScriptBuffer):
        (WebCore::HTMLDocumentParser::executeScriptsWaitingForStylesheets):
        (WebCore::HTMLDocumentParser::notifyFinished):
        (WebCore::HTMLDocumentParser::executeExternalScriptsIfReady):
        (WebCore::HTMLDocumentParser::executeExternalScriptsTimerFired):
        (WebCore::HTMLDocumentParser::continueExecutingExternalScripts):
        (WebCore::HTMLDocumentParser::isWaitingForScripts):
        (WebCore::HTMLDocumentParser::setSrc):
        (WebCore::parseHTMLDocumentFragment):
        (WebCore::decodeNamedEntity):
        * html/HTMLDocumentParser.h: Added.
        (WebCore::Token::Token):
        (WebCore::Token::~Token):
        (WebCore::Token::isOpenTag):
        (WebCore::Token::isCloseTag):
        (WebCore::Token::reset):
        (WebCore::Token::addViewSourceChar):
        (WebCore::):
        (WebCore::DoctypeToken::DoctypeToken):
        (WebCore::DoctypeToken::reset):
        (WebCore::DoctypeToken::state):
        (WebCore::DoctypeToken::setState):
        (WebCore::HTMLDocumentParser::forceSynchronous):
        (WebCore::HTMLDocumentParser::executingScript):
        (WebCore::HTMLDocumentParser::lineNumber):
        (WebCore::HTMLDocumentParser::columnNumber):
        (WebCore::HTMLDocumentParser::processingContentWrittenByScript):
        (WebCore::HTMLDocumentParser::htmlParser):
        (WebCore::HTMLDocumentParser::asHTMLTokenizer):
        (WebCore::HTMLDocumentParser::checkBuffer):
        (WebCore::HTMLDocumentParser::checkScriptBuffer):
        (WebCore::HTMLDocumentParser::):
        (WebCore::HTMLDocumentParser::State::State):
        (WebCore::HTMLDocumentParser::State::tagState):
        (WebCore::HTMLDocumentParser::State::setTagState):
        (WebCore::HTMLDocumentParser::State::entityState):
        (WebCore::HTMLDocumentParser::State::setEntityState):
        (WebCore::HTMLDocumentParser::State::inScript):
        (WebCore::HTMLDocumentParser::State::setInScript):
        (WebCore::HTMLDocumentParser::State::inStyle):
        (WebCore::HTMLDocumentParser::State::setInStyle):
        (WebCore::HTMLDocumentParser::State::inXmp):
        (WebCore::HTMLDocumentParser::State::setInXmp):
        (WebCore::HTMLDocumentParser::State::inTitle):
        (WebCore::HTMLDocumentParser::State::setInTitle):
        (WebCore::HTMLDocumentParser::State::inIFrame):
        (WebCore::HTMLDocumentParser::State::setInIFrame):
        (WebCore::HTMLDocumentParser::State::inPlainText):
        (WebCore::HTMLDocumentParser::State::setInPlainText):
        (WebCore::HTMLDocumentParser::State::inProcessingInstruction):
        (WebCore::HTMLDocumentParser::State::setInProcessingInstruction):
        (WebCore::HTMLDocumentParser::State::inComment):
        (WebCore::HTMLDocumentParser::State::setInComment):
        (WebCore::HTMLDocumentParser::State::inDoctype):
        (WebCore::HTMLDocumentParser::State::setInDoctype):
        (WebCore::HTMLDocumentParser::State::inTextArea):
        (WebCore::HTMLDocumentParser::State::setInTextArea):
        (WebCore::HTMLDocumentParser::State::escaped):
        (WebCore::HTMLDocumentParser::State::setEscaped):
        (WebCore::HTMLDocumentParser::State::inServer):
        (WebCore::HTMLDocumentParser::State::setInServer):
        (WebCore::HTMLDocumentParser::State::skipLF):
        (WebCore::HTMLDocumentParser::State::setSkipLF):
        (WebCore::HTMLDocumentParser::State::startTag):
        (WebCore::HTMLDocumentParser::State::setStartTag):
        (WebCore::HTMLDocumentParser::State::discardLF):
        (WebCore::HTMLDocumentParser::State::setDiscardLF):
        (WebCore::HTMLDocumentParser::State::allowYield):
        (WebCore::HTMLDocumentParser::State::setAllowYield):
        (WebCore::HTMLDocumentParser::State::loadingExtScript):
        (WebCore::HTMLDocumentParser::State::setLoadingExtScript):
        (WebCore::HTMLDocumentParser::State::forceSynchronous):
        (WebCore::HTMLDocumentParser::State::setForceSynchronous):
        (WebCore::HTMLDocumentParser::State::inAnyNonHTMLText):
        (WebCore::HTMLDocumentParser::State::hasTagState):
        (WebCore::HTMLDocumentParser::State::hasEntityState):
        (WebCore::HTMLDocumentParser::State::needsSpecialWriteHandling):
        (WebCore::HTMLDocumentParser::State::):
        (WebCore::HTMLDocumentParser::State::setBit):
        (WebCore::HTMLDocumentParser::State::testBit):
        * html/HTMLElement.cpp:
        * html/HTMLFormControlElement.cpp:
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::reportErrorToConsole):
        * html/HTMLParser.h:
        * html/HTMLTokenizer.cpp: Removed.
        * html/HTMLTokenizer.h: Removed.
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createTokenizer):
        (WebCore::HTMLViewSourceDocument::addViewSourceToken):
        * html/HTMLViewSourceDocument.h:
        * loader/DocumentLoader.cpp:
        * loader/FTPDirectoryDocument.cpp:
        (WebCore::FTPDirectoryTokenizer::FTPDirectoryTokenizer):
        (WebCore::FTPDirectoryTokenizer::loadDocumentTemplate):
        (WebCore::FTPDirectoryTokenizer::finish):
        * loader/FrameLoader.cpp:
        * loader/ImageDocument.cpp:
        * loader/MediaDocument.cpp:
        * loader/PluginDocument.cpp:
        * loader/TextDocument.cpp:
        * page/XSSAuditor.h:
        * svg/SVGDocumentExtensions.cpp:
        * wml/WMLErrorHandling.cpp:
        (WebCore::reportWMLError):
        * xml/XSLStyleSheetLibxslt.cpp:
        (WebCore::XSLStyleSheet::parseString):
        * xml/XSLTProcessor.cpp:
        * xml/XSLTProcessorLibxslt.cpp:
2010-06-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Rename the rest of the *Tokenizer classes to *DocumentParser
        https://bugs.webkit.org/show_bug.cgi?id=40507

        * src/WebEntities.cpp:
         - Fix a comment to match new class names.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Evan Stade <estade@chromium.org>
eric@webkit.org [Sun, 13 Jun 2010 02:09:44 +0000 (02:09 +0000)]
2010-06-12  Evan Stade  <estade@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] Menu key should act on current selection even if it is not editable
        https://bugs.webkit.org/show_bug.cgi?id=40348

        Allow the menu key to act on non-editable selections.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::sendContextMenuEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Andreas Kling <andreas.kling@nokia.com>
eric@webkit.org [Sun, 13 Jun 2010 01:03:54 +0000 (01:03 +0000)]
2010-06-12  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        Window object should have CanvasGradient and CanvasPattern
        https://bugs.webkit.org/show_bug.cgi?id=40394

        Unskipped 2 tests that are now working properly.

        * canvas/philip/tests/2d.gradient.object.return-expected.txt:
        * canvas/philip/tests/2d.pattern.basic.type-expected.txt:
        * fast/dom/Window/window-properties-expected.txt:
        * fast/dom/Window/window-property-descriptors-expected.txt:
        * fast/dom/dom-constructors-expected.txt:
        * fast/dom/prototype-inheritance-2-expected.txt:
        * fast/dom/prototype-inheritance-expected.txt:
        * fast/js/global-constructors-expected.txt:
        * platform/gtk/fast/dom/Window/window-properties-expected.txt:
        * platform/gtk/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/gtk/fast/dom/prototype-inheritance-expected.txt:
        * platform/gtk/fast/js/global-constructors-expected.txt:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/qt/fast/dom/Window/window-properties-expected.txt:
        * platform/qt/fast/dom/Window/window-property-descriptors-expected.txt:
        * platform/qt/fast/dom/prototype-inheritance-expected.txt:
        * platform/qt/fast/js/global-constructors-expected.txt:
2010-06-12  Andreas Kling  <andreas.kling@nokia.com>

        Reviewed by Darin Adler.

        Window object should have CanvasGradient and CanvasPattern
        https://bugs.webkit.org/show_bug.cgi?id=40394

        This fixes the following tests:
        - canvas/philip/tests/2d.gradient.object.return.html
        - canvas/philip/tests/2d.pattern.basic.type.html

        * html/canvas/CanvasGradient.idl:
        * html/canvas/CanvasPattern.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8025267> REGRESSION (Safari 4-TOT): Crash when a frame’s resize handl...
mitz@apple.com [Sat, 12 Jun 2010 23:35:31 +0000 (23:35 +0000)]
<rdar://problem/8025267> REGRESSION (Safari 4-TOT): Crash when a frame’s resize handler removes the frame
https://bugs.webkit.org/show_bug.cgi?id=40534

Reviewed by Oliver Hunt.

WebCore:

Test: fast/replaced/frame-removed-during-resize.html

* rendering/RenderWidget.cpp:
(WebCore::RenderWidget::updateWidgetPosition): Null-check m_widget, since resizing the widget
may trigger an iframe’s resize handler, which may destroy the widget.

LayoutTests:

* fast/replaced/frame-removed-during-resize-expected.txt: Added.
* fast/replaced/frame-removed-during-resize.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoNot reviewed, update for Chromium test expectations.
dimich@chromium.org [Sat, 12 Jun 2010 22:34:23 +0000 (22:34 +0000)]
Not reviewed, update for Chromium test expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Dean Jackson <dino@apple.com>
simon.fraser@apple.com [Sat, 12 Jun 2010 22:16:46 +0000 (22:16 +0000)]
2010-06-12  Dean Jackson  <dino@apple.com>

        Reviewed by Darin Adler.

        Animation keyframe timing functions are applying incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=38963

        When copying RenderStyles, we have to clone the AnimationList so that each keyframe
        can have its own timing function.

        Tests: animations/keyframe-timing-functions-transform.html
               animations/keyframe-timing-functions2.html

        * platform/animation/Animation.h:
        (WebCore::Animation::create):
        * platform/animation/AnimationList.cpp:
        (WebCore::AnimationList::AnimationList):
        * platform/animation/AnimationList.h:
        (WebCore::AnimationList::AnimationList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/7882140> -webkit-column-break-* properties don’t do anything
mitz@apple.com [Sat, 12 Jun 2010 20:05:08 +0000 (20:05 +0000)]
<rdar://problem/7882140> -webkit-column-break-* properties don’t do anything
https://bugs.webkit.org/show_bug.cgi?id=40531

Reviewed by Dave Hyatt.

WebCore:

Test: fast/multicol/break-properties.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::paintChildren): Check for -webkit-column-break-{before,after}: always
and -webkit-column-break-inside: avoid when doing column layout.

LayoutTests:

* fast/multicol/break-properties-expected.txt: Added.
* fast/multicol/break-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Dawit Alemayehu <adawit@kde.org>
eric@webkit.org [Sat, 12 Jun 2010 18:05:11 +0000 (18:05 +0000)]
2010-06-12  Dawit Alemayehu  <adawit@kde.org>

        Reviewed by Kenneth Rohde Christiansen.

        Added an attribute to enable/disable site specific quirks mode in WebKit.
        The attribute is enabled by default.

        https://bugs.webkit.org/show_bug.cgi?id=40073

        * Api/qwebsettings.cpp:
        (QWebSettingsPrivate::apply):
        (QWebSettings::QWebSettings):
        * Api/qwebsettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 12 Jun 2010 16:45:24 +0000 (16:45 +0000)]
2010-06-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Fix tst_qwebframe regression from http://trac.webkit.org/changeset/61062

        Only use cacheableBindingRootObject() if the object has QtOwnership.

        https://bugs.webkit.org/show_bug.cgi?id=40527

        * Api/qwebframe.cpp:
        (QWebFrame::addToJavaScriptWindowObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-13 Robert Hogan <robert@webkit.org>
robert@webkit.org [Sat, 12 Jun 2010 13:41:03 +0000 (13:41 +0000)]
2010-06-13  Robert Hogan  <robert@webkit.org>

        Reviewed by Alexey Proskuryakov.

        FrameLoader::clear() clears JS objects that cached pages later rely on

        https://bugs.webkit.org/show_bug.cgi?id=37725
        https://bugs.webkit.org/show_bug.cgi?id=31626

        Fix the following tests for Qt:

        fast/events/pageshow-pagehide-on-back-cached.html
        fast/events/pageshow-pagehide-on-back-cached-with-frames.html
        fast/loader/input-element-page-cache-crash.html
        fast/dom/Window/timer-resume-on-navigation-back.html
        loader/go-back-to-different-window-size.html
        fast/dom/javascript-url-crash-function.html
        fast/dom/location-new-window-no-crash.html
        http/tests/security/javascriptURL/xss-ALLOWED-from-javascript-url-window-open.html

        which currently fail because the page's Qt-bindings runtime objects are
        cleared when navigating away from the page containing them.

        Track Qt-bindings objects in a separate ScriptController::cacheableRootBindingObject().
        RuntimeObjects tracked by this root object will not get invalidated on page navigations,
        so they will still be available when the pages containing them are retrieved from the
        b/f cache.

        This means the Qt bindings objects will only get cleared on Frame::pageDestroyed().

        * Api/qwebframe.cpp:
        (QWebFrame::addToJavaScriptWindowObject):
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::~ScriptController):
        (WebCore::ScriptController::cacheableBindingRootObject):
        * bindings/js/ScriptController.h:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Sat, 12 Jun 2010 12:44:04 +0000 (12:44 +0000)]
2010-06-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Dimitri Glazkov.

        [Chromium] new-run-webkit-tests --use-drt should work with Chromium checkout
        https://bugs.webkit.org/show_bug.cgi?id=40402

        _build_path() of each Chromium port check existence of build path
        of Chromium checkout first, then check existence of build path of
        WebKit-only checkout.

        * Scripts/webkitpy/layout_tests/port/chromium_linux.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: Can't submit a form with <input type=radio required>
tkent@chromium.org [Sat, 12 Jun 2010 11:33:48 +0000 (11:33 +0000)]
REGRESSION: Can't submit a form with <input type=radio required>
https://bugs.webkit.org/show_bug.cgi?id=40429

Reviewed by Darin Adler.

WebCore:

Validity state was not updated correctly for radio buttons, and it
prevents form submission even if a radio button group has a
checked radio button.

Test: fast/forms/interactive-validation-required-radio.html

* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::updateCheckedRadioButtons):
 Call setNeedsValidityCheck() for all of radio buttons in the same group
 to update validity state.
(WebCore::HTMLInputElement::setChecked):
 Remove setNeedsValidityCheck() call because it is called in
 updateCheckedRadioButtons().

LayoutTests:

* fast/forms/ValidityState-valueMissing-radio-expected.txt:
* fast/forms/interactive-validation-required-radio-expected.txt: Added.
* fast/forms/interactive-validation-required-radio.html: Added.
* fast/forms/script-tests/ValidityState-valueMissing-radio.js:
  We need to test against a radio group with at least three radio buttons
  because we should test behaviors of
  - checked
  - unchecked
  - neither checked nor unchecked

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable interactive form validation in non-strict modes
tkent@chromium.org [Sat, 12 Jun 2010 11:19:02 +0000 (11:19 +0000)]
Disable interactive form validation in non-strict modes
https://bugs.webkit.org/show_bug.cgi?id=40218

Reviewed by Dimitri Glazkov.

WebCore:

The interactive validation feature of HTML5 is not compatible with
HTML4, and users and page authors don't expect existing sites work
differently in WebKit. For example, maxlength and required attributes
in existing sites unexpectedly prevented form submission.
So, we disable the interactive validation feature in non-strict
modes to improve compatibility.

Test: fast/forms/interactive-validation-compat-mode.html
      fast/forms/interactive-validation-html4.html

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::validateInteractively):
 Process interactive validation only in the strict mode.

LayoutTests:

* fast/forms/interactive-validation-compat-mode-expected.txt: Added.
* fast/forms/interactive-validation-compat-mode.html: Added.
* fast/forms/interactive-validation-html4-expected.txt: Added.
* fast/forms/interactive-validation-html4.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 No'am Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Sat, 12 Jun 2010 08:21:56 +0000 (08:21 +0000)]
2010-06-12  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Add documentation to the QtWebkit bridge
        https://bugs.webkit.org/show_bug.cgi?id=35861

        The previous accepted patch was actually a faulty one; It was hard to trace since it's just a documentation
        change. The new patch amends that, with the correct snippets and grammar fixes.

        * docs/qtwebkit-bridge.qdoc:
        * docs/webkitsnippets/qtwebkit_bridge_snippets.cpp:
        (wrapInFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 12 Jun 2010 08:10:24 +0000 (08:10 +0000)]
2010-06-12  Eric Seidel  <eric@webkit.org>

        Reviewed by David Levin.

        Rename Tokenizer to DocumentParser to match what it actually does
        https://bugs.webkit.org/show_bug.cgi?id=40504

        The rename was entirely done by do-webcore-rename.
        The only manual changes were removing out-dated comments
        and fixing Tokenizer_h to DocumentParser_h in the header guards.

        I'll do all the rest of the renames (like the tokenizer subclasses
        and the tokenizer() createTokenizer() methods) in separate changes.

        No functional change, thus no tests.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSHTMLDocumentCustom.cpp:
        * bindings/v8/ScriptEventListener.cpp:
        * dom/Document.cpp:
        (WebCore::Document::createTokenizer):
        * dom/Document.h:
        (WebCore::Document::tokenizer):
        * dom/DocumentParser.h: Added.
        (WebCore::DocumentParser::~DocumentParser):
        (WebCore::DocumentParser::stopParsing):
        (WebCore::DocumentParser::processingData):
        (WebCore::DocumentParser::executingScript):
        (WebCore::DocumentParser::wantsRawData):
        (WebCore::DocumentParser::writeRawData):
        (WebCore::DocumentParser::inViewSourceMode):
        (WebCore::DocumentParser::setInViewSourceMode):
        (WebCore::DocumentParser::wellFormed):
        (WebCore::DocumentParser::lineNumber):
        (WebCore::DocumentParser::columnNumber):
        (WebCore::DocumentParser::executeScriptsWaitingForStylesheets):
        (WebCore::DocumentParser::htmlParser):
        (WebCore::DocumentParser::asHTMLTokenizer):
        (WebCore::DocumentParser::xssAuditor):
        (WebCore::DocumentParser::setXSSAuditor):
        (WebCore::DocumentParser::DocumentParser):
        * dom/Tokenizer.h: Removed.
        * dom/ViewportArguments.cpp:
        (WebCore::reportViewportWarning):
        * dom/XMLTokenizer.h:
        * dom/XMLTokenizerLibxml2.cpp:
        (WebCore::XMLTokenizer::stopParsing):
        * dom/XMLTokenizerQt.cpp:
        (WebCore::XMLTokenizer::stopParsing):
        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::HTML5Tokenizer):
        * html/HTML5Tokenizer.h:
        * html/HTMLDocument.cpp:
        (WebCore::HTMLDocument::createTokenizer):
        * html/HTMLDocument.h:
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::removedFromTree):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::HTMLTokenizer):
        (WebCore::HTMLTokenizer::stopParsing):
        * html/HTMLTokenizer.h:
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createTokenizer):
        * html/HTMLViewSourceDocument.h:
        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::isLoadingInAPISense):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::addData):
        * loader/FTPDirectoryDocument.cpp:
        (WebCore::FTPDirectoryDocument::createTokenizer):
        * loader/FTPDirectoryDocument.h:
        * loader/ImageDocument.cpp:
        (WebCore::ImageDocument::createTokenizer):
        * loader/ImageDocument.h:
        * loader/MediaDocument.cpp:
        (WebCore::MediaDocument::createTokenizer):
        * loader/MediaDocument.h:
        * loader/PluginDocument.cpp:
        (WebCore::PluginDocument::createTokenizer):
        * loader/PluginDocument.h:
        * loader/SinkDocument.cpp:
        (WebCore::SinkDocument::createTokenizer):
        * loader/SinkDocument.h:
        * loader/TextDocument.cpp:
        (WebCore::TextTokenizer::TextTokenizer):
        (WebCore::TextDocument::createTokenizer):
        (WebCore::createTextTokenizer):
        * loader/TextDocument.h:
        * wml/WMLDocument.cpp:
        (WebCore::WMLDocument::finishedParsing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Robert Hogan <robert@webkit.org>
eric@webkit.org [Sat, 12 Jun 2010 07:36:06 +0000 (07:36 +0000)]
2010-06-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Back-forward list dumping is incorrect

        https://bugs.webkit.org/show_bug.cgi?id=36392

        Support dumping child history items in DRT.

        Unskip:

        fast/loader/frame-src-change-added-to-history.html
        fast/loader/frame-src-change-not-added-to-history.html
        fast/loader/frame-location-change-not-added-to-history.html

        * platform/qt/Skipped:
2010-06-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Back-forward list dumping is incorrect

        https://bugs.webkit.org/show_bug.cgi?id=36392

        Support dumping child history items in DRT.

        Unskip:

        fast/loader/frame-src-change-added-to-history.html
        fast/loader/frame-src-change-not-added-to-history.html
        fast/loader/frame-location-change-not-added-to-history.html

        * Api/qwebhistory.cpp:
        (QWebHistoryItemPrivate::core):
        * Api/qwebhistory.h:
        * Api/qwebhistory_p.h:
        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::isTargetItem):
        (DumpRenderTreeSupportQt::historyItemTarget):
        (DumpRenderTreeSupportQt::getChildHistoryItems):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2010-06-12  Robert Hogan  <robert@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Back-forward list dumping is incorrect

        https://bugs.webkit.org/show_bug.cgi?id=36392

        Support dumping child history items in DRT.

        Unskip:

        fast/loader/frame-src-change-added-to-history.html
        fast/loader/frame-src-change-not-added-to-history.html
        fast/loader/frame-location-change-not-added-to-history.html

        * DumpRenderTree/qt/DumpRenderTreeQt.cpp:
        (WebCore::dumpHistoryItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 12 Jun 2010 07:23:19 +0000 (07:23 +0000)]
2010-06-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5Tokenizer needs to tell the InspectorTimelineAgent before and after it writes
        https://bugs.webkit.org/show_bug.cgi?id=40417

        This "fixes" inspector/timeline-script-tag-1.html.  HTML5 results
        differ from the old parser for expected reasons.

        HTML5Tokenizer calls InspectorTimelineAgent::will/didWriteHTML every
        time we pump the lexer instead of every write() call.
        We end up pumping the lexer slightly more often than the old code called
        write() in order to cleanly handle unclosed-entities, unclosed tags,
        buffered characters, etc. at the end of a document.

        I discussed this extensively with James Robinson in #webkit and we decided
        that it was better for the HTML5Tokenizer to call for every pump and
        that the Inspector should later filter out empty pumps.

        We can't filter out empty pumps yet, because the number of parsed
        characters is passed in willWrite instead of didWrite and thus is
        speculative (and wrong).  This is a problem independent of this change
        as willWrite's "length" argument is wrong in different ways for the old
        parser, including always being 0 when the old parser resumes.

        Tested by inspector/timeline-script-tag-1.html

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::willPumpLexer):
         - Notify the InspectorTimelineAgent we're about to process input.
        (WebCore::HTML5Tokenizer::didPumpLexer):
         - Notify the InspectorTimelineAgent we did process tokens.
        (WebCore::HTML5Tokenizer::pumpLexer):
         - Call willPump and didPump
        * html/HTML5Tokenizer.h:
        * inspector/InspectorTimelineAgent.h:
         - Add a FIXME about passing length to didWrite instead of willWrite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Sat, 12 Jun 2010 07:09:53 +0000 (07:09 +0000)]
2010-06-11  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Just updating expectations.

        tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling
        https://bugs.webkit.org/show_bug.cgi?id=40485

        The current HTML5 parser is expected to fail the new webkit01 test.
        It will be fixed when we fix text-node coalescing as discussed in
        the previous commit.

        * html5lib/runner-expected-html5.txt:
        * html5lib/webkit-resumer-expected-html5.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Sat, 12 Jun 2010 06:21:33 +0000 (06:21 +0000)]
2010-06-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r61052.
        http://trac.webkit.org/changeset/61052
        https://bugs.webkit.org/show_bug.cgi?id=40517

        "Broke fast/forms/caret-rtl.html on Mac bots" (Requested by
        eseidel on #webkit).

        * fast/html/hidden-attr-expected.txt: Removed.
        * fast/html/hidden-attr.html: Removed.
2010-06-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r61052.
        http://trac.webkit.org/changeset/61052
        https://bugs.webkit.org/show_bug.cgi?id=40517

        "Broke fast/forms/caret-rtl.html on Mac bots" (Requested by
        eseidel on #webkit).

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::mapToEntry):
        (WebCore::HTMLElement::parseMappedAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Sat, 12 Jun 2010 01:28:18 +0000 (01:28 +0000)]
2010-06-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Ojan Vafai.

        Implement HTML5 hidden attribute
        https://bugs.webkit.org/show_bug.cgi?id=40511

        Test: fast/html/hidden-attr.html

        Note: I used the mapped attribute mechanism for this instead of a rule in the UA stylesheet
        to avoid a performance hit from adding a global attribute rule to the UA stylesheet.

        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::mapToEntry): Pick up hidden as a global mapped attribute.
        (WebCore::HTMLElement::parseMappedAttribute): Map hidden attribute to display: none.
2010-06-11  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Ojan Vafai.

        Implement HTML5 hidden attribute
        https://bugs.webkit.org/show_bug.cgi?id=40511

        * fast/html/hidden-attr-expected.txt: Added.
        * fast/html/hidden-attr.html: Added. Test static and dynamic cases of hidden attribute.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 12 Jun 2010 00:54:40 +0000 (00:54 +0000)]
2010-06-11  Simon Fraser  <simon.fraser@apple.com>

        Add expected result missing from the previous commit.

        * svg/text/text-style-invalid-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Abhishek Arya <inferno@chromium.org>
simon.fraser@apple.com [Sat, 12 Jun 2010 00:52:38 +0000 (00:52 +0000)]
2010-06-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Do not render CSS Styles :first-letter and :first-line in a SVG text element context.
        https://bugs.webkit.org/show_bug.cgi?id=40031

        Test: svg/text/text-style-invalid.svg

        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::firstLineBlock):
        (WebCore::RenderSVGText::updateFirstLetter):
        * rendering/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUse -Os for optimized builds instead of -02. -02 wasn't giving the
weinig@apple.com [Sat, 12 Jun 2010 00:24:16 +0000 (00:24 +0000)]
Use -Os for optimized builds instead of -02. -02 wasn't giving the
right trade off at this time.

Reviewed by Mark Rowe.

* Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove WKRetain and WKRelease overloaded functions out of WKRetainPtr
weinig@apple.com [Sat, 12 Jun 2010 00:17:29 +0000 (00:17 +0000)]
Move WKRetain and WKRelease overloaded functions out of WKRetainPtr
and into the files of the type they overload (eg, WKRetain(WKFrameRef
moves to WKFrame.h)).

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKContext.h:
* UIProcess/API/C/WKFrame.h:
* UIProcess/API/C/WKFramePolicyListener.h:
* UIProcess/API/C/WKNavigationData.h:
* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKPageNamespace.h:
* UIProcess/API/C/WKPreferences.h:
* UIProcess/API/C/WKString.h:
* UIProcess/API/C/WKURL.h:
* UIProcess/API/cpp/WKRetainPtr.h:
* UIProcess/API/win/WKView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 11 Jun 2010 23:55:04 +0000 (23:55 +0000)]
2010-06-10  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        upload all patches that lack in-rietveld to rietveld
        https://bugs.webkit.org/show_bug.cgi?id=40444

        If it's a patch, then we'll try to upload it as long as it
        doesn't have in-rietveld set. No longer set in-rietveld? since
        it's not needed.

        * Scripts/webkitpy/common/net/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 11 Jun 2010 23:44:31 +0000 (23:44 +0000)]
2010-06-11  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy
        https://bugs.webkit.org/show_bug.cgi?id=40506

        Return the data members of WebGLRenderingContext for these
        parameter queries rather than asking OpenGL, which knows nothing
        about them.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getParameter):
2010-06-11  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        getParameter with UNPACK_FLIP_Y_WEBGL and UNPACK_PREMULTIPLY_ALPHA_WEBGL is buggy
        https://bugs.webkit.org/show_bug.cgi?id=40506

        Return the data members of WebGLRenderingContext for these
        parameter queries rather than asking OpenGL, which knows nothing
        about them.

        * fast/canvas/webgl/gl-get-calls-expected.txt:
        * fast/canvas/webgl/gl-get-calls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 11 Jun 2010 23:38:29 +0000 (23:38 +0000)]
2010-06-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dr Dan Bernstein.

        REGRESSION: crash when unloading an iFrame with Flash from the DOM
        https://bugs.webkit.org/show_bug.cgi?id=40161
        <rdar://problem/7994710>

        Null-check the ownerElement of the RenderView's document when unhooking the compositing
        root of an iframe whose layers are parented via the enclosing document. Fixes a crash when
        dynamically removing such an iframe.

        Test: compositing/iframes/remove-iframe-crash.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::detachRootPlatformLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Abhishek Arya <inferno@chromium.org>
jhawkins@chromium.org [Fri, 11 Jun 2010 23:33:27 +0000 (23:33 +0000)]
2010-06-11  Abhishek Arya  <inferno@chromium.org>

        Reviewed by David Hyatt.

        Don't process floats if parent node is not a RenderBlock.
        https://bugs.webkit.org/show_bug.cgi?id=40033

        Test: svg/text/clear-floats-crash.svg

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::clearFloats):
2010-06-11  Abhishek Arya  <inferno@chromium.org>

        Reviewed by David Hyatt.

        Tests that we do not crash when clearing floats during SVG load.
        https://bugs.webkit.org/show_bug.cgi?id=40033

        * svg/text/clear-floats-crash-expected.txt: Added.
        * svg/text/clear-floats-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, fixing Chromium test bots.
dimich@chromium.org [Fri, 11 Jun 2010 22:50:38 +0000 (22:50 +0000)]
Unreviewed, fixing Chromium test bots.

* platform/chromium/test_expectations.txt:
Adding MISSING expectation for the fast/css/nested-rounded-corners.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 11 Jun 2010 22:41:03 +0000 (22:41 +0000)]
2010-06-11  Kenneth Russell  <kbr@google.com>

        Unreviewed, test fix.

        gl-get-calls failing apparently due to UNPACK_ALIGNMENT test
        https://bugs.webkit.org/show_bug.cgi?id=40502

        Disabled new test of UNPACK_ALIGNMENT which appears to be failing
        on some of the bots.

        * fast/canvas/webgl/gl-get-calls-expected.txt:
        * fast/canvas/webgl/gl-get-calls.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Fri, 11 Jun 2010 22:10:41 +0000 (22:10 +0000)]
2010-06-11  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r61036.
        http://trac.webkit.org/changeset/61036
        https://bugs.webkit.org/show_bug.cgi?id=40499

        broke chromium compile (Requested by jamesr on #webkit).

        * bindings/v8/SerializedScriptValue.cpp:
        * bindings/v8/SerializedScriptValue.h:
        (WebCore::SerializedScriptValue::deserializeAndSetProperty):
        (WebCore::SerializedScriptValue::create):
        (WebCore::SerializedScriptValue::createFromWire):
        (WebCore::SerializedScriptValue::release):
        (WebCore::SerializedScriptValue::SerializedScriptValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 11 Jun 2010 22:08:28 +0000 (22:08 +0000)]
2010-06-11  James Robinson  <jamesr@chromium.org>

        Unreviewed baselines for new test on Qt/Gtk.

        https://bugs.webkit.org/show_bug.cgi?id=40456

        Qt and Gtk appear to produce layers of slightly different sizes
        for blocks with rounded corners, probably due to roundoff difference
        in the graphics layers.  Since the diffs are +/- 1 pixel, just
        rebaselining.

        * platform/gtk/fast/css/nested-rounded-corners-expected.txt: Added.
        * platform/qt/fast/css/nested-rounded-corners-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 11 Jun 2010 22:03:49 +0000 (22:03 +0000)]
2010-06-11  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Add texImage2D and texSubImage2D signatures with internal format, etc.
        https://bugs.webkit.org/show_bug.cgi?id=40318

        Added new texImage2D and texSubImage2D entry points following
        WebGL specification changes. Added UNPACK_FLIP_Y_WEBGL and
        UNPACK_PREMULTIPLY_ALPHA_WEBGL pixelStorei parameters, honored
        them for the new entry points taking HTML elements, and added
        support to getParameter. Added warnings to the console for calls
        to the obsolete entry points, which will be removed in a few
        weeks.  Updated all layout tests to use the new entry points and
        pixelStorei parameters, and associated expectations. No other new
        tests.

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::WebGLRenderingContext):
        (WebCore::WebGLRenderingContext::getParameter):
        (WebCore::WebGLRenderingContext::pixelStorei):
        (WebCore::WebGLRenderingContext::texImage2DImpl):
        (WebCore::WebGLRenderingContext::texImage2D):
        (WebCore::WebGLRenderingContext::texSubImage2DImpl):
        (WebCore::WebGLRenderingContext::texSubImage2D):
        (WebCore::WebGLRenderingContext::printWarningToConsole):
        * html/canvas/WebGLRenderingContext.h:
        * html/canvas/WebGLRenderingContext.idl:
        * platform/graphics/GraphicsContext3D.h:
        (WebCore::GraphicsContext3D::):
2010-06-11  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Add texImage2D and texSubImage2D signatures with internal format, etc.
        https://bugs.webkit.org/show_bug.cgi?id=40318

        Added new texImage2D and texSubImage2D entry points following
        WebGL specification changes. Added UNPACK_FLIP_Y_WEBGL and
        UNPACK_PREMULTIPLY_ALPHA_WEBGL pixelStorei parameters, honored
        them for the new entry points taking HTML elements, and added
        support to getParameter. Added warnings to the console for calls
        to the obsolete entry points, which will be removed in a few
        weeks. Updated all layout tests to use the new entry points and
        pixelStorei parameters, and associated expectations. No other new
        tests.

        * fast/canvas/webgl/bug-32364-expected.txt:
        * fast/canvas/webgl/bug-32364.html:
        * fast/canvas/webgl/bug-32888.html:
        * fast/canvas/webgl/gl-get-calls-expected.txt:
        * fast/canvas/webgl/gl-get-calls.html:
        * fast/canvas/webgl/resources/utils3d.js:
        (doLoadImageTexture):
        * fast/canvas/webgl/script-tests/texImageTest.js:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data-expected.txt:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-data.html:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image-expected.txt:
        * fast/canvas/webgl/tex-image-and-sub-image-2d-with-image.html:
        * fast/canvas/webgl/texImage2DImageDataTest.html:
        * fast/canvas/webgl/texImageTest-expected.txt:
        * fast/canvas/webgl/texture-npot.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRoll out the failing part of fast/canvas/webgl/get-active-test.html (failed in Chrome...
zmo@google.com [Fri, 11 Jun 2010 21:33:31 +0000 (21:33 +0000)]
Roll out the failing part of fast/canvas/webgl/get-active-test.html (failed in Chrome in Mac)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 11 Jun 2010 21:08:05 +0000 (21:08 +0000)]
2010-06-11  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Skia mispaints pages with border-radius
        https://bugs.webkit.org/show_bug.cgi?id=40456

        Skia mispaints pages that have border radius set in some cases. The bug is in the anti aliased
        clip path logic used to implement anti aliased curves in Skia.  Since Skia internally only supports
        1-bit clips, anti aliased clipping is emulated by creating a new alpha layer, storing a set of
        clip paths on the side, and then 'erasing' the regions outside the clip.  See r49641.
        PlatformContextSkia maintains a stack of PlatformContextSkia::State objects that preserve information
        like fill color, drawing mode, etc that is manipulated by GraphicsContext::save() /
        GraphicsContext::restore() calls as well some internal functions.  Whenever a new State object is pushed
        a new copy of the current State object is pushed onto the top of this stack using the copy c'tor.  The
        set of anti alias clip paths is also stored on the State object, but not copied when new entries are
        added as the paths only apply to that entry on the stack.

        The bug is that the state stack is stored in a WTF::Vector.  When this vector exceeds its capacity
        (by default at 16 elements) all of the existing State entries are copied into the new buffer using
        State's copy constructor.  This does not preserve the anti alias clip paths, so when the State entries
        are popped the anti aliasing info is lost.  This corrupts all further paint operations since it results
        in inbalanced save/restore calls to the underlying SkCanvas.

        The fix is to make the PlatformContextSkia::State copy constructor copy all fields and to add a new
        function PlatformContextSkia::State::cloneInheritedProperties to use when pushing new State entries
        that copies everything except for the anti aliased clip paths.

        Test: fast/css/nested-rounded-corners.html

        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::State::State):
        (PlatformContextSkia::State::cloneInheritedProperties):
        (PlatformContextSkia::save):
2010-06-11  James Robinson  <jamesr@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] Skia mispaints pages with border-radius
        https://bugs.webkit.org/show_bug.cgi?id=40456

        Tests deeply nested divs with border-radius.

        * fast/css/nested-rounded-corners-expected.txt: Added.
        * fast/css/nested-rounded-corners.html: Added.
        * platform/chromium/test_expectations.txt
        * platform/chromium-linux/fast/css/nested-rounded-corners-expected.checksum: Added.
        * platform/chromium-linux/fast/css/nested-rounded-corners-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Jeremy Orlow <jorlow@chromium.org>
eric@webkit.org [Fri, 11 Jun 2010 20:41:33 +0000 (20:41 +0000)]
2010-06-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        [V8] Clean up SerializedScriptValue
        https://bugs.webkit.org/show_bug.cgi?id=40482

        SerializedScriptValue doesn't follow WebKit's style guidelines very well
        and needlessly inlines quite a bit within the .h file. This change cleans
        things up. No funcitonal changes.

        No change in behavior.

        * bindings/v8/SerializedScriptValue.cpp:
        (WebCore::SerializedScriptValue::deserializeAndSetProperty):
        (WebCore::SerializedScriptValue::create):
        (WebCore::SerializedScriptValue::createFromWire):
        (WebCore::SerializedScriptValue::release):
        (WebCore::SerializedScriptValue::SerializedScriptValue):
        * bindings/v8/SerializedScriptValue.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 James Hawkins <jhawkins@chromium.org>
eric@webkit.org [Fri, 11 Jun 2010 20:20:15 +0000 (20:20 +0000)]
2010-06-11  James Hawkins  <jhawkins@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Notify the WebView when the AutoFill popup hides.

        https://bugs.webkit.org/show_bug.cgi?id=40459

        * src/AutoFillPopupMenuClient.cpp:
        (WebKit::AutoFillPopupMenuClient::selectionCleared):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Jesus Sanchez-Palencia <jesus@webkit.org>
eric@webkit.org [Fri, 11 Jun 2010 19:57:12 +0000 (19:57 +0000)]
2010-06-11  Jesus Sanchez-Palencia  <jesus@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Typo error in QWebPluginFactory Documentation
        https://bugs.webkit.org/show_bug.cgi?id=40490

        * Api/qwebpluginfactory.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 11 Jun 2010 19:37:27 +0000 (19:37 +0000)]
2010-06-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        tables/mozilla/bugs/bug1188.html needlessly depends on HTML Parser text node handling
        https://bugs.webkit.org/show_bug.cgi?id=40485

        The old HTMLTokenizer handled invalid close tags like "< /A>" as part
        of the lexing step.  The HTML5 parser specification dictates that
        the tokenization/lexing step is to output each character token in sequence
        and that the parser is to insert emitted character tokens into the last
        parser-created text node.  In our current HTML5Lexer-with-old-HTMLParser
        setup, we gather up character tokens and output them all in one bunch
        (to match the expectations of the old parser).

        In the case of "foo< /A>" the HTML5Lexer sees the '<', switched out of the
        "data" state and emits all pending characters assuming the start of a close tag.
        When it sees the ' ' it switches back to the "data" state.  The HTML5Lexer
        expects that the parser will coalesce the separate characters it emitted
        into one text node.  Since we haven't implemented the parser side of the
        HTML5 spec, for now we don't.  This is a known issue we will address after
        enabling the HTML5Lexer, as we start to write an HTML5-compliant parser.

        This text-node-coalescing behavior is already tested by numerous html5lib
        tests, however this was the only layout test which hit this quirk.  I've
        added yet another html5lib test of this exact case just for good measure.

        * html5lib/resources/webkit01.dat:
         - Add a test of this exact case to make sure we don't miss it when implementing
           an HTML5-compliant parser.
        * tables/mozilla/bugs/bug1188.html:
         - Replace "< /A>" with "&lt /A>" to avoid hitting this lexing quirk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Fri, 11 Jun 2010 19:23:12 +0000 (19:23 +0000)]
2010-06-11  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Dimitri Glazkov.

        Roll chromium DEPS 49376:49521
        https://bugs.webkit.org/show_bug.cgi?id=40488

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Anton Muhin <antonm@chromium.org>
eric@webkit.org [Fri, 11 Jun 2010 19:11:44 +0000 (19:11 +0000)]
2010-06-11  Anton Muhin  <antonm@chromium.org>

        Reviewed by Adam Barth.

        [v8] Introduce single element caches for WebCore::String to v8::String conversions
        https://bugs.webkit.org/show_bug.cgi?id=40435
        Measurements show that for some web apps (GMail, Wave) and some scenarios
        (intensive reading and/or keeping a tab open for a long time),
        hit rate lies in 30--50% interval.
        Inlining fast case gives another minor performance win.

        * bindings/v8/V8Binding.cpp:
        (WebCore::getStringCache):
        (WebCore::v8ExternalStringSlow):
        * bindings/v8/V8Binding.h:
        (WebCore::v8ExternalString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Leandro Pereira <leandro@profusion.mobi>
eric@webkit.org [Fri, 11 Jun 2010 19:00:08 +0000 (19:00 +0000)]
2010-06-11  Leandro Pereira  <leandro@profusion.mobi>

        Reviewed by Gustavo Noronha Silva.

        [EFL] Build fix: remove unneeded file (npapi.cpp) and add
        other files that got added to the tree.
        http://webkit.org/b/40331

        * CMakeLists.txt:
        * CMakeListsEfl.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, update Chromium test expectations.
dimich@chromium.org [Fri, 11 Jun 2010 18:48:24 +0000 (18:48 +0000)]
Unreviewed, update Chromium test expectations.

* platform/chromium/test_expectations.txt:
http://trac.webkit.org/changeset/60999 regressed acid3.html image match on Chromium Mac.
http://trac.webkit.org/changeset/61020 modified get-active-test.html that now fails on Chromium Mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Fri, 11 Jun 2010 18:46:27 +0000 (18:46 +0000)]
2010-06-11  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Eric Seidel.

        Fix fast/forms/preserveFormDuringResidualStyle.html for HTML5 Parser.
        https://bugs.webkit.org/show_bug.cgi?id=40454

        This required exposing the HTMLParser which we definitely don't want to
        do, but the good news is that it can go away when the HTMLParser goes
        away.

        No new tests because covered by fast/forms/preserve/FormDuringResidualStyle.html.

        * dom/Tokenizer.h:
        (WebCore::Tokenizer::htmlParser):
        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::htmlParser):
        * html/HTML5Tokenizer.h:
        * html/HTML5TreeBuilder.h:
        (WebCore::HTML5TreeBuilder::htmlParser):
        * html/HTMLFormControlElement.cpp:
        (WebCore::HTMLFormControlElement::removedFromTree):
        * html/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::htmlParser):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Kenneth Russell <kbr@google.com>
kbr@google.com [Fri, 11 Jun 2010 18:22:18 +0000 (18:22 +0000)]
2010-06-11  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
        https://bugs.webkit.org/show_bug.cgi?id=40443

        Deleted custom JSC bindings for bufferData, texImage2D and
        texSubImage2D and fixed minor associated issues in code generator
        and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
        which now runs as intended. Ran all layout tests, including WebGL
        tests, in Safari.

        * bindings/js/JSWebGLRenderingContextCustom.cpp:
         - Deleted custom bindings.
        * bindings/scripts/CodeGeneratorJS.pm:
         - Made overload helper functions static to fix compiler warnings.
         - Added needed isObject check for overloads between object and non-object arguments.
         - Added JSValue::encode to exception return path, needed on Leopard in particular.
        * html/HTMLCanvasElement.idl:
        * html/HTMLImageElement.idl:
        * html/HTMLVideoElement.idl:
         - Added GenerateNativeConverter extended attribute.
        * html/canvas/WebGLRenderingContext.idl:
         - Deleted #ifdefs for custom JSC bindings.
2010-06-11  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Delete custom JSC bindings for bufferData, texImage2D and texSubImage2D
        https://bugs.webkit.org/show_bug.cgi?id=40443

        Deleted custom JSC bindings for bufferData, texImage2D and
        texSubImage2D and fixed minor associated issues in code generator
        and IDL. Updated fast/canvas/webgl/texImageTest-expected.txt,
        which now runs as intended. Ran all layout tests, including WebGL
        tests, in Safari.

        * fast/canvas/webgl/script-tests/texImageTest.js:
        * fast/canvas/webgl/texImageTest-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Written by Dave Moore <davemoore@google.com>.
ap@apple.com [Fri, 11 Jun 2010 17:54:27 +0000 (17:54 +0000)]
    Written by Dave Moore <davemoore@google.com>.

        https://bugs.webkit.org/show_bug.cgi?id=22741
        innerHTML, forms and images don't play well together

        This was fixed already (in bug 34076), just landing an additional test.

        * fast/forms/form-image-access-by-name-expected.txt: Added.
        * fast/forms/form-image-access-by-name.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix, add KillRingNone.cpp until we can implement it.
kevino@webkit.org [Fri, 11 Jun 2010 17:42:40 +0000 (17:42 +0000)]
[wx] Build fix, add KillRingNone.cpp until we can implement it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 11 Jun 2010 16:49:29 +0000 (16:49 +0000)]
2010-06-10  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Darin Fisher.

        Fix rietveld upload when message length > 100 characters
        https://bugs.webkit.org/show_bug.cgi?id=40457

        * Scripts/webkitpy/common/net/rietveld.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Hans Wennborg <hans@chromium.org>
eric@webkit.org [Fri, 11 Jun 2010 16:17:05 +0000 (16:17 +0000)]
2010-06-11  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        DOM storage should only create databases when needed
        https://bugs.webkit.org/show_bug.cgi?id=40301

        As soon as a page attempts to use localstorage, StorageAreaSync will
        create an empty database if one doesn't already exist. This can lead to
        lots of unnecessary database files. In particular, they are created
        even when the privacy settings or private browsing mode disallow
        localstorage data, which may seem odd to the user.

        Database creation should be put off in StorageAreaSync until it is time
        to actually write something to the database.

        Tests:
         manual-tests/localstorage-empty-database.html

        * manual-tests/localstorage-empty-database.html: Added.
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::StorageAreaSync):
        (WebCore::StorageAreaSync::openDatabase):
        (WebCore::StorageAreaSync::performImport):
        (WebCore::StorageAreaSync::sync):
        * storage/StorageAreaSync.h:
        (WebCore::StorageAreaSync::):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Ilya Tikhonovsky <loislo@chromium.org>
eric@webkit.org [Fri, 11 Jun 2010 16:04:46 +0000 (16:04 +0000)]
2010-06-11  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Eric Seidel.

        Perl scripts for bindings don't use strict keyword.
        As result some problems in the script code were not detected at compile stage.
        https://bugs.webkit.org/show_bug.cgi?id=40468

        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/IDLParser.pm:
        * bindings/scripts/IDLStructure.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 11 Jun 2010 15:28:48 +0000 (15:28 +0000)]
2010-06-11  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        HTML5Tokenizer should not delete itself while running scripts
        https://bugs.webkit.org/show_bug.cgi?id=40458

        Tested by fast/dom/document-clear.html

        * html/HTML5Tokenizer.cpp:
        (WebCore::HTML5Tokenizer::attemptToEnd):
         - Don't ever end() while running scripts.
           This matches the old HTMLTokenizer.cpp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 11 Jun 2010 15:16:58 +0000 (15:16 +0000)]
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        getActiveUniform must ensure names of arrays end in "[0]"
        https://bugs.webkit.org/show_bug.cgi?id=38709

        * fast/canvas/webgl/get-active-test-expected.txt: Copied from LayoutTests/fast/canvas/webgl/getActiveTest-expected.txt, modified to test array names.
        * fast/canvas/webgl/get-active-test.html: Copied from LayoutTests/fast/canvas/webgl/getActiveTest.html.
        * fast/canvas/webgl/getActiveTest-expected.txt: Removed.
        * fast/canvas/webgl/getActiveTest.html: Removed.
        * fast/canvas/webgl/resources/intArrayUniformShader.vert: Added, with array uniform.
        * fast/canvas/webgl/script-tests/get-active-test.js: Copied from LayoutTests/fast/canvas/webgl/script-tests/getActiveTest.js, modified to test array names.
        * fast/canvas/webgl/script-tests/getActiveTest.js: Removed.
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        getActiveUniform must ensure names of arrays end in "[0]"
        https://bugs.webkit.org/show_bug.cgi?id=38709

        Test: fast/canvas/webgl/get-active-test.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::getActiveAttrib): Append "[0]" to the name if needed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 11 Jun 2010 15:03:34 +0000 (15:03 +0000)]
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        readPixels with negative width/height should generate INVALID_VALUE and return
        https://bugs.webkit.org/show_bug.cgi?id=39704

        * fast/canvas/webgl/read-pixels-expected.txt: Add test cases for non-positive width/height.
        * fast/canvas/webgl/read-pixels.html: Ditto.
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        readPixels with negative width/height should generate INVALID_VALUE and return
        https://bugs.webkit.org/show_bug.cgi?id=39704

        * html/canvas/WebGLRenderingContext.cpp: Deal with negative width/height.
        (WebCore::WebGLRenderingContext::readPixels):
        * html/canvas/WebGLRenderingContext.h: Change width/height type from unsigned long to long.
        * html/canvas/WebGLRenderingContext.idl: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 11 Jun 2010 14:50:28 +0000 (14:50 +0000)]
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        uniform* entry points must ignore the call if a null WebGLUniformLocation is passed
        https://bugs.webkit.org/show_bug.cgi?id=38707

        * fast/canvas/webgl/null-uniform-location-expected.txt: No error is generated if a null WebGLUniformLocation is passed to uniform*().
        * fast/canvas/webgl/script-tests/null-uniform-location.js: Ditto.
        * fast/canvas/webgl/script-tests/uniform-location.js: Ditto.
        * fast/canvas/webgl/uniform-location-expected.txt: Ditto.
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        uniform* entry points must ignore the call if a null WebGLUniformLocation is passed
        https://bugs.webkit.org/show_bug.cgi?id=38707

        * html/canvas/WebGLRenderingContext.cpp: uniform* entry points ignore the call if a null WebGLUniformLocation is passed.
        (WebCore::WebGLRenderingContext::uniform1f):
        (WebCore::WebGLRenderingContext::uniform1fv):
        (WebCore::WebGLRenderingContext::uniform1i):
        (WebCore::WebGLRenderingContext::uniform1iv):
        (WebCore::WebGLRenderingContext::uniform2f):
        (WebCore::WebGLRenderingContext::uniform2fv):
        (WebCore::WebGLRenderingContext::uniform2i):
        (WebCore::WebGLRenderingContext::uniform2iv):
        (WebCore::WebGLRenderingContext::uniform3f):
        (WebCore::WebGLRenderingContext::uniform3fv):
        (WebCore::WebGLRenderingContext::uniform3i):
        (WebCore::WebGLRenderingContext::uniform3iv):
        (WebCore::WebGLRenderingContext::uniform4f):
        (WebCore::WebGLRenderingContext::uniform4fv):
        (WebCore::WebGLRenderingContext::uniform4i):
        (WebCore::WebGLRenderingContext::uniform4iv):
        (WebCore::WebGLRenderingContext::uniformMatrix2fv):
        (WebCore::WebGLRenderingContext::uniformMatrix3fv):
        (WebCore::WebGLRenderingContext::uniformMatrix4fv):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 11 Jun 2010 14:38:42 +0000 (14:38 +0000)]
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        drawElements/drawArrays should validate input parameters according to GLES2 spec
        https://bugs.webkit.org/show_bug.cgi?id=38700

        * fast/canvas/webgl/draw-arrays-out-of-bounds-expected.txt: Copied from LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds-expected.txt, and fix a few test cases.
        * fast/canvas/webgl/draw-arrays-out-of-bounds.html: Copied from LayoutTests/fast/canvas/webgl/drawArraysOutOfBounds.html, and fix a few test cases.
        * fast/canvas/webgl/draw-elements-out-of-bounds-expected.txt: Copied from LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds-expected.txt, and fix a few test cases.
        * fast/canvas/webgl/draw-elements-out-of-bounds.html: Copied from LayoutTests/fast/canvas/webgl/drawElementssOutOfBounds.html, and fix a few test cases.
        * fast/canvas/webgl/drawArraysOutOfBounds-expected.txt: Removed.
        * fast/canvas/webgl/drawArraysOutOfBounds.html: Removed.
        * fast/canvas/webgl/drawElementssOutOfBounds-expected.txt: Removed.
        * fast/canvas/webgl/drawElementssOutOfBounds.html: Removed.
        * fast/canvas/webgl/resources/webgl-test.js: Add helper functions for easy test of gl function errors.
        (getGLErrorAsString):
        (shouldGenerateGLError):
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        drawElements/drawArrays should validate input parameters according to GLES2 spec
        https://bugs.webkit.org/show_bug.cgi?id=38700

        Tests: fast/canvas/webgl/draw-arrays-out-of-bounds.html
               fast/canvas/webgl/draw-elements-out-of-bounds.html

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::drawArrays): Validate input parameters.
        (WebCore::WebGLRenderingContext::drawElements): Ditto.
        (WebCore::WebGLRenderingContext::validateDrawMode): Validate mode for draw{Arrays/Elements}.
        * html/canvas/WebGLRenderingContext.h: Add validateDrawMode, fix incorrect parameter types.
        * html/canvas/WebGLRenderingContext.idl: Fix incorrect parameter types.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Luiz Agostini <luiz.agostini@openbossa.org>, Kenneth Rohde Christiansen...
eric@webkit.org [Fri, 11 Jun 2010 14:25:44 +0000 (14:25 +0000)]
2010-06-11  Luiz Agostini  <luiz.agostini@openbossa.org>, Kenneth Rohde Christiansen <kenneth@webkit.org>

        Reviewed by Antti Koivisto.

        CSS3 Media Queries are not serialized according to CSSOM
        https://bugs.webkit.org/show_bug.cgi?id=39220

        Added test for testing the serialization, plus updated current
        tests to take serialization into account.

        * fast/css/insertRule-media-expected.txt:
        * fast/css/insertRule-media.html:
        * fast/css/resources/insertRule-media.js:
        * fast/media/media-query-serialization-expected.txt: Added.
        * fast/media/media-query-serialization.html: Added.
2010-06-11  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Antti Koivisto.

        CSS3 Media Queries are not serialized according to CSSOM
        https://bugs.webkit.org/show_bug.cgi?id=39220

        MediaQuery serialization according to specification
        http://dev.w3.org/csswg/cssom/#serializing-media-queries.

        MediaQuery objects now ignore duplicated expressions. MediaQueryEvaluator::eval()
        now does not proccess MediaQuery objects that are known to be invalid.

        Test: fast/media/media-query-serialization.html

        * css/MediaQuery.cpp:
        (WebCore::stringCompare):
        (WebCore::MediaQuery::serialize):
        (WebCore::MediaQuery::MediaQuery):
        (WebCore::MediaQuery::~MediaQuery):
        (WebCore::MediaQuery::operator==):
        (WebCore::MediaQuery::cssText):
        (WebCore::MediaQuery::append):
        * css/MediaQuery.h:
        (WebCore::MediaQuery::ignored):
        (WebCore::MediaQuery::begin):
        (WebCore::MediaQuery::end):
        * css/MediaQueryExp.cpp:
        (WebCore::MediaQueryExp::serialize):
        * css/MediaQueryExp.h:
        * css/MediaQueryEvaluator.cpp:
        (WebCore::MediaQueryEvaluator::eval):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Fri, 11 Jun 2010 14:02:44 +0000 (14:02 +0000)]
2010-06-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Implement more of IndexedDB's Indexes and ObjectStores
        https://bugs.webkit.org/show_bug.cgi?id=40424

        Clean up both of these classes a bit and add create/open/remove
        methods as needed.

        Tests in a future patch (promise).

        * storage/IDBDatabase.h:
        * storage/IDBDatabaseImpl.cpp:
        (WebCore::IDBDatabaseImpl::objectStores):
        (WebCore::IDBDatabaseImpl::createObjectStore):
        (WebCore::IDBDatabaseImpl::objectStore):
        (WebCore::IDBDatabaseImpl::removeObjectStore):
        * storage/IDBDatabaseImpl.h:
        (WebCore::IDBDatabaseImpl::name):
        (WebCore::IDBDatabaseImpl::description):
        (WebCore::IDBDatabaseImpl::version):
        * storage/IDBDatabaseRequest.cpp:
        (WebCore::IDBDatabaseRequest::IDBDatabaseRequest):
        (WebCore::IDBDatabaseRequest::createObjectStore):
        (WebCore::IDBDatabaseRequest::objectStore):
        (WebCore::IDBDatabaseRequest::removeObjectStore):
        * storage/IDBDatabaseRequest.h:
        (WebCore::IDBDatabaseRequest::create):
        (WebCore::IDBDatabaseRequest::name):
        (WebCore::IDBDatabaseRequest::description):
        (WebCore::IDBDatabaseRequest::version):
        (WebCore::IDBDatabaseRequest::objectStores):
        * storage/IDBDatabaseRequest.idl:
        * storage/IDBObjectStore.h:
        * storage/IDBObjectStoreImpl.h:
        * storage/IDBObjectStoreRequest.cpp:
        (WebCore::IDBObjectStoreRequest::get):
        (WebCore::IDBObjectStoreRequest::add):
        (WebCore::IDBObjectStoreRequest::modify):
        (WebCore::IDBObjectStoreRequest::addOrModify):
        (WebCore::IDBObjectStoreRequest::remove):
        (WebCore::IDBObjectStoreRequest::createIndex):
        (WebCore::IDBObjectStoreRequest::index):
        (WebCore::IDBObjectStoreRequest::removeIndex):
        * storage/IDBObjectStoreRequest.h:
        * storage/IDBObjectStoreRequest.idl:
2010-06-10  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Implement more of IndexedDB's Indexes and ObjectStores
        https://bugs.webkit.org/show_bug.cgi?id=40424

        Add plumbing for both of these classes.

        * public/WebIDBDatabase.h:
        (WebKit::WebIDBDatabase::name):
        (WebKit::WebIDBDatabase::description):
        (WebKit::WebIDBDatabase::version):
        (WebKit::WebIDBDatabase::objectStores):
        (WebKit::WebIDBDatabase::objectStore):
        (WebKit::WebIDBDatabase::removeObjectStore):
        * public/WebIDBObjectStore.h:
        (WebKit::WebIDBObjectStore::indexNames):
        (WebKit::WebIDBObjectStore::createIndex):
        (WebKit::WebIDBObjectStore::index):
        (WebKit::WebIDBObjectStore::removeIndex):
        * src/IDBDatabaseProxy.cpp:
        (WebCore::IDBDatabaseProxy::name):
        (WebCore::IDBDatabaseProxy::description):
        (WebCore::IDBDatabaseProxy::version):
        (WebCore::IDBDatabaseProxy::objectStores):
        (WebCore::IDBDatabaseProxy::objectStore):
        (WebCore::IDBDatabaseProxy::removeObjectStore):
        * src/IDBDatabaseProxy.h:
        * src/IDBObjectStoreProxy.cpp:
        (WebCore::IDBObjectStoreProxy::indexNames):
        (WebCore::IDBObjectStoreProxy::createIndex):
        (WebCore::IDBObjectStoreProxy::index):
        (WebCore::IDBObjectStoreProxy::removeIndex):
        * src/IDBObjectStoreProxy.h:
        * src/WebIDBDatabaseImpl.cpp:
        (WebKit::WebIDBDatabaseImpl::WebIDBDatabaseImpl):
        (WebKit::WebIDBDatabaseImpl::name):
        (WebKit::WebIDBDatabaseImpl::description):
        (WebKit::WebIDBDatabaseImpl::version):
        (WebKit::WebIDBDatabaseImpl::objectStores):
        (WebKit::WebIDBDatabaseImpl::createObjectStore):
        (WebKit::WebIDBDatabaseImpl::objectStore):
        (WebKit::WebIDBDatabaseImpl::removeObjectStore):
        * src/WebIDBDatabaseImpl.h:
        * src/WebIDBObjectStoreImpl.cpp:
        (WebKit::WebIDBObjectStoreImpl::WebIDBObjectStoreImpl):
        (WebKit::WebIDBObjectStoreImpl::name):
        (WebKit::WebIDBObjectStoreImpl::keyPath):
        (WebKit::WebIDBObjectStoreImpl::indexNames):
        (WebKit::WebIDBObjectStoreImpl::createIndex):
        (WebKit::WebIDBObjectStoreImpl::index):
        (WebKit::WebIDBObjectStoreImpl::removeIndex):
        * src/WebIDBObjectStoreImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 11 Jun 2010 13:47:12 +0000 (13:47 +0000)]
2010-06-11  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Enable serialization/deserialization of the frontend state
        https://bugs.webkit.org/show_bug.cgi?id=40228

        WebCore:
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::saveApplicationSettings):
        (WebCore::InspectorBackend::saveSessionSettings):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::setSessionSettings):
        (WebCore::InspectorController::populateScriptObjects):
        (WebCore::InspectorController::didCommitLoad):
        * inspector/InspectorController.h:
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::populateApplicationSettings):
        (WebCore::InspectorFrontend::populateSessionSettings):
        * inspector/InspectorFrontend.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._settingsLoaded):
        (WebInspector.ConsoleView.prototype._enterKeyPressed.printResult):
        (WebInspector.ConsoleView.prototype._enterKeyPressed):
        * inspector/front-end/EventListenersSidebarPane.js:
        (WebInspector.EventListenersSidebarPane.prototype._settingsLoaded):
        (WebInspector.EventListenersSidebarPane.prototype):
        ():
        * inspector/front-end/InspectorBackendStub.js:
        (.WebInspector.InspectorBackendStub.prototype.saveApplicationSettings):
        (.WebInspector.InspectorBackendStub.prototype.saveSessionSettings):
        * inspector/front-end/ResourceView.js:
        (WebInspector.ResourceView.prototype._selectTab):
        (WebInspector.ResourceView.prototype._selectHeadersTab):
        (WebInspector.ResourceView.prototype.selectContentTab):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype._createStatusbarButtons):
        (WebInspector.ResourcesPanel.prototype._settingsLoaded):
        (WebInspector.ResourcesPanel.prototype._toggleLargerResources):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        (WebInspector.ScriptsPanel.prototype._addScriptToFilesMenu):
        * inspector/front-end/Settings.js:
        (WebInspector.populateApplicationSettings):
        (WebInspector.populateSessionSettings):
        (WebInspector.Settings):
        (WebInspector.Settings.prototype.reset):
        (WebInspector.Settings.prototype._load):
        (WebInspector.Settings.prototype._set):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype._settingsLoaded):
        (WebInspector.StylesSidebarPane.prototype.update):
        (WebInspector.StylesSidebarPane.prototype._changeSetting):
        (WebInspector.StylesSidebarPane.prototype._changeColorFormat):
        (WebInspector.ComputedStyleSidebarPane.settingsLoaded):
        (WebInspector.ComputedStyleSidebarPane.showInheritedToggleFunction):
        (WebInspector.ComputedStyleSidebarPane):
        * inspector/front-end/WatchExpressionsSidebarPane.js:
        (WebInspector.WatchExpressionsSidebarPane):
        (WebInspector.WatchExpressionsSidebarPane.prototype._settingsLoaded):
        (WebInspector.WatchExpressionsSection):
        (WebInspector.WatchExpressionsSection.prototype.saveExpressions):
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.reset):

        Webkit/chromium:
        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 S√∏ren Gjesse <sgjesse@chromium.org>
pfeldman@chromium.org [Fri, 11 Jun 2010 13:37:23 +0000 (13:37 +0000)]
2010-06-10  S√∏ren Gjesse  <sgjesse@chromium.org>

        Reviewed by Pavel Feldman.

        V8: Chromium test expectations not matching improved V8 JavaScript stepping
        https://bugs.webkit.org/show_bug.cgi?id=40419

        Update test expetations to match chaged V8 break locations.

        * src/js/Tests.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 11 Jun 2010 13:31:27 +0000 (13:31 +0000)]
2010-06-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.

        https://bugs.webkit.org/show_bug.cgi?id=40422

        * inspector/InjectedScriptHost.cpp:
        (WebCore::InjectedScriptHost::addNodesToSearchResult):
        * inspector/InspectorBackend.cpp:
        (WebCore::InspectorBackend::performSearch):
        (WebCore::InspectorBackend::searchCanceled):
        * inspector/InspectorBackend.h:
        * inspector/InspectorBackend.idl:
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::):
        (WebCore::InspectorDOMAgent::InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::~InspectorDOMAgent):
        (WebCore::InspectorDOMAgent::performSearch):
        (WebCore::InspectorDOMAgent::searchCanceled):
        (WebCore::InspectorDOMAgent::onMatchJobsTimer):
        (WebCore::InspectorDOMAgent::reportNodesAsSearchResults):
        * inspector/InspectorDOMAgent.h:
        (WebCore::MatchJob::~MatchJob):
        (WebCore::MatchJob::MatchJob):
        (WebCore::MatchJob::addNodesToResults):
        * inspector/InspectorFrontend.cpp:
        (WebCore::InspectorFrontend::addNodesToSearchResult):
        * inspector/InspectorFrontend.h:
        * inspector/InspectorResource.cpp:
        (WebCore::InspectorResource::updateScriptObject):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel.prototype.searchCanceled):
        (WebInspector.ElementsPanel.prototype.performSearch):
        (WebInspector.ElementsPanel.prototype.addNodesToSearchResult):
        * inspector/front-end/InjectedScript.js:
        (injectedScriptConstructor):
        * inspector/front-end/InjectedScriptAccess.js:
2010-06-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.

        https://bugs.webkit.org/show_bug.cgi?id=40422

        * src/js/InspectorControllerImpl.js:
        (devtools.InspectorBackendImpl):
2010-06-10  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: Port performSearch from InjectedScript to InspectorDOMAgent.

        https://bugs.webkit.org/show_bug.cgi?id=40422

        * inspector/elements-panel-search.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Fri, 11 Jun 2010 13:17:25 +0000 (13:17 +0000)]
2010-06-11  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Pavel Feldman.

        [Chromium] Restore 'console.profiles' access.

        https://bugs.webkit.org/show_bug.cgi?id=39840

        * bindings/v8/ScriptProfiler.cpp:
        (WebCore::ScriptProfiler::stop):
        * bindings/v8/custom/V8ConsoleCustom.cpp:
        (WebCore::V8Console::profilesAccessorGetter):
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::stopUserInitiatedProfiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-07 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 11 Jun 2010 12:53:50 +0000 (12:53 +0000)]
2010-06-07  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add a test for dumping global object in the console.

        https://bugs.webkit.org/show_bug.cgi?id=40241

        * http/tests/inspector/inspector-test.js:
        (frontend_dumpTreeOutline):
        (frontend_dumpTreeItem):
        * inspector/console-dir-global-expected.txt: Added.
        * inspector/console-dir-global.html: Added.
        * inspector/elements-tests.js:
        (frontend_dumpStyleTreeItem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-10 Nikita Vasilyev <me@elv1s.ru>
pfeldman@chromium.org [Fri, 11 Jun 2010 12:48:47 +0000 (12:48 +0000)]
2010-06-10  Nikita Vasilyev  <me@elv1s.ru>

        Reviewed by Pavel Feldman.

        Web Inspector: Make a close brace in Styles pane selectable.
        https://bugs.webkit.org/show_bug.cgi?id=40157

        * inspector/front-end/inspector.css:
        (.styles-selector):
        (.styles-section .properties li):
        (.styles-section):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 11 Jun 2010 12:39:04 +0000 (12:39 +0000)]
2010-06-11  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: localize missing script source message
        https://bugs.webkit.org/show_bug.cgi?id=40467

        * English.lproj/localizedStrings.js:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::didParseSource): fixed typo in comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Vangelis Kokkevis <vangelis@chromium.org>
eric@webkit.org [Fri, 11 Jun 2010 12:28:45 +0000 (12:28 +0000)]
2010-06-11  Vangelis Kokkevis  <vangelis@chromium.org>

        Reviewed by David Levin.

        [chromium] Adding a build dependency to the gles2 C library to the webkit_unit_tests
        project to allow it to link when WebCore is compiled with the ACCELERATED_COMPOSITING
        flag.
        https://bugs.webkit.org/show_bug.cgi?id=40341

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 11 Jun 2010 12:16:18 +0000 (12:16 +0000)]
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Vertex attributes enabled as arrays but not bound to buffers must generate INVALID_OPERATION
        https://bugs.webkit.org/show_bug.cgi?id=40315

        * fast/canvas/webgl/index-validation-expected.txt: Generate INVALID_ERROR when an enabled vertex attrib is not bound to any buffer in drawElements().
        * fast/canvas/webgl/script-tests/index-validation.js: Ditto.
2010-06-11  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Vertex attributes enabled as arrays but not bound to buffers must generate INVALID_OPERATION
        https://bugs.webkit.org/show_bug.cgi?id=40315

        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::validateRenderingState): Check if an enabled vertext attribs is bound to a buffer.
        (WebCore::WebGLRenderingContext::vertexAttribPointer): Set bound buffer in vertex attrib state.
        * html/canvas/WebGLRenderingContext.h: Add a member in vertex attrib state to track bound buffer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Second fix attempt for the build break introduced by r61002.
jocelyn.turcotte@nokia.com [Fri, 11 Jun 2010 11:47:22 +0000 (11:47 +0000)]
[Qt] Second fix attempt for the build break introduced by r61002.

Reviewed by nobody, build fix.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Fix build break introduced by r61002.
jocelyn.turcotte@nokia.com [Fri, 11 Jun 2010 10:42:36 +0000 (10:42 +0000)]
[Qt] Fix build break introduced by r61002.

Reviewed by nobody, build fix.

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Explicit conversions from QtScript types to JSC opaque types were removed.
hausmann@webkit.org [Fri, 11 Jun 2010 10:36:18 +0000 (10:36 +0000)]
[Qt] Explicit conversions from QtScript types to JSC opaque types were removed.
https://bugs.webkit.org/show_bug.cgi?id=40412

Patch by Jedrzej Nowacki <jedrzej.nowacki@nokia.com> on 2010-06-11
Reviewed by Simon Hausmann.

Conversion between a JSC C types and a QtScript private types, takes
main part of the source code. In most cases a mapping between the types
is one to one. New cast operators were added to simplify the code.

The QScriptValuePrivate could be casted to the JSValueRef and the JSObjectRef.
The QScriptEnginePrivate could be casted to the JSGlobalContext.
The QScriptProgramPrivate could be casted to the JSStringRef.

* qt/api/qscriptengine_p.cpp:
(QScriptEnginePrivate::evaluate):
(QScriptEnginePrivate::newObject):
(QScriptEnginePrivate::globalObject):
* qt/api/qscriptengine_p.h:
(QScriptEnginePrivate::operator JSGlobalContextRef):
* qt/api/qscriptprogram_p.h:
(QScriptProgramPrivate::operator JSStringRef):
* qt/api/qscriptsyntaxcheckresult.cpp:
(QScriptSyntaxCheckResultPrivate::~QScriptSyntaxCheckResultPrivate):
(QScriptSyntaxCheckResultPrivate::errorMessage):
(QScriptSyntaxCheckResultPrivate::errorLineNumber):
* qt/api/qscriptvalue_p.h:
(QScriptValuePrivate::~QScriptValuePrivate):
(QScriptValuePrivate::QScriptValuePrivate):
(QScriptValuePrivate::isBool):
(QScriptValuePrivate::isNumber):
(QScriptValuePrivate::isNull):
(QScriptValuePrivate::isString):
(QScriptValuePrivate::isUndefined):
(QScriptValuePrivate::isFunction):
(QScriptValuePrivate::toString):
(QScriptValuePrivate::toNumber):
(QScriptValuePrivate::toBool):
(QScriptValuePrivate::toObject):
(QScriptValuePrivate::equals):
(QScriptValuePrivate::strictlyEquals):
(QScriptValuePrivate::instanceOf):
(QScriptValuePrivate::call):
(QScriptValuePrivate::operator JSValueRef):
(QScriptValuePrivate::operator JSObjectRef):
(QScriptValuePrivate::setValue):
(QScriptValuePrivate::inherits):
(QScriptValuePrivate::refinedJSValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Implement the simple text code path.
jocelyn.turcotte@nokia.com [Fri, 11 Jun 2010 09:59:36 +0000 (09:59 +0000)]
[Qt] Implement the simple text code path.
https://bugs.webkit.org/show_bug.cgi?id=40077

Reviewed by Simon Hausmann.

Remove the FONT_FAST_PATH macro and use the Qt's
fast text implementation instead of the one of WebKit.

The Qt::TextBypassShaping flag is used to tell Qt to
only use the glyph advances.

Qt 4.7 is needed to get this flag thus the complex path is always
used if QtWebKit is compiled against an earlier version.

Contrary to the WebKit's implementation, the complex code path
is taken if the text is RightToLeft, justified or is formatted
with non-zero letter or word spacing.

JavaScriptCore:

* wtf/Platform.h:

WebCore:

* platform/graphics/Font.cpp:
(WebCore::Font::drawText):
(WebCore::Font::floatWidth):
(WebCore::Font::selectionRectForText):
(WebCore::Font::offsetForPosition):
* platform/graphics/Font.h:
(WebCore::Font::isRoundingHackCharacter):
* platform/graphics/qt/FontQt.cpp:
(WebCore::fromRawDataWithoutRef):
(WebCore::needComplexCodePath):
(WebCore::setupPlatformContext):
(WebCore::Font::canReturnFallbackFontsForComplexText):
(WebCore::Font::drawSimpleText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForSimpleText):
(WebCore::Font::offsetForPositionForSimpleText):
(WebCore::Font::selectionRectForSimpleText):

WebKit\qt:

* Api/qwebpage.cpp:
(QWebPagePrivate::QWebPagePrivate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMove the text code path detection code from FontFastPath.cpp to Font.cpp.
jocelyn.turcotte@nokia.com [Fri, 11 Jun 2010 09:58:29 +0000 (09:58 +0000)]
Move the text code path detection code from FontFastPath.cpp to Font.cpp.
https://bugs.webkit.org/show_bug.cgi?id=40077

Reviewed by Simon Hausmann.

This is a patch preliminary to the implementation of the
simple font code path for the Qt port.

* platform/graphics/Font.cpp:
(WebCore::Font::setCodePath):
(WebCore::Font::codePath):
* platform/graphics/Font.h:
* platform/graphics/FontFastPath.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Sterling Swigart <sswigart@google.com>
eric@webkit.org [Fri, 11 Jun 2010 09:36:27 +0000 (09:36 +0000)]
2010-06-11  Sterling Swigart  <sswigart@google.com>

        Reviewed by Dmitry Titov.

        Added AsyncImageResizer and ImageResizerThread classes, which after further
        patches will be capable of resizing images.
        https://bugs.webkit.org/show_bug.cgi?id=40018

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * html/AsyncImageResizer.cpp: Added.
        (WebCore::AsyncImageResizer::create):
        (WebCore::AsyncImageResizer::AsyncImageResizer):
        (WebCore::AsyncImageResizer::~AsyncImageResizer):
        (WebCore::AsyncImageResizer::notifyFinished):
        * html/AsyncImageResizer.h: Added.
        (WebCore::AsyncImageResizer::CallbackInfo::CallbackInfo):
        (WebCore::AsyncImageResizer::):
        (WebCore::AsyncImageResizer::resizeComplete):
        (WebCore::AsyncImageResizer::resizeError):
        * html/ImageResizerThread.cpp: Added.
        (WebCore::returnBlobOrError):
        (WebCore::ImageResizerThread::start):
        (WebCore::ImageResizerThread::ImageResizerThread):
        (WebCore::ImageResizerThread::~ImageResizerThread):
        (WebCore::ImageResizerThread::imageResizerThreadStart):
        (WebCore::ImageResizerThread::imageResizerThread):
        * html/ImageResizerThread.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@61000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Fri, 11 Jun 2010 09:10:18 +0000 (09:10 +0000)]
2010-06-11  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Update acid3 test with latest from acid3.acidtests.org
        https://bugs.webkit.org/show_bug.cgi?id=40428

        This is a straight copy from "curl http://acid3.acidtests.org/" with
        LayoutTest specific bits reapplied:
         - Rename resources to resources/acid3/...
         - Add window.layoutTestController bits to start and end.

        We still fail the same link test. The difference is that its error
        changed from "LINKTEST FAILED" to "YOU SHOULD NOT SEE THIS AT ALL".

        * http/tests/misc/acid3-expected.checksum:
        * http/tests/misc/acid3-expected.png:
        * http/tests/misc/acid3-expected.txt:
        * http/tests/misc/acid3.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-06-11 Steve Block <steveblock@google.com>
steveblock@google.com [Fri, 11 Jun 2010 08:50:22 +0000 (08:50 +0000)]
2010-06-11  Steve Block  <steveblock@google.com>

        Reviewed by Alexey Proskuryakov.

        Client-based Geolocation does not handle multiple simultaneous requests
        https://bugs.webkit.org/show_bug.cgi?id=40148

        Test: fast/dom/Geolocation/multiple-requests.html

        The Geolocation must handle multiple calls to addObserver() from the same Geolocation object.

        * page/GeolocationController.cpp:
        (WebCore::GeolocationController::addObserver):
2010-06-11  Steve Block  <steveblock@google.com>

        Reviewed by Alexey Proskuryakov.

        Client-based Geolocation does not handle multiple simultaneous requests
        https://bugs.webkit.org/show_bug.cgi?id=40148

        The change to the GeolocationController is explicitly tested with multiple-requests.html.

        This change also fixes reentrant-error.html and reentrant-success.html which were previously
        on the mac skipped list. reentrant-error.html required a minor tweak as the mac
        GeolocationController can only provide an error code of 2 (POSITION_UNAVAILABLE).

        Added to GTK skipped list.

        * fast/dom/Geolocation/multiple-requests-expected.txt: Added.
        * fast/dom/Geolocation/multiple-requests.html: Added.
        * fast/dom/Geolocation/script-tests/multiple-requests.js: Added.
        * fast/dom/Geolocation/script-tests/reentrant-error.js:
        * platform/mac/Skipped:
        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@60998 268f45cc-cd09-0410-ab3c-d52691b4dbfc