WebKit-https.git
10 months agoWeb Inspector: Table selection should not require that rows be in the cache
mattbaker@apple.com [Mon, 5 Nov 2018 19:01:30 +0000 (19:01 +0000)]
Web Inspector: Table selection should not require that rows be in the cache
https://bugs.webkit.org/show_bug.cgi?id=190993
<rdar://problem/45613812>

Reviewed by Devin Rousso.

Source/WebInspectorUI:

Deselecting a table row shouldn't depend on it being in the cache. This
allows us to implement select all, and other kinds of bulk selection
actions that affect rows that haven't been revealed.

* UserInterface/Views/Table.js:
(WI.Table.prototype.deselectRow):

LayoutTests:

Add a test that a table row that is not in the cache can be selected/deselected.

* inspector/table/table-selection-expected.txt:
* inspector/table/table-selection.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237817 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoExpose a constructor for PointerEvent from PlatformTouchEvent
dino@apple.com [Mon, 5 Nov 2018 18:37:43 +0000 (18:37 +0000)]
Expose a constructor for PointerEvent from PlatformTouchEvent
https://bugs.webkit.org/show_bug.cgi?id=191238
<rdar://problem/45795682>

Reviewed by Antoine Quint.

Implement a constructor that takes a PlatformTouchEvent to
create a PointerEvent. At the moment the code to call this
constructor will live in WebKitAdditions, so no new tests
yet.

* SourcesCocoa.txt: Add PointerEventIOS.cpp.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/EventNames.h: Add macros for pointerdown, pointermove,
     pointerup, pointercancel.
* dom/PointerEvent.cpp: Remove JSC namespace.
* dom/PointerEvent.h: Add create and constructor that takes
     a PlatformTouchEvent.
* dom/ios/PointerEventIOS.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, rolling out r237785.
ryanhaddad@apple.com [Mon, 5 Nov 2018 18:07:06 +0000 (18:07 +0000)]
Unreviewed, rolling out r237785.

Introduced layout test and API test failures on macOS and iOS.

Reverted changeset:

"[iOS] Issue initial paint soon after the visuallyNonEmpty
milestone is fired."
https://bugs.webkit.org/show_bug.cgi?id=191078
https://trac.webkit.org/changeset/237785

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, rolling out r237784 and r237788.
commit-queue@webkit.org [Mon, 5 Nov 2018 18:03:14 +0000 (18:03 +0000)]
Unreviewed, rolling out r237784 and r237788.
https://bugs.webkit.org/show_bug.cgi?id=191270

Caused mediastream layout test failures (Requested by
ryanhaddad on #webkit).

Reverted changesets:

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
https://bugs.webkit.org/show_bug.cgi?id=191227
https://trac.webkit.org/changeset/237784

"[MediaStream] User should not be prompted again after denying
getDisplayMedia request"
https://bugs.webkit.org/show_bug.cgi?id=191227
https://trac.webkit.org/changeset/237788

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoResync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing...
cdumez@apple.com [Mon, 5 Nov 2018 17:54:22 +0000 (17:54 +0000)]
Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests
https://bugs.webkit.org/show_bug.cgi?id=191214

Reviewed by Geoff Garen.

Resync html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name WPT tests from
upstream c583bcd7eb.

* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01-expected.txt:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/creating_browsing_context_test_01.html:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window-expected.txt: Added.
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.html: Added.
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/no_window_open_when_term_nesting_level_nonzero.window.js: Added.
(test.frame.contentWindow.onpagehide):
(test.frame.contentDocument.onvisibilitychange):
(test.frame.contentWindow.onbeforeunload):
(test.frame.contentWindow.onunload):
(test):
(async_test):
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/non_automated/w3c-import.log:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener-expected.txt:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/open-features-tokenization-noopener.html:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/message-opener.html:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/resources/w3c-import.log:
* web-platform-tests/html/browsers/the-window-object/apis-for-creating-and-navigating-browsing-contexts-by-name/w3c-import.log:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agohttps://bugs.webkit.org/show_bug.cgi?id=191268
lforschler@apple.com [Mon, 5 Nov 2018 17:47:42 +0000 (17:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=191268
Remove unused bots.

rubber-stamped by Alexey Proskuryakov.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/public_html/dashboard/Scripts/WebKitBuildbot.js:
(WebKitBuildbot):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237810 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed build fix for linux.
msaboff@apple.com [Mon, 5 Nov 2018 17:43:40 +0000 (17:43 +0000)]
Unreviewed build fix for linux.

* stress/regexp-compile-oom.js: Disabled for non-darwin OSes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoWeb Inspector: show save/restore stack for recorded 2D Canvases
drousso@apple.com [Mon, 5 Nov 2018 17:34:48 +0000 (17:34 +0000)]
Web Inspector: show save/restore stack for recorded 2D Canvases
https://bugs.webkit.org/show_bug.cgi?id=175283
<rdar://problem/34040756>

Reviewed by Matt Baker.

Source/WebInspectorUI:

Instead of using plain objects for holding the `WI.Recording`'s state, use a model object
so that more data can be passed around. When visualizing the state, show any previously
saved states in a `WI.DetailsSection` underneath the current state. If there are no saved
states (meaning there is only the current state), don't use a `WI.DetailsSection`.

* UserInterface/Models/RecordingState.js: Added.
(WI.RecordingState):
(WI.RecordingState.fromContext):
(WI.RecordingState.async swizzleInitialState):
(WI.RecordingState.prototype.get source):
(WI.RecordingState.prototype.has):
(WI.RecordingState.prototype.get return):
(WI.RecordingState.prototype.toJSON):
(WI.RecordingState.prototype.[Symbol.iterator]):

* UserInterface/Models/Recording.js:
(WI.Recording.prototype.async _process):
(WI.Recording.prototype.async _swizzleState): Deleted.

* UserInterface/Models/RecordingAction.js:
(WI.RecordingAction.prototype.process):
(WI.RecordingAction.deriveCurrentState): Deleted.

* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView.prototype._generateContentCanvas2D):

* UserInterface/Views/RecordingStateDetailsSidebarPanel.js:
(WI.RecordingStateDetailsSidebarPanel):
(WI.RecordingStateDetailsSidebarPanel.prototype.get scrollElement):
(WI.RecordingStateDetailsSidebarPanel.prototype.sizeDidChange): Added.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D):
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.isColorProperty): Deleted.
(WI.RecordingStateDetailsSidebarPanel.prototype._generateDetailsCanvas2D.createInlineSwatch): Deleted.
* UserInterface/Views/RecordingStateDetailsSidebarPanel.css:
(.sidebar > .panel.details.recording-state > .content .details-section > .header .source): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr.modified): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected).non-standard .name-column): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid tr:not(.selected) .unavailable): Added.
(.sidebar > .panel.details.recording-state > .content .data-grid .inline-swatch): Added.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr.modified): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected).non-standard): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid tr:not(.selected) .unavailable): Deleted.
(.sidebar > .panel.details.recording-state > .content > .data-grid .inline-swatch): Deleted.

* UserInterface/Main.html:
* UserInterface/Test.html:

* Localizations/en.lproj/localizedStrings.js:

LayoutTests:

* inspector/canvas/recording-2d.html:
* inspector/canvas/resources/recording-utilities.js:
(TestPage.registerInitializer.log):
(TestPage.registerInitializer.async logRecording):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WPE][GTK] API test runner fails to respect default build type
mcatanzaro@igalia.com [Mon, 5 Nov 2018 16:45:20 +0000 (16:45 +0000)]
[WPE][GTK] API test runner fails to respect default build type
https://bugs.webkit.org/show_bug.cgi?id=190247

Reviewed by Carlos Garcia Campos.

Problem is it's looking for a release build, even though I've run set-webkit-configuration
--debug. It should look for a debug build unless I explicitly pass --release.

* glib/api_test_runner.py:
(TestRunner.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237805 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer][WebRTC] Error out when simulcast is activated
commit-queue@webkit.org [Mon, 5 Nov 2018 16:08:12 +0000 (16:08 +0000)]
[GStreamer][WebRTC] Error out when simulcast is activated
https://bugs.webkit.org/show_bug.cgi?id=190678

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Implementing it is not for now yet.
Source/WebCore:

Tests for simulcast have been disabled as they now fail (instead of crashing).

* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::InitEncode):

LayoutTests:

Tests for simulcast have been disabled as they now fail (instead of crashing).

* platform/gtk/TestExpectations:
* platform/wpe/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237804 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoEnable LLInt on ARMv7/Linux
dinfuehr@igalia.com [Mon, 5 Nov 2018 16:07:40 +0000 (16:07 +0000)]
Enable LLInt on ARMv7/Linux
https://bugs.webkit.org/show_bug.cgi?id=191190

Reviewed by Yusuke Suzuki.

After enabling the new bytecode format in r237547, C_LOOP was
forced on all 32-bit platforms. Now enable LLInt again on
.:

ARMv7-Thumb2/Linux by default.

* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

ARMv7-Thumb2/Linux.

This adds a callee-saved register in ARMv7/Linux for the metadataTable and
stores/restores it on LLInt function calls. It also introduces the globaladdr-
instruction for the ARM-offlineasm to access the opcode-table.

* jit/GPRInfo.h:
* jit/RegisterSet.cpp:
(JSC::RegisterSet::llintBaselineCalleeSaveRegisters):
* llint/LowLevelInterpreter.asm:
* llint/LowLevelInterpreter32_64.asm:
* offlineasm/arm.rb:
* offlineasm/asm.rb:
* offlineasm/instructions.rb:

Source/WTF:

ARMv7-Thumb2/Linux by default.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237803 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRealtimeOutgoingAudioSource subclasses should observe its source when fully constructed
youenn@apple.com [Mon, 5 Nov 2018 15:32:03 +0000 (15:32 +0000)]
RealtimeOutgoingAudioSource subclasses should observe its source when fully constructed
https://bugs.webkit.org/show_bug.cgi?id=191241

Reviewed by Eric Carlson.

Moving the logic to observe the audio source to the point where the
RealtimeOutgoingAudioSource subclass is fully initialized.
Covered by existing tests.

* platform/mediastream/RealtimeOutgoingAudioSource.cpp:
(WebCore::RealtimeOutgoingAudioSource::RealtimeOutgoingAudioSource):
(WebCore::RealtimeOutgoingAudioSource::observeSource):
* platform/mediastream/RealtimeOutgoingAudioSource.h:
* platform/mediastream/gstreamer/RealtimeOutgoingAudioSourceLibWebRTC.cpp:
(WebCore::RealtimeOutgoingAudioSourceLibWebRTC::RealtimeOutgoingAudioSourceLibWebRTC):
* platform/mediastream/mac/RealtimeOutgoingAudioSourceCocoa.cpp:
(WebCore::RealtimeOutgoingAudioSourceCocoa::RealtimeOutgoingAudioSourceCocoa):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set...
commit-queue@webkit.org [Mon, 5 Nov 2018 15:09:54 +0000 (15:09 +0000)]
[GStreamer][WebRTC] Add webrtcencoder bin to cleanup and refactor the way we set encoders
https://bugs.webkit.org/show_bug.cgi?id=190674

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

webrtcencoder is a simple GstBin with a set of well known GStreamer encoders which
it can use to implement encoding for different formats exposing a trimmed down unified API.

It also adds proper handling of H264 profiles.

The added files follow GStreamer coding style as we aim at upstreaming the element
in the future.

Source/WebCore:

This is a refactoring so current tests already cover it.

* platform/GStreamer.cmake:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
(WebCore::MediaPlayerPrivateGStreamerBase::initializeGStreamerAndRegisterWebKitElements):
* platform/mediastream/libwebrtc/GStreamerVideoEncoder.cpp: Added.
(gst_webrtc_video_encoder_get_property):
(gst_webrtc_video_encoder_set_bitrate):
(gst_webrtc_video_encoder_set_format):
(gst_webrtc_video_encoder_set_property):
(register_known_encoder):
(setup_x264enc):
(setup_vp8enc):
(setup_openh264enc):
(set_bitrate_kbit_per_sec):
(set_bitrate_bit_per_sec):
(gst_webrtc_video_encoder_class_init):
(gst_webrtc_video_encoder_init):
* platform/mediastream/libwebrtc/GStreamerVideoEncoder.h: Added.
* platform/mediastream/libwebrtc/GStreamerVideoEncoderFactory.cpp:
(WebCore::GStreamerVideoEncoder::GStreamerVideoEncoder):
(WebCore::GStreamerVideoEncoder::InitEncode):
(WebCore::GStreamerVideoEncoder::createEncoder):
(WebCore::GStreamerVideoEncoder::AddCodecIfSupported):
(WebCore::GStreamerVideoEncoder::ImplementationName const):
(WebCore::GStreamerVideoEncoder::SetRestrictionCaps):

Tools:

Reviewed by Philippe Normand.

* Scripts/webkitpy/style/checker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer][WebRTC] properly mark H.264 stream type in the "decoder"
commit-queue@webkit.org [Mon, 5 Nov 2018 15:05:39 +0000 (15:05 +0000)]
[GStreamer][WebRTC] properly mark H.264 stream type in the "decoder"
https://bugs.webkit.org/show_bug.cgi?id=190676

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Avoiding to have h264parse make assumption (which might be wrong at some
point).

* platform/mediastream/libwebrtc/GStreamerVideoDecoderFactory.cpp:
(WebCore::GStreamerVideoDecoder::GetCapsForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer] Do not sync libwerbtc stream on the clock
commit-queue@webkit.org [Mon, 5 Nov 2018 14:50:28 +0000 (14:50 +0000)]
[GStreamer] Do not sync libwerbtc stream on the clock
https://bugs.webkit.org/show_bug.cgi?id=190677

The approach here is basically to let libwebrtc do all the
synchronisation for us, and the same way as it is done in apple ports,
we basically try to display what libwebrtc outputs as fast as possible.

Patch by Thibault Saunier <tsaunier@igalia.com> on 2018-11-05
Reviewed by Philippe Normand.

Manually tested

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::setSyncOnSink):
(WebCore::MediaPlayerPrivateGStreamer::syncOnClock):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::load):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
ajuma@chromium.org [Mon, 5 Nov 2018 14:47:40 +0000 (14:47 +0000)]
[IntersectionObserver] Fix isIntersecting computation when 0 is not a threshold
https://bugs.webkit.org/show_bug.cgi?id=191210

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectation for test that now passes.

* web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.txt:

Source/WebCore:

isIntersecting should be false if the intersection ratio is smaller than the
smallest threshold value. Update the computation of isIntersecting to depend on
the current thresholdIndex.

Test: imported/w3c/web-platform-tests/intersection-observer/initial-observation-with-threshold-expected.html

* dom/Document.cpp:
(WebCore::Document::updateIntersectionObservations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRemove some virtual methods in CachedRawResource
commit-queue@webkit.org [Mon, 5 Nov 2018 13:55:21 +0000 (13:55 +0000)]
Remove some virtual methods in CachedRawResource
https://bugs.webkit.org/show_bug.cgi?id=191251

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-05
Reviewed by Frédéric Wang.

Since CachedRawResource is final no need to introduce new virtual
methods in CachedRawResource. This patch also removes an outdated
comment and forward declaration.

No new tests since no change in functionality.

* loader/cache/CachedRawResource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
mcatanzaro@igalia.com [Mon, 5 Nov 2018 12:19:47 +0000 (12:19 +0000)]
[WPE][GTK] API test /webkit/WebKitSettings/webkit-settings is failing
https://bugs.webkit.org/show_bug.cgi?id=191221

Reviewed by Carlos Garcia Campos.

This test ensures that MSE is disabled by default, but we now enable it by default, so
reverse the semantics of the test.

* TestWebKitAPI/Tests/WebKitGLib/TestWebKitSettings.cpp:
(testWebKitSettings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoREGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
mcatanzaro@igalia.com [Mon, 5 Nov 2018 10:46:38 +0000 (10:46 +0000)]
REGRESSION(r237031): [GTK] Test /webkit/WebKitWebView/settings is failing
https://bugs.webkit.org/show_bug.cgi?id=191225

Reviewed by Alejandro G. Castro.

Fix a memory leak causing this test to fail.

* TestWebKitAPI/glib/WebKitGLib/WebViewTest.cpp:
(WebViewTest::initializeWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GStreamer] Move elements registration to GStreamerCommon
philn@webkit.org [Mon, 5 Nov 2018 10:00:19 +0000 (10:00 +0000)]
[GStreamer] Move elements registration to GStreamerCommon
https://bugs.webkit.org/show_bug.cgi?id=191189

Reviewed by Xabier Rodriguez-Calvar.

It was a bit odd to have this in the base player class and to have
sub-classes calling a static function of the super-class.

Covered by existing tests.

* platform/graphics/gstreamer/GStreamerCommon.cpp:
(WebCore::initializeGStreamerAndRegisterWebKitElements):
* platform/graphics/gstreamer/GStreamerCommon.h:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::isAvailable):
(WebCore::MediaPlayerPrivateGStreamer::loadFull):
(WebCore::MediaPlayerPrivateGStreamer::getSupportedTypes):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.cpp:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamerBase.h:
* platform/graphics/gstreamer/mse/MediaPlayerPrivateGStreamerMSE.cpp:
(WebCore::MediaPlayerPrivateGStreamerMSE::registerMediaEngine):
(WebCore::MediaPlayerPrivateGStreamerMSE::load):
(WebCore::MediaPlayerPrivateGStreamerMSE::trackDetected):
(WebCore::MediaPlayerPrivateGStreamerMSE::supportsType):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot...
Hironori.Fujii@sony.com [Mon, 5 Nov 2018 09:34:01 +0000 (09:34 +0000)]
[Win][Clang][JSC] JIT::is64BitType reports "warning: explicit specialization cannot have a storage class"
https://bugs.webkit.org/show_bug.cgi?id=191146

Reviewed by Yusuke Suzuki.

* jit/JIT.h: Changed is64BitType from a template class method to a
template inner class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed WPE gardening. Updating or adding various baselines. Also
zandobersek@gmail.com [Mon, 5 Nov 2018 09:08:47 +0000 (09:08 +0000)]
Unreviewed WPE gardening. Updating or adding various baselines. Also
adding new failure expectations for tests that need a closer look.

* platform/wpe/TestExpectations:
* platform/wpe/fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
* platform/wpe/fast/block/basic/height-percentage-simple-expected.txt: Added.
* platform/wpe/fast/block/basic/inline-content-with-floating-image-expected.txt: Added.
* platform/wpe/fast/block/basic/inline-content-with-floating-images2-expected.txt: Added.
* platform/wpe/fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
* platform/wpe/fast/history: Added.
* platform/wpe/fast/history/page-cache-webdatabase-pending-transaction-expected.txt: Added.
* platform/wpe/fast/inline-block/14498-positionForCoordinates-expected.txt:
* platform/wpe/fast/inline/simple-inline-block-expected.txt: Added.
* platform/wpe/fast/inline/simple-intruding-float1-expected.txt: Added.
* platform/wpe/fast/inline/simple-intruding-floats2-expected.txt: Added.
* platform/wpe/fast/inline/simple-intruding-floats3-expected.txt: Added.
* platform/wpe/fast/inline/simple-shrink-to-fit-inline-block-expected.txt: Added.
* platform/wpe/webgl/2.0.0/conformance/canvas/drawingbuffer-test-expected.txt: Added.
* platform/wpe/webgl/2.0.0/conformance/context/context-attributes-alpha-depth-stencil-antialias-expected.txt:
* platform/wpe/webgl/2.0.0/conformance/context/context-hidden-alpha-expected.txt:
* platform/wpe/webgl/2.0.0/conformance/extensions/get-extension-expected.txt:
* platform/wpe/webgl/2.0.0/conformance/extensions/oes-texture-half-float-with-image-data-expected.txt: Added.
* platform/wpe/webgl/2.0.0/conformance/glsl/misc/shaders-with-invariance-expected.txt:
* platform/wpe/webgl/2.0.0/conformance/rendering/multisample-corruption-expected.txt:
* platform/wpe/webgl/2.0.0/conformance2/buffers/bound-buffer-size-change-test-expected.txt:
* platform/wpe/webgl/2.0.0/conformance2/extensions/promoted-extensions-in-shaders-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
mcatanzaro@igalia.com [Mon, 5 Nov 2018 08:03:30 +0000 (08:03 +0000)]
[WPE][GTK] Expose ENABLE_MEDIA_SOURCE as public option
https://bugs.webkit.org/show_bug.cgi?id=191223

Reviewed by Xabier Rodriguez-Calvar.

This option should be public because it needs to be disabled to build with GStreamer older
than 1.14.4.

* Source/cmake/GStreamerDefinitions.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[webkitpy] Support WPE in the run-web-platform-tests script
zandobersek@gmail.com [Mon, 5 Nov 2018 06:50:12 +0000 (06:50 +0000)]
[webkitpy] Support WPE in the run-web-platform-tests script
https://bugs.webkit.org/show_bug.cgi?id=191183

Reviewed by Alex Christensen.

* Scripts/webkitpy/w3c/wpt_runner.py:
(parse_args): Support `--wpe` as an argument that specifies WPE as the
target port. Additionally, the `--display-server` flag now accepts
`headless` as a valid value, enabling the WPE WebDriver to run in
headless mode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Win] Use C++14, not C++17
Hironori.Fujii@sony.com [Mon, 5 Nov 2018 04:38:32 +0000 (04:38 +0000)]
[Win] Use C++14, not C++17
https://bugs.webkit.org/show_bug.cgi?id=191101

Reviewed by Alex Christensen.

.:

Based on the webkit-dev discussion, this change switches Windows
port from C++17 to C++14.
<https://lists.webkit.org/pipermail/webkit-dev/2018-September/030186.html>

* Source/cmake/OptionsMSVC.cmake: Replaced /std:c++17 with /std:c++14 switch.

Source/WTF:

* wtf/StdLibExtras.h: Use _MSVC_LANG to check C++ language version
instead of _MSC_FULL_VER.

Tools:

std::basic_string::data() returns a read-only const buffer in
C++14.

* MiniBrowser/win/WebKitBrowserWindow.cpp:
(createString): Use std::vector instead of std::wstring.
(createUTF8String): Use std::vector instead of std::string.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[MediaStream] User should not be prompted again after denying getDisplayMedia request
Hironori.Fujii@sony.com [Mon, 5 Nov 2018 04:29:02 +0000 (04:29 +0000)]
[MediaStream] User should not be prompted again after denying getDisplayMedia request
https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Unreviewed build fix of ports not ENABLE(MEDIA_STREAM).

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp: Define getRequestAction only if ENABLE(MEDIA_STREAM).
* UIProcess/UserMediaPermissionRequestManagerProxy.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRemove ENABLE_OPENCL fully
commit-queue@webkit.org [Mon, 5 Nov 2018 02:15:48 +0000 (02:15 +0000)]
Remove ENABLE_OPENCL fully
https://bugs.webkit.org/show_bug.cgi?id=191172

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-04
Reviewed by Yusuke Suzuki.

Forgot to simplify this, no need for applyAll anymore
since it just calls apply.

No new tests since no change in functionality.

* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::applyAll): Deleted.
* rendering/svg/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::postApplyResource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptCo...
wenson_hsieh@apple.com [Sun, 4 Nov 2018 21:19:44 +0000 (21:19 +0000)]
[Cocoa] Fold common UIScriptController functionality on macOS and iOS into UIScriptControllerCocoa.mm
https://bugs.webkit.org/show_bug.cgi?id=191231

Reviewed by Simon Fraser.

Moves some UIScriptController method implementations specific to iOS and macOS into UIScriptControllerCocoa, so
it can be shared between iOS-family and macOS platforms. See below for more details.

No change in behavior.

* DumpRenderTree/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::overridePreference):

Add a method stub for DumpRenderTree.

* TestRunnerShared/UIScriptContext/UIScriptController.cpp:
* WebKitTestRunner/UIScriptControllerCocoa.mm:
(WTR::UIScriptController::doAsyncTask):
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution):

Unify these method implementations.

(WTR::UIScriptController::removeViewFromWindow):
(WTR::UIScriptController::addViewToWindow):

Move the macOS implementation to UIScriptControllerCocoa. On iOS, this method currently only adds the web view
to the window, and does not attempt to invoke the given completion block; additionally, invoking the completion
block after a presentation update (as done on macOS) causes pageoverlay/overlay-remove-reinsert-view.html to
begin failing consistently. This patch does not attempt to change behavior, but adds a FIXME describing this.

(WTR::UIScriptController::overridePreference):
(WTR::UIScriptController::findString):
(WTR::UIScriptController::contentsOfUserInterfaceItem const):

Move these from UIScriptControllerMac to UIScriptControllerCocoa, so that it is now implemented on iOS as well.

* WebKitTestRunner/ios/UIScriptControllerIOS.mm:
(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.
* WebKitTestRunner/mac/UIScriptControllerMac.mm:
(WTR::UIScriptController::doAsyncTask): Deleted.
(WTR::UIScriptController::contentsOfUserInterfaceItem const): Deleted.
(WTR::UIScriptController::overridePreference): Deleted.
(WTR::UIScriptController::findString): Deleted.
(WTR::UIScriptController::removeViewFromWindow): Deleted.
(WTR::UIScriptController::addViewToWindow): Deleted.
(WTR::UIScriptController::setShareSheetCompletesImmediatelyWithResolution): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
zalan@apple.com [Sun, 4 Nov 2018 16:38:36 +0000 (16:38 +0000)]
[iOS] Issue initial paint soon after the visuallyNonEmpty milestone is fired.
https://bugs.webkit.org/show_bug.cgi?id=191078
<rdar://problem/45736178>

Reviewed by Antti Koivisto.

Source/WebCore:

1. Improve visuallyNonEmpty milestone confidence level.
    Ignore whitespace and non visible text content.
    Parsing the main document should not necessarily fire the milestone. Check if there's any pending scripts/css/font loading.
    Check if the html/body is actually visible.

2. Issue initial paint soon after the milestone fires.
    Use a 0ms timer to flush the initial paint.
    Throttle additional flushes for 500ms (remove the non-initial 1.5 throttling)

3. Suspend optional style recalcs and layouts while painting is being throttled.
   When parsing yields we initiate a 0ms style recalc/layout timer.
   These optional layouts produce content that we have no intention to paint.

* dom/Document.cpp:
(WebCore::Document::scheduleStyleRecalc):
(WebCore::Document::shouldScheduleLayout):
* page/ChromeClient.h:
* page/FrameView.cpp:
(WebCore::FrameView::resetLayoutMilestones):
(WebCore::FrameView::qualifiesAsVisuallyNonEmpty const):
(WebCore::FrameView::updateSignificantRenderedTextMilestoneIfNeeded):
(WebCore::FrameView::updateIsVisuallyNonEmpty):
* page/FrameView.h:
(WebCore::FrameView::incrementVisuallyNonEmptyCharacterCount): Ignore whitespace characters. Some pages start with plenty of whitespace only content.
* platform/graphics/FontCascade.h:
* rendering/RenderText.cpp: Check whether the text is actually visible at this point.
(WebCore::RenderText::RenderText):

Source/WebKit:

* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::layerFlushThrottlingIsActive const):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebPage/AcceleratedDrawingArea.cpp:
(WebKit::AcceleratedDrawingArea::scheduleInitialDeferredPaint):
* WebProcess/WebPage/AcceleratedDrawingArea.h:
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::layerFlushThrottlingIsActive const):
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.h:
* WebProcess/WebPage/RemoteLayerTree/RemoteLayerTreeDrawingArea.mm:
(WebKit::RemoteLayerTreeDrawingArea::RemoteLayerTreeDrawingArea):
(WebKit::RemoteLayerTreeDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::RemoteLayerTreeDrawingArea::initialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleInitialDeferredPaint):
(WebKit::RemoteLayerTreeDrawingArea::scheduleCompositingLayerFlush):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::scheduleInitialDeferredPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[MediaStream] User should not be prompted again after denying getDisplayMedia request
eric.carlson@apple.com [Sun, 4 Nov 2018 16:04:19 +0000 (16:04 +0000)]
[MediaStream] User should not be prompted again after denying getDisplayMedia request
https://bugs.webkit.org/show_bug.cgi?id=191227
<rdar://problem/45784512>

Reviewed by Youenn Fablet.

Source/WebKit:

* UIProcess/UserMediaPermissionRequestManagerProxy.cpp:
(WebKit::UserMediaPermissionRequestManagerProxy::userMediaAccessWasDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::wasRequestDenied):
(WebKit::UserMediaPermissionRequestManagerProxy::requestUserMediaPermissionForFrame):
* UIProcess/UserMediaPermissionRequestManagerProxy.h:

Tools:

* TestWebKitAPI/Tests/WebKitCocoa/GetDisplayMedia.mm:
(-[GetDisplayMediaUIDelegate _webView:requestUserMediaAuthorizationForDevices:url:mainFrameURL:decisionHandler:]):
(TestWebKitAPI::GetDisplayMediaTest::promptForCapture):
(TestWebKitAPI::TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[LFC][BFC] Add support for percentage height in quirks mode.
zalan@apple.com [Sun, 4 Nov 2018 15:46:38 +0000 (15:46 +0000)]
[LFC][BFC] Add support for percentage height in quirks mode.
https://bugs.webkit.org/show_bug.cgi?id=191232

Reviewed by Antti Koivisto.

Source/WebCore:

In quirks mode, we go and travers the containing block chain to find a block level
box with fixed height value to resolve the percentage value.

Test: fast/block/basic/quirk-mode-percent-height.html

* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):
* layout/Verification.cpp:
(WebCore::Layout::LayoutState::verifyAndOutputMismatchingLayoutTree const):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/basic/quirk-mode-percent-height-expected.txt: Added.
* fast/block/basic/quirk-mode-percent-height.html: Added.
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[LFC][BCF] Add support for block level non-replaced inflow height percentage
zalan@apple.com [Sun, 4 Nov 2018 15:44:57 +0000 (15:44 +0000)]
[LFC][BCF] Add support for block level non-replaced inflow height percentage
https://bugs.webkit.org/show_bug.cgi?id=191229

Reviewed by Antti Koivisto.

Source/WebCore:

Test: fast/block/basic/child-block-level-box-with-height-percent.html

* layout/FormattingContext.h:
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::computedHeightValue):
(WebCore::Layout::computedHeightValue): Deleted.
* layout/blockformatting/BlockFormattingContextGeometry.cpp:
(WebCore::Layout::BlockFormattingContext::Geometry::inFlowNonReplacedHeightAndMargin):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/basic/child-block-level-box-with-height-percent-expected.txt: Added.
* fast/block/basic/child-block-level-box-with-height-percent.html: Added.
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRealtimeOutgoingAudioSource should use DestructionThread::Main
youenn@apple.com [Sun, 4 Nov 2018 15:30:31 +0000 (15:30 +0000)]
RealtimeOutgoingAudioSource should use DestructionThread::Main
https://bugs.webkit.org/show_bug.cgi?id=191230

Reviewed by Eric Carlson.

Covered by imported/w3c/web-platform-tests/webrtc/RTCPeerConnection-setRemoteDescription-replaceTrack.https.html
that should no longer crash in debug.

* platform/mediastream/RealtimeOutgoingAudioSource.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoIDB should allow storing RTCCertificate
youenn@apple.com [Sun, 4 Nov 2018 10:28:11 +0000 (10:28 +0000)]
IDB should allow storing RTCCertificate
https://bugs.webkit.org/show_bug.cgi?id=191077

Reviewed by Chris Dumez.

LayoutTests/imported/w3c:

* web-platform-tests/webrtc/RTCCertificate-postMessage.html: Added.
* web-platform-tests/webrtc/resources/RTCCertificate-postMessage-iframe.html: Added.

Source/WebCore:

Add support for serialization/deserialization of RTCCertificate.
Store the origin in RTCCertificate and make sure that a certificate
with a different origin cannot be used to create a RTCPeerConnection.

Test: imported/w3c/web-platform-tests/webrtc/RTCCertificate-postMessage.html

* Modules/mediastream/PeerConnectionBackend.cpp:
(WebCore::PeerConnectionBackend::generateCertificate):
* Modules/mediastream/RTCCertificate.cpp:
(WebCore::RTCCertificate::create):
(WebCore::RTCCertificate::RTCCertificate):
* Modules/mediastream/RTCCertificate.h:
(WebCore::RTCCertificate::origin const):
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::RTCPeerConnection::certificatesFromConfiguration):
* Modules/mediastream/RTCPeerConnection.h:
* Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.cpp:
(WebCore::LibWebRTCCertificateGenerator::RTCCertificateGeneratorCallback::RTCCertificateGeneratorCallback):
(WebCore::LibWebRTCCertificateGenerator::generateCertificate):
* Modules/mediastream/libwebrtc/LibWebRTCCertificateGenerator.h:
* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):
(WebCore::CloneDeserializer::CachedString::takeString):
(WebCore::CloneDeserializer::readRTCCertificate):
(WebCore::CloneDeserializer::readTerminal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAdd support for RTCMuxPolicy
youenn@apple.com [Sun, 4 Nov 2018 07:55:02 +0000 (07:55 +0000)]
Add support for RTCMuxPolicy
https://bugs.webkit.org/show_bug.cgi?id=191188

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

* web-platform-tests/webrtc/RTCConfiguration-rtcpMuxPolicy-expected.txt:
* web-platform-tests/webrtc/rtcpeerconnection/rtcpeerconnection-constructor-expected.txt:

Source/WebCore:

Add support for RTCMuxPolicy dictionary option for both constructor and setConfiguration.
Make sure setConfiguration throws if trying to change this policy.
Pipe this parameter up to libwebrtc.
Covered by rebased test.

* Modules/mediastream/RTCConfiguration.h:
* Modules/mediastream/RTCConfiguration.idl:
* Modules/mediastream/RTCPeerConnection.cpp:
(WebCore::iceServersFromConfiguration):
(WebCore::RTCPeerConnection::initializeConfiguration):
(WebCore::RTCPeerConnection::setConfiguration):
* Modules/mediastream/libwebrtc/LibWebRTCPeerConnectionBackend.cpp:
(WebCore::rtcpMuxPolicyfromConfiguration):
(WebCore::configurationFromMediaEndpointConfiguration):
* WebCore.xcodeproj/project.pbxproj:
* platform/mediastream/MediaEndpointConfiguration.cpp:
(WebCore::MediaEndpointConfiguration::MediaEndpointConfiguration):
* platform/mediastream/MediaEndpointConfiguration.h:
* platform/mediastream/RTCPMuxPolicy.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoWeb Inspector: Canvas: capture changes to <canvas> that would affect the recorded...
drousso@apple.com [Sat, 3 Nov 2018 23:24:35 +0000 (23:24 +0000)]
Web Inspector: Canvas: capture changes to <canvas> that would affect the recorded context
https://bugs.webkit.org/show_bug.cgi?id=190854

Reviewed by Matt Baker.

Source/WebCore:

Updated existing tests: inspector/canvas/recording-2d.html
                        inspector/canvas/recording-bitmaprenderer.html
                        inspector/canvas/recording-webgl.html

* html/HTMLCanvasElement.idl:
Apply `CallTracingCallback=recordCanvasAction` to the `width` and `height` attributes so
that they are recorded through the same path as `CanvasRenderingContext`.

* html/CanvasBase.h:
* html/CanvasBase.cpp:
(WebCore::CanvasBase::callTracingActive const): Added.

* bindings/js/CallTracer.h:
* bindings/js/CallTracer.cpp:
(WebCore::CallTracer::recordCanvasAction):

Source/WebInspectorUI:

* UserInterface/Models/RecordingAction.js:
(WI.RecordingAction):
(WI.RecordingAction.isFunctionForType):
(WI.RecordingAction.constantNameForParameter):
(WI.RecordingAction.prototype.get contextReplacer): Added.
(WI.RecordingAction.prototype.async.swizzle):
(WI.RecordingAction.prototype.apply):
Create a constant list of actions for each recording type that need to replace the context
with a different value before being applied (e.g. `width` should be applied to the
`context`'s `canvas` instead of directly to the `context`).

* UserInterface/Views/RecordingContentView.js:
(WI.RecordingContentView.prototype._generateContentCanvas2D.actionModifiesPath): Added.
(WI.RecordingContentView.prototype._generateContentCanvas2D):
(WI.RecordingContentView._actionModifiesPath): Deleted.
Generate the path context after the actions are applied to the preview context so that the
final width/height are known and can be used. This is needed because changing the
width/height causes the content to be erased.

* UserInterface/Views/RecordingActionTreeElement.js:
(WI.RecordingActionTreeElement._generateDOM):
(WI.RecordingActionTreeElement._classNameForAction):
* UserInterface/Views/RecordingActionTreeElement.css:
(.tree-outline:focus .item.action.selected:not(.invalid, .initial-state, .has-context-replacer) > .icon): Added.
(.item.action > .titles .context-replacer::after): Added.
(.item.action.has-context-replacer > .icon): Added.
(@media (prefers-dark-interface) .item.action:not(.invalid, .initial-state, .has-context-replacer) > .icon): Added.
(.tree-outline:focus .item.action.selected:not(.initial-state, .invalid) > .icon): Deleted.
(@media (prefers-dark-interface) .item.action:not(.initial-state) > .icon): Deleted.
(@media (prefers-dark-interface) .tree-outline:not(.hide-disclosure-buttons) .item.action:not(.initial-state, .parent) > .icon): Deleted.
Add the context replacer text to the beginning of the action's name if it exists.

* UserInterface/Views/CanvasContentView.js:
(WI.CanvasContentView.prototype._refreshPixelSize):
(WI.CanvasContentView.prototype._updatePixelSize): Deleted.
Update preview image when the canvas' size changes.

LayoutTests:

* inspector/canvas/recording-2d-expected.txt:
* inspector/canvas/recording-2d.html:
* inspector/canvas/recording-bitmaprenderer-expected.txt:
* inspector/canvas/recording-bitmaprenderer.html:
* inspector/canvas/recording-webgl-expected.txt:
* inspector/canvas/recording-webgl.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Payment Request] PaymentResponse.retry()'s errorFields should be optional
aestes@apple.com [Sat, 3 Nov 2018 18:45:47 +0000 (18:45 +0000)]
[Payment Request] PaymentResponse.retry()'s errorFields should be optional
https://bugs.webkit.org/show_bug.cgi?id=191212

Reviewed by Youenn Fablet.

Source/WebCore:

Per WebIDL, the errorFields argument to PaymentResponse.retry() should be optional. See
<https://github.com/w3c/payment-request/issues/804> for details.

Added test case to http/tests/paymentrequest/payment-response-retry-method.https.html.

* Modules/paymentrequest/PaymentResponse.idl:

LayoutTests:

* http/tests/paymentrequest/payment-response-retry-method.https-expected.txt:
* http/tests/paymentrequest/payment-response-retry-method.https.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[LFC][BFC] Resolve percentage height values.
zalan@apple.com [Sat, 3 Nov 2018 17:57:49 +0000 (17:57 +0000)]
[LFC][BFC] Resolve percentage height values.
https://bugs.webkit.org/show_bug.cgi?id=191224

Reviewed by Antti Koivisto.

Source/WebCore:

10.5 Content height: the 'height' property
The percentage is calculated with respect to the height of the generated box's containing block.
If the height of the containing block is not specified explicitly (i.e., it depends on content height),
and this element is not absolutely positioned, the used height is calculated as if 'auto' was specified.

https://www.w3.org/TR/CSS22/visudet.html#propdef-height

Test: fast/block/basic/height-percentage-simple.html

* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::isHeightAuto):
(WebCore::Layout::computedHeightValue):
(WebCore::Layout::contentHeightForFormattingContextRoot):
(WebCore::Layout::FormattingContext::Geometry::computedMaxHeight):
(WebCore::Layout::FormattingContext::Geometry::computedMinHeight):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedVerticalGeometry):
(WebCore::Layout::FormattingContext::Geometry::complicatedCases):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedHeightAndMargin):
(WebCore::Layout::FormattingContext::Geometry::inlineReplacedWidthAndMargin):

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/block/basic/height-percentage-simple-expected.txt: Added.
* fast/block/basic/height-percentage-simple.html: Added.
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoMac production builds should sign the network process xpc service with entitlements
achristensen@apple.com [Sat, 3 Nov 2018 15:22:55 +0000 (15:22 +0000)]
Mac production builds should sign the network process xpc service with entitlements
https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

* Configurations/Network-OSX.entitlements: Copied from Configurations/Network-OSX-sandbox.entitlements.
* Configurations/NetworkService.xcconfig:
Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process,
except with the corresponoding network process entitlements file.
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _networkProcessHasEntitlementForTesting:]):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):
* UIProcess/WebProcessPool.h:
* WebKit.xcodeproj/project.pbxproj:
Add infrastructure to test that the network process actually has an entitlement.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRefresh WPT webrtc tests
youenn@apple.com [Sat, 3 Nov 2018 14:57:19 +0000 (14:57 +0000)]
Refresh WPT webrtc tests
https://bugs.webkit.org/show_bug.cgi?id=191133

Reviewed by Eric Carlson.

LayoutTests/imported/w3c:

* web-platform-tests/webrtc/: Refreshed.
* web-platform-tests/webrtc/w3c-import.log:

LayoutTests:

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WPE] Add the WebKitVersion.h header
philn@webkit.org [Sat, 3 Nov 2018 14:29:44 +0000 (14:29 +0000)]
[WPE] Add the WebKitVersion.h header
https://bugs.webkit.org/show_bug.cgi?id=191015
<rdar://problem/45647211>

Reviewed by Michael Catanzaro.

* PlatformWPE.cmake: Install the generated header as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, fix WebDriver expectations syntax after previous commit
mcatanzaro@igalia.com [Sat, 3 Nov 2018 14:04:11 +0000 (14:04 +0000)]
Unreviewed, fix WebDriver expectations syntax after previous commit

* TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[MediaStream] enumerateDevices should not expose devices that are not available to...
eric.carlson@apple.com [Sat, 3 Nov 2018 13:30:30 +0000 (13:30 +0000)]
[MediaStream] enumerateDevices should not expose devices that are not available to getUserMedia
https://bugs.webkit.org/show_bug.cgi?id=191177
<rdar://problem/45747873>

Reviewed by Jer Noble.

Source/WebCore:

Test: http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html

* Modules/mediastream/MediaDevicesRequest.cpp:
(WebCore::MediaDevicesRequest::start): Only expose devices that are available to gUM.

* Modules/mediastream/UserMediaController.cpp:
(WebCore::isSecure): Moved from UserMediaRequest.cpp.
(WebCore::isAllowedToUse): Ditto.
(WebCore::UserMediaController::canCallGetUserMedia): Modified from UserMediaRequest.cpp.
(WebCore::UserMediaController::logGetUserMediaDenial): Log reason for denial.
* Modules/mediastream/UserMediaController.h:

* Modules/mediastream/UserMediaRequest.cpp:
(WebCore::UserMediaRequest::start): Use UserMediaController::canCallGetUserMedia.
(WebCore::isSecure): Deleted.
(WebCore::isAllowedToUse): Deleted.
(WebCore::canCallGetUserMedia): Deleted.

LayoutTests:

* http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute-expected.txt: Added.
* http/tests/media/media-stream/enumerate-devices-iframe-allow-attribute.html: Added.
* http/tests/media/media-stream/resources/enumerate-devices-iframe.html: Added.
* http/tests/ssl/media-stream/get-user-media-different-host-expected.txt: Rebased for updated logging.
* http/tests/ssl/media-stream/get-user-media-nested-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, rolling out r237761.
achristensen@apple.com [Sat, 3 Nov 2018 06:25:56 +0000 (06:25 +0000)]
Unreviewed, rolling out r237761.

Makes most API tests timeout and WK2 tests crash

Reverted changeset:

"Mac production builds should sign the network process xpc
service with entitlements"
https://bugs.webkit.org/show_bug.cgi?id=191209
https://trac.webkit.org/changeset/237761

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed WebDriver expectations gardening
mcatanzaro@igalia.com [Sat, 3 Nov 2018 05:53:38 +0000 (05:53 +0000)]
Unreviewed WebDriver expectations gardening

There are still a few more flaky tests, but this should improve things significantly.

* TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed API test gardening
mcatanzaro@igalia.com [Sat, 3 Nov 2018 05:27:08 +0000 (05:27 +0000)]
Unreviewed API test gardening

* TestWebKitAPI/glib/TestExpectations.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAdd new global object and preliminary Worklets support for CSS painting api
justin_michaud@apple.com [Sat, 3 Nov 2018 04:01:29 +0000 (04:01 +0000)]
Add new global object and preliminary Worklets support for CSS painting api
https://bugs.webkit.org/show_bug.cgi?id=190979

Reviewed by Chris Dumez.

Source/WebCore:

Test: fast/css-custom-paint/worklet.html

Add a new ScriptExecutionContext and global object to run worklets in. This is mostly copy+paste
from Workers, but without any of the threading. Worklet.addModule does not yet support loading scripts
or doing cross origin checking. There are quite a few parts of the ScriptExecutionContext api that are
left as ASSERT_NOT_REACHED().

* CMakeLists.txt:
* DerivedSources.make:
* Sources.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/JSDOMGlobalObject.cpp:
(WebCore::JSDOMGlobalObject::scriptExecutionContext const):
* bindings/js/JSPaintWorkletGlobalScopeCustom.cpp: Renamed from Source/WebCore/bindings/js/JSCSSPaintWorkletGlobalScopeCustom.cpp.
(WebCore::JSPaintWorkletGlobalScope::visitAdditionalChildren):
(WebCore::JSPaintWorkletGlobalScope::registerPaint):
* bindings/js/JSWorkletGlobalScopeBase.cpp: Added.
(WebCore::JSWorkletGlobalScopeBase::JSWorkletGlobalScopeBase):
(WebCore::JSWorkletGlobalScopeBase::finishCreation):
(WebCore::JSWorkletGlobalScopeBase::clearDOMGuardedObjects):
(WebCore::JSWorkletGlobalScopeBase::visitChildren):
(WebCore::JSWorkletGlobalScopeBase::destroy):
(WebCore::JSWorkletGlobalScopeBase::scriptExecutionContext const):
(WebCore::JSWorkletGlobalScopeBase::supportsRichSourceInfo):
(WebCore::JSWorkletGlobalScopeBase::shouldInterruptScript):
(WebCore::JSWorkletGlobalScopeBase::shouldInterruptScriptBeforeTimeout):
(WebCore::JSWorkletGlobalScopeBase::javaScriptRuntimeFlags):
(WebCore::toJS):
(WebCore::toJSWorkletGlobalScope):
* bindings/js/JSWorkletGlobalScopeBase.h: Added.
(WebCore::JSWorkletGlobalScopeBase::wrapped const):
(WebCore::JSWorkletGlobalScopeBase::proxy const):
(WebCore::JSWorkletGlobalScopeBase::createStructure):
(WebCore::toJS):
* bindings/js/ScriptState.cpp:
(WebCore::execStateFromWorkerGlobalScope):
(WebCore::execStateFromWorkletGlobalScope):
* bindings/js/ScriptState.h:
* bindings/js/WebCoreBuiltinNames.h:
* bindings/scripts/CodeGeneratorJS.pm:
(IsDOMGlobalObject):
(ShouldUseGlobalObjectPrototype):
(GenerateHeader):
(GenerateRuntimeEnableConditionalStringForExposed):
(GenerateImplementation):
* bindings/scripts/preprocess-idls.pl:
* css/CSSPaintImageValue.cpp:
(WebCore::CSSPaintImageValue::image):
* css/DOMCSSPaintWorklet.cpp:
(WebCore::DOMCSSPaintWorklet::ensurePaintWorklet):
(WebCore::DOMCSSPaintWorklet::ensurePaintWorkletGlobalScope): Deleted.
* css/DOMCSSPaintWorklet.h:
* css/DOMCSSPaintWorklet.idl:
* dom/Document.cpp:
(WebCore::Document::ensureCSSPaintWorklet):
(WebCore::Document::setCSSPaintWorkletGlobalScope):
(WebCore::Document::ensureCSSPaintWorkletGlobalScope): Deleted.
* dom/Document.h:
(WebCore::Document::getCSSPaintWorkletGlobalScope):
* dom/EventTargetFactory.in:
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::vm):
(WebCore::ScriptExecutionContext::execState):
* dom/ScriptExecutionContext.h:
(WebCore::ScriptExecutionContext::isWorkletGlobalScope const):
* inspector/agents/worker/WorkerDebuggerAgent.cpp:
(WebCore::WorkerDebuggerAgent::injectedScriptForEval):
* inspector/agents/worker/WorkerRuntimeAgent.cpp:
(WebCore::WorkerRuntimeAgent::injectedScriptForEval):
* platform/graphics/CustomPaintImage.cpp:
(WebCore::CustomPaintImage::CustomPaintImage):
(WebCore::CustomPaintImage::doCustomPaint):
* platform/graphics/CustomPaintImage.h:
* worklets/PaintWorkletGlobalScope.cpp: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.cpp.
(WebCore::PaintWorkletGlobalScope::create):
(WebCore::PaintWorkletGlobalScope::PaintWorkletGlobalScope):
(WebCore::PaintWorkletGlobalScope::devicePixelRatio):
(WebCore::PaintWorkletGlobalScope::addRegisteredPaint):
* worklets/PaintWorkletGlobalScope.h: Renamed from Source/WebCore/css/CSSPaintWorkletGlobalScope.h.
* worklets/PaintWorkletGlobalScope.idl: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.idl.
* worklets/Worklet.cpp: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.cpp.
(WebCore::Worklet::create):
(WebCore::Worklet::Worklet):
(WebCore::Worklet::addModule):
* worklets/Worklet.h: Renamed from Source/WebCore/css/CSSPaintWorkletGlobalScope.cpp.
* worklets/Worklet.idl: Copied from Source/WebCore/css/CSSPaintWorkletGlobalScope.idl.
* worklets/WorkletConsoleClient.cpp: Copied from Source/WebCore/inspector/agents/worker/WorkerDebuggerAgent.cpp.
(WebCore::WorkletConsoleClient::WorkletConsoleClient):
(WebCore::WorkletConsoleClient::messageWithTypeAndLevel):
(WebCore::WorkletConsoleClient::count):
(WebCore::WorkletConsoleClient::time):
(WebCore::WorkletConsoleClient::timeEnd):
(WebCore::WorkletConsoleClient::profile):
(WebCore::WorkletConsoleClient::profileEnd):
(WebCore::WorkletConsoleClient::takeHeapSnapshot):
(WebCore::WorkletConsoleClient::timeStamp):
(WebCore::WorkletConsoleClient::record):
(WebCore::WorkletConsoleClient::recordEnd):
* worklets/WorkletConsoleClient.h: Added.
* worklets/WorkletGlobalScope.cpp: Added.
(WebCore::WorkletGlobalScope::WorkletGlobalScope):
(WebCore::WorkletGlobalScope::~WorkletGlobalScope):
(WebCore::WorkletGlobalScope::evaluate):
(WebCore::WorkletGlobalScope::isJSExecutionForbidden const):
(WebCore::WorkletGlobalScope::disableEval):
(WebCore::WorkletGlobalScope::disableWebAssembly):
(WebCore::WorkletGlobalScope::completeURL const):
(WebCore::WorkletGlobalScope::logExceptionToConsole):
(WebCore::WorkletGlobalScope::addConsoleMessage):
(WebCore::WorkletGlobalScope::addMessage):
* worklets/WorkletGlobalScope.h: Added.
(WebCore::WorkletGlobalScope::isPaintWorkletGlobalScope const):
(WebCore::WorkletGlobalScope::identifier const):
(WebCore::WorkletGlobalScope::script):
(WebCore::WorkletGlobalScope::jsRuntimeFlags const):
(isType):
* worklets/WorkletGlobalScope.idl: Renamed from Source/WebCore/css/CSSPaintWorkletGlobalScope.idl.
* worklets/WorkletScriptController.cpp: Added.
(WebCore::WorkletScriptController::WorkletScriptController):
(WebCore::WorkletScriptController::~WorkletScriptController):
(WebCore::WorkletScriptController::forbidExecution):
(WebCore::WorkletScriptController::isExecutionForbidden const):
(WebCore::WorkletScriptController::disableEval):
(WebCore::WorkletScriptController::disableWebAssembly):
(WebCore::WorkletScriptController::initScriptWithSubclass):
(WebCore::WorkletScriptController::initScript):
(WebCore::WorkletScriptController::evaluate):
(WebCore::WorkletScriptController::setException):
* worklets/WorkletScriptController.h: Added.
(WebCore::WorkletScriptController::workletGlobalScopeWrapper):
(WebCore::WorkletScriptController::vm):
(WebCore::WorkletScriptController::initScriptIfNeeded):

Tools:

* Scripts/webkitpy/bindings/main.py:
(BindingsTests.generate_supplemental_dependency):
(BindingsTests.main):

LayoutTests:

Add a new test harness for worklet tests, since they do not have access to the dom.

* fast/css-custom-paint/basic-expected.txt:
* fast/css-custom-paint/basic.html:
* fast/css-custom-paint/registerPaintBindings-expected.html: Added.
* fast/css-custom-paint/registerPaintBindings-expected.txt: Removed.
* fast/css-custom-paint/registerPaintBindings.html:
* fast/css-custom-paint/resources/testharness-worklet.js: Added.
(format_value):
* fast/css-custom-paint/resources/testharness.js: Added.
(async.importWorklet):
* fast/css-custom-paint/worklet-expected.html: Added.
* fast/css-custom-paint/worklet.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoClean up drawLineForDocumentMarker()
mmaxfield@apple.com [Sat, 3 Nov 2018 02:36:28 +0000 (02:36 +0000)]
Clean up drawLineForDocumentMarker()
https://bugs.webkit.org/show_bug.cgi?id=191215

Reviewed by Zalan Bujtas.

In preparation for https://bugs.webkit.org/show_bug.cgi?id=190764, I need to do a little bit of refactoring.
This patch has no behavior change; it just does the following:

1. Renames drawLineForDocumentMarker() to drawDotsForDocumentMarker(), because 2 of the 3 implementations draw dots
2. Moves our implementation back into GraphicsContext, because it's simpler and  GraphicsContext is already platform-
       specific.
3. The signature used to accept a location and a width, but without a height, it's difficult to know what the bounding
       box is. In particular, knowing the bounding box must be possible without a GraphicsContext. So, I've modified
       the signature to accept a rectangle instead. The GraphicsContext draws only within this rectangle.

No new tests because there is no behavior change.

* platform/graphics/GraphicsContext.h:
* platform/graphics/GraphicsContextImpl.h:
* platform/graphics/cairo/CairoOperations.cpp:
(WebCore::Cairo::drawDotsForDocumentMarker):
(WebCore::Cairo::drawLineForDocumentMarker): Deleted.
* platform/graphics/cairo/CairoOperations.h:
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.
* platform/graphics/cairo/GraphicsContextImplCairo.cpp:
(WebCore::GraphicsContextImplCairo::drawDotsForDocumentMarker):
(WebCore::GraphicsContextImplCairo::drawLineForDocumentMarker): Deleted.
* platform/graphics/cairo/GraphicsContextImplCairo.h:
* platform/graphics/cocoa/FontCascadeCocoa.mm:
* platform/graphics/cocoa/GraphicsContextCocoa.mm:
(WebCore::colorForMarkerLineStyle):
(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.
* platform/graphics/displaylists/DisplayListItems.cpp:
(WebCore::DisplayList::Item::sizeInBytes):
(WebCore::DisplayList::DrawDotsForDocumentMarker::apply const):
(WebCore::DisplayList::DrawDotsForDocumentMarker::localBounds const):
(WebCore::DisplayList::operator<<):
(WebCore::DisplayList::DrawLineForDocumentMarker::apply const): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::localBounds const): Deleted.
* platform/graphics/displaylists/DisplayListItems.h:
(WebCore::DisplayList::DrawDotsForDocumentMarker::create):
(WebCore::DisplayList::DrawDotsForDocumentMarker::rect const):
(WebCore::DisplayList::DrawDotsForDocumentMarker::DrawDotsForDocumentMarker):
(WebCore::DisplayList::DrawLineForDocumentMarker::create): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::point const): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::width const): Deleted.
(WebCore::DisplayList::DrawLineForDocumentMarker::DrawLineForDocumentMarker): Deleted.
* platform/graphics/displaylists/DisplayListRecorder.cpp:
(WebCore::DisplayList::Recorder::drawDotsForDocumentMarker):
(WebCore::DisplayList::Recorder::drawLineForDocumentMarker): Deleted.
* platform/graphics/displaylists/DisplayListRecorder.h:
* platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.cpp:
(Nicosia::CairoOperationRecorder::drawDotsForDocumentMarker):
(Nicosia::CairoOperationRecorder::drawLineForDocumentMarker): Deleted.
* platform/graphics/nicosia/cairo/NicosiaCairoOperationRecorder.h:
* platform/graphics/win/GraphicsContextCGWin.cpp:
(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.
* platform/graphics/win/GraphicsContextDirect2D.cpp:
(WebCore::GraphicsContext::drawDotsForDocumentMarker):
(WebCore::GraphicsContext::drawLineForDocumentMarker): Deleted.
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintPlatformDocumentMarker):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::drawLineForDocumentMarker): Deleted.
* rendering/RenderTheme.h:
* rendering/RenderThemeCocoa.h:
* rendering/RenderThemeCocoa.mm:
(WebCore::RenderThemeCocoa::drawLineForDocumentMarker): Deleted.
* rendering/RenderThemeIOS.h:
* rendering/RenderThemeIOS.mm:
(WebCore::RenderThemeIOS::colorForMarkerLineStyle): Deleted.
* rendering/RenderThemeMac.h:
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::colorForMarkerLineStyle): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAssert JSValues can fit into a pointer when API casting
keith_miller@apple.com [Sat, 3 Nov 2018 01:52:35 +0000 (01:52 +0000)]
Assert JSValues can fit into a pointer when API casting
https://bugs.webkit.org/show_bug.cgi?id=191220

Reviewed by Michael Saboff.

* API/APICast.h:
(toJS):
(toJSForGC):
(toRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRolling in r237753 with unreviewed build fix.
msaboff@apple.com [Sat, 3 Nov 2018 01:27:42 +0000 (01:27 +0000)]
Rolling in r237753 with unreviewed build fix.

Fixed issues with DECLARE_THROW_SCOPE placement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, attempt to fix the build with recent SDKs.
ryanhaddad@apple.com [Sat, 3 Nov 2018 00:49:49 +0000 (00:49 +0000)]
Unreviewed, attempt to fix the build with recent SDKs.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.mm:
(WebKit::XPCServiceExit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoMac production builds should sign the network process xpc service with entitlements
achristensen@apple.com [Sat, 3 Nov 2018 00:33:53 +0000 (00:33 +0000)]
Mac production builds should sign the network process xpc service with entitlements
https://bugs.webkit.org/show_bug.cgi?id=191209
<rdar://problem/45377609>

Reviewed by Geoff Garen.

Source/WebKit:

* Configurations/NetworkService.xcconfig:
Set CODE_SIGN_ENTITLEMENTS_COCOA_TOUCH_NO like we do for the web process,
except with the corresponoding network process entitlements file.
* UIProcess/API/Cocoa/WKProcessPool.mm:
(-[WKProcessPool _networkProcessHasEntitlementForTesting:]):
* UIProcess/API/Cocoa/WKProcessPoolPrivate.h:
* UIProcess/Cocoa/WebProcessPoolCocoa.mm:
(WebKit::WebProcessPool::networkProcessHasEntitlementForTesting):
* UIProcess/WebProcessPool.h:
Add infrastructure to test that the network process actually has an entitlement.

Tools:

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitCocoa/NetworkProcess.mm: Added.
(TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoREGRESSION (r237699): Layout Test http/tests/security/anchor-download-block-crossorig...
cdumez@apple.com [Sat, 3 Nov 2018 00:06:09 +0000 (00:06 +0000)]
REGRESSION (r237699): Layout Test http/tests/security/anchor-download-block-crossorigin.html is a flaky failure
https://bugs.webkit.org/show_bug.cgi?id=191199

Reviewed by Dewei Zhu.

Navigate the subframe instead of the main frame, to make sure that the console message is consistently logged.

* http/tests/security/anchor-download-block-crossorigin-expected.txt:
* http/tests/security/anchor-download-block-crossorigin.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoFollow-up fix for the webkit.org blog index page
jond@apple.com [Fri, 2 Nov 2018 23:20:42 +0000 (23:20 +0000)]
Follow-up fix for the webkit.org blog index page
https://bugs.webkit.org/show_bug.cgi?id=191216

Reviewed by Timothy Hatcher.

* wp-content/themes/webkit/index.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, rolling out r237753.
ryanhaddad@apple.com [Fri, 2 Nov 2018 22:47:14 +0000 (22:47 +0000)]
Unreviewed, rolling out r237753.

Introduced JSC test failures

Reverted changeset:

"Running out of stack space not properly handled in
RegExp::compile() and its callers"
https://bugs.webkit.org/show_bug.cgi?id=191206
https://trac.webkit.org/changeset/237753

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Win] Layout Test fast/block/basic/inline-content-with-floating-image.html is failing
pvollan@apple.com [Fri, 2 Nov 2018 22:46:14 +0000 (22:46 +0000)]
[Win] Layout Test fast/block/basic/inline-content-with-floating-image.html is failing
https://bugs.webkit.org/show_bug.cgi?id=191194

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAdd Windows 10 archive bots
lforschler@apple.com [Fri, 2 Nov 2018 22:35:49 +0000 (22:35 +0000)]
Add Windows 10 archive bots
https://bugs.webkit.org/show_bug.cgi?id=190964

This Change updates the Apple Windows Buildbot configuration.
- Add Windows 10 specific builders and testers for release and debug.
- Refactor Windows -> Windows 7.
- Remove Windows 7 Debug.

Reviewed by Aakash Jain.

* BuildSlaveSupport/build.webkit.org-config/config.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agorequestAnimationFrame causes bad location of position:fixed inside overflow:auto...
ajuma@chromium.org [Fri, 2 Nov 2018 22:07:18 +0000 (22:07 +0000)]
requestAnimationFrame causes bad location of position:fixed inside overflow:auto and iframe
https://bugs.webkit.org/show_bug.cgi?id=176243

Reviewed by Simon Fraser.

When a new layer tree is committed to the UIProcess, the positions of layers for fixed
or sticky nodes in the newly-committed tree can be stale, because of scrolling that has
happened in the UIProcess since the tree was updated in the WebProcess. To handle this,
RemoteLayerTreeDrawingAreaProxy::commitLayerTree updates the positions of these layers
by calling RemoteScrollingCoordinatorProxy::viewportChangedViaDelegatedScrolling, which
leads to a recursive traversal of the ScrollingTree to update each such layer. However,
since ScrollingTreeFrameScrollingNodeIOS didn't implement updateLayersAfterAncestorChange,
this traversal never descended into scrolling nodes within an iframe, so the layers for
these nodes were left with stale positions.

Implement ScrollingTreeFrameScrollingNodeIOS::updateLayersAfterAncestorChange so that
fixed and sticky layers within an iframe do get their positions updated when a new layer
tree is committed.

* page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.h:
* page/scrolling/ios/ScrollingTreeFrameScrollingNodeIOS.mm:
(WebCore::ScrollingTreeFrameScrollingNodeIOS::updateLayersAfterAncestorChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRunning out of stack space not properly handled in RegExp::compile() and its callers
msaboff@apple.com [Fri, 2 Nov 2018 22:05:51 +0000 (22:05 +0000)]
Running out of stack space not properly handled in RegExp::compile() and its callers
https://bugs.webkit.org/show_bug.cgi?id=191206

Reviewed by Filip Pizlo.

JSTests:

New regression test.

* stress/regexp-compile-oom.js: Added.
(recurseAndTest):

Source/JavaScriptCore:

Eliminated two RELEASE_ASSERT_NOT_REACHED() for errors returned by Yarr parsing code.  Bubbled those errors
up to where they are turned into the appropriate exceptions in matchInline().  If the errors are not due
to syntax, we reset the RegExp state in case the parsing is tried with a smaller stack.

* runtime/RegExp.cpp:
(JSC::RegExp::compile):
(JSC::RegExp::compileMatchOnly):
* runtime/RegExp.h:
* runtime/RegExpInlines.h:
(JSC::RegExp::compileIfNecessary):
(JSC::RegExp::matchInline):
(JSC::RegExp::compileIfNecessaryMatchOnly):
* runtime/RegExpObjectInlines.h:
(JSC::RegExpObject::execInline):
* yarr/YarrErrorCode.h:
(JSC::Yarr::hasHardError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoImproved the SVG icons to use SVG symbols
jond@apple.com [Fri, 2 Nov 2018 21:43:42 +0000 (21:43 +0000)]
Improved the SVG icons to use SVG symbols
https://bugs.webkit.org/show_bug.cgi?id=191205

Reviewed by Timothy Hatcher.

This change makes it far easier to add new SVG icons to the
icons.svg sprite and provides better positioning control
over the icons within the blog post tile frame.

* wp-content/themes/webkit/front-page.php:
* wp-content/themes/webkit/functions.php:
* wp-content/themes/webkit/header.php:
* wp-content/themes/webkit/images/icons.svg:
* wp-content/themes/webkit/index.php:
* wp-content/themes/webkit/loop.php:
* wp-content/themes/webkit/style.css:
(@supports ( -webkit-backdrop-filter: blur(10px) )):
(footer):
(#icons):
(.tile .background-image):
(.tile .background-image svg):
(.tile.category-web-inspector svg):
(.tile.category-performance svg):
(.tile.category-javascript svg):
(.tile.category-css svg):
(.tile.category-standards svg):
(.tile.category-contributing svg):
(.tile.category-storage svg):
(.tile.category-layout svg):
(.tile.category-safari-technology-preview svg):
(.tile.category-accessibility svg):
(.tile.category-security svg):
(.tile.category-privacy svg):
(header .menu-item-has-children .label-toggle::after):
(@media only screen and (max-width: 920px)):
(.main-menu.label-toggle):
(header .menu):
(@media only screen and (max-width: 690px)):
(@media only screen and (max-width: 415px)):
(@media only screen and (max-height: 415px)):
(.tile.category-web-inspector .background-image): Deleted.
(.tile.category-performance .background-image): Deleted.
(.tile.category-javascript .background-image): Deleted.
(.tile.category-css .background-image): Deleted.
(.tile.category-standards .background-image): Deleted.
(.tile.category-contributing .background-image): Deleted.
(.tile.category-storage .background-image): Deleted.
(.tile.category-layout .background-image): Deleted.
(.tile.category-safari-technology-preview .background-image): Deleted.
(.tile.category-accessibility .background-image): Deleted.
(.tile.tag-console .background-image,): Deleted.
(.tile.tag-console .background-image): Deleted.
(.tile.tag-debugger .background-image): Deleted.
(.tile.tag-shortcuts .background-image): Deleted.
(.tile.tag-timeline .background-image): Deleted.
* wp-content/themes/webkit/widgets/post.php:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoWeb Inspector: support multiple selection/deletion of cookie records
mattbaker@apple.com [Fri, 2 Nov 2018 19:39:01 +0000 (19:39 +0000)]
Web Inspector: support multiple selection/deletion of cookie records
https://bugs.webkit.org/show_bug.cgi?id=66381
<rdar://problem/19281525>

Reviewed by Devin Rousso.

* Localizations/en.lproj/localizedStrings.js:

* UserInterface/Views/CookieStorageContentView.js:
(WI.CookieStorageContentView):
(WI.CookieStorageContentView.prototype.get scrollableElements):
(WI.CookieStorageContentView.prototype.tableNumberOfRows):
(WI.CookieStorageContentView.prototype.tableSortChanged):
(WI.CookieStorageContentView.prototype.tableCellContextMenuClicked):
(WI.CookieStorageContentView.prototype.tableDidRemoveRows):
(WI.CookieStorageContentView.prototype.tablePopulateCell):
(WI.CookieStorageContentView.prototype.initialLayout):
(WI.CookieStorageContentView.prototype._generateSortComparator):
(WI.CookieStorageContentView.prototype._refreshButtonClicked):
(WI.CookieStorageContentView.prototype._reloadCookies):
(WI.CookieStorageContentView.prototype._updateSort):
(WI.CookieStorageContentView.prototype._handleTableKeyDown):
(WI.CookieStorageContentView.prototype.update): Deleted.
(WI.CookieStorageContentView.prototype._rebuildTable): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid.localeCompare): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid.numberCompare): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid.expiresCompare): Deleted.
(WI.CookieStorageContentView.prototype._sortDataGrid): Deleted.
(WI.CookieStorageContentView.prototype._deleteCallback): Deleted.
Replace DataGrid with Table. The content view serves as the table
delegate and data source, and handles delete and backspace key events
to allow deleting the selected cookies. Cookies may also be deleted from
the table context menu and a new button in the navigation bar.

* UserInterface/Views/Table.js:
(WI.Table.prototype.isRowSelected):
(WI.Table.prototype.selectRow):
(WI.Table.prototype.deselectRow):
(WI.Table.prototype.removeRow):
(WI.Table.prototype._getOrCreateRow):
(WI.Table.prototype._handleMouseDown):
(WI.Table.prototype._removeRows):
(WI.Table.prototype._isRowSelected): Deleted.
Make `isSelectedRow` public. It is more convenient and efficient than
calling `Table.prototype.selectedRows.includes(rowIndex)`.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAPI should use wrapper object if address is 32-bit
keith_miller@apple.com [Fri, 2 Nov 2018 19:03:44 +0000 (19:03 +0000)]
API should use wrapper object if address is 32-bit
https://bugs.webkit.org/show_bug.cgi?id=191203

Reviewed by Filip Pizlo.

* API/APICast.h:
(toJS):
(toJSForGC):
(toRef):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[iOS] Changing view scale sometimes does not zoom the page to the new initial scale...
wenson_hsieh@apple.com [Fri, 2 Nov 2018 18:10:23 +0000 (18:10 +0000)]
[iOS] Changing view scale sometimes does not zoom the page to the new initial scale, when the page is at initial scale
https://bugs.webkit.org/show_bug.cgi?id=191180
<rdar://problem/45744786>

Reviewed by Simon Fraser.

Source/WebCore:

When computing the minimum scale in ViewportConfiguration::minimumScale, if our content width or height is
shorter than the view width or height, then we recompute the minimum scale such that the content dimensions will
fill the bounds of the view by setting the minimum scale to the view width or height divided by the content
width or height.

Suppose the minimum scale is equal to some value `s`; additionally, let `w_c` denote the content width and `w_v`
denote the view width (as integers). If `w_v / s` is not an integral value, the computed content width `w_c` may
be rounded, such that `w_v / w_c` is not precisely equal to `s`. In the case that `w_v / w_c` is ever so
slightly larger than `s`, we will end up overriding the minimum scale `s` with `w_v / w_c`.

As a result, specifying a viewport with a decimal `minimum-scale` will sometimes cause the computed minimum
scale of the viewport (and platform view) to be very slightly different from the minimum scale. The new layout
test below exercises this scenario, specifying a viewport with minimum and initial scales of 0.94 that results
in `ViewportConfiguration::minimumScale` returning 0.94158.

With the `WebPage::setViewportConfigurationViewLayoutSize` check added in r237127, this means setting
`_viewScale:` when the page is at initial scale sometimes doesn't zoom the page to the new initial scale when it
should, since the page scale factor and the initial scale are different enough such that
`areEssentiallyEqualAsFloat` returns false.

This patch addresses these issues by snapping to the minimum scale if the computed scale that fits content
dimensions to view dimensions results in a minimum scale that is close enough to the configuration's minimum
scale, such that the difference can be attributed to rounding error when computing content or view dimensions.

Test: fast/viewport/ios/viewport-minimum-and-initial-scale.html

* page/ViewportConfiguration.cpp:
(WebCore::ViewportConfiguration::minimumScale const):

LayoutTests:

Add a layout test, and make some adjustments to UIHelper.

* fast/viewport/ios/constant-width-viewport-after-changing-view-scale.html:
* fast/viewport/ios/device-width-viewport-after-changing-view-scale.html:
* fast/viewport/ios/viewport-minimum-and-initial-scale-expected.txt: Added.
* fast/viewport/ios/viewport-minimum-and-initial-scale.html: Added.

Add a new layout test that contains a viewport meta tag with minimum and initial scales set to 0.94, and checks
that the resulting minimum and initial scales are 0.94 instead of 0.94158.

* fast/viewport/watchos/viewport-disable-extra-zoom-adaptations.html:
* resources/ui-helper.js:

Make UIHelper.zoomScale return a number rather than a string, and adjust a few call sites.

(window.UIHelper.zoomScale):
(window.UIHelper.minimumZoomScale):
(window.UIHelper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GTK][WPE] Unreviewed, another --no-video --no-web-audio build fix following r237677
philn@webkit.org [Fri, 2 Nov 2018 17:45:37 +0000 (17:45 +0000)]
[GTK][WPE] Unreviewed, another --no-video --no-web-audio build fix following r237677

* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::addEventListenersToNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through
philn@webkit.org [Fri, 2 Nov 2018 17:42:46 +0000 (17:42 +0000)]
[GTK][WPE] Enable GST_DEBUG_NO_COLOR environment variable pass-through

Rubber-stamped by Michael Catanzaro.

This variable is useful to get rid of shell color escapes in tests stderr files.

* Scripts/webkitpy/port/gtk.py:
(GtkPort.setup_environ_for_server):
* Scripts/webkitpy/port/wpe.py:
(WPEPort.setup_environ_for_server):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAdd Basic Django web app for OpenSource EWS
aakash_jain@apple.com [Fri, 2 Nov 2018 17:35:41 +0000 (17:35 +0000)]
Add Basic Django web app for OpenSource EWS
https://bugs.webkit.org/show_bug.cgi?id=191091

Reviewed by Lucas Forschler.

* BuildSlaveSupport/EWS_app/manage.py: Added, auto-generated by Django.
* BuildSlaveSupport/EWS_app/EWS_app/__init__.py: Added, auto-generated by Django.
* BuildSlaveSupport/EWS_app/EWS_app/settings.py: Added, auto-generated by Django.
* BuildSlaveSupport/EWS_app/EWS_app/urls.py: Added, auto-generated by Django.
* BuildSlaveSupport/EWS_app/EWS_app/wsgi.py: Added, auto-generated by Django.
* BuildSlaveSupport/EWS_app/ews/__init__.py: Added.
* BuildSlaveSupport/EWS_app/ews/admin.py: Added, auto-generated by Django.
* BuildSlaveSupport/EWS_app/ews/apps.py: Added, auto-generated by Django.
* BuildSlaveSupport/EWS_app/ews/migrations/__init__.py: Added.
* BuildSlaveSupport/EWS_app/ews/tests.py: Added, auto-generated by Django.
* BuildSlaveSupport/EWS_app/ews/models/__init__.py: Added.
* BuildSlaveSupport/EWS_app/ews/models/patch.py: Added.
* BuildSlaveSupport/EWS_app/ews/views/__init__.py: Added.
* BuildSlaveSupport/EWS_app/ews/views/patch.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[iOS] Normalize character string based on key code
dbates@webkit.org [Fri, 2 Nov 2018 17:20:28 +0000 (17:20 +0000)]
[iOS] Normalize character string based on key code
https://bugs.webkit.org/show_bug.cgi?id=191120

Reviewed by Tim Horton.

Source/WebCore:

Following r236417 (https://bugs.webkit.org/show_bug.cgi?id=189604) we always have a valid key code
for a special key (e.g. page up) and can simplify the character string normalization code.

No functionality changed. So, no new tests.

* platform/ios/WebEvent.mm:
(normalizedStringWithAppKitCompatibilityMapping): Modified to take a key code and wrote algorithm
in terms of it.

(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
Pass the key code for the event to normalizedStringWithAppKitCompatibilityMapping().

Source/WebCore/PAL:

Remove forward declarations that are no longer needed now that we check key code.

* pal/spi/ios/UIKitSPI.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[iOS] WebKit should dispatch DOM events when a modifier key is pressed
dbates@webkit.org [Fri, 2 Nov 2018 17:17:09 +0000 (17:17 +0000)]
[iOS] WebKit should dispatch DOM events when a modifier key is pressed
https://bugs.webkit.org/show_bug.cgi?id=190487

Reviewed by Tim Horton.

Source/WebCore:

Add support for modifier flags change events.

* platform/ios/PlatformEventFactoryIOS.mm:
(WebCore::modifiersForEvent): Modifier keys do not have an associated character and do not
participate in key repeat.
(WebCore::keyIdentifierForKeyEvent): Identify modifier keys, returning "Unidentified" if
the modifier key is unidentified. This matches the behavior on Mac.
(WebCore::keyForKeyEvent): Identify modifier keys, returning the empty string if the modifier
key is unidentified. This matches the behavior on Mac.
(WebCore::PlatformKeyboardEventBuilder::PlatformKeyboardEventBuilder):
* platform/ios/WebEvent.h:

* platform/ios/WebEvent.mm:
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:keyCode:isTabKey:characterSet:]):
(-[WebEvent initWithKeyEventType:timeStamp:characters:charactersIgnoringModifiers:modifiers:isRepeating:withFlags:withInputManagerHint:keyCode:isTabKey:]):
Modifier keys do not have an associated character and do not participate in key repeat.

(-[WebEvent _eventDescription]): Modified to print a description for a keydown or keyup event
that represents a modifier flags change.
(-[WebEvent characters]): Modifier keys do not have an associated character. Assert this
invariant as it is a programming error. On Mac, the same operation would result in a
NSInternalInconsistencyException exception being raised.
(-[WebEvent charactersIgnoringModifiers]): Ditto.

Source/WebKit:

Add support for modifier flags change events dispatched by UIKit.

* Shared/ios/WebIOSEventFactory.mm:
(modifiersForEvent): Update for renamed enumerations.
(WebIOSEventFactory::createWebKeyboardEvent): Modifier keys do not have an associated
character and do not participate in key repeat.
* UIProcess/Automation/ios/WebAutomationSessionIOS.mm:
(WebKit::WebAutomationSession::platformSimulateKeyboardInteraction): Update for renamed enumerations.
* UIProcess/ios/WKContentViewInteraction.mm:
(-[WKContentView _interpretKeyEvent:isCharEvent:]): Return NO if the event represents a
modifier flags change to allow the default handling.
* UIProcess/ios/WKKeyboardScrollingAnimator.mm:
(-[WKKeyboardScrollingAnimator keyboardScrollForEvent:]): Update for renamed enumerations.

Source/WebKitLegacy/mac:

Having Legacy WebKit return NO if the editing event represents a modifier flags change to
allow the default handling.

* WebView/WebHTMLView.mm:
(-[WebHTMLView _handleEditingKeyEvent:]):

Tools:

Update the code for renamed enumerations. For WebKitTestRunner, removed comment that does not
match my observations when using the simulator to simulate iOS 12 and add support for testing
right-hand side modifiers.

* DumpRenderTree/mac/EventSendingController.mm:
(modifierFlags):
(-[EventSendingController keyDown:withModifiers:withLocation:]):
(-[EventSendingController setTouchModifier:value:]):
* WebKitTestRunner/ios/HIDEventGenerator.mm:
(hidUsageCodeForCharacter):

LayoutTests:

Update expected results of an existing test now that we identify modifier keys.

* fast/events/ios/keydown-keyup-special-keys-in-non-editable-element-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAllow cross-document intersection observing
ajuma@chromium.org [Fri, 2 Nov 2018 16:55:13 +0000 (16:55 +0000)]
Allow cross-document intersection observing
https://bugs.webkit.org/show_bug.cgi?id=165746

Reviewed by Simon Fraser.

LayoutTests/imported/w3c:

Update expectations for tests that now pass.

* web-platform-tests/intersection-observer/client-rect-expected.txt:
* web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt:
* web-platform-tests/intersection-observer/iframe-no-root-expected.txt:
* web-platform-tests/intersection-observer/timestamp-expected.txt:

Source/WebCore:

Add logic to compute the intersection between the viewport and an element in a
subframe.

Add a FloatRect version of ScrollView::rootViewToContents, and FloatRect versions
of the methods it calls.

Test: http/tests/intersection-observer/intermediate-frame-changes.html
Also covered by rebased tests in imported/w3c/web-platform-tests/intersection-observer.

* dom/Document.cpp:
(WebCore::computeClippedRectInRootContentsSpace):
(WebCore::computeIntersectionState):
(WebCore::Document::updateIntersectionObservations):
* page/FrameView.cpp:
(WebCore::FrameView::viewportContentsChanged):
(WebCore::FrameView::convertFromContainingViewToRenderer const):
(WebCore::FrameView::convertFromContainingView const):
* page/FrameView.h:
* platform/ScrollView.cpp:
(WebCore::ScrollView::viewToContents const):
(WebCore::ScrollView::contentsToView const):
(WebCore::ScrollView::rootViewToContents const):
* platform/ScrollView.h:
* platform/Widget.cpp:
(WebCore::Widget::convertFromRootView const):
(WebCore::Widget::convertFromContainingView const):
* platform/Widget.h:

LayoutTests:

Add a test that cross-document intersection observations are triggered when an intermediate frame
scrolls. Skip the test on WK1 platforms where IntersectionObserver is not supported.

Add platform-specific baselines for tests involving iframe scrolling, which isn't supported on iOS.

* http/tests/intersection-observer/intermediate-frame-changes-expected.txt: Added.
* http/tests/intersection-observer/intermediate-frame-changes.html: Added.
* http/tests/intersection-observer/resources/intermediate-frame.html: Added.
* http/tests/intersection-observer/resources/nested-frame.html: Added.
* platform/ios/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/intersection-observer/cross-origin-iframe-expected.txt.
* platform/ios/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root-expected.txt: Copied from LayoutTests/imported/w3c/web-platform-tests/intersection-observer/iframe-no-root-expected.txt.
* platform/mac-wk1/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[PSON] Reuse SuspendedPages' process when possible, for performance
cdumez@apple.com [Fri, 2 Nov 2018 15:59:23 +0000 (15:59 +0000)]
[PSON] Reuse SuspendedPages' process when possible, for performance
https://bugs.webkit.org/show_bug.cgi?id=191166

Reviewed by Geoffrey Garen.

Source/WebKit:

When process-swapping check if there is an existing SuspendedPage for the domain we're going to.
If there is, use this SuspendedPage's process for the navigation instead of a fresh new process.
This change should be beneficial for performance as it:
- Avoids spinning up a new process (CPU & memory cost)
- Likely better leverages caches since this process already loaded this domain in the past

Due to current limitations, using a SuspendedPage's proxy may consume the SuspendedPage, which
means that it can no longer be used for PageCache on history navigations. We need to do this when
the SuspendedPageProxy in question was created for the current WebPageProxy because:
- This SuspendedPageProxy's process already has a suspended WebPage with this WebPageProxy's pageID
and
- We do not currently support having more than one WebPage with a given pageID within a single
  WebProcess.

* UIProcess/SuspendedPageProxy.cpp:
(WebKit::SuspendedPageProxy::SuspendedPageProxy):
* UIProcess/SuspendedPageProxy.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigationInternal):

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoMetadata should not be copyable
tzagallo@apple.com [Fri, 2 Nov 2018 15:46:57 +0000 (15:46 +0000)]
Metadata should not be copyable
https://bugs.webkit.org/show_bug.cgi?id=191193

Reviewed by Keith Miller.

We should only ever hold references to the entry in the metadata table.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::finalizeLLIntInlineCaches):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::parseBlock):
* generator/Metadata.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Win] Layout Test fast/block/basic/inline-content-with-floating-image.html is failing
pvollan@apple.com [Fri, 2 Nov 2018 15:41:19 +0000 (15:41 +0000)]
[Win] Layout Test fast/block/basic/inline-content-with-floating-image.html is failing
https://bugs.webkit.org/show_bug.cgi?id=191194

Unreviewed test gardening.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRemove ENABLE_OPENCL fully
commit-queue@webkit.org [Fri, 2 Nov 2018 15:39:52 +0000 (15:39 +0000)]
Remove ENABLE_OPENCL fully
https://bugs.webkit.org/show_bug.cgi?id=191172

Patch by Rob Buis <rbuis@igalia.com> on 2018-11-02
Reviewed by Yusuke Suzuki.

No new tests since no change in functionality.

* platform/graphics/filters/FilterEffect.h:
(WebCore::FilterEffect::hasResult const):
(WebCore::FilterEffect::applyAll):
(WebCore::FilterEffect::openCLImage): Deleted.
(WebCore::FilterEffect::setOpenCLImage): Deleted.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[LFC][IFC] Add support for intrinsic width calculation
zalan@apple.com [Fri, 2 Nov 2018 14:23:54 +0000 (14:23 +0000)]
[LFC][IFC] Add support for intrinsic width calculation
https://bugs.webkit.org/show_bug.cgi?id=191144

Reviewed by Antti Koivisto.

Source/WebCore:

This is the inline formatting version of the shrink-to-fit computation. It generates inline runs
and uses InlineLineBreaker to compute min/max width. This is very similar to ::layout.

Test: fast/inline/simple-shrink-to-fit-inline-block.html

* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layout const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::InlineFormattingContext::computeHeightAndMargin const):
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForReplacedInlineBox const):
(WebCore::Layout::InlineFormattingContext::collectInlineContent const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
(WebCore::Layout::InlineFormattingContext::computeWidthAndHeightForInlineBox const): Deleted.
* layout/inlineformatting/InlineFormattingContext.h:

Tools:

* LayoutReloaded/misc/LFC-passing-tests.txt:

LayoutTests:

* fast/inline/simple-shrink-to-fit-inline-block-expected.txt: Added.
* fast/inline/simple-shrink-to-fit-inline-block.html: Added.
* platform/ios/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[LFC][BFC] BlockFormattingContext::instrinsicWidthConstraints logic should look simil...
zalan@apple.com [Fri, 2 Nov 2018 14:21:56 +0000 (14:21 +0000)]
[LFC][BFC] BlockFormattingContext::instrinsicWidthConstraints logic should look similar to ::layout
https://bugs.webkit.org/show_bug.cgi?id=191181

Reviewed by Antti Koivisto.

* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[LFC] Align shrink-to-fit width computation with the layout implementation.
zalan@apple.com [Fri, 2 Nov 2018 13:41:05 +0000 (13:41 +0000)]
[LFC] Align shrink-to-fit width computation with the layout implementation.
https://bugs.webkit.org/show_bug.cgi?id=191179

Reviewed by Antti Koivisto.

There are many similarities between layout and shrink-to-fit.
They both operate on formatting roots only (shrink-to-fit -> float, out-of-flow, inline-block) and in both cases
the algoritm depends on what type of formatting context the element establishes.

This patch is in preparation for transforming the "shrink-to-fit" width computation to make it behave more like layout.
With this change the instrinsicWidthConstraints() computation happens in the formatting context that the element establishes (similar to layout).

* layout/FormattingContext.cpp:
(WebCore::Layout::FormattingContext::computeOutOfFlowHorizontalGeometry const):
* layout/FormattingContext.h:
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
* layout/FormattingContextGeometry.cpp:
(WebCore::Layout::FormattingContext::Geometry::shrinkToFitWidth):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowNonReplacedHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingNonReplacedWidthAndMargin):
(WebCore::Layout::FormattingContext::Geometry::outOfFlowHorizontalGeometry):
(WebCore::Layout::FormattingContext::Geometry::floatingWidthAndMargin):
* layout/blockformatting/BlockFormattingContext.cpp:
(WebCore::Layout::BlockFormattingContext::computeWidthAndMargin const):
(WebCore::Layout::BlockFormattingContext::instrinsicWidthConstraints const):
* layout/blockformatting/BlockFormattingContext.h:
* layout/inlineformatting/InlineFormattingContext.cpp:
(WebCore::Layout::InlineFormattingContext::layoutFormattingContextRoot const):
(WebCore::Layout::InlineFormattingContext::instrinsicWidthConstraints const):
* layout/inlineformatting/InlineFormattingContext.h:
* layout/inlineformatting/InlineFormattingContextGeometry.cpp:
(WebCore::Layout::InlineFormattingContext::Geometry::inlineBlockWidthAndMargin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoREGRESSION(r237547): Exception handlers should be aware of wide opcodes when JIT...
tzagallo@apple.com [Fri, 2 Nov 2018 10:46:34 +0000 (10:46 +0000)]
REGRESSION(r237547): Exception handlers should be aware of wide opcodes when JIT is disabled
https://bugs.webkit.org/show_bug.cgi?id=191175

Reviewed by Keith Miller.

https://bugs.webkit.org/show_bug.cgi?id=191108 did not handle the case where JIT is not enabled

* jit/JITExceptions.cpp:
(JSC::genericUnwind):
* llint/LLIntData.h:
(JSC::LLInt::getWideCodePtr):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Apache] Self-signed SSL certificate RSA key is considered too weak
philn@webkit.org [Fri, 2 Nov 2018 10:04:22 +0000 (10:04 +0000)]
[Apache] Self-signed SSL certificate RSA key is considered too weak
https://bugs.webkit.org/show_bug.cgi?id=191156

Reviewed by Michael Catanzaro.

Tools:

* Scripts/webkitpy/common/system/pemfile.py:

LayoutTests:

Regenerate the self-signed SSL certificate with a 2048 bits RSA key.

* http/conf/webkit-httpd.pem:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[Web Animations] Make document.getAnimations() return declarative animations in the...
graouts@webkit.org [Fri, 2 Nov 2018 07:54:19 +0000 (07:54 +0000)]
[Web Animations] Make document.getAnimations() return declarative animations in the correct order
https://bugs.webkit.org/show_bug.cgi?id=191153

Reviewed by Dean Jackson.

LayoutTests/imported/mozilla:

Mark progressions for the document.getAnimations() tests covering CSS Animations and CSS Transitions.
These tests are now in WPT and will be updated as part of a general WPT update for all of Web Animations
shortly. We will upstream the minor changes made at that point. Those changes were necessary because we
don't support the PseudoElement interface and instead we check which animation names and CSS properties
are applied to pseudo-elements rather than the pseudo-element's type.

* css-animations/test_document-get-animations-expected.txt:
* css-animations/test_document-get-animations.html:
* css-animations/test_event-dispatch.html: Remove a comment that was added by mistake in a previous patch.
* css-transitions/test_document-get-animations-expected.txt:
* css-transitions/test_document-get-animations.html:

Source/WebCore:

The Web Animations spec has the notion of "composite order" which determines the order in which animations should
be returned when document.getAnimations() is called. The CSS Transitions and CSS Animations specifications also
determine the composite order of their respective animation classes, as well as the notion of "owning element",
the element that was the animation target when specified through style, prior to any manipulation via the Web
Animations API. We implement these two notions so that we can pass the document.getAnimations() tests for
declarative animations.

It is important that we have the notion of an "owning element" since when a CSS Transition or CSS Animation is
modified via the Web Animations API in a way that an animation created through CSS we must consider no longer
as a declarative animation but as a regular Web Animation. In this patch, we remove the DeclarativeAnimation's
target(), which returned a reference, to owningElement(), which returns a pointer and return nullptr once the
declarative animation has been modified.

In order to also keep a correct count of declarative animations applied to elements, we correctly add transitions
that have completed to a list of completed transitions, as specified by the CSS Transitions spec. We have had this
list declared in AnimationTimeline.h for a while but never actually did the work to add items to it. Thanks to that,
AnimationTimeline::updateCSSTransitionsForElement() now correctly accounts for completed transitions so that they
may be canceled if overridden with a new animation, correctly removing their "owning element".

Finally, now that we have saner lists of animations per classes, we can apply the right sorting routines to match
the composite order for CSS Transitions, CSS Animations and Web Animations, keeping a list of all animations created
in order as the final criterion for sorting.

* animation/AnimationTimeline.cpp:
(WebCore::AnimationTimeline::animationTimingDidChange): Make sure this animation is tracked on the list of all animations
created for this timeline in the order in which they were created, which is needed to sort animations correctly when
document.getAnimations() is called.
(WebCore::AnimationTimeline::animationWasAddedToElement): We've removed the relevantMapForAnimation() method which we used
to determine which map we should add an animation to based on its class and instead have code that accounts for not just
the animation's class, but also whether it has an owning element since a valid owning element is required to qualify as
a CSS Transition or CSS Animation, regardless of the animation's original class.
(WebCore::removeAnimationFromMapForElement): Adding this helper to remove an animation from the provided animation map so
that animationWasRemovedFromElement() can call this with all of the various animation maps.
(WebCore::AnimationTimeline::animationWasRemovedFromElement): Check all of the various animation maps to see which may
contain the animation we're trying to remove as the owning element might have been cleared by the time this function is
called and looking at the animation's class would not be sufficient to determine which animation map the animation was in.
(WebCore::AnimationTimeline::removeDeclarativeAnimationFromListsForOwningElement): New function in which the logic from
animationWasRemovedFromElement() that dealt with removing animations from the list of running CSS Animations/Transitions as
well as completed CSS Transitions was factored out. This allowed us to also call this function from
DeclarativeAnimation::disassociateFromOwningElement().
(WebCore::AnimationTimeline::elementWasRemoved): We no longer need to remove an animation as canceling it will remove it
correctly when DocumentTimeline::updateAnimationsAndSendEvents() is called.
(WebCore::AnimationTimeline::updateCSSAnimationsForElement): Call cancelDeclarativeAnimation() instead of the removed
cancelOrRemoveDeclarativeAnimation() when a CSS Animation should be canceled.
(WebCore::AnimationTimeline::ensureRunningTransitionsByProperty): Now that we correctly remove transitions from the list
of running transitions once they've completed or have been canceled, we need a helper to always get a valid map of running
transitions for a given element as that map can be cleared while updateCSSTransitionsForElement() is running.
(WebCore::AnimationTimeline::updateCSSTransitionsForElement): Call cancelDeclarativeAnimation() instead of the removed
cancelOrRemoveDeclarativeAnimation() when a CSS Transition should be canceled. Additionally we always get the list of running
transitions for a given element as it can be cleared by a prior cancelation.
(WebCore::AnimationTimeline::cancelDeclarativeAnimation): New function replacing cancelOrRemoveDeclarativeAnimation() in which
we call the new DeclarativeAnimation::cancelFromStyle() function on the provided animation and then remove the animation from
all known lists, including the new list of all animations. We do this final part so that the animation gets re-added as if it
were a new animation since canceling a declarative animation via a style change removes its declarative-ness. This guarantees
that a declarative animation that is canceled through style but then resumed through the Web Animations API sorts after any
declarative animation with an owning element.
(WebCore::AnimationTimeline::relevantMapForAnimation): Deleted.
(WebCore::AnimationTimeline::cancelOrRemoveDeclarativeAnimation): Deleted.
* animation/AnimationTimeline.h:
(WebCore::AnimationTimeline::timingModelDidChange): Deleted. This was left over in the patch where we implemented the "update
animations and send events" procedure.
(WebCore::AnimationTimeline::animations const): Deleted.
* animation/CSSAnimation.cpp:
(WebCore::CSSAnimation::create): Some refactoring to make the handling of a declarative animation's owning element part of the
DeclarativeAnimation constructor.
* animation/CSSTransition.cpp:
(WebCore::CSSTransition::create): Some refactoring to make the handling of a declarative animation's owning element part of the
DeclarativeAnimation constructor.
* animation/DeclarativeAnimation.cpp:
(WebCore::DeclarativeAnimation::DeclarativeAnimation):
(WebCore::DeclarativeAnimation::tick): Make sure we disassociate from the animation's owning element once we transition from a
relevant state to an idle state. This will catch any changes made via the Web Animations API to a declarative animation when the
"update animations and send events" procedure is run.
(WebCore::DeclarativeAnimation::disassociateFromOwningElement): Remove this animation from the list of declarative animations on
the associated timeline and make owningElement() nullptr so that document.getAnimations() will know to sort this animation with other
Web Animations created via the Web Animations API.
(WebCore::DeclarativeAnimation::initialize):
(WebCore::DeclarativeAnimation::cancelFromStyle): New method called from AnimationTimeline::cancelDeclarativeAnimation() which
cancels the animation but also disassociates it from its owning element.
(WebCore::DeclarativeAnimation::invalidateDOMEvents):
(WebCore::DeclarativeAnimation::enqueueDOMEvent):
* animation/DeclarativeAnimation.h:
(WebCore::DeclarativeAnimation::owningElement const):
(WebCore::DeclarativeAnimation::target const): Deleted.
* animation/DocumentTimeline.cpp:
(WebCore::compareDeclarativeAnimationOwningElementPositionsInDocumentTreeOrder): Adding a new utility used when sorting both
CSS Transitions and CSS Animations by tree order when their owning element differ, with special logic for pseudo-elements.
(WebCore::DocumentTimeline::getAnimations const): Filter and sort animations according to their composite order.
(WebCore::DocumentTimeline::updateAnimationsAndSendEvents): Compile a list of transitions that move to a finished state to
the list of completed transitions so that they may be canceled correctly in AnimationTimeline::updateCSSTransitionsForElement().
(WebCore::DocumentTimeline::transitionDidComplete):
* animation/DocumentTimeline.h:

LayoutTests:

Mark that the two document.getAnimations() tests for declarative animations are no longer flaky.

* TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoPNGImageDecoder: report no repetition for non-animated images
zandobersek@gmail.com [Fri, 2 Nov 2018 07:15:13 +0000 (07:15 +0000)]
PNGImageDecoder: report no repetition for non-animated images
https://bugs.webkit.org/show_bug.cgi?id=191068

Reviewed by Michael Catanzaro.

When building with APNG support enabled, the
PNGImageDecoder::repetitionCount() method until now reported  infinite
repetition count for all PNG images, even the ones that were not
animated. This is now changed so that no repetition is reported for
non-animated images.

* platform/image-decoders/png/PNGImageDecoder.cpp:
(WebCore::PNGImageDecoder::repetitionCount const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WPE] WebDriver: support validating and parsing the 'certificates' capability
zandobersek@gmail.com [Fri, 2 Nov 2018 07:11:27 +0000 (07:11 +0000)]
[WPE] WebDriver: support validating and parsing the 'certificates' capability
https://bugs.webkit.org/show_bug.cgi?id=191014

Reviewed by Michael Catanzaro.

Adopt the same approach as in the GTK's WebDriverService implementation
for validating and parsing the 'certificates' WebDriver capability.

* wpe/WebDriverServiceWPE.cpp:
(WebDriver::WebDriverService::platformValidateCapability const):
(WebDriver::WebDriverService::platformParseCapabilities const):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WebGPU] Experimental prototype for MSL shaders
justin_fan@apple.com [Fri, 2 Nov 2018 07:09:09 +0000 (07:09 +0000)]
[WebGPU] Experimental prototype for MSL shaders
https://bugs.webkit.org/show_bug.cgi?id=191084

Reviewed by Dean Jackson.

Source/WebCore:

Begin implementation for WebGPUDevice and WebGPUShaderModule and associated descriptor objects.

Test: webgpu/webgpu-basics.html
Test: webgpu/shader-modules.html

* CMakeLists.txt:
* DerivedSources.make:
* Modules/webgpu/GPUDevice.cpp:
(WebCore::GPUDevice::createShaderModule const):
* Modules/webgpu/GPUDevice.h:
(WebCore::GPUDevice::platformDevice const):
* Modules/webgpu/GPUShaderModule.h:
(WebCore::GPUShaderModule::platformShaderModule const):
* Modules/webgpu/GPUShaderModuleDescriptor.h:
* Modules/webgpu/WebGPU.cpp:
(WebCore::WebGPU::requestAdapter const):
* Modules/webgpu/WebGPUAdapter.cpp:
(WebCore::WebGPUAdapter::create):
(WebCore::WebGPUAdapter::createDevice):
* Modules/webgpu/WebGPUAdapter.h:
* Modules/webgpu/WebGPUAdapter.idl:
* Modules/webgpu/WebGPUDevice.cpp:
(WebCore::WebGPUDevice::create):
(WebCore::WebGPUDevice::WebGPUDevice):
(WebCore::WebGPUDevice::createShaderModule const):
* Modules/webgpu/WebGPUDevice.h:
* Modules/webgpu/WebGPUDevice.idl:
* Modules/webgpu/WebGPUShaderModule.cpp:
(WebCore::WebGPUShaderModule::create):
(WebCore::WebGPUShaderModule::WebGPUShaderModule):
* Modules/webgpu/WebGPUShaderModule.h:
* Modules/webgpu/WebGPUShaderModule.idl:
* Modules/webgpu/WebGPUShaderModuleDescriptor.h:
* Modules/webgpu/WebGPUShaderModuleDescriptor.idl:
* Modules/webgpu/WebGPUSwapChain.cpp:
(WebCore::WebGPUSwapChain::configure):
* Modules/webgpu/WebGPUSwapChain.h:
* Modules/webgpu/WebGPUSwapChain.idl:
* Modules/webgpu/cocoa/GPUDeviceMetal.mm:
(WebCore::GPUDevice::create):
(WebCore::GPUDevice::GPUDevice):
* Modules/webgpu/cocoa/GPUShaderModuleMetal.mm:
(WebCore::GPUShaderModule::create):
(WebCore::GPUShaderModule::GPUShaderModule):
* Sources.txt:
* SourcesCocoa.txt:
* WebCore.xcodeproj/project.pbxproj:
* bindings/js/WebCoreBuiltinNames.h:
* platform/Logging.h:

Source/WTF:

Disabling WebGPU on non-Cocoa platforms and iOS Simulator.

* wtf/Platform.h:

LayoutTests:

* webgpu/shader-modules.html: Added.
* webgpu/shader-modules-expected.html: Added.
* webgpu/webgpu-basics.html: Added.
* webgpu/webgpu-basics-expected.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed follow-up to r237678.
zandobersek@gmail.com [Fri, 2 Nov 2018 07:04:30 +0000 (07:04 +0000)]
Unreviewed follow-up to r237678.

* wpe/jhbuild.modules: The patch element apparently has to be a child
of the branch in order for Jhbuild to properly detect and apply the
patch file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoReplace CommonRandom SPI with API
jiewen_tan@apple.com [Fri, 2 Nov 2018 06:35:59 +0000 (06:35 +0000)]
Replace CommonRandom SPI with API
https://bugs.webkit.org/show_bug.cgi?id=191178
<rdar://problem/45722391>

Reviewed by Brent Fulgham.

Source/bmalloc:

* bmalloc/CryptoRandom.cpp:
(bmalloc::ARC4RandomNumberGenerator::stir):

Source/WebCore:

The API is available since macOS 10.10 and iOS 10, and therefore it is safe to replace
all SPI usages with API.

No change of behaviors.

* crypto/CommonCryptoUtilities.h:
* crypto/mac/CryptoKeyMac.cpp:
(WebCore::CryptoKey::randomData):
* crypto/mac/SerializedCryptoKeyWrapMac.mm:
(WebCore::createAndStoreMasterKey):
(WebCore::wrapSerializedCryptoKey):
* page/Crypto.cpp:
(WebCore::Crypto::getRandomValues):

Source/WTF:

* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/RandomDevice.cpp:
(WTF::RandomDevice::cryptographicallyRandomValues):
* wtf/spi/darwin/CommonCryptoSPI.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoWeb Inspector: View: introduce a didLayoutSubtree
drousso@apple.com [Fri, 2 Nov 2018 04:11:57 +0000 (04:11 +0000)]
Web Inspector: View: introduce a didLayoutSubtree
https://bugs.webkit.org/show_bug.cgi?id=191176

Reviewed by Matt Baker.

Source/WebInspectorUI:

Introduce logic to allow subclasses of `WI.View` to perform logic after every `WI.View` in
their subtree has finished `layout`.

* UserInterface/Views/View.js:
(WI.View.prototype.didLayoutSubtree): Added.
(WI.View.prototype._layoutSubtree):

* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype.didLayoutSubtree): Added.

LayoutTests:

* inspector/view/resources/test-view.js:
(TestPage.registerInitializer.WI.TestView.prototype.layout):
(TestPage.registerInitializer.WI.TestView.prototype.didLayoutSubtree): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WebIDL] Rename CallWith=ScriptState to CallWith=ExecState
cdumez@apple.com [Fri, 2 Nov 2018 03:35:57 +0000 (03:35 +0000)]
[WebIDL] Rename CallWith=ScriptState to CallWith=ExecState
https://bugs.webkit.org/show_bug.cgi?id=191162

Reviewed by Alex Christensen.

Rename CallWith=ScriptState to CallWith=ExecState in our Web IDL as ScriptState is no longer a thing
in modern WebKit. The implementation is actually passed an ExecState nowadays.

* Modules/applepay/ApplePaySession.idl:
* Modules/encryptedmedia/MediaKeyStatusMap.idl:
* Modules/fetch/FetchBody.idl:
* Modules/indexeddb/IDBCursor.idl:
* Modules/indexeddb/IDBFactory.idl:
* Modules/indexeddb/IDBIndex.idl:
* Modules/indexeddb/IDBKeyRange.idl:
* Modules/indexeddb/IDBObjectStore.idl:
* Modules/mediastream/RTCPeerConnection.idl:
* animation/Animatable.idl:
* animation/KeyframeEffect.idl:
* animation/KeyframeEffectReadOnly.idl:
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateCallWith):
(GenerateConstructorDefinition):
* bindings/scripts/IDLAttributes.json:
* bindings/scripts/test/JS/JSTestObj.cpp:
(WebCore::jsTestObjWithExecStateAttributeGetter):
(WebCore::jsTestObjWithExecStateAttribute):
(WebCore::setJSTestObjWithExecStateAttributeSetter):
(WebCore::setJSTestObjWithExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateAttribute):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeGetter):
(WebCore::jsTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttributeSetter):
(WebCore::setJSTestObjWithScriptExecutionContextAndExecStateWithSpacesAttribute):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoid):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObj):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateVoidException):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecState):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjExceptionBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateObjException):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpacesBody):
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndExecStateWithSpaces):
(WebCore::jsTestObjWithScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateAttribute): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeGetter): Deleted.
(WebCore::jsTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttributeSetter): Deleted.
(WebCore::setJSTestObjWithScriptExecutionContextAndScriptStateWithSpacesAttribute): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoid): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObj): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateVoidException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptState): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjExceptionBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateObjException): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpacesBody): Deleted.
(WebCore::jsTestObjPrototypeFunctionWithScriptExecutionContextAndScriptStateWithSpaces): Deleted.
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestPromiseRejectionEvent.idl:
* crypto/SubtleCrypto.idl:
* dom/Element.idl:
* dom/ErrorEvent.idl:
* dom/MessagePort.idl:
* dom/MouseEvent.idl:
* html/HTMLCanvasElement.idl:
* html/HTMLFrameElement.idl:
* html/OffscreenCanvas.idl:
* html/track/DataCue.idl:
* inspector/CommandLineAPIHost.idl:
* page/DOMWindow.idl:
* page/RemoteDOMWindow.idl:
* page/WindowOrWorkerGlobalScope.idl:
* testing/Internals.idl:
* workers/DedicatedWorkerGlobalScope.idl:
* workers/Worker.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agobuild-jsc --wincairo should update WinCairo libraries
ross.kirsling@sony.com [Fri, 2 Nov 2018 02:04:26 +0000 (02:04 +0000)]
build-jsc --wincairo should update WinCairo libraries
https://bugs.webkit.org/show_bug.cgi?id=191170

Reviewed by Fujii Hironori.

* Scripts/build-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoRename <wtf/unicode/UTF8.h> to <wtf/unicode/UTF8Conversion.h> in order to avoid confl...
Hironori.Fujii@sony.com [Fri, 2 Nov 2018 01:13:19 +0000 (01:13 +0000)]
Rename <wtf/unicode/UTF8.h> to <wtf/unicode/UTF8Conversion.h> in order to avoid conflicting with ICU's unicode/utf8.h
https://bugs.webkit.org/show_bug.cgi?id=189693

Reviewed by Yusuke Suzuki.

Source/JavaScriptCore:

* API/JSClassRef.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
* API/JSStringRef.cpp: Ditto.
* runtime/JSGlobalObjectFunctions.cpp: Ditto.
* wasm/WasmParser.h: Ditto.

Source/WebCore:

No new tests because there's no behaviro changes.

* platform/SharedBuffer.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
* xml/XSLTProcessorLibxslt.cpp: Ditto.
* xml/parser/XMLDocumentParserLibxml2.cpp: Ditto.

Source/WebKit:

* Shared/API/APIString.h: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.

Source/WTF:

* WTF.xcodeproj/project.pbxproj: Replaced unicode/UTF8.{cpp,h} with unicode/UTF8Conversion.{cpp,h}.
* wtf/CMakeLists.txt: Ditto.
* wtf/text/AtomicStringImpl.cpp: Replaced <wtf/unicode/UTF8.h> with <wtf/unicode/UTF8Conversion.h>.
* wtf/text/StringImpl.cpp: Ditto.
* wtf/text/StringView.cpp: Ditto.
* wtf/text/WTFString.cpp: Ditto.
* wtf/unicode/UTF8Conversion.cpp: Renamed from Source/WTF/wtf/unicode/UTF8.cpp.
* wtf/unicode/UTF8Conversion.h: Renamed from Source/WTF/wtf/unicode/UTF8.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoIn WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possibl...
wilander@apple.com [Fri, 2 Nov 2018 00:51:12 +0000 (00:51 +0000)]
In WebCore::ResourceLoadObserver, use document.sessionID().isEphemeral() when possible and check for page existence when not
https://bugs.webkit.org/show_bug.cgi?id=191119
<rdar://problem/44176965>

Reviewed by Chris Dumez.

Source/WebCore:

New API test added.

* loader/ResourceLoadObserver.cpp:
(WebCore::ResourceLoadObserver::logSubresourceLoading):
(WebCore::ResourceLoadObserver::logUserInteractionWithReducedTimeResolution):

Tools:

This is an API test for a WebKitLegacy WebView that is first closed and then
JavaScript is handed a keyboard event.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKitLegacy/mac/ClosingWebView.mm: Added.
(-[ClosingWebViewThenSendingItAKeyDownEventLoadDelegate webView:didFinishLoadForFrame:]):
(-[KeyboardEventListener handleEvent:]):
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoWeb Inspector: Network: remove unnecessary media event tracking
drousso@apple.com [Fri, 2 Nov 2018 00:27:19 +0000 (00:27 +0000)]
Web Inspector: Network: remove unnecessary media event tracking
https://bugs.webkit.org/show_bug.cgi?id=191174

Reviewed by Joseph Pecoraro.

Source/WebCore:

No new tests, as this simply removes some event listeners for the WebInspector frontend.

* inspector/agents/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::addEventListenersToNode):

Source/WebInspectorUI:

Renames "Group by Node" to "Group Media Requests" for clarity.

* UserInterface/Views/NetworkTableContentView.js:
(WI.NetworkTableContentView):
(WI.NetworkTableContentView.prototype.reset):
(WI.NetworkTableContentView.prototype.showRepresentedObject):
(WI.NetworkTableContentView.prototype.networkDetailViewClose):
(WI.NetworkTableContentView.prototype._populateNameCell):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph.createDOMEventLine):
(WI.NetworkTableContentView.prototype._populateWaterfallGraph):
(WI.NetworkTableContentView.prototype.layout):
(WI.NetworkTableContentView.prototype._entryForDOMNode):
(WI.NetworkTableContentView.prototype._handleGroupByDOMNodeCheckedDidChange):
(WI.NetworkTableContentView.prototype._restoreSelectedRow):
(WI.NetworkTableContentView.prototype._handleResourceEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleNodeEntryMousedownWaterfall):
(WI.NetworkTableContentView.prototype._handleMousedownWaterfall):
* UserInterface/Views/NetworkTableContentView.css:
(.network-table .data-container .cell.name .range): Added.
(.network-table .data-container .cell.name .range::before): Added.
(.network-table:focus .data-container li.selected .cell.name .range): Added.
(@media (prefers-dark-interface) .network-table .data-container .cell.name .range): Added.
Always display the "Byte Range" title as a "subtitle", regardless of the media requests
setting being toggled.
Drive-by: update the position of the waterfall popover whenever the time range changes.
Drive-by: close the details view if a node is selected and the media requests setting is
turned off.

* UserInterface/Views/Popover.js:
(WI.Popover.prototype.resize): Added.
(WI.Popover.prototype.handleEvent):

* Localizations/en.lproj/localizedStrings.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, JavaScriptCore should only guarantee to produce a
keith_miller@apple.com [Fri, 2 Nov 2018 00:02:40 +0000 (00:02 +0000)]
Unreviewed, JavaScriptCore should only guarantee to produce a
modulemap if we are building for iOSMac.

* Configurations/JavaScriptCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoWeb Inspector: Uncaught Exception: TypeError: null is not an object (evaluating ...
drousso@apple.com [Thu, 1 Nov 2018 23:49:32 +0000 (23:49 +0000)]
Web Inspector: Uncaught Exception: TypeError: null is not an object (evaluating 'mouseBlock.addEventListener')
https://bugs.webkit.org/show_bug.cgi?id=191020

Reviewed by Joseph Pecoraro.

* UserInterface/Views/TimelineRuler.js:
(WI.TimelineRuler):
Since `undefined` is not a number, it isn't less than `0`, which caused us to divide by
`undefined` (equivalent to dividing by `0`), resulting in `NaN`.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKey...
nvasilyev@apple.com [Thu, 1 Nov 2018 23:24:16 +0000 (23:24 +0000)]
Uncaught Exception: TypeError: undefined is not an object (evaluating 'WI.modifierKeys.metaKey') (at ScopeBarItem.js:87:67)
https://bugs.webkit.org/show_bug.cgi?id=191173

Reviewed by Devin Rousso.

WI.modifierKeys was accessed before it was initialized. Move it from WI.contentLoaded to WI.loaded,
which happens before WI.contentLoaded.

* UserInterface/Base/Main.js:
(WI.loaded):
(WI.contentLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoCleanup: Extraneous platform guarding of -_setUpSQLiteDatabaseTrackerClient
dbates@webkit.org [Thu, 1 Nov 2018 23:22:24 +0000 (23:22 +0000)]
Cleanup: Extraneous platform guarding of -_setUpSQLiteDatabaseTrackerClient
https://bugs.webkit.org/show_bug.cgi?id=191124

Reviewed by Tim Horton.

Remove the platform guard around the call to -_setUpSQLiteDatabaseTrackerClient as the
implementation of that message is already guarded.

* UIProcess/API/Cocoa/WKWebView.mm:
(-[WKWebView _initializeWithConfiguration:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, attempt to fix the build with recent SDKs.
ryanhaddad@apple.com [Thu, 1 Nov 2018 23:19:57 +0000 (23:19 +0000)]
Unreviewed, attempt to fix the build with recent SDKs.

* Shared/EntryPointUtilities/mac/XPCService/XPCServiceEntryPoint.h:
(WebKit::XPCServiceInitializer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoLocation object sans browsing context
cdumez@apple.com [Thu, 1 Nov 2018 21:40:16 +0000 (21:40 +0000)]
Location object sans browsing context
https://bugs.webkit.org/show_bug.cgi?id=191060

Reviewed by Geoffrey Garen.

LayoutTests/imported/w3c:

* web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window-expected.txt:
Rebase WPT test now that all checks are passing.

* web-platform-tests/html/browsers/history/the-location-interface/no-browsing-context.window.js:
Fix bug in WPT test (https://github.com/web-platform-tests/wpt/pull/13854)

* web-platform-tests/html/webappapis/dynamic-markup-insertion/opening-the-input-stream/url.window-expected.txt:

Source/WebCore:

As per https://github.com/whatwg/html/pull/4076, a Location object's URL should be "about:blank" when
it does not have a browsing context (Frame), not "".

No new tests, rebaselined existing tests.

* page/Location.cpp:
(WebCore::Location::url const):
(WebCore::Location::href const):
(WebCore::Location::protocol const):
(WebCore::Location::host const):
(WebCore::Location::hostname const):
(WebCore::Location::port const):
(WebCore::Location::pathname const):
(WebCore::Location::search const):
(WebCore::Location::origin const):
(WebCore::Location::hash const):

LayoutTests:

Update existing tests to reflect behavior change.

* http/tests/dom/same-origin-detached-window-properties-expected.txt:
* http/tests/dom/same-origin-detached-window-properties.html:
* http/tests/security/xss-DENIED-script-inject-into-inactive-window.html:
* http/tests/security/xss-DENIED-script-inject-into-inactive-window2-pson.html:
* http/tests/security/xss-DENIED-script-inject-into-inactive-window2.html:
* http/tests/security/xss-DENIED-script-inject-into-inactive-window3.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[WinCairo] Unreviewed layout test gardening.
ross.kirsling@sony.com [Thu, 1 Nov 2018 21:19:12 +0000 (21:19 +0000)]
[WinCairo] Unreviewed layout test gardening.

(Also remove one outdated global test failure.)

* TestExpectations:
* platform/wincairo/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoAdd a storage limit for IndexedDB
sihui_liu@apple.com [Thu, 1 Nov 2018 21:11:57 +0000 (21:11 +0000)]
Add a storage limit for IndexedDB
https://bugs.webkit.org/show_bug.cgi?id=190598
<rdar://problem/44654715>

Reviewed by Chris Dumez.

Source/WebCore:

Set a storage limit in IndexedDB for each pair of mainFrameOrigin and openingOrigin.
IndexedDB will return a QuotaExceededError if limit is reached.

If the size of free disk space is over 1 GB, the default limit is 500 MB; otherwise it is
half the free disk space.

Test: storage/indexeddb/storage-limit.html

* Modules/indexeddb/server/IDBBackingStore.h:
* Modules/indexeddb/server/IDBServer.cpp:
(WebCore::IDBServer::IDBServer::createBackingStore):
(WebCore::IDBServer::IDBServer::setPerOriginQuota):
* Modules/indexeddb/server/IDBServer.h:
(WebCore::IDBServer::IDBServer::perOriginQuota const):
* Modules/indexeddb/server/MemoryIDBBackingStore.h:
* Modules/indexeddb/server/SQLiteIDBBackingStore.cpp:
(WebCore::IDBServer::SQLiteIDBBackingStore::SQLiteIDBBackingStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::quotaForOrigin const):
(WebCore::IDBServer::SQLiteIDBBackingStore::maximumSize const):
(WebCore::IDBServer::SQLiteIDBBackingStore::beginTransaction):
(WebCore::IDBServer::SQLiteIDBBackingStore::createObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameObjectStore):
(WebCore::IDBServer::SQLiteIDBBackingStore::createIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedPutIndexRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::renameIndex):
(WebCore::IDBServer::SQLiteIDBBackingStore::addRecord):
(WebCore::IDBServer::SQLiteIDBBackingStore::uncheckedSetKeyGeneratorValue):
* Modules/indexeddb/server/SQLiteIDBBackingStore.h:
* Modules/indexeddb/server/UniqueIDBDatabase.cpp:
(WebCore::IDBServer::UniqueIDBDatabase::setQuota):
* Modules/indexeddb/server/UniqueIDBDatabase.h:

Source/WebKit:

Add SPI for testing.

* NetworkProcess/NetworkProcess.cpp:
(WebKit::NetworkProcess::NetworkProcess):
(WebKit::NetworkProcess::idbServer):
(WebKit::NetworkProcess::setIDBPerOriginQuota):
* NetworkProcess/NetworkProcess.h:
* NetworkProcess/NetworkProcess.messages.in:
* UIProcess/API/C/WKContext.cpp:
(WKContextSetIDBPerOriginQuota):
* UIProcess/API/C/WKContextPrivate.h:
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::setIDBPerOriginQuota):
* UIProcess/WebProcessPool.h:

Source/WebKitLegacy:

* Storage/WebDatabaseProvider.cpp:
(WebDatabaseProvider::idbConnectionToServerForSession):
(WebDatabaseProvider::setIDBPerOriginQuota):
* Storage/WebDatabaseProvider.h:

Source/WebKitLegacy/mac:

* Storage/WebDatabaseManager.mm:
(-[WebDatabaseManager setIDBPerOriginQuota:]):
* Storage/WebDatabaseManagerPrivate.h:

Source/WebKitLegacy/win:

* Interfaces/IWebDatabaseManager.idl:
* WebDatabaseManager.cpp:
(WebDatabaseManager::setIDBPerOriginQuota):
* WebDatabaseManager.h:

Tools:

Add API for testing.

* DumpRenderTree/TestRunner.cpp:
(setIDBPerOriginQuotaCallback):
(TestRunner::staticFunctions):
* DumpRenderTree/TestRunner.h:
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::setIDBPerOriginQuota):
* DumpRenderTree/win/TestRunnerWin.cpp:
(TestRunner::setIDBPerOriginQuota):
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
(WTR::TestRunner::setIDBPerOriginQuota):
* WebKitTestRunner/InjectedBundle/TestRunner.h:
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::setIDBPerOriginQuota):
* WebKitTestRunner/TestController.h:
* WebKitTestRunner/TestInvocation.cpp:
(WTR::TestInvocation::didReceiveSynchronousMessageFromInjectedBundle):

LayoutTests:

Some tests will fail after adding storage limit to IndexedDB, so we need to reduce their
size and rebase their expectations.

* storage/indexeddb/key-type-array-expected.txt:
* storage/indexeddb/key-type-array-private-expected.txt:
* storage/indexeddb/modern/idbkey-array-equality-expected.txt:
* storage/indexeddb/modern/idbkey-array-equality-private-expected.txt:
* storage/indexeddb/modern/resources/idbkey-array-equality.js:
(request.onsuccess):
(request.onerror):
(doAdd):
* storage/indexeddb/prefetch-invalidation-expected.txt:
* storage/indexeddb/prefetch-invalidation-private-expected.txt:
* storage/indexeddb/resources/key-type-array.js:
(testValidArrayKeys.getreq.onsuccess):
(testValidArrayKeys.putreq.onsuccess):
(testValidArrayKeys.testArrayPutGet):
* storage/indexeddb/resources/prefetch-invalidation.js:
(cursorRequest.onsuccess):
(continue50Times):
(continue100Times): Deleted.
* storage/indexeddb/resources/storage-limit.js: Added.
(prepareDatabase):
(onOpenSuccess.request.onerror):
(onOpenSuccess.request.onsuccess):
(onOpenSuccess):
* storage/indexeddb/storage-limit-expected.txt: Added.
* storage/indexeddb/storage-limit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months ago[PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new...
cdumez@apple.com [Thu, 1 Nov 2018 20:53:50 +0000 (20:53 +0000)]
[PSON] WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping
https://bugs.webkit.org/show_bug.cgi?id=191076

Reviewed by Geoffrey Garen.

Source/WebKit:

WebPageProxy::receivedNavigationPolicyDecision() should not schedule the new load asynchronously when process-swapping.
The client can request a new load synchronously after answering the policy decision, in which case we'd end up loading
the wrong URL.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::receivedNavigationPolicyDecision):
* UIProcess/WebProcessPool.cpp:
(WebKit::WebProcessPool::processForNavigation):
(WebKit::WebProcessPool::processForNavigationInternal):
* UIProcess/WebProcessPool.h:

Tools:

Add API test coverage.

* TestWebKitAPI/Tests/WebKitCocoa/ProcessSwapOnNavigation.mm:
(-[PSONNavigationDelegate init]):
(-[PSONNavigationDelegate webView:decidePolicyForNavigationAction:decisionHandler:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 months agoUnreviewed, mark a couple of newly imported WPT tests as flaky on Mac WK1.
cdumez@apple.com [Thu, 1 Nov 2018 20:46:22 +0000 (20:46 +0000)]
Unreviewed, mark a couple of newly imported WPT tests as flaky on Mac WK1.

* platform/mac-wk1/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@237698 268f45cc-cd09-0410-ab3c-d52691b4dbfc