WebKit-https.git
8 years agohttps://bugs.webkit.org/show_bug.cgi?id=16777
barraclough@apple.com [Sat, 11 Jun 2011 02:03:00 +0000 (02:03 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=16777
Eliminate JSC::NaN and JSC::Inf

Reviewed by Sam Weinig.

There's no good reason for -K-J-S- JSC to have its own NAN and infinity constants.
The ones in std::numeric_limits are perfectly good.
Remove JSC::Inf, JSC::NaN, switch some cases of (isnan || isinf) to !isfinite.

Source/JavaScriptCore:

* API/JSCallbackObjectFunctions.h:
(JSC::::toNumber):
* API/JSValueRef.cpp:
(JSValueMakeNumber):
(JSValueToNumber):
* JavaScriptCore.exp:
* runtime/CachedTranscendentalFunction.h:
(JSC::CachedTranscendentalFunction::initialize):
* runtime/DateConstructor.cpp:
(JSC::constructDate):
* runtime/DateInstanceCache.h:
(JSC::DateInstanceData::DateInstanceData):
(JSC::DateInstanceCache::reset):
* runtime/JSCell.cpp:
* runtime/JSCell.h:
(JSC::JSCell::JSValue::getPrimitiveNumber):
(JSC::JSCell::JSValue::toNumber):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):
(JSC::JSGlobalData::resetDateCache):
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObjectFunctions.cpp:
(JSC::globalFuncParseInt):
(JSC::globalFuncIsFinite):
* runtime/JSNotAnObject.cpp:
(JSC::JSNotAnObject::toNumber):
* runtime/JSValue.cpp:
* runtime/JSValue.h:
* runtime/JSValueInlineMethods.h:
(JSC::jsNaN):
* runtime/MathObject.cpp:
(JSC::mathProtoFuncMax):
(JSC::mathProtoFuncMin):
* runtime/NumberConstructor.cpp:
(JSC::numberConstructorNegInfinity):
(JSC::numberConstructorPosInfinity):
* runtime/NumberPrototype.cpp:
(JSC::numberProtoFuncToExponential):
(JSC::numberProtoFuncToFixed):
(JSC::numberProtoFuncToPrecision):
(JSC::numberProtoFuncToString):
* runtime/UString.cpp:
* wtf/DecimalNumber.h:
(WTF::DecimalNumber::DecimalNumber):
* wtf/dtoa.cpp:
(WTF::dtoa):

Source/WebCore:

* bindings/js/JSDataViewCustom.cpp:
(WebCore::getDataViewMember):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Sat, 11 Jun 2011 01:56:26 +0000 (01:56 +0000)]
2011-06-10  James Simonsen  <simonjam@chromium.org>

        Unreviewed, missing expectations for non-V8 from change 88584.
        https://bugs.webkit.org/show_bug.cgi?id=62412

        * html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Sam Weinig <sam@webkit.org>
weinig@apple.com [Sat, 11 Jun 2011 01:18:43 +0000 (01:18 +0000)]
2011-06-10  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        Unresponsive cursor is shown when displaying a modal dialog
        Part of <rdar://problem/9581492>
        https://bugs.webkit.org/show_bug.cgi?id=62494

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::runModal):
        * UIProcess/WebPageProxy.h:
        Stop the responsiveness timer when calling out to show a modal dialog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Sat, 11 Jun 2011 01:08:09 +0000 (01:08 +0000)]
2011-06-10  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        <script> inside <svg> should be executed
        https://bugs.webkit.org/show_bug.cgi?id=62412

        * platform/chromium/html5lib/runner-expected.txt: Passes another test.
        * svg/dom/range-delete-expected.txt: Removed.
        * svg/dom/range-delete.html: Removed.
        * svg/dom/use-style-recalc-script-execute-crash-expected.txt: Now expected to execute script (and not crash).
        * svg/dom/use-style-recalc-script-execute-crash.html:
        * svg/in-html/resources/external.js: Added.
        * svg/in-html/script-expected.txt: Added.
        * svg/in-html/script-external-expected.txt: Added.
        * svg/in-html/script-external.html: Added.
        * svg/in-html/script-nested-expected.txt: Added.
        * svg/in-html/script-nested.html: Added.
        * svg/in-html/script-write-expected.txt: Added.
        * svg/in-html/script-write.html: Added.
        * svg/in-html/script.html: Added.
2011-06-10  James Simonsen  <simonjam@chromium.org>

        Reviewed by Eric Seidel.

        <script> inside <svg> should be executed
        https://bugs.webkit.org/show_bug.cgi?id=62412

        Tests: svg/in-html/script-external.html
               svg/in-html/script-nested.html
               svg/in-html/script-write.html
               svg/in-html/script.html

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processEndTag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Jun 2011 00:56:13 +0000 (00:56 +0000)]
2011-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Script-created parsers should ignore data from the network
        https://bugs.webkit.org/show_bug.cgi?id=62336

        Triggering this condition is very hard to do deterministically.  This
        test attempts to trigger the condition by sending exactly the right
        number of bytes for the Chromium network stack.  As network stacks vary
        and evolve, it's likely we'll lose test coverage for this issue, but
        this is the best test I could come up with.

        * fast/parser/document-write-ignores-later-network-bytes-expected.txt: Added.
        * fast/parser/document-write-ignores-later-network-bytes.html: Added.
2011-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Darin Adler.

        Script-created parsers should ignore data from the network
        https://bugs.webkit.org/show_bug.cgi?id=62336

        If the network packet boundaries line up just right, we can end up
        feeding network data to a parser created by document.write (or
        document.open).  That's incorrect.

        This patch causes DocumentWriter to grab hold of the original parser
        and direct all input to that parser.

        Test: fast/parser/document-write-ignores-later-network-bytes.html

        * dom/Document.cpp:
        (WebCore::Document::explicitClose):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::begin):
        (WebCore::DocumentWriter::addData):
        (WebCore::DocumentWriter::endIfNotLoadingMainResource):
        (WebCore::DocumentWriter::setDocumentWasLoadedAsPartOfNavigation):
        * loader/DocumentWriter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Sat, 11 Jun 2011 00:39:10 +0000 (00:39 +0000)]
2011-06-10  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by James Robinson.

        Web Inspector: [Chromium] DevTools does not highlight elements when accelerated compositing is on.
        https://bugs.webkit.org/show_bug.cgi?id=62149

        Added page overlay for inspector highlight support.

        * WebKit.gyp:
        * src/ChromeClientImpl.cpp:
        (WebKit::ChromeClientImpl::attachRootGraphicsLayer):
        * src/PageOverlay.cpp: Added.
        (WebKit::PageOverlay::create):
        (WebKit::PageOverlay::PageOverlay):
        (WebKit::OverlayGraphicsLayerClientImpl::create):
        (WebKit::OverlayGraphicsLayerClientImpl::~OverlayGraphicsLayerClientImpl):
        (WebKit::OverlayGraphicsLayerClientImpl::notifyAnimationStarted):
        (WebKit::OverlayGraphicsLayerClientImpl::notifySyncRequired):
        (WebKit::OverlayGraphicsLayerClientImpl::paintContents):
        (WebKit::OverlayGraphicsLayerClientImpl::showDebugBorders):
        (WebKit::OverlayGraphicsLayerClientImpl::showRepaintCounter):
        (WebKit::OverlayGraphicsLayerClientImpl::OverlayGraphicsLayerClientImpl):
        (WebKit::PageOverlay::clear):
        (WebKit::PageOverlay::update):
        (WebKit::PageOverlay::paintWebFrame):
        (WebKit::PageOverlay::invalidateWebFrame):
        * src/PageOverlay.h: Added.
        (WebKit::PageOverlay::~PageOverlay):
        (WebKit::PageOverlay::setClient):
        * src/WebDevToolsAgentImpl.cpp:
        (WebKit::WebDevToolsAgentImpl::paintPageOverlay):
        (WebKit::WebDevToolsAgentImpl::highlight):
        (WebKit::WebDevToolsAgentImpl::hideHighlight):
        * src/WebDevToolsAgentImpl.h:
        * src/WebFrameImpl.cpp:
        (WebKit::WebFrameImpl::paintWithContext):
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::setPageOverlayClient):
        (WebKit::WebViewImpl::setOverlayLayer):
        (WebKit::WebViewImpl::setRootGraphicsLayer):
        (WebKit::WebViewImpl::setRootPlatformLayer):
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):
        (WebKit::WebViewImpl::doComposite):
        (WebKit::WebViewImpl::reallocateRenderer):
        * src/WebViewImpl.h:
        (WebKit::WebViewImpl::pageOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Sat, 11 Jun 2011 00:38:26 +0000 (00:38 +0000)]
2011-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by James Robinson.

        When sheriffbot reports failures on IRC instead of saying "(and more..)" it should say the number of tests that are failing
        https://bugs.webkit.org/show_bug.cgi?id=62489

        * Scripts/webkitpy/tool/bot/sheriff.py:
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Sat, 11 Jun 2011 00:22:29 +0000 (00:22 +0000)]
2011-06-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Keep overlap testing logic until real 3d transforms are being used
        https://bugs.webkit.org/show_bug.cgi?id=49857

        For pages that use the translateZ(0) hack to force compositing layers, it's
        advantageous to keep overlap testing, to avoid putting too many other
        elements into layers.

        Only turn off overlap testing if non-identity 3D transforms are used.

        Tests: compositing/layer-creation/rotate3d-overlap.html
               compositing/layer-creation/translatez-overlap.html

        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::updateBacking):
        (WebCore::RenderLayerCompositor::hasNonIdentity3DTransform):
        * rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Worker fails to fire error event when a resource fetch fails.
levin@chromium.org [Sat, 11 Jun 2011 00:21:23 +0000 (00:21 +0000)]
Web Worker fails to fire error event when a resource fetch fails.
https://bugs.webkit.org/show_bug.cgi?id=62475

Reviewed by Dmitry Titov.

Source/WebCore:

Test: http/tests/workers/worker-workerScriptNotThere.html

* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::didFinishLoading): Ensure that
the client is notified of the error when it happens during loading.

LayoutTests:

* http/tests/workers/worker-workerScriptNotThere-expected.txt: Added.
* http/tests/workers/worker-workerScriptNotThere.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFetching a Worker with url that isn't allowed from a file based test causes DRT to...
levin@chromium.org [Sat, 11 Jun 2011 00:11:01 +0000 (00:11 +0000)]
Fetching a Worker with url that isn't allowed from a file based test causes DRT to crash.
https://bugs.webkit.org/show_bug.cgi?id=62469

Reviewed by Dmitry Titov.

Source/WebCore:

Test: fast/workers/worker-crash-with-invalid-location.html

* workers/DefaultSharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::load): Changed to using the RefCounted version of WorkerScriptLoader.
* workers/Worker.cpp:
(WebCore::Worker::create): Ditto.
* workers/Worker.h: Ditto.
* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):  Ditto.
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::~WorkerScriptLoader): Created to
allow removing some header includes in WorkerScriptLoader.h.
(WebCore::WorkerScriptLoader::loadAsynchronously): Fix the ordering
of setPendingActivity and keep WorkerScriptLoader alive during a
potential callback.
* workers/WorkerScriptLoader.h: Made this RefCounted to allow for
keeping it alive during callbacks. Also, removed unnecessary header
inclusions (and added a destructor to facilitate that).
(WebCore::WorkerScriptLoader::create):

Source/WebKit/chromium:

Test: fast/workers/worker-crash-with-invalid-location.html

* src/SharedWorkerRepository.cpp:
(WebCore::SharedWorkerScriptLoader::SharedWorkerScriptLoader): Changed to using the RefCounted version
of WorkerScriptLoader.
(WebCore::SharedWorkerScriptLoader::load): Rearranged calls as done in similar places,
which allows for SharedWorkerScriptLoader to be deleted during the laodAsynchronously call
and for unsetPendingActivity to be called.
(WebCore::SharedWorkerScriptLoader::notifyFinished): Changed to using the RefCounted version
of WorkerScriptLoader.

LayoutTests:

* fast/workers/worker-crash-with-invalid-location-expected.txt: Added.
* fast/workers/worker-crash-with-invalid-location.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Alok Priyadarshi <alokp@chromium.org>
alokp@chromium.org [Fri, 10 Jun 2011 23:55:31 +0000 (23:55 +0000)]
2011-06-10  Alok Priyadarshi  <alokp@chromium.org>

        Reviewed by James Robinson.

        [chromium] Top portion of page is rendered messed up with accelerated drawing
        https://bugs.webkit.org/show_bug.cgi?id=62484

        Fixed the math in flipping the texture from bottom-up to top-down.
        Test: compositing/repaint/shrink-layer.html (existing)

        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::draw):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 10 Jun 2011 23:35:46 +0000 (23:35 +0000)]
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Configurations/FeatureDefines.xcconfig:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Configurations/FeatureDefines.xcconfig:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Configurations/FeatureDefines.xcconfig:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Configurations/FeatureDefines.xcconfig:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * Scripts/build-webkit:
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Ojan Vafai.

        add a compile guard ENABLE(FLEXBOX)
        https://bugs.webkit.org/show_bug.cgi?id=62049

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 David Levin <levin@chromium.org>
levin@chromium.org [Fri, 10 Jun 2011 23:27:50 +0000 (23:27 +0000)]
2011-06-10  David Levin  <levin@chromium.org>

        Reviewed by Adam Barth.

        Add tests for Web Workers at invalid urls.
        https://bugs.webkit.org/show_bug.cgi?id=62486

        * http/tests/workers/shared-worker-invalid-url-expected.txt: Added.
        * http/tests/workers/shared-worker-invalid-url.html: Added.
        * http/tests/workers/worker-invalid-url-expected.txt: Added.
        * http/tests/workers/worker-invalid-url.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 22:55:22 +0000 (22:55 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Turns out, linux baseline isn't spurious.

        * platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll out r88568. It is not the right fix for the problem.
weinig@apple.com [Fri, 10 Jun 2011 22:43:20 +0000 (22:43 +0000)]
Roll out r88568. It is not the right fix for the problem.

* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 22:21:46 +0000 (22:21 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove all spurious copies of test expectations that somehow made it into the tree.

        * platform/chromium-linux/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
        * platform/chromium-mac-leopard/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
        * platform/chromium-mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.
        * platform/mac/fast/dom/navigator-detached-no-crash-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9562114> Fix DumpRenderTree build for production configuration.
mrowe@apple.com [Fri, 10 Jun 2011 22:20:24 +0000 (22:20 +0000)]
<rdar://problem/9562114> Fix DumpRenderTree build for production configuration.

Reviewed by Dimitri Glazkov.

Source/WebCore:

Rename the built WebCoreTestSupport dylib to libWebCoreTestSupport.dylib so
that it can be found via the library search path rather than requiring an
absolute path be passed to the linker.

Install the library and its associated header file in a more appropriate location
for the production configuration.

* Configurations/WebCoreTestSupport.xcconfig:

Tools:

Ensure that DumpRenderTree can find libWebCoreTestSupport.dylib and the associated
header file.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* DumpRenderTree/mac/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Jun 2011 21:53:49 +0000 (21:53 +0000)]
2011-06-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Add a scheduleSetNeedsStyleRecalc() method to ContainerNode for use by RenderLayerCompositor
        https://bugs.webkit.org/show_bug.cgi?id=62471

        RenderLayerCompositor had some code that did a setNeedsStyleRecalc(), but
        in a way that was safe to call during existing style recalc or layout.

        Move this code to ContainerElement so it can be called elsewhere.
        Also add a param to the node callback so we can pass the style change type.

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::queuePostAttachCallback):
        (WebCore::ContainerNode::dispatchPostAttachCallbacks):
        (WebCore::needsStyleRecalcCallback):
        (WebCore::ContainerNode::scheduleSetNeedsStyleRecalc):
        * dom/ContainerNode.h:
        * dom/Node.h:
        (WebCore::Node::scheduleSetNeedsStyleRecalc):
        * html/HTMLFormControlElement.cpp:
        (WebCore::focusPostAttach):
        (WebCore::updateFromElementCallback):
        * html/HTMLPlugInImageElement.cpp:
        (WebCore::HTMLPlugInImageElement::updateWidgetCallback):
        * html/HTMLPlugInImageElement.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::attachRootPlatformLayer):
        (WebCore::RenderLayerCompositor::detachRootPlatformLayer):
        (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange):
        * rendering/RenderLayerCompositor.h:
        * svg/SVGUseElement.cpp:
        (WebCore::updateFromElementCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Fri, 10 Jun 2011 21:42:29 +0000 (21:42 +0000)]
2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: indexedDB.open() name argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62398

        * storage/indexeddb/database-name-undefined-expected.txt: Added.
        * storage/indexeddb/database-name-undefined.html: Added.
2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: indexedDB.open() name argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62398

        Test: storage/indexeddb/database-name-undefined.html

        * storage/IDBFactory.idl: use appropriate IDL magic to force undefined values to null, so we handle missing arguments as well as null arguments

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCommon crash in ApplicationCacheHost::isApplicationCacheEnabled
weinig@apple.com [Fri, 10 Jun 2011 21:34:20 +0000 (21:34 +0000)]
Common crash in ApplicationCacheHost::isApplicationCacheEnabled
<rdar://problem/9328684>

Reviewed by Beth Dakin.

* loader/appcache/ApplicationCacheHost.cpp:
(WebCore::ApplicationCacheHost::isApplicationCacheEnabled):
Speculative fix for a null frame on ApplicationCacheHost's DocumentLoader.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Fri, 10 Jun 2011 21:25:17 +0000 (21:25 +0000)]
2011-06-10  Emil A Eklund  <eae@chromium.org>

        Land Windows expectations for new test added in r88556.

        * platform/win/printing/page-count-relayout-shrink-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 10 Jun 2011 21:16:20 +0000 (21:16 +0000)]
2011-06-10  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove Document::finishParsing
        https://bugs.webkit.org/show_bug.cgi?id=62474

        This function appears to exist only to confuse and befuddle us.  This
        patch prepares for DocumentWriter to grab hold of the parser.

        This patch removes one of the print statements from
        INSTRUMENT_LAYOUT_SCHEDULING, but I'm not sure
        INSTRUMENT_LAYOUT_SCHEDULING works anymore anyway.

        * dom/Document.cpp:
        * dom/Document.h:
        * dom/XMLDocumentParser.cpp:
        (WebCore::XMLDocumentParser::finish):
        * html/parser/HTMLDocumentParser.cpp:
        (WebCore::HTMLDocumentParser::finish):
        * loader/DocumentWriter.cpp:
        (WebCore::DocumentWriter::addData):
        (WebCore::DocumentWriter::endIfNotLoadingMainResource):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::stop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Mark Pilgrim <pilgrim@chromium.org>
commit-queue@webkit.org [Fri, 10 Jun 2011 21:14:14 +0000 (21:14 +0000)]
2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: setVersion() version argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62401

        * storage/indexeddb/setVersion-undefined-expected.txt: Added.
        * storage/indexeddb/setVersion-undefined.html: Added.
2011-06-10  Mark Pilgrim  <pilgrim@chromium.org>

        Reviewed by Tony Chang.

        IndexedDB: setVersion() version argument is required
        https://bugs.webkit.org/show_bug.cgi?id=62401

        Test: storage/indexeddb/setVersion-undefined.html

        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::setVersion): check for null version
        * storage/IDBDatabase.idl: add IDL magic to force undefined to null so we can handle both missing and null arguments

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Jun 2011 21:04:28 +0000 (21:04 +0000)]
2011-06-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dan Bernstein.

        Null-check the layer owner again when painting layers
        https://bugs.webkit.org/show_bug.cgi?id=62473

        Speculative fix for a crash that occurs when the layer's owner
        gets destroyed during painting.

        * platform/graphics/mac/WebLayer.mm:
        (drawLayerContents):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 20:59:21 +0000 (20:59 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Land expectations for a test, added in r88556.

        * platform/chromium-mac/printing/page-count-relayout-shrink-expected.txt: Added.
        * platform/chromium-win/printing/page-count-relayout-shrink-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 20:54:48 +0000 (20:54 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [V8] Add failure expectation for a test, added in r88559.

        * platform/chromium/test_expectations.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-08 Robert Hogan <robert@webkit.org>
robert@webkit.org [Fri, 10 Jun 2011 20:49:25 +0000 (20:49 +0000)]
2011-06-08  Robert Hogan  <robert@webkit.org>

        Reviewed by Andreas Kling.

        [Qt] Lighten the --no-svg build a little
        https://bugs.webkit.org/show_bug.cgi?id=62314

        Only generate source from SVG*.idl if the build is svg-enabled.

        * CodeGenerators.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 20:39:02 +0000 (20:39 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Remove expectation of crash, fixed in r88551.

        * platform/chromium/test_expectations.txt: Removed expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=55347
barraclough@apple.com [Fri, 10 Jun 2011 20:33:27 +0000 (20:33 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=55347
"name" and "message" enumerable on *Error.prototype

Reviewed by Sam Weinig.

This arises from chapter 15 of the spec:
    "Every other property described in this clause has the attributes
    { [[Writable]]: true, [[Enumerable]]: false, [[Configurable]]: true }
    unless otherwise specified."
Standardized properties are not enumerable.

Source/JavaScriptCore:

* runtime/ErrorInstance.cpp:
(JSC::ErrorInstance::ErrorInstance):
* runtime/NativeErrorPrototype.cpp:
(JSC::NativeErrorPrototype::NativeErrorPrototype):

LayoutTests:

* fast/js/exception-properties-expected.txt: Added.
* fast/js/exception-properties.html: Added.
* fast/js/script-tests/exception-properties.js: Added.
(enumerableProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 20:29:33 +0000 (20:29 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Update expectations after r88555.

        * platform/chromium-win/svg/custom/focus-ring-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 10 Jun 2011 20:15:10 +0000 (20:15 +0000)]
2011-06-10  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Rob Buis.

        Integrate SVG Fonts within GlyphPage concept, removing the special SVG code paths from Font, making it possible to reuse the simple text code path for SVG Fonts
        https://bugs.webkit.org/show_bug.cgi?id=59085

        Add glyph table to SVGFontElement mapping between SVGGlyph <-> Glyph
        https://bugs.webkit.org/show_bug.cgi?id=62441

        Preparation patch 1: Introduce the internal glyph table in SVGGlyphMap that will be used to identify each
        SVGGlyph identifier with a Glyph (which is just an ushort). It will be used by follow-up patches.

        Doesn't affect any test so far.

        * platform/graphics/SVGGlyph.h:
        (WebCore::SVGGlyph::SVGGlyph):
        (WebCore::SVGGlyph::operator==):
        * rendering/svg/SVGTextRunRenderingContext.cpp:
        (WebCore::SVGTextRunWalker::walk):
        * svg/SVGFontData.cpp:
        (WebCore::SVGFontData::initializeFontData):
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::SVGFontElement):
        (WebCore::SVGFontElement::registerLigaturesInGlyphCache):
        (WebCore::SVGFontElement::ensureGlyphCache):
        (WebCore::kerningForPairOfStringsAndGlyphs):
        (WebCore::SVGFontElement::horizontalKerningForPairOfStringsAndGlyphs):
        (WebCore::SVGFontElement::verticalKerningForPairOfStringsAndGlyphs):
        (WebCore::SVGFontElement::collectGlyphsForString):
        (WebCore::SVGFontElement::collectGlyphsForGlyphName):
        (WebCore::SVGFontElement::svgGlyphForGlyph):
        (WebCore::SVGFontElement::missingGlyph):
        * svg/SVGFontElement.h:
        (WebCore::SVGKerningPair::SVGKerningPair):
        * svg/SVGGlyphMap.h:
        (WebCore::SVGGlyphMap::addGlyphByUnicodeString):
        (WebCore::SVGGlyphMap::addGlyphByName):
        (WebCore::SVGGlyphMap::appendToGlyphTable):
        (WebCore::SVGGlyphMap::collectGlyphsForString):
        (WebCore::SVGGlyphMap::clear):
        (WebCore::SVGGlyphMap::svgGlyphForGlyph):
        (WebCore::SVGGlyphMap::glyphIdentifierForGlyphName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Emil A Eklund <eae@chromium.org>
eae@chromium.org [Fri, 10 Jun 2011 19:44:39 +0000 (19:44 +0000)]
2011-06-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Regression r85573: Blank pages appear at the end of some wikipedia documents.
        https://bugs.webkit.org/show_bug.cgi?id=62343

        Fix regression caused by r85573. Cached document size not updated after layout.

        * platform/chromium-linux/printing/page-count-relayout-shrink-expected.txt: Added.
        * platform/mac/printing/page-count-relayout-shrink-expected.txt: Added.
        * printing/page-count-relayout-shrink.html: Added.
2011-06-10  Emil A Eklund  <eae@chromium.org>

        Reviewed by Eric Seidel.

        Regression r85573: Blank pages appear at the end of some wikipedia documents.
        https://bugs.webkit.org/show_bug.cgi?id=62343

        Fix regression caused by r85573. Cached document size not updated after layout.

        Test: printing/page-count-relayout-shrink.html

        * page/FrameView.cpp:
        (WebCore::FrameView::forceLayoutForPagination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Rob Buis <rbuis@rim.com>
rwlbuis@webkit.org [Fri, 10 Jun 2011 19:43:23 +0000 (19:43 +0000)]
2011-06-10  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        animation event handling broken: focusin
        https://bugs.webkit.org/show_bug.cgi?id=12894

        focusin, focusout, activate not implemented in SVG
        https://bugs.webkit.org/show_bug.cgi?id=40545

        Test whether focusin and focusout events are dispatched and seen in the focusin/focusout event handlers.

        * platform/mac/svg/custom/focus-ring-expected.txt:
        * svg/custom/focus-event-handling-expected.txt: Added.
        * svg/custom/focus-event-handling-keyboard-expected.txt: Added.
        * svg/custom/focus-event-handling-keyboard.xhtml: Added.
        * svg/custom/focus-event-handling.xhtml: Added.
        * svg/custom/resources/focus-event-handling-keyboard.js: Added.
        (focusinHandler):
        (focusoutHandler):
        * svg/custom/resources/focus-event-handling.js: Added.
        (clearFocusSeen):
        ():
        (focusoutHandler):
        (clickAt):
2011-06-10  Rob Buis  <rbuis@rim.com>

        Reviewed by Nikolas Zimmermann.

        amation event handling broken: focusin
        https://bugs.webkit.org/show_bug.cgi?id=12894

        focusin, focusout, activate not implemented in SVG
        https://bugs.webkit.org/show_bug.cgi?id=40545

        Make elements that should support GraphicalEventAttribute handle focussing, since focusin, focusout is part of that:

        http://www.w3.org/TR/SVG11/intro.html#TermGraphicalEventAttribute

        Match Opera behaviour ; elements that support GraphicalEventAttribute can receive visual mouse focus when having either a focusin or focusout event handler. Elements that support GraphicalEventAttribute can receive visual keyboard focus when having either a focusin or focusout event handler. Keyboard focus does not advance to SVG elements that are not focusable at the time.

        Tests: svg/custom/focus-event-handling-keyboard.xhtml
               svg/custom/focus-event-handling.xhtml

        * rendering/svg/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::computeRectForRepaint):
        * svg/SVGCircleElement.h:
        (WebCore::SVGCircleElement::supportsFocus):
        * svg/SVGEllipseElement.h:
        (WebCore::SVGEllipseElement::supportsFocus):
        * svg/SVGGElement.h:
        (WebCore::SVGGElement::supportsFocus):
        * svg/SVGImageElement.h:
        (WebCore::SVGImageElement::supportsFocus):
        * svg/SVGLineElement.h:
        (WebCore::SVGLineElement::supportsFocus):
        * svg/SVGPathElement.h:
        (WebCore::SVGPathElement::supportsFocus):
        * svg/SVGPolyElement.h:
        (WebCore::SVGPolyElement::supportsFocus):
        * svg/SVGRectElement.h:
        (WebCore::SVGRectElement::supportsFocus):
        * svg/SVGSVGElement.h:
        (WebCore::SVGSVGElement::supportsFocus):
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::isMouseFocusable):
        (WebCore::SVGStyledElement::isKeyboardFocusable):
        * svg/SVGStyledElement.h:
        * svg/SVGSwitchElement.h:
        (WebCore::SVGSwitchElement::supportsFocus):
        * svg/SVGSymbolElement.h:
        (WebCore::SVGSymbolElement::supportsFocus):
        * svg/SVGTextElement.h:
        (WebCore::SVGTextElement::supportsFocus):
        * svg/SVGUseElement.h:
        (WebCore::SVGUseElement::supportsFocus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 10 Jun 2011 18:35:46 +0000 (18:35 +0000)]
2011-06-10  Ryosuke Niwa  <rniwa@webkit.org>

        Rolled DEPS.

        * DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Fri, 10 Jun 2011 18:17:21 +0000 (18:17 +0000)]
2011-06-10  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Clean up CSSPrimitiveValue::computeLength*
        https://bugs.webkit.org/show_bug.cgi?id=61612

        No new tests as no functionality changed.

        * css/CSSGradientValue.cpp:
        Use new computeLength functions.
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::computeLengthIntForLength):
        Reduce to a single function using default parameter values.
        (WebCore::CSSPrimitiveValue::computeLength):
        Redefine existing functions with separate names as a single function using templated function specialization.
        * css/CSSPrimitiveValue.h:
        Prototypes for computeLengthIntForLength and computeLength.
        * css/CSSStyleApplyProperty.cpp:
        Use new computeLength functions.
        * css/CSSStyleSelector.cpp:
        Use new computeLength functions.
        * css/MediaQueryEvaluator.cpp:
        Use new computeLength functions.
        * css/SVGCSSStyleSelector.cpp:
        Use new computeLength functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 10 Jun 2011 18:10:37 +0000 (18:10 +0000)]
2011-06-10  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Beth Dakin.

        Add utility to RenderLayer to determine if the layer is scrollable
        https://bugs.webkit.org/show_bug.cgi?id=62467

        New method that returns true if either scrollbar is present and enabled.
        Not called anywhere yet.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::allowsScrolling):
        * rendering/RenderLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 17:56:52 +0000 (17:56 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Tony Chang.

        REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges
        https://bugs.webkit.org/show_bug.cgi?id=62460

        Test: fast/dom/prototype-inheritance-2.html

        * dom/DocumentMarkerController.cpp:
        (WebCore::DocumentMarkerController::userSpellingMarkersForNode): Added an extra 0-check.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 10 Jun 2011 17:31:29 +0000 (17:31 +0000)]
2011-06-10  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Tony Gentilcore.

        Tests that trying to remove all document children while building a svg <use>
        element shadow and instance tree does not result in crash.
        https://bugs.webkit.org/show_bug.cgi?id=62225

        * svg/dom/use-style-recalc-script-execute-crash-expected.txt: Added.
        * svg/dom/use-style-recalc-script-execute-crash.html: Added.
2011-06-10  James Simonsen  <simonjam@chromium.org>

        Reviewed by Tony Gentilcore.

        Don't execute scripts in shadow SVG.
        https://bugs.webkit.org/show_bug.cgi?id=62225

        Test: svg/dom/use-style-recalc-script-execute-crash.html

        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::prepareScript):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 10 Jun 2011 17:31:13 +0000 (17:31 +0000)]
2011-06-10  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] make features.gypi the same as features_override.gypi
        https://bugs.webkit.org/show_bug.cgi?id=62399

        Make the file the same as chromium's features_override.gypi so we
        can remove features_override.gypi in chromium.

        Remove ENABLE_DATAGRID=0 since the define is gone and remove
        ENABLE_FULLSCREEN_API=1 since we want to disable it.

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Konstantin Tokarev <ktokarev@smartlabs.tv>
loislo@chromium.org [Fri, 10 Jun 2011 17:29:08 +0000 (17:29 +0000)]
2011-06-10  Konstantin Tokarev  <ktokarev@smartlabs.tv>

        Reviewed by Joseph Pecoraro.

        Fixed build with enabled workers and disabled inspector
        https://bugs.webkit.org/show_bug.cgi?id=62461

        * inspector/InspectorWorkerAgent.cpp: Added inspector guard

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 10 Jun 2011 17:05:31 +0000 (17:05 +0000)]
2011-06-10  Darin Adler  <darin@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION: Fullscreen video controller can't be dragged
        https://bugs.webkit.org/show_bug.cgi?id=62462

        No regression test because we don't have machinery for testing the fullscreen
        mode. We may find a way to add this in the future.

        * html/shadow/MediaControlElements.cpp:
        (WebCore::MediaControlPanelElement::MediaControlPanelElement): Initialize new
        booleans related to dragging.
        (WebCore::MediaControlPanelElement::startDrag): Added. Starts drag if dragging
        is allowed and a drag isn't already in progress.
        (WebCore::MediaControlPanelElement::continueDrag): Added. Moves the window if
        dragging is already in progress.
        (WebCore::MediaControlPanelElement::endDrag): Added. Ends the capture that is
        done during the dragging process.
        (WebCore::MediaControlPanelElement::setPosition): Added. Positions the panel
        using explicit top/left.
        (WebCore::MediaControlPanelElement::resetPosition): Added. Removes the positioning
        done by setPosition.
        (WebCore::MediaControlPanelElement::defaultEventHandler): Added. Calls startDrag,
        continueDrag, and endDrag in response to mouse events.
        (WebCore::MediaControlPanelElement::setCanBeDragged): Added.
        * html/shadow/MediaControlElements.h: Added new function and data members
        as mentioned above.

        * html/shadow/MediaControlRootElement.cpp:
        (WebCore::MediaControlRootElement::enteredFullscreen): Call setCanBeDragged(true)
        so you can drag the panel while in fullscreen.
        (WebCore::MediaControlRootElement::exitedFullscreen): Call setCanBeDragged(false)
        so you can't drag the panel while not in fullscreen. Also call resetPosition so
        position changes from dragging don't affect the panel in other contexts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 17:00:17 +0000 (17:00 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        Remove tests that are now passing.

        * platform/chromium/test_expectations.txt: Removed passing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Darin Adler <darin@apple.com>
darin@apple.com [Fri, 10 Jun 2011 16:52:01 +0000 (16:52 +0000)]
2011-06-10  Darin Adler  <darin@apple.com>

        Reviewed by Eric Carlson.

        REGRESSION: Full screen video HUD is positioned too low for standalone video documents
        https://bugs.webkit.org/show_bug.cgi?id=62463

        No test because we don't currently have machinery for testing fullscreen.

        * css/fullscreen.css: Removed rule that said bottom: 0px for the control panel
        for full page media in full screen mode. This is not needed because the control
        panel for full screen mode already has style rules to set its vertical position.
        (:-webkit-full-screen-ancestor:not(iframe)): Fixed typo where it said
        -webkit-tranform. This will fix a potential problem where fullscreen would
        malfunction on a page that had a media element inside a transform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Sergio Villar Senin <svillar@igalia.com>
sergio@webkit.org [Fri, 10 Jun 2011 16:06:53 +0000 (16:06 +0000)]
2011-06-10  Sergio Villar Senin  <svillar@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] Add support for non-ASCII filenames in Content-Disposition header
        https://bugs.webkit.org/show_bug.cgi?id=62454

        Try latin1 as fallback for header parameter values as some servers
        do not follow RFC 2045 for example with filename parameter in
        Content-Disposition.

        No new tests required as no functionality changed.

        * platform/network/soup/ResourceResponseSoup.cpp:
        (WebCore::ResourceResponse::updateFromSoupMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 10 Jun 2011 15:55:36 +0000 (15:55 +0000)]
2011-06-10  Dimitri Glazkov  <dglazkov@chromium.org>

        REGRESSION (r88332): prototype-inheritance-2 ASSERTS attempting to enumerate spellCheckRanges.
        https://bugs.webkit.org/show_bug.cgi?id=62460

        * platform/chromium/test_expectations.txt: Updated test expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 No'am Rosenthal <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko...
commit-queue@webkit.org [Fri, 10 Jun 2011 11:56:37 +0000 (11:56 +0000)]
2011-06-10  No'am Rosenthal  <noam.rosenthal@nokia.com> and Viatcheslav Ostapenko <ostapenko.viatcheslav@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Add layer factory to GraphicsLayer for creating non-default layer type.
        https://bugs.webkit.org/show_bug.cgi?id=61925

        Added a static factory protected member to GraphicsLayer, which should be accessed from
        a port-specific implementation of GraphicsLayer::create. For now this is enabled for Qt only.

        This is needed for accelerated compositing across processes in WebKit2, since WebCore
        doesn't know in compile time whether it's in WebKit or WebKit2, which makes having two
        different implementations of GraphicsLayer coexist impossible without some runtime
        factory that can be overridden by the web process.

        Note that the use of the factory would be optional, and the port-specific GraphicsLayer::create
        would have to explicitly call it, in order to be unintrusive with current implementations.

        No new functionality, so no new tests.

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::setGraphicsLayerFactory):
        * platform/graphics/GraphicsLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 10 Jun 2011 11:34:59 +0000 (11:34 +0000)]
2011-06-10  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL][WK2] Add dummy files in WebProcess/WebCoreSupport/efl
        https://bugs.webkit.org/show_bug.cgi?id=62346

        Add WebProcess/WebCoreSupport/efl directory and files.

        * WebProcess/WebCoreSupport/efl/WebContextMenuClientEfl.cpp: Added.
        (WebKit::WebContextMenuClient::lookUpInDictionary):
        (WebKit::WebContextMenuClient::isSpeaking):
        (WebKit::WebContextMenuClient::speak):
        (WebKit::WebContextMenuClient::stopSpeaking):
        * WebProcess/WebCoreSupport/efl/WebEditorClientEfl.cpp: Added.
        (WebKit::WebEditorClient::handleKeyboardEvent):
        (WebKit::WebEditorClient::handleInputMethodKeydown):
        * WebProcess/WebCoreSupport/efl/WebErrorsEfl.cpp: Added.
        (WebKit::cancelledError):
        (WebKit::blockedError):
        (WebKit::cannotShowURLError):
        (WebKit::interruptForPolicyChangeError):
        (WebKit::cannotShowMIMETypeError):
        (WebKit::fileDoesNotExistError):
        (WebKit::pluginWillHandleLoadError):
        * WebProcess/WebCoreSupport/efl/WebFrameNetworkingContext.h: Added.
        (WebFrameNetworkingContext::create):
        (WebFrameNetworkingContext::WebFrameNetworkingContext):
        * WebProcess/WebCoreSupport/efl/WebPopupMenuEfl.cpp: Added.
        (WebKit::WebPopupMenu::setUpPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Lucas De Marchi <lucas.demarchi@profusion.mobi>
commit-queue@webkit.org [Fri, 10 Jun 2011 11:32:38 +0000 (11:32 +0000)]
2011-06-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [CMAKE] Add generic support for building with WebGL
        https://bugs.webkit.org/show_bug.cgi?id=62376

        Add files that need to be compiled in every port for supporting WebGL.
        Each port still needs to add its specific files to
        CMakeLists${PORT}.txt. Therefore we do not enable WebGL in any port
        yet.

        * Source/CMakeLists.txt: Add files needed to support WebGL.
        * Source/cmake/OptionsCommon.cmake: Find required OpenGL package.
        * Source/cmakeconfig.h.cmake: define ENABLE_WEBGL this feature is
        enabled.
2011-06-10  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Kenneth Rohde Christiansen.

        [CMAKE] Add generic support for building with WebGL
        https://bugs.webkit.org/show_bug.cgi?id=62376

        Set new THIRDPARTY_DIR variable to compile sources under ThirdParty.

        No change in functionality so no new tests.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Fri, 10 Jun 2011 11:31:23 +0000 (11:31 +0000)]
2011-06-10  Andreas Kling  <kling@webkit.org>

        Reviewed by Benjamin Poulain.

        [Qt] Fix 'headers' autotest when building inside Qt.
        https://bugs.webkit.org/show_bug.cgi?id=62449

        * Api/qwebkitplatformplugin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 KwangHyuk Kim <hyuki.kim@samsung.com>
commit-queue@webkit.org [Fri, 10 Jun 2011 11:30:19 +0000 (11:30 +0000)]
2011-06-10  KwangHyuk Kim  <hyuki.kim@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL]add image content hint information for tile image object when it is created
        https://bugs.webkit.org/show_bug.cgi?id=62436

        When application is using opengl_x11 Ecore_Evas, it can be working as gl texture.
        In order to support this enhanced feature, image content hint information must be
        specified as EVAS_IMAGE_CONTENT_HINT_DYNAMIC

        * ewk/ewk_tiled_model.c:
        (ewk_tile_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Fri, 10 Jun 2011 11:23:38 +0000 (11:23 +0000)]
2011-06-10  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Andreas Kling.

        [GTK][EFL] m_imageInterpolationQuality is not initialized in PlatformContextCairo::PlatformContextCairo.
        https://bugs.webkit.org/show_bug.cgi?id=62435

        No new tests required as just fixed warning.

        * platform/graphics/cairo/PlatformContextCairo.cpp:
        (WebCore::PlatformContextCairo::PlatformContextCairo):

2011-06-11-06-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
        https://bugs.webkit.org/show_bug.cgi?id=62377

        * inspector/InspectorValues.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 10 Jun 2011 10:15:50 +0000 (10:15 +0000)]
2011-06-10  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
        https://bugs.webkit.org/show_bug.cgi?id=62377

        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:

2011-06-11-06-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
        https://bugs.webkit.org/show_bug.cgi?id=62377

        * inspector/InspectorValues.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Laszlo Gombos <laszlo.1.gombos@nokia.com>
laszlo.1.gombos@nokia.com [Fri, 10 Jun 2011 10:06:41 +0000 (10:06 +0000)]
2011-06-10  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Keep ORIENTATION_EVENTS independent from DEVICE_ORIENTATION
        https://bugs.webkit.org/show_bug.cgi?id=62420

        ORIENTATION_EVENTS and DEVICE_ORIENTATION features are very similar
        but they meant to be independent.

        * Api/qwebframe.cpp:
        (QWebFramePrivate::_q_orientationChanged):
        (QWebFrame::QWebFrame):
        * Api/qwebframe_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Grzegorz Czajkowski <g.czajkowski@samsung.com>
commit-queue@webkit.org [Fri, 10 Jun 2011 09:09:45 +0000 (09:09 +0000)]
2011-06-10  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Reviewed by Kenneth Rohde Christiansen.

        [EFL] Repaint throttling API.
        https://bugs.webkit.org/show_bug.cgi?id=56178

        The API allows to set the values for repaint throttling.
        It should ensure displaying a content with many css/gif animations.

        * ewk/ewk_settings.cpp:
        (ewk_settings_repaint_throttling_set):
        * ewk/ewk_settings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Fri, 10 Jun 2011 08:56:48 +0000 (08:56 +0000)]
2011-06-10  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Kent Tamura.

        [EFL] Use makeString() when getting os version
        https://bugs.webkit.org/show_bug.cgi?id=62434

        When os version string is created, to use makeString() is better than
        String operation.

        * ewk/ewk_settings.cpp:
        (_ewk_settings_webkit_os_version_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Sheriff Bot <webkit.review.bot@gmail.com>
loislo@chromium.org [Fri, 10 Jun 2011 08:41:55 +0000 (08:41 +0000)]
2011-06-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r88530.
        http://trac.webkit.org/changeset/88530
        https://bugs.webkit.org/show_bug.cgi?id=62440

        qt build was broken (Requested by loislo on #webkit).

        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2011-06-10  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r88530.
        http://trac.webkit.org/changeset/88530
        https://bugs.webkit.org/show_bug.cgi?id=62440

        qt build was broken (Requested by loislo on #webkit).

        * inspector/InspectorValues.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Fri, 10 Jun 2011 08:33:11 +0000 (08:33 +0000)]
2011-06-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
        https://bugs.webkit.org/show_bug.cgi?id=62377

        * inspector/report-protocol-errors-expected.txt:
        * inspector/report-protocol-errors.html:
2011-06-09  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol: json: Whitespace can be inserted between any pair of tokens.
        https://bugs.webkit.org/show_bug.cgi?id=62377

        * inspector/InspectorValues.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 10 Jun 2011 07:35:55 +0000 (07:35 +0000)]
2011-06-09  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Dmitry Titov.

        [Chromium] Worker object may be garbage collected even if it has message handlers
        https://bugs.webkit.org/show_bug.cgi?id=62292

        I'd like to convert the test case into a layout test but I don't see yet
        how to do this so that the test isn't too slow and reliable. The problem
        with test is that full-GC needs to be triggered right after
        WebWorkerClientImpl::confirmMessageFromWorkerObject is called and there
        is no way to hook WebWorkerClientImpl::confirmMessageFromWorkerObject from JavaScript.
        So no test for now.

        * src/WebWorkerClientImpl.cpp:
        (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObject):
        (WebKit::WebWorkerClientImpl::confirmMessageFromWorkerObjectTask): update worker context pending
        activity state every time a message is confirmed since the message may have created a new activity.
        * src/WebWorkerClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 10 Jun 2011 07:10:53 +0000 (07:10 +0000)]
2011-06-09  Jer Noble  <jer.noble@apple.com>

        Reviewed by Darin Adler.

        REGRESSION: Vertical scroll bar appears when taking videos into full screen at jerryseinfeld.com
        https://bugs.webkit.org/show_bug.cgi?id=62402

        Sites are able to override the "overflow:hidden" rule for root full-screen nodes
        simply by adding a "html {}" rule.  Make this rule !important, and also make it apply
        to root nodes who are merely ancestors of full-screen elements, to cover the case of
        a root node containing an <iframe> whose contents have gone full-screen.

        * css/fullscreen.css:
        (:root:-webkit-full-screen-document:not(:-webkit-full-screen),
            :root:-webkit-full-screen-ancestor): Apply the overflow rule to root elements
            who are full-screen ancestors, and make them !important.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-10 Mahesh Kulkarni <mahesh.kulkarni@nokia.com>
mahesh.kulkarni@nokia.com [Fri, 10 Jun 2011 06:42:57 +0000 (06:42 +0000)]
2011-06-10  Mahesh Kulkarni  <mahesh.kulkarni@nokia.com>

        Reviewed by Antonio Gomes.

        [Qt] LayoutTests/fast/history/history_reload.html failing
        https://bugs.webkit.org/show_bug.cgi?id=62369

        Unskipping. Generating click of button element in generic way.
        Remove hardcoding of click co-ordinates to avoid native font differences.

        * fast/history/history_reload.html:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Fri, 10 Jun 2011 06:20:58 +0000 (06:20 +0000)]
2011-06-09  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Rename RenderStyle visuallyOrdered property and use an enum instead of a bool.
        https://bugs.webkit.org/show_bug.cgi?id=61495

        No new tests required as no functionality changed.

        * css/CSSPrimitiveValueMappings.h:
        Support cast to/from Order
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::styleForDocument):
        Convert from bool to enum type.
        (WebCore::CSSStyleSelector::applyProperty):
        Convert to macro that uses the cast defined in CSSPrimitiveValueMappings.
        * dom/Document.cpp:
        (WebCore::Document::setVisuallyOrdered):
        Change call to RenderStyle::setRTLOrdering using enum parameter.
        * rendering/style/RenderStyle.h:
        rename visuallyOrdered proerties rtlOrdering and use appropriate enum types.
        * rendering/style/RenderStyleConstants.h:
        Define enum type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Fri, 10 Jun 2011 06:19:22 +0000 (06:19 +0000)]
2011-06-09  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Implement CSSPropertyOutlineStyle handler in CSSStyleApplyProperty
        https://bugs.webkit.org/show_bug.cgi?id=61601

        No new tests. No new functionality added / covered by existing tests.

        * css/CSSPrimitiveValueMappings.h:
        (WebCore::CSSPrimitiveValue::operator EBorderStyle):
        Support CSSValueAuto as required by outline-style property.
        (WebCore::CSSPrimitiveValue::operator OutlineIsAuto):
        Add cast to new OutlineIsAuto enum.
        * css/CSSStyleApplyProperty.cpp:
        (WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
        Initialize handler for CSSPropertyOutlineStyle.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        Remove old handler for CSSPropertyOutlineStyle.
        * rendering/style/OutlineValue.h:
        Use new OutlineIsAuto enum instead of bool.
        * rendering/style/RenderStyle.h:
        Split existing two-parameter setter setOutlineStyle into separate setters for style and auto properties.
        Use new OutlineIsAuto enum type.
        * rendering/style/RenderStyleConstants.h:
        Define new enum OutlineIsAuto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Luke Macpherson <macpherson@chromium.org>
macpherson@chromium.org [Fri, 10 Jun 2011 06:17:40 +0000 (06:17 +0000)]
2011-06-09  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Eric Seidel.

        Code cleanup - add wrappers for function pointer dereferences to improve readability in ApplyPropertyDefaultBase and derived classes.
        https://bugs.webkit.org/show_bug.cgi?id=62418

        No new tests / cleanup only.

        * css/CSSStyleApplyProperty.cpp:
        (WebCore::ApplyPropertyDefaultBase::applyInheritValue):
        Use new wrapper functions.
        (WebCore::ApplyPropertyDefaultBase::applyInitialValue):
        Use new wrapper functions.
        (WebCore::ApplyPropertyDefaultBase::setValue):
        Wrapper for calling m_setter function pointer.
        (WebCore::ApplyPropertyDefaultBase::value):
        Wrapper for calling m_getter function pointer.
        (WebCore::ApplyPropertyDefaultBase::initial):
        Wrapper for calling m_initial function pointer.
        (WebCore::ApplyPropertyDefault::applyValue):
        Use new setValue function.
        (WebCore::ApplyPropertyLength::applyValue):
        Use new setValue function.
        (WebCore::ApplyPropertyWidth::applyValue):
        Use new setValue function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 James Kozianski <koz@chromium.org>
koz@chromium.org [Fri, 10 Jun 2011 06:16:18 +0000 (06:16 +0000)]
2011-06-09  James Kozianski  <koz@chromium.org>

        Unreviewed, rolling out r88466.
        http://trac.webkit.org/changeset/88466
        https://bugs.webkit.org/show_bug.cgi?id=60059

        Broke PPAPITest.URLLoader test on the chromium bots

        * WebKit.gyp:
        * WebKit.gypi:
        * src/AssociatedURLLoader.cpp:
        (WebKit::AssociatedURLLoader::ClientAdapter::clearClient):
        (WebKit::AssociatedURLLoader::ClientAdapter::ClientAdapter):
        (WebKit::AssociatedURLLoader::ClientAdapter::didFinishLoading):
        (WebKit::AssociatedURLLoader::ClientAdapter::didFail):
        (WebKit::AssociatedURLLoader::loadAsynchronously):
        * tests/AssociatedURLLoaderTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRollback 88521
keishi@webkit.org [Fri, 10 Jun 2011 05:54:26 +0000 (05:54 +0000)]
Rollback 88521

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agotest
keishi@webkit.org [Fri, 10 Jun 2011 05:49:06 +0000 (05:49 +0000)]
test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix: Corrected header spelling.
ggaren@apple.com [Fri, 10 Jun 2011 04:43:03 +0000 (04:43 +0000)]
Build fix: Corrected header spelling.

* heap/OldSpace.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 10 Jun 2011 04:38:23 +0000 (04:38 +0000)]
2011-06-09  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Added OldSpace to the project
        https://bugs.webkit.org/show_bug.cgi?id=62417

        Currently unused.

        Added OldSpace, the ability to iterate NewSpace vs OldSpace, and a
        per-block flag for testing whether you're in NewSpace vs OldSpace.

        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.pro:
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj: Build!

        * heap/MarkedBlock.cpp:
        (JSC::MarkedBlock::MarkedBlock):
        * heap/MarkedBlock.h:
        (JSC::MarkedBlock::inNewSpace):
        (JSC::MarkedBlock::setInNewSpace): Added inNewSpace flag, for use in
        write barrier.

        * heap/NewSpace.cpp:
        (JSC::NewSpace::addBlock):
        (JSC::NewSpace::removeBlock):
        * heap/NewSpace.h:
        (JSC::NewSpace::forEachBlock): Added forEachBlock, to use for
        NewSpace-specific operations.

        * heap/OldSpace.cpp: Added.
        (JSC::OldSpace::OldSpace):
        (JSC::OldSpace::addBlock):
        (JSC::OldSpace::removeBlock):
        * heap/OldSpace.h: Added.
        (JSC::OldSpace::forEachBlock): New class for holding promoted blocks.
        Not in use yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Hyowon Kim <hw1008.kim@samsung.com>
commit-queue@webkit.org [Fri, 10 Jun 2011 03:52:46 +0000 (03:52 +0000)]
2011-06-09  Hyowon Kim  <hw1008.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Make accelerated compositing build in Webkit-EFL
        https://bugs.webkit.org/show_bug.cgi?id=62361

        Add PLATFORM(EFL) to enable ACCELERATED_COMPOSITING on EFL port.

        * wtf/Platform.h:
2011-06-09  Hyowon Kim  <hw1008.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Make accelerated compositing build in Webkit-EFL
        https://bugs.webkit.org/show_bug.cgi?id=62361

        Add a new class, GraphicsLayerEfl - not yet implemented.
        Add ACCELERATED_COMPOSITING related files to CMakeLists.

        * CMakeLists.txt:
        * CMakeListsEfl.txt:
        * platform/graphics/efl/GraphicsLayerEfl.cpp: Added.
        (WebCore::GraphicsLayer::create):
        (WebCore::GraphicsLayerEfl::GraphicsLayerEfl):
        (WebCore::GraphicsLayerEfl::~GraphicsLayerEfl):
        (WebCore::GraphicsLayerEfl::setNeedsDisplay):
        (WebCore::GraphicsLayerEfl::setNeedsDisplayInRect):
        * platform/graphics/efl/GraphicsLayerEfl.h: Added.
2011-06-09  Hyowon Kim  <hw1008.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Make accelerated compositing build in Webkit-EFL
        https://bugs.webkit.org/show_bug.cgi?id=62361

        Add functions for accelerated compositing to ChromeClientEfl.

        * WebCoreSupport/ChromeClientEfl.cpp:
        (WebCore::ChromeClientEfl::attachRootGraphicsLayer):
        (WebCore::ChromeClientEfl::setNeedsOneShotDrawingSynchronization):
        (WebCore::ChromeClientEfl::scheduleCompositingLayerSync):
        (WebCore::ChromeClientEfl::allowedCompositingTriggers):
        * WebCoreSupport/ChromeClientEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Fri, 10 Jun 2011 03:45:07 +0000 (03:45 +0000)]
2011-06-09  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Antonio Gomes.

        [CMAKE] Never let USER_AGENT defined to nothing
        https://bugs.webkit.org/show_bug.cgi?id=62410

        This patch is similar to r88342, but sets WEBKIT_USER_AGENT_*
        definitions only if that port defined it. A port might prefer to set it
        in other place, e.g. a header that is part of the public API (like GTK
        does).

        By using #cmakedefine instead of #define, if that variable is not set
        in CMake it will expand to:

        /* #define WEBKIT_USER_AGENT_MAJOR_VERSION */

        * Source/cmake/OptionsEfl.cmake:
        * Source/cmakeconfig.h.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] The profiler test is entirely unrelated to the original change r88337
ossy@webkit.org [Fri, 10 Jun 2011 02:50:43 +0000 (02:50 +0000)]
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

Last attempt to make buildbot happy against crazy flakiness near inspector tests. :-/

* platform/qt/Skipped: Disable all inspector tests until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-05-30 Raphael Kubo da Costa <kubo@profusion.mobi>
demarchi@webkit.org [Fri, 10 Jun 2011 02:43:40 +0000 (02:43 +0000)]
2011-05-30  Raphael Kubo da Costa  <kubo@profusion.mobi>

        Reviewed by Brent Fulgham.

        [efl] Do not enable the encoding detector by default.
        https://bugs.webkit.org/show_bug.cgi?id=61744

        This should match the behaviour of other ports more closely, and makes
        at least dom/xhtml/level3/core/documentgetinputencoding01.xhtml pass.

        * ewk/ewk_view.cpp:
        (_ewk_view_priv_new):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] The profiler test is entirely unrelated to the original change r88337
ossy@webkit.org [Fri, 10 Jun 2011 02:30:59 +0000 (02:30 +0000)]
[Qt] The profiler test is entirely unrelated to the original change r88337
and seems to be highly related to https://bugs.webkit.org/show_bug.cgi?id=60881

https://bugs.webkit.org/show_bug.cgi?id=62278

One more attempt to make buildbot happy
against crazy flakiness near inspector tests. :-/

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed rolling out r88471, because it broke plugin tests on Qt.
ossy@webkit.org [Fri, 10 Jun 2011 01:59:33 +0000 (01:59 +0000)]
Unreviewed rolling out r88471, because it broke plugin tests on Qt.

Tools:

* DumpRenderTree/TestNetscapePlugIn/main.cpp:
(handleEventX11):
(NPP_GetValue):
* DumpRenderTree/qt/TestNetscapePlugin/TestNetscapePlugin.pro:
* DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp: Added.
(webkit_test_plugin_new_instance):
(webkit_test_plugin_destroy_instance):
(webkit_test_plugin_set_window):
(executeScript):
(webkit_test_plugin_new_stream):
(webkit_test_plugin_destroy_stream):
(webkit_test_plugin_stream_as_file):
(webkit_test_plugin_write_ready):
(webkit_test_plugin_write):
(webkit_test_plugin_print):
(keyEventToChar):
(webkit_test_plugin_handle_event):
(webkit_test_plugin_url_notify):
(webkit_test_plugin_get_value):
(webkit_test_plugin_set_value):
(NP_GetMIMEDescription):
(NP_Initialize):
(NP_Shutdown):
(NP_GetValue):
* GNUmakefile.am:

LayoutTests:

* platform/chromium-linux/plugins/mouse-events-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Mac] Unskip fast/forms/input-number-large-padding.html
tkent@chromium.org [Fri, 10 Jun 2011 01:31:31 +0000 (01:31 +0000)]
[Mac] Unskip fast/forms/input-number-large-padding.html
https://bugs.webkit.org/show_bug.cgi?id=61845

It should work now because we don't use outer-spin-button anymore.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCalling WebKitBlobBuilder.append with null argument should not crash
jianli@chromium.org [Fri, 10 Jun 2011 01:09:11 +0000 (01:09 +0000)]
Calling WebKitBlobBuilder.append with null argument should not crash
https://bugs.webkit.org/show_bug.cgi?id=62419

Reviewed by David Levin.

Source/WebCore:

Test: fast/files/blob-builder-crash.html

* fileapi/WebKitBlobBuilder.cpp:
(WebCore::WebKitBlobBuilder::append):

LayoutTests:

* fast/files/blob-builder-crash-expected.txt: Added.
* fast/files/blob-builder-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 James Kozianski <koz@chromium.org>
koz@chromium.org [Fri, 10 Jun 2011 01:08:15 +0000 (01:08 +0000)]
2011-06-09  James Kozianski  <koz@chromium.org>

        [Chromium] Unreviewed. Remove expectations for passing tests.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 10 Jun 2011 00:50:00 +0000 (00:50 +0000)]
2011-06-09  James Robinson  <jamesr@chromium.org>

        [chromium] Update some chromium gpu baselines

        * platform/chromium-gpu-linux/compositing/direct-image-compositing-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/tall-page-composited-expected.png:
        * platform/chromium-gpu-linux/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-mac/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium-gpu-mac/platform/chromium/compositing/huge-layer-rotated-expected.png:
        * platform/chromium-gpu-win/compositing/direct-image-compositing-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/horizontal-scroll-composited-expected.png:
        * platform/chromium-gpu-win/compositing/geometry/vertical-scroll-composited-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 10 Jun 2011 00:30:25 +0000 (00:30 +0000)]
2011-06-09  James Robinson  <jamesr@chromium.org>

        [chromium] Mark the fullscreen directory as skipped
        https://bugs.webkit.org/show_bug.cgi?id=62397

        * platform/chromium/test_expectations.txt:
2011-06-09  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        [chromium] webkitRequestFullscreen exposed to web even when feature is disabled
        https://bugs.webkit.org/show_bug.cgi?id=62397

        Remove ENABLE_FULLSCREEN_API define from chromium builds since this exposes the webkitRequestFullscreen function
        even when the runtime setting was disabled.

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 62405 - Fix integer overflow in Array.prototype.push
barraclough@apple.com [Fri, 10 Jun 2011 00:30:21 +0000 (00:30 +0000)]
Bug 62405 - Fix integer overflow in Array.prototype.push

Reviewed by Geoff Garen.

Fix geoff's review comments re static_cast.

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Fri, 10 Jun 2011 00:03:18 +0000 (00:03 +0000)]
2011-06-09  Jer Noble  <jer.noble@apple.com>

        Reviewed by David Hyatt.

        Roll out r88468, and fix bug #61911 without making Element::offset functions virtual.
        https://bugs.webkit.org/show_bug.cgi?id=62400

        No new tests; covered by existing fullscreen/full-screen-video-offset.html test.

        * rendering/RenderVideo.cpp:
        (WebCore::rendererPlaceholder): Added; returns the placeholder block, if it exists.
        (WebCore::RenderVideo::offsetLeft): Pass the offset request to the placeholder block.
        (WebCore::RenderVideo::offsetTop): Ditto.
        (WebCore::RenderVideo::offsetWidth): Ditto.
        (WebCore::RenderVideo::offsetHeight): Ditto.
        * rendering/RenderVideo.h: Added virtual overrides for the offset functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 10 Jun 2011 00:02:23 +0000 (00:02 +0000)]
2011-06-09  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Factored MarkedBlock set management into a helper class with a fast case Bloom filter
        https://bugs.webkit.org/show_bug.cgi?id=62413

        SunSpider reports a small speedup.

        This is in preparation for having ConservativeSet operate on arbitrary
        sets of MarkedBlocks, and in preparation for conservative scanning
        becoming proportionally more important than other GC activities.

        * GNUmakefile.list.am:
        * JavaScriptCore.gypi:
        * JavaScriptCore.xcodeproj/project.pbxproj: Build-o.

        * heap/ConservativeRoots.cpp:
        (JSC::ConservativeRoots::add):
        * heap/ConservativeRoots.h:
        (JSC::ConservativeRoots::ConservativeRoots): Operate on a MarkedBlockSet
        directly, instead of a Heap, so we can operate on subsets of the Heap
        instead.

        Use a TinyBloomFilter for single-cycle exclusion of most pointers. This
        is particularly important since we expect not to find our subject pointer
        in the MarkedBlock hash, and hash misses are more expensive than typical
        hash lookups because they have high collision rates.

        No need for single-pointer add() to be public anymore, since nobody uses it.

        * heap/Heap.cpp:
        (JSC::Heap::markRoots):
        * heap/Heap.h:
        (JSC::Heap::forEachCell):
        (JSC::Heap::forEachBlock): Use MarkedBlockSet since that's what
        ConservativeRoots relies on.

        Nixed contains(), since nobody uses it anymore.

        * heap/MarkedBlock.h:
        (WTF::MarkedBlockHash::hash): Added a faster hash taking advantage of
        the VM layout properties of MarkedBlocks.

        * heap/MarkedBlockSet.h: Added.
        (JSC::MarkedBlockSet::add):
        (JSC::MarkedBlockSet::remove):
        (JSC::MarkedBlockSet::recomputeFilter):
        (JSC::MarkedBlockSet::filter):
        (JSC::MarkedBlockSet::set):
        * heap/TinyBloomFilter.h: Added.
        (JSC::TinyBloomFilter::TinyBloomFilter):
        (JSC::TinyBloomFilter::add):
        (JSC::TinyBloomFilter::ruleOut): New helper class, used above.

        * interpreter/RegisterFile.cpp:
        (JSC::RegisterFile::gatherConservativeRoots): No need to specifically
        exclude values by tag -- the tiny bloom filter is already a register-register
        compare, so adding another "rule out" factor just slows things down.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 62405 - Fix integer overflow in Array.prototype.push
barraclough@apple.com [Thu, 9 Jun 2011 23:46:54 +0000 (23:46 +0000)]
Bug 62405 - Fix integer overflow in Array.prototype.push

Reviewed by Oliver Hunt.

There are three integer overflows here, leading to safe (not a security risk)
but incorrect (non-spec-compliant) behaviour.

Two overflows occur when calculating the new length after pushing (one in the
fast version of push in JSArray, one in the generic version in ArrayPrototype).
The other occurs calculating indices to write to when multiple items are pushed.

These errors result in three test-262 failures.

Source/JavaScriptCore:

* runtime/ArrayPrototype.cpp:
(JSC::arrayProtoFuncPush):
* runtime/JSArray.cpp:
(JSC::JSArray::put):
(JSC::JSArray::push):

LayoutTests:

* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A3-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T2-expected.txt:
* sputnik/Conformance/15_Native_Objects/15.4_Array/15.4.4/15.4.4.7_Array_prototype_push/S15.4.4.7_A4_T3-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 9 Jun 2011 23:33:49 +0000 (23:33 +0000)]
2011-06-09  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
        https://bugs.webkit.org/show_bug.cgi?id=55603

        * platform/gtk/Skipped: Unskip a test that is now passing. Better describe remaining failures.
2011-06-09  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
        https://bugs.webkit.org/show_bug.cgi?id=55603

        Added DumpRenderTreeSupport methods to support hasMarkedText and markedRange.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::setComposition): Use start and length rather than start and
        end. This matches other ports. Only use GLib style early returns when checking the
        validity of GObjects.
        (DumpRenderTreeSupportGtk::hasComposition):  Added.
        (DumpRenderTreeSupportGtk::compositionRange): Added.
        (DumpRenderTreeSupportGtk::confirmComposition): Cleanup as described above.
        (DumpRenderTreeSupportGtk::firstRectForCharacterRange): Cleanup as described above.
        (DumpRenderTreeSupportGtk::selectedRange): Cleanup as described above.
        * WebCoreSupport/DumpRenderTreeSupportGtk.h: Added new declarations.
2011-06-09  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        [GTK] Implement the next bit of the TextInputController (hasMarkedText and markedRange)
        https://bugs.webkit.org/show_bug.cgi?id=55603

        Add callbacks to support hasMarkedText and markedRange and also clean up existing
        TextInputController support.

        * DumpRenderTree/gtk/TextInputController.cpp:
        (setMarkedTextCallback): Accept parameters in terms of start and length, instead
        of start and end. This matches the other ports. Do not use GLib style early returns.
        (hasMarkedTextCallback): Added.
        (markedRangeCallback): Added.
        (insertTextCallback): Cleanup as described above.
        (unmarkTextCallback): Cleanup as described above.
        (firstRectForCharacterRangeCallback): Cleanup as described above.
        (selectedRangeCallback): Cleanup as described above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 9 Jun 2011 23:04:51 +0000 (23:04 +0000)]
2011-06-09  Kenneth Russell  <kbr@google.com>

        Skipped new tests from r88489 on WebKit Win, since WebGL is not yet enabled.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 James Robinson <jamesr@chromium.org>
commit-queue@webkit.org [Thu, 9 Jun 2011 22:53:53 +0000 (22:53 +0000)]
2011-06-09  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Scissor rect not set for clipping layers set offscreen
        https://bugs.webkit.org/show_bug.cgi?id=62339

        Tests that a layer that should clip its children actually does clip even when scrolled offscreen.

        * platform/chromium/compositing/scissor-out-of-viewport-expected.png: Added.
        * platform/chromium/compositing/scissor-out-of-viewport-expected.txt: Added.
        * platform/chromium/compositing/scissor-out-of-viewport.html: Added.
2011-06-09  James Robinson  <jamesr@chromium.org>

        Reviewed by Kenneth Russell.

        [chromium] Scissor rect not set for clipping layers set offscreen
        https://bugs.webkit.org/show_bug.cgi?id=62339

        We set a scissorRect on each layer, but only layers with masksToBounds and their descendants should actually set
        a scissor.  Layers that didn't need to scissor had empty scissorRects.  Unfortunately layers with masksToBounds
        and their descendants that are scrolled offscreen also end up with an empty clipped scissor rect.

        This patch sets an explicit bit on each layer that should scissor and then checks that bit instead of checking
        for an empty scissor rect at draw time.  RenderSurfaceChromiums have different requirements for
        setScissorToRect, so the old behavior is still available with a flag.  This can probably be cleaned up more.

        Test: platform/chromium/compositing/scissor-out-of-viewport.html

        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::updatePropertiesAndRenderSurfaces):
        (WebCore::LayerRendererChromium::drawLayer):
        (WebCore::LayerRendererChromium::setScissorToRect):
        * platform/graphics/chromium/LayerRendererChromium.h:
        * platform/graphics/chromium/RenderSurfaceChromium.cpp:
        (WebCore::RenderSurfaceChromium::draw):
        * platform/graphics/chromium/cc/CCLayerImpl.cpp:
        (WebCore::CCLayerImpl::CCLayerImpl):
        * platform/graphics/chromium/cc/CCLayerImpl.h:
        (WebCore::CCLayerImpl::setUsesLayerScissor):
        (WebCore::CCLayerImpl::usesLayerScissor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 9 Jun 2011 22:53:32 +0000 (22:53 +0000)]
2011-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r88486.
        http://trac.webkit.org/changeset/88486
        https://bugs.webkit.org/show_bug.cgi?id=62409

        Broke chromium-win compile (Requested by jamesr on #webkit).

        * public/WebData.h:
        * public/WebPageSerializer.h:
        * src/WebData.cpp:
        * src/WebPageSerializer.cpp:
        (WebKit::WebPageSerializer::serialize):
        (WebKit::WebPageSerializer::serializeToMHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 9 Jun 2011 22:23:23 +0000 (22:23 +0000)]
2011-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r88468.
        http://trac.webkit.org/changeset/88468
        https://bugs.webkit.org/show_bug.cgi?id=62408

        It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
        on #webkit).

        * fullscreen/full-screen-video-offset-expected.txt: Removed.
        * fullscreen/full-screen-video-offset.html: Removed.
2011-06-09  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r88468.
        http://trac.webkit.org/changeset/88468
        https://bugs.webkit.org/show_bug.cgi?id=62408

        It broke build if !ENABLE(FULLSCREEN_API) (Requested by Ossy
        on #webkit).

        * dom/Element.cpp:
        (WebCore::adjustForLocalZoom):
        * dom/Element.h:
        * html/HTMLMediaElement.cpp:
        * html/HTMLMediaElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 9 Jun 2011 22:02:22 +0000 (22:02 +0000)]
2011-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Adam Barth.

        Disallow use of cross-domain media (images, video) in WebGL
        https://bugs.webkit.org/show_bug.cgi?id=62257

        Updated WebGL implementation to track recent spec updates in this area.

        Tests: http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html
               http/tests/security/webgl-remote-read-remote-image-allowed.html
               http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html

        * html/canvas/CanvasRenderingContext.cpp:
        (WebCore::CanvasRenderingContext::wouldTaintOrigin):
        (WebCore::CanvasRenderingContext::checkOrigin):
        * html/canvas/CanvasRenderingContext.h:
        (WebCore::CanvasRenderingContext::checkOrigin):
        * html/canvas/WebGLRenderingContext.cpp:
        (WebCore::WebGLRenderingContext::readPixels):
        (WebCore::WebGLRenderingContext::texImage2D):
        (WebCore::WebGLRenderingContext::videoFrameToImage):
        (WebCore::WebGLRenderingContext::texSubImage2D):
        * html/canvas/WebGLRenderingContext.h:
2011-06-09  Kenneth Russell  <kbr@google.com>

        Reviewed by Adam Barth.

        Disallow use of cross-domain media (images, video) in WebGL
        https://bugs.webkit.org/show_bug.cgi?id=62257

        Updated origin-clean-conformance.html to track upstream version in
        Khronos repository. Added new layout tests mirroring those added
        in bug 61015 which verify that new CORS support for images is
        working in the context of WebGL.

        Verified new tests in WebKit and Chromium. Skipped tests on
        platforms where WebGL is disabled.

        * http/tests/canvas/webgl/origin-clean-conformance-expected.txt:
        * http/tests/canvas/webgl/origin-clean-conformance.html:
        * http/tests/security/webgl-remote-read-remote-image-allowed-expected.txt: Added.
        * http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials-expected.txt: Added.
        * http/tests/security/webgl-remote-read-remote-image-allowed-with-credentials.html: Added.
        * http/tests/security/webgl-remote-read-remote-image-allowed.html: Added.
        * http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin-expected.txt: Added.
        * http/tests/security/webgl-remote-read-remote-image-blocked-no-crossorigin.html: Added.
        * platform/gtk/Skipped:
        * platform/mac-leopard/Skipped:
        * platform/mac-wk2/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 9 Jun 2011 21:55:24 +0000 (21:55 +0000)]
2011-06-09  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add an ASSERT to HTMLTreeBuilder
        https://bugs.webkit.org/show_bug.cgi?id=62403

        This ASSERT was useful in investigating a re-entrancy bug.  We should
        keep it.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processEndOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a regression from r88478.
mitz@apple.com [Thu, 9 Jun 2011 21:48:35 +0000 (21:48 +0000)]
Fix a regression from r88478.

Reviewed by Darin Adler.

* platform/graphics/mac/ComplexTextControllerCoreText.cpp:
(WebCore::ComplexTextController::collectComplexTextRunsForCharactersCoreText): Add the runs
in reverse order in the RTL case here, since the whole vector is reversed by collectComplexTextRuns()
afterwards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Thu, 9 Jun 2011 21:45:18 +0000 (21:45 +0000)]
2011-06-09  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by Darin Fisher.

        Page serializer APIs now use WebData instead of fetching the entire
        resource contents.
        https://bugs.webkit.org/show_bug.cgi?id=61908

        * public/WebData.h:
        * public/WebPageSerializer.h:
        * src/WebData.cpp:
        (WebKit::WebData::getSomeData):
        * src/WebPageSerializer.cpp:
        (WebKit::WebPageSerializer::serialize):
        (WebKit::WebPageSerializer::serializeToMHTML):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 9 Jun 2011 21:24:23 +0000 (21:24 +0000)]
2011-06-09  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Mark tests failing after http://trac.webkit.org/changeset/88478/ as failing.

        * platform/chromium/test_expectations.txt: Added failing tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 9 Jun 2011 21:18:59 +0000 (21:18 +0000)]
2011-06-09  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        nrwt: support webaudio in chromium driver
        https://bugs.webkit.org/show_bug.cgi?id=62226

        * Scripts/webkitpy/layout_tests/port/chromium.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 9 Jun 2011 21:11:47 +0000 (21:11 +0000)]
2011-06-09  Dimitri Glazkov  <dglazkov@chromium.org>

        [Chromium] Update expectations.

        * platform/chromium-linux/plugins/mouse-events-expected.txt: Added.
        * platform/chromium-win/fullscreen/full-screen-video-offset-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Thu, 9 Jun 2011 20:53:58 +0000 (20:53 +0000)]
2011-06-09  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by James Robinson.

        Web Inspector: Inspector layout tests - extract method for sending XHR
        https://bugs.webkit.org/show_bug.cgi?id=62391

        * http/tests/inspector/console-xhr-logging.html:
        * http/tests/inspector/network-test.js:
        (doXHR.xhr.onreadystatechange):
        (doXHR):
        * http/tests/inspector/network/network-size-sync.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Julien Chaffraix <jchaffraix@codeaurora.org>
commit-queue@webkit.org [Thu, 9 Jun 2011 20:33:20 +0000 (20:33 +0000)]
2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Antti Koivisto.

        REGRESSION(84329): Stylesheets on some pages do not load
        https://bugs.webkit.org/show_bug.cgi?id=61400

        Adding test to cover the regression. The test actually uncovered
        a bug in the way we handle alternate stylesheet and thus is
        failing some parts.

        * fast/css/link-disabled-attr-expected.txt: Added.
        * fast/css/link-disabled-attr.html: Added.
2011-06-09  Julien Chaffraix  <jchaffraix@codeaurora.org>

        Reviewed by Antti Koivisto.

        REGRESSION(84329): Stylesheets on some pages do not load
        https://bugs.webkit.org/show_bug.cgi?id=61400

        Test: fast/css/link-disabled-attr.html

        Fixed r84329: the change did not take into account the fact
        that HTMLLinkElement did already contain the disabled information
        and the 2 information were not linked as they should have!

        The new logic pushes the information to the stylesheet as this
        is what the spec mandates and what FF is doing. Also it keeps
        one bit of information (that JS enabled the stylesheet) as it
        is needed for the recalcStyleSelector logic.

        * dom/Document.cpp:
        (WebCore::Document::recalcStyleSelector): s/isDisabled/disabled.

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::HTMLLinkElement): Removed m_disabledState,
        replaced by m_isEnabledViaScript.
        (WebCore::HTMLLinkElement::setDisabled): Updated the logic after
        m_disabledState removal. It also matches the spec by forwarding
        the disabled state to our stylesheet if we have one.
        (WebCore::HTMLLinkElement::parseMappedAttribute): Removed harmful
        handling of the disabledAttr.
        (WebCore::HTMLLinkElement::process): Updated after m_disabledState removal.
        * html/HTMLLinkElement.h:
        (WebCore::HTMLLinkElement::isEnabledViaScript): Ditto.
        (WebCore::HTMLLinkElement::isAlternate): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSimplify ComplexTextController::collectComplexTextRuns()
mitz@apple.com [Thu, 9 Jun 2011 20:30:39 +0000 (20:30 +0000)]
Simplify ComplexTextController::collectComplexTextRuns()
https://bugs.webkit.org/show_bug.cgi?id=62387

Reviewed by Darin Adler.

No new test, since functionality is unchanged.

* platform/graphics/mac/ComplexTextController.cpp:
(WebCore::ComplexTextController::collectComplexTextRuns): Always iterate characters in logical order,
then reverse the run vector for RTL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSource/JavaScriptCore: Add Vector::reverse()
mitz@apple.com [Thu, 9 Jun 2011 20:29:02 +0000 (20:29 +0000)]
Source/JavaScriptCore: Add Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393

Reviewed by Anders Carlsson.

* wtf/Vector.h:
(WTF::Vector::reverse): Added

Tools: Added a test for Vector::reverse()
https://bugs.webkit.org/show_bug.cgi?id=62393

Reviewed by Anders Carlsson.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WTF/VectorReverse.cpp: Added.
(TestWebKitAPI::TEST):
* TestWebKitAPI/win/TestWebKitAPI.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-06-09 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 9 Jun 2011 20:24:59 +0000 (20:24 +0000)]
2011-06-09  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        Fold isShadowBoundary into isShadowRoot.
        https://bugs.webkit.org/show_bug.cgi?id=62317

        Since there are no longer cases where Node::isShadowBoundary() != Node::isShadowRoot, we can remove this function.

        In one case where isShadowBoundary was also tested to find ShadowContentElemnt, added a new isContentElement function.

        Refactoring, covered by existing tests.

        * css/CSSStyleSelector.cpp:
        (WebCore::isAtShadowBoundary): Changed to use isShadowRoot.
        * dom/Element.cpp:
        (WebCore::Element::isSpellCheckingEnabled): Ditto.
        * dom/Node.cpp:
        (WebCore::Node::nonBoundaryShadowTreeRootNode): Ditto.
        (WebCore::Node::nonShadowBoundaryParentNode): Ditto.
        * dom/Node.h:
        (WebCore::Node::isContentElement): Added.
        * dom/NodeRenderingContext.cpp:
        (WebCore::NodeRenderingContext::NodeRenderingContext): Changed to use isShadowRoot.
        * dom/Position.cpp:
        (WebCore::Position::Position): Ditto.
        * dom/ShadowContentElement.h:
        (WebCore::ShadowContentElement::isContentElement): Added.
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::hasContentElement): Changed to use isContentElement.
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAfter): Changed to use isShadowRoot.
        * editing/htmlediting.cpp:
        (WebCore::visiblePositionBeforeNode): Ditto.
        (WebCore::visiblePositionAfterNode): Ditto.
        * page/DragController.cpp:
        (WebCore::asFileInput): Ditto.
        * rendering/RenderTreeAsText.cpp:
        (WebCore::nodePosition): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@88476 268f45cc-cd09-0410-ab3c-d52691b4dbfc