WebKit-https.git
14 years ago2006-10-05 Mark Rowe <bdash@webkit.org>
bdash [Wed, 4 Oct 2006 22:25:28 +0000 (22:25 +0000)]
2006-10-05  Mark Rowe  <bdash@webkit.org>

        Reviewed by maculloch.

        Gdk build fix.

        * JavaScriptCoreSources.bkl: Add DateMath.cpp to file list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by aroben
kmccullo [Wed, 4 Oct 2006 21:27:29 +0000 (21:27 +0000)]
    Reviewed by aroben

        - build fix

        * JavaScriptCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-04 Nikolas Zimmermann <zimmermann@kde.org>
bdash [Wed, 4 Oct 2006 21:11:10 +0000 (21:11 +0000)]
2006-10-04  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Mitz.

        Fix Qt/Linux build by adding DateMath.cpp to compilation.

        * CMakeLists.txt: Also replace tabs with spaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by DethBakin.
kmccullo [Wed, 4 Oct 2006 21:08:43 +0000 (21:08 +0000)]
    Reviewed by DethBakin.

        - Apparently the build bot uses an older version of XCode which warns about conversions and the newest version does not.  I hope this fixes the build but I cann't be sure on my system.

        * kjs/DateMath.cpp:
        (KJS::msToYear):
        (KJS::dayInYear):
        (KJS::dateToDayInYear):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Mitz Pettel!
thatcher [Wed, 4 Oct 2006 20:44:29 +0000 (20:44 +0000)]
    Reviewed by Mitz Pettel!

        Bug 10708: [Drosera] Make the console input plaintext-only
        http://bugs.webkit.org/show_bug.cgi?id=10708

        Change the console input -webkit-user-modify property to
        read-write-plaintext-only.

        * Drosera/console.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim H.
thatcher [Wed, 4 Oct 2006 20:37:02 +0000 (20:37 +0000)]
    Reviewed by Tim H.

        Bug 10473: [Drosera] Overlapping text in JavaScript Console
        http://bugs.webkit.org/show_bug.cgi?id=10473

        Using min-height instead of height to avoid overlapping text.

        * ChangeLog:
        * Drosera/console.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
kmccullo [Wed, 4 Oct 2006 20:35:58 +0000 (20:35 +0000)]
    Reviewed by Adam.

        * wtf/Assertions.cpp: Changed assertion formatting to omit the "======"
        lines so you can see more assertions in less space. Also improved format
        of file/line information so it works with more development environments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
darin [Wed, 4 Oct 2006 20:34:21 +0000 (20:34 +0000)]
    Reviewed by Adam.

        * wtf/Assertions.cpp: Changed assertion formatting to omit the "======"
        lines so you can see more assertions in less space. Also improved format
        of file/line information so it works with more development environments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim H.
thatcher [Wed, 4 Oct 2006 18:37:48 +0000 (18:37 +0000)]
    Reviewed by Tim H.

        Added a bash-style command history.

        * Drosera/console.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by GGaren
kmccullo [Wed, 4 Oct 2006 18:36:29 +0000 (18:36 +0000)]
    Reviewed by GGaren

        - This is a big makeover for our Date implemenetation.  This solves many platform specific issues, specifically dates before 1970, and simplifies some ugly code.  The purpose of this was to get us to pass many of the JavaScriptCore tests on windows.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * kjs/DateMath.cpp: Added.
        (KJS::):
        (KJS::daysInYear):
        (KJS::daysFrom1970ToYear):
        (KJS::msFrom1970ToYear):
        (KJS::msToDays):
        (KJS::msToYear):
        (KJS::isLeapYear):
        (KJS::isInLeapYear):
        (KJS::dayInYear):
        (KJS::msToMilliseconds):
        (KJS::msToWeekDay):
        (KJS::msToSeconds):
        (KJS::msToMinutes):
        (KJS::msToHours):
        (KJS::msToMonth):
        (KJS::msToDayInMonth):
        (KJS::monthToDayInYear):
        (KJS::timeToMseconds):
        (KJS::dateToDayInYear):
        (KJS::equivalentYearForDST):
        (KJS::getUTCOffset):
        (KJS::getDSTOffsetSimple):
        (KJS::getDSTOffset):
        (KJS::localTimeToUTC):
        (KJS::UTCToLocalTime):
        (KJS::dateToMseconds):
        (KJS::msToTM):
        (KJS::isDST):
        * kjs/DateMath.h: Added.
        (KJS::):
        * kjs/date_object.cpp:
        (KJS::gmtoffset):
        (KJS::formatTime):
        (KJS::DateInstance::getTime):
        (KJS::DateInstance::getUTCTime):
        (KJS::DateProtoFunc::callAsFunction):
        (KJS::DateObjectImp::construct):
        (KJS::DateObjectFuncImp::callAsFunction):
        (KJS::parseDate):
        * kjs/testkjs.cpp:
        * os-win32/stdint.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-04 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 4 Oct 2006 18:04:16 +0000 (18:04 +0000)]
2006-10-04  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by John Sullivan.

        <rdar://problem/4654328>
        Safari Crashes in WebCore::PluginTokenizer::writeRawData If I Try to Open a SWF File With Plug-ins Turned Off

        * loader/PluginDocument.cpp:
        (WebCore::PluginTokenizer::writeRawData):
        Only send the data to the plug-in if plug-ins are enabled, otherwise just silently eat it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Gdk bustage.
hyatt [Wed, 4 Oct 2006 08:43:29 +0000 (08:43 +0000)]
Fix Gdk bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Gdk bustage.
hyatt [Wed, 4 Oct 2006 08:39:10 +0000 (08:39 +0000)]
Fix Gdk bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix more win32 and qt bustage.
hyatt [Wed, 4 Oct 2006 08:26:17 +0000 (08:26 +0000)]
Fix more win32 and qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix more win32 bustage.
hyatt [Wed, 4 Oct 2006 08:21:56 +0000 (08:21 +0000)]
Fix more win32 bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix more win32 bustage.
hyatt [Wed, 4 Oct 2006 08:19:16 +0000 (08:19 +0000)]
Fix more win32 bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Gdk bustage.
hyatt [Wed, 4 Oct 2006 08:11:56 +0000 (08:11 +0000)]
Fix Gdk bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt bustage.
hyatt [Wed, 4 Oct 2006 08:10:55 +0000 (08:10 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Gdk bustage.
hyatt [Wed, 4 Oct 2006 08:09:50 +0000 (08:09 +0000)]
Fix Gdk bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Qt bustage.
hyatt [Wed, 4 Oct 2006 08:06:57 +0000 (08:06 +0000)]
Fix Qt bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16770 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Win32 bustage.
hyatt [Wed, 4 Oct 2006 08:05:57 +0000 (08:05 +0000)]
Fix Win32 bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Win32 bustage.
hyatt [Wed, 4 Oct 2006 07:53:55 +0000 (07:53 +0000)]
Fix Win32 bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix Win32 bustage.
hyatt [Wed, 4 Oct 2006 07:52:09 +0000 (07:52 +0000)]
Fix Win32 bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix mac build bustage.
hyatt [Wed, 4 Oct 2006 04:45:28 +0000 (04:45 +0000)]
Fix mac build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim H.
ap [Wed, 4 Oct 2006 04:34:45 +0000 (04:34 +0000)]
    Reviewed by Tim H.

        http://bugs.webkit.org/show_bug.cgi?id=11130
        Convert "undefined" to AE missing value

WebCore:
        * bridge/mac/WebCoreFrameBridge.mm:
        (aeDescFromJSValue): return missing value for UndefinedType.

LayoutTests:
        * fast/AppleScript/001-expected.txt:
        * fast/AppleScript/array-expected.txt:
        Updated the results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoScrolling work.
hyatt [Wed, 4 Oct 2006 04:22:10 +0000 (04:22 +0000)]
Scrolling work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-04 Mark Rowe <bdash@webkit.org>
bdash [Wed, 4 Oct 2006 03:36:10 +0000 (03:36 +0000)]
2006-10-04  Mark Rowe  <bdash@webkit.org>

        Reviewed by NOBODY (build fix).

        * WebView/WebView.m:
        (-[WebView scrollDOMRangeToVisible:]): Move scrollDOMRangeToVisible: into the correct category.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoUpdate bug URLs in the two patches that I just landed.
bdash [Wed, 4 Oct 2006 02:51:10 +0000 (02:51 +0000)]
Update bug URLs in the two patches that I just landed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-09-26 David Smith <catfish.man@gmail.com>
bdash [Wed, 4 Oct 2006 02:46:19 +0000 (02:46 +0000)]
2006-09-26  David Smith  <catfish.man@gmail.com>

        Reviewed by Timothy.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
        Add -scrollDOMRangeToVisible:

        No automated tests are possible as this code path isn't reachable from JavaScript.

        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge scrollDOMRangeToVisible:]):

2006-09-26  David Smith  <catfish.man@gmail.com>

        Reviewed by Timothy.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=3723
        Add -scrollDOMRangeToVisible:

        * WebView/WebView.m:
        (-[WebView scrollDOMRangeToVisible:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-03 Graham Dennis <graham.dennis@gmail.com>
bdash [Wed, 4 Oct 2006 02:31:10 +0000 (02:31 +0000)]
2006-10-03  Graham Dennis  <graham.dennis@gmail.com>

        Reviewed by Timothy.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
        When contentEditable, cursor doesn't change to hand

        Allow the behaviour of editable links to be specified by a WebPreference
        The preference WebKitEditableLinkBehavior has four options:
         - AlwaysLive: Safari 2.0 behaviour
         - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
         - LiveWhenNotFocused: Editable links are live only when their editable block is not
             focused, or when the shift key is pressed
         - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.

        No layout tests, just a modification of a manual-test as it isn't possible to test
        this automatically.

        * bridge/mac/WebCoreSettings.h:
        * bridge/mac/WebCoreSettings.mm:
        (-[WebCoreSettings setEditableLinkBehavior:]):
        (-[WebCoreSettings editableLinkBehavior]):
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::HTMLAnchorElement):
        (WebCore::HTMLAnchorElement::defaultEventHandler):
        (WebCore::HTMLAnchorElement::setActive):
        * html/HTMLAnchorElement.h:
        * manual-tests/contenteditable-link.html:
        * page/FrameView.cpp:
        (WebCore::nodeIsNotBeingEdited):
        (WebCore::selectCursor):
        * page/Settings.h:
        (WebCore::Settings::):
        (WebCore::Settings::Settings):
        (WebCore::Settings::editableLinkBehavior):
        (WebCore::Settings::setEditableLinkBehavior):

2006-10-03  Graham Dennis  <graham.dennis@gmail.com>

        Reviewed by Timothy.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=10338>
        When contentEditable, cursor doesn't change to hand

        Allow the behaviour of editable links to be specified by a WebPreference
        The preference WebKitEditableLinkBehavior has four options:
         - AlwaysLive: Safari 2.0 behaviour
         - OnlyLiveWithShiftKey: Firefox/WinIE behaviour (and prior WebKit-ToT behaviour)
         - LiveWhenNotFocused: Editable links are live only when their editable block is not
             focused, or when the shift key is pressed
         - DefaultBehavior: This is the same as OnlyLiveWithShiftKey.

        No layout tests, just a modification of a manual-test as it isn't possible to test
        this automatically.

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):
        (-[WebPreferences editableLinkBehavior]):
        (-[WebPreferences setEditableLinkBehavior:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.m:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed Darin.
bdakin [Wed, 4 Oct 2006 01:12:17 +0000 (01:12 +0000)]
    Reviewed Darin.

        No test cases needed.

        Implemented a version of StringImpl::append that takes a UChar* and
        a length.

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::append):
        (WebCore::StringImpl::insert): Call new append instead of making a
        new StringImpl.
        * platform/StringImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-03 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 4 Oct 2006 01:10:26 +0000 (01:10 +0000)]
2006-10-03  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Adam and Brady.

        * DumpRenderTree/DumpRenderTree.m:
        (main):
        Update URL to Ahem.ttf

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-03 MorganL <morganl.webkit@yahoo.com>
bdash [Wed, 4 Oct 2006 01:09:33 +0000 (01:09 +0000)]
2006-10-03  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Darin.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=11099
        HttpSendRequestEx results in ERROR_HTTP_HEADER_NOT_FOUND

        * platform/win/ResourceLoaderWin.cpp:
        (WebCore::ResourceLoader::onHandleCreated):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 3 Oct 2006 23:28:49 +0000 (23:28 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/execCommand/paste-1-expected.checksum: Added.
        * editing/execCommand/paste-1-expected.png: Added.
        * editing/execCommand/paste-1-expected.txt: Added.
        * editing/execCommand/paste-1.html: Added.
        * editing/execCommand/paste-2-expected.checksum: Added.
        * editing/execCommand/paste-2-expected.png: Added.
        * editing/execCommand/paste-2-expected.txt: Added.
        * editing/execCommand/paste-2.html: Added.

WebKit:

        Reviewed by harrison

        execCommand("Cut"/"Copy"/"Paste") broken in editable subframes.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge issueCutCommand]): Issue the command on the WebHTMLView, not the WebView.
        (-[WebFrameBridge issueCopyCommand]): Ditto.
        (-[WebFrameBridge issuePasteCommand]): Ditto.
        (-[WebFrameBridge issuePasteAndMatchStyleCommand]): Ditto.
        (-[WebFrameBridge issueTransposeCommand]): Fixed formatting.
        (-[WebFrameBridge canPaste]): Ask the WebHTMLView, not the WebView.
        * WebView/WebHTMLView.m:
        (-[WebHTMLView copy:]): Moved to WebInternal
        (-[WebHTMLView cut:]): Ditto.
        (-[WebHTMLView paste:]): Ditto.
        (-[WebHTMLView pasteAsPlainText:]): Ditto.
        * WebView/WebHTMLViewInternal.h:
        * WebView/WebView.m: Removed the now unused _canPaste.
        * WebView/WebViewInternal.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
bdakin [Tue, 3 Oct 2006 23:19:50 +0000 (23:19 +0000)]
    Reviewed by Geoff.

        Changing these two counters tests so they pass on the BuildBot.

        * fast/css/counters/counter04-expected.checksum:
        * fast/css/counters/counter04-expected.png:
        * fast/css/counters/counter04-expected.txt:
        * fast/css/counters/counter04.html:
        * fast/css/counters/counters04-expected.checksum:
        * fast/css/counters/counters04-expected.png:
        * fast/css/counters/counters04-expected.txt:
        * fast/css/counters/counters04.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by geoff
justing [Tue, 3 Oct 2006 23:00:40 +0000 (23:00 +0000)]
    Reviewed by geoff

        Fixed a typo, updating expected results.

        * editing/execCommand/create-list-with-hr-expected.checksum:
        * editing/execCommand/create-list-with-hr-expected.png:
        * editing/execCommand/create-list-with-hr-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Feared, loathed, reviewed by Darin.
ggaren [Tue, 3 Oct 2006 23:00:20 +0000 (23:00 +0000)]
    Feared, loathed, reviewed by Darin.

        More frame/iframe merging. Merged IFRAME::willRemove and IFRAME::detach
        into FRAME, plus other cleanup.

        No new behavior, so no new test. Layout tests pass. Basic browsing and
        Mail editing seem to work.

        * dom/Node.cpp:
        (WebCore::Node::detach): Removed random commented-out code.
        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::isURLAllowed):
        (1) Removed reference to FrameView, to dissociate frame loading from rendering.
        (2) Renamed newURL to completeURL because the difference between newURL
        and URLString is that newURL is a KURL that is the complete version of URLString,
        not that it is new.
        (WebCore::HTMLFrameElement::willRemove):
        (1) Removed close() call and moved close() code into willRemove(), also removing
        close() call from detach(), since willRemove is the well-defined place
        from DOM tear-down, not detach().
        (2) Removed manual renderer detach code because the DOM is not responsible
        for managing the render tree. I confirmed that this change not
        regress <rdar://problem/4132581>.
        (3) Removed questionable ASSERT. The ASSERT assumed that iframe elements
        lost their content frames after being removed from the DOM. That's our
        current behavior, but it's going to change in future rounds of refactoring.
        This also fixes <rdar://problem/4750835>.
        (WebCore::HTMLFrameElement::setLocation): Removed wacky manual calls to
        attach/detach, because the render tree should not be in charge of deciding
        when to load.
        * html/HTMLFrameElement.h:
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::attach): Renamed renderPart to renderPartObject,
        because the renderer is a renderPartObject, not a renderPart.
        * html/HTMLIFrameElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Scripts/commit-log-editor: Added missing "close" call. Oops!
darin [Tue, 3 Oct 2006 22:46:08 +0000 (22:46 +0000)]
    * Scripts/commit-log-editor: Added missing "close" call. Oops!

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-03 Mark Rowe <bdash@webkit.org>
bdash [Tue, 3 Oct 2006 22:14:54 +0000 (22:14 +0000)]
2006-10-03  Mark Rowe  <bdash@webkit.org>

        Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=11137
        Bug 11137: GdkLauncher dies with "pure virtual method called" if
        window is closed while page still loading

        * platform/gdk/FrameGdk.cpp:
        (WebCore::FrameGdk::~FrameGdk): Call cancelAndClear to allow virtual
        methods to be called before the FrameGdk portion of "this" is torn down.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by geoff
justing [Tue, 3 Oct 2006 21:53:37 +0000 (21:53 +0000)]
    Reviewed by geoff

        <rdar://problem/4763519> REGRESSION: Multipart/x-mixed-replace sub-resources fail to load

        * Loader/WebSubresourceLoader.m:
        (+[WebSubresourceLoader startLoadingResource:withRequest:customHeaders:referrer:forFrameLoader:]):
        Enable multipart/x-mixed-replace support on the request.  This line was accidently removed during
        some loader refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
aroben [Tue, 3 Oct 2006 21:09:10 +0000 (21:09 +0000)]
    Reviewed by Darin.

        Handle tab key presses in the DOM.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::defaultEventHandler): Add tab key handling.
        * page/FrameView.cpp:
        (WebCore::FrameView::advanceFocus): Rename and reimplement
        focusNextPrevNode. Now we just call Element::focus().
        * page/FrameView.h: Rename focusNextPrevNode to advanceFocus and make
        it public.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by mjs
justing [Tue, 3 Oct 2006 19:01:33 +0000 (19:01 +0000)]
    Reviewed by mjs

        <rdar://problem/4760612>
        TOT REGRESSION: Repro assertion failure when forwarding draft in Range::compareBoundaryPoints

        No layout test possible, attributedStringFrom:(DOMNode*)...etc isn't available to DRT.

        * dom/Range.cpp:
        (WebCore::Range::boundaryPointsValid): compareBoundaryPoints asserts that the incoming
        positions are non-null since most of it's callers would be in a bad state if the positions
        were null.  boundaryPointsValid, which calls compareBoundaryPoints, is an exception.
        Instead of removing the assert I've added nil checks in boundaryPointsValid, to keep it
        from entering compareBoundaryPoints and hitting the assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
adele [Tue, 3 Oct 2006 18:55:19 +0000 (18:55 +0000)]
    Reviewed by Geoff.

        Make code for turning off new listbox implementation mac-only, since there's no implementation on other platforms.

        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::isKeyboardFocusable):
        (WebCore::HTMLSelectElement::isMouseFocusable):
        (WebCore::HTMLSelectElement::createRenderer):
        (WebCore::HTMLSelectElement::setRecalcListItems):
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        (WebCore::HTMLSelectElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-04 Darin Adler <darin@apple.com>
darin [Tue, 3 Oct 2006 18:18:08 +0000 (18:18 +0000)]
2006-10-04  Darin Adler  <darin@apple.com>

        Reviewed by Geoff.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11132
          Caret disappears when you're typing

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection): Remove unnecessary call to
        clearCaretRectIfNeeded. The recomputeCaretRect now takes care of this.
        (WebCore::SelectionController::recomputeCaretRect): Explicitly set m_needsLayout
        to false so we can get the old caret repaint rect. Later we need to change the
        design so getting the rect doesn't have a side effect of causing a layout without
        invalidation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
harrison [Tue, 3 Oct 2006 14:44:40 +0000 (14:44 +0000)]
LayoutTests:

        Reviewed by Maciej.

        <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

        Updated test so that it actually shows the caret rect for the caret position.
        Before, it was showing the caret rect for the 9th character of the test description.

        * fast/text/justified-text-rect-expected.checksum:
        * fast/text/justified-text-rect-expected.png:
        * fast/text/justified-text-rect-expected.txt:
        * fast/text/justified-text-rect.html:

WebCore:

        Reviewed by Maciej.

        <rdar://problem/4671286> Candidate Window isn't displayed and only first candidate is displayed at typing location.

        Updated test:
        * fast/text/justified-text-rect.html

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge convertToNSRange:]):
        (-[WebCoreFrameBridge convertToDOMRange:]):
        Make the selection's root editable element (or the document itself) be
        the basis for NSRange conversions. This supports "shadow DOM" like
        that for text fields and text areas.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs):
        Pass the document element as the scope.

        * editing/TextIterator.cpp:
        (WebCore::TextIterator::rangeFromLocationAndLength):
        Make the first parameter the scope.

        * editing/TextIterator.h:
        Make the first parameter of rangeFromLocationAndLength() the scope.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-03 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Tue, 3 Oct 2006 12:14:44 +0000 (12:14 +0000)]
2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Offer a way for BuildBot to not colorize the cmake output, when building
        with the 'build-webkit' script. Add "--color" / "--no-color" option pair.

        Default is colorize output, though only Qt platform handles this for now.

        * Scripts/build-dumprendertree:
        * Scripts/build-webkit:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-03 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Tue, 3 Oct 2006 10:49:35 +0000 (10:49 +0000)]
2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Make all important scripts work with Qt/Linux.

        You can safely use this now:
        set-configuration-release --debug && build-webkit && run-javascriptcore-tests && run-webkit-tests

        * Scripts/build-dumprendertree:
        * Scripts/run-javascriptcore-tests:
        * Scripts/run-webkit-tests:
        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-03 Nikolas Zimmermann <zimmermann@kde.org>
bdash [Tue, 3 Oct 2006 09:46:17 +0000 (09:46 +0000)]
2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric.

        build-webkit tweak: Use WebKitBuild/$config as output dir (Release/Debug).

        * Scripts/webkitdirs.pm:

2006-10-03  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric.

        Fix Qt/Linux build.

        * CMakeLists.txt: Add counter related files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-03 Mark Rowe <bdash@webkit.org>
bdash [Tue, 3 Oct 2006 09:42:33 +0000 (09:42 +0000)]
2006-10-03  Mark Rowe  <bdash@webkit.org>

        Reviewed by Eric.

        Stop Bakefile-generated Makefile from running `pkg-config' multiple times per file.

        * presets.bkl: Make use of "options" and Python commands to run pkg-config etc up front.

2006-10-03  Mark Rowe  <bdash@webkit.org>

        Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=10981
        Linux/GDK build fixes

        Based on a patch by Krzysztof Kowalczyk.

        * WebCoreSources.bkl:
        * platform/gdk/FrameGdk.cpp:
        (WebCore::doScroll):
        (WebCore::FrameGdk::handleGdkEvent):
        * platform/gdk/PlatformScrollBar.h: Added.
        (WebCore::PlatformScrollBar::isWidget):
        * platform/gdk/ScrollViewGdk.cpp:
        * platform/gdk/TemporaryLinkStubs.cpp:
        (FrameView::passMousePressEventToScrollbar):
        (FrameView::passMousePressEventToSubframe):
        (FrameView::passMouseReleaseEventToSubframe):
        (FrameView::passMouseMoveEventToSubframe):
        (FrameView::passWheelEventToSubframe):
        (Cursor::Cursor):
        (Widget::invalidate):
        (Widget::invalidateRect):
        (ScrollView::wheelEvent):
        (ScrollView::convertToContainingWindow):
        (ScrollView::convertFromContainingWindow):
        (GraphicsContext::clip):
        (PlatformScrollBar::PlatformScrollBar):
        (PlatformScrollBar::updateThumbPosition):
        (PlatformScrollBar::updateThumbProportion):
        (ScrollBar::ScrollBar):
        (ScrollBar::setProportion):
        (WebCore::supportedKeySizes):
        (WebCore::signedPublicKeyAndChallengeString):
        * platform/gdk/WheelEventGdk.cpp:
        (WebCore::PlatformWheelEvent::PlatformWheelEvent):
        * platform/gdk/WidgetGdk.cpp:
        (WebCore::Widget::convertToContainingWindow):
        (WebCore::Widget::convertFromContainingWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
aroben [Tue, 3 Oct 2006 04:38:39 +0000 (04:38 +0000)]
    Reviewed by Maciej.

        (Forgot this in previous checkin)

        Add message paramter to WebView::mouse* methods to pass down to
        PlatformMouseEvent.

        * COM/WebView.cpp:
        (WebView::mouseMoved):
        (WebView::mouseDown):
        (WebView::mouseUp):
        (WebView::mouseDoubleClick):
        (WebViewWndProc):
        * COM/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
aroben [Tue, 3 Oct 2006 04:26:59 +0000 (04:26 +0000)]
    Reviewed by Maciej.

        Let Windows determine which mouse button is pressed.

        * platform/PlatformMouseEvent.h: Add message parameter to constructor.
        * platform/win/MouseEventWin.cpp:
        (WebCore::PlatformMouseEvent::PlatformMouseEvent): Use message
        parameter to determine which mouse button is pressed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Alice.
mjs [Tue, 3 Oct 2006 02:00:41 +0000 (02:00 +0000)]
    Reviewed by Alice.

        - take away direct knowledge of WebFrame from WebDataSource

        * Loader/WebDocumentLoadState.h:
        * Loader/WebDocumentLoadState.m:
        (-[WebDocumentLoadState setFrameLoader:]):
        (-[WebDocumentLoadState detachFromFrameLoader]):
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader _setDocumentLoadState:]):
        (-[WebFrameLoader _setProvisionalDocumentLoadState:]):
        * WebView/WebDataSource.m:
        * WebView/WebDataSourceInternal.h:
        * WebView/WebDocumentLoadStateMac.m:
        (-[WebDocumentLoadStateMac detachFromFrameLoader]):
        * WebView/WebFrame.m:
        (-[WebFrame _loadDataSource:withLoadType:formState:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by anders
justing [Tue, 3 Oct 2006 01:38:21 +0000 (01:38 +0000)]
    Reviewed by anders

        Build fix

        * editing/SelectionController.cpp:
        (WebCore::SelectionController::empty):
        * editing/SelectionController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 3 Oct 2006 01:08:36 +0000 (01:08 +0000)]
LayoutTests:

        Reviewed by john

        * editing/execCommand/create-list-with-hr-expected.checksum: Added.
        * editing/execCommand/create-list-with-hr-expected.png: Added.
        * editing/execCommand/create-list-with-hr-expected.txt: Added.
        * editing/execCommand/create-list-with-hr.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/4755287>
        Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element

        * editing/markup.cpp:
        (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced
        elements).  Don't skip blocks that aren't containers (like horizontal rules).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-03 Darin Adler <darin@apple.com>
darin [Tue, 3 Oct 2006 01:06:57 +0000 (01:06 +0000)]
2006-10-03  Darin Adler  <darin@apple.com>

        Reviewed by Justin Garcia.

        - correct mistaken code that would restart blinking every
          time "invalidateSelection" is called even if the caret
          has not moved

        * editing/SelectionController.h:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection): Update for name change.
        (WebCore::SelectionController::recomputeCaretRect): New function.
        Computes caret rect and does any necessary invalidation if the rect
        changes.
        (WebCore::SelectionController::invalidateCaretRect): Renamed from
        needsCaretRepaint. Invalidates the caret rect unconditionally. Also
        calls recomputeCaretRect as a side effect.

        * page/Frame.cpp:
        (WebCore::Frame::invalidateSelection): Remove unneeded call to
        clearCaretRectIfNeeded.
        (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
        (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
        recomputeCaretRect function and not restart blinking if caret has
        not changed position.
        (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
        are not needed since selectionLayoutChanged already checks these.

        * page/FramePrivate.h: Removed unused m_blinkCaret.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adam.
bdakin [Tue, 3 Oct 2006 01:05:40 +0000 (01:05 +0000)]
    Reviewed by Adam.

        Build fix. Add counters to vcproj.

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Mon, 2 Oct 2006 23:54:02 +0000 (23:54 +0000)]
    Reviewed by Darin.

        - move a big slice of data and logic from WebDataSource to WebDocumentLoadState

        * Loader/WebDocumentLoadState.h:
        * Loader/WebDocumentLoadState.m:
        (-[WebDocumentLoadState initWithRequest:]):
        (-[WebDocumentLoadState dealloc]):
        (-[WebDocumentLoadState originalRequestCopy]):
        (-[WebDocumentLoadState request]):
        (-[WebDocumentLoadState replaceRequestURLForAnchorScrollWithURL:]):
        (-[WebDocumentLoadState setRequest:]):
        (-[WebDocumentLoadState setResponse:]):
        (-[WebDocumentLoadState isStopping]):
        (-[WebDocumentLoadState bridge]):
        (-[WebDocumentLoadState setMainDocumentError:]):
        (-[WebDocumentLoadState mainDocumentError]):
        (-[WebDocumentLoadState clearErrors]):
        (-[WebDocumentLoadState mainReceivedError:complete:]):
        (-[WebDocumentLoadState stopLoading]):
        (-[WebDocumentLoadState setupForReplace]):
        (-[WebDocumentLoadState commitIfReady]):
        (-[WebDocumentLoadState finishedLoading]):
        (-[WebDocumentLoadState setCommitted:]):
        (-[WebDocumentLoadState isCommitted]):
        (-[WebDocumentLoadState setLoading:]):
        (-[WebDocumentLoadState isLoading]):
        (-[WebDocumentLoadState commitLoadWithData:]):
        (-[WebDocumentLoadState doesProgressiveLoadWithMIMEType:]):
        (-[WebDocumentLoadState receivedData:]):
        (-[WebDocumentLoadState setupForReplaceByMIMEType:]):
        (-[WebDocumentLoadState updateLoading]):
        (-[WebDocumentLoadState response]):
        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader activeDocumentLoadState]):
        (-[WebFrameLoader activeDataSource]):
        (-[WebFrameLoader _archivedSubresourceForURL:]):
        (-[WebFrameLoader addPlugInStreamLoader:]):
        (-[WebFrameLoader removePlugInStreamLoader:]):
        (-[WebFrameLoader addSubresourceLoader:]):
        (-[WebFrameLoader removeSubresourceLoader:]):
        (-[WebFrameLoader documentLoadState]):
        (-[WebFrameLoader provisionalDocumentLoadState]):
        (-[WebFrameLoader stopLoading]):
        (-[WebFrameLoader _originalRequest]):
        (-[WebFrameLoader _receivedData:]):
        (-[WebFrameLoader _setRequest:]):
        (-[WebFrameLoader bridge]):
        (-[WebFrameLoader _handleFallbackContent]):
        (-[WebFrameLoader _isStopping]):
        (-[WebFrameLoader _setupForReplaceByMIMEType:]):
        (-[WebFrameLoader _setResponse:]):
        (-[WebFrameLoader _mainReceivedError:complete:]):
        (-[WebFrameLoader _finishedLoading]):
        (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
        (-[WebFrameLoader finishedLoadingDocumentLoadState:]):
        (-[WebFrameLoader commitProvisitionalLoad]):
        (-[WebFrameLoader committedLoadWithDocumentLoadState:data:]):
        (-[WebFrameLoader isReplacing]):
        (-[WebFrameLoader setReplacing]):
        (-[WebFrameLoader revertToProvisionalWithDocumentLoadState:]):
        (-[WebFrameLoader documentLoadState:setMainDocumentError:]):
        (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]):
        (-[WebFrameLoader finalSetupForReplaceWithDocumentLoadState:]):
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _prepareForLoadStart]):
        (-[WebDataSource _mainDocumentError]):
        (-[WebDataSource _finishedLoading]):
        (-[WebDataSource _receivedData:]):
        (-[WebDataSource _setMainDocumentError:]):
        (-[WebDataSource _clearUnarchivingState]):
        (-[WebDataSource _revertToProvisionalState]):
        (-[WebDataSource _receivedMainResourceError:complete:]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _loadFromPageCache:]):
        (-[WebDataSource _bridge]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource _URLForHistory]):
        (-[WebDataSource _setTitle:]):
        (-[WebDataSource _initWithDocumentLoadState:]):
        (-[WebDataSource request]):
        (-[WebDataSource response]):
        (-[WebDataSource isLoading]):
        (-[WebDataSource webArchive]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebDocumentLoadStateMac.m:
        (-[WebDocumentLoadStateMac initWithRequest:]):
        * WebView/WebFrame.m:
        (-[WebFrame _createItem:]):
        (-[WebFrame _receivedMainResourceError:]):
        (-[WebFrame _transitionToCommitted:]):
        (-[WebFrame _commitProvisionalLoad:]):
        (-[WebFrame _checkLoadCompleteForThisFrame]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
        (-[WebFrame _didReceiveServerRedirectForProvisionalLoadForFrame]):
        (-[WebFrame _provisionalLoadStarted]):
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele
beidson [Mon, 2 Oct 2006 23:51:21 +0000 (23:51 +0000)]
    Reviewed by Adele

        If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
        icon data out because we don't correctly check SQL error conditions.

        * loader/icon/IconDataCache.cpp:
        (WebCore::IconDataCache::writeToDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-02 Steve Falkenburg <sfalken@apple.com>
sfalken [Mon, 2 Oct 2006 23:36:07 +0000 (23:36 +0000)]
2006-10-02  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Hyatt.

        Added method to find out whether a layout has occurred.

        * page/FrameView.cpp:
        (WebCore::FrameView::didFirstLayout):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Minor harassment followed by abject surrender provided by ggggaren.
bdakin [Mon, 2 Oct 2006 23:25:58 +0000 (23:25 +0000)]
    Minor harassment followed by abject surrender provided by ggggaren.

        Tests for counters.

        * fast/css/counters/contentNone-expected.checksum: Added.
        * fast/css/counters/contentNone-expected.png: Added.
        * fast/css/counters/contentNone-expected.txt: Added.
        * fast/css/counters/contentNone.html: Added.
        * fast/css/counters/counter00-expected.checksum: Added.
        * fast/css/counters/counter00-expected.png: Added.
        * fast/css/counters/counter00-expected.txt: Added.
        * fast/css/counters/counter00.html: Added.
        * fast/css/counters/counter01-expected.checksum: Added.
        * fast/css/counters/counter01-expected.png: Added.
        * fast/css/counters/counter01-expected.txt: Added.
        * fast/css/counters/counter01.html: Added.
        * fast/css/counters/counter02-expected.checksum: Added.
        * fast/css/counters/counter02-expected.png: Added.
        * fast/css/counters/counter02-expected.txt: Added.
        * fast/css/counters/counter02.html: Added.
        * fast/css/counters/counter03-expected.checksum: Added.
        * fast/css/counters/counter03-expected.png: Added.
        * fast/css/counters/counter03-expected.txt: Added.
        * fast/css/counters/counter03.html: Added.
        * fast/css/counters/counter04-expected.checksum: Added.
        * fast/css/counters/counter04-expected.png: Added.
        * fast/css/counters/counter04-expected.txt: Added.
        * fast/css/counters/counter04.html: Added.
        * fast/css/counters/counter05-expected.checksum: Added.
        * fast/css/counters/counter05-expected.png: Added.
        * fast/css/counters/counter05-expected.txt: Added.
        * fast/css/counters/counter05.html: Added.
        * fast/css/counters/counter06-expected.checksum: Added.
        * fast/css/counters/counter06-expected.png: Added.
        * fast/css/counters/counter06-expected.txt: Added.
        * fast/css/counters/counter06.html: Added.
        * fast/css/counters/counter07-expected.checksum: Added.
        * fast/css/counters/counter07-expected.png: Added.
        * fast/css/counters/counter07-expected.txt: Added.
        * fast/css/counters/counter07.html: Added.
        * fast/css/counters/counter08-expected.checksum: Added.
        * fast/css/counters/counter08-expected.png: Added.
        * fast/css/counters/counter08-expected.txt: Added.
        * fast/css/counters/counter08.html: Added.
        * fast/css/counters/counter09-expected.checksum: Added.
        * fast/css/counters/counter09-expected.png: Added.
        * fast/css/counters/counter09-expected.txt: Added.
        * fast/css/counters/counter09.html: Added.
        * fast/css/counters/counter10-expected.checksum: Added.
        * fast/css/counters/counter10-expected.png: Added.
        * fast/css/counters/counter10-expected.txt: Added.
        * fast/css/counters/counter10.html: Added.
        * fast/css/counters/counter11-expected.checksum: Added.
        * fast/css/counters/counter11-expected.png: Added.
        * fast/css/counters/counter11-expected.txt: Added.
        * fast/css/counters/counter11.html: Added.
        * fast/css/counters/counter12-expected.checksum: Added.
        * fast/css/counters/counter12-expected.png: Added.
        * fast/css/counters/counter12-expected.txt: Added.
        * fast/css/counters/counter12.html: Added.
        * fast/css/counters/counter13-expected.checksum: Added.
        * fast/css/counters/counter13-expected.png: Added.
        * fast/css/counters/counter13-expected.txt: Added.
        * fast/css/counters/counter13.html: Added.
        * fast/css/counters/counter14-expected.checksum: Added.
        * fast/css/counters/counter14-expected.png: Added.
        * fast/css/counters/counter14-expected.txt: Added.
        * fast/css/counters/counter14.html: Added.
        * fast/css/counters/counter15-expected.checksum: Added.
        * fast/css/counters/counter15-expected.png: Added.
        * fast/css/counters/counter15-expected.txt: Added.
        * fast/css/counters/counter15.html: Added.
        * fast/css/counters/counter16-expected.checksum: Added.
        * fast/css/counters/counter16-expected.png: Added.
        * fast/css/counters/counter16-expected.txt: Added.
        * fast/css/counters/counter16.html: Added.
        * fast/css/counters/counters00-expected.checksum: Added.
        * fast/css/counters/counters00-expected.png: Added.
        * fast/css/counters/counters00-expected.txt: Added.
        * fast/css/counters/counters00.html: Added.
        * fast/css/counters/counters01-expected.checksum: Added.
        * fast/css/counters/counters01-expected.png: Added.
        * fast/css/counters/counters01-expected.txt: Added.
        * fast/css/counters/counters01.html: Added.
        * fast/css/counters/counters02-expected.checksum: Added.
        * fast/css/counters/counters02-expected.png: Added.
        * fast/css/counters/counters02-expected.txt: Added.
        * fast/css/counters/counters02.html: Added.
        * fast/css/counters/counters03-expected.checksum: Added.
        * fast/css/counters/counters03-expected.png: Added.
        * fast/css/counters/counters03-expected.txt: Added.
        * fast/css/counters/counters03.html: Added.
        * fast/css/counters/counters04-expected.checksum: Added.
        * fast/css/counters/counters04-expected.png: Added.
        * fast/css/counters/counters04-expected.txt: Added.
        * fast/css/counters/counters04.html: Added.
        * fast/css/counters/counters05-expected.checksum: Added.
        * fast/css/counters/counters05-expected.png: Added.
        * fast/css/counters/counters05-expected.txt: Added.
        * fast/css/counters/counters05.html: Added.
        * fast/css/counters/counters06-expected.checksum: Added.
        * fast/css/counters/counters06-expected.png: Added.
        * fast/css/counters/counters06-expected.txt: Added.
        * fast/css/counters/counters06.html: Added.
        * fast/css/counters/counters07-expected.checksum: Added.
        * fast/css/counters/counters07-expected.png: Added.
        * fast/css/counters/counters07-expected.txt: Added.
        * fast/css/counters/counters07.html: Added.
        * fast/css/counters/counters08-expected.checksum: Added.
        * fast/css/counters/counters08-expected.png: Added.
        * fast/css/counters/counters08-expected.txt: Added.
        * fast/css/counters/counters08.html: Added.
        * fast/css/counters/counters09-expected.checksum: Added.
        * fast/css/counters/counters09-expected.png: Added.
        * fast/css/counters/counters09-expected.txt: Added.
        * fast/css/counters/counters09.html: Added.
        * fast/css/counters/counters10-expected.checksum: Added.
        * fast/css/counters/counters10-expected.png: Added.
        * fast/css/counters/counters10-expected.txt: Added.
        * fast/css/counters/counters10.html: Added.
        * fast/css/counters/counters11-expected.checksum: Added.
        * fast/css/counters/counters11-expected.png: Added.
        * fast/css/counters/counters11-expected.txt: Added.
        * fast/css/counters/counters11.html: Added.
        * fast/css/counters/counters12-expected.checksum: Added.
        * fast/css/counters/counters12-expected.png: Added.
        * fast/css/counters/counters12-expected.txt: Added.
        * fast/css/counters/counters12.html: Added.
        * fast/css/counters/counters13-expected.checksum: Added.
        * fast/css/counters/counters13-expected.png: Added.
        * fast/css/counters/counters13-expected.txt: Added.
        * fast/css/counters/counters13.html: Added.
        * fast/css/counters/counters14-expected.checksum: Added.
        * fast/css/counters/counters14-expected.png: Added.
        * fast/css/counters/counters14-expected.txt: Added.
        * fast/css/counters/counters14.html: Added.
        * fast/css/counters/counters15-expected.checksum: Added.
        * fast/css/counters/counters15-expected.png: Added.
        * fast/css/counters/counters15-expected.txt: Added.
        * fast/css/counters/counters15.html: Added.
        * fast/css/counters/counters18-expected.checksum: Added.
        * fast/css/counters/counters18-expected.png: Added.
        * fast/css/counters/counters18-expected.txt: Added.
        * fast/css/counters/counters18.html: Added.
        * fast/css/counters/implied00-expected.checksum: Added.
        * fast/css/counters/implied00-expected.png: Added.
        * fast/css/counters/implied00-expected.txt: Added.
        * fast/css/counters/implied00.html: Added.
        * fast/css/counters/root-expected.checksum: Added.
        * fast/css/counters/root-expected.png: Added.
        * fast/css/counters/root-expected.txt: Added.
        * fast/css/counters/root.html: Added.
        * fast/css/counters/visibilityNone-expected.checksum: Added.
        * fast/css/counters/visibilityNone-expected.png: Added.
        * fast/css/counters/visibilityNone-expected.txt: Added.
        * fast/css/counters/visibilityNone.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
bdakin [Mon, 2 Oct 2006 23:15:31 +0000 (23:15 +0000)]
    Reviewed by Darin.

        Initial implementation of CSS2 counters. See http://
        bugs.webkit.org/show_bug.cgi?id=4980 for more details.

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return
        the increment/reset list now that this is implemented.
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText):
        * css/Counter.h:
        (WebCore::Counter::Counter):
        (WebCore::Counter::~Counter):
        (WebCore::Counter::identifier):
        (WebCore::Counter::listStyle):
        (WebCore::Counter::separator):
        (WebCore::Counter::listStyleNumber):
        (WebCore::Counter::setIdentifier):
        (WebCore::Counter::setListStyle):
        (WebCore::Counter::setSeparator):
        * css/cssparser.cpp:
        (WebCore::CSSParser::addProperty): Take care of reset/increment
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseContent): content can now take counters
        (WebCore::CSSParser::parseCounterContent): Parse counter() and
        counters()
        (WebCore::CSSParser::parseCounter): Parse counter-reset and
        counter-increment
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::matchUARules):
        (WebCore::CSSStyleSelector::applyProperty):
        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::insert): Implemented a version of insert that
        accepts a UChar* and a length.
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::insert): Same as above.
        * platform/StringImpl.h:
        * rendering/CounterListItem.h: Added.
        * rendering/CounterNode.cpp: Added.
        (WebCore::CounterNode::CounterNode):
        (WebCore::CounterNode::insertAfter):
        (WebCore::CounterNode::removeChild):
        (WebCore::CounterNode::remove):
        (WebCore::CounterNode::setUsesSeparator):
        (WebCore::CounterNode::recountAndGetNext):
        (WebCore::CounterNode::recountTree):
        (WebCore::CounterNode::setSelfDirty):
        (WebCore::CounterNode::setParentDirty):
        * rendering/CounterNode.h: Added.
        (WebCore::CounterNode::~CounterNode):
        (WebCore::CounterNode::parent):
        (WebCore::CounterNode::previousSibling):
        (WebCore::CounterNode::nextSibling):
        (WebCore::CounterNode::firstChild):
        (WebCore::CounterNode::lastChild):
        (WebCore::CounterNode::value):
        (WebCore::CounterNode::setValue):
        (WebCore::CounterNode::count):
        (WebCore::CounterNode::setCount):
        (WebCore::CounterNode::setHasSeparator):
        (WebCore::CounterNode::isReset):
        (WebCore::CounterNode::hasSeparator):
        (WebCore::CounterNode::willNeedLayout):
        (WebCore::CounterNode::setWillNeedLayout):
        (WebCore::CounterNode::isRoot):
        (WebCore::CounterNode::setRenderer):
        (WebCore::CounterNode::renderer):
        * rendering/CounterResetNode.cpp: Added.
        (WebCore::CounterResetNode::CounterResetNode):
        (WebCore::CounterResetNode::insertAfter):
        (WebCore::CounterResetNode::removeChild):
        (WebCore::CounterResetNode::recountAndGetNext):
        (WebCore::CounterResetNode::setParentDirty):
        (WebCore::CounterResetNode::updateTotal):
        * rendering/CounterResetNode.h: Added.
        (WebCore::CounterResetNode::firstChild):
        (WebCore::CounterResetNode::lastChild):
        (WebCore::CounterResetNode::isReset):
        (WebCore::CounterResetNode::total):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::updatePseudoChildForObject): Account for
        counter content.
        * rendering/RenderCounter.cpp: Added.
        (WebCore::RenderCounter::RenderCounter):
        (WebCore::RenderCounter::layout):
        (WebCore::toRoman):
        (WebCore::toLetterString):
        (WebCore::toHebrew):
        (WebCore::RenderCounter::convertValueToType):
        (WebCore::RenderCounter::calcMinMaxWidth):
        * rendering/RenderCounter.h: Added.
        (WebCore::RenderCounter::renderName):
        (WebCore::RenderCounter::isCounter):
        * rendering/RenderObject.cpp:
        (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to
        maps of CounterNodes
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::destroy): Destroy the maps.
        (WebCore::RenderObject::findCounter): Finds/creates counters.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isCounter):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleVisualData::StyleVisualData):
        (WebCore::RenderStyle::arenaDelete):
        (WebCore::RenderStyle::RenderStyle):
        (WebCore::RenderStyle::diff):
        (WebCore::RenderStyle::setContent):
        (WebCore::ContentData::clearContent):
        (WebCore::RenderStyle::counterDataEquivalent):
        (WebCore::hasCounter):
        (WebCore::RenderStyle::hasCounterReset):
        (WebCore::RenderStyle::hasCounterIncrement):
        (WebCore::readCounter):
        (WebCore::RenderStyle::counterReset):
        (WebCore::RenderStyle::counterIncrement):
        * rendering/RenderStyle.h:
        (WebCore::StyleVisualData::operator==):
        (WebCore::CounterData::CounterData):
        (WebCore::CounterData::identifier):
        (WebCore::CounterData::listStyle):
        (WebCore::CounterData::separator):
        (WebCore::ContentData::contentCounter):
        (WebCore::ContentData::):
        (WebCore::RenderStyle::counterIncrement):
        (WebCore::RenderStyle::counterReset):
        (WebCore::RenderStyle::setCounterIncrement):
        (WebCore::RenderStyle::setCounterReset):
        (WebCore::RenderStyle::setCounterResetList):
        (WebCore::RenderStyle::setCounterIncrementList):
        (WebCore::RenderStyle::counterResetValueList):
        (WebCore::RenderStyle::counterIncrementValueList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim H.
aroben [Mon, 2 Oct 2006 21:03:31 +0000 (21:03 +0000)]
    Reviewed by Tim H.

        This change fixes a couple of problems with the window-properties
        test. window-properties' output changes depending on the presence or
        non-presence of session history (see
        http://bugs.webkit.org/show_bug.cgi?id=10965 for details). For this
        reason, the test must always be run as part of a run of ALL layout
        tests. The test results checked in were generated from an individual
        run of this test, so the buildbots were always failing since they run
        all the tests at once.

        This change regenerates the results for the test using a full run of
        layout tests. The test now also prints out object class names, and
        will print an error message when the test is run by itself.

        * fast/js/window-properties-expected.txt:
        * fast/js/window-properties.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by john
justing [Mon, 2 Oct 2006 20:44:13 +0000 (20:44 +0000)]
    Reviewed by john

        <rdar://problem/4757583>
        REGRESSION: tabbing into page focuses wrong control on 2nd pass
        <rdar://problem/4757594>
        REGRESSION: Form field is left with secondary selection after tabbing out of WebView

        * WebView/WebHTMLView.m:
        (-[NSArray maintainsInactiveSelection]): Replace code that I removed in error in the patch
        for 9642.  Only leave inactive editable selections in the WebHTMLView if the nextResponder
        is in the same WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Mon, 2 Oct 2006 20:30:43 +0000 (20:30 +0000)]
LayoutTests:

        Reviewed by Adam.

        - Updated results for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>

        * fast/forms/HTMLOptionElement_label05-expected.checksum:
        * fast/forms/HTMLOptionElement_label05-expected.png:
        * fast/forms/HTMLOptionElement_label05-expected.txt:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/option-strip-whitespace-expected.checksum:
        * fast/forms/option-strip-whitespace-expected.png:
        * fast/forms/option-strip-whitespace-expected.txt:
        * fast/forms/password-doubleclick-selection-expected.txt: Added.
        * fast/forms/password-doubleclick-selection.html: Added.
        * fast/forms/select-change-popup-to-listbox-expected.checksum:
        * fast/forms/select-change-popup-to-listbox-expected.png:
        * fast/forms/select-change-popup-to-listbox-expected.txt:
        * fast/text/updateNewFont-expected.checksum:
        * fast/text/updateNewFont-expected.png:
        * fast/text/updateNewFont-expected.txt:

WebCore:

        Reviewed by Adam.

        - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>

        There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
        by using "-webkit-appearance:none".

        * css/html4.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Backing out these accidental commits.
aroben [Mon, 2 Oct 2006 16:46:49 +0000 (16:46 +0000)]
    Backing out these accidental commits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
aroben [Mon, 2 Oct 2006 16:33:48 +0000 (16:33 +0000)]
2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>

JavaScriptCore:

        Reviewed/landed by Adam.

        Build testkjs on Qt/Linux.

        * CMakeLists.txt:

WebKitTools:

        Reviewed/landed by Adam.

        Proper build-webkit support for Qt/Linux.

        Compilation process is similar to OSX now, aka.
        the build directory is RootCheckoutDir/WebKitBuild now.

        * Scripts/build-webkit: Recognize Qt.
        * Scripts/webkitdirs.pm: Add buildCMakeProject() logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reverted the code part of r16696, my patch for <rdar://problem/4641262>,...
harrison [Mon, 2 Oct 2006 15:32:17 +0000 (15:32 +0000)]
    Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
        addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
        Left the layout test.

        * rendering/bidi.cpp:
        (WebCore::checkMidpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Mon, 2 Oct 2006 10:57:23 +0000 (10:57 +0000)]
2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Fix win32 build, which has no inttypes.h

        * wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Mon, 2 Oct 2006 10:30:45 +0000 (10:30 +0000)]
2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Fix Qt/Linux build.

        * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
        (WebCore::supportedKeySizes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Mon, 2 Oct 2006 10:26:58 +0000 (10:26 +0000)]
2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>

        Reviewed by eseidel & mjs.  Landed by eseidel.

        Fix Qt/Linux build with older gcc 3.3.4.
        http://bugs.webkit.org/show_bug.cgi?id=11116

        As discussed with Maciej, the GCC_ROOT_NS_HACK
        can be completely removed, as well as the friendship
        between cacheGlobalObject & the JS* objects.

        * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
        * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
        (png_read_filter_row_mmx_avg):
        * platform/image-decoders/png/pngvcrd.c: Ditto.
        (png_mmx_support):
        (png_read_filter_row_mmx_avg):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
mjs [Mon, 2 Oct 2006 07:46:30 +0000 (07:46 +0000)]
    Reviewed by Anders.

        - remove webFrame field from WebDataSourcePrivate, it can get it from WebDocumentLoadState now

        * Loader/WebDocumentLoadState.h:
        * Loader/WebDocumentLoadState.m:
        (-[WebDocumentLoadState frameLoader]):
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _revertToProvisionalState]):
        (-[WebDataSource _setupForReplaceByMIMEType:]):
        (-[WebDataSource _updateLoading]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _defersCallbacksChanged]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _webView]):
        (-[WebDataSource _stopLoadingWithError:]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource dealloc]):
        (-[WebDataSource webFrame]):
        (-[WebDataSource isLoading]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
mjs [Mon, 2 Oct 2006 07:39:32 +0000 (07:39 +0000)]
    Reviewed by Anders.

        - fix crash on back/forward - reattach WebDocumentLoadState to data source when needed

        * WebView/WebDataSource.m:
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _initWithDocumentLoadState:]):
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix, not reviewed.
mjs [Mon, 2 Oct 2006 07:16:48 +0000 (07:16 +0000)]
    Build fix, not reviewed.

        - Added missing files to fix build.

        * WebView/WebDocumentLoadStateMac.h: Added.
        * WebView/WebDocumentLoadStateMac.m: Added.
        (-[WebDocumentLoadStateMac initWithRequest:]):
        (-[WebDocumentLoadStateMac dealloc]):
        (-[WebDocumentLoadStateMac setDataSource:]):
        (-[WebDocumentLoadStateMac dataSource]):
        (-[WebDocumentLoadStateMac setFrameLoader:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Brady and Oliver.
mjs [Mon, 2 Oct 2006 07:00:16 +0000 (07:00 +0000)]
    Reviewed by Brady and Oliver.

        - move things around so that WebDataSource and WebDocumentLoadState know about each other in
        the right way. This lines things up to move nearly all functionality down to WebDocumentLoadState.

        * Loader/WebDocumentLoadState.h:
        * Loader/WebDocumentLoadState.m:
        (-[WebDocumentLoadState initWithRequest:]):
        (-[WebDocumentLoadState dealloc]):
        (-[WebDocumentLoadState originalRequest]):
        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader dealloc]):
        (-[WebFrameLoader addSubresourceLoader:]):
        (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
        (-[WebFrameLoader dataSource]):
        (-[WebFrameLoader _setDocumentLoadState:]):
        (-[WebFrameLoader policyDataSource]):
        (-[WebFrameLoader _setPolicyDocumentLoadState:]):
        (-[WebFrameLoader clearDataSource]):
        (-[WebFrameLoader provisionalDataSource]):
        (-[WebFrameLoader _setProvisionalDocumentLoadState:]):
        (-[WebFrameLoader _clearProvisionalDataSource]):
        (-[WebFrameLoader _setState:]):
        (-[WebFrameLoader clearProvisionalLoad]):
        (-[WebFrameLoader commitProvisionalLoad]):
        (-[WebFrameLoader stopLoading]):
        (-[WebFrameLoader startLoading]):
        (-[WebFrameLoader startProvisionalLoad:]):
        (-[WebFrameLoader setupForReplace]):
        (-[WebFrameLoader activeDocumentLoadState]):
        (-[WebFrameLoader activeDataSource]):
        (-[WebFrameLoader _loadRequest:archive:]):
        (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
        (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
        (-[WebFrameLoader reload]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _documentLoadState]):
        (-[WebDataSource _initWithDocumentLoadState:]):
        (-[WebDataSource initWithRequest:]):
        (-[WebDataSource initialRequest]):
        (-[WebDataSource unreachableURL]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebFrame.m:
        (-[WebFramePrivate dealloc]):
        (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrame _loadDataSource:withLoadType:formState:]):
        (-[WebFrame _policyDataSource]):
        (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
        (-[WebFrame _dataSourceForDocumentLoadState:]):
        (-[WebFrame _createDocumentLoadStateWithRequest:]):
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
mjs [Mon, 2 Oct 2006 05:16:21 +0000 (05:16 +0000)]
LayoutTests:

        Rubber stamped by Alexey.

        - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes

        * fast/dom/css-insert-import-rule-expected.txt: Removed.
        * fast/dom/css-insert-import-rule.html: Removed.

WebCore:

        Rubber stamped by Alexey.

        - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-01 Eric Seidel <eric@webkit.org>
eseidel [Mon, 2 Oct 2006 04:36:23 +0000 (04:36 +0000)]
2006-10-01  Eric Seidel  <eric@webkit.org>

        Reviewed by mjs.

        Eliminate a few more hotspots in SVG drawing code.

        No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)

        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
        * platform/mac/ColorMac.mm:
        (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-01 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Mon, 2 Oct 2006 01:20:05 +0000 (01:20 +0000)]
2006-10-01  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Maciej.

        Add QT build slave to Buildbot.

        * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Add QT build slave, fix existing errors.
        * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Add QT build factory.
        * BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Disable forcing of builds via web interface to prevent spamming.  Use the IRC bot in #webkit-build instead.
        * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Add CMake build step.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Mon, 2 Oct 2006 01:02:49 +0000 (01:02 +0000)]
LayoutTests:

        Added test for the viewource attribute, which applies to <frame> and
        <iframe> elements.

        * fast/frames/viewsource-attribute-expected.txt: Added.
        * fast/frames/viewsource-attribute.html: Added.

        * fast/frames/frameElement-widthheight.html: Removed stray character.

WebCore:

        Reviewed by Maciej.

        More frame/iframe merging.

        - Removed needWidgetUpdate and related code. needWidgetUpdate is always
        false, so this was dead code.
        - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
        than attach(), is the correct place for setInViewSourceMode, because
        openURL() is the function that creates our frame.
        - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
        code that did the same thing in other places.
        - Made FRAME's attach() method suffuciently generic so that IFRAME could
        call up to it, rather than skipping its superclass and calling up directly
        to ELEMENT.
        - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
        - Replaced ad hoc frame loading code in FRAME::attach() with call to
        openURL(), the designated frame loading function.

        Layout tests pass. I added a layout test for viewsource mode, since I
        broke it in the course of writing this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-01 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Mon, 2 Oct 2006 00:04:56 +0000 (00:04 +0000)]
2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.

        * CMakeLists.txt: add option to disable colored output when building on the buildbot

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-01 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 1 Oct 2006 20:45:15 +0000 (20:45 +0000)]
2006-10-01  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * dom/Document.cpp:
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.

        * dom/Node.h:
        Remove DeprecatedStringList class forward declaration.

        * editing/markup.cpp:
        Include DeprecatedStringList.h here since it's not included by Document.h anymore.

        * kcanvas/KCanvasTreeDebug.cpp:
        * kcanvas/KCanvasTreeDebug.h:
        Remove unused functions.

        * loader/loader.cpp:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/FrameView.h:
        Fixup DeprecatedStringList.h includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
harrison [Sun, 1 Oct 2006 16:06:11 +0000 (16:06 +0000)]
LayoutTests:

        Reviewed by John Sullivan.

        <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point

        * fast/text/international/wrap-CJK-001-expected.checksum: Added.
        * fast/text/international/wrap-CJK-001-expected.png: Added.
        * fast/text/international/wrap-CJK-001-expected.txt: Added.
        * fast/text/international/wrap-CJK-001.html: Added.

WebCore:

        Reviewed by John Sullivan.

        <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point

        Problem was that the decision to trim was based only on whether the character
        is a soft hyphen, which caused pretty much any Japanese character to go.
        Changed to decide based on whether the character is ignorable whitespace.

        Test:
        * fast/text/international/wrap-CJK-001.html

        * rendering/bidi.cpp:
        (WebCore::isTrimmableChar):
        New. Checks whether character is whitespace that can be ignored
        according to the text node's style.
        trimmed from the end of wrapped line.
        (WebCore::checkMidpoints):
        Call isTrimmable() rather than checking for char != SOFT_HYPHEN.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-01 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 1 Oct 2006 15:40:02 +0000 (15:40 +0000)]
2006-10-01  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Mitz Pettel.

        Convert the SVG code to use Vector<String> instead of DeprecatedStringList.

        * ksvg2/svg/SVGColor.cpp:
        (WebCore::SVGColor::setRGBColor):
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        (SVGFESpecularLightingElement::parseMappedAttribute):
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
        * ksvg2/svg/SVGLengthList.cpp:
        * ksvg2/svg/SVGNumberList.cpp:
        (SVGNumberList::parse):
        * ksvg2/svg/SVGNumberList.h:
        * ksvg2/svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
        * ksvg2/svg/SVGStringList.cpp:
        (WebCore::SVGStringList::reset):
        * ksvg2/svg/SVGStringList.h:
        * ksvg2/svg/SVGTransformable.cpp:
        (SVGTransformable::parseTransformAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-01 Nikolas Zimmermann <zimmermann@kde.org>
ap [Sun, 1 Oct 2006 10:05:01 +0000 (10:05 +0000)]
2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric, tweaked and landed by ap.

        Fix Qt/Linux build.

        * CMakeLists.txt:
        * platform/qt/PlatformScrollBar.h:
        * platform/qt/TemporaryLinkStubs.cpp:
        (WebCore::ScrollBar::ScrollBar):
        (WebCore::PlatformScrollBar::PlatformScrollBar):
        (FrameView::passMousePressEventToSubframe):
        (FrameView::passMouseMoveEventToSubframe):
        (FrameView::passMouseReleaseEventToSubframe):
        (FrameView::passWheelEventToSubframe):
        (FrameView::passMousePressEventToScrollbar):
        * ksvg2/svg/SVGDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-10-01 Mitz Pettel <opendarwin.org@mitzpettel.com>
ap [Sun, 1 Oct 2006 09:11:35 +0000 (09:11 +0000)]
2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
        REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading

        No test case added (probably requires new DumpRenderTree functionality)

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged): Added early return if the document is
        being destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
ap [Sun, 1 Oct 2006 09:06:09 +0000 (09:06 +0000)]
    Reviewed by Hyatt.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
        REGRESSION (r15418): contenteditable div truncates rightmost Japanese character

        Make sure we only break after a space (and not any other valid line-break) if
        the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
        I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
        twice in quick succession.

        Test: fast/text/line-breaks-after-white-space.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixed Bugzilla references in ChangeLogs for my previous commit.
ap [Sun, 1 Oct 2006 08:37:29 +0000 (08:37 +0000)]
Fixed Bugzilla references in ChangeLogs for my previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej and Darin.
ap [Sun, 1 Oct 2006 08:35:29 +0000 (08:35 +0000)]
    Reviewed by Maciej and Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=4372
        JavaScript document.write page form does not submit in Safari

        Test: fast/forms/document-write.html

        * page/Frame.cpp:
        (WebCore::Frame::submitForm): Don't check for parsing().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix.
ap [Sun, 1 Oct 2006 08:13:04 +0000 (08:13 +0000)]
    Build fix.

        * bridge/mac/FrameViewMac.mm: Add missing #imports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRefactor the code that sends the mouse down to scrollbars.
hyatt [Sun, 1 Oct 2006 07:26:55 +0000 (07:26 +0000)]
Refactor the code that sends the mouse down to scrollbars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
weinig [Sat, 30 Sep 2006 23:33:25 +0000 (23:33 +0000)]
    Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
        Add more SVG Objective-C DOM bindings

        - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
          DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
          DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
          DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
          DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
          DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMSVG.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * ksvg2/svg/SVGAElement.idl:
        * ksvg2/svg/SVGAnimateColorElement.idl:
        * ksvg2/svg/SVGAnimateElement.idl:
        * ksvg2/svg/SVGAnimateTransformElement.idl:
        * ksvg2/svg/SVGAnimatedPathData.idl:
        * ksvg2/svg/SVGAnimatedPoints.idl:
        * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
        * ksvg2/svg/SVGAnimationElement.idl:
        * ksvg2/svg/SVGCircleElement.idl:
        * ksvg2/svg/SVGClipPathElement.idl:
        * ksvg2/svg/SVGColor.idl:
        * ksvg2/svg/SVGCursorElement.idl:
        * ksvg2/svg/SVGDefsElement.idl:
        * ksvg2/svg/SVGDescElement.idl:
        * ksvg2/svg/SVGDocument.idl:
        * ksvg2/svg/SVGEllipseElement.idl:
        * ksvg2/svg/SVGPointList.idl:
        * ksvg2/svg/SVGPreserveAspectRatio.idl:
        * ksvg2/svg/SVGRect.idl:
        * ksvg2/svg/SVGSVGElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
mjs [Sat, 30 Sep 2006 23:18:59 +0000 (23:18 +0000)]
    Reviewed by Adele.

        - fix build

        * platform/FloatRect.h:
        (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
        but more appropriate for path-type stuff.
        * platform/cg/PathCG.cpp:
        (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Sat, 30 Sep 2006 21:14:44 +0000 (21:14 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11011
        External CSS is parsed as iso-8859-1 even though the main document is utf-8

        Test: fast/encoding/css-charset-default.xhtml

        * loader/CachedResourceClient.h:
        (WebCore::CachedResourceClient::setCSSStyleSheet):
        (WebCore::CachedResourceClient::setXSLStyleSheet):
        Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
        takes an additional charset parameter, to be passed to CSSStyleSheet constructor.

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet):
        (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
        * css/CSSImportRule.h:

        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::CSSStyleSheet):
        * css/CSSStyleSheet.h:
        Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
        member. Changed some String parameters to const String&.

        * css/StyleSheet.cpp:
        (WebCore::StyleSheet::StyleSheet):
        * css/StyleSheet.h:
        Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.

        * css/StyleSheetList.cpp:
        (WebCore::StyleSheetList::length):
        (WebCore::StyleSheetList::item):
        * css/StyleSheetList.h:
        Special-casing implicit stylesheets seemed to be dead code, removed.

        * dom/Document.cpp:
        (WebCore::Document::setCSSStyleSheet):
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        Renamed setStyleSheet() to setCSSStyleSheet().

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        (WebCore::ProcessingInstruction::setXSLStyleSheet):
        (WebCore::ProcessingInstruction::parseStyleSheet):
        * dom/ProcessingInstruction.h:

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
        is not specified.
        (WebCore::HTMLLinkElement::setCSSStyleSheet):
        * html/HTMLLinkElement.h:

        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::childrenChanged):
        * ksvg2/svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::childrenChanged):
        Inherit URL and charset from the document.

        * loader/Cache.cpp:
        (WebCore::Cache::requestCSSStyleSheet):
        * loader/Cache.h:
        Adjust for setStyleSheet() renaming.

        * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::ref):
        (WebCore::CachedCSSStyleSheet::deref):
        (WebCore::CachedCSSStyleSheet::checkNotify):
        Pass the encoding to setCSSStyleSheet().

        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::ref):
        (WebCore::CachedXSLStyleSheet::checkNotify):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestCSSStyleSheet):
        * loader/DocLoader.h:
        * page/Frame.cpp:
        (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
        (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::setXSLStyleSheet):
        (WebCore::XSLImportRule::loadSheet):
        * xml/XSLImportRule.h:
        Adjust for setStyleSheet() renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by eseidel.
rwlbuis [Sat, 30 Sep 2006 17:08:39 +0000 (17:08 +0000)]
    Reviewed by eseidel.

        http://bugs.webkit.org/show_bug.cgi?id=11096
        Hit testing for polylines fails

        Fix Path::contains so it handles filled, non-closed paths too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix win32.
hyatt [Sat, 30 Sep 2006 10:11:11 +0000 (10:11 +0000)]
Fix win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRevert minimum font size pref back to 1.
hyatt [Sat, 30 Sep 2006 09:49:30 +0000 (09:49 +0000)]
Revert minimum font size pref back to 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix win32 bustage caused by a typo.
hyatt [Sat, 30 Sep 2006 09:48:24 +0000 (09:48 +0000)]
Fix win32 bustage caused by a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix mac bustage in FrameMac.mm and FrameViewMac.mm
hyatt [Sat, 30 Sep 2006 09:46:07 +0000 (09:46 +0000)]
Fix mac bustage in FrameMac.mm and FrameViewMac.mm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoEvent refactoring.
hyatt [Sat, 30 Sep 2006 09:30:31 +0000 (09:30 +0000)]
Event refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
adele [Sat, 30 Sep 2006 05:42:00 +0000 (05:42 +0000)]
    Reviewed by Adele.

        Fixes windows bustage:
        http://bugs.webkit.org/show_bug.cgi?id=11093

        * platform/win/PlatformScrollBar.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (PlatformScrollBar::PlatformScrollBar):
        (ScrollBar::ScrollBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Bug 11041: fast/dom/isindex-001 needs new results
thatcher [Sat, 30 Sep 2006 03:25:38 +0000 (03:25 +0000)]
    Bug 11041: fast/dom/isindex-001 needs new results
        http://bugs.webkit.org/show_bug.cgi?id=11041

        * fast/dom/isindex-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16681 268f45cc-cd09-0410-ab3c-d52691b4dbfc