WebKit-https.git
6 years agoAnother speculative windows build fix.
bdakin@apple.com [Fri, 1 Feb 2013 20:13:45 +0000 (20:13 +0000)]
Another speculative windows build fix.

* platform/ScrollAnimator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[canvas] Add more constructors to Path
krit@webkit.org [Fri, 1 Feb 2013 20:11:41 +0000 (20:11 +0000)]
[canvas] Add more constructors to Path
https://bugs.webkit.org/show_bug.cgi?id=108587

Patch by Dirk Schulze <krit@webkit.org> on 2013-01-31
Reviewed by Dean Jackson.

Source/WebCore:

Add more constructors to Path object to make it possible
to copy Path objects and parse SVG strings into a Path
object that can be used on the canvas context afterwards.

Test: fast/canvas/canvas-path-constructors.html

* html/canvas/DOMPath.h: New constructors for Path.
(WebCore::DOMPath::create):
(WebCore::DOMPath::DOMPath):
* html/canvas/DOMPath.idl: Ditto.

LayoutTests:

Add tests for new constructors of Path objects.
Since the feature is behind a flag, the test is skipped on
all platforms for now.

* fast/canvas/canvas-path-constructors-expected.txt: Added.
* fast/canvas/canvas-path-constructors.html: Added.
* fast/canvas/script-tests/canvas-path-constructors.js: Added.
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:
* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] InputHandler status is not restored when page history goes back
commit-queue@webkit.org [Fri, 1 Feb 2013 20:11:15 +0000 (20:11 +0000)]
[BlackBerry] InputHandler status is not restored when page history goes back
https://bugs.webkit.org/show_bug.cgi?id=108448

Patch by Sean Wang <Xuewen.Wang@torchmobile.com.cn> on 2013-02-01
Reviewed by Yong Li.

PR288406 Internally reviewed by Mike Fenton

When webpage goes back, it restores the old frame's selection and focused node,
but we don't save the InputHandler's status, it becomes non-input mode when page
goes back. When it restores the focus, since the new focus node is same as the old
document focused node, webcore will not notify client to update the input handler.

This patch updates the input handler's status by notifying it focus node changed.

* WebCoreSupport/FrameLoaderClientBlackBerry.cpp:
(WebCore::FrameLoaderClientBlackBerry::restoreViewState):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::restoreViewState):
(WebKit):
* WebKitSupport/InputHandler.h:
(InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add WTFURL source files to the build
zandobersek@gmail.com [Fri, 1 Feb 2013 20:06:55 +0000 (20:06 +0000)]
[GTK] Add WTFURL source files to the build
https://bugs.webkit.org/show_bug.cgi?id=108215

Reviewed by Benjamin Poulain.

.:

* Source/autotools/symbols.filter: Force the export of the KURL::string() symbol.
This is required when using the WTFURL backend but otherwise doesn't affect the build.

Source/WebCore:

* platform/KURLWTFURL.cpp:
(WebCore): Only use the stub implementation of the fileSystemPath method for the
Apple ports, other ports should for now still rely on their platform-specific implementations.

Source/WTF:

The WTFURL implementation sources are all still guarded by the USE(WTFURL) guard,
meaning that the GTK port still uses the default KURL backend. To use the WTFURL
backend instead, one would have to define WTF_USE_WTFURL in Platform.h.

* GNUmakefile.am: List the directories from which source headers will be included.
Plenty of WTFURL code currently just includes the required header by name rather
than specifying the header path as relative to Source/WTF. In the future all the inclusions
should probaby be changed to include the header through the path relative to Source/WTF.
* GNUmakefile.list.am: Add build targets for the WTFURL source files.
* wtf/url/api/ParsedURL.cpp: Specify the complete path to the required headers and
reorder the inclusions.
* wtf/url/src/URLCanon.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove call to SecurityOrigin::canAccessDatabase from IDB constructor.
mkwst@chromium.org [Fri, 1 Feb 2013 19:58:47 +0000 (19:58 +0000)]
Remove call to SecurityOrigin::canAccessDatabase from IDB constructor.
https://bugs.webkit.org/show_bug.cgi?id=108477

Reviewed by Adam Barth.

Source/WebCore:

This change removes the 'SecurityOrigin::canAccessDatabase' check from
the constructor for the 'indexedDB' property on both DOMWindow and
WorkerContext. After the patch for http://wkbug.com/94171 this check
is redundant, as all the entry points to IDB are now gated on access
being granted.

As a side-effect, dropping the check in WorkerContextIndexedDatabase
allows us to stop holding a pointer to the ScriptExecutionContext we're
extending, which can only be a good thing.

The tests in storage/indexeddb should continue to pass.

* Modules/indexeddb/DOMWindowIndexedDatabase.cpp:
(WebCore::DOMWindowIndexedDatabase::indexedDB):
    Drop the SecurityOrigin::canAccessDatabase check.
* Modules/indexeddb/WorkerContextIndexedDatabase.cpp:
(WebCore::WorkerContextIndexedDatabase::WorkerContextIndexedDatabase):
(WebCore::WorkerContextIndexedDatabase::from):
    Drop the ScriptExecutionContext parameter from the class's
    constructor and callsites.
(WebCore::WorkerContextIndexedDatabase::indexedDB):
    Drop the SecurityOrigin::canAccessDatabase check.
* Modules/indexeddb/WorkerContextIndexedDatabase.h:
(WorkerContextIndexedDatabase):
    Drop the stored pointer to ScriptExecutionContext, as we no longer
    need it in ::indexedDB.

LayoutTests:

* http/tests/security/no-indexeddb-from-sandbox-expected.txt:
* http/tests/security/no-indexeddb-from-sandbox.html:
    This test expected the 'webkitIndexedDB' property to be missing
    entirely inside a sandbox. The expectation has been updated to
    expect 'webkitIndexedDB.open()' to throw a SECURITY_ERR.
* platform/efl/TestExpectations:
* platform/mac-snowleopard/TestExpectations:
* platform/mac/TestExpectations:
* platform/qt/TestExpectations:
* platform/win/TestExpectations:
* platform/wincairo/TestExpectations:
    This test was accidentally passing on a variety of platforms that
    don't yet implement IndexedDB. Now that failure is distinguishable
    we should skip it on a variety of platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSpeculative Windows build fix.
bdakin@apple.com [Fri, 1 Feb 2013 19:54:03 +0000 (19:54 +0000)]
Speculative Windows build fix.

* platform/ScrollAnimator.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMessage decoding functions should take a MessageDecoder reference
andersca@apple.com [Fri, 1 Feb 2013 19:53:44 +0000 (19:53 +0000)]
Message decoding functions should take a MessageDecoder reference
https://bugs.webkit.org/show_bug.cgi?id=108669

Reviewed by Andreas Kling.

Message encoding functions already take a reference instead of a pointer, so
make the decoding functions take a reference as well.

* Platform/CoreIPC/ArgumentCoder.h:
(CoreIPC::ArgumentCoder::decode):
* Platform/CoreIPC/ArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeStringText):
* Platform/CoreIPC/ArgumentCoders.h:
(CoreIPC::SimpleArgumentCoder::decode):
* Platform/CoreIPC/ArgumentDecoder.h:
(CoreIPC::ArgumentDecoder::decode):
* Platform/CoreIPC/Arguments.h:
(CoreIPC::Arguments0::decode):
(CoreIPC::Arguments1::decode):
(CoreIPC::Arguments2::decode):
(CoreIPC::Arguments3::decode):
(CoreIPC::Arguments4::decode):
(CoreIPC::Arguments5::decode):
(CoreIPC::Arguments6::decode):
(CoreIPC::Arguments7::decode):
(CoreIPC::Arguments8::decode):
(CoreIPC::Arguments10::decode):
* Platform/CoreIPC/Attachment.cpp:
(CoreIPC::Attachment::decode):
* Platform/CoreIPC/Attachment.h:
(Attachment):
* Platform/CoreIPC/DataReference.cpp:
(CoreIPC::DataReference::decode):
* Platform/CoreIPC/DataReference.h:
(DataReference):
* Platform/CoreIPC/StringReference.cpp:
(CoreIPC::StringReference::decode):
* Platform/CoreIPC/StringReference.h:
(StringReference):
* Platform/CoreIPC/mac/MachPort.h:
(CoreIPC::MachPort::decode):
* Platform/SharedMemory.h:
(Handle):
* Platform/mac/SharedMemoryMac.cpp:
(WebKit::SharedMemory::Handle::decode):
* PluginProcess/PluginCreationParameters.cpp:
(WebKit::PluginCreationParameters::decode):
* PluginProcess/PluginCreationParameters.h:
(PluginCreationParameters):
* Shared/DictionaryPopupInfo.cpp:
(WebKit::DictionaryPopupInfo::decode):
* Shared/DictionaryPopupInfo.h:
(DictionaryPopupInfo):
* Shared/EditorState.cpp:
(WebKit::EditorState::decode):
* Shared/EditorState.h:
(EditorState):
* Shared/FontInfo.cpp:
(WebKit::FontInfo::decode):
* Shared/FontInfo.h:
(FontInfo):
* Shared/LayerTreeContext.h:
(LayerTreeContext):
* Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::decode):
* Shared/Network/NetworkProcessCreationParameters.h:
(NetworkProcessCreationParameters):
* Shared/Network/NetworkResourceLoadParameters.cpp:
(WebKit::NetworkResourceLoadParameters::decode):
* Shared/Network/NetworkResourceLoadParameters.h:
(NetworkResourceLoadParameters):
* Shared/OriginAndDatabases.cpp:
(WebKit::OriginAndDatabases::decode):
* Shared/OriginAndDatabases.h:
(OriginAndDatabases):
* Shared/PlatformPopupMenuData.cpp:
(WebKit::PlatformPopupMenuData::decode):
* Shared/PlatformPopupMenuData.h:
(PlatformPopupMenuData):
* Shared/Plugins/NPIdentifierData.cpp:
(WebKit::NPIdentifierData::decode):
* Shared/Plugins/NPIdentifierData.h:
(NPIdentifierData):
* Shared/Plugins/NPVariantData.cpp:
(WebKit::NPVariantData::decode):
* Shared/Plugins/NPVariantData.h:
(NPVariantData):
* Shared/Plugins/PluginProcessCreationParameters.cpp:
(WebKit::PluginProcessCreationParameters::decode):
* Shared/Plugins/PluginProcessCreationParameters.h:
(PluginProcessCreationParameters):
* Shared/PrintInfo.cpp:
(WebKit::PrintInfo::decode):
* Shared/PrintInfo.h:
(PrintInfo):
* Shared/SandboxExtension.h:
(Handle):
(HandleArray):
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):
* Shared/SecurityOriginData.cpp:
(WebKit::SecurityOriginData::decode):
* Shared/SecurityOriginData.h:
(SecurityOriginData):
* Shared/SessionState.cpp:
(WebKit::SessionState::decode):
* Shared/SessionState.h:
(SessionState):
* Shared/ShareableBitmap.cpp:
(WebKit::ShareableBitmap::Handle::decode):
* Shared/ShareableBitmap.h:
(Handle):
* Shared/ShareableResource.cpp:
(WebKit::ShareableResource::Handle::decode):
* Shared/ShareableResource.h:
(Handle):
* Shared/SharedWorkerProcessCreationParameters.cpp:
(WebKit::SharedWorkerProcessCreationParameters::decode):
* Shared/SharedWorkerProcessCreationParameters.h:
(SharedWorkerProcessCreationParameters):
* Shared/StatisticsData.cpp:
(WebKit::StatisticsData::decode):
* Shared/StatisticsData.h:
(StatisticsData):
* Shared/StringPairVector.h:
(WebKit::StringPairVector::decode):
* Shared/UpdateInfo.cpp:
(WebKit::UpdateInfo::decode):
* Shared/UpdateInfo.h:
(UpdateInfo):
* Shared/UserMessageCoders.h:
(WebKit::UserMessageDecoder::baseDecode):
* Shared/WebContextMenuItemData.cpp:
(WebKit::WebContextMenuItemData::decode):
* Shared/WebContextMenuItemData.h:
(WebContextMenuItemData):
* Shared/WebCoreArgumentCoders.cpp:
(CoreIPC::::decode):
(CoreIPC::decodeImage):
* Shared/WebCoreArgumentCoders.h:
* Shared/WebEvent.cpp:
(WebKit::WebEvent::decode):
* Shared/WebEvent.h:
(WebEvent):
(WebMouseEvent):
(WebWheelEvent):
(WebKeyboardEvent):
(WebGestureEvent):
(WebPlatformTouchPoint):
(WebTouchEvent):
* Shared/WebGeolocationPosition.cpp:
(WebKit::WebGeolocationPosition::Data::decode):
* Shared/WebGeolocationPosition.h:
(Data):
* Shared/WebGestureEvent.cpp:
(WebKit::WebGestureEvent::decode):
* Shared/WebHitTestResult.cpp:
(WebKit::WebHitTestResult::Data::decode):
* Shared/WebHitTestResult.h:
(Data):
* Shared/WebKeyboardEvent.cpp:
(WebKit::WebKeyboardEvent::decode):
* Shared/WebMouseEvent.cpp:
(WebKit::WebMouseEvent::decode):
* Shared/WebNavigationDataStore.h:
(WebKit::WebNavigationDataStore::decode):
* Shared/WebPageCreationParameters.cpp:
(WebKit::WebPageCreationParameters::decode):
* Shared/WebPageCreationParameters.h:
(WebPageCreationParameters):
* Shared/WebPageGroupData.cpp:
(WebKit::WebPageGroupData::decode):
* Shared/WebPageGroupData.h:
(WebPageGroupData):
* Shared/WebPlatformTouchPoint.cpp:
(WebKit::WebPlatformTouchPoint::decode):
* Shared/WebPopupItem.cpp:
(WebKit::WebPopupItem::decode):
* Shared/WebPopupItem.h:
* Shared/WebPreferencesStore.cpp:
(WebKit::WebPreferencesStore::decode):
* Shared/WebPreferencesStore.h:
(WebPreferencesStore):
* Shared/WebProcessCreationParameters.cpp:
(WebKit::WebProcessCreationParameters::decode):
* Shared/WebProcessCreationParameters.h:
(WebProcessCreationParameters):
* Shared/WebTouchEvent.cpp:
(WebKit::WebTouchEvent::decode):
* Shared/WebWheelEvent.cpp:
(WebKit::WebWheelEvent::decode):
* Shared/cf/ArgumentCodersCF.cpp:
(CoreIPC::decode):
* Shared/cf/ArgumentCodersCF.h:
(CoreIPC):
* Shared/mac/ArgumentCodersMac.h:
(CoreIPC):
* Shared/mac/ArgumentCodersMac.mm:
(CoreIPC::decode):
* Shared/mac/AttributedString.h:
(AttributedString):
* Shared/mac/AttributedString.mm:
(WebKit::AttributedString::decode):
* Shared/mac/ColorSpaceData.h:
(ColorSpaceData):
* Shared/mac/ColorSpaceData.mm:
(WebKit::ColorSpaceData::decode):
* Shared/mac/LayerTreeContextMac.mm:
(WebKit::LayerTreeContext::decode):
* Shared/mac/ObjCObjectGraphCoders.h:
(WebContextObjCObjectGraphDecoder):
(InjectedBundleObjCObjectGraphDecoder):
* Shared/mac/ObjCObjectGraphCoders.mm:
(WebKit::ObjCObjectGraphDecoder::baseDecode):
(WebKit::WebContextObjCObjectGraphDecoderImpl::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoderImpl::decode):
(WebKit::WebContextObjCObjectGraphDecoder::decode):
(WebKit::InjectedBundleObjCObjectGraphDecoder::decode):
* Shared/mac/PlatformCertificateInfo.h:
(PlatformCertificateInfo):
* Shared/mac/PlatformCertificateInfo.mm:
(WebKit::PlatformCertificateInfo::decode):
* Shared/mac/RemoteLayerTreeTransaction.h:
(LayerProperties):
(RemoteLayerTreeTransaction):
* Shared/mac/RemoteLayerTreeTransaction.mm:
(WebKit::RemoteLayerTreeTransaction::LayerProperties::decode):
(WebKit::RemoteLayerTreeTransaction::decode):
* Shared/mac/SandboxExtensionMac.mm:
(WebKit::SandboxExtension::Handle::decode):
(WebKit::SandboxExtension::HandleArray::decode):
* Shared/mac/SecItemRequestData.cpp:
(WebKit::SecItemRequestData::decode):
* Shared/mac/SecItemRequestData.h:
* Shared/mac/SecItemResponseData.cpp:
(WebKit::SecItemResponseData::decode):
* Shared/mac/SecItemResponseData.h:
(SecItemResponseData):
* Shared/mac/WebCoreArgumentCodersMac.mm:
(CoreIPC::::decodePlatformData):
(CoreIPC::::decode):
* UIProcess/WebContextUserMessageCoders.h:
(WebKit::WebContextUserMessageDecoder::decode):
* WebProcess/InjectedBundle/InjectedBundleUserMessageCoders.h:
(WebKit::InjectedBundleUserMessageDecoder::decode):
* WebProcess/Plugins/Plugin.cpp:
(WebKit::Plugin::Parameters::decode):
* WebProcess/Plugins/Plugin.h:
(Parameters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSmart link can erroneously move caret after an URL when typing immediately before it
rniwa@webkit.org [Fri, 1 Feb 2013 19:44:37 +0000 (19:44 +0000)]
Smart link can erroneously move caret after an URL when typing immediately before it
https://bugs.webkit.org/show_bug.cgi?id=92812

Reviewed by Enrica Casucci.

Source/WebCore:

The bug was caused by smart link being triggered even when a user finished typing a word
immediately before an URL. We already had a logic to avoid smart-linking an URL when the caret
was after the URL but we were missing a check for when the caret is before the URL.

Fixed the bug by adding this check.

Test: editing/inserting/smart-link-when-caret-is-moved-before-URL.html

* editing/Editor.cpp:
(WebCore::Editor::markAndReplaceFor):

LayoutTests:

Add a regression for typing immediately before an URL while smart link is enabled.
WebKit should not be moving the caret erroneously.

* editing/inserting/smart-link-when-caret-is-moved-before-URL-expected.txt: Added.
* editing/inserting/smart-link-when-caret-is-moved-before-URL.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Windows build fix. FloatSize.cpp was not included in the project.
roger_fong@apple.com [Fri, 1 Feb 2013 19:40:32 +0000 (19:40 +0000)]
Unreviewed. Windows build fix. FloatSize.cpp was not included in the project.

* WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks
jchaffraix@webkit.org [Fri, 1 Feb 2013 19:29:18 +0000 (19:29 +0000)]
[CSS Grid Layout] computePreferredLogicalWidths doesn't handle minmax tracks
https://bugs.webkit.org/show_bug.cgi?id=108403

Reviewed by Ojan Vafai.

Source/WebCore:

Test: fast/css-grid-layout/grid-preferred-logical-widths.html

The code before this change was only handling minmax() with 2 fixed widths.
The new code was updated to remove this artificial limitation and we now
support all combination of minmax().

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::computePreferredLogicalWidths):
Updated to use computePreferredTrackWidth..

(WebCore::RenderGrid::computePreferredTrackWidth):
Added this helper function that implements the core of the preferred width
computation.

* rendering/RenderGrid.h: Added computePreferredTrackWidth.

LayoutTests:

* fast/css-grid-layout/grid-preferred-logical-widths-expected.txt: Added.
* fast/css-grid-layout/grid-preferred-logical-widths.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCached main resources report a zero identifer on 304s
japhet@chromium.org [Fri, 1 Feb 2013 19:25:38 +0000 (19:25 +0000)]
Cached main resources report a zero identifer on 304s
https://bugs.webkit.org/show_bug.cgi?id=108402

Reviewed by Adam Barth.

Source/WebCore:

Test: http/tests/cache/iframe-304-crash.html

* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::responseReceived): Throughout, check m_identifierForLoadWithoutResourceLoader
    instead of !loader() to determine whether MainResourceLoader needs to synthesize resource load callbacks.
(WebCore::MainResourceLoader::dataReceived):
(WebCore::MainResourceLoader::didFinishLoading):

LayoutTests:

* http/tests/cache/iframe-304-crash-expected.txt: Added.
* http/tests/cache/iframe-304-crash.html: Added.
* http/tests/cache/resources/iframe304.php: Added.
* platform/chromium/TestExpectations: New test requires main resource caching, which isn't supported on chromium at the moment.
* platform/mac/TestExpectations: New test requires main resource caching, which isn't supported on mac at the moment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Build webkit with enable_web_intents set to 0.
thakis@chromium.org [Fri, 1 Feb 2013 19:14:03 +0000 (19:14 +0000)]
[chromium] Build webkit with enable_web_intents set to 0.
https://bugs.webkit.org/show_bug.cgi?id=108408

Reviewed by Tony Chang.

I'll then make chromium build fine with that, then switch
enable_web_intents to 0, roll that into webkit, and then
actually remove the code hidden behind this flag.

Source/WebCore:

* bindings/v8/custom/V8IntentCustom.cpp:

Source/WebKit/chromium:

The features.gypi bit depends on https://codereview.chromium.org/12143002/
and will disable web intents support on android. Since common.gypi
sets enable_web_intents to 0 explicitly, it seems this is currently on
by accident anyway.

While it looks like this CL just removes ENABLE_WEB_INTENTS=1 from
features.gypi completely, it's still set further down the file if
enable_web_intents is on.

* WebKit.gyp:
* features.gypi:
* src/WebFrameImpl.cpp:

Tools:

* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::registerIntentService):
(WebTestRunner::WebTestProxyBase::dispatchIntent):
* DumpRenderTree/chromium/WebViewHost.cpp:
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: make console object state hint non-active
pfeldman@chromium.org [Fri, 1 Feb 2013 19:07:46 +0000 (19:07 +0000)]
Web Inspector: make console object state hint non-active
https://bugs.webkit.org/show_bug.cgi?id=108642

Reviewed by Vsevolod Vlasov.

Otherwise it seems like an active element user could click.

* inspector/front-end/inspector.css:
(.object-info-state-note):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoZero size gradient should paint nothing on canvas
commit-queue@webkit.org [Fri, 1 Feb 2013 19:04:43 +0000 (19:04 +0000)]
Zero size gradient should paint nothing on canvas
https://bugs.webkit.org/show_bug.cgi?id=102654

Patch by Rashmi Shyamasundar <rashmi.s2@samsung.com> on 2013-02-01
Reviewed by Dirk Schulze.

Source/WebCore:

The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.

Tests: fast/canvas/canvas-fill-zeroSizeGradient.html
       fast/canvas/canvas-fillRect-zeroSizeGradient.html
       fast/canvas/canvas-fillText-zeroSizeGradient.html
       fast/canvas/canvas-stroke-zeroSizeGradient.html
       fast/canvas/canvas-strokeRect-zeroSizeGradient.html
       fast/canvas/canvas-strokeText-zeroSizeGradient.html

* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::fill):
(WebCore::CanvasRenderingContext2D::stroke):
(WebCore::CanvasRenderingContext2D::strokeRect):
(WebCore::CanvasRenderingContext2D::drawTextInternal):

LayoutTests:

The functions fill(), fillText(), stroke(), strokeRect() and strokeText()
should paint nothing on canvas when the canvas fillStyle/strokeStyle
is set to a zero size gradient.

* fast/canvas/canvas-fill-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-fill-zeroSizeGradient.html: Added.
* fast/canvas/canvas-fillRect-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-fillRect-zeroSizeGradient.html: Added.
* fast/canvas/canvas-fillText-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-fillText-zeroSizeGradient.html: Added.
* fast/canvas/canvas-stroke-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-stroke-zeroSizeGradient.html: Added.
* fast/canvas/canvas-strokeRect-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-strokeRect-zeroSizeGradient.html: Added.
* fast/canvas/canvas-strokeText-zeroSizeGradient-expected.txt: Added.
* fast/canvas/canvas-strokeText-zeroSizeGradient.html: Added.
* fast/canvas/script-tests/canvas-fill-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-fillRect-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-fillText-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-stroke-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-strokeRect-zeroSizeGradient.js: Added.
* fast/canvas/script-tests/canvas-strokeText-zeroSizeGradient.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHRTFElevation segfault if a null AudioBus is returned by loadPlatformResource
commit-queue@webkit.org [Fri, 1 Feb 2013 19:00:13 +0000 (19:00 +0000)]
HRTFElevation segfault if a null AudioBus is returned by loadPlatformResource
https://bugs.webkit.org/show_bug.cgi?id=108504

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-02-01
Reviewed by Kenneth Russell.

Fixed a segfault by checking if the returned AudioBus is null or not.
If it is, we should early return in the same way it was being done already
in HRTFElevation::calculateKernelsForAzimuthElevation();

No new tests, covered by existing tests.

* platform/audio/HRTFElevation.cpp:
(WebCore::getConcatenatedImpulseResponsesForSubject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoScrollAnimatorMac should adopt contentAreaScrolledInDirection
bdakin@apple.com [Fri, 1 Feb 2013 18:59:08 +0000 (18:59 +0000)]
ScrollAnimatorMac should adopt contentAreaScrolledInDirection
https://bugs.webkit.org/show_bug.cgi?id=108647
-and corresponding-
<rdar://problem/12434779>

Reviewed by Anders Carlsson.

This patch makes notifyContentAreaScrolled() and notifyPositionChanged() take a
FloatSize parameter that represents the scroll delta so that it can be passed
along to contentAreaScrolledInDirection:.

Pass along the scroll delta.
* platform/ScrollAnimator.cpp:
(WebCore::ScrollAnimator::scroll):
(WebCore::ScrollAnimator::scrollToOffsetWithoutAnimation):

The delta is not needed in this base-class implementation. It will only be needed
in the ScrollAnimatorMac override.
(WebCore::ScrollAnimator::notifyPositionChanged):
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::notifyContentAreaScrolled):

Pass along the delta.
* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scrollToOffsetWithoutAnimation):
(WebCore::ScrollAnimatorNone::animationTimerFired):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::scrollPositionChanged):

Add contentAreaScrolledInDirection: to the NSScrollerImpDetails.
* platform/mac/NSScrollerImpDetails.h:

New member variable m_contentAreaScrolledTimerScrollDelta stores the current
scroll delta while we are waiting for m_sendContentAreaScrolledTimer to fire.
* platform/mac/ScrollAnimatorMac.h:

We need this so that we can call just contentAreaScrolled if
contentAreaScrolledInDirection: is not available.
* platform/mac/ScrollAnimatorMac.mm:
(supportsContentAreaScrolledInDirection):

Pass along the delta.
(WebCore::ScrollAnimatorMac::immediateScrollTo):
(WebCore::ScrollAnimatorMac::notifyPositionChanged):
(WebCore::ScrollAnimatorMac::mayBeginScrollGesture):
(WebCore::ScrollAnimatorMac::notifyContentAreaScrolled):
(WebCore::ScrollAnimatorMac::immediateScrollBy):
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledSoon):

If contentAreaScrolledInDirection: is available, call it with the delta, and then
reset our delta. Otherwise, still call contentAreaScrolled.
(WebCore::ScrollAnimatorMac::sendContentAreaScrolledTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebKit/chromium: [Chromium] Ignore whitespace in spellcheck
commit-queue@webkit.org [Fri, 1 Feb 2013 18:55:09 +0000 (18:55 +0000)]
Source/WebKit/chromium: [Chromium] Ignore whitespace in spellcheck
https://bugs.webkit.org/show_bug.cgi?id=108510

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.

* src/ContextMenuClientImpl.cpp:
(WebKit::selectMisspellingAsync): Ignore whitespace when selecting the misspelling.

LayoutTests: [Chromium] Expect spellcheck to ignore whitespace
https://bugs.webkit.org/show_bug.cgi?id=108510

Patch by Rouslan Solomakhin <rouslan@chromium.org> on 2013-02-01
Reviewed by Ryosuke Niwa.

* platform/chromium/TestExpectations: Expect spellcheck to ignore whitespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [file selector dialog] for mixed case queries, score uppercase letters...
pfeldman@chromium.org [Fri, 1 Feb 2013 18:49:10 +0000 (18:49 +0000)]
Web Inspector: [file selector dialog] for mixed case queries, score uppercase letters only when assessing camelcase.
https://bugs.webkit.org/show_bug.cgi?id=108639

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):

LayoutTests:

* inspector/filtered-item-selection-dialog-filtering-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPadding in a parent inline preceding an empty inline child should be counted towards...
robert@webkit.org [Fri, 1 Feb 2013 18:45:27 +0000 (18:45 +0000)]
Padding in a parent inline preceding an empty inline child should be counted towards width
https://bugs.webkit.org/show_bug.cgi?id=108226

Reviewed by Levi Weintraub.

Source/WebCore:

Add the border/padding/margin from an empty inline's parent inline if it is the first or last
child of the inline.

Tests: fast/inline/parent-inline-element-padding-contributes-width.html
       fast/inline/positioned-element-padding-contributes-width.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/inline/parent-inline-element-padding-contributes-width-expected.txt: Added.
* fast/inline/parent-inline-element-padding-contributes-width.html: Added.
* fast/inline/positioned-element-padding-contributes-width-expected.txt: Added.
* fast/inline/positioned-element-padding-contributes-width.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoContinue making XSSAuditor thread safe: Remove dependencies on m_parser from init()
tonyg@chromium.org [Fri, 1 Feb 2013 18:40:20 +0000 (18:40 +0000)]
Continue making XSSAuditor thread safe: Remove dependencies on m_parser from init()
https://bugs.webkit.org/show_bug.cgi?id=108531

Reviewed by Adam Barth.

The threaded HTML parser will create and init() the XSSAuditor on the main thread, but filterToken() will be called on the background.

No new tests because no change in functionality.

* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/XSSAuditor.cpp:
(WebCore::XSSAuditor::XSSAuditor):
(WebCore::XSSAuditor::init):
(WebCore::XSSAuditor::filterToken):
* html/parser/XSSAuditor.h:
(WebCore):
(XSSAuditor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141605 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved an unused function: JSGlobalObject::createFunctionExecutableFromGlobalCode
ggaren@apple.com [Fri, 1 Feb 2013 18:32:23 +0000 (18:32 +0000)]
Removed an unused function: JSGlobalObject::createFunctionExecutableFromGlobalCode
https://bugs.webkit.org/show_bug.cgi?id=108657

Reviewed by Anders Carlsson.

* runtime/JSGlobalObject.cpp:
(JSC):
* runtime/JSGlobalObject.h:
(JSGlobalObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
beidson@apple.com [Fri, 1 Feb 2013 18:31:09 +0000 (18:31 +0000)]
Remove unnecessary parameter from DocumentLoader::scheduleArchiveLoad
https://bugs.webkit.org/show_bug.cgi?id=108654

Reviewed by Alexey Proskuryakov.

No new tests (No behavior change.)

Remove the KURL parameter parameter from this method which, in practice,
is always the same as the url of the ResourceRequest parameter.

* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::scheduleArchiveLoad):
* loader/DocumentLoader.h:

* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSet the GTK 64-bit Debug builder to build and test only WebKit1
zandobersek@gmail.com [Fri, 1 Feb 2013 18:18:27 +0000 (18:18 +0000)]
Set the GTK 64-bit Debug builder to build and test only WebKit1
https://bugs.webkit.org/show_bug.cgi?id=108648

Reviewed by Philippe Normand.

* BuildSlaveSupport/build.webkit.org-config/config.json: Change the builder name, type and
build directory to note that the builder builds and tests only the WebKit1 port on the GTK platform.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileWebKit1Only): Add the new build class that builds only the WebKit1 port of the builder's platform.
(BuildAndTestWebKit1OnlyFactory): Add the new factory that uses the CompileWebKit1Only build class
for building and testing only WebKit1 on the builder's platform.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Adapt WorkQueueGtk to the latest changes in WebKit2 after r141497
carlosgc@webkit.org [Fri, 1 Feb 2013 17:18:16 +0000 (17:18 +0000)]
[GTK] Adapt WorkQueueGtk to the latest changes in WebKit2 after r141497
https://bugs.webkit.org/show_bug.cgi?id=108607

Reviewed by Anders Carlsson.

* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::executeEventSource): Remove the is valid
work queue check.
(WorkQueue::EventSource): WorkQueue is now refcounted, so keep a
reference when a new job is scheduled and unref it when it
finishes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Make QWebHistory unit tests more robust
hausmann@webkit.org [Fri, 1 Feb 2013 16:34:05 +0000 (16:34 +0000)]
[Qt] Make QWebHistory unit tests more robust

Reviewed by Jocelyn Turcotten.

The tests were using a QEventLoop::exec() call to verify the emission
of the loadFinished() signal after calling for example back() or forward().
However sometimes the call to back() may emit the signal immediately and
sometimes async, causing instabilities in test runs. The call to exec()
also means that if there was a bug then the rest would hang forever because
exec() has no timeout.

This patch introduces a simple SignalBarrier class that solves both issues:

(1) ensureSignalEmitted() supports the immediate signal emission case as well
as the async one.

(2) Through the use of QSignalSpy's wait() there's an actual timeout.

* tests/qwebhistory/tst_qwebhistory.cpp:
(tst_QWebHistory::init):
(tst_QWebHistory::cleanup):
(tst_QWebHistory::back):
(tst_QWebHistory::forward):
(tst_QWebHistory::goToItem):
(tst_QWebHistory::serialize_2):
* tests/util.h:
(waitForSignal):
(SignalBarrier):
(SignalBarrier::SignalBarrier):
(SignalBarrier::ensureSignalEmitted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, GTK build fix after r141566.
philn@webkit.org [Fri, 1 Feb 2013 16:14:46 +0000 (16:14 +0000)]
Unreviewed, GTK build fix after r141566.

* POTFILES.in: The FullscreenVideoController moved to WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] move ownership of TestRunner object to TestInterfaces
jochen@chromium.org [Fri, 1 Feb 2013 16:02:07 +0000 (16:02 +0000)]
[chromium] move ownership of TestRunner object to TestInterfaces
https://bugs.webkit.org/show_bug.cgi?id=108464

Reviewed by Adam Barth.

Before, TestShell owned the class. This also removes the last include
from DumpRenderTree to TestRunner/src.

This also deletes TestDelegate and uses WebTestDelegate everywhere
instead.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebTestInterfaces):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebKit):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.cpp:
* DumpRenderTree/chromium/TestRunner/src/AccessibilityControllerChromium.h:
(WebTestRunner):
(WebTestRunner::AccessibilityController::setDelegate):
(AccessibilityController):
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::makeMenuItemStringsFor):
* DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebTestRunner):
(WebTestRunner::EventSender::setDelegate):
(EventSender):
* DumpRenderTree/chromium/TestRunner/src/GamepadController.cpp:
(WebTestRunner::GamepadController::setDelegate):
* DumpRenderTree/chromium/TestRunner/src/GamepadController.h:
(WebTestRunner):
(GamepadController):
* DumpRenderTree/chromium/TestRunner/src/TestDelegate.h: Removed.
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::TestInterfaces):
(WebTestRunner::TestInterfaces::~TestInterfaces):
(WebTestRunner::TestInterfaces::setWebView):
(WebTestRunner::TestInterfaces::setDelegate):
(WebTestRunner::TestInterfaces::bindTo):
(WebTestRunner::TestInterfaces::resetAll):
(WebTestRunner):
(WebTestRunner::TestInterfaces::setTestIsRunning):
(WebTestRunner::TestInterfaces::testRunner):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebTestRunner):
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
(WebTestRunner::TestRunner::reset):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(WebKit):
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::Internal::testRunner):
(WebTestInterfaces::Internal):
(WebTestRunner::WebTestInterfaces::Internal::Internal):
(WebTestRunner::WebTestInterfaces::Internal::setDelegate):
(WebTestRunner::WebTestInterfaces::Internal::setTestIsRunning):
* DumpRenderTree/chromium/TestRunner/src/WebTestRunner.cpp: Added.
(WebTestRunner):
(WebTestRunner::WebTestRunner::WebTestRunner):
(WebTestRunner::WebTestRunner::shouldDumpEditingCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpAsText):
(WebTestRunner::WebTestRunner::setShouldDumpAsText):
(WebTestRunner::WebTestRunner::shouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::setShouldGeneratePixelResults):
(WebTestRunner::WebTestRunner::shouldDumpChildFrameScrollPositions):
(WebTestRunner::WebTestRunner::shouldDumpChildFramesAsText):
(WebTestRunner::WebTestRunner::shouldDumpAsAudio):
(WebTestRunner::WebTestRunner::audioData):
(WebTestRunner::WebTestRunner::shouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::setShouldDumpFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpUserGestureInFrameLoadCallbacks):
(WebTestRunner::WebTestRunner::stopProvisionalFrameLoads):
(WebTestRunner::WebTestRunner::shouldDumpTitleChanges):
(WebTestRunner::WebTestRunner::shouldDumpCreateView):
(WebTestRunner::WebTestRunner::canOpenWindows):
(WebTestRunner::WebTestRunner::shouldDumpResourceLoadCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceRequestCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpResourceResponseMIMETypes):
(WebTestRunner::WebTestRunner::webPermissions):
(WebTestRunner::WebTestRunner::shouldDumpStatusCallbacks):
(WebTestRunner::WebTestRunner::shouldDumpProgressFinishedCallback):
(WebTestRunner::WebTestRunner::shouldDumpBackForwardList):
(WebTestRunner::WebTestRunner::deferMainResourceDataLoad):
(WebTestRunner::WebTestRunner::shouldDumpSelectionRect):
(WebTestRunner::WebTestRunner::testRepaint):
(WebTestRunner::WebTestRunner::sweepHorizontally):
(WebTestRunner::WebTestRunner::isPrinting):
(WebTestRunner::WebTestRunner::shouldStayOnPageAfterHandlingBeforeUnload):
(WebTestRunner::WebTestRunner::setTitleTextDirection):
(WebTestRunner::WebTestRunner::httpHeadersToClear):
(WebTestRunner::WebTestRunner::shouldBlockRedirects):
(WebTestRunner::WebTestRunner::willSendRequestShouldReturnNull):
(WebTestRunner::WebTestRunner::setTopLoadingFrame):
(WebTestRunner::WebTestRunner::topLoadingFrame):
(WebTestRunner::WebTestRunner::policyDelegateDone):
(WebTestRunner::WebTestRunner::policyDelegateEnabled):
(WebTestRunner::WebTestRunner::policyDelegateIsPermissive):
(WebTestRunner::WebTestRunner::policyDelegateShouldNotifyDone):
(WebTestRunner::WebTestRunner::shouldInterceptPostMessage):
(WebTestRunner::WebTestRunner::isSmartInsertDeleteEnabled):
(WebTestRunner::WebTestRunner::isSelectTrailingWhitespaceEnabled):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::runFileTest):
(TestShell::resetTestController):
(TestShell::dump):
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::testRunner):
(TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r180131. Requested by
commit-queue@webkit.org [Fri, 1 Feb 2013 15:58:35 +0000 (15:58 +0000)]
Unreviewed.  Rolled Chromium DEPS to r180131.  Requested by
"Florin Malita" <fmalita@chromium.org> via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: relax goto file matching again.
pfeldman@chromium.org [Fri, 1 Feb 2013 15:46:32 +0000 (15:46 +0000)]
Web Inspector: relax goto file matching again.
https://bugs.webkit.org/show_bug.cgi?id=108346

Reviewed by Vsevolod Vlasov.

Source/WebCore:

This change brings back behavior introduced in r116244.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._createSearchRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._createScoringRegex):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems.compareFunction):
(WebInspector.FilteredItemSelectionDialog.prototype._filterItems):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):
(WebInspector.FilteredItemSelectionDialog.prototype.itemElement):
(WebInspector.OpenResourceDialog):
* inspector/front-end/utilities.js:
(String.regexSpecialCharacters):
(String.prototype.escapeForRegExp):

LayoutTests:

* inspector/filtered-item-selection-dialog-filtering-expected.txt:
* inspector/filtered-item-selection-dialog-filtering.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Navigator should not create tree elements for uiSourceCodes unless...
vsevik@chromium.org [Fri, 1 Feb 2013 15:43:25 +0000 (15:43 +0000)]
Web Inspector: Navigator should not create tree elements for uiSourceCodes unless neededm should populate folders on expand only.
https://bugs.webkit.org/show_bug.cgi?id=108601

Reviewed by Pavel Feldman.

Source/WebCore:

Tree elememnts for uiSourceCodes are not created until really needed anymore.
They are now created when parent folder tree elememnts are expanded or when uiSourceCode is revealed in navigator.

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView):
(WebInspector.NavigatorView.prototype.addUISourceCode):
(WebInspector.NavigatorView.prototype._getOrCreateScriptTreeElement):
(WebInspector.NavigatorView.prototype._getScriptTreeElement):
(WebInspector.NavigatorView.prototype._createScriptTreeElement):
(WebInspector.NavigatorView.prototype._removeScriptTreeElement):
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.isScriptSourceAdded):
(WebInspector.NavigatorView.prototype.revealUISourceCode):
(WebInspector.NavigatorView.prototype.removeUISourceCode):
(WebInspector.NavigatorView.prototype.reset):
(WebInspector.NavigatorView.prototype.createFolderTreeElement):
(WebInspector.NavigatorView.prototype._populateFolderTreeElement):
(WebInspector.NavigatorView.prototype._addScriptTreeElement):
(WebInspector.NavigatorView.prototype._adoptUISourceCode):
(WebInspector.NavigatorFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement.prototype.onpopulate):

LayoutTests:

* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest.):
(initialize_DebuggerTest):
* inspector/debugger/scripts-file-selector-expected.txt:
* inspector/debugger/scripts-file-selector.html:
* inspector/debugger/scripts-sorting-expected.txt:
* inspector/debugger/scripts-sorting.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, flagging more fullscreen tests in GTK due to bug 108363.
philn@webkit.org [Fri, 1 Feb 2013 15:40:12 +0000 (15:40 +0000)]
Unreviewed, flagging more fullscreen tests in GTK due to bug 108363.

* platform/gtk/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141592 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Native Memory Instrumentation: provide edge names and class names...
loislo@chromium.org [Fri, 1 Feb 2013 15:32:35 +0000 (15:32 +0000)]
Web Inspector: Native Memory Instrumentation: provide edge names and class names for WTF containers and strings
https://bugs.webkit.org/show_bug.cgi?id=107303

Reviewed by Yury Semikhatsky.

I'd like to use ValueType[] as className for the container data members
because class names of template parameters already present in the container class names.

* wtf/MemoryInstrumentationArrayBufferView.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationHashCountedSet.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationHashMap.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationHashSet.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationListHashSet.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationSequence.h:
* wtf/MemoryInstrumentationString.h:
(WTF::reportMemoryUsage):
* wtf/MemoryInstrumentationVector.h:
(WTF::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPatchLog process durations are increasing linearly with time (faulty data logging)
commit-queue@webkit.org [Fri, 1 Feb 2013 15:27:15 +0000 (15:27 +0000)]
PatchLog process durations are increasing linearly with time (faulty data logging)
https://bugs.webkit.org/show_bug.cgi?id=108621

Patch by Alan Cutter <alancutter@chromium.org> on 2013-02-01
Reviewed by Eric Seidel.

Added a check to prevent a stop event from happening to the same patch multiple times.

* QueueStatusServer/loggers/recordpatchevent.py:
(RecordPatchEvent.stopped):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: TabbedEditorContainer.History performance optimization.
vsevik@chromium.org [Fri, 1 Feb 2013 15:27:03 +0000 (15:27 +0000)]
Web Inspector: TabbedEditorContainer.History performance optimization.
https://bugs.webkit.org/show_bug.cgi?id=108581

Introduced history items indexing by url.

Reviewed by Pavel Feldman.

Covered by existing test.

* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.History):
(WebInspector.TabbedEditorContainer.History.prototype.index):
(WebInspector.TabbedEditorContainer.History.prototype._rebuildItemIndex):
(WebInspector.TabbedEditorContainer.History.prototype.update):
(WebInspector.TabbedEditorContainer.History.prototype.remove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdded TriState to WTF and started using it in one place
ggaren@apple.com [Fri, 1 Feb 2013 15:01:34 +0000 (15:01 +0000)]
Added TriState to WTF and started using it in one place
https://bugs.webkit.org/show_bug.cgi?id=108628

Reviewed by Beth Dakin.

../JavaScriptCore:

* runtime/PrototypeMap.h:
(JSC::PrototypeMap::isPrototype): Use TriState instead of boolean. In
response to review feedback, this is an attempt to clarify that our
'true' condition is actually just a 'maybe'.

* runtime/PrototypeMap.h:
(PrototypeMap):
(JSC::PrototypeMap::isPrototype):

../WebCore:

* editing/EditingStyle.h:
(WebCore): Moved TriState to WTF so it can be used in more places.

../WTF:

Useful for expressing "maybe" conditions in a boolean context.

* WTF.xcodeproj/project.pbxproj:
* wtf/TriState.h: Added.
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r141319.
commit-queue@webkit.org [Fri, 1 Feb 2013 14:17:49 +0000 (14:17 +0000)]
Unreviewed, rolling out r141319.
http://trac.webkit.org/changeset/141319
https://bugs.webkit.org/show_bug.cgi?id=108629

This patch is causing the UIProcess to hang on GTK port when
loading plugins (Requested by chris-qBT_laptop on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-01

* UIProcess/Plugins/unix/PluginProcessProxyUnix.cpp:
(WebKit::PluginProcessProxy::scanPlugin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for WinCE after r137709
paroga@webkit.org [Fri, 1 Feb 2013 14:12:51 +0000 (14:12 +0000)]
Build fix for WinCE after r137709
https://bugs.webkit.org/show_bug.cgi?id=105767

Do not pass functions as const references to
templated arguments to make the compiler happy.

* wtf/StdLibExtras.h:
(WTF::binarySearch):
(WTF::tryBinarySearch):
(WTF::approximateBinarySearch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][WK2] MiniBrowser fullscreen signals support
commit-queue@webkit.org [Fri, 1 Feb 2013 14:11:18 +0000 (14:11 +0000)]
[GTK][WK2] MiniBrowser fullscreen signals support
https://bugs.webkit.org/show_bug.cgi?id=108005

Patch by Manuel Rego Casasnovas <rego@igalia.com> on 2013-02-01
Reviewed by Carlos Garcia Campos.

Shows a label for 2 seconds using overlay (if GTK >= 3.2.0) and hides
the toolbar when entering fullscreen. When leaving fullscreen the
label is hidden (if it's not hidden yet) and the toolbar is shown again.

* MiniBrowser/gtk/BrowserWindow.c:
(_BrowserWindow):
(fullScreenMessageTimeoutCallback):
(webViewEnterFullScreen):
(webViewLeaveFullScreen):
(browserWindowFinalize):
(browserWindowConstructed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 1 Feb 2013 13:42:25 +0000 (13:42 +0000)]
Unreviewed EFL gardening.

Skip some failing tests on EFL bots after r141459 and r141310.

* platform/efl-wk2/TestExpectations:
* platform/efl/TestExpectations:
* platform/efl/fast/js/global-constructors-expected.txt: Revert change from r141573.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] EwkContext should be based on C WK2 API
mikhail.pozdnyakov@intel.com [Fri, 1 Feb 2013 13:08:17 +0000 (13:08 +0000)]
[EFL][WK2] EwkContext should be based on C WK2 API
https://bugs.webkit.org/show_bug.cgi?id=107666

Reviewed by Andreas Kling.

EwkContext should be based on C WK2 API so that API layering is not violated.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
* UIProcess/API/efl/ewk_context.cpp:
(EwkContext::EwkContext):
(EwkContext::create):
(EwkContext::cookieManager):
(EwkContext::ensureFaviconDatabase):
(EwkContext::setFaviconDatabaseDirectoryPath):
(EwkContext::addVisitedLink):
(EwkContext::setCacheModel):
(EwkContext::cacheModel):
(EwkContext::setAdditionalPluginPath):
(EwkContext::clearResourceCache):
* UIProcess/API/efl/ewk_context_private.h:
(EwkContext):
* UIProcess/API/efl/ewk_view.cpp:
(ewk_view_base_add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Fix hanging deleteQWebViewTwice test
hausmann@webkit.org [Fri, 1 Feb 2013 13:00:32 +0000 (13:00 +0000)]
[Qt] Fix hanging deleteQWebViewTwice test

Reviewed by Allan Sandfeld Jensen.

Don't use QCoreApplication::instance()->exec(), because in case of a bug
that never finishes. Instead use waitForSignal() which has the concept of
a timeout.

* tests/qwebpage/tst_qwebpage.cpp:
(tst_QWebPage::deleteQWebViewTwice):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Use C API inside ewk_auth_request
christophe.dumez@intel.com [Fri, 1 Feb 2013 12:56:17 +0000 (12:56 +0000)]
[EFL][WK2] Use C API inside ewk_auth_request
https://bugs.webkit.org/show_bug.cgi?id=107806

Reviewed by Andreas Kling.

Use C API inside ewk_auth_request instead of accessing C++ internal
classes directly, to avoid violating layering.

* UIProcess/API/efl/ewk_auth_request.cpp:
(EwkAuthRequest::EwkAuthRequest):
(EwkAuthRequest::suggestedUsername):
(EwkAuthRequest::realm):
(EwkAuthRequest::host):
(EwkAuthRequest::continueWithoutCredential):
(EwkAuthRequest::authenticate):
(EwkAuthRequest::isRetrying):
(ewk_auth_request_authenticate):
* UIProcess/API/efl/ewk_auth_request_private.h:
(EwkAuthRequest::create):
(EwkAuthRequest):
* UIProcess/efl/PageLoadClientEfl.cpp:
(WebKit::PageLoadClientEfl::didReceiveAuthenticationChallengeInFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Gtk][WK2] Fix build after recent WebKit2 changes
hausmann@webkit.org [Fri, 1 Feb 2013 12:54:33 +0000 (12:54 +0000)]
[Gtk][WK2] Fix build after recent WebKit2 changes
https://bugs.webkit.org/show_bug.cgi?id=108588

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

Don't remove WorkQueue during execution.
Following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544

* Platform/gtk/WorkQueueGtk.cpp:
(WorkQueue::EventSource::~EventSource):
(WorkQueue::EventSource::executeEventSource):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
(WorkQueue::dispatchOnTermination):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Follow up to r141260: fixing renamed style.
pfeldman@chromium.org [Fri, 1 Feb 2013 12:23:56 +0000 (12:23 +0000)]
Web Inspector: Follow up to r141260: fixing renamed style.
Not reviewed.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.FilteredItemSelectionDialog.prototype._createItemElement):
(WebInspector.FilteredItemSelectionDialog.prototype._onClick):
(WebInspector.FilteredItemSelectionDialog.prototype._onMouseMove):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable unprefixed CSS transitions by default.
alexis@webkit.org [Fri, 1 Feb 2013 12:16:51 +0000 (12:16 +0000)]
Enable unprefixed CSS transitions by default.
https://bugs.webkit.org/show_bug.cgi?id=108216

Reviewed by Dean Jackson.

.:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/JavaScriptCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations. Remove the
various #ifdefs and conditional generations.

* Configurations/FeatureDefines.xcconfig:
* DerivedSources.cpp:
* GNUmakefile.features.am.in:
* css/CSSPropertyNames.in:
* dom/EventNames.in:
* dom/TransitionEvent.cpp:
* dom/TransitionEvent.h:
* dom/TransitionEvent.idl:
* page/DOMWindow.idl:
* page/animation/AnimationController.cpp:
(WebCore::AnimationControllerPrivate::fireEventsAndUpdateStyle):

Source/WebKit/chromium:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* features.gypi:

Source/WebKit/mac:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Configurations/FeatureDefines.xcconfig:

Tools:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* Scripts/webkitperl/FeatureList.pm:
* qmake/mkspecs/features/features.pri:

WebKitLibraries:

Rename the flag CSS_TRANSFORMS_ANIMATIONS_TRANSITIONS_UNPREFIXED
to CSS_TRANSFORMS_ANIMATIONS_UNPREFIXED which will be used later to
guard the unprefixing work for CSS Transforms and animations.

* win/tools/vsprops/FeatureDefines.vsprops:
* win/tools/vsprops/FeatureDefinesCairo.vsprops:

LayoutTests:

Unskip the tests by default as now unprefixed CSS Transitions are
enabled by default.

* fast/events/event-creation-expected.txt:
* fast/events/event-creation.html: Add the test that was commented out
before.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r141548.
haraken@chromium.org [Fri, 1 Feb 2013 11:49:35 +0000 (11:49 +0000)]
Unreviewed, rolling out r141548.
http://trac.webkit.org/changeset/141548
https://bugs.webkit.org/show_bug.cgi?id=108579

userscript-plugin-document.html is flaky

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
* bindings/v8/V8GCController.cpp:
(WebCore):
(WebCore::gcTree):
(WebCore::V8GCController::didCreateWrapperForNode):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
* bindings/v8/V8GCController.h:
(V8GCController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Skipped some failing tests.
kadam@inf.u-szeged.hu [Fri, 1 Feb 2013 11:39:56 +0000 (11:39 +0000)]
[Qt] Unreviewed gardening. Skipped some failing tests.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Skip hanging WebGL software fallback tests
hausmann@webkit.org [Fri, 1 Feb 2013 11:27:47 +0000 (11:27 +0000)]
[Qt] Skip hanging WebGL software fallback tests

Reviewed by Allan Sandfeld Jensen.

See also https://bugs.webkit.org/show_bug.cgi?id=105820.

* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::webglSoftwareFallbackVerticalOrientation):
(tst_QGraphicsWebView::webglSoftwareFallbackHorizontalOrientation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: fix jscompiler warnings
aandrey@chromium.org [Fri, 1 Feb 2013 11:26:17 +0000 (11:26 +0000)]
Web Inspector: fix jscompiler warnings
https://bugs.webkit.org/show_bug.cgi?id=108604

Reviewed by Pavel Feldman.

* inspector/front-end/ConsoleView.js:
(WebInspector.ConsoleGroup.prototype.addMessage):
* inspector/front-end/ContextMenu.js:
(WebInspector.ContextSubMenuItem):
* inspector/front-end/ImageView.js:
(WebInspector.ImageView.prototype._copyImageURL):
(WebInspector.ImageView.prototype._openInNewTab):
* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkLogView.prototype._clearBrowserCache):
(WebInspector.NetworkLogView.prototype._clearBrowserCookies):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.IDBDatabaseTreeElement.prototype._refreshIndexedDB):
* inspector/front-end/ScriptsNavigator.js:
(WebInspector.SnippetsNavigatorView.prototype._handleEvaluateSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRenameSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleRemoveSnippet):
(WebInspector.SnippetsNavigatorView.prototype._handleCreateSnippet):
* inspector/front-end/Toolbar.js:
(WebInspector.Toolbar.prototype._isDockedToBottom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 1 Feb 2013 11:22:04 +0000 (11:22 +0000)]
Unreviewed EFL gardening.

Update platform expectations for failing tests after the
WEB_INTENTS flag turned off for EFL port in r141439

* platform/efl/fast/images/crossfade-client-not-removed-crash-expected.txt: Removed.
* platform/efl/fast/js/global-constructors-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
sudarsana.nagineni@linux.intel.com [Fri, 1 Feb 2013 11:00:58 +0000 (11:00 +0000)]
Unreviewed EFL gardening.

Renamed inspector/editor/text-editor-ctrl-movements.html to
inspector/editor/text-editor-word-jumps.html after r141399.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
commit-queue@webkit.org [Fri, 1 Feb 2013 10:51:59 +0000 (10:51 +0000)]
Coordinated Graphics : Sort Target.pri and class declarations in alphabetical order.
https://bugs.webkit.org/show_bug.cgi?id=108590

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-02-01
Reviewed by Noam Rosenthal.

Source/WebCore:

Sort CoordinatedGraphics files in Target.pri in alphabetical order.

No new tests. No change in behavior.

* Target.pri:

Source/WebKit2:

Sort class declarations in alphabetical order.

* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Native Memory Instrumentation: provide edge names to class members...
loislo@chromium.org [Fri, 1 Feb 2013 10:42:37 +0000 (10:42 +0000)]
Web Inspector: Native Memory Instrumentation: provide edge names to class members in all WebCore instrumented classes.
https://bugs.webkit.org/show_bug.cgi?id=107369

Reviewed by Yury Semikhatsky.

It is almost mechanical change generated by a script.
Late I'll implement name to edge name consistency check in clang plugin.

* Modules/webaudio/AudioContext.cpp:
(WebCore::AudioContext::reportMemoryUsage):
* Modules/webaudio/AudioNode.cpp:
(WebCore::AudioNode::reportMemoryUsage):
* bindings/js/ScriptWrappable.h:
(WebCore::ScriptWrappable::reportMemoryUsage):
* bindings/v8/DOMDataStore.cpp:
(WebCore::DOMDataStore::reportMemoryUsage):
* bindings/v8/DOMWrapperMap.h:
(WebCore::DOMWrapperMap::reportMemoryUsage):
* bindings/v8/V8PerIsolateData.cpp:
(WebCore::V8PerIsolateData::reportMemoryUsage):
* bindings/v8/V8ValueCache.cpp:
(WebCore::StringCache::reportMemoryUsage):
* css/CSSBorderImageSliceValue.cpp:
(WebCore::CSSBorderImageSliceValue::reportDescendantMemoryUsage):
* css/CSSCalculationValue.cpp:
* css/CSSCanvasValue.cpp:
(WebCore::CSSCanvasValue::reportDescendantMemoryUsage):
* css/CSSCharsetRule.cpp:
(WebCore::CSSCharsetRule::reportMemoryUsage):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::reportMemoryUsage):
* css/CSSCrossfadeValue.cpp:
(WebCore::CSSCrossfadeValue::reportDescendantMemoryUsage):
* css/CSSCursorImageValue.cpp:
(WebCore::CSSCursorImageValue::reportDescendantMemoryUsage):
* css/CSSFontFaceRule.cpp:
(WebCore::CSSFontFaceRule::reportMemoryUsage):
* css/CSSFontFaceSrcValue.cpp:
(WebCore::CSSFontFaceSrcValue::reportDescendantMemoryUsage):
* css/CSSFunctionValue.cpp:
(WebCore::CSSFunctionValue::reportDescendantMemoryUsage):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientColorStop::reportMemoryUsage):
(WebCore::CSSGradientValue::reportBaseClassMemoryUsage):
(WebCore::CSSLinearGradientValue::reportDescendantMemoryUsage):
(WebCore::CSSRadialGradientValue::reportDescendantMemoryUsage):
* css/CSSGroupingRule.cpp:
(WebCore::CSSGroupingRule::reportMemoryUsage):
* css/CSSImageGeneratorValue.cpp:
(WebCore::CSSImageGeneratorValue::reportBaseClassMemoryUsage):
* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::reportDescendantMemoryUsage):
(WebCore::CSSImageSetValue::ImageWithScale::reportMemoryUsage):
* css/CSSImageValue.cpp:
(WebCore::CSSImageValue::reportDescendantMemoryUsage):
* css/CSSImportRule.cpp:
(WebCore::CSSImportRule::reportMemoryUsage):
* css/CSSMediaRule.cpp:
(WebCore::CSSMediaRule::reportMemoryUsage):
* css/CSSPageRule.cpp:
(WebCore::CSSPageRule::reportMemoryUsage):
* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::reportDescendantMemoryUsage):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::reportMemoryUsage):
* css/CSSReflectValue.cpp:
(WebCore::CSSReflectValue::reportDescendantMemoryUsage):
* css/CSSRule.cpp:
(WebCore::CSSRule::reportMemoryUsage):
* css/CSSRuleList.cpp:
(WebCore::StaticCSSRuleList::reportMemoryUsage):
* css/CSSRuleList.h:
* css/CSSSelectorList.cpp:
(WebCore::CSSSelectorList::reportMemoryUsage):
* css/CSSStyleRule.cpp:
(WebCore::CSSStyleRule::reportMemoryUsage):
* css/CSSStyleSheet.cpp:
(WebCore::CSSStyleSheet::reportMemoryUsage):
* css/CSSValue.cpp:
(WebCore::TextCloneCSSValue::reportDescendantMemoryUsage):
* css/CSSValueList.cpp:
(WebCore::CSSValueList::reportDescendantMemoryUsage):
* css/CSSVariableValue.h:
(WebCore::CSSVariableValue::reportDescendantMemoryUsage):
* css/FontFeatureValue.cpp:
(WebCore::FontFeatureValue::reportDescendantMemoryUsage):
* css/FontValue.cpp:
(WebCore::FontValue::reportDescendantMemoryUsage):
* css/MediaList.cpp:
(WebCore::MediaQuerySet::reportMemoryUsage):
(WebCore::MediaList::reportMemoryUsage):
* css/MediaQuery.cpp:
(WebCore::MediaQuery::reportMemoryUsage):
* css/MediaQueryExp.cpp:
(WebCore::MediaQueryExp::reportMemoryUsage):
* css/PropertySetCSSStyleDeclaration.cpp:
(WebCore::PropertySetCSSStyleDeclaration::reportMemoryUsage):
(WebCore::StyleRuleCSSStyleDeclaration::reportMemoryUsage):
(WebCore::InlineCSSStyleDeclaration::reportMemoryUsage):
* css/RuleFeature.cpp:
(WebCore::RuleFeatureSet::reportMemoryUsage):
* css/RuleSet.cpp:
(WebCore::RuleData::reportMemoryUsage):
(WebCore::RuleSet::reportMemoryUsage):
(WebCore::RuleSet::RuleSetSelectorPair::reportMemoryUsage):
* css/ShadowValue.cpp:
(WebCore::ShadowValue::reportDescendantMemoryUsage):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::reportMemoryUsage):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::MatchedProperties::reportMemoryUsage):
(WebCore::StyleResolver::MatchedPropertiesCacheItem::reportMemoryUsage):
(WebCore::MediaQueryResult::reportMemoryUsage):
(WebCore::StyleResolver::reportMemoryUsage):
* css/StyleRule.cpp:
(WebCore::StyleRule::reportDescendantMemoryUsage):
(WebCore::StyleRulePage::reportDescendantMemoryUsage):
(WebCore::StyleRuleFontFace::reportDescendantMemoryUsage):
(WebCore::StyleRuleGroup::reportDescendantMemoryUsage):
(WebCore::StyleRuleMedia::reportDescendantMemoryUsage):
(WebCore::StyleRuleRegion::reportDescendantMemoryUsage):
(WebCore::StyleRuleViewport::reportDescendantMemoryUsage):
* css/StyleRuleImport.cpp:
(WebCore::StyleRuleImport::reportDescendantMemoryUsage):
* css/StyleScopeResolver.cpp:
(WebCore::StyleScopeResolver::reportMemoryUsage):
* css/StyleSheetContents.cpp:
(WebCore::StyleSheetContents::reportMemoryUsage):
* css/WebKitCSSKeyframeRule.cpp:
(WebCore::StyleKeyframe::reportMemoryUsage):
(WebCore::WebKitCSSKeyframeRule::reportMemoryUsage):
* css/WebKitCSSKeyframesRule.cpp:
(WebCore::StyleRuleKeyframes::reportDescendantMemoryUsage):
(WebCore::WebKitCSSKeyframesRule::reportMemoryUsage):
* css/WebKitCSSSVGDocumentValue.cpp:
(WebCore::WebKitCSSSVGDocumentValue::reportDescendantMemoryUsage):
* css/WebKitCSSShaderValue.cpp:
(WebCore::WebKitCSSShaderValue::reportDescendantMemoryUsage):
* css/WebKitCSSViewportRule.cpp:
(WebCore::WebKitCSSViewportRule::reportMemoryUsage):
* dom/Attribute.h:
(WebCore::Attribute::reportMemoryUsage):
* dom/CharacterData.cpp:
(WebCore::CharacterData::reportMemoryUsage):
* dom/ContainerNode.cpp:
(WebCore::ContainerNode::reportMemoryUsage):
* dom/ContainerNode.h:
(ContainerNode):
* dom/Document.cpp:
(WebCore::Document::reportMemoryUsage):
* dom/DocumentEventQueue.cpp:
(WebCore::DocumentEventQueue::reportMemoryUsage):
* dom/DocumentOrderedMap.cpp:
(WebCore::DocumentOrderedMap::reportMemoryUsage):
* dom/DocumentStyleSheetCollection.cpp:
(WebCore::DocumentStyleSheetCollection::reportMemoryUsage):
* dom/Element.cpp:
(WebCore::Element::reportMemoryUsage):
* dom/ElementAttributeData.cpp:
(WebCore::ElementAttributeData::reportMemoryUsage):
* dom/ElementRareData.cpp:
(WebCore::ElementRareData::reportMemoryUsage):
* dom/ElementShadow.cpp:
(WebCore::ElementShadow::reportMemoryUsage):
* dom/Event.cpp:
(WebCore::Event::reportMemoryUsage):
* dom/LiveNodeList.cpp:
(WebCore::LiveNodeListBase::reportMemoryUsage):
* dom/Node.cpp:
(WebCore::Node::reportMemoryUsage):
* dom/NodeRareData.cpp:
(WebCore::NodeListsNodeData::reportMemoryUsage):
(WebCore::NodeRareData::reportMemoryUsage):
* dom/QualifiedName.cpp:
(WebCore::QualifiedName::reportMemoryUsage):
(WebCore::QualifiedName::QualifiedNameImpl::reportMemoryUsage):
* dom/ScriptExecutionContext.cpp:
(WebCore::ScriptExecutionContext::reportMemoryUsage):
* dom/SecurityContext.cpp:
(WebCore::SecurityContext::reportMemoryUsage):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::reportMemoryUsage):
* dom/TreeScope.cpp:
(WebCore::TreeScope::reportMemoryUsage):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::reportMemoryUsage):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::reportMemoryUsage):
* html/HTMLImageElement.cpp:
(WebCore::HTMLImageElement::reportMemoryUsage):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::reportMemoryUsage):
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::reportMemoryUsage):
* html/HTMLTextFormControlElement.cpp:
(WebCore::HTMLTextFormControlElement::reportMemoryUsage):
* inspector/HeapGraphSerializer.cpp:
(WebCore::HeapGraphSerializer::HeapGraphSerializer):
(WebCore::HeapGraphSerializer::reportNode):
(WebCore::HeapGraphSerializer::reportMemoryUsage):
* inspector/HeapGraphSerializer.h:
(HeapGraphSerializer):
* inspector/InspectorBaseAgent.cpp:
(WebCore::InspectorBaseAgentInterface::reportMemoryUsage):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::reportMemoryUsage):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):
* inspector/InspectorDebuggerAgent.cpp:
(WebCore::InspectorDebuggerAgent::reportMemoryUsage):
(WebCore::ScriptDebugListener::Script::reportMemoryUsage):
* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::reportMemoryUsage):
* inspector/InspectorOverlay.cpp:
(WebCore::InspectorOverlay::reportMemoryUsage):
* inspector/InspectorProfilerAgent.cpp:
(WebCore::InspectorProfilerAgent::reportMemoryUsage):
* inspector/InspectorResourceAgent.cpp:
(WebCore::InspectorResourceAgent::reportMemoryUsage):
* inspector/MemoryInstrumentationImpl.cpp:
(WebCore::MemoryInstrumentationClientImpl::reportMemoryUsage):
(WebCore::MemoryInstrumentationImpl::reportMemoryUsage):
* inspector/NetworkResourcesData.cpp:
(WebCore::XHRReplayData::reportMemoryUsage):
(WebCore::NetworkResourcesData::ResourceData::reportMemoryUsage):
(WebCore::NetworkResourcesData::reportMemoryUsage):
* loader/CachedMetadata.cpp:
(WebCore::CachedMetadata::reportMemoryUsage):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::reportMemoryUsage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::reportMemoryUsage):
* loader/MainResourceLoader.cpp:
(WebCore::MainResourceLoader::reportMemoryUsage):
* loader/Prerenderer.cpp:
(WebCore::Prerenderer::reportMemoryUsage):
* loader/ResourceBuffer.cpp:
(WebCore::ResourceBuffer::reportMemoryUsage):
* loader/ResourceLoader.cpp:
(WebCore::ResourceLoader::reportMemoryUsage):
* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::reportMemoryUsage):
* loader/SubstituteData.cpp:
(WebCore::SubstituteData::reportMemoryUsage):
* loader/cache/CachedCSSStyleSheet.cpp:
(WebCore::CachedCSSStyleSheet::reportMemoryUsage):
* loader/cache/CachedFont.cpp:
(WebCore::CachedFont::reportMemoryUsage):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::reportMemoryUsage):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResourceHandle.cpp:
(WebCore::CachedResourceHandleBase::reportMemoryUsage):
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::reportMemoryUsage):
* loader/cache/CachedSVGDocument.cpp:
(WebCore::CachedSVGDocument::reportMemoryUsage):
* loader/cache/CachedScript.cpp:
(WebCore::CachedScript::reportMemoryUsage):
* loader/cache/CachedShader.cpp:
(WebCore::CachedShader::reportMemoryUsage):
* loader/cache/CachedXSLStyleSheet.cpp:
(WebCore::CachedXSLStyleSheet::reportMemoryUsage):
* loader/cache/MemoryCache.cpp:
(WebCore::MemoryCache::reportMemoryUsage):
* page/DOMTimer.cpp:
(WebCore::DOMTimer::reportMemoryUsage):
* page/Frame.cpp:
(WebCore::Frame::reportMemoryUsage):
* page/Page.cpp:
(WebCore::Page::reportMemoryUsage):
* platform/KURL.cpp:
(WebCore::KURL::reportMemoryUsage):
* platform/KURLGoogle.cpp:
(WebCore::KURLGooglePrivate::reportMemoryUsage):
* platform/KURLWTFURLImpl.h:
(WebCore::KURLWTFURLImpl::reportMemoryUsage):
* platform/ScrollableArea.cpp:
(WebCore::ScrollableArea::reportMemoryUsage):
* platform/SharedBuffer.cpp:
(WebCore::SharedBuffer::reportMemoryUsage):
* platform/audio/AudioArray.h:
(WebCore::AudioArray::reportMemoryUsage):
* platform/audio/FFTFrame.cpp:
(WebCore::FFTFrame::reportMemoryUsage):
* platform/audio/HRTFDatabase.cpp:
(WebCore::HRTFDatabase::reportMemoryUsage):
* platform/audio/HRTFDatabaseLoader.cpp:
(WebCore::HRTFDatabaseLoader::reportMemoryUsage):
* platform/audio/HRTFElevation.cpp:
(WebCore::HRTFElevation::reportMemoryUsage):
* platform/audio/HRTFKernel.cpp:
(WebCore::HRTFKernel::reportMemoryUsage):
* platform/audio/ffmpeg/FFTFrameFFMPEG.cpp:
(reportMemoryUsage):
* platform/graphics/BitmapImage.cpp:
(WebCore::BitmapImage::reportMemoryUsage):
(WebCore::FrameData::reportMemoryUsage):
* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::reportMemoryUsage):
* platform/graphics/GeneratorGeneratedImage.cpp:
(WebCore::GeneratorGeneratedImage::reportMemoryUsage):
* platform/graphics/GraphicsLayer.cpp:
(WebCore::GraphicsLayer::reportMemoryUsage):
* platform/graphics/ImageBuffer.cpp:
(WebCore::ImageBuffer::reportMemoryUsage):
* platform/graphics/ImageSource.cpp:
(WebCore::ImageSource::reportMemoryUsage):
* platform/graphics/chromium/GraphicsLayerChromium.cpp:
(WebCore::GraphicsLayerChromium::reportMemoryUsage):
* platform/graphics/skia/ImageBufferSkia.cpp:
(WebCore::ImageBufferData::reportMemoryUsage):
* platform/graphics/skia/MemoryInstrumentationSkia.cpp:
(reportMemoryUsage):
* platform/graphics/skia/NativeImageSkia.cpp:
(WebCore::NativeImageSkia::reportMemoryUsage):
* platform/image-decoders/ImageDecoder.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
(WebCore):
(WebCore::ImageDecoder::reportMemoryUsage):
* platform/image-decoders/skia/ImageDecoderSkia.cpp:
(WebCore::ImageFrame::reportMemoryUsage):
* platform/network/FormData.cpp:
(WebCore::FormData::reportMemoryUsage):
(WebCore::FormDataElement::reportMemoryUsage):
* platform/network/ResourceRequestBase.cpp:
(WebCore::ResourceRequestBase::reportMemoryUsageBase):
* platform/network/ResourceResponseBase.cpp:
(WebCore::ResourceResponseBase::reportMemoryUsage):
* platform/network/chromium/ResourceRequest.cpp:
(WebCore::ResourceRequest::reportMemoryUsage):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::reportMemoryUsage):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::reportMemoryUsage):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::reportMemoryUsage):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::reportMemoryUsage):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reportMemoryUsage):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::reportMemoryUsage):
(WebCore::RenderFrameSet::GridAxis::reportMemoryUsage):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::reportMemoryUsage):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::reportMemoryUsage):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::reportMemoryUsage):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::reportMemoryUsage):
* rendering/RenderListMarker.cpp:
(WebCore::RenderListMarker::reportMemoryUsage):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::reportMemoryUsage):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::reportMemoryUsage):
* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::reportMemoryUsage):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::reportMemoryUsage):
(WebCore::RenderTableSection::RowStruct::reportMemoryUsage):
(WebCore::RenderTableSection::CellStruct::reportMemoryUsage):
* rendering/RenderText.cpp:
(WebCore::RenderText::reportMemoryUsage):
* rendering/RenderView.cpp:
(WebCore::RenderView::reportMemoryUsage):
* rendering/style/DataRef.h:
(WebCore::DataRef::reportMemoryUsage):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::reportMemoryUsage):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::reportMemoryUsage):
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::reportMemoryUsage):
* svg/SVGPaint.cpp:
(WebCore::SVGPaint::reportDescendantMemoryUsage):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::reportMemoryUsage):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::reportMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] visibility of embedded widget
pierre.rossi@gmail.com [Fri, 1 Feb 2013 10:40:18 +0000 (10:40 +0000)]
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::hide in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

* WebCoreSupport/FrameLoaderClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
mihnea@adobe.com [Fri, 1 Feb 2013 10:37:50 +0000 (10:37 +0000)]
[CSS Regions] Convert fast/regions/region-overflow-auto-overflow* to reftests
https://bugs.webkit.org/show_bug.cgi?id=108333

Reviewed by Tony Chang.

Add reftests, cleanup existing tests.

* fast/regions/region-overflow-auto-overflow-hidden-expected.html: Added.
* fast/regions/region-overflow-auto-overflow-hidden.html:
* fast/regions/region-overflow-auto-overflow-visible-expected.html: Added.
* fast/regions/region-overflow-auto-overflow-visible.html:
* platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-linux-x86/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/chromium-linux/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium-mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium-mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/chromium/TestExpectations:
* platform/chromium/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/chromium/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/efl/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/gtk/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/mac-snowleopard/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/mac/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/mac/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.png: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-hidden-expected.txt: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.png: Removed.
* platform/qt/fast/regions/region-overflow-auto-overflow-visible-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] visibility of embedded widget
pierre.rossi@gmail.com [Fri, 1 Feb 2013 10:35:31 +0000 (10:35 +0000)]
[Qt] visibility of embedded widget
https://bugs.webkit.org/show_bug.cgi?id=108327

Rubber-stamped by Simon Hausmann.

In overriding Widget::show in QtPluginWidget, we forgot to call the
parent implementation, which as it turns, out does sensible stuff.

* WebCoreSupport/FrameLoaderClientQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][GStreamer] FullscreenVideoControllerGtk implementation
philn@webkit.org [Fri, 1 Feb 2013 10:25:16 +0000 (10:25 +0000)]
[GTK][GStreamer] FullscreenVideoControllerGtk implementation
https://bugs.webkit.org/show_bug.cgi?id=107398

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

NATIVE_FULLSCREEN_VIDEO support for the GTK port. The previous
FullscreenVideoController implementation was refactored as a
sub-class of FullscreenVideoControllerGStreamer and hooked in the
MediaPlayerPrivateGStreamer backend.

* GNUmakefile.list.am:
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::~MediaPlayerPrivateGStreamer):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
* platform/graphics/gtk/FullscreenVideoControllerGtk.cpp: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.cpp.
* platform/graphics/gtk/FullscreenVideoControllerGtk.h: Renamed from Source/WebKit/gtk/WebCoreSupport/FullscreenVideoController.h.

Source/WebKit/gtk:

Remove the FullscreenVideoController as it moved to
FullscreenVideoControllerGStreamer and its Gtk subclass in
WebCore. Hook in NATIVE_FULLSCREEN_VIDEO in the ChromeClient in
the two possible scenarios, wether FULLSCREEN_API is enabled or not.

* GNUmakefile.am: Remove FullscreenVideoController.
* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit):
(WebKit::ChromeClient::enterFullscreenForNode): Hook
NATIVE_FULLSCREEN_VIDEO support.
(WebKit::ChromeClient::exitFullscreenForNode): Ditto
(WebKit::ChromeClient::enterFullScreenForElement): Ditto
(WebKit::ChromeClient::exitFullScreenForElement): Ditto
* WebCoreSupport/ChromeClientGtk.h:
(ChromeClient):
* WebCoreSupport/FullscreenVideoController.cpp: Removed.
* WebCoreSupport/FullscreenVideoController.h: Removed.
* webkit/webkitwebview.cpp: Remove FullscreenVideoController support.
* webkit/webkitwebviewprivate.h: Ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: fix cursor location in Source Frame
commit-queue@webkit.org [Fri, 1 Feb 2013 10:11:24 +0000 (10:11 +0000)]
Web Inspector: fix cursor location in Source Frame
https://bugs.webkit.org/show_bug.cgi?id=108592

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.

Normalize range before computing amount of lines in
_updateSourcePosition.

No new tests.

* inspector/front-end/SourceFrame.js:
(WebInspector.SourceFrame.prototype._updateSourcePosition): Normalize text range.
* inspector/front-end/inspector.css: Slightly bigger left padding for the text.
(.source-frame-position):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r141553.
haraken@chromium.org [Fri, 1 Feb 2013 10:09:47 +0000 (10:09 +0000)]
Unreviewed build fix after r141553.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Sources panel navigator reveal and expand fixes.
vsevik@chromium.org [Fri, 1 Feb 2013 10:07:25 +0000 (10:07 +0000)]
Web Inspector: Sources panel navigator reveal and expand fixes.
https://bugs.webkit.org/show_bug.cgi?id=108584

Reviewed by Pavel Feldman.

Navigator folders are not expanded by default anymore.
Made domain folder expanded for inspected page main frame domain.
UISourceCodes are now added to navigator before editor container
so that they could be revealed if editor container decides to show them.

* inspector/front-end/NavigatorView.js:
(WebInspector.BaseNavigatorTreeElement.prototype.onattach):
(WebInspector.NavigatorFolderTreeElement.prototype.onattach):
* inspector/front-end/ScriptsPanel.js:
(WebInspector.ScriptsPanel.prototype._addUISourceCode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] MiniBrowser segfaults on loading google.com
hausmann@webkit.org [Fri, 1 Feb 2013 10:06:06 +0000 (10:06 +0000)]
[EFL][WK2] MiniBrowser segfaults on loading google.com
https://bugs.webkit.org/show_bug.cgi?id=108597

Patch by Gwang Yoon Hwang <ryumiel@company100.net> on 2013-02-01
Reviewed by Andreas Kling.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::processMessage):
oolMessageBody should be properly initialized before it is used.

This patch also adds omitted break statement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
aandrey@chromium.org [Fri, 1 Feb 2013 09:52:10 +0000 (09:52 +0000)]
Web Inspector: [Canvas] drop trace log in the backend when deleting profile in frontend
https://bugs.webkit.org/show_bug.cgi?id=108591

Reviewed by Pavel Feldman.

Send a dropTraceLog command to the backend when deleting a profile header from the sidebar.
Before we were sending the command only upon deleting an existing view of a profile, so we  would not
sent the command if the view was not created or if a profile header was removed via context menu (the ondelete() method).
Drive-by: fixed an odd formatting of property functions.
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileHeader.prototype.reset):
* inspector/front-end/ProfilesPanel.js:
(WebInspector.ProfileHeader.prototype.reset):
(WebInspector.ProfileHeader.prototype.load):
(WebInspector.ProfileHeader.prototype.canSaveToFile):
(WebInspector.ProfileHeader.prototype.saveToFile):
(WebInspector.ProfileHeader.prototype.loadFromFile):
(WebInspector.ProfileHeader.prototype.fromFile):
(WebInspector.ProfilesPanel):
(WebInspector.ProfilesPanel.prototype._reset):
(WebInspector.ProfilesPanel.prototype._removeProfileHeader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: when aria-activedescendant is used with a ComboBox role, focus should not be...
cfleizach@apple.com [Fri, 1 Feb 2013 09:32:54 +0000 (09:32 +0000)]
AX: when aria-activedescendant is used with a ComboBox role, focus should not be changed
https://bugs.webkit.org/show_bug.cgi?id=108596

Reviewed by Ryosuke Niwa.

Source/WebCore:

Normally, an aria-activedescendant change causes a focus change to be triggered.
However, when used in conjunction with a combo box, this causes problems for screen readers.
Namely, the user expects focus to remain in the text field so that the user can keep typing.
If focus moves to an item in the combobox list, it is not possible to keep typing.

The solution is to not trigger a focus change in this case and instead use a selected children change notification.

Test: platform/mac/accessibility/combobox-activedescendant-notifications.html

* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::shouldNotifyActiveDescendant):
(WebCore::AccessibilityRenderObject::shouldFocusActiveDescendant):
(WebCore::AccessibilityRenderObject::handleActiveDescendantChanged):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postPlatformNotification):

LayoutTests:

* platform/mac/accessibility/combobox-activedescendant-notifications-expected.txt: Added.
* platform/mac/accessibility/combobox-activedescendant-notifications.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
cfleizach@apple.com [Fri, 1 Feb 2013 09:17:02 +0000 (09:17 +0000)]
Source/WebCore: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion=
https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

This accounts for differences in what AppKit gives for accessibility role descriptions between platforms
when the subrole is not recognized, and standardizes it for WebKit.

Unskip a failing Lion test

* accessibility/mac/WebAccessibilityObjectWrapper.mm:
(-[WebAccessibilityObjectWrapper roleDescription]):

LayoutTests: [Mac] REGRESSION(r140974): accessibility/lists.html fails on Lion
https://bugs.webkit.org/show_bug.cgi?id=108291

Reviewed by Ryosuke Niwa.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Replace localeCompare in NavigatorView with compareTo.
vsevik@chromium.org [Fri, 1 Feb 2013 09:06:29 +0000 (09:06 +0000)]
Web Inspector: Replace localeCompare in NavigatorView with compareTo.
https://bugs.webkit.org/show_bug.cgi?id=108585

Reviewed by Pavel Feldman.

Replaced String.prototype.localeCompare with String.prototype.compareTo
in NavigatorView to improve performance.

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorTreeOutline._treeElementsCompare):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: File system pending requests list is not cleared after processing.
vsevik@chromium.org [Fri, 1 Feb 2013 08:57:15 +0000 (08:57 +0000)]
Web Inspector: File system pending requests list is not cleared after processing.
https://bugs.webkit.org/show_bug.cgi?id=108573

Reviewed by Pavel Feldman.

* inspector/front-end/IsolatedFileSystemModel.js:
(WebInspector.IsolatedFileSystemModel.prototype._processPendingFileSystemRequests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDubious cast from HTMLCollection to HTMLAllCollection
tsepez@chromium.org [Fri, 1 Feb 2013 08:52:01 +0000 (08:52 +0000)]
Dubious cast from HTMLCollection to HTMLAllCollection
https://bugs.webkit.org/show_bug.cgi?id=108538

Reviewed by Adam Barth.

Patch is tested by enabling V8 binding integrity on HTMLAllCollection and
running the existing tests without introducing new crashes.

* dom/Document.cpp:
(WebCore::Document::all):
Pass correct type to template.

* html/HTMLAllCollection.cpp:
(WebCore::HTMLAllCollection::create):
(WebCore::HTMLAllCollection::HTMLAllCollection):
* html/HTMLAllCollection.h:
(HTMLAllCollection):
Make create() method arguments compatible with template above.

* html/HTMLAllCollection.idl:
Enable binding integrity.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Add support for handling modal dialogs
commit-queue@webkit.org [Fri, 1 Feb 2013 08:50:19 +0000 (08:50 +0000)]
Web Inspector: Add support for handling modal dialogs
https://bugs.webkit.org/show_bug.cgi?id=107883

Patch by Ken Kania <kkania@chromium.org> on 2013-02-01
Reviewed by Pavel Feldman.

Introduce support for being notified when a JavaScript modal dialog
is opening and closing, as well as a new command for accepting or
dismissing the dialog.

Source/WebCore:

Test: inspector-protocol/page/willRunJavaScriptDialog.html

* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::handleJavaScriptDialog):
(InspectorClient):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialogImpl):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialogImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorInstrumentation::didRunJavaScriptDialog):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::willRunJavaScriptDialog):
(WebCore):
(WebCore::InspectorPageAgent::didRunJavaScriptDialog):
(WebCore::InspectorPageAgent::handleJavaScriptDialog):
* inspector/InspectorPageAgent.h:
* inspector/front-end/ResourceTreeModel.js:
(WebInspector.PageDispatcher.prototype.frameStartedLoading):
(WebInspector.PageDispatcher.prototype.frameStoppedLoading):
(WebInspector.PageDispatcher.prototype.frameScheduledNavigation):
(WebInspector.PageDispatcher.prototype.frameClearedScheduledNavigation):
(WebInspector.PageDispatcher.prototype.javascriptDialogOpening):
(WebInspector.PageDispatcher.prototype.javascriptDialogClosed):
* page/Chrome.cpp:
(WebCore::Chrome::runBeforeUnloadConfirmPanel):
(WebCore::Chrome::runJavaScriptAlert):
(WebCore::Chrome::runJavaScriptConfirm):
(WebCore::Chrome::runJavaScriptPrompt):

Source/WebKit/chromium:

* public/WebDevToolsAgent.h:
* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::handleJavaScriptDialog):
(WebKit):
* src/InspectorClientImpl.h:
(InspectorClientImpl):
* src/WebDevToolsAgentImpl.cpp:
(BrowserDataHintStringValues):
(WebKit::WebDevToolsAgentImpl::captureScreenshot):
(WebKit::WebDevToolsAgentImpl::handleJavaScriptDialog):
(WebKit):
(WebKit::browserHintToString):
(WebKit::browserHintFromString):
(WebKit::WebDevToolsAgent::patchWithBrowserData):
* src/WebDevToolsAgentImpl.h:
(WebDevToolsAgentImpl):

LayoutTests:

* inspector-protocol/page/javascriptDialogEvents-expected.txt: Added.
* inspector-protocol/page/javascriptDialogEvents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTouch disambiguation blacklist is not being queried properly
commit-queue@webkit.org [Fri, 1 Feb 2013 08:48:05 +0000 (08:48 +0000)]
Touch disambiguation blacklist is not being queried properly
https://bugs.webkit.org/show_bug.cgi?id=108222

Patch by Dan Alcantara <dfalcantara@chromium.org> on 2013-02-01
Reviewed by Adam Barth.

TEST=WebFrameTest::DisambiguationPopupBlacklist

Source/WebCore:

Fix the blacklist so that we check it for the right nodes.
Add a chromium test to check that the blacklist is being built and used
correctly.  Also update the other DisambiguationPopup tests to
use the new page scale method.

* page/TouchDisambiguation.cpp:
(WebCore::findGoodTouchTargets):

Source/WebKit/chromium:

Fix the blacklist so that we check it for the right nodes.
Add a test to check that the blacklist is being built and used
correctly.  Also update the other DisambiguationPopup tests to
use the new page scale method.

* tests/WebFrameTest.cpp:
* tests/data/disambiguation_popup_blacklist.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Add a temporary optional Isolate parameter to HasInstance()
haraken@chromium.org [Fri, 1 Feb 2013 08:45:57 +0000 (08:45 +0000)]
[V8] Add a temporary optional Isolate parameter to HasInstance()
https://bugs.webkit.org/show_bug.cgi?id=108567

Reviewed by Adam Barth.

The optional Isolate parameter will be removed once all call sites have an Isolate.
It will require several patches.

No tests. No change in behavior.

* bindings/scripts/CodeGeneratorV8.pm:
(GenerateHeader):
(GenerateNormalAttrSetter):
(GenerateParametersCheckExpression):
(GenerateParametersCheck):
(GenerateImplementation):
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore::V8Float64Array::HasInstance):
* bindings/scripts/test/V8/V8Float64Array.h:
(V8Float64Array):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore::V8TestActiveDOMObject::HasInstance):
* bindings/scripts/test/V8/V8TestActiveDOMObject.h:
(V8TestActiveDOMObject):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore::V8TestCustomNamedGetter::HasInstance):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.h:
(V8TestCustomNamedGetter):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore::V8TestEventConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestEventConstructor.h:
(V8TestEventConstructor):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore::V8TestEventTarget::HasInstance):
* bindings/scripts/test/V8/V8TestEventTarget.h:
(V8TestEventTarget):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore::V8TestException::HasInstance):
* bindings/scripts/test/V8/V8TestException.h:
(V8TestException):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore::V8TestInterface::HasInstance):
* bindings/scripts/test/V8/V8TestInterface.h:
(V8TestInterface):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore::V8TestMediaQueryListListener::HasInstance):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.h:
(V8TestMediaQueryListListener):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore::V8TestNamedConstructor::HasInstance):
* bindings/scripts/test/V8/V8TestNamedConstructor.h:
(V8TestNamedConstructor):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore::V8TestNode::HasInstance):
* bindings/scripts/test/V8/V8TestNode.h:
(V8TestNode):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore::TestObjV8Internal::overloadedMethodCallback):
(WebCore::TestObjV8Internal::variadicNodeMethodCallback):
(WebCore::V8TestObj::HasInstance):
* bindings/scripts/test/V8/V8TestObj.h:
(V8TestObj):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.cpp:
(WebCore::V8TestOverloadedConstructors::constructorCallback):
(WebCore::V8TestOverloadedConstructors::HasInstance):
* bindings/scripts/test/V8/V8TestOverloadedConstructors.h:
(V8TestOverloadedConstructors):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore::V8TestSerializedScriptValueInterface::HasInstance):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.h:
(V8TestSerializedScriptValueInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Unreviewed, marking table-section-overflow-clip-crash.html failed.
morrita@google.com [Fri, 1 Feb 2013 08:44:31 +0000 (08:44 +0000)]
[Chromium] Unreviewed, marking table-section-overflow-clip-crash.html failed.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CPP,GObject,ObjC] Add 'static' skip to CodeGenerator{CPP,GObject,ObjC}.pm
commit-queue@webkit.org [Fri, 1 Feb 2013 08:44:24 +0000 (08:44 +0000)]
[CPP,GObject,ObjC] Add 'static' skip to CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108578

Patch by Nils Barth <nbarth@google.com> on 2013-02-01
Reviewed by Kentaro Hara.

Since CPP/GObject/ObjC code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support static attributes, add test to skip these.
This lets us remove #if macro from static in test files and not need
these in future.

Test: bindings/scripts/test/TestObj.idl (run-bindings-test)
Test: bindings/scripts/test/TestSupplemental.idl (run-bindings-test)

* bindings/scripts/CodeGeneratorCPP.pm:
(SkipAttribute):
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute):
* bindings/scripts/test/TestObj.idl:
* bindings/scripts/test/TestSupplemental.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] only show checkboxes for FPS meter and continuous painting when compositin...
commit-queue@webkit.org [Fri, 1 Feb 2013 08:37:10 +0000 (08:37 +0000)]
[chromium] only show checkboxes for FPS meter and continuous painting when compositing mode is forced
https://bugs.webkit.org/show_bug.cgi?id=108236

Patch by Eberhard Graether <egraether@google.com> on 2013-02-01
Reviewed by Pavel Feldman.

This change hides the checkboxes for FPS meter and continuous painting if compositing mode is not forced.
This way the checkboxes only show up for users that can make use of these features.

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canShowFPSCounter):
(WebKit::InspectorClientImpl::canContinuouslyPaint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rebaselining a result.
morrita@google.com [Fri, 1 Feb 2013 08:30:09 +0000 (08:30 +0000)]
Unreviewed, rebaselining a result.

* platform/chromium/fast/js/kde/inbuilt_function_tostring-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[V8] Remove V8GCController::m_edenNodes
haraken@chromium.org [Fri, 1 Feb 2013 08:27:10 +0000 (08:27 +0000)]
[V8] Remove V8GCController::m_edenNodes
https://bugs.webkit.org/show_bug.cgi?id=108579

Reviewed by Adam Barth.

Currently V8GCController::m_edenNodes stores a list of nodes whose
wrappers have been created since the latest GC. The reason why we
needed m_edenNodes is that there was no way to know a list of wrappers
in the new space of V8. By using m_edenNodes, we had been approximating
'wrappers in the new space' by 'wrappers that have been created since
the latest GC'.

Now V8 provides VisitHandlesForPartialDependence(), with which WebKit
can know a list of wrappers in the new space. By using the API, we can
remove V8GCController::m_edenNodes. The benefit is that (1) we no longer
need to keep m_edenNodes and that (2) it enables more precise minor
DOM GC (Remember that m_edenNodes was just an approximation).

Performance benchmark: https://bugs.webkit.org/attachment.cgi?id=185940
The benchmark runs 300 iterations, each of which creates 100000 elements.
The benchmark measures average, min, median, max and stdev of execution times
of the 300 iterations. This will tell us the worst-case overhead of this change.

Before:
  mean=59.91ms, min=39ms, median=42ms, max=258ms, stdev=47.48ms

After:
  mean=58.75ms, min=35ms, median=41ms, max=250ms, stdev=47.32ms

As shown above, I couldn't observe any performance regression.

No tests. No change in behavior.

* bindings/v8/DOMDataStore.h:
(WebCore::DOMDataStore::setWrapperInObject):
* bindings/v8/V8GCController.cpp:
(WebCore::gcTree):
(WebCore):
(MinorGCWrapperVisitor):
(WebCore::MinorGCWrapperVisitor::notifyFinished):
(WebCore::V8GCController::gcPrologue):
(WebCore::V8GCController::minorGCPrologue):
(WebCore::V8GCController::majorGCPrologue):
* bindings/v8/V8GCController.h:
(V8GCController):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf...
vsevik@chromium.org [Fri, 1 Feb 2013 08:19:35 +0000 (08:19 +0000)]
Web Inspector: Use String.prototype.startsWith instead of String.prototype.indexOf when possible
https://bugs.webkit.org/show_bug.cgi?id=108575

Reviewed by Yury Semikhatsky.

Source/WebCore:

* inspector/front-end/FileMapping.js:
(WebInspector.FileMapping.prototype._entryMatchesURL):
(WebInspector.FileMapping.prototype.urlForURI):
* inspector/front-end/FileSystemMapping.js:
(get WebInspector.FileSystemMappingImpl.prototype.fileForURI):
(get WebInspector.FileSystemMappingImpl.prototype.uriForPath):

LayoutTests:

* http/tests/inspector/console-cd-completions.html:
* http/tests/inspector/console-cd.html:
* http/tests/inspector/indexeddb/indexeddb-test.js:
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer.consoleMessageOverride):
(initialize_IndexedDBTest.InspectorTest._installIndexedDBSniffer):
* inspector/network-status-non-http.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Add MessageFlags.h in Target.pri
commit-queue@webkit.org [Fri, 1 Feb 2013 08:02:07 +0000 (08:02 +0000)]
[Qt] Add MessageFlags.h in Target.pri
https://bugs.webkit.org/show_bug.cgi?id=108583

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-31
Reviewed by Kentaro Hara.

Since MessageDecoder and MessageEncoder include MessageFlags.h, it
should be included in Target.pri.

* Target.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEditor::m_compositionNode not updated on HTMLInputElement::setValue()
commit-queue@webkit.org [Fri, 1 Feb 2013 07:43:13 +0000 (07:43 +0000)]
Editor::m_compositionNode not updated on HTMLInputElement::setValue()
https://bugs.webkit.org/show_bug.cgi?id=107737

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.

Source/WebCore:

Chromium has a bug where the IME composition did not get cancelled on JavaScript changes
to the focused editing field. Most of other WebKit ports were already doing this check
in their EditorClient::respondToChangedSelection. I took that logic and moved it to the
Editor so every port and use the same code.

An existing test editing/input/setting-input-value-cancel-ime-composition.html covers this change.
This test used to have an expectation to fail on Chromium and after this patch it will start passing.

* editing/Editor.cpp:
(WebCore::Editor::cancelCompositionIfSelectionIsInvalid):
    Adding a call that can be used by any the port to cancel the composition if it's no longer valid.
(WebCore):
* editing/Editor.h:
(Editor):

Source/WebKit/chromium:

* public/WebViewClient.h:
(WebKit::WebViewClient::didCancelCompositionOnSelectionChange):
    Adding a callback to let the WebViewClient know that the composition has been cancelled.
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::respondToChangedSelection):
    Adding a call composition if it is no longer valid.

Source/WebKit/efl:

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):
    Adding a call to the newly refactored method.

Source/WebKit/gtk:

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::respondToChangedSelection):
    Adding a call to the newly refactored Editor method.

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateSelectionForInputManager]):

Source/WebKit/win:

* WebView.cpp:
(WebView::updateSelectionForIME):
    Adding a call to the newly refactored method.

LayoutTests:

* platform/chromium/TestExpectations: Removed fail expectation for the editing/input/setting-input-value-cancel-ime-composition.html since this patch fixes the bug https://bugs.webkit.org/show_bug.cgi?id=55560

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG::CFGSimplificationPhase::keepOperandAlive() conflates liveness and availability
fpizlo@apple.com [Fri, 1 Feb 2013 07:40:31 +0000 (07:40 +0000)]
DFG::CFGSimplificationPhase::keepOperandAlive() conflates liveness and availability
https://bugs.webkit.org/show_bug.cgi?id=108580

Reviewed by Oliver Hunt.

This is a harmless bug in that it only results in us keeping a bit too many things
for OSR.  But it's worth fixing so that the code is consistent.

keepOperandAlive() is called when block A has a branch to blocks B and C, but the
A->B edge is proven to never be taken and we want to optimize the code to have A
unconditionally jump to C.  In that case, for the purposes of OSR, we need to
preserve the knowledge that the state that B expected to be live incoming from A
ought still to be live up to the point of where the A->B,C branch used to be.  The
way we keep things alive is by using the variablesAtTail of A (i.e., we use the
knowledge of in what manner A made state available to B and C).  The way we choose
which state should be kept alive ought to be chosen by the variablesAtHead of B
(i.e. the things B says it needs from its predecessors, including A), except that
keepOperandAlive() was previously just using variablesAtTail of A for this
purpose.

The fix is to have keepOperandAlive() use both liveness and availability in its
logic. It should use liveness (i.e. B->variablesAtHead) to decide what to keep
alive, and it should use availability (i.e. A->variablesAtTail) to decide how to
keep it alive.

This might be a microscopic win on some programs, but it's mainly intended to be
a code clean-up so that I don't end up scratching my head in confusion the next
time I look at this code.

* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(JSC::DFG::CFGSimplificationPhase::jettisonBlock):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCoordinated Graphics : Move CoordinatedGraphics related files to WebCore
commit-queue@webkit.org [Fri, 1 Feb 2013 07:32:26 +0000 (07:32 +0000)]
Coordinated Graphics : Move CoordinatedGraphics related files to WebCore
https://bugs.webkit.org/show_bug.cgi?id=108149

Patch by Jae Hyun Park <jae.park@company100.net> on 2013-01-31
Reviewed by Noam Rosenthal.

This patch moves Coordinated Graphics related code to WebCore. To
implement Threaded Coordinated Graphics, most of Coordianted Graphics
code should be shared. Therefore, they should reside in WebCore instead of
WebKit2.

When moving to WebCore, two renamings have been done.

1. Rename LayerTreeRenderer to CoordinatedGraphicsScene.

2. Rename WebCustomFilterProgram and WebCustomFilterOperation to
CoordinatedCustomFilterProgram and CoordinatedCustomFilterOperation,
respectively.

No new tests, covered by existing tests.

Source/WebCore:

* CMakeLists.txt:
* Target.pri:
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/coordinated/AreaAllocator.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.cpp.
* platform/graphics/texmap/coordinated/AreaAllocator.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/AreaAllocator.h.
* platform/graphics/texmap/coordinated/CoordinatedBackingStore.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.cpp.
* platform/graphics/texmap/coordinated/CoordinatedBackingStore.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/CoordinatedBackingStore.h.
* platform/graphics/texmap/coordinated/CoordinatedCustomFilterOperation.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/WebCustomFilterOperation.h.
* platform/graphics/texmap/coordinated/CoordinatedCustomFilterProgram.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/WebCustomFilterProgram.h.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.cpp.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsLayer.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedGraphicsLayer.h.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.cpp: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.cpp.
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h: Renamed from Source/WebKit2/UIProcess/CoordinatedGraphics/LayerTreeRenderer.h.
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.cpp.
* platform/graphics/texmap/coordinated/CoordinatedImageBacking.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedImageBacking.h.
* platform/graphics/texmap/coordinated/CoordinatedLayerInfo.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedLayerInfo.h.
* platform/graphics/texmap/coordinated/CoordinatedSurface.cpp: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.cpp.
* platform/graphics/texmap/coordinated/CoordinatedSurface.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/CoordinatedSurface.h.
* platform/graphics/texmap/coordinated/CoordinatedTile.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.cpp.
* platform/graphics/texmap/coordinated/CoordinatedTile.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/CoordinatedTile.h.
* platform/graphics/texmap/coordinated/SurfaceUpdateInfo.h: Renamed from Source/WebKit2/Shared/CoordinatedGraphics/SurfaceUpdateInfo.h.
* platform/graphics/texmap/coordinated/UpdateAtlas.cpp: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.cpp.
* platform/graphics/texmap/coordinated/UpdateAtlas.h: Renamed from Source/WebKit2/WebProcess/WebPage/CoordinatedGraphics/UpdateAtlas.h.

Source/WebKit2:

* CMakeLists.txt:
* Scripts/webkit2/messages.py:
* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.cpp:
* Shared/CoordinatedGraphics/CoordinatedGraphicsArgumentCoders.h:
* Shared/CoordinatedGraphics/WebCoordinatedSurface.h:
* Target.pri:
* UIProcess/API/efl/EwkView.cpp:
* UIProcess/API/efl/EwkView.h:
* UIProcess/API/qt/qquickwebpage.cpp:
* UIProcess/API/qt/raw/qrawwebview.cpp:
* UIProcess/API/qt/raw/qrawwebview_p.h:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.cpp:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.h:
* UIProcess/CoordinatedGraphics/CoordinatedLayerTreeHostProxy.messages.in:
* UIProcess/efl/PageClientBase.cpp:
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
* UIProcess/qt/QtWebPageSGNode.cpp:
* UIProcess/qt/QtWebPageSGNode.h:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.cpp:
* WebProcess/WebPage/CoordinatedGraphics/CoordinatedLayerTreeHost.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Add support for text decoration "wavy" style
commit-queue@webkit.org [Fri, 1 Feb 2013 07:26:02 +0000 (07:26 +0000)]
[Qt] Add support for text decoration "wavy" style
https://bugs.webkit.org/show_bug.cgi?id=93507

Patch by Lamarque V. Souza <Lamarque.Souza@basyskom.com> on 2013-01-31
Reviewed by Simon Hausmann.

Source/WebCore:

Add support for text decoration "wavy" style for Qt platform.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::toQPenStyle):
Remove FIXME comments obsoleted by this patch.
(WebCore::GraphicsContext::drawLine):
Implement wavy style line tracer.

LayoutTests:

Add pixel-test expected results for CSS3 text decoration tests for Qt port.

* platform/qt-5.0-wk1/fast/css3-text/css3-text-decoration/repaint/repaint-text-decoration-style-expected.png: Added.
* platform/qt-5.0-wk1/fast/css3-text/css3-text-decoration/text-decoration-style-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CPP,GObject,ObjC] Add 'enum' skip to CodeGenerator{CPP,GObject,ObjC}.pm
commit-queue@webkit.org [Fri, 1 Feb 2013 07:07:33 +0000 (07:07 +0000)]
[CPP,GObject,ObjC] Add 'enum' skip to CodeGenerator{CPP,GObject,ObjC}.pm
https://bugs.webkit.org/show_bug.cgi?id=108565

Patch by Nils Barth <nbarth@google.com> on 2013-01-31
Reviewed by Kentaro Hara.

Since legacy code generators (CodeGenerator{CPP,GObject,ObjC}.pm)
do not support enumerations, add test to skip attributes of enum type.
This lets us remove #if macro from enum in test file and not need
these in future.
Also minor associated code cleaning:
  auxiliary variable: $type = $attribute->signature->type.

Test: bindings/scripts/test/TestObj.idl (run-bindings-test)

* bindings/scripts/CodeGeneratorCPP.pm:
(SkipAttribute):
* bindings/scripts/CodeGeneratorGObject.pm:
(SkipAttribute):
* bindings/scripts/CodeGeneratorObjC.pm:
(SkipAttribute):
* bindings/scripts/test/TestObj.idl: remove #if macro

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
commit-queue@webkit.org [Fri, 1 Feb 2013 06:56:01 +0000 (06:56 +0000)]
[Chromium] WebViewTest.SetCompositionFromExistingText failing after r141479
https://bugs.webkit.org/show_bug.cgi?id=108543

Patch by Aurimas Liutikas <aurimas@chromium.org> on 2013-01-31
Reviewed by Ryosuke Niwa.

Fixing a bug that was uncovered after fixing http://trac.webkit.org/changeset/141479

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::setCompositionFromExistingText):
* tests/WebViewTest.cpp:
    Re-enabling the test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Native Memory Instrumentation: replace nodeName argument with className
loislo@chromium.org [Fri, 1 Feb 2013 06:52:09 +0000 (06:52 +0000)]
Web Inspector: Native Memory Instrumentation: replace nodeName argument with className
https://bugs.webkit.org/show_bug.cgi?id=107278

Reviewed by Yury Semikhatsky.

I replaced nodeName with className because we newer report node name for private and raw buffers
but need to report their class names.

* wtf/MemoryInstrumentation.cpp:
(WTF::MemoryInstrumentation::reportLinkToBuffer):
(WTF::MemoryClassInfo::addRawBuffer):
(WTF::MemoryClassInfo::addPrivateBuffer):
* wtf/MemoryInstrumentation.h:
(WTF::MemoryInstrumentation::addRawBuffer):
(MemoryClassInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, followup fix for r141535.
morrita@google.com [Fri, 1 Feb 2013 06:36:02 +0000 (06:36 +0000)]
Unreviewed, followup fix for r141535.

* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to r180023. Requested by
commit-queue@webkit.org [Fri, 1 Feb 2013 06:28:28 +0000 (06:28 +0000)]
Unreviewed.  Rolled Chromium DEPS to r180023.  Requested by
thakis_ via sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r141192): Crash beneath cti_op_get_by_id_generic @ discussions.apple.com
ggaren@apple.com [Fri, 1 Feb 2013 05:54:04 +0000 (05:54 +0000)]
REGRESSION (r141192): Crash beneath cti_op_get_by_id_generic @ discussions.apple.com
https://bugs.webkit.org/show_bug.cgi?id=108576

Reviewed by Filip Pizlo.

This was a long-standing bug. The DFG would destructively reuse a register
in op_convert_this, but:

    * The bug only presented during speculation failure for type Other

    * The bug presented by removing the low bits of a pointer, which
    used to be harmless, since all objects were so aligned anyway.

* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile): Don't reuse our this register as
our scratch register. The whole point of our scratch register is to
avoid destructively modifying our this register. I'm pretty sure this
was a copy-paste error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, disabling failing test.
morrita@google.com [Fri, 1 Feb 2013 05:37:58 +0000 (05:37 +0000)]
Unreviewed, disabling failing test.

* tests/WebFrameTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoProvide a sensible default architecture when building on iOS SDKs
commit-queue@webkit.org [Fri, 1 Feb 2013 05:01:35 +0000 (05:01 +0000)]
Provide a sensible default architecture when building on iOS SDKs
https://bugs.webkit.org/show_bug.cgi?id=108395

Patch by David Farler <dfarler@apple.com> on 2013-01-31
Reviewed by Anders Carlsson.

* Scripts/webkitdirs.pm:
(determineArchitecture): Anchor SDK regex matches at the beginning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRefactoring: Remove the default argument value for Node::setFocus
tkent@chromium.org [Fri, 1 Feb 2013 04:25:42 +0000 (04:25 +0000)]
Refactoring: Remove the default argument value for Node::setFocus
https://bugs.webkit.org/show_bug.cgi?id=108554

Reviewed by Kentaro Hara.

There is no code to use the default argument.
No new tests. Just a refactoring.

* dom/Node.h: Remove default argument value for setFocus.
* dom/ContainerNode.h:
(ContainerNode): Ditto.
* html/HTMLAreaElement.h:
(HTMLAreaElement): Add OVERRIDE to setFocus.
* html/HTMLFrameElementBase.h:
(HTMLFrameElementBase): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Unreviewed, rebaselining expectations.
morrita@google.com [Fri, 1 Feb 2013 04:20:01 +0000 (04:20 +0000)]
[Chromium] Unreviewed, rebaselining expectations.

* platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-e-expected.txt: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-n-expected.txt: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-s-expected.txt: Added.
* platform/chromium-mac/platform/chromium/rubberbanding/event-overhang-w-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Track] Closed Caption button shouldn't be visible if all the track resources have...
vcarbune@chromium.org [Fri, 1 Feb 2013 04:03:04 +0000 (04:03 +0000)]
[Track] Closed Caption button shouldn't be visible if all the track resources have failed loading
https://bugs.webkit.org/show_bug.cgi?id=106285

Reviewed by Eric Carlson.

Source/WebCore:

Updated existing test cases.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTracksAreReady): Checked whether there are tracks not loaded
when the algorithm began.
(WebCore::HTMLMediaElement::textTrackReadyStateChanged): If the ready state changed to
FailedToLoad the media controls should check whether there are other caption tracks
and hide the button if not.
(WebCore::HTMLMediaElement::didAddTrack): Added trigger to closedCaptionsTrackChanged.
(WebCore::HTMLMediaElement::hasClosedCaptions): Updated check to skip tracks that
failed to load.
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset): Used the newly added method.
(WebCore::MediaControls::refreshClosedCaptionsButtonVisibility): Added container method for
default behaviour for refreshing the visibility of the caption button.
(WebCore::MediaControls::closedCaptionTracksChanged): Used the newly added method.
(WebCore):
* html/shadow/MediaControls.h:
(MediaControls):

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::textTracksAreReady):
(WebCore::HTMLMediaElement::textTrackReadyStateChanged):
(WebCore::HTMLMediaElement::setReadyState):
(WebCore::HTMLMediaElement::didAddTrack):
(WebCore::HTMLMediaElement::hasClosedCaptions):
* html/shadow/MediaControls.cpp:
(WebCore::MediaControls::reset):
(WebCore::MediaControls::refreshClosedCaptionsButtonVisibility):
(WebCore::MediaControls::closedCaptionTracksChanged):
(WebCore):
* html/shadow/MediaControls.h:
(MediaControls):

LayoutTests:

Updated tests to include improved behavior.

* media/video-controls-captions-expected.txt: Updated.
* media/video-controls-captions.html: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agobuildbot should not rely on webkitpy
rniwa@webkit.org [Fri, 1 Feb 2013 04:01:57 +0000 (04:01 +0000)]
buildbot should not rely on webkitpy
https://bugs.webkit.org/show_bug.cgi?id=107379

Reviewed by Eric Seidel.

Move all Python files used in buildbot configuration into BuildSlaveSupport directory.
Once this patch is landed, we can stop restarting the master on webkitpy changes.

* BuildSlaveSupport/build.webkit.org-config/committer_auth.py:
* BuildSlaveSupport/build.webkit.org-config/htdigestparser.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser.py.
* BuildSlaveSupport/build.webkit.org-config/htdigestparser_unittest.py: Copied from Tools/Scripts/webkitpy/common/net/htdigestparser_unittest.py.
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
* BuildSlaveSupport/build.webkit.org-config/wkbuild.py: Copied from Tools/Scripts/webkitpy/common/config/build.py.
* BuildSlaveSupport/build.webkit.org-config/wkbuild_unittest.py: Copied from Tools/Scripts/webkitpy/common/config/build_unittest.py.
(ShouldBuildTest.test_should_build):
* Scripts/webkitpy/common/config/build.py: Removed.
* Scripts/webkitpy/common/config/build_unittest.py: Removed.
* Scripts/webkitpy/common/net/htdigestparser.py: Removed.
* Scripts/webkitpy/common/net/htdigestparser_unittest.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r140231): media track layout tests crashing
commit-queue@webkit.org [Fri, 1 Feb 2013 03:57:37 +0000 (03:57 +0000)]
REGRESSION(r140231): media track layout tests crashing
https://bugs.webkit.org/show_bug.cgi?id=107579

Patch by Dima Gorbik <dgorbik@apple.com> on 2013-01-31
Reviewed by Eric Carlson.

Source/WebCore:

We were using non-standard element names with HTMLElement, which made v8 try to cast
WebVTTElements to HTMLUnknownElements which was not possible. Subclassing Element instead
of HTMLElement, though this requires building HTMLElements from WebVTTElements for creating
a DOM tree. The code has been refactored to move WebVTT node type to QuialifiedName mappings
inside the WebVTTElement class. All WebVTTElements in the shadow dom tree now are in the
namespace defined by 'NullAtom'. This prevents regular styles from being applied to <b>, <i>
and similar tags. Those have to be styled separately without reusing existing QualifiedNames
and their styles. https://bugs.webkit.org/show_bug.cgi?id=107214

Unskipping tests to cover this.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOne):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::canShareStyleWithElement):
* html/track/TextTrackCue.cpp:
(WebCore::TextTrackCue::copyWebVTTNodeToDOMTree):
(WebCore::TextTrackCue::getCueAsHTML):
(WebCore::TextTrackCue::createCueRenderingTree):
(WebCore::TextTrackCue::markFutureAndPastNodes):
* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::cueShadowPseudoId):
* html/track/WebVTTElement.cpp:
(WebCore::nodeTypeToTagName): get a QualifiedName to use in the shadow DOM tree.
(WebCore::WebVTTElement::WebVTTElement):
(WebCore::WebVTTElement::create):
(WebCore::WebVTTElement::cloneElementWithoutAttributesAndChildren):
(WebCore::WebVTTElement::createEquivalentHTMLElement): create an HTMLElement to use in the DOM tree.
* html/track/WebVTTElement.h:
(WebCore::WebVTTElement::setWebVTTNodeType):
(WebCore::WebVTTElement::webVTTNodeType):
(WebCore::WebVTTElement::isPastNode):
(WebCore::WebVTTElement::setIsPastNode):
(WebCore::WebVTTElement::voiceAttributeName):
* html/track/WebVTTParser.cpp:
(WebCore::tokenToNodeType): determine a WebVTT node type for the token.
(WebCore::WebVTTParser::constructTreeFromToken):

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt][WK2] Another attempt to fix build after recent WebKit2 changes
rafael.lobo@openbossa.org [Fri, 1 Feb 2013 03:52:13 +0000 (03:52 +0000)]
[Qt][WK2] Another attempt to fix build after recent WebKit2 changes
https://bugs.webkit.org/show_bug.cgi?id=108548

Reviewed by Anders Carlsson.

* Platform/CoreIPC/unix/ConnectionUnix.cpp:
(CoreIPC::Connection::platformInvalidate):
(CoreIPC::Connection::processMessage): Change Deque to Vector and do similar
logic as on patch for https://bugs.webkit.org/show_bug.cgi?id=108517
(CoreIPC::Connection::open):
(CoreIPC::Connection::setShouldCloseConnectionOnProcessTermination):
* Platform/qt/WorkQueueQt.cpp: Reflect changes on Qt WorkQueue to increase ref
count when the execution is started and decrease it when the work item is deleted,
following the logic on https://bugs.webkit.org/show_bug.cgi?id=108544
(WorkQueue::WorkItemQt::~WorkItemQt):
(WorkQueue::WorkItemQt::execute):
(WorkQueue::dispatch):
(WorkQueue::dispatchAfterDelay):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::getPluginPath): This function was moved from WebProcessProxy but
mac specific code was not protected properly: https://bugs.webkit.org/show_bug.cgi?id=108407

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Unreviewed, marking a failing test.
morrita@google.com [Fri, 1 Feb 2013 03:51:12 +0000 (03:51 +0000)]
[Chromium] Unreviewed, marking a failing test.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r141479.
commit-queue@webkit.org [Fri, 1 Feb 2013 03:20:48 +0000 (03:20 +0000)]
Unreviewed, rolling out r141479.
http://trac.webkit.org/changeset/141479
https://bugs.webkit.org/show_bug.cgi?id=108564

breaks chromium test (Requested by morrita on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31

Source/WebCore:

* editing/Editor.cpp:
* editing/Editor.h:
(Editor):

Source/WebKit/chromium:

* public/WebViewClient.h:
* src/EditorClientImpl.cpp:
(WebKit::EditorClientImpl::respondToChangedSelection):

Source/WebKit/efl:

* WebCoreSupport/EditorClientEfl.cpp:
(WebCore::EditorClientEfl::respondToChangedSelection):

Source/WebKit/gtk:

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::respondToChangedSelection):

Source/WebKit/mac:

* WebView/WebHTMLView.mm:
(-[WebHTMLView _updateSelectionForInputManager]):

Source/WebKit/win:

* WebView.cpp:
(WebView::updateSelectionForIME):

LayoutTests:

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename from parentOrHost* to parentOrShadowHost* in Node.h.
commit-queue@webkit.org [Fri, 1 Feb 2013 03:17:19 +0000 (03:17 +0000)]
Rename from parentOrHost* to parentOrShadowHost* in Node.h.
https://bugs.webkit.org/show_bug.cgi?id=108308

Source/WebCore:

Patch by Changhun Kang <temoochin@company100.net> on 2013-01-31
Reviewed by Dimitri Glazkov.

No new tests. No change in behavior.

Source/WebKit2:

Patch by Changhun Kang <temoochin@company100.net> on 2013-01-31
Reviewed by Dimitri Glazkov.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndexedDB: remove old transaction backend bootstrap code
alecflett@chromium.org [Fri, 1 Feb 2013 03:01:27 +0000 (03:01 +0000)]
IndexedDB: remove old transaction backend bootstrap code
https://bugs.webkit.org/show_bug.cgi?id=103923

Reviewed by Dimitri Glazkov.

Source/WebCore:

Finally remove all leftover code from the IndexedDB "giant
async refactor of 2012." This includes removal of all
IDBTransaction* interfaces that were shared between
the frontend and backend and a few straggling methods
like onUpgradeNeeded and onSuccess that were left from
the last stage of refactoring.

* Modules/indexeddb/IDBCallbacks.h:
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
* Modules/indexeddb/IDBDatabaseBackendImpl.h:
(WebCore):
(WebCore::IDBDatabaseBackendImpl::metadata):
(IDBDatabaseBackendImpl):
* Modules/indexeddb/IDBDatabaseBackendInterface.h:
(WebCore):
(IDBDatabaseBackendInterface):
* Modules/indexeddb/IDBObjectStoreBackendImpl.h:
(WebCore):
* Modules/indexeddb/IDBTransaction.h:
(WebCore):
(IDBTransaction):
* Modules/indexeddb/IDBTransactionBackendImpl.h:
(WebCore):
(IDBTransactionBackendImpl):
* Modules/indexeddb/IDBTransactionBackendInterface.h: Removed.
* Modules/indexeddb/IDBTransactionCallbacks.h: Removed.
* Modules/indexeddb/IDBTransactionCoordinator.h:
(WebCore):
* Target.pri:
* WebCore.gypi:
* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/chromium:

Remove all deprecated WebKit APIs from
the IDB backend.

* WebKit.gyp:
* public/WebIDBCallbacks.h:
(WebKit):
* public/WebIDBDatabase.h:
(WebKit):
* public/WebIDBTransaction.h: Removed.
* public/WebIDBTransactionCallbacks.h: Removed.
* src/AssertMatchingEnums.cpp:
* src/IDBCallbacksProxy.cpp:
* src/IDBDatabaseBackendProxy.cpp:
* src/IDBDatabaseBackendProxy.h:
(IDBDatabaseBackendProxy):
* src/IDBTransactionBackendProxy.cpp: Removed.
* src/IDBTransactionBackendProxy.h: Removed.
* src/IDBTransactionCallbacksProxy.cpp: Removed.
* src/IDBTransactionCallbacksProxy.h: Removed.
* src/WebIDBCallbacksImpl.cpp:
* src/WebIDBDatabaseImpl.cpp:
(WebKit):
* src/WebIDBDatabaseImpl.h:
(WebKit):
(WebIDBDatabaseImpl):
* src/WebIDBTransactionCallbacksImpl.cpp: Removed.
* src/WebIDBTransactionCallbacksImpl.h: Removed.
* src/WebIDBTransactionImpl.cpp: Removed.
* src/WebIDBTransactionImpl.h: Removed.
* tests/IDBAbortOnCorruptTest.cpp:
* tests/IDBDatabaseBackendTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r141349.
commit-queue@webkit.org [Fri, 1 Feb 2013 02:44:35 +0000 (02:44 +0000)]
Unreviewed, rolling out r141349.
http://trac.webkit.org/changeset/141349
https://bugs.webkit.org/show_bug.cgi?id=108422

"yet another windows ews fix needed" (Requested by lforschler
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-01-31

* Scripts/webkitpy/tool/commands/earlywarningsystem.py:
(WinEWS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@141522 268f45cc-cd09-0410-ab3c-d52691b4dbfc