WebKit-https.git
6 years agoAX: move isIgnored caching to AXObject
dmazzoni@google.com [Sat, 9 Feb 2013 23:06:00 +0000 (23:06 +0000)]
AX: move isIgnored caching to AXObject
https://bugs.webkit.org/show_bug.cgi?id=109322

Reviewed by Chris Fleizach.

There's some benefit to caching accessibilityIsIgnored
(using AXComputedObjectAttributeCache) for more than just
AXRenderObject, so move the caching code to AXObject.

AXObject now has a protected virtual method
computeAccessibilityIsIgnored, and all subclasses
override that instead.

No new tests.

* accessibility/AccessibilityImageMapLink.h:
(AccessibilityImageMapLink):
(WebCore::AccessibilityImageMapLink::computeAccessibilityIsIgnored):
* accessibility/AccessibilityList.cpp:
(WebCore::AccessibilityList::computeAccessibilityIsIgnored):
* accessibility/AccessibilityList.h:
(AccessibilityList):
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::computeAccessibilityIsIgnored):
* accessibility/AccessibilityListBox.h:
(AccessibilityListBox):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::computeAccessibilityIsIgnored):
* accessibility/AccessibilityListBoxOption.h:
(AccessibilityListBoxOption):
* accessibility/AccessibilityMediaControls.cpp:
(WebCore::AccessibilityMediaControl::computeAccessibilityIsIgnored):
(WebCore::AccessibilityMediaTimeDisplay::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMediaControls.h:
(AccessibilityMediaControl):
(WebCore::AccessibilityMediaControlsContainer::computeAccessibilityIsIgnored):
(AccessibilityMediaTimeDisplay):
* accessibility/AccessibilityMenuList.h:
(WebCore::AccessibilityMenuList::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMenuListOption.cpp:
(WebCore::AccessibilityMenuListOption::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMenuListOption.h:
(AccessibilityMenuListOption):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::computeAccessibilityIsIgnored):
* accessibility/AccessibilityMenuListPopup.h:
(AccessibilityMenuListPopup):
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::computeAccessibilityIsIgnored):
* accessibility/AccessibilityNodeObject.h:
(AccessibilityNodeObject):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::accessibilityIsIgnored):
(WebCore):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):
(WebCore::AccessibilityObject::computeAccessibilityIsIgnored):
* accessibility/AccessibilityProgressIndicator.cpp:
(WebCore::AccessibilityProgressIndicator::computeAccessibilityIsIgnored):
* accessibility/AccessibilityProgressIndicator.h:
(AccessibilityProgressIndicator):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::computeAccessibilityIsIgnored):
* accessibility/AccessibilityRenderObject.h:
(AccessibilityRenderObject):
* accessibility/AccessibilityScrollView.cpp:
(WebCore::AccessibilityScrollView::computeAccessibilityIsIgnored):
* accessibility/AccessibilityScrollView.h:
(AccessibilityScrollView):
* accessibility/AccessibilityScrollbar.h:
(WebCore::AccessibilityScrollbar::computeAccessibilityIsIgnored):
* accessibility/AccessibilitySlider.cpp:
(WebCore::AccessibilitySlider::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySliderThumb::computeAccessibilityIsIgnored):
* accessibility/AccessibilitySlider.h:
(AccessibilitySlider):
(AccessibilitySliderThumb):
* accessibility/AccessibilitySpinButton.h:
(WebCore::AccessibilitySpinButton::computeAccessibilityIsIgnored):
(WebCore::AccessibilitySpinButtonPart::computeAccessibilityIsIgnored):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::computeAccessibilityIsIgnored):
* accessibility/AccessibilityTable.h:
(AccessibilityTable):
* accessibility/AccessibilityTableCell.cpp:
(WebCore::AccessibilityTableCell::computeAccessibilityIsIgnored):
* accessibility/AccessibilityTableCell.h:
(AccessibilityTableCell):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::computeAccessibilityIsIgnored):
* accessibility/AccessibilityTableColumn.h:
(AccessibilityTableColumn):
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::computeAccessibilityIsIgnored):
* accessibility/AccessibilityTableHeaderContainer.h:
(AccessibilityTableHeaderContainer):
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::computeAccessibilityIsIgnored):
* accessibility/AccessibilityTableRow.h:
(AccessibilityTableRow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake TestWebKitAPI work for iOS
commit-queue@webkit.org [Sat, 9 Feb 2013 22:53:14 +0000 (22:53 +0000)]
Make TestWebKitAPI work for iOS
https://bugs.webkit.org/show_bug.cgi?id=108978

Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.

Source/WebCore:

Tests already exist - refactor only.

* WebCore.exp.in: Lumped __ZNK7WebCore4KURL7hasPathEv with related methods.
* platform/KURL.cpp: Inlined hasPath() into the header
* platform/KURL.h: Inlined hasPath() into the header

Tools:

* Makefile: Added TestWebKitAPI to iOS MODULES list.
* TestWebKitAPI/Configurations/Base.xcconfig:
- Include FeatureDefines
- Removed VALID_ARCHS
- Removed FRAMEWORK_SEARCH_PATHS - allows building against other SDKs
- Excluded source files per platform
* TestWebKitAPI/Configurations/TestWebKitAPI.xcconfig:
- framework and library switches per platform
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
- Remove explicit framework and library linking (moved to xcconfigs)
- Added iOS main.mm
* TestWebKitAPI/config.h:
- Guard importing Cocoa.h and WebKit2_C.h on iOS
* TestWebKitAPI/ios/mainIOS.mm: Copied from Tools/TestWebKitAPI/mac/main.mm.
* TestWebKitAPI/mac/mainMac.mm: Renamed from Tools/TestWebKitAPI/mac/main.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Reverting earlier change now
schenney@chromium.org [Sat, 9 Feb 2013 21:00:11 +0000 (21:00 +0000)]
[Chromium] Reverting earlier change now

Unreviewed expectations.

* platform/chromium/TestExpectations: Removed all the expectations added earlier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CHROMIUM] Suppress c4267 build warnings for Win64 tests
jschuh@chromium.org [Sat, 9 Feb 2013 20:13:54 +0000 (20:13 +0000)]
[CHROMIUM] Suppress c4267 build warnings for Win64 tests
https://bugs.webkit.org/show_bug.cgi?id=109359

Reviewed by Abhishek Arya.

* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLoad event fires too early with threaded HTML parser
abarth@webkit.org [Sat, 9 Feb 2013 19:34:08 +0000 (19:34 +0000)]
Load event fires too early with threaded HTML parser
https://bugs.webkit.org/show_bug.cgi?id=108984

Reviewed by Eric Seidel.

Previously, the DocumentLoader would always be on the stack when the
HTMLDocumentParser was processing data from the network.  The
DocumentLoader would then tell isLoadingInAPISense not to fire the load
event.  Now that we process data asynchronously with the threaded
parser, the DocumentLoader is not always on the stack, which means we
need to delay the load event using the clause that asks the parser
whether it is processing data.

Unfortunately, that clause is fragile because we can check for load
completion while we're switching parsers between the network-created
parser and a script-created parser. To avoid accidentially triggerin
the load event during these "gaps," this patch introduces a counter on
document to record how many parsers are active on the stack.  While
that numer is non-zero, we'll delay the load event. When that number
reaches zero, we'll check for load complete.

That last step is required because the DocumentLoader::finishLoading
method is no longer guarunteed to check for load complete after calling
finish on the parser because the finish operation might complete
asynchronously.

After this patch, the threaded parser passes all but four fast/parser
tests.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::hasActiveParser):
(WebCore):
(WebCore::Document::decrementActiveParserCount):
* dom/Document.h:
(Document):
(WebCore::Document::incrementActiveParserCount):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::processParsedChunkFromBackgroundParser):
(WebCore::HTMLDocumentParser::pumpTokenizer):
* html/parser/HTMLParserScheduler.cpp:
(WebCore::ActiveParserSession::ActiveParserSession):
(WebCore):
(WebCore::ActiveParserSession::~ActiveParserSession):
(WebCore::PumpSession::PumpSession):
(WebCore::PumpSession::~PumpSession):
* html/parser/HTMLParserScheduler.h:
(WebCore):
(ActiveParserSession):
(PumpSession):
* loader/DocumentLoader.cpp:
(WebCore::DocumentLoader::isLoadingInAPISense):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDFG should allow phases to break Phi's and then have one phase to rebuild them
fpizlo@apple.com [Sat, 9 Feb 2013 19:33:00 +0000 (19:33 +0000)]
DFG should allow phases to break Phi's and then have one phase to rebuild them
https://bugs.webkit.org/show_bug.cgi?id=108414

Reviewed by Mark Hahnenberg.

Introduces two new DFG forms: LoadStore and ThreadedCPS. These are described in
detail in DFGCommon.h.

Consequently, DFG phases no longer have to worry about preserving data flow
links between basic blocks. It is generally always safe to request that the
graph be dethreaded (Graph::dethread), which brings it into LoadStore form, where
the data flow is implicit. In this form, only liveness-at-head needs to be
preserved.

All of the machinery for "threading" the graph to introduce data flow between
blocks is now moved out of the bytecode parser and into the CPSRethreadingPhase.
All phases that previously did this maintenance themselves now just rely on
being able to dethread the graph. The one exception is the structure check
hoising phase, which operates over a threaded graph and preserves it, for the
sake of performance.

Also moved two other things into their own phases: unification (previously found
in the parser) and prediction injection (previously found in various places).

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* bytecode/Operands.h:
(Operands):
(JSC::Operands::sizeFor):
(JSC::Operands::atFor):
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
(JSC::DFG::AbstractState::mergeStateAtTail):
* dfg/DFGAllocator.h:
(JSC::DFG::::allocateSlow):
* dfg/DFGArgumentsSimplificationPhase.cpp:
(JSC::DFG::ArgumentsSimplificationPhase::run):
* dfg/DFGBasicBlockInlines.h:
(DFG):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::getLocal):
(JSC::DFG::ByteCodeParser::getArgument):
(JSC::DFG::ByteCodeParser::flushDirect):
(JSC::DFG::ByteCodeParser::parseBlock):
(DFG):
(JSC::DFG::ByteCodeParser::parse):
* dfg/DFGCFGSimplificationPhase.cpp:
(JSC::DFG::CFGSimplificationPhase::run):
(JSC::DFG::CFGSimplificationPhase::killUnreachable):
(JSC::DFG::CFGSimplificationPhase::keepOperandAlive):
(CFGSimplificationPhase):
(JSC::DFG::CFGSimplificationPhase::fixJettisonedPredecessors):
(JSC::DFG::CFGSimplificationPhase::mergeBlocks):
* dfg/DFGCPSRethreadingPhase.cpp: Added.
(DFG):
(CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::CPSRethreadingPhase):
(JSC::DFG::CPSRethreadingPhase::run):
(JSC::DFG::CPSRethreadingPhase::freeUnnecessaryNodes):
(JSC::DFG::CPSRethreadingPhase::clearVariablesAtHeadAndTail):
(JSC::DFG::CPSRethreadingPhase::addPhiSilently):
(JSC::DFG::CPSRethreadingPhase::addPhi):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeGetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocalFor):
(JSC::DFG::CPSRethreadingPhase::canonicalizeFlushOrPhantomLocal):
(JSC::DFG::CPSRethreadingPhase::canonicalizeSetArgument):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlock):
(JSC::DFG::CPSRethreadingPhase::canonicalizeLocalsInBlocks):
(JSC::DFG::CPSRethreadingPhase::propagatePhis):
(JSC::DFG::CPSRethreadingPhase::PhiStackEntry::PhiStackEntry):
(PhiStackEntry):
(JSC::DFG::CPSRethreadingPhase::phiStackFor):
(JSC::DFG::performCPSRethreading):
* dfg/DFGCPSRethreadingPhase.h: Added.
(DFG):
* dfg/DFGCSEPhase.cpp:
(CSEPhase):
(JSC::DFG::CSEPhase::performNodeCSE):
* dfg/DFGCommon.cpp:
(WTF):
(WTF::printInternal):
* dfg/DFGCommon.h:
(JSC::DFG::logCompilationChanges):
(DFG):
(WTF):
* dfg/DFGConstantFoldingPhase.cpp:
(JSC::DFG::ConstantFoldingPhase::foldConstants):
* dfg/DFGDriver.cpp:
(JSC::DFG::compile):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::Graph):
(JSC::DFG::Graph::dump):
(JSC::DFG::Graph::dethread):
(JSC::DFG::Graph::collectGarbage):
* dfg/DFGGraph.h:
(JSC::DFG::Graph::performSubstitution):
(Graph):
(JSC::DFG::Graph::performSubstitutionForEdge):
(JSC::DFG::Graph::convertToConstant):
* dfg/DFGNode.h:
(JSC::DFG::Node::convertToPhantomLocal):
(Node):
(JSC::DFG::Node::convertToGetLocal):
(JSC::DFG::Node::hasVariableAccessData):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGPhase.cpp:
(JSC::DFG::Phase::beginPhase):
* dfg/DFGPhase.h:
(JSC::DFG::runAndLog):
* dfg/DFGPredictionInjectionPhase.cpp: Added.
(DFG):
(PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::PredictionInjectionPhase):
(JSC::DFG::PredictionInjectionPhase::run):
(JSC::DFG::performPredictionInjection):
* dfg/DFGPredictionInjectionPhase.h: Added.
(DFG):
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::run):
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGStructureCheckHoistingPhase.cpp:
(JSC::DFG::StructureCheckHoistingPhase::run):
* dfg/DFGUnificationPhase.cpp: Added.
(DFG):
(UnificationPhase):
(JSC::DFG::UnificationPhase::UnificationPhase):
(JSC::DFG::UnificationPhase::run):
(JSC::DFG::performUnification):
* dfg/DFGUnificationPhase.h: Added.
(DFG):
* dfg/DFGValidate.cpp:
(JSC::DFG::Validate::validate):
(JSC::DFG::Validate::dumpGraphIfAppropriate):
* dfg/DFGVirtualRegisterAllocationPhase.cpp:
(JSC::DFG::VirtualRegisterAllocationPhase::run):
* llint/LLIntSlowPaths.cpp:
(JSC::LLInt::setUpCall):
* runtime/JSCJSValue.cpp:
(JSC::JSValue::dump):
* runtime/JSString.h:
(JSString):
* runtime/Options.h:
(JSC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd a link to EFL perf bot on build.webkit.org
rniwa@webkit.org [Sat, 9 Feb 2013 19:29:25 +0000 (19:29 +0000)]
Add a link to EFL perf bot on build.webkit.org
https://bugs.webkit.org/show_bug.cgi?id=109342

Reviewed by Gyuyoung Kim.

Added.

* BuildSlaveSupport/build.webkit.org-config/templates/root.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse IGNORE_EXCEPTION for initialized, but unused, ExceptionCodes.
mkwst@chromium.org [Sat, 9 Feb 2013 19:19:09 +0000 (19:19 +0000)]
Use IGNORE_EXCEPTION for initialized, but unused, ExceptionCodes.
https://bugs.webkit.org/show_bug.cgi?id=109295

Reviewed by Darin Adler.

The monster patch in http://wkbug.com/108771 missed an entire class of
ignored exceptions. It only dealt with call sites that never initialized
the ExceptionCode variable, on the assumption that only such call sites
would ignore the variable's value.

That was a flawed assumption: a large number of sites that initialize the
ExceptionCode to 0 ignore it regardless. This patch deals with the
almost-as-large set of callsites that initialize the variable, pass it to
a function, and then never touch it again.

* Modules/indexeddb/IDBDatabase.cpp:
(WebCore::IDBDatabase::forceClose):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaSelectedTextRange):
(WebCore::AccessibilityRenderObject::visiblePositionForIndex):
(WebCore::AccessibilityRenderObject::indexForVisiblePosition):
* accessibility/atk/WebKitAccessibleInterfaceText.cpp:
(getSelectionOffsetsForObject):
* accessibility/atk/WebKitAccessibleUtil.cpp:
(selectionBelongsToObject):
* dom/Node.cpp:
(WebCore::Node::textRects):
* editing/DeleteButtonController.cpp:
(WebCore::DeleteButtonController::hide):
* editing/EditingStyle.cpp:
(WebCore::EditingStyle::styleAtSelectionStart):
* editing/Editor.cpp:
(WebCore::Editor::canDeleteRange):
(WebCore::Editor::pasteAsPlainText):
(WebCore::Editor::pasteAsFragment):
(WebCore::Editor::shouldDeleteRange):
(WebCore::Editor::dispatchCPPEvent):
(WebCore::Editor::setComposition):
(WebCore::Editor::advanceToNextMisspelling):
(WebCore::isFrameInRange):
* editing/EditorCommand.cpp:
(WebCore::expandSelectionToGranularity):
* editing/MergeIdenticalElementsCommand.cpp:
(WebCore::MergeIdenticalElementsCommand::doApply):
* editing/SplitElementCommand.cpp:
(WebCore::SplitElementCommand::doUnapply):
* editing/SplitTextNodeCommand.cpp:
(WebCore::SplitTextNodeCommand::doApply):
* editing/TextCheckingHelper.cpp:
(WebCore::expandToParagraphBoundary):
(WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
(WebCore::TextCheckingHelper::isUngrammatical):
(WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
* editing/TextInsertionBaseCommand.cpp:
(WebCore::dispatchBeforeTextInsertedEvent):
(WebCore::canAppendNewLineFeedToSelection):
* editing/TextIterator.cpp:
(WebCore::findPlainText):
* editing/htmlediting.cpp:
(WebCore::extendRangeToWrappingNodes):
(WebCore::isNodeVisiblyContainedWithin):
* editing/visible_units.cpp:
(WebCore::nextBoundary):
* html/FileInputType.cpp:
(WebCore::FileInputType::createShadowSubtree):
* html/HTMLKeygenElement.cpp:
(WebCore::HTMLKeygenElement::HTMLKeygenElement):
* html/HTMLScriptElement.cpp:
(WebCore::HTMLScriptElement::setText):
* html/HTMLTitleElement.cpp:
(WebCore::HTMLTitleElement::setText):
* html/HTMLTrackElement.cpp:
(WebCore::HTMLTrackElement::didCompleteLoad):
* html/RangeInputType.cpp:
(WebCore::RangeInputType::createShadowSubtree):
* html/SearchInputType.cpp:
(WebCore::SearchInputType::createShadowSubtree):
* html/TextFieldInputType.cpp:
(WebCore::TextFieldInputType::createShadowSubtree):
* html/track/TextTrackList.cpp:
(TextTrackList::asyncEventTimerFired):
* inspector/DOMPatchSupport.cpp:
(WebCore::DOMPatchSupport::patchDocument):
* inspector/InspectorDatabaseAgent.cpp:
(WebCore):
* inspector/InspectorFileSystemAgent.cpp:
(WebCore):
* page/DOMSelection.cpp:
(WebCore::DOMSelection::addRange):
* page/DragController.cpp:
(WebCore::DragController::dispatchTextInputEventFor):
* page/EventHandler.cpp:
(WebCore::EventHandler::dispatchMouseEvent):
(WebCore::EventHandler::handleTouchEvent):
* page/FrameActionScheduler.cpp:
(WebCore::EventFrameAction::fire):
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::shouldWaitForLoadingOfResource):
* svg/SVGDocument.cpp:
(WebCore::SVGDocument::dispatchZoomEvent):
(WebCore::SVGDocument::dispatchScrollEvent):
* svg/SVGLength.cpp:
(WebCore::SVGLength::SVGLength):
(WebCore::SVGLength::value):
* xml/parser/XMLDocumentParser.cpp:
(WebCore::XMLDocumentParser::exitText):
* xml/parser/XMLDocumentParserQt.cpp:
(WebCore::XMLDocumentParser::parse):
(WebCore::XMLDocumentParser::startDocument):
(WebCore::XMLDocumentParser::parseCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Update my IRC nickname in committers.py.
ch.dumez@sisa.samsung.com [Sat, 9 Feb 2013 19:11:34 +0000 (19:11 +0000)]
Unreviewed. Update my IRC nickname in committers.py.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agobuild-webkit: document sdk, debug, release, device, and simulator options
commit-queue@webkit.org [Sat, 9 Feb 2013 19:09:03 +0000 (19:09 +0000)]
build-webkit: document sdk, debug, release, device, and simulator options
https://bugs.webkit.org/show_bug.cgi?id=109221

Patch by David Farler <dfarler@apple.com> on 2013-02-09
Reviewed by David Kilzer.

* Scripts/build-webkit: Add options to usage
* Scripts/webkitdirs.pm: Remove --deploy and --devel checks

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[skia] Fix memory management in SkiaImageFilterBuilder and friends.
senorblanco@chromium.org [Sat, 9 Feb 2013 19:05:20 +0000 (19:05 +0000)]
[skia] Fix memory management in SkiaImageFilterBuilder and friends.
https://bugs.webkit.org/show_bug.cgi?id=109326

Sadly, skia has no official ref-counted pointers, so we must make do
with SkAutoTUnref.

Reviewed by James Robinson.

Correctness covered by existing tests in css3/filters.

* platform/graphics/filters/skia/FEBlendSkia.cpp:
(WebCore::FEBlend::createImageFilter):
* platform/graphics/filters/skia/FEComponentTransferSkia.cpp:
(WebCore::FEComponentTransfer::createImageFilter):
* platform/graphics/filters/skia/FELightingSkia.cpp:
(WebCore::FELighting::createImageFilter):
Adopt refs produced by the build() pass with SkAutoTUnref.
* platform/graphics/filters/skia/SkiaImageFilterBuilder.cpp:
(WebCore::SkiaImageFilterBuilder::~SkiaImageFilterBuilder):
Unref the builder's hashmap effect pointers.
(WebCore::SkiaImageFilterBuilder::build):
Ref the pointer returned to the caller, and use SkAutoTUnref
internally while building the tree.
* platform/graphics/filters/skia/SkiaImageFilterBuilder.h:
(SkiaImageFilterBuilder):
Add a destructor to SkiaImageFilterBuilder.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] move context menu data tracking to TestRunner library
jochen@chromium.org [Sat, 9 Feb 2013 19:01:43 +0000 (19:01 +0000)]
[chromium] move context menu data tracking to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109313

Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebKit):
(WebTestDelegate):
* DumpRenderTree/chromium/TestRunner/public/WebTestProxy.h:
(WebKit):
(WebTestRunner::WebTestProxy::showContextMenu):
* DumpRenderTree/chromium/TestRunner/src/EventSender.cpp:
(WebTestRunner):
(WebTestRunner::EventSender::setContextMenuData):
(WebTestRunner::EventSender::contextClick):
* DumpRenderTree/chromium/TestRunner/src/EventSender.h:
(WebKit):
(EventSender):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::showContextMenu):
(WebTestRunner):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::showContextMenu):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] move methods that change initial testRunner state to TestRunner library
jochen@chromium.org [Sat, 9 Feb 2013 18:55:36 +0000 (18:55 +0000)]
[chromium] move methods that change initial testRunner state to TestRunner library
https://bugs.webkit.org/show_bug.cgi?id=109043

Reviewed by Adam Barth.

* DumpRenderTree/chromium/TestRunner/public/WebTestInterfaces.h:
(WebKit):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.cpp:
(WebTestRunner::TestInterfaces::configureForTestWithURL):
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestInterfaces.h:
(WebKit):
(TestInterfaces):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::showDevTools):
(WebTestRunner):
(WebTestRunner::TestRunner::showWebInspector):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestInterfaces.cpp:
(WebTestRunner::WebTestInterfaces::configureForTestWithURL):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::runFileTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd myself as a reviewer. (Yay!!!!!)
thakis@chromium.org [Sat, 9 Feb 2013 18:41:26 +0000 (18:41 +0000)]
Add myself as a reviewer. (Yay!!!!!)
https://bugs.webkit.org/show_bug.cgi?id=109110

Unreviewed.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Rename AXObject::cachedIsIgnoredValue to lastKnownIsIgnoredValue
dmazzoni@google.com [Sat, 9 Feb 2013 18:35:47 +0000 (18:35 +0000)]
AX: Rename AXObject::cachedIsIgnoredValue to lastKnownIsIgnoredValue
https://bugs.webkit.org/show_bug.cgi?id=108238

Reviewed by Chris Fleizach.

Simple refactoring, no new tests.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::getOrCreate):
(WebCore::AXObjectCache::childrenChanged):
* accessibility/AccessibilityObject.cpp:
(WebCore::AccessibilityObject::AccessibilityObject):
(WebCore::AccessibilityObject::lastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::setLastKnownIsIgnoredValue):
(WebCore::AccessibilityObject::notifyIfIgnoredValueChanged):
* accessibility/AccessibilityObject.h:
(AccessibilityObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Text Autosizing] Cleanup change: converter the pointer argument to be a reference...
commit-queue@webkit.org [Sat, 9 Feb 2013 18:34:02 +0000 (18:34 +0000)]
[Text Autosizing] Cleanup change: converter the pointer argument to be a reference since
non-null pointer is always expected.
https://bugs.webkit.org/show_bug.cgi?id=109079

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.

Cleanup change, no need to add new tests or modify the existing ones.

* rendering/TextAutosizer.cpp:

Changed parameter from a pointer to a reference in the methods below.

(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::isNarrowDescendant):
(WebCore::TextAutosizer::isWiderDescendant):
(WebCore::TextAutosizer::isAutosizingCluster):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):

* rendering/TextAutosizer.h: updated method prototypes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[TexMap] Separate classes per file in TextureMapperBackingStore.h
rafael.lobo@openbossa.org [Sat, 9 Feb 2013 18:15:14 +0000 (18:15 +0000)]
[TexMap] Separate classes per file in TextureMapperBackingStore.h
https://bugs.webkit.org/show_bug.cgi?id=109333

Reviewed by Noam Rosenthal.

TextureMapperBackingStore.h had the classes TextureMapperBackingStore,
TextureMapperTiledBackingStore, TextureMapperSurfaceBackingStore and
TextureMapperTile which was quite confusing. Now each one has its
own header and its own source file.

No new tests needed, refactoring only.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
* platform/graphics/texmap/TextureMapperBackingStore.cpp:
* platform/graphics/texmap/TextureMapperBackingStore.h:
* platform/graphics/texmap/TextureMapperSurfaceBackingStore.cpp: Added.
(WebCore):
(WebCore::TextureMapperSurfaceBackingStore::setGraphicsSurface):
(WebCore::TextureMapperSurfaceBackingStore::swapBuffersIfNeeded):
(WebCore::TextureMapperSurfaceBackingStore::texture):
(WebCore::TextureMapperSurfaceBackingStore::paintToTextureMapper):
* platform/graphics/texmap/TextureMapperSurfaceBackingStore.h: Added.
(WebCore):
(TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::create):
(WebCore::TextureMapperSurfaceBackingStore::~TextureMapperSurfaceBackingStore):
(WebCore::TextureMapperSurfaceBackingStore::TextureMapperSurfaceBackingStore):
* platform/graphics/texmap/TextureMapperTile.cpp: Added.
(WebCore):
(WebCore::TextureMapperTile::updateContents):
(WebCore::TextureMapperTile::paint):
* platform/graphics/texmap/TextureMapperTile.h: Added.
(WebCore):
(TextureMapperTile):
(WebCore::TextureMapperTile::texture):
(WebCore::TextureMapperTile::rect):
(WebCore::TextureMapperTile::setTexture):
(WebCore::TextureMapperTile::setRect):
(WebCore::TextureMapperTile::~TextureMapperTile):
(WebCore::TextureMapperTile::TextureMapperTile):
* platform/graphics/texmap/TextureMapperTiledBackingStore.cpp: Copied from Source/WebCore/platform/graphics/texmap/TextureMapperBackingStore.cpp.
(WebCore):
(WebCore::TextureMapperTiledBackingStore::TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::updateContentsFromImageIfNeeded):
(WebCore::TextureMapperTiledBackingStore::adjustedTransformForRect):
(WebCore::TextureMapperTiledBackingStore::paintToTextureMapper):
(WebCore::TextureMapperTiledBackingStore::drawBorder):
(WebCore::TextureMapperTiledBackingStore::drawRepaintCounter):
(WebCore::TextureMapperTiledBackingStore::createOrDestroyTilesIfNeeded):
(WebCore::TextureMapperTiledBackingStore::updateContents):
(WebCore::TextureMapperTiledBackingStore::texture):
* platform/graphics/texmap/TextureMapperTiledBackingStore.h: Added.
(WebCore):
(TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::create):
(WebCore::TextureMapperTiledBackingStore::~TextureMapperTiledBackingStore):
(WebCore::TextureMapperTiledBackingStore::setContentsToImage):
(WebCore::TextureMapperTiledBackingStore::rect):
* platform/graphics/texmap/coordinated/CoordinatedBackingStore.h:
* platform/graphics/texmap/coordinated/CoordinatedGraphicsScene.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSanitize m_keyTimes for paced value animations
pdr@google.com [Sat, 9 Feb 2013 18:02:37 +0000 (18:02 +0000)]
Sanitize m_keyTimes for paced value animations
https://bugs.webkit.org/show_bug.cgi?id=108828

Reviewed by Dirk Schulze.

Source/WebCore:

SVG animations with calcMode=paced calculate new m_keyTimes in
SVGAnimationElement::calculateKeyTimesForCalcModePaced() because paced animations do not
specify keyTimes. If an error occurs while calculating m_keyTimes, and there exists
user-specified values, a crash could occur because the user-specified values were not
sanitized.

This change clears user-specified keyTimes before calculating new ones.

Test: svg/animations/animate-keytimes-crash.html

* svg/SVGAnimationElement.cpp:
(WebCore::SVGAnimationElement::calculateKeyTimesForCalcModePaced):

LayoutTests:

* svg/animations/animate-keytimes-crash-expected.html: Added.
* svg/animations/animate-keytimes-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] Set mouse document position for mouse event in updateCursor.
commit-queue@webkit.org [Sat, 9 Feb 2013 17:54:42 +0000 (17:54 +0000)]
[BlackBerry] Set mouse document position for mouse event in updateCursor.
https://bugs.webkit.org/show_bug.cgi?id=109094.

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-02-09
Reviewed by Rob Buis.

RIM PR 246976
Internally Reviewed by Genevieve Mak.

BlackBerry::Platform::MouseEvent have document viewport and document
content position as members. When we create the event, we should initial
them as well.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix TextDocumentParser to play nice with threading
eric@webkit.org [Sat, 9 Feb 2013 17:52:19 +0000 (17:52 +0000)]
Fix TextDocumentParser to play nice with threading
https://bugs.webkit.org/show_bug.cgi?id=109240

Reviewed by Adam Barth.

Before the HTML5 parser re-write the text document parser
was completely custom.  With the HTML5 parser, we just made
the TextDocumentParser use the HTMLDocumentParser with an
artificial script tag.

However, our solution was slightly over-engineered to avoid
lying about the column numbers of the first line of the text document
during parsing. :)

This change makes us use a simpler (and threading-compatible)
solution by just inserting a real "<pre>" tag into the
input stream instead of hacking one together with the treebuilder
and manually setting the Tokenizer state.

fast/parser/empty-text-resource.html covers this case.

* html/parser/TextDocumentParser.cpp:
(WebCore::TextDocumentParser::TextDocumentParser):
(WebCore::TextDocumentParser::insertFakePreElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to last-known good revision. Really this time.
schenney@chromium.org [Sat, 9 Feb 2013 17:28:41 +0000 (17:28 +0000)]
Unreviewed.  Rolled Chromium DEPS to last-known good revision. Really this time.

* DEPS: 181594

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. Rolled Chromium DEPS to last-known good revision.
schenney@chromium.org [Sat, 9 Feb 2013 17:21:00 +0000 (17:21 +0000)]
Unreviewed.  Rolled Chromium DEPS to last-known good revision.
Requested by "Stephen Chenney" <schenney@chromium.org> via
sheriffbot.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-09

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Trying to turn the build.webkit.org builders greener
schenney@chromium.org [Sat, 9 Feb 2013 17:05:40 +0000 (17:05 +0000)]
[Chromium] Trying to turn the build.webkit.org builders greener

Unreviewed expectations.

We seem to have an issue with build.webkit.org test bots and
Chromium.WebKit test bots doing different things. This is temporary
until we figure out what went wrong.

* platform/chromium/TestExpectations: Re-adding all the changes due to Skia flags.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd missing copyright header
tkent@chromium.org [Sat, 9 Feb 2013 15:37:27 +0000 (15:37 +0000)]
Add missing copyright header
https://bugs.webkit.org/show_bug.cgi?id=107507

* Resources/pagepopups/chromium/calendarPickerChromium.css:
* Resources/pagepopups/chromium/pickerCommonChromium.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix crash by img[ismap] with content property
tkent@chromium.org [Sat, 9 Feb 2013 15:25:19 +0000 (15:25 +0000)]
Fix crash by img[ismap] with content property
https://bugs.webkit.org/show_bug.cgi?id=108702

Reviewed by Adam Barth.

Source/WebCore:

Test: fast/dom/HTMLAnchorElement/anchor-ismap-crash.html

* html/HTMLAnchorElement.cpp:
(WebCore::appendServerMapMousePosition):
Check if the renderer of an img element is RenderImage.

LayoutTests:

* fast/dom/HTMLAnchorElement/anchor-ismap-crash-expected.txt: Added.
* fast/dom/HTMLAnchorElement/anchor-ismap-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Test expectation update.
tkent@chromium.org [Sat, 9 Feb 2013 15:16:54 +0000 (15:16 +0000)]
[Chromium] Test expectation update.

* platform/chromium/TestExpectations:
Correct encrypted-media-v2-*.html expectation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDrop ExceptionCode from IDB's directionToString and modeToString.
mkwst@chromium.org [Sat, 9 Feb 2013 15:14:20 +0000 (15:14 +0000)]
Drop ExceptionCode from IDB's directionToString and modeToString.
https://bugs.webkit.org/show_bug.cgi?id=109143

Reviewed by Jochen Eisinger.

No caller of either IDBCursor::directionToString or
IDBTransaction::modeToString makes use of the ExceptionCode these
methods require. This patch removes the 'ExceptionCode&' parameter from
both methods and their callsites.

* Modules/indexeddb/IDBCursor.cpp:
(WebCore::IDBCursor::direction):
(WebCore::IDBCursor::directionToString):
    Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
    exception previously generated with ASSERT_NOT_REACHED.
* Modules/indexeddb/IDBCursor.h:
* Modules/indexeddb/IDBTransaction.cpp:
(WebCore::IDBTransaction::mode):
(WebCore::IDBTransaction::modeToString):
    Drop the 'ExceptionCode&' parameter, and replace the 'TypeError'
    exception previously generated with ASSERT_NOT_REACHED.
* Modules/indexeddb/IDBTransaction.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][Qt][WebGL] Share the common code between GraphicsSurfaceGLX and X11WindowResources.
commit-queue@webkit.org [Sat, 9 Feb 2013 15:10:08 +0000 (15:10 +0000)]
[EFL][Qt][WebGL] Share the common code between GraphicsSurfaceGLX and X11WindowResources.
https://bugs.webkit.org/show_bug.cgi?id=106666

Patch by Kondapally Kalyan <kalyan.kondapally@intel.com> on 2013-02-09
Reviewed by Kenneth Rohde Christiansen.

Covered by existing WebGL tests.

This patch removes any duplicate code in X11WindowResources and
GraphicsSurfaceGLX. No new functionality is added.

* PlatformEfl.cmake:
* Target.pri:
* platform/graphics/surfaces/egl/EGLConfigSelector.cpp:
(WebCore::EGLConfigSelector::pixmapContextConfig):
* platform/graphics/surfaces/egl/EGLConfigSelector.h:
(EGLConfigSelector):
* platform/graphics/surfaces/egl/EGLSurface.cpp:
(WebCore::EGLWindowTransportSurface::EGLWindowTransportSurface):
(WebCore::EGLWindowTransportSurface::destroy):
(WebCore::EGLWindowTransportSurface::setGeometry):
* platform/graphics/surfaces/egl/EGLSurface.h:
(WebCore):
(EGLWindowTransportSurface):
* platform/graphics/surfaces/glx/GLXConfigSelector.h:
(WebCore::GLXConfigSelector::GLXConfigSelector):
(WebCore::GLXConfigSelector::visualInfo):
(WebCore::GLXConfigSelector::pBufferContextConfig):
(WebCore::GLXConfigSelector::createSurfaceConfig):
(GLXConfigSelector):
* platform/graphics/surfaces/glx/GLXContext.cpp:
(WebCore::initializeARBExtensions):
(WebCore::GLXOffScreenContext::GLXOffScreenContext):
(WebCore::GLXOffScreenContext::initialize):
(WebCore::GLXOffScreenContext::platformReleaseCurrent):
(WebCore::GLXOffScreenContext::freeResources):
* platform/graphics/surfaces/glx/GLXContext.h:
(GLXOffScreenContext):
* platform/graphics/surfaces/glx/GLXSurface.cpp:
(WebCore::GLXTransportSurface::GLXTransportSurface):
(WebCore::GLXTransportSurface::setGeometry):
(WebCore::GLXTransportSurface::destroy):
(WebCore::GLXPBuffer::initialize):
* platform/graphics/surfaces/glx/GLXSurface.h:
(GLXTransportSurface):
(GLXPBuffer):
* platform/graphics/surfaces/glx/GraphicsSurfaceGLX.cpp:
(WebCore):
(WebCore::GraphicsSurfacePrivate::GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::initialize):
(GraphicsSurfacePrivate):
(WebCore::GraphicsSurfacePrivate::createSurface):
(WebCore::GraphicsSurfacePrivate::createPixmap):
(WebCore::GraphicsSurfacePrivate::display):
(WebCore::GraphicsSurfacePrivate::flags):
(WebCore::GraphicsSurfacePrivate::clear):
(WebCore::GraphicsSurface::platformPaintToTextureMapper):
No new functionality added. Made changes to take the common code into use.

* platform/graphics/surfaces/glx/X11WindowResources.h: Removed.
* platform/graphics/surfaces/glx/X11Helper.cpp: Renamed from Source/WebCore/platform/graphics/surfaces/glx/X11WindowResources.cpp.
(WebCore):
(WebCore::DisplayConnection::DisplayConnection):
(DisplayConnection):
(WebCore::DisplayConnection::~DisplayConnection):
(WebCore::DisplayConnection::display):
(OffScreenRootWindow):
(WebCore::OffScreenRootWindow::OffScreenRootWindow):
(WebCore::OffScreenRootWindow::~OffScreenRootWindow):
(WebCore::OffScreenRootWindow::rootWindow):
(WebCore::X11Helper::resizeWindow):
(WebCore::X11Helper::createOffScreenWindow):
(WebCore::X11Helper::destroyWindow):
(WebCore::X11Helper::isXRenderExtensionSupported):
(WebCore::X11Helper::nativeDisplay):
(WebCore::X11Helper::offscreenRootWindow):
* platform/graphics/surfaces/glx/X11Helper.h: Added.
(WebCore):
(WebCore::handleXPixmapCreationError):
(X11Helper):
(ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::~ScopedXPixmapCreationErrorHandler):
(WebCore::ScopedXPixmapCreationErrorHandler::isValidOperation):
Moved common code from GraphicsSurfaceGLX to X11Helper.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Sat, 9 Feb 2013 14:58:14 +0000 (14:58 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding a failure expectation for the test introduced in r142335.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening.
ch.dumez@sisa.samsung.com [Sat, 9 Feb 2013 14:31:09 +0000 (14:31 +0000)]
Unreviewed EFL gardening.

Rebaseline fast/text/international/bidi-ignored-for-first-child-inline.html
after r142152.

* platform/efl/TestExpectations:
* platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.png:
* platform/efl/fast/text/international/bidi-ignored-for-first-child-inline-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, another GTK+ build fix after r142343.
philn@webkit.org [Sat, 9 Feb 2013 11:51:15 +0000 (11:51 +0000)]
Unreviewed, another GTK+ build fix after r142343.

* Source/autotools/symbols.filter: Expose the InlineBox delete operator.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: show whitespace characters in DTE
commit-queue@webkit.org [Sat, 9 Feb 2013 09:58:10 +0000 (09:58 +0000)]
Web Inspector: show whitespace characters in DTE
https://bugs.webkit.org/show_bug.cgi?id=108947

Patch by Andrey Lushnikov <lushnikov@chromium.org> on 2013-02-09
Reviewed by Pavel Feldman.

Source/WebCore:

New test: inspector/editor/text-editor-show-whitespaces.html

Split consecutive whitespace characters into groups of 16, 8, 4, 2 and 1 and
add ::before pseudoclass for this groups which contains necessary
amount of "dots" (u+00b7). Add a setting "Show whitespace" for this
option in "Sources" section of "General" tab.

* English.lproj/localizedStrings.js:
* inspector/front-end/DefaultTextEditor.js:
(WebInspector.TextEditorMainPanel.prototype.wasShown):
(WebInspector.TextEditorMainPanel.prototype.willHide):
(WebInspector.TextEditorMainPanel.prototype._renderRanges):
(WebInspector.TextEditorMainPanel.prototype._renderWhitespaceCharsWithFixedSizeSpans):
(WebInspector.TextEditorMainPanel.prototype._paintLine):
* inspector/front-end/Settings.js:
* inspector/front-end/SettingsScreen.js:
(WebInspector.GenericSettingsTab):
* inspector/front-end/inspectorSyntaxHighlight.css:
(.webkit-whitespace-1::before):
(.webkit-whitespace-2::before):
(.webkit-whitespace-4::before):
(.webkit-whitespace-8::before):
(.webkit-whitespace-16::before):
(.webkit-whitespace::before):

LayoutTests:

Add layout test to verify whitespace highlight functionality.

* inspector/editor/text-editor-show-whitespace-expected.txt: Added.
* inspector/editor/text-editor-show-whitespace.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix ASSERT when the Web Content Process crashes
weinig@apple.com [Sat, 9 Feb 2013 06:13:40 +0000 (06:13 +0000)]
Fix ASSERT when the Web Content Process crashes
https://bugs.webkit.org/show_bug.cgi?id=109346

Reviewed by Simon Fraser.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidCrash):
We need to remove ourselves as a message receiver before calling out to the client, as
the client might want to re-add us (as Safari does).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] respect in-band caption color
eric.carlson@apple.com [Sat, 9 Feb 2013 05:52:53 +0000 (05:52 +0000)]
[Mac] respect in-band caption color
https://bugs.webkit.org/show_bug.cgi?id=109203

Reviewed by Dean Jackson.

Source/WebCore:

Test: media/track/track-in-band-style.html

* WebCore.xcodeproj/project.pbxproj: Add HTMLDivElement.h to private headers because it is
    included by HTMLTextElement, which is included by HTMLMediaElement.h, which is included
    by files in WebKit/WebKit2.
* html/track/InbandTextTrack.cpp:
(WebCore::InbandTextTrack::addGenericCue): Set cue colors if necessary.

* html/track/TextTrackCue.h:
(WebCore::TextTrackCue::element): New, accessor for the cue element so it can be styled.

* html/track/TextTrackCueGeneric.cpp:
(WebCore::TextTrackCueGenericBoxElement::applyCSSProperties): Set container and cue background
    color if necessary.
(WebCore::TextTrackCueGeneric::operator==): Compare cue colors.
* html/track/TextTrackCueGeneric.h:
(WebCore::TextTrackCueGeneric::foregroundColor): Add color accessors.
(WebCore::TextTrackCueGeneric::setForegroundColor):
(WebCore::TextTrackCueGeneric::backgroundColor):
(WebCore::TextTrackCueGeneric::setBackgroundColor):

* page/CaptionUserPreferencesMac.mm:
(WebCore::CaptionUserPreferencesMac::registerForCaptionPreferencesChangedCallbacks): Always
    regenerate override CSS when an element registers for callbacks.
(WebCore::CaptionUserPreferencesMac::captionsWindowCSS): Drive by fix of "window color" padding.
(WebCore::CaptionUserPreferencesMac::captionsStyleSheetOverride): Log the stylesheet generated
    for easier debugging.

* platform/graphics/InbandTextTrackPrivateClient.h:
(WebCore::GenericCueData::foregroundColor): Add color getters/setters.
(WebCore::GenericCueData::setForegroundColor):
(WebCore::GenericCueData::backgroundColor):
(WebCore::GenericCueData::setBackgroundColor):

* platform/graphics/avfoundation/InbandTextTrackPrivateAVF.cpp:
(WebCore::makeRGBA32FromARGBCFArray): Initialize a RGBA32 from a CFArray of color values.
(WebCore::InbandTextTrackPrivateAVF::processCueAttributes): Process cue colors.

LayoutTests:

* media/track/track-in-band-style-expected.txt: Added.
* media/track/track-in-band-style.html: Added.

* platform/chromium/TestExpectations: Skip new test.
* platform/efl/TestExpectations: Ditto.
* platform/gtk/TestExpectations: Ditto.
* platform/mac/TestExpectations: Ditto.
* platform/qt/TestExpectations: Ditto.
* platform/win/TestExpectations: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove workerThreadCount from TestRunner to WebCore Internals
benjamin@webkit.org [Sat, 9 Feb 2013 05:17:53 +0000 (05:17 +0000)]
Move workerThreadCount from TestRunner to WebCore Internals
https://bugs.webkit.org/show_bug.cgi?id=109239

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-02-08
Reviewed by Darin Adler.

.:

* Source/autotools/symbols.filter:

Source/WebCore:

Add the new read-only property workerThreadCount.

* testing/Internals.cpp:
(WebCore::Internals::workerThreadCount):
(WebCore):
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

Source/WebKit:

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/efl:

* WebCoreSupport/DumpRenderTreeSupportEfl.cpp:
* WebCoreSupport/DumpRenderTreeSupportEfl.h:

Source/WebKit/gtk:

* WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
* WebCoreSupport/DumpRenderTreeSupportGtk.h:
(DumpRenderTreeSupportGtk):

Source/WebKit/mac:

Get rid of WebWorkersPrivate, which was only needed for DRT.

* WebKit.exp:
* Workers/WebWorkersPrivate.h: Removed.
* Workers/WebWorkersPrivate.mm: Removed.

Source/WebKit/qt:

* WebCoreSupport/DumpRenderTreeSupportQt.cpp:
* WebCoreSupport/DumpRenderTreeSupportQt.h:

Source/WebKit/win:

* WebKit.vcproj/WebKitExports.def.in:

Source/WebKit2:

* WebProcess/InjectedBundle/API/c/WKBundle.cpp:
* WebProcess/InjectedBundle/API/c/WKBundlePrivate.h:
* WebProcess/InjectedBundle/InjectedBundle.cpp:
* WebProcess/InjectedBundle/InjectedBundle.h:
(InjectedBundle):
* WebProcess/WebPage/WebFrame.cpp: Remove a useless #include.

Tools:

* DumpRenderTree/TestRunner.cpp:
(TestRunner::staticValues):
* DumpRenderTree/TestRunner.h:
(TestRunner):
* DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:
* DumpRenderTree/chromium/TestRunner/src/TestRunner.cpp:
(WebTestRunner::TestRunner::TestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/efl/TestRunnerEfl.cpp:
* DumpRenderTree/gtk/TestRunnerGtk.cpp:
* DumpRenderTree/mac/TestRunnerMac.mm:
(TestRunner::webHistoryItemCount):
* DumpRenderTree/qt/TestRunnerQt.cpp:
* DumpRenderTree/qt/TestRunnerQt.h:
(TestRunner):
* DumpRenderTree/win/TestRunnerWin.cpp:
* DumpRenderTree/wx/TestRunnerWx.cpp:
* WebKitTestRunner/InjectedBundle/Bindings/TestRunner.idl:
* WebKitTestRunner/InjectedBundle/TestRunner.cpp:
* WebKitTestRunner/InjectedBundle/TestRunner.h:

LayoutTests:

Update the tests testRunner->internals.

* fast/workers/resources/dedicated-worker-lifecycle.js:
(runTests.worker.onmessage):
(runTests):
(orphanedWorkerExited.worker.onmessage):
(orphanedWorkerExited):
* fast/workers/resources/worker-lifecycle.js:
(runTests.worker.onmessage):
(runTests):
* fast/workers/resources/worker-util.js:
(.return):
(waitUntilThreadCountMatches):
* fast/workers/worker-close-more.html:
* http/tests/workers/resources/worker-util.js:
(.return):
(waitUntilThreadCountMatches):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove use of plugInStartLabelImage
dino@apple.com [Sat, 9 Feb 2013 04:21:56 +0000 (04:21 +0000)]
Remove use of plugInStartLabelImage
https://bugs.webkit.org/show_bug.cgi?id=108273

Reviewed by Simon Fraser.

Source/WebKit2:

Remove any use of plugInStartLabelImage. While there, implement plugInStartLabelTitle
and plugInStartLabelSubtitle to return the values from the client.
implement them.

* WebProcess/InjectedBundle/API/c/WKBundlePage.h: Remove callback and entry from client structure.
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
(WebKit::InjectedBundlePageUIClient::plugInStartLabelTitle): Ask the client bundle for value.
(WebKit::InjectedBundlePageUIClient::plugInStartLabelSubtitle): Ditto.

Tools:

Removed plugInStartLabelImage entry from client structure.

* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoOnly a fool would cut and paste from a terminal showing truncated git logs.
dino@apple.com [Sat, 9 Feb 2013 04:04:21 +0000 (04:04 +0000)]
Only a fool would cut and paste from a terminal showing truncated git logs.
I am that fool.

Export the full symbol for InlineBox::nodeAtPoint.

* Source/autotools/symbols.filter:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSnapshotted plug-in should use shadow root
dino@apple.com [Sat, 9 Feb 2013 03:58:00 +0000 (03:58 +0000)]
Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Unreviewed GTK+ build fix.

* Source/autotools/symbols.filter: Export InlineBox symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the WebInspectorAPI watch list.
timothy@apple.com [Sat, 9 Feb 2013 03:42:48 +0000 (03:42 +0000)]
Fix the WebInspectorAPI watch list.

Reviewed by Joseph Pecoraro.

* Scripts/webkitpy/common/config/watchlist: Fix the regrexs.
Added InjectedScriptSource.js and Console.idl.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Snapshotted plug-in should use shadow root
dino@apple.com [Sat, 9 Feb 2013 03:29:20 +0000 (03:29 +0000)]
Source/WebCore: Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Reviewed by Simon Fraser.

Take two! This time with updated exports file.

A snapshotted plugin needs to indicate to the user that it can be clicked
to be restarted. Previously this was done with an image that had embedded
text. Instead, we now use an internal shadow root to embed some markup that
will display instructions that can be localised.

The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.

In the process, RenderSnapshottedPlugIn no longer inherits from RenderEmbeddedObject,
since it is only responsible for drawing a paused plug-in. The snapshot creation
can work with the default renderer, but a shadow root requires something like
RenderBlock in order to draw its children. We swap from one renderer to another when
necessary either by creating the shadow root or by explicitly detaching and attaching
the plugin element.

Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.

* WebCore.exp.in: Export the InlineBox interface.

* css/plugIns.css:
(object::-webkit-snapshotted-plugin-content): New rules for a default label style.

* platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
* platform/LocalizedStrings.h:
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
* platform/chromium/LocalizedStringsChromium.cpp:
* platform/efl/LocalizedStringsEfl.cpp:
* platform/gtk/LocalizedStringsGtk.cpp:
* platform/qt/LocalizedStringsQt.cpp:

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New default values in constructor.
(WebCore::HTMLPlugInElement::defaultEventHandler): Make sure to call base class.
(WebCore::HTMLPlugInElement::willRecalcStyle): No need to reattach if we're a snapshot.
(WebCore::HTMLPlugInImageElement::createRenderer): If we're showing a snapshot, create such
    a renderer, otherwise use the typical plug-in path.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll
    need to give it to the renderer.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.
* html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label
    should show immediately.
(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need
    to swap to the Shadow Root.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin
    in being recreated. Make sure we reattach so that a plugin renderer will be created.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right
    displayState for snapshots.
* html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not
    a snapshot should be immediately labeled.

* page/ChromeClient.h: No need for plugInStartLabelImage any more.

* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New inheritance.
(WebCore::RenderSnapshottedPlugIn::paint): If we're in the background paint phase, render the snapshot image.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotImage): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotWithLabel): Rename. No need for label sizes.
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): The renderer doesn't restart the plug-in any more. Tell the element and it will do it.
* rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn): New inheritance. Some method renaming.

Source/WebKit2:

* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp:
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h:
(InjectedBundlePageUIClient):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
(WebChromeClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDisable All WebGL Tests on WebKit for Windows
gman@chromium.org [Sat, 9 Feb 2013 03:08:36 +0000 (03:08 +0000)]
Disable All WebGL Tests on WebKit for Windows
https://bugs.webkit.org/show_bug.cgi?id=109207

Unreviewed expectations update.

* platform/win/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRolling out r142333 and r142337 which broke Mac Release builds.
dino@apple.com [Sat, 9 Feb 2013 02:42:51 +0000 (02:42 +0000)]
Rolling out r142333 and r142337 which broke Mac Release builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r142337.
commit-queue@webkit.org [Sat, 9 Feb 2013 02:40:09 +0000 (02:40 +0000)]
Unreviewed, rolling out r142337.
http://trac.webkit.org/changeset/142337
https://bugs.webkit.org/show_bug.cgi?id=109339

Breaking Mac release builds (Requested by dino_ on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-08

* rendering/RenderSnapshottedPlugIn.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove plug-in enumeration back to the main thread
andersca@apple.com [Sat, 9 Feb 2013 02:34:13 +0000 (02:34 +0000)]
Move plug-in enumeration back to the main thread
https://bugs.webkit.org/show_bug.cgi?id=109337
<rdar://problem/12015046>

Reviewed by Andreas Kling.

Plug-in enumeration was moved to a separate work queue to improve responsiveness, but
doing so lead to crashes when WebKit1 would enumerate plug-ins on the main thread at the same time.
Bug <rdar://problem/13185819> tracks fixing the responsiveness issue by spawning a plug-in process
and have it do the enumeration.

* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::getPluginInfoFromCarbonResources):
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::connectionWillOpen):
(WebKit::WebProcessProxy::connectionWillClose):
(WebKit::WebProcessProxy::getPlugins):
* UIProcess/WebProcessProxy.h:
(WebCore):
(WebProcessProxy):
* UIProcess/WebProcessProxy.messages.in:
* WebProcess/WebCoreSupport/WebPlatformStrategies.cpp:
(WebKit):
(WebKit::WebPlatformStrategies::populatePluginCache):
* WebProcess/WebProcess.cpp:
* WebProcess/WebProcess.h:
(WebProcess):
* WebProcess/WebProcess.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSome tiled drawing tests use scalePageBy() incorrectly
timothy_horton@apple.com [Sat, 9 Feb 2013 02:20:48 +0000 (02:20 +0000)]
Some tiled drawing tests use scalePageBy() incorrectly
https://bugs.webkit.org/show_bug.cgi?id=109336

Rubber-stamped by Simon Fraser.

scalePageBy takes (scale, x, y). Some of the tiled drawing tests are incorrectly handing them (scale, scale).
Adjust the tests and the expected results.

* platform/mac-wk2/tiled-drawing/fixed-background/fixed-body-background-zoomed.html:
* platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed-expected.txt:
* platform/mac-wk2/tiled-drawing/fixed/four-bars-zoomed.html:
* platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-expected.txt:
* platform/mac-wk2/tiled-drawing/tiled-drawing-zoom-scrolled.html:
* platform/mac-wk2/tiled-drawing/tiled-drawing-zoom.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAttempted Mac and GTK build fix after r142333.
dino@apple.com [Sat, 9 Feb 2013 02:07:11 +0000 (02:07 +0000)]
Attempted Mac and GTK build fix after r142333.

* rendering/RenderSnapshottedPlugIn.h: Include InlineBox.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoARM_NEON Inline Assembly for copyLCharsFromUCharSource() inefficient for aligned...
msaboff@apple.com [Sat, 9 Feb 2013 01:58:29 +0000 (01:58 +0000)]
ARM_NEON Inline Assembly for copyLCharsFromUCharSource() inefficient for aligned destinations
https://bugs.webkit.org/show_bug.cgi?id=109335

Reviewed by Filip Pizlo.

Change a "do while" to a "while" so that we don't copy single characters to align the
destination when it is already aligned.

* wtf/text/ASCIIFastPath.h:
(WTF::copyLCharsFromUCharSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRestore pre-r118852 behavior for EllipsisBox::nodeAtPoint()
aestes@apple.com [Sat, 9 Feb 2013 01:48:09 +0000 (01:48 +0000)]
Restore pre-r118852 behavior for EllipsisBox::nodeAtPoint()
https://bugs.webkit.org/show_bug.cgi?id=109277

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/flexbox/line-clamp-link-after-ellipsis.html

Roll out r118852. Enough time has passed that this can't be done
mechanically, so transcribe the old method definition to current
WebCore interfaces.

* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::markupBox): EllipsisBox no longer has
m_markupBox, so break the logic for finding the markup box from
paintMarkupBox() into its own function.
(WebCore::EllipsisBox::paintMarkupBox): Call markupBox().
(WebCore::EllipsisBox::nodeAtPoint): Transcribe the pre-r118852 implementation.
* rendering/EllipsisBox.h:
(EllipsisBox): Declare markupBox().

LayoutTests:

Remove test added by r118852 and add a test that verifies the original
expected behavior.

* fast/css/text-overflow-ellipsis-hit-test-expected.txt: Removed.
* fast/css/text-overflow-ellipsis-hit-test.html: Removed.
* fast/flexbox/line-clamp-link-after-ellipsis-expected.txt: Added.
* fast/flexbox/line-clamp-link-after-ellipsis.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] In-band closed caption tracks are not always initialized correctly
eric.carlson@apple.com [Sat, 9 Feb 2013 01:32:16 +0000 (01:32 +0000)]
[Mac] In-band closed caption tracks are not always initialized correctly
https://bugs.webkit.org/show_bug.cgi?id=109323

Reviewed by Dean Jackson.

No new tests, makes existing tests less flakey.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::createAVPlayerItem): Create and configure legible output
    here instad of in tracksChanged.
(WebCore::MediaPlayerPrivateAVFoundationObjC::setClosedCaptionsVisible): Do nothing in a build with
    in-band track support.
(WebCore::MediaPlayerPrivateAVFoundationObjC::tracksChanged): Move legible output creation to
    createAVPlayerItem, don't set look at track media type to see if the movie has captions
    when we have support for in-band captions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSnapshotted plug-in should use shadow root
dino@apple.com [Sat, 9 Feb 2013 01:24:36 +0000 (01:24 +0000)]
Snapshotted plug-in should use shadow root
https://bugs.webkit.org/show_bug.cgi?id=108284

Reviewed by Simon Fraser.

Source/WebCore:

A snapshotted plugin needs to indicate to the user that it can be clicked
to be restarted. Previously this was done with an image that had embedded
text. Instead, we now use an internal shadow root to embed some markup that
will display instructions that can be localised.

The UA stylesheet for plug-ins provides a default styling for the label, which
can be overridden by ports.

In the process, RenderSnapshottedPlugIn no longer inherits from RenderEmbeddedObject,
since it is only responsible for drawing a paused plug-in. The snapshot creation
can work with the default renderer, but a shadow root requires something like
RenderBlock in order to draw its children. We swap from one renderer to another when
necessary either by creating the shadow root or by explicitly detaching and attaching
the plugin element.

Unfortunately this is difficult to test, because the snapshotting requires
time to execute, and also a PluginView to be instantiated.

* css/plugIns.css:
(object::-webkit-snapshotted-plugin-content): New rules for a default label style.

* platform/LocalizedStrings.cpp: Make sure all ports have plugin strings, now it is called.
* platform/LocalizedStrings.h:
* platform/blackberry/LocalizedStringsBlackBerry.cpp:
* platform/chromium/LocalizedStringsChromium.cpp:
* platform/efl/LocalizedStringsEfl.cpp:
* platform/gtk/LocalizedStringsGtk.cpp:
* platform/qt/LocalizedStringsQt.cpp:

* html/HTMLPlugInElement.cpp:
(WebCore::HTMLPlugInElement::defaultEventHandler): Take into account the fact
that RenderSnapshottedPlugIn no longer is an embedded object.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::HTMLPlugInImageElement): New default values in constructor.
(WebCore::HTMLPlugInElement::defaultEventHandler): Make sure to call base class.
(WebCore::HTMLPlugInElement::willRecalcStyle): No need to reattach if we're a snapshot.
(WebCore::HTMLPlugInImageElement::createRenderer): If we're showing a snapshot, create such
    a renderer, otherwise use the typical plug-in path.
(WebCore::HTMLPlugInImageElement::updateSnapshot): Keep a record of the snapshot, since we'll
    need to give it to the renderer.
(WebCore::HTMLPlugInImageElement::didAddUserAgentShadowRoot): Build a subtree that will display a label.
* html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): New member variable to record the snapshot image and whether the label
    should show immediately.
(WebCore::HTMLPlugInImageElement::swapRendererTimerFired): The callback function triggered when we need
    to swap to the Shadow Root.
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot): The user has tapped on the snapshot so the plugin
    in being recreated. Make sure we reattach so that a plugin renderer will be created.
(WebCore::HTMLPlugInImageElement::subframeLoaderWillCreatePlugIn): Make sure we set the right
    displayState for snapshots.
* html/HTMLPlugInImageElement.h:
(HTMLPlugInImageElement): The new methods listed above.
(WebCore::HTMLPlugInImageElement::setShouldShowSnapshotLabelAutomatically): Indicates whether or not
    a snapshot should be immediately labeled.

* page/ChromeClient.h: No need for plugInStartLabelImage any more.

* rendering/RenderSnapshottedPlugIn.cpp:
(WebCore::RenderSnapshottedPlugIn::RenderSnapshottedPlugIn): New inheritance.
(WebCore::RenderSnapshottedPlugIn::paint): If we're in the background paint phase, render the snapshot image.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotImage): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshot): Rename.
(WebCore::RenderSnapshottedPlugIn::paintSnapshotWithLabel): Rename. No need for label sizes.
(WebCore::RenderSnapshottedPlugIn::getCursor):
(WebCore::RenderSnapshottedPlugIn::handleEvent): The renderer doesn't restart the plug-in any more. Tell the element and it will do it.
* rendering/RenderSnapshottedPlugIn.h:
(RenderSnapshottedPlugIn): New inheritance. Some method renaming.

Source/WebKit2:

We no longer have any need for plugInStartLabelImage.

* WebProcess/InjectedBundle/InjectedBundlePageUIClient.cpp: Remove plugInStartLabelImage.
* WebProcess/InjectedBundle/InjectedBundlePageUIClient.h: Ditto.
* WebProcess/WebCoreSupport/WebChromeClient.cpp: Ditto.
* WebProcess/WebCoreSupport/WebChromeClient.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Expectation modification after r142327
schenney@chromium.org [Sat, 9 Feb 2013 00:45:08 +0000 (00:45 +0000)]
[Chromium] Expectation modification after r142327

Unreviewed expectations update.

The test from "Bring WebKit up to speed with latest Encrypted Media spec" is slow.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Expectations as a result of removing Skia code suppressions
schenney@chromium.org [Sat, 9 Feb 2013 00:41:43 +0000 (00:41 +0000)]
[Chromium] Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

A remaining textual fix.

* editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
* platform/chromium-mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
* platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Unreviewed rebaseline
jpfau@apple.com [Sat, 9 Feb 2013 00:28:26 +0000 (00:28 +0000)]
[Mac] Unreviewed rebaseline

* platform/mac-lion/compositing/visible-rect/iframe-no-layers-expected.txt: Removed.
* platform/mac/compositing/visible-rect/iframe-no-layers-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago{FocusIn,FocusOut,Focus,Blur}EventDispatchMediator should be in FocusEvent.cpp
haraken@chromium.org [Sat, 9 Feb 2013 00:20:17 +0000 (00:20 +0000)]
{FocusIn,FocusOut,Focus,Blur}EventDispatchMediator should be in FocusEvent.cpp
https://bugs.webkit.org/show_bug.cgi?id=109265

Reviewed by Dimitri Glazkov.

Conventionally we put XXXEventDispatchMediator to XXXEvent.cpp.
We should move {FocusIn,FocusOut,Focus,Blur}EventDispatchMediator to FocusEvent.cpp.

No tests. No change in behavior.

* dom/EventDispatchMediator.cpp:
* dom/EventDispatchMediator.h:
* dom/FocusEvent.cpp:
(WebCore::FocusEventDispatchMediator::create):
(WebCore):
(WebCore::FocusEventDispatchMediator::FocusEventDispatchMediator):
(WebCore::FocusEventDispatchMediator::dispatchEvent):
(WebCore::BlurEventDispatchMediator::create):
(WebCore::BlurEventDispatchMediator::BlurEventDispatchMediator):
(WebCore::BlurEventDispatchMediator::dispatchEvent):
(WebCore::FocusInEventDispatchMediator::create):
(WebCore::FocusInEventDispatchMediator::FocusInEventDispatchMediator):
(WebCore::FocusInEventDispatchMediator::dispatchEvent):
(WebCore::FocusOutEventDispatchMediator::create):
(WebCore::FocusOutEventDispatchMediator::FocusOutEventDispatchMediator):
(WebCore::FocusOutEventDispatchMediator::dispatchEvent):
* dom/FocusEvent.h:
(WebCore):
(FocusEventDispatchMediator):
(BlurEventDispatchMediator):
(FocusInEventDispatchMediator):
(FocusOutEventDispatchMediator):
* dom/UIEvent.cpp:
* dom/UIEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix. MSVC (and other compilers) need a default: case in switch state...
jer.noble@apple.com [Sat, 9 Feb 2013 00:13:47 +0000 (00:13 +0000)]
Unreviewed build fix. MSVC (and other compilers) need a default: case in switch statement.

* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::notificationName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBring WebKit up to speed with latest Encrypted Media spec.
jer.noble@apple.com [Fri, 8 Feb 2013 23:31:29 +0000 (23:31 +0000)]
Bring WebKit up to speed with latest Encrypted Media spec.
https://bugs.webkit.org/show_bug.cgi?id=97037

Reviewed by Eric Carlson.

Source/JavaScriptCore:

Define the ENABLE_ENCRYPTED_MEDIA_V2 setting.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

The most recent version of the Encrypted Media Extensions spec breaks functionality out of the
HTMLMediaElement and into new MediaKeys and MediaKeySession classes. Since the CDM functionality
has been pulled out of the media element, we create a proxy CDM class and factory system for
creating specific CDM key system implementations. The spec also breaks out MediaKeyEvent
into distinct event classes, MediaKeyNeededEvent and MediaKeyMessageEvent, for needkey and
keymessage events, respectively.

Tests: media/encrypted-media/encrypted-media-v2-events.html
       media/encrypted-media/encrypted-media-v2-syntax.html

CDM is a proxy class (a la MediaPlayer) for a specific CDMPrivateInterface implementation. A CDM
implementation is registered with the CDMFactory and will be created if that implementation supports
the key system passed into the MediaKeys constructor. CDMSession is a pure-virtual interface exposed
by concrete CDMPrivate subclasses.  Its lifetime is owned by MediaKeySession.
* Modules/encryptedmedia/CDM.cpp: Added.
(WebCore::installedCDMFactories): Initialize all the known CDM subtypes. Ports will add CDM implementations here.
(WebCore::CDM::registerCDMFactory): Registers a new CDMFactory using the passed in function pointers.
(WebCore::CDMFactoryForKeySystem): Return the first CDM factory which supports the requested key system.
(WebCore::CDM::supportsKeySystem): Walk the installed CDMs and ask if the given key system is supported.
(WebCore::CDM::supportsKeySystemMIMETypeAndCodec): Ditto, with an additional MIME type and codec string.
(WebCore::CDM::create): Simple constructor wrapper.
(WebCore::CDM::CDM): Simple constructor; calls bestCDMForKeySystem() to create it's private implementation.
(WebCore::CDM::~CDM): Simple destructor.
(WebCore::CDM::createSession): Creates a new CDMSession.
* Modules/encryptedmedia/CDM.h: Added.
(WebCore::CDM::keySystem): Simple accessor for m_keySystem.
(WebCore::CDMSession::CDMSession): Simple constructor.
(WebCore::CDMSession::~CDMSession): Simple destructor.
* Modules/encryptedmedia/CDMPrivate.h: Added.
(WebCore::CDMPrivateInterface::CDMPrivateInterface): Simple constructor.
(WebCore::CDMPrivateInterface::~CDMPrivateInterface): Simple destructor.

The new classes, MediaKeyMessageEvent and MediaKeyNeededEvent, take distinct subsets of the initializers of
the original MediaKeyMessageEvent.
* Modules/encryptedmedia/MediaKeyMessageEvent.cpp: Copied from Source/WebCore/html/MediaKeyEvent.cpp.
(WebCore::MediaKeyMessageEventInit::MediaKeyMessageEventInit): Initializer now only takes message and destinationURL
    parameters.
(WebCore::MediaKeyMessageEvent::MediaKeyMessageEvent): Simple constructor.
(WebCore::MediaKeyMessageEvent::~MediaKeyMessageEvent): Simple destructor.
(WebCore::MediaKeyMessageEvent::interfaceName): Standard interfaceName.
* Modules/encryptedmedia/MediaKeyMessageEvent.h: Copied from Source/WebCore/html/MediaKeyEvent.h.
(WebCore::MediaKeyMessageEvent::create): Simple construction wrapper.
(WebCore::MediaKeyMessageEvent::message): Simple accessor for m_message.
(WebCore::MediaKeyMessageEvent::destinationURL): Simple accessor for m_destinationURL.
* Modules/encryptedmedia/MediaKeyMessageEvent.idl: Copied from Source/WebCore/html/MediaKeyEvent.idl.
* Modules/encryptedmedia/MediaKeyNeededEvent.cpp: Copied from Source/WebCore/html/MediaKeyEvent.h.
(WebCore::MediaKeyNeededEventInit::MediaKeyNeededEventInit): Initializer now only takes initData parameter.
(WebCore::MediaKeyNeededEvent::MediaKeyNeededEvent): Simple constructor.
(WebCore::MediaKeyNeededEvent::~MediaKeyNeededEvent): Simple destructor.
(WebCore::MediaKeyNeededEvent::interfaceName): Standard interfaceName.
* Modules/encryptedmedia/MediaKeyNeededEvent.h: Copied from Source/WebCore/html/MediaKeyEvent.h.
(WebCore::MediaKeyNeededEvent::create): Simple construction wrapper.
(WebCore::MediaKeyNeededEvent::initData): Simple accessor for m_initData.
* Modules/encryptedmedia/MediaKeyNeededEvent.idl: Copied from Source/WebCore/html/MediaKeyEvent.idl.

MediaKeySession is a new class that maps keys and key requests to a given session ID:
* Modules/encryptedmedia/MediaKeySession.cpp: Added.
(WebCore::MediaKeySession::create): Simple construction wrapper.
(WebCore::MediaKeySession::MediaKeySession): Simple constructor.
(WebCore::MediaKeySession::~MediaKeySession): Simple destructor; calls close().
(WebCore::MediaKeySession::setError): Simple setter for m_error;
(WebCore::MediaKeySession::close): Tell the CDM to clear any saved session keys.
(WebCore::MediaKeySession::generateKeyRequest): Start a one-shot timer, handled in keyRequestTimerFired.
(WebCore::MediaKeySession::keyRequestTimerFired): Follow the steps in the spec; ask the CDM to generate a key request.
(WebCore::MediaKeySession::addKey): Start a one-shot timer, handled in addKeyTimerFired.
(WebCore::MediaKeySession::addKeyTimerFired): Follow the steps in the spec; provide the key data to the CDM.
* Modules/encryptedmedia/MediaKeySession.h: Added.
(WebCore::MediaKeySession::keySystem): Simple accessor for m_keySystem.
(WebCore::MediaKeySession::sessionId): Simple accessor for m_sessionId.
(WebCore::MediaKeySession::error): Simple accessor for m_error;
* Modules/encryptedmedia/MediaKeySession.idl:

MediaKeySession inherits from EventTarget, and must override the pure virtual functions in that class:
* Modules/encryptedmedia/MediaKeySession.cpp: Added.
(WebCore::MediaKeySession::interfaceName):
* Modules/encryptedmedia/MediaKeySession.h: Added.
(WebCore::MediaKeySession::refEventTarget):
(WebCore::MediaKeySession::derefEventTarget):
(WebCore::MediaKeySession::eventTargetData):
(WebCore::MediaKeySession::ensureEventTargetData):
(WebCore::MediaKeySession::scriptExecutionContext):

MediaKeys is a new class that encapsulates a CDM and a number of key sessions:
* Modules/encryptedmedia/MediaKeys.cpp: Added.
(WebCore::MediaKeys::create): Throw an exception if the key system parameter is unsupported; create a CDM object
    and a new MediaKeys session.
(WebCore::MediaKeys::MediaKeys): Simple constructor.
(WebCore::MediaKeys::~MediaKeys): Simple destructor.
(WebCore::MediaKeys::createSession): Follow the spec and create a new key session.
* Modules/encryptedmedia/MediaKeys.h: Added.
* Modules/encryptedmedia/MediaKeys.idl: Copied from Source/WebCore/html/MediaError.idl.

Provide a new interface to HTMLMediaElement for MediaPlayer which does not require a sessionId or a key system:
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded):
* platform/graphics/MediaPlayer.cpp:
(WebCore::MediaPlayer::keyNeeded):

MediaKeyError now has a systemCode parameter and member variable.
* html/MediaKeyError.h:
(WebCore::MediaKeyError::create): Take a systemCode parameter with a default (0) value.
(WebCore::MediaKeyError::MediaKeyError): Ditto.
(WebCore::MediaKeyError::systemCode): Simple accessor for m_systemCode.
* html/MediaKeyError.idl:

Add new methods to HTMLMediaElement to support MediaKeys. Support different initializer
for the MediaKeyNeededEvent.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::setMediaKeys): Simple setter for m_mediaKeys.
(WebCore::HTMLMediaElement::mediaPlayerKeyNeeded): This version takes fewer parameters
    than the deprecated version.
* html/HTMLMediaElement.h:
(WebCore::HTMLMediaElement::mediaKeys): Simple accessor for m_mediaKeys.
* html/HTMLMediaElement.idl: Add the mediaKeys attribute.

Add an ENABLE(ENCRYPTED_MEDIA_V2) check to the existing ENABLE(ENCRYPTED_MEDIA) one:
* html/MediaError.h:
* html/MediaError.idl:
* platform/graphics/MediaPlayer.cpp:
(WebCore::bestMediaEngineForTypeAndCodecs):
(WebCore::MediaPlayer::supportsType):
* platform/graphics/MediaPlayer.h:
(WebCore::MediaPlayer::keyNeeded): This version takes fewer parameters than the
    deprecated version.

Support the new version of canPlayType which takes an extra parameter:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.h:
* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::registerMediaEngine):
(WebCore::MediaPlayerPrivateAVFoundationObjC::extendedSupportsType):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::registerMediaEngine):
(WebCore::MediaPlayerPrivateQTKit::extendedSupportsType):

Add a mock CDM for use within DRT and WKTR to test the MediaKeys and MediaKeySession
APIs and events:
* testing/Internals.cpp:
(WebCore::Internals::initializeMockCDM): Add the MockCDM class to the CDM factories.
* testing/Internals.h:
* testing/Internals.idl: Add the initializeMockCDM() method.
* testing/MockCDM.cpp: Added.
(WebCore::MockCDM::supportsKeySystem): Only supports the 'com.webcore.mock' key system.
(WebCore::MockCDM::supportsMIMEType): Only supports the 'video/mock' mime type.
(WebCore::initDataPrefix): Static method which returns a Uint8Array containing 'mock'.
(WebCore::keyPrefix): Static method which returns a Uint8Array containing 'key'.
(WebCore::keyRequest): Static method which returns a Uint8Array containing 'request'.
(WebCore::generateSessionId): Return a monotonically increasing number.
(WebCore::MockCDMSession::MockCDMSession): Simple constructor.
(WebCore::MockCDMSession::generateKeyRequest): Ignores the parameters and returns a keyRequest() array.
(WebCore::MockCDMSession::releaseKeys): No-op.
(WebCore::MockCDMSession::addKey): Checks that the key starts with the keyPrefix() array.
* testing/MockCDM.h: Added.
(WebCore::MockCDM::create):
(WebCore::MockCDM::~MockCDM): Simple destructor.
(WebCore::MockCDM::MockCDM): Simple constructor.

Add the new classes to the built system:
* Configurations/FeatureDefines.xcconfig:
* DerivedSources.make:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:

Miscelaneous changes:
* dom/EventNames.in: Add the two new event types, MediaKeyMessageEvent and MediaKeyNeededEvent.
* dom/EventTargetFactory.in: Add the new EventTarget, MediaKeySession.
* page/DOMWindow.idl: Add constructors for the new classes to the window object.

Source/WTF:

Define the ENABLE_ENCRYPTED_MEDIA_V2 setting.

* wtf/Platform.h:

LayoutTests:

Added new tests for the updated Encrypted Media Extensions spec.

* media/encrypted-media/encrypted-media-v2-events-expected.txt: Added.
* media/encrypted-media/encrypted-media-v2-events.html: Added.
* media/encrypted-media/encrypted-media-v2-syntax-expected.txt: Added.
* media/encrypted-media/encrypted-media-v2-syntax.html: Added.
* platform/Chromium/TestExpectations: Skip the new media/encrypted-media/ v2 tests.
* platform/mac/media/encrypted-media/encrypted-media-can-play-type-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] Fix the build on !Mac after r142314.
rakuco@webkit.org [Fri, 8 Feb 2013 23:04:15 +0000 (23:04 +0000)]
[WK2] Fix the build on !Mac after r142314.
https://bugs.webkit.org/show_bug.cgi?id=109327

Reviewed by Benjamin Poulain.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPreInitialize): Add a stub for
the newly-added function.

* WebProcess/Plugins/Netscape/x11/NetscapePluginX11.cpp:
(WebKit::NetscapePlugin::platformPreInitialize):
(WebKit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Expectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 23:02:06 +0000 (23:02 +0000)]
[Chromium] Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Why does this test always fail to be correctly rebaselined during mass updates?

* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIndexedDB: De-flake open-during-transaction layout test
jsbell@chromium.org [Fri, 8 Feb 2013 22:48:46 +0000 (22:48 +0000)]
IndexedDB: De-flake open-during-transaction layout test
https://bugs.webkit.org/show_bug.cgi?id=109072

Reviewed by Tony Chang.

This test was observed to be flaky in local runs; sometimes the transaction
would terminate after the third open() call rather than the second, resulting
in a TEXT difference. Added code to keep the transaction alive until all of
the open() calls are complete, and changed expectations to match.

* storage/indexeddb/open-during-transaction-expected.txt:
* storage/indexeddb/resources/open-during-transaction.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Expectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 22:35:28 +0000 (22:35 +0000)]
[Chromium] Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Cleaning up the remaining failures. With luck this is it, although probably not.

* platform/chromium-linux-x86/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
* platform/chromium-linux/fast/hidpi/video-controls-in-hidpi-expected.png:
* platform/chromium-linux/fast/writing-mode/Kusa-Makura-background-canvas-expected.png:
* platform/chromium-linux/fast/writing-mode/japanese-ruby-vertical-lr-expected.png:
* platform/chromium-linux/fast/writing-mode/japanese-ruby-vertical-rl-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/hidpi/gradient-with-scaled-ancestor-expected.png: Added.
* platform/chromium-mac-lion/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-lion/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-mac-snowleopard/fast/backgrounds/size/contain-and-cover-expected.png: Removed.
* platform/chromium-mac/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-win-xp/media/video-zoom-controls-expected.png: Removed.
* platform/chromium-win/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png:
* platform/chromium-win/fast/backgrounds/size/contain-and-cover-expected.png:
* platform/chromium-win/media/video-zoom-controls-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 22:18:23 +0000 (22:18 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 19. The last, except for cleanup. Too many to list.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 21:46:03 +0000 (21:46 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 18. SVG all but dynamic-updates and custom tests. List omitted
except for changes touching other ports.

* platform/chromium/TestExpectations:
* platform/efl-wk2/svg/css/circle-in-mask-with-shadow-expected.png: Added.
* platform/efl-wk2/svg/css/group-with-shadow-expected.png: Added.
* platform/efl-wk2/svg/css/text-gradient-shadow-expected.png: Added.
* platform/efl/svg/batik/text/textEffect-expected.png: Removed.
* platform/efl/svg/batik/text/textEffect2-expected.png: Removed.
* platform/efl/svg/batik/text/textProperties2-expected.png: Removed.
* platform/efl/svg/css/circle-in-mask-with-shadow-expected.png: Removed.
* platform/efl/svg/css/group-with-shadow-expected.png: Removed.
* platform/efl/svg/css/text-gradient-shadow-expected.png: Removed.
* platform/mac/svg/batik/text/textPosition2-expected.txt: Removed.
* platform/win-future/svg/batik/text/textPosition2-expected.txt: Added.
* svg/batik/text/textPosition2-expected.txt: Replaced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRefactor platform-specific code in SpeechSynthesis
cfleizach@apple.com [Fri, 8 Feb 2013 21:45:07 +0000 (21:45 +0000)]
Refactor platform-specific code in SpeechSynthesis
https://bugs.webkit.org/show_bug.cgi?id=107414

Reviewed by Sam Weinig.

Refactor WebSpeech code to use a platform mechanism to provide access to platform resources.

* Modules/speech/DOMWindowSpeechSynthesis.cpp:
(WebCore::DOMWindowSpeechSynthesis::from):
* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::SpeechSynthesis):
(WebCore):
(WebCore::SpeechSynthesis::voicesDidChange):
(WebCore::SpeechSynthesis::getVoices):
(WebCore::SpeechSynthesis::pending):
(WebCore::SpeechSynthesis::speaking):
(WebCore::SpeechSynthesis::paused):
(WebCore::SpeechSynthesis::speak):
(WebCore::SpeechSynthesis::cancel):
(WebCore::SpeechSynthesis::pause):
(WebCore::SpeechSynthesis::resume):
* Modules/speech/SpeechSynthesis.h:
(WebCore):
(SpeechSynthesis):
(WebCore::SpeechSynthesis::didStartSpeaking):
(WebCore::SpeechSynthesis::didFinishSpeaking):
(WebCore::SpeechSynthesis::speakingErrorOccurred):
* Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::SpeechSynthesisUtterance):
* Modules/speech/SpeechSynthesisUtterance.h:
(WebCore::SpeechSynthesisUtterance::text):
(WebCore::SpeechSynthesisUtterance::setText):
(WebCore::SpeechSynthesisUtterance::lang):
(WebCore::SpeechSynthesisUtterance::setLang):
(WebCore::SpeechSynthesisUtterance::voiceURI):
(WebCore::SpeechSynthesisUtterance::setVoiceURI):
(WebCore::SpeechSynthesisUtterance::volume):
(WebCore::SpeechSynthesisUtterance::setVolume):
(WebCore::SpeechSynthesisUtterance::rate):
(WebCore::SpeechSynthesisUtterance::setRate):
(WebCore::SpeechSynthesisUtterance::pitch):
(WebCore::SpeechSynthesisUtterance::setPitch):
(SpeechSynthesisUtterance):
(WebCore::SpeechSynthesisUtterance::platformUtterance):
* Modules/speech/SpeechSynthesisVoice.cpp:
(WebCore::SpeechSynthesisVoice::create):
(WebCore::SpeechSynthesisVoice::SpeechSynthesisVoice):
* Modules/speech/SpeechSynthesisVoice.h:
(SpeechSynthesisVoice):
(WebCore::SpeechSynthesisVoice::voiceURI):
(WebCore::SpeechSynthesisVoice::name):
(WebCore::SpeechSynthesisVoice::lang):
(WebCore::SpeechSynthesisVoice::localService):
(WebCore::SpeechSynthesisVoice::isDefault):
* Modules/speech/mac/SpeechSynthesisMac.mm:
* WebCore.xcodeproj/project.pbxproj:
* platform/PlatformSpeechSynthesis.h: Added.
(WebCore):
(PlatformSpeechSynthesis):
* platform/PlatformSpeechSynthesisUtterance.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesisUtterance::PlatformSpeechSynthesisUtterance):
* platform/PlatformSpeechSynthesisUtterance.h: Added.
(WebCore):
(PlatformSpeechSynthesisUtteranceClient):
(WebCore::PlatformSpeechSynthesisUtteranceClient::~PlatformSpeechSynthesisUtteranceClient):
(PlatformSpeechSynthesisUtterance):
(WebCore::PlatformSpeechSynthesisUtterance::text):
(WebCore::PlatformSpeechSynthesisUtterance::setText):
(WebCore::PlatformSpeechSynthesisUtterance::lang):
(WebCore::PlatformSpeechSynthesisUtterance::setLang):
(WebCore::PlatformSpeechSynthesisUtterance::voiceURI):
(WebCore::PlatformSpeechSynthesisUtterance::setVoiceURI):
(WebCore::PlatformSpeechSynthesisUtterance::volume):
(WebCore::PlatformSpeechSynthesisUtterance::setVolume):
(WebCore::PlatformSpeechSynthesisUtterance::rate):
(WebCore::PlatformSpeechSynthesisUtterance::setRate):
(WebCore::PlatformSpeechSynthesisUtterance::pitch):
(WebCore::PlatformSpeechSynthesisUtterance::setPitch):
* platform/PlatformSpeechSynthesisVoice.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesisVoice::create):
(WebCore::PlatformSpeechSynthesisVoice::PlatformSpeechSynthesisVoice):
* platform/PlatformSpeechSynthesisVoice.h: Added.
(WebCore):
(PlatformSpeechSynthesisVoice):
(WebCore::PlatformSpeechSynthesisVoice::voiceURI):
(WebCore::PlatformSpeechSynthesisVoice::name):
(WebCore::PlatformSpeechSynthesisVoice::lang):
(WebCore::PlatformSpeechSynthesisVoice::localService):
(WebCore::PlatformSpeechSynthesisVoice::isDefault):
* platform/PlatformSpeechSynthesizer.cpp: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::PlatformSpeechSynthesizer):
* platform/PlatformSpeechSynthesizer.h: Added.
(WebCore):
(PlatformSpeechSynthesizerClient):
(WebCore::PlatformSpeechSynthesizerClient::~PlatformSpeechSynthesizerClient):
(PlatformSpeechSynthesizer):
(WebCore::PlatformSpeechSynthesizer::voiceList):
* platform/mac/PlatformSpeechSynthesisMac.mm: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesis::create):
(WebCore::PlatformSpeechSynthesis::PlatformSpeechSynthesis):
(WebCore::PlatformSpeechSynthesis::platformSpeak):
* platform/mac/PlatformSpeechSynthesizerMac.mm: Added.
(WebCore):
(WebCore::PlatformSpeechSynthesizer::initializeVoiceList):
(WebCore::PlatformSpeechSynthesizer::speak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoObjective-C API for JavaScriptCore
barraclough@apple.com [Fri, 8 Feb 2013 21:41:25 +0000 (21:41 +0000)]
Objective-C API for JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=105889

Reviewed by Joseph Pecoraro

Following up on review comments, mostly typos.

* API/JSBlockAdaptor.h:
* API/JSBlockAdaptor.mm:
(-[JSBlockAdaptor blockFromValue:inContext:withException:]):
* API/JSContext.h:
* API/JSExport.h:
* API/JSValue.h:
* API/JSValue.mm:
* API/JSWrapperMap.mm:
(selectorToPropertyName):
(-[JSWrapperMap classInfoForClass:]):
(-[JSWrapperMap wrapperForObject:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 21:18:30 +0000 (21:18 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 17. SVG W3C tests. List omitted.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Mac] Unreviewed, fix test expectation for a test only crashing in debug mode
jpfau@apple.com [Fri, 8 Feb 2013 21:04:30 +0000 (21:04 +0000)]
[Mac] Unreviewed, fix test expectation for a test only crashing in debug mode

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 21:00:20 +0000 (21:00 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 16. Everything done but SVG, and cleanup.

* platform/chromium-linux-x86/tables/mozilla/bugs/bug138725-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug18359-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-2-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug2479-3-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug26178-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug28928-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug29326-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug33855-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug39209-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug4382-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug4429-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug44505-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug4527-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-1-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug46368-2-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug51037-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug51727-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug52505-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug52506-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug60749-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug68912-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug7342-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug92647-2-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/bugs/bug96334-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/collapsing_borders: Removed.
* platform/chromium-linux-x86/tables/mozilla/collapsing_borders/bug41262-4-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/core: Removed.
* platform/chromium-linux-x86/tables/mozilla/core/margins-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/dom: Removed.
* platform/chromium-linux-x86/tables/mozilla/dom/tableDom-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla/other: Removed.
* platform/chromium-linux-x86/tables/mozilla/other/move_row-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders: Removed.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/core: Removed.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions1-expected.png: Removed.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/core/captions2-expected.png: Removed.
* platform/chromium-linux-x86/transforms/2d/zoom-menulist-expected.png: Removed.
* platform/chromium-linux/tables/mozilla/bugs/bug138725-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug26178-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug29326-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug33855-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug39209-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4429-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug51727-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug52505-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug52506-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug60749-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug68912-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-4-expected.png:
* platform/chromium-linux/tables/mozilla/core/margins-expected.png:
* platform/chromium-linux/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-linux/tables/mozilla/other/move_row-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/bugs/bug58402-2-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/core/captions1-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/core/captions2-expected.png:
* platform/chromium-linux/transforms/2d/zoom-menulist-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 20:54:50 +0000 (20:54 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 15. platform/. Too many to list.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWork around a bug in Flash where NSException objects can be released too early
andersca@apple.com [Fri, 8 Feb 2013 20:46:26 +0000 (20:46 +0000)]
Work around a bug in Flash where NSException objects can be released too early
https://bugs.webkit.org/show_bug.cgi?id=109242
<rdar://problem/13003470>

Reviewed by Darin Adler.

* Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
(WebKit::NetscapePluginModule::determineQuirks):
Set the new plug-in quirk.

* Shared/Plugins/PluginQuirks.h:
Add a new plug-in quirk.

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::initialize):
Call platformPreInitialize.

* WebProcess/Plugins/Netscape/NetscapePlugin.h:
(NetscapePlugin):
Add platformPreInitialize.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NSException_release):
Add new empty function.

(WebKit::NetscapePlugin::platformPreInitialize):
Patch -[NSException release] to be a no-op.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 20:45:43 +0000 (20:45 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 14. Remaining tests up to platform in sorted order. Too many to list.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 20:35:17 +0000 (20:35 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 13. Last of the fast tests. Too many to list. Still listing efl changes.

* platform/chromium/TestExpectations:
* platform/chromium/fast/repaint/gradients-em-stops-repaint-expected.png: Removed.
* platform/efl-wk2/fast/repaint/shadow-multiple-horizontal-expected.png: Added.
* platform/efl-wk2/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
* platform/efl-wk2/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
* platform/efl-wk2/fast/repaint/shadow-multiple-vertical-expected.png: Added.
* platform/efl-wk2/fast/text: Added.
* platform/efl-wk2/fast/text/stroking-decorations-expected.png: Added.
* platform/efl-wk2/fast/text/stroking-expected.png: Added.
* platform/efl-wk2/fast/transforms: Added.
* platform/efl-wk2/fast/transforms/shadows-expected.png: Added.
* platform/efl-wk2/fast/transforms/transformed-focused-text-input-expected.png: Added.
* platform/efl/fast/repaint/shadow-multiple-horizontal-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-strict-vertical-expected.png: Removed.
* platform/efl/fast/repaint/shadow-multiple-vertical-expected.png: Removed.
* platform/efl/fast/text/stroking-decorations-expected.png: Removed.
* platform/efl/fast/text/stroking-expected.png: Removed.
* platform/efl/fast/transforms/shadows-expected.png: Removed.
* platform/efl/fast/transforms/transformed-focused-text-input-expected.png: Removed.
* platform/mac/fast/replaced/three-selects-break-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPut snapshotting label text into localizable strings
dino@apple.com [Fri, 8 Feb 2013 20:24:11 +0000 (20:24 +0000)]
Put snapshotting label text into localizable strings
https://bugs.webkit.org/show_bug.cgi?id=108268

Reviewed by Simon Fraser.

In preparation for a snapshotted plug-in using a ShadowRoot, allow
its label to be localized.

* English.lproj/Localizable.strings:
* platform/LocalizedStrings.cpp:
(WebCore::snapshottedPlugInLabelTitle): New method for returning title.
(WebCore::snapshottedPlugInLabelSubtitle): New method for returning subtitle.
* platform/LocalizedStrings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDo not register autostart for plugins from file:// (or nowhere)
dino@apple.com [Fri, 8 Feb 2013 20:23:50 +0000 (20:23 +0000)]
Do not register autostart for plugins from file:// (or nowhere)
https://bugs.webkit.org/show_bug.cgi?id=108271

Reviewed by Tim Horton.

Source/WebCore:

If the page url origin is treated as a local URL, don't attempt
to add it to the auto-start list.

* html/HTMLPlugInImageElement.cpp:
(WebCore::HTMLPlugInImageElement::userDidClickSnapshot):

Source/WebKit2:

If the pageOrigin is the empty string don't add
it to the auto-start origin list for snapshotting.

* WebProcess/WebProcess.cpp:
(WebKit::WebProcess::addPlugInAutoStartOrigin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate .gitignore for vim swap files.
commit-queue@webkit.org [Fri, 8 Feb 2013 20:18:32 +0000 (20:18 +0000)]
Update .gitignore for vim swap files.
https://bugs.webkit.org/show_bug.cgi?id=109252

Patch by Seulgi Kim <seulgikim@company100.net> on 2013-02-08
Reviewed by Dirk Pranke.

When opening the same files multiple with vim, vim creates a .*.sw[a-p]
file as the swap file.

* .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 19:48:57 +0000 (19:48 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 12. More fast tests. Too many to list.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. VS2010 WebKit Solution touchups.
roger_fong@apple.com [Fri, 8 Feb 2013 19:41:00 +0000 (19:41 +0000)]
Unreviewed. VS2010 WebKit Solution touchups.
Remove all .user files.
Add some build scripts to QTMovieWin that were forgotten about earlier.
Update the OpenSource WebKit solution to include DumpRenderTree and related projects.

* WebKit.vcxproj: Added properties svn:ignore, svn:ignore, svn:ignore, svn:ignore and svn:ignore.
* WebKit.vcxproj/Interfaces: Added property svn:ignore.
* WebKit.vcxproj/Interfaces/Interfaces.vcxproj.user: Removed.
* WebKit.vcxproj/WebKit: Added property svn:ignore.
* WebKit.vcxproj/WebKit.sln:
* WebKit.vcxproj/WebKit/WebKit.vcxproj.user: Removed.
* WebKit.vcxproj/WebKitExportGenerator: Added property svn:ignore.
* WebKit.vcxproj/WebKitExportGenerator/WebKitExportGenerator.vcxproj.user: Removed.
* WebKit.vcxproj/WebKitGUID: Added property svn:ignore.
* WebKit.vcxproj/WebKitGUID/WebKitGUID.vcxproj.user: Removed.
* WebCore.vcxproj: Added properties svn:ignore and svn:ignore.
* WebCore.vcxproj/QTMovieWin: Added property svn:ignore.
* WebCore.vcxproj/QTMovieWin/QTMovieWin.vcxproj.user: Removed.
* WebCore.vcxproj/QTMovieWin/QTMovieWinPostBuild.cmd: Added.
* WebCore.vcxproj/QTMovieWin/QTMovieWinPreBuild.cmd: Added.
* WebCore.vcxproj/QTMovieWin/QTMovieWinPreLink.cmd: Added.
* WebCore.vcxproj/WebCore.vcxproj.user: Removed.
* WebCore.vcxproj/WebCoreGenerated.vcxproj.user: Removed.
* JavaScriptCore.vcxproj: Added properties svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore, svn:ignore and svn:ignore.
* JavaScriptCore.vcxproj/JavaScriptCore.vcxproj.user: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator: Added property svn:ignore.
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExportGenerator.vcxproj.user: Removed.
* JavaScriptCore.vcxproj/JavaScriptCoreGenerated.vcxproj.user: Removed.
* JavaScriptCore.vcxproj/LLInt/LLIntAssembly: Added property svn:ignore.
* JavaScriptCore.vcxproj/LLInt/LLIntAssembly/LLIntAssembly.vcxproj.user: Removed.
* JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets: Added property svn:ignore.
* JavaScriptCore.vcxproj/LLInt/LLIntDesiredOffsets/LLIntDesiredOffsets.vcxproj.user: Removed.
* JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor: Added property svn:ignore.
* JavaScriptCore.vcxproj/LLInt/LLIntOffsetsExtractor/LLIntOffsetsExtractor.vcxproj.user: Removed.
* JavaScriptCore.vcxproj/jsc: Added property svn:ignore.
* JavaScriptCore.vcxproj/jsc/jsc.vcxproj.user: Removed.
* JavaScriptCore.vcxproj/testRegExp: Added property svn:ignore.
* JavaScriptCore.vcxproj/testRegExp/testRegExp.vcxproj.user: Removed.
* JavaScriptCore.vcxproj/testapi: Added property svn:ignore.
* JavaScriptCore.vcxproj/testapi/testapi.vcxproj.user: Removed.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Added property svn:ignore.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Added property svn:ignore.
* WinLauncher/WinLauncher.vcxproj: Added property svn:ignore.
* WinLauncher/WinLauncher.vcxproj/WinLauncher.vcxproj.user: Removed.
* WinLauncher/WinLauncher.vcxproj/WinLauncherLib.vcxproj.user: Removed.
* WTF.vcxproj: Added property svn:ignore.
* WTF.vcxproj/WTF.vcxproj.user: Removed.
* WTF.vcxproj/WTFGenerated.vcxproj.user: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Flakey test expectations update
schenney@chromium.org [Fri, 8 Feb 2013 19:30:56 +0000 (19:30 +0000)]
[Chromium] Flakey test expectations update

Unreviewed gardening.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse WeakPtrs to communicate between the HTMLDocumentParser and the BackgroundHTMLParser
abarth@webkit.org [Fri, 8 Feb 2013 19:30:54 +0000 (19:30 +0000)]
Use WeakPtrs to communicate between the HTMLDocumentParser and the BackgroundHTMLParser
https://bugs.webkit.org/show_bug.cgi?id=107190

Reviewed by Eric Seidel.

Source/WebCore:

This patch replaces the parser map with WeakPtr. We now use WeakPtrs to
communicate from the main thread to the background thread. (We were
already using WeakPtrs to communicate from the background thread to the
main thread.) This change lets us remove a bunch of boilerplate code.

* html/parser/BackgroundHTMLParser.cpp:
(WebCore::BackgroundHTMLParser::BackgroundHTMLParser):
(WebCore::BackgroundHTMLParser::stop):
(WebCore):
* html/parser/BackgroundHTMLParser.h:
(WebCore::BackgroundHTMLParser::create):
(BackgroundHTMLParser):
* html/parser/HTMLDocumentParser.cpp:
(WebCore::HTMLDocumentParser::didFailSpeculation):
(WebCore::HTMLDocumentParser::startBackgroundParser):
(WebCore::HTMLDocumentParser::stopBackgroundParser):
(WebCore::HTMLDocumentParser::append):
(WebCore::HTMLDocumentParser::finish):
* html/parser/HTMLDocumentParser.h:
(WebCore):
(HTMLDocumentParser):

Source/WTF:

Add the ability to create an unbound weak reference. This facility lets
you start sending messages to a WeakPtr on another thread before the
object backing the WeakPtr has actually been created.

* wtf/WeakPtr.h:
(WTF::WeakReference::createUnbound):
(WTF::WeakReference::bindTo):
(WeakReference):
(WTF::WeakReference::WeakReference):
(WTF::WeakPtr::WeakPtr):
(WeakPtr):
(WTF::WeakPtrFactory::WeakPtrFactory):
(WeakPtrFactory):
(WTF::WeakPtrFactory::revokeAll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 19:09:13 +0000 (19:09 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 11. Some fast tests. Elided.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDumpRenderTree, ImageDiff and TestNetscapePlugin projects, property sheets and resour...
roger_fong@apple.com [Fri, 8 Feb 2013 18:45:03 +0000 (18:45 +0000)]
DumpRenderTree, ImageDiff and TestNetscapePlugin projects, property sheets and resources for VS2010 solution.
https://bugs.webkit.org/show_bug.cgi?id=107034.

Reviewed by Brent Fulgham.

* DumpRenderTree/DumpRenderTree.vcxproj: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTree.vcxproj.filters: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeApple.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeCommon.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeDebug.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncher.vcxproj: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherCommon.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherDebug.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeLauncherRelease.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePostBuild.cmd: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreePreBuild.cmd: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/DumpRenderTree/DumpRenderTreeRelease.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiff.vcxproj: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffCommon.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffDebug.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncher.vcxproj: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherCommon.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherDebug.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffLauncherRelease.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPostBuild.cmd: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffPreBuild.cmd: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/ImageDiff/ImageDiffRelease.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.def: Copied from DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.def.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.rc: Copied from DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.rc.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePlugin.vcxproj.filters: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginCommon.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginDebug.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPostBuild.cmd: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginPreBuild.cmd: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/TestNetscapePluginRelease.props: Added.
* DumpRenderTree/DumpRenderTree.vcxproj/TestNetscapePlugin/resource.h: Copied from DumpRenderTree/TestNetscapePlugIn/win/resource.h.
* DumpRenderTree/TestNetscapePlugIn/Tests/win/CallJSThatDestroysPlugin.cpp: Copied from DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp.
* DumpRenderTree/TestNetscapePlugIn/win/CallJSThatDestroysPlugin.cpp: Removed.

VS2010 WebCore TestSupport project.
* WebCore.vcxproj/WebCoreTestSupport.vcxproj: Added.
* WebCore.vcxproj/WebCoreTestSupport.vcxproj.filters: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 18:09:01 +0000 (18:09 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 10. Mac 10.6 results were wrong. This simplifies things a lot.

* fast/repaint/scale-page-shrink-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/repaint/background-scaling-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/scale-page-shrink-expected.png:
* platform/chromium-mac-snowleopard/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/chromium/fast/repaint/scale-page-shrink-expected.png: Removed.
* platform/mac/fast/repaint/scale-page-shrink-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 18:06:36 +0000 (18:06 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 9. These were rebaselined earlier before all the bots were done.

* platform/chromium-mac-lion/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac-lion/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-lion/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac-lion/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium-mac-lion/svg/text/selection-styles-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac/svg/batik/text/smallFonts-expected.png:
* platform/chromium-mac/svg/batik/text/textDecoration-expected.png:
* platform/chromium-mac/svg/batik/text/textFeatures-expected.png:
* platform/chromium-mac/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium-mac/svg/text/selection-styles-expected.png:
* platform/chromium-win/svg/batik/text/smallFonts-expected.png:
* platform/chromium-win/svg/batik/text/textDecoration-expected.png:
* platform/chromium-win/svg/batik/text/textFeatures-expected.png:
* platform/chromium-win/svg/custom/shapes-supporting-markers-expected.png:
* platform/chromium-win/svg/text/selection-styles-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 18:04:25 +0000 (18:04 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 8. Outstanding mac failure.

* editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
* platform/chromium-mac-lion/editing/input/reveal-caret-of-multiline-input-expected.txt: Added.
* platform/chromium/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.
* platform/mac/editing/input/reveal-caret-of-multiline-input-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 18:01:19 +0000 (18:01 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 7. Outstanding failing linux tests

* platform/chromium-linux-x86/fast/forms/button-generated-content-expected.png: Removed.
* platform/chromium-linux-x86/fast/forms/button-inner-block-reuse-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Add an experimental gyp build
commit-queue@webkit.org [Fri, 8 Feb 2013 17:59:24 +0000 (17:59 +0000)]
[GTK] Add an experimental gyp build
https://bugs.webkit.org/show_bug.cgi?id=109003

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-08
Reviewed by Gustavo Noronha Silva.

Source/JavaScriptCore:

* JavaScriptCore.gypi: Update the list of source files to include those
necessary for the GTK+ build.

Source/WebKit/gtk:

Add an experimental gyp build for WebKitGTK+. Currently only libjavascriptcoregtk,
jsc, and minidom build (and only on platforms for that support bash). To use the
build simply run:

$ gyp --generator-output=build --depth=. Source/WebKit/gtk/gyp/JavaScriptCore.gyp

Then enter the build directory and run make.

* gyp/Configuration.gypi: Added.
* gyp/JavaScriptCore.gyp: Added.
* gyp/WTF.gyp: Added.
* gyp/generate-derived-sources.sh: Added.

Source/WTF:

* WTF.gyp/WTF.gyp: Filter out MetaAllocator.(cpp/h) from the Chromium
build. It's only necessary for GTK+.
* WTF.gypi: Add MetaAllocator to the build for WebKitGTK+.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][AC] GraphicsLayerActor code clean up after clutter version up.
commit-queue@webkit.org [Fri, 8 Feb 2013 17:58:11 +0000 (17:58 +0000)]
[GTK][AC] GraphicsLayerActor code clean up after clutter version up.
https://bugs.webkit.org/show_bug.cgi?id=109304

Patch by ChangSeok Oh <shivamidow@gmail.com> on 2013-02-08
Reviewed by Gustavo Noronha Silva.

This patch cleans up GraphicsLayerActor functions by using new clutter apis
and makes existing functions simple & readable.

No new tests since no change in functionality

* platform/graphics/clutter/GraphicsLayerActor.cpp:
(_GraphicsLayerActorPrivate):
(graphicsLayerActorApplyTransform):
(graphicsLayerActorPaint):
(graphicsLayerActorDraw):
(graphicsLayerActorUpdateTexture):
(drawLayerContents):
(graphicsLayerActorNew):
(graphicsLayerActorInvalidateRectangle):
(graphicsLayerActorSetTransform):
(graphicsLayerActorSetAnchorPoint):
(graphicsLayerActorGetAnchorPoint):
(graphicsLayerActorSetScrollPosition):
* platform/graphics/clutter/PlatformClutterAnimation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 17:58:04 +0000 (17:58 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 6. Outstanding failing linux tests

* platform/chromium-linux/fast/writing-mode/japanese-rl-text-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 17:55:10 +0000 (17:55 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 5. Editing expectations.

File list truncated to remove the hundreds of files that have been updated.

* platform/chromium/TestExpectations: Removed the temp expectations and re-added one mac failure case
* platform/efl-wk1/editing/selection: Added.
* platform/efl-wk1/editing/selection/move-by-character-6-expected.png: Added.
* platform/efl/editing/selection/move-by-character-6-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Qt] Unreviewed gardening. Update platform specific expected files after r142280.
kadam@inf.u-szeged.hu [Fri, 8 Feb 2013 17:35:48 +0000 (17:35 +0000)]
[Qt] Unreviewed gardening. Update platform specific expected files after r142280.

* platform/qt/fast/block/float/024-expected.txt: Update after r142280.
* platform/qt/fast/block/margin-collapse/empty-clear-blocks-expected.txt: Update after r142280.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[chromium] Unreviewed gardening. Remove effect-reference-hw from test expectations...
senorblanco@chromium.org [Fri, 8 Feb 2013 17:28:13 +0000 (17:28 +0000)]
[chromium] Unreviewed gardening.  Remove effect-reference-hw from test expectations, since it's now passing.
https://bugs.webkit.org/show_bug.cgi?id=104289

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
tkent@chromium.org [Fri, 8 Feb 2013 17:12:32 +0000 (17:12 +0000)]
[Chromium] Disable ENABLE_INPUT_TYPE_DATETIME
https://bugs.webkit.org/show_bug.cgi?id=109272

Reviewed by Kentaro Hara.

Source/WebKit/chromium:

We enabled this flag for desktop Chromium, but disabled the feature by a
runtime flag. We disables the compile flag too because we have no plan
to ship it in near future.

* features.gypi: Remove ENABLE_INPUT_TYPE_DATETIME.

LayoutTests:

* platform/chromium/TestExpectations:
Skip fast/forms/datetime and datetime-multiple-fields

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Fix and test for missing return statement
commit-queue@webkit.org [Fri, 8 Feb 2013 17:05:28 +0000 (17:05 +0000)]
Source/WebCore: Fix and test for missing return statement

RTCPeerConnection.getStats() failed when remote stats were instantiated.
https://bugs.webkit.org/show_bug.cgi?id=109292

Patch by Harald Alvestrand <hta@google.com> on 2013-02-08
Reviewed by Adam Barth.

Tested by extending the existing mock's behaviour.

* Modules/mediastream/RTCStatsReport.cpp:
(WebCore::RTCStatsReport::addElement):

Tools: Fix and test for missing return

RTCPeerConnection.getStats() fails when remote stats are instantiated.
https://bugs.webkit.org/show_bug.cgi?id=109292

Patch by Harald Alvestrand <hta@google.com> on 2013-02-08
Reviewed by Adam Barth.

* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::getStats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMediaStream API: Removing the deprecated WebMediaStreamDescriptor and WebMediaStreamC...
tommyw@google.com [Fri, 8 Feb 2013 16:57:06 +0000 (16:57 +0000)]
MediaStream API: Removing the deprecated WebMediaStreamDescriptor and WebMediaStreamComponent shims
https://bugs.webkit.org/show_bug.cgi?id=109296

Reviewed by Adam Barth.

Source/Platform:

* Platform.gypi:
* chromium/public/WebMediaStreamComponent.h: Removed.
* chromium/public/WebMediaStreamDescriptor.h: Removed.

Tools:

* DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.cpp:
(MockWebRTCDTMFSenderHandler::MockWebRTCDTMFSenderHandler):
* DumpRenderTree/chromium/MockWebRTCDTMFSenderHandler.h:
(MockWebRTCDTMFSenderHandler):
* DumpRenderTree/chromium/MockWebRTCPeerConnectionHandler.cpp:
(MockWebRTCPeerConnectionHandler::createDTMFSender):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Text Autosizing] Split isAutosizingCluster into three independent checks
commit-queue@webkit.org [Fri, 8 Feb 2013 16:40:52 +0000 (16:40 +0000)]
[Text Autosizing] Split isAutosizingCluster into three independent checks
https://bugs.webkit.org/show_bug.cgi?id=109093

Refactoring to create more flexible version of isAutosizingCluster since there're more types
of autosizing cluster now: narrower than the parent cluster, wider than the parent cluster
and the one that doesn't depend on the parent cluster.

Patch by Anton Vayvod <avayvod@chromium.org> on 2013-02-08
Reviewed by Kenneth Rohde Christiansen.

Refactoring, no test changes.

* rendering/TextAutosizer.cpp:

(WebCore::TextAutosizer::isNarrowDescendant):

    Separate check for the container to be of the narrow-descendant type. Was a part of
    isAutosizingCluster().

(WebCore::TextAutosizer::isWiderDescendant):

    Separate check for the container to be of the wider-descendant type. Was a part of
    isAutosizingCluster().

(WebCore::TextAutosizer::isIndependentDescendant):

    Separate check for the container to be autosized separately from the ancestor cluster.
    Checks for conditions independent of the aforementioned cluster.

(WebCore::TextAutosizer::isAutosizingCluster):

    Handy method to check all separate conditions together.

(WebCore::TextAutosizer::processSubtree):
(WebCore::TextAutosizer::processCluster):
(WebCore::TextAutosizer::processContainer):
(WebCore::TextAutosizer::clusterShouldBeAutosized):
(WebCore::TextAutosizer::measureDescendantTextWidth):
(WebCore::TextAutosizer::findFirstTextLeafNotInCluster):

    The methods above were updated to use new functions/arguments.

* rendering/TextAutosizer.h:

    Updated/added method definitions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 16:27:26 +0000 (16:27 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 4. CSS expectations.

* platform/chromium-linux-x86/css1/box_properties: Removed.
* platform/chromium-linux-x86/css1/box_properties/acid_test-expected.png: Removed.
* platform/chromium-linux-x86/css2.1/t09-c5526c-display-00-e-expected.png: Removed.
* platform/chromium-linux-x86/css3/images: Removed.
* platform/chromium-linux-x86/css3/images/cross-fade-overflow-position-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/html: Removed.
* platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-161-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-19b-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-25-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-64-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/html/css3-modsel-70-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-161-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-19b-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-25-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-64-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xhtml/css3-modsel-70-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-161-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-19b-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-25-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-64-expected.png: Removed.
* platform/chromium-linux-x86/css3/selectors3/xml/css3-modsel-70-expected.png: Removed.
* platform/chromium-linux/compositing/overflow/theme-affects-visual-overflow-expected.png:
* platform/chromium-linux/compositing/video/video-controls-layer-creation-expected.png:
* platform/chromium-linux/css1/box_properties/acid_test-expected.png:
* platform/chromium-linux/css2.1/t0505-c16-descendant-01-e-expected.png:
* platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
* platform/chromium-linux/css3/images/cross-fade-overflow-position-expected.png: Removed.
* platform/chromium-linux/css3/masking/clip-path-circle-filter-expected.png:
* platform/chromium-linux/css3/masking/clip-path-circle-overflow-expected.png:
* platform/chromium-linux/css3/masking/clip-path-ellipse-expected.png:
* platform/chromium-linux/css3/selectors3/html/css3-modsel-161-expected.png:
* platform/chromium-linux/css3/selectors3/html/css3-modsel-19b-expected.png:
* platform/chromium-linux/css3/selectors3/html/css3-modsel-25-expected.png:
* platform/chromium-linux/css3/selectors3/html/css3-modsel-64-expected.png:
* platform/chromium-linux/css3/selectors3/html/css3-modsel-70-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-161-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-19b-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-25-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-64-expected.png:
* platform/chromium-linux/css3/selectors3/xhtml/css3-modsel-70-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-161-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-19b-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-25-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-64-expected.png:
* platform/chromium-linux/css3/selectors3/xml/css3-modsel-70-expected.png:
* platform/chromium-mac-lion/compositing/video/video-controls-layer-creation-expected.png:
* platform/chromium-mac-lion/css2.1/t0505-c16-descendant-01-e-expected.png:
* platform/chromium-mac-lion/css3/images: Removed.
* platform/chromium-mac-lion/css3/images/cross-fade-overflow-position-expected.png: Removed.
* platform/chromium-mac-lion/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/video/video-controls-layer-creation-expected.png:
* platform/chromium-mac-snowleopard/css2.1/t0505-c16-descendant-01-e-expected.png:
* platform/chromium-mac-snowleopard/css3/images/cross-fade-overflow-position-expected.png: Removed.
* platform/chromium-mac-snowleopard/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
* platform/chromium-mac/compositing/video/video-controls-layer-creation-expected.png:
* platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.png:
* platform/chromium-mac/css2.1/t0505-c16-descendant-01-e-expected.txt: Added.
* platform/chromium-mac/css3/images/cross-fade-overflow-position-expected.png:
* platform/chromium-mac/css3/masking/clip-path-circle-filter-expected.png:
* platform/chromium-mac/css3/masking/clip-path-circle-overflow-expected.png:
* platform/chromium-mac/css3/masking/clip-path-ellipse-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15c-expected.png:
* platform/chromium-mac/css3/selectors3/xhtml/css3-modsel-15c-expected.txt:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-15c-expected.png:
* platform/chromium-mac/css3/selectors3/xml/css3-modsel-15c-expected.txt:
* platform/chromium-win-xp/css3/images: Removed.
* platform/chromium-win-xp/css3/images/cross-fade-overflow-position-expected.png: Removed.
* platform/chromium-win-xp/css3/selectors3: Removed.
* platform/chromium-win/compositing/video/video-controls-layer-creation-expected.png:
* platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.png:
* platform/chromium-win/css2.1/t0505-c16-descendant-01-e-expected.txt:
* platform/chromium-win/css3/images/cross-fade-overflow-position-expected.png:
* platform/chromium-win/css3/masking/clip-path-circle-filter-expected.png:
* platform/chromium-win/css3/masking/clip-path-circle-overflow-expected.png:
* platform/chromium-win/css3/masking/clip-path-ellipse-expected.png:
* platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Added.
* platform/chromium-win/css3/selectors3/xhtml/css3-modsel-15c-expected.txt: Added.
* platform/chromium/TestExpectations:
* platform/chromium/css2.1/t0505-c16-descendant-01-e-expected.txt: Removed.
* platform/chromium/css3/selectors3/xhtml/css3-modsel-15c-expected.png: Removed.
* platform/chromium/css3/selectors3/xhtml/css3-modsel-15c-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Include files from DerivedSources/webkitdom for introspection
commit-queue@webkit.org [Fri, 8 Feb 2013 16:17:04 +0000 (16:17 +0000)]
[GTK] Include files from DerivedSources/webkitdom for introspection
https://bugs.webkit.org/show_bug.cgi?id=108631

Patch by Tomas Popela <tpopela@redhat.com> on 2013-02-08
Reviewed by Martin Robinson.

Include files from DerivedSources/webkitdom for introspection

* /Source/WebKit/gtk/GNUmakefile.am:
* /Source/WebKit2/GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Split configure.ac into reusable portions
mrobinson@webkit.org [Fri, 8 Feb 2013 16:15:18 +0000 (16:15 +0000)]
[GTK] Split configure.ac into reusable portions
https://bugs.webkit.org/show_bug.cgi?id=109246

Reviewed by Philippe Normand.

Split up configure.ac into sections based on different "phases"
of configuration. This should make it easier to find what you are
looking for as well as creating a "right" place to put things.
A nice side effect of this is that we can share the different
modules with a gyp build.

* Source/autotools/CheckSystemAndBasicDependencies.m4: Added.
* Source/autotools/FindDependencies.m4: Added.
* Source/autotools/PrintBuildConfiguration.m4: Added.
* Source/autotools/ReadCommandLineArguments.m4: Added.
* Source/autotools/SetupAutoconfHeader.m4: Added.
* Source/autotools/SetupAutomake.m4: Added.
* Source/autotools/SetupCompilerFlags.m4: Added.
* Source/autotools/SetupLibtool.m4: Added.
* Source/autotools/Versions.m4: Added.
* configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: Extension sever should use Workspace.projectForType() instead of Works...
vsevik@chromium.org [Fri, 8 Feb 2013 16:09:59 +0000 (16:09 +0000)]
Web Inspector: Extension sever should use Workspace.projectForType() instead of Workspace.project()
https://bugs.webkit.org/show_bug.cgi?id=109301

Reviewed by Alexander Pavlov.

* inspector/front-end/ExtensionServer.js:
(WebInspector.ExtensionServer.prototype._onGetPageResources):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoExpectations as a result of removing Skia code suppressions
schenney@chromium.org [Fri, 8 Feb 2013 16:09:01 +0000 (16:09 +0000)]
Expectations as a result of removing Skia code suppressions

Unreviewed expectations update.

Round 3. Remaining expected failures that had platform-specific supppressions

* platform/chromium-linux-x86/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
* platform/chromium-linux-x86/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
* platform/chromium-linux/fast/css/background-clip-radius-values-expected.png:
* platform/chromium-linux/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-linux/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-linux/fast/frames/iframe-scaling-with-scroll-expected.png:
* platform/chromium-linux/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-linux/fast/replaced/border-radius-clip-content-edge-expected.png:
* platform/chromium-mac-lion/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
* platform/chromium-mac-lion/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
* platform/chromium-mac-lion/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-mac-lion/fast/dom/52776-expected.png:
* platform/chromium-mac-lion/fast/frames/iframe-scaling-with-scroll-expected.png:
* platform/chromium-mac-lion/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/52776-expected.png:
* platform/chromium-mac-snowleopard/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png: Removed.
* platform/chromium-mac/editing/pasteboard/emacs-cntl-y-001-expected.png: Added.
* platform/chromium-mac/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Added.
* platform/chromium-mac/fast/css/background-clip-radius-values-expected.png:
* platform/chromium-mac/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-mac/fast/dom/52776-expected.png:
* platform/chromium-mac/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-mac/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/interact-cursor-01-f-expected.png:
* platform/chromium-win-xp/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Removed.
* platform/chromium-win-xp/fast/gradients/css3-linear-angle-gradients-expected.png: Removed.
* platform/chromium-win/fast/css/background-clip-radius-values-expected.png:
* platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-win/fast/gradients/css3-linear-angle-gradients-expected.png:
* platform/chromium-win/fast/replaced/border-radius-clip-content-edge-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/editing/pasteboard/emacs-cntl-y-001-expected.png: Removed.
* platform/chromium/editing/pasteboard/emacs-ctrl-a-k-y-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: simplify Memory.getDOMNodeCount implementation
yurys@chromium.org [Fri, 8 Feb 2013 16:04:28 +0000 (16:04 +0000)]
Web Inspector: simplify Memory.getDOMNodeCount implementation
https://bugs.webkit.org/show_bug.cgi?id=108821

Reviewed by Alexander Pavlov.

Removed Memory.getDOMNodeCount command from the protocol. Memory.getDOMCounters
should be used instead.

* inspector/Inspector.json:
* inspector/InspectorMemoryAgent.cpp:
* inspector/InspectorMemoryAgent.h:
(InspectorMemoryAgent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@142281 268f45cc-cd09-0410-ab3c-d52691b4dbfc