WebKit-https.git
14 years agoWebCore:
thatcher [Wed, 25 Jan 2006 22:16:25 +0000 (22:16 +0000)]
WebCore:

        Move off of -[NSFont widthOfString:] since it is now deprecated.
        Use the NSStringDrawing -[NSString sizeWithAttributes:] API.

        * bridge/mac/MacFrame.mm:
        (MacFrame::attributedString):
        * kwq/KWQTextArea.mm:
        (-[KWQTextAreaTextView sizeWithColumns:rows:]):

WebKit:

        Move off of -[NSFont widthOfString:] since it is now deprecated.
        Use the NSStringDrawing -[NSString sizeWithAttributes:] API.

        * WebCoreSupport.subproj/WebFileButton.m:
        (-[WebFileChooserButton bestVisualFrameSizeForCharacterCount:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Dave Harrison.
tomernic [Wed, 25 Jan 2006 22:05:33 +0000 (22:05 +0000)]
    Reviewed by Dave Harrison.

        <rdar://problem/4339024>
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=6785> "Fix for possible leak of applet, object, or embed
        (and plugin view)"

        * khtml/html/html_objectimpl.cpp:
        (WebCore::HTMLAppletElementImpl::~HTMLAppletElementImpl):
        Assert that appletInstance has been deleted by detach().
        (WebCore::HTMLAppletElementImpl::detach):
        Delete appletInstance, because it references the widget owned by the renderer we're about to destroy.
        It is assumed elsewhere (getRuntimeObject(), kjs_dom.cpp) that the instance is owned by the applet
        element.  Therefore, it is required that the element destroy the instance in its tear-down phase.
        (WebCore::HTMLEmbedElementImpl::~HTMLEmbedElementImpl):
        Assert that embedInstance has been deleted by detach().
        (WebCore::HTMLEmbedElementImpl::detach):
        Delete embedInstance, same reason.  This is the one that fixes <rdar://problem/4339024>.
        (WebCore::HTMLObjectElementImpl::~HTMLObjectElementImpl):
        Assert that objectInstance has been deleted by detach().
        (WebCore::HTMLObjectElementImpl::detach):
        Delete embedInstance, same reason.
        * khtml/html/html_objectimpl.h:
        Declared HTMLAppletElementImpl::detach() and HTMLEmbedElementImpl::detach().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoForgot to add this
andersca [Wed, 25 Jan 2006 22:04:29 +0000 (22:04 +0000)]
Forgot to add this

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-24 Anders Carlsson <andersca@mac.com>
andersca [Wed, 25 Jan 2006 21:57:47 +0000 (21:57 +0000)]
2006-01-24  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=5975
        WebCore needs to use KDOM-like DOM binding autogeneration

        This is a first cut at an autogeneration framework based on
        what KDOM uses, but with some changes to be able to move
        gradually to using autogenerated files. Currently only Javascript
        is supported, but ObjC support could be added by writing a new code
        generator package.

        * WebCore.xcodeproj/project.pbxproj:
        Call generate-bindings.pl

        * bindings/js/JSEvents.cpp: Added.
        New file which #includes all generated files in the event module
        (Just JSWheelEvent.cpp for now)

        * khtml/xml/WheelEvent.idl: Added.

        * bindings/scripts: Added.
        * bindings/scripts/CodeGenerator.pm: Added.
        * bindings/scripts/CodeGeneratorJS.pm: Added.
        * bindings/scripts/IDLParser.pm: Added.
        * bindings/scripts/IDLStructure.pm: Added.
        * bindings/scripts/generate-bindings.pl: Added.

        * khtml/ecma/kjs_events.cpp:
        Remove DOMWheelEvent class.

        (KJS::getDOMEvent):
        Use JSWheelEvent here.

        * khtml/ecma/kjs_events.h:
        Remove DOMWheelEvent class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Updated for fixes of:
harrison [Wed, 25 Jan 2006 21:11:04 +0000 (21:11 +0000)]
    Updated for fixes of:

        <rdar://problem/3907635> copy/paste of list item text moves list item up one <LI>
        <rdar://problem/3907647> Enhance list editing: return inserts <li></li>
        <rdar://problem/4060158> deleting selection within table deletes more than intended
        <rdar://problem/4061232> Deleting a list can delete unselected content
        <rdar://problem/4062212> after pasting in contents of web.apple.com, typing before start adds to table instead of before table
        <rdar://problem/4064437> After copy/paste from bugweb cannot go back to entering text at left side of page
        <rdar://problem/4259845> Table editing in design mode is broken
        <rdar://problem/4287667> Insertion point goes before table instead of inside first cell
        <rdar://problem/4345749> Editing HTML - Enter at end of <LI> inserts uneditable blank <LI>
        <rdar://problem/4345794> HTML editing: Enter at end of last <LI> does not add new <LI>
        <rdar://problem/4345825> HTML Editing: editing first <LI> element removes first <LI> and more
        <rdar://problem/4345835> HTML editing: editing last <LI> removes everything within <BODY>
        <rdar://problem/4345879> HTML editing: editing first <TD> moves data out of table

        * editing/deleting/delete-4083333-fix-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
        * editing/deleting/delete-image-004-expected.txt:
        * editing/deleting/delete-line-015-expected.txt:
        * editing/deleting/delete-select-all-001-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/pasteboard/paste-table-001-expected.txt:
        * editing/pasteboard/paste-table-001.html:
        * editing/selection/3690703-2-expected.txt:
        * editing/selection/3690703-2.html:
        * editing/selection/3690703-expected.txt:
        * editing/selection/3690719-expected.txt:
        * editing/selection/move-by-line-001-expected.txt:
        * editing/selection/move-by-line-001.html:
        * editing/selection/replaced-boundaries-3-expected.txt:
        * editing/unsupported-content/list-type-after-expected.txt:
        * editing/unsupported-content/list-type-after.html:
        * editing/unsupported-content/list-type-before-expected.txt:
        * editing/unsupported-content/list-type-before.html:
        * editing/unsupported-content/table-delete-001-expected.txt:
        * editing/unsupported-content/table-delete-001.html:
        * editing/unsupported-content/table-delete-002-expected.txt:
        * editing/unsupported-content/table-delete-002.html:
        * editing/unsupported-content/table-type-after-expected.txt:
        * editing/unsupported-content/table-type-after.html:
        * editing/unsupported-content/table-type-before-expected.txt:
        * editing/unsupported-content/table-type-before.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Justin.
harrison [Wed, 25 Jan 2006 21:05:02 +0000 (21:05 +0000)]
    Reviewed by Justin.

        <rdar://problem/3907635> copy/paste of list item text moves list item up one <LI>
        <rdar://problem/3907647> Enhance list editing: return inserts <li></li>
        <rdar://problem/4060158> deleting selection within table deletes more than intended
        <rdar://problem/4061232> Deleting a list can delete unselected content
        <rdar://problem/4062212> after pasting in contents of web.apple.com, typing before start adds to table instead of before table
        <rdar://problem/4064437> After copy/paste from bugweb cannot go back to entering text at left side of page
        <rdar://problem/4259845> Table editing in design mode is broken
        <rdar://problem/4287667> Insertion point goes before table instead of inside first cell
        <rdar://problem/4345749> Editing HTML - Enter at end of <LI> inserts uneditable blank <LI>
        <rdar://problem/4345794> HTML editing: Enter at end of last <LI> does not add new <LI>
        <rdar://problem/4345825> HTML Editing: editing first <LI> element removes first <LI> and more
        <rdar://problem/4345835> HTML editing: editing last <LI> removes everything within <BODY>
        <rdar://problem/4345879> HTML editing: editing first <TD> moves data out of table

        ...also added showTree() static functions because switch to gcc 4.0 makes calling instance methods unreliable

        - numerous small changes to handle empty list items
        - fix numeric list marker updating when adding/deleting list items
        - start to decompose "special element" handling, replacing it with appropriate handling of the different
          kinds of special elements in various situations, rather than giving a blanket treatment.  I will do more
          of this in subsequent checkins.
        - numerous small editing/selection changes to handle VisiblePosition at table offset childNodeCount()
        - simplify and fix equivalentRangeCompliantPosition, rename it to rangeCompliantEquivalent and make it static
        - some minor reformatting to current standards
        - the comments in the list below are for changes not covered by the above comments

        * khtml/editing/Selection.cpp:
        (WebCore::Selection::toRange):
        (WebCore::Selection::validate):
        * khtml/editing/SelectionController.cpp:
        (WebCore::SelectionController::modifyExtendingLeftBackward):
        - character selection backward from after table selects the table
        (WebCore::showTree):
        * khtml/editing/composite_edit_command.cpp:
        (WebCore::CompositeEditCommand::removeFullySelectedNode):
        - make sure empty cell has some height
        (WebCore::CompositeEditCommand::positionOutsideTabSpan):
        - check for !isTabSpanTextNode() to make calling this function easier
        (WebCore::CompositeEditCommand::addBlockPlaceholderIfNeeded):
        * khtml/editing/delete_selection_command.cpp:
        (WebCore::positionBeforePossibleContainingSpecialElement):
        (WebCore::positionAfterPossibleContainingSpecialElement):
        (WebCore::DeleteSelectionCommand::initializeStartEnd):
        - new.  more consistent handling of special element boundaries.
        (WebCore::DeleteSelectionCommand::initializePositionData):
        (WebCore::DeleteSelectionCommand::handleGeneralDelete):
        - handle childless block (e.g. empty table cell)
        - allow merging across list items
        (WebCore::DeleteSelectionCommand::moveNodesAfterNode):
        - use new isEmpty() method for renderers, to handle empty list items
        * khtml/editing/delete_selection_command.h:
        * khtml/editing/htmlediting.cpp:
        (WebCore::isAtomicNode):
        (WebCore::editingIgnoresContent):
        - new.  smarter check than isReplaced()
        (WebCore::rangeCompliantEquivalent):
        (WebCore::maxDeepOffset):
        (WebCore::isFirstVisiblePositionInSpecialElement):
        (WebCore::positionBeforeContainingSpecialElement):
        (WebCore::isLastVisiblePositionInSpecialElement):
        (WebCore::positionAfterContainingSpecialElement):
        (WebCore::positionOutsideContainingSpecialElement):
        (WebCore::positionBeforeNode):
        (WebCore::positionAfterNode):
        (WebCore::isListElement):
        (WebCore::isTableElement):
        (WebCore::isFirstVisiblePositionAfterTableElement):
        (WebCore::positionBeforePrecedingTableElement):
        (WebCore::positionAvoidingSpecialElementBoundary):
        * khtml/editing/htmlediting.h:
        * khtml/editing/insert_line_break_command.cpp:
        (khtml::InsertLineBreakCommand::doApply):
        * khtml/editing/insert_paragraph_separator_command.cpp:
        (khtml::InsertParagraphSeparatorCommand::doApply):
        * khtml/editing/insert_text_command.cpp:
        (khtml::InsertTextCommand::prepareForTextInsertion):
        (khtml::InsertTextCommand::input):
        * khtml/editing/replace_selection_command.cpp:
        (WebCore::isMailPasteAsQuotationNode):
        (WebCore::ReplacementFragment::countRenderedBlocks):
        (WebCore::ReplaceSelectionCommand::doApply):
        - allow for fact that fragments have no VisiblePositions
        * khtml/editing/visible_position.cpp:
        (khtml::VisiblePosition::isCandidate):
        (khtml::showTree):
        (khtml::makeRange):
        (khtml::setStart):
        (khtml::setEnd):
        * khtml/editing/visible_position.h:
        * khtml/editing/visible_units.cpp:
        (khtml::previousBoundary):
        (khtml::nextBoundary):
        (khtml::startOfLine):
        - allow for fact that renderers for list markers and other generated content
          have no corresponding NodeImpl.
        (khtml::endOfLine):
        - ditto
        (khtml::nextLinePosition):
        (khtml::startOfParagraph):
        (khtml::endOfParagraph):
        * khtml/xml/ContainerNodeImpl.cpp:
        (WebCore::ContainerNodeImpl::getUpperLeftCorner):
        (WebCore::ContainerNodeImpl::childNode):
        * khtml/xml/ContainerNodeImpl.h:
        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::childNode):
        (WebCore::NodeImpl::traversePreviousNode):
        (WebCore::NodeImpl::nextEditable):
        (WebCore::showTree):
        * khtml/xml/NodeImpl.h:
        * khtml/xml/dom_position.cpp:
        (DOM::Position::upstream):
        (DOM::Position::downstream):
        (DOM::Position::inRenderedContent):
        (DOM::showTree):
        * khtml/xml/dom_position.h:
        * rendering/render_canvas.cpp:
        (RenderCanvas::selectionRect):
        * rendering/render_list.cpp:
        (RenderListItem::calcListValue):
        (RenderListItem::isEmpty):
        (getParentOfFirstLineBox):
        (RenderListItem::resetMarkerValue):
        (RenderListItem::updateMarkerLocation):
        * rendering/render_list.h:
        (khtml::RenderListMarker::isListMarker):
        * rendering/render_object.cpp:
        (WebCore::RenderObject::nextRenderer):
        (WebCore::RenderObject::previousRenderer):
        (WebCore::showTree):
        * rendering/render_object.h:
        (WebCore::RenderObject::getBaselineOfLastLineBox):
        (WebCore::RenderObject::isEmpty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake Color compile on Win32.
hyatt [Wed, 25 Jan 2006 20:14:08 +0000 (20:14 +0000)]
Make Color compile on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMake Win32 build again.
hyatt [Wed, 25 Jan 2006 19:58:47 +0000 (19:58 +0000)]
Make Win32 build again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix, -[NSFont defaultLineHeightForFont] is deprecated.
thatcher [Wed, 25 Jan 2006 19:37:47 +0000 (19:37 +0000)]
    Build fix, -[NSFont defaultLineHeightForFont] is deprecated.
        We need to use -[NSLayoutManager defaultLineHeightForFont:] instead.

        * kwq/KWQLineEdit.mm:
        (QLineEdit::sizeForCharacterWidth):
        (QLineEdit::baselinePosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoQuick update for Dave, who's working on getting this compiling again.
darin [Wed, 25 Jan 2006 19:33:17 +0000 (19:33 +0000)]
Quick update for Dave, who's working on getting this compiling again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix JavaScriptCore Win32 bustage by #defining copysign to be _copysign.
hyatt [Wed, 25 Jan 2006 19:12:34 +0000 (19:12 +0000)]
Fix JavaScriptCore Win32 bustage by #defining copysign to be _copysign.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - removed an unused source file
darin [Wed, 25 Jan 2006 18:20:49 +0000 (18:20 +0000)]
    - removed an unused source file

        * kjs/pointer_hash.h: Removed.
        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj: Removed reference to pointer_hash.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Wed, 25 Jan 2006 12:36:48 +0000 (12:36 +0000)]
    Reviewed by Darin.

        Corrected a test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=6385.

        * fast/frames/frame-element-name.html: Fix a reference to the left frame.
        * fast/frames/frame-element-name-expected.txt: Updated results.
        * fast/frames/frame-element-name-expected.png: Updated results.
        * fast/frames/frame-element-name-expected.checksum: Updated results.
        * fast/frames/resources/frame-element-name-left.html: Use escape() on the name.
        * fast/frames/resources/frame-element-name-right.html: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6731
darin [Wed, 25 Jan 2006 07:42:04 +0000 (07:42 +0000)]
   - test for bugzilla.opendarwin.org/show_bug.cgi?id=6731
         REGRESSION: change event fires at load time for checked items

        * fast/forms/radio-button-no-change-event.html: Added.
        * fast/forms/radio-button-no-change-event-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
darin [Wed, 25 Jan 2006 07:41:42 +0000 (07:41 +0000)]
    Reviewed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6731
          REGRESSION: change event fires at load time for checked items

        Test: fast/forms/radio-button-no-change-event.html

        * khtml/html/HTMLInputElementImpl.cpp: (WebCore::HTMLInputElementImpl::setChecked):
        One of many possible fixes: Don't send the event if the element is not yet in
        a document (as in when parsing the initial attributes).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Wed, 25 Jan 2006 07:35:27 +0000 (07:35 +0000)]
LayoutTests:

        Test for focus and blur for new text fields.

        * fast/forms/input-appearance-focus.html: Added.
        * fast/forms/input-appearance-focus-expected.txt: Added.
        * fast/forms/input-appearance-focus-expected.png: Added.
        * fast/forms/input-appearance-focus-expected.checksum: Added.

WebCore:

        Reviewed by Hyatt.

        This change will allow the new text field elements to get focus, and to respond to the focus and blur events.

        Added: fast/forms/input-appearance-focus.html

        * khtml/html/HTMLElementImpl.cpp: (WebCore::HTMLElementImpl::isFocusable):
          Removed recently added code that allowed editable elements with no parent to be focusable.
          We don't need to do this now that we try to focus the input element, instead of the inner div.
        * khtml/html/HTMLGenericFormElementImpl.cpp: (WebCore::HTMLGenericFormElementImpl::isMouseFocusable): Added case to for text fields.
        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::focus): Added. Selects contents of text field.
        (WebCore::HTMLInputElementImpl::setSelectionStart): Added break; in switch statement.
        (WebCore::HTMLInputElementImpl::setSelectionEnd): ditto.
        (WebCore::HTMLInputElementImpl::select): ditto.
        (WebCore::HTMLInputElementImpl::setSelectionRange): ditto.
        * khtml/html/HTMLInputElementImpl.h: Added focus()
        * khtml/xml/dom_elementimpl.h: Made focus() virtual.
        * page/Frame.cpp: (Frame::setFocusNodeIfNeeded):
          Walk up the Render Tree instead of the DOM tree when trying to find a node to focus.
          This will let us choose the input node instead of one of the nodes in the shadow tree.
        * page/FrameView.cpp: (FrameView::dispatchMouseEvent): ditto.
        * rendering/RenderContainer.cpp: (WebCore::RenderContainer::destroyLeftoverChildren): Corrected misspelling.
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::select): Implemented.  Select contents of inner div.
        * rendering/RenderTextField.h:
        (WebCore::RenderTextField::renderName): Changed order.
        (WebCore::RenderTextField::removeLeftoverAnonymousBoxes): ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Wed, 25 Jan 2006 06:08:08 +0000 (06:08 +0000)]
   Reviewed by Eric.

       - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6782
         REGRESSION: replaceChild broken when node to replace is first (TinyMCE test app broken)

       * fast/dom/replace-first-child.html: Added.
       * fast/dom/replace-first-child-expected.txt: Added

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Wed, 25 Jan 2006 06:07:42 +0000 (06:07 +0000)]
    Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6782
          REGRESSION: replaceChild broken when node to replace is first (TinyMCE test app broken)

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6784
          REGRESSION: 25 layout tests failing (basic DOM operations)

        * khtml/xml/ContainerNodeImpl.cpp:
        (WebCore::ContainerNodeImpl::insertBefore): Change one place that hands off ownership of
        as PassRefPtr that causes us to almost always return 0. Fix test that would screw up when
        both "prev" and "refChild->previousSibling()" were 0.
        (WebCore::ContainerNodeImpl::appendChild): Changed a nearly-identical place handing off
        ownership as above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
mjs [Wed, 25 Jan 2006 04:01:53 +0000 (04:01 +0000)]
LayoutTests:

        Reviewed by Dave Hyatt.

        - test case for http://bugzilla.opendarwin.org/show_bug.cgi?id=6778
        (Crash if a node is removed from the DOM before being reparented due to residual style)

        * fast/parser/remove-block-in-residual-style-expected.checksum: Added.
        * fast/parser/remove-block-in-residual-style-expected.png: Added.
        * fast/parser/remove-block-in-residual-style-expected.txt: Added.

WebCore:

        Reviewed by Dave Hyatt.

        - fixed crash if a node is removed from the DOM before being reparented due to residual style
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6778

        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleResidualStyleCloseTagAcrossBlocks): If the
        block has been removed from the document, then do not remove it
        from its parent or add it to its new location. This prevents the
        crash and matches Mozilla.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
darin [Wed, 25 Jan 2006 03:35:00 +0000 (03:35 +0000)]
    Reviewed by John Sullivan.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6750
          replace QDateTime with a simpler platform abstraction

        * ForwardingHeaders/qdatetime.h: Removed.
        * kwq/KWQDateTime.cpp: Removed.
        * kwq/KWQDateTime.h: Removed.

        * platform/SystemTime.h: Added.
        * platform/mac/SystemTime.cpp: (WebCore::currentTime): Added.
        * platform/win: Added.
        * platform/win/SystemTime.cpp: (WebCore::currentTime): Added.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Added new files, removed old.
        * WebCore.xcodeproj/project.pbxproj: Ditto.

        * css/css_base.h: Removed include of <qdatetime.h>.
        * css/cssstyleselector.cpp: Ditto.

        * khtml/html/htmltokenizer.h:
        * khtml/html/htmltokenizer.cpp: Convert tabs to spaces.
        (WebCore::HTMLTokenizer::continueProcessing): Change parameter from QTime to double.
        Use currentTime() instead of QTime::elapsed().
        (WebCore::HTMLTokenizer::write): Use currentTime() instead of QTime::elapsed().

        * config.h: Added HAVE_FUNC_USLEEP for now, not sure this is really a
        good way to handle this.
        * khtml/xml/ContainerNodeImpl.cpp: (WebCore::ContainerNodeImpl::setActive):
        Use currentTime() instead of QTime::elapsed(). Use HAVE_FUNC_USLEEP for the if.

        * khtml/xml/DocumentImpl.h:
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::DocumentImpl): Use currentTime() instead of QTime::elapsed().
        (WebCore::DocumentImpl::implicitClose): Ditto.
        (WebCore::DocumentImpl::minimumLayoutDelay): Ditto.
        (WebCore::DocumentImpl::elapsedTime): Ditto.

        * khtml/xml/dom2_eventsimpl.cpp: (WebCore::EventImpl::EventImpl): Use currentTime()
        instead of local function called currentTimeStamp().

        * khtml/xml/xml_tokenizer.h: Removed declaration of class QTime.

        * ksvg2/misc/KSVGTimeScheduler.h:
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        (KSVG::TimeScheduler::TimeScheduler): Use currentTime instead of QTime::elapsed.
        (KSVG::TimeScheduler::startAnimations): Ditto.
        (KSVG::TimeScheduler::toggleAnimations): Ditto.
        (KSVG::TimeScheduler::elapsed): Ditto.

        * page/Frame.cpp: (Frame::clear): Removed unused m_parsetime.
        * page/FramePrivate.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for bug 6781, convert QColor to Color (and QRgb to RGBA32). r=maciej.
hyatt [Wed, 25 Jan 2006 02:58:34 +0000 (02:58 +0000)]
    Fix for bug 6781, convert QColor to Color (and QRgb to RGBA32).  r=maciej.

        * ForwardingHeaders/qcolor.h: Removed.
        * WebCore+SVG/KDOMSettings.h:
        * WebCore+SVG/RGBColorImpl.cpp:
        (RGBColorImpl::RGBColorImpl):
        (RGBColorImpl::red):
        (RGBColorImpl::green):
        (RGBColorImpl::blue):
        * WebCore+SVG/RGBColorImpl.h:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMCSS.mm:
        (getWrapperForRGB):
        (setWrapperForRGB):
        (removeWrapperForRGB):
        (-[DOMRGBColor dealloc]):
        (-[DOMRGBColor finalize]):
        (-[DOMRGBColor red]):
        (-[DOMRGBColor green]):
        (-[DOMRGBColor blue]):
        (-[DOMRGBColor _initWithRGB:]):
        (+[DOMRGBColor _RGBColorWithRGB:]):
        (-[DOMRGBColor alpha]):
        (-[DOMRGBColor _color]):
        * bridge/mac/MacFrame.mm:
        (MacFrame::attributedString):
        (MacFrame::fontAttributesForSelectionStart):
        (MacFrame::bodyBackgroundColor):
        (convertAttributesToUnderlines):
        * css/css_valueimpl.cpp:
        (WebCore::CSSPrimitiveValueImpl::CSSPrimitiveValueImpl):
        (WebCore::CSSPrimitiveValueImpl::cssText):
        * css/csshelper.h:
        * css/cssparser.cpp:
        (CSSParser::parseColor):
        (CSSParser::parseColorFromValue):
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::canShareStyleWithElement):
        (WebCore::):
        (WebCore::colorForCSSValue):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
        * css/cssstyleselector.h:
        * kcanvas/KCanvasFilters.h:
        (KCanvasFEDiffuseLighting::lightingColor):
        (KCanvasFEDiffuseLighting::setLightingColor):
        (KCanvasFEFlood::floodColor):
        (KCanvasFEFlood::setFloodColor):
        (KCanvasFESpecularLighting::lightingColor):
        (KCanvasFESpecularLighting::setLightingColor):
        * kcanvas/KCanvasTreeDebug.cpp:
        (operator<<):
        * kcanvas/KCanvasTreeDebug.h:
        * kcanvas/device/KRenderingDevice.h:
        * kcanvas/device/KRenderingPaintServerGradient.cpp:
        (KCSortedGradientStopList::addStop):
        * kcanvas/device/KRenderingPaintServerGradient.h:
        * kcanvas/device/KRenderingPaintServerSolid.cpp:
        (KRenderingPaintServerSolid::color):
        (KRenderingPaintServerSolid::setColor):
        * kcanvas/device/KRenderingPaintServerSolid.h:
        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (ciColor):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (setupShadingWithStyle):
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (KRenderingPaintServerPatternQuartz::setup):
        * khtml/ecma/kjs_css.h:
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::Context2DFunction::callAsFunction):
        (KJS::colorRefFromValue):
        (KJS::colorFromValue):
        (KJS::Context2D::putValueProperty):
        (KJS::GradientFunction::callAsFunction):
        * khtml/ecma/kjs_html.h:
        * khtml/editing/apply_style_command.cpp:
        (WebCore::StyleChange::checkForLegacyHTMLStyleChange):
        * khtml/html/html_baseimpl.cpp:
        (WebCore::HTMLBodyElementImpl::parseMappedAttribute):
        * khtml/misc/helper.h:
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::DocumentImpl):
        (WebCore::DocumentImpl::resetLinkColor):
        (WebCore::DocumentImpl::resetVisitedLinkColor):
        * khtml/xml/DocumentImpl.h:
        (WebCore::DocumentImpl::setTextColor):
        (WebCore::DocumentImpl::textColor):
        (WebCore::DocumentImpl::linkColor):
        (WebCore::DocumentImpl::visitedLinkColor):
        (WebCore::DocumentImpl::activeLinkColor):
        (WebCore::DocumentImpl::setLinkColor):
        (WebCore::DocumentImpl::setVisitedLinkColor):
        (WebCore::DocumentImpl::setActiveLinkColor):
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        (KDOM::CSSStyleSelector::applySVGProperty):
        * ksvg2/css/SVGRenderStyle.h:
        * ksvg2/css/SVGRenderStyleDefs.h:
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (WebCore::KSVGPainterFactory::fillPaintServer):
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        (KSVG::SVGTimer::notifyAll):
        * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
        (SVGAnimateColorElementImpl::handleTimerEvent):
        (SVGAnimateColorElementImpl::clampColor):
        (SVGAnimateColorElementImpl::color):
        (SVGAnimateColorElementImpl::initialColor):
        * ksvg2/svg/SVGAnimateColorElementImpl.h:
        * ksvg2/svg/SVGAnimateElementImpl.cpp:
        (SVGAnimateElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGColorImpl.cpp:
        (SVGColorImpl::setRGBColor):
        (SVGColorImpl::color):
        * ksvg2/svg/SVGColorImpl.h:
        * ksvg2/svg/SVGGradientElementImpl.cpp:
        (SVGGradientElementImpl::rebuildStops):
        * kwq/KWQAccObject.mm:
        (AXAttributeStringSetStyle):
        * kwq/KWQBrush.h:
        (QBrush::QBrush::QBrush):
        (QBrush::color):
        (QBrush::setColor):
        * kwq/KWQColor.h: Removed.
        * kwq/KWQColor.mm: Removed.
        * kwq/KWQColorData.gperf: Removed.
        * kwq/KWQKConfigBase.h:
        * kwq/KWQKConfigBase.mm:
        (KConfig::readColorEntry):
        * kwq/KWQLineEdit.mm:
        (QLineEdit::setPalette):
        * kwq/KWQNamespace.h:
        (Qt::):
        * kwq/KWQObject.h:
        * kwq/KWQPainter.h:
        * kwq/KWQPainter.mm:
        (QPainter::setPen):
        (QPainter::setBrush):
        (QPainter::drawText):
        (QPainter::drawHighlightForText):
        (QPainter::selectedTextBackgroundColor):
        (_fillRectXX):
        (QPainter::setShadow):
        (QPainter::initFocusRing):
        * kwq/KWQPalette.h:
        (QColorGroup::QColorGroup):
        (QColorGroup::color):
        (QColorGroup::setColor):
        (QColorGroup::background):
        (QColorGroup::foreground):
        (QColorGroup::base):
        (QPalette::QPalette):
        (QPalette::background):
        (QPalette::foreground):
        * kwq/KWQPen.cpp:
        (QPen::QPen):
        (QPen::color):
        (QPen::setColor):
        * kwq/KWQPen.h:
        * kwq/KWQRenderTreeDebug.cpp:
        (operator<<):
        * kwq/KWQTextEdit.mm:
        (QTextEdit::setPalette):
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::tiled_pixmap):
        * loader/CachedImage.h:
        * page/Frame.cpp:
        (Frame::paint):
        * page/Frame.h:
        (MarkedTextUnderline::MarkedTextUnderline):
        * platform/Color.cpp: Added.
        (WebCore::makeRGB):
        (WebCore::makeRGBA):
        (WebCore::parseHexColor):
        (WebCore::Color::Color):
        (WebCore::Color::name):
        (WebCore::Color::setNamedColor):
        (WebCore::Color::hsv):
        (WebCore::Color::setHsv):
        (WebCore::Color::light):
        (WebCore::Color::dark):
        (WebCore::Color::getRgbaF):
        * platform/Color.h: Added.
        (WebCore::Color::Color):
        (WebCore::Color::rgb):
        (WebCore::Color::setRgb):
        (WebCore::operator==):
        (WebCore::operator!=):
        * platform/ColorData.gperf: Added.
        * rendering/InlineTextBox.cpp:
        (khtml::simpleDifferenceBetweenColors):
        (khtml::correctedTextColor):
        (khtml::InlineTextBox::paint):
        (khtml::InlineTextBox::paintSelection):
        (khtml::InlineTextBox::paintMarkedTextBackground):
        (khtml::InlineTextBox::paintDecoration):
        * rendering/RenderTable.h:
        (WebCore::RenderTable::bgColor):
        * rendering/RenderTableCell.cpp:
        (WebCore::outlineBox):
        (WebCore::RenderTableCell::paintBoxDecorations):
        * rendering/font.cpp:
        (khtml::Font::drawHighlightForText):
        (khtml::Font::drawText):
        * rendering/font.h:
        * rendering/render_box.cpp:
        (WebCore::RenderBox::paintRootBoxDecorations):
        (WebCore::RenderBox::paintBackgrounds):
        (WebCore::RenderBox::paintBackground):
        (WebCore::RenderBox::paintBackgroundExtended):
        (WebCore::RenderBox::outlineBox):
        * rendering/render_box.h:
        * rendering/render_flow.cpp:
        (RenderFlow::paintFocusRing):
        (RenderFlow::paintOutlineForLine):
        * rendering/render_form.cpp:
        (RenderFieldset::paintBorderMinusLegend):
        * rendering/render_frames.cpp:
        (WebCore::RenderFrameSet::userResize):
        * rendering/render_image.cpp:
        (WebCore::RenderImage::paint):
        * rendering/render_layer.h:
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::paintBackgrounds):
        (WebCore::InlineFlowBox::paintBackground):
        (WebCore::InlineFlowBox::paintBackgroundAndBorder):
        (WebCore::InlineFlowBox::paintDecorations):
        (WebCore::EllipsisBox::paint):
        * rendering/render_line.h:
        * rendering/render_list.cpp:
        (RenderListMarker::paint):
        * rendering/render_object.cpp:
        (WebCore::RenderObject::drawBorder):
        (WebCore::RenderObject::paintBorder):
        (WebCore::RenderObject::paintOutline):
        (WebCore::RenderObject::selectionColor):
        (WebCore::RenderObject::getTextDecorationColors):
        * rendering/render_object.h:
        (WebCore::RenderObject::paintBackgroundExtended):
        * rendering/render_replaced.cpp:
        (WebCore::RenderReplaced::selectionColor):
        * rendering/render_replaced.h:
        * rendering/render_style.h:
        (khtml::BorderValue::isTransparent):
        (khtml::CollapsedBorderValue::color):
        (khtml::RenderStyle::hasBackground):
        (khtml::RenderStyle::borderLeftColor):
        (khtml::RenderStyle::borderRightColor):
        (khtml::RenderStyle::borderTopColor):
        (khtml::RenderStyle::borderBottomColor):
        (khtml::RenderStyle::outlineColor):
        (khtml::RenderStyle::color):
        (khtml::RenderStyle::backgroundColor):
        (khtml::RenderStyle::setBackgroundColor):
        (khtml::RenderStyle::setBorderLeftColor):
        (khtml::RenderStyle::setBorderRightColor):
        (khtml::RenderStyle::setBorderTopColor):
        (khtml::RenderStyle::setBorderBottomColor):
        (khtml::RenderStyle::setOutlineColor):
        (khtml::RenderStyle::setColor):
        (khtml::RenderStyle::initialColor):
        * rendering/render_theme.cpp:
        (khtml::RenderTheme::isControlStyled):
        * rendering/render_theme.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John and Anders.
darin [Tue, 24 Jan 2006 23:27:41 +0000 (23:27 +0000)]
    Reviewed by John and Anders.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6732
          REGRESSION: Repro crash at Google Maps

        * khtml/ecma/JSXMLHttpRequest.cpp:
        (KJS::JSXMLHttpRequest::getValueProperty): Clean up a bit, using PassRefPtr where appropriate.
        (KJS::JSXMLHttpRequest::mark): Remove get calls now that getter functions don't return PassRefPtr.
        (KJS::JSXMLHttpRequest::JSXMLHttpRequest): Put the object into the DOM objects map.
        (KJS::JSXMLHttpRequest::~JSXMLHttpRequest): Remove the object from the DOM objects map. Also clear
        out both listeners so the implementation object isn't left with dangling pointers (since we won't
        be around to mark those objects any more).
        (KJS::JSXMLHttpRequestProtoFunc::callAsFunction): Tightened up the code a bit.

        * xml/xmlhttprequest.h:
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::getResponseXML): Change to return just a plain old pointer. Remove
        the unnecessary typeIsXML boolean.
        (WebCore::XMLHttpRequest::onReadyStateChangeListener): Change to return just a plain old pointer.
        Update for name changes.
        (WebCore::XMLHttpRequest::setOnReadyStateChangeListener): Ditto.
        (WebCore::XMLHttpRequest::onLoadListener): Ditto.
        (WebCore::XMLHttpRequest::setOnLoadListener): Ditto.
        (WebCore::XMLHttpRequest::send): Protect the DOM wrapper if any as well as ourselves while
        the load is in progress.
        (WebCore::XMLHttpRequest::abort): Unprotect to balance out the above.
        (WebCore::XMLHttpRequest::slotFinished): Ditto.

        * khtml/ecma/JSXMLHttpRequest.h: Just formatting changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Justin.
darin [Tue, 24 Jan 2006 23:23:53 +0000 (23:23 +0000)]
    Reviewed by Justin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6753
          REGRESSION (r12282-12292): Crash loading TinyMCE test app

        * khtml/xml/ContainerNodeImpl.h: Remove some internals that don't need
        to be member functions.
        * khtml/xml/ContainerNodeImpl.cpp:
        (WebCore::ContainerNodeImpl::insertBefore): Improved algorithm to keep
        refs to more things so that we don't end up with a dangling pointer (fixes
        the crash) and so that we do not crash if someone modifies the tree inside
        a DOM mutation event handler (theoretical only at this point, needs test
        cases).
        (WebCore::ContainerNodeImpl::replaceChild): Ditto.
        (WebCore::willRemoveChild): Changed from member function to free function.
        (WebCore::ContainerNodeImpl::removeChild): Fix potential problem if the
        mutation event handler moves the node into a different parent.
        (WebCore::ContainerNodeImpl::appendChild): Made changes like those in
        insertBefore above.
        (WebCore::dispatchChildInsertionEvents): Changed from member function to
        free function. Tightened up handling of some edge cases.
        (WebCore::dispatchChildRemovalEvents): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
darin [Tue, 24 Jan 2006 23:14:22 +0000 (23:14 +0000)]
    Reviewed by John Sullivan.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6696
          REGRESSION: JavaScript window.opener set incorrectly

        * khtml/ecma/kjs_window.cpp: (KJS::WindowFunc::callAsFunction):
        Fix local variable "frame" that was shadowing another local variable
        named "frame" by naming the one for the new frame "newFrame".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-23 Anders Carlsson <andersca@mac.com>
andersca [Tue, 24 Jan 2006 17:21:58 +0000 (17:21 +0000)]
2006-01-23  Anders Carlsson  <andersca@mac.com>

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6737
        KJS_DEFINE_PROTOTYPE should work outside of the KJS namespace

        * kjs/lookup.h:
        Prefix all KJS types with KJS:: in KJS_DEFINE_PROTOTYPE.

        (cacheGlobalObject):
        Move this out of the KJS namespace.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoTouch the wrapper so it rebuilds. We need a better solution for this.
darin [Tue, 24 Jan 2006 10:13:54 +0000 (10:13 +0000)]
Touch the wrapper so it rebuilds. We need a better solution for this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix build
mjs [Tue, 24 Jan 2006 10:02:20 +0000 (10:02 +0000)]
    - fix build

        * ksvg2/scripts/make_names.pl: Update script to generate code that
        works with the new HashMap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Tue, 24 Jan 2006 09:04:11 +0000 (09:04 +0000)]
    Reviewed by Eric.

        - fixed a storage leak found by running run-webkit-tests fast --leak

        * khtml/xml/dom_xmlimpl.cpp:
        (ProcessingInstructionImpl::checkStyleSheet): Removed bogus deref call,
        since the RefPtr handles it for us. Also deployed PassRefPtr in one place.
        (ProcessingInstructionImpl::setStyleSheet): Removed more bogus ref/deref calls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Rubber stamped by Eric.
mjs [Tue, 24 Jan 2006 07:51:20 +0000 (07:51 +0000)]
    Rubber stamped by Eric.

        - Made some functions return const AtomicString& instead of
        AtomicString because they could.

        Result of Darin's and Eric's comments on the last patch.

        * khtml/html/HTMLGenericFormElementImpl.cpp:
        (WebCore::HTMLGenericFormElementImpl::name):
        * khtml/html/HTMLGenericFormElementImpl.h:
        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::name):
        * khtml/html/HTMLInputElementImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mjs [Tue, 24 Jan 2006 07:31:21 +0000 (07:31 +0000)]
JavaScriptCore:

        Reviewed by Eric.

        - renamed PointerHash to PtrHash
        - made PtrHash the default hash function for int and pointer types that aren't further specialized
        - added an AtomicStringImpl class to make it easier and more typesafe to identity hash atomic strings
        - did appropriate consequent cleanup (very few places now need to declare a hash function)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6752

        * kjs/array_object.cpp:
        (ArrayProtoFunc::callAsFunction): no need to mention PointerHash
        * kjs/collector.cpp: ditto
        * kjs/identifier.cpp:
        (KXMLCore::): declare DefaultHash the new way
        * kjs/internal.cpp: no need to mention PointerHash
        * kjs/ustring.h:
        * kxmlcore/HashCountedSet.h: change how we get the default hash to make it
        easier to specialize on PtrHash
        * kxmlcore/HashFunctions.h:
        (KXMLCore::): renamed PointerHash to PtrHash; changed DefaultHash so that it has
        a Hash typedef rather than being a hash function class itself; declared DefaultHash
        for int and partializy specialized for pointer types
        * kxmlcore/HashMapPtrSpec.h:
        (KXMLCore::PtrHashIteratorAdapter::PtrHashIteratorAdapter): Slight tweaks for new
        way of handling pointer hash
        (KXMLCore::PtrHashConstIteratorAdapter::PtrHashConstIteratorAdapter): ditto
        (KXMLCore::): ditto
        * kxmlcore/HashMap.h: ditto
        * kxmlcore/HashSet.h: ditto

WebCore:

        Reviewed by Eric.

        - renamed PointerHash to PtrHash
        - made PtrHash the default hash function for int and pointer types that aren't further specialized
        - added an AtomicStringImpl class to make it easier and more typesafe to identity hash atomic strings
        - did appropriate consequent cleanup (very few places now need to declare a hash function)
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6752

        * bindings/objc/DOM.mm:
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge elementWithName:inForm:]):
        * css/cssstyleselector.cpp:
        (WebCore::CSSRuleSet::getIDRules):
        (WebCore::CSSRuleSet::getClassRules):
        (WebCore::CSSRuleSet::getTagRules):
        (WebCore::CSSRuleSet::addToRuleSet):
        * khtml/dom/dom_string.h:
        (KXMLCore::):
        * khtml/ecma/kjs_binding.cpp:
        (KJS::UString::UString):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::mark):
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::HTMLElement::classInfo):
        (KJS::HTMLElement::accessors):
        (KJS::HTMLElement::selectSetter):
        (KJS::HTMLElement::inputSetter):
        (KJS::HTMLElement::textAreaSetter):
        (KJS::HTMLElement::buttonSetter):
        * khtml/ecma/kjs_window.h:
        * khtml/editing/apply_style_command.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        * khtml/html/HTMLCollectionImpl.h:
        * khtml/html/HTMLElementImpl.cpp:
        (WebCore::HTMLElementImpl::isRecognizedTagName):
        (WebCore::inlineTagList):
        (WebCore::blockTagList):
        * khtml/html/HTMLFormCollectionImpl.cpp:
        (WebCore::HTMLFormCollectionImpl::updateNameCache):
        * khtml/html/HTMLGenericFormElementImpl.cpp:
        (WebCore::HTMLGenericFormElementImpl::name):
        (WebCore::HTMLGenericFormElementImpl::setName):
        * khtml/html/HTMLGenericFormElementImpl.h:
        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::name):
        * khtml/html/HTMLInputElementImpl.h:
        * khtml/html/htmlfactory.cpp:
        (DOM::HTMLElementFactory::createHTMLElement):
        * khtml/html/htmlparser.cpp:
        (HTMLParser::isHeaderTag):
        (HTMLParser::isResidualStyleTag):
        (HTMLParser::isAffectedByResidualStyle):
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::checkedRadioButtonForGroup):
        (WebCore::DocumentImpl::removeRadioButtonGroup):
        * khtml/xml/DocumentImpl.h:
        * khtml/xml/NodeImpl.h:
        * khtml/xml/dom_atomicstring.h:
        (DOM::AtomicString::AtomicString):
        (DOM::AtomicString::impl):
        (KXMLCore::):
        * khtml/xml/dom_stringimpl.cpp:
        (DOM::equal):
        * khtml/xml/dom_stringimpl.h:
        (KXMLCore::):
        * khtml/xml/xml_tokenizer.h:
        * ksvg2/misc/KSVGTimeScheduler.cpp:
        (KSVG::SVGTimer::notifyAll):
        * kwq/KWQKJobClasses.h:
        * kwq/KWQObject.cpp:
        * loader/CachedObject.h:
        * loader/CachedObjectClientWalker.h:
        * loader/loader.h:
        * page/Frame.cpp:
        (Frame::endAllLifeSupport):
        * rendering/render_canvas.cpp:
        (RenderCanvas::selectionRect):
        (RenderCanvas::setSelection):
        * rendering/render_canvas.h:
        * rendering/render_object.h:
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick.
mjs [Tue, 24 Jan 2006 06:24:11 +0000 (06:24 +0000)]
    Reviewed by Tim Omernick.

        - use classes instead of free functions for extractors, this better matches how other
        things work and should avoid the need for hacky workarounds on other compilers
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6748

        * kjs/array_object.cpp:
        * kjs/identifier.cpp:
        * kjs/internal.cpp:
        * kxmlcore/HashMap.h:
        (KXMLCore::PairFirstExtractor::extract):
        * kxmlcore/HashMapPtrSpec.h:
        (KXMLCore::):
        * kxmlcore/HashSet.h:
        (KXMLCore::IdentityExtractor::extract):
        * kxmlcore/HashTable.h:
        (KXMLCore::addIterator):
        (KXMLCore::removeIterator):
        (KXMLCore::HashTable::add):
        (KXMLCore::HashTable::isEmptyBucket):
        (KXMLCore::HashTable::isDeletedBucket):
        (KXMLCore::HashTable::HashTable):
        (KXMLCore::HashTable::lookup):
        (KXMLCore::HashTable::add):
        (KXMLCore::HashTable::reinsert):
        (KXMLCore::HashTable::find):
        (KXMLCore::HashTable::contains):
        (KXMLCore::HashTable::remove):
        (KXMLCore::HashTable::allocateTable):
        (KXMLCore::HashTable::deallocateTable):
        (KXMLCore::HashTable::expand):
        (KXMLCore::HashTable::rehash):
        (KXMLCore::HashTable::clear):
        (KXMLCore::HashTable::swap):
        (KXMLCore::HashTable::operator):
        (KXMLCore::HashTable::checkTableConsistency):
        (KXMLCore::HashTable::checkTableConsistencyExceptSize):
        (KXMLCore::HashTable::invalidateIterators):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Tue, 24 Jan 2006 04:23:28 +0000 (04:23 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6733
          REGRESSION: html input doesn't honor change to value

        * rendering/render_form.cpp: (RenderLineEdit::slotTextChanged): Made newText a
        DOMString. Assigning the empty DOMString to a QString and back to a DOMString
        resulted in a null string, which should be avoided here.

        * khtml/dom/dom_string.cpp: (DOM::DOMString::qstring): Don't turn an empty
        DOMString into a null QString; make an empty QString instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3608
darin [Tue, 24 Jan 2006 04:20:10 +0000 (04:20 +0000)]
     - fix bugzilla.opendarwin.org/show_bug.cgi?id=3608
           need script to update localizable strings file in WebKit

        * Scripts/update-webkit-localizable-strings: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fixed some small localizable strings issues
darin [Tue, 24 Jan 2006 04:18:01 +0000 (04:18 +0000)]
    - fixed some small localizable strings issues

        * WebInspector.subproj/WebInspector.m:
        (-[DOMNode _nodeTypeName]): Changed so we don't have two localizable strings that
        are both "Document". I'm not sure we want to localize the DOM inspector UI at all,
        but this fixes things for now.
        (-[DOMNode _displayName]): Ditto.

        * English.lproj/Localizable.strings: Updated.
        * English.lproj/StringsNotToBeLocalized.txt: Updated for recent changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6385
darin [Tue, 24 Jan 2006 04:08:51 +0000 (04:08 +0000)]
    - test for bugzilla.opendarwin.org/show_bug.cgi?id=6385
          REGRESSION: Unnamed frames return a generated name as window.frameElement.name

        * fast/frames/frame-element-name.html: Added.
        * fast/frames/frame-element-name-expected.txt: Added.
        * fast/frames/frame-element-name-expected.png: Added.
        * fast/frames/frame-element-name-expected.checksum: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Tue, 24 Jan 2006 04:08:40 +0000 (04:08 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6385
          REGRESSION: Unnamed frames return a generated name as window.frameElement.name

        Test: fast/frames/frame-element-name.html

        * khtml/ecma/kjs_html.cpp: (KJS::HTMLElement::getOwnPropertySlot):
        Remove the quirk where frame and iframe elements reflect all the
        properties of the window inside the frame. Testing indicates that
        no other browser does this -- not sure why we were doing it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix to workaround 4213314.
thatcher [Tue, 24 Jan 2006 01:38:59 +0000 (01:38 +0000)]
Build fix to workaround 4213314.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mjs [Tue, 24 Jan 2006 00:56:32 +0000 (00:56 +0000)]
JavaScriptCore:

        Rubber stamped by Tim Hatcher.

        - renamed inert() operation on HashSet, HashCountedSet and HashTable to add()
        for consistency with HashMap

        * kjs/array_object.cpp:
        (ArrayProtoFunc::callAsFunction):
        * kjs/collector.cpp:
        (KJS::Collector::protect):
        * kjs/identifier.cpp:
        (KJS::Identifier::add):
        * kxmlcore/HashCountedSet.h:
        (KXMLCore::::add):
        * kxmlcore/HashMap.h:
        (KXMLCore::::inlineAdd):
        * kxmlcore/HashSet.h:
        (KXMLCore::::add):
        * kxmlcore/HashTable.h:
        (KXMLCore::HashTable::add):
        (KXMLCore::::add):
        (KXMLCore::::HashTable):

WebCore:

        Rubber stamped by Tim Hatcher.

        - renamed inert() operation on HashSet, HashCountedSet and HashTable to add()
        for consistency with HashMap

        * bridge/mac/MacFrame.mm:
        (MacFrame::didTellBridgeAboutLoad):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::mark):
        * khtml/html/HTMLElementImpl.cpp:
        (WebCore::HTMLElementImpl::isRecognizedTagName):
        (WebCore::inlineTagList):
        (WebCore::blockTagList):
        * khtml/html/HTMLFormCollectionImpl.cpp:
        (WebCore::HTMLFormCollectionImpl::updateNameCache):
        * khtml/html/htmlparser.cpp:
        (HTMLParser::isHeaderTag):
        (HTMLParser::isResidualStyleTag):
        (HTMLParser::isAffectedByResidualStyle):
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::addElementById):
        (WebCore::DocumentImpl::registerDisconnectedNodeWithEventListeners):
        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::registerNodeList):
        * khtml/xml/dom_atomicstring.cpp:
        (DOM::AtomicString::add):
        * khtml/xml/dom_qname.cpp:
        (DOM::QualifiedName::QualifiedName):
        * loader/CachedObject.cpp:
        (WebCore::CachedObject::ref):
        * page/Frame.cpp:
        (Frame::keepAlive):
        * rendering/render_canvas.cpp:
        (RenderCanvas::addWidget):
        * rendering/render_frames.cpp:
        (WebCore::RenderPartObject::updateWidget):
        * rendering/render_line.cpp:
        (WebCore::InlineFlowBox::paint):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::addToRequestsByDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoBuild fix.
thatcher [Tue, 24 Jan 2006 00:25:44 +0000 (00:25 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by thatcher
justing [Tue, 24 Jan 2006 00:23:48 +0000 (00:23 +0000)]
Reviewed by thatcher
Turned on -O2 for Default and OptimizedWithSymbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix for when building in a clean sandbox and WebKit isn't built yet.
thatcher [Mon, 23 Jan 2006 23:38:57 +0000 (23:38 +0000)]
Fix for when building in a clean sandbox and WebKit isn't built yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
mjs [Mon, 23 Jan 2006 21:41:36 +0000 (21:41 +0000)]
    Reviewed by Tim Hatcher.

        - it's "Franklin Street", not "Franklin Steet"

        * kjs/array_instance.h:
        * kjs/array_object.cpp:
        * kjs/array_object.h:
        * kjs/bool_object.cpp:
        * kjs/bool_object.h:
        * kjs/collector.cpp:
        * kjs/collector.h:
        * kjs/completion.h:
        * kjs/context.h:
        * kjs/date_object.cpp:
        * kjs/date_object.h:
        * kjs/debugger.cpp:
        * kjs/debugger.h:
        * kjs/dtoa.h:
        * kjs/error_object.cpp:
        * kjs/error_object.h:
        * kjs/function.cpp:
        * kjs/function.h:
        * kjs/function_object.cpp:
        * kjs/function_object.h:
        * kjs/grammar.y:
        * kjs/identifier.cpp:
        * kjs/identifier.h:
        * kjs/internal.cpp:
        * kjs/internal.h:
        * kjs/interpreter.cpp:
        * kjs/interpreter.h:
        * kjs/lexer.cpp:
        * kjs/lexer.h:
        * kjs/list.cpp:
        * kjs/list.h:
        * kjs/lookup.cpp:
        * kjs/lookup.h:
        * kjs/math_object.cpp:
        * kjs/math_object.h:
        * kjs/nodes.cpp:
        * kjs/nodes.h:
        * kjs/nodes2string.cpp:
        * kjs/number_object.cpp:
        * kjs/number_object.h:
        * kjs/object.cpp:
        * kjs/object.h:
        * kjs/object_object.cpp:
        * kjs/object_object.h:
        * kjs/operations.cpp:
        * kjs/operations.h:
        * kjs/property_map.cpp:
        * kjs/property_map.h:
        * kjs/property_slot.cpp:
        * kjs/property_slot.h:
        * kjs/reference.cpp:
        * kjs/reference.h:
        * kjs/reference_list.cpp:
        * kjs/reference_list.h:
        * kjs/regexp.cpp:
        * kjs/regexp.h:
        * kjs/regexp_object.cpp:
        * kjs/regexp_object.h:
        * kjs/scope_chain.cpp:
        * kjs/scope_chain.h:
        * kjs/simple_number.h:
        * kjs/string_object.cpp:
        * kjs/string_object.h:
        * kjs/testkjs.cpp:
        * kjs/types.h:
        * kjs/ustring.cpp:
        * kjs/ustring.h:
        * kjs/value.cpp:
        * kjs/value.h:
        * kxmlcore/AlwaysInline.h:
        * kxmlcore/ListRefPtr.h:
        * kxmlcore/PassRefPtr.h:
        * kxmlcore/RefPtr.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - added a couple of scripts -- more about these two soon
darin [Mon, 23 Jan 2006 17:13:24 +0000 (17:13 +0000)]
    - added a couple of scripts -- more about these two soon

        * Scripts/extract-localizable-strings: Added.
        * Scripts/merge-changelog: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
darin [Mon, 23 Jan 2006 17:10:45 +0000 (17:10 +0000)]
    Reviewed by John Sullivan.

        - change needed for fix to http://bugzilla.opendarwin.org/show_bug.cgi?id=6617
          REGRESSION: Crash in cloneChildNodes when clicking element

        * kxmlcore/PassRefPtr.h: Fix assignment operator from RefPtr of a different
        type by calling get() instead of going directly at m_ptr.
        * kxmlcore/RefPtr.h: Ditto.

        - other changes

        * JavaScriptCore.xcodeproj/project.pbxproj: Xcode decided to change this file.
        It's just a resorted list of keys in a dictionary.

        * kjs/fpconst.cpp: Wrap this file in #if __APPLE__ since the alternate version
        in internal.cpp is in #if !__APPLE__. This file is to give us the "no init
        routine" property we want to have on OS X.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Suggested by Anders.
darin [Mon, 23 Jan 2006 17:10:27 +0000 (17:10 +0000)]
    Suggested by Anders.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6617
          REGRESSION: Crash in cloneChildNodes when clicking element

        * fast/dom/clone-node-form-elements-with-attr.html: Added.
        * fast/dom/clone-node-form-elements-with-attr-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
darin [Mon, 23 Jan 2006 17:07:29 +0000 (17:07 +0000)]
    Reviewed by John Sullivan.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6617
          REGRESSION: Crash in cloneChildNodes when clicking element

        Test: fast/dom/clone-node-form-elements-with-attr.html

        Changed cloneNode and some other functions to return PassRefPtr.
        Also made m_render private and changed its name to m_renderer.

        * bindings/objc/DOM.mm: (-[DOMNode cloneNode:]): Add call to get() needed
        now that cloneNode returns a PassRefPtr.

        * khtml/editing/break_blockquote_command.cpp:
        (WebCore::BreakBlockquoteCommand::doApply):
        * khtml/editing/insert_paragraph_separator_command.cpp:
        (khtml::InsertParagraphSeparatorCommand::doApply):
        * khtml/editing/split_element_command.cpp:
        (khtml::SplitElementCommand::doApply):
        * khtml/html/htmlparser.cpp:
        (HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        (HTMLParser::reopenResidualStyleTags):
        * khtml/xml/dom2_rangeimpl.cpp: (DOM::RangeImpl::processContents):
        * ksvg2/svg/SVGUseElementImpl.cpp: (SVGUseElementImpl::closeRenderer):
        Use RefPtr and PassRefPtr as appropriate, since the result of cloneNode
        is now a referenced object in a PassRefPtr rather than a floating one and
        so needs to be kept referenced until used.

        * khtml/html/HTMLElementImpl.h:
        * khtml/html/HTMLElementImpl.cpp:
        (WebCore::HTMLElementImpl::cloneNode): Changed to return a PassRefPtr.
        (WebCore::HTMLElementImpl::children): Ditto.
        * khtml/xml/DocumentFragmentImpl.h:
        * khtml/xml/DocumentFragmentImpl.cpp:
        (DOM::DocumentFragmentImpl::cloneNode): Changed to return a PassRefPtr.
        * khtml/xml/DocumentImpl.h:
        * khtml/xml/DocumentTypeImpl.h:
        * khtml/xml/DocumentTypeImpl.cpp:
        (DOM::DocumentTypeImpl::cloneNode): Changed to return a PassRefPtr.
        * khtml/xml/NamedNodeMapImpl.h:
        (WebCore::NamedNodeMapImpl::getNamedItem): Changed to return PassRefPtr.
        (WebCore::NamedNodeMapImpl::removeNamedItem): Ditto.
        (WebCore::NamedNodeMapImpl::setNamedItemNS): Ditto.

        * khtml/html/HTMLGenericFormElementImpl.cpp:
        (WebCore::HTMLGenericFormElementImpl::attach): Use renderer() instead of
        getting at m_render directly.
        (WebCore::HTMLGenericFormElementImpl::recalcStyle): Ditto.
        (WebCore::HTMLGenericFormElementImpl::isFocusable): Ditto.
        (WebCore::HTMLGenericFormElementImpl::isKeyboardFocusable): Ditto.
        (WebCore::HTMLGenericFormElementImpl::isMouseFocusable): Ditto.
        * khtml/html/HTMLInputElementImpl.cpp:
        (WebCore::HTMLInputElementImpl::selectionStart): Ditto.
        (WebCore::HTMLInputElementImpl::selectionEnd): Ditto.
        (WebCore::HTMLInputElementImpl::setSelectionStart): Ditto.
        (WebCore::HTMLInputElementImpl::setSelectionEnd): Ditto.
        (WebCore::HTMLInputElementImpl::select): Ditto.
        (WebCore::HTMLInputElementImpl::setSelectionRange): Ditto.
        (WebCore::HTMLInputElementImpl::parseMappedAttribute): Ditto.
        (WebCore::HTMLInputElementImpl::setValue): Ditto.
        (WebCore::HTMLInputElementImpl::defaultEventHandler): Ditto.
        * khtml/html/HTMLSelectElementImpl.cpp:
        (WebCore::HTMLSelectElementImpl::recalcStyle): Ditto.
        (WebCore::HTMLSelectElementImpl::setRecalcListItems): Ditto.
        (WebCore::HTMLSelectElementImpl::reset): Ditto.
        (WebCore::HTMLSelectElementImpl::notifyOptionSelected): Ditto.
        (WebCore::HTMLSelectElementImpl::defaultEventHandler): Ditto.
        * khtml/html/HTMLTextAreaElementImpl.cpp:
        (WebCore::HTMLTextAreaElementImpl::selectionStart): Ditto.
        (WebCore::HTMLTextAreaElementImpl::selectionEnd): Ditto.
        (WebCore::HTMLTextAreaElementImpl::setSelectionStart): Ditto.
        (WebCore::HTMLTextAreaElementImpl::setSelectionEnd): Ditto.
        (WebCore::HTMLTextAreaElementImpl::select): Ditto.
        (WebCore::HTMLTextAreaElementImpl::setSelectionRange): Ditto.
        (WebCore::HTMLTextAreaElementImpl::updateValue): Ditto.
        (WebCore::HTMLTextAreaElementImpl::setValue): Ditto.
        * khtml/html/html_baseimpl.cpp:
        (WebCore::HTMLFrameElementImpl::updateForNewURL): Ditto.
        (WebCore::HTMLFrameElementImpl::openURL): Ditto.
        (WebCore::HTMLFrameElementImpl::attach): Ditto.
        (WebCore::HTMLFrameElementImpl::close): Ditto.
        (WebCore::HTMLFrameElementImpl::willRemove): Ditto.
        (WebCore::HTMLFrameElementImpl::isFocusable): Ditto.
        (WebCore::HTMLFrameElementImpl::setFocus): Ditto.
        (WebCore::HTMLFrameElementImpl::frameWidth): Ditto.
        (WebCore::HTMLFrameElementImpl::frameHeight): Ditto.
        (WebCore::HTMLFrameSetElementImpl::defaultEventHandler): Ditto.
        (WebCore::HTMLFrameSetElementImpl::recalcStyle): Ditto.
        (WebCore::HTMLIFrameElementImpl::attach): Ditto.
        (WebCore::HTMLIFrameElementImpl::recalcStyle): Ditto.
        * khtml/html/html_imageimpl.cpp:
        (WebCore::HTMLImageElementImpl::parseMappedAttribute): Ditto.
        (WebCore::HTMLImageElementImpl::width): Ditto.
        (WebCore::HTMLImageElementImpl::height): Ditto.
        * khtml/html/html_inlineimpl.cpp:
        (WebCore::HTMLAnchorElementImpl::isFocusable): Ditto.
        * khtml/html/html_listimpl.cpp:
        (DOM::HTMLLIElementImpl::parseMappedAttribute): Ditto.
        (DOM::HTMLLIElementImpl::attach): Ditto.
        * khtml/html/html_objectimpl.cpp:
        (WebCore::HTMLAppletElementImpl::getAppletInstance): Ditto.
        (WebCore::HTMLAppletElementImpl::closeRenderer): Ditto.
        (WebCore::HTMLEmbedElementImpl::getEmbedInstance): Ditto.
        (WebCore::HTMLEmbedElementImpl::attach): Ditto.
        (WebCore::HTMLObjectElementImpl::getObjectInstance): Ditto.
        (WebCore::HTMLObjectElementImpl::parseMappedAttribute): Ditto.
        (WebCore::HTMLObjectElementImpl::attach): Ditto.
        (WebCore::HTMLObjectElementImpl::detach): Ditto.
        (WebCore::HTMLObjectElementImpl::recalcStyle): Ditto.
        * khtml/html/html_tableimpl.cpp:
        (WebCore::HTMLTableElementImpl::parseMappedAttribute): Ditto.
        (WebCore::HTMLTableElementImpl::attach): Ditto.
        * khtml/xml/ContainerNodeImpl.cpp:
        (WebCore::ContainerNodeImpl::getUpperLeftCorner): Ditto.
        (WebCore::ContainerNodeImpl::getLowerRightCorner): Ditto.
        (WebCore::ContainerNodeImpl::setActive): Ditto.
        (WebCore::ContainerNodeImpl::setHovered): Ditto.
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::~DocumentImpl): Ditto.
        (WebCore::DocumentImpl::elementFromPoint): Ditto.
        (WebCore::DocumentImpl::recalcStyle): Ditto.
        (WebCore::DocumentImpl::attach): Ditto.
        (WebCore::DocumentImpl::restoreRenderer): Ditto.
        (WebCore::DocumentImpl::detach): Ditto.
        (WebCore::DocumentImpl::setVisuallyOrdered): Ditto.
        (WebCore::DocumentImpl::updateSelection): Ditto.
        (WebCore::DocumentImpl::prepareMouseEvent): Ditto.
        (WebCore::DocumentImpl::cloneNode): Changed to return PassRefPtr.
        (WebCore::DocumentImpl::recalcStyleSelector): Use renderer() instead
        of getting at m_render directly.
        (WebCore::DocumentImpl::setInPageCache): Ditto.

        * khtml/xml/NodeImpl.h:
        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::NodeImpl): Changed m_render to m_renderer.
        (WebCore::NodeImpl::~NodeImpl): Changed use of m_render to renderer().
        (WebCore::NodeImpl::getRect): Ditto.
        (WebCore::NodeImpl::attach): Ditto.
        (WebCore::NodeImpl::detach): Ditto.
        (WebCore::NodeImpl::createRendererIfNeeded): Ditto.
        (WebCore::NodeImpl::getElementsByTagName): Changed to return PassRefPtr.
        (WebCore::NodeImpl::getElementsByTagNameNS): Ditto.

        * khtml/xml/dom_elementimpl.h:
        * khtml/xml/dom_elementimpl.cpp:
        (WebCore::AttrImpl::cloneNode): Changed to return PassRefPtr.
        (WebCore::ElementImpl::cloneNode): Ditto.
        (WebCore::ElementImpl::scrollIntoView): Use renderer() instead of m_render.
        (WebCore::ElementImpl::scrollIntoViewIfNeeded): Ditto.
        (WebCore::ElementImpl::recalcStyle): Ditto.
        (WebCore::ElementImpl::setAttributeNode): Changed to return PassRefPtr.
        (WebCore::ElementImpl::removeAttributeNode): Ditto.
        (WebCore::NamedAttrMapImpl::removeNamedItemNS): Ditto.
        (WebCore::NamedAttrMapImpl::setNamedItem): Ditto.
        (WebCore::NamedAttrMapImpl::removeNamedItem): Ditto.
        (DOM::ElementImpl::setAttributeNodeNS): Ditto.

        * khtml/xml/dom_textimpl.h:
        * khtml/xml/dom_textimpl.cpp:
        (CharacterDataImpl::setData): Changed use of m_render to renderer().
        (CharacterDataImpl::appendData): Ditto.
        (CharacterDataImpl::insertData): Ditto.
        (CharacterDataImpl::deleteData): Ditto.
        (CharacterDataImpl::replaceData): Ditto.
        (CommentImpl::cloneNode): Changed to return PassRefPtr.
        (TextImpl::splitText): Changed use of m_render to renderer().
        (TextImpl::cloneNode): Changed to return PassRefPtr.
        (TextImpl::recalcStyle): Changed use of m_render to renderer().
        (CDATASectionImpl::cloneNode): Changed to return PassRefPtr.

        * khtml/xml/dom_xmlimpl.h:
        * khtml/xml/dom_xmlimpl.cpp:
        (DOM::EntityImpl::cloneNode): Changed to return PassRefPtr.
        (DOM::EntityReferenceImpl::cloneNode): Ditto.
        (DOM::NotationImpl::cloneNode): Ditto.
        (DOM::ProcessingInstructionImpl::cloneNode): Ditto.

        - removed unused code

        * khtml/html/html_documentimpl.cpp: Removed unused slotHistoryChanged function.
        * khtml/html/html_documentimpl.h: Ditto.
        * kwq/KWQObject.cpp: (QObject::connect): Removed special case for
        slotHistoryChanged, no longer used.

        - fixed storage leak

        * bridge/mac/MacFrame.mm: (MacFrame::~MacFrame): Delete window widget.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago <rdar://problem/4026906> Paste of HTML table content can break table structure
harrison [Mon, 23 Jan 2006 15:30:14 +0000 (15:30 +0000)]
    <rdar://problem/4026906> Paste of HTML table content can break table structure

        * editing/pasteboard/paste-4039777-fix-expected.checksum: Added.
        * editing/pasteboard/paste-4039777-fix-expected.png: Added.
        * editing/pasteboard/paste-4039777-fix-expected.txt: Added.
        * editing/pasteboard/paste-4039777-fix.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-23 Anders Carlsson <andersca@mac.com>
andersca [Mon, 23 Jan 2006 12:00:12 +0000 (12:00 +0000)]
2006-01-23  Anders Carlsson  <andersca@mac.com>

        Forgot to add this as part of
        http://bugzilla.opendarwin.org/show_bug.cgi?id=3869

        * manual-tests/resources/webkit-background.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12311 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix layout tests
darin [Mon, 23 Jan 2006 10:14:04 +0000 (10:14 +0000)]
    - fix layout tests

        * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Added
        missing code to set wrapInAnonymousSection false in the case where
        adding a footer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd missing reviewer.
mjs [Mon, 23 Jan 2006 08:47:11 +0000 (08:47 +0000)]
Add missing reviewer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12309 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by NOBODY (OOPS!).
mjs [Mon, 23 Jan 2006 08:44:59 +0000 (08:44 +0000)]
    Reviewed by NOBODY (OOPS!).

        - Set up Page class and invert Frame / WebCoreFrameBridge ownership
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6577

        * kjs/interpreter.h: make globalExec virtual so ScriptInterpreter can
        override it

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
mjs [Mon, 23 Jan 2006 08:36:08 +0000 (08:36 +0000)]
    Reviewed by Darin.

        - Set up Page class and invert Frame / WebCoreFrameBridge ownership
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6577

        * bridge/mac/MacFrame.h:
        * bridge/mac/MacFrame.mm:
        (MacFrame::MacFrame): Initialize _bridge
        (MacFrame::~MacFrame): Clear the bridge's frame pointer and release it.
        (Frame::frameDetached): Reverse order of removing from old-style frames
        array and calling frameDetached.
        (MacFrame::createPart): Don't ref the part when creating it, since the child
        bridge is no longer going to own a ref.
        (MacFrame::setBridge): KWQRetain / KWQRelease since we know own the bridge.
        (MacFrame::detachFromView): New method; clear out the view.
        * bridge/mac/WebCoreFrameBridge.h:
        * bridge/mac/WebCoreFrameBridge.mm:
        (Bridge): Helper method to get a WebCoreFrameBridge from a Frame.
        (-[WebCoreFrameBridge firstChild]): Call through Frame.
        (-[WebCoreFrameBridge lastChild]): ditto
        (-[WebCoreFrameBridge childCount]): ditto
        (-[WebCoreFrameBridge previousSibling]): ditto
        (-[WebCoreFrameBridge nextSibling]): ditto
        (-[WebCoreFrameBridge isDescendantOfFrame:]): No need to cast parent
        pointer.
        (-[WebCoreFrameBridge appendChild:]): Call through Frame.
        (-[WebCoreFrameBridge _clearRenderPart]): New helper method to free
        the renderPart when removing a child.
        (-[WebCoreFrameBridge removeChild:]): Clear child's render part
        and call through to Frame.
        (-[WebCoreFrameBridge dealloc]): Remove unneeded m_frame-related code.
        (-[WebCoreFrameBridge finalize]): ditto
        (-[WebCoreFrameBridge clearFrame]): New helper method, needed now that
        bridge can outlive frame.
        (-[WebCoreFrameBridge handleFallbackContent]): Make safe against a null
        frame.
        (-[WebCoreFrameBridge removeFromFrame]): ditto
        * bridge/mac/WebCorePageBridge.h:
        * bridge/mac/WebCorePageBridge.mm:
        (-[WebCorePageBridge initWithMainFrame:]): Create a Page instance.
        (-[WebCorePageBridge dealloc]): Delete the Page.
        (-[WebCorePageBridge mainFrame]): Get the main frame from the Page.
        * khtml/ecma/kjs_binding.cpp:
        (KJS::ScriptInterpreter::globalExec): Override; keep frame alive, then
        call superclass.
        * khtml/ecma/kjs_binding.h:
        * khtml/ecma/kjs_proxy.cpp:
        (KJSProxyImpl::clear): Don't pass exec to window.
        (KJSProxyImpl::interpreter): Don't do keepAlive.
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::isSafeScript): If the active part's document is gone, use the frame's
        URL for security check purposes.
        (KJS::Window::clear): Don't take an ExecState parameter any more - it
        wasn't used.
        * khtml/ecma/kjs_window.h:
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::implicitOpen): If we've got a tokenizer, delete
        it before closing - you don't ever want to fire an onload handler because of
        an open.
        * page/Frame.cpp:
        (Frame::init): Pass `this' to FramePrivate constructor.
        (FrameCounter::~FrameCounter): Added debug counting of leftover
        Frame objects on exit.
        (Frame::Frame): Moved out-of-line. Increment debug counter.
        (Frame::~Frame): Assert that there is no life support going, either at the
        start or end of this method. Decrement frame counter.
        (Frame::stopLoading): tweaked for the fact that ChildFrame::m_frame is now
        a RefPtr.
        (Frame::clear): ditto
        (Frame::stop): ditto
        (Frame::stopAnimations): ditto
        (Frame::checkEmitLoadEvent): ditto
        (Frame::processObjectRequest): ditto
        (Frame::childFrame): ditto
        (Frame::findFrame): ditto
        (Frame::setZoomFactor): ditto
        (Frame::frames): ditto
        (Frame::connectChild): ditto
        (Frame::disconnectChild): ditto
        (Frame::endAllLifeSupport): Method that, in debug mode, will clear
        all life suppor timers so the Frame exit counter works.
        (Frame::keepAlive): In debug mode, add proper support for
        endAllLifeSupport
        (Frame::slotEndLifeSupport): ditto
        (Frame::setPolicyBaseURL): Update for the fact that ChildFrame::m_frame is now
        a RefPtr.
        (Frame::treeNode): New helper method, get the FrameTreeNode class that implements
        frame tree traversal.
        (Frame::nextSibling): Simple wrapper that calls through to treeNode().
        (Frame::previousSibling): ditto
        (Frame::firstChild): ditto
        (Frame::lastChild): ditto
        (Frame::childCount): ditto
        (Frame::appendChild): ditto
        (Frame::removeChild): ditto
        (Frame::detachFromView): no-op, just a virtual base for the MAcFrame method.
        * page/Frame.h:
        * page/FramePrivate.h:
        (FramePrivate::FramePrivate): Add FrameTreeNode member.
        * page/FrameTreeNode.cpp: Added.
        (FrameTreeNode::~FrameTreeNode): detach all children from their view
        (FrameTreeNode::appendChild): implemented
        (FrameTreeNode::removeChild): implemented - make sure to detach child
        from its view.
        * page/FrameTreeNode.h: Added.
        (FrameTreeNode::FrameTreeNode): New; initialize fields tht need it.
        (FrameTreeNode::nextSibling): Trivial inline.
        (FrameTreeNode::previousSibling): ditto
        (FrameTreeNode::firstChild): ditto
        (FrameTreeNode::lastChild): ditto
        (FrameTreeNode::childCount): ditto
        * page/Page.cpp: Added.
        (Page::Page): Initialize mainFrame and bump pageCount appropriately.
        (Page::~Page): Detach main frame from view, handle ending life support
        when last frame is destroyed.
        * page/Page.h: Added.
        (Page::mainFrame): Trivial inline.
        * WebCore.xcodeproj/project.pbxproj: Add new files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * Info.plist: Updated Apple copyright date. Need to update others
darin [Mon, 23 Jan 2006 07:23:34 +0000 (07:23 +0000)]
    * Info.plist: Updated Apple copyright date. Need to update others
        too at some point.

        * WebCore-svg.exp: Removed unused empty file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej and Darin.
staikos [Mon, 23 Jan 2006 07:20:50 +0000 (07:20 +0000)]
    Reviewed by Maciej and Darin.

        * kxmlcore/Assertions.h: This file only works with __APPLE__ right now
        * kjs/interpreter.cpp: ditto
        * kjs/simple_number.h: Add assert.h and remove from config.h
        * kjs/array_object.cpp: Use relative paths for kxmlcore includes
        * kjs/testkjs.cpp: Use relative paths for kxmlcore includes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRubber stamp from Maciej:
staikos [Mon, 23 Jan 2006 07:01:37 +0000 (07:01 +0000)]
Rubber stamp from Maciej:
 - Assertions is only valid in __APPLE__ right now

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-22 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 23 Jan 2006 07:00:03 +0000 (07:00 +0000)]
2006-01-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Make <animateColor> work again (broke during DOM merger).
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5964

        * WebCore.xcodeproj/project.pbxproj:
        * kcanvas/device/quartz/KCanvasItemQuartz.h:
        * kcanvas/device/quartz/KCanvasItemQuartz.mm:
        (KCanvasItemQuartz::getAbsoluteRepaintRect): moved to .cpp file
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::implicitClose): start svg animations
        (WebCore::DocumentImpl::svgExtensions): svg document extensions
        (WebCore::DocumentImpl::accessSVGExtensions): svg doc extensions
        * khtml/xml/DocumentImpl.h:
        * ksvg2/css/SVGCSSStyleSelector.cpp:
        (KDOM::CSSStyleSelector::applySVGProperty):
        * ksvg2/svg/SVGAElementImpl.cpp:
        (SVGAElementImpl::defaultEventHandler): cleanup
        * ksvg2/svg/SVGAnimateColorElementImpl.cpp:
        (SVGAnimateColorElementImpl::handleTimerEvent): update css lookup
        * ksvg2/svg/SVGAnimateElementImpl.cpp:
        (SVGAnimateElementImpl::handleTimerEvent): fix css property lookup
        * ksvg2/svg/SVGAnimateTransformElementImpl.cpp:
        (SVGAnimateTransformElementImpl::handleTimerEvent):
        * ksvg2/svg/SVGAnimationElementImpl.cpp:
        (SVGAnimationElementImpl::closeRenderer): use doc extensions
        (SVGAnimationElementImpl::targetAttribute): fix css properties
        (SVGAnimationElementImpl::setTargetAttribute): fix css properties
        * ksvg2/svg/SVGDocumentImpl.cpp:
        (SVGDocumentImpl::svgView): remove unnecessary static cast
        (SVGDocumentImpl::executeScripts):
        * ksvg2/svg/SVGDocumentImpl.h:
        * ksvg2/svg/SVGElementImpl.cpp:
        (WebCore::SVGElementImpl::addSVGEventListener): helper function
        (WebCore::SVGElementImpl::parseMappedAttribute): use helper
        * ksvg2/svg/SVGElementImpl.h:
        * ksvg2/svg/SVGGElementImpl.cpp:
        * ksvg2/svg/SVGGElementImpl.h:
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        (WebCore::SVGSVGElementImpl::SVGSVGElementImpl):
        (WebCore::SVGSVGElementImpl::~SVGSVGElementImpl):
        (WebCore::SVGSVGElementImpl::addSVGWindowEventListner): helper
        (WebCore::SVGSVGElementImpl::parseMappedAttribute): use helper
        * ksvg2/svg/SVGSVGElementImpl.h:
        * ksvg2/svg/SVGSetElementImpl.cpp:
        (SVGSetElementImpl::handleTimerEvent): use doc extensions
        * ksvg2/svg/SVGStyledElementImpl.h:
        * page/Frame.cpp:
        (Frame::pauseTimeouts): pause svg animation
        (Frame::resumeTimeouts): resume svg animation
        * rendering/render_canvas.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agounbreak preprocessor change
staikos [Mon, 23 Jan 2006 06:55:03 +0000 (06:55 +0000)]
unbreak preprocessor change
Reviewed by Maciej

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Approved by Maciej and Darin.
staikos [Mon, 23 Jan 2006 06:10:54 +0000 (06:10 +0000)]
    Approved by Maciej and Darin.

        * kjs/:
        * kxmlcore/:
             Update FSF address in license to make merging easier

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej and Darin.
staikos [Mon, 23 Jan 2006 05:44:33 +0000 (05:44 +0000)]
    Reviewed by Maciej and Darin.

        * kjs/collector.cpp: merge major speedup from KDE on Linux
                             patch by Maks Orlovich, bug #6145
                             Also unify cpu detection
        * kjs/config.h: define simpler CPU macros

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - fix deployment builds
darin [Mon, 23 Jan 2006 05:43:02 +0000 (05:43 +0000)]
    - fix deployment builds

        * rendering/RenderTable.cpp: (WebCore::RenderTable::addChild): Init bool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Mon, 23 Jan 2006 05:29:14 +0000 (05:29 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5731
          Form element as display table-cell hangs Safari (will eventually crash)

        * fast/table/form-with-table-style.html: Added.
        * fast/table/form-with-table-style-expected.txt: Added.
        * fast/table/form-with-table-style-expected.png: Added.
        * fast/table/form-with-table-style-expected.checksum: Added.

WebCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5731
          Form element as display table-cell hangs Safari (will eventually crash)

        Test: fast/table/form-with-table-style.html

        Hang was caused by the fact that RenderContainer has code to wrap table
        styled elements in appropriate anonymous table elements, but the table
        elements themselves have a special case for form elements that causes them
        to call through, which led to infinite recursion as RenderContainer kept
        making new tables which kept calling through to RenderContainer::addChild.

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild): Improved logic about wrapping children
        in anonymous table sections in the following ways: (1) Do wrap a form
        properly it has a table display style (such as table-cell or table-row).
        (2) When an item has a particular display style, check that it has the
        right type of render object before casting it to that type. Also
        restructured the code a little to make it slightly more readable.
        (WebCore::RenderTable::layout): Added a FIXME about forms that have a
        display style that makes it a table section, since they will be skipped
        here in the loop to lay children out.
        (WebCore::RenderTable::recalcSections): Added checks similar to the ones
        in addChild above.

        * rendering/RenderTableSection.cpp: (WebCore::RenderTableSection::addChild):
        Moved form tag logic inside render object type check so that a table row
        that happens to be a form element won't be affected by the special form
        tag logic. Also added an explicit check for the table-cell style so we
        will wrap it in a row rather than just putting the form at this level.

        * rendering/RenderTableRow.h: Removed removeChildNode and dump functions
        that just called through to the base class.
        * rendering/RenderTableRow.cpp: (WebCore::RenderTableRow::addChild):
        Moved form tag logic inside render object type check so that a table cell
        that happens to be a form element won't be affected by the special form
        tag logic. Removed unnecessary null check of section() at end of function.

        * rendering/RenderTableCol.h: Removed addChild because all it did was
        assert (incorrectly) and then call through to the base class. Changed
        _span to be m_span.
        * rendering/RenderTableCol.cpp: Removed addChild function. Updated for
        change in name of m_span field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Mon, 23 Jan 2006 05:07:33 +0000 (05:07 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3518
          REGRESSION (312-412): mojibake left behind when scrolling a clipped <select>

        * kwq/KWQListBox.mm: (QListBox::QListBox): Call setCopiesOnScroll:NO.
        * kwq/KWQTextArea.mm: (-[KWQTextArea initWithFrame:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Maciej
staikos [Mon, 23 Jan 2006 04:39:36 +0000 (04:39 +0000)]
Reviewed by Maciej
Compile fix for FreeBSD 5.4 from KDE

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdded a few Radar bug numbers for future searching purposes.
darin [Mon, 23 Jan 2006 02:53:16 +0000 (02:53 +0000)]
Added a few Radar bug numbers for future searching purposes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Mon, 23 Jan 2006 02:47:57 +0000 (02:47 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5656
        REGRESSION: Buttons on Yahoo! Mail misplaced in ToT
        <rdar://problem/4404335>
        Tests whether white-space mode on buttons is inherited and not forced.

        * fast/forms/button-white-space-expected.checksum: Added.
        * fast/forms/button-white-space-expected.png: Added.
        * fast/forms/button-white-space-expected.txt: Added.
        * fast/forms/button-white-space.html: Added.

WebCore:

        Reviewed by Maciej.

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=5656
        REGRESSION: Buttons on Yahoo! Mail misplaced in ToT
        <rdar://problem/4404335>
        Tests whether white-space mode on buttons is inheritied and not forced.
        Originally broken in Subversion revision r10909.

        * css/html4.css: Remove default white-space value for <button> tag to
        allow it to be inherited.
        * rendering/render_theme_mac.mm:
        (khtml::RenderThemeMac::adjustButtonStyle): Fix misleading comment.

        * css/UserAgentStyleSheets.cpp: Touched this file to make the rebuild
        of html4.css work (shouldn't have to do this).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * css/make-css-file-arrays.pl: Fix typo that was resulting in a bunch
darin [Mon, 23 Jan 2006 02:35:47 +0000 (02:35 +0000)]
    * css/make-css-file-arrays.pl: Fix typo that was resulting in a bunch
        of whitespace that was supposed to go into a derived source file going
        to the console instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-22 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 22 Jan 2006 23:53:02 +0000 (23:53 +0000)]
2006-01-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        SVG needs to support "evt" instead of "event" in event handlers.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=5874

        * WebCore.xcodeproj/project.pbxproj: added new classes
        * khtml/ecma/kjs_events.cpp:
        * khtml/ecma/kjs_events.h:
        * khtml/ecma/kjs_proxy.cpp:
        (WebCore::KJSProxyImpl::createHTMLEventHandler): simplified
        (WebCore::KJSProxyImpl::createSVGEventHandler): new
        * khtml/ecma/kjs_proxy.h:
        * khtml/ecma/kjs_window.cpp:
        * khtml/ecma/kjs_window.h:
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::createHTMLEventListener): simplified
        (WebCore::DocumentImpl::createSVGEventListener): new
        * khtml/xml/DocumentImpl.h:
        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::dispatchEvent): use RefPtr
        * ksvg2/events/JSSVGLazyEventListener.cpp: Added.
        (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): added.
        (WebCore::JSSVGLazyEventListener::eventParameterName): added.
        * ksvg2/events/JSSVGLazyEventListener.h: Added.
        * ksvg2/svg/SVGElementImpl.cpp:
        (SVGElementImpl::parseMappedAttribute): use new SVG event handler
        * ksvg2/svg/SVGSVGElementImpl.cpp:
        (SVGSVGElementImpl::parseMappedAttribute): use new SVG event handler
        * page/Frame.cpp: updated KJSProxyImpl namespace
        * page/Frame.h: updated KJSProxyImpl namespace
        * page/FramePrivate.h: updated KJSProxyImpl namespace

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders Carlsson.
thatcher [Sun, 22 Jan 2006 22:57:46 +0000 (22:57 +0000)]
    Reviewed by Anders Carlsson.

        Makes the Inspector's Style pane take !important into account
        when marking overloaded properties.

        * WebInspector.subproj/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Sun, 22 Jan 2006 22:32:35 +0000 (22:32 +0000)]
LayoutTests:

        Reviewed by Maciej.

        - tests for http://bugzilla.opendarwin.org/show_bug.cgi?id=3508
          REGRESSION (125-412): problem with negative margin-top and position: absolute (vre.aitg.com)

        * fast/css/position-negative-top-margin.html: Added.
        * fast/css/position-negative-top-margin-expected.txt: Added.
        * fast/css/position-negative-top-margin-expected.png: Added.
        * fast/css/position-negative-top-margin-expected.checksum: Added.

        * fast/box-sizing/box-sizing-expected.txt: Updated, since absolute position box locations changed.
        * fast/box-sizing/box-sizing-expected.png: Ditto.
        * fast/box-sizing/box-sizing-expected.checksum: Ditto.

        - changed a few suitable tests to dump as text (in part to fix a failing pixel test in one)

        * fast/parser/entity-surrogate-pairs.html: Added a call to dumpAsText().
        * fast/parser/entity-surrogate-pairs-expected.txt: Now a plain text file instead of a render tree.
        * fast/parser/entity-surrogate-pairs-expected.png: Removed.
        * fast/parser/entity-surrogate-pairs-expected.checksum: Removed.

        * fast/parser/head-comment.html Added a call to dumpAsText().
        * fast/parser/head-comment-expected.txt: Now a plain text file instead of a render tree.
        * fast/parser/head-comment-expected.png: Removed.
        * fast/parser/head-comment-expected.checksum: Removed.

WebCore:

       Reviewed by Maciej.

       - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3508
         REGRESSION (125-412): problem with negative margin-top and position: absolute (vre.aitg.com)

       Test: fast/css/position-negative-top-margin.html

       * rendering/RenderBlock.cpp: (WebCore::RenderBlock::adjustPositionedBlock):
       Fixed two different problems that contributed to the bug: (1) Added a call to calcVerticalMargins
       otherwise the margin will always be 0. (2) Corrected logic for the negative margin case, which
       was comparing a negative margin-top to a number representing the absolute value of the margin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoMaciej mentioned he reviewed the change George just landed, so updating the log to...
darin [Sun, 22 Jan 2006 21:27:01 +0000 (21:27 +0000)]
Maciej mentioned he reviewed the change George just landed, so updating the log to reflect that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Sun, 22 Jan 2006 20:32:36 +0000 (20:32 +0000)]
    Reviewed by Darin.

       - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3702
         Web page is laid out incorrectly after printing with print-specific style sheet.

        Also replaced tabs with spaces in the changed files.

        Test cases:
        * fast/table/append-cells.html
        * fast/table/append-cells2.html
        * fast/table/remove-td-display-none.html

        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::recalcSections): Shrink columns and columnPos to the
          actual number of columns.

        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::numColumns): New function.
        (WebCore::RenderTableSection::dump): Use gridRows instead of grid.size() for row count,
          preventing crashes.

        * rendering/RenderTableSection.h: Added numColumns() and a comment about cCol/cRow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders.
darin [Sun, 22 Jan 2006 20:20:45 +0000 (20:20 +0000)]
    Reviewed by Anders.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6705
          use PassRefPtr in more of the basic DOM operations

        Once we do the same with cloneNode, I believe we'll fix one of our P1 bugs,
        but cloneNode was a little too much to do without doing this first pass.

        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::childNodes): Updated for parameter changes.
        (WebCore::NodeImpl::insertBefore): Ditto.
        (WebCore::NodeImpl::replaceChild): Ditto.
        (WebCore::NodeImpl::removeChild): Ditto.
        (WebCore::NodeImpl::appendChild): Ditto.
        (WebCore::NodeImpl::addChild): Ditto.
        (WebCore::NodeImpl::addEventListener): Ditto.
        (WebCore::NodeImpl::setHTMLEventListener): Ditto.
        (WebCore::NodeImpl::isDefaultNamespace): Updated for changed name of ancestorElement.
        (WebCore::NodeImpl::lookupPrefix): Ditto.
        (WebCore::NodeImpl::lookupNamespaceURI): Ditto.
        (WebCore::NodeImpl::lookupNamespacePrefix): Ditto.
        (WebCore::NodeImpl::ancestorElement): Changed name from getAncestorElement.
        * khtml/xml/NodeImpl.h: Changed most functions where it makes sense to take and return
        PassRefPtr instead of raw pointers. Even non-obvious cases like appendChild, where the
        return value has to be PassRefPtr only because it might be removed when the JavaScript
        triggered by the DOM mutation event runs (normally, there's no need to return an "owning"
        pointer because the tree now owns the newly-inserted node). Made the ancestorElement
        function private.

        * khtml/xml/ContainerNodeImpl.cpp:
        (WebCore::ContainerNodeImpl::ContainerNodeImpl): Updated for changes from
        _first to m_firstChild and _last to m_lastChild.
        (WebCore::ContainerNodeImpl::removeAllChildren): Ditto.
        (WebCore::ContainerNodeImpl::firstChild): Ditto.
        (WebCore::ContainerNodeImpl::lastChild): Ditto.
        (WebCore::ContainerNodeImpl::insertBefore): Updated for parameter changes.
        (WebCore::ContainerNodeImpl::replaceChild): Ditto.
        (WebCore::ContainerNodeImpl::willRemove): Updated for m_lastChild.
        (WebCore::ContainerNodeImpl::removeChild): Updated for parameter changes.
        (WebCore::ContainerNodeImpl::removeChildren): Updated for m_first/lastChild.
        (WebCore::ContainerNodeImpl::appendChild): Updated for parameter changes.
        (WebCore::ContainerNodeImpl::hasChildNodes): Updated for m_firstChild.
        (WebCore::ContainerNodeImpl::addChild): Updated for parameter changes.
        (WebCore::ContainerNodeImpl::attach): Updated for m_firstChild.
        (WebCore::ContainerNodeImpl::detach): Ditto.
        (WebCore::ContainerNodeImpl::insertedIntoDocument): Ditto.
        (WebCore::ContainerNodeImpl::removedFromDocument): Ditto.
        (WebCore::ContainerNodeImpl::insertedIntoTree): Ditto.
        (WebCore::ContainerNodeImpl::removedFromTree): Ditto.
        * khtml/xml/ContainerNodeImpl.h: Removed unused checkSameDocument and checkIsChild.
        Made more things private, updated parameters for NodeImpl functions.

        * khtml/html/HTMLSelectElementImpl.cpp:
        (DOM::HTMLSelectElementImpl::insertBefore): Ditto.
        (DOM::HTMLSelectElementImpl::replaceChild): Ditto.
        (DOM::HTMLSelectElementImpl::removeChild): Ditto.
        (DOM::HTMLSelectElementImpl::appendChild): Ditto.
        (DOM::HTMLSelectElementImpl::addChild): Ditto.
        * khtml/html/HTMLSelectElementImpl.h: Ditto.

        * khtml/html/HTMLOptGroupElementImpl.cpp:
        (WebCore::HTMLOptGroupElementImpl::insertBefore): Updated for parameter type change.
        Also changed to look at return value, not exception code, to check for success.
        (WebCore::HTMLOptGroupElementImpl::replaceChild): Ditto.
        (WebCore::HTMLOptGroupElementImpl::removeChild): Ditto.
        (WebCore::HTMLOptGroupElementImpl::appendChild): Ditto.
        (WebCore::HTMLOptGroupElementImpl::addChild): Ditto.
        * khtml/html/HTMLOptGroupElementImpl.h: Ditto.

        * WebCore+SVG/kdom.h: Renamed enum from ExceptionCode to ExceptionCodes
        to avoid conflict with a typedef ExceptionCode I added.

        * bindings/objc/DOM.mm:
        (-[DOMNode insertBefore::]): Added get() call since return value is a PassRefPtr.
        (-[DOMNode replaceChild::]): Ditto.
        (-[DOMNode removeChild:]): Ditto.
        (-[DOMNode appendChild:]): Ditto.

        * khtml/ecma/kjs_dom.h: Changed getDOMNode to take PassRefPtr.
        * khtml/ecma/kjs_dom.cpp: (KJS::getDOMNode): Changed to take PassRefPtr.

        * khtml/html/HTMLElementImpl.cpp: Added dom2_events.h include, now needed.
        Re-sorted includes.
        * ksvg2/svg/SVGElementImpl.cpp: Ditto.

        * khtml/html/html_documentimpl.cpp: (WebCore::HTMLDocumentImpl::documentElement):
        Changed access to now-private data member _first to equivalent inline function
        fastFirstChild().
        * khtml/xml/DocumentImpl.cpp: (WebCore::DocumentImpl::recalcStyle): Ditto.
        * khtml/xml/dom_elementimpl.cpp: (WebCore::ElementImpl::recalcStyle): Ditto.

        * khtml/html/html_tableimpl.cpp:
        (WebCore::HTMLTableElementImpl::setCaption): Updated to work with new replaceChild
        that returns PassRefPtr.
        (WebCore::HTMLTableElementImpl::setTHead): Ditto.
        (WebCore::HTMLTableElementImpl::setTFoot): Ditto.
        (WebCore::HTMLTableElementImpl::setTBody): Ditto.
        (WebCore::HTMLTableElementImpl::addChild): Updated for parameter type change.
        (WebCore::HTMLTableSectionElementImpl::addChild): Ditto.
        (WebCore::HTMLTableRowElementImpl::addChild): Ditto.
        * khtml/html/html_tableimpl.h: Ditto.

        * khtml/html/htmlparser.cpp: (HTMLParser::handleResidualStyleCloseTagAcrossBlocks):
        Removed an unneeded explicit call to removeChild. appendChild already takes care of
        removing the child from its own location. This avoids the fact that removeChild was
        removing the parent, the only thing keeping the node alive. This is sort of the
        "flip side" of our removeChild leaks -- code that depended on the behavior that
        caused the leaks.

        * khtml/xml/xml_tokenizer.cpp: (WebCore::XMLTokenizer::startElementNs):
        Removed unneeded isHTMLElement() calls from before the "qualified name" change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoSomehow this file didn't get checked in before (even though it was
darin [Sun, 22 Jan 2006 19:22:19 +0000 (19:22 +0000)]
Somehow this file didn't get checked in before (even though it was
mentioned in the change log).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix by Mark Rowe . Reviewed by Anders.
ap [Sun, 22 Jan 2006 19:18:27 +0000 (19:18 +0000)]
    Fix by Mark Rowe . Reviewed by Anders.

        Build fix.  build-webkit dies with "invalid build action: (empty string)"

        * Scripts/build-webkit:
        Use svgOptions in an array context so xcodebuild doesn't choke on an empty argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-22 Eric Seidel <eseidel@apple.com>
eseidel [Sun, 22 Jan 2006 14:41:30 +0000 (14:41 +0000)]
2006-01-22  Eric Seidel  <eseidel@apple.com>

        Reviewed by anders.

        Fix --no-svg option to use XCode flags instead of gcc flags.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-22 Eric Seidel <eseidel@apple.com
eseidel [Sun, 22 Jan 2006 14:08:24 +0000 (14:08 +0000)]
2006-01-22  Eric Seidel  <eseidel@apple.com

        Rubber-stamped by anders.

        Remove WebCore-no-SVG target and wrap files in #if SVG_SUPPORT
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6633

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ap [Sun, 22 Jan 2006 10:49:27 +0000 (10:49 +0000)]
    Reviewed by Maciej.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=6642
          Split XMLHttpRequest class into JS binding and implementation

        * WebCore.xcodeproj/project.pbxproj: Adjusted for moved and renamed files.
        New group "xml" to match directory structure.
        * xml: Added.
        * khtml/ecma/JSXMLHttpRequest.cpp: Added.
        * khtml/ecma/JSXMLHttpRequest.h: Added.
        * khtml/ecma/xmlhttprequest.cpp: Removed.
        * khtml/ecma/xmlhttprequest.h: Removed.
        * xml/xmlhttprequest.cpp: Added.
        * xml/xmlhttprequest.h: Added.
        * khtml/ecma/kjs_binding.cpp:
        (KJS::jsStringOrUndefined): Moved from kjs_events.cpp.
        * khtml/ecma/kjs_binding.h: Added prototype for jsStringOrUndefined().
        * khtml/ecma/kjs_events.cpp: Removed jsStringOrUndefined().
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::getValueProperty): Use new class name for JSXMLHttpRequest.
        * kwq/KWQSlot.cpp: XMLHttpRequestQObject is now in WebCore, not KJS.
        * page/Frame.cpp:
        (Frame::stopLoading): XMLHttpRequest is now in WebCore, not KJS.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-22 Alexander Kellett <lypanov@kde.org>
eseidel [Sun, 22 Jan 2006 09:57:32 +0000 (09:57 +0000)]
2006-01-22  Alexander Kellett  <lypanov@kde.org>

        Reviewed by eseidel.

        Add support for custom fill/strokes on text.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6448

        * kcanvas/RenderSVGText.cpp:
        (RenderSVGText::paint): use new painter setup/teardown infrastructure
        * kcanvas/device/KRenderingPaintServer.h:
        (KRenderingPaintServer::KRenderingPaintServer):
        (KRenderingPaintServer::setup):
        (KRenderingPaintServer::render):
        (KRenderingPaintServer::teardown):
        (KRenderingPaintServer::isPaintingText):
        (KRenderingPaintServer::setPaintingText):
        * kcanvas/device/quartz/KRenderingPaintServerGradientQuartz.mm:
        (setupShadingWithStyle):
        (renderShadingWithStyle):
        (teardownShadingWithStyle):
        (KRenderingPaintServerLinearGradientQuartz::draw):
        (KRenderingPaintServerLinearGradientQuartz::setup):
        (KRenderingPaintServerLinearGradientQuartz::render):
        (KRenderingPaintServerLinearGradientQuartz::teardown):
        (KRenderingPaintServerRadialGradientQuartz::draw):
        (KRenderingPaintServerRadialGradientQuartz::setup):
        (KRenderingPaintServerRadialGradientQuartz::render):
        (KRenderingPaintServerRadialGradientQuartz::teardown):
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.h:
        (KRenderingPaintServerPatternQuartz::KRenderingPaintServerPatternQuartz):
        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (KRenderingPaintServerQuartzHelper::strokePath):
        (KRenderingPaintServerQuartzHelper::clipToStrokePath):
        (KRenderingPaintServerQuartzHelper::fillPath):
        (KRenderingPaintServerQuartzHelper::clipToFillPath):
        (KRenderingPaintServerSolidQuartz::draw):
        (KRenderingPaintServerSolidQuartz::setup):
        (KRenderingPaintServerSolidQuartz::render):
        (KRenderingPaintServerSolidQuartz::teardown):
        (KRenderingPaintServerPatternQuartz::draw):
        (KRenderingPaintServerPatternQuartz::setup):
        (KRenderingPaintServerPatternQuartz::render):
        (KRenderingPaintServerPatternQuartz::teardown):
        * kcanvas/device/quartz/QuartzSupport.h: fix prototype
        * kcanvas/device/quartz/QuartzSupport.mm:
        (applyStrokeStyleToContext):
        * ksvg2/misc/KCanvasRenderingStyle.cpp:
        (KSVGPainterFactory::fillPaintServer):
        (KSVGPainterFactory::strokePaintServer):
        (KSVGPainterFactory::cssPrimitiveToLength):
        (KSVGPainterFactory::strokePainter):
        (KSVGPainterFactory::fillPainter):
        * ksvg2/misc/KCanvasRenderingStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoReviewed by Maciej
staikos [Sun, 22 Jan 2006 06:20:06 +0000 (06:20 +0000)]
Reviewed by Maciej

Merge some build fixes for various Perl and gcc versions from KDE SVN.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Sun, 22 Jan 2006 04:28:19 +0000 (04:28 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=3509
          REGRESSION(125-412) Portion of nested table is not painted correctly on cafepress site

        * manual-tests/bugzilla-3509.html: Added.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::layoutBlockChildren): Force repaint if the child didn't move but
        didn't repaint correctly during layout because it was not at its final position then.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Anders Carlsson.
thatcher [Sun, 22 Jan 2006 00:25:48 +0000 (00:25 +0000)]
    Reviewed by Anders Carlsson.

        Make sure shorthand properties get striked-out if
        all the properties they expand into are overloaded.

        * WebInspector.subproj/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-20 David Kilzer <ddkilzer@kilzer.net>
eseidel [Sat, 21 Jan 2006 22:11:40 +0000 (22:11 +0000)]
2006-01-20  David Kilzer  <ddkilzer@kilzer.net>

        Reviewed by eseidel.

        - fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6682
        Call to checkWebCoreSVGSupport() broken in build-drawtest and run-drawtest

        * Scripts/build-drawtest: Changed bareword 'true' to 1.
        * Scripts/run-drawtest: Changed bareword 'true' to 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-21 Anders Carlsson <andersca@mac.com>
andersca [Sat, 21 Jan 2006 21:58:03 +0000 (21:58 +0000)]
2006-01-21  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=3869
        Should use HTML Image element instead of JS Image object

        * khtml/ecma/kjs_events.cpp:
        (KJS::ClipboardProtoFunc::callAsFunction):
        Don't check Image object. Instead, if the element passed in
        is an image element which isn't in any document, use its pixmap.

        * khtml/ecma/kjs_html.cpp:
        (KJS::HTMLElement::imageGetter):
        Add complete.

        (KJS::ImageConstructorImp::construct):
        Take a QPixmap instead of an Image.

        (KJS::KJS::Context2DFunction::callAsFunction):
        Remove usage of Image and use HTMLImageElementImpl instead.

        * khtml/ecma/kjs_html.h:
        Remove Image class.

        (KJS::HTMLElement::):
        Add ImgComplete.

        * khtml/html/html_imageimpl.cpp:
        (WebCore::HTMLImageElementImpl::width):
        (WebCore::HTMLImageElementImpl::height):
        If the element has no renderer but its image size is known
        return that instead.

        (WebCore::HTMLImageElementImpl::complete):
        New function, returns true if an image has finished loading.

        * khtml/html/html_imageimpl.h:
        Add complete.

        * manual-tests/drag-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-21 Anders Carlsson <andersca@mac.com>
andersca [Sat, 21 Jan 2006 21:20:31 +0000 (21:20 +0000)]
2006-01-21  Anders Carlsson  <andersca@mac.com>

        * editing/editing.js:
        Fix typo which made editing test cases fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-21 Anders Carlsson <andersca@mac.com>
andersca [Sat, 21 Jan 2006 20:15:17 +0000 (20:15 +0000)]
2006-01-21  Anders Carlsson  <andersca@mac.com>

        Reviewed by Darin.

        - fixes http://bugzilla.opendarwin.org/show_bug.cgi?id=6691
        TinyMCE: strikethrough unimplemented

        * khtml/editing/jsediting.cpp:
        Add support for the "Strikethrough" command.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Sat, 21 Jan 2006 20:02:37 +0000 (20:02 +0000)]
LayoutTests:

        Reviewed by Darin.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=5983
          REGRESSION: onmouseover-powered navbar at MacNN renders incorrectly

        * fast/dynamic/hovered-detach.html: Added.
        * fast/dynamic/hovered-detach-expected.txt: Added.

WebCore:

        Test: fast/dynamic/hovered-detach.html

        Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=5983
          REGRESSION: onmouseover-powered navbar at MacNN renders incorrectly

        * khtml/xml/NodeImpl.cpp:
        (WebCore::NodeImpl::detach): Set m_hovered to false and set the document's
        hoverNode to an hovered ancestor that still has a renderer.
        * rendering/render_layer.cpp: Changed static method hoverAncestor() into a
        RenderObject instance method.
        (WebCore::commonAncestor):
        (WebCore::RenderLayer::updateHoverActiveState):
        * rendering/render_object.cpp: Ditto.
        (WebCore::RenderObject::hoverAncestor)
        * rendering/render_object.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Sat, 21 Jan 2006 19:22:21 +0000 (19:22 +0000)]
    Reviewed by Darin.

        Adds computed style to the Web Inspector.
        Adds a "mapped style" link to the mapped attributes.

        * WebInspector.subproj/webInspector/inspector.css:
        * WebInspector.subproj/webInspector/inspector.html:
        * WebInspector.subproj/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Fix for bug 6666, pseudo-element rules incorrectly displayed
hyatt [Sat, 21 Jan 2006 03:47:52 +0000 (03:47 +0000)]
    Fix for bug 6666, pseudo-element rules incorrectly displayed
        in Web Inspector.

        Reviewed by darin

        Added fast/inspector/matchedrules.html as test case.

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::matchRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd a test case for Web Inspector style matching bug.
hyatt [Sat, 21 Jan 2006 03:45:31 +0000 (03:45 +0000)]
Add a test case for Web Inspector style matching bug.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
thatcher [Sat, 21 Jan 2006 03:05:26 +0000 (03:05 +0000)]
WebCore:

        Reviewed by John.

        Removes code that is no longer needed with the new Web Inspector.

        * bridge/mac/WebCoreFrameBridge.h: removes the WebCoreDOMTreeCopier protocol.
        * bridge/mac/WebCoreFrameBridge.mm: removes copyDOMNode:copier:

WebKit:

        Reviewed by John, some parts by Darin.

        Removes the old WebDebugDOMNode code, superseded by the ObjC DOM and the Web Inspector.
        Since Safari 2.0 still relies on these classes for the Debug menu's "Show DOM Tree", we remove
        that menu item to prevent a crash.

        * WebKit.exp: adds WebInspector, removes WebDebugDOMNode
        * WebKit.xcodeproj/project.pbxproj: added the REMOVE_SAFARI_DOM_TREE_DEBUG_ITEM define so the new WebView code doesn't build in the Default config
        * WebView.subproj/WebDebugDOMNode.h: Removed.
        * WebView.subproj/WebDebugDOMNode.m: Removed.
        * WebView.subproj/WebView.m:
        (+[WebView initialize]): check if we are in Safari and IncludeDebugMenu is true then observe for NSApplicationDidFinishLaunchingNotification and call _finishedLaunching
        (+[WebView _finishedLaunching]): observe for NSMenuDidAddItemNotification now that the main menu is loaded and wait for the Debug menu to be added
        (+[WebView _removeDOMTreeMenuItem:]): when the debug menu is added remove the "Show DOM Tree" item

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-21 Anders Carlsson <andersca@mac.com>
andersca [Sat, 21 Jan 2006 01:03:42 +0000 (01:03 +0000)]
2006-01-21  Anders Carlsson  <andersca@mac.com>

        Reviewed by David Hyatt.

        Rename Frame::xmlDocImpl => Frame::document and
        Frame::replaceDocImpl => Frame::setDocument

        * bridge/mac/MacFrame.mm:
        (MacFrame::findString):
        (MacFrame::advanceToNextMisspelling):
        (MacFrame::nextKeyViewInFrame):
        (MacFrame::nextKeyViewInFrameHierarchy):
        (MacFrame::keyEvent):
        (MacFrame::dispatchCPPEvent):
        (MacFrame::setDisplaysWithFocusAttributes):
        (MacFrame::bodyBackgroundColor):
        (MacFrame::markMisspellings):
        (MacFrame::respondToChangedSelection):
        (MacFrame::setMarkedTextRange):
        (MacFrame::dashboardRegionsDictionary):
        (MacFrame::shouldClose):
        * bridge/mac/WebCoreFrameBridge.mm:
        (updateRenderingForBindings):
        (frameHasSelection):
        (-[WebCoreFrameBridge addData:]):
        (-[WebCoreFrameBridge didNotOpenURL:pageCache:]):
        (-[WebCoreFrameBridge saveDocumentState]):
        (-[WebCoreFrameBridge restoreDocumentState]):
        (-[WebCoreFrameBridge saveDocumentToPageCache]):
        (-[WebCoreFrameBridge _documentTypeString]):
        (-[WebCoreFrameBridge deselectAll]):
        (-[WebCoreFrameBridge reapplyStylesForDeviceType:]):
        (nowPrinting):
        (-[WebCoreFrameBridge _setupRootForPrinting:]):
        (-[WebCoreFrameBridge computePageRectsWithPrintWidthScaleFactor:printHeight:]):
        (-[WebCoreFrameBridge copyDOMTree:]):
        (-[WebCoreFrameBridge URLWithAttributeString:]):
        (-[WebCoreFrameBridge unmarkAllMisspellings]):
        (-[WebCoreFrameBridge nextKeyView]):
        (-[WebCoreFrameBridge previousKeyView]):
        (-[WebCoreFrameBridge nextKeyViewInsideWebFrameViews]):
        (-[WebCoreFrameBridge previousKeyViewInsideWebFrameViews]):
        (-[WebCoreFrameBridge DOMDocument]):
        (-[WebCoreFrameBridge baseURL]):
        (-[WebCoreFrameBridge domain]):
        (-[WebCoreFrameBridge numPendingOrLoadingRequests]):
        (-[WebCoreFrameBridge doneProcessingData]):
        (-[WebCoreFrameBridge selectionColor]):
        (-[WebCoreFrameBridge accessibilityTree]):
        (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]):
        (-[WebCoreFrameBridge convertToNSRange:]):
        (-[WebCoreFrameBridge convertToDOMRange:]):
        (-[WebCoreFrameBridge replaceMarkedTextWithText:]):
        (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
        (-[WebCoreFrameBridge documentFragmentWithMarkupString:baseURLString:]):
        (-[WebCoreFrameBridge documentFragmentWithText:]):
        (-[WebCoreFrameBridge documentFragmentWithNodesAsParagraphs:]):
        (-[WebCoreFrameBridge replaceSelectionWithFragment:selectReplacement:smartReplace:matchStyle:]):
        (-[WebCoreFrameBridge insertLineBreak]):
        (-[WebCoreFrameBridge insertParagraphSeparator]):
        (-[WebCoreFrameBridge insertParagraphSeparatorInQuotedContent]):
        (-[WebCoreFrameBridge insertText:selectInsertedText:]):
        (-[WebCoreFrameBridge moveSelectionToDragCaret:smartMove:]):
        (-[WebCoreFrameBridge deleteSelectionWithSmartDelete:]):
        (-[WebCoreFrameBridge deleteKeyPressedWithSmartDelete:]):
        (-[WebCoreFrameBridge forwardDeleteKeyPressedWithSmartDelete:]):
        * khtml/ecma/kjs_html.cpp:
        (KJS::KJS::HTMLDocument::putValueProperty):
        * khtml/ecma/kjs_window.cpp:
        (KJS::createNewWindow):
        (KJS::Window::getValueProperty):
        (KJS::Window::namedItemGetter):
        (KJS::Window::getOwnPropertySlot):
        (KJS::Window::put):
        (KJS::Window::isSafeScript):
        (KJS::Window::setListener):
        (KJS::Window::getListener):
        (KJS::WindowFunc::callAsFunction):
        (KJS::Window::updateLayout):
        (KJS::ScheduledAction::execute):
        (KJS::Location::put):
        (KJS::LocationFunc::callAsFunction):
        * khtml/ecma/xmlhttprequest.cpp:
        (KJS::XMLHttpRequestProtoFunc::callAsFunction):
        * khtml/editing/jsediting.cpp:
        * khtml/html/html_baseimpl.cpp:
        (WebCore::HTMLFrameElementImpl::contentDocument):
        * khtml/html/htmltokenizer.cpp:
        (WebCore::HTMLTokenizer::scriptExecution):
        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::parentDocument):
        * khtml/xsl/xslt_processorimpl.cpp:
        (DOM::XSLTProcessorImpl::createDocumentFromSource):
        * kwq/KWQAccObject.mm:
        (-[KWQAccObject textUnderElement]):
        (-[KWQAccObject doAXTextMarkerForPosition:]):
        (-[KWQAccObject rendererForView:]):
        * kwq/KWQKJavaAppletWidget.mm:
        (KJavaAppletWidget::KJavaAppletWidget):
        * page/Frame.cpp:
        (Frame::document):
        (Frame::setDocument):
        (Frame::setFocusNodeIfNeeded):
        (Frame::isPointInsideSelection):
        (Frame::computeAndSetTypingStyle):
        (Frame::applyStyle):
        (Frame::applyParagraphStyle):
        (Frame::selectionComputedStyle):
        (Frame::selectFrameElementInParentIfFullySelected):
        (Frame::renderer):
        (Frame::scrollOverflow):
        (Frame::paint):
        (Frame::adjustPageHeight):
        (Frame::updatePolicyBaseURL):
        (Frame::setPolicyBaseURL):
        (Frame::forceLayoutWithPageWidthRange):
        (Frame::sendScrollEvent):
        (Frame::clearTimers):
        (Frame::styleForSelectionStart):
        (Frame::setSelectionFromNone):
        (Frame::setWindowHasFocus):
        (Frame::backslashAsCurrencySymbol):
        * page/Frame.h:
        * page/FrameView.cpp:
        (FrameView::~FrameView):
        (FrameView::clear):
        (FrameView::resizeEvent):
        (FrameView::adjustViewSize):
        (FrameView::layout):
        (FrameView::updateDashboardRegions):
        (FrameView::viewportMousePressEvent):
        (FrameView::viewportMouseDoubleClickEvent):
        (FrameView::viewportMouseMoveEvent):
        (FrameView::viewportMouseReleaseEvent):
        (FrameView::keyPressEvent):
        (FrameView::dispatchDragEvent):
        (FrameView::updateDragAndDrop):
        (FrameView::focusNextPrevNode):
        (FrameView::dispatchMouseEvent):
        (FrameView::viewportWheelEvent):
        (FrameView::timerEvent):
        (FrameView::scheduleRelayout):
        (FrameView::unscheduleRelayout):
        * rendering/render_frames.cpp:
        (WebCore::RenderPartObject::updateWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Hyatt.
thatcher [Fri, 20 Jan 2006 22:54:16 +0000 (22:54 +0000)]
    Reviewed by Hyatt.

        Corrects the cascade order for mapped attributes.
        Shows "inline stylesheet" rather than "null" for rules in <style> tags.

        * WebInspector.subproj/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by eseidel.
cpeterse [Fri, 20 Jan 2006 21:48:47 +0000 (21:48 +0000)]
    Reviewed by eseidel.

        Build fix.

        * khtml/xml/DocumentImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-20 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 20 Jan 2006 20:20:45 +0000 (20:20 +0000)]
2006-01-20  Eric Seidel  <eseidel@apple.com>

        Reviewed by beth.

        Unbreak build (partial commit of animation patch)

        * khtml/xml/DocumentImpl.cpp:
        (WebCore::DocumentImpl::implicitClose):
        * khtml/xml/DocumentImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-20 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 20 Jan 2006 19:30:10 +0000 (19:30 +0000)]
2006-01-20  Eric Seidel  <eseidel@apple.com>

        Reviewed by beth.

        Missed the kcanvas directory in my previous commit.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6683

        * kcanvas/KCanvasContainer.h:
        * kcanvas/RenderForeignObject.h:
        * kcanvas/RenderSVGText.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-01-19 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 20 Jan 2006 19:24:53 +0000 (19:24 +0000)]
2006-01-19  Eric Seidel  <eseidel@apple.com>

        Reviewed by beth.

        Break classes in render_table out into separate files.
        Move render_block to RenderBlock.
        Move render_container to RenderContainer.

        * WebCore.xcodeproj/project.pbxproj:
        * bridge/mac/MacFrame.mm:
        * kcanvas/KCanvasContainer.h:
        * kcanvas/RenderForeignObject.h:
        * kcanvas/RenderSVGText.h:
        * khtml/editing/visible_units.cpp:
        * khtml/html/html_tableimpl.cpp:
        (WebCore::HTMLTableElementImpl::insertRow):
        * khtml/xml/dom2_rangeimpl.cpp:
        * khtml/xml/dom_position.cpp:
        * kwq/KWQRenderTreeDebug.cpp:
        * page/Frame.cpp:
        * rendering/InlineTextBox.cpp:
        * rendering/RenderBlock.cpp: Added.
        * rendering/RenderBlock.h: Added.
        * rendering/RenderContainer.cpp: Added.
        (WebCore::RenderContainer::addChild):
        * rendering/RenderContainer.h: Added.
        * rendering/RenderTable.cpp: Added.
        (WebCore::RenderTable::RenderTable):
        (WebCore::RenderTable::updateFirstLetter):
        * rendering/RenderTable.h: Added.
        * rendering/RenderTableCell.cpp: Added.
        (WebCore::RenderTableCell::RenderTableCell):
        (WebCore::RenderTableCell::updateFromElement):
        * rendering/RenderTableCell.h: Added.
        * rendering/RenderTableCol.cpp: Added.
        (WebCore::RenderTableCol::RenderTableCol):
        (WebCore::RenderTableCol::updateFromElement):
        * rendering/RenderTableCol.h: Added.
        * rendering/RenderTableRow.cpp: Added.
        (WebCore::RenderTableRow::RenderTableRow):
        * rendering/RenderTableRow.h: Added.
        * rendering/RenderTableSection.cpp: Added.
        (WebCore::RenderTableSection::RenderTableSection):
        * rendering/RenderTableSection.h: Added.
        * rendering/RenderText.cpp:
        * rendering/bidi.cpp:
        * rendering/render_block.cpp: Removed.
        * rendering/render_block.h: Removed.
        * rendering/render_box.cpp:
        * rendering/render_canvas.h:
        * rendering/render_container.cpp: Removed.
        * rendering/render_container.h: Removed.
        * rendering/render_flexbox.h:
        * rendering/render_flow.cpp:
        * rendering/render_flow.h:
        * rendering/render_form.h:
        * rendering/render_frames.h:
        * rendering/render_inline.cpp:
        * rendering/render_inline.h:
        * rendering/render_line.cpp:
        * rendering/render_list.h:
        * rendering/render_object.cpp:
        * rendering/render_replaced.h:
        * rendering/render_table.cpp: Removed.
        * rendering/render_table.h: Removed.
        * rendering/table_layout.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - added test case for a parsing bug that was fixed in different ways in KJS
mjs [Fri, 20 Jan 2006 19:10:03 +0000 (19:10 +0000)]
    - added test case for a parsing bug that was fixed in different ways in KJS
        and JSC. In older KJS versions, there would have been a parse error.

        * fast/js/parse-backslash-before-newline-expected.txt: Added.
        * fast/js/parse-backslash-before-newline.html: Added.
        * fast/js/resources/parse-backslash-before-newline.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Fri, 20 Jan 2006 18:45:08 +0000 (18:45 +0000)]
LayoutTests:

        Reviewed by Darin, committed by Adele.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6673
          Selection highlight doesn't scroll along with an image contained in an overflow:scroll block

        * fast/overflow/image-selection-highlight-expected.checksum: Added.
        * fast/overflow/image-selection-highlight-expected.png: Added.
        * fast/overflow/image-selection-highlight-expected.txt: Added.
        * fast/overflow/image-selection-highlight.html: Added.

WebCore:

        Test: fast/overflow/image-selection-highlight.html

        Reviewed by Darin, committed by Adele.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=6673
          Selection highlight doesn't scroll along with an image contained in an overflow:scroll block

        * rendering/render_replaced.cpp:
        (WebCore::RenderReplaced::selectionRect): Subtract the containing block's scroll offset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd irc://irc.freenode.net/#webkit links.
thatcher [Fri, 20 Jan 2006 17:42:55 +0000 (17:42 +0000)]
Add irc://irc.freenode.net/#webkit links.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixes the rest of http://bugzilla.opendarwin.org/show_bug.cgi?id=6535
thatcher [Fri, 20 Jan 2006 17:26:03 +0000 (17:26 +0000)]
Fixes the rest of bugzilla.opendarwin.org/show_bug.cgi?id=6535
add <tt></tt> around an instance of "svn diff".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@12257 268f45cc-cd09-0410-ab3c-d52691b4dbfc