WebKit-https.git
8 years ago2011-04-20 Dominic Cooney <dominicc@chromium.org>
commit-queue@webkit.org [Thu, 21 Apr 2011 06:33:42 +0000 (06:33 +0000)]
2011-04-20  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        layoutTestController can create and destroy shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59058

        Exercise the new layoutTestController methods.

        * fast/dom/shadow/layout-tests-can-access-shadow-expected.txt: Added.
        * fast/dom/shadow/layout-tests-can-access-shadow.html: Added.
2011-04-20  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        layoutTestController can create and destroy shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59058

        Test: fast/dom/shadow/layout-tests-can-access-shadow.html

        * WebCore.exp.in: Mac DRT needs to see Element::ensure/removeShadowRoot
2011-04-20  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        layoutTestController can create and destroy shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59058

        Chromium DRT relies on the Chromium WebKit API

        * public/WebElement.h:
        * src/WebElement.cpp:
        (WebKit::WebElement::shadowRoot): don't steal a zero refcount
        (WebKit::WebElement::ensureShadowRoot): added
        (WebKit::WebElement::removeShadowRoot): added
2011-04-20  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        layoutTestController can create and destroy shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59058

        Support for new methods in GTK DRT.

        * WebCoreSupport/DumpRenderTreeSupportGtk.cpp:
        (DumpRenderTreeSupportGtk::ensureShadowRoot):
        (DumpRenderTreeSupportGtk::removeShadowRoot):
        * WebCoreSupport/DumpRenderTreeSupportGtk.h:
2011-04-20  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        layoutTestController can create and destroy shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59058

        Support for new methods in Mac DRT.

        * DOM/WebDOMOperations.mm:
        (-[DOMElement _ensureShadowRoot:]):
        (-[DOMElement _removeShadowRoot]):
        * DOM/WebDOMOperationsPrivate.h:
2011-04-20  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        layoutTestController can create and destroy shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59058

        Support for new methods in Qt DRT.

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
        (DumpRenderTreeSupportQt::ensureShadowRoot):
        (DumpRenderTreeSupportQt::removeShadowRoot):
        * WebCoreSupport/DumpRenderTreeSupportQt.h:
2011-04-20  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        layoutTestController can create and destroy shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59058

        Support for new methods in WK2 WebKitTestRunner.

        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandle.cpp:
        (WKBundleNodeHandleCopyElementEnsureShadowRoot):
        (WKBundleNodeHandleRemoveShadowRoot):
        * WebProcess/InjectedBundle/API/c/WKBundleNodeHandlePrivate.h:
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.cpp:
        (WebKit::InjectedBundleNodeHandle::elementShadowRoot):
        (WebKit::InjectedBundleNodeHandle::elementEnsureShadowRoot):
        (WebKit::InjectedBundleNodeHandle::elementRemoveShadowRoot):
        * WebProcess/InjectedBundle/DOM/InjectedBundleNodeHandle.h:
2011-04-20  Dominic Cooney  <dominicc@chromium.org>

        Reviewed by Dimitri Glazkov.

        layoutTestController can create and destroy shadow DOM
        https://bugs.webkit.org/show_bug.cgi?id=59058

        Chromium, Mac, GTK and Qt DRT; and WK2 test runner.

        * DumpRenderTree/LayoutTestController.cpp:
        (ensureShadowRootCallback):
        (removeShadowRootCallback):
        (LayoutTestController::staticFunctions):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::ensureShadowRoot):
        (LayoutTestController::removeShadowRoot):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::ensureShadowRoot):
        (LayoutTestController::removeShadowRoot):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::shadowRoot):
        (LayoutTestController::ensureShadowRoot):
        (LayoutTestController::removeShadowRoot):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::ensureShadowRoot):
        (LayoutTestController::removeShadowRoot):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::ensureShadowRoot):
        (LayoutTestController::removeShadowRoot):
        * WebKitTestRunner/InjectedBundle/Bindings/LayoutTestController.idl:
        * WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
        (WTR::LayoutTestController::shadowRoot):
        (WTR::LayoutTestController::ensureShadowRoot):
        (WTR::LayoutTestController::removeShadowRoot):
        * WebKitTestRunner/InjectedBundle/LayoutTestController.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 05:49:37 +0000 (05:49 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Make video/image-zoom fail on GPU on all ports.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 05:42:56 +0000 (05:42 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 05:29:19 +0000 (05:29 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Add test failures for r84454, r84457, flakiness on deps bots.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFollow on fix for https://bugs.webkit.org/show_bug.cgi?id=58926
psolanki@apple.com [Thu, 21 Apr 2011 05:20:50 +0000 (05:20 +0000)]
Follow on fix for https://bugs.webkit.org/show_bug.cgi?id=58926

Reviewed by Ryosuke Niwa.

Fix assertions in Chromium builds.

* platform/graphics/Image.cpp:
(WebCore::Image::drawTiled): Skia and Wx do not have proper implementations of
BitmapImage::checkForSolidColor() so we shouldn't assert on those platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 04:50:11 +0000 (04:50 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: handle ctrl-c more cleanly
        https://bugs.webkit.org/show_bug.cgi?id=58849

        * Scripts/new-run-webkit-tests:
        * Scripts/webkitpy/layout_tests/layout_package/worker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Adam Klein <adamk@chromium.org>
adamk@chromium.org [Thu, 21 Apr 2011 04:20:28 +0000 (04:20 +0000)]
2011-04-20  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        Rename all uses of JSC_MULTIPLE_THREADS under wtf/... to WTF_MULTIPLE_THREADS
        https://bugs.webkit.org/show_bug.cgi?id=59040

        This will be used to fix https://bugs.webkit.org/show_bug.cgi?id=55728
        by enabling WTF_MULTIPLE_THREADS for Chromium.

        * wtf/CryptographicallyRandomNumber.cpp:
        (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomNumber):
        (WTF::ARC4Stream::ARC4RandomNumberGenerator::randomValues):
        * wtf/FastMalloc.cpp:
        * wtf/Platform.h:
        Enable WTF_MULTIPLE_THREADS whenever JSC_MULTIPLE_THREADS is enabled.
        * wtf/RandomNumber.cpp:
        (WTF::randomNumber):
        * wtf/RefCountedLeakCounter.cpp:
        (WTF::RefCountedLeakCounter::increment):
        (WTF::RefCountedLeakCounter::decrement):
        * wtf/dtoa.cpp:
        (WTF::pow5mult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Thu, 21 Apr 2011 04:14:11 +0000 (04:14 +0000)]
2011-04-20  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Eric Seidel.

        [EFL] Add timeline to mediaControlsEfl.css
        https://bugs.webkit.org/show_bug.cgi?id=58865

        Add timeline to mediaControlsEfl.css in order to show playing time of media
        content.

        * css/mediaControlsEfl.css:
        (audio):
        (audio::-webkit-media-controls-panel, video::-webkit-media-controls-panel):
        (audio::-webkit-media-controls-mute-button, video::-webkit-media-controls-mute-button):
        (audio::-webkit-media-controls-play-button, video::-webkit-media-controls-play-button):
        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
        (audio::-webkit-media-controls-current-time-display, video::-webkit-media-controls-current-time-display):
        (audio::-webkit-media-controls-timeline, video::-webkit-media-controls-timeline):
        (audio::-webkit-media-controls-seek-back-button, video::-webkit-media-controls-seek-back-button):
        (audio::-webkit-media-controls-seek-forward-button, video::-webkit-media-controls-seek-forward-button):
        (audio::-webkit-media-controls-fullscreen-button, video::-webkit-media-controls-fullscreen-button):
        (audio::-webkit-media-controls-toggle-closed-captions-button, video::-webkit-media-controls-toggle-closed-captions-button):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 03:49:38 +0000 (03:49 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Suppress failures for inspector/debugger/live-edit.html
        and inspector/console/console-object-constructor-name.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 21 Apr 2011 03:41:38 +0000 (03:41 +0000)]
2011-04-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Eric Seidel.

        Create RIAA class for GraphicsContext::save() and restore()
        https://bugs.webkit.org/show_bug.cgi?id=58807

        Make a stack-based class that can be used to save and restore
        the graphics state. It has conditional behavior to deal with the many cases
        where we decide to save/restore based on some runtime condition.

        Change RenderBoxModelObject to use it for now; it can be used more widely
        once committed.

        * platform/graphics/GraphicsContext.h:
        (WebCore::GraphicsContextStateSaver::GraphicsContextStateSaver):
        (WebCore::GraphicsContextStateSaver::~GraphicsContextStateSaver):
        (WebCore::GraphicsContextStateSaver::saveState):
        * rendering/RenderBoxModelObject.cpp:
        (WebCore::RenderBoxModelObject::paintFillLayerExtended):
        (WebCore::RenderBoxModelObject::paintOneBorderSide):
        (WebCore::RenderBoxModelObject::paintBorder):
        (WebCore::RenderBoxModelObject::drawBoxSideFromPath):
        (WebCore::RenderBoxModelObject::paintBoxShadow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 59069 - DFG JIT - register allocate r8, r9, r10
barraclough@apple.com [Thu, 21 Apr 2011 03:33:43 +0000 (03:33 +0000)]
Bug 59069 - DFG JIT - register allocate r8, r9, r10

Rubber stamped by Geoff Garen

* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::gprToRegisterID):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 03:26:53 +0000 (03:26 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Suppress failures for media/csp-blocks-video.html and
        plugins/embed-attributes-style.html

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 21 Apr 2011 03:21:20 +0000 (03:21 +0000)]
2011-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP frame-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58643

        Tests the basic functionality of frame-src.

        * http/tests/security/contentSecurityPolicy/frame-src-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/frame-src-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/frame-src-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/frame-src-blocked.html: Added.
        * http/tests/security/contentSecurityPolicy/resources/alert-fail.html: Added.
        * http/tests/security/contentSecurityPolicy/resources/alert-pass.html: Added.
2011-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP frame-src is missing
        https://bugs.webkit.org/show_bug.cgi?id=58643

        This is a first cut at an implementation of frame-src.  There are a
        couple things that will need to be improved:

          1) I don't think we're handling in-frame navigation properly.  This
             patch only covers setting the src attribute of the frame, but I
             think the intent of the spec is to cover navigation as well.

          2) The console message is printed twice, once when we try to load the
             frame and again when we attach the frame to the render tree.

        I'll file bugs about these issues (blocking
        https://bugs.webkit.org/show_bug.cgi?id=53572) once this patch lands.

        Tests: http/tests/security/contentSecurityPolicy/frame-src-allowed.html
               http/tests/security/contentSecurityPolicy/frame-src-blocked.html

        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::isURLAllowed):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::allowChildFrameFromSource):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Thu, 21 Apr 2011 03:02:28 +0000 (03:02 +0000)]
2011-04-20  Jia Pu  <jpu@apple.com>

        Reviewed by Maciej Stachowiak.

        [Mac] Correction panel shows up at incorrect location after webpage is scrolled.
        https://bugs.webkit.org/show_bug.cgi?id=59052
        <rdar://problem/9312513>

        Fixed a regression caused by interaction between patch for bug 57353 and patch for bug 55571.
        See bug webpage for detail.

        * editing/Editor.cpp:
        (WebCore::Editor::selectionStartHasMarkerFor):
        * editing/SpellingCorrectionController.cpp:
        (WebCore::SpellingCorrectionController::windowRectForRange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 02:47:45 +0000 (02:47 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 21 Apr 2011 02:33:55 +0000 (02:33 +0000)]
2011-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP policy violations should log to the console
        https://bugs.webkit.org/show_bug.cgi?id=58646

        Now with console messages.  I had to split a bunch of these tests into
        smaller pieces to avoid race conditions in the new test output.

        * http/tests/security/contentSecurityPolicy/directive-parsing-expected.txt:
        * http/tests/security/contentSecurityPolicy/eval-scripts-setInterval-blocked-expected.txt:
        * http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt:
        * http/tests/security/contentSecurityPolicy/image-blocked-expected.txt:
        * http/tests/security/contentSecurityPolicy/inline-script-blocked-expected.txt:
        * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy-expected.txt:
        * http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html:
        * http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/inline-script-blocked-goofy.html.
        * http/tests/security/contentSecurityPolicy/javascript-url-allowed-expected.txt: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/eval-scripts-setTimeout-blocked-expected.txt.
        * http/tests/security/contentSecurityPolicy/javascript-url-allowed.html: Added.
        * http/tests/security/contentSecurityPolicy/javascript-url-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/javascript-url-blocked.html: Added.
        * http/tests/security/contentSecurityPolicy/javascript-url-expected.txt: Removed.
        * http/tests/security/contentSecurityPolicy/javascript-url.html: Removed.
        * http/tests/security/contentSecurityPolicy/media-src-blocked-expected.txt:
        * http/tests/security/contentSecurityPolicy/object-src-none-allowed-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/object-src-none-allowed.html: Copied from LayoutTests/http/tests/security/contentSecurityPolicy/object-src-none.html.
        * http/tests/security/contentSecurityPolicy/object-src-none-blocked-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/object-src-none-blocked.html: Renamed from LayoutTests/http/tests/security/contentSecurityPolicy/object-src-none.html.
        * http/tests/security/contentSecurityPolicy/object-src-none-expected.txt: Removed.
        * http/tests/security/contentSecurityPolicy/script-src-none-expected.txt:
        * http/tests/security/contentSecurityPolicy/script-src-none-inline-event-expected.txt:
        * http/tests/security/contentSecurityPolicy/script-src-redirect-expected.txt:
        * http/tests/security/contentSecurityPolicy/script-src-self-blocked-01-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/script-src-self-blocked-01.html: Added.
        * http/tests/security/contentSecurityPolicy/script-src-self-blocked-02-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/script-src-self-blocked-02.html: Added.
        * http/tests/security/contentSecurityPolicy/script-src-self-blocked-03-expected.txt: Added.
        * http/tests/security/contentSecurityPolicy/script-src-self-blocked-03.html: Added.
        * http/tests/security/contentSecurityPolicy/script-src-self-expected.txt:
        * http/tests/security/contentSecurityPolicy/script-src-self.html:
        * http/tests/security/contentSecurityPolicy/source-list-parsing-expected.txt:
        * http/tests/security/contentSecurityPolicy/style-blocked-expected.txt:
        * http/tests/security/contentSecurityPolicy/xsl-blocked-expected.txt:
        * media/csp-blocks-video-expected.txt:
2011-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        CSP policy violations should log to the console
        https://bugs.webkit.org/show_bug.cgi?id=58646

        We now log policy violations to the JavaScript console to help
        developers debug what's going on with their Content-Security-Policy.

        Tests: http/tests/security/contentSecurityPolicy/inline-script-blocked-javascript-url.html
               http/tests/security/contentSecurityPolicy/javascript-url-allowed.html
               http/tests/security/contentSecurityPolicy/javascript-url-blocked.html
               http/tests/security/contentSecurityPolicy/object-src-none-allowed.html
               http/tests/security/contentSecurityPolicy/object-src-none-blocked.html
               http/tests/security/contentSecurityPolicy/script-src-self-blocked-01.html
               http/tests/security/contentSecurityPolicy/script-src-self-blocked-02.html
               http/tests/security/contentSecurityPolicy/script-src-self-blocked-03.html

        * dom/Document.cpp:
        (WebCore::Document::initSecurityContext):
        * page/ContentSecurityPolicy.cpp:
        (WebCore::ContentSecurityPolicy::ContentSecurityPolicy):
        (WebCore::ContentSecurityPolicy::allowJavaScriptURLs):
        (WebCore::ContentSecurityPolicy::allowInlineEventHandlers):
        (WebCore::ContentSecurityPolicy::allowInlineScript):
        (WebCore::ContentSecurityPolicy::allowEval):
        (WebCore::ContentSecurityPolicy::allowScriptFromSource):
        (WebCore::ContentSecurityPolicy::allowObjectFromSource):
        (WebCore::ContentSecurityPolicy::allowImageFromSource):
        (WebCore::ContentSecurityPolicy::allowStyleFromSource):
        (WebCore::ContentSecurityPolicy::allowFontFromSource):
        (WebCore::ContentSecurityPolicy::allowMediaFromSource):
        (WebCore::ContentSecurityPolicy::addDirective):
        * page/ContentSecurityPolicy.h:
        (WebCore::ContentSecurityPolicy::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofast/images/animated-gif-restored-from-bfcache.html fails on Windows bots
aestes@apple.com [Thu, 21 Apr 2011 02:23:00 +0000 (02:23 +0000)]
fast/images/animated-gif-restored-from-bfcache.html fails on Windows bots
https://bugs.webkit.org/show_bug.cgi?id=59062

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Thu, 21 Apr 2011 02:20:17 +0000 (02:20 +0000)]
2011-04-20  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r84431.
        http://trac.webkit.org/changeset/84431
        https://bugs.webkit.org/show_bug.cgi?id=59061

        Breaks for folks who don't have editbugs (Requested by abarth
        on #webkit).

        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9095366> With a non-1 page scale, scrolling to reveal selection fails
mitz@apple.com [Thu, 21 Apr 2011 02:13:10 +0000 (02:13 +0000)]
<rdar://problem/9095366> With a non-1 page scale, scrolling to reveal selection fails
https://bugs.webkit.org/show_bug.cgi?id=59046

Reviewed by Maciej Stachowiak.

Source/WebCore:

Test: fast/transforms/selection-bounds-in-transformed-view.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintUsingContainer): If the repaint container is the RenderView, and
it has a composited layer that paints straight to the window, then translate from view coordinates
to window coordinates here.
* rendering/RenderView.cpp:
(WebCore::RenderView::mapLocalToContainer): Do not apply our transform if we are the painting root.
(WebCore::RenderView::computeRectForRepaint): Ditto. Applying the transform here was compensating
for not applying it in RenderObject::repaintUsingContainer(), but for purposes other than repainting,
such as computing selection bounds, this function was returning the wrong results.

LayoutTests:

* fast/transforms/selection-bounds-in-transformed-view-expected.txt: Added.
* fast/transforms/selection-bounds-in-transformed-view.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Leo Yang <leo.yang@torchmobile.com.cn>
leo.yang@torchmobile.com.cn [Thu, 21 Apr 2011 02:07:35 +0000 (02:07 +0000)]
2011-04-20  Leo Yang  <leo.yang@torchmobile.com.cn>

        Unreviewed.

        Adding myself to committers.py.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/9304956> media/broken-video.html crashes
mitz@apple.com [Thu, 21 Apr 2011 02:03:37 +0000 (02:03 +0000)]
<rdar://problem/9304956> media/broken-video.html crashes

Reviewed by Eric Carlson.

* platform/graphics/MediaPlayer.cpp:
(WebCore::nextMediaEngine): Fixed an off-by-one error.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 01:58:45 +0000 (01:58 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change.

        Merge forward more suppressions from the chromium overrides
        file.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 21 Apr 2011 01:55:09 +0000 (01:55 +0000)]
2011-04-20  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Split out isIteratorTarget from bidiNext and bidiFirst
        https://bugs.webkit.org/show_bug.cgi?id=59033

        This is the first (tiny) step of many.  When I tried to
        make larger changes to this function I broke stuff, so
        doing this in tiny pieces so we know it's right.

        * rendering/InlineIterator.h:
        (WebCore::isIteratorTarget):
        (WebCore::bidiNext):
        (WebCore::bidiFirstSkippingInlines):
        (WebCore::bidiFirstNotSkippingInlines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Alexey Marinichev <amarinichev@chromium.org>
commit-queue@webkit.org [Thu, 21 Apr 2011 01:38:12 +0000 (01:38 +0000)]
2011-04-20  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Kenneth Russell.

        Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=59045

        Lose context extension test might not catch this bug, more reliable
        way is forcing the crash of the GPU process, which is done by Chromium
        browser tests.

        * platform/graphics/chromium/WebGLLayerChromium.cpp:
        (WebCore::WebGLLayerChromium::updateCompositorResources):
        (WebCore::WebGLLayerChromium::setContext):
        * platform/graphics/chromium/WebGLLayerChromium.h:
2011-04-20  Alexey Marinichev  <amarinichev@chromium.org>

        Reviewed by Kenneth Russell.

        Check for null m_context in WebGLLayerChromium and add resetting platform layer's context in the destructor of GraphicsContext3D.
        https://bugs.webkit.org/show_bug.cgi?id=59045

        * src/GraphicsContext3DChromium.cpp:
        (WebCore::GraphicsContext3D::~GraphicsContext3D): call into platform
        layer and unregister itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Thu, 21 Apr 2011 01:28:30 +0000 (01:28 +0000)]
2011-04-20  Jia Pu  <jpu@apple.com>

        Reviewed by Maciej Stachowiak.

        [Mac]Regression: extending word that is already marked misspelled doesn't remove misspelling underline.
        https://bugs.webkit.org/show_bug.cgi?id=59032
        <rdar://problem/9312444>

        This fixes a regression introduced in recent refactoring work in Editor. See bug webpage for detail.

        manual test: Source/WebCore/manual-tests/autocorrection/remove-misspelling-marker-after-appending-letter.html

        * editing/Editor.cpp:
        (WebCore::Editor::insertTextWithoutSendingTextEvent):
        * manual-tests/autocorrection/remove-misspelling-marker-after-appending-letter.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself to the committers script.
adamk@chromium.org [Thu, 21 Apr 2011 01:10:43 +0000 (01:10 +0000)]
Unreviewed. Add myself to the committers script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix - revert accidental change.
barraclough@apple.com [Thu, 21 Apr 2011 01:04:34 +0000 (01:04 +0000)]
Build fix - revert accidental change.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd SAMPLING_FLAGS tool to DFG JIT.
barraclough@apple.com [Thu, 21 Apr 2011 01:03:44 +0000 (01:03 +0000)]
Add SAMPLING_FLAGS tool to DFG JIT.

Reviewed by Sam Weinig.

* bytecode/SamplingTool.h:
(JSC::SamplingFlags::addressOfFlags):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::setSamplingFlag):
(JSC::DFG::JITCompiler::clearSamplingFlag):
* dfg/DFGJITCompiler.h:
* jit/JITInlineMethods.h:
(JSC::JIT::setSamplingFlag):
(JSC::JIT::clearSamplingFlag):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Chris Fleizach <cfleizach@apple.com>
cfleizach@apple.com [Thu, 21 Apr 2011 00:54:25 +0000 (00:54 +0000)]
2011-04-20  Chris Fleizach  <cfleizach@apple.com>

        Reviewed by Beth Dakin.

        CrashTracer: 301 crashes in Safari at com.apple.WebCore: WebCore::AccessibilityRenderObject::visiblePositionForPoint const + 297
        https://bugs.webkit.org/show_bug.cgi?id=57405

        The offending line in this crash was a null pointer access in
           m_renderer->document()->topDocument()->renderer()->view()->frameView();
        It seems likely that one of those calls was invalid. I could not reproduce and there was no
        information on reproducible steps, hence the absence of a layout test.

        * accessibility/AccessibilityRenderObject.cpp:
        (WebCore::AccessibilityRenderObject::topRenderer):
        (WebCore::AccessibilityRenderObject::topDocument):
        (WebCore::AccessibilityRenderObject::topDocumentFrameView):
        (WebCore::AccessibilityRenderObject::visiblePositionForPoint):
        * accessibility/AccessibilityRenderObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Andy Estes <aestes@apple.com>
aestes@apple.com [Thu, 21 Apr 2011 00:46:20 +0000 (00:46 +0000)]
2011-04-20  Andy Estes  <aestes@apple.com>

        Reviewed by Maciej Stachowiak.

        REGRESSION (WK2): Animated GIF stops when navigating forward, back
        https://bugs.webkit.org/show_bug.cgi?id=59042

        * fast/images/animated-gif-restored-from-bfcache-expected.txt: Added.
        * fast/images/animated-gif-restored-from-bfcache.html: Added.
        * fast/images/resources/animated-10color.gif: Added.
        * platform/mac-wk2/Skipped: Sadly, this test for a WebKit2-specific fix
        has to be skipped for now on WebKit2 since it doesn't implement
        layoutTestController.overridePreference().
2011-04-20  Andy Estes  <aestes@apple.com>

        Reviewed by Maciej Stachowiak.

        REGRESSION (WK2): Animated GIF stops when navigating forward, back
        https://bugs.webkit.org/show_bug.cgi?id=59042

        When loading the page from the b/f cache,
        document()->view()->isOffscreen() returns true in
        RenderObject::willRenderImage(), so BitmapImage::startAnimation()
        returns without actually kicking off the animation.

        In WebKit1, the ScrollView is a platform widget, so
        ScrollView::isOffscreen() calls [NSWindow isVisible]. In WebKit2, the
        ScrollView isn't a platform widget so it asks the WebCore Widget
        whether or not it is visible. It always returns false since
        setParentVisible(false) was called on the old ScrollView before
        navigating to a new page, but setParentVisible(true) is never called
        when restoring it from the back/forward cache. This is probably a
        long-standing bug.

        Fix this by calling setParentVisible(true) when a cached main frame is
        being restored.

        Test: fast/images/animated-gif-restored-from-bfcache.html

        * history/CachedFrame.cpp:
        (WebCore::CachedFrameBase::restore): If the cached frame is the main
        frame, call setParentVisible(true) on the frame's view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 21 Apr 2011 00:35:24 +0000 (00:35 +0000)]
2011-04-20  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        WebKit2: Can't scroll page after printing on Yahoo.com and other sites
        <rdar://problem/9233291>
        https://bugs.webkit.org/show_bug.cgi?id=59049

        * page/Frame.cpp:
        (WebCore::Frame::setPrinting): Match Mac WebKit1 code when ending printing,
        and call forceLayout() instead of forceLayoutForPagination().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84442 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 21 Apr 2011 00:28:17 +0000 (00:28 +0000)]
2011-04-20  Kenneth Russell  <kbr@google.com>

        Reviewed by James Robinson.

        Reduce size of GraphicsContext3D's compiled code
        https://bugs.webkit.org/show_bug.cgi?id=59029

        Changed format conversion operations to work line-by-line instead
        of pixel-by-pixel, and passed them as function pointers rather
        than template parameters. Simplified computation of source
        increment, since elements per row is now all that is needed.

        These changes reduce the size of GraphicsContext3D.o in release
        mode on Linux from 299 KB to 53 KB.

        No new tests. Existing layout tests cover these format conversions
        well, and caught one typo in the restructuring. Also ran WebGL
        conformance suite and other demos.

        * platform/graphics/GraphicsContext3D.cpp:
        (WebCore::doUnpackingAndPacking):
        (WebCore::computeSourceElementsPerRow):
        (WebCore::doPacking):
        (WebCore::doFloatingPointPacking):
        (WebCore::GraphicsContext3D::packPixels):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 21 Apr 2011 00:23:28 +0000 (00:23 +0000)]
2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
        https://bugs.webkit.org/show_bug.cgi?id=59037

        * fast/events/simulated-click-disabled-expected.txt: Added.
        * fast/events/simulated-click-disabled.html: Added.
2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Kent Tamura.

        REGRESSION(r82376): Clicking on a label, associated with a disabled input element changes state of the element.
        https://bugs.webkit.org/show_bug.cgi?id=59037

        Test: fast/events/simulated-click-disabled.html

        * dom/EventDispatcher.cpp:
        (WebCore::EventDispatcher::dispatchSimulatedClick): Added check for disabled element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Thu, 21 Apr 2011 00:21:12 +0000 (00:21 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Pull in more flaky expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 23:55:56 +0000 (23:55 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, expectations change. Pull in expectations from
        overrides file.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Wed, 20 Apr 2011 23:50:20 +0000 (23:50 +0000)]
2011-04-20  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Don't discard backing stores for hung web processes
        https://bugs.webkit.org/show_bug.cgi?id=59039
        <rdar://problem/9237090>

        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::viewStateDidChange):
        (WebKit::WebPageProxy::processDidBecomeUnresponsive):
        (WebKit::WebPageProxy::processDidBecomeResponsive):
        Call updateBackingStoreDiscardableState.

        (WebKit::WebPageProxy::updateBackingStoreDiscardableState):
        Never mark the backing store as discardable if the web process is hung

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 20 Apr 2011 23:48:23 +0000 (23:48 +0000)]
2011-04-20  Eric Seidel  <eric@webkit.org>

        Reviewed by Ryosuke Niwa.

        Split bidiFirst into two functions
        https://bugs.webkit.org/show_bug.cgi?id=59025

        I don't have a full understanding of the skipInlines case yet
        (hence it's not as pretty as the non-skipping case), but
        this is clearly a win, as both functions are much simpler
        than their combined version.

        Both of these functions still have bad names.  However the
        bidiNext/bidiFirst names date all the way back to revision 1
        of the WebKit repository. :)  So I don't feel too bad keeping
        them for the moment.

        * rendering/InlineIterator.h:
        (WebCore::bidiNext):
        (WebCore::bidiFirstSkippingInlines):
        (WebCore::bidiFirstNotSkippingInlines):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::simplifiedNormalFlowLayout):
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::layoutInlineChildren):
        (WebCore::RenderBlock::determineStartPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoProvide missing implementation of WebMutableURLRequest::mutableCopy.
bfulgham@webkit.org [Wed, 20 Apr 2011 23:43:04 +0000 (23:43 +0000)]
Provide missing implementation of WebMutableURLRequest::mutableCopy.
This was preventing DumpRenderTree from working properly under
the WinCairo port.
https://bugs.webkit.org/show_bug.cgi?id=59034

Reviewed by Martin Robinson.

* WebMutableURLRequest.cpp:
(WebMutableURLRequest::mutableCopy): Implement cURL version of the
copy operation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Wed, 20 Apr 2011 23:41:52 +0000 (23:41 +0000)]
2011-04-20  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Sam Weinig.

        Reproducible crash under WebPageProxy::didReceiveEvent
        https://bugs.webkit.org/show_bug.cgi?id=59036
        <rdar://problem/9252083>

        * UIProcess/API/mac/WKView.mm:
        (-[WKView _resendKeyDownEvent:]): Protect against self-destruction
        when re-dispatching the event.
        * UIProcess/WebProcessProxy.cpp:
        (WebKit::WebProcessProxy::createWebPage): Fixed a type mismatch
        I noticed while debugging.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Wed, 20 Apr 2011 23:35:15 +0000 (23:35 +0000)]
2011-04-20  Jia Pu  <jpu@apple.com>

        Reviewed by Adele Peterson.

        [Mac] Like autocorrection, other types of substitution need to respect undo.
        https://bugs.webkit.org/show_bug.cgi?id=59009
        <rdar://problem/8601537>

        Similar to autocorrection, we use SpellingCorrectionCommand to carry out other types of text substitution, so that
        if user undoes the substitution, it will not be applied again. For CreateLinkCommand,  we add marker when it's undone
        so that we won't automatically add link again.

        * editing/CreateLinkCommand.h:
        (WebCore::CreateLinkCommand::isCreateLinkCommand):
        * editing/EditCommand.cpp:
        (WebCore::EditCommand::isCreateLinkCommand):
        * editing/EditCommand.h:
        * editing/Editor.cpp:
        (WebCore::Editor::unappliedEditing):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        * editing/SpellingCorrectionController.cpp:
        (WebCore::SpellingCorrectionController::respondToAppliedEditing):
        (WebCore::SpellingCorrectionController::respondToUnappliedEditing):
        * editing/SpellingCorrectionController.h:
        (WebCore::SpellingCorrectionController::UNLESS_ENABLED):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 23:20:16 +0000 (23:20 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Update 2 more tests that are missing png files.

        * platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.checksum: Removed.
        * platform/chromium-mac/fast/borders/borderRadiusDotted06-expected.png: Added. png with embedded checksum pulled from the bot.
        * platform/chromium-win/compositing/repaint/become-overlay-composited-layer-expected.checksum: Removed. This file is not used since we don't
            run compositing tests w/CPU rendering and there's a GPU result in chromium-gpu-win.
        * platform/chromium/test_expectations.txt:  Remove these tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Wed, 20 Apr 2011 23:08:27 +0000 (23:08 +0000)]
2011-04-20  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        webkit-patch upload should assign the bug to you
        https://bugs.webkit.org/show_bug.cgi?id=33699

        This patch only re-assigns the bug if it is currently unassigned.  We
        can be more aggressive in the future if people want us to be more
        agressive.

        * Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, fixed typo in the failed test added to chromium test
jianli@chromium.org [Wed, 20 Apr 2011 23:07:36 +0000 (23:07 +0000)]
Unreviewed, fixed typo in the failed test added to chromium test
expectations.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Steve Lacey <sjl@chromium.org>
commit-queue@webkit.org [Wed, 20 Apr 2011 22:57:42 +0000 (22:57 +0000)]
2011-04-20  Steve Lacey  <sjl@chromium.org>

        Reviewed by Eric Carlson.

        [chromium] Move Chromium media controls into own root element.
        https://bugs.webkit.org/show_bug.cgi?id=59018

        No new tests as there is no functional change

        * WebCore.gypi:
        * css/mediaControlsChromium.css:
        (audio::-webkit-media-controls-timeline-container, video::-webkit-media-controls-timeline-container):
        * html/shadow/MediaControlRootElementChromium.cpp: Added.
        Clone of html/shadow/MediaControlRootElement.cpp with all unused code removed.
        * html/shadow/MediaControlRootElementChromium.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 22:54:26 +0000 (22:54 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        More .checksum file cleanup.

        * fast/css/background-clip-values-expected.checksum: Removed. This is a duplicate of the .checksum
            file in platform/mac.
        * platform/mac-leopard/fast/backgrounds/size/contain-and-cover-expected.checksum: Correct checksum by
            regenerating on my leopard machine.
        * platform/mac-leopard/fast/backgrounds/size/contain-and-cover-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Yuzhu Shen <yzshen@chromium.org>
commit-queue@webkit.org [Wed, 20 Apr 2011 22:32:47 +0000 (22:32 +0000)]
2011-04-20  Yuzhu Shen  <yzshen@chromium.org>

        Reviewed by Tony Chang.

        [chromium] linux chromium doesn't set click count for mouse up events.
        https://bugs.webkit.org/show_bug.cgi?id=58921

        The reason why we need such a fix is that the Pepper API passes this information to plugins,
        and some consumers (e.g., Flash) need it to detect double-clicks.

        * src/gtk/WebInputEventFactory.cpp: set click count for mouse up events.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84427 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Charlie Lee <chocobo@chromium.org>
commit-queue@webkit.org [Wed, 20 Apr 2011 22:26:42 +0000 (22:26 +0000)]
2011-04-20  Charlie Lee  <chocobo@chromium.org>

        Reviewed by Dirk Schulze.

        LEFilter change doesn't compile on ARM neon targets
        https://bugs.webkit.org/show_bug.cgi?id=58671

        Build fix for Chromium ARM/NEON platform. Added platform/graphics/filters/arm directory to build system.

        * WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Wed, 20 Apr 2011 22:20:39 +0000 (22:20 +0000)]
2011-04-20  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        Continue (3rd) experiment with moving caret by word in visual order.
        https://bugs.webkit.org/show_bug.cgi?id=58294

        This patch along with r82588 and r83483 implements moving caret by
        word in visual order.

        The overall algorithm is:
        1. First get the InlineBox and offset of the pass-in VisiblePosition.
        2. Based on the position (left boundary, middle, right boundary) of the offset and the
           direction of the movement, look for visually adjacent word breaks.
        2.1 If the offset is the minimum offset of the box,
            return the rightmost word boundary in previous boxes if moving left.
            return the leftmost word boundary in box and next boxes if moving right.
        2.2 Similar for the case when offset is at the maximum offset of the box.
        2.3 When offset is inside the box (not at boundaries), first find the previousWordPosition
            or nextWordPosition based on the directionality of the box. If this word break position
            is also inside the same box, return it. Otherwise (the nextWordPosition or
            previousWordPosition is not in the same box or is at the box boundary), collect all the
            word breaks in the box and search for the one closest to the input "offset" based on
            box directionality, block directionality, and movement direction. Continue search in
            adjacent boxes if needed.

        Notes:
        1. Word boundaries are collected one box at a time. Only when a boundary that is closest to
           the input position (in the moving direction) is not available in current box, word
           boundaries in adjacent box will be collected. So, there is no need to save InlineBox in
           word boundaries. Instead, the word boundaries are saved as a pair
           (VisiblePosition, offset) to avoid recomputing VisiblePosition.

        2. We only collect boundaries of the right kind (i.e. left boundary of a word in LTR block
           and right boundary of a word in RTL block). And word boundaries are collected using
           previousWordPosition() and nextWordPosition(). So when box directionality is the same as
           block directionality, word boundaries are collected from right to left visually in a LTR
           box, and word boundaries are collected from left to right visually in a RTL box. It is
           the other way around when box directionality is different from block directionality.

        3. To find the right kinds of word boundaries, we must move back and forth between words
           in some situations. For example, if we're moving to the right in a LTR box in LTR block,
           we cannot simply return nextWordPosition() because it would return the right boundary
           of a word. Instead, we return nextWordPosition()'s nextWordPosition()'s previousWordPosition().

        4. When collecting word breaks inside a box, it first computes a start position, then
           collect the right kind of word breaks until it reaches the end of (or beyond) the box.
           In the meanwhile, it might need special handling on the rightmost or leftmost position
           based on the directionality of the box and block. These computations do not consider the
           box's bidi level.

        * editing/visible_units.cpp:
        (WebCore::nextWordBreakInBoxInsideBlockWithDifferentDirectionality):
        (WebCore::collectWordBreaksInBox):
        (WebCore::previousWordBoundaryInBox):
        (WebCore::nextWordBoundaryInBox):
        (WebCore::visuallyLastWordBoundaryInBox):
        (WebCore::leftWordBoundary):
        (WebCore::rightWordBoundary):
        (WebCore::leftWordPosition):
        (WebCore::rightWordPosition):
2011-04-20  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Ryosuke Niwa.

        Continue (3rd) experiment with moving caret by word in visual order.
        https://bugs.webkit.org/show_bug.cgi?id=58294

        * editing/selection/move-by-word-visually-expected.txt:
        * editing/selection/move-by-word-visually.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake the Web Insepctor come to the front when a breakpoint is hit.
timothy@apple.com [Wed, 20 Apr 2011 22:09:24 +0000 (22:09 +0000)]
Make the Web Insepctor come to the front when a breakpoint is hit.

<https://webkit.org/b/57480> REGRESSION (WebKit2): Inspector doesn't come to the front when a breakpoint is hit in the debugger
<rdar://problem/9209472>

Reviewed by Adam Roben.

* UIProcess/WebInspectorProxy.cpp:
(WebKit::WebInspectorProxy::bringToFront): Added. Call platformBringToFront.
* UIProcess/WebInspectorProxy.h:
* UIProcess/WebInspectorProxy.messages.in: Added BringToFront.
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformBringToFront): Added. Call orderFront:.
* UIProcess/win/WebInspectorProxyWin.cpp:
(WebKit::WebInspectorProxy::platformBringToFront): Added. Call SetWindowPos.
* WebProcess/WebCoreSupport/WebInspectorFrontendClient.cpp:
(WebKit::WebInspectorFrontendClient::bringToFront): Call WebInspector::bringToFront.
* WebProcess/WebPage/WebInspector.cpp:
(WebKit::WebInspector::bringToFront): Added. Send WebInspectorProxy::BringToFront message.
* WebProcess/WebPage/WebInspector.h: Added bringToFront.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoModify builder.html template to allow easy access
ossy@webkit.org [Wed, 20 Apr 2011 21:57:34 +0000 (21:57 +0000)]
Modify builder.html template to allow easy access
to list more builds on the builder's page.

Patch by Peter Gal <galpeter@inf.u-szeged.hu> on 2011-04-20
Reviewed by Csaba Osztrogon√°c.

https://bugs.webkit.org/show_bug.cgi?id=59008

* BuildSlaveSupport/build.webkit.org-config/templates/builder.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Cris Neckar <cdn@chromium.org>
cdn@chromium.org [Wed, 20 Apr 2011 21:57:07 +0000 (21:57 +0000)]
2011-04-20  Cris Neckar  <cdn@chromium.org>

        Reviewed by Dirk Schulze.

        Tests for crash when copying a filter effect after applying tranforms.
        https://bugs.webkit.org/show_bug.cgi?id=57885

        * svg/filters/svg-transform-blur-crash-expected.txt: Added.
        * svg/filters/svg-transform-blur-crash.xhtml: Added.
2011-04-20  Cris Neckar  <cdn@chromium.org>

        Reviewed by Dirk Schulze.

        Return early when the paint rect and the source rect do not overlap as no bytes need to be copied.
        https://bugs.webkit.org/show_bug.cgi?id=57885

        Test: svg/filters/svg-transform-blur-crash.xhtml

        * platform/graphics/filters/FilterEffect.cpp:
        (WebCore::FilterEffect::copyImageBytes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Peter Gal <galpeter@inf.u-szeged.hu>
ossy@webkit.org [Wed, 20 Apr 2011 21:48:08 +0000 (21:48 +0000)]
2011-04-20  Peter Gal  <galpeter@inf.u-szeged.hu>

        Reviewed by Csaba Osztrogon√°c.

        Add the default template for builder page.

        https://bugs.webkit.org/show_bug.cgi?id=59008

        * BuildSlaveSupport/build.webkit.org-config/templates/builder.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 20 Apr 2011 21:45:30 +0000 (21:45 +0000)]
2011-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        move page generation into a single function
        https://bugs.webkit.org/show_bug.cgi?id=59027

        Now executing the script doesn't create any state. We should then
        be able to write tests for this by setting custom results data.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 20 Apr 2011 21:39:16 +0000 (21:39 +0000)]
2011-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Tony Chang.

        move global state into a shared object
        https://bugs.webkit.org/show_bug.cgi?id=59023

        This makes the code more testable.

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSupport DataView in workers
jianli@chromium.org [Wed, 20 Apr 2011 21:38:02 +0000 (21:38 +0000)]
Support DataView in workers
https://bugs.webkit.org/show_bug.cgi?id=59014

Reviewed by Kenneth Russell.

Source/WebCore:

Test: fast/canvas/webgl/worker-data-view-test.html

* workers/WorkerContext.idl: Expose DataView constructor.

LayoutTests:

* fast/canvas/webgl/resources/worker-data-view-test.js: Added.
* fast/canvas/webgl/worker-data-view-test-expected.txt: Added.
* fast/canvas/webgl/worker-data-view-test.html: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 21:33:46 +0000 (21:33 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Cleanup .checksum files that don't have .png files.

        If the test is marked as failing, just delete the .checksum file.
        If the test is marked as passing, put it in test_expectations.txt so
        the bots will generate results.

        * platform/chromium-mac-leopard/fast/borders/border-radius-split-inline-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/repaint/positioned-document-element-expected.checksum: Removed.
        * platform/chromium-mac-leopard/fast/text/basic/014-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.checksum: Removed.
        * platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.checksum: Removed.
        * platform/chromium-mac/fast/forms/input-appearance-bkcolor-expected.checksum: Removed.
        * platform/chromium-mac/fast/images/imagemap-focus-ring-expected.checksum: Removed.
        * platform/chromium-mac/tables/mozilla/core/misc-expected.checksum: Removed.
        * platform/chromium-win/fast/forms/searchfield-heights-expected.checksum: Removed.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Wed, 20 Apr 2011 21:09:00 +0000 (21:09 +0000)]
2011-04-20  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Adam Roben.

        REGRESSION (WebKit2): CSS animations on pages that use accelerated compositing stop after switching tabs
        https://bugs.webkit.org/show_bug.cgi?id=57868

        Running CACFAnimations aren't remembered when layer tree is unparented and
        then reparented. Added a new ensureAnimationsSubmitted function to
        PlatformCALayer to traverse the tree and resubmit animations, setting the
        beginTime to the original start time of the animation. This is called in WK2
        when layer tree is newly parented.

        I also consolidated currentTimeToMediaTime into PlatformCALayer so it can be shared
        between PlatformCALayer and GraphicsLayerCA.

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        * platform/graphics/ca/PlatformCAAnimation.h:
            Remember actual animation start time in CACFAnimation beginTime property
        * platform/graphics/ca/PlatformCALayer.h:
            New ensureAnimationsSubmitted function which traverses layers and resubmits all animations
        * platform/graphics/ca/mac/PlatformCALayerMac.mm:
        * platform/graphics/ca/win/PlatformCALayerWin.cpp:

2011-04-20  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Adam Roben.

        REGRESSION (WebKit2): CSS animations on pages that use accelerated compositing stop after switching tabs
        https://bugs.webkit.org/show_bug.cgi?id=57868

        Subclassed setRootCompositingLayer so it can call ensureAnimationsSubmitted on Win.

        * WebProcess/WebPage/ca/LayerTreeHostCA.h:
            Make setRootCompositingLayer protected so it can be called from subclass
        * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.cpp:
            Override setRootCompositingLayer to add call to root layer's
            PlatformCALayer::ensureAnimationsSubmitted method
        * WebProcess/WebPage/ca/win/LayerTreeHostCAWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Wed, 20 Apr 2011 21:02:48 +0000 (21:02 +0000)]
2011-04-20  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Adopt QTKit API for listing and deleting file in its media cache.
        <rdar://problem/9130029>
        https://bugs.webkit.org/show_bug.cgi?id=58795

        Not possible to test automatically, verified manually.

        * WebCore.exp.in: Export new media download cache functions.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.h:
        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivateQTKit::registerMediaEngine): Register cache management functions.
        (WebCore::MediaPlayerPrivateQTKit::getSitesInMediaCache): New, return cache origins.
        (WebCore::MediaPlayerPrivateQTKit::clearMediaCache): New, empty the media cache.
        (WebCore::MediaPlayerPrivateQTKit::clearMediaCacheForSite): New, delete files in the media
            cache for one origin.

        * platform/mac/WebCoreSystemInterface.h: Add new WKSI functions.
        * platform/mac/WebCoreSystemInterface.mm: Ditto.

2011-04-20  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Adopt QTKit API for listing and deleting file in its media cache.
        <rdar://problem/9130029>
        https://bugs.webkit.org/show_bug.cgi?id=58795

        * WebKitSystemInterface.h:
        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:

2011-04-20  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Adopt QTKit API for listing and deleting file in its media cache.
        <rdar://problem/9130029>

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): Initialize new functions.

2011-04-18  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Adopt QTKit API for listing and deleting file in its media cache.
        <rdar://problem/9130029>

        * WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): Initialize new functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 20 Apr 2011 21:00:10 +0000 (21:00 +0000)]
2011-04-20  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, fix duplicate expectations.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBug 59022 - DFG JIT - Optimize branch-on-relational-compare
barraclough@apple.com [Wed, 20 Apr 2011 20:47:53 +0000 (20:47 +0000)]
Bug 59022 - DFG JIT - Optimize branch-on-relational-compare

Reviewed by Oliver Hunt.

If a relational compare (< or <=) is immediately followed by a branch,
we can combine the two, avoiding generation of a boolean into a register.

* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::invert):
(JSC::MacroAssemblerX86Common::commute):
* dfg/DFGNode.h:
(JSC::DFG::Node::adjustedRefCount):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compilePeepHoleBranch):
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::isJSConstantWithInt32Value):
(JSC::DFG::SpeculativeJIT::detectPeepHoleBranch):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 20:47:31 +0000 (20:47 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Robert Hogan <robert@webkit.org>
robert@webkit.org [Wed, 20 Apr 2011 20:28:49 +0000 (20:28 +0000)]
2011-04-20  Robert Hogan  <robert@webkit.org>

        Reviewed by Antonio Gomes.

        [Qt] DRT sideeffect revealed by r63657 and r75305
        https://bugs.webkit.org/show_bug.cgi?id=42578

        Unskip tests passing since r76958

        The NetworkAccessManager's authentication cache is getting
        cleared now on every page load, so these no longer leak
        credentials between tests.

        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Wed, 20 Apr 2011 20:05:27 +0000 (20:05 +0000)]
2011-04-20  Dirk Schulze  <krit@webkit.org>

        Reviewed by Simon Fraser.

        SVG feDropShadow implementation of SVG Filters 1.2
        https://bugs.webkit.org/show_bug.cgi?id=52513

        Support different radii for horizontal and vertical blurring in ShadowBlur. This is a preperation for feDropShadow.
        feDropShadow is a new shorthand filter effect for the up-comming Filter 1.0 specification and will use ShadowBlur.
        feGaussianBlur might make use of ShadowBlur as well later (on SourceAlpha input).
        Added ShadowBlur to remaining platforms.

        The changes can't be tested before the changes in feGaussianBlur or feDropShadow. Current behavior is not affected.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.list.am:
        * WebCore.pro:
        * platform/graphics/FloatSize.h:
        (WebCore::FloatSize::scale):
        * platform/graphics/ShadowBlur.cpp:
        (WebCore::ScratchBuffer::ScratchBuffer):
        (WebCore::ScratchBuffer::setLastShadowValues):
        (WebCore::ScratchBuffer::setLastInsetShadowValues):
        (WebCore::ScratchBuffer::matchesLastShadow):
        (WebCore::ScratchBuffer::matchesLastInsetShadow):
        (WebCore::ScratchBuffer::clearScratchBuffer):
        (WebCore::ShadowBlur::ShadowBlur):
        (WebCore::calculateLobes):
        (WebCore::ShadowBlur::blurLayerImage):
        (WebCore::ShadowBlur::adjustBlurRadius):
        (WebCore::ShadowBlur::calculateLayerBoundingRect):
        (WebCore::computeSliceSizesFromRadii):
        (WebCore::ShadowBlur::templateSize):
        (WebCore::ShadowBlur::drawInsetShadowWithTiling):
        (WebCore::ShadowBlur::drawRectShadowWithTiling):
        (WebCore::ShadowBlur::drawLayerPieces):
        * platform/graphics/ShadowBlur.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRect):
        (WebCore::GraphicsContext::fillRoundedRect):
        (WebCore::GraphicsContext::fillRectWithRoundedHole):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-03-07 Victoria Kirst <vrk@google.com>
vrk@chromium.org [Wed, 20 Apr 2011 19:56:52 +0000 (19:56 +0000)]
2011-03-07  Victoria Kirst  <vrk@google.com>

        Reviewed by Mihai Parparita.

        Make LayoutTests robust to latency btwn playing event and frame rendering
        https://bugs.webkit.org/show_bug.cgi?id=55918

        * media/controls-after-reload.html:
        * media/controls-without-preload.html:
        * media/video-paint-test.js:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Taiju TSUIKI <tzik@google.com>
commit-queue@webkit.org [Wed, 20 Apr 2011 19:54:08 +0000 (19:54 +0000)]
2011-04-20  Taiju TSUIKI  <tzik@google.com>

        Reviewed by David Levin.

        Add overwrite copy/move tests for FileSystem API
        https://bugs.webkit.org/show_bug.cgi?id=58864

        * fast/filesystem/op-copy-expected.txt:
        * fast/filesystem/op-move-expected.txt:
        * fast/filesystem/resources/op-copy.js:
        * fast/filesystem/resources/op-move.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdding myself to committer list
mahesh.kulkarni@nokia.com [Wed, 20 Apr 2011 19:48:17 +0000 (19:48 +0000)]
Adding myself to committer list

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 19:38:49 +0000 (19:38 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/chromium-linux*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 20 Apr 2011 19:21:59 +0000 (19:21 +0000)]
2011-04-20  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Eric Seidel.

        add expandAll/collapseAll links
        https://bugs.webkit.org/show_bug.cgi?id=59011

        * Scripts/webkitpy/layout_tests/layout_package/json_results.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
yael.aharon@nokia.com [Wed, 20 Apr 2011 19:18:32 +0000 (19:18 +0000)]
Unreviewed.

Adjust Windows results after r84398.

* platform/win/fast/borders: Added.
* platform/win/fast/borders/bidi-012-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 19:13:12 +0000 (19:13 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/chromium-win*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoARMv7 build fix II.
barraclough@apple.com [Wed, 20 Apr 2011 19:09:51 +0000 (19:09 +0000)]
ARMv7 build fix II.

* jit/JITOpcodes32_64.cpp:
(JSC::JIT::softModulo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoARMv7 build fix.
barraclough@apple.com [Wed, 20 Apr 2011 19:02:01 +0000 (19:02 +0000)]
ARMv7 build fix.

* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::test8):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Evan Martin <evan@chromium.org>
evan@chromium.org [Wed, 20 Apr 2011 18:54:13 +0000 (18:54 +0000)]
2011-04-20  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] expose title text direction on WebDataSource
        https://bugs.webkit.org/show_bug.cgi?id=59010

        * public/WebDataSource.h:
        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::pageTitle):
        (WebKit::WebDataSourceImpl::pageTitleDirection):
        * src/WebDataSourceImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRationalize MacroAssembler branch methods
barraclough@apple.com [Wed, 20 Apr 2011 18:44:35 +0000 (18:44 +0000)]
Rationalize MacroAssembler branch methods
https://bugs.webkit.org/show_bug.cgi?id=58950

Reviewed by Oliver Hunt.

The MacroAssembler currently exposes x86's weird behaviour that the 'setcc'
instruction only sets the low 8 bits of a register. Stop that.

Having done so, to clarify remove the 'set32' prefix from test & compare
instructions - these methods all now set a full 32/64 bit register (Ptr size).
The size in the function name should indicate the amount of data being compared.

Also split out the 'Condition' enum into 'RelationalCondition' and
'ResultCondition'. The former is used in binary comparison, the latter is a unary
condition check on the result of an operation.

* JavaScriptCore.xcodeproj/project.pbxproj:
* assembler/MacroAssembler.h:
(JSC::MacroAssembler::branchPtr):
(JSC::MacroAssembler::branch32):
(JSC::MacroAssembler::branch16):
(JSC::MacroAssembler::branchTestPtr):
(JSC::MacroAssembler::comparePtr):
(JSC::MacroAssembler::branchAddPtr):
(JSC::MacroAssembler::branchSubPtr):
(JSC::MacroAssembler::branchTest8):
* assembler/MacroAssemblerARM.h:
(JSC::MacroAssemblerARM::branch8):
(JSC::MacroAssemblerARM::branch32):
(JSC::MacroAssemblerARM::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARM::branch16):
(JSC::MacroAssemblerARM::branchTest8):
(JSC::MacroAssemblerARM::branchTest32):
(JSC::MacroAssemblerARM::branchAdd32):
(JSC::MacroAssemblerARM::branchMul32):
(JSC::MacroAssemblerARM::branchSub32):
(JSC::MacroAssemblerARM::branchNeg32):
(JSC::MacroAssemblerARM::branchOr32):
(JSC::MacroAssemblerARM::compare32):
(JSC::MacroAssemblerARM::test32):
(JSC::MacroAssemblerARM::test8):
(JSC::MacroAssemblerARM::branchPtrWithPatch):
(JSC::MacroAssemblerARM::ARMCondition):
* assembler/MacroAssemblerARMv7.h:
(JSC::MacroAssemblerARMv7::branch32):
(JSC::MacroAssemblerARMv7::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerARMv7::branch16):
(JSC::MacroAssemblerARMv7::branch8):
(JSC::MacroAssemblerARMv7::branchTest32):
(JSC::MacroAssemblerARMv7::branchTest8):
(JSC::MacroAssemblerARMv7::branchAdd32):
(JSC::MacroAssemblerARMv7::branchMul32):
(JSC::MacroAssemblerARMv7::branchOr32):
(JSC::MacroAssemblerARMv7::branchSub32):
(JSC::MacroAssemblerARMv7::compare32):
(JSC::MacroAssemblerARMv7::test32):
(JSC::MacroAssemblerARMv7::test8):
(JSC::MacroAssemblerARMv7::branchPtrWithPatch):
(JSC::MacroAssemblerARMv7::makeBranch):
(JSC::MacroAssemblerARMv7::armV7Condition):
* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::branch8):
(JSC::MacroAssemblerMIPS::branch32):
(JSC::MacroAssemblerMIPS::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerMIPS::branch16):
(JSC::MacroAssemblerMIPS::branchTest32):
(JSC::MacroAssemblerMIPS::branchTest8):
(JSC::MacroAssemblerMIPS::branchAdd32):
(JSC::MacroAssemblerMIPS::branchMul32):
(JSC::MacroAssemblerMIPS::branchSub32):
(JSC::MacroAssemblerMIPS::branchOr32):
(JSC::MacroAssemblerMIPS::compare32):
(JSC::MacroAssemblerMIPS::test8):
(JSC::MacroAssemblerMIPS::test32):
(JSC::MacroAssemblerMIPS::branchPtrWithPatch):
* assembler/MacroAssemblerX86.h:
(JSC::MacroAssemblerX86::branch32):
(JSC::MacroAssemblerX86::branchPtrWithPatch):
* assembler/MacroAssemblerX86Common.h:
(JSC::MacroAssemblerX86Common::branch8):
(JSC::MacroAssemblerX86Common::branch32):
(JSC::MacroAssemblerX86Common::branch32WithUnalignedHalfWords):
(JSC::MacroAssemblerX86Common::branch16):
(JSC::MacroAssemblerX86Common::branchTest32):
(JSC::MacroAssemblerX86Common::branchTest8):
(JSC::MacroAssemblerX86Common::branchAdd32):
(JSC::MacroAssemblerX86Common::branchMul32):
(JSC::MacroAssemblerX86Common::branchSub32):
(JSC::MacroAssemblerX86Common::branchNeg32):
(JSC::MacroAssemblerX86Common::branchOr32):
(JSC::MacroAssemblerX86Common::compare32):
(JSC::MacroAssemblerX86Common::test8):
(JSC::MacroAssemblerX86Common::test32):
(JSC::MacroAssemblerX86Common::x86Condition):
* assembler/MacroAssemblerX86_64.h:
(JSC::MacroAssemblerX86_64::comparePtr):
(JSC::MacroAssemblerX86_64::branchPtr):
(JSC::MacroAssemblerX86_64::branchTestPtr):
(JSC::MacroAssemblerX86_64::branchAddPtr):
(JSC::MacroAssemblerX86_64::branchSubPtr):
(JSC::MacroAssemblerX86_64::branchPtrWithPatch):
(JSC::MacroAssemblerX86_64::branchTest8):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jit/JITOpcodes.cpp:
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::emit_op_eq):
(JSC::JIT::emit_op_neq):
(JSC::JIT::compileOpStrictEq):
(JSC::JIT::emit_op_eq_null):
(JSC::JIT::emit_op_neq_null):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace bidi-004.html with its new version.
yael.aharon@nokia.com [Wed, 20 Apr 2011 18:15:04 +0000 (18:15 +0000)]
Replace bidi-004.html with its new version.
https://bugs.webkit.org/show_bug.cgi?id=58984

Reviewed by Eric Seidel.

* fast/borders/bidi-004.html: Removed.
* fast/borders/bidi-012.html: Added.
* platform/chromium-linux/fast/borders/bidi-004-expected.png: Removed.
* platform/chromium-mac-leopard/fast/borders/bidi-004-expected.png: Removed.
* platform/chromium-win/fast/borders/bidi-004-expected.png: Removed.
* platform/chromium-win/fast/borders/bidi-004-expected.txt: Removed.
* platform/gtk/fast/borders/bidi-004-expected.checksum: Removed.
* platform/gtk/fast/borders/bidi-004-expected.png: Removed.
* platform/gtk/fast/borders/bidi-004-expected.txt: Removed.
* platform/mac/fast/borders/bidi-004-expected.checksum: Removed.
* platform/mac/fast/borders/bidi-004-expected.png: Removed.
* platform/mac/fast/borders/bidi-004-expected.txt: Removed.
* platform/mac/fast/borders/bidi-012-expected.checksum: Added.
* platform/mac/fast/borders/bidi-012-expected.png: Added.
* platform/mac/fast/borders/bidi-012-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed typo fix.
ossy@webkit.org [Wed, 20 Apr 2011 18:09:37 +0000 (18:09 +0000)]
Unreviewed typo fix.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.
kevino@webkit.org [Wed, 20 Apr 2011 17:57:58 +0000 (17:57 +0000)]
[wx] Unreviewed build fixes for wx 2.9.1, Cocoa and 64-bit builds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 17:46:28 +0000 (17:46 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/google*,
        platform/chromium-gpu*, platform/chromium-mac*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-19 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Wed, 20 Apr 2011 17:25:33 +0000 (17:25 +0000)]
2011-04-19  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 52963 - Enable O(1) access to root from any node in shadow DOM subtree
        https://bugs.webkit.org/show_bug.cgi?id=52963

        .) Change base class of ShadowRoot from DocumentFragment to TreeScope.
        .) Re-enable tree scope handling in Node (had ASSERT_NOT_REACHED, etc.).
        .) Merged setTreeScope() with setTreeScopeRecursively()
        .) Call setTreeScopeRecursively in DOM manipulation functions where applicable.
        .) Adapt JavaScript Node wrappers (temporary code - see https://bugs.webkit.org/show_bug.cgi?id=58704).

        No new tests. (refactoring)

        * bindings/js/JSNodeCustom.cpp:
        (WebCore::createWrapperInline):
        * bindings/v8/custom/V8NodeCustom.cpp:
        (WebCore::toV8Slow):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::takeAllChildrenFrom):
        (WebCore::ContainerNode::removeBetween):
        (WebCore::ContainerNode::removeChildren):
        (WebCore::ContainerNode::parserAddChild):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::setDocType):
        * dom/Element.h:
        * dom/Node.cpp:
        (WebCore::Node::treeScope):
        (WebCore::Node::setTreeScopeRecursively):
        * dom/Node.h:
        (WebCore::Node::document):
        * dom/ShadowRoot.cpp:
        (WebCore::ShadowRoot::ShadowRoot):
        (WebCore::ShadowRoot::~ShadowRoot):
        (WebCore::ShadowRoot::nodeType):
        (WebCore::ShadowRoot::cloneNode):
        (WebCore::ShadowRoot::childTypeAllowed):
        * dom/ShadowRoot.h:
        (WebCore::toShadowRoot):
        * dom/TreeScope.cpp:
        (WebCore::TreeScope::TreeScope):
        (WebCore::TreeScope::setParentTreeScope):
        * dom/TreeScope.h:
        * rendering/RenderSlider.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 17:24:37 +0000 (17:24 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Unreviewed, embedding checksums in png files in platform/mac-*.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] WebProcess crashes intermittently: "FAIL: TestControllerRunLoop timed out."
ossy@webkit.org [Wed, 20 Apr 2011 17:16:09 +0000 (17:16 +0000)]
[Qt][WK2] WebProcess crashes intermittently: "FAIL: TestControllerRunLoop timed out."

* platform/qt-wk2/Skipped: Add http/tests/security/contentSecurityPolicy/media-src-blocked.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Skip new failing tests.
ossy@webkit.org [Wed, 20 Apr 2011 17:09:34 +0000 (17:09 +0000)]
[Qt][WK2] Skip new failing tests.

* platform/qt-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Wed, 20 Apr 2011 17:06:57 +0000 (17:06 +0000)]
2011-04-20  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Dan Bernstein.

        Update fast/canvas/font-update.html to use dumpAsText.
        https://bugs.webkit.org/show_bug.cgi?id=59003

        * fast/canvas/font-update-expected.txt:
        * fast/canvas/font-update.html: This test is only useful as a pixel test. Dumping the render tree will always show the same thing regardless of what's done on the canvas in the test. However, with new render tree schemes (canvases in layers and such) the render trees will even look different but not actually failing what the test tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Vsevolod Vlasov <vsevik@chromium.org>
commit-queue@webkit.org [Wed, 20 Apr 2011 17:00:09 +0000 (17:00 +0000)]
2011-04-20  Vsevolod Vlasov  <vsevik@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Update front-end files list in WebCore.vcproj
        https://bugs.webkit.org/show_bug.cgi?id=58896

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Mike Reed <reed@google.com>
commit-queue@webkit.org [Wed, 20 Apr 2011 16:55:47 +0000 (16:55 +0000)]
2011-04-20  Mike Reed  <reed@google.com>

        Reviewed by Steve Block.

        prepare tests for rebaselining
        https://bugs.webkit.org/show_bug.cgi?id=58989

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Wed, 20 Apr 2011 16:47:14 +0000 (16:47 +0000)]
2011-04-20  Tony Chang  <tony@chromium.org>

        Fixed lint errors in test_expectations.txt.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Wed, 20 Apr 2011 16:46:31 +0000 (16:46 +0000)]
2011-04-20  Dimitri Glazkov  <dglazkov@chromium.org>

        Qt build fix after r84380.

        * css/CSSPrimitiveValueMappings.h: Moved EBorderCollapse-related casts from under ENABLE(SVG) guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 16:41:20 +0000 (16:41 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Remove crash expectation for http/tests/local/formdata/send-form-data-with-sliced-file.html
        https://bugs.webkit.org/show_bug.cgi?id=59004

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Wed, 20 Apr 2011 16:39:45 +0000 (16:39 +0000)]
2011-04-20  Alejandro G. Castro  <alex@igalia.com>

        Fixed GTK+ compilation after r84206.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 16:24:25 +0000 (16:24 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Adjust test expectations.
        https://bugs.webkit.org/show_bug.cgi?id=59002

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Carlos Garcia Campos <cgarcia@igalia.com>
carlosgc@webkit.org [Wed, 20 Apr 2011 16:21:24 +0000 (16:21 +0000)]
2011-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Build libWebCore with the gtk sources too
        https://bugs.webkit.org/show_bug.cgi?id=58968

        In some cases webcore files are compiled twice, so it improves the
        build time.

        * GNUmakefile.am: Add webcore gtk sources to libWebCore sources.
2011-04-20  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Build libWebCore with the gtk sources too
        https://bugs.webkit.org/show_bug.cgi?id=58968

        In some cases webcore files are compiled twice, so it improves the
        build time.

        * GNUmakefile.am: Remove webcore gtk sources from libwebkitgtk
        sources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Luke Macpherson <macpherson@chromium.org>
commit-queue@webkit.org [Wed, 20 Apr 2011 16:14:37 +0000 (16:14 +0000)]
2011-04-20  Luke Macpherson   <macpherson@chromium.org>

        Reviewed by Dimitri Glazkov.

        Allow casting between CSSPrimitiveValue and EBorderCollapse to remove special-case logic from CSSStyleSelector.
        https://bugs.webkit.org/show_bug.cgi?id=58964

        No new tests as no new functionality added.

        * css/CSSPrimitiveValueMappings.h:
        Support casting to/from EBorderCollapse.
        * css/CSSStyleSelector.cpp:
        Use new casting ability to simplify code.
        * rendering/style/RenderStyle.h:
        Use EBorderCollapse instead of a bool for representing border collapse member variable.
        * rendering/style/RenderStyleConstants.h:
        Added EBorderCollapse enum.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd Windows 7 SP1 baselines for some SVG tests that progressed in SP1
aroben@apple.com [Wed, 20 Apr 2011 16:11:45 +0000 (16:11 +0000)]
Add Windows 7 SP1 baselines for some SVG tests that progressed in SP1

These baselines were previously thought to be WebKit2-specific. However, it turned out that
the WebKit2 bots had Windows 7 SP1 installed, while the WebKit1 bots just had Windows 7
installed, and that was the crucial difference. So this patch reclassifies the new baselines
as being SP1 vs. not-SP1, rather than WK2 vs. WK1. I also added pixel results.

Fixes <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
differences from Windows 7 "SP0"

* platform/win-7sp0/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
* platform/win-7sp0/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
* platform/win-7sp0/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/win-7sp0/svg/text/bidi-text-query-expected.checksum:
* platform/win-7sp0/svg/text/bidi-text-query-expected.png:
* platform/win-7sp0/svg/text/bidi-text-query-expected.txt:
Copied these results from platform/win.

* platform/win-wk2/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
* platform/win-wk2/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/win-wk2/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/win-wk2/svg/text/bidi-text-query-expected.txt:
Moved these results to platform/win.

* platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.checksum:
* platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.png:
* platform/win/svg/W3C-I18N/text-dirLTR-ubOverride-expected.txt:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.checksum:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.png:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-default-context-expected.txt:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.checksum:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.png:
* platform/win/svg/W3C-I18N/tspan-dirLTR-ubOverride-in-ltr-context-expected.txt:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.checksum:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.png:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.checksum:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.png:
* platform/win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/win/svg/text/bidi-text-query-expected.checksum:
* platform/win/svg/text/bidi-text-query-expected.png:
* platform/win/svg/text/bidi-text-query-expected.txt:
The .txt files came from platform/win-wk2, and the .png/.checksum files were
newly-generated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 20 Apr 2011 16:05:56 +0000 (16:05 +0000)]
2011-04-20  Martin Robinson  <mrobinson@igalia.com>

        platform/gtk/fast/dom/gc-10-expected.png is corrupt
        https://bugs.webkit.org/show_bug.cgi?id=58940

        Remove expected results for fast/dom/gc-10.html since it is crashing on GTK+.

        * platform/gtk/fast/dom/gc-10-expected.checksum: Removed.
        * platform/gtk/fast/dom/gc-10-expected.png: Removed.
        * platform/gtk/fast/dom/gc-10-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReplace old-run-webkit-tests's win-7 platform with win-7sp0
aroben@apple.com [Wed, 20 Apr 2011 16:05:36 +0000 (16:05 +0000)]
Replace old-run-webkit-tests's win-7 platform with win-7sp0

It was an error that we had a win-7 platform to begin with. Windows 7 was the most recent
version of Windows we cared about, so its results should just go in win. But now that
Windows 7 SP1 exists (and has different results for some tests), we need a place to store
results for Windows 7 without SP1 (and older versions of Windows).

Part of <http://webkit.org/b/56617> Several tests fail on Windows 7 SP1 due to font
differences from Windows 7 "SP0"

Reviewed by David Kilzer.

* Scripts/old-run-webkit-tests: Replaced win-7 with win-7sp0. Newer versions of Windows 7
will just use "win".

* Scripts/webkitdirs.pm:
(isWindows7SP0): Added. Replaces isWindows7, because that function had no remaining callers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 15:44:15 +0000 (15:44 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark css2.1/t140201-c533-bgimage-00-a.html as crash on Linux, Win Debug
        https://bugs.webkit.org/show_bug.cgi?id=58995

Accidentally indicated MAC instead of WIN.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-20 John Knottenbelt <jknotten@chromium.org>
jknotten@chromium.org [Wed, 20 Apr 2011 15:39:55 +0000 (15:39 +0000)]
2011-04-20  John Knottenbelt  <jknotten@chromium.org>

        Unreviewed.

        [Chromium] Mark css2.1/t140201-c533-bgimage-00-a.html as crash on Linux, Win Debug
        https://bugs.webkit.org/show_bug.cgi?id=58995

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-04-19 Stephen White <senorblanco@chromium.org>
senorblanco@chromium.org [Wed, 20 Apr 2011 14:54:25 +0000 (14:54 +0000)]
2011-04-19  Stephen White  <senorblanco@chromium.org>

        Reviewed by Kenneth Russell.

        Move and rename GLES2Canvas.
        https://bugs.webkit.org/show_bug.cgi?id=58927

        Move GLES2Canvas to platform/graphcs/gpu, where all the other
        gpu-related files live, and rename it to GraphicsContextGPU to better
        reflect its purpose.

        Covered by existing tests.

        * WebCore.gypi:
        * platform/graphics/chromium/GLES2Canvas.cpp:
        * platform/graphics/chromium/GLES2Canvas.h:
        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::fillPath):
        (WebCore::GraphicsContext::setPlatformShadow):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::drawBitmapGLES2):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (WebCore::PlatformContextSkia::setSharedGraphicsContext3D):
        * platform/graphics/skia/PlatformContextSkia.h:
        (WebCore::PlatformContextSkia::gpuCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Clean the style of our cookie methods
benjamin.poulain@nokia.com [Wed, 20 Apr 2011 14:46:52 +0000 (14:46 +0000)]
[Qt] Clean the style of our cookie methods
https://bugs.webkit.org/show_bug.cgi?id=58987

Reviewed by Andreas Kling.

Got rid of the variables named "u" in favor just converting the url when needed.

* platform/qt/CookieJarQt.cpp:
(WebCore::setCookies): The variable p was unused.
The ::toAscii() depends on the default codec, use toLatin1() instead.
(WebCore::cookies): foreach() should use const reference.
(WebCore::cookieRequestHeaderFieldValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTeach webkitdirs::winVersion about build numbers
aroben@apple.com [Wed, 20 Apr 2011 14:44:05 +0000 (14:44 +0000)]
Teach webkitdirs::winVersion about build numbers

The build number isn't currently used, but soon will be.

As a bonus, winVersion now works on non-Cygwin variants of Perl!

Fixes <http://webkit.org/b/58991> Need a way to distinguish between Windows 7 and Windows 7
SP1

Reviewed by Anders Carlsson.

* Scripts/webkitdirs.pm:
(isAnyWindows): Added. Returns true if we're running on any Windows-ish Perl.
(determineWinVersion): Use `cmd /c ver` to get the version number, including the build
number. Parse the version number into a hash, similar to how osXVersion() works.

(isWindows7):
(isWindowsVista):
(isWindowsXP):
Updated for changes to winVersion().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@84372 268f45cc-cd09-0410-ab3c-d52691b4dbfc