WebKit-https.git
12 years ago2008-03-12 Michael Emmel <mike.emmel@gmail.com>
alp@webkit.org [Fri, 11 Apr 2008 00:45:17 +0000 (00:45 +0000)]
2008-03-12  Michael Emmel  <mike.emmel@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18397
        Fix leaving spaces before parens in functions

        * WebKitTools/Scripts/wkstyle:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-10 Mario Bensi <mbensi@pleyo.com>
alp@webkit.org [Fri, 11 Apr 2008 00:30:33 +0000 (00:30 +0000)]
2008-04-10  Mario Bensi  <mbensi@pleyo.com>

        Reviewed by Alp Toker.

        https://bugs.webkit.org/show_bug.cgi?id=18400
        Database example doesn't work on Gtk port

        Fix quota in ChromeClient

        * WebCoreSupport/ChromeClientGtk.cpp:
        (WebKit::ChromeClient::exceededDatabaseQuota):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes floating point precision in the Resources graph labels by using String.sprintf to
timothy@apple.com [Thu, 10 Apr 2008 23:56:47 +0000 (23:56 +0000)]
Fixes floating point precision in the Resources graph labels by using String.sprintf to
format the values. Also makes the image view use Number.bytesToString when showing the file
size. Makes Number.bytesToString and Number.secondsToString take an optional formatter function
so the Inspector can pass WebInspector.UIString, so the format strings can be localized.

https://bugs.webkit.org/show_bug.cgi?id=18381
https://bugs.webkit.org/show_bug.cgi?id=14333

Reviewed by Adam Roben.

* English.lproj/InspectorLocalizedStrings.js: Added the new strings.
* page/inspector/ImageView.js:
(WebInspector.ImageView): Use Number.bytesToString to format this.resource.contentLength.
* page/inspector/ResourcesPanel.js:
(WebInspector.ResourceTransferTimeCalculator.prototype.formatValue): Pass WebInspector.UIString
to Number.secondsToString.
(WebInspector.ResourceTransferSizeCalculator.prototype.formatValue): Pass WebInspector.UIString
to Number.bytesToString.
* page/inspector/utilities.js:
(Number.secondsToString): Added a formatterFunction argument. Use the formatter and format strings
to control the number precision.
(Number.bytesToString): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
alice.liu@apple.com [Thu, 10 Apr 2008 23:42:20 +0000 (23:42 +0000)]
WebCore:

2008-04-010  Alice Liu  <alice.liu@apple.com>

        Reviewed by Dan Bernstein.

        Fixed <rdar://5815856> CrashTracer: [USER] 8384 crashes in WebCore::Widget::getView const + 6

        Test: fast/events/mouseout-dead-subframe.html

        * page/EventHandler.cpp:
        dispatching a mouse event can change the document structure, necessitating
        a check for whether we still want to pass the event to the pre-determined subframe
        (WebCore::EventHandler::handleMouseMoveEvent):

LayoutTests:

2008-04-10  Alice Liu  <alice.liu@apple.com>

        Reviewed by Dan Bernstein.

        Added test for <rdar://5815856> CrashTracer: [USER] 8384 crashes in WebCore::Widget::getView const + 6

        * fast/events/mouseout-dead-subframe-expected.txt: Added.
        * fast/events/mouseout-dead-subframe.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix https://bugs.webkit.org/show_bug.cgi?id=18367 and the many dupes.
mrowe@apple.com [Thu, 10 Apr 2008 22:51:33 +0000 (22:51 +0000)]
Fix https://bugs.webkit.org/show_bug.cgi?id=18367 and the many dupes.
Bug 18367: Crash during celtic kane js speed 2007 test

Reviewed by Maciej Stachowiak.

GCC 4.2 on x86_64 Linux decided to reorder the local variables in markCurrentThreadConservatively's
stack frame.  This lead to the range of addresses the collector treated as stack to exclude the
contents of volatile registers that markCurrentThreadConservatively forces onto the stack.  This was
leading to objects being prematurely collected if the only reference to them was via a register at
the time a collection occurred.

The fix for this is to move the calculation of the top of the stack into a NEVER_INLINE function
that is called from markCurrentThreadConservatively.  This forces the dummy variable we use for
determining the top of stack to be in a different stack frame which prevents the compiler from
reordering it relative to the registers that markCurrentThreadConservatively forces onto the stack.

* kjs/collector.cpp:
(KJS::Collector::markCurrentThreadConservativelyInternal):
(KJS::Collector::markCurrentThreadConservatively):
* kjs/collector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added WebCoreStatistics that provides stats on Javascript objects
adachan@apple.com [Thu, 10 Apr 2008 22:30:49 +0000 (22:30 +0000)]
    Added WebCoreStatistics that provides stats on Javascript objects
        and IconDatabase.

        Changed WebCache::statistics() to additionally return xsl stylesheets data
        and data on live sizes and decoded sizes.

        Reviewed by Steve.

        * ForEachCoClass.h:
        * Interfaces/IWebCoreStatistics.idl: Added.
        * Interfaces/WebKit.idl:
        * WebCache.cpp:
        (WebCache::statistics):
        * WebCoreStatistics.cpp: Added.
        (WebCoreStatistics::WebCoreStatistics):
        (WebCoreStatistics::~WebCoreStatistics):
        (WebCoreStatistics::createInstance):
        (WebCoreStatistics::QueryInterface):
        (WebCoreStatistics::AddRef):
        (WebCoreStatistics::Release):
        (WebCoreStatistics::javaScriptObjectsCount):
        (WebCoreStatistics::javaScriptGlobalObjectsCount):
        (WebCoreStatistics::javaScriptProtectedObjectsCount):
        (WebCoreStatistics::javaScriptProtectedGlobalObjectsCount):
        (WebCoreStatistics::iconPageURLMappingCount):
        (WebCoreStatistics::iconRetainedPageURLCount):
        (WebCoreStatistics::iconRecordCount):
        (WebCoreStatistics::iconsWithDataCount):
        * WebCoreStatistics.h: Added.
        * WebKit.vcproj/WebKit.vcproj:
        * WebKitClassFactory.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-10 Antti Koivisto <antti@apple.com>
antti@apple.com [Thu, 10 Apr 2008 22:24:33 +0000 (22:24 +0000)]
2008-04-10  Antti Koivisto  <antti@apple.com>

        Reviewed by Eric.

        Fix scale transform. This will be tested by the animation test suite when
        SVG animation support lands.

        * svg/SVGTransformDistance.cpp:
        (WebCore::SVGTransformDistance::SVGTransformDistance):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 10 Apr 2008 20:25:16 +0000 (20:25 +0000)]
2008-04-10  David Hyatt  <hyatt@apple.com>

        Add a gradient fillRect method to GraphicsContext.  This is implemented only in the CG port.  I stubbed
        out a method in GraphicsContext.cpp with notImplemented().  Other platforms will need to add their own
        gradient fill methods.

        Reviewed by aroben

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::fillRect):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cg/GraphicsContextCG.cpp:
        (WebCore::GraphicsContext::fillRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-10 David Hyatt <hyatt@apple.com>
hyatt@apple.com [Thu, 10 Apr 2008 19:35:45 +0000 (19:35 +0000)]
2008-04-10  David Hyatt  <hyatt@apple.com>

        Gradient improvements.  Support for adding color stops by Color and not just by String.  Add the ability to mark
        stops as already being sorted.

        Reviewed by aroben

        * platform/graphics/Gradient.cpp:
        (WebCore::Gradient::addColorStop):
        * platform/graphics/Gradient.h:
        (WebCore::Gradient::setStopsSorted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes the build where some wtf headers would not be copied due
timothy@apple.com [Thu, 10 Apr 2008 19:25:06 +0000 (19:25 +0000)]
Fixes the build where some wtf headers would not be copied due
to a bug in some older versions of Xcode.

Rubber-stamped by Adam Roben.

* WebCore.xcodeproj/project.pbxproj: Adds a new script phase to handle
the copying of the icu and ForwardingHeaders folder to WebCore's PrivateHeaders.
Removes the old copy files phase and the icu and ForwardingHeaders folder references.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Delete backing store (after a delay) when a WebView's top-level parent become...
sfalken@apple.com [Thu, 10 Apr 2008 18:46:05 +0000 (18:46 +0000)]
    Delete backing store (after a delay) when a WebView's top-level parent becomes inactive.

        Reviewed by Brady Eidson.

        * WebView.cpp:
        (WebView::windowReceivedMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-10 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 10 Apr 2008 17:42:13 +0000 (17:42 +0000)]
2008-04-10  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel

        DOM Storage layout test cleanup

        * storage/domstorage/sessionstorage/iframe-events.html: Check for the layoutTestController in a manner that
          won't confuse Firefox
        * storage/domstorage/sessionstorage/resources/clearSessionStorage.js: Don't mutate while iterating!  Clea
          the sessionStorage properly

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTouch a file to force WTF.vcproj to build
aroben@apple.com [Thu, 10 Apr 2008 16:03:42 +0000 (16:03 +0000)]
Touch a file to force WTF.vcproj to build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago VC++ Express build fix
aroben@apple.com [Thu, 10 Apr 2008 15:25:02 +0000 (15:25 +0000)]
    VC++ Express build fix

        * JavaScriptCore.vcproj/WTF/WTF.vcproj: Link against user32.lib so
        that anyone who links against WTF.lib will get user32.lib
        automatically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-09 Brady Eidson <beidson@apple.com>
beidson@apple.com [Thu, 10 Apr 2008 06:52:20 +0000 (06:52 +0000)]
2008-04-09  Brady Eidson  <beidson@apple.com>

        Forgot to check in this updated result with my Storage-enumeration change
        earlier today

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Thu, 10 Apr 2008 06:49:52 +0000 (06:49 +0000)]
WebCore:

2008-04-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel

        Add the "onstorage" attribute for the body element to provide easy setup of StorageEvent handling.

        Tests: storage/domstorage/sessionstorage/onstorage-attribute-markup.html
               storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html

        * html/HTMLAttributeNames.in: Added "onstorage"
        * html/HTMLBodyElement.cpp:
        (WebCore::HTMLBodyElement::parseMappedAttribute): Handle this attribute on the body element *only*
          because that's where the HTML5 spec says StorageEvents go.  This might change in the future

LayoutTests:

2008-04-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitz Pettel

        Add the "onstorage" attribute for the body element to provide easy setup of StorageEvent handling.

        * storage/domstorage/sessionstorage/onstorage-attribute-markup-expected.txt: Added.
        * storage/domstorage/sessionstorage/onstorage-attribute-markup.html: Added.
        * storage/domstorage/sessionstorage/onstorage-attribute-setattribute-expected.txt: Added.
        * storage/domstorage/sessionstorage/onstorage-attribute-setattribute.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-09 Antti Koivisto <antti@apple.com>
antti@apple.com [Thu, 10 Apr 2008 00:55:51 +0000 (00:55 +0000)]
2008-04-09  Antti Koivisto  <antti@apple.com>

        Reviewed by Mitz.

        Remove a less-than-critical bit from Node and replace it with a hash. Those bits are valuable!

        Also moved setting of the guard to dispatchSimulatedClick for better consistency.
        No one else calls dispatchSimulatedMouseEvent() currently and this is really a click() specific behavior.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchSimulatedMouseEvent):
        (WebCore::EventTargetNode::dispatchSimulatedClick):
        * dom/Node.cpp:
        (WebCore::Node::Node):
        * dom/Node.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-09 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 10 Apr 2008 00:23:06 +0000 (00:23 +0000)]
2008-04-09  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        Fix for https://bugs.webkit.org/show_bug.cgi?id=18389
        Crash in JSDOMWindowWrapper::mark loading digg.com

        - Add a null check to JSDOMWindowWrapper::mark for the case when the collector
          runs during its allocation.
        - Cleans up the creation of the window to be a little more straight forward.

        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBasePrivate::JSDOMWindowBasePrivate):
        (WebCore::JSDOMWindowBase::JSDOMWindowBase):
        (WebCore::JSDOMWindowBase::clear):
        (WebCore::JSDOMWindowBase::wrapper):
        * bindings/js/JSDOMWindowBase.h:
        * bindings/js/JSDOMWindowWrapper.cpp:
        (WebCore::JSDOMWindowWrapper::JSDOMWindowWrapper):
        (WebCore::JSDOMWindowWrapper::mark):
        * bindings/js/JSDOMWindowWrapper.h:
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::initScript):
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago VC++ Express build fix
aroben@apple.com [Thu, 10 Apr 2008 00:21:27 +0000 (00:21 +0000)]
    VC++ Express build fix

        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj: Link against
        user32.lib.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-09 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 9 Apr 2008 23:29:48 +0000 (23:29 +0000)]
2008-04-09  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Mitzpettel

        Added HTMLAttributeNames.in and HTMLTagNames.in to the xcodeproj for easy editing,
        and sorted the html group

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31764 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-09 Brent Fulgham <bfulgham@gmail.com>
pewtermoose@webkit.org [Wed, 9 Apr 2008 23:20:32 +0000 (23:20 +0000)]
2008-04-09  Brent Fulgham  <bfulgham@gmail.com>

        Reviewed by Mitz.

        Correct build regression in Windows (Cairo) build due to changes
        in FontDescription.h signature.  (see http://bugs.webkit.org/show_bug.cgi?id=18394)

        * rendering/RenderThemeWin.cpp:  Change for new font methods.
        (WebCore::RenderThemeWin::systemFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31763 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Wed, 9 Apr 2008 23:18:48 +0000 (23:18 +0000)]
WebCore:

2008-04-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        When enumerating a Storage object, the Storage built-ins should not be included, but the
        prototype chain SHOULD be included.

        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::customGetPropertyNames): Return false so the prototype chain is walked

        * storage/Storage.idl: Mark all built-ins as "DontEnum"

LayoutTests:

2008-04-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Sam Weinig

        When enumerating a Storage object, the Storage built-ins should not be included, but the
        prototype chain SHOULD be included.

        Updated the layout test to test this.
        * storage/domstorage/sessionstorage/enumerate-storage-expected.txt:
        * storage/domstorage/sessionstorage/enumerate-storage.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Sam Weinig.
mitz@apple.com [Wed, 9 Apr 2008 22:36:04 +0000 (22:36 +0000)]
    Reviewed by Sam Weinig.

        - fix more Windows layout test regressions from the font-weight patch

        The patch silently introduced the ability to select some fonts
        by their full name on Windows. Firefox and IE allow the same.
        This made these tests use different, Windows-only fonts on
        Windows. The patch removes references to these fonts from the
        tests.

        * tables/mozilla/bugs/bug4093.html:
        * tables/mozilla/bugs/bug43854-1.html:
        * tables/mozilla/bugs/bug8381.html:
        * tables/mozilla/core/bloomberg.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Wed, 9 Apr 2008 21:21:40 +0000 (21:21 +0000)]
WebCore:

2008-04-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben

        Per the HTML5 spec, enumerating a Storage object should walk the keys in the storage area,
        and should not return the built-in properties.

        Test: storage/domstorage/sessionstorage/enumerate-storage.html

        * bindings/js/JSLocationCustom.cpp:
        (WebCore::JSLocation::customGetPropertyNames): Removed the name from an unused parameter

        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::customGetPropertyNames): Copy all of the keys into the property names array

        * storage/Storage.idl: Add CustomGetPropertyNames

LayoutTests:

2008-04-09  Brady Eidson  <beidson@apple.com>

        Reviewed by Adam Roben

        Per the HTML5 spec, enumerating a Storage object should walk the keys in the storage area,
        and should not return the built-in properties.

        This test adds some keys to sessionStorage, enumerates the sessionStorage object, and logs
        the sorted result.  It should *not* contain the built in properties of the Storage object

        * storage/domstorage/sessionstorage/enumerate-storage-expected.txt: Added.
        * storage/domstorage/sessionstorage/enumerate-storage.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes the regression where resource time/size pills do not
timothy@apple.com [Wed, 9 Apr 2008 20:36:36 +0000 (20:36 +0000)]
Fixes the regression where resource time/size pills do not
update during a load in the Inspector.

http://bugs.webkit.org/show_bug.cgi?id=18374

Reviewed by John Sullivan.

* page/inspector/ResourcesPanel.js:
(ResourcesPanel.prototype.show): Remove an unneeded call to _updateGraphBars,
since _updateSidebarWidth already calls _updateGraphBars.
(ResourcesPanel.prototype.addResource): Call updateGraphSideWidth.
(ResourcesPanel.prototype._updateGraphBars): Ditto.
(ResourceSidebarTreeElement.prototype.updateGraphSideWidth): Update the
style for graphSideElement with the passed in width.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-09 Antti Koivisto <antti@apple.com>
antti@apple.com [Wed, 9 Apr 2008 18:36:49 +0000 (18:36 +0000)]
2008-04-09  Antti Koivisto  <antti@apple.com>

        Reviewed by Mitz.

        Avoid unnecessary calls to virtual updateStyleAttributeIfNeeded() method.
        - do the the checking in call sites instead of inside the function
        - rename to updateStyleAttribute()
        - use namedAttrMap directly (for getting id attribute) in insertedIntoDocument/removedFromDocument
          to avoid calling attributes() which may trigger style attribute update.

        * dom/Element.cpp:
        (WebCore::Element::attributes):
        (WebCore::Element::getAttribute):
        (WebCore::Element::hasAttributes):
        (WebCore::Element::insertedIntoDocument):
        (WebCore::Element::removedFromDocument):
        * dom/Element.h:
        (WebCore::Element::updateStyleAttribute):
        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::addAttribute):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::updateStyleAttribute):
        * dom/StyledElement.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoA more complete fix for: can't drag the Web Inspector when grabbing
timothy@apple.com [Wed, 9 Apr 2008 17:01:19 +0000 (17:01 +0000)]
A more complete fix for: can't drag the Web Inspector when grabbing
in the toolbar area. Makes dragging under the search field in the
empty space work again.

http://bugs.webkit.org/show_bug.cgi?id=18373

Reviewed by Adam Roben.

* page/inspector/inspector.js:
(WebInspector.toolbarDragStart): Prevent dragging if the event target
is a toggleable toolbar item. Allow dragging when the target is a
normal toolbar item.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
aroben@apple.com [Wed, 9 Apr 2008 15:28:58 +0000 (15:28 +0000)]
    Build fix

        * JavaScriptCore.exp: Export isMainThread.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
aroben@apple.com [Wed, 9 Apr 2008 15:18:47 +0000 (15:18 +0000)]
    Build fix

        * wtf/AlwaysInline.h: Make sure to #include Platform.h before using
        the macros it defines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Wed, 9 Apr 2008 06:18:53 +0000 (06:18 +0000)]
2008-04-08  Mark Rowe  <mrowe@apple.com>

        Export WTF::initializeThreading() from JavaScriptCore.

        * JavaScriptCore.exp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-08 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 9 Apr 2008 05:13:44 +0000 (05:13 +0000)]
2008-04-08  Sam Weinig  <sam@webkit.org>

        Reviewed by Timothy Hatcher.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=18373
        REGRESSION: Can't drag the Web Inspector when grabbing in the toolbar area

        * page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31748 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-08 Christian Persch <chpe@gnome.org>
alp@webkit.org [Wed, 9 Apr 2008 03:21:16 +0000 (03:21 +0000)]
2008-04-08  Christian Persch  <chpe@gnome.org>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18360
        "missing sentinel" warnings in PluginDatabaseGtk.cpp

        Use NULL, not 0 as sentinel in varargs calls.

        * plugins/gtk/PluginDatabaseGtk.cpp:
        (WebCore::PluginDatabase::getPluginPathsInDirectories):
        (WebCore::PluginDatabase::defaultPluginDirectories):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
weinig@apple.com [Wed, 9 Apr 2008 02:17:49 +0000 (02:17 +0000)]
JavaScriptCore:

2008-04-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        First step in implementing the "split window"

        - Add a GlobalThisValue to ExecState which should be used
          in places that used to implement the "use the global object
          as this if null" rule.
        - Factor out lookupGetter/lookupSetter into virtual methods
          on JSObject so that they can be forwarded.
        - Make defineGetter/defineSetter virtual methods for the same
          reason.
        - Have PrototypeReflexiveFunction store the globalObject used
          to create it so that it can be used to get the correct thisObject
          for eval.

        * API/JSObjectRef.cpp:
        (JSObjectCallAsFunction):
        * JavaScriptCore.exp:
        * kjs/Activation.h:
        * kjs/ExecState.cpp:
        (KJS::ExecState::ExecState):
        (KJS::GlobalExecState::GlobalExecState):
        * kjs/ExecState.h:
        (KJS::ExecState::globalThisValue):
        * kjs/ExecStateInlines.h:
        (KJS::ExecState::ExecState):
        (KJS::FunctionExecState::FunctionExecState):
        * kjs/JSGlobalObject.cpp:
        (KJS::JSGlobalObject::reset):
        (KJS::JSGlobalObject::toGlobalObject):
        * kjs/JSGlobalObject.h:
        (KJS::JSGlobalObject::JSGlobalObjectData::JSGlobalObjectData):
        (KJS::JSGlobalObject::JSGlobalObject):
        * kjs/array_instance.cpp:
        (KJS::CompareWithCompareFunctionArguments::CompareWithCompareFunctionArguments):
        (KJS::compareWithCompareFunctionForQSort):
        * kjs/array_object.cpp:
        (KJS::arrayProtoFuncSort):
        (KJS::arrayProtoFuncFilter):
        (KJS::arrayProtoFuncMap):
        (KJS::arrayProtoFuncEvery):
        (KJS::arrayProtoFuncForEach):
        (KJS::arrayProtoFuncSome):
        * kjs/function.cpp:
        (KJS::FunctionImp::callAsFunction):
        (KJS::ActivationImp::toThisObject):
        (KJS::globalFuncEval):
        (KJS::PrototypeReflexiveFunction::PrototypeReflexiveFunction):
        (KJS::PrototypeReflexiveFunction::mark):
        * kjs/function.h:
        (KJS::PrototypeReflexiveFunction::cachedGlobalObject):
        * kjs/function_object.cpp:
        (KJS::functionProtoFuncApply):
        (KJS::functionProtoFuncCall):
        * kjs/nodes.cpp:
        (KJS::ExpressionNode::resolveAndCall):
        (KJS::FunctionCallValueNode::evaluate):
        (KJS::LocalVarFunctionCallNode::inlineEvaluate):
        (KJS::ScopedVarFunctionCallNode::inlineEvaluate):
        (KJS::FunctionCallBracketNode::evaluate):
        (KJS::FunctionCallDotNode::inlineEvaluate):
        * kjs/object.cpp:
        (KJS::JSObject::call):
        (KJS::JSObject::put):
        (KJS::tryGetAndCallProperty):
        (KJS::JSObject::lookupGetter):
        (KJS::JSObject::lookupSetter):
        (KJS::JSObject::toThisObject):
        (KJS::JSObject::toGlobalObject):
        (KJS::JSObject::fillGetterPropertySlot):
        * kjs/object.h:
        * kjs/object_object.cpp:
        (KJS::objectProtoFuncLookupGetter):
        (KJS::objectProtoFuncLookupSetter):
        * kjs/string_object.cpp:
        (KJS::replace):

WebCore:

2008-04-04  Sam Weinig  <sam@webkit.org>

        Reviewed by Geoffrey Garen.

        First step in implementing the "split window"

        - This patch takes the first step in changing the window navigation model
          from clearing the window properties on navigation, to replacing
          an inner window.  This is necessary to safely perform security checks
          using the lexical global object.

          This first step adds a new class called JSDOMWindowWrapper, which wraps
          the real window object.  All JS calls that would go to the window object
          now go to it, which it forwards to the current inner window.  To accomplish
          this, the wrapper window is used as the ThisValue wherever the window was used
          before.

        * WebCore.base.exp:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSDOMWindowBase.cpp:
        (WebCore::JSDOMWindowBase::JSDOMWindowBase):
        (WebCore::JSDOMWindowBase::clear): Reset the wrapper windows prototype too.
        (WebCore::JSDOMWindowBase::toThisObject):
        (WebCore::JSDOMWindowBase::wrapper):
        (WebCore::windowProtoFuncAToB):
        (WebCore::windowProtoFuncBToA):
        (WebCore::windowProtoFuncOpen):
        (WebCore::windowProtoFuncSetTimeout):
        (WebCore::windowProtoFuncClearTimeout):
        (WebCore::windowProtoFuncSetInterval):
        (WebCore::windowProtoFuncAddEventListener):
        (WebCore::windowProtoFuncRemoveEventListener):
        (WebCore::windowProtoFuncShowModalDialog):
        (WebCore::windowProtoFuncNotImplemented):
        (WebCore::toJS):
        * bindings/js/JSDOMWindowBase.h:
        Fix to expect the wrapper as the thisObj.
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::postMessage):
        (WebCore::toDOMWindow):
        * bindings/js/JSDOMWindowWrapper.cpp: Added.
        (WebCore::):
        (WebCore::JSDOMWindowWrapper::JSDOMWindowWrapper):
        (WebCore::JSDOMWindowWrapper::~JSDOMWindowWrapper):
        (WebCore::JSDOMWindowWrapper::mark):
        (WebCore::JSDOMWindowWrapper::className):
        (WebCore::JSDOMWindowWrapper::getOwnPropertySlot):
        (WebCore::JSDOMWindowWrapper::put):
        (WebCore::JSDOMWindowWrapper::deleteProperty):
        (WebCore::JSDOMWindowWrapper::getPropertyNames):
        (WebCore::JSDOMWindowWrapper::getPropertyAttributes):
        (WebCore::JSDOMWindowWrapper::defineGetter):
        (WebCore::JSDOMWindowWrapper::defineSetter):
        (WebCore::JSDOMWindowWrapper::lookupGetter):
        (WebCore::JSDOMWindowWrapper::lookupSetter):
        (WebCore::JSDOMWindowWrapper::toGlobalObject):
        (WebCore::JSDOMWindowWrapper::impl):
        (WebCore::JSDOMWindowWrapper::disconnectFrame):
        (WebCore::JSDOMWindowWrapper::clear):
        (WebCore::toJS):
        * bindings/js/JSDOMWindowWrapper.h: Added.
        (WebCore::JSDOMWindowWrapper::innerWindow):
        (WebCore::JSDOMWindowWrapper::setInnerWindow):
        (WebCore::JSDOMWindowWrapper::classInfo):
        Forward methods to the innerWindow.
        * bindings/js/JSHTMLDocumentCustom.cpp:
        (WebCore::JSHTMLDocument::open):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::execute):
        * bindings/js/kjs_events.cpp:
        (WebCore::JSAbstractEventListener::handleEvent):
        * bindings/js/kjs_proxy.cpp:
        (WebCore::KJSProxy::~KJSProxy):
        (WebCore::KJSProxy::evaluate):
        (WebCore::KJSProxy::clear):
        (WebCore::KJSProxy::initScript):
        (WebCore::KJSProxy::clearDocumentWrapper):
        (WebCore::KJSProxy::processingUserGesture):
        (WebCore::KJSProxy::attachDebugger):
        * bindings/js/kjs_proxy.h:
        (WebCore::KJSProxy::haveWindowWrapper):
        (WebCore::KJSProxy::windowWrapper):
        (WebCore::KJSProxy::globalObject):
        (WebCore::KJSProxy::initScriptIfNeeded):
        Hold onto the wrapper window instead of global object.  As a convenience,
        keep the globalObject() as a forward to the inner window.
        * bindings/objc/DOMUtility.mm:
        (KJS::createDOMWrapper):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.cpp:
        (WebCore::Document::domWindow):
        * dom/Document.h:
        (WebCore::Document::defaultView):
        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::dispatchWindowObjectAvailable):
        * page/DOMWindow.idl:
        * page/Frame.cpp:
        (WebCore::Frame::~Frame):
        (WebCore::Frame::pageDestroyed):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
beidson@apple.com [Wed, 9 Apr 2008 01:02:17 +0000 (01:02 +0000)]
JavaScriptCore:

2008-04-08  Brady Eidson  <beidson@apple.com>

        Encourage Windows to rebuild - AGAIN...

        * kjs/DateMath.cpp:

WebCore:

2008-04-08  Brady Eidson  <beidson@apple.com>

        Encourage Windows to rebuild - AGAIN...

        * WebCore.vcproj/build-generated-files.sh:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-08 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 9 Apr 2008 00:10:37 +0000 (00:10 +0000)]
2008-04-08  Brady Eidson  <beidson@apple.com>

        OMG release builds didn't have this flag Windows build bots I'm so
        sorry will you ever forgive me?

        (Found by Stephanie, rubberstamped and landed by Brady)

        * WebCore.vcproj/WebCore.vcproj: Add ENABLE_DOM_STORAGE for release builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes a crash in KJS::JSValue::toObject when closing
timothy@apple.com [Wed, 9 Apr 2008 00:06:12 +0000 (00:06 +0000)]
Fixes a crash in KJS::JSValue::toObject when closing
Safari with Inspector open.

http://bugs.webkit.org/show_bug.cgi?id=18371

Reviewed by Adam Roben.

* page/InspectorController.cpp:
(WebCore::inspectedWindow): NULL check the result of toJSDOMWindow.
Return JSNull if JSDOMWindow is 0.
* page/inspector/ElementsPanel.js:
(ElementsPanel.prototype.reset): NULL check the result of
InspectorController.inspectedWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Export callOnMainThread from WebKit.dll
aroben@apple.com [Tue, 8 Apr 2008 23:57:23 +0000 (23:57 +0000)]
    Export callOnMainThread from WebKit.dll

        Rubberstamped by Anders.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd some updated proposals for CSS specifications, such as
dino@apple.com [Tue, 8 Apr 2008 23:07:57 +0000 (23:07 +0000)]
Add some updated proposals for CSS specifications, such as
Transforms and Transitions which are already implemented in TOT.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Wx build fix
aroben@apple.com [Tue, 8 Apr 2008 21:57:48 +0000 (21:57 +0000)]
    Wx build fix

        * webcore-wx.bkl: Removed entry for non-existent file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago qmake build fixes
aroben@apple.com [Tue, 8 Apr 2008 21:52:30 +0000 (21:52 +0000)]
    qmake build fixes

        * WebCore.pro: Removed entries for non-existent files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Mac build fix
aroben@apple.com [Tue, 8 Apr 2008 21:34:04 +0000 (21:34 +0000)]
    Mac build fix

        * JavaScriptCore.exp: Add callOnMainThread, and sorted the list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoStrongly encourage Windows bots to rebuild with DOM_STORAGE enabled
beidson@apple.com [Tue, 8 Apr 2008 21:28:08 +0000 (21:28 +0000)]
Strongly encourage Windows bots to rebuild with DOM_STORAGE enabled

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoImplements the majority of the Inspector UI refresh as shown at:
timothy@apple.com [Tue, 8 Apr 2008 21:04:45 +0000 (21:04 +0000)]
Implements the majority of the Inspector UI refresh as shown at:
http://trac.webkit.org/projects/webkit/wiki/ProposedWebInspectorUIRefresh

http://bugs.webkit.org/show_bug.cgi?id=17773

A few areas that have not been re-implemented with the new UI are:
* Search and search results.
* Request and response headers in the Resources panel.
* Changing the sorting, grouping or toggling small rows in Resources.
* Image and font previews in the icon of resources.

Reviewed by Adam Roben.

* English.lproj/InspectorLocalizedStrings.js: Updated to match actual strings.
* WebCore.vcproj/WebCore.vcproj: Added new files.
* page/InspectorController.cpp:
(WebCore::InspectorController::setWindowVisible): Call resetScriptObjects()
instead of individual clear functions.
(WebCore::InspectorController::populateScriptObjects): Renamed from
populateScriptResources.
(WebCore::InspectorController::addDatabaseScriptResource): Call
addDatabase instead of addResource.
(WebCore::InspectorController::removeDatabaseScriptResource): Call
removeDatabase instead of removeResource.
(WebCore::InspectorController::resetScriptObjects): Renamed from
clearScriptResources.
(WebCore::InspectorController::didCommitLoad): Call resetScriptObjects()
instead of individual clear functions.
* page/InspectorController.h: Rename functions.
* page/inspector/Console.js: Changed the object name to Console from
ConsolePanel. Made it inherit the prototype from View. Added code
to animate in and out.
* page/inspector/Database.js: Removed title updating and Resource
pseudo-subclassing. Made more of a Model object that just encapsulates
data. Add a getter for table names.
* page/inspector/DatabaseQueryView.js: Added. Implements the view seen
when selecting a Database in the DatabasesPanel. Implemented as an
interactive console-like area.
* page/inspector/DatabaseTableView.js: Added. Implements the view seen
when selecting a Database Table in the DatabasesPanel. Matches the old
Browse view of Database panels.
* page/inspector/DatabasesPanel.js: Changed the object name to DatabasesPanel
from DatabasePanel. Implements a panel that shows a sidebar of Databases
and Database Tables.
* page/inspector/ElementsPanel.js:  Changed the object name to ElementsPanel
from DocumentPanel. Implements the DOM tree that shows the DOM rooted at the
main resource.
* page/inspector/FontView.js: Use this.contentElement instead of this.element.
* page/inspector/ImageView.js: Ditto.
* page/inspector/Images/clearConsoleButtons.png: Added.
* page/inspector/Images/consoleButtons.png: Added.
* page/inspector/Images/darkShadow.png: Flipped.
* page/inspector/Images/database.png: Modified to be 32x32.
* page/inspector/Images/databaseTable.png: Added.
* page/inspector/Images/databasesIcon.png: Added.
* page/inspector/Images/disclosureTriangleSmallDown.png: Added.
* page/inspector/Images/disclosureTriangleSmallDownBlack.png: Added.
* page/inspector/Images/disclosureTriangleSmallDownWhite.png: Added.
* page/inspector/Images/disclosureTriangleSmallRight.png: Added.
* page/inspector/Images/disclosureTriangleSmallRightBlack.png: Added.
* page/inspector/Images/disclosureTriangleSmallRightDown.png: Added.
* page/inspector/Images/disclosureTriangleSmallRightDownBlack.png: Added.
* page/inspector/Images/disclosureTriangleSmallRightDownWhite.png: Added.
* page/inspector/Images/disclosureTriangleSmallRightWhite.png: Added.
* page/inspector/Images/dockButtons.png: Added.
* page/inspector/Images/elementsIcon.png: Added.
* page/inspector/Images/gradientHighlightBottom.png:
* page/inspector/Images/resourceCSSIcon.png: Added.
* page/inspector/Images/resourceDocumentIcon.png: Added.
* page/inspector/Images/resourcePlainIcon.png: Added.
* page/inspector/Images/resourcesIcon.png: Added.
* page/inspector/Images/resourcesSizeGraphIcon.png: Added.
* page/inspector/Images/resourcesTimeGraphIcon.png: Added.
* page/inspector/Images/scriptsIcon.png: Added.
* page/inspector/Images/segment.png: Modified to fit the taller status bar.
* page/inspector/Images/segmentEnd.png: Ditto.
* page/inspector/Images/segmentHover.png: Ditto.
* page/inspector/Images/segmentHoverEnd.png: Ditto.
* page/inspector/Images/segmentSelected.png: Ditto.
* page/inspector/Images/segmentSelectedEnd.png: Ditto.
* page/inspector/Images/sidebarSelectionBackground.png: Added.
* page/inspector/Images/sidebarSelectionBackgroundFocused.png: Added.
* page/inspector/Images/sidebarSelectionBackgroundInactive.png: Added.
* page/inspector/Images/sidebarSmallSelectionBackground.png: Added.
* page/inspector/Images/sidebarSmallSelectionBackgroundFocused.png: Added.
* page/inspector/Images/sidebarSmallSelectionBackgroundInactive.png: Added.
* page/inspector/Images/statusbarBackground.png: Added.
* page/inspector/Images/statusbarBottomBackground.png: Added.
* page/inspector/Images/statusbarButtons.png: Added.
* page/inspector/Images/statusbarResizerVertical.png: Added.
* page/inspector/Images/toolbarItemSelected.png: Added.
* page/inspector/Panel.js: Added support for toolbar items and status bar items.
Inherits from the View prototype.
* page/inspector/Resource.js: Removed title updating and the ResourceTreeElement.
Made more of a Model object that just encapsulates data.
* page/inspector/ResourceCategory.js: Removed the ResourceCategoryTreeElement.
Made more of a Model object that just encapsulates data.
* page/inspector/ResourceView.js: A simple base object for Resource views
shown in ResourcesPanel. Inherits from the View prototype.
* page/inspector/ResourcesPanel.js: Changed the object name to ResourcesPanel
from NetworkPanel. Implements the timeline graph, size graph and resource
viewing by using ResourceViews.
* page/inspector/SidebarTreeElement.js: Added. Inherits from TreeElement and implements
a section element and a regular element that has an icon, title and optional subtitle.
* page/inspector/SourceView.js: Use this.contentElement instead of this.element.
* page/inspector/StylesSidebarPane.js: Null check WebInspector.mainResource.
* page/inspector/View.js: Added. A simple object to manage showing and hiding an element.
* page/inspector/WebKit.qrc: Added new files.
* page/inspector/inspector.css: New and changed style rules to support the new UI.
* page/inspector/inspector.html: New and changed HTML for the UI. The search field
is disabled until search is reimplemented.
* page/inspector/inspector.js: Removed code related to the sidebar and back-forward lists.
Also removed code related to navigation to panels. Added code to instantiate the new
panels and setup the toolbar.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Antti Koivisto.
mitz@apple.com [Tue, 8 Apr 2008 20:59:58 +0000 (20:59 +0000)]
    Reviewed by Antti Koivisto.

        - fix a regression from r31313 which made the inspector highlight and
          yellow find highlight for table cells with extra top appear in the
          wrong position

        * rendering/LayoutState.cpp:
        (WebCore::LayoutState::LayoutState): Changed absolutePosition() to
        absolutePositionForContent(), to get the right position for children of
        table cells. This is the correct fix for this part of r31313.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::absolutePosition): Reverted the change from r31313
        by changing absolutePosition() to absolutePositionForContent() here too.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::absolutePositionForContent): Changed to return
        the result from absolutePosition().
        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::absoluteClippedOverflowRect): Turned the
        "else" case into an early return.
        (WebCore::RenderTableCell::absolutePosition): Reverted the change from
        r31313.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Tue, 8 Apr 2008 20:58:36 +0000 (20:58 +0000)]
WebCore:

        Reviewed by Antti Koivisto.

        - fix http://bugs.webkit.org/show_bug.cgi?id=18172
          REGRESSION (r31114-31132): Page renders structured almost horizontally (at flickr.com)

        Test: fast/block/float/br-with-clear-2.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): The existing code for
        handling a float-clearing <br> in incremental layout had several bugs in
        it: it only applied when the <br> was on the last line of the block; it
        assumed that the <br> was always the rightmost box on the line (which is
        false in right-to-left runs); and in some places it looked at the last
        child of the block instead of the last box on the line. Fixed these
        bugs.

LayoutTests:

        Reviewed by Antti Koivisto.

        - test for http://bugs.webkit.org/show_bug.cgi?id=18172
          REGRESSION (r31114-31132): Page renders structured almost horizontally (at flickr.com)

        * fast/block/float/br-with-clear-2.html: Added.
        * platform/mac/fast/block/float/br-with-clear-2-expected.checksum: Added.
        * platform/mac/fast/block/float/br-with-clear-2-expected.png: Added.
        * platform/mac/fast/block/float/br-with-clear-2-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Mac build fix
aroben@apple.com [Tue, 8 Apr 2008 20:50:32 +0000 (20:50 +0000)]
    Mac build fix

        * WebCore.xcodeproj/project.pbxproj: Removed MainThread* files which
        were moved to WTF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoChange WebInspector.elementDragStart and WebInspector.elementDragEnd to have more
timothy@apple.com [Tue, 8 Apr 2008 20:36:24 +0000 (20:36 +0000)]
Change WebInspector.elementDragStart and WebInspector.elementDragEnd to have more
state, so calling elementDragEnd does not need the listener functions. Also makes
calling elementDragStart again without elementDragEnd work correctly.

Reviewed by Adam Roben.

* page/inspector/ElementsPanel.js:
(DocumentPanel.prototype.rightSidebarResizerDragStart): Just call WebInspector.elementDragStart.
Removed code that stored away the listeners now that elementDragStart does it.
(DocumentPanel.prototype.rightSidebarResizerDragEnd): Just call WebInspector.elementDragEnd.
Removed code that deleted listeners properties now that elementDragEnd does it.
* page/inspector/inspector.js:
(WebInspector.sidebarResizerDragEnd): Pass less arguments to elementDragEnd.
(WebInspector.searchResultsResizerDragEnd): Ditto.
(WebInspector.elementDragStart): Store the listeners as private properties on WebInspector.
If the properties are already defined, call elementDragEnd first.
(WebInspector.elementDragEnd): Remove the event listeners using the stored properties.
Delete the private listener properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix
aroben@apple.com [Tue, 8 Apr 2008 20:30:29 +0000 (20:30 +0000)]
    Build fix

        * ForwardingHeaders/wtf/MainThread.h: Added. Forgot to commit this.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMove callOnMainThread to WTF
aroben@apple.com [Tue, 8 Apr 2008 20:12:29 +0000 (20:12 +0000)]
Move callOnMainThread to WTF

JavaScriptCore:

        Move callOnMainThread to WTF

        Reviewed by Alexey Proskuryakov.

        * GNUmakefile.am:
        * JavaScriptCore.pri:
        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        * JavaScriptCoreSources.bkl:
        Added new files.

        * wtf/MainThread.cpp:
        * wtf/MainThread.h:
        * wtf/gtk/MainThreadGtk.cpp:
        * wtf/mac/MainThreadMac.mm:
        * wtf/qt/MainThreadQt.cpp:
        * wtf/win/MainThreadWin.cpp:
        * wtf/wx/MainThreadWx.cpp:
        Moved here from WebCore/platform. Replaced all instances of "WebCore"
        with "WTF".

        * kjs/bool_object.cpp: Touched to force JavaScriptCore.vcproj to
        build.
        to the WTF namespace.
        * wtf/ThreadingWin.cpp:
        (WTF::initializeThreading): Call initializeMainThread.

WebCore:

        Move callOnMainThread to WTF

        Reviewed by Alexey Proskuryakov.

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCoreSources.bkl:
        Removed MainThread files.

        * bindings/js/JSCustomSQLTransactionCallback.cpp:
        * loader/icon/IconDatabase.cpp:
        (WebCore::iconDatabase):
        * storage/Database.cpp:
        (WebCore::Database::Database):
        * storage/DatabaseTracker.cpp:
        Updated #includes and replaced calls to
        WebCore::initializeThreadingAndMainThread with calls to
        KJS::initializeThreading.

        * platform/MainThread.cpp: Removed.
        * platform/MainThread.h: Removed.
        * platform/gtk/MainThreadGtk.cpp: Removed.
        * platform/mac/MainThreadMac.mm: Removed.
        * platform/qt/MainThreadQt.cpp: Removed.
        * platform/win/MainThreadWin.cpp: Removed.
        * platform/wx/MainThreadWx.cpp: Removed.

WebKit/gtk:

        Move callOnMainThread to WTF

        Reviewed by Alexey Proskuryakov.

        * webkit/webkitprivate.cpp: Updated #include.
        (webkit_init): Changed to call KJS::initializeThreading.

WebKit/win:

        Move callOnMainThread to WTF

        Reviewed by Alexey Proskuryakov.

        * WebIconDatabase.cpp: Updated #include

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-08 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 8 Apr 2008 19:48:51 +0000 (19:48 +0000)]
2008-04-08  Mark Rowe  <mrowe@apple.com>

        Clean up after Brady.

        * DumpRenderTree/mac/DumpRenderTree.mm: Add an include so that NSInteger can be found.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Combine :equal operations with the following operation if they are fewer...
aroben@apple.com [Tue, 8 Apr 2008 18:56:09 +0000 (18:56 +0000)]
    Combine :equal operations with the following operation if they are fewer than 3 characters long

        This keeps us from showing lots of small changes on long lines, just
        because some letters happened to be the same.

        Inspired by
        http://code.google.com/p/reviewboard/source/browse/trunk/reviewboard/diffviewer/diffutils.py?r=1264#147

        * PrettyPatch/PrettyPatch.rb:
        (PrettyPatch::DiffSection.initialize): Remove :equal operations fewer
        than 3 characters long. The characters from the removed operations
        become part of the subsequent operation.
        (PrettyPatch::CodeLine.text_as_html): Don't wrap 0-length strings in
        <ins>/<del> tags. Also removed the @fromLineNumber.nil? and
        @toLineNumber.nil? checks as they are no longer reliable now that
        we're removing operations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix ChangeLog
sfalken@apple.com [Tue, 8 Apr 2008 18:28:48 +0000 (18:28 +0000)]
Fix ChangeLog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add missing increment/decrement COM class counts to detect leaks.
sfalken@apple.com [Tue, 8 Apr 2008 18:28:32 +0000 (18:28 +0000)]
    Add missing increment/decrement COM class counts to detect leaks.

        Reviewed by Adam Roben.

        * CFDictionaryPropertyBag.cpp:
        (CFDictionaryPropertyBag::CFDictionaryPropertyBag):
        (CFDictionaryPropertyBag::~CFDictionaryPropertyBag):
        * CFDictionaryPropertyBag.h:
        * HTTPHeaderPropertyBag.cpp:
        (HTTPHeaderPropertyBag::HTTPHeaderPropertyBag):
        (HTTPHeaderPropertyBag::~HTTPHeaderPropertyBag):
        * HTTPHeaderPropertyBag.h:
        * WebActionPropertyBag.cpp:
        (WebActionPropertyBag::WebActionPropertyBag):
        (WebActionPropertyBag::~WebActionPropertyBag):
        * WebDocumentLoader.cpp:
        (WebDocumentLoader::WebDocumentLoader):
        (WebDocumentLoader::~WebDocumentLoader):
        * WebDropSource.cpp:
        (WebDropSource::WebDropSource):
        (WebDropSource::~WebDropSource):
        * WebDropSource.h:
        * WebElementPropertyBag.cpp:
        (WebElementPropertyBag::WebElementPropertyBag):
        (WebElementPropertyBag::~WebElementPropertyBag):
        * WebTextRenderer.cpp:
        (WebTextRenderer::WebTextRenderer):
        (WebTextRenderer::~WebTextRenderer):
        * WebView.cpp:
        (WebView::updateActiveState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Change PrettyPatch to use DiffBuilder for intra-line diffs
aroben@apple.com [Tue, 8 Apr 2008 18:08:25 +0000 (18:08 +0000)]
    Change PrettyPatch to use DiffBuilder for intra-line diffs

        This gives us much prettier intra-line diffs, largely because it can
        distinguish multiple changes on the same line. e.g., if a line changes
        from:

        const int myConstant = 0;

        to

        static const unsigned myConstant;

        You will see that "static " was inserted, "int" changed to "unsigned",
        and " = 0" was deleted.

        This seems to have also gotten rid of some spurious instances of
        "<ins></ins>" and "<del></del>" at the end of a line.

        * PrettyPatch/PrettyPatch.rb:
        (PrettyPatch::DiffSection.initialize): Use DiffBuilder instead of
        setChangeExtentFromLine (which had been copied from Trac's diffing
        code).
        (PrettyPatch::CodeLine):
         - Removed the changeExtent attribute
         - Added the operations attribute
         - Removed the setChangeExtentFromLine method
        (PrettyPatch::CodeLine.text_as_html): Uses @operations to determine
        what text to wrap in <ins> and <del> tags.
        * PrettyPatch/diff.rb: Deleted a bunch of code we don't use.
        (HTMLDiff::DiffBuilder.initialize): Moved code here from the old build
        method, but left out the calls to perform_operation, since we build
        the diff HTML outside of this class.
        (HTMLDiff::DiffBuilder.split_inputs_to_words): Removed calls to
        convert_html_to_list_of_words, since we're not diffing HTML.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Check in diff.rb
aroben@apple.com [Tue, 8 Apr 2008 18:06:57 +0000 (18:06 +0000)]
    Check in diff.rb

        This came from
        http://instiki.rubyforge.org/svn/instiki/trunk/lib/diff.rb
        revision 28521

        * PrettyPatch/diff.rb: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMakes the Network timeline graph resource sizes on the bar graph
timothy@apple.com [Tue, 8 Apr 2008 18:06:37 +0000 (18:06 +0000)]
Makes the Network timeline graph resource sizes on the bar graph
when Transfer Size is selected.

http://bugs.webkit.org/show_bug.cgi?id=18351

Reviewed by Adam Roben.

* page/inspector/Resource.js:
(WebInspector.Resource.CompareByTime): Array sorting function for time.
Copied from WebInspector.NetworkPanel.timelineEntryCompare.

* page/inspector/ResourcesPanel.js:
(WebInspector.NetworkPanel): Set the selectedIndex of graphModeSelectElement to
make Transfer Time the default graph.
(WebInspector.NetworkPanel.prototype.changeGraphMode): Call calculator.reset,
_refreshAllResources and _updateGraphDividersIfNeeded.
(WebInspector.NetworkPanel.prototype.get totalDuration): Removed.
(WebInspector.NetworkPanel.prototype._updateGraphBoundriesIfNeeded): Removed boundary
checking code and just call calculator.updateBoundries.
(WebInspector.NetworkPanel.prototype._updateGraphDividersIfNeeded): Add a force argument.
Use calculator.boundarySpan when computing the slice. If the slice is NaN, don't make a label.
Ask the calculator to format the label values for each slice.
(WebInspector.NetworkPanel.prototype.clearTimeline): Call calculator.reset.
(WebInspector.NetworkPanel.timelineEntryCompare): Call WebInspector.Resource.CompareByTime.

(WebInspector.NetworkTimelineEntry.prototype.refresh): Ask the panel's calculator to compute
bar graph percentages for a resource. Use those percentages to change the bar style.

(WebInspector.ResourceCalculator): Renamed from WebInspector.TimelineValueCalculator.
(WebInspector.ResourceCalculator.prototype.computeSummaryValues): Changed the Array.forEach
to a normal for loop. Work with resources instead of TimelineEntries.
(WebInspector.ResourceCalculator.prototype.computeBarGraphPercentages): Return basic bar graph
percents with start always being zero.
(WebInspector.ResourceCalculator.prototype.get boundarySpan): Return the difference between
maximumBoundary and minimumBoundary.
(WebInspector.ResourceCalculator.prototype.updateBoundries): Update maximumBoundary based on _value.
The minimumBoundary is always zero.
(WebInspector.ResourceCalculator.prototype.reset): Delete maximumBoundary and minimumBoundary.
(WebInspector.ResourceCalculator.prototype._value): Takes a Resource instead of TimelineEntry.

(WebInspector.ResourceTransferTimeCalculator): Renamed from TransferTimeCalculator.
(WebInspector.ResourceTransferTimeCalculator.prototype.computeSummaryValues): Work with resources
instead of entries. Changed the Array.forEach to a normal for loop.
(WebInspector.ResourceTransferTimeCalculator.prototype.computeBarGraphPercentages): Return percents
just like WebInspector.NetworkTimelineEntry.prototype.refresh was doing before.
(WebInspector.ResourceTransferTimeCalculator.prototype.updateBoundries): Update minimumBoundary and
maximumBoundary just like the checks WebInspector.NetworkPanel.prototype._updateGraphBoundriesIfNeeded was doing.

(WebInspector.ResourceTransferSizeCalculator): Renamed from TransferSizeCalculator.
(WebInspector.ResourceTransferSizeCalculator.prototype._value): Takes a Resource instead of TimelineEntry.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebKitTools:
beidson@apple.com [Tue, 8 Apr 2008 17:29:32 +0000 (17:29 +0000)]
WebKitTools:

2008-04-08  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitzpettel

        Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
        -WebArchive subresources dump in random order, intermittent failures

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (compareResourceURLs): Sorting function based on the resource URLs
        (serializeWebArchiveToXML): Sort the subresource array

LayoutTests:

2008-04-08  Brady Eidson  <beidson@apple.com>

        Reviewed by Mitzpettel

        Fixed http://bugs.webkit.org/show_bug.cgi?id=18302
        -WebArchive subresources dump in random order, intermittent failures

        Now that a DRT fix has set the order, these 3 tests needed new results

        * webarchive/test-css-import-expected.txt:
        * webarchive/test-duplicate-resources-expected.txt:
        * webarchive/test-frameset-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix the SVG build.
rwlbuis@webkit.org [Tue, 8 Apr 2008 17:27:20 +0000 (17:27 +0000)]
    Fix the SVG build.

        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::filterEffect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-08 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Tue, 8 Apr 2008 16:50:21 +0000 (16:50 +0000)]
2008-04-08  Alice Liu  <alice.liu@apple.com>

        Reviewed by Dan Bernstein.

        fixed http://bugs.webkit.org/show_bug.cgi?id=18329
        REGRESSION: Assertion failure in -[WebViewFactory endOfTextMarkerRange:]
        when invoking the Dictionary pop-up

        * page/mac/AccessibilityObjectWrapper.mm:
        (-[AccessibilityObjectWrapper accessibilityAttributeValue:forParameter:]):
        In the section of code where WebCore-equivalents of mac-specific types are
        prepared, some functions weren't meant to operate on the default initialized
        values.  Checking for nil in certain places will better maintain the original
        pre-refactoring code path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-08 Dan Bernstein <mitz@apple.com>
mitz@apple.com [Tue, 8 Apr 2008 08:15:37 +0000 (08:15 +0000)]
2008-04-08  Dan Bernstein  <mitz@apple.com>

        - fix most of the Windows layout test regressions from the font-weight patch

        * platform/graphics/win/FontCacheWin.cpp:
        (WebCore::matchImprovingEnumProc): Changed to be symmetric with respect
        to italics: always prefer (reject) a candidate that changes the italics
        trait to (from) the desired value.
        (WebCore::createGDIFont): Added code to set more members of the LOGFONT
        structure before creating the font.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Ollie.
rwlbuis@webkit.org [Tue, 8 Apr 2008 07:20:21 +0000 (07:20 +0000)]
    Reviewed by Ollie.

        http://bugs.webkit.org/show_bug.cgi?id=18354
        feFlood in attribute should be removed according to SVG 1.1 Errata

        Remove the in attribute from SVGFEFlood DOM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 8 Apr 2008 05:20:02 +0000 (05:20 +0000)]
2008-04-07  Brady Eidson  <beidson@apple.com>

        Rubberstamped by Geoff Garen

        Forgot to update these results after I added the Prototype

        * fast/dom/Window/window-properties-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agobuild fix for gtk. hopefully the only one
alice.liu@apple.com [Tue, 8 Apr 2008 03:12:49 +0000 (03:12 +0000)]
build fix for gtk.  hopefully the only one

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 8 Apr 2008 03:01:44 +0000 (03:01 +0000)]
2008-04-07  Brady Eidson  <beidson@apple.com>

        I can't fathom why the new storage tests could be hanging, but alas they are on Windows
        Disable until I can figure out why

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoI "objeect" to that previous build fix
alice.liu@apple.com [Tue, 8 Apr 2008 03:00:45 +0000 (03:00 +0000)]
I "objeect" to that previous build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 8 Apr 2008 02:54:29 +0000 (02:54 +0000)]
2008-04-07  Brady Eidson  <beidson@apple.com>

        OMG, BUILD - please!

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 8 Apr 2008 01:57:15 +0000 (01:57 +0000)]
2008-04-07  Brady Eidson  <beidson@apple.com>

        Touch JSStorageCustom.cpp to try to FORCE a recompile on bots that haven't gotten the message

        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::customPut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoqt build fix. third time is hopefully the charm.
alice.liu@apple.com [Tue, 8 Apr 2008 01:28:12 +0000 (01:28 +0000)]
qt build fix. third time is hopefully the charm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoattempt at wx build fix
alice.liu@apple.com [Tue, 8 Apr 2008 01:23:54 +0000 (01:23 +0000)]
attempt at wx build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoanother attempt at qt build fix
alice.liu@apple.com [Tue, 8 Apr 2008 01:16:30 +0000 (01:16 +0000)]
another attempt at qt build fix

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoattempt at fixing qt build
alice.liu@apple.com [Tue, 8 Apr 2008 01:08:22 +0000 (01:08 +0000)]
attempt at fixing qt build

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Tue, 8 Apr 2008 01:01:15 +0000 (01:01 +0000)]
WebCore:

2008-04-07  Brady Eidson  <beidson@apple.com>

        Reviewed by John Honeycutt

        ENABLE_DOM_STORAGE for Windows

        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.vcproj/build-generated-files.sh:

WebKit/win:

2008-04-07  Brady Eidson  <beidson@apple.com>

        Reviewed by John Honeycutt

        ENABLE_DOM_STORAGE for Windows

        * WebKit.vcproj/WebKit.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
beidson@apple.com [Tue, 8 Apr 2008 00:21:33 +0000 (00:21 +0000)]
JavaScriptCore:

2008-04-07  Brady Eidson  <beidson@apple.com>

        Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project

        * Configurations/JavaScriptCore.xcconfig:

WebKit/mac:

2008-04-07  Brady Eidson  <beidson@apple.com>

        Add "ENABLE_DOM_STORAGE" to keep in sync with the rest of the project

        * Configurations/WebKit.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 8 Apr 2008 00:16:20 +0000 (00:16 +0000)]
2008-04-07  Brady Eidson  <beidson@apple.com>

        Fix build for builds without DOM_STORAGE enabled

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchStorageEvent):
        * dom/EventTargetNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 Alice Liu <alice.liu@apple.com>
alice.liu@apple.com [Mon, 7 Apr 2008 23:47:11 +0000 (23:47 +0000)]
2008-04-07  Alice Liu  <alice.liu@apple.com>

        Reviewed by Beth Dakin.

        * WebCore.vcproj/WebCore.vcproj:
            Added a few cross-platform accessibility source files

        * WebCore.xcodeproj/project.pbxproj:
            Added AXObjectCache.cpp

        * page/AXObjectCache.cpp: Added.
            These were made cross-platform:
        (WebCore::AXObjectCache::~AXObjectCache):
        (WebCore::AXObjectCache::get):
        (WebCore::AXObjectCache::remove):
        (WebCore::AXObjectCache::childrenChanged):

        * page/AXObjectCache.h:
            These were made platform-specific
        (WebCore::AXObjectCache::isIDinUse):
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::attachWrapper):
        (WebCore::AXObjectCache::postNotificationToElement):

        * page/AccessibilityObject.cpp:
        (WebCore::AccessibilityObject::detach):
            Since only the mac has a wrapper for now, so temporarily
            wrapping this line in #if PLATFORM(MAC)

        (WebCore::AccessibilityObject::removeAXObjectID):
            Since only the mac has uses Accessibility Object IDs,
            wrap this line in #if PLATFORM(MAC)

        * page/mac/AXObjectCacheMac.mm:
            Detaching and attaching the wrapper is platform-specific
            since each wrapper class is platform-specific.
        (WebCore::AXObjectCache::detachWrapper):
        (WebCore::AXObjectCache::attachWrapper):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson@apple.com [Mon, 7 Apr 2008 23:11:29 +0000 (23:11 +0000)]
WebCore:

2008-04-07  Brady Eidson  <beidson@apple.com>

        Lovingly reviewed by Sam Weinig

        <rdar://problem/5797684> - HTML5 SessionStorage and underpinnings for LocalStorage

        Tests: storage/domstorage/sessionstorage/iframe-events.html
               storage/domstorage/sessionstorage/index-get-and-set.html
               storage/domstorage/sessionstorage/simple-events.html
               storage/domstorage/sessionstorage/simple-usage.html
               storage/domstorage/sessionstorage/window-open.html
               storage/domstorage/window-attributes-exist.html

        * Configurations/WebCore.xcconfig: Define to enable DOM_STORAGE

        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::mark): Add optionalSessionStorage case

        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS): Add StorageEvent case

        * bindings/js/JSStorageCustom.cpp:
        (WebCore::JSStorage::canGetItemsForName):
        (WebCore::JSStorage::nameGetter): If the property doesn't exist on the object, call through to getItem()
        (WebCore::JSStorage::customPut): If the property doesn't exist on the object, call through to setItem()

        * dom/Event.cpp:
        (WebCore::Event::isStorageEvent):
        * dom/Event.h:

        * dom/EventNames.h: Add "storage"

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchStorageEvent):
        * dom/EventTargetNode.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow): After a new page has been created, set its SessionStorage object
          to a copy of the previous Page's

        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::sessionStorage): Accessor to pull the appropriate OriginStorage out of the Page's
          SessionStorage.
        (WebCore::DOMWindow::localStorage): To be filled in later
        * page/DOMWindow.h:
        (WebCore::DOMWindow::optionalSessionStorage): Return the session Storage object for this window to mark,
          if any exists
        * page/DOMWindow.idl:

        * page/Page.cpp:
        (WebCore::Page::sessionStorage):  Create and/or return the SessionStorage for this Page.
        (WebCore::Page::setSessionStorage): Set the SessionStorage for this Page - used in FrameLoader after a
          Window.open();
        * page/Page.h:

        * storage/OriginStorage.cpp: Intermediate layer between individual Storage objects, and shared StorageMap
          objects.  There is one OriginStorage object per SecurityOrigin in each "unique set of storage areas", such
          as the SessionStorage.  This layer forwards DOM-level calls down to the backing StorageMap, handles
          copy-on-write along with the StorageMap, fires StorageEvents to the DOM when a value is changed, and will
          eventually handle quota enforcement.
        (WebCore::OriginStorage::create):
        (WebCore::OriginStorage::OriginStorage):
        (WebCore::OriginStorage::~OriginStorage):
        (WebCore::OriginStorage::copy):
        (WebCore::OriginStorage::length):
        (WebCore::OriginStorage::key):
        (WebCore::OriginStorage::getItem):
        (WebCore::OriginStorage::setItem):
        (WebCore::OriginStorage::removeItem):
        (WebCore::OriginStorage::contains):
        (WebCore::OriginStorage::dispatchStorageEvent):
        * storage/OriginStorage.h:

        * storage/SessionStorage.cpp: From the HTML5 spec:
          "Each top-level browsing context has a unique set of session storage areas, one for each origin."
          This object represents that "unique set of session storage areas", and creates or returns the Storage
          object for the requested SecurityOrigin
        (WebCore::SessionStorage::create):
        (WebCore::SessionStorage::SessionStorage):
        (WebCore::SessionStorage::copy):
        (WebCore::SessionStorage::originStorage):
        * storage/SessionStorage.h:
        (WebCore::SessionStorage::page):

        * storage/Storage.cpp: Representation of the DOM-level object, wrapped by JSStorage.  There is a unique
          Storage object per Window (per-Frame) that wraps a specific shared OriginStorage object.
        (WebCore::Storage::create):
        (WebCore::Storage::Storage):
        (WebCore::Storage::length):
        (WebCore::Storage::key):
        (WebCore::Storage::getItem):
        (WebCore::Storage::setItem):
        (WebCore::Storage::removeItem):
        (WebCore::Storage::contains):
        * storage/Storage.h:
        * storage/Storage.idl:

        * storage/StorageEvent.cpp:
        (WebCore::StorageEvent::StorageEvent):
        (WebCore::StorageEvent::initStorageEvent):
        * storage/StorageEvent.h:
        (WebCore::StorageEvent::isStorageEvent):

        * storage/StorageMap.cpp: The physical map of key/value pairs that is shared between OriginStorage objects,
          and implements copy-on-write semantics whenever a value is changed
        (WebCore::StorageMap::create):
        (WebCore::StorageMap::StorageMap):
        (WebCore::StorageMap::copy):
        (WebCore::StorageMap::invalidateIterator): Used to support the key(unsigned i) part of the API
        (WebCore::StorageMap::setIteratorToIndex): Ditto
        (WebCore::StorageMap::length):
        (WebCore::StorageMap::key):
        (WebCore::StorageMap::getItem):
        (WebCore::StorageMap::setItem):
        (WebCore::StorageMap::removeItem):
        (WebCore::StorageMap::contains):
        * storage/StorageMap.h:

LayoutTests:

2008-04-07  Brady Eidson  <beidson@apple.com>

        Begrudgingly reviewed by Sam Weinig

        Initial suite of layout tests for HTML5 key/value SessionStorage (<rdar://problem/5797684>)

        * fast/dom/Window/window-properties-expected.txt:
        * storage/domstorage: Added.
        * storage/domstorage/localstorage: Added.
        * storage/domstorage/sessionstorage: Added.
        * storage/domstorage/sessionstorage/iframe-events-expected.txt: Added.
        * storage/domstorage/sessionstorage/iframe-events.html: Added.
        * storage/domstorage/sessionstorage/index-get-and-set-expected.txt: Added.
        * storage/domstorage/sessionstorage/index-get-and-set.html: Added.
        * storage/domstorage/sessionstorage/resources: Added.
        * storage/domstorage/sessionstorage/resources/clearSessionStorage.js: Added.
        * storage/domstorage/sessionstorage/resources/iframe-events-second.html: Added.
        * storage/domstorage/sessionstorage/resources/window-open-second.html: Added.
        * storage/domstorage/sessionstorage/simple-events-expected.txt: Added.
        * storage/domstorage/sessionstorage/simple-events.html: Added.
        * storage/domstorage/sessionstorage/simple-usage-expected.txt: Added.
        * storage/domstorage/sessionstorage/simple-usage.html: Added.
        * storage/domstorage/sessionstorage/window-open-expected.txt: Added.
        * storage/domstorage/sessionstorage/window-open.html: Added.
        * storage/domstorage/window-attributes-exist-expected.txt: Added.
        * storage/domstorage/window-attributes-exist.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRenamed various functions that are internal to the Console object to have an undersco...
timothy@apple.com [Mon, 7 Apr 2008 22:18:33 +0000 (22:18 +0000)]
Renamed various functions that are internal to the Console object to have an underscore prefix.

Rubber-stamped by Adam Roben.

* page/inspector/Console.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRenamed various functions and properties that are internal to an object to have an...
timothy@apple.com [Mon, 7 Apr 2008 22:10:13 +0000 (22:10 +0000)]
Renamed various functions and properties that are internal to an object to have an underscore prefix.

Rubber-stamped by Adam Roben.

* page/inspector/Resource.js:
* page/inspector/ResourcesPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Mon, 7 Apr 2008 22:04:00 +0000 (22:04 +0000)]
    Windows build fix

        * wtf/ThreadingWin.cpp: Back out some changes I didn't mean to land.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixes coding style for two utility getters.
timothy@apple.com [Mon, 7 Apr 2008 21:45:01 +0000 (21:45 +0000)]
Fixes coding style for two utility getters.

* page/inspector/utilities.js: Fix coding style for the
totalOffsetLeft and totalOffsetTop getters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 John Sullivan <sullivan@apple.com>
sullivan@apple.com [Mon, 7 Apr 2008 21:34:21 +0000 (21:34 +0000)]
2008-04-07  John Sullivan  <sullivan@apple.com>

        Reviewed by Tim

        - made the JavaScript text input panel not block Quit (part of 4133196)

        * English.lproj/WebJavaScriptTextInputPanel.nib/classes.nib:
        * English.lproj/WebJavaScriptTextInputPanel.nib/info.nib:
        * English.lproj/WebJavaScriptTextInputPanel.nib/keyedobjects.nib:
        Made the panel be a NonBlockingPanel

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Export some more WTF functions from WebKit.dll
aroben@apple.com [Mon, 7 Apr 2008 21:04:59 +0000 (21:04 +0000)]
    Export some more WTF functions from WebKit.dll

        Reviewed by Alexey Proskuryakov.

        * WebKit.vcproj/WebKit.def:
        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Add WTF::isMainThread
aroben@apple.com [Mon, 7 Apr 2008 21:04:38 +0000 (21:04 +0000)]
    Add WTF::isMainThread

        Reviewed by Alexey Proskuryakov.

        * wtf/Threading.h: Declare the new function.
        * wtf/ThreadingGtk.cpp:
        (WTF::initializeThreading): Initialize the main thread identifier.
        (WTF::isMainThread): Added.
        * wtf/ThreadingNone.cpp: Ditto ThreadingGtk.cpp.
        (WTF::initializeThreading):
        (WTF::isMainThread):
        * wtf/ThreadingPthreads.cpp: Ditto.
        (WTF::initializeThreading):
        (WTF::isMainThread):
        * wtf/ThreadingWin.cpp: Ditto.
        (WTF::initializeThreading):
        (WTF::isMainThread):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Hyatt.
mitz@apple.com [Mon, 7 Apr 2008 20:08:30 +0000 (20:08 +0000)]
    Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=18311
          <rdar://problem/5842980> REGRESSION (r31620): Font variants (e.g. Helvetica Neue *Light*) don't render correctly

        * platform/mac/WebFontCache.mm:
        (+[WebFontCache internalFontWithFamily:traits:weight:size:]): Changed to
        match by family name first, and only if that fails, look for a match by
        full (PostScript) name. Reverted the full name-based match logic to only
        distinguish between the broad categories of "bold" and "not bold".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWhen the WebInspector.currentFocusElement changes, move the caret selection to be...
timothy@apple.com [Mon, 7 Apr 2008 20:01:54 +0000 (20:01 +0000)]
When the WebInspector.currentFocusElement changes, move the caret selection to be inside the focused element. This makes sure the caret moves in and out of the console when the focus changes.

Reviewed by Adam Roben.

* page/inspector/TextPrompt.js:
(TextPrompt.prototype.isCaretInsidePrompt): Just call isInsertionCaretInside.
* page/inspector/inspector.js:
(WebInspector.set currentFocusElement): Make a caret selection inside
the focused element if there isn't a range selection and there isn't
already a caret selection inside.
* page/inspector/utilities.js:
(Element.prototype.isInsertionCaretInside): Added. Tests if the
selection is collapsed and is inside the element.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 7 Apr 2008 19:17:23 +0000 (19:17 +0000)]
2008-04-07  Brady Eidson  <beidson@apple.com>

        Reviewed by Tim Hatcher

        Add 1 more empty file for upcoming work, as a separate step, to keep all build-systems working

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * bindings/js/JSStorageCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dan Bernstein.
ap@webkit.org [Mon, 7 Apr 2008 18:50:23 +0000 (18:50 +0000)]
    Reviewed by Dan Bernstein.

        <rdar://problem/5574946> Inline frame ISO-8859-1 even though parent character set is UTF-8

        Test: fast/loader/inherit-charset-to-empty-frame.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::write): Treat an empty m_encoding the same as null one.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRename some Inspector panel objects to facilitate the up-coming
timothy@apple.com [Mon, 7 Apr 2008 17:33:37 +0000 (17:33 +0000)]
Rename some Inspector panel objects to facilitate the up-coming
UI refresh changes.

Reviewed by Adam Roben.

* page/inspector/DatabasesPanel.js: Renamed ResourcePanel to ResourceView.
* page/inspector/ElementsPanel.js: Renamed SourcePanel to SourceView.
* page/inspector/FontView.js: Renamed FontPanel to FontView.
* page/inspector/ImageView.js: Renamed ImagePanel to ImageView.
* page/inspector/Resource.js: Instantiate the new "View" named objects.
* page/inspector/ResourceView.js: Renamed ResourcePanel to ResourceView.
* page/inspector/SourceView.js: Renamed SourcePanel to SourceView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix an exception and remove code that was missed when TextPrompt
timothy@apple.com [Mon, 7 Apr 2008 17:14:04 +0000 (17:14 +0000)]
Fix an exception and remove code that was missed when TextPrompt
was added. This makes the Console work again.

Reviewed by Adam Roben.

* page/inspector/Console.js: Removed code that used non-existent
properties.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove the workaround for bug 11399 now that it is fixed.
timothy@apple.com [Mon, 7 Apr 2008 16:41:12 +0000 (16:41 +0000)]
Remove the workaround for bug 11399 now that it is fixed.

Reviewed by Adam Roben.

* page/inspector/Console.js: Removed the 'with' statement
around the eval and call eval directly on the inspected window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Mon, 7 Apr 2008 13:34:45 +0000 (13:34 +0000)]
2008-04-07  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        http://bugs.webkit.org/show_bug.cgi?id=18297
        Bug #18297 - Acid2/Acid3 -tests don't load load with soup.

        Fixes in the libsoup backend: data url parsing, acid tests, redirects,
        response headers handling and re-entrancy issues on job cancellation.
        Thanks to Dan Winship for libsoup hints.

        * platform/network/ResourceHandleInternal.h:
        (WebCore::ResourceHandleInternal::ResourceHandleInternal): add m_cancelled and remove unuseful m_session
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::restartedCallback): added to route redirects to webkit
        (WebCore::dataCallback): add response headers, some checks and fix re-entrancy
        (WebCore::parseDataUrl): be an idle callback for the main loop
        (WebCore::ResourceHandle::start):
        (WebCore::ResourceHandle::cancel): fixed re-entrancy

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix, rubber-stamped and landed by ap.
ap@webkit.org [Mon, 7 Apr 2008 12:24:26 +0000 (12:24 +0000)]
    Build fix, rubber-stamped and landed by ap.

        * configure.ac: Add autoconf flag for HTML5 client-side session and persistent storage support.

WebCore:
        * GNUmakefile.am: Fix dom_storage conditional and typo: ENABLE_DOM_STORAG.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-07 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 7 Apr 2008 07:07:19 +0000 (07:07 +0000)]
2008-04-07  Brady Eidson  <beidson@apple.com>

        Whoops, idls don't go in the vcproj!

        * WebCore.vcproj/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 7 Apr 2008 06:55:43 +0000 (06:55 +0000)]
2008-04-06  Brady Eidson <beidson@apple.com>

        Attempt to tickle Windows build into accepting this idl

        * storage/StorageEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-06 Brady Eidson <beidson@apple.com>
beidson@apple.com [Mon, 7 Apr 2008 06:39:35 +0000 (06:39 +0000)]
2008-04-06  Brady Eidson <beidson@apple.com>

        Reviewed by Sam

        HTML5 Session and Local Storage

        Land a bunch of empty files and interfaces to keep things building while
        I finish off the rest of the implementation of SessionStorage

        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:

        * storage/OriginStorage.cpp: Added.
        * storage/OriginStorage.h: Added.

        * storage/SessionStorage.cpp: Added.
        * storage/SessionStorage.h: Added.

        * storage/Storage.cpp: Added.
        (WebCore::Storage::length):
        (WebCore::Storage::key):
        (WebCore::Storage::getItem):
        (WebCore::Storage::setItem):
        (WebCore::Storage::removeItem):
        * storage/Storage.h: Added.
        * storage/Storage.idl: Added.

        * storage/StorageEvent.cpp: Added.
        * storage/StorageEvent.h: Added.
        (WebCore::StorageEvent::key):
        (WebCore::StorageEvent::oldValue):
        (WebCore::StorageEvent::newValue):
        (WebCore::StorageEvent::uri):
        (WebCore::StorageEvent::source):
        (WebCore::StorageEvent::initStorageEvent):
        * storage/StorageEvent.idl: Added.

        * storage/StorageMap.cpp: Added.
        * storage/StorageMap.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
ap@webkit.org [Mon, 7 Apr 2008 06:33:20 +0000 (06:33 +0000)]
    Reviewed by Darin.

        Make UString thread-safe.

        No change on SunSpider total, although individual tests have changed a lot, up to 3%.

        * kjs/InitializeThreading.cpp: (KJS::initializeThreading): Call UString::null() to initialize
        a static.

        * kjs/identifier.cpp:
        (KJS::CStringTranslator::translate):
        (KJS::UCharBufferTranslator::translate):
        Use "true" for a boolean value instead of 1, because it's C++.

        * kjs/ustring.h:
        (KJS::CString::adopt): Added a method to create from a char* buffer without copying.
        (KJS::UString::Rep::ref): Removed an assertion for JSLock::lockCount, as it's no longer
        necessary to hold JSLock when working with strings.
        (KJS::UString::Rep::deref): Ditto.
        (KJS::UString::Rep::isStatic): Added a field to quickly determine that this is an empty
        or null static string.

        * kjs/ustring.cpp:
        (KJS::): Removed normalStatBufferSize and statBufferSize, as there is no reason to have such
        an advanced implementation of a debug-only ascii() method. Removed a long-obsolete comment
        about UChar.
        (KJS::UString::Rep::createCopying): Removed an assertion for JSLock::lockCount.
        (KJS::UString::Rep::create): Ditto.
        (KJS::UString::Rep::destroy): Ditto. Do not do anything for static null and empty strings,
        as refcounting is not reliable for those. Reordered branches for a noticeable speed gain -
        apparently this functiton is hot enough for SunSpider to see an effect from this!
        (KJS::UString::null): Moved a star, added a comment.
        (KJS::UString::cstring): Reimplemented to not call ascii(), which is not thread-safe.
        (KJS::UString::ascii): Simplified statBuffer handling logic.
        (KJS::UString::toDouble): Use cstring() instead of ascii().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2008-04-06 Luca Bruno <lethalman88@gmail.com>
alp@webkit.org [Mon, 7 Apr 2008 00:09:36 +0000 (00:09 +0000)]
2008-04-06  Luca Bruno  <lethalman88@gmail.com>

        Reviewed by Alp Toker.

        Fix webkit_web_view_get_transparent() return value.

        * webkit/webkitwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRubber stamped by Mark Rowe.
kevino@webkit.org [Sun, 6 Apr 2008 00:56:32 +0000 (00:56 +0000)]
Rubber stamped by Mark Rowe.

Don't assume wxWebKit to be part of the wx package. This allows us to run it from any directory on the PYTHONPATH rather than having to copy files into the wxPython directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Mark Rowe.
kevino@webkit.org [Sun, 6 Apr 2008 00:38:16 +0000 (00:38 +0000)]
Reviewed by Mark Rowe.

Add CSS to the MIMETypeRegistry, which ensures CSS files get the right MIMEType when loaded from disk.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric.
rwlbuis@webkit.org [Sat, 5 Apr 2008 20:43:48 +0000 (20:43 +0000)]
    Reviewed by Eric.

        http://bugs.webkit.org/show_bug.cgi?id=17129
        Incorrect style resolution in CSS styled SVG, with multiple style sheets
        Fix the style resolution on the svg by ensuring xml-stylesheet pseudo
        attributes title and alternate are transferred to the stylesheet
        created from the ProcessingInstruction.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@31664 268f45cc-cd09-0410-ab3c-d52691b4dbfc