WebKit-https.git
7 years ago[Win] 5 fast/events/popup-* tests fail
jberlin@webkit.org [Thu, 31 May 2012 21:15:20 +0000 (21:15 +0000)]
[Win] 5 fast/events/popup-* tests fail
https://bugs.webkit.org/show_bug.cgi?id=88008

Add Windows-specific expected (failing?) results to get the bots greener.

* platform/win/fast/events/popup-allowed-from-gesture-initiated-event-expected.txt: Added.
* platform/win/fast/events/popup-allowed-from-gesture-initiated-form-submit-expected.txt: Added.
* platform/win/fast/events/popup-blocked-from-fake-user-gesture-expected.txt: Added.
* platform/win/fast/events/popup-blocked-from-untrusted-mouse-click-expected.txt: Added.
* platform/win/fast/events/popup-blocking-timers-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] 23 media tests fail / time out
jberlin@webkit.org [Thu, 31 May 2012 21:10:39 +0000 (21:10 +0000)]
[Win] 23 media tests fail / time out
https://bugs.webkit.org/show_bug.cgi?id=88005

Add/update the Windows expected (failing?) results to get the bots greener.

* platform/win/Skipped:
* platform/win/media/audio-controls-rendering-expected.txt:
* platform/win/media/audio-repaint-expected.txt:
* platform/win/media/controls-after-reload-expected.txt:
* platform/win/media/controls-strict-expected.txt:
* platform/win/media/controls-styling-expected.txt:
* platform/win/media/controls-without-preload-expected.txt:
* platform/win/media/media-can-play-wav-audio-expected.txt: Added.
* platform/win/media/media-controls-clone-expected.txt:
* platform/win/media/media-controls-invalid-url-expected.txt: Added.
* platform/win/media/media-document-audio-repaint-expected.txt:
* platform/win/media/nodesFromRect-shadowContent-expected.txt: Added.
* platform/win/media/video-colorspace-yuv420-expected.txt: Added.
* platform/win/media/video-colorspace-yuv422-expected.txt: Added.
* platform/win/media/video-controls-rendering-expected.txt:
* platform/win/media/video-display-toggle-expected.txt:
* platform/win/media/video-no-audio-expected.txt:
* platform/win/media/video-pause-immediately-expected.txt: Added.
* platform/win/media/video-playing-and-pause-expected.txt: Added.
* platform/win/media/video-size-intrinsic-scale-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119125.
rafaelw@chromium.org [Thu, 31 May 2012 21:09:01 +0000 (21:09 +0000)]
Unreviewed, rolling out r119125.
http://trac.webkit.org/changeset/119125
https://bugs.webkit.org/show_bug.cgi?id=88007

Will break android build if rolled (Requested by rafaelw_ on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-05-31

Source/WebCore:

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::bytesLoaded):
(WebCore::MediaPlayer::bytesLoaded):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
(WebCore::MediaPlayerPrivateAVFoundation::bytesLoaded):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::bytesLoaded):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::bytesLoaded):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(MediaPlayerPrivateQTKit):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::bytesLoaded):
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::bytesLoaded):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::bytesLoaded):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(MediaPlayerPrivateQuickTimeVisualContext):
* platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(MediaPlayerPrivate):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebMediaPlayer):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::bytesLoaded):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merel...
aestes@apple.com [Thu, 31 May 2012 21:03:16 +0000 (21:03 +0000)]
Disentangle code that relies on USE(AUTOMATIC_TEXT_REPLACEMENT) from that which merely relies on PLATFORM(MAC)
https://bugs.webkit.org/show_bug.cgi?id=87933

Reviewed by Dan Bernstein.

Source/WebCore:

* editing/Editor.cpp:
* editing/Editor.h:
* loader/EmptyClients.h:
* page/ContextMenuController.cpp:
(WebCore::ContextMenuController::contextMenuItemSelected):
* page/EditorClient.h:

Source/WebKit/mac:

* WebCoreSupport/WebEditorClient.h:
* WebCoreSupport/WebEditorClient.mm:

Source/WebKit2:

* WebProcess/WebCoreSupport/WebEditorClient.h:
* WebProcess/WebCoreSupport/mac/WebEditorClientMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] fast/events/remove-target* tests fail
jberlin@webkit.org [Thu, 31 May 2012 20:58:29 +0000 (20:58 +0000)]
[Win] fast/events/remove-target* tests fail
https://bugs.webkit.org/show_bug.cgi?id=88006

Add Windows-specific expected (failing?) results to get the bots greener.

* platform/win/fast/events/remove-target-in-mouseup-deep-expected.txt: Added.
* platform/win/fast/events/remove-target-in-mouseup-expected.txt: Added.
* platform/win/fast/events/remove-target-in-mouseup-insertback-expected.txt: Added.
* platform/win/fast/events/remove-target-in-mouseup-twice-expected.txt: Added.
* platform/win/fast/events/remove-target-with-shadow-in-drag-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable support for rvalue references until I figure out why this is breaking the...
andersca@apple.com [Thu, 31 May 2012 20:55:17 +0000 (20:55 +0000)]
Disable support for rvalue references until I figure out why this is breaking the Xcode 4.2 build.

* wtf/Compiler.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening; skip fast/canvas/canvas-imageSmoothingEnabled.
rakuco@webkit.org [Thu, 31 May 2012 20:53:10 +0000 (20:53 +0000)]
[EFL] Gardening; skip fast/canvas/canvas-imageSmoothingEnabled.

Skip the test just like GTK+, as there seems to be a problem in
the cairo backend that makes the test fail.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fixes.
andersca@apple.com [Thu, 31 May 2012 20:44:21 +0000 (20:44 +0000)]
Build fixes.

Disable the C++11 extensions warning.

* DumpRenderTree/mac/Configurations/Base.xcconfig:
* TestWebKitAPI/Configurations/Base.xcconfig:
* WebKitTestRunner/Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Move drawing code for RenderSurfaces into LayerRendererChromium
danakj@chromium.org [Thu, 31 May 2012 20:41:38 +0000 (20:41 +0000)]
[chromium] Move drawing code for RenderSurfaces into LayerRendererChromium
https://bugs.webkit.org/show_bug.cgi?id=87877

Reviewed by James Robinson.

Source/WebCore:

We add data to CCRenderSurfaceDrawQuad so that the only use of
CCRenderSurface directly from LayerRendererChromium is to
reserve, release, and use the surface's textures, and to set the
scissor rect. Each of these changes will be done independent
of this change.

Covered by existing tests.

* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::applyFilters):
(WebCore):
(WebCore::LayerRendererChromium::drawBackgroundFilters):
(WebCore::LayerRendererChromium::drawRenderSurfaceQuad):
(WebCore::LayerRendererChromium::copyTextureToFramebuffer):
* platform/graphics/chromium/LayerRendererChromium.h:
(LayerRendererChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::contentsTextureId):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCQuadCuller.cpp:
* platform/graphics/chromium/cc/CCQuadCuller.h:
(CCQuadCuller):
* platform/graphics/chromium/cc/CCRenderPass.cpp:
(WebCore::CCRenderPass::appendQuadsForRenderSurfaceLayer):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore):
(WebCore::CCRenderSurface::CCRenderSurface):
(WebCore::CCRenderSurface::prepareContentsTexture):
(WebCore::CCRenderSurface::releaseContentsTexture):
(WebCore::CCRenderSurface::hasValidContentsTexture):
(WebCore::CCRenderSurface::releaseBackgroundTexture):
(WebCore::CCRenderSurface::hasValidBackgroundTexture):
(WebCore::CCRenderSurface::hasMask):
(WebCore::CCRenderSurface::replicaHasMask):
(WebCore::CCRenderSurface::appendQuads):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore):
(CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.cpp:
(WebCore::CCRenderSurfaceDrawQuad::create):
(WebCore::CCRenderSurfaceDrawQuad::CCRenderSurfaceDrawQuad):
* platform/graphics/chromium/cc/CCRenderSurfaceDrawQuad.h:
(WebKit):
(CCRenderSurfaceDrawQuad):
(WebCore::CCRenderSurfaceDrawQuad::maskTextureId):
(WebCore::CCRenderSurfaceDrawQuad::filters):
(WebCore::CCRenderSurfaceDrawQuad::backgroundFilters):
* platform/graphics/chromium/cc/CCTiledLayerImpl.cpp:
(WebCore::CCTiledLayerImpl::contentsTextureId):
* platform/graphics/chromium/cc/CCTiledLayerImpl.h:
(CCTiledLayerImpl):

Source/WebKit/chromium:

* tests/CCRenderSurfaceTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] 10 fast/text tests failing
jberlin@webkit.org [Thu, 31 May 2012 20:28:36 +0000 (20:28 +0000)]
[Win] 10 fast/text tests failing
https://bugs.webkit.org/show_bug.cgi?id=87998

Add/update Windows-specific expected (failing?) pixel results in order to get the bots greener.

* platform/win/fast/text/complex-preferred-logical-widths-expected.png: Added.
* platform/win/fast/text/complex-synthetic-bold-space-width-expected.png: Added.
* platform/win/fast/text/international/arabic-justify-expected.png: Added.
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.png:
* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.png: Added.
* platform/win/fast/text/international/text-combine-image-test-expected.png:
* platform/win/fast/text/international/text-spliced-font-expected.png: Added.
* platform/win/fast/text/line-initial-and-final-swashes-expected.png: Added.
* platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.png: Added.
* platform/win/fast/text/unicode-variation-selector-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening, updating baselines after r119124.
zandobersek@gmail.com [Thu, 31 May 2012 20:16:07 +0000 (20:16 +0000)]
Unreviewed gardening, updating baselines after r119124.

* dom/xhtml/level3/core/documentnormalizedocument10-expected.txt:
* dom/xhtml/level3/core/documentsetxmlversion03-expected.txt:
* fast/workers/storage/test-authorizer-sync-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<rdar://problem/11544454> and https://bugs.webkit.org/show_bug.cgi?id=87990
beidson@apple.com [Thu, 31 May 2012 19:58:01 +0000 (19:58 +0000)]
<rdar://problem/11544454> and https://bugs.webkit.org/show_bug.cgi?id=87990
Crashes unregistering DOMWindowProperties while releasing CachedPages

Reviewed by Jessie Berlin.

This patch rewrites DOMWindowProperty to always keep direct track of the DOMWindow
it has registered with and to only ever unregister from that very same DOMWindow.

No new tests. (While the direct cause of the crash is understood, reproducing it is not)

* page/DOMWindowProperty.cpp:
(WebCore::DOMWindowProperty::DOMWindowProperty):
(WebCore::DOMWindowProperty::~DOMWindowProperty):
(WebCore::DOMWindowProperty::disconnectFrameForPageCache):
(WebCore::DOMWindowProperty::reconnectFrameFromPageCache):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInCachedFrame):
(WebCore::DOMWindowProperty::willDestroyGlobalObjectInFrame):
(WebCore::DOMWindowProperty::willDetachGlobalObjectFromFrame):
* page/DOMWindowProperty.h:
(DOMWindowProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Blackberry] Initialize the select client and delete the pointer
staikos@webkit.org [Thu, 31 May 2012 19:30:33 +0000 (19:30 +0000)]
[Blackberry] Initialize the select client and delete the pointer
in the destructor so it doesn't leak.  Fixes test crashes.
https://bugs.webkit.org/show_bug.cgi?id=87992

Reviewed by Rob Buis.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::InputHandler):
(BlackBerry::WebKit::InputHandler::~InputHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoVector should have a move constructor and move assignment operator
andersca@apple.com [Thu, 31 May 2012 19:12:30 +0000 (19:12 +0000)]
Vector should have a move constructor and move assignment operator
https://bugs.webkit.org/show_bug.cgi?id=87997

Reviewed by Andreas Kling.

* wtf/Compiler.h:
Use __has_extension so we can use move semantics and other C++11 features even when building as C++98.

* wtf/Vector.h:
Add a move constructor and a move assignment operator to Vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agorename flexbox CSS properties from flex-align and flex-item-align to align-items...
tony@chromium.org [Thu, 31 May 2012 19:08:19 +0000 (19:08 +0000)]
rename flexbox CSS properties from flex-align and flex-item-align to align-items and align-self
https://bugs.webkit.org/show_bug.cgi?id=87907

Reviewed by Ojan Vafai.

Source/WebCore:

This was recently changed in the spec:
http://dev.w3.org/csswg/css3-flexbox/#align-items-property

No new tests, updated the tests to use the new naming.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::isValidKeywordPropertyAndValue):
(WebCore::isKeywordPropertyID):
(WebCore::CSSParser::parseValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator EAlignItems):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/StyleBuilder.cpp:
(WebCore::StyleBuilder::StyleBuilder):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::alignmentForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/style/RenderStyle.h:
* rendering/style/RenderStyleConstants.h:
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:
(StyleFlexibleBoxData): Move member variables to StyleRareNonInheritedData
because these values will eventually apply to more than just flexbox.
* rendering/style/StyleRareNonInheritedData.cpp:
(WebCore::StyleRareNonInheritedData::StyleRareNonInheritedData):
(WebCore::StyleRareNonInheritedData::operator==):
* rendering/style/StyleRareNonInheritedData.h:
(StyleRareNonInheritedData):

LayoutTests:

Updated tests for new CSS property names.

* css3/flexbox/align-absolute-child.html:
* css3/flexbox/cross-axis-scrollbar.html:
* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/css-properties.html:
* css3/flexbox/flex-align-baseline.html:
* css3/flexbox/flex-align-column.html:
* css3/flexbox/flex-align-end.html:
* css3/flexbox/flex-align-stretch.html:
* css3/flexbox/flex-align-vertical-writing-mode.html:
* css3/flexbox/flex-align.html:
* css3/flexbox/line-wrapping.html:
* css3/flexbox/multiline-align.html:
* css3/flexbox/multiline-reverse-wrap-baseline.html:
* css3/flexbox/orthogonal-flex-directions.html:
* css3/flexbox/position-absolute-child.html:
* css3/flexbox/true-centering.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] 10 fast/text tests failing
jberlin@webkit.org [Thu, 31 May 2012 18:52:35 +0000 (18:52 +0000)]
[Win] 10 fast/text tests failing
https://bugs.webkit.org/show_bug.cgi?id=87998

Add/update Windows-specific expected (failing?) results in order to get the bots greener.

* platform/win/fast/text/complex-preferred-logical-widths-expected.txt: Added.
* platform/win/fast/text/complex-synthetic-bold-space-width-expected.txt: Added.
* platform/win/fast/text/international/arabic-justify-expected.txt: Added.
* platform/win/fast/text/international/bidi-mirror-he-ar-expected.txt: Added.
* platform/win/fast/text/international/float-as-only-child-of-isolate-crash-expected.txt: Added.
* platform/win/fast/text/international/text-combine-image-test-expected.txt:
* platform/win/fast/text/international/text-spliced-font-expected.txt: Added.
* platform/win/fast/text/line-initial-and-final-swashes-expected.txt: Added.
* platform/win/fast/text/midword-break-before-surrogate-pair-2-expected.txt: Added.
* platform/win/fast/text/unicode-variation-selector-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Add copy constructor to WebFilterOperations
danakj@chromium.org [Thu, 31 May 2012 18:48:47 +0000 (18:48 +0000)]
[chromium] Add copy constructor to WebFilterOperations
https://bugs.webkit.org/show_bug.cgi?id=87970

Reviewed by James Robinson.

* chromium/public/WebFilterOperations.h:
(WebKit::WebFilterOperations::WebFilterOperations):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpdating test expectations (svg/as-image/animated-svg-as-image.html)
rafaelw@chromium.org [Thu, 31 May 2012 18:37:19 +0000 (18:37 +0000)]
Updating test expectations (svg/as-image/animated-svg-as-image.html)

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago [WK2] window.internals settings are not reset between tests
ap@apple.com [Thu, 31 May 2012 18:11:55 +0000 (18:11 +0000)]
    [WK2] window.internals settings are not reset between tests
        https://bugs.webkit.org/show_bug.cgi?id=87783

        Reviewed by Mihai Parparita.

        * WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
        (WTR::InjectedBundle::done): Call resetAfterTest().

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
        (WTR::InjectedBundlePage::prepare): Renamed from "reset" for clarity.
        (WTR::InjectedBundlePage::resetAfterTest): Added a function that resets internals.
        This needs to be done after a tets, because the code assumes that there is an object
        with this name in global scope.

        * WebKitTestRunner/InjectedBundle/InjectedBundlePage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride
commit-queue@webkit.org [Thu, 31 May 2012 18:09:33 +0000 (18:09 +0000)]
[BlackBerry] Crash when destroying WebOverlay with active WebOverlayOverride
https://bugs.webkit.org/show_bug.cgi?id=87968

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by Rob Buis.

The override object is using a compositing thread WebOverlayPrivate
object with no client because the layer doesn't delegate drawing to the
WebOverlayPrivate, it's only used to modify the override properties on
the underlying compositing thread layer.

Since the m_layerCompositingThreadClient is optional, we have to add
null checks.

* Api/WebOverlay.cpp:
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::~WebOverlayPrivateCompositingThread):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setClient):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToImage):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setContentsToColor):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::setDrawsContent):
(BlackBerry::WebKit::WebOverlayPrivateCompositingThread::invalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoReplace WebMediaPlayer::bytesLoaded() with an explicit didLoadingProgress()
fischman@chromium.org [Thu, 31 May 2012 18:03:28 +0000 (18:03 +0000)]
Replace WebMediaPlayer::bytesLoaded() with an explicit didLoadingProgress()
https://bugs.webkit.org/show_bug.cgi?id=86113

Reviewed by Eric Carlson.

Source/WebCore:

No new functionality, so no new tests.  Loading progress is already tested by existing layouttests.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement):
(WebCore::HTMLMediaElement::startProgressEventTimer):
(WebCore::HTMLMediaElement::changeNetworkStateFromLoadingToIdle):
(WebCore::HTMLMediaElement::progressEventTimerFired):
(WebCore::HTMLMediaElement::startPlaybackProgressTimer):
* platform/graphics/MediaPlayer.cpp:
(WebCore::NullMediaPlayerPrivate::didLoadingProgress):
(WebCore::MediaPlayer::didLoadingProgress):
* platform/graphics/MediaPlayer.h:
* platform/graphics/MediaPlayerPrivate.h:
(MediaPlayerPrivateInterface):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.cpp:
(WebCore::MediaPlayerPrivateAVFoundation::MediaPlayerPrivateAVFoundation):
* platform/graphics/avfoundation/MediaPlayerPrivateAVFoundation.h:
(MediaPlayerPrivateAVFoundation):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:
(WebCore::MediaPlayerPrivate::didLoadingProgress):
* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.h:
(MediaPlayerPrivate):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::didLoadingProgress):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
* platform/graphics/mac/MediaPlayerPrivateQTKit.h:
(MediaPlayerPrivateQTKit):
* platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
(WebCore::MediaPlayerPrivateQTKit::MediaPlayerPrivateQTKit):
(WebCore::MediaPlayerPrivateQTKit::didLoadingProgress):
* platform/graphics/qt/MediaPlayerPrivateQt.cpp:
(WebCore::MediaPlayerPrivateQt::MediaPlayerPrivateQt):
(WebCore::MediaPlayerPrivateQt::didLoadingProgress):
* platform/graphics/qt/MediaPlayerPrivateQt.h:
(MediaPlayerPrivateQt):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::MediaPlayerPrivateQuickTimeVisualContext):
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::didLoadingProgress):
* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.h:
(MediaPlayerPrivateQuickTimeVisualContext):
* platform/graphics/wince/MediaPlayerPrivateWinCE.h:
(MediaPlayerPrivate):

Source/WebKit/chromium:

* public/WebMediaPlayer.h:
(WebMediaPlayer):
* src/WebMediaPlayerClientImpl.cpp:
(WebKit::WebMediaPlayerClientImpl::didLoadingProgress):
* src/WebMediaPlayerClientImpl.h:
(WebMediaPlayerClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake DOM Exceptions Errors
arv@chromium.org [Thu, 31 May 2012 18:00:03 +0000 (18:00 +0000)]
Make DOM Exceptions Errors
https://bugs.webkit.org/show_bug.cgi?id=85078

Reviewed by Oliver Hunt.

WebIDL mandates that exceptions should have Error.prototype on its prototype chain.

For JSC we have access to the Error.prototype from the binding code.

For V8 we set a field in the WrapperTypeInfo and when the constructor function is created we
set the prototype as needed.

Updated test: fast/dom/DOMException/prototype-object.html

Source/JavaScriptCore:

* JavaScriptCore.xcodeproj/project.pbxproj:
* runtime/JSGlobalObject.cpp:
(JSC::JSGlobalObject::reset):
* runtime/JSGlobalObject.h:
(JSC):
(JSGlobalObject):
(JSC::JSGlobalObject::errorPrototype):

Source/WebCore:

* ForwardingHeaders/runtime/ErrorPrototype.h: Added.
* bindings/scripts/CodeGeneratorJS.pm:
(GenerateHeader):
(GenerateImplementation):
* bindings/scripts/CodeGeneratorV8.pm:
(GenerateNamedConstructorCallback):
(GenerateImplementation):
* bindings/scripts/test/JS/JSTestException.cpp:
(WebCore::JSTestException::createPrototype):
* bindings/scripts/test/JS/JSTestException.h:
* bindings/scripts/test/V8/V8Float64Array.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestActiveDOMObject.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestCustomNamedGetter.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestEventTarget.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestException.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestInterface.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestMediaQueryListListener.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNamedConstructor.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestNode.cpp:
(WebCore):
* bindings/scripts/test/V8/V8TestObj.cpp:
(WebCore):
(WebCore::V8TestObj::installPerContextProperties):
* bindings/scripts/test/V8/V8TestSerializedScriptValueInterface.cpp:
(WebCore):
* bindings/v8/NPV8Object.cpp:
(WebCore::npObjectTypeInfo):
* bindings/v8/V8BindingPerContextData.cpp:
(WebCore):
(WebCore::V8BindingPerContextData::init):
(WebCore::V8BindingPerContextData::createWrapperFromCacheSlowCase):
(WebCore::V8BindingPerContextData::constructorForTypeSlowCase):
* bindings/v8/V8BindingPerContextData.h:
(V8BindingPerContextData):
* bindings/v8/V8HiddenPropertyName.h:
(WebCore):
* bindings/v8/WrapperTypeInfo.h:
(WebCore):
(WrapperTypeInfo):
* bindings/v8/custom/V8HTMLImageElementConstructor.cpp:
(WebCore):

LayoutTests:

* fast/dom/DOMException/prototype-object-expected.txt:
* fast/dom/DOMException/prototype-object.html:
* fast/dom/DOMException/resources/prototype-object.js: Removed.
* platform/chromium-win/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Removed.
* platform/chromium-win/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Removed.
* platform/chromium-win/svg/filters/feBlend-invalid-mode-expected.txt: Removed.
* platform/chromium/dom/xhtml/level3/core/documentnormalizedocument10-expected.txt: Added.
* platform/chromium/dom/xhtml/level3/core/documentsetxmlversion03-expected.txt: Added.
* platform/chromium/fast/dom/DOMException/prototype-object-expected.txt:
* platform/chromium/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/NamedNodeMap-setNamedItem-crash-expected.txt.
* platform/chromium/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt: Renamed from LayoutTests/platform/chromium-mac/fast/dom/timer-clear-interval-in-handler-and-generate-error-expected.txt.
* platform/chromium/svg/filters/feBlend-invalid-mode-expected.txt: Renamed from LayoutTests/platform/chromium-mac/svg/filters/feBlend-invalid-mode-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] ASSERT(oldLayoutDelta == view()->layoutDelta()) failed in RenderBlock::layoutBl...
jberlin@webkit.org [Thu, 31 May 2012 17:56:12 +0000 (17:56 +0000)]
[Win] ASSERT(oldLayoutDelta == view()->layoutDelta()) failed in RenderBlock::layoutBlockChild
when running media/media-volume-slider-rendered-below.html
https://bugs.webkit.org/show_bug.cgi?id=87450

Add the test to the Windows Skipped list to get the bots greener.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] create WebTransformOperation interface for chromium platform
commit-queue@webkit.org [Thu, 31 May 2012 17:38:08 +0000 (17:38 +0000)]
[chromium] create WebTransformOperation interface for chromium platform
https://bugs.webkit.org/show_bug.cgi?id=87510

Patch by Ian Vollick <vollick@chromium.org> on 2012-05-31
Reviewed by James Robinson.

Source/Platform:

* Platform.gypi:
* chromium/public/WebTransformOperations.h: Added.
(WebKit):
(WebTransformOperations):
(WebKit::WebTransformOperations::~WebTransformOperations):
(WebKit::WebTransformOperations::WebTransformOperations):
(WebKit::WebTransformOperations::operator=):

Source/WebCore:

Unit tests:
    WebTransformOperationsTest.transformTypesAreUnique
    WebTransformOperationsTest.matchesTypesSameLength
    WebTransformOperationsTest.matchesTypesDifferentLength
    WebTransformOperationsTest.applyTranslate
    WebTransformOperationsTest.applyRotate
    WebTransformOperationsTest.applyScale
    WebTransformOperationsTest.applySkew
    WebTransformOperationsTest.applyPerspective
    WebTransformOperationsTest.applyMatrix
    WebTransformOperationsTest.applyOrder
    WebTransformOperationsTest.blendOrder
    WebTransformOperationsTest.blendProgress
    WebTransformOperationsTest.blendWhenTypesDoNotMatch

* WebCore.gypi:
* platform/chromium/support/WebTransformOperations.cpp: Added.
(WebKit):
(WebTransformOperationsPrivate):
(WebKit::WebTransformOperations::apply):
(WebKit::WebTransformOperations::blend):
(WebKit::WebTransformOperations::matchesTypes):
(WebKit::WebTransformOperations::appendTranslate):
(WebKit::WebTransformOperations::appendRotate):
(WebKit::WebTransformOperations::appendScale):
(WebKit::WebTransformOperations::appendSkew):
(WebKit::WebTransformOperations::appendPerspective):
(WebKit::WebTransformOperations::appendMatrix):
(WebKit::WebTransformOperations::reset):
(WebKit::WebTransformOperations::initialize):

Source/WebKit/chromium:

* WebKit.gypi:
* tests/WebTransformOperationsTest.cpp: Added.
(TEST):
(checkProgress):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago10 W3C video and audio canPlayType tests are failing on Mac and Win
jberlin@webkit.org [Thu, 31 May 2012 17:35:18 +0000 (17:35 +0000)]
10 W3C video and audio canPlayType tests are failing on Mac and Win
https://bugs.webkit.org/show_bug.cgi?id=75184

Add Windows-specific expected (failing?) results to get the bots greener.

* platform/win/media/W3C: Added.
* platform/win/media/W3C/audio: Added.
* platform/win/media/W3C/audio/canPlayType: Added.
* platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_1-expected.txt: Added.
* platform/win/media/W3C/audio/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
* platform/win/media/W3C/video: Added.
* platform/win/media/W3C/video/canPlayType: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_2-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_codecs_order_3-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_2-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_supported_but_no_codecs_parameter_3-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_3-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_4-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_5-expected.txt: Added.
* platform/win/media/W3C/video/canPlayType/canPlayType_two_implies_one_6-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Blackberry] WebKit's fullscreen mode needs to notify page client.
commit-queue@webkit.org [Thu, 31 May 2012 17:33:39 +0000 (17:33 +0000)]
[Blackberry] WebKit's fullscreen mode needs to notify page client.
https://bugs.webkit.org/show_bug.cgi?id=87337

Patch by Chris Guan <chris.guan@torchmobile.com.cn> on 2012-05-31
Reviewed by Antonio Gomes.

Move "fullScreenVideoCapable" into webpagePrivate to make code
clean for "fullScreenForElement/Node" of cromeClientBlackberry,
All Video checks and code path selections are in webpagePrivate now.
For some UX and secure reasons, we could not apply fullscreen capacity
for all elements, So we use client's fullscreenStart/Stop only for
those video elements and those elements containing video tags.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPage::notifyFullScreenVideoExited):
(WebKit):
(BlackBerry::WebKit::containsVideoTags):
(BlackBerry::WebKit::WebPagePrivate::enterFullScreenForElement):
(BlackBerry::WebKit::WebPagePrivate::exitFullScreenForElement):
* Api/WebPageClient.h:
* Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
* WebCoreSupport/ChromeClientBlackBerry.cpp:
(WebCore::ChromeClientBlackBerry::enterFullScreenForElement):
(WebCore::ChromeClientBlackBerry::exitFullScreenForElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Memory leak in webkit_web_view_init
commit-queue@webkit.org [Thu, 31 May 2012 17:29:02 +0000 (17:29 +0000)]
[GTK] Memory leak in webkit_web_view_init
https://bugs.webkit.org/show_bug.cgi?id=87943

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-31
Reviewed by Martin Robinson.

Fixed a memory leak in webkit_web_view_init by making the
UserMediaClientGtk to be owned by the WebView.

* webkit/webkitwebview.cpp:
(webkit_web_view_init):
* webkit/webkitwebviewprivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix reference to unset variable in debug mode
wingo@igalia.com [Thu, 31 May 2012 17:28:21 +0000 (17:28 +0000)]
Fix reference to unset variable in debug mode
https://bugs.webkit.org/show_bug.cgi?id=87981

Reviewed by Geoffrey Garen.

* runtime/JSONObject.cpp (Stringifier::Holder::Holder):
Initialize m_size in debug mode, as we check it later in an assert.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] EFL's DRT navigation_policy_decision implementation
commit-queue@webkit.org [Thu, 31 May 2012 17:15:20 +0000 (17:15 +0000)]
[EFL][DRT] EFL's DRT navigation_policy_decision implementation
https://bugs.webkit.org/show_bug.cgi?id=85006

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31
Reviewed by Tor Arne Vestbø.

Tools:

Added navigation_policy_decision implementation for DumpRenderTreeView.
Added LayoutTestController::setCustomPolicyDelegate implementation.
Modified LayoutTestController::waitForPolicyDelegate.

* DumpRenderTree/efl/DumpRenderTree.cpp:
* DumpRenderTree/efl/DumpRenderTreeChrome.cpp:
(DumpRenderTreeChrome::resetDefaultsToConsistentValues):
* DumpRenderTree/efl/DumpRenderTreeEfl.h:
* DumpRenderTree/efl/DumpRenderTreeView.cpp:
(navigationTypeToString): aux function
(onNavigationPolicyDecision): navigation_policy_decision implementation
(drtViewAdd):
* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::setCustomPolicyDelegate):
(LayoutTestController::waitForPolicyDelegate):

LayoutTests:

Unskipped corresponding tests. Those still not passing are put into
test_expectations.txt.

* platform/efl/Skipped:
* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
commit-queue@webkit.org [Thu, 31 May 2012 17:00:02 +0000 (17:00 +0000)]
[EFL][DRT] LayoutTestController does not implement clearApplicationCacheForOrigin
https://bugs.webkit.org/show_bug.cgi?id=86195

Patch by Jussi Kukkonen <jussi.kukkonen@intel.com> on 2012-05-31
Reviewed by Gustavo Noronha Silva.

Source/WebKit/efl:

add new function to clear security origin application cache,
and a function to create a security origin from url string.
Reindent the header to match new longer return signature.

* ewk/ewk_security_origin.cpp:
(ewk_security_origin_application_cache_clear):
(ewk_security_origin_new_from_string):
* ewk/ewk_security_origin.h:

Tools:

Implement clearApplicationCacheForOrigin in EFL
LayoutTestController.

* DumpRenderTree/efl/LayoutTestControllerEfl.cpp:
(LayoutTestController::clearApplicationCacheForOrigin):

LayoutTests:

Unskip http/tests/appcache/origin-delete.html now that
EFL TestLayoutController has required functionality.

* platform/efl/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agom_totalAllocated should be intialized in RenderArena constructor
yurys@chromium.org [Thu, 31 May 2012 16:53:16 +0000 (16:53 +0000)]
m_totalAllocated should be intialized in RenderArena constructor
https://bugs.webkit.org/show_bug.cgi?id=87967

Reviewed by Ojan Vafai.

* rendering/RenderArena.cpp:
(WebCore::RenderArena::RenderArena): added missing initializer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpell checker doesn't recognize contractions (apostrophes)
commit-queue@webkit.org [Thu, 31 May 2012 16:36:29 +0000 (16:36 +0000)]
Spell checker doesn't recognize contractions (apostrophes)
https://bugs.webkit.org/show_bug.cgi?id=86118

Patch by commit-queue@webkit.org <commit-queue@webkit.org@268f45cc-cd09-0410-ab3c-d52691b4dbfc> on 2012-05-31
Reviewed by Gustavo Noronha Silva.

The Enchant spell checker was breaking words on apostrophes, because
apparently they were always being detected as Pango word-end
characters. To know whether or not the apostrophe is a
word end character requires looking at a string with a larger
granularity than one character.

Simplify the way the we break strings, by search for non-graphable
character manually to find word starts and ends. This has the side
effect of removing the dependency on Pango and eliminating one copy.

This change also cleans up some misbehavior on the part of the
WebCoreSupport layer which was not converting from Unicode character
offsets to UTF-16. These offsets can be different if any of the
characters in the UTF-16 string are surrogate pairs (non BMP
characters).

* WebCoreSupport/TextCheckerClientGtk.cpp:
(WebKit::TextCheckerClientGtk::checkSpellingOfString): Properly
convert from Unicode offsets to UTF-16 offsets.
* webkit/webkitspellcheckerenchant.cpp:
(findByteOffsetToFirstNonGraphableCharacter): Added this helper.
(getExtentsOfNextWord): Ditto.
(wordIsSpelledCorrectlyInAtLeastOneDictionary): Ditto.
(checkSpellingOfString): Don't split words on apostrophes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Unreviewed. Added FAIL expectation due to failure after r119100.
mario@webkit.org [Thu, 31 May 2012 16:32:33 +0000 (16:32 +0000)]
[GTK] Unreviewed. Added FAIL expectation due to failure after r119100.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] 6 canvas tests failing
jberlin@webkit.org [Thu, 31 May 2012 16:08:15 +0000 (16:08 +0000)]
[Win] 6 canvas tests failing
https://bugs.webkit.org/show_bug.cgi?id=87983

Add Windows-specific expected (failing?) results to get the bots greener.

* platform/win/fast/canvas/canvas-draw-canvas-on-canvas-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-fillRect-gradient-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-scale-drawImage-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-scale-fillPath-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-scale-fillRect-shadow-expected.txt: Added.
* platform/win/fast/canvas/canvas-transforms-fillRect-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoThe difference between a column and a column group renderer is badly drawn
jchaffraix@webkit.org [Thu, 31 May 2012 16:00:20 +0000 (16:00 +0000)]
The difference between a column and a column group renderer is badly drawn
https://bugs.webkit.org/show_bug.cgi?id=87556

Reviewed by Abhishek Arya.

No expected change in behavior.

This patch tries to draw a better line between those 3 concepts:
- renderer is a RenderTableCol (RenderObject::isRenderTableCol).
- renderer is a column (RenderTableCol::isTableColumn()).
- renderer is a column group (RenderTableCol::isTableColumnGroup()).
(most of the code that needs to know the difference manipulate a RenderTableCol
so there was no need to move the 2 last helpers into RenderObject)

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::recalcColumn):
Factored the code to use the column / column group iteration we
set up in the rest of the code. Made the code more self-describing
by using more RenderTableCol functions.

* rendering/RenderObject.cpp:
(WebCore::RenderObject::addChild):
Factored the code to use the isTableColumn() and isTableColumnGroup() to
better underline what we check.

* rendering/RenderObject.h:
(WebCore::RenderObject::isRenderTableCol):
(WebCore::RenderObject::isTablePart):
Renamed isTableCol to isRenderTableCol to match the class as this doesn't
imply that the renderer is actually a column.

* html/HTMLTableColElement.cpp:
(WebCore::HTMLTableColElement::parseAttribute):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::fullRecalc):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::addChild):
(WebCore::RenderTable::layout):
(WebCore::RenderTable::firstColumn):
Updated after the isRenderTableCol rename.

* dom/Text.cpp:
(WebCore::Text::rendererIsNeeded):
* editing/htmlediting.cpp:
(WebCore::isTableStructureNode):
Ditto and renamed some variables.

* html/HTMLFormElement.cpp:
(WebCore::HTMLFormElement::rendererIsNeeded):
Ditto and added a FIXME as the logic doesn't seem very bullet proof.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
Changed to use the enclosingColumnGroup* helpers.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paintCell):
* rendering/RenderTableCol.cpp:
(WebCore::RenderTableCol::isChildAllowed):
(WebCore::RenderTableCol::canHaveChildren):
(WebCore::RenderTableCol::enclosingColumnGroup):
(WebCore::RenderTableCol::nextColumn):
Updated to use the new functions.

* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableColumn):
(WebCore::RenderTableCol::isTableColumnGroup):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentBefore):
(WebCore::RenderTableCol::enclosingColumnGroupIfAdjacentAfter):
Added the following new helpers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFix Lion build after r119073.
jberlin@webkit.org [Thu, 31 May 2012 15:41:33 +0000 (15:41 +0000)]
Fix Lion build after r119073.

* platform/Decimal.cpp:
(WebCore::Decimal::toString):
Do not attempt to assign a unsigned long long to an int.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Add webkit_download_get_request to WebKit2 GTK+ API
carlosgc@webkit.org [Thu, 31 May 2012 15:31:54 +0000 (15:31 +0000)]
[GTK] Add webkit_download_get_request to WebKit2 GTK+ API
https://bugs.webkit.org/show_bug.cgi?id=87957

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitDownload.cpp:
(webkit_download_get_request): Return the WebKitURIRequest
representing the request that originated the download.
* UIProcess/API/gtk/WebKitDownload.h:
* UIProcess/API/gtk/docs/webkit2gtk-sections.txt: Add new symbol.
* UIProcess/API/gtk/tests/TestDownloads.cpp:
(testDownloadLocalFile):
(testDownloadRemoteFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SOUP] WebProcess crashes when a download is started from an existing ResourceHandle
carlosgc@webkit.org [Thu, 31 May 2012 15:29:48 +0000 (15:29 +0000)]
[SOUP] WebProcess crashes when a download is started from an existing ResourceHandle
https://bugs.webkit.org/show_bug.cgi?id=87953

Reviewed by Martin Robinson.

The output stream to write the downloaded data is created in the
didReceiveResponse callback of the download client. When a
download is created for an existing ResourceHandle (this happens
for example when policy decision is download), the response has
already been received. In this case we should make sure that the
download client is notified about the response, so that when data
actually arrives the output stream has already been created.

* WebProcess/Downloads/soup/DownloadSoup.cpp:
(WebKit::Download::startWithHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Fix webkit_web_view_can_execute_editing_command() API doc
carlosgc@webkit.org [Thu, 31 May 2012 15:27:19 +0000 (15:27 +0000)]
[GTK] Fix webkit_web_view_can_execute_editing_command() API doc
https://bugs.webkit.org/show_bug.cgi?id=87930

Reviewed by Martin Robinson.

* UIProcess/API/gtk/WebKitWebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Crash when closing web page if selection is active
commit-queue@webkit.org [Thu, 31 May 2012 15:27:15 +0000 (15:27 +0000)]
[BlackBerry] Crash when closing web page if selection is active
https://bugs.webkit.org/show_bug.cgi?id=87962

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-05-31
Reviewed by Antonio Gomes.

The embedder may try to remove a layer from the compositor at a stage
where the compositor has been set to 0.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPage::addCompositingThreadOverlay):
(BlackBerry::WebKit::WebPage::removeCompositingThreadOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] Fix bug reference in array-override-set.html test
commit-queue@webkit.org [Thu, 31 May 2012 15:15:25 +0000 (15:15 +0000)]
[v8] Fix bug reference in array-override-set.html test
https://bugs.webkit.org/show_bug.cgi?id=87952

Patch by Ulan Degenbaev <ulan@chromium.org> on 2012-05-31
Reviewed by Abhishek Arya.

* fast/canvas/webgl/array-override-set-expected.txt:
* fast/canvas/webgl/array-override-set.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Unreviewed. Added FAIL expectation due to test consistently failing.
mario@webkit.org [Thu, 31 May 2012 15:12:18 +0000 (15:12 +0000)]
[GTK] Unreviewed. Added FAIL expectation due to test consistently failing.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Enable CSS_IMAGE_SET flag
commit-queue@webkit.org [Thu, 31 May 2012 14:47:30 +0000 (14:47 +0000)]
[EFL] Enable CSS_IMAGE_SET flag
https://bugs.webkit.org/show_bug.cgi?id=87727

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-31
Reviewed by Adam Roben.

.:

Add CSS_IMAGE_SET flag to CMake and enable it by default on EFL port.

* Source/cmake/OptionsEfl.cmake:
* Source/cmake/WebKitFeatures.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebCore:

Fix CMakeLists.txt so that CSSImageSetValue.cpp gets compiled if
CSS_IMAGE_SET flag is enabled.

* CMakeLists.txt:

LayoutTests:

Unskip test case associated to CSS image-set functionality now that it
is enabled by default on EFL port.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added FAIL expectation for GTK due to missing feature in DRT.
mario@webkit.org [Thu, 31 May 2012 14:44:34 +0000 (14:44 +0000)]
Unreviewed. Added FAIL expectation for GTK due to missing feature in DRT.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agothe imageSmoothingEnabled flag needs to be in the state object
commit-queue@webkit.org [Thu, 31 May 2012 14:32:13 +0000 (14:32 +0000)]
the imageSmoothingEnabled flag needs to be in the state object
https://bugs.webkit.org/show_bug.cgi?id=87853

Patch by Keyar Hood <keyar@chromium.org> on 2012-05-31
Reviewed by Darin Adler.

Source/WebCore:

Updated fast/canvas/canvas-imageSmoothingEnabled.html instead of
adding a new test.

The imageSmoothingEnabled flag is saved in the draw state now.
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::CanvasRenderingContext2D):
(WebCore::CanvasRenderingContext2D::State::State):
(WebCore::CanvasRenderingContext2D::State::operator=):
(WebCore::CanvasRenderingContext2D::webkitImageSmoothingEnabled):
(WebCore::CanvasRenderingContext2D::setWebkitImageSmoothingEnabled):
* html/canvas/CanvasRenderingContext2D.h:
(State):

LayoutTests:

Updated the test for imageSmoothingEnabled to test that it is saved in
the draw state.

* fast/canvas/canvas-imageSmoothingEnabled-expected.txt:
* fast/canvas/script-tests/canvas-imageSmoothingEnabled.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Fix checkbox position on Settings screen.
caseq@chromium.org [Thu, 31 May 2012 14:08:10 +0000 (14:08 +0000)]
Web Inspector: Fix checkbox position on Settings screen.
https://bugs.webkit.org/show_bug.cgi?id=87007

Patch by Eugene Klyuchnikov <eustas.bug@gmail.com> on 2012-05-31
Reviewed by Yury Semikhatsky.

Checkbox seems to be improperly aligned.
It is "shifted" up on 1px on Mac and 2px on Linux.
Also, keyboard-shortcuts screen has "wrapped" key descriptions on Mac.

UI changes, no new tests.

* inspector/front-end/helpScreen.css:
(.help-container): Fixed column width.
(.help-block): Ditto.
(.help-key-cell): Ditto.
(body.platform-mac .help-container): Ditto.
(body.platform-mac .help-block): Ditto.
(body.platform-mac .help-key-cell): Ditto.
(.help-content p): Ajdusted spacing between lines
(.help-content input[type=checkbox]): Fixed alignment.
(body.platform-mac .help-content input[type=checkbox]): Ditto.
(.help-content input[type=radio]): Fixed alignment.
(body.platform-mac .help-content input[type=radio]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
vestbo@webkit.org [Thu, 31 May 2012 14:00:53 +0000 (14:00 +0000)]
[Qt] Simplify QT_VERSION_CHECKS for Qt5 by introducing HAVE(QT5)
https://bugs.webkit.org/show_bug.cgi?id=87955

Reviewed by Simon Hausmann.

Source/WebCore:

* bridge/qt/qt_class.cpp:
* bridge/qt/qt_instance.cpp:
* bridge/qt/qt_runtime.h:
* page/qt/EventHandlerQt.cpp:
* platform/graphics/GraphicsContext3D.h:
* platform/graphics/OpenGLShims.cpp:
* platform/graphics/OpenGLShims.h:
* platform/graphics/gstreamer/PlatformVideoWindowPrivate.h:
* platform/graphics/gstreamer/PlatformVideoWindowQt.cpp:
* platform/graphics/qt/GraphicsContext3DQt.cpp:
* platform/graphics/qt/SimpleFontDataQt.cpp:
* platform/graphics/texmap/TextureMapper.h:
* platform/graphics/texmap/TextureMapperGL.cpp:
* platform/qt/DeviceMotionProviderQt.h:
* platform/qt/DeviceOrientationProviderQt.h:
* platform/qt/KURLQt.cpp:
* platform/qt/PlatformScreenQt.cpp:
* platform/qt/QWebPageClient.h:
* plugins/qt/PluginPackageQt.cpp:
* plugins/qt/PluginViewQt.cpp:

Source/WebKit/qt:

* Api/qgraphicswebview.cpp:
* Api/qgraphicswebview.h:
* Api/qwebframe.cpp:
* Api/qwebframe_p.h:
* Api/qwebpage.cpp:
* Api/qwebpage.h:
* Api/qwebsettings.cpp:
* Api/qwebview.cpp:
* Api/qwebview.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
* WebCoreSupport/GeolocationClientQt.cpp:
* WebCoreSupport/GeolocationClientQt.h:
* WebCoreSupport/PageClientQt.cpp:
* WebCoreSupport/WebEventConversion.cpp:
* declarative/plugin.cpp:
* tests/qwebframe/tst_qwebframe.cpp:
* tests/util.h:

Source/WebKit2:

* UIProcess/API/qt/tests/publicapi/tst_publicapi.cpp:

Source/WTF:

* wtf/qt/UtilsQt.h:

Tools:

* DumpRenderTree/qt/DumpRenderTreeQt.cpp:
* DumpRenderTree/qt/EventSenderQt.cpp:
* DumpRenderTree/qt/QtInitializeTestFonts.cpp:
* DumpRenderTree/qt/main.cpp:
* QtTestBrowser/cookiejar.cpp:
* QtTestBrowser/launcherwindow.cpp:
* WebKitTestRunner/InjectedBundle/qt/LayoutTestControllerQt.cpp:
* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHave StylePropertySet constructor take array/length instead of vector.
kling@webkit.org [Thu, 31 May 2012 13:38:47 +0000 (13:38 +0000)]
Have StylePropertySet constructor take array/length instead of vector.
<http://webkit.org/b/87876>

Reviewed by Antti Koivisto.

Remove the StylePropertyVector typedef and have StylePropertySet constructors
take CSSProperty*/length since we are copying the data into a tightly packed
array anyway. This frees up the call sites to use whatever storage they please
rather than being restricted to a vector with inlineCapacity=4.

Change said call sites to use an arbitrary high inline capacity (256) for their
stack-allocated temporary vectors.

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::copyPropertiesInSet):
* css/CSSParser.cpp:
(WebCore::filterProperties):
(WebCore::CSSParser::createStylePropertySet):
* css/StylePropertySet.cpp:
(WebCore::StylePropertySet::createImmutable):
(WebCore::StylePropertySet::StylePropertySet):
(WebCore::StylePropertySet::removePropertiesInSet):
(WebCore::StylePropertySet::copyPropertiesInSet):
* css/StylePropertySet.h:
(WebCore::StylePropertySet::create):
(StylePropertySet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r118989
commit-queue@webkit.org [Thu, 31 May 2012 13:24:13 +0000 (13:24 +0000)]
[EFL] Gardening after r118989
https://bugs.webkit.org/show_bug.cgi?id=87958

Unreviewed gardening.

fast/css/font-face-download-error.html is skipped as bug85977 is not fixed yet.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible(...
commit-queue@webkit.org [Thu, 31 May 2012 13:07:36 +0000 (13:07 +0000)]
[Qt][WK2] Add missing ViewportUpdateDeferrer guarding to setPageItemRectVisible() calls.
https://bugs.webkit.org/show_bug.cgi?id=87936

Patch by Zalan Bujtas <zbujtas@gmail.com> on 2012-05-31
Reviewed by Kenneth Rohde Christiansen.

* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::QtViewportInteractionEngine::viewportAttributesChanged):
(WebKit::QtViewportInteractionEngine::pageContentsSizeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFixing compilation with SVG disabled.
commit-queue@webkit.org [Thu, 31 May 2012 12:41:11 +0000 (12:41 +0000)]
Fixing compilation with SVG disabled.
https://bugs.webkit.org/show_bug.cgi?id=87944

This patch adds the missing enumeration value
'CSSPropertyWebkitBoxDecorationBreak' into switch statements to make
clang happy.

Patch by Mike West <mkwst@chromium.org> on 2012-05-31
Reviewed by Alexis Menard.

* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Unreviewed, update Mac Leopard baselines for fast/muticol/span/span-as...
apavlov@chromium.org [Thu, 31 May 2012 12:33:17 +0000 (12:33 +0000)]
[Chromium] Unreviewed, update Mac Leopard baselines for fast/muticol/span/span-as-immediate-columns-child.html.

* platform/chromium-mac-leopard/fast/multicol/span/span-as-immediate-columns-child-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Add WKURLRequestEfl and WKURLResponseEfl
commit-queue@webkit.org [Thu, 31 May 2012 12:30:02 +0000 (12:30 +0000)]
[EFL][WK2] Add WKURLRequestEfl and WKURLResponseEfl
https://bugs.webkit.org/show_bug.cgi?id=70231

Patch by Keunsoon Lee <keunsoon.lee@samsung.com> on 2012-05-31
Reviewed by Chang Shu.

These codes can be used for WKPageDecidePolicyForResponseCallback on page policy callbacks.
The callback conveys WKURLResponseRef and WKURLRequestRef as parameter.

By the way, EFL browser needs content type from response to decide correct policy.
Another information, cookie, is necessary with similar reason.
But, there is no way to obtain such information on WebKit2 main stream, except for WKURLRequestCopyURL().

So, EFL port created those files to extract necessary information from WKURLResponseRef and WKURLRequestRef,
and not to desturb WebKit2 main stream.

* Shared/API/c/efl/WKURLRequestEfl.cpp: Added.
(WKURLRequestEflCopyCookies): extracting cookie information from WKURLRequestRef.
* Shared/API/c/efl/WKURLRequestEfl.h: Added.
* Shared/API/c/efl/WKURLResponseEfl.cpp: Added.
(WKURLResponseEflCopyContentType): extracting content type (i.e. MIME type) from WKURLResponseRef.
* Shared/API/c/efl/WKURLResponseEfl.h: Added.
* Shared/efl/WebCoreArgumentCodersEfl.cpp: Added.
(CoreIPC):
(CoreIPC::::encode):
(CoreIPC::::decode):
* Shared/efl/WebURLRequestEfl.cpp: Added.
(WebKit):
(WebKit::WebURLRequestEfl::WebURLRequestEfl):
(WebKit::WebURLRequestEfl::cookies): obtaining cookie information from ResourceRequest.
* Shared/efl/WebURLRequestEfl.h: Added.
(WebKit):
(WebURLRequestEfl):
(WebKit::WebURLRequestEfl::create):
* Shared/efl/WebURLResponseEfl.cpp: Added.
(WebKit):
(WebKit::WebURLResponseEfl::WebURLResponseEfl):
(WebKit::WebURLResponseEfl::contentType): obtaining content type (i.e. MIME type) from ResourceResponse.
* Shared/efl/WebURLResponseEfl.h: Added.
(WebKit):
(WebURLResponseEfl):
(WebKit::WebURLResponseEfl::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119092 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening, skip new failing tests, unskip a now passing test.
ossy@webkit.org [Thu, 31 May 2012 12:06:32 +0000 (12:06 +0000)]
[Qt] Unreviewed gardening, skip new failing tests, unskip a now passing test.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119091 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added new baselines for GTK after r117815.
mario@webkit.org [Thu, 31 May 2012 11:57:51 +0000 (11:57 +0000)]
Unreviewed. Added new baselines for GTK after r117815.

* platform/gtk/svg/zoom/page/zoom-hixie-rendering-model-004-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.png: Added.
* platform/gtk/svg/zoom/page/zoom-svg-as-background-with-relative-size-and-viewBox-expected.txt: Added.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.png: Updated.
* platform/gtk/svg/zoom/page/zoom-svg-through-object-with-auto-size-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119090 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Added new baselines for GTK after r118891.
mario@webkit.org [Thu, 31 May 2012 11:57:31 +0000 (11:57 +0000)]
Unreviewed. Added new baselines for GTK after r118891.

* platform/gtk/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/gtk/fast/forms/select/optgroup-rendering-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119089 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Platform] Implementation of Decimal(int32_t) isn't portable.
yosin@chromium.org [Thu, 31 May 2012 11:54:18 +0000 (11:54 +0000)]
[Platform] Implementation of Decimal(int32_t) isn't portable.
https://bugs.webkit.org/show_bug.cgi?id=87941

Reviewed by Kent Tamura.

This patch changes negation of integer to make unsigned integer
in portable way.

No new tests. This patch doesn't change behavior.

* platform/Decimal.cpp:
(WebCore::Decimal::Decimal): Use uint64_t(-int64_t(i32)) instead of uint64_t(-i32)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119088 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/events/message-port-multi.html needs new baseline after r119027
ossy@webkit.org [Thu, 31 May 2012 11:48:03 +0000 (11:48 +0000)]
fast/events/message-port-multi.html needs new baseline after r119027
https://bugs.webkit.org/show_bug.cgi?id=87949

Unreviewed gardening.

Update baseline for fast/events/message-port-multi.html after r119027.
Now all the checks are passing and we can get rid of the FAIL lines in
the expected result.

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-31

* fast/events/message-port-multi-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][WK2] Rename ewk_private.h to ewk_view_private.h
gyuyoung.kim@samsung.com [Thu, 31 May 2012 11:35:18 +0000 (11:35 +0000)]
[EFL][WK2] Rename ewk_private.h to ewk_view_private.h
https://bugs.webkit.org/show_bug.cgi?id=87923

Reviewed by Kenneth Rohde Christiansen.

EFL WK1 decided to divide up ewk_private.h into each file's XXX_private.h file in order to maintain
internal functions more easily. EFL WK2 needs to adjust this as well.

* UIProcess/API/efl/PageClientImpl.cpp:
* UIProcess/API/efl/ewk_view_private.h: Renamed from Source/WebKit2/UIProcess/API/efl/ewk_private.h.
(WebCore):
* UIProcess/cairo/BackingStoreCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
apavlov@chromium.org [Thu, 31 May 2012 11:28:40 +0000 (11:28 +0000)]
Web Inspector: [Chromium] Cannot bring Inspector to front when paused on breakpoint
https://bugs.webkit.org/show_bug.cgi?id=87871

Reviewed by Yury Semikhatsky.

When input events handling is suppressed (due to the JS being paused on a breakpoint), we should report
these events as NOT handled by the WebKit, so that the browser can handle them appropriately
(on MacOS, switching between the application windows is done through the default key event handler, so if you run
event.preventDefault() for all keydown events in a handler, the Chromium window switch will not occur on Cmd+`).

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::handleInputEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r118993
commit-queue@webkit.org [Thu, 31 May 2012 11:22:29 +0000 (11:22 +0000)]
[EFL] Gardening after r118993
https://bugs.webkit.org/show_bug.cgi?id=87946

Unreviewed gardening.

Test fast/forms/file/input-file-write-files.html that was added at r118993 relies on
unsupported EventSender.beginDragWithFiles and hence should be skipped.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Unskipping tests for GTK now passing in all the bots.
mario@webkit.org [Thu, 31 May 2012 11:14:42 +0000 (11:14 +0000)]
Unreviewed. Unskipping tests for GTK now passing in all the bots.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agofast/dom/Window/mozilla-focus-blur.html failing after r118916
mario@webkit.org [Thu, 31 May 2012 10:42:17 +0000 (10:42 +0000)]
fast/dom/Window/mozilla-focus-blur.html failing after r118916
https://bugs.webkit.org/show_bug.cgi?id=87951

Unreviewed. Added FAIL expectation for GTK after r118916.

* platform/gtk/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoTest expectation pngs missing checksums
abecsi@webkit.org [Thu, 31 May 2012 10:10:38 +0000 (10:10 +0000)]
Test expectation pngs missing checksums
https://bugs.webkit.org/show_bug.cgi?id=87947

Reviewed by Ojan Vafai.

Add proper platform independent png expectation with checksum and revert chromium
expectations since layoutTestController.keepWebHistory() seems to have no effect
on chromium, and the test is still failing (See bug 87839).

* http/tests/misc/acid3-expected.png: Add png with embedded checksum.
* platform/chromium-mac-leopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
* platform/chromium-mac-snowleopard/http/tests/misc/acid3-expected.png: Revert to prior r118566.
* platform/chromium-mac/http/tests/misc/acid3-expected.png: Revert to prior r118566.
* platform/chromium-mac/http/tests/misc/acid3-expected.txt: Revert to prior r118566.
* platform/chromium/test_expectations.txt: Revert to prior r118566.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [CMAKE][EFL] Remove unneeded include path
gyuyoung.kim@samsung.com [Thu, 31 May 2012 10:02:14 +0000 (10:02 +0000)]
Source/WebCore: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using "<wtf/gobject/XXX>" directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

* PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.

Source/WebKit: [CMAKE][EFL] Remove unneeded include path
https://bugs.webkit.org/show_bug.cgi?id=87927

Reviewed by Kenneth Rohde Christiansen.

Though *wtf* directory was moved to Source/WTF, PlatformEfl.cmake is still including the previous
path. In addition, files on EFL port are using <wtf/gobject/XXX> directly in #include line.
So, EFL port doesn't need to include ${JAVASCRIPTCORE_DIR}/wtf/gobject path anymore.

* PlatformEfl.cmake: Remove '${JAVASCRIPTCORE_DIR}/wtf/gobject' path from include path list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119080 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolled DEPS.
peter@chromium.org [Thu, 31 May 2012 09:50:29 +0000 (09:50 +0000)]
Unreviewed.  Rolled DEPS.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119079 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Don't enforce the version of libpng for the config test when passing the option...
zoltan@webkit.org [Thu, 31 May 2012 09:47:14 +0000 (09:47 +0000)]
[Qt] Don't enforce the version of libpng for the config test when passing the option to the linker

Rubber-stamped by Kenneth Rohde Christiansen.

* qmake/config.tests/libpng/libpng.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119078 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Automatically install 64-bit linker for Android
peter@chromium.org [Thu, 31 May 2012 09:22:45 +0000 (09:22 +0000)]
[Chromium] Automatically install 64-bit linker for Android
https://bugs.webkit.org/show_bug.cgi?id=79780

Reviewed by Adam Barth.

Source/WebKit/chromium:

Change the Android-specific dependencies to inherit their revision from
Chromium's DEPS file, like many other dependencies do, solving the
versioning problem that we're running in to right now. These are listed
in Chromium's main DEPS file starting Chromium r139529.

* DEPS:

Tools:

Change the update-webkit-chromium script to check whether the 64-bit
linker needs to be installed as part of the update process. The actual
code for doing these checks and "installing" it has been added to the
webkitdirs.pm script.

The linker itself is part of the third_party/aosp repository, which
will be pulled in through the DEPS change.

* Scripts/update-webkit-chromium:
* Scripts/webkitdirs.pm:
(chromiumInstall64BitAndroidLinkerIfNeeded):
(chromiumReplaceAndroidLinkerIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119077 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Gardening after r118957
commit-queue@webkit.org [Thu, 31 May 2012 09:02:02 +0000 (09:02 +0000)]
[EFL] Gardening after r118957
https://bugs.webkit.org/show_bug.cgi?id=87937

Unreviewed gardening.

compositing/layer-creation/fixed-position-and-transform.html and compositing/layer-creation/fixed-position-under-transform.html
added with r118957 were skipped in EFL port as EFL's LayoutTestController does not implement layerTreeAsText.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119076 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Chromium Linux (Tests) after r119073.
yosin@chromium.org [Thu, 31 May 2012 08:55:10 +0000 (08:55 +0000)]
Build fix for Chromium Linux (Tests) after r119073.

* tests/DecimalTest.cpp:
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119075 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Rebase xss test, skip failing tests.
kkristof@inf.u-szeged.hu [Thu, 31 May 2012 08:42:35 +0000 (08:42 +0000)]
[Qt] Unreviewed gardening. Rebase xss test, skip failing tests.

Patch by Zoltan Arvai <zarvai@inf.u-szeged.hu> on 2012-05-31

* platform/qt/Skipped:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-document-write-expected.txt:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-navigate-opener-javascript-url-expected.txt:
* platform/qt/http/tests/security/aboutBlank/xss-DENIED-set-opener-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119074 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Platform] Introduce Decimal class for Number/Range input type.
yosin@chromium.org [Thu, 31 May 2012 08:28:29 +0000 (08:28 +0000)]
[Platform] Introduce Decimal class for Number/Range input type.
https://bugs.webkit.org/show_bug.cgi?id=87360

Reviewed by Kent Tamura.

Source/WebCore:

This patch added new class Decimal for decimal arithmatic in two
files: platform/Decimal.cpp and Decimal.h with unit test.

Test: WebKit/chromium/tests/DecimalTest.cpp

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/Decimal.cpp: Added.
(WebCore):
(DecimalPrivate):
(SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::handle):
(WebCore::DecimalPrivate::SpecialValueHandler::value):
(UInt128):
(WebCore::DecimalPrivate::UInt128::UInt128):
(WebCore::DecimalPrivate::UInt128::high):
(WebCore::DecimalPrivate::UInt128::low):
(WebCore::DecimalPrivate::UInt128::multiply):
(WebCore::DecimalPrivate::UInt128::highUInt32):
(WebCore::DecimalPrivate::UInt128::lowUInt32):
(WebCore::DecimalPrivate::UInt128::isZero):
(WebCore::DecimalPrivate::UInt128::makeUInt64):
(WebCore::DecimalPrivate::UInt128::operator/=):
(WebCore::DecimalPrivate::UInt128::multiplyHigh):
(WebCore::DecimalPrivate::countDigits):
(WebCore::DecimalPrivate::scaleDown):
(WebCore::DecimalPrivate::scaleUp):
(WebCore::Decimal::EncodedData::EncodedData):
(WebCore::Decimal::EncodedData::operator==):
(WebCore::Decimal::Decimal):
(WebCore::Decimal::operator=):
(WebCore::Decimal::operator+=):
(WebCore::Decimal::operator-=):
(WebCore::Decimal::operator*=):
(WebCore::Decimal::operator/=):
(WebCore::Decimal::operator-):
(WebCore::Decimal::operator+):
(WebCore::Decimal::operator*):
(WebCore::Decimal::operator/):
(WebCore::Decimal::operator==):
(WebCore::Decimal::operator!=):
(WebCore::Decimal::operator<):
(WebCore::Decimal::operator<=):
(WebCore::Decimal::operator>):
(WebCore::Decimal::operator>=):
(WebCore::Decimal::abs):
(WebCore::Decimal::alignOperands):
(WebCore::Decimal::ceiling):
(WebCore::Decimal::compareTo):
(WebCore::Decimal::floor):
(WebCore::Decimal::fromString):
(WebCore::Decimal::infinity):
(WebCore::Decimal::nan):
(WebCore::Decimal::remainder):
(WebCore::Decimal::round):
(WebCore::Decimal::toString):
(WebCore::Decimal::zero):
* platform/Decimal.h: Added.
(WebCore):
(DecimalPrivate):
(Decimal):
(EncodedData):
(WebCore::Decimal::EncodedData::operator!=):
(WebCore::Decimal::EncodedData::coefficient):
(WebCore::Decimal::EncodedData::exponent):
(WebCore::Decimal::EncodedData::isFinite):
(WebCore::Decimal::EncodedData::isNaN):
(WebCore::Decimal::EncodedData::isSpecial):
(WebCore::Decimal::EncodedData::isZero):
(WebCore::Decimal::EncodedData::sign):
(WebCore::Decimal::EncodedData::setSign):
(WebCore::Decimal::EncodedData::formatClass):
(WebCore::Decimal::isFinite):
(WebCore::Decimal::isNaN):
(WebCore::Decimal::isNegative):
(WebCore::Decimal::isPositive):
(WebCore::Decimal::isSpecial):
(WebCore::Decimal::isZero):
(WebCore::Decimal::value):
(AlignedOperands):
(WebCore::Decimal::invertSign):
(WebCore::Decimal::exponent):
(WebCore::Decimal::sign):

Source/WebKit/chromium:

This patch added unit test for Decimal class.

* WebKit.gypi:
* tests/DecimalTest.cpp: Added.
(WebCore):
(WebCore::operator<<): Output Decimal for unit test debugging
(DecimalStepRange):
(DecimalStepRange::DecimalStepRange):
(DecimalStepRange::clampValue):
(DecimalTest):
(DecimalTest::encode):
(DecimalTest::fromString):
(DecimalTest::stepDown):
(DecimalTest::stepUp):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL][DRT] Gardening after r118920
commit-queue@webkit.org [Thu, 31 May 2012 08:22:54 +0000 (08:22 +0000)]
[EFL][DRT] Gardening after r118920
https://bugs.webkit.org/show_bug.cgi?id=87934

Unreviewed, gardening of http/tests/local/fileapi/file-last-modified-after-delete.html which
relies on unsupported drag'n'drop feature.

Patch by Mikhail Pozdnyakov <mikhail.pozdnyakov@intel.com> on 2012-05-31

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Retainers are missing for all objects
commit-queue@webkit.org [Thu, 31 May 2012 08:05:10 +0000 (08:05 +0000)]
Web Inspector: Retainers are missing for all objects
https://bugs.webkit.org/show_bug.cgi?id=87655

Skip the test on wincairo platform.

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-05-31
Reviewed by Yury Semikhatsky.

* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[V8] Pass Isolate to v8String() in custom bindings
haraken@chromium.org [Thu, 31 May 2012 08:00:35 +0000 (08:00 +0000)]
[V8] Pass Isolate to v8String() in custom bindings
https://bugs.webkit.org/show_bug.cgi?id=87825

Reviewed by Adam Barth.

The objective is to pass Isolate around in V8 bindings.
This patch passes Isolate to v8String() in custom bindings.

No tests. No change in behavior.

* bindings/v8/custom/V8ArrayBufferViewCustom.cpp:
(WebCore::installFastSet):
* bindings/v8/custom/V8ArrayBufferViewCustom.h:
(WebCore):
(WebCore::setWebGLArrayHelper):
* bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp:
(WebCore::V8CSSStyleDeclaration::namedPropertyEnumerator):
(WebCore::V8CSSStyleDeclaration::namedPropertyGetter):
* bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8ClipboardCustom.cpp:
(WebCore::V8Clipboard::typesAccessorGetter):
* bindings/v8/custom/V8DOMStringMapCustom.cpp:
(WebCore::V8DOMStringMap::namedPropertyGetter):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):
* bindings/v8/custom/V8FileReaderCustom.cpp:
(WebCore::V8FileReader::resultAccessorGetter):
* bindings/v8/custom/V8HTMLCanvasElementCustom.cpp:
(WebCore::V8HTMLCanvasElement::toDataURLCallback):
* bindings/v8/custom/V8HTMLElementCustom.cpp:
(WebCore::toV8Object):
* bindings/v8/custom/V8HTMLInputElementCustom.cpp:
(WebCore::V8HTMLInputElement::selectionDirectionAccessorGetter):
* bindings/v8/custom/V8IDBAnyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8IDBKeyCustom.cpp:
(WebCore::toV8):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::V8InjectedScriptHost::databaseIdCallback):
(WebCore::V8InjectedScriptHost::storageIdCallback):
* bindings/v8/custom/V8InspectorFrontendHostCustom.cpp:
(WebCore::V8InspectorFrontendHost::platformCallback):
* bindings/v8/custom/V8JavaScriptCallFrameCustom.cpp:
(WebCore::V8JavaScriptCallFrame::typeAccessorGetter):
* bindings/v8/custom/V8LocationCustom.cpp:
(WebCore::V8Location::toStringCallback):
* bindings/v8/custom/V8SQLResultSetRowListCustom.cpp:
(WebCore::V8SQLResultSetRowList::itemCallback):
* bindings/v8/custom/V8StorageCustom.cpp:
(WebCore::V8Storage::namedPropertyEnumerator):
(WebCore::storageGetter):
* bindings/v8/custom/V8XMLHttpRequestCustom.cpp:
(WebCore::V8XMLHttpRequest::responseTextAccessorGetter):
* bindings/v8/custom/V8XSLTProcessorCustom.cpp:
(WebCore::V8XSLTProcessor::getParameterCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoComposedShadowTreeWalker should support traversing nodes in an orphaned shadow subtree.
hayato@chromium.org [Thu, 31 May 2012 07:55:29 +0000 (07:55 +0000)]
ComposedShadowTreeWalker should support traversing nodes in an orphaned shadow subtree.
https://bugs.webkit.org/show_bug.cgi?id=87493

Reviewed by Dimitri Glazkov.

Source/WebCore:

ComposedShadowTreeWalker assumed that a visited shadow root is
always assigned to a shadow insertion point since it only
traverses nodes which are rendered.  But there is an exceptional
use case such as an event dispatching. Some events, such as a
'click' event, may happen in an orphaned shadow subtree.  In such
cases, traversal might start with a node in an orphaned shadow
subtree.  So ComposedShadowTreeWalker can not assume that visited
shadow root is always assigned to a shadow insertion point.

This patch only fixes ComposedShadowTreeWalker.
ComposedShadowTreeParentWalker will be fixed in another patch with
an event dispatching test.

Test: fast/dom/shadow/composed-shadow-tree-walker.html

* dom/ComposedShadowTreeWalker.cpp:
(WebCore::ComposedShadowTreeWalker::traverseParentBackToYoungerShadowRootOrHost):

LayoutTests:

* fast/dom/shadow/composed-shadow-tree-walker.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: add MemoryUsageSupport::processMemorySizesInBytes
yurys@chromium.org [Thu, 31 May 2012 07:33:16 +0000 (07:33 +0000)]
Web Inspector: add MemoryUsageSupport::processMemorySizesInBytes
https://bugs.webkit.org/show_bug.cgi?id=87830

Reviewed by James Robinson.

Source/Platform:

* chromium/public/Platform.h:
(Platform):
(WebKit::Platform::processMemorySizesInBytes): moved this method from
Source/WebKit/chromium/public/platform/WebKitPlatformSupport.h, also
removed 'get' prefix.

Source/WebCore:

Added a method for getting process memory usage in bytes. It is
used in the inspector memory instrumentation to get process total
memory usage.

* inspector/InspectorMemoryAgent.cpp:
(WebCore::InspectorMemoryAgent::getProcessMemoryDistribution):
* platform/MemoryUsageSupport.cpp:
(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):
* platform/MemoryUsageSupport.h:
(MemoryUsageSupport): provided embedders with a way to report WebKit process
memory usage.
* platform/chromium/MemoryUsageSupportChromium.cpp:
(WebCore::MemoryUsageSupport::processMemorySizesInBytes):
(WebCore):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h: pulled getProcessMemorySize up
to the Source/Platform/chromium/public/Platform.h
* src/PlatformSupport.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r119062 and r119064.
tkent@chromium.org [Thu, 31 May 2012 07:22:58 +0000 (07:22 +0000)]
Unreviewed, rolling out r119062 and r119064.
http://trac.webkit.org/changeset/119062
http://trac.webkit.org/changeset/119064
https://bugs.webkit.org/show_bug.cgi?id=87360

Broke build on Lion, SnowLoepard, Chromium Windows, and
Chromium Linux 32

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/Decimal.cpp: Removed.
* platform/Decimal.h: Removed.

Source/WebKit/chromium:

* WebKit.gypi:
* tests/DecimalTest.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMove the specification of framework and library linking out of WebKit2.xcodeproj...
aestes@apple.com [Thu, 31 May 2012 07:18:32 +0000 (07:18 +0000)]
Move the specification of framework and library linking out of WebKit2.xcodeproj and into WebKit2.xcconfig
https://bugs.webkit.org/show_bug.cgi?id=87932

Reviewed by Dan Bernstein.

Doing this makes it easier to vary linking based on SDK or other factors.

* Configurations/WebKit2.xcconfig: Create FRAMEWORK_AND_LIBRARY_LDFLAGS,
which specifies the same list of frameworks and libraries that were
previously in WebKit2's 'Link Binary With Libraries' build phase, and
append it to $(OTHER_LDFLAGS).
* WebKit2.xcodeproj/project.pbxproj: Remove all frameworks and
libraries from the 'Link Binary With Libraries' build phase.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agotext-decoration should not be propagated through absolutely positioned elements to...
commit-queue@webkit.org [Thu, 31 May 2012 07:12:48 +0000 (07:12 +0000)]
text-decoration should not be propagated through absolutely positioned elements to <a> tags
https://bugs.webkit.org/show_bug.cgi?id=86517

Source/WebCore:

Patch by Shane Stephens <shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.

Test: fast/css/text-decoration-in-second-order-descendants.html

* rendering/RenderObject.cpp:
(WebCore::RenderObject::getTextDecorationColors):
Remove fix from 18611 as it doesn't work on second order descendants.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::adjustRenderStyle):
Add floating and positioned checks when deciding whether to avoid propagating text decoration. Move all checks into new method to improve readability.
(WebCore::doesNotInheritTextDecoration): Added

LayoutTests:

Added layout test to check no propagation of text-decoration to second-order descendants
(i.e. descendants of descendants), where the first-order descendant is positioned.

Tightened up existing descendants test to fail when text-decoration is incorrectly propagated
to first-order descendant.

Patch by Shane Stephens <shanestephens@google.com> on 2012-05-31
Reviewed by Darin Adler.

* fast/css/text-decoration-in-descendants-expected.html:
* fast/css/text-decoration-in-second-order-descendants-expected.html: Added.
* fast/css/text-decoration-in-second-order-descendants.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for Linon/SnowLeopard after r119062
yosin@chromium.org [Thu, 31 May 2012 06:58:10 +0000 (06:58 +0000)]
Build fix for Linon/SnowLeopard after r119062

* platform/Decimal.cpp:
(WebCore::Decimal::Decimal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
commit-queue@webkit.org [Thu, 31 May 2012 06:46:16 +0000 (06:46 +0000)]
[GTK] [WK2] Memory leak in webkitWebViewBaseStartDrag
https://bugs.webkit.org/show_bug.cgi?id=87756

Patch by Sudarsana Nagineni <sudarsana.nagineni@linux.intel.com> on 2012-05-30
Reviewed by Carlos Garcia Campos.

Source/WebKit/gtk:

Fixed a memory leak in drag and drop by using adoptRef instead
of just getting a new reference of targetList.

* WebCoreSupport/DragClientGtk.cpp:
(WebKit::DragClient::startDrag):

Source/WebKit2:

Fixed memory leaks in drag and drop by using adoptRef instead
of just getting new references.

* UIProcess/API/gtk/WebKitWebViewBase.cpp:
(webkitWebViewBaseStartDrag):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Platform] Introduce Decimal class for Number/Range input type.
yosin@chromium.org [Thu, 31 May 2012 06:36:42 +0000 (06:36 +0000)]
[Platform] Introduce Decimal class for Number/Range input type.
https://bugs.webkit.org/show_bug.cgi?id=87360

Reviewed by Kent Tamura.

Source/WebCore:

This patch added new class Decimal for decimal arithmatic in two
files: platform/Decimal.cpp and Decimal.h with unit test.

Test: WebKit/chromium/tests/DecimalTest.cpp

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/Decimal.cpp: Added.
(WebCore):
(DecimalPrivate):
(SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::SpecialValueHandler):
(WebCore::DecimalPrivate::SpecialValueHandler::handle):
(WebCore::DecimalPrivate::SpecialValueHandler::value):
(UInt128):
(WebCore::DecimalPrivate::UInt128::UInt128):
(WebCore::DecimalPrivate::UInt128::high):
(WebCore::DecimalPrivate::UInt128::low):
(WebCore::DecimalPrivate::UInt128::multiply):
(WebCore::DecimalPrivate::UInt128::highUInt32):
(WebCore::DecimalPrivate::UInt128::lowUInt32):
(WebCore::DecimalPrivate::UInt128::isZero):
(WebCore::DecimalPrivate::UInt128::makeUInt64):
(WebCore::DecimalPrivate::UInt128::operator/=):
(WebCore::DecimalPrivate::UInt128::multiplyHigh):
(WebCore::DecimalPrivate::countDigits):
(WebCore::DecimalPrivate::scaleDown):
(WebCore::DecimalPrivate::scaleUp):
(WebCore::Decimal::EncodedData::EncodedData):
(WebCore::Decimal::EncodedData::operator==):
(WebCore::Decimal::Decimal):
(WebCore::Decimal::operator=):
(WebCore::Decimal::operator+=):
(WebCore::Decimal::operator-=):
(WebCore::Decimal::operator*=):
(WebCore::Decimal::operator/=):
(WebCore::Decimal::operator-):
(WebCore::Decimal::operator+):
(WebCore::Decimal::operator*):
(WebCore::Decimal::operator/):
(WebCore::Decimal::operator==):
(WebCore::Decimal::operator!=):
(WebCore::Decimal::operator<):
(WebCore::Decimal::operator<=):
(WebCore::Decimal::operator>):
(WebCore::Decimal::operator>=):
(WebCore::Decimal::abs):
(WebCore::Decimal::alignOperands):
(WebCore::Decimal::ceiling):
(WebCore::Decimal::compareTo):
(WebCore::Decimal::floor):
(WebCore::Decimal::fromString):
(WebCore::Decimal::infinity):
(WebCore::Decimal::nan):
(WebCore::Decimal::remainder):
(WebCore::Decimal::round):
(WebCore::Decimal::toString):
(WebCore::Decimal::zero):
* platform/Decimal.h: Added.
(WebCore):
(DecimalPrivate):
(Decimal):
(EncodedData):
(WebCore::Decimal::EncodedData::operator!=):
(WebCore::Decimal::EncodedData::coefficient):
(WebCore::Decimal::EncodedData::exponent):
(WebCore::Decimal::EncodedData::isFinite):
(WebCore::Decimal::EncodedData::isNaN):
(WebCore::Decimal::EncodedData::isSpecial):
(WebCore::Decimal::EncodedData::isZero):
(WebCore::Decimal::EncodedData::sign):
(WebCore::Decimal::EncodedData::setSign):
(WebCore::Decimal::EncodedData::formatClass):
(WebCore::Decimal::isFinite):
(WebCore::Decimal::isNaN):
(WebCore::Decimal::isNegative):
(WebCore::Decimal::isPositive):
(WebCore::Decimal::isSpecial):
(WebCore::Decimal::isZero):
(WebCore::Decimal::value):
(AlignedOperands):
(WebCore::Decimal::invertSign):
(WebCore::Decimal::exponent):
(WebCore::Decimal::sign):

Source/WebKit/chromium:

This patch added unit test for Decimal class.

* WebKit.gypi:
* tests/DecimalTest.cpp: Added.
(WebCore):
(WebCore::operator<<): Output Decimal for unit test debugging
(DecimalStepRange):
(DecimalStepRange::DecimalStepRange):
(DecimalStepRange::clampValue):
(DecimalTest):
(DecimalTest::encode):
(DecimalTest::fromString):
(DecimalTest::stepDown):
(DecimalTest::stepUp):
(TEST_F):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r116723.
paroga@webkit.org [Thu, 31 May 2012 06:30:03 +0000 (06:30 +0000)]
Build fix for WinCE after r116723.

* platform/graphics/wince/FontWinCE.cpp:
(WebCore::TextRunComponent::TextRunComponent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoImplement CSSParser::determineNameInNamespace() as a helper function for CSSGrammar.y
haraken@chromium.org [Thu, 31 May 2012 06:23:53 +0000 (06:23 +0000)]
Implement CSSParser::determineNameInNamespace() as a helper function for CSSGrammar.y
https://bugs.webkit.org/show_bug.cgi?id=87799

Reviewed by Darin Adler.

As pointed out by darin@ in https://bugs.webkit.org/show_bug.cgi?id=87627#c12,
we should avoid repeating the following code in CSSGrammar.y:

    if (p->m_styleSheet)
        $$->setTag(QualifiedName(namespacePrefix, $2, p->m_styleSheet->determineNamespace(namespacePrefix)));
    else
        $$->setTag(QualifiedName(namespacePrefix, $2, p->m_defaultNamespace));

This patch implements CSSParser::determineNameInNamespace() as a helper function
and replaces the above code.

Tests: fast/dom/SelectorAPI/*. No change in test results.

* css/CSSGrammar.y:
* css/CSSParser.cpp:
(WebCore::CSSParser::determineNameInNamespace):
(WebCore):
* css/CSSParser.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r117697.
paroga@webkit.org [Thu, 31 May 2012 06:15:17 +0000 (06:15 +0000)]
Build fix for WinCE after r117697.

* page/wince/FrameWinCE.cpp:
(WebCore::computePageRectsForFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Fix min/max bounds error in CCMathUtil.cpp
shawnsingh@chromium.org [Thu, 31 May 2012 06:05:30 +0000 (06:05 +0000)]
[chromium] Fix min/max bounds error in CCMathUtil.cpp
https://bugs.webkit.org/show_bug.cgi?id=87915

Reviewed by James Robinson.

Source/WebCore:

Two unit tests added to CCMathUtilTest:
    CCMathUtilTest.verifyEnclosingClippedRectUsesCorrectInitialBounds
    CCMathUtilTest.verifyEnclosingRectOfVerticesUsesCorrectInitialBounds

While computing bounds, the initial values for xmax and ymax are
intended to be set to -float_max. It turns out that
std::numeric_limits<float>::min() actually returns the smallest
positive value close to zero, which is not what was intended. This
patch fixes the code to use -float_max instead, which is the
intended value.

* platform/graphics/chromium/cc/CCMathUtil.cpp:
(WebCore::CCMathUtil::mapClippedRect):
(WebCore::CCMathUtil::projectClippedRect):
(WebCore::CCMathUtil::computeEnclosingRectOfVertices):
(WebCore::CCMathUtil::computeEnclosingClippedRect):
(WebCore):
* platform/graphics/chromium/cc/CCMathUtil.h:
(WebCore::HomogeneousCoordinate::HomogeneousCoordinate):
(HomogeneousCoordinate):
(WebCore::HomogeneousCoordinate::shouldBeClipped):
(WebCore::HomogeneousCoordinate::cartesianPoint2d):
(WebCore):
(CCMathUtil):

Source/WebKit/chromium:

* tests/CCMathUtilTest.cpp:
(WebCore::TEST):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoBuild fix for WinCE after r118568.
paroga@webkit.org [Thu, 31 May 2012 05:58:45 +0000 (05:58 +0000)]
Build fix for WinCE after r118568.

* platform/text/wince/TextBreakIteratorWinCE.cpp:
(WebCore::NonSharedCharacterBreakIterator::NonSharedCharacterBreakIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRoll chromium DEPS from r139300 to r139542. Unreviewed.
fischman@chromium.org [Thu, 31 May 2012 05:50:23 +0000 (05:50 +0000)]
Roll chromium DEPS from r139300 to r139542.  Unreviewed.
https://bugs.webkit.org/show_bug.cgi?id=87868

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in ContainerNode::parserAddChild.
inferno@chromium.org [Thu, 31 May 2012 04:25:01 +0000 (04:25 +0000)]
Crash in ContainerNode::parserAddChild.
https://bugs.webkit.org/show_bug.cgi?id=87903

Reviewed by Ryosuke Niwa.

Source/WebCore:

Call the ChildNodeInsertionNotifier.notify call at the end since
it can destroy |this| and some of the local pointers like |last|.
This also matches the order of calls - childrenChanged precedes
ChildNodeInsertionNotifier.notify in updateTreeAfterInsertion and
ContainerNode::parserInsertBefore.

Also remove a FIXME since we use ChildNodeInsertionNotifier.notify
instead of ChildNodeInsertionNotifier.notifyInsertedIntoDocument
(as recommended in the FIXME).

Test: fast/dom/child-insertion-notify-crash.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::parserAddChild):

LayoutTests:

* fast/dom/child-insertion-notify-crash-expected.txt: Added.
* fast/dom/child-insertion-notify-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
commit-queue@webkit.org [Thu, 31 May 2012 03:59:39 +0000 (03:59 +0000)]
[BlackBerry] Add an Accelerated Compositing layer for Web Inspector DOM highlight.
https://bugs.webkit.org/show_bug.cgi?id=81001

Source/WebKit:

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-05-30
Reviewed by Antonio Gomes

Added new InspectorOverlay class

* PlatformBlackBerry.cmake:

Source/WebKit/blackberry:

Patch by Konrad Piascik <kpiascik@rim.com> on 2012-05-30
Reviewed by Antonio Gomes.

Implemented InspectorOverlay using WebOverlayAPI.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::renderContents):
* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::updateDelegatedOverlays):
(BlackBerry::WebKit::WebPagePrivate::commitRootLayerIfNeeded):
(BlackBerry::WebKit::WebPagePrivate::setInspectorOverlayClient):
(WebKit):
* Api/WebPage_p.h:
(WebCore):
(WebPagePrivate):
* WebCoreSupport/InspectorClientBlackBerry.cpp:
(WebCore::InspectorClientBlackBerry::highlight):
(WebCore::InspectorClientBlackBerry::hideHighlight):
(WebCore::InspectorClientBlackBerry::paintInspectorOverlay):
(WebCore):
* WebCoreSupport/InspectorClientBlackBerry.h:
(InspectorClientBlackBerry):
* WebCoreSupport/InspectorOverlay.cpp: Added.
(WebCore):
(WebCore::InspectorOverlay::create):
(WebCore::InspectorOverlay::InspectorOverlay):
(WebCore::InspectorOverlay::notifySyncRequired):
(WebCore::InspectorOverlay::paintContents):
(WebCore::InspectorOverlay::showDebugBorders):
(WebCore::InspectorOverlay::showRepaintCounter):
(WebCore::InspectorOverlay::contentsVisible):
(WebCore::InspectorOverlay::~InspectorOverlay):
(WebCore::InspectorOverlay::clear):
(WebCore::InspectorOverlay::update):
(WebCore::InspectorOverlay::paintWebFrame):
(WebCore::InspectorOverlay::invalidateWebFrame):
* WebCoreSupport/InspectorOverlay.h: Added.
(WebKit):
(WebCore):
(InspectorOverlay):
(InspectorOverlayClient):
(WebCore::InspectorOverlay::setClient):
(WebCore::InspectorOverlay::notifyAnimationStarted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Implement pointer and hover CSS media features
commit-queue@webkit.org [Thu, 31 May 2012 03:56:21 +0000 (03:56 +0000)]
[chromium] Implement pointer and hover CSS media features
https://bugs.webkit.org/show_bug.cgi?id=87403

Patch by Rick Byers <rbyers@chromium.org> on 2012-05-30
Reviewed by Adam Barth.

Source/WebCore:

Add initial support for the pointer and hover media features as defined
here:
http://dev.w3.org/csswg/css4-mediaqueries/#pointer
http://dev.w3.org/csswg/css4-mediaqueries/#hover

For now this only supports the case where we know a touch screen is
available (currently known only for the chromium port on certain
platforms).  All other cases continue to behave exactly as if the media
feature isn't supported.

Tests: fast/media/mq-pointer.html

* css/CSSValueKeywords.in:
* css/MediaFeatureNames.h:
(MediaFeatureNames):
* css/MediaQueryEvaluator.cpp:
(WebCore::getLeastCapablePrimaryPointerDeviceType):
(WebCore):
(WebCore::hoverMediaFeatureEval):
(WebCore::pointerMediaFeatureEval):

* testing/InternalSettings.cpp:
(WebCore::InternalSettings::InternalSettings):
(WebCore::InternalSettings::restoreTo):
(WebCore::InternalSettings::setDeviceSupportsTouch):
(WebCore):
* testing/InternalSettings.h:
(InternalSettings):
* testing/InternalSettings.idl:

LayoutTests:

Adds tests for pointer and hover media features, for the initial cases
with and without a touch screen.

* fast/media/mq-pointer-expected.txt: Added.
* fast/media/mq-pointer.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Need implementation of layoutTestController.setBackingScaleFactor
jberlin@webkit.org [Thu, 31 May 2012 03:26:15 +0000 (03:26 +0000)]
[Win] Need implementation of layoutTestController.setBackingScaleFactor
https://bugs.webkit.org/show_bug.cgi?id=87919

Add tests that use setBackingScaleFactor to the Windows Skipped list.

* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd an helper function to get the style for a cell's flow computation
jchaffraix@webkit.org [Thu, 31 May 2012 03:15:06 +0000 (03:15 +0000)]
Add an helper function to get the style for a cell's flow computation
https://bugs.webkit.org/show_bug.cgi?id=87902

Reviewed by Ojan Vafai.

No expected change in behavior.

This change introduces styleForCellFlow that unify which function we use
to determine a cell's direction and writing mode.

This unification will make it easier to support direction on table row
group (section in WebKit land).

* rendering/RenderTableCell.h:
(WebCore::RenderTableCell::styleForCellFlow):
Added the new function along with a comment as to its purpose.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::clippedOverflowRectForRepaint):
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
(WebCore::RenderTableCell::borderHalfLeft):
(WebCore::RenderTableCell::borderHalfRight):
(WebCore::RenderTableCell::borderHalfTop):
(WebCore::RenderTableCell::borderHalfBottom):
(WebCore::RenderTableCell::borderHalfStart):
(WebCore::RenderTableCell::borderHalfEnd):
(WebCore::RenderTableCell::borderHalfBefore):
(WebCore::RenderTableCell::borderHalfAfter):
(WebCore::RenderTableCell::paintCollapsedBorders):
Mostly mechanical replacement.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::cachedCollapsedLeftBorder):
(WebCore::RenderTableCell::cachedCollapsedRightBorder):
(WebCore::RenderTableCell::cachedCollapsedTopBorder):
(WebCore::RenderTableCell::cachedCollapsedBottomBorder):
Made the argument 'const' now.

* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::layoutRows):
Added a FIXME to unify with the rest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agohttps://bugs.webkit.org/show_bug.cgi?id=87803
slewis@apple.com [Thu, 31 May 2012 03:05:34 +0000 (03:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=87803
Layout tests often fail trying to stat nonexistent logs

Reviewed by Dirk Pranke.

CrashReporter removes logs using a heuristic to conserve space.  Wrap a
try/catch block around accessing the logs as a precaution.

* Scripts/webkitpy/common/system/crashlogs.py:
(CrashLogs._find_newest_log_darwin):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoHeap should sweep incrementally
mhahnenberg@apple.com [Thu, 31 May 2012 03:04:00 +0000 (03:04 +0000)]
Heap should sweep incrementally
https://bugs.webkit.org/show_bug.cgi?id=85429

We shouldn't have to wait for the opportunistic GC timer to fire in order
to call object destructors. Instead, we should incrementally sweep some
subset of the blocks requiring sweeping periodically. We tie this sweeping
to a timer rather than to collections because we want to reclaim this memory
even if we stop allocating. This way, our memory usage scales smoothly with
actual use, regardless of whether we've recently done an opportunistic GC or not.

Reviewed by Geoffrey Garen.

* CMakeLists.txt:
* GNUmakefile.list.am:
* JavaScriptCore.gypi:
* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
* JavaScriptCore.xcodeproj/project.pbxproj:
* Target.pri:
* heap/Heap.cpp:
(JSC::Heap::Heap):
(JSC::Heap::collect): We no longer sweep during a full sweep. We only shrink now,
which we will switch over to being done during incremental sweeping too as soon as
all finalizers can be run lazily (and, by extension, incrementally).
(JSC::Heap::sweeper):
(JSC):
* heap/Heap.h:
(JSC):
(Heap):
* heap/IncrementalSweeper.cpp: Added.
(JSC):
(JSC::IncrementalSweeper::timerDidFire): The IncrementalSweeper works very similarly to
GCActivityCallback. It is tied to a run-loop based timer that fires periodically based
on how long the previous sweep increment took to run. The IncrementalSweeper doesn't do
anything if the platform doesn't support CoreFoundation.
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC::IncrementalSweeper::~IncrementalSweeper):
(JSC::IncrementalSweeper::create):
(JSC::IncrementalSweeper::scheduleTimer):
(JSC::IncrementalSweeper::cancelTimer):
(JSC::IncrementalSweeper::doSweep): Iterates over the snapshot of the MarkedSpace taken
during the last collection, checking to see which blocks need sweeping. If it successfully
gets to the end of the blocks that need sweeping then it cancels the timer.
(JSC::IncrementalSweeper::startSweeping): We take a snapshot of the Heap and store it in
a Vector that the incremental sweep will iterate over. We also reset our index into this Vector.
* heap/IncrementalSweeper.h: Added.
(JSC):
(IncrementalSweeper):
* heap/MarkedBlock.h:
(JSC::MarkedBlock::needsSweeping): If a block is in the Marked state it needs sweeping
to be usable and to run any destructors that need to be run.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be...
commit-queue@webkit.org [Thu, 31 May 2012 02:58:48 +0000 (02:58 +0000)]
[JSC] SerializedScriptValue.create() succeeds even if MessagePort object cannot be found in transferred ports
https://bugs.webkit.org/show_bug.cgi?id=87118

Patch by Christophe Dumez <christophe.dumez@intel.com> on 2012-05-30
Reviewed by Adam Barth.

Source/WebCore:

Make SerializedScriptValue.create() throw an exception if one of the
MessagePort objects cannot be found in the transferred ports. This
matches the behavior of the V8 implementation.

Test: webintents/web-intents-obj-constructor.html

* bindings/js/SerializedScriptValue.cpp:
(WebCore::CloneSerializer::dumpIfTerminal):

LayoutTests:

Unskip webintents/web-intents-obj-constructor.html now that
SerializedScriptValue.create() throws an exception if one of the
MessagePort objects cannot be found in the transferred ports.

* platform/efl/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Win] Need results for ietestcenter CSS3 tests
jberlin@webkit.org [Thu, 31 May 2012 02:53:48 +0000 (02:53 +0000)]
[Win] Need results for ietestcenter CSS3 tests
https://bugs.webkit.org/show_bug.cgi?id=87916

Add expected (failing?) results to get the bots greener.

* platform/win/ietestcenter/css3/flexbox/flexbox-align-baseline-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-baseline-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-center-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-center-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-center-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-center-002-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-end-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-end-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-start-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-start-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-align-stretch-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-direction-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-direction-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-002-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-003-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-004-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-004-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-005-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-flex-005-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-002-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-003-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-004-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-groups-004-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-002-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-layout-003-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-ordinal-group-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-center-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-center-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-end-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-end-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-justify-001-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-start-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/flexbox/flexbox-pack-start-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/display-grid-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/display-grid-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/display-grid-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/display-grid-002-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-002-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-column-003-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-columns-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-columns-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-001-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-002-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-003-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-004-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-004-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-005-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/grid/grid-items-005-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-block-formatting-context-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-block-formatting-context-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-002-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-containing-block-003-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-filling-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-filling-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-002-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-002-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-003-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-004-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-004-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-005-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-005-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-006-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-006-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-007-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-007-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-008-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-008-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-009-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-009-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-010-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-010-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-012-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-012-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-013-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-013-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-014-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-014-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-015-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-applies-to-015-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-negative-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-negative-001-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-percentage-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/multicolumn/column-width-percentage-001-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/declaring-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/declaring-001-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-007-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-007-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-008-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-008-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-009-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-009-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-010-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-010-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-011-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/prefix-011-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/qualifiedNames-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/qualifiedNames-001-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/scope-003-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/scope-003-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-016-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-016-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-017-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-017-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-018-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-018-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-019-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-019-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-020-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-020-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-021-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-021-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-022-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-022-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-023-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/syntax-023-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/terminology-001-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/namespaces/terminology-001-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-000-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-010-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-010-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-020-expected-expected.txt: Added.
* platform/win/ietestcenter/css3/valuesandunits/units-020-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Call fileUtilities methods directly
pilgrim@chromium.org [Thu, 31 May 2012 02:31:36 +0000 (02:31 +0000)]
[Chromium] Call fileUtilities methods directly
https://bugs.webkit.org/show_bug.cgi?id=87852

Reviewed by Adam Barth.

Part of a refactoring series. See tracking bug 82948.

Source/WebCore:

* platform/chromium/DragDataChromium.cpp:
(WebCore::DragData::asURL):
* platform/chromium/FileSystemChromium.cpp:
(WebCore::deleteFile):
(WebCore::deleteEmptyDirectory):
(WebCore::getFileSize):
(WebCore::getFileModificationTime):
(WebCore::getFileMetadata):
(WebCore::directoryName):
(WebCore::pathByAppendingComponent):
(WebCore::makeAllDirectories):
(WebCore::openFile):
(WebCore::closeFile):
(WebCore::seekFile):
(WebCore::truncateFile):
(WebCore::readFromFile):
(WebCore::writeToFile):
* platform/chromium/PlatformSupport.h:
(PlatformSupport):

Source/WebKit/chromium:

* src/PlatformSupport.cpp:
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoForm controls in <fieldset disabled> should not be focusable.
tkent@chromium.org [Thu, 31 May 2012 02:24:22 +0000 (02:24 +0000)]
Form controls in <fieldset disabled> should not be focusable.
https://bugs.webkit.org/show_bug.cgi?id=87380

Reviewed by Darin Adler.

Source/WebCore:

Test: fast/forms/fieldset/focus-in-fieldset-disabled.html

* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::supportsFocus):
Refer to disabled() instead of m_disabled to take account of wrapping
fieldset elements.

LayoutTests:

* fast/forms/fieldset/fieldset-disabled-expected.txt:
* fast/forms/fieldset/fieldset-disabled.html:
Updated because disabled controls are not focusable.
Also, remove testing elements to remove unnecessary blank lines.
* fast/forms/fieldset/focus-in-fieldset-disabled-expected.txt: Added.
* fast/forms/fieldset/focus-in-fieldset-disabled.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@119023 268f45cc-cd09-0410-ab3c-d52691b4dbfc