WebKit-https.git
14 years agoImplement live scrolling on Win32.
hyatt [Thu, 30 Mar 2006 10:55:35 +0000 (10:55 +0000)]
Implement live scrolling on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoAdd some ifdefed out paint flashing code for Win32 to the scroll view's updateContent...
hyatt [Thu, 30 Mar 2006 10:53:22 +0000 (10:53 +0000)]
Add some ifdefed out paint flashing code for Win32 to the scroll view's updateContents method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix win32 sprintf method on string to not infinite loop. r=eric
hyatt [Thu, 30 Mar 2006 10:11:21 +0000 (10:11 +0000)]
Fix win32 sprintf method on string to not infinite loop. r=eric

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoRoll out the change to 7102.
hyatt [Thu, 30 Mar 2006 10:02:11 +0000 (10:02 +0000)]
Roll out the change to 7102.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLand support for JPEG image decoding on Win32.
hyatt [Thu, 30 Mar 2006 09:23:59 +0000 (09:23 +0000)]
Land support for JPEG image decoding on Win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixed a bug number.
justing [Thu, 30 Mar 2006 06:45:28 +0000 (06:45 +0000)]
Fixed a bug number.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Thu, 30 Mar 2006 06:38:22 +0000 (06:38 +0000)]
LayoutTests:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
        REGRESSION: selectionRect includes next/previous replaced elements
        <rdar://problems/4402375&4474871&4474871>

        * editing/selection/4402375-expected.checksum: Added.
        * editing/selection/4402375-expected.png: Added.
        * editing/selection/4402375-expected.txt: Added.
        * editing/selection/4402375.html: Added.
        Turned on dumpSelectionRect for these tests:
        * editing/selection/replaced-boundaries-1-expected.checksum:
        * editing/selection/replaced-boundaries-1-expected.png:
        * editing/selection/replaced-boundaries-1.html:
        * editing/selection/replaced-boundaries-2-expected.checksum:
        * editing/selection/replaced-boundaries-2-expected.png:
        * editing/selection/replaced-boundaries-2.html:
        * editing/selection/replaced-boundaries-3-expected.checksum:
        * editing/selection/replaced-boundaries-3-expected.png:
        * editing/selection/replaced-boundaries-3.html:
        * editing/selection/image-before-linebreak-expected.checksum: Added.
        * editing/selection/image-before-linebreak-expected.png: Added.
        * editing/selection/image-before-linebreak-expected.txt: Added.
        * editing/selection/image-before-linebreak.html: Added.

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=8067>
        REGRESSION: selectionRect includes next/previous replaced elements
        Also fixes: <rdar://problems/4402375&4474871&4474871>

        In the case where a selection starts at the end or ends at the start
        of o, o->selectionState() != SelectionNone, but o isn't really selected.
        Constraining the selection with upstream and downstream eliminates these
        types of endpoints, but constraining endpoints that occur at the
        start or end of a paragraph creates positions inside containers - some
        of which the selection painting code isn't equipped to handle.

        * dom/Document.cpp:
        (WebCore::Document::updateSelection):
        * rendering/render_replaced.cpp:
        (WebCore::RenderReplaced::shouldPaint):
        (WebCore::RenderReplaced::selectionRect):
        (WebCore::RenderReplaced::setSelectionState):
        (WebCore::RenderWidget::setSelectionState):

WebKitTools:

        Reviewed by darin

        <rdar://problem/4402375>
        REGRESSION (417.8-TOT): selectionRect sometimes includes adjacent images

        Added an option to draw the selectionRect.

        * DumpRenderTree/DumpRenderTree.m:
        (dump):
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (-[LayoutTestController dumpSelectionRect]):
        (dumpRenderTree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Justin pointed out that this test should use an old-style form element,
adele [Thu, 30 Mar 2006 06:16:41 +0000 (06:16 +0000)]
    Justin pointed out that this test should use an old-style form element,
        so I changed the test to use <input type="password">.

        * fast/events/event-sender-mouse-click-expected.txt:
        * fast/events/event-sender-mouse-click.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
ggaren [Thu, 30 Mar 2006 02:39:24 +0000 (02:39 +0000)]
JavaScriptCore:

        Reviewed by Darin.

        - JavaScriptCore side of fix for <rdar://problem/4308243> 8F36
        Regression: crash in malloc_consolidate if you use a .PAC file

        The crash was a result of threaded deallocation of thread-unsafe
        objects. Pure JS objects are thread-safe because all JS execution
        is synchronized through JSLock. However, JS objects that wrap WebCore
        objects are thread-unsafe because JS and WebCore execution are not
        synchronized.  That unsafety comes into play when the collector
        deallocates a JS object that wraps a WebCore object, thus causing the
        WebCore object to be deallocated.

        The solution here is to have each JSCell know whether it is safe to
        collect on a non-main thread, and to avoid collecting unsafe cells
        when on a non-main thread.

        We don't have a way to test PAC files yet, so there's no test
        attached to this patch.

        * kjs/collector.cpp:
        (KJS::Collector::collect):
        (1) Added the test "currentThreadIsMainThread ||
        imp->m_destructorIsThreadSafe".

        * kjs/protect.h:
        (KJS::gcProtectNullTolerant):
        (KJS::gcUnprotectNullTolerant):
        * kjs/value.h:
        (KJS::JSCell::JSCell): The bools here must be bitfields, otherwise
        m_destructorIsThreadSafe becomes another whole word, ruining the
        collector optimizations we've made based on the size of a JSObject.
        * kxmlcore/FastMalloc.cpp:
        (KXMLCore::currentThreadIsMainThread):
        (KXMLCore::fastMallocRegisterThread):
        * kxmlcore/FastMalloc.h:

WebCore:

        Reviewed by Hyatt.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
        Switch to use new text field implementation for <input type="text">

        * css/html4.css: Added default style info for new text fields.
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla.
        (WebCore::RenderTextField::updateFromElement): Removed some outdated comments.  Cleaned up the way we add text nodes to the div.
        (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior.
        (WebCore::RenderTextField::setSelectionEnd): ditto.
        (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange.
        (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred.
        (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from
         the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border.
        (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css.
         We also add intrinsic margins here if the font size is large enough.
        * html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler):
         No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isKeyboardFocusable): ditto.
        (WebCore::HTMLInputElement::focus): ditto.
        (WebCore::HTMLInputElement::selectionStart): ditto.
        (WebCore::HTMLInputElement::selectionEnd): ditto.
        (WebCore::HTMLInputElement::setSelectionStart): ditto.
        (WebCore::HTMLInputElement::setSelectionEnd): ditto.
        (WebCore::HTMLInputElement::select): ditto.
        (WebCore::HTMLInputElement::setSelectionRange): ditto.
        (WebCore::HTMLInputElement::createRenderer): ditto.
        (WebCore::HTMLInputElement::defaultEventHandler): ditto.
        (WebCore::HTMLInputElement::isMouseFocusable): Added.  Old text fields relied on the widget to provide a focus policy.
         A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
        * html/HTMLInputElement.h: Added isMouseFocusable.
        * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable):
         Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
        * dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Thu, 30 Mar 2006 01:49:57 +0000 (01:49 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Updated tests for: http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
        Switch to use new text field implementation for <input type="text">

        The new text field implementation uses RenderTextFielda instead of RenderLineEdits,
        and this accounts for many of the changes here.

        Also, background color and border properties are now dumped as part of the RenderTextField.

        There is also an outstanding bug that affects many tests that make a selection in a text field.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8068
        Editing delegate should not be notified when selection change involved new text field

        Now that we support box-sizing, we count border and padding when calculating size, so some
        of the tests that specify border size have different text field sizes.

        * editing/selection/3690703-2-expected.checksum:
        * editing/selection/3690703-2-expected.png:
        * editing/selection/3690703-2-expected.txt:
        * editing/selection/3690703-expected.checksum:
        * editing/selection/3690703-expected.png:
        * editing/selection/3690703-expected.txt:
        * editing/selection/3690719-expected.checksum:
        * editing/selection/3690719-expected.png:
        * editing/selection/3690719-expected.txt:
        * fast/block/float/032-expected.checksum:
        * fast/block/float/032-expected.png:
        * fast/block/float/032-expected.txt:
        * fast/block/margin-collapse/103-expected.txt:
        * fast/events/div-focus-expected.txt:
        * fast/events/event-sender-mouse-click-expected.txt:
        * fast/forms/access-key-expected.txt:
        * fast/forms/element-by-name-expected.txt:
        * fast/forms/focus-expected.txt:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/indeterminate-expected.checksum:
        * fast/forms/indeterminate-expected.png:
        * fast/forms/input-appearance-bkcolor-expected.checksum:
        * fast/forms/input-appearance-bkcolor-expected.png:
        * fast/forms/input-appearance-bkcolor-expected.txt:
        * fast/forms/input-appearance-default-bkcolor-expected.checksum:
        * fast/forms/input-appearance-default-bkcolor-expected.png:
        * fast/forms/input-appearance-default-bkcolor-expected.txt:
        * fast/forms/input-appearance-disabled-expected.checksum:
        * fast/forms/input-appearance-disabled-expected.png:
        * fast/forms/input-appearance-disabled-expected.txt:
        * fast/forms/input-appearance-focus-expected.checksum:
        * fast/forms/input-appearance-focus-expected.png:
        * fast/forms/input-appearance-focus-expected.txt:
        * fast/forms/input-appearance-maxlength-expected.txt:
        * fast/forms/input-appearance-maxlength.html:
        * fast/forms/input-appearance-minWidth-expected.checksum:
        * fast/forms/input-appearance-minWidth-expected.png:
        * fast/forms/input-appearance-minWidth-expected.txt:
        * fast/forms/input-appearance-preventDefault-expected.checksum:
        * fast/forms/input-appearance-preventDefault-expected.png:
        * fast/forms/input-appearance-preventDefault-expected.txt:
        * fast/forms/input-appearance-selection-expected.checksum:
        * fast/forms/input-appearance-selection-expected.png:
        * fast/forms/input-appearance-selection-expected.txt:
        * fast/forms/input-appearance-visibility-expected.checksum:
        * fast/forms/input-appearance-visibility-expected.png:
        * fast/forms/input-appearance-visibility-expected.txt:
        * fast/forms/input-appearance-width-expected.checksum:
        * fast/forms/input-appearance-width-expected.png:
        * fast/forms/input-appearance-width-expected.txt:
        * fast/forms/input-baseline-expected.checksum:
        * fast/forms/input-baseline-expected.png:
        * fast/forms/input-baseline-expected.txt:
        * fast/forms/input-changing-value-expected.txt:
        * fast/forms/input-value-expected.txt:
        * fast/forms/input-width-expected.txt:
        * fast/forms/legend-access-key-expected.txt:
        * fast/forms/selection-functions-expected.txt:
        * fast/forms/textfield-focus-out-expected.txt:
        * fast/replaced/width100percent-expected.checksum:
        * fast/replaced/width100percent-expected.png:
        * fast/replaced/width100percent-expected.txt:
        * fast/table/003-expected.txt:
        * fast/table/colspanMinWidth-expected.txt:
        * fast/table/spanOverlapRepaint-expected.txt:
        * tables/mozilla/bugs/45621-expected.txt:
        * tables/mozilla/bugs/bug1188-expected.checksum:
        * tables/mozilla/bugs/bug1188-expected.png:
        * tables/mozilla/bugs/bug1188-expected.txt:
        * tables/mozilla/bugs/bug12384-expected.checksum:
        * tables/mozilla/bugs/bug12384-expected.png:
        * tables/mozilla/bugs/bug12384-expected.txt:
        * tables/mozilla/bugs/bug18359-expected.checksum:
        * tables/mozilla/bugs/bug18359-expected.png:
        * tables/mozilla/bugs/bug18359-expected.txt:
        * tables/mozilla/bugs/bug24200-expected.txt:
        * tables/mozilla/bugs/bug2479-3-expected.txt:
        * tables/mozilla/bugs/bug2479-4-expected.txt:
        * tables/mozilla/bugs/bug28928-expected.txt:
        * tables/mozilla/bugs/bug4382-expected.txt:
        * tables/mozilla/bugs/bug4527-expected.txt:
        * tables/mozilla/bugs/bug46368-1-expected.txt:
        * tables/mozilla/bugs/bug46368-2-expected.txt:
        * tables/mozilla/bugs/bug51037-expected.txt:
        * tables/mozilla/bugs/bug55545-expected.checksum:
        * tables/mozilla/bugs/bug55545-expected.png:
        * tables/mozilla/bugs/bug55545-expected.txt:
        * tables/mozilla/bugs/bug59354-expected.txt:
        * tables/mozilla/bugs/bug7342-expected.checksum:
        * tables/mozilla/bugs/bug7342-expected.png:
        * tables/mozilla/bugs/bug7342-expected.txt:
        * tables/mozilla/bugs/bug96334-expected.checksum:
        * tables/mozilla/bugs/bug96334-expected.png:
        * tables/mozilla/bugs/bug96334-expected.txt:
        * tables/mozilla/bugs/bug99948-expected.txt:
        * tables/mozilla/dom/tableDom-expected.txt:
        * tables/mozilla/other/move_row-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.png:
        * tables/mozilla_expected_failures/bugs/bug2479-2-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.png:
        * tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
        * tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

WebCore:

        Reviewed by Hyatt.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6986
        Switch to use new text field implementation for <input type="text">

        * css/html4.css: Added default style info for new text fields.
        * rendering/RenderTextField.cpp:
        (WebCore::RenderTextField::createDivStyle): Added an extra 1px of padding on the left & right to match Win IE & the latest Mozilla.
        (WebCore::RenderTextField::updateFromElement): Removed some outdated comments.  Cleaned up the way we add text nodes to the div.
        (WebCore::RenderTextField::setSelectionStart): Tweaked selection code to better match Mozilla behavior.
        (WebCore::RenderTextField::setSelectionEnd): ditto.
        (WebCore::RenderTextField::select): Cleaned this up by having it call setSelectionRange.
        (WebCore::RenderTextField::setSelectionRange): Calls updateLayout now in case this is called in an onload handler, and no other layout has occurred.
        (WebCore::RenderTextField::calcMinMaxWidth): Use floatWidth to calculate the width of the "0" character.
        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isControlStyled): If the text field's specified border is different from
         the default border, then treat the control as styled, so the engine knows to turn off the aqua appearance.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::paintTextField): return false so the engine knows not to try to draw the border.
        (WebCore::RenderThemeMac::adjustTextFieldStyle): text field style info has been moved to html4.css.
         We also add intrinsic margins here if the font size is large enough.
        * html/HTMLTextFieldInnerElement.cpp: (WebCore::HTMLTextFieldInnerElement::defaultEventHandler):
         No longer check for appearance. All text fields with m_type == TEXT will use the new implementation.
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::isKeyboardFocusable): ditto.
        (WebCore::HTMLInputElement::focus): ditto.
        (WebCore::HTMLInputElement::selectionStart): ditto.
        (WebCore::HTMLInputElement::selectionEnd): ditto.
        (WebCore::HTMLInputElement::setSelectionStart): ditto.
        (WebCore::HTMLInputElement::setSelectionEnd): ditto.
        (WebCore::HTMLInputElement::select): ditto.
        (WebCore::HTMLInputElement::setSelectionRange): ditto.
        (WebCore::HTMLInputElement::createRenderer): ditto.
        (WebCore::HTMLInputElement::defaultEventHandler): ditto.
        (WebCore::HTMLInputElement::isMouseFocusable): Added.  Old text fields relied on the widget to provide a focus policy.
         A text field that is focusable should be mouse focusable, and shouldn't need to ask the base class.
        * html/HTMLInputElement.h: Added isMouseFocusable.
        * html/HTMLGenericFormElement.cpp: (WebCore::HTMLGenericFormElement::isMouseFocusable):
         Removed specific text field code since that is now done in HTMLInputElement::isMouseFocusable.
        * dom/Document.cpp: (WebCore::Document::clearSelectionIfNeeded): Check that the new selection is does not have a shadowAncestorNode that is focused.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Wed, 29 Mar 2006 23:47:58 +0000 (23:47 +0000)]
LayoutTests:

        Reviewed by Eric.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=8026
          A particular animated SVG crashes in filter code
          <rdar://problem/4494775> A particular animated SVG crashes in filter code

        * svg/custom/empty-merge-expected.checksum: Added.
        * svg/custom/empty-merge-expected.png: Added.
        * svg/custom/empty-merge-expected.txt: Added.
        * svg/custom/empty-merge.svg: Added.

WebCore:

        Reviewed by Eric.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8026
          A particular animated SVG crashes in filter code
          <rdar://problem/4494775> A particular animated SVG crashes in filter code

        - fix some code that is not handling references correctly for GC

        Test: svg/custom/empty-merge.svg

        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        (WebCore::KCanvasFilterQuartz::KCanvasFilterQuartz): Use KWQRetainNSRelease to
        properly retain a reference to an Objective-C object in a C++ class.
        (WebCore::KCanvasFilterQuartz::~KCanvasFilterQuartz): Use KWQRelease instead of
        release.
        (WebCore::KCanvasFilterQuartz::prepareFilter): Use KWQRetain instead of retain.
        (WebCore::KCanvasFilterQuartz::applyFilter): Use KWQRelease instead of release.
        (WebCore::KCanvasFilterQuartz::imageForName): Use objectForKey: instead of
        valueForKey: on the dictionary to sidestep a bug in valueForKey: on empty strings
        and because what we're doing with a dictionary here has nothing to do with
        key value encoding.

        * kcanvas/device/quartz/KRenderingDeviceQuartz.mm:
        (WebCore::KRenderingDeviceContextQuartz::~KRenderingDeviceContextQuartz):
        Use KWQRelease instead of release.
        (WebCore::KRenderingDeviceContextQuartz::nsGraphicsContext): Use KWQRetain
        instead of retain to properly retain a reference to an Objective-C object
        in a C++ class.

        * platform/mac/ImageMac.mm:
        (WebCore::Image::invalidateNativeData): Use CFRelease instead of release.
        (WebCore::Image::getNSImage): Use KWQRetainNSRelease to properly retain
        a reference to an Objective-C object in a C++ class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13566 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
darin [Wed, 29 Mar 2006 23:42:16 +0000 (23:42 +0000)]
    Reviewed by Tim Hatcher.

        - make the global initializer check work on Xcode 2.1 (although it's better on 2.2)

        * Scripts/check-for-global-initializers: Use NATIVE_ARCH if there is no CURRENT_ARCH.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
tomernic [Wed, 29 Mar 2006 22:13:38 +0000 (22:13 +0000)]
    Reviewed by John Sullivan.

        <rdar://problem/4495316> REGRESSION (420+): After page has loaded, spinning progress indicator is displayed on
        tab at versiontracker.com

        * WebView/WebFrame.m:
        (-[WebFrame _receivedMainResourceError:]):
        Call -_clientRedirectCancelledOrFinished: here so that the frame load delegate is notified that the redirect's
        status has changed, if there was a redirect.  The frame load delegate may have saved some state about
        the redirect in its -webView:willPerformClientRedirectToURL:delay:fireDate:forFrame:.  Since we are definitely
        not going to use this provisional resource, as it was cancelled, notify the frame load delegate that the redirect
        has ended.
        The fix for 4432562 was similar to this, but only took care of the case where the redirect load was actually
        committed to the frame.  The new call to -_clientRedirectCancelledOrFinished: handles the case where the redirect
        load was successful, but was not committed.  This happens with downloads.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
ggaren [Wed, 29 Mar 2006 22:11:21 +0000 (22:11 +0000)]
LayoutTests:

        - Layout test for <rdar://problem/4477126> TOT REGRESSION: with
        release build, maps.google.com zoom slider always zooms fully out

        * fast/events/mouseclick-target-and-positioning-expected.txt: Added.
        * fast/events/mouseclick-target-and-positioning.html: Added.

WebCore:

        Reviewed by Darin.

        - Fixed <rdar://problem/4477126> TOT REGRESSION: with release
        build, maps.google.com zoom slider always zooms fully out

        There were 2 problems: (1) A syntax error in the UIEvent IDL file
        prevented some things from showing up in the bindings; (2)
        MouseEvent had a duplicate isSimulated property that shadowed
        MouseRelatedEvent's isSimulated property, and MouseEvent failed to
        initialize MouseRelatedEvent's isSimulated property.

        * dom/UIEvent.idl:
        * dom/dom2_eventsimpl.cpp:
        (WebCore::MouseRelatedEvent::MouseRelatedEvent):
        (WebCore::MouseEvent::MouseEvent):
        * dom/dom2_eventsimpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
tomernic [Wed, 29 Mar 2006 21:42:36 +0000 (21:42 +0000)]
    Reviewed by Darin.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setInputType):
        If the input type is dynamically changed, reevaluate whether the element maintains its state
        (this decision is based on the input's type).  Fixes an assertion error when leaving a page
        with a text field that had been dynamically changed to a password field.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Omernick.
sullivan [Wed, 29 Mar 2006 21:41:11 +0000 (21:41 +0000)]
    Reviewed by Tim Omernick.

        - fixed these bugs:
        <rdar://problem/4483806> REGRESSION (417.8-TOT): PDFs don't scale correctly with auto-size (5356)
        <rdar://problem/3874856> Safari PDF display should be full width by default rather than
        sized to show the entire page

        * WebView/WebPDFRepresentation.m:
        (-[WebPDFRepresentation finishedLoadingWithDataSource:]):
        Let the WebPDFView handle setting the document, because that's the best time to apply
        the sizing-related preferences.

        * WebView/WebPDFView.h:
        eliminated firstLayoutDone ivar and -PDFSubview public method; added -setPDFDocument:

        * WebView/WebPDFView.m:
        (-[WebPDFView initWithFrame:]):
        eliminate use of obsolete firstLayoutDone ivar
        (-[WebPDFView _applyPDFDefaults]):
        renamed from _readPDFDefaults for clarity
        (-[WebPDFView layout]):
        removed code that applied the preferences here. This was too early to handle auto-sizing correctly,
        because -layout can be called before the document exists, and calling setAutoSize:YES at that
        point confuses PDFView into setting the scale factor to 20 (the maximum).
        (-[WebPDFView setPDFDocument:]):
        New method, does what WebPDFRepresentation used to do and also applies the preferences here.
        This is a good place to apply them because the document is guaranteed to now exist (of course).
        (-[WebPDFView PDFSubview]):
        Moved this into a new FileInternal category because it's still needed by another class in
        this file but no longer needs to be public.

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):
        Change WebKitPDFScaleFactorPreferenceKey to 0, which represents auto-size. This fixes 3874856,
        but wasn't feasible until 4483806 was fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Wed, 29 Mar 2006 17:37:43 +0000 (17:37 +0000)]
    Reviewed by Darin.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=8055
          Fix most CSS grammar conflicts.

        Gets the number of shift/reduce and reduce/reduce conflicts down from 37+4 to 7+0.

        I have fixed the reduce/reduce conflicts, then noticed that two of the fixes
        were already made in KDE tree (the other two are different because declaration
        blocks are described in quite different ways). Shift/reduce fixes are just
        merged from KDE, r332845 by Michael Matz.

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
ap [Wed, 29 Mar 2006 15:57:20 +0000 (15:57 +0000)]
    Reviewed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7157
          An asterisk in a CSS property name breaks CSS handling
          (Many layout problems at letras.terra.com.br)

        Test: fast/css/error-in-last-decl.html

        * css/CSSGrammar.y: Added a rule for the case when the last CSS rule
          has a syntax error, and doesn't end with a semicolon.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-29 Darin Adler <darin@apple.com>
darin [Wed, 29 Mar 2006 15:09:35 +0000 (15:09 +0000)]
2006-03-29  Darin Adler  <darin@apple.com>

        Reviewed by Anders.

        - another cut at fixing the buildbot

        * generate-derived-sources: Fix if statement that was always following
        the Windows case. I believe this is the main problem.

        * WebCore.xcodeproj/project.pbxproj: Added CharsetData.h and added CharsetData.cpp
        to the target.
        * WebCore.vcproj/WebCore/WebCore.vcproj: Similar changes.

        * platform/CharsetData.h: Added.
        * platform/CharsetNames.cpp: Moved the actual character set data out into a
        separate source file instead of include a .cpp file.

        * platform/make-charset-table.pl: Changed to generate a file that can stand alone.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-29 Darin Adler <darin@apple.com>
darin [Wed, 29 Mar 2006 14:29:22 +0000 (14:29 +0000)]
2006-03-29  Darin Adler  <darin@apple.com>

        - an attempt to fix the buildbot

        * platform/mac/mac-encodings.txt: Touched this file so the character encodings
        files will be regenerated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-29 Darin Adler <darin@apple.com>
darin [Wed, 29 Mar 2006 11:22:39 +0000 (11:22 +0000)]
2006-03-29  Darin Adler  <darin@apple.com>

        - a quick cut at fixing the windows build

        * WebCore.vcproj/WebCore/WebCore.vcproj: Added a few recently-added files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
mjs [Wed, 29 Mar 2006 09:38:54 +0000 (09:38 +0000)]
LayoutTests:

        Reviewed by Anders.

        Test cases for Element.contains, including testing fix for
        <rdar://problem/4405353> JavaScript flickers popups onmouseover

        * fast/dom/Element/contains-method-expected.txt: Added.
        * fast/dom/Element/contains-method.html: Added.
        * fast/dom/Element/resources/contains-method.js: Added.
        * fast/events/capture-on-target.html:

WebCore:

        Reviewed by Anders.

        - fixed  <rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating

        Also fixed other issues with contains. The problem that caused the bug was:
        - contains should return true for the element itself, unlike isAncestor

        Other problems I fixed:
        - contains shouldn't be present on non-Element nodes
        - contains should return false when passed a non-Element node
        - contains should return false when passed a non-Node

        * bindings/scripts/CodeGeneratorJS.pm: Handle Element as a parameter.
        * dom/Element.cpp:
        (WebCore::Element::contains): Added new implementation.
        * dom/Element.h: Added prototype for contains.
        * dom/Element.idl: Added IDL declaration for contains.
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNodeProtoFunc::callAsFunction): Added old wrong contains().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFixing typo from last commit.
bdakin [Wed, 29 Mar 2006 05:11:38 +0000 (05:11 +0000)]
Fixing typo from last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej
bdakin [Wed, 29 Mar 2006 05:07:51 +0000 (05:07 +0000)]
    Reviewed by Maciej

        Fix for <rdar://problem/4493218> repro crash in
        khtml::RenderBlock::repaintFloatingDescendants with giant
        cellspacing value

        Some callers of CSSPrimitiveValue::computeLength() expect an int,
        and others a short. This patch splits computerLength() into
        computeIntLength() and computeShortLength() so that the appropriate
        bounds can be checked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
ap [Wed, 29 Mar 2006 04:23:18 +0000 (04:23 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=4616
          Setting nodeValue on a textnode with collapsed whitespace only has no visual effect

        Test: fast/dom/space-to-text.html

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData): Create a renderer if it's needed, but missing.
        (WebCore::CharacterData::appendData): Ditto.
        (WebCore::CharacterData::insertData): Ditto.
        (WebCore::CharacterData::replaceData): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
tomernic [Wed, 29 Mar 2006 03:02:18 +0000 (03:02 +0000)]
    Reviewed by Maciej.

        <rdar://problem/4454976> repro crash in -[NSTextView(NSSharing) setSelectedRanges:affinity:stillSelecting:] when navigating
        to another page while selecting inside textarea inside iframe

        * kwq/WebCoreTextArea.mm:
        (-[WebCoreTextArea mouseDown:]):
        Guard super's -mouseDown: with calls to Widget::beforeMouseDown() and Widget::afterMouseDown().
        Other widgets do this to protect against being removed from the page and deallocated while handling
        mouse down events.
        (-[WebCoreTextView mouseDown:]):
        ditto

        * manual-tests/textarea-iframe-navigation.html: Added.
        * manual-tests/textarea-iframe-navigation2.html: Added.
        Manual test case for this fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-28 Eric Seidel <eseidel@apple.com>
eseidel [Wed, 29 Mar 2006 02:48:48 +0000 (02:48 +0000)]
2006-03-28  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        <rdar://problem/4402170> CrashTracer: 499 crashes in Safari at com.apple.WebCore: DOM::DocumentImpl::open + 16

        * dom/Document.cpp:
        (WebCore::Document::write): Fix unreproducible infinite recursion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-28 Eric Seidel <eseidel@apple.com>
eseidel [Wed, 29 Mar 2006 02:46:20 +0000 (02:46 +0000)]
2006-03-28  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Remove global initializers.

        * kcanvas/device/quartz/KCanvasFilterQuartz.mm:
        * ksvg2/svg/SVGAngle.cpp:
        * ksvg2/svg/SVGColor.cpp:
        * ksvg2/svg/SVGLength.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-28 Eric Seidel <eseidel@apple.com>
eseidel [Wed, 29 Mar 2006 02:35:51 +0000 (02:35 +0000)]
2006-03-28  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Switch UIEvent, MouseEvent and KeyboardEvent over to
        be new auto-generated bindings.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7928

        Updated test: fast/dom/prototype-chain.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMEvents.mm:
        (-[DOMEvent ::]):
        (-[DOMMouseEvent initMouseEvent:::::::::::::::]):
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchMouseEvent):
        * dom/KeyboardEvent.idl: Added.
        * dom/MouseEvent.idl: Added.
        * dom/UIEvent.idl: Added.
        * dom/WheelEvent.idl:
        * dom/dom2_eventsimpl.cpp:
        (WebCore::MouseEvent::MouseEvent):
        (WebCore::MouseEvent::initMouseEvent):
        * dom/dom2_eventsimpl.h:
        (WebCore::MouseEvent::relatedTarget):
        (WebCore::MouseEvent::clipboard):
        * generate-derived-sources:
        * khtml/ecma/kjs_dom.cpp:
        (KJS::toEventTargetNode):
        * khtml/ecma/kjs_dom.h:
        * khtml/ecma/kjs_events.cpp:
        (KJS::toJS):
        * khtml/ecma/kjs_events.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Wed, 29 Mar 2006 02:23:47 +0000 (02:23 +0000)]
    Reviewed by Eric.

        - replace getDocument with document in a few places that Geoff missed

        * WebCore.xcodeproj/project.pbxproj:
        * dom/Attr.cpp:
        (WebCore::Attr::createTextChild):
        (WebCore::Attr::setValue):
        (WebCore::Attr::cloneNode):
        * dom/Attribute.cpp:
        (WebCore::Attribute::createAttrIfNeeded):
        * dom/Element.cpp:
        (WebCore::Element::cloneNode):
        (WebCore::inHTMLDocument):
        (WebCore::Element::setAttribute):
        (WebCore::Element::setAttributeMap):
        (WebCore::Element::createStyleForRenderer):
        (WebCore::Element::createRenderer):
        (WebCore::Element::recalcStyle):
        (WebCore::Element::dispatchAttrRemovalEvent):
        (WebCore::Element::dispatchAttrAdditionEvent):
        (WebCore::Element::updateId):
        (WebCore::Element::removeAttributeNode):
        (WebCore::Element::focus):
        (WebCore::Element::blur):
        * dom/NamedAttrMap.cpp:
        (WebCore::inHTMLDocument):
        (WebCore::NamedAttrMap::setNamedItem):
        * dom/NamedMappedAttrMap.cpp:
        (WebCore::NamedMappedAttrMap::parseClassAttribute):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::createInlineStyleDecl):
        (WebCore::StyledElement::parseMappedAttribute):
        (WebCore::StyledElement::createMappedDecl):

        - added missing include that seems to be breaking the Windows build

        * platform/String.cpp: Include <stdarg.h>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-25 Eric Seidel <eseidel@apple.com>
eseidel [Wed, 29 Mar 2006 02:10:38 +0000 (02:10 +0000)]
2006-03-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by adele.

        Make plug-ins test dump as test.

        * fast/dom/Window/Plug-ins-expected.txt:
        * fast/dom/Window/Plug-ins.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
thatcher [Wed, 29 Mar 2006 02:01:26 +0000 (02:01 +0000)]
    Reviewed by Darin.

        Exit gracefully if $ENV{'CURRENT_ARCH'} is undefined. Rolling out my previous change.

        * Scripts/check-for-global-initializers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix. Turn off uninitialized warnings for the first block of code.
thatcher [Wed, 29 Mar 2006 01:50:54 +0000 (01:50 +0000)]
    Build fix. Turn off uninitialized warnings for the first block of code.

        * Scripts/check-for-global-initializers:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Beth.
ggaren [Wed, 29 Mar 2006 00:21:31 +0000 (00:21 +0000)]
    Reviewed by Beth.

        - Global replace of getDocument() with document(). Darin suggested this
        in his review of my EventTargetNode patch. It matches the style of
        methods like ownerDocument().

        - Changed getDocument() to document(); changed data member document to
        m_document; changed stack variable document to doc.

        * bindings/objc/DOM.mm:
        (-[DOMNode ownerDocument]):
        (-[DOMNode KJS::Bindings::]):
        (-[DOMElement _getURLAttribute:]):
        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLElement titleDisplayString]):
        (-[DOMHTMLInputElement altDisplayString]):
        (-[DOMHTMLAnchorElement blur]):
        (-[DOMHTMLAnchorElement focus]):
        (-[DOMHTMLImageElement altDisplayString]):
        (-[DOMHTMLAppletElement altDisplayString]):
        (-[DOMHTMLAreaElement altDisplayString]):
        * bindings/objc/DOMInternal.mm:
        (-[WebScriptObject _initializeScriptDOMNodeImp]):
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::attributedString):
        * bridge/mac/FrameViewMac.mm:
        (WebCore::FrameView::updateDashboardRegions):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge initSubframeWithRenderer:]):
        (-[WebCoreFrameBridge setSelectedDOMRange:affinity:closeTyping:]):
        (-[WebCoreFrameBridge smartDeleteRangeForProposedRange:]):
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/css_base.cpp:
        (WebCore::StyleBase::baseURL):
        * css/css_stylesheetimpl.cpp:
        (WebCore::CSSStyleSheet::CSSStyleSheet):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::initForStyleResolve):
        (WebCore::CSSStyleSelector::canShareStyleWithElement):
        (WebCore::CSSStyleSelector::locateSharedStyle):
        (WebCore::CSSStyleSelector::createStyleForElement):
        (WebCore::CSSStyleSelector::createPseudoStyleForElement):
        (WebCore::CSSStyleSelector::adjustRenderStyle):
        (WebCore::CSSStyleSelector::styleRulesForElement):
        (WebCore::CSSStyleSelector::checkOneSelector):
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::mapBackgroundImage):
        (WebCore::CSSStyleSelector::getColorFromPrimitiveValue):
        * dom/AbstractView.cpp:
        (WebCore::AbstractView::AbstractView):
        * dom/CDATASection.cpp:
        (WebCore::CDATASection::cloneNode):
        (WebCore::CDATASection::createNew):
        * dom/CharacterData.cpp:
        (WebCore::CharacterData::setData):
        (WebCore::CharacterData::insertData):
        (WebCore::CharacterData::deleteData):
        (WebCore::CharacterData::replaceData):
        (WebCore::CharacterData::dispatchModifiedEvent):
        * dom/Comment.cpp:
        (WebCore::Comment::cloneNode):
        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertBefore):
        (WebCore::ContainerNode::replaceChild):
        (WebCore::ContainerNode::removeChild):
        (WebCore::ContainerNode::appendChild):
        (WebCore::ContainerNode::addChild):
        (WebCore::ContainerNode::getUpperLeftCorner):
        (WebCore::dispatchChildInsertionEvents):
        (WebCore::dispatchChildRemovalEvents):
        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::~Document):
        (WebCore::Document::createDocumentFragment):
        (WebCore::Document::adoptNode):
        (WebCore::Document::createElementNS):
        (WebCore::Document::nodeAbsIndex):
        (WebCore::Document::setFocusNode):
        (WebCore::Document::topDocument):
        * dom/DocumentFragment.cpp:
        (WebCore::DocumentFragment::cloneNode):
        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::~EventTargetNode):
        (WebCore::EventTargetNode::insertedIntoDocument):
        (WebCore::EventTargetNode::removedFromDocument):
        (WebCore::EventTargetNode::addEventListener):
        (WebCore::EventTargetNode::removeEventListener):
        (WebCore::EventTargetNode::dispatchGenericEvent):
        (WebCore::EventTargetNode::dispatchEvent):
        (WebCore::EventTargetNode::dispatchSubtreeModifiedEvent):
        (WebCore::EventTargetNode::dispatchWindowEvent):
        (WebCore::EventTargetNode::dispatchUIEvent):
        (WebCore::EventTargetNode::dispatchKeyEvent):
        (WebCore::EventTargetNode::dispatchMouseEvent):
        (WebCore::EventTargetNode::dispatchWheelEvent):
        (WebCore::EventTargetNode::removeHTMLEventListener):
        * dom/Node.cpp:
        (WebCore::Node::Node):
        (WebCore::Node::setDocument):
        (WebCore::Node::setChanged):
        (WebCore::Node::checkSetPrefix):
        (WebCore::Node::checkAddChild):
        (WebCore::Node::attach):
        (WebCore::Node::detach):
        (WebCore::Node::createRendererIfNeeded):
        (WebCore::Node::rendererIsNeeded):
        (WebCore::Node::getElementsByTagNameNS):
        (WebCore::Node::ownerDocument):
        (WebCore::Node::setTextContent):
        * dom/Node.h:
        (WebCore::Node::document):
        (WebCore::Node::inDocument):
        * dom/NodeList.cpp:
        (WebCore::NodeList::itemById):
        * dom/Position.cpp:
        (WebCore::Position::documentElement):
        * dom/Range.cpp:
        (WebCore::Range::commonAncestorContainer):
        (WebCore::Range::setStart):
        (WebCore::Range::setEnd):
        (WebCore::Range::compareBoundaryPoints):
        (WebCore::Range::insertNode):
        (WebCore::Range::text):
        (WebCore::Range::setStartAfter):
        (WebCore::Range::setEndBefore):
        (WebCore::Range::setEndAfter):
        (WebCore::Range::surroundContents):
        (WebCore::Range::setStartBefore):
        (WebCore::rangeOfContents):
        * dom/Text.cpp:
        (WebCore::Text::cloneNode):
        (WebCore::Text::createNew):
        * dom/dom2_eventsimpl.cpp:
        (WebCore::MouseRelatedEvent::receivedTarget):
        * dom/dom2_traversalimpl.cpp:
        (WebCore::NodeIterator::NodeIterator):
        * dom/dom_elementimpl.cpp:
        (WebCore::Attribute::createAttrIfNeeded):
        (WebCore::Attr::createTextChild):
        (WebCore::Attr::setValue):
        (WebCore::Attr::cloneNode):
        (WebCore::Element::cloneNode):
        (WebCore::inHTMLDocument):
        (WebCore::Element::setAttribute):
        (WebCore::Element::setAttributeMap):
        (WebCore::Element::createStyleForRenderer):
        (WebCore::Element::createRenderer):
        (WebCore::Element::recalcStyle):
        (WebCore::Element::dispatchAttrRemovalEvent):
        (WebCore::Element::dispatchAttrAdditionEvent):
        (WebCore::Element::updateId):
        (WebCore::Element::removeAttributeNode):
        (WebCore::Element::focus):
        (WebCore::Element::blur):
        (WebCore::NamedAttrMap::setNamedItem):
        (WebCore::NamedMappedAttrMap::parseClassAttribute):
        (WebCore::StyledElement::createInlineStyleDecl):
        (WebCore::StyledElement::parseMappedAttribute):
        (WebCore::StyledElement::createMappedDecl):
        * dom/dom_xmlimpl.cpp:
        (WebCore::EntityReference::cloneNode):
        (WebCore::ProcessingInstruction::cloneNode):
        (WebCore::ProcessingInstruction::checkStyleSheet):
        (WebCore::ProcessingInstruction::sheetLoaded):
        (WebCore::ProcessingInstruction::setStyleSheet):
        * dom/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::XMLTokenizer):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        (WebCore::ReplaceSelectionCommand::fixupNodeStyles):
        (WebCore::styleForNode):
        * editing/Selection.cpp:
        (WebCore::Selection::toRange):
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::~SelectionController):
        (WebCore::SelectionController::setSelection):
        (WebCore::SelectionController::xPosForVerticalArrowNavigation):
        (WebCore::SelectionController::frame):
        (WebCore::SelectionController::layout):
        (WebCore::SelectionController::needsCaretRepaint):
        * editing/TextIterator.cpp:
        (WebCore::TextIterator::range):
        (WebCore::SimplifiedBackwardsTextIterator::range):
        * editing/VisiblePosition.cpp:
        (WebCore::VisiblePosition::init):
        (WebCore::makeRange):
        * editing/markup.cpp:
        (WebCore::startMarkup):
        (WebCore::shouldSelfClose):
        (WebCore::markup):
        (WebCore::createMarkup):
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):
        (WebCore::nextBoundary):
        (WebCore::previousLinePosition):
        (WebCore::nextLinePosition):
        (WebCore::inSameDocument):
        * html/HTMLCollection.cpp:
        (WebCore::HTMLCollection::HTMLCollection):
        (WebCore::HTMLCollection::resetCollectionInfo):
        * html/HTMLElement.cpp:
        (WebCore::HTMLElement::nodeName):
        (WebCore::HTMLElement::cloneNode):
        (WebCore::HTMLElement::innerText):
        (WebCore::HTMLElement::createContextualFragment):
        (WebCore::HTMLElement::setInnerText):
        (WebCore::HTMLElement::setOuterText):
        (WebCore::HTMLElement::isContentEditable):
        (WebCore::HTMLElement::contentEditable):
        (WebCore::HTMLElement::toString):
        (WebCore::HTMLElement::childAllowed):
        (WebCore::HTMLElement::setHTMLEventListener):
        * html/HTMLFormElement.cpp:
        (WebCore::HTMLFormElement::formWouldHaveSecureSubmission):
        (WebCore::HTMLFormElement::attach):
        (WebCore::HTMLFormElement::insertedIntoDocument):
        (WebCore::HTMLFormElement::removedFromDocument):
        (WebCore::HTMLFormElement::formData):
        (WebCore::HTMLFormElement::prepareSubmit):
        (WebCore::HTMLFormElement::submit):
        (WebCore::HTMLFormElement::reset):
        (WebCore::HTMLFormElement::parseMappedAttribute):
        (WebCore::HTMLFormElement::registerFormElement):
        (WebCore::HTMLFormElement::removeFormElement):
        * html/HTMLGenericFormElement.cpp:
        (WebCore::HTMLGenericFormElement::attach):
        (WebCore::HTMLGenericFormElement::insertedIntoTree):
        (WebCore::HTMLGenericFormElement::isKeyboardFocusable):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::~HTMLInputElement):
        (WebCore::HTMLInputElement::isKeyboardFocusable):
        (WebCore::HTMLInputElement::focus):
        (WebCore::HTMLInputElement::setInputType):
        (WebCore::HTMLInputElement::parseMappedAttribute):
        (WebCore::HTMLInputElement::attach):
        (WebCore::HTMLInputElement::setChecked):
        (WebCore::HTMLInputElement::preDispatchEventHandler):
        (WebCore::HTMLInputElement::defaultEventHandler):
        (WebCore::HTMLInputElement::src):
        * html/HTMLKeygenElement.cpp:
        (WebCore::HTMLKeygenElement::appendFormData):
        * html/HTMLLabelElement.cpp:
        (WebCore::HTMLLabelElement::formElement):
        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::text):
        (WebCore::HTMLOptionElement::setText):
        * html/HTMLParser.cpp:
        (WebCore::HTMLParser::HTMLParser):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::~HTMLSelectElement):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::~HTMLTextAreaElement):
        (WebCore::HTMLTextAreaElement::setDefaultValue):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::HTMLTokenizer):
        * html/html_baseimpl.cpp:
        (WebCore::HTMLBodyElement::createLinkDecl):
        (WebCore::HTMLBodyElement::mapToEntry):
        (WebCore::HTMLBodyElement::parseMappedAttribute):
        (WebCore::HTMLBodyElement::insertedIntoDocument):
        (WebCore::HTMLFrameElement::isURLAllowed):
        (WebCore::HTMLFrameElement::openURL):
        (WebCore::HTMLFrameElement::attach):
        (WebCore::HTMLFrameElement::close):
        (WebCore::HTMLFrameElement::contentFrame):
        (WebCore::HTMLFrameElement::frameWidth):
        (WebCore::HTMLFrameElement::frameHeight):
        (WebCore::HTMLFrameSetElement::parseMappedAttribute):
        (WebCore::HTMLIFrameElement::parseMappedAttribute):
        (WebCore::HTMLIFrameElement::insertedIntoDocument):
        (WebCore::HTMLIFrameElement::removedFromDocument):
        (WebCore::HTMLIFrameElement::attach):
        (WebCore::HTMLIFrameElement::src):
        * html/html_blockimpl.cpp:
        (WebCore::HTMLParagraphElement::checkDTD):
        * html/html_headimpl.cpp:
        (WebCore::HTMLBaseElement::removedFromDocument):
        (WebCore::HTMLBaseElement::process):
        (WebCore::HTMLLinkElement::setDisabledState):
        (WebCore::HTMLLinkElement::parseMappedAttribute):
        (WebCore::HTMLLinkElement::process):
        (WebCore::HTMLLinkElement::setStyleSheet):
        (WebCore::HTMLLinkElement::sheetLoaded):
        (WebCore::HTMLLinkElement::href):
        (WebCore::HTMLMetaElement::process):
        (WebCore::HTMLScriptElement::childrenChanged):
        (WebCore::HTMLScriptElement::parseMappedAttribute):
        (WebCore::HTMLScriptElement::insertedIntoDocument):
        (WebCore::HTMLScriptElement::evaluateScript):
        (WebCore::HTMLScriptElement::setText):
        (WebCore::HTMLScriptElement::src):
        (WebCore::HTMLStyleElement::insertedIntoDocument):
        (WebCore::HTMLStyleElement::removedFromDocument):
        (WebCore::HTMLStyleElement::childrenChanged):
        (WebCore::HTMLStyleElement::sheetLoaded):
        (WebCore::HTMLTitleElement::insertedIntoDocument):
        (WebCore::HTMLTitleElement::removedFromDocument):
        (WebCore::HTMLTitleElement::childrenChanged):
        (WebCore::HTMLTitleElement::setText):
        * html/html_imageimpl.cpp:
        (WebCore::HTMLImageLoader::~HTMLImageLoader):
        (WebCore::HTMLImageLoader::updateFromElement):
        (WebCore::HTMLImageLoader::notifyFinished):
        (WebCore::HTMLImageElement::parseMappedAttribute):
        (WebCore::HTMLImageElement::insertedIntoDocument):
        (WebCore::HTMLImageElement::removedFromDocument):
        (WebCore::HTMLImageElement::width):
        (WebCore::HTMLImageElement::height):
        (WebCore::HTMLImageElement::src):
        (WebCore::HTMLMapElement::~HTMLMapElement):
        (WebCore::HTMLMapElement::parseMappedAttribute):
        (WebCore::HTMLAreaElement::href):
        * html/html_inlineimpl.cpp:
        (WebCore::HTMLAnchorElement::isKeyboardFocusable):
        (WebCore::HTMLAnchorElement::defaultEventHandler):
        (WebCore::HTMLAnchorElement::href):
        (WebCore::HTMLAnchorElement::blur):
        (WebCore::HTMLAnchorElement::focus):
        * html/html_objectimpl.cpp:
        (WebCore::HTMLAppletElement::parseMappedAttribute):
        (WebCore::HTMLAppletElement::insertedIntoDocument):
        (WebCore::HTMLAppletElement::removedFromDocument):
        (WebCore::HTMLAppletElement::createRenderer):
        (WebCore::HTMLAppletElement::getAppletInstance):
        (WebCore::HTMLEmbedElement::getEmbedInstance):
        (WebCore::HTMLEmbedElement::parseMappedAttribute):
        (WebCore::HTMLEmbedElement::rendererIsNeeded):
        (WebCore::HTMLEmbedElement::insertedIntoDocument):
        (WebCore::HTMLEmbedElement::removedFromDocument):
        (WebCore::HTMLObjectElement::getObjectInstance):
        (WebCore::HTMLObjectElement::parseMappedAttribute):
        (WebCore::HTMLObjectElement::rendererIsNeeded):
        (WebCore::HTMLObjectElement::insertedIntoDocument):
        (WebCore::HTMLObjectElement::removedFromDocument):
        (WebCore::HTMLObjectElement::updateDocNamedItem):
        (WebCore::HTMLParamElement::parseMappedAttribute):
        * html/html_tableimpl.cpp:
        (WebCore::HTMLTableElement::createTHead):
        (WebCore::HTMLTableElement::createTFoot):
        (WebCore::HTMLTableElement::createCaption):
        (WebCore::HTMLTableElement::insertRow):
        (WebCore::HTMLTableElement::addChild):
        (WebCore::HTMLTableElement::mapToEntry):
        (WebCore::HTMLTableElement::parseMappedAttribute):
        (WebCore::HTMLTableElement::additionalAttributeStyleDecl):
        (WebCore::HTMLTableElement::getSharedCellDecl):
        (WebCore::HTMLTablePartElement::mapToEntry):
        (WebCore::HTMLTablePartElement::parseMappedAttribute):
        (WebCore::HTMLTableSectionElement::insertRow):
        (WebCore::HTMLTableRowElement::insertCell):
        * khtml/ecma/kjs_dom.cpp:
        (KJS::DOMNode::~DOMNode):
        (KJS::DOMNode::mark):
        (KJS::DOMElement::getValueProperty):
        (KJS::DOMElementProtoFunc::callAsFunction):
        (KJS::checkNodeSecurity):
        (KJS::toJS):
        * khtml/ecma/kjs_html.cpp:
        (KJS::JSHTMLElement::implementsCall):
        (KJS::JSHTMLElement::bodyGetter):
        (KJS::JSHTMLElement::anchorGetter):
        (KJS::JSHTMLElement::getValueProperty):
        (KJS::JSHTMLElement::bodySetter):
        * khtml/ecma/kjs_traversal.cpp:
        (KJS::JSNodeFilterCondition::acceptNode):
        * khtml/ecma/kjs_views.cpp:
        (KJS::DOMAbstractViewProtoFunc::callAsFunction):
        * khtml/xbl/xbl_binding.cpp:
        (XBL::XBLBindingChain::failed):
        (XBL::m_nextBinding):
        (XBL::XBLBinding::setXBLDocument):
        * khtml/xbl/xbl_protobinding.cpp:
        (XBL::XBLPrototypeBinding::document):
        * khtml/xsl/XSLStyleSheet.cpp:
        (WebCore::XSLStyleSheet::XSLStyleSheet):
        * khtml/xsl/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource):
        (WebCore::xmlDocPtrFromNode):
        (WebCore::XSLTProcessor::transformToString):
        * ksvg2/svg/SVGAElement.cpp:
        (SVGAElement::defaultEventHandler):
        * ksvg2/svg/SVGAnimateColorElement.cpp:
        (SVGAnimateColorElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimateElement.cpp:
        (SVGAnimateElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        (SVGAnimateTransformElement::handleTimerEvent):
        * ksvg2/svg/SVGAnimationElement.cpp:
        (SVGAnimationElement::closeRenderer):
        * ksvg2/svg/SVGClipPathElement.cpp:
        (SVGClipPathElement::canvasResource):
        * ksvg2/svg/SVGElement.cpp:
        (WebCore::SVGElement::addSVGEventListener):
        * ksvg2/svg/SVGGradientElement.cpp:
        (SVGGradientElement::rebuildStops):
        * ksvg2/svg/SVGHelper.cpp:
        (SVGHelper::PercentageOfViewport):
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        (SVGLinearGradientElement::buildGradient):
        * ksvg2/svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::fillAttributesFromReferencePattern):
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::buildGradient):
        * ksvg2/svg/SVGSVGElement.cpp:
        (WebCore::SVGSVGElement::setCurrentScale):
        (WebCore::SVGSVGElement::addSVGWindowEventListner):
        * ksvg2/svg/SVGSetElement.cpp:
        (SVGSetElement::handleTimerEvent):
        * ksvg2/svg/SVGStyleElement.cpp:
        (SVGStyleElement::childrenChanged):
        * ksvg2/svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::canvas):
        * ksvg2/svg/SVGTitleElement.cpp:
        (WebCore::SVGTitleElement::closeRenderer):
        (WebCore::SVGTitleElement::insertedIntoDocument):
        (WebCore::SVGTitleElement::removedFromDocument):
        (WebCore::SVGTitleElement::childrenChanged):
        * ksvg2/svg/SVGUseElement.cpp:
        (SVGUseElement::closeRenderer):
        * kwq/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityPerformAction:]):
        (-[WebCoreAXObject accessibilityAttributeValue:]):
        * page/Frame.cpp:
        (WebCore::parentFromOwnerRenderer):
        (WebCore::Frame::frameForNode):
        (WebCore::Frame::clearDocumentFocus):
        * page/FrameView.cpp:
        (WebCore::FrameView::dispatchMouseEvent):
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::setStyle):
        * rendering/RenderCanvas.cpp:
        (WebCore::RenderCanvas::RenderCanvas):
        (WebCore::RenderCanvas::paintBoxDecorations):
        (WebCore::RenderCanvas::repaintViewRectangle):
        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageMap):
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::setHasHorizontalScrollbar):
        (WebCore::RenderLayer::setHasVerticalScrollbar):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject):
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::isRoot):
        (WebCore::RenderObject::backslashAsCurrencySymbol):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::document):
        * rendering/RenderTheme.cpp:
        (WebCore::RenderTheme::isFocused):
        * rendering/render_applet.cpp:
        (WebCore::RenderApplet::createWidgetIfNecessary):
        * rendering/render_replaced.cpp:
        (WebCore::RenderWidget::RenderWidget):
        (WebCore::RenderWidget::focusIn):
        (WebCore::RenderWidget::focusOut):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptGlue:
darin [Wed, 29 Mar 2006 00:11:34 +0000 (00:11 +0000)]
JavaScriptGlue:

        Reviewed by Geoff.

        - added a build step that checks for init routines

        * JavaScriptGlue.xcodeproj/project.pbxproj: Added a custom build phase that invokes the
        check-for-global-initializers script.

WebCore:

        Reviewed by Geoff.

        - added a build step that checks for init routines

        * WebCore.xcodeproj/project.pbxproj: Deleted now-unused custom build rule that
        was replaced by the generate-derived-sources script a while back. Added a custom
        build phase that invokes the check-for-global-initializers script.

WebKit:

        Reviewed by Geoff.

        - added a build step that checks for init routines

        * WebKit.xcodeproj/project.pbxproj: Added a custom build phase that invokes the
        check-for-global-initializers script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Wed, 29 Mar 2006 00:09:20 +0000 (00:09 +0000)]
    Reviewed by Geoff.

        - change some code that resulted in init routines on Mac OS X -- if the framework has
          init routines it will use memory and slow down applications that link with WebKit
          even in cases where those applications don't use WebKit

        * kjs/date_object.cpp: Changed constants that were derived by multiplying other constants
        to use immediate numbers instead. Apparently, double constant expressions of the type we
        had here are evaluated at load time.

        * kjs/list.cpp: Can't use OwnArrayPtr in ListImp because of the global instances of
        ListImp, so go back to using a plain old pointer.
        (KJS::List::List): Set overflow to 0 when initializing ListImp.
        (KJS::List::release): Replace a clear call with a delete and explicit set to 0.
        (KJS::List::append): Use raw pointers, and do a delete [] instead of finessing it with
        a swap of OwnArrayPtr.
        (KJS::List::copyFrom): Remove now-unneeded get().
        (KJS::List::copyTail): Ditto.

        * kjs/ustring.cpp: Changed UString::Rep::empty initializer a bit so that it doesn't get
        a static initializer routine. Had to get rid of one level of constant to get the compiler
        to understand it could initialize without any code.

        - added a build step that checks for init routines

        * JavaScriptCore.xcodeproj/project.pbxproj: Deleted now-unused custom build rule that
        was replaced by the generate-derived-sources script a while back. Added a custom build
        phase that invokes the check-for-global-initializers script.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Geoff.
darin [Tue, 28 Mar 2006 23:59:36 +0000 (23:59 +0000)]
    Reviewed by Geoff.

        * Scripts/check-for-global-initializers: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
thatcher [Tue, 28 Mar 2006 23:52:49 +0000 (23:52 +0000)]
    Reviewed by Eric.

        fixes <rdar://problem/4458539> Unable to include Security(public) and WebKit(private) headers

        * bindings/npapi.h: added #defines after the #ifndefs

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
thatcher [Tue, 28 Mar 2006 23:37:01 +0000 (23:37 +0000)]
    Reviewed by Maciej.

        Moved the derived sources script to an agregate target. Fixes internal builds.

        * WebCore.xcodeproj/project.pbxproj:
        * generate-derived-sources: was missing a use of $CREATE_HASH_TABLE

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-28 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Mar 2006 21:36:40 +0000 (21:36 +0000)]
2006-03-28  Eric Seidel  <eseidel@apple.com>

        Reviewed by hyatt.

        Build fix.

        * dom/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::error):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
tomernic [Tue, 28 Mar 2006 21:07:41 +0000 (21:07 +0000)]
    Reviewed by Darin.

        <rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed

        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView initWithFrame:]):
        Don't observe preferences changes here -- we only want to observe preferences while the view is
        installed in the view hierarchy.  Plugins will appropriately start and stop themselves when added to
        or removed from a window.
        (-[WebBaseNetscapePluginView dealloc]):
        Don't remove observers here -- they should have been removed when the view was removed from its
        window.
        (-[WebBaseNetscapePluginView finalize]):
        ditto
        (-[WebBaseNetscapePluginView viewWillMoveToWindow:]):
        Stop observing preferences when the view is removed from its window.
        (-[WebBaseNetscapePluginView viewDidMoveToWindow]):
        Start observing preferences when the view is added to a window.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed, tweaked, landed by Darin.
darin [Tue, 28 Mar 2006 19:07:58 +0000 (19:07 +0000)]
    Reviewed, tweaked, landed by Darin.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8023
          Attribute.h missing class predeclaration

        * dom/Attribute.h: Add declarations for classes so that the friend
        declaration is not the only one. There's an issue with either an earlier
        or later version of gcc, which is why we see this only on certain platforms.

        * dom/Attr.cpp:
        (WebCore::Attr::Attr):
        (WebCore::Attr::~Attr):
        * dom/NamedAttrMap.cpp:
        (WebCore::NamedAttrMap::clearAttributes):
        (WebCore::NamedAttrMap::addAttribute):
        (WebCore::NamedAttrMap::removeAttribute):
        Change places where practical to use attr() instead of m_impl in the vain
        hope of removing the need for the friend declarations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Mar 2006 18:34:44 +0000 (18:34 +0000)]
2006-03-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by darin.

        Replace more DeprecatedString with String.
        Add String::sprintf() and String::number()
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8009

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLTextAreaElement setCols:]):
        (-[DOMHTMLTextAreaElement setRows:]):
        (-[DOMHTMLOListElement setStart:]):
        (-[DOMHTMLPreElement setWidth:]):
        (-[DOMHTMLImageElement setHeight:]):
        (-[DOMHTMLImageElement setHspace:]):
        (-[DOMHTMLImageElement setVspace:]):
        (-[DOMHTMLImageElement setWidth:]):
        (-[DOMHTMLObjectElement setHspace:]):
        (-[DOMHTMLObjectElement setTabIndex:]):
        (-[DOMHTMLObjectElement setVspace:]):
        (-[DOMHTMLAppletElement setHspace:]):
        (-[DOMHTMLAppletElement setVspace:]):
        (-[DOMHTMLAreaElement setTabIndex:]):
        (-[DOMHTMLTableColElement setSpan:]):
        (-[DOMHTMLTableCellElement setColSpan:]):
        (-[DOMHTMLTableCellElement setRowSpan:]):
        (-[DOMHTMLEmbedElement setHeight:]):
        (-[DOMHTMLEmbedElement setWidth:]):
        * bindings/objc/DOMInternal.mm:
        (String::String):
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::numberAsString):
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/css_valueimpl.cpp:
        (WebCore::CSSMutableStyleDeclaration::getPropertyValue):
        (WebCore::CSSPrimitiveValue::cssText):
        * dom/Position.cpp:
        (WebCore::Position::formatForDebugger):
        * dom/Range.cpp:
        (WebCore::Range::formatForDebugger):
        * dom/StyledElement.cpp:
        (WebCore::StyledElement::addCSSColor):
        * dom/xml_tokenizer.cpp:
        (WebCore::XMLTokenizer::error):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyRelativeFontStyleChange):
        * html/HTMLGenericFormElement.cpp:
        (WebCore::HTMLGenericFormElement::findMatchingState):
        (WebCore::HTMLGenericFormElement::setTabIndex):
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setMaxLength):
        (WebCore::HTMLInputElement::setSize):
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSize):
        * html/HTMLTextAreaElement.cpp:
        (WebCore::HTMLTextAreaElement::setCols):
        (WebCore::HTMLTextAreaElement::setRows):
        * html/html_baseimpl.cpp:
        (WebCore::HTMLBodyElement::insertedIntoDocument):
        * html/html_blockimpl.cpp:
        (WebCore::HTMLHRElement::parseMappedAttribute):
        (WebCore::HTMLPreElement::setWidth):
        * html/html_imageimpl.cpp:
        (WebCore::HTMLImageElement::width):
        (WebCore::HTMLImageElement::height):
        (WebCore::HTMLImageElement::setBorder):
        (WebCore::HTMLImageElement::setHeight):
        (WebCore::HTMLImageElement::setHspace):
        (WebCore::HTMLImageElement::setVspace):
        (WebCore::HTMLImageElement::setWidth):
        (WebCore::HTMLAreaElement::setTabIndex):
        * html/html_inlineimpl.cpp:
        (WebCore::HTMLAnchorElement::setTabIndex):
        * html/html_listimpl.cpp:
        (WebCore::HTMLOListElement::setStart):
        (WebCore::HTMLLIElement::setValue):
        * html/html_objectimpl.cpp:
        (WebCore::HTMLObjectElement::setTabIndex):
        * html/html_tableimpl.cpp:
        (WebCore::HTMLTableElement::parseMappedAttribute):
        (WebCore::HTMLTableCellElement::setColSpan):
        (WebCore::HTMLTableCellElement::setRowSpan):
        (WebCore::HTMLTableColElement::setSpan):
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::isSafeScript):
        (KJS::Location::getValueProperty):
        * ksvg2/css/SVGCSSParser.cpp:
        (WebCore::CSSParser::parseSVGPaint):
        (WebCore::CSSParser::parseSVGColor):
        * ksvg2/svg/SVGAngle.cpp:
        (SVGAngle::setValueAsString):
        (SVGAngle::valueAsString):
        * ksvg2/svg/SVGAngle.h:
        * ksvg2/svg/SVGLength.cpp:
        (SVGLength::setValueAsString):
        (SVGLength::valueAsString):
        * ksvg2/svg/SVGLength.h:
        * ksvg2/svg/SVGPathSeg.h:
        (WebCore::SVGPathSeg::pathSegTypeAsLetter):
        (WebCore::SVGPathSeg::toString):
        * ksvg2/svg/SVGPathSegArc.h:
        (WebCore::SVGPathSegArcAbs::pathSegTypeAsLetter):
        (WebCore::SVGPathSegArcAbs::toString):
        (WebCore::SVGPathSegArcRel::pathSegTypeAsLetter):
        (WebCore::SVGPathSegArcRel::toString):
        * ksvg2/svg/SVGPathSegClosePath.h:
        (WebCore::SVGPathSegClosePath::pathSegTypeAsLetter):
        (WebCore::SVGPathSegClosePath::toString):
        * ksvg2/svg/SVGPathSegCurvetoCubic.h:
        (WebCore::SVGPathSegCurvetoCubicAbs::pathSegTypeAsLetter):
        (WebCore::SVGPathSegCurvetoCubicAbs::toString):
        (WebCore::SVGPathSegCurvetoCubicRel::pathSegTypeAsLetter):
        (WebCore::SVGPathSegCurvetoCubicRel::toString):
        * ksvg2/svg/SVGPathSegCurvetoCubicSmooth.h:
        (WebCore::SVGPathSegCurvetoCubicSmoothAbs::pathSegTypeAsLetter):
        (WebCore::SVGPathSegCurvetoCubicSmoothAbs::toString):
        (WebCore::SVGPathSegCurvetoCubicSmoothRel::pathSegTypeAsLetter):
        (WebCore::SVGPathSegCurvetoCubicSmoothRel::toString):
        * ksvg2/svg/SVGPathSegCurvetoQuadratic.h:
        (WebCore::SVGPathSegCurvetoQuadraticAbs::pathSegTypeAsLetter):
        (WebCore::SVGPathSegCurvetoQuadraticAbs::toString):
        (WebCore::SVGPathSegCurvetoQuadraticRel::pathSegTypeAsLetter):
        (WebCore::SVGPathSegCurvetoQuadraticRel::toString):
        * ksvg2/svg/SVGPathSegCurvetoQuadraticSmooth.h:
        (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::pathSegTypeAsLetter):
        (WebCore::SVGPathSegCurvetoQuadraticSmoothAbs::toString):
        (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::pathSegTypeAsLetter):
        (WebCore::SVGPathSegCurvetoQuadraticSmoothRel::toString):
        * ksvg2/svg/SVGPathSegLineto.h:
        (WebCore::SVGPathSegLinetoAbs::pathSegTypeAsLetter):
        (WebCore::SVGPathSegLinetoAbs::toString):
        (WebCore::SVGPathSegLinetoRel::pathSegTypeAsLetter):
        (WebCore::SVGPathSegLinetoRel::toString):
        * ksvg2/svg/SVGPathSegLinetoHorizontal.h:
        (WebCore::SVGPathSegLinetoHorizontalAbs::pathSegTypeAsLetter):
        (WebCore::SVGPathSegLinetoHorizontalAbs::toString):
        (WebCore::SVGPathSegLinetoHorizontalRel::pathSegTypeAsLetter):
        (WebCore::SVGPathSegLinetoHorizontalRel::toString):
        * ksvg2/svg/SVGPathSegLinetoVertical.h:
        (WebCore::SVGPathSegLinetoVerticalAbs::pathSegTypeAsLetter):
        (WebCore::SVGPathSegLinetoVerticalAbs::toString):
        (WebCore::SVGPathSegLinetoVerticalRel::pathSegTypeAsLetter):
        (WebCore::SVGPathSegLinetoVerticalRel::toString):
        * ksvg2/svg/SVGPathSegMoveto.h:
        (WebCore::SVGPathSegMovetoAbs::pathSegTypeAsLetter):
        (WebCore::SVGPathSegMovetoAbs::toString):
        (WebCore::SVGPathSegMovetoRel::pathSegTypeAsLetter):
        (WebCore::SVGPathSegMovetoRel::toString):
        * ksvg2/svg/SVGPolyElement.cpp:
        (SVGPolyElement::notifyAttributeChange):
        * ksvg2/svg/SVGStopElement.cpp:
        (SVGStopElement::parseMappedAttribute):
        * ksvg2/svg/SVGUseElement.cpp:
        (SVGUseElement::closeRenderer):
        * platform/AtomicString.h:
        (WebCore::AtomicString::toInt):
        * platform/Color.cpp:
        (WebCore::Color::name):
        * platform/Color.h:
        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::sprintf):
        (WebCore::String::number):
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::StringImpl):
        (WebCore::StringImpl::initWithChar):
        (WebCore::StringImpl::initWithQChar):
        (WebCore::StringImpl::containsOnlyWhitespace):
        * platform/mac/KeyEventMac.mm:
        (WebCore::keyIdentifierForKeyEvent):
        * rendering/render_form.cpp:
        (WebCore::RenderSlider::updateFromElement):
        (WebCore::RenderSlider::valueChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Tue, 28 Mar 2006 11:30:44 +0000 (11:30 +0000)]
LayoutTests:

        Reviewed by mjs

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7152>
        REGRESSION: Select All does not highlight table if it's last in the document

        * editing/selection/7152-1-expected.checksum: Added.
        * editing/selection/7152-1-expected.png: Added.
        * editing/selection/7152-1-expected.txt: Added.
        * editing/selection/7152-1.html: Added.
        * editing/selection/7152-2-expected.checksum: Added.
        * editing/selection/7152-2-expected.png: Added.
        * editing/selection/7152-2-expected.txt: Added.
        * editing/selection/7152-2.html: Added.

WebCore:

        Reviewed by mjs

        <http://bugzilla.opendarwin.org/attachment.cgi?id=7322>
        REGRESSION: Select All does not highlight table if it's last in the document

        * rendering/RenderCanvas.cpp:
        (WebCore::rendererAfterPosition):
        Added, returns the render object that a pre-order traversal over a range
        of render objects ending at the input position should stop at.
        (WebCore::RenderCanvas::selectionRect):
        Stop at rendererAfterPosition(m_selectionEnd, m_selectionEndPos), moved code
        for traversal to nextInPreOrder. Also, the travesal doesn't need to fetch the
        next object before doing work, since the work it does will never change what
        the next object in the traversal will be.
        (WebCore::RenderCanvas::setSelection): Ditto.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::nextInPreOrder): Renamed from nextRenderer, cleaned up the logic a little.
        (WebCore::RenderObject::nextInPreOrderAfterChildren): Added.
        (WebCore::RenderObject::previousInPreOrder): Renamed from previousRenderer.
        (WebCore::RenderObject::childAt): Added.
        * rendering/RenderObject.h:
        * rendering/RenderText.cpp:
        (WebCore::RenderText::setText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Justin.
mjs [Tue, 28 Mar 2006 10:37:18 +0000 (10:37 +0000)]
    Reviewed by Justin.

        - fixed <rdar://problem/4483851> REGRESSION: parse mode gets set to strict after going back from non-HTML content (7102)

        Reshuffled things to arrange for m_doc to be cleared somewhat earlier than before.

        * page/Frame.cpp:
        (WebCore::Frame::didOpenURL):
        (WebCore::Frame::receivedFirstData):
        (WebCore::Frame::begin):
        (WebCore::Frame::endIfNotLoading):
        * manual-tests/accidental-strict-mode.html: Added. I don't think an
        automated test is possible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoForgot to check in these results earlier today.
justing [Tue, 28 Mar 2006 09:33:36 +0000 (09:33 +0000)]
Forgot to check in these results earlier today.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-28 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Mar 2006 09:02:15 +0000 (09:02 +0000)]
2006-03-28  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Convert a couple DeprecatedPtrList<T> to Vector<T*> and HashSet<T*>

        * bridge/mac/FrameMac.h:
        * bridge/mac/FrameMac.mm:
        (WebCore::regExpForLabels):
        (WebCore::FrameMac::addPluginRootObject):
        (WebCore::FrameMac::cleanupPluginRootObjects):
        * loader/Cache.cpp:
        (WebCore::Cache::init):
        (WebCore::Cache::clear):
        (WebCore::Cache::remove):
        * loader/Cache.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::DocLoader):
        (WebCore::DocLoader::~DocLoader):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-27 Eric Seidel <eseidel@apple.com>
eseidel [Tue, 28 Mar 2006 06:32:09 +0000 (06:32 +0000)]
2006-03-27  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Give StringImpl a little privacy.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=8022

        * dom/CharacterData.cpp:
        (WebCore::CharacterData::length):
        (WebCore::CharacterData::appendData):
        (WebCore::CharacterData::replaceData):
        (WebCore::CharacterData::checkCharDataOperation):
        (WebCore::CharacterData::rendererIsNeeded):
        * dom/Range.cpp:
        (WebCore::Range::compareBoundaryPoints):
        * dom/Text.cpp:
        (WebCore::Text::splitText):
        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::processToken):
        * platform/AtomicString.cpp:
        (WebCore::operator==):
        * platform/String.cpp:
        (WebCore::String::operator[]):
        (WebCore::String::length):
        (WebCore::String::percentage):
        (WebCore::String::unicode):
        (WebCore::String::deprecatedString):
        (WebCore::String::isEmpty):
        * platform/StringImpl.cpp:
        (WebCore::equal):
        (WebCore::equalIgnoringCase):
        * platform/StringImpl.h:
        * rendering/InlineTextBox.cpp:
        (WebCore::InlineTextBox::selectionRect):
        (WebCore::InlineTextBox::paint):
        (WebCore::InlineTextBox::paintSelection):
        (WebCore::InlineTextBox::paintMarkedTextBackground):
        (WebCore::InlineTextBox::paintTextMatchMarker):
        (WebCore::InlineTextBox::offsetForPosition):
        (WebCore::InlineTextBox::positionForOffset):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::widthFromCache):
        (WebCore::RenderText::calcMinMaxWidth):
        (WebCore::RenderText::width):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
mjs [Tue, 28 Mar 2006 06:30:14 +0000 (06:30 +0000)]
LayoutTests:

        Reviewed by Beth.

        - test cases for <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)

        * fast/block/float/float-in-float-hit-testing-expected.checksum: Added.
        * fast/block/float/float-in-float-hit-testing-expected.png: Added.
        * fast/block/float/float-in-float-hit-testing-expected.txt: Added.
        * fast/block/float/float-in-float-hit-testing.html: Added.
        * fast/block/float/float-in-float-painting-expected.checksum: Added.
        * fast/block/float/float-in-float-painting-expected.png: Added.
        * fast/block/float/float-in-float-painting-expected.txt: Added.
        * fast/block/float/float-in-float-painting.html: Added.
        * fast/events/capture-on-target.html:

WebCore:

        Reviewed by Beth.

        - fixed <rdar://problem/4279765> REGRESSION: "More..." links on flickr groups pages have hover issues (flickr.com)

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::floatRect): Rewrote in terms of rects, and made it consider child floatRects
        as well as their overflowRects.
        * platform/IntRect.h:
        (WebCore::unionRect): useful helper
        * platform/FloatRect.h:
        (WebCore::unionRect): added same for FloatRect just because

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
tomernic [Tue, 28 Mar 2006 04:26:14 +0000 (04:26 +0000)]
    Reviewed by Eric.

        <rdar://problem/3694090> -[WebBaseNetscapePluginView finalize] is incorrect; design change needed

        * ChangeLog:
        * Plugins/WebBaseNetscapePluginView.m:
        (-[WebBaseNetscapePluginView dealloc]):
        Instead of calling -stop, assert that the plugin is not running.  A plugin view cannot be deallocated
        until it is removed from its window.  When a plugin view is removed from its window, it calls -stop
        on itself.  Therefore I believe that this call to -stop is unnecessary; if I'm wrong, then the
        assertion will help catch any edge cases.
        (-[WebBaseNetscapePluginView finalize]):
        ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
tomernic [Tue, 28 Mar 2006 04:15:07 +0000 (04:15 +0000)]
    Reviewed by Eric.

        <rdar://problem/3694086> -[WebBaseNetscapePluginStream finalize] is incorrect; design change needed

        * Plugins/WebBaseNetscapePluginStream.m:
        (-[WebBaseNetscapePluginStream dealloc]):
        Assert that the stream file path either never existed, or was deleted and NULL-ed out.  The stream file
        is now deleted immediately after calling NPP_StreamAsFile().
        (-[WebBaseNetscapePluginStream finalize]):
        ditto
        (-[WebBaseNetscapePluginStream _destroyStream]):
        Delete the file after calling NPP_StreamAsFile(), instead of in -dealloc/-finalize.  It should be OK
        to delete the file here -- NPP_StreamAsFile() is always called immediately before NPP_DestroyStream()
        (the stream destruction function), so there can be no expectation that a plugin will read the stream file
        asynchronously after NPP_StreamAsFile() is called.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
tomernic [Tue, 28 Mar 2006 04:13:28 +0000 (04:13 +0000)]
    Reviewed by Eric.

        <rdar://problem/3694093> -[WebBasePluginPackage finalize] is incorrect; design change needed

        Call -unload on plug-in packages instead of relying on -dealloc/-finalize to do it.  Currently
        the only place plug-in packages are deallocated is when refreshing the set of plugins, as when
        handling JavaScript's navigator.plugins.refresh().

        * Plugins/WebBasePluginPackage.m:
        (-[WebBasePluginPackage dealloc]):
        Assert that the plug-in has been unloaded by the time -dealloc is called.
        (-[WebBasePluginPackage finalize]):
        ditto

        * Plugins/WebPluginDatabase.m:
        (-[WebPluginDatabase refresh]):
        Call -unload on the plug-in packages before releasing them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Based on a patch by Michael Emmel <mike.emmel@gmail.com>.
darin [Tue, 28 Mar 2006 01:07:28 +0000 (01:07 +0000)]
    Based on a patch by Michael Emmel <mike.emmel@gmail.com>.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=8012
          TransferJob.cpp includes non-existent "String.h" (capital S)

        * platform/TransferJob.cpp: Remove unneeded include of "String.h".

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Tue, 28 Mar 2006 00:57:18 +0000 (00:57 +0000)]
    Reviewed by Darin.

        <rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

        * editing/deleting/delete-block-merge-contents-022.html: Added.
        * editing/deleting/delete-block-merge-contents-023.html: Added.
        * editing/selection/selectNode-expected.checksum: Added.
        * editing/selection/selectNode-expected.png: Added.
        * editing/selection/selectNode-expected.txt: Added.
        * editing/selection/selectNode.html: Added.
        * editing/selection/selectNodeContents-expected.checksum: Added.
        * editing/selection/selectNodeContents-expected.png: Added.
        * editing/selection/selectNodeContents-expected.txt: Added.
        * editing/selection/selectNodeContents.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
harrison [Tue, 28 Mar 2006 00:54:30 +0000 (00:54 +0000)]
    Reviewed by Darin.

        <rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

        Better fix than previous checkin, since maxDeepOffset is really an editing hack.

        * editing/selection/selectNodeContents-textNode.html: Added.

        * dom/Range.cpp:
        (WebCore::Range::selectNodeContents):
        Use maxOffset if offsetInCharacters, otherwise use childNodeCount.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago At the request of Michael Emmel <mike.emmel@gmail.com>.
darin [Mon, 27 Mar 2006 22:21:09 +0000 (22:21 +0000)]
    At the request of Michael Emmel <mike.emmel@gmail.com>.

        - fix compilation for Linux
          http://bugzilla.opendarwin.org/show_bug.cgi?id=8013

        * rendering/render_style.h: Add declaration of CSSStyleSelector. Also tweaked
        formatting a bit and removed some extraneous WebCore:: prefixes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
tomernic [Mon, 27 Mar 2006 22:07:12 +0000 (22:07 +0000)]
    Reviewed by Tim Hatcher.

        Part of <rdar://problem/4448350> Deprecated ObjC language API used in JavaScriptCore, WebCore,
        WebKit and WebBrowser

        * Carbon/HIViewAdapter.h:
        HIViewAdapter is no longer an NSView subclass, since we no longer pose it as NSView.
        * Carbon/HIViewAdapter.m:
        (+[NSView bindHIViewToNSView:nsView:]):
        Replace individual NSView methods instead of posing as NSView.
        (_webkit_NSView_setNeedsDisplay):
        Replacement implementation of -[NSView setNeedsDisplay:].
        (_webkit_NSView_setNeedsDisplayInRect):
        Replacement implementation of -[NSView setNeedsDisplayInRect:]
        (_webkit_NSView_nextValidKeyView):
        Replacement implementation of -[NSView nextValidKeyView]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler and Tim Omernick
sullivan [Mon, 27 Mar 2006 21:44:53 +0000 (21:44 +0000)]
    Reviewed by Darin Adler and Tim Omernick

        - fixed <rdar://problem/4406505> REGRESSION: (japanese text) Clauses is unexpectedly
        confirmed while typing on Safari.

        * bindings/objc/DOMHTML.mm:
        (-[DOMHTMLInputElement _displayedValue]):
        Avoid calling stringValue on the focused NSTextField. This will soon be obsolete, but
        for now it fixes this regression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin Adler.
sullivan [Mon, 27 Mar 2006 21:33:20 +0000 (21:33 +0000)]
    Reviewed by Darin Adler.

        Removed two overzealous assertions that the steps to reproduce 4451831 were running into.
        Improved comments to match.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge _nextKeyViewOutsideWebFrameViewsWithValidityCheck:]):
        Remove assertion that _inNextKeyViewOutsideWebFrameViews should always be false here.

        * WebView/WebHTMLView.m:
        (-[NSArray nextValidKeyView]):
        Removed assertion that the frame should never be the main frame here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
tomernic [Mon, 27 Mar 2006 21:20:50 +0000 (21:20 +0000)]
    Reviewed by Tim Hatcher.

        Removed tabs & reformatted code.

        * Carbon/HIViewAdapter.m:
        (+[NSView bindHIViewToNSView:nsView:]):
        (+[NSView getHIViewForNSView:]):
        (+[NSView unbindNSView:]):
        (-[NSView setNeedsDisplay:]):
        (-[NSView setNeedsDisplayInRect:]):
        (-[NSView nextValidKeyView]):
        (SetViewNeedsDisplay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-27 Alexander Kellett <lypanov@kde.org>
lypanov [Mon, 27 Mar 2006 21:10:17 +0000 (21:10 +0000)]
2006-03-27  Alexander Kellett  <lypanov@kde.org>

        Reviewed by darin

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6520
        the IE extension insertAdjacentElement

        * fast/dynamic/insertAdjacentElement.html: Added.

2006-03-27  Alexander Kellett  <lypanov@kde.org>

        Reviewed by darin

        Implement the IE extension insertAdjacentElement
        http://bugzilla.opendarwin.org/show_bug.cgi?id=6520

        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Element.cpp:
        (WebCore::ElementImpl::insertAdjacentElement):
        * dom/Element.h:
        * dom/Element.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by beth and geoff
justing [Mon, 27 Mar 2006 17:34:20 +0000 (17:34 +0000)]
    Reviewed by beth and geoff

        * editing/selection/6476-expected.checksum: Added.
        * editing/selection/6476-expected.png: Added.
        * editing/selection/6476-expected.txt: Added.
        * editing/selection/6476.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Tim Hatcher.
harrison [Mon, 27 Mar 2006 16:23:01 +0000 (16:23 +0000)]
    Reviewed by Tim Hatcher.

        <rdar://problem/4427002> REGRESSION: VoiceOver doesn't read heading level text in Safari (Range selectNodeContents broken)

        Range::selectNodeContents() was erroneously using childNodeCount, which is always 0 for text
        nodes.  Turns out that [WebCoreAXObject textUnderElement] is the only code that ends up calling
        selectNodeContents on a text node.

        Test cases added: None.  Manual AX testing is way too awkward, and automated testing
        is not possible.  See following bug...
            <rdar://problem/4256882> Need automated testing support for accessibility APIs

        * dom/Range.cpp:
        (WebCore::Range::selectNodeContents):
        Use maxDeepOffset instead of childNodeCount, so that text node content is selected.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Mon, 27 Mar 2006 13:17:22 +0000 (13:17 +0000)]
LayoutTests:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
        REGRESSION: Extraneous focus ring drawn at the end of the page

        * fast/css/outline-auto-empty-rects-expected.checksum: Added.
        * fast/css/outline-auto-empty-rects-expected.png: Added.
        * fast/css/outline-auto-empty-rects-expected.txt: Added.
        * fast/css/outline-auto-empty-rects.html: Added.

WebCore:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7868>
        REGRESSION: Extraneous focus ring drawn at the end of the page

        * platform/GraphicsContext.cpp:
        (WebCore::GraphicsContext::addFocusRingRect): Don't add a focus ring for an empty rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
mjs [Mon, 27 Mar 2006 11:29:11 +0000 (11:29 +0000)]
JavaScriptCore:

        Reviewed by Anders.

        - fixed <rdar://problem/4489745> REGRESSION: Safari crashes at to display http://www.lgphilips-lcd.com/

        * kjs/nodes.cpp:
        (Node::deref): take into account the case where the extra refcount table was never created

WebCore:

        Reviewed by Anders.

        - fixed <rdar://problem/4489745> REGRESSION: Safari crashes at to display http://www.lgphilips-lcd.com/

        * manual-tests/empty-script-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Build fix:
mjs [Mon, 27 Mar 2006 09:32:34 +0000 (09:32 +0000)]
    Build fix:

        - reverted fix for <rdar://problem/4362396> capturing listeners do not fire on the target node
        It turns out that the behavior we had was standards-compliant and
        Moz will be changing to match.

        Also added a note so this doesn't get reverted again.

        * dom/EventTargetNode.cpp:
        (WebCore::EventTargetNode::dispatchGenericEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoWebCore:
justing [Mon, 27 Mar 2006 08:34:32 +0000 (08:34 +0000)]
WebCore:

        Reviewed by darn

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
        Add EditActions and WebUndoActions for CreateLink and Unlink

        * bridge/mac/WebCoreFrameBridge.h:
        * editing/CreateLinkCommand.h:
        (WebCore::CreateLinkCommand::editingAction):
        * editing/EditAction.h:
        * editing/UnlinkCommand.h:
        (WebCore::UnlinkCommand::editingAction):

WebKit:

        Reviewed by darin

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7974>
        Add EditActions and WebUndoActions for CreateLink and Unlink

        * English.lproj/Localizable.strings:
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge nameForUndoAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-26 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Mar 2006 03:29:58 +0000 (03:29 +0000)]
2006-03-26  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix win32 build.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * editing/CompositeEditCommand.cpp:
        * editing/InsertTextCommand.cpp:
        * generate-derived-sources:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-26 Eric Seidel <eseidel@apple.com>
eseidel [Mon, 27 Mar 2006 01:30:00 +0000 (01:30 +0000)]
2006-03-26  Eric Seidel  <eseidel@apple.com>

        * dom/Element.cpp: fix include case, fixing build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-25 Mitz Pettel <opendarwin.org@mitzpettel.com>
eseidel [Sun, 26 Mar 2006 22:58:26 +0000 (22:58 +0000)]
2006-03-25  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by darin.  Landed by eseidel.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7916
          Box repaint rect does not include the left overflow

        * manual-tests/left-overflow-repaint.html: Added.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::overflowRect): Changed m_overflowWidth and m_overflowHeight
        to overflowWidth() and overflowHeight() since RenderTable overrides the latter.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::getAbsoluteRepaintRect): Include top and left overflows.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::getAbsoluteRepaintRect): Removed redundant code.
        * rendering/RenderTableCell.cpp: Removed subclass implementation of
        getAbsoluteRepaintRect().
        * rendering/RenderTableCell.h:
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::layoutInlineChildren): Include left overflow in repaint rect.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-25 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 23:52:21 +0000 (23:52 +0000)]
2006-03-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Build fix.

        * bindings/scripts/CodeGeneratorJS.pm: include Element.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-24 Mitz Pettel <opendarwin.org@mitzpettel.com>
eseidel [Sat, 25 Mar 2006 22:24:52 +0000 (22:24 +0000)]
2006-03-24  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by darin.  Landed by eseidel.

        - http://bugzilla.opendarwin.org/show_bug.cgi?id=7947
          Add repaint testing support to run-webkit-tests

        * DumpRenderTree/DumpRenderTree.m:
        (main): Added --repaint and --horizontal-sweep options.
        (dump): Repaint line-by-line or column-by-column when the appropriate option
        is selected.
        (+[LayoutTestController isSelectorExcludedFromWebScript:]): Added testRepaint()
        and repaintSweepHorizontally() methods to layoutTestController.
        (-[LayoutTestController testRepaint]):
        (-[LayoutTestController repaintSweepHorizontally]):
        (dumpRenderTree):
        * Scripts/run-webkit-tests: Added --repaint and --horizontal-sweep options
        to force these settings on tests that do not ask for them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-25 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 22:20:36 +0000 (22:20 +0000)]
2006-03-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by andersca.

        Split dom_elementimpl.* into multiple files (one per class).
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7978

        * ForwardingHeaders/kdom/core/Attr.h: Removed.
        * ForwardingHeaders/kdom/core/Element.h: Removed.
        * ForwardingHeaders/kdom/core/XMLElement.h: Removed.
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMHTML.mm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/AbstractView.cpp:
        * dom/Attr.cpp: Added.
        * dom/Attr.h: Added.
        * dom/Attribute.cpp: Added.
        * dom/Attribute.h: Added.
        * dom/CSSMappedAttributeDeclaration.cpp: Added.
        * dom/CSSMappedAttributeDeclaration.h: Added.
        * dom/DOMImplementation.cpp:
        * dom/Document.h:
        * dom/DocumentType.cpp:
        * dom/Element.cpp: Added.
        (WebCore::Element::Element):
        (WebCore::Element::~Element):
        * dom/Element.h: Added.
        * dom/EventNames.cpp:
        * dom/EventTargetNode.cpp:
        * dom/MappedAttribute.cpp: Added.
        * dom/MappedAttribute.h: Added.
        * dom/MappedAttributeEntry.h: Added.
        (WebCore::):
        * dom/NameNodeList.cpp:
        (WebCore::NameNodeList::NameNodeList):
        (WebCore::NameNodeList::item):
        (WebCore::NameNodeList::nodeMatches):
        * dom/NamedAttrMap.cpp: Added.
        * dom/NamedAttrMap.h: Added.
        * dom/NamedMappedAttrMap.cpp: Added.
        (WebCore::NamedMappedAttrMap::NamedMappedAttrMap):
        * dom/NamedMappedAttrMap.h: Added.
        * dom/Node.cpp:
        * dom/NodeList.cpp:
        * dom/Position.cpp:
        * dom/StyledElement.cpp: Added.
        * dom/StyledElement.h: Added.
        * dom/dom_elementimpl.cpp: Removed.
        * dom/dom_elementimpl.h: Removed.
        * editing/BreakBlockquoteCommand.cpp:
        * editing/CompositeEditCommand.cpp:
        * editing/DeleteFromTextNodeCommand.cpp:
        * editing/DeleteSelectionCommand.cpp:
        * editing/InsertLineBreakCommand.cpp:
        * editing/InsertParagraphSeparatorCommand.cpp:
        * editing/InsertTextCommand.cpp:
        * editing/MergeIdenticalElementsCommand.cpp:
        * editing/ModifySelectionListLevelCommand.cpp:
        * editing/MoveSelectionCommand.cpp:
        * editing/RemoveCSSPropertyCommand.cpp:
        * editing/RemoveNodeAttributeCommand.cpp:
        * editing/Selection.cpp:
        * editing/SelectionController.cpp:
        * editing/SetNodeAttributeCommand.cpp:
        * editing/SplitElementCommand.cpp:
        * editing/SplitTextNodeContainingElementCommand.cpp:
        * editing/TextIterator.cpp:
        * editing/TypingCommand.cpp:
        * editing/VisiblePosition.cpp:
        * editing/visible_units.cpp:
        * html/HTMLElement.h:
        * html/HTMLTokenizer.h:
        * html/html_baseimpl.cpp:
        * kcanvas/RenderSVGImage.cpp:
        * khtml/ecma/kjs_views.cpp:
        * khtml/ecma/kjs_window.cpp:
        (KJS::Window::getValueProperty):
        * khtml/xbl/xbl_binding_manager.cpp:
        * khtml/xbl/xbl_tokenizer.cpp:
        * ksvg2/misc/SVGImageLoader.cpp:
        * ksvg2/svg/SVGAElement.cpp:
        * ksvg2/svg/SVGAnimateTransformElement.cpp:
        * ksvg2/svg/SVGAnimationElement.cpp:
        * ksvg2/svg/SVGCircleElement.cpp:
        * ksvg2/svg/SVGClipPathElement.cpp:
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        * ksvg2/svg/SVGCursorElement.cpp:
        * ksvg2/svg/SVGElement.cpp:
        (WebCore::SVGElement::SVGElement):
        * ksvg2/svg/SVGElement.h:
        * ksvg2/svg/SVGEllipseElement.cpp:
        * ksvg2/svg/SVGExternalResourcesRequired.cpp:
        * ksvg2/svg/SVGFEBlendElement.cpp:
        * ksvg2/svg/SVGFEColorMatrixElement.cpp:
        * ksvg2/svg/SVGFEComponentTransferElement.cpp:
        * ksvg2/svg/SVGFECompositeElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        * ksvg2/svg/SVGFEDisplacementMapElement.cpp:
        * ksvg2/svg/SVGFEFloodElement.cpp:
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        * ksvg2/svg/SVGFEImageElement.cpp:
        * ksvg2/svg/SVGFELightElement.cpp:
        * ksvg2/svg/SVGFEMergeElement.cpp:
        * ksvg2/svg/SVGFEMergeNodeElement.cpp:
        * ksvg2/svg/SVGFEOffsetElement.cpp:
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        * ksvg2/svg/SVGFETileElement.cpp:
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        * ksvg2/svg/SVGFilterElement.cpp:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.cpp:
        * ksvg2/svg/SVGFitToViewBox.cpp:
        * ksvg2/svg/SVGGradientElement.cpp:
        * ksvg2/svg/SVGImageElement.cpp:
        * ksvg2/svg/SVGLangSpace.cpp:
        * ksvg2/svg/SVGLineElement.cpp:
        * ksvg2/svg/SVGLinearGradientElement.cpp:
        * ksvg2/svg/SVGMarkerElement.cpp:
        * ksvg2/svg/SVGMaskElement.cpp:
        * ksvg2/svg/SVGPathElement.cpp:
        * ksvg2/svg/SVGPatternElement.cpp:
        * ksvg2/svg/SVGPolyElement.cpp:
        * ksvg2/svg/SVGRadialGradientElement.cpp:
        * ksvg2/svg/SVGRectElement.cpp:
        * ksvg2/svg/SVGSVGElement.cpp:
        * ksvg2/svg/SVGScriptElement.cpp:
        * ksvg2/svg/SVGStopElement.cpp:
        * ksvg2/svg/SVGStyledElement.cpp:
        * ksvg2/svg/SVGStyledTransformableElement.cpp:
        * ksvg2/svg/SVGSwitchElement.cpp:
        * ksvg2/svg/SVGTests.cpp:
        * ksvg2/svg/SVGTextContentElement.cpp:
        * ksvg2/svg/SVGTextPositioningElement.cpp:
        * ksvg2/svg/SVGTransformable.cpp:
        * ksvg2/svg/SVGURIReference.cpp:
        * ksvg2/svg/SVGUseElement.cpp:
        * ksvg2/svg/SVGViewElement.cpp:
        * ksvg2/svg/SVGZoomAndPan.cpp:
        * kwq/WebCoreTextArea.mm:
        * platform/Widget.h:
        * rendering/RenderBlock.cpp:
        * rendering/RenderCanvas.cpp:
        * rendering/RenderContainer.cpp:
        * rendering/RenderObject.cpp:
        * rendering/RenderTextField.cpp:
        * rendering/RenderThemeMac.mm:
        * rendering/bidi.cpp:
        * rendering/render_replaced.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-25 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 11:22:44 +0000 (11:22 +0000)]
2006-03-25  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix RenderStyle creation to avoid floating RenderStyle objects.
        This also fixes a bug, were SVG to ever start sharing RenderStyles
        between elements, code would have crashed as there were improperly
        paired style->deref() statements in SVG code.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7976

        No test possible (no functionality change).

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::createStyleForElement):
        (WebCore::CSSStyleSelector::createPseudoStyleForElement):
        * css/cssstyleselector.h:
        * dom/Node.cpp:
        (WebCore::Node::createRendererIfNeeded):
        (WebCore::Node::createStyleForRenderer):
        * dom/Node.h:
        * dom/dom_elementimpl.cpp:
        (WebCore::Element::createStyleForRenderer):
        (WebCore::Element::recalcStyle):
        * dom/dom_elementimpl.h:
        * ksvg2/svg/SVGClipPathElement.cpp:
        (SVGClipPathElement::canvasResource):
        * ksvg2/svg/SVGFEFloodElement.cpp:
        (SVGFEFloodElement::filterEffect):
        * ksvg2/svg/SVGGradientElement.cpp:
        (SVGGradientElement::rebuildStops):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::createObject):
        (WebCore::RenderObject::RenderObject):
        (WebCore::selectStartNode):
        (WebCore::RenderObject::draggableNode):
        (WebCore::RenderObject::getPseudoStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-23 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 10:46:44 +0000 (10:46 +0000)]
2006-03-23  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Shave .2% on PLT by removing bogus strcmp.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7938

        Test: fast/parser/tag-with-exclamation-point.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseTag): remove bogus strcmp

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Sat, 25 Mar 2006 10:17:39 +0000 (10:17 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
        TinyMCE: execCommand("Unlink") unimplemented

        * editing/editing.js:
        * editing/execCommand/createLink-expected.checksum: Removed.
        * editing/execCommand/createLink-expected.png: Removed.
        * editing/execCommand/createLink-expected.txt:
        * editing/execCommand/createLink.html:
        * editing/execCommand/unlink-expected.txt: Added.
        * editing/execCommand/unlink.html: Added.

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7683>
        TinyMCE: execCommand("Unlink") unimplemented

        Added code to push partially selected anchor elements down before
        creating or removing links to create fully selected chunks that can be removed.
        Changed __create_link_command_h__ to CreateLinkCommand_h
        Gave styled element application/removal its own ApplyStyleCommand constructor.
        Still need to add new EditActions (7974).

        * WebCore.xcodeproj/project.pbxproj:
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::ApplyStyleCommand):
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
        * editing/ApplyStyleCommand.h:
        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::applyStyle):
        (WebCore::CompositeEditCommand::applyStyledElement):
        (WebCore::CompositeEditCommand::removeStyledElement):
        (WebCore::enclosingAnchorElement):
        (WebCore::CompositeEditCommand::pushAnchorElementDown):
        (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
        * editing/CompositeEditCommand.h:
        * editing/CreateLinkCommand.cpp:
        (WebCore::CreateLinkCommand::doApply):
        * editing/CreateLinkCommand.h:
        * editing/JSEditor.cpp:
        * editing/Selection.cpp:
        (WebCore::Selection::selectionFromContentsOfNode):
        * editing/Selection.h:
        * editing/UnlinkCommand.cpp: Added.
        (WebCore::UnlinkCommand::UnlinkCommand):
        (WebCore::UnlinkCommand::doApply):
        * editing/UnlinkCommand.h: Added.
        * page/Frame.cpp:
        (WebCore::Frame::selectContentsOfNode):
        (WebCore::Frame::computeAndSetTypingStyle):
        (WebCore::Frame::applyStyle):
        (WebCore::Frame::applyParagraphStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@13476 268f45cc-cd09-0410...
justing [Sat, 25 Mar 2006 03:34:00 +0000 (03:34 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
justing [Sat, 25 Mar 2006 03:28:51 +0000 (03:28 +0000)]
LayoutTests:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
        REGRESSION: Content with an interchange newline lost when pasted at the end of the document

        * editing/pasteboard/7955-expected.checksum: Added.
        * editing/pasteboard/7955-expected.png: Added.
        * editing/pasteboard/7955-expected.txt: Added.
        * editing/pasteboard/7955.html: Added.

WebCore:

        Reviewed by harrison

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7955>
        REGRESSION: Content with an interchange newline lost when pasted at the end of the document

        There's no safe place in the document to keep the fragment while pasting, so I avoid
        isProbablyBlock by saving whether or not something was blockFlow during the test
        insertion.

        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplacementFragment::ReplacementFragment):
        (WebCore::ReplacementFragment::~ReplacementFragment):
        (WebCore::ReplacementFragment::firstChild):
        (WebCore::ReplacementFragment::lastChild):
        (WebCore::ReplacementFragment::mergeStartNode):
        (WebCore::ReplacementFragment::enclosingBlock):
        (WebCore::ReplacementFragment::insertFragmentForTestRendering):
        (WebCore::ReplacementFragment::restoreTestRenderingNodesToFragment):
        (WebCore::ReplacementFragment::isBlockFlow):
        (WebCore::ReplaceSelectionCommand::fixupNodeStyles):
        (WebCore::styleForNode):
        (WebCore::ReplacementFragment::saveRenderingInfo):
        (WebCore::ReplacementFragment::removeUnrenderedNodes):
        (WebCore::ReplacementFragment::renderedBlocks):
        (WebCore::ReplacementFragment::removeStyleNodes):
        (WebCore::RenderingInfo::RenderingInfo):
        (WebCore::ReplaceSelectionCommand::ReplaceSelectionCommand):
        (WebCore::ReplaceSelectionCommand::doApply):
        * editing/ReplaceSelectionCommand.h:
        (WebCore::RenderingInfo::isBlockFlow):
        (WebCore::ReplacementFragment::renderingInfo):
        (WebCore::ReplacementFragment::nodes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-24 Eric Seidel <eseidel@apple.com>
eseidel [Sat, 25 Mar 2006 03:11:23 +0000 (03:11 +0000)]
2006-03-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by justing.

        * generate-derived-sources: fix clean builds on mac.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Sat, 25 Mar 2006 01:47:44 +0000 (01:47 +0000)]
LayoutTests:

        Reviewed by Dave Harrison.

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7942
          nightlies after r13387 break js createcontextualfragment

        * fast/dom/Range/create-contextual-fragment-expected.checksum: Added.
        * fast/dom/Range/create-contextual-fragment-expected.png: Added.
        * fast/dom/Range/create-contextual-fragment-expected.txt: Added.
        * fast/dom/Range/create-contextual-fragment.html: Added.

WebCore:

        Reviewed by Dave Harrison.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7942
          nightlies after r13387 break js createcontextualfragment

        Test: fast/dom/Range/create-contextual-fragment.html

        * dom/Range.idl: Add createContextualFragment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoFix typo
eseidel [Fri, 24 Mar 2006 10:42:07 +0000 (10:42 +0000)]
Fix typo

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Mar 2006 10:41:05 +0000 (10:41 +0000)]
2006-03-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Build fix.

        * Spinneret/Spinneret/WebFrame.cpp:
        (WebKit::WebFrame::openURL): replace QString with DeprecatedString

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago2006-03-24 Eric Seidel <eseidel@apple.com>
eseidel [Fri, 24 Mar 2006 10:40:28 +0000 (10:40 +0000)]
2006-03-24  Eric Seidel  <eseidel@apple.com>

        Reviewed by mjs.

        Fix win32 build.
        Uninify mac/win dependency handling.
        Fix class vs. struct linker problem for win32.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Add DerivedSources
        * WebCore.vcproj/WebCore/build-generated-files.sh:
        * bridge/win/BrowserExtensionWin.h:
        * bridge/win/FrameWin.h:
        * generate-derived-sources:
        * kwq/AccessibilityObjectCache.h:
        * platform/GraphicsContext.cpp:
        (WebCore::GraphicsContext::createGraphicsContextPrivate):
        (WebCore::GraphicsContext::destroyGraphicsContextPrivate):
        * platform/GraphicsContext.h:
        * platform/cairo/GraphicsContextCairo.cpp:
        * platform/mac/GraphicsContextMac.mm:
        * platform/win/TemporaryLinkStubs.cpp:
        (QLineEdit::selectedText):
        (FrameWin::createPlugin):
        (BrowserExtensionWin::setTypedIconURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Fri, 24 Mar 2006 07:17:26 +0000 (07:17 +0000)]
    Reviewed by Darin.

        - Fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7918
        Coding style doc uses illegal entity

        * coding/coding-style.html: Changed &emdash; to &mdash;.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin.
darin [Fri, 24 Mar 2006 07:15:40 +0000 (07:15 +0000)]
    Reviewed by Darin.

        - JSObject in LiveConnect not working.
        http://bugzilla.opendarwin.org/show_bug.cgi?id=7917

        * bindings/jni_jsobject.cpp:
        (JavaJSObject::convertJObjectToValue): Was trying to retrieve the native pointer from the wrong base
        class, and the GetFieldID was using the wrong signature.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Adele.
darin [Fri, 24 Mar 2006 07:07:34 +0000 (07:07 +0000)]
    Reviewed by Adele.

        - fix <rdar://problem/4484787> KWQAccObject dangles under GC

        * kwq/AccessibilityObjectCache.h: Moved AccessibilityObjectCache into the WebCore
        namespace. Renamed accObject to get, removed setAccObject, renamed removeAccObject
        to remove, removed getAccObjectID, renamed removeAXObjectID to removeAXID, change
        from CF dictionaries to HashMap and HashSet.
        * kwq/AccessibilityObjectCache.mm:
        (WebCore::AccessibilityObjectCache::~AccessibilityObjectCache): Detach all objects
        and call CFRelease on all of them.
        (WebCore::AccessibilityObjectCache::get): Call CFRetain on objects before putting
        them in the HashMap, rather than assuming that retain == CFRetain. This is what
        fixes the GC issue.
        (WebCore::AccessibilityObjectCache::remove): Detach and call CFRelease when removing.
        (WebCore::AccessibilityObjectCache::getAXID): Change to use a single global variable
        for the AXIDs, which makes it so we won't reuse the same AXID as much as we did before.
        (WebCore::AccessibilityObjectCache::removeAXID): Updated to use HashSet.
        (WebCore::AccessibilityObjectCache::textMarkerForVisiblePosition): Updated for other changes.
        (WebCore::AccessibilityObjectCache::visiblePositionForTextMarker): Ditto.
        (WebCore::AccessibilityObjectCache::childrenChanged): Ditto.
        (WebCore::AccessibilityObjectCache::postNotificationToTopWebArea): Ditto.
        (WebCore::AccessibilityObjectCache::postNotification): Ditto.

        * bridge/mac/WebCoreFrameBridge.mm: (-[WebCoreFrameBridge accessibilityTree]):
        Change to use functions by new names.

        * dom/Document.h: AccessibilityObjectCache is now in the WebCore namespace.
        getAccObjectCache and ownerElement are const member functions, and m_accCache
        is a mutable data member.
        * dom/Document.cpp:
        (WebCore::Document::getAccObjectCache): Make const.
        (WebCore::Document::ownerElement): Make const.

        * kwq/WebCoreAXObject.h: Changed WebCoreAXID to WebCore::AXID.
        * kwq/WebCoreAXObject.mm:
        (-[WebCoreAXObject anchorElement]): Update for function name change.
        (-[WebCoreAXObject firstChild]): Ditto.
        (-[WebCoreAXObject lastChild]): Ditto.
        (-[WebCoreAXObject previousSibling]): Ditto.
        (-[WebCoreAXObject nextSibling]): Ditto.
        (-[WebCoreAXObject parentObject]): Ditto.
        (-[WebCoreAXObject accessibilityAttributeValue:]): Ditto.
        (-[WebCoreAXObject doAXUIElementForTextMarker:]): Ditto.
        (AXLinkElementForNode): Ditto.
        (AXAttributedStringAppendReplaced): Ditto.
        (-[WebCoreAXObject accessibilityHitTest:]): Ditto.
        (-[WebCoreAXObject _accessibilityParentForSubview:]): Ditto.
        (-[WebCoreAXObject accessibilityFocusedUIElement]): Ditto.
        (-[WebCoreAXObject axObjectID]): Change field name to m_id.
        (-[WebCoreAXObject setAXObjectID:]): Ditto.
        (-[WebCoreAXObject removeAXObjectID]): Ditto.

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::removeChildNode): Remove ifdefs.
        (WebCore::RenderContainer::appendChildNode): Ditto.
        (WebCore::RenderContainer::insertChildNode): Ditto.
        * rendering/RenderObject.cpp: (WebCore::RenderObject::remove): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Fri, 24 Mar 2006 07:05:03 +0000 (07:05 +0000)]
    Reviewed by Maciej.

        - fix buildbot

        * JavaScriptCore.xcodeproj/project.pbxproj: Change target name to JavaScriptCore (it was "include"!?).
        Also add -Y 3 option for linker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoJavaScriptCore:
darin [Fri, 24 Mar 2006 06:28:07 +0000 (06:28 +0000)]
JavaScriptCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7726
          REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

        * kjs/object.h: Take function name, as well as source URL and line number, when
        using the special overloaded construct for making functions.
        * kjs/object.cpp: (KJS::JSObject::construct): Ditto.
        * kjs/function_object.h: Ditto.
        * kjs/function_object.cpp: (FunctionObjectImp::construct): Pass a name when
        constructing the function rather than null. Use "anonymous" when making a
        function using the default function constructor.

        * kjs/nodes2string.cpp: (FuncDeclNode::streamTo): Put a line break just before
        a function declaration.

        - unrelated fix

        * kxmlcore/HashMapPtrSpec.h: Add missing needed friend declaration.

LayoutTests:

        - test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7726
          REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

        * fast/js/resources/function-names.js: Added.
        * fast/js/function-names.html: Generated.
        * fast/js/function-names-expected.txt: Generated.

WebCore:

        Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7726
          REGRESSION: orbitz calendar fails (JavaScript function serialization/parsing)

        Test: fast/js/function-names.html

        * dom/Document.h: Add function name parameter to createHTMLEventListener.
        * dom/Document.cpp:
        (WebCore::Document::createHTMLEventListener): Pass function name when calling
        createHTMLEventHandler.
        (WebCore::Document::setHTMLWindowEventListener): Pass attribute name as function name
        when calling createHTMLEventListener.

        * html/HTMLElement.cpp: (WebCore::HTMLElement::setHTMLEventListener): Pass attribute
        name as function name when calling createHTMLEventListener.

        * khtml/ecma/kjs_events.h: Add a function name parameter to JSLazyEventListener.
        * khtml/ecma/kjs_events.cpp:
        (KJS::JSLazyEventListener::JSLazyEventListener): Take and store a function name.
        (KJS::JSLazyEventListener::parseCode): Pass function name when constructing the function.

        * khtml/ecma/kjs_proxy.h: Add a function name parameter to createHTMLEventHandler and
        createSVGEventHandler.
        * khtml/ecma/kjs_proxy.cpp:
        (WebCore::KJSProxy::createHTMLEventHandler): Pass function name when creating
        a JSLazyEventListener.
        (WebCore::KJSProxy::createSVGEventHandler): Ditto.

        * ksvg2/events/JSSVGLazyEventListener.h: Add a function name parameter to
        JSSVGLazyEventListener.
        * ksvg2/events/JSSVGLazyEventListener.cpp:
        (WebCore::JSSVGLazyEventListener::JSSVGLazyEventListener): Pass the function name
        on to the base class constructor.

        * ksvg2/misc/SVGDocumentExtensions.h: Add function name parameter to createSVGEventListener.
        * ksvg2/misc/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::createSVGEventListener): Pass function name when
        calling createSVGEventHandler.

        * ksvg2/svg/SVGElement.cpp: (WebCore::SVGElement::addSVGEventListener):
        * ksvg2/svg/SVGSVGElement.cpp: (WebCore::SVGSVGElement::addSVGWindowEventListner):
        Pass attribute name as function name when calling createSVGEventListener.

        * WebCore.xcodeproj/project.pbxproj: Moved generation script to the top.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
tomernic [Fri, 24 Mar 2006 01:51:45 +0000 (01:51 +0000)]
LayoutTests:

        Reviewed by Darin.

        Layout test for:
        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>

        * fast/forms/button-default-title-expected.checksum: Added.
        * fast/forms/button-default-title-expected.png: Added.
        * fast/forms/button-default-title-expected.txt: Added.
        * fast/forms/button-default-title.html: Added.

WebCore:

        Reviewed by Darin.

        <http://bugzilla.opendarwin.org/show_bug.cgi?id=7691>
        REGRESSION: imdb.com search button looks wrong because "Submit" is drawn

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::valueWithDefault):
        Only use the default button title if no title was specified; previously we'd use the default
        button title if the specified title was empty, which is not what Firefox does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago - removed merge artifacts from .checksum files
darin [Fri, 24 Mar 2006 01:20:28 +0000 (01:20 +0000)]
    - removed merge artifacts from .checksum files

        * fast/block/float/vertical-move-relayout-expected.checksum:
        * fast/css/first-letter-detach-expected.checksum:
        * fast/css/hover-subselector-expected.checksum:
        * fast/dom/Element/class-attribute-whitespace-expected.checksum:
        * fast/events/event-sender-mouse-moved-expected.checksum:
        * fast/forms/form-hides-table-expected.checksum:
        * fast/invalid/missing-address-end-tag-expected.checksum:
        * fast/invalid/missing-dl-end-tag-expected.checksum:
        * fast/invalid/missing-dt-end-tag-expected.checksum:
        * fast/invalid/missing-font-end-tag-expected.checksum:
        * fast/text/in-rendered-text-rtl-expected.checksum:
        * fast/tokenizer/missing-title-end-tag-1-expected.checksum:
        * fast/tokenizer/missing-title-end-tag-2-expected.checksum:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
darin [Fri, 24 Mar 2006 01:08:37 +0000 (01:08 +0000)]
LayoutTests:

        Reviewed by Beth.

        - test for <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored

        * fast/css/max-height-none-expected.checksum: Added.
        * fast/css/max-height-none-expected.txt: Added.
        * fast/css/max-height-none.html: Added.
        * fast/css/max-height-none-expected.png: Added.

WebCore:

        Reviewed by Beth.

        - fix <rdar://problem/4335038> REGRESSION: when max-height is none, height value is ignored

        * css/cssstyleselector.cpp: (WebCore::CSSStyleSelector::applyProperty):
        For max-height of none, set it to Length(undefinedLength, Fixed), which
        is the correct value (same as the default). Also did some formatting fixes
        to the height section.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed, tweaked, and landed by Beth.
bdakin [Thu, 23 Mar 2006 22:44:29 +0000 (22:44 +0000)]
    Reviewed, tweaked, and landed by Beth.

        Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=6431

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Darin
bdakin [Thu, 23 Mar 2006 22:27:49 +0000 (22:27 +0000)]
    Reviewed by Darin

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=6431
        REGRESSION: style change where :hover changes only an :after style
        doesn't work

        * dom/Node.cpp:
        (WebCore::Node::diff): Need to call diff() on the before and after
        styles if we have them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by John Sullivan.
tomernic [Thu, 23 Mar 2006 22:07:37 +0000 (22:07 +0000)]
    Reviewed by John Sullivan.

        At John's suggestion, renamed a private WebFrame method and tightened up some of the redirect logic I recently touched.

        * WebView/WebFramePrivate.h:
        Renamed -_clientRedirectCancelled: to -_clientRedirectCancelledOrFinished:, since we call this both when a redirect is
        cancelled and when a redirect is successfully committed.
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge reportClientRedirectCancelled:]):
        Call renamed WebFrame method.
        * WebView/WebFrame.m:
        Added sentRedirectNotification flag to WebFramePrivate.  This flag is set when we notify the frame load delegate that a
        redirect will occur.  We check this flag when committing a provisional load to ensure that the frame load delegate is
        notified that the redirect finished.
        (-[WebFrame _commitProvisionalLoad:]):
        After committing a provisional load, make sure that the frame load delegate is notified that there is no longer a pending
        redirect.
        (-[WebFrame _clientRedirectedTo:delay:fireDate:lockHistory:isJavaScriptFormAction:]):
        Set the new sentRedirectNotification flag.
        (-[WebFrame _clientRedirectCancelledOrFinished:]):
        Renamed method.
        Clear the sentRedirectNotification flag.
        (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
        Call renamed method.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoLayoutTests:
adele [Thu, 23 Mar 2006 21:58:32 +0000 (21:58 +0000)]
LayoutTests:

        - Test for http://bugzilla.opendarwin.org/show_bug.cgi?id=7935
        <rdar://problem/4489010>
        Infinite recursion in table code when button or new text fields get display:table-row

        Added:
        * fast/forms/button-table-styles.txt: Added.
        * fast/forms/button-table-styles.png: Added.
        * fast/forms/button-table-styles.checksum: Added.
        * fast/forms/button-table-styles.html: Added.

WebCore:

        Reviewed by Hyatt.

        - Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=7935
        <rdar://problem/4489010>
        Infinite recursion in table code when button or new text fields get display:table-row

        Test:
        fast/forms/button-table-styles.html

        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::adjustStyle):
        The theme should disallow table display styles form elements.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years agoCorrected the date on my previous ChangeLog entry for 4439752.
tomernic [Thu, 23 Mar 2006 21:28:44 +0000 (21:28 +0000)]
Corrected the date on my previous ChangeLog entry for 4439752.
Also moved to the top of the file (merge problem).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
tomernic [Thu, 23 Mar 2006 21:17:51 +0000 (21:17 +0000)]
    Reviewed by Eric.

        - fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu

        * WebView/WebDataSource.m:
        (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil.
        (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Maciej.
darin [Thu, 23 Mar 2006 16:31:32 +0000 (16:31 +0000)]
    Reviewed by Maciej.

        - fix http://bugzilla.opendarwin.org/show_bug.cgi?id=7805
          LEAK: method name leaks in KJS::Bindings::CInstance::invokeMethod

        * bindings/c/c_utility.h: Remove NPN_UTF16FromString declaration (not implemented).
        * bindings/c/c_utility.cpp:
        (KJS::Bindings::convertValueToNPVariant): Use DOUBLE_TO_NPVARIANT,
        BOOLEAN_TO_NPVARIANT, VOID_TO_NPVARIANT, NULL_TO_NPVARIANT, and
        OBJECT_TO_NPVARIANT. In the case of OBJECT, call _NPN_RetainObject in
        one case and remove a _NPN_ReleaseObject in another because this
        should return a retained value.
        (KJS::Bindings::convertNPVariantToValue): Use NPVARIANT_TO_BOOLEAN,
        NPVARIANT_TO_INT32, and NPVARIANT_TO_DOUBLE.

        * bindings/c/c_runtime.h: Removed implementations of CMethod::name and
        CField::name that called _NPN_UTF8FromIdentifier and hence leaked.
        * bindings/c/c_runtime.cpp:
        (KJS::Bindings::CMethod::name): Added. Returns the string from inside the
        method object.
        (KJS::Bindings::CField::name): Added. Returns the string from inside the
        field object.
        (KJS::Bindings::CField::valueFromInstance): Added call to _NPN_ReleaseVariantValue
        on the result of getProperty after using it to fix a storage leak.
        (KJS::Bindings::CField::setValueToInstance): Added call to _NPN_ReleaseVariantValue
        after pasing a value to setProperty now that the conversion function does a retain.

        * bindings/c/c_instance.cpp:
        (KJS::Bindings::CInstance::invokeMethod): Changed to use Vector for a local
        stack buffer. Removed special case for NPVARIANT_IS_VOID because the
        convertNPVariantToValue function handles that properly.
        (KJS::Bindings::CInstance::invokeDefaultMethod): Ditto.

        * bindings/NP_jsobject.h: Formatting changes only.
        * bindings/NP_jsobject.cpp:
        (jsDeallocate): Changed parameter type so we don't need a function cast.
        (_NPN_InvokeDefault): Use VOID_TO_NPVARIANT.
        (_NPN_Invoke): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT.
        (_NPN_Evaluate): Use VOID_TO_NPVARIANT.
        (_NPN_GetProperty): Use NULL_TO_NPVARIANT and VOID_TO_NPVARIANT.

        * bindings/c/c_class.cpp: Formatting changes only.
        * bindings/c/c_class.h: Formatting changes only.

        * bindings/npruntime_priv.h: Removed obsolete and now-unused functions:
        NPN_VariantIsVoid, NPN_VariantIsNull, NPN_VariantIsUndefined,
        NPN_VariantIsBool, NPN_VariantIsInt32, NPN_VariantIsDouble,
        NPN_VariantIsString, NPN_VariantIsObject, NPN_VariantToBool,
        NPN_VariantToInt32, NPN_VariantToDouble, NPN_VariantToString,
        NPN_VariantToStringCopy, NPN_VariantToObject, NPN_InitializeVariantAsVoid,
        NPN_InitializeVariantAsNull, NPN_InitializeVariantAsUndefined,
        NPN_InitializeVariantWithBool, NPN_InitializeVariantWithInt32,
        NPN_InitializeVariantWithDouble, NPN_InitializeVariantWithString,
        NPN_InitializeVariantWithObject, and NPN_InitializeVariantWithVariant.
        * bindings/npruntime.cpp:
        (getIntIdentifierDictionary): Don't bother creating custom callbacks for the
        integer dictionary since the default behavior is fine for integers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago * generate-derived-sources: Tweaked formatting a tiny bit and removed a stray
darin [Thu, 23 Mar 2006 16:08:29 +0000 (16:08 +0000)]
    * generate-derived-sources: Tweaked formatting a tiny bit and removed a stray
        touch that was left in here.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

14 years ago Reviewed by Eric.
darin [Thu, 23 Mar 2006 15:36:47 +0000 (15:36 +0000)]
    Reviewed by Eric.

        - fix <rdar://problem/4380465> repro crash when unsuccessfully attempting to import image from Services menu

        * WebView/WebDataSource.m:
        (-[WebDataSource _imageElementWithImageResource:]): Quietly do nothing if passed nil.
        (-[WebDataSource _documentFragmentWithImageResource:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@13453 268f45cc-cd09-0410-ab3c-d52691b4dbfc