WebKit-https.git
6 years agoSource/WebCore: iOS build fixing: export required by iOS WebKit1.
simon.fraser@apple.com [Tue, 14 Jan 2014 22:20:04 +0000 (22:20 +0000)]
Source/WebCore: iOS build fixing: export required by iOS WebKit1.

* WebCore.exp.in:

Source/WebKit/mac: iOS build fixing: link WebKit against Security.framework on iOS.

* Configurations/WebKit.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK1] Allow generated export files on iOS
dino@apple.com [Tue, 14 Jan 2014 22:18:16 +0000 (22:18 +0000)]
[WK1] Allow generated export files on iOS
https://bugs.webkit.org/show_bug.cgi?id=127008

Reviewed by Simon Fraser.

Source/WebKit:

Modify the export file generation rule to read from
a shared and platform-specific input file.

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

Add a new Mac-only symbol file.

* WebKit.exp: To begin, move the WebIcon* into the Mac-specific exports.
* WebKit.mac.exp: Added. New file holds Mac-only symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r162000.
commit-queue@webkit.org [Tue, 14 Jan 2014 22:13:33 +0000 (22:13 +0000)]
Unreviewed, rolling out r162000.
http://trac.webkit.org/changeset/162000
https://bugs.webkit.org/show_bug.cgi?id=127009

API versioning is wrong (Requested by rfong on #webkit).

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::getContext):
* loader/FrameLoaderClient.h:
* loader/FrameLoaderTypes.h:
* page/ChromeClient.h:

Source/WebKit2:

* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKPageLoaderClient.h:
* UIProcess/API/C/WKPageUIClient.h:
* UIProcess/WebLoaderClient.cpp:
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
* UIProcess/WebUIClient.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebPage.cpp:
* WebProcess/WebPage/WebPage.h:

Tools:

* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createOtherPage):
(WTR::TestController::createWebViewWithOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
mark.lam@apple.com [Tue, 14 Jan 2014 22:11:43 +0000 (22:11 +0000)]
ASSERTION FAILED: !hasError() in JSC::Parser<LexerType>::createSavePoint().
https://bugs.webkit.org/show_bug.cgi?id=126990.

Reviewed by Geoffrey Garen.

Source/JavaScriptCore:

* parser/Parser.cpp:
(JSC::Parser<LexerType>::parseConstDeclarationList):
- We were missing an error check after attempting to parse an initializer
  expression. This is now fixed.

LayoutTests:

* js/dom/parse-syntax-error-in-initializer-expected.txt: Added.
* js/dom/parse-syntax-error-in-initializer.html: Added.
* js/resources/parse-syntax-error-in-initializer.js: Added.
- Added bug test case as a regression test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSpeculative buildfix after r161999.
ossy@webkit.org [Tue, 14 Jan 2014 22:10:40 +0000 (22:10 +0000)]
Speculative buildfix after r161999.

* Shared/APIObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSkip some tests that now fail after r162000.
roger_fong@apple.com [Tue, 14 Jan 2014 21:46:26 +0000 (21:46 +0000)]
Skip some tests that now fail after r162000.
https://bugs.webkit.org/show_bug.cgi?id=127000.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Move CSSPrimitiveValue <-> LayoutBox Conversion to CSSPrimitiveValueMappings
betravis@adobe.com [Tue, 14 Jan 2014 21:42:03 +0000 (21:42 +0000)]
[CSS Shapes] Move CSSPrimitiveValue <-> LayoutBox Conversion to CSSPrimitiveValueMappings
https://bugs.webkit.org/show_bug.cgi?id=126719

Reviewed by Dirk Schulze.

The standard location for conversions to/from CSSPrimitiveValues is CSSPrimitiveValueMappings.
This patch moves the conversion for LayoutBoxes from BasicShapeFunctions to
CSSPrimitiveValueMappings.h.

Refactoring, no new tests.

* css/BasicShapeFunctions.cpp:
(WebCore::valueForBasicShape):
(WebCore::basicShapeForValue):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::ComputedStyleExtractor::propertyValue):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::operator LayoutBox):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyShape::applyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd support for handling WebGL load policies.
roger_fong@apple.com [Tue, 14 Jan 2014 21:41:04 +0000 (21:41 +0000)]
Add support for handling WebGL load policies.
https://bugs.webkit.org/show_bug.cgi?id=126935
<rdar://problem/15790448>.

Reviewed by Brent Fulgham.

* WebCore.xcodeproj/project.pbxproj: Copy over HTMLCanvasElement.h to the private headers directory.
* html/HTMLCanvasElement.cpp: Show the policy dialog and retrieve policies as necessary.
(WebCore::HTMLCanvasElement::getContext): Make sure that WebGL is allowed on the site.
                                          If it isn't, be sure to notify the frame loader client that
                                          the site is trying to create a WebGL context.

Boiler plate code for sending messages to and from the UI and Web Process.

* loader/FrameLoaderClient.h:
(WebCore::FrameLoaderClient::webGLPolicyForHost): Used to get the WebGL load policy for a site.
* loader/FrameLoaderTypes.h:
* page/ChromeClient.h:
(WebCore::ChromeClient::webGLContextCreated): Called when a site is creating a WebGL context.
* UIProcess/API/C/WKAPICast.h:
(WebKit::toWebGLLoadPolicy):
* UIProcess/API/C/WKPageLoaderClient.h:
* UIProcess/API/C/WKPageUIClient.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::webGLLoadPolicy):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::webGLContextCreated):
(WebKit::WebPageProxy::webGLPolicyForHost):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::webGLContextCreated):
* UIProcess/WebUIClient.h:
* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::WebInspectorProxy::platformCreateInspectorPage):
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::webGLContextCreated):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::webGLPolicyForHost):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:
* WebProcess/WebPage/WebPage.cpp: A sendSync is used here to get the webGLPolicyForHost message sent between the Web and UI process.
                                  In the future this will be replaced with a strategy is non-blocking.
(WebKit::WebPage::getWebGLPolicyForHost):
* WebProcess/WebPage/WebPage.h:
* MiniBrowser/mac/WK2BrowserWindowController.m:
(-[WK2BrowserWindowController awakeFromNib]):
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::createWebViewWithOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@162000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of ThreadRestrictionVerifier
andersca@apple.com [Tue, 14 Jan 2014 21:38:38 +0000 (21:38 +0000)]
Get rid of ThreadRestrictionVerifier
https://bugs.webkit.org/show_bug.cgi?id=127004

Reviewed by Sam Weinig.

Source/WebCore:

Remove now unneeded calls.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::defaultIcon):
(WebCore::IconDatabase::setIconDataForIconURL):
(WebCore::IconDatabase::getOrCreateIconRecord):
(WebCore::IconDatabase::readFromDatabase):

Source/WTF:

The ThreadRestrictionVerifier mechanism has been turned off for a while
since it doesn't really have a good solution for objects that are passed between threads.
Instead of having dead code in the tree, just get rid of it.

* GNUmakefile.list.am:
* WTF.vcxproj/WTF.vcxproj:
* WTF.vcxproj/WTF.vcxproj.filters:
* WTF.xcodeproj/project.pbxproj:
* wtf/CMakeLists.txt:
* wtf/RefCounted.h:
(WTF::RefCountedBase::ref):
(WTF::RefCountedBase::hasOneRef):
(WTF::RefCountedBase::refCount):
(WTF::RefCountedBase::derefBase):
* wtf/ThreadRestrictionVerifier.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebKit2 leaks sudden termination assertions when a page with unload handlers is closed.
mrowe@apple.com [Tue, 14 Jan 2014 21:19:12 +0000 (21:19 +0000)]
WebKit2 leaks sudden termination assertions when a page with unload handlers is closed.
<https://webkit.org/b/126974> / <rdar://problem/15812954>

When a page with an unload handler is loaded, the web process tells the UI process that it
should disable sudden termination. However, when the page is closed the connection between
the web and UI process is torn down before the web content has a chance to tell the UI
process to reenable sudden termination.

Reviewed by Anders Carlsson.

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::WebProcessProxy):
(WebKit::WebProcessProxy::~WebProcessProxy): Balance any outstanding disableSuddenTermination calls.
(WebKit::WebProcessProxy::enableSuddenTermination): Decrement the count.
(WebKit::WebProcessProxy::disableSuddenTermination): Increment the count.
* UIProcess/WebProcessProxy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary() and...
dbates@webkit.org [Tue, 14 Jan 2014 20:59:26 +0000 (20:59 +0000)]
[iOS] Directly allocate NSMutableDictionary in QLPreviewConverterDictionary() and QLContentDictionary()
https://bugs.webkit.org/show_bug.cgi?id=126999
<rdar://problem/15810305>

Reviewed by Joseph Pecoraro.

Fixes an issue where we may crash when subsequently accessing WebCore::QLPreviewConverterDictionary()
or WebCore::QLContentDictionary(). Currently neither of these functions retain'ed the NSMutable dictionary
returned by [NSMutableDictionary dictionary]. Instead, we should allocate and initialize NSMutableDictionary
directly to ensure that the dictionary is retained.

* platform/network/ios/QuickLook.mm:
(QLPreviewConverterDictionary):
(QLContentDictionary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexF...
bfulgham@apple.com [Tue, 14 Jan 2014 20:52:50 +0000 (20:52 +0000)]
Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error

LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils): Add missing 'waitForComposite' implementatino.
* fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
* fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebCore icon database appears to leak sudden termination assertions
mrowe@apple.com [Tue, 14 Jan 2014 20:28:23 +0000 (20:28 +0000)]
WebCore icon database appears to leak sudden termination assertions
<https://webkit.org/b/126971> / <rdar://problem/15808797>

Introduce an RAII wrapper around disableSuddenTermination / enableSuddenTermination
and adopt it in IconDatabase to address the incorrect management of sudden termination.

IconDatabase now owns up to two SuddenTerminationDisabler objects. One ensures that
sudden termination is disabled while we're waiting on the sync timer to fire. The second
ensures that sudden termination is disabled while we're waiting on the sync thread to
process any pending work.

Reviewed by Alexey Proskuryakov.

* loader/icon/IconDatabase.cpp:
(WebCore::IconDatabase::IconDatabase):
(WebCore::IconDatabase::wakeSyncThread): Disable sudden termination until the sync thread
has finished this unit of work.
(WebCore::IconDatabase::scheduleOrDeferSyncTimer): Disable sudden termination until the
sync timer has fired.
(WebCore::IconDatabase::syncTimerFired): Clear the member variable to reenable sudden termination.
(WebCore::IconDatabase::syncThreadMainLoop): Taken ownership of the SuddenTerminationDisabler
instance when we start processing a unit of work. Discard the object when our work is complete.
* loader/icon/IconDatabase.h:
* platform/SuddenTermination.h:
(WebCore::SuddenTerminationDisabler::SuddenTerminationDisabler): Disable sudden termination when created.
(WebCore::SuddenTerminationDisabler::~SuddenTerminationDisabler): Enable it when destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: For Remote Inspection link WebProcess's to their parent UIProcess
commit-queue@webkit.org [Tue, 14 Jan 2014 20:23:41 +0000 (20:23 +0000)]
Web Inspector: For Remote Inspection link WebProcess's to their parent UIProcess
https://bugs.webkit.org/show_bug.cgi?id=126995

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-14
Reviewed by Timothy Hatcher.

Source/JavaScriptCore:

* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::listingForDebuggable):
For each WebView, list the parent process. Listing the parent per WebView
is already supported back when we supported processes that could host WebViews
for multiple applications.

* inspector/remote/RemoteInspectorConstants.h:
Add a separate key for the bundle identifier, separate from application identifier.

* inspector/remote/RemoteInspectorDebuggable.cpp:
(Inspector::RemoteInspectorDebuggable::info):
* inspector/remote/RemoteInspectorDebuggable.h:
(Inspector::RemoteInspectorDebuggableInfo::RemoteInspectorDebuggableInfo):
(Inspector::RemoteInspectorDebuggableInfo::hasParentProcess):
If a RemoteInspectorDebuggable has a non-zero parent process identifier
it is a proxy for the parent process.

Source/WebCore:

* inspector/InspectorClient.h:
(WebCore::InspectorClient::parentProcessIdentifier):
Client method intended for WebKit2 so a WebProcess can link to its UIProcess.

* page/PageDebuggable.h:
* page/PageDebuggable.cpp:
(WebCore::PageDebuggable::parentProcessIdentifier):
Provide parent process identifier if there is one.

Source/WebKit2:

* WebProcess/WebCoreSupport/WebInspectorClient.h:
* WebProcess/WebCoreSupport/WebInspectorClient.cpp:
(WebKit::WebInspectorClient::parentProcessIdentifier):
WebProcesses are proxies for a parent UIProcess.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoEnable the experimental selector code generator by default
benjamin@webkit.org [Tue, 14 Jan 2014 20:17:13 +0000 (20:17 +0000)]
Enable the experimental selector code generator by default
https://bugs.webkit.org/show_bug.cgi?id=126953

Reviewed by Gavin Barraclough.

* wtf/Platform.h:
Enable CSS_SELECTOR_JIT on OS X x86_64 by default.
The feature is not ready to ship but it is stable enough to enable
for the bots and nightly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS WebKit2 build fixes, part 3
timothy_horton@apple.com [Tue, 14 Jan 2014 20:14:58 +0000 (20:14 +0000)]
iOS WebKit2 build fixes, part 3

* WebKit2.xcodeproj/project.pbxproj:
Remove some files from the 'All' target that should never have been a part of it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS WebKit2 build fixes, part 2
timothy_horton@apple.com [Tue, 14 Jan 2014 20:07:50 +0000 (20:07 +0000)]
iOS WebKit2 build fixes, part 2

* WebKit2.xcodeproj/project.pbxproj:
Add some missing files.

* WebCore.exp.in:
Export some more symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Skip FontConfig initialization in WebKitTestRunner if requested
zandobersek@gmail.com [Tue, 14 Jan 2014 19:50:08 +0000 (19:50 +0000)]
[GTK] Skip FontConfig initialization in WebKitTestRunner if requested
https://bugs.webkit.org/show_bug.cgi?id=120110

Reviewed by Martin Robinson.

Skip the FontConfig settings initialization in WebKitTestRunner if the
WEBKIT_SKIP_WEBKITTESTRUNNER_FONTCONFIG_INITIALIZATION environment variable is set.
This is useful when profiling the WebKitTestRunner execution, where at the startup
this step takes considerable amount of time and disturbs the profiling output.

* WebKitTestRunner/InjectedBundle/gtk/ActivateFontsGtk.cpp:
(WTR::initializeFontConfigSetting):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd ENABLE(WEB_REPLAY) feature flag to the build system
commit-queue@webkit.org [Tue, 14 Jan 2014 19:21:29 +0000 (19:21 +0000)]
Add ENABLE(WEB_REPLAY) feature flag to the build system
https://bugs.webkit.org/show_bug.cgi?id=126949

Patch by Brian J. Burg <burg@cs.washington.edu> on 2014-01-14
Reviewed by Joseph Pecoraro.

Source/JavaScriptCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Source/WTF:

* wtf/FeatureDefines.h: for now, disable the flag by default.

Tools:

* Scripts/webkitperl/FeatureList.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCrash in WebCore::MediaSourcePrivateAVFObjC::hasAudio const + 13
jer.noble@apple.com [Tue, 14 Jan 2014 19:19:44 +0000 (19:19 +0000)]
Crash in WebCore::MediaSourcePrivateAVFObjC::hasAudio const + 13
https://bugs.webkit.org/show_bug.cgi?id=126768

Reviewed by Eric Carlson.

Null-check m_mediaSourcePrivate before calling.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm:
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasVideo):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::hasAudio):
(WebCore::MediaPlayerPrivateMediaSourceAVFObjC::seekInternal):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in posit...
commit-queue@webkit.org [Tue, 14 Jan 2014 19:13:51 +0000 (19:13 +0000)]
REGRESSION (r160085): check-webkit-style: utf8' codec can't decode byte 0x89 in position 0: invalid start byte.
https://bugs.webkit.org/show_bug.cgi?id=126702

Patch by László Langó <llango.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Alexey Proskuryakov.

Resolve regression and remove a FIXME comment that is already fixed.

* Scripts/webkitpy/common/system/filesystem.py:
(FileSystem.open_text_file_for_reading):
* Scripts/webkitpy/common/system/filesystem_unittest.py:
(RealFileSystemTest.test_read_and_write_file):
* Scripts/webkitpy/style/filereader.py:
(TextFileReader._read_lines):
* Scripts/webkitpy/style/filereader_unittest.py:
(TextFileReaderTest.test_count_delete_only_file):
(TextFileReaderTest):
(TextFileReaderTest.test_process_malformed_file):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove WKView.mm to WKViewIOS.mm as 161950 was supposed to do.
timothy_horton@apple.com [Tue, 14 Jan 2014 18:59:15 +0000 (18:59 +0000)]
Move WKView.mm to WKViewIOS.mm as 161950 was supposed to do.

* UIProcess/API/ios/WKView.mm: Removed.
* UIProcess/API/ios/WKViewIOS.mm: Copied from UIProcess/API/ios/WKView.mm.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] Playback rate is not set when pipeline is not ready.
commit-queue@webkit.org [Tue, 14 Jan 2014 18:59:07 +0000 (18:59 +0000)]
[GStreamer] Playback rate is not set when pipeline is not ready.
https://bugs.webkit.org/show_bug.cgi?id=126692

Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-14
Reviewed by Philippe Normand.

No new tests. Covered by existing tests.

Added new method updatePlaybackRate which is called when playback rate change is possible.
Added m_lastPlaybackRate in order to retrieve last correct playback rate and notify upper
layers about that setting playback rate failed.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::updatePlaybackRate):
(WebCore::MediaPlayerPrivateGStreamer::setRate):
(WebCore::MediaPlayerPrivateGStreamer::updateStates):
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[Win] Application name in user agent string is truncated.
commit-queue@webkit.org [Tue, 14 Jan 2014 18:42:20 +0000 (18:42 +0000)]
[Win] Application name in user agent string is truncated.
https://bugs.webkit.org/show_bug.cgi?id=126810

Patch by peavo@outlook.com <peavo@outlook.com> on 2014-01-14
Reviewed by Anders Carlsson.

* wtf/text/StringConcatenate.h:
(WTF::tryMakeString): Add missing 8 bit check for last argument.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r161978.
commit-queue@webkit.org [Tue, 14 Jan 2014 18:39:19 +0000 (18:39 +0000)]
Unreviewed, rolling out r161978.
http://trac.webkit.org/changeset/161978
https://bugs.webkit.org/show_bug.cgi?id=126992

Test case causes crash on some hardware (Requested by bfulgham
on #webkit).

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel):

LayoutTests:

* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
* fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
* fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r161964 and r161965.
commit-queue@webkit.org [Tue, 14 Jan 2014 18:19:25 +0000 (18:19 +0000)]
Unreviewed, rolling out r161964 and r161965.
http://trac.webkit.org/changeset/161964
http://trac.webkit.org/changeset/161965
https://bugs.webkit.org/show_bug.cgi?id=126988

Tests do not pass on the bots because of slight color
differences. The tests should be redone with squared results
and blending that leads to stable colors. (Requested by krit_
on #webkit).

Source/WebCore:

* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::draw):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):
* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):

LayoutTests:

* css3/compositing/background-blend-mode-crossfade-image-expected.html: Removed.
* css3/compositing/background-blend-mode-crossfade-image.html: Removed.
* css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Removed.
* css3/compositing/background-blend-mode-data-uri-svg-image.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Shapes] Shape images are now <image> types, not just URIs
hmuller@adobe.com [Tue, 14 Jan 2014 18:16:42 +0000 (18:16 +0000)]
[CSS Shapes] Shape images are now <image> types, not just URIs
https://bugs.webkit.org/show_bug.cgi?id=125224

Reviewed by Andreas Kling.

Source/WebCore:

Added support for image-set valued shapes. Added an optional ResourceLoaderOptions
parameter to CSSImageSetValue::cachedImageSet() to enable CORS-enabled fetch of
image-set images. This change is based on a similar patch for ordinary shape image values:
https://bugs.webkit.org/show_bug.cgi?id=123114.

Tests: fast/shapes/shape-inside/shape-inside-image-set.html
       fast/shapes/shape-outside-floats/shape-outside-image-set.html

* css/CSSImageSetValue.cpp:
(WebCore::CSSImageSetValue::cachedImageSet):
* css/CSSImageSetValue.h:
* css/CSSParser.cpp:
(WebCore::CSSParser::parseShapeProperty):
* css/DeprecatedStyleBuilder.cpp:
(WebCore::ApplyPropertyShape::applyValue):
* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingShapeImage):
* css/StyleResolver.h:
* rendering/shapes/Shape.cpp:
(WebCore::Shape::createShape):

LayoutTests:

* fast/shapes/shape-inside/shape-inside-image-set-expected.html: Added.
* fast/shapes/shape-inside/shape-inside-image-set.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-image-set-expected.html: Added.
* fast/shapes/shape-outside-floats/shape-outside-image-set.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Modernize AccessibilityChildrenVector loops
cfleizach@apple.com [Tue, 14 Jan 2014 18:09:51 +0000 (18:09 +0000)]
AX: Modernize AccessibilityChildrenVector loops
https://bugs.webkit.org/show_bug.cgi?id=126915

Reviewed by Anders Carlsson.

Change appropriate for loops to use the new style.
Use auto where appropriate.

* accessibility/AXObjectCache.cpp:
(WebCore::AXObjectCache::focusedImageMapUIElement):
* accessibility/AccessibilityARIAGrid.cpp:
(WebCore::AccessibilityARIAGrid::addRowDescendant):
* accessibility/AccessibilityARIAGridCell.cpp:
(WebCore::AccessibilityARIAGridCell::rowIndexRange):
* accessibility/AccessibilityARIAGridRow.cpp:
(WebCore::AccessibilityARIAGridRow::disclosedRows):
(WebCore::AccessibilityARIAGridRow::disclosedByRow):
(WebCore::AccessibilityARIAGridRow::parentTable):
(WebCore::AccessibilityARIAGridRow::headerObject):
* accessibility/AccessibilityListBox.cpp:
(WebCore::AccessibilityListBox::addChildren):
(WebCore::AccessibilityListBox::setSelectedChildren):
(WebCore::AccessibilityListBox::selectedChildren):
* accessibility/AccessibilityListBoxOption.cpp:
(WebCore::AccessibilityListBoxOption::listBoxOptionIndex):
* accessibility/AccessibilityMenuList.cpp:
(WebCore::AccessibilityMenuList::didUpdateActiveOption):
* accessibility/AccessibilityMenuListPopup.cpp:
(WebCore::AccessibilityMenuListPopup::addChildren):
* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::insertChild):
(WebCore::AccessibilityNodeObject::selectedRadioButton):
(WebCore::AccessibilityNodeObject::selectedTabItem):
(WebCore::AccessibilityNodeObject::ariaLabeledByText):
* accessibility/AccessibilityObject.cpp:
(WebCore::appendChildrenToArray):
(WebCore::AccessibilityObject::clearChildren):
(WebCore::AccessibilityObject::ariaTreeRows):
(WebCore::AccessibilityObject::ariaTreeItemContent):
(WebCore::AccessibilityObject::ariaTreeItemDisclosedRows):
(WebCore::AccessibilityObject::elementAccessibilityHitTest):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::addRadioButtonGroupMembers):
(WebCore::AccessibilityRenderObject::ariaFlowToElements):
(WebCore::AccessibilityRenderObject::isTabItemSelected):
(WebCore::AccessibilityRenderObject::setSelectedRows):
(WebCore::AccessibilityRenderObject::ariaOwnsElements):
(WebCore::AccessibilityRenderObject::accessibilityImageMapHitTest):
(WebCore::AccessibilityRenderObject::addRemoteSVGChildren):
(WebCore::AccessibilityRenderObject::updateAttachmentViewParents):
(WebCore::AccessibilityRenderObject::addHiddenChildren):
(WebCore::AccessibilityRenderObject::ariaSelectedRows):
(WebCore::AccessibilityRenderObject::ariaListboxSelectedChildren):
(WebCore::AccessibilityRenderObject::ariaListboxVisibleChildren):
(WebCore::AccessibilityRenderObject::tabChildren):
(WebCore::AccessibilityRenderObject::mathRadicandObject):
(WebCore::AccessibilityRenderObject::mathRootIndexObject):
(WebCore::AccessibilityRenderObject::mathNumeratorObject):
(WebCore::AccessibilityRenderObject::mathDenominatorObject):
(WebCore::AccessibilityRenderObject::mathUnderObject):
(WebCore::AccessibilityRenderObject::mathOverObject):
(WebCore::AccessibilityRenderObject::mathBaseObject):
(WebCore::AccessibilityRenderObject::mathSubscriptObject):
(WebCore::AccessibilityRenderObject::mathSuperscriptObject):
* accessibility/AccessibilityTable.cpp:
(WebCore::AccessibilityTable::columnHeaders):
(WebCore::AccessibilityTable::rowHeaders):
(WebCore::AccessibilityTable::visibleRows):
(WebCore::AccessibilityTable::cells):
(WebCore::AccessibilityTable::cellForColumnAndRow):
* accessibility/AccessibilityTableColumn.cpp:
(WebCore::AccessibilityTableColumn::headerObject):
* accessibility/AccessibilityTableHeaderContainer.cpp:
(WebCore::AccessibilityTableHeaderContainer::addChildren):
* accessibility/AccessibilityTableRow.cpp:
(WebCore::AccessibilityTableRow::headerObject):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper accessibilityElementAtIndex:]):
(-[WebAccessibilityObjectWrapper indexOfAccessibilityElement:]):
(-[WebAccessibilityObjectWrapper containsUnnaturallySegmentedChildren]):
* accessibility/mac/WebAccessibilityObjectWrapperBase.mm:
(convertMathPairsToNSArray):
(-[WebAccessibilityObjectWrapperBase accessibilityTitle]):
(-[WebAccessibilityObjectWrapperBase accessibilityDescription]):
(-[WebAccessibilityObjectWrapperBase accessibilityHelpText]):
* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(convertToNSArray):
(convertStringsToNSArray):
(-[WebAccessibilityObjectWrapper accessibilityAttributeValue:]):
(-[WebAccessibilityObjectWrapper accessibilityIndexOfChild:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeCount:]):
(-[WebAccessibilityObjectWrapper accessibilityArrayAttributeValues:index:maxCount:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexF...
bfulgham@apple.com [Tue, 14 Jan 2014 17:53:14 +0000 (17:53 +0000)]
Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error

LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils): Add missing 'waitForComposite' implementatino.
* fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
* fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed Mac TestExpectations update.
zalan@apple.com [Tue, 14 Jan 2014 17:41:15 +0000 (17:41 +0000)]
Unreviewed Mac TestExpectations update.

<https://webkit.org/b/126890> is duplicate of <https://webkit.org/b/126889>

* platform/mac/TestExpectations: Mark it as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Test /webkit2/WebKitWebContext/languages crashes with network process enabled
carlosgc@webkit.org [Tue, 14 Jan 2014 17:30:21 +0000 (17:30 +0000)]
[GTK] Test /webkit2/WebKitWebContext/languages crashes with network process enabled
https://bugs.webkit.org/show_bug.cgi?id=126130

Reviewed by Anders Carlsson.

We need to notify the network process when the user preferred
languages have changed to update the SoupSession accordingly.

* NetworkProcess/NetworkProcess.h: Add
userPreferredLanguagesChanged when using soup network backend.
* NetworkProcess/NetworkProcess.messages.in: Add
UserPreferredLanguagesChanged message when using soup network
backend.
* NetworkProcess/soup/NetworkProcessSoup.cpp:
(WebKit::NetworkProcess::userPreferredLanguagesChanged): Update
the SoupSession to use the given languages.
(WebKit::NetworkProcess::platformInitializeNetworkProcess): Call
userPreferredLanguagesChanged() when initialization parameters
contain languages.
(WebKit::NetworkProcess::allowSpecificHTTPSCertificateForHost):
Remove unnedded WebCore prefix.
(WebKit::NetworkProcess::clearCacheForAllOrigins): Simplify using
a single line.
* Shared/Network/NetworkProcessCreationParameters.cpp:
(WebKit::NetworkProcessCreationParameters::encode): Encode the
languages vector.
(WebKit::NetworkProcessCreationParameters::decode): Decode the
languages vector.
* Shared/Network/NetworkProcessCreationParameters.h:
* UIProcess/WebContext.cpp:
(WebKit::WebContext::languageChanged): Send a message also to the
network process.
* UIProcess/soup/WebContextSoup.cpp:
(WebKit::WebContext::platformInitializeNetworkProcess): Set
languages initial parameter.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[SOUP] SoupNetworkSession::setAcceptLanguages should receive a const reference
carlosgc@webkit.org [Tue, 14 Jan 2014 17:02:24 +0000 (17:02 +0000)]
[SOUP] SoupNetworkSession::setAcceptLanguages should receive a const reference
https://bugs.webkit.org/show_bug.cgi?id=126966

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

We don't really need to modify the Vector just to ignore the C
locale.

* platform/network/soup/SoupNetworkSession.cpp:
(WebCore::buildAcceptLanguages): Rework it to not modify the
passed vector to ignore the C locale when it's present.
(WebCore::SoupNetworkSession::setAcceptLanguages): Use const Vector<String>&.
* platform/network/soup/SoupNetworkSession.h:

Source/WebKit2:

* WebProcess/soup/WebProcessSoup.cpp:
(WebKit::setSoupSessionAcceptLanguage): Use const Vector<String>&.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHTMLMediaElement::potentiallyPlaying can be more simple.
commit-queue@webkit.org [Tue, 14 Jan 2014 16:41:48 +0000 (16:41 +0000)]
HTMLMediaElement::potentiallyPlaying can be more simple.
https://bugs.webkit.org/show_bug.cgi?id=111

Patch by Piotr Grad <p.grad@samsung.com> on 2014-01-14
Reviewed by Eric Carlson.

Tests: No new tests, just refactorings.

Expression is simplified because the first 'if' statement depends on the same condition
as pausedToBuffer value.

* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::parseAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove deprecated DeferrableOneShotTimer constructor.
akling@apple.com [Tue, 14 Jan 2014 16:29:51 +0000 (16:29 +0000)]
Remove deprecated DeferrableOneShotTimer constructor.
<https://webkit.org/b/126984>

Source/WebCore:

Remove the deprecated constructor for callback functions that take
the timer by pointer instead of by reference.

This shrinks DeferrableOneShotTimer by 8 bytes.

Reviewed by Anders Carlsson.

* platform/Timer.h:
(WebCore::DeferrableOneShotTimer::DeferrableOneShotTimer):

Source/WebKit2:

Reviewed by Anders Carlsson.

* WebProcess/Plugins/PluginView.h:
* WebProcess/Plugins/PluginView.cpp:
(WebKit::PluginView::pluginSnapshotTimerFired):

    Take the timer by reference so we can use the new constructor.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake CachedSVGDocument independent of CSS Filters
krit@webkit.org [Tue, 14 Jan 2014 15:58:22 +0000 (15:58 +0000)]
Make CachedSVGDocument independent of CSS Filters
https://bugs.webkit.org/show_bug.cgi?id=126133

Reviewed by Antti Koivisto.

Clean-up the pendingSVGDocuments code in StyleResolver.
CachedSVGDocumentReference is responsible for requesting the
SVG document instead of WebKitCSSSVGDocumentValue.
CachedSVGDocumentReference can be used by other SVG resource like
clip-path and mask now so that these may load external resources
as well.
WebKitCSSSVGDocumentValue does not provide any further value
and will be removed in the next patch.

Refactoring, no new test cases.

* css/StyleResolver.cpp:
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::createFilterOperations):
* css/StyleResolver.h: Replace Map with a Set.
(WebCore::StyleResolver::State::pendingSVGDocuments): Use the Set from now on.
* loader/cache/CachedSVGDocumentReference.cpp:
(WebCore::CachedSVGDocumentReference::CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::~CachedSVGDocumentReference):
(WebCore::CachedSVGDocumentReference::load):
* loader/cache/CachedSVGDocumentReference.h: Is responsible for
    requesting the SVG document.
(WebCore::CachedSVGDocumentReference::create):
(WebCore::CachedSVGDocumentReference::loadRequested):
* platform/graphics/filters/FilterOperation.cpp:
(WebCore::ReferenceFilterOperation::createCachedSVGDocumentReference):
* platform/graphics/filters/FilterOperation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[ATK] AXChildrenChanged notification handling is a performance black hole
mario.prada@samsung.com [Tue, 14 Jan 2014 15:45:32 +0000 (15:45 +0000)]
[ATK] AXChildrenChanged notification handling is a performance black hole
https://bugs.webkit.org/show_bug.cgi?id=126970

Reviewed by Gustavo Noronha Silva.

Source/WebCore:

Remove code that is causing a huge performance problem when
loading big pages, just to be able to emit the children-changed:add
signal at the exact time a child is added.

This removal does not imply that the signal won't be ever emitted,
just that it will be emitted a bit later (when the new child is
asynchronously added to the tree), which should be good enough
anyway for Accessible Technologies, without impacting perfformance
in such a negative way.

* accessibility/atk/AXObjectCacheAtk.cpp:
(WebCore::AXObjectCache::postPlatformNotification): Removed
extremely expensive referring loop when AXChildrenChanged is received.

LayoutTests:

Because of the removal of the referring test when
AXChildrenChanged is received, the children-changed:add signal is
now emitted later, so we need to reorder the expectations.

* accessibility/children-changed-sends-notification-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade...
commit-queue@webkit.org [Tue, 14 Jan 2014 15:41:32 +0000 (15:41 +0000)]
Source/WebCore: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied. Turns out the problem was
the blending parameter not being passed to WebCore::CrossfadeGeneratedImage::draw

https://bugs.webkit.org/show_bug.cgi?id=126887

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-crossfade-image.html

* platform/graphics/CrossfadeGeneratedImage.cpp:
(WebCore::CrossfadeGeneratedImage::draw): set blendMode on context.

LayoutTests: [CSS Background Blending] Background layer with -webkit-cross-fade doesn't blend
when having -webkit-background-blending applied.

https://bugs.webkit.org/show_bug.cgi?id=126887
Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.

* css3/compositing/background-blend-mode-crossfade-image-expected.html: Added.
* css3/compositing/background-blend-mode-crossfade-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Background-blend-mode doesn't work for an element with an
commit-queue@webkit.org [Tue, 14 Jan 2014 15:38:26 +0000 (15:38 +0000)]
Source/WebCore: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
The problem consisted in the drawing path using the default
blending parameter at all times.
https://bugs.webkit.org/show_bug.cgi?id=118894

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.

Test: css3/compositing/background-blend-mode-data-uri-svg-image.html

* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer): Pass blendMode to Image::drawPattern.
* svg/graphics/SVGImage.h: Add a blendMode parameter to drawPatternForContainer.
* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern): Pass blendMode to drawPatternForContainer call.

LayoutTests: Background-blend-mode doesn't work for an element with an
SVG image as background and border-style or padding set.
https://bugs.webkit.org/show_bug.cgi?id=118894

Patch by Mihai Tica <mitica@adobe.com> on 2014-01-14
Reviewed by Dirk Schulze.

* css3/compositing/background-blend-mode-data-uri-svg-image-expected.html: Added.
* css3/compositing/background-blend-mode-data-uri-svg-image.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove accidentally added PLATFORM(QT) from Source/WebCore/editing/EditorCommand...
commit-queue@webkit.org [Tue, 14 Jan 2014 15:35:49 +0000 (15:35 +0000)]
Remove accidentally added PLATFORM(QT) from Source/WebCore/editing/EditorCommand.cpp after r161638
https://bugs.webkit.org/show_bug.cgi?id=126980

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Andreas Kling.

* editing/EditorCommand.cpp:
(WebCore::createCommandMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] FTL buildfix, add missing includes
commit-queue@webkit.org [Tue, 14 Jan 2014 15:20:19 +0000 (15:20 +0000)]
[EFL] FTL buildfix, add missing includes
https://bugs.webkit.org/show_bug.cgi?id=126641

Patch by Peter Molnar <pmolnar.u-szeged@partner.samsung.com> on 2014-01-14
Reviewed by Csaba Osztrogonác.

* ftl/FTLOSREntry.cpp:
* ftl/FTLOSRExitCompiler.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] Test dynamic change of position for fixed element in named flow
mihnea@adobe.com [Tue, 14 Jan 2014 15:13:13 +0000 (15:13 +0000)]
[CSSRegions] Test dynamic change of position for fixed element in named flow
https://bugs.webkit.org/show_bug.cgi?id=126807

Reviewed by Dirk Schulze.

* fast/regions/fixed-in-named-flow-position-changed-expected.html: Added.
* fast/regions/fixed-in-named-flow-position-changed.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSSRegions] The list of fixed positioned layers in named flows should be sorted...
mihnea@adobe.com [Tue, 14 Jan 2014 14:51:03 +0000 (14:51 +0000)]
[CSSRegions] The list of fixed positioned layers in named flows should be sorted by z-index
https://bugs.webkit.org/show_bug.cgi?id=126978

Reviewed by Antti Koivisto.

Return the list of fixed positioned layers sorted by z-index from
FlowThreadController::collectFixedPositionedLayers instead of manually sort it
every time we need it (RenderLayer::paintFixedLayersInNamedFlows, RenderLayer::hitTestFixedLayersInNamedFlows).
Refactoring covered by existing regions tests.

* rendering/FlowThreadController.cpp:
(WebCore::compareZIndex):
(WebCore::FlowThreadController::collectFixedPositionedLayers):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintFixedLayersInNamedFlows):
(WebCore::RenderLayer::hitTestFixedLayersInNamedFlows):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
rego@igalia.com [Tue, 14 Jan 2014 14:20:22 +0000 (14:20 +0000)]
Unreviewed GTK gardening.

Added missing baselines for some regions tests.

* platform/gtk/TestExpectations: Unskip tests as new baselines have been added.
* platform/gtk/fast/regions/multiple-directionality-changes-in-variable-width-regions-expected.txt: Added.
* platform/gtk/fast/regions/region-dynamic-after-before-expected.txt: Added.
* platform/gtk/fast/regions/region-generated-content-before-after-expected.txt: Added.
* platform/gtk/fast/regions/repaint/japanese-rl-selection-repaint-in-regions-expected.txt: Added.
* platform/gtk/fast/regions/repaint/line-flow-with-floats-in-regions-expected.txt: Added.
* platform/gtk/fast/regions/repaint/overflow-flipped-writing-mode-block-in-regions-expected.txt: Added.
* platform/gtk/fast/regions/repaint/region-painting-invalidation-expected.txt: Added.
* platform/gtk/fast/regions/repaint/region-painting-via-layout-expected.txt: Added.
* platform/gtk/fast/regions/text-region-split-small-pagination-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPack ResourceLoaderOptions harder.
akling@apple.com [Tue, 14 Jan 2014 13:26:19 +0000 (13:26 +0000)]
Pack ResourceLoaderOptions harder.
<https://webkit.org/b/126972>

Make all ResourceLoaderOptions members bitfields to reduce padding,
shrinking it from 28 to 4 bytes.

Reviewed by Antti Koivisto.

* loader/ResourceLoaderOptions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed GTK gardening.
rego@igalia.com [Tue, 14 Jan 2014 13:14:31 +0000 (13:14 +0000)]
Unreviewed GTK gardening.

Added missing baselines for some regions tests.

* platform/gtk/fast/regions/auto-size/autoheight-regions-mark-expected.txt: Added.
* platform/gtk/fast/regions/flows-dependency-dynamic-remove-expected.txt: Added.
* platform/gtk/fast/regions/flows-dependency-same-flow-expected.txt: Added.
* platform/gtk/fast/regions/iframe-html-collected-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Parse Valgrind xml leak files
brian.holt@samsung.com [Tue, 14 Jan 2014 11:51:22 +0000 (11:51 +0000)]
[GTK] Parse Valgrind xml leak files
https://bugs.webkit.org/show_bug.cgi?id=119446

Reviewed by Alejandro G. Castro.

Parse the xml files generated by Valgrind to yield useful
information about the memory leaks.

* Scripts/webkitpy/port/gtk.py:
(GtkPort.__init__):
(GtkPort.setup_test_run): Clear the previous output files before new
run.
(GtkPort.print_leaks_summary):

* Scripts/webkitpy/port/leakdetector_valgrind.py: Added.
Parse the xml files generated by Valgrind and summarise leaks
into an easily understandable list.
(get_text_of):
(get_CDATA_of):
(gather_frames):
(ValgrindError):
(ValgrindError.__init__):
(ValgrindError.__str__):
(ValgrindError.unique_string):
(ValgrindError.error_hash):
(ValgrindError.__hash__):
(ValgrindError.__eq__):
(LeakDetectorValgrind):
(LeakDetectorValgrind.__init__):
(LeakDetectorValgrind._parse_leaks_output):
(LeakDetectorValgrind.leaks_files_in_results_directory):
(LeakDetectorValgrind.clean_leaks_files_from_results_directory):
(LeakDetectorValgrind.parse_and_print_leaks_detail):

* Scripts/webkitpy/port/leakdetector_valgrind_unittest.py: Added.
(make_mock_valgrind_output):
(make_mock_incomplete_valgrind_output):
(make_mock_valgrind_results):
(make_mock_valgrind_results_incomplete):
(make_mock_valgrind_results_empty):
(make_mock_valgrind_results_misformatted):
(mock_run_cppfilt_command):
(LeakDetectorValgrindTest):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_pass):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_incomplete):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_empty):
(LeakDetectorValgrindTest.test_parse_and_print_leaks_detail_misformatted):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPack ResourceError harder.
akling@apple.com [Tue, 14 Jan 2014 10:39:08 +0000 (10:39 +0000)]
Pack ResourceError harder.
<https://webkit.org/b/126969>

Re-arrange the members of ResourceError to reduce padding,
shrinking it by 8 bytes.

Reviewed by Antti Koivisto.

* platform/network/ResourceErrorBase.h:
(WebCore::ResourceErrorBase::ResourceErrorBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPack RenderLayer harder.
akling@apple.com [Tue, 14 Jan 2014 10:35:35 +0000 (10:35 +0000)]
Pack RenderLayer harder.
<https://webkit.org/b/126967>

Re-arrange the members of ScrollableArea a bit so that RenderLayer
can combine its bitfields with the ones in ScrollableArea.
This makes RenderLayer fit into a snugger size class, saving 32 bytes
per layer.

296 kB progression on Membuster3.

Reviewed by Antti Koivisto.

* platform/ScrollableArea.cpp:
* platform/ScrollableArea.h:

    Put bitfield members at the end of ScrollableArea so inheriting
    classes can synergize with the padding.

* rendering/RenderLayer.h:

    Make m_blendMode a bitfield to avoid bloating the class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: RemoteInspector::updateDebuggable may miss a push
commit-queue@webkit.org [Tue, 14 Jan 2014 08:35:40 +0000 (08:35 +0000)]
Web Inspector: RemoteInspector::updateDebuggable may miss a push
https://bugs.webkit.org/show_bug.cgi?id=126965

Patch by Joseph Pecoraro <pecoraro@apple.com> on 2014-01-14
Reviewed by Timothy Hatcher.

* inspector/remote/RemoteInspector.mm:
(Inspector::RemoteInspector::updateDebuggable):
Always push an update. If a debuggable went from allowed to
not allowed, we would have missed pushing an update.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMake spelling tests added in r141354 to be able to run asynchronously
g.czajkowski@samsung.com [Tue, 14 Jan 2014 07:48:38 +0000 (07:48 +0000)]
Make spelling tests added in r141354 to be able to run asynchronously
https://bugs.webkit.org/show_bug.cgi?id=126895

Reviewed by Ryosuke Niwa.

As we started running spelling tests asynchronously, invoke 'finishJSTest()'
when all operations are completed, for example, required spelling markers have appeared.
It might happen later then during 'initSpellTest'  testing callback.

Due to the tests perform other checks that do not affect expectation order (selection,
context menu suggestion items), the asynchronous operations were pushed back to the end of
the tests to be sure that those won't break expectation order.

* editing/spelling/context-menu-suggestions-multiword-selection-expected.txt:
* editing/spelling/context-menu-suggestions-multiword-selection.html:
* editing/spelling/context-menu-suggestions-subword-selection-expected.txt:
* editing/spelling/context-menu-suggestions-subword-selection.html:
* editing/spelling/resources/util.js:
* editing/spelling/spelling-changed-text-expected.txt:
* editing/spelling/spelling-changed-text.html:
* editing/spelling/spelling-double-clicked-word-expected.txt:
* editing/spelling/spelling-double-clicked-word.html:
* editing/spelling/spelling-exactly-selected-word-expected.txt:
* editing/spelling/spelling-exactly-selected-word.html:

* editing/spelling/spelling-with-whitespace-selection-expected.txt:
* editing/spelling/spelling-with-whitespace-selection.html:
* editing/spelling/spelling-with-punctuation-selection-expected.txt:
* editing/spelling/spelling-with-punctuation-selection.html:
Additionally fix description format and get rid of context click, needless after r148282.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS WebCore build fixes
timothy_horton@apple.com [Tue, 14 Jan 2014 07:15:58 +0000 (07:15 +0000)]
iOS WebCore build fixes

Add WebKit and WebKit2 as allowable clients of WebCore.

* Configurations/WebCore.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS WebKit2 build fixes, part 1
timothy_horton@apple.com [Tue, 14 Jan 2014 07:02:46 +0000 (07:02 +0000)]
iOS WebKit2 build fixes, part 1

* WebCore.xcodeproj/project.pbxproj:
Move some headers to 'private', from 'project'.
* Configurations/WebKit2.xcconfig:
* NetworkProcess/NetworkResourceLoader.cpp:
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/RemoteNetworkingContext.h:
* Shared/WebEventConversion.h:
* UIProcess/API/ios/WKGeolocationProviderIOS.mm:
* UIProcess/API/ios/WKInteractionView.mm:
(-[WKTextPosition isEqual:]):
* UIProcess/API/ios/WKViewIOS.mm: Renamed from Source/WebKit2/UIProcess/API/ios/WKView.mm.
* UIProcess/ios/WebPageProxyIOS.mm:
* UIProcess/ios/WebProcessProxyIOS.mm:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/ios/WebPageIOS.mm:
(WebKit::WebPage::elementDidFocus):
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate the LLINT CLoop Bot build infrastructure
lforschler@apple.com [Tue, 14 Jan 2014 06:58:01 +0000 (06:58 +0000)]
Update the LLINT CLoop Bot build infrastructure
https://bugs.webkit.org/show_bug.cgi?id=126604

Unreviewed.

* BuildSlaveSupport/build.webkit.org-config/config.json:
* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(CompileLLINTCLoop):
(RunLLINTCLoopTests):
(BuildAndTestLLINTCLoopFactory):
(BuildAndTestLLINTCLoopFactory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Disable failing API tests
jinwoo7.song@samsung.com [Tue, 14 Jan 2014 06:54:22 +0000 (06:54 +0000)]
[EFL][WK2] Disable failing API tests
https://bugs.webkit.org/show_bug.cgi?id=126960

Reviewed by Gyuyoung Kim.

Source/WebKit2:

Disable color picker test until bug 119120 is resolved.

* UIProcess/API/efl/tests/test_ewk2_color_picker.cpp:
(TEST_F):

Tools:

Disable WKViewUserViewportToContents test until bug 126261 is resolved.

* TestWebKitAPI/Tests/WebKit2/CoordinatedGraphics/WKViewUserViewportToContents.cpp:
(TestWebKitAPI::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r161907.
commit-queue@webkit.org [Tue, 14 Jan 2014 06:06:40 +0000 (06:06 +0000)]
Unreviewed, rolling out r161907.
http://trac.webkit.org/changeset/161907
https://bugs.webkit.org/show_bug.cgi?id=126963

fast/canvas/webgl/webgl-compressed-texture-size-limit.html
fails on many bots (Requested by ap on #webkit).

Source/WebCore:

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel):

LayoutTests:

* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils):
* fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Removed.
* fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoLayout Test plugins/plugin-document-load-prevented-userscript.html is flaky
ap@apple.com [Tue, 14 Jan 2014 05:57:20 +0000 (05:57 +0000)]
Layout Test plugins/plugin-document-load-prevented-userscript.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=126962

* platform/mac-wk2/TestExpectations: Marking as such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix typedef of DragDataRef from id back to id<NSDraggingInfo>
ddkilzer@apple.com [Tue, 14 Jan 2014 05:16:28 +0000 (05:16 +0000)]
Fix typedef of DragDataRef from id back to id<NSDraggingInfo>
<http://webkit.org/b/126958>
<rdar://problem/14814649>

Reviewed by Mark Rowe.

* WebCore.exp.in: Export different symbols based on
__has_feature(objc_protocol_qualifier_mangling) since clang
mangles the type differently with that change.

* platform/DragData.h:
* platform/mac/DragDataMac.mm:
(WebCore::DragData::DragData):
- Revert r154493 by switching back to id<NSDraggingInfo>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] ewk_view_page_contents_get() API test is failing
jinwoo7.song@samsung.com [Tue, 14 Jan 2014 05:07:32 +0000 (05:07 +0000)]
[EFL][WK2] ewk_view_page_contents_get() API test is failing
https://bugs.webkit.org/show_bug.cgi?id=126957

Reviewed by Gyuyoung Kim.

As the day in 'Date' field may be one digit or two digit,
the data length may also be varied by one byte.

* UIProcess/API/efl/tests/test_ewk2_view.cpp:
(EWK2ViewTest::PageContentsAsMHTMLCallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r161939.
commit-queue@webkit.org [Tue, 14 Jan 2014 03:59:08 +0000 (03:59 +0000)]
Unreviewed, rolling out r161939.
http://trac.webkit.org/changeset/161939
https://bugs.webkit.org/show_bug.cgi?id=126956

didn't work with mac, of course (Requested by thorton on
#webkit).

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj:

Source/WebKit2:

* NetworkProcess/NetworkResourceLoader.cpp:
* NetworkProcess/NetworkResourceLoader.h:
* NetworkProcess/RemoteNetworkingContext.h:
* Shared/WebEventConversion.h:
* UIProcess/API/ios/WKGeolocationProviderIOS.mm:
* UIProcess/API/ios/WKInteractionView.mm:
(-[WKTextPosition isEqual:]):
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate WebPageProxyIOS's user agent string
benjamin@webkit.org [Tue, 14 Jan 2014 03:52:09 +0000 (03:52 +0000)]
Update WebPageProxyIOS's user agent string
https://bugs.webkit.org/show_bug.cgi?id=126933

Patch by Benjamin Poulain <bpoulain@apple.com> on 2014-01-13
Reviewed by Darin Adler.

* UIProcess/ios/WebPageProxyIOS.mm:
(WebKit::WebPageProxy::standardUserAgent):
Send a more reasonable user agent. The previous one was forcing
iOS 5.1's iPad user-agent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoiOS WebKit2 build fixes
timothy_horton@apple.com [Tue, 14 Jan 2014 03:35:51 +0000 (03:35 +0000)]
iOS WebKit2 build fixes

* NetworkProcess/NetworkResourceLoader.cpp:
* NetworkProcess/NetworkResourceLoader.h:
Introduce/clarify some confusion about CFNETWORK vs. PLATFORM(IOS).

* NetworkProcess/RemoteNetworkingContext.h:
* WebProcess/WebCoreSupport/mac/WebFrameNetworkingContext.h:
Get rid of an override of something that doesn't exist anymore.

* WebKit2.xcodeproj/project.pbxproj:
Add some files. It's likely there are more missing, but this is a start.

* Shared/WebEventConversion.h:
* WebProcess/WebPage/WebPage.h:
Use WebKitAdditions.

* UIProcess/API/ios/WKGeolocationProviderIOS.mm:
Something bizarre is happening with internal deprecation warnings.

* UIProcess/API/ios/WKInteractionView.mm:
(-[WKTextPosition isEqual:]):
Fix a typo.

* WebProcess/WebPage/mac/RemoteLayerTreeDrawingArea.h:
Remove an override of something that doesn't exist anymore.

* WebCore.xcodeproj/project.pbxproj:
Make some headers private instead of project for WK2's use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the Mac build. WebViewPrivate.h declares quickLookContentForURL:
simon.fraser@apple.com [Tue, 14 Jan 2014 02:41:08 +0000 (02:41 +0000)]
Fix the Mac build. WebViewPrivate.h declares quickLookContentForURL:
for iOS, but the implementation conditionalizes on USE(QUICK_LOOK),
which we are confused about.

* WebView/WebView.mm:
(-[WebView quickLookContentForURL:]):
* WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: Make NetworkStateNotifier.h a private header, needed by iOS.
simon.fraser@apple.com [Tue, 14 Jan 2014 02:10:09 +0000 (02:10 +0000)]
Source/WebCore: Make NetworkStateNotifier.h a private header, needed by iOS.

* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/mac: Fix the remaining compiler errors in iOS WK1.

* WebView/WebFrame.mm:
(vectorForDictationPhrasesArray): Need this function on iOS.
(-[WebFrame setSelectedDOMRange:affinity:closeTyping:]): We're already inside
a huge if PLATFORM(IOS) block.
(-[WebFrame resetTextAutosizingBeforeLayout]): Document now exposes RenderView.
* WebView/WebFrameInternal.h: Declare vectorForDictationPhrasesArray() (not a good place for it!)
* WebView/WebView.mm: #import cleanup for iOS.
(-[WebView initSimpleHTMLDocumentWithStyle:frame:preferences:groupName:]): Declare autoStartRemoteInspector
here but this needs cleaning up (<rdar://problem/15810991>).
(-[WebView setHostApplicationBundleId:name:]): No [WebView sharedWebInspectorServer] any more.
(-[WebView _didCommitLoadForFrame:]): Ditto.
* WebView/WebViewData.h: Add allowsRemoteInspection.
* WebView/WebViewData.mm: Initialize allowsRemoteInspection
(-[WebViewPrivate init]):
* WebView/WebViewPrivate.h: Fumbled #ifdef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r161916.
commit-queue@webkit.org [Tue, 14 Jan 2014 02:02:34 +0000 (02:02 +0000)]
Unreviewed, rolling out r161916.
http://trac.webkit.org/changeset/161916
https://bugs.webkit.org/show_bug.cgi?id=126952

it is a lie - still fails on some configs (Requested by dino
on #webkit).

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Do not store reference variables as a pointer in private data structure
ryuan.choi@samsung.com [Tue, 14 Jan 2014 01:42:44 +0000 (01:42 +0000)]
[EFL] Do not store reference variables as a pointer in private data structure
https://bugs.webkit.org/show_bug.cgi?id=126945

Reviewed by Gyuyoung Kim.

Remove pageSettings, mainFrame and storageSession variables from Ewk_View_Private_Data.

* ewk/ewk_view.cpp:
(_ewk_view_priv_new):
(_ewk_view_smart_add):
(_ewk_view_smart_repaints_process):
(_ewk_view_smart_calculate):
(ewk_view_fixed_layout_size_set):
(ewk_view_fixed_layout_size_get):
(ewk_view_bg_color_set):
(ewk_view_setting_user_agent_set):
(ewk_view_setting_user_stylesheet_set):
(ewk_view_setting_auto_load_images_set):
(ewk_view_setting_auto_shrink_images_set):
(ewk_view_setting_enable_scripts_set):
(ewk_view_setting_enable_plugins_set):
(ewk_view_setting_enable_frame_flattening_set):
(ewk_view_setting_scripts_can_open_windows_set):
(ewk_view_setting_scripts_can_close_windows_set):
(ewk_view_setting_scripts_can_access_clipboard_set):
(ewk_view_setting_resizable_textareas_set):
(ewk_view_setting_private_browsing_set):
(ewk_view_setting_application_cache_set):
(ewk_view_setting_caret_browsing_set):
(ewk_view_setting_encoding_default_set):
(ewk_view_setting_encoding_detector_set):
(ewk_view_setting_enable_developer_extras_set):
(ewk_view_setting_font_minimum_size_set):
(ewk_view_setting_font_minimum_logical_size_set):
(ewk_view_setting_font_default_size_set):
(ewk_view_setting_font_monospace_size_set):
(ewk_view_font_family_name_set):
(ewk_view_setting_spatial_navigation_set):
(ewk_view_setting_local_storage_set):
(ewk_view_setting_page_cache_set):
(ewk_view_setting_local_storage_database_path_set):
(ewk_view_setting_minimum_timer_interval_set):
(ewk_view_setting_enable_webgl_set):
(ewk_view_setting_enable_hyperlink_auditing_set):
(ewk_view_setting_allow_universal_access_from_file_urls_set):
(ewk_view_setting_allow_file_access_from_file_urls_set):
(ewk_view_layout_if_needed_recursive):
(ewk_view_paint):
(ewk_view_paint_contents):
(ewk_view_js_object_add):
(ewk_view_page_rect_get):
(ewk_view_soup_session_get):
(ewk_view_soup_session_set):
(ewk_view_setting_enable_xss_auditor_set):
(ewk_view_setting_should_display_captions_set):
(ewk_view_setting_should_display_subtitles_set):
(ewk_view_setting_should_display_text_descriptions_set):
(ewk_view_setting_enable_fullscreen_set):
(ewk_view_setting_tiled_backing_store_enabled_set):
(ewk_view_setting_tiled_backing_store_enabled_get):
(ewk_view_tiled_backing_store_invalidate):
(EWKPrivate::storageSession):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMore work towards getting iOS WK1 building.
simon.fraser@apple.com [Tue, 14 Jan 2014 01:27:57 +0000 (01:27 +0000)]
More work towards getting iOS WK1 building.

Source/WebCore:

Some more Private headers for iOS.

* WebCore.xcodeproj/project.pbxproj:

Source/WebKit/ios:

* WebCoreSupport/WebFrameIOS.mm:
(-[WebFrame imageForNode:allowDownsampling:drawContentBehindTransparentNodes:]): Stub out this
function, since it should use recently-refactored node snapshotting code. Covered by <rdar://problem/15808709>.

Source/WebKit/mac:

* DOM/WebDOMOperations.mm: Need RenderObject.h.
* DOM/WebDOMOperationsPrivate.h:
* History/WebBackForwardList.mm: Need Foundation/NSGeometry.h for NSRect
(-[WebBackForwardList dictionaryRepresentation]): Fix array iteration to match
other code.
* Misc/WebIconDatabase.h: #ifdef out functions that return NSImages.
* Plugins/WebPluginController.mm: Need <WebCore/AudioSession.h>
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::transitionToCommittedForNewPage): Some new code to
handle the error case.
* WebView/WebFrameView.mm: Avoid including some headers which pull in AppKit classes.
* WebView/WebHTMLView.mm: Ditto.
(-[WebHTMLView selectionImageForcingBlackText:selectionImageForcingBlackText:]): Handle
different return type of createDragImageForSelection().
* WebView/WebPolicyDelegatePrivate.h:
* WebView/WebPreferences.mm: <WebCore/AudioSession.h> and <AudioToolbox/AudioSession.h>

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix for Win64.
alex.christensen@flexsim.com [Tue, 14 Jan 2014 01:13:02 +0000 (01:13 +0000)]
Unreviewed build fix for Win64.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in:
Corrected 64-bit linker symbols.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Build Fix: Don't build the 'All-iOS' target on iOS. Just use 'All'.
aestes@apple.com [Tue, 14 Jan 2014 01:09:21 +0000 (01:09 +0000)]
[iOS] Build Fix: Don't build the 'All-iOS' target on iOS. Just use 'All'.

* Makefile:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening. Rebaselining after r161669.
jinwoo7.song@samsung.com [Tue, 14 Jan 2014 01:05:17 +0000 (01:05 +0000)]
Unreviewed EFL gardening. Rebaselining after r161669.

* platform/efl/css3/masking/clip-path-circle-border-box-expected.png: Added.
* platform/efl/css3/masking/clip-path-circle-border-box-expected.txt: Added.
* platform/efl/css3/masking/clip-path-circle-bounding-box-expected.png: Added.
* platform/efl/css3/masking/clip-path-circle-bounding-box-expected.txt: Added.
* platform/efl/css3/masking/clip-path-circle-content-box-expected.png: Added.
* platform/efl/css3/masking/clip-path-circle-content-box-expected.txt: Added.
* platform/efl/css3/masking/clip-path-circle-margin-box-expected.png: Added.
* platform/efl/css3/masking/clip-path-circle-margin-box-expected.txt: Added.
* platform/efl/css3/masking/clip-path-circle-padding-box-expected.png: Added.
* platform/efl/css3/masking/clip-path-circle-padding-box-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoHighlighting password field then making a Sticky Note via Safari Services exposes...
mmaxfield@apple.com [Tue, 14 Jan 2014 01:02:15 +0000 (01:02 +0000)]
Highlighting password field then making a Sticky Note via Safari Services exposes password
https://bugs.webkit.org/show_bug.cgi?id=126946

Reviewed by Enrica Casucci.

Using the Services menu has a slightly different codepath than Editor::copy() does. This
patch duplicates the canCopy() check that Editor::copy() does.

Testing is not possible because the Services menu is not accessible to our tests.

* editing/mac/EditorMac.mm:
(WebCore::Editor::stringSelectionForPasteboard):
(WebCore::Editor::stringSelectionForPasteboardWithImageAltText):
(WebCore::Editor::dataSelectionForPasteboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WebGL] Crash due to forceLostContext
bfulgham@apple.com [Tue, 14 Jan 2014 01:00:54 +0000 (01:00 +0000)]
[WebGL] Crash due to forceLostContext
https://bugs.webkit.org/show_bug.cgi?id=126947

Reviewed by Dean Jackson.

Covered by webgl/conformance/textures/origin-clean-conformance.html.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::isContextLost): Make const.
(WebCore::WebGLRenderingContext::platformLayer): Don't attempt to use
a lost context.
* html/canvas/WebGLRenderingContext.h: isContextLost should be const.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed EFL gardening. Rebaseline after r161696.
jinwoo7.song@samsung.com [Tue, 14 Jan 2014 00:53:01 +0000 (00:53 +0000)]
Unreviewed EFL gardening. Rebaseline after r161696.

* platform/efl/css1/text_properties/word_spacing-expected.png:
* platform/efl/css1/text_properties/word_spacing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMake] Mark all dependency include paths and libraries as advanced variables
mrobinson@webkit.org [Tue, 14 Jan 2014 00:43:32 +0000 (00:43 +0000)]
[CMake] Mark all dependency include paths and libraries as advanced variables
https://bugs.webkit.org/show_bug.cgi?id=126504

Reviewed by Daniel Bates.

.:

* Source/cmake/FindATK.cmake: Mark result variable as advanced.
* Source/cmake/FindCairo.cmake: Ditto.
* Source/cmake/FindEGL.cmake: Ditto.
* Source/cmake/FindEnchant.cmake: Ditto.
* Source/cmake/FindGLIB.cmake: Ditto.
* Source/cmake/FindGStreamer.cmake: Ditto.
* Source/cmake/FindHarfBuzz.cmake: Ditto.
* Source/cmake/FindLibSoup.cmake: Ditto.

Source/WebKit2:

* CMakeLists.txt: Mark the LIBRT_LIBRARIES variable as advanced.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][CMake] Add a 'check' target
mrobinson@webkit.org [Tue, 14 Jan 2014 00:42:25 +0000 (00:42 +0000)]
[GTK][CMake] Add a 'check' target
https://bugs.webkit.org/show_bug.cgi?id=126770

Reviewed by Daniel Bates.

* Source/PlatformGTK.cmake: Add a 'check' target that calls run-gtk-tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][CMake] WebCorePlatform build can sometimes fail due to missing generated headers
mrobinson@webkit.org [Tue, 14 Jan 2014 00:38:45 +0000 (00:38 +0000)]
[GTK][CMake] WebCorePlatform build can sometimes fail due to missing generated headers
https://bugs.webkit.org/show_bug.cgi?id=126911

Reviewed by Daniel Bates.

* PlatformGTK.cmake: Add an explicit dependency from WebCorePlatform to WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK][CMake] Circular dependency in generation of WebKitEnumTypes.h
mrobinson@webkit.org [Tue, 14 Jan 2014 00:37:11 +0000 (00:37 +0000)]
[GTK][CMake] Circular dependency in generation of WebKitEnumTypes.h
https://bugs.webkit.org/show_bug.cgi?id=126912

Reviewed by Daniel Bates.

* PlatformGTK.cmake: Remove the circular dependency by generating WebKitEnumTypes.h with
all installed headers except for WebKitEnumTypes.h itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Exclude shims and PluginProcess.app from the WebKit2 build
aestes@apple.com [Tue, 14 Jan 2014 00:33:35 +0000 (00:33 +0000)]
[iOS] Exclude shims and PluginProcess.app from the WebKit2 build
https://bugs.webkit.org/show_bug.cgi?id=126936

Reviewed by Daniel Bates.

* Configurations/All.xcconfig: Added. Excluded PluginProcess.app from
being copied into WebKit2.framework on iOS.
* Configurations/NetworkProcess.xcconfig: Excluded SecItemShim.dylib
from being copied into NetworkProcess.app on iOS.
* Configurations/PluginProcess.xcconfig: Excluded
PluginProcessShim.dylib from being copied into PluginProcess.app and
set SKIP_INSTALL to YES on iOS.
* Configurations/PluginProcessShim.xcconfig: Added. Linked the shim
against necessary frameworks on Mac.
* Configurations/SecItemShim.xcconfig: Ditto.
* Configurations/WebProcessShim.xcconfig: Ditto.
* Configurations/WebContentProcess.xcconfig: Excluded
WebProcessShim.dylib from being copied into WebProcess.app on iOS.
* PluginProcess/mac/PluginProcessShim.mm: Added #if !PLATFORM(IOS) guards.
* Shared/mac/CookieStorageShimLibrary.cpp: Ditto.
* WebProcess/mac/SecItemShimLibrary.mm: Ditto.
* WebKit2.xcodeproj/project.pbxproj: Removed Mac-only frameworks from
the shims' 'Link Binary with Libraries' build phases. Added new xcconfigs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUse the Selector Code Generator for resolving style
benjamin@webkit.org [Tue, 14 Jan 2014 00:27:49 +0000 (00:27 +0000)]
Use the Selector Code Generator for resolving style
https://bugs.webkit.org/show_bug.cgi?id=126199

Reviewed by Ryosuke Niwa.

* css/ElementRuleCollector.cpp:
(WebCore::ElementRuleCollector::ruleMatches):
* css/RuleSet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed gardening. Unskipping WebGL 1.0.2/conformance/ogles/GL/build/build_009_to_...
dino@apple.com [Tue, 14 Jan 2014 00:14:23 +0000 (00:14 +0000)]
Unreviewed gardening. Unskipping WebGL 1.0.2/conformance/ogles/GL/build/build_009_to_016.html
It now passes.

* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed
jinwoo7.song@samsung.com [Tue, 14 Jan 2014 00:02:55 +0000 (00:02 +0000)]
[EFL][WK2] Replace usage of DEFINE_STATIC_LOCAL with NeverDestroyed
https://bugs.webkit.org/show_bug.cgi?id=126882

Reviewed by Gyuyoung Kim.

* Shared/efl/ProcessExecutablePathEfl.cpp:
(WebKit::executablePathOfWebProcess):
(WebKit::executablePathOfPluginProcess):
(WebKit::executablePathOfNetworkProcess):
* UIProcess/API/efl/EwkView.cpp:
(wkPageToEvasObjectMap):
* UIProcess/API/efl/ewk_context.cpp:
(contextMap):
* UIProcess/API/efl/ewk_page_group.cpp:
(pageGroupMap):
* UIProcess/efl/TextCheckerClientEfl.cpp:
(TextCheckerClientEfl::instance):
* UIProcess/efl/TextCheckerClientEfl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPerformance regression on dromaeo due to generational marking
mhahnenberg@apple.com [Mon, 13 Jan 2014 23:50:58 +0000 (23:50 +0000)]
Performance regression on dromaeo due to generational marking
https://bugs.webkit.org/show_bug.cgi?id=126901

Reviewed by Oliver Hunt.

We were seeing some performance regression with ENABLE_GGC == 0, so this patch
ifdefs out more things to get rid of the additional overhead.

* heap/Heap.cpp:
(JSC::Heap::markRoots):
(JSC::Heap::writeBarrier):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::clearMarksWithCollectionType):
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::resetAllocators):
* heap/MarkedSpace.h:
(JSC::MarkedSpace::didAllocateInBlock):
* heap/SlotVisitorInlines.h:
(JSC::SlotVisitor::internalAppend):
(JSC::SlotVisitor::reportExtraMemoryUsage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Remove duplicate inclusions of header WAKView.h
dbates@webkit.org [Mon, 13 Jan 2014 23:03:47 +0000 (23:03 +0000)]
[iOS] Remove duplicate inclusions of header WAKView.h
following <http://trac.webkit.org/changeset/161910>

* WebView/WebFrameView.h:
* WebView/WebHTMLView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate the SelectorQuery code using compiled selector after r161196
benjamin@webkit.org [Mon, 13 Jan 2014 22:59:16 +0000 (22:59 +0000)]
Update the SelectorQuery code using compiled selector after r161196
https://bugs.webkit.org/show_bug.cgi?id=126860

Reviewed by Andreas Kling.

Update tree traversal code to the current traversal functions.

* dom/SelectorQuery.cpp:
(WebCore::SelectorDataList::executeCompiledSimpleSelectorChecker):
(WebCore::SelectorDataList::executeCompiledSelectorCheckerWithContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoVarious iOS WebKit1 build fixes.
simon.fraser@apple.com [Mon, 13 Jan 2014 22:55:47 +0000 (22:55 +0000)]
Various iOS WebKit1 build fixes.

Source/WebCore:

* WebCore.xcodeproj/project.pbxproj: iOS WebKit1 needs various
headers to be Private.

Source/WebKit/mac:

* Configurations/WebKit.xcconfig: Add more Mac-only files
to the excluded files list for iOS.
* DefaultDelegates/WebDefaultUIDelegate.m: Don't include WebJavaScriptTextInputPanel.h
on iOS
* History/WebHistory.h: NSCalendarDate doesn't exist on iOS.
* Misc/WebDownload.h: Need WAKAppKitStubs.h
* Misc/WebNSViewExtras.m: No WebNSPasteboardExtras on iOS
* Storage/WebDatabaseManagerClient.mm: Need DatabaseTracker.h, no harm
in including it for all platforms.
* WebCoreSupport/WebEditorClient.h: Remove useless comment.
* WebCoreSupport/WebEditorClient.mm:
(nsStringWithoutCopying): Moved
(WebEditorClient::checkTextOfParagraph): Modernized.
* WebInspector/WebNodeHighlightView.mm: Need FloatQuad.h.
* WebView/WebDataSource.mm: Need WebFrameViewInternal.h
* WebView/WebDocument.h: Needs WAKView.h.
* WebView/WebFrameView.h: Ditto.
* WebView/WebHTMLView.h: Ditto.
* WebView/WebPDFDocumentExtras.mm:
(allScriptsInPDFDocument): No PDFDocument on iOS.
* WebView/WebPolicyDelegate.h:
* WebView/WebView.h: Fix incorrect #if.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMap RootInlineBox to containing region via bit+hashmap.
akling@apple.com [Mon, 13 Jan 2014 22:33:08 +0000 (22:33 +0000)]
Map RootInlineBox to containing region via bit+hashmap.
<https://webkit.org/b/126917>

The vas majority of RootInlineBox objects don't have a containing
RenderRegion, so let's store that in a bit+hashmap configuration
instead of having a dedicated pointer member for it.

148 kB progression on Membuster3.

Reviewed by Antti Koivisto.

* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::InlineFlowBox):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):

    Added m_hasContainingRegion bit.

(WebCore::containingRegionMap):

    Global map between RootInlineBox and RenderRegion.

(WebCore::RootInlineBox::~RootInlineBox):

    Remove self from aforementioned global map if needed.

(WebCore::RootInlineBox::paint):

    Tweak a condition to avoid double hash lookup.

* rendering/RootInlineBox.h:
(WebCore::RootInlineBox::containingRegion):
(WebCore::RootInlineBox::clearContainingRegion):
(WebCore::RootInlineBox::setContainingRegion):

    Store the containing region in a bit+hashmap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] More build fixes for WebKit
dbates@webkit.org [Mon, 13 Jan 2014 22:29:01 +0000 (22:29 +0000)]
[iOS] More build fixes for WebKit

Source/WebKit:

Add iOS-specific logic to build phases: "Symlink WebKitPluginHost in to place" and "Migrate Headers".

* WebKit.xcodeproj/project.pbxproj:

Source/WebKit/mac:

* Configurations/Base.xcconfig: Removed extraneous definition of SUPPORTED_PLATFORMS.
* Configurations/WebKit.xcconfig: Exclude more Mac-specific files when building for iOS:
CarbonUtils.m, CarbonWindowAdapter.mm, CarbonWindowContentView.m, CarbonWindowFrame.m,
HIViewAdapter.m, HIWebView.mm, MailQuirksUserScript.js, OutlookQuirksUserScript.js,
PopupMenuMac.mm, SearchPopupMenuMac.mm, WebClipView.mm, WebInspectorClient.mm,
WebNetscapeContainerCheckContextInfo.mm, WebNetscapeContainerCheckPrivate.mm, WebRenderNode.mm,
WebStringTruncator.mm, and WebTextCompletionController.mm. I haven't verified the Mac-specific
nature of each of these files. We may be able to reduce this list upon further investigation.
* WebView/WebDocument.h: Include header <WebKit/WAKView.h> for definition of WAKView.
* WebView/WebFrameView.h: Ditto.
* WebView/WebUIDelegate.h: Ditto.
* WebView/WebView.h: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSource/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexF...
bfulgham@apple.com [Mon, 13 Jan 2014 22:27:18 +0000 (22:27 +0000)]
Source/WebCore: [WebGL] Invalid range checking in WebGLRenderingContext::validateTexFuncLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

Added fast/canvas/webgl/webgl-compressed-texture-size-limit.html.

* html/canvas/WebGLRenderingContext.cpp:
(WebCore::WebGLRenderingContext::validateTexFuncLevel): Avoid off-by-one error

LayoutTests: [WebGL] Invalid range checking in WebGLRenderContext::validateTexFunctionLevel
https://bugs.webkit.org/show_bug.cgi?id=126925

Reviewed by Dean Jackson.

* fast/canvas/webgl/resources/webgl-test-utils.js:
(WebGLTestUtils): Add missing 'waitForComposite' implementatino.
* fast/canvas/webgl/webgl-compressed-texture-size-limit-expected.txt: Added.
* fast/canvas/webgl/webgl-compressed-texture-size-limit.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUpdate Mountain Lion test results for subpixel layout chanegs.
ap@apple.com [Mon, 13 Jan 2014 22:20:10 +0000 (22:20 +0000)]
Update Mountain Lion test results for subpixel layout chanegs.

Patch by Zalan Bujtas.

* platform/mac-mountainlion/compositing: Added.
* platform/mac-mountainlion/compositing/contents-opaque: Added.
* platform/mac-mountainlion/compositing/contents-opaque/control-layer-expected.txt: Added.
* platform/mac-mountainlion/css3/selectors3/html/css3-modsel-23-expected.txt:
* platform/mac-mountainlion/css3/selectors3/html/css3-modsel-24-expected.txt:
* platform/mac-mountainlion/css3/selectors3/html/css3-modsel-68-expected.txt:
* platform/mac-mountainlion/css3/selectors3/html/css3-modsel-69-expected.txt:
* platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-23-expected.txt:
* platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-24-expected.txt:
* platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-68-expected.txt:
* platform/mac-mountainlion/css3/selectors3/xhtml/css3-modsel-69-expected.txt:
* platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-23-expected.txt:
* platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-24-expected.txt:
* platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-68-expected.txt:
* platform/mac-mountainlion/css3/selectors3/xml/css3-modsel-69-expected.txt:
* platform/mac-mountainlion/editing/selection/3690703-2-expected.txt:
* platform/mac-mountainlion/editing/selection/3690703-expected.txt:
* platform/mac-mountainlion/editing/selection/3690719-expected.txt:
* platform/mac-mountainlion/fast/block/margin-collapse/103-expected.txt:
* platform/mac-mountainlion/fast/css/continuationCrash-expected.txt:
* platform/mac-mountainlion/fast/css/css2-system-fonts-expected.txt:
* platform/mac-mountainlion/fast/css/margin-top-bottom-dynamic-expected.txt: Added.
* platform/mac-mountainlion/fast/css/text-overflow-input-expected.txt:
* platform/mac-mountainlion/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt:
* platform/mac-mountainlion/fast/forms/basic-inputs-expected.txt:
* platform/mac-mountainlion/fast/forms/basic-textareas-expected.txt:
* platform/mac-mountainlion/fast/forms/basic-textareas-quirks-expected.txt:
* platform/mac-mountainlion/fast/forms/box-shadow-override-expected.txt:
* platform/mac-mountainlion/fast/forms/button-cannot-be-nested-expected.txt: Added.
* platform/mac-mountainlion/fast/forms/button-positioned-expected.txt:
* platform/mac-mountainlion/fast/forms/button-sizes-expected.txt:
* platform/mac-mountainlion/fast/forms/button-style-color-expected.txt:
* platform/mac-mountainlion/fast/forms/button-table-styles-expected.txt:
* platform/mac-mountainlion/fast/forms/button-text-transform-expected.txt:
* platform/mac-mountainlion/fast/forms/button-white-space-expected.txt:
* platform/mac-mountainlion/fast/forms/control-restrict-line-height-expected.txt:
* platform/mac-mountainlion/fast/forms/fieldset-align-expected.txt:
* platform/mac-mountainlion/fast/forms/file/input-file-re-render-expected.txt:
* platform/mac-mountainlion/fast/forms/form-element-geometry-expected.txt:
* platform/mac-mountainlion/fast/forms/input-appearance-height-expected.txt:
* platform/mac-mountainlion/fast/forms/input-button-sizes-expected.txt:
* platform/mac-mountainlion/fast/forms/input-disabled-color-expected.txt:
* platform/mac-mountainlion/fast/forms/input-readonly-autoscroll-expected.txt:
* platform/mac-mountainlion/fast/forms/input-readonly-dimmed-expected.txt:
* platform/mac-mountainlion/fast/forms/input-text-scroll-left-on-blur-expected.txt:
* platform/mac-mountainlion/fast/forms/input-value-expected.txt:
* platform/mac-mountainlion/fast/forms/listbox-hit-test-zoomed-expected.txt:
* platform/mac-mountainlion/fast/forms/minWidthPercent-expected.txt:
* platform/mac-mountainlion/fast/forms/search-rtl-expected.txt:
* platform/mac-mountainlion/fast/forms/search-vertical-alignment-expected.txt:
* platform/mac-mountainlion/fast/forms/searchfield-heights-expected.txt:
* platform/mac-mountainlion/fast/forms/select-baseline-expected.txt: Added.
* platform/mac-mountainlion/fast/forms/textAreaLineHeight-expected.txt:
* platform/mac-mountainlion/fast/forms/validation-message-appearance-expected.txt:
* platform/mac-mountainlion/fast/html/details-no-summary4-expected.txt:
* platform/mac-mountainlion/fast/html/details-open-javascript-expected.txt:
* platform/mac-mountainlion/fast/html/details-open2-expected.txt:
* platform/mac-mountainlion/fast/html/details-open4-expected.txt:
* platform/mac-mountainlion/fast/html/details-replace-summary-child-expected.txt:
* platform/mac-mountainlion/fast/html/details-replace-text-expected.txt:
* platform/mac-mountainlion/fast/overflow/scroll-nested-positioned-layer-in-overflow-expected.txt:
* platform/mac-mountainlion/fast/replaced/replaced-breaking-expected.txt:
* platform/mac-mountainlion/fast/text/textIteratorNilRenderer-expected.txt:
* platform/mac-mountainlion/http/tests/navigation/javascriptlink-frames-expected.txt:
* platform/mac-mountainlion/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug1188-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug138725-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug18359-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug24200-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug26178-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug28928-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug30692-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug33855-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug4527-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug51037-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug51727-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug52505-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug59354-expected.txt:
* platform/mac-mountainlion/tables/mozilla/bugs/bug7342-expected.txt:
* platform/mac-mountainlion/tables/mozilla/collapsing_borders/bug41262-4-expected.txt:
* platform/mac-mountainlion/tables/mozilla/core/margins-expected.txt:
* platform/mac-mountainlion/tables/mozilla/dom/tableDom-expected.txt:
* platform/mac-mountainlion/tables/mozilla/other/move_row-expected.txt:
* platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug2479-5-expected.txt:
* platform/mac-mountainlion/tables/mozilla_expected_failures/bugs/bug58402-2-expected.txt:
* platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-5-expected.txt:
* platform/mac-mountainlion/tables/mozilla_expected_failures/collapsing_borders/bug41262-6-expected.txt:
* platform/mac-mountainlion/transforms/2d/zoom-menulist-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Fix up WebKit build phases
dbates@webkit.org [Mon, 13 Jan 2014 22:02:08 +0000 (22:02 +0000)]
[iOS] Fix up WebKit build phases

Add iOS-specific logic to build phrases "Generate 64-bit Export File" and "Migrate Headers".

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[iOS] Fix up WebKit build phases
dbates@webkit.org [Mon, 13 Jan 2014 22:01:36 +0000 (22:01 +0000)]
[iOS] Fix up WebKit build phases

Add iOS-specific logic to build phrases "Generate 64-bit Export File" and "Migrate Headers".

* WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd uint8_t specialization for WebCore::writeLittleEndian()
dbates@webkit.org [Mon, 13 Jan 2014 20:56:04 +0000 (20:56 +0000)]
Add uint8_t specialization for WebCore::writeLittleEndian()
https://bugs.webkit.org/show_bug.cgi?id=126924

Reviewed by Darin Adler.

Specialize WebCore::writeLittleEndian() for datatype uint8_t so as to avoid
a compiler warning when right shifting a uint8_t by 8 because the result of
such a computation is undefined.

* bindings/js/SerializedScriptValue.cpp:
(WebCore::writeLittleEndian<uint8_t>): Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix.
eric.carlson@apple.com [Mon, 13 Jan 2014 20:54:04 +0000 (20:54 +0000)]
Unreviewed build fix.

* WebKit.vcxproj/WebKitExportGenerator/WebKitExports.def.in: Add missing
    exports needed for Windows build after r161899.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agor161638 broke the Windows build
dbates@webkit.org [Mon, 13 Jan 2014 20:21:40 +0000 (20:21 +0000)]
r161638 broke the Windows build
https://bugs.webkit.org/show_bug.cgi?id=126916

* DerivedSources.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWeb Inspector: protocol generator should support integer-typed declarations
bburg@apple.com [Mon, 13 Jan 2014 20:10:22 +0000 (20:10 +0000)]
Web Inspector: protocol generator should support integer-typed declarations
https://bugs.webkit.org/show_bug.cgi?id=126828

Reviewed by Joseph Pecoraro.

Add new binding classes for parameter/ad-hoc and normal integer type declarations.

* inspector/scripts/CodeGeneratorInspector.py:
(TypeBindings.create_type_declaration_):
(TypeBindings.create_type_declaration_.PlainInteger):
(TypeBindings.create_type_declaration_.PlainInteger.resolve_inner):
(TypeBindings.create_type_declaration_.PlainInteger.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.PlainInteger.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.PlainInteger.get_code_generator):
(TypeBindings.create_type_declaration_.PlainInteger.get_validator_call_text):
(TypeBindings.create_type_declaration_.PlainInteger.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.PlainInteger.get_type_model):
(TypeBindings.create_type_declaration_.PlainInteger.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.PlainInteger.get_array_item_c_type_text):
(TypeBindings.create_type_declaration_.TypedefInteger):
(TypeBindings.create_type_declaration_.TypedefInteger.resolve_inner):
(TypeBindings.create_type_declaration_.TypedefInteger.request_user_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefInteger.request_internal_runtime_cast):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.generate_type_builder.int):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.register_use):
(TypeBindings.create_type_declaration_.TypedefInteger.get_code_generator.CodeGenerator.get_generate_pass_id):
(TypeBindings.create_type_declaration_.TypedefInteger.get_validator_call_text):
(TypeBindings.create_type_declaration_.TypedefInteger.reduce_to_raw_type):
(TypeBindings.create_type_declaration_.TypedefInteger.get_type_model):
(TypeBindings.create_type_declaration_.TypedefInteger.get_setter_value_expression_pattern):
(TypeBindings.create_type_declaration_.TypedefInteger.get_array_item_c_type_text):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow MediaSessionManager to restrict media playback
eric.carlson@apple.com [Mon, 13 Jan 2014 19:42:27 +0000 (19:42 +0000)]
Allow MediaSessionManager to restrict media playback
https://bugs.webkit.org/show_bug.cgi?id=126780

Reviewed by Jer Noble.

Source/WebCore:

Test: media/video-concurrent-playback.html

* WebCore.exp.in: Export functions needed by Internals.

Add HTMLMediaSession.
* WebCore.xcodeproj/project.pbxproj:
* CMakeLists.txt:
* GNUmakefile.list.am:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

Add a media session object to manage HTMLMediaElement restrictions.
* html/HTMLMediaSession.cpp: Added.
* html/HTMLMediaSession.h: Added.

Move media restriction management to a MediaSession.
* html/HTMLMediaElement.cpp:
(WebCore::HTMLMediaElement::HTMLMediaElement): Use the media session to manage restrictions.
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
(WebCore::HTMLMediaElement::insertedInto): Ditto.
(WebCore::HTMLMediaElement::parseAttribute): Ditto.
(WebCore::HTMLMediaElement::loadInternal): Ditto.
(WebCore::HTMLMediaElement::loadResource): Ditto.
(WebCore::HTMLMediaElement::setReadyState): Ditto.
(WebCore::HTMLMediaElement::autoplay): Ditto.
(WebCore::HTMLMediaElement::play): Ditto.
(WebCore::HTMLMediaElement::pause): Ditto
(WebCore::HTMLMediaElement::pauseInternal): Ditto
(WebCore::HTMLMediaElement::suspend): Ditto
(WebCore::HTMLMediaElement::resume): Ditto.
(WebCore::HTMLMediaElement::updatePlayState): Tell media session playback is about to start.
(WebCore::HTMLMediaElement::deliverNotification): Ditto.
(WebCore::HTMLMediaElement::webkitShowPlaybackTargetPicker): Ditto.
(WebCore::HTMLMediaElement::mediaPlayerIsFullscreenPermitted): Ditto.
(WebCore::HTMLMediaElement::removeBehaviorsRestrictionsAfterFirstUserGesture): Ditto.
(WebCore::HTMLMediaElement::pausePlayback): New, allows the media session to pause playback.
* html/HTMLMediaElement.h:

* html/HTMLVideoElement.cpp:
(WebCore::HTMLVideoElement::webkitEnterFullscreen): Use the media session to manage restrictions.

* platform/audio/MediaSession.cpp:
(WebCore::MediaSession::beginInterruption): Add logging.
(WebCore::MediaSession::endInterruption): Ditto.
(WebCore::MediaSession::pauseSession): New, allows the session manager to pause playback.
* platform/audio/MediaSession.h:

Add per-media type restrictions.
* platform/audio/MediaSessionManager.cpp:
(WebCore::MediaSessionManager::MediaSessionManager): Initialize restrictions.
(WebCore::MediaSessionManager::addRestriction): New.
(WebCore::MediaSessionManager::removeRestriction): New.
(WebCore::MediaSessionManager::restrictions): New.
(WebCore::MediaSessionManager::sessionWillBeginPlayback): New. If only one session if the same
    type is allowed to play, pause all others.
* platform/audio/MediaSessionManager.h:

* platform/audio/ios/MediaSessionManagerIOS.h: Added.
* platform/audio/ios/MediaSessionManagerIOS.mm: Added.
(WebCore::MediaSessionManager::sharedManager):
(WebCore::m_objcObserver):
(-[WebAVAudioSessionHelper initWithCallback:]):
(-[WebAVAudioSessionHelper dealloc]):
(-[WebAVAudioSessionHelper interruption:]):

* platform/audio/mac/AudioDestinationMac.h: Add pausePlayback.

Allow tests to set media session restrictions.
* testing/Internals.cpp:
* testing/Internals.h:
* testing/Internals.idl:

LayoutTests:

* media/video-concurrent-playback-expected.txt: Added.
* media/video-concurrent-playback.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed Mac WK2 gardering after r161882.
zalan@apple.com [Mon, 13 Jan 2014 19:34:06 +0000 (19:34 +0000)]
Unreviewed Mac WK2 gardering after r161882.

* platform/mac-wk2/fast/dynamic/012-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoInclude WAKAppKitStubs.h to get NSSelectionAffinity.
simon.fraser@apple.com [Mon, 13 Jan 2014 19:32:25 +0000 (19:32 +0000)]
Include WAKAppKitStubs.h to get NSSelectionAffinity.

* WebView/WebEditingDelegate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the build more.
ap@apple.com [Mon, 13 Jan 2014 19:17:38 +0000 (19:17 +0000)]
Fix the build more.

* xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDOMTouch* etc should not be public headers on iOS.
simon.fraser@apple.com [Mon, 13 Jan 2014 19:13:55 +0000 (19:13 +0000)]
DOMTouch* etc should not be public headers on iOS.

* MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix the build.
ap@apple.com [Mon, 13 Jan 2014 19:11:17 +0000 (19:11 +0000)]
Fix the build.

* xml/XMLHttpRequestProgressEventThrottle.cpp:
(WebCore::XMLHttpRequestProgressEventThrottle::dispatchProgressEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@161894 268f45cc-cd09-0410-ab3c-d52691b4dbfc