12 years ago Set the font smoothing preference in DRT
aroben@apple.com [Mon, 26 Nov 2007 00:13:40 +0000 (00:13 +0000)]
     Set the font smoothing preference in DRT

         This makes the pixel results on Windows closer to the Mac results.

         Reviewed by Mitz.

         * DumpRenderTree/win/DumpRenderTree.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix Bug 16133: Implement pixel test support on Windows
aroben@apple.com [Mon, 26 Nov 2007 00:03:42 +0000 (00:03 +0000)]
 Fix Bug 16133: Implement pixel test support on Windows


         Add ImageDiff.vcproj to WebKit.sln

         Reviewed by Sam.

         * WebKit.vcproj/WebKit.sln:


         Port ImageDiff to CG and C++

         Final part of http://bugs.webkit.org/show_bug.cgi?id=16133

         Reviewed by Sam.

         * DumpRenderTree/DumpRenderTree.sln: Added ImageDiff.vcproj.
         * DumpRenderTree/cg/ImageDiffCG.cpp: Added.
         * DumpRenderTree/win/ImageDiff.vcproj: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix image diff link generation on Windows
aroben@apple.com [Mon, 26 Nov 2007 00:03:18 +0000 (00:03 +0000)]
     Fix image diff link generation on Windows

         Reviewed by Sam.

         * Scripts/run-webkit-tests: Removed unnecessary and incorrect calls
         to toURL.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Implement pixel dumping in Windows DRT
aroben@apple.com [Mon, 26 Nov 2007 00:02:55 +0000 (00:02 +0000)]
    Implement pixel dumping in Windows DRT

        Part of http://bugs.webkit.org/show_bug.cgi?id=16133

        Reviewed by Sam.

        * DumpRenderTree/cg/PixelDumpSupportCG.cpp: Added.
        (printPNG): Dumps a CGImageRef as a PNG to stdout, along with a
        Content-Length header.
        * DumpRenderTree/cg/PixelDumpSupportCG.h: Copied from WebKitTools/DumpRenderTree/mac/DumpRenderTreePasteboard.h.
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (dump): Do a pixel dump if requested.
        (main): Parse pixel test options.
        * DumpRenderTree/win/DumpRenderTree.vcproj: Added new files and added
        the cg/ subdirectory to the include path.
        * DumpRenderTree/win/MD5.cpp: Added. Windows MD5 functions aren't
        available in a header or import library, so we have to go through this
        LoadLibrary/GetProcAddress dance to use them.
        * DumpRenderTree/win/MD5.h: Added.
        * DumpRenderTree/win/PixelDumpSupport.h: Added. This file should be
        moved up to the top level to share it with Mac eventually.
        * DumpRenderTree/win/PixelDumpSupportWin.cpp: Added.
        (getBitmapContextFromWebView): Forces the WebView to paint using a
        WM_PRINTCLIENT message, and puts the result in a CGBitmapContext.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Clean up Windows DRT's option parsing a little bit
aroben@apple.com [Mon, 26 Nov 2007 00:02:29 +0000 (00:02 +0000)]
     Clean up Windows DRT's option parsing a little bit

         Reviewed by Sam.

         * DumpRenderTree/win/DumpRenderTree.cpp:
         (main): Put non-option arguments into a Vector.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Make Windows DRT stop changing LF into CRLF
aroben@apple.com [Mon, 26 Nov 2007 00:01:44 +0000 (00:01 +0000)]
     Make Windows DRT stop changing LF into CRLF

         Reviewed by Sam.

         * DumpRenderTree/win/DumpRenderTree.cpp:
         (main): Put stdout in binary mode.
         * Scripts/run-webkit-tests: Remove the CRLF hack.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix bug 16129: REGRESSION (r27761-r27811): malloc error while visiting http://mysit...
mrowe@apple.com [Sun, 25 Nov 2007 22:14:31 +0000 (22:14 +0000)]
Fix bug 16129: REGRESSION (r27761-r27811): malloc error while visiting mysit.es (crashes release build)

* pcre/pcre_compile.cpp: Change errorcode to be passed by reference so that any error code is propagated
to our caller like they expect.

Reviewed by Dan Bernstein.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fixes for Linux/GTK+ port.
kevino@webkit.org [Sun, 25 Nov 2007 21:16:03 +0000 (21:16 +0000)]
wx build fixes for Linux/GTK+ port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix wrong bug number in ChangeLog. Not reviewed.
zimmermann@webkit.org [Sun, 25 Nov 2007 13:06:22 +0000 (13:06 +0000)]
Fix wrong bug number in ChangeLog. Not reviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoReviewed by Adam Roben.
zimmermann@webkit.org [Sun, 25 Nov 2007 13:04:55 +0000 (13:04 +0000)]
Reviewed by Adam Roben.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=15393

Fix problems with hidden glyphs. They were taken into account for quite
some operations (hit testing, length calulcations etc..) except painting.
Especially fixes boundaries of <textPath> (see using Web Inspector) if
text-anchor isn't equal to 'start'.

Added testcase:

Fixed testcase: (all showed text selection problems on text paths)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Sun, 25 Nov 2007 09:45:09 +0000 (09:45 +0000)]
    Reviewed by Maciej.

        XSLTProcessor.transformToFragment creates an extra not defined TEXT_NODE at the end

        Test: fast/xsl/extra-lf-at-end.html

        * xml/XSLTProcessor.cpp:
        (WebCore::writeToVector): Changed to use Vector to avoid slow String::apend().
        (WebCore::saveResultToString): Remove trailing line feed if present.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-24 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 25 Nov 2007 08:48:48 +0000 (08:48 +0000)]
2007-11-24  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] Public API does not follow GTK+ conventions

        Public API enhancements:

        Implement webkit_page_get_editable() and webkit_page_set_editable().

        Implement webkit_frame_get_name().

        Remove definitions for functions that are unusable or not implemented.
        This has caused much confusion for application developers.

        Improve documentation.

        Correct/constify some return types.

        Add parameter checks.

        Make the default fixed font "Courier New" to match the other Web
        font names.

        * Api/webkitgtkframe.cpp:
        * Api/webkitgtkframe.h:
        * Api/webkitgtkpage.cpp:
        * Api/webkitgtkpage.h:
        * Api/webkitgtkprivate.h:
        * WebCoreSupport/EditorClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added tests for select.options.remove(boolean).
ddkilzer@apple.com [Sun, 25 Nov 2007 07:15:33 +0000 (07:15 +0000)]
    Added tests for select.options.remove(boolean).

        Reviewed by Maciej.

        * fast/js/resources/select-options-add.js: Added two tests.
        * fast/js/select-options-add-expected.txt: Updated results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28012 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-24 Alp Toker <alp@atoker.com>
alp@webkit.org [Sun, 25 Nov 2007 03:39:55 +0000 (03:39 +0000)]
2007-11-24  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        [GTK] Up key doesn't work properly when content is editable

        Add a missing 'break' to avoid falling through to the next case when
        handling VK_UP keystrokes. This was noticed when working on editing
        support in the GTK+ port.

        I've checked the other cases for similar typos and they seem fine.

        * WebCoreSupport/EditorClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-24 David Kilzer <ddkilzer@webkit.org>
ddkilzer@apple.com [Sun, 25 Nov 2007 03:13:12 +0000 (03:13 +0000)]
2007-11-24  David Kilzer  <ddkilzer@webkit.org>

        Removed empty directory.

        * Scripts/resources: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28010 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-24 Xan Lopez <xan@gnome.org>
alp@webkit.org [Sun, 25 Nov 2007 02:53:42 +0000 (02:53 +0000)]
2007-11-24  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp Toker.

        [GTK] Arrow keys do not Scroll

        * Api/webkitgtkpage.cpp:

        Support Up/Down/Right/Left keys to scroll. Slight hack, see FIXME for

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-24 Christian Dywan <christian@twotoasts.de>
alp@webkit.org [Sun, 25 Nov 2007 01:23:41 +0000 (01:23 +0000)]
2007-11-24  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Alp Toker.

        [GTK] Javascript console and dialogs are not implemented

        Fix call to gtk_message_dialog_new() which expects a format string.

        * Api/webkitgtkpage.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoTiger build fix.
mrowe@apple.com [Sat, 24 Nov 2007 23:56:02 +0000 (23:56 +0000)]
Tiger build fix.

Use WebCFAutorelease in place of NSMakeCollectable then autorelease as this also works on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/5432686> 333MB RPRVT seems to leak @ www.43folders.com (1hr plug...
mrowe@apple.com [Sat, 24 Nov 2007 23:48:52 +0000 (23:48 +0000)]
Fix <rdar://problem/5432686> 333MB RPRVT seems to leak @ 43folders.com (1hr plug-in stream).

Reviewed by Tim Hatcher.

Have NP_ASFILE and NP_ASFILEONLY streams write the data to disk as they receive it rather than
dumping the data to disk in a single go when the stream has completed loading.  On a test case
involving a 150MB Flash movie being streamed from a local web server this reduces memory consumption
on page load from around 400MB to 22MB.

The only plugin I have found that uses NP_ASFILE or NP_ASFILEONLY on the Mac is our NetscapeMoviePlugin
example code so the NP_ASFILE portion of this change has not had any testing with a real-world plugin.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Get rid of WebCoreSystemInterface on Windows
aroben@apple.com [Sat, 24 Nov 2007 23:43:22 +0000 (23:43 +0000)]
 Get rid of WebCoreSystemInterface on Windows


         Get rid of WebCoreSystemInterface on Windows

         The one function defined in that file is now in WebKitSystemInterface.

         Reviewed by Tim.

         * WebCore.vcproj/WebCore.vcproj: Removed
         * platform/graphics/cg/ImageCG.cpp: Made #include of
         WebCoreSystemInterface.h Mac-only.
         * platform/win/GraphicsContextWin.cpp: Ditto.
         * platform/win/WebCoreSystemInterface.cpp: Removed.
         * platform/win/WebCoreSystemInterface.h: Removed.


         Add wkSetPatternPhaseInUserSpace to WebKitSystemInterface on Windows

         Reviewed by Tim.

         * win/include/WebKitSystemInterface/WebKitSystemInterface.h: Added
         * win/lib/WebKitSystemInterface.lib: Updated.
         * win/lib/WebKitSystemInterface_debug.lib: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Replace uses of %@ with %s in the inspector
aroben@apple.com [Sat, 24 Nov 2007 23:33:18 +0000 (23:33 +0000)]
    Replace uses of %@ with %s in the inspector

        Rubberstamped by Tim.

        * English.lproj/InspectorLocalizedStrings.js: Changed %@ to %s.
        * page/inspector/DatabasePanel.js: Ditto.
        * page/inspector/StylesSidebarPane.js: Ditto.
        * page/inspector/inspector.js: Ditto.
        * page/inspector/utilities.js:
        (String.vsprintf): Removed @ as a format specifier.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Windows build fix
aroben@apple.com [Sat, 24 Nov 2007 23:32:48 +0000 (23:32 +0000)]
    Windows build fix

        Turn off the change made in r27984 on Windows for now.

        * xml/XSLTProcessor.cpp:
        * xml/XSLTUnicodeSort.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
timothy@apple.com [Sat, 24 Nov 2007 22:35:52 +0000 (22:35 +0000)]
    Reviewed by Adam Roben.

        Bug 16121: Web Inspector needs helper functions that pass a 'this' object to
        addEventListener and setTimeout

        Add Function.prototype.bind. This helper will return a wrapper function
        that will call the original function with the supplied arguments
        and using the supplied 'this' object.

        * page/inspector/Database.js: Remove a use of setTimeout by
          inheriting some common functions from Resource.
        * page/inspector/DatabasePanel.js: Use the new bind function.
        * page/inspector/ConsolePanel.js: Ditto.
        * page/inspector/DocumentPanel.js: Ditto.
        * page/inspector/NetworkPanel.js: Ditto.
        * page/inspector/PropertiesSection.js: Ditto.
        * page/inspector/Resource.js: Ditto.
        * page/inspector/SidebarPane.js: Ditto.
        * page/inspector/inspector.html: Moved Database.js after Resource.js,
          now that Database.js uses it.
        * page/inspector/inspector.js: Use the new bind function. Also
          removed a setTimeout used for the localized strings code. There is
          now a load event listener added to the localized strings script
          element that will call WebInspector.loaded.
        * page/inspector/utilities.js: Add Function.prototype.bind.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28002 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd missing strings.
timothy@apple.com [Sat, 24 Nov 2007 22:20:56 +0000 (22:20 +0000)]
Add missing strings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-24 Christian Dywan <christian@twotoasts.de>
alp@webkit.org [Sat, 24 Nov 2007 21:52:31 +0000 (21:52 +0000)]
2007-11-24  Christian Dywan  <christian@twotoasts.de>

        Reviewed by Alp Toker.

        [GTK] Webkit doesn't show title attribute tooltip when hovering over an image

        Implement tooltip support using the new Tooltip API.

        Support for older versions of GTK+ is still lacking.

        * WebCoreSupport/ChromeClientGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@28000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
timothy@apple.com [Sat, 24 Nov 2007 19:18:45 +0000 (19:18 +0000)]
    Reviewed by Adam Roben.

        Bug 16112: Some Web Inspector UI elements use offsetWidth and offsetHeight before the stylesheet loads

        In the places where we use offsetWidth and offsetHeight before
        the stylesheet loads there is now a check. If the body's
        offsetWidth is not greater than zero, then set a timeout
        to do the updates requiring the stylesheet later.

        The three places this happened:
        - DOM tree selection highlight would show up at the wrong height
          when using Inspect Element to open the inspector.
        - DOM tree breadcrumbs would not collapse when using Inspect Element
          to open the inspector.
        - Network Timeline divider lines would not show when opening directly
          into the timeline.

        * page/inspector/DocumentPanel.js: Check if the stylesheet loaded.
        * page/inspector/NetworkPanel.js: Ditto.
        * page/inspector/inspector.html: Include the stylesheet before
          any scripts, this will help get it loaded sooner.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd wx implementation for pathGetFilename
kevino@webkit.org [Sat, 24 Nov 2007 18:18:53 +0000 (18:18 +0000)]
Add wx implementation for pathGetFilename

Reviewed by David D. Kilzer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix bisect-builds to work with recent WebKit nightly builds.
ddkilzer@apple.com [Sat, 24 Nov 2007 06:09:39 +0000 (06:09 +0000)]
    Fix bisect-builds to work with recent WebKit nightly builds.

        Reviewed by Dan.

        * Scripts/bisect-builds: Check for the
        WebKit.app/Contents/Frameworks/10.[45] directory. If it exists, use
        it for the DYLD_FRAMEWORK_PATH environment variable, else fallback
        to WebKit.app/Contents/Resources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27997 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
timothy@apple.com [Sat, 24 Nov 2007 04:48:07 +0000 (04:48 +0000)]
    Reviewed by Adam Roben.

        Bug 16110: Clicking inside the resource headers in the network timeline collapses them

        Toggle the resource headers only if the click happens on the
        resource row, not within the headers area.

        * WebCore.xcodeproj/project.pbxproj:
        * page/inspector/NetworkPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27996 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed <rdar://problem/3759190> allow input methods the option of processing mouse...
oliver@apple.com [Sat, 24 Nov 2007 03:14:46 +0000 (03:14 +0000)]
Fixed <rdar://problem/3759190> allow input methods the option of processing mouse events themselves

Reviewed by Mark Rowe.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWindows build fixes for USE(CURL) and MSVC compilation for ports.
kevino@webkit.org [Sat, 24 Nov 2007 00:52:18 +0000 (00:52 +0000)]
Windows build fixes for USE(CURL) and MSVC compilation for ports.

Reviewed by Adam Roben.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoForgot to add JSCore and WebCore ChangeLog during previous commit.
kevino@webkit.org [Fri, 23 Nov 2007 23:22:24 +0000 (23:22 +0000)]
Forgot to add JSCore and WebCore ChangeLog during previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix the wx buildbot after removal of move-js-headers.sh..
kevino@webkit.org [Fri, 23 Nov 2007 23:17:29 +0000 (23:17 +0000)]
Fix the wx buildbot after removal of move-js-headers.sh..

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27992 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-22 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 23 Nov 2007 22:03:38 +0000 (22:03 +0000)]
2007-11-22  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Implement and document several WebKitFrame functions, some of which
        are necessary to support DRT.

        Correct NULL handling and improve run-time checks.

        * Api/webkitgtkframe.cpp:
        * Api/webkitgtkframe.h:
        * Api/webkitgtkprivate.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Set video src from script, not from the element attribute. This
antti@apple.com [Fri, 23 Nov 2007 20:07:06 +0000 (20:07 +0000)]
    Set video src from script, not from the element attribute. This
        guarantees load events do not fire before event listeners are registered.
        This change does not affect test results.

        * media/progress-event.html:
        * media/video-autoplay.html:
        * media/video-buffered.html:
        * media/video-currentTime-set.html:
        * media/video-currentTime-set2.html:
        * media/video-currentTime.html:
        * media/video-dom-autoplay.html:
        * media/video-error-abort.html:
        * media/video-error-does-not-exist.html:
        * media/video-load-networkState.html:
        * media/video-load-readyState.html:
        * media/video-no-autoplay.html:
        * media/video-seekable.html:
        * media/video-seeking.html:
        * media/video-size.html:
        * media/video-src.html:
        * media/video-start.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27990 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAnother build fix specific to trunk (instead of the stable branch) to fix make clean...
hausmann@webkit.org [Fri, 23 Nov 2007 15:56:05 +0000 (15:56 +0000)]
Another build fix specific to trunk (instead of the stable branch) to fix make clean (which the buildbots call).

Signed-off-by: George Staikos <staikos@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27989 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix make (dist)clean on Windows.
hausmann@webkit.org [Fri, 23 Nov 2007 15:44:14 +0000 (15:44 +0000)]
Fix make (dist)clean on Windows.

OBJECTS_DIR_WTR does not exist anymore, use GENERATED_SOURCES_DIR.

Signed-off-by: George Staikos <staikos@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27988 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Not reviewed, trivial leak fix.
ap@webkit.org [Fri, 23 Nov 2007 12:27:06 +0000 (12:27 +0000)]
    Not reviewed, trivial leak fix.

        Fix xsltUnicodeSortFunction() memory leaks.

        * xml/XSLTUnicodeSort.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Fri, 23 Nov 2007 10:19:17 +0000 (10:19 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5539306> REGRESSION: redirect fails when subframe's document is opened but
        not closed (affects digg.com)

        Tests: fast/loader/meta-refresh-vs-open.html

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::scheduleRedirection): Only check whether the load is complete for
        HTTP redirects - JavaScript-initiated ones are effective immediately.

        * DumpRenderTree/mac/DumpRenderTree.mm: (runTest): Replace the current document with a blank
        one after finishing with a test to avoid having its delayed onload handler fired when
        starting the next test. This is ugly and still unreliable (see LayoutTests ChangeLog),
        but it helps somewhat.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 23 Nov 2007 09:20:16 +0000 (09:20 +0000)]

        Reviewed by Alexey Proskuryakov.

        - apply matrix transforms on the correct side of the transformation
          matrix (not on the side where the vector is multiplied).

        Test: fast/transforms/matrix-02.html

        * rendering/RenderStyle.h:


        Reviewed by Alexey Proskuryakov.

        - test the matrix transforms are applied on the correct side

        * fast/transforms/matrix-02.html: Added.
        * platform/mac/fast/transforms/matrix-02-expected.checksum: Added.
        * platform/mac/fast/transforms/matrix-02-expected.png: Added.
        * platform/mac/fast/transforms/matrix-02-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Fri, 23 Nov 2007 08:29:59 +0000 (08:29 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5609785> XSLT processor <xsl:sort> algorithm is incompatible with other
        browser implementations

        Test: fast/xsl/sort-unicode.xml

        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::transformToString): Set a custom sort function.

        * xml/XSLTUnicodeSort.cpp: Added.
        * xml/XSLTUnicodeSort.h: Added.
        ICU-based implementation of xsl:sort, using an example from libxslt distribution.
        Only minimal coding style fixes to ease synchronization with upstream in the future.

        * icu/unicode/ucol.h: Added.
        * icu/unicode/uset.h: Added.
        Taken from ICU 3.2

        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        Added XSLTUnicodeSort.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27984 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Fri, 23 Nov 2007 06:43:49 +0000 (06:43 +0000)]
    Reviewed by Maciej.

        Hixie's DOM Core performance test shows insert >10x slower than append

        Each invocation of Element.childNodes[n] was creating and registering a new ChildNodeList,
        which persisted and listened to notifications until GC.

        A fix is to avoid registering child node lists for notifications - they don't need them, as
        they share a common cache in Node.

        * dom/Node.cpp:
        * dom/NodeList.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 23 Nov 2007 06:04:36 +0000 (06:04 +0000)]

        Reviewed by Antti Koivisto.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15811
          WebKit plug-ins can re-enter WebKit under attach()

        Defer plug-in loading until after attach and recalcStyle using the
        post-attach callback mechanism. Netscape plug-ins are still loaded only
        after layout.

        * dom/ContainerNode.cpp:
        Made NodeCallbackQueue elements retain the Node because callbacks might
        delete nodes that are in the callback queue.
        (WebCore::ContainerNode::suspendPostAttachCallbacks): Added. Needed to
        prevent post-attach callbacks from being dispatched under recalcStyle().
        (WebCore::ContainerNode::resumePostAttachCallbacks): Ditto.
        (WebCore::ContainerNode::dispatchPostAttachCallbacks): Factored out from
        * dom/ContainerNode.h:
        * dom/Document.cpp:
        (WebCore::Document::recalcStyle): Added calls to
        suspendPostAttachCallbacks() and resumePostAttachCallbacks().
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::attach): Changed to queue the widget update
        for post-attach.
        (WebCore::HTMLEmbedElement::updateWidget): Added. Called by the
        post-attach callback.
        * html/HTMLEmbedElement.h: Added an m_needWidgetUpdate member needed to
        prevent a double update if another plug-in's post-attach updateWidget()
        triggers a layout which updates the widget before this plug-in's
        post-attach callback is invoked.
        (WebCore::HTMLEmbedElement::setNeedWidgetUpdate): Added a setter for
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::attach): Changed to queue the widget update
        for post-attach.
        (WebCore::HTMLObjectElement::updateWidget): Added. Called by the
        post-attach callback.
        * html/HTMLObjectElement.h:
        (WebCore::HTMLObjectElement::setNeedWidgetUpdate): Added a setter for
        * html/HTMLPlugInElement.cpp:
        (WebCore::HTMLPlugInElement::updateWidgetCallback): Added.
        * html/HTMLPlugInElement.h:
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget): Added calls to
        setNeedWidgetUpdate(false) so that if this method is called from
        FrameView::layout() during post-attach dispatch of another plug-in,
        it will not be called again when this plug-in's post-attach callback
        is dispatched.
        * rendering/RenderPartObject.h:
        (WebCore::RenderPartObject::updateWidget) Renamed argument to match
        the method definition.


        Reviewed by Antti Koivisto.

        - http://bugs.webkit.org/show_bug.cgi?id=15811
          WebKit plug-ins can re-enter WebKit under attach()

        * Plugins/WebNullPluginView.mm:
        (-[WebNullPluginView viewDidMoveToWindow]): Removed workaround for the
        above bug that added as part of fixing

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dan Bernstein.
timothy@apple.com [Fri, 23 Nov 2007 04:45:26 +0000 (04:45 +0000)]
    Reviewed by Dan Bernstein.

        Fix the Element.hasStyleClass and Element.removeStyleClass helpers
        to not find and replace substrings, but whole class names at the
        beginning or end of the string or surrounded by whitespace.

        * page/inspector/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix typo.
timothy@apple.com [Fri, 23 Nov 2007 04:23:57 +0000 (04:23 +0000)]
Fix typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Revert part of my r27935 change that made the Tip balloons
timothy@apple.com [Fri, 23 Nov 2007 04:20:13 +0000 (04:20 +0000)]
    Revert part of my r27935 change that made the Tip balloons
        animate with CSS transitions. The balloon was only opacity 0,
        so it would cause it's row to highlight when hovering over
        another row.

        * page/inspector/NetworkPanel.js:
        * page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27979 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Fri, 23 Nov 2007 04:11:09 +0000 (04:11 +0000)]

        Reviewed by Maciej Stachowiak.

        - fix http://bugs.webkit.org/show_bug.cgi?id=15943
          -webkit-transform matrix does not work

        Test: fast/transforms/matrix-01.html

        Parse all six matrix entries as numbers.

        * css/CSSParser.cpp:
        * css/CSSStyleSelector.cpp:
        * rendering/RenderStyle.cpp:
        * rendering/RenderStyle.h:


        Reviewed by Maciej Stachowiak.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=15943
          -webkit-transform matrix does not work

        * fast/transforms/matrix-01.html: Added.
        * platform/mac/fast/transforms/matrix-01-expected.checksum: Added.
        * platform/mac/fast/transforms/matrix-01-expected.png: Added.
        * platform/mac/fast/transforms/matrix-01-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-22 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 23 Nov 2007 02:53:18 +0000 (02:53 +0000)]
2007-11-22  Alp Toker  <alp@atoker.com>

        Whitespace fixes only.

        * Api/webkitgtkframe.cpp:
        * Api/webkitgtkpage.cpp:
        * Api/webkitgtkpage.h:
        * Api/webkitgtkprivate.h:
        * WebCoreSupport/ChromeClientGtk.cpp:
        * WebCoreSupport/ContextMenuClientGtk.cpp:
        * WebCoreSupport/ContextMenuClientGtk.h:
        * WebCoreSupport/DragClientGtk.h:
        * WebCoreSupport/EditorClientGtk.h:
        * WebCoreSupport/FrameLoaderClientGtk.cpp:
        * WebCoreSupport/FrameLoaderClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-22 Michael Natterer <mitch@imendio.com>
alp@webkit.org [Fri, 23 Nov 2007 01:52:25 +0000 (01:52 +0000)]
2007-11-22  Michael Natterer  <mitch@imendio.com>

        Reviewed by Alp Toker.

        Implement "navigation-requested" signal for WebKit Gtk

        * Api/webkitgtknetworkrequest.h: fix parent class member.

        * Api/webkitgtknetworkrequest.cpp
        * Api/webkitgtkprivate.h: basic implementation featuring an
        "url" member and API.

        * Api/webkitgtkdefines.h: added network request typedefs.

        * Api/webkitgtkpage.h: fix enum name:
        and sanitized enum values.

        * Api/webkitgtkpage.cpp: made "navigation-requested" a signal.

        * Api/webkitgtk-marshal.list: added INT:OBJECT,OBJECT

        * WebCoreSupport/FrameLoaderClientGtk.cpp: emit the new signal in

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-22 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Fri, 23 Nov 2007 01:48:52 +0000 (01:48 +0000)]
2007-11-22  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp Toker.

        Fix build-webkit to propagate make's exit status if it fails.

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-22 Alp Toker <alp@atoker.com>
alp@webkit.org [Fri, 23 Nov 2007 01:03:19 +0000 (01:03 +0000)]
2007-11-22  Alp Toker  <alp@atoker.com>

        GTK+ build fix. Pass a correct LIBDIR value.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-22 Laszlo Gombos <laszlo.gombos@gmail.com>
alp@webkit.org [Fri, 23 Nov 2007 00:04:00 +0000 (00:04 +0000)]
2007-11-22  Laszlo Gombos  <laszlo.gombos@gmail.com>

        Reviewed by Alp Toker.

        Fix some compilation warnings.  Do not reference undefined (platform) specific type (WebCore::CachedFont::m_fontData)

        * loader/CachedFont.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-22 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 22 Nov 2007 21:02:33 +0000 (21:02 +0000)]
2007-11-22  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        GTK+ drawing fix.

        Add a check to avoid crashing when the GraphicsContext is not
        associated with a GdkEventExpose. This was noticed when adding
        printing support but might be triggered in other situations too.

        * platform/gtk/WidgetGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
mitz@apple.com [Thu, 22 Nov 2007 17:36:54 +0000 (17:36 +0000)]
    Reviewed by Mark Rowe.

        - fix crash when running pixel tests

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (dumpRenderTree): Parse the command line options before setting up the
        environment so that we know if we need to set up the pixel dump

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-22 Julien Chaffraix <julien.chaffraix@gmail.com>
ap@webkit.org [Thu, 22 Nov 2007 11:03:32 +0000 (11:03 +0000)]
2007-11-22  Julien Chaffraix  <julien.chaffraix@gmail.com>

        Reviewed by Alexey.

        Bug 15530: XMLHttpRequest should not support certain methods

        Test: http/tests/xmlhttprequest/xmlhttprequest-forbidden-methods-exception.html

        * xml/XMLHttpRequest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove WARNING notes from change logs that committers neglected to remove when landing.
mrowe@apple.com [Thu, 22 Nov 2007 10:55:30 +0000 (10:55 +0000)]
Remove WARNING notes from change logs that committers neglected to remove when landing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix changelog
hausmann@webkit.org [Thu, 22 Nov 2007 10:16:38 +0000 (10:16 +0000)]
Fix changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix compilation (don't define notImplemented twice)
hausmann@webkit.org [Thu, 22 Nov 2007 10:13:00 +0000 (10:13 +0000)]
Fix compilation (don't define notImplemented twice)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse Q_SIGNALS/Q_SLOTS in the public API
hausmann@webkit.org [Thu, 22 Nov 2007 10:12:42 +0000 (10:12 +0000)]
Use Q_SIGNALS/Q_SLOTS in the public API

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed the signature of the QWebPage constructor to follow Qt guidelines.
hausmann@webkit.org [Thu, 22 Nov 2007 10:12:19 +0000 (10:12 +0000)]
Fixed the signature of the QWebPage constructor to follow Qt guidelines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse <QtModule/headerfile.h> instead of <Classname> in public HEADER files, to not...
hausmann@webkit.org [Thu, 22 Nov 2007 10:12:03 +0000 (10:12 +0000)]
Use <QtModule/headerfile.h> instead of <Classname> in public HEADER files, to not require the include paths for the other modules to be present

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved inline copy of QExplicitlySharedDataPointer. This is not needed anymore since...
hausmann@webkit.org [Thu, 22 Nov 2007 10:11:39 +0000 (10:11 +0000)]
Removed inline copy of QExplicitlySharedDataPointer. This is not needed anymore since we require Qt >= 4.3.0.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFor the build inside Qt include qbase.pri and don't duplicate what qbase.pri otherwis...
hausmann@webkit.org [Thu, 22 Nov 2007 10:11:22 +0000 (10:11 +0000)]
For the build inside Qt include qbase.pri and don't duplicate what qbase.pri otherwise does (install targets, etc.)

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoDon't set OBJECTS_DIR when building inside Qt
hausmann@webkit.org [Thu, 22 Nov 2007 10:11:05 +0000 (10:11 +0000)]
Don't set OBJECTS_DIR when building inside Qt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27961 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUse ../generated as path for the generated sources for builds inside Qt
hausmann@webkit.org [Thu, 22 Nov 2007 10:10:51 +0000 (10:10 +0000)]
Use ../generated as path for the generated sources for builds inside Qt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMake the directory of where to put the generated sources configurable through the...
hausmann@webkit.org [Thu, 22 Nov 2007 10:10:33 +0000 (10:10 +0000)]
Make the directory of where to put the generated sources configurable through the GENERATED_SOURCE_DIR variable

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoCentralize the setup for all the extra compilers in a addExtraCompiler function.
hausmann@webkit.org [Thu, 22 Nov 2007 10:10:07 +0000 (10:10 +0000)]
Centralize the setup for all the extra compilers in a addExtraCompiler function.

This allows adding a "generated_files" target that builds all generated files
using "make generated_files".  For the build inside Qt we do not generate
actual rules for the extra compilers but instead do the variable substitution
of compiler.output manually and add the generated sources to SOURCES.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix license headers
hausmann@webkit.org [Thu, 22 Nov 2007 09:08:28 +0000 (09:08 +0000)]
Fix license headers

Signed-off-by: Simon Hausmann <hausmann@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix shadowing of "page" variable that is passed as argument as well as a member variable.
hausmann@webkit.org [Thu, 22 Nov 2007 08:50:59 +0000 (08:50 +0000)]
Fix shadowing of "page" variable that is passed as argument as well as a member variable.

This also fixes compilation with gcc 4.3.

Signed-off-by: George Staikos <staikos@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27956 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Nov 2007 07:06:38 +0000 (07:06 +0000)]
2007-11-21  Eric Seidel  <eric@webkit.org>

        Speculative build fix for Tiger.

        * DumpRenderTree/mac/PixelDumpSupport.mm: include unistd.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27955 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoUpdate changelog entry to match reality.
mrowe@apple.com [Thu, 22 Nov 2007 06:48:29 +0000 (06:48 +0000)]
Update changelog entry to match reality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Eric Seidel.
timothy@apple.com [Thu, 22 Nov 2007 05:54:48 +0000 (05:54 +0000)]
    Reviewed by Eric Seidel.

        Show Fonts as Yellow in the network timeline.

        * page/inspector/NetworkPanel.js:
        * page/inspector/inspector.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
mitz@apple.com [Thu, 22 Nov 2007 05:23:20 +0000 (05:23 +0000)]

        Reviewed by Eric Seidel.

        - fix <rdar://problem/5607037> REGRESSION (r27351): Departure date does not repaint when changed on Google Maps public transit planner (16034)

        Test: fast/repaint/subtree-root-skipped.html

        * page/FrameView.cpp:
        (WebCore::FrameViewPrivate::FrameViewPrivate): Initialize the layout
        root to 0.
        (WebCore::FrameView::layoutRoot): Changed to return a RenderObject
        instead of a Node.
        (WebCore::FrameView::layout): Changed for layout root being a renderer
        rather than a DOM node. Also replaced clearing the repaint rects
        set with asserting that it is empty if this is the top-level call to
        layout(). If it is not, the set may contain rects from enclosing
        layout() and those should not be removed.
        (WebCore::FrameView::scheduleRelayout): Changed for layout root being
        a renderer rather than a DOM node.
        (WebCore::isObjectAncestorContainerOf): Added this helper function that
        tests whether one object will be marked by calling
        markContainingBlocksForLayout() on the other.
        (WebCore::FrameView::scheduleRelayoutOfSubtree): Changed for layout
        root being a renderer rather than a DOM node. Changed the check if new
        and current layout roots are on the same path from the root to use
        the subgraph of the render tree defined by container()hood instead of
        the DOM tree and parenthood.
        * page/FrameView.h:
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcWidth): Changed for layout root being a
        renderer rather than a DOM node.
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::~RenderObject): Added an assertion that the
        object being deleted is not currently the layout root.
        (WebCore::RenderObject::scheduleRelayout): Changed for layout root being
        a renderer rather than a DOM node.


        Reviewed by Eric Seidel.

        - repaint test for <rdar://problem/5607037> REGRESSION (r27351): Departure date does not repaint when changed on Google Maps public transit planner (16034)

        * fast/repaint/subtree-root-skipped.html: Added.
        * platform/mac-leopard/fast/repaint/subtree-root-skipped-expected.checksum: Added.
        * platform/mac-leopard/fast/repaint/subtree-root-skipped-expected.png: Added.
        * platform/mac/fast/repaint/subtree-root-skipped-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix JavaScriptGlue, WebCore and WebKit to build without warnings using GCC 4.2.
mrowe@apple.com [Thu, 22 Nov 2007 04:32:46 +0000 (04:32 +0000)]
Fix JavaScriptGlue, WebCore and WebKit to build without warnings using GCC 4.2.

Reviewed by Eric.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-21 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Thu, 22 Nov 2007 04:13:22 +0000 (04:13 +0000)]
2007-11-21  Mark Rowe  <mrowe@apple.com>

        Reviewed by Eric.

        Update coding style to cover control statements with no body.

        * coding/coding-style.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Nov 2007 04:03:18 +0000 (04:03 +0000)]
2007-11-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Tim Hatcher.

        Break out more of DumpRenderTree.mm into individual files

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/CheckedMalloc.cpp: Added.
        * DumpRenderTree/mac/CheckedMalloc.h: Added.
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/DumpRenderTreeMac.h:
        * DumpRenderTree/mac/DumpRenderTreePasteboard.h:
        * DumpRenderTree/mac/DumpRenderTreePasteboard.m:
        * DumpRenderTree/mac/DumpRenderTreeWindow.h:
        * DumpRenderTree/mac/DumpRenderTreeWindow.mm:
        * DumpRenderTree/mac/JavaScriptThreading.cpp: Added.
        * DumpRenderTree/mac/JavaScriptThreading.h: Added.
        * DumpRenderTree/mac/PixelDumpSupport.h: Added.
        * DumpRenderTree/mac/PixelDumpSupport.mm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-21 Alp Toker <alp@atoker.com>
alp@webkit.org [Thu, 22 Nov 2007 03:28:14 +0000 (03:28 +0000)]
2007-11-21  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Curl backend handles EINTR incorrectly

        Defer timers during select() to avoid interruption by timer signals.

        * platform/network/curl/ResourceHandleManager.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/5602936> Need to resolve new GCC 4.2 warnings.
mrowe@apple.com [Thu, 22 Nov 2007 03:08:41 +0000 (03:08 +0000)]
Fix <rdar://problem/5602936> Need to resolve new GCC 4.2 warnings.

Reviewed by Tim Hatcher.

Fix all warnings emitted by GCC 4.2 when building JavaScriptCore.  This allows builds with
-Werror to succeed.  At present they will crash when executed due to code that is not safe
under strict aliasing (<rdar://problem/5536806>).

This required some format strings to be modified in WebCore and WebKit as their format
specifiers did not match the argument type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27947 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRestore the wx buildbot for Mac by automatically installing dependencies not provided...
kevino@webkit.org [Thu, 22 Nov 2007 03:01:59 +0000 (03:01 +0000)]
Restore the wx buildbot for Mac by automatically installing dependencies not provided by the OS into WebKitLibraries.

Reviewed by Mark Rowe

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27946 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 22 Nov 2007 02:19:12 +0000 (02:19 +0000)]
2007-11-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam.

        More refactoring for greater code readability

        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/DumpRenderTreeMac.h:
        * DumpRenderTree/mac/UIDelegate.mm:
        (-[UIDelegate webView:createWebViewWithRequest:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27945 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-21 Xan Lopez <xan@gnome.org>
alp@webkit.org [Thu, 22 Nov 2007 00:24:35 +0000 (00:24 +0000)]
2007-11-21  Xan Lopez  <xan@gnome.org>

        Reviewed by Alp Toker.

        Clarify scroll event processing with a comment.

        * platform/gtk/PlatformScrollBarGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
timothy@apple.com [Wed, 21 Nov 2007 23:40:16 +0000 (23:40 +0000)]
    Reviewed by Adam Roben.

        Bug 16085: Web Inspector's Network Timeline graph code clean up and misc. fixes

        Changes include:
        - Refactor the drawing code as nested functions instead of global functions.
        - Compute the segment percentages only once per call to drawSummaryGraph.
        - Account for percentages that rounded down to total less-than 100%.
        - Draw the pill shadow better using the canvas shadow drawing properties.
        - Removes a couple canvas context saves and restores.

        * page/inspector/NetworkPanel.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 21 Nov 2007 19:29:08 +0000 (19:29 +0000)]
2007-11-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Tim Hatcher.

        Abstract more of DRT into static methods

        * DumpRenderTree/mac/DumpRenderTree.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27942 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 21 Nov 2007 19:28:36 +0000 (19:28 +0000)]
2007-11-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Tim Hatcher.

        Pull DumpRenderTreeWindow and DumpRenderTreePasteboard out into their own files

        * DumpRenderTree/DumpRenderTree.h:
        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
        * DumpRenderTree/mac/DumpRenderTree.mm:
        * DumpRenderTree/mac/DumpRenderTreePasteboard.h: Added.
        * DumpRenderTree/mac/DumpRenderTreePasteboard.m: Added.
        (+[DumpRenderTreePasteboard _pasteboardWithName:]):
        (+[DumpRenderTreePasteboard releaseLocalPasteboards]):
        (-[DumpRenderTreePasteboard declareType:owner:]):
        (+[LocalPasteboard alloc]):
        (-[LocalPasteboard init]):
        (-[LocalPasteboard dealloc]):
        (-[LocalPasteboard name]):
        (-[LocalPasteboard releaseGlobally]):
        (-[LocalPasteboard declareTypes:owner:]):
        (-[LocalPasteboard addTypes:owner:]):
        (-[LocalPasteboard changeCount]):
        (-[LocalPasteboard types]):
        (-[LocalPasteboard availableTypeFromArray:]):
        (-[LocalPasteboard setData:forType:]):
        (-[LocalPasteboard dataForType:]):
        (-[LocalPasteboard setPropertyList:forType:]):
        (-[LocalPasteboard setString:forType:]):
        * DumpRenderTree/mac/DumpRenderTreeWindow.h: Added.
        * DumpRenderTree/mac/DumpRenderTreeWindow.mm: Added.
        (+[DumpRenderTreeWindow allWindows]):
        (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
        (-[DumpRenderTreeWindow dealloc]):
        (-[DumpRenderTreeWindow isKeyWindow]):
        (-[DumpRenderTreeWindow keyDown:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Connect up the signal for all subframes too.
treat@webkit.org [Wed, 21 Nov 2007 13:02:36 +0000 (13:02 +0000)]
* Connect up the signal for all subframes too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Wed, 21 Nov 2007 12:20:33 +0000 (12:20 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5230233> dom/xhtml/level2/html/frame.xhtml is failing on Windows

        This isn't actually a test, but an unused resource - we should re-work the W3C test rig to
        support subresource loading from (X)HTML.
        Anyway, it doesn't fail for me, I suppose this problem was fixed since the bug was filed.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
ap@webkit.org [Wed, 21 Nov 2007 11:54:51 +0000 (11:54 +0000)]
    Reviewed by Maciej.

        Fix a copy/paste error in the test (introduced in bug 12194).

        * http/tests/xmlhttprequest/zero-length-response-sync-expected.txt:
        * http/tests/xmlhttprequest/zero-length-response-sync.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
ap@webkit.org [Wed, 21 Nov 2007 08:10:12 +0000 (08:10 +0000)]
    Reviewed by Adam Roben.

        Unicode not being interpreted correctly in Web Inspector source view

        Cannot be tested automatically.

        * loader/CachedCSSStyleSheet.cpp:
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedResource.h:
        * loader/CachedScript.cpp:
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        * loader/CachedXSLStyleSheet.h:
        Teach textual CachedResources to report their encodings.

        * page/InspectorController.cpp:
        Use the actual encoding - the network layer has little idea about it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix <rdar://problem/5609579> (DOMParser().parseFromString() freezes Safari when parsi...
mrowe@apple.com [Wed, 21 Nov 2007 07:29:50 +0000 (07:29 +0000)]
Fix <rdar://problem/5609579> (DOMParser().parseFromString() freezes Safari when parsing large nodes with XML entities)

Reviewed by Maciej Stachowiak.

XMLTokenizer was calling CharacterData::appendData twice per entity in the fragment of XML being
parsed (once for text before the entity, once for the entity itself).  This triggered O(n^2) copying
of the CharacterData's string due to resizing.  We now prevent this happening by buffering all the
content for a given Text node in the XMLTokenizer before sending it out to the node in a single go.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
timothy@apple.com [Wed, 21 Nov 2007 06:55:32 +0000 (06:55 +0000)]
    Reviewed by Mark Rowe.

        Animate the status area and tip balloons in the Web Inspector
        with CSS animations.

        * page/inspector/NetworkPanel.js:
        * page/inspector/inspector.css:
        * page/inspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agowx build fix for Windows. Don't use WebCore/move-js-headers.sh as it indiscriminately...
kevino@webkit.org [Wed, 21 Nov 2007 01:14:27 +0000 (01:14 +0000)]
wx build fix for Windows. Don't use WebCore/move-js-headers.sh as it indiscriminately copies any headers inside JavaScriptCore, which includes Tiger ICU headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-20 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 20 Nov 2007 22:11:51 +0000 (22:11 +0000)]
2007-11-20  Alp Toker  <alp@atoker.com>

        Reviewed by Mark Rowe.

        Avoid pointlessly mallocing and freeing this transform matrix.

        * platform/gtk/FontPlatformDataGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-20 Naiem Shaik <naiem.shaik@gmail.com>
alp@webkit.org [Tue, 20 Nov 2007 21:46:26 +0000 (21:46 +0000)]
2007-11-20  Naiem Shaik  <naiem.shaik@gmail.com>

        Reviewed by Alp Toker.

        [GTK] Enter key does not take to the link highlighted.

        Add missing keycode cases.

        * platform/gtk/KeyEventGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFix http://bugs.webkit.org/show_bug.cgi?id=16074
mrowe@apple.com [Tue, 20 Nov 2007 21:36:34 +0000 (21:36 +0000)]
Fix http://bugs.webkit.org/show_bug.cgi?id=16074
Bug 16074: execCommand("InsertHorizontalRule", false, "") results in id="" being inserted

For consistency with InsertOrderedList and InsertUnorderedList a value parameter of "" should
not result in an id being set.

Reviewed by Sam Weinig.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago* Prepend git branch name to $baseProductDir
treat@webkit.org [Tue, 20 Nov 2007 18:01:54 +0000 (18:01 +0000)]
* Prepend git branch name to $baseProductDir

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam Roben.
mitz@apple.com [Tue, 20 Nov 2007 17:38:54 +0000 (17:38 +0000)]
    Reviewed by Adam Roben.

        - fix <rdar://problem/5090708> Textareas render broken-looking scrollbars when too short to show full scrollbar

        * platform/win/PlatformScrollBar.h:
        * platform/win/PlatformScrollBarSafari.cpp:
        Added the "hit inset" constants (representing how far the track eats
        into the button).
        (WebCore::PlatformScrollbar::paint): Changed to paint the buttons and
        the thumb only if they should be showing.
        (WebCore::PlatformScrollbar::hasButtons): Added. Returns whether the
        arrows should be drawn.
        (WebCore::PlatformScrollbar::hasThumb): Added. Returns whether the thumb
        should be drawn.
        (WebCore::PlatformScrollbar::trackRect): Changed to return the entire
        bounds of the scrollbar if the scrollbar has no buttons.
        (WebCore::PlatformScrollbar::paintTrack): Changed to paint a disabled
        track along the entire scrollbar if it has not buttons.
        (WebCore::PlatformScrollbar::hitTest): Changed to hit test only the
        parts that the scrollbar has in its current dimensions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-20 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 20 Nov 2007 16:06:23 +0000 (16:06 +0000)]
2007-11-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp Toker.

        * WebKit.pri: Add in -Wno-unused-parameter to silence warnings in WebCore.

2007-11-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Alp Toker.

        * config.h: Change #if to #ifdef to silence warnings on non-Apple platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-20 Mark Rowe <mrowe@apple.com>
mrowe@apple.com [Tue, 20 Nov 2007 15:53:35 +0000 (15:53 +0000)]
2007-11-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Simon Hausmann.

        * Scripts/build-webkit:  Pass "clean" flag down into buildQMakeProject.
        * Scripts/webkitdirs.pm: Respect the "clean" flag passed down from build-webkit.
        Have it trigger a "make distclean" rather than "make clean" to ensure that the
        built product and generated Makefile's are removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-11-20 Alp Toker <alp@atoker.com>
alp@webkit.org [Tue, 20 Nov 2007 15:35:49 +0000 (15:35 +0000)]
2007-11-20  Alp Toker  <alp@atoker.com>

        Reviewed by Simon Hausmann.

        Clean up GTK+ port configuration.

        Use similar compiler warning flags to the Mac build.

        Add the qmake changes needed for DirectFB support.

        * WebKit.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemove static linkage of QtWebKit against the ICO image format plugin.
hausmann@webkit.org [Tue, 20 Nov 2007 15:27:36 +0000 (15:27 +0000)]
Remove static linkage of QtWebKit against the ICO image format plugin.

Instead build the support for the ICO image format as a proper standalone qt image format plugin and install it.

Signed-off-by: Adam Treat <treat@kde.org>
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@27925 268f45cc-cd09-0410-ab3c-d52691b4dbfc