WebKit-https.git
9 years ago[Chromium] Unreviewed, rebaseline SVG tests after r105061.
apavlov@chromium.org [Mon, 16 Jan 2012 18:05:06 +0000 (18:05 +0000)]
[Chromium] Unreviewed, rebaseline SVG tests after r105061.

* platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-linux-x86/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-linux-x86/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Added.
* platform/chromium-linux-x86/svg/foreignObject/text-tref-02-b-expected.png: Added.
* platform/chromium-linux-x86/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
* platform/chromium-linux-x86/svg/text/text-align-02-b-expected.png: Added.
* platform/chromium-linux-x86/svg/text/text-align-03-b-expected.png: Added.
* platform/chromium-linux-x86/svg/text/text-spacing-01-b-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.txt: Copied from LayoutTests/platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt.
* platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-linux/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-linux/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
* platform/chromium-linux/svg/text/select-textLength-spacing-squeeze-2-expected.txt: Removed.
* platform/chromium-linux/svg/text/text-path-01-b-expected.png:
* platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt:
* platform/chromium-mac-leopard/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-mac-leopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-leopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-leopard/svg/text/text-align-01-b-expected.png:
* platform/chromium-mac-leopard/svg/text/text-align-03-b-expected.png:
* platform/chromium-mac-leopard/svg/text/text-tselect-02-f-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textAnchor-expected.png:
* platform/chromium-mac-snowleopard/svg/batik/text/textProperties2-expected.png:
* platform/chromium-mac-snowleopard/svg/foreignObject/text-tref-02-b-expected.png:
* platform/chromium-mac-snowleopard/svg/text/bidi-text-anchor-direction-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-1-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-2-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-3-expected.png:
* platform/chromium-mac-snowleopard/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.png:
* platform/chromium-mac-snowleopard/svg/text/text-align-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/text/text-align-03-b-expected.png:
* platform/chromium-mac-snowleopard/svg/text/text-spacing-01-b-expected.png:
* platform/chromium-mac-snowleopard/svg/text/text-tselect-02-f-expected.png:
* platform/chromium-mac-snowleopard/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt: Renamed from LayoutTests/platform/chromium/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-win-vista/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
* platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/chromium-win-xp/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-default-context-expected.txt: Removed.
* platform/chromium-win-xp/svg/W3C-I18N/tspan-dirRTL-ubOverride-in-ltr-context-expected.txt: Removed.
* platform/chromium-win-xp/svg/text/bidi-text-anchor-direction-expected.txt: Removed.
* platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-default-context-expected.txt:
* platform/chromium-win/svg/W3C-I18N/tspan-dirNone-ubOverride-in-ltr-context-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-04-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/coords-trans-04-t-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
* platform/chromium-win/svg/batik/text/verticalTextOnPath-expected.txt:
* platform/chromium-win/svg/custom/js-late-pattern-and-object-creation-expected.txt:
* platform/chromium-win/svg/custom/tref-update-expected.txt:
* platform/chromium-win/svg/foreignObject/text-tref-02-b-expected.png:
* platform/chromium-win/svg/text/select-textLength-spacing-squeeze-2-expected.txt:
* platform/chromium-win/svg/text/select-textLength-spacing-squeeze-4-expected.png:
* platform/chromium-win/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
* platform/chromium-win/svg/text/text-align-02-b-expected.png:
* platform/chromium-win/svg/text/text-align-03-b-expected.png:
* platform/chromium-win/svg/text/text-align-04-b-expected.txt:
* platform/chromium-win/svg/text/text-align-06-b-expected.png:
* platform/chromium-win/svg/text/text-align-06-b-expected.txt:
* platform/chromium-win/svg/text/text-spacing-01-b-expected.png:
* platform/chromium-win/svg/text/text-text-01-b-expected.txt:
* platform/chromium-win/svg/text/text-tspan-01-b-expected.txt:
* platform/chromium-win/svg/text/text-ws-01-t-expected.txt:
* platform/chromium-win/svg/text/text-ws-02-t-expected.txt:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:
* platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.png:
* platform/chromium-win/svg/zoom/text/zoom-coords-viewattr-01-b-expected.txt:
* platform/chromium/svg/text/bidi-text-anchor-direction-expected.png: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105073 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd myself as a committer
danw@gnome.org [Mon, 16 Jan 2012 18:03:40 +0000 (18:03 +0000)]
Add myself as a committer

Unreviewed

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105072 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: timeline record bars may overlap with the records column
pfeldman@chromium.org [Mon, 16 Jan 2012 17:31:36 +0000 (17:31 +0000)]
Web Inspector: timeline record bars may overlap with the records column
https://bugs.webkit.org/show_bug.cgi?id=76387

Reviewed by Yury Semikhatsky.

* inspector/front-end/timelinePanel.css:
(#timeline-container .split-view-sidebar-left):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105071 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: styles sidebar rendering is broken
apavlov@chromium.org [Mon, 16 Jan 2012 17:24:28 +0000 (17:24 +0000)]
Web Inspector: styles sidebar rendering is broken
https://bugs.webkit.org/show_bug.cgi?id=76065

Reviewed by Pavel Feldman.

Source/WebCore:

* inspector/front-end/StylesSidebarPane.js:
(WebInspector.StylePropertiesSection):
* inspector/front-end/elementsPanel.css:
(.styles-section .header .subtitle):
(.styles-section .properties):

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.dumpSelectedElementStyles): Fix dump output due to DOM changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105070 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed...
kubo@profusion.mobi [Mon, 16 Jan 2012 17:18:21 +0000 (17:18 +0000)]
Unreviewed; fix the build when --as-needed and --no-copy-dt-needed-entries are passed to the linker.

Some recent versions of a few Linux distributions have started passing
--as-needed and --no-copy-dt-needed-entries by default to the linker,
which broke the build when SHARED_CORE was turned on, as libwtf_efl.so
needed a few symbols from libjavascriptcore_efl.so.

* DumpRenderTree/efl/CMakeLists.txt: Explicitly pass WTF_LIBRARY_NAME
before JavaScriptCore_LIBRARY_NAME in DumpRenderTree_LIBRARIES so the
libraries are searched in the right order by the linker.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105069 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Inremental build problem revealed by https://bugs.webkit.org/show_bug.cgi?id...
ossy@webkit.org [Mon, 16 Jan 2012 17:17:53 +0000 (17:17 +0000)]
[Qt] Inremental build problem revealed by https://bugs.webkit.org/show_bug.cgi?id=74455

Reviewed by Tor Arne Vestbø.

* DerivedSources.pri: supplemental_dependency.tmp must depends on idl files too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105068 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: do not merge iframes into a single DOM hierarchy.
pfeldman@chromium.org [Mon, 16 Jan 2012 16:56:19 +0000 (16:56 +0000)]
Web Inspector: do not merge iframes into a single DOM hierarchy.
https://bugs.webkit.org/show_bug.cgi?id=76383

Reviewed by Timothy Hatcher.

Source/WebCore:

* inspector/DOMEditor.h:
* inspector/Inspector.json:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::unbind):
(WebCore::InspectorDOMAgent::buildObjectForNode):
(WebCore::InspectorDOMAgent::innerFirstChild):
(WebCore::InspectorDOMAgent::innerParentNode):
* inspector/front-end/CSSStyleModel.js:
(WebInspector.CSSStyleModel.prototype.setRuleSelector.callback):
(WebInspector.CSSStyleModel.prototype.setRuleSelector):
(WebInspector.CSSStyleModel.prototype.addRule.callback):
(WebInspector.CSSStyleModel.prototype.addRule):
(WebInspector.CSSStyleModel.prototype._ownerDocumentId):
* inspector/front-end/DOMAgent.js:
(WebInspector.DOMNode):
(WebInspector.DOMNode.prototype.getChildNodes):
(WebInspector.DOMNode.prototype._insertChild):
(WebInspector.DOMNode.prototype._setChildrenPayload):
(WebInspector.DOMDocument):
(WebInspector.DOMAgent.prototype._setDetachedRoot):
* inspector/front-end/ElementsTreeOutline.js:

LayoutTests:

* http/tests/inspector/elements-test.js:
(initialize_ElementTest.InspectorTest.findNode.processChildren):
* inspector/console/console-dirxml-expected.txt:
* inspector/console/console-tests-expected.txt:
* inspector/elements/set-outer-html-body.html:
* inspector/styles/styles-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105067 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: setCurrentFocusElement should not update selection when focus is moved...
vsevik@chromium.org [Mon, 16 Jan 2012 16:47:19 +0000 (16:47 +0000)]
Web Inspector: setCurrentFocusElement should not update selection when focus is moved to text field or text area.
https://bugs.webkit.org/show_bug.cgi?id=76384

Reviewed by Timothy Hatcher.

* inspector/front-end/JavaScriptOutlineDialog.js:
(WebInspector.JavaScriptOutlineDialog):
* inspector/front-end/UIUtils.js:
(WebInspector._isTextEditingElement):
(WebInspector.setCurrentFocusElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105066 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] set audio resources path in NRTW
philn@webkit.org [Mon, 16 Jan 2012 16:13:20 +0000 (16:13 +0000)]
[GTK] set audio resources path in NRTW
https://bugs.webkit.org/show_bug.cgi?id=76380

Reviewed by Martin Robinson.

* Scripts/webkitpy/layout_tests/port/gtk.py:
(GtkPort.setup_environ_for_server): Set $AUDIO_RESOURCES_PATH so
the uninstalled audio resources are used during webaudio tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105065 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r105061.
philn@webkit.org [Mon, 16 Jan 2012 16:08:53 +0000 (16:08 +0000)]
Unreviewed, GTK rebaseline after r105061.

* platform/gtk/svg/carto.net/colourpicker-expected.txt:
* platform/gtk/svg/carto.net/combobox-expected.txt:
* platform/gtk/svg/carto.net/slider-expected.txt:
* platform/gtk/svg/carto.net/textbox-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105064 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK baselines for new tests.
philn@webkit.org [Mon, 16 Jan 2012 16:00:23 +0000 (16:00 +0000)]
Unreviewed, GTK baselines for new tests.

* platform/gtk/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
* platform/gtk/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
* platform/gtk/fast/borders/border-image-slice-constrained-expected.txt: Added.
* platform/gtk/fast/text/unicode-variation-selector-expected.txt: Added.
* platform/gtk/http/tests/media/video-buffering-repaints-controls-expected.txt: Added.
* platform/gtk/media/video-colorspace-yuv420-expected.txt: Added.
* platform/gtk/media/video-colorspace-yuv422-expected.txt: Added.
* platform/gtk/svg/custom/pattern-userSpaceOnUse-userToBaseTransform-expected.txt: Added.
* platform/gtk/svg/filters/filter-refresh-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105063 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove references to PagePointer in the FrameNetworkingContext
commit-queue@webkit.org [Mon, 16 Jan 2012 14:28:27 +0000 (14:28 +0000)]
[Qt] Remove references to PagePointer in the FrameNetworkingContext
https://bugs.webkit.org/show_bug.cgi?id=76342

Patch by Alexander Færøy <alexander.faeroy@nokia.com> on 2012-01-16
Reviewed by Simon Hausmann.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createNetworkingContext):
* WebProcess/qt/QtNetworkAccessManager.cpp:
(WebKit::QtNetworkAccessManager::obtainOriginatingWebPage):
* WebProcess/qt/QtNetworkAccessManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105062 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLarge SVG text layout performance regression in r81168
zimmermann@webkit.org [Mon, 16 Jan 2012 14:04:25 +0000 (14:04 +0000)]
Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Source/WebCore:

Enable simple code path in SVGTextMetricsBuilder, allowing fast-measurement of simple text.
This affects the geometry of several <text> elements, thus several tests need rebaselining.

* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):

LayoutTests:

Update some test results after enabling the simple code path to measure SVG text.

* platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png:
* platform/mac/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/filters-comptran-01-b-expected.txt:
* platform/mac/svg/W3C-SVG-1.1/text-text-01-b-expected.txt:
* platform/mac/svg/batik/text/smallFonts-expected.png:
* platform/mac/svg/batik/text/textAnchor-expected.txt:
* platform/mac/svg/carto.net/window-expected.png:
* platform/mac/svg/carto.net/window-expected.txt:
* platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-clipPath-and-object-creation-expected.txt:
* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-gradient-and-object-creation-expected.txt:
* platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.png:
* platform/mac/svg/custom/js-late-pattern-and-object-creation-expected.txt:
* platform/mac/svg/custom/text-repaint-including-stroke-expected.png:
* platform/mac/svg/custom/use-clipped-hit-expected.txt:
* platform/mac/svg/custom/use-detach-expected.png:
* platform/mac/svg/custom/use-detach-expected.txt:
* platform/mac/svg/foreignObject/text-tref-02-b-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-1-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-2-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-3-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.png:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-squeeze-4-expected.txt:
* platform/mac/svg/text/select-textLength-spacingAndGlyphs-stretch-4-expected.txt:
* platform/mac/svg/text/text-align-01-b-expected.png:
* platform/mac/svg/text/text-align-01-b-expected.txt:
* platform/mac/svg/text/text-align-02-b-expected.txt:
* platform/mac/svg/text/text-align-04-b-expected.txt:
* platform/mac/svg/text/text-align-06-b-expected.png:
* platform/mac/svg/text/text-align-06-b-expected.txt:
* platform/mac/svg/text/text-deco-01-b-expected.txt:
* platform/mac/svg/text/text-fonts-01-t-expected.txt:
* platform/mac/svg/text/text-spacing-01-b-expected.png:
* platform/mac/svg/text/text-text-04-t-expected.png:
* platform/mac/svg/text/text-text-05-t-expected.png:
* platform/mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.txt:
* platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/mac/svg/transforms/text-with-pattern-with-svg-transform-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105061 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: CodeGeneratorInspector.py: generate array types.
commit-queue@webkit.org [Mon, 16 Jan 2012 13:44:14 +0000 (13:44 +0000)]
Web Inspector: CodeGeneratorInspector.py: generate array types.
https://bugs.webkit.org/show_bug.cgi?id=75284

Patch by Peter Rybin <peter.rybin@gmail.com> on 2012-01-16
Reviewed by Yury Semikhatsky.

New classes are generated for ecah array type instance. Some includes
and ifdefs are fixed.

* inspector/CodeGeneratorInspector.py:
(ArrayBinding):
(ArrayBinding.get_code_generator):
(ArrayBinding.get_code_generator.CodeGenerator):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.get_type_name_fix.NameFix.output_comment):
(ArrayBinding.get_code_generator.CodeGenerator.generate_type_builder.AdHocTypeContext.call_generate_type_builder):
(ArrayBinding.get_code_generator.CodeGenerator.generate_forward_declaration):
(ArrayBinding.get_code_generator.CodeGenerator.register_use):
(ArrayBinding.get_in_c_type_text):
(ArrayBinding.get_setter_value_expression_pattern):
(ArrayBinding.reduce_to_raw_type):
(RawTypeBinding):
(RawTypeBinding.__init__):
(RawTypeBinding.get_code_generator):
(RawTypeBinding.get_in_c_type_text):
(RawTypeBinding.get_setter_value_expression_pattern):
(RawTypeBinding.reduce_to_raw_type):
(TypeData.__init__):
(TypeData.get_binding):
* inspector/ConsoleMessage.cpp:
* inspector/InspectorValues.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105060 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Update NEWS and configure.ac for 1.7.4 release
carlosgc@webkit.org [Mon, 16 Jan 2012 13:40:04 +0000 (13:40 +0000)]
[GTK] Update NEWS and configure.ac for 1.7.4 release
https://bugs.webkit.org/show_bug.cgi?id=76375

Reviewed by Philippe Normand.

.:

* configure.ac: Bumped version number.

Source/WebKit/gtk:

* NEWS: Added release notes for 1.7.4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105059 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: editing body multiplies head
pfeldman@chromium.org [Mon, 16 Jan 2012 13:35:04 +0000 (13:35 +0000)]
Web Inspector: editing body multiplies head
https://bugs.webkit.org/show_bug.cgi?id=62272

Patch by Pavel Feldman <pfeldman@chromium.org> on 2012-01-15
Reviewed by Yury Semikhatsky.

Source/WebCore:

Test: inspector/elements/set-outer-html-body.html

* inspector/DOMEditor.cpp:
(WebCore::DOMEditor::patchDocument):
(WebCore::DOMEditor::patchNode):
(WebCore::DOMEditor::innerPatchChildren):
(WebCore::DOMEditor::insertBefore):
* inspector/DOMEditor.h:
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::setOuterHTML):

LayoutTests:

* inspector/elements/resources/set-outer-html-body-iframe.html: Added.
* inspector/elements/set-outer-html-body-expected.txt: Added.
* inspector/elements/set-outer-html-body.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105058 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoLarge SVG text layout performance regression in r81168
zimmermann@webkit.org [Mon, 16 Jan 2012 13:08:29 +0000 (13:08 +0000)]
Large SVG text layout performance regression in r81168
https://bugs.webkit.org/show_bug.cgi?id=65711

Reviewed by Zoltan Herczeg.

Change the way we store x/y/dx/dy/rotate values for a <text> element and its ancestors.

SVGTextLayoutAttributesBuilder used to hold a Vector<float> for x/y/dx/dy/rotate, each as big
as the whole text subtree length. For each character, that has an absolute position, or rotation
the value was stored in this list. For all other characters a special empty value marker was stored.

This is highly inefficient, and is now replaced with a HashMap<unsigned, SVGCharacterData> where
SVGCharacterData is a struct, holding float x/y/dx/dy/rotate. The code is now optimized for the
common case, where only a few characters actually specify such values, eg:
<text x="50" y="90">looooong text<tspan x="50" y="30">abc</tspan></text>.

NOTE: There are still some inefficiencies in this patch (especially the copying of SVGTextLayoutAttributes).
To keep the patch size smaller, I decided to fix this in another patch, and only fix the memory issue with this patch.

This reduces the memory consumption from 35MB to 10MB on the attached testcase in bug 65711.

Doesn't affect any test, yet. A follow-up commit will enable the usage of the simple code path, using WidthIterator,
in SVGTextMetricsBuilder, which will result in several layout test changes, because of geometry changes.

* rendering/svg/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::RenderSVGInlineText):
(WebCore::RenderSVGInlineText::characterStartsNewTextChunk):
* rendering/svg/RenderSVGInlineText.h:
(WebCore::RenderSVGInlineText::layoutAttributes):
* rendering/svg/RenderSVGText.cpp:
(WebCore::RenderSVGText::layout):
(WebCore::recursiveCollectLayoutAttributes):
(WebCore::RenderSVGText::rebuildLayoutAttributes):
* rendering/svg/RenderSVGText.h:
* rendering/svg/SVGRootInlineBox.cpp:
(WebCore::SVGRootInlineBox::computePerCharacterLayoutInformation):
(WebCore::SVGRootInlineBox::layoutCharactersInTextBoxes):
(WebCore::SVGRootInlineBox::closestLeafChildForPosition):
(WebCore::swapItemsInLayoutAttributes):
(WebCore::findFirstAndLastAttributesInVector):
(WebCore::reverseInlineBoxRangeAndValueListsIfNeeded):
* rendering/svg/SVGTextLayoutAttributes.cpp:
(WebCore::SVGTextLayoutAttributes::clear):
(WebCore::dumpSVGCharacterDataMapValue):
(WebCore::SVGTextLayoutAttributes::dump):
* rendering/svg/SVGTextLayoutAttributes.h:
(WebCore::SVGTextLayoutAttributes::characterDataMap):
* rendering/svg/SVGTextLayoutAttributesBuilder.cpp:
(WebCore::SVGTextLayoutAttributesBuilder::SVGTextLayoutAttributesBuilder):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForTextRenderer):
(WebCore::SVGTextLayoutAttributesBuilder::rebuildMetricsForWholeTree):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributesIfNeeded):
(WebCore::processRenderSVGInlineText):
(WebCore::SVGTextLayoutAttributesBuilder::collectTextPositioningElements):
(WebCore::SVGTextLayoutAttributesBuilder::buildLayoutAttributes):
(WebCore::updateCharacterData):
(WebCore::SVGTextLayoutAttributesBuilder::fillCharacterDataMap):
* rendering/svg/SVGTextLayoutAttributesBuilder.h:
(WebCore::SVGTextLayoutAttributesBuilder::clearTextPositioningElements):
* rendering/svg/SVGTextLayoutEngine.cpp:
(WebCore::SVGTextLayoutEngine::updateRelativePositionAdjustmentsIfNeeded):
(WebCore::SVGTextLayoutEngine::currentLogicalCharacterAttributes):
(WebCore::SVGTextLayoutEngine::layoutTextOnLineOrPath):
* rendering/svg/SVGTextLayoutEngine.h:
(WebCore::SVGTextLayoutEngine::layoutAttributes):
* rendering/svg/SVGTextMetricsBuilder.cpp:
(WebCore::SVGTextMetricsBuilder::advance):
(WebCore::SVGTextMetricsBuilder::advanceComplexText):
(WebCore::SVGTextMetricsBuilder::measureTextRenderer):
* rendering/svg/SVGTextQuery.cpp:
(WebCore::SVGTextQuery::modifyStartEndPositionsRespectingLigatures):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105057 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSSCanvasValue can't be renamed, enforce this at compile-time.
kling@webkit.org [Mon, 16 Jan 2012 13:00:39 +0000 (13:00 +0000)]
CSSCanvasValue can't be renamed, enforce this at compile-time.
<http://webkit.org/b/76352>

Reviewed by Antti Koivisto.

Have the CSSCanvasValue constructor take the name as an argument instead of
having a setName() that's only called from one place in CSSParser.

* css/CSSCanvasValue.h:
(WebCore::CSSCanvasValue::create):
(WebCore::CSSCanvasValue::CSSCanvasValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105056 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSSStyleSelector: Dodge parser when creating default LTR/RTL declarations.
kling@webkit.org [Mon, 16 Jan 2012 12:57:00 +0000 (12:57 +0000)]
CSSStyleSelector: Dodge parser when creating default LTR/RTL declarations.
<http://webkit.org/b/76374>

Reviewed by Antti Koivisto.

Pass CSSValueLtr/CSSValueRtl directly to setProperty() instead of parsing "ltr"/"rtl".

* css/CSSStyleSelector.cpp:
(WebCore::leftToRightDeclaration):
(WebCore::rightToLeftDeclaration):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105055 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Mon, 16 Jan 2012 12:25:55 +0000 (12:25 +0000)]
Unreviewed. Fix make distcheck.

Source/JavaScriptCore:

* GNUmakefile.list.am: Fix typo.

Source/WebCore:

* GNUmakefile.list.am: Add missing files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105054 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
carlosgc@webkit.org [Mon, 16 Jan 2012 12:19:41 +0000 (12:19 +0000)]
[GTK] ldflags and cflags should take precedence over the existing flags in gtkdoc.py
https://bugs.webkit.org/show_bug.cgi?id=76369

Reviewed by Xan Lopez.

If there's an installed version of webkit and there are new
symbols in the build tree, gtkdoc-scanobj fails due to undefined
references, because the env ldflags are given before the local
ones.

* gtk/gtkdoc.py:
(GTKDoc._run_gtkdoc_scangobj):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105053 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSSStyleSelector constructor and appendAuthorStylesheets() contain duplicated code
rolandsteiner@chromium.org [Mon, 16 Jan 2012 12:05:03 +0000 (12:05 +0000)]
CSSStyleSelector constructor and appendAuthorStylesheets() contain duplicated code
https://bugs.webkit.org/show_bug.cgi?id=76043

Re-use appendAuthorStylesheets() from within CSSStyleSelector constructor.

Reviewed by Antti Koivisto.

No new tests. (refactoring)

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::CSSStyleSelector):
* css/StyleSheetList.h:
(WebCore::StyleSheetList::vector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105052 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r105040.
commit-queue@webkit.org [Mon, 16 Jan 2012 11:32:40 +0000 (11:32 +0000)]
Unreviewed, rolling out r105040.
http://trac.webkit.org/changeset/105040
https://bugs.webkit.org/show_bug.cgi?id=76373

Breaks Win (dbg) canary builder (Requested by apavlov on
#webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-16

* WebKit.gypi:
* tests/DispatchEventTest.cpp: Removed.
* tests/data/event_target.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105051 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[crash] Renderer crashes when spell checking a disabled input field.
commit-queue@webkit.org [Mon, 16 Jan 2012 11:31:38 +0000 (11:31 +0000)]
[crash] Renderer crashes when spell checking a disabled input field.
https://bugs.webkit.org/show_bug.cgi?id=75941

Patch by Shinya Kawanaka <shinyak@google.com> on 2012-01-16
Reviewed by Hajime Morita.

.:

* ManualTests/editing-disabled-node-replace-crash.html: Added.

Source/WebCore:

We confirm the selection is editable before replacing text.

Tests: ManualTests/editing-disabled-node-replace-crash.html

* editing/Editor.cpp:
(WebCore::Editor::replaceSelectionWithFragment):
* editing/ReplaceSelectionCommand.cpp:
(WebCore::ReplaceSelectionCommand::doApply):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105050 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compilation errors on build-webkit --debug --no-svg --no-svg-fonts --no-svg-dom...
commit-queue@webkit.org [Mon, 16 Jan 2012 11:28:48 +0000 (11:28 +0000)]
Fix compilation errors on build-webkit --debug --no-svg --no-svg-fonts --no-svg-dom-objc-bindings on mac.
https://bugs.webkit.org/show_bug.cgi?id=75865

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-16
Reviewed by Hajime Morita.

Source/WebCore:

* WebCore.exp.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
* loader/cache/CachedImage.cpp:
(WebCore::CachedImage::setContainerSizeForRenderer):
(WebCore::CachedImage::imageSizeForRenderer):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::drawGlyphBuffer):
* rendering/FilterEffectRenderer.cpp:
* svg/SVGElementInstance.idl:

Source/WebKit/mac:

* WebView/WebFrame.mm:
(-[WebFrame _pauseSVGAnimation:onSMILNode:atTime:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105049 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCompilation error on build-webkit --debug --no-request-animation-frame on mac.
commit-queue@webkit.org [Mon, 16 Jan 2012 11:09:00 +0000 (11:09 +0000)]
Compilation error on build-webkit --debug --no-request-animation-frame on mac.
https://bugs.webkit.org/show_bug.cgi?id=75875

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-16
Reviewed by Hajime Morita.

* dom/Document.cpp:
(WebCore::Document::windowScreenDidChange):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105048 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, mark two inspector/debugger tests as SLOW on Linux Debug.
apavlov@chromium.org [Mon, 16 Jan 2012 11:04:37 +0000 (11:04 +0000)]
[Chromium] Unreviewed, mark two inspector/debugger tests as SLOW on Linux Debug.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105047 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Unreviewed, suppres webaudio/gain.html failures on Windows.
apavlov@chromium.org [Mon, 16 Jan 2012 10:55:50 +0000 (10:55 +0000)]
[Chromium] Unreviewed, suppres webaudio/gain.html failures on Windows.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105046 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Fix GoToLineDialog and extract common dialog functionality.
ossy@webkit.org [Mon, 16 Jan 2012 10:51:33 +0000 (10:51 +0000)]
Web Inspector: Fix GoToLineDialog and extract common dialog functionality.
https://bugs.webkit.org/show_bug.cgi?id=69341

Unreviewed trivial buildfix/typo fix after r105043.

* inspector/front-end/WebKit.qrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105045 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSolaris Studio supports alignment macros too
commit-queue@webkit.org [Mon, 16 Jan 2012 10:23:05 +0000 (10:23 +0000)]
Solaris Studio supports alignment macros too
https://bugs.webkit.org/show_bug.cgi?id=75453

Patch by Pavel Heimlich <tropikhajma@gmail.com> on 2012-01-16
Reviewed by Hajime Morita.

* wtf/Alignment.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105044 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWeb Inspector: Fix GoToLineDialog and extract common dialog functionality.
vsevik@chromium.org [Mon, 16 Jan 2012 09:56:44 +0000 (09:56 +0000)]
Web Inspector: Fix GoToLineDialog and extract common dialog functionality.
https://bugs.webkit.org/show_bug.cgi?id=69341

Fixed dialog: in old implementation dialog never hides if you press mouse button
on Go button and release it somewhere else.
Dialog functionality extracted to be used for search dialog.

Reviewed by Pavel Feldman.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/compile-front-end.sh:
* inspector/front-end/Dialog.js: Added.
(WebInspector.Dialog):
(WebInspector.Dialog.show):
(WebInspector.Dialog.prototype._hide):
(WebInspector.Dialog.prototype._onFocus):
(WebInspector.Dialog.prototype._doFocus):
(WebInspector.Dialog.prototype._position):
(WebInspector.Dialog.prototype._onKeyDown):
(WebInspector.Dialog.prototype._onClick):
(WebInspector.DialogDelegate):
(WebInspector.DialogDelegate.prototype.get defaultFocusedElement):
(WebInspector.DialogDelegate.prototype.get okButton):
(WebInspector.DialogDelegate.prototype.onAction):
* inspector/front-end/GoToLineDialog.js:
(WebInspector.GoToLineDialog):
(WebInspector.GoToLineDialog._show):
(WebInspector.GoToLineDialog.prototype.get defaultFocusedElement):
(WebInspector.GoToLineDialog.prototype.get okButton):
(WebInspector.GoToLineDialog.prototype.onAction):
* inspector/front-end/WebKit.qrc:
* inspector/front-end/dialog.css: Renamed from Source/WebCore/inspector/front-end/goToLineDialog.css.
(.dialog-glass-pane):
(.dialog):
(.dialog-contents):
(.go-to-line-dialog input):
(.go-to-line-dialog button):
(.go-to-line-dialog button:active):
* inspector/front-end/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105043 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Build fix when using pango as font backends.
ryuan.choi@samsung.com [Mon, 16 Jan 2012 09:41:59 +0000 (09:41 +0000)]
[EFL] Build fix when using pango as font backends.
https://bugs.webkit.org/show_bug.cgi?id=76368

Unreviewed build fix.

* ewk/ewk_view.cpp: include RefPtrCairo.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105042 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScriptRunner should also keep references to pending async scripts
jochen@chromium.org [Mon, 16 Jan 2012 09:37:03 +0000 (09:37 +0000)]
ScriptRunner should also keep references to pending async scripts
https://bugs.webkit.org/show_bug.cgi?id=76350

Reviewed by Adam Barth.

Source/WebCore:

The CachedResourceLoader only keeps a raw pointer to a ScriptElement.
If an async ScriptElement is removed from the document before it is
executed, it might be garbage collected before the script is loaded, so
it's never run.

By making the ScriptRunner keep an explicit reference to the
ScriptElement while it's loading (as is done for sync ScriptElements),
we can guarantee that the ScriptElement lives until it is executed.

No more flaky timeouts: http/tests/misc/async-script.html:

* dom/ScriptElement.cpp:
(WebCore::ScriptElement::prepareScript):
(WebCore::ScriptElement::notifyFinished):
* dom/ScriptRunner.cpp:
(WebCore::ScriptRunner::~ScriptRunner):
(WebCore::ScriptRunner::queueScriptForExecution):
(WebCore::ScriptRunner::notifyScriptReady):
* dom/ScriptRunner.h:
(WebCore::ScriptRunner::hasPendingScripts):

LayoutTests:

* http/tests/misc/async-script.html:
* platform/qt/Skipped: unskip http/tests/misc/async-script.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105041 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoReland chromium event dispatch test from https://bugs.webkit.org/show_bug.cgi?id...
commit-queue@webkit.org [Mon, 16 Jan 2012 09:23:06 +0000 (09:23 +0000)]
Reland chromium event dispatch test from https://bugs.webkit.org/show_bug.cgi?id=72988
https://bugs.webkit.org/show_bug.cgi?id=73837

The original patch had a mistake that caused it to fail (not sure how I
missed that or why the bots didn't catch it).

Patch by Dave Michael <dmichael@chromium.org> on 2012-01-16
Reviewed by Hajime Morita.

* WebKit.gypi:
* tests/DispatchEventTest.cpp: Added.
(WebKit::MockListener::MockListener):
(WebKit::MockListener::~MockListener):
(WebKit::MockListener::events):
(WebKit::DispatchEventTest::DispatchEventTest):
(WebKit::DispatchEventTest::TearDown):
(WebKit::DispatchEventTest::createMessageEvent):
(WebKit::TEST_F):
* tests/data/event_target.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105040 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix; added WebCore.exp.in changes lost in r105036.
reni@webkit.org [Mon, 16 Jan 2012 09:16:40 +0000 (09:16 +0000)]
Unreviewed build fix; added WebCore.exp.in changes lost in r105036.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105039 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoScriptRunner should also keep references to pending async scripts
ossy@webkit.org [Mon, 16 Jan 2012 08:47:55 +0000 (08:47 +0000)]
ScriptRunner should also keep references to pending async scripts
https://bugs.webkit.org/show_bug.cgi?id=76350

* platform/qt/Skipped: Skip http/tests/misc/async-script.html until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105038 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix on 32bit if verbose debug is enabled in DFG
yuqiang.xian@intel.com [Mon, 16 Jan 2012 08:42:50 +0000 (08:42 +0000)]
Build fix on 32bit if verbose debug is enabled in DFG
https://bugs.webkit.org/show_bug.cgi?id=76351

Reviewed by Hajime Morita.

Mostly change "%lu" to "%zu" to print a "size_t" variable.

* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::endBasicBlock):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleCall):
(JSC::DFG::ByteCodeParser::handleInlining):
(JSC::DFG::ByteCodeParser::parseBlock):
(JSC::DFG::ByteCodeParser::parseCodeBlock):
* dfg/DFGGraph.cpp:
(JSC::DFG::Graph::predictArgumentTypes):
* dfg/DFGJITCompiler.cpp:
(JSC::DFG::JITCompiler::link):
* dfg/DFGOSREntry.cpp:
(JSC::DFG::prepareOSREntry):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105037 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd DeviceOrientationEvent.absolute
commit-queue@webkit.org [Mon, 16 Jan 2012 07:33:31 +0000 (07:33 +0000)]
Add DeviceOrientationEvent.absolute
https://bugs.webkit.org/show_bug.cgi?id=51742

Patch by Xinchao He <xinchao.he@intel.com> on 2012-01-15
Reviewed by Darin Fisher.

This patch add the DeviceOrientationEvent.absolute to follow the
latest w3c device orientation event spec.
http://www.w3.org/TR/orientation-event/

Source/WebCore:

* bindings/js/JSDeviceOrientationEventCustom.cpp:
(WebCore::JSDeviceOrientationEvent::absolute):
(WebCore::JSDeviceOrientationEvent::initDeviceOrientationEvent):
* bindings/v8/custom/V8DeviceOrientationEventCustom.cpp:
(WebCore::V8DeviceOrientationEvent::absoluteAccessorGetter):
(WebCore::V8DeviceOrientationEvent::initDeviceOrientationEventCallback):
* dom/DeviceOrientation.cpp:
(WebCore::DeviceOrientation::create):
(WebCore::DeviceOrientation::DeviceOrientation):
(WebCore::DeviceOrientation::absolute):
(WebCore::DeviceOrientation::canProvideAbsolute):
* dom/DeviceOrientation.h:
* dom/DeviceOrientationEvent.idl:

Source/WebKit/chromium:

* public/WebDeviceOrientation.h:
(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::canProvideAbsolute):
(WebKit::WebDeviceOrientation::absolute):
* src/WebDeviceOrientation.cpp:
(WebKit::WebDeviceOrientation::WebDeviceOrientation):
(WebKit::WebDeviceOrientation::operator=):
(WebKit::WebDeviceOrientation::operator PassRefPtr<WebCore::DeviceOrientation>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105036 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoThe C calling convention logic in DFG::SpeculativeJIT should be available even
fpizlo@apple.com [Mon, 16 Jan 2012 04:03:47 +0000 (04:03 +0000)]
The C calling convention logic in DFG::SpeculativeJIT should be available even
when not generating code for the DFG speculative path
https://bugs.webkit.org/show_bug.cgi?id=76355

Reviewed by Dan Bernstein.

Moved all of the logic for placing C call arguments into the right place (stack
or registers) into a new class, DFG::CCallHelpers.  This class inherits from
AssemblyHelpers, another DFG grab-bag of helper functions.  I could have moved
this code into AssemblyHelpers, but decided against it, because I wanted to
limit the number of methods each class in the JIT has.  Hence now we have a
slightly odd organization of JIT classes in DFG: MacroAssembler (basic instruction
emission) <= AssemblyHelpers (some additional JS smarts) <= CCallHelpers
(understands calls to C functions) <= JITCompiler (can compile a graph to machine
code).  Each of these except for JITCompiler can be reused for stub compilation.

* GNUmakefile.list.am:
* JavaScriptCore.xcodeproj/project.pbxproj:
* dfg/DFGCCallHelpers.h: Added.
(JSC::DFG::CCallHelpers::CCallHelpers):
(JSC::DFG::CCallHelpers::resetCallArguments):
(JSC::DFG::CCallHelpers::addCallArgument):
(JSC::DFG::CCallHelpers::setupArguments):
(JSC::DFG::CCallHelpers::setupArgumentsExecState):
(JSC::DFG::CCallHelpers::setupArgumentsWithExecState):
(JSC::DFG::CCallHelpers::setupTwoStubArgs):
(JSC::DFG::CCallHelpers::setupStubArguments):
* dfg/DFGJITCompiler.h:
(JSC::DFG::JITCompiler::JITCompiler):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105035 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix wrong bug URL in ChangeLog.
kling@webkit.org [Mon, 16 Jan 2012 00:57:10 +0000 (00:57 +0000)]
Fix wrong bug URL in ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105034 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove external references to CSSPrimitiveValue::UnitTypes enum.
macpherson@chromium.org [Sun, 15 Jan 2012 23:18:28 +0000 (23:18 +0000)]
Remove external references to CSSPrimitiveValue::UnitTypes enum.
https://bugs.webkit.org/show_bug.cgi?id=76229

Reviewed by Darin Adler.

No new tests / refactoring only.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::addFontFaceRule):
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::addStops):
(WebCore::positionFromValue):
(WebCore::CSSGradientValue::isCacheable):
(WebCore::CSSRadialGradientValue::resolveRadius):
(WebCore::CSSRadialGradientValue::createGradient):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::isUnitTypeLength):
(WebCore::CSSPrimitiveValue::isFontRelativeLength):
(WebCore::CSSPrimitiveValue::isIdent):
(WebCore::CSSPrimitiveValue::isNumber):
(WebCore::CSSPrimitiveValue::isPercentage):
(WebCore::CSSPrimitiveValue::isString):
(WebCore::CSSPrimitiveValue::isURI):
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyZoom::applyValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105033 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compilation errors on build-webkit --debug --no-video on mac.
commit-queue@webkit.org [Sun, 15 Jan 2012 20:14:31 +0000 (20:14 +0000)]
Fix compilation errors on build-webkit --debug --no-video on mac.
https://bugs.webkit.org/show_bug.cgi?id=75867

Patch by Pablo Flouret <pablof@motorola.com> on 2012-01-15
Reviewed by Philippe Normand.

Source/JavaScriptCore:

Make ENABLE_VIDEO_TRACK conditional on ENABLE_VIDEO, video track feature
doesn't build without video.

* wtf/Platform.h:

Source/WebCore:

- Some exported HTMLMediaElement symbols were guarded by FULLSCREEN_API
  feature instead of VIDEO.
- Unused parameter warning in CanvasRenderingContext::wouldTaintOrigin().
- RenderThemeMac::shouldShowPlaceholderWhenFocused() implementation
  wrongly guarded by VIDEO feature.

* WebCore.exp.in:
* html/canvas/CanvasRenderingContext.cpp:
(WebCore::CanvasRenderingContext::wouldTaintOrigin):
* rendering/RenderThemeMac.mm:

Source/WebKit/mac:

- WebChromeClient::fullScreenRendererChanged() declaration wrongly guarded
  by VIDEO feature instead of FULLSCREEN_API.
- _isAnyMoviePlaying implementation depends on VIDEO.

* WebCoreSupport/WebChromeClient.h:
* WebView/WebFullScreenController.mm:
(-[WebFullScreenController _isAnyMoviePlaying]):

Tools:

Add --[no-]video-track to build-webkit, since video track feature
depends on video.

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105032 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSSParser: Fix failing assertion below BorderImageQuadParseContext.
kling@webkit.org [Sun, 15 Jan 2012 19:42:47 +0000 (19:42 +0000)]
CSSParser: Fix failing assertion below BorderImageQuadParseContext.
<http://webkit.org/b/76343> and <rdar://problem/10584969>

Reviewed by Antti Koivisto.

No longer asserts: fast/borders/inline-mask-overlay-image-outset-vertical-rl.html

* css/CSSParser.cpp:
(WebCore::BorderImageSliceParseContext::commitBorderImageSlice):
(WebCore::BorderImageQuadParseContext::commitBorderImageQuad):

    Clone CSSValues by copying the RefPtrs instead of going through
    the CSSValuePool's create-from-double factory. This prevents an
    assertion when the incoming value is CSSValueAuto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105031 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<embed> width and height properties propagate to parent object node
robert@webkit.org [Sun, 15 Jan 2012 17:17:36 +0000 (17:17 +0000)]
<embed> width and height properties propagate to parent object node
https://bugs.webkit.org/show_bug.cgi?id=17688

Reviewed by Eric Seidel.

Source/WebCore:

Test: fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html

WebKit seems to have inherited this behaviour from KHTML. When the width/height
of an <embed> element is set, it propagates the values up to any parent <object>
element. There doesn't seem to be any good reason for this and it is not consistent
with the behaviour of Firefox and Opera.

* html/HTMLEmbedElement.cpp:
(WebCore::HTMLEmbedElement::insertedIntoDocument):
(WebCore::HTMLEmbedElement::attributeChanged): Removed
* html/HTMLEmbedElement.h:
(WebCore::HTMLEmbedElement::attributeChanged): Removed

LayoutTests:

* fast/dom/insertedIntoDocument-child-expected.txt:
* fast/dom/insertedIntoDocument-sibling-expected.txt:
  These tests were added by http://trac.webkit.org/changeset/81611.
  The fact that an <embed> element inserted into the document no longer passes its
  height/width up to its parent object node seems to prevent the node getting removed
  by a simple garbage collection now so the <embed> added by the test is still there at the end,
  creating the trailing spaces. This is consistent with Opera's treatment of the test, FF is entirely
  different - it doesn't add the embed node in the first place. So given that the purpose of the
  test is to cause a crash (?), the change in result seems benign.
* fast/images/embed-does-not-propagate-dimensions-to-object-ancestor-expected.txt: Added.
* fast/images/embed-does-not-propagate-dimensions-to-object-ancestor.html: Added.
  This tests that the width/height for an embed element does not get propagated to the parent object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105030 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocompareBorders() is called too often during painting
robert@webkit.org [Sun, 15 Jan 2012 13:48:45 +0000 (13:48 +0000)]
compareBorders() is called too often during painting
https://bugs.webkit.org/show_bug.cgi?id=73349

Reviewed by Julien Chaffraix.

Collapsed borders are re-calculated every time they are painted.
This is unnecessary, they only change with the layout or style so calculate and
cache them whenever the layout or style changes and use the cached values when
painting. The cache is stored in the table section so that the memory footprint
of a table is only increased when it has collapsing borders.

The gain in performance here consists of skipping collapsed border computation
during painting. The only path that incurs a small performance penalty is the
additional get/set on the cache when a collapsed border is computed. This penalty only applies
during style change, layout, or when the width of the table is calculated. The computed
border value is not stored in the cache when it has been calculated without its color
for borderHalfStart and co., so that code path is unaffected by this change.

No new tests, covered by existing collapsed border tests.

* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::willBeDestroyed): remove entries from collapsed border cache
(WebCore::RenderTableCell::collapsedStartBorder):
 Compute, and also cache if the full border including color was computed.
(WebCore::RenderTableCell::computeCollapsedStartBorder):
(WebCore::RenderTableCell::collapsedEndBorder): ditto
(WebCore::RenderTableCell::computeCollapsedEndBorder):
(WebCore::RenderTableCell::collapsedBeforeBorder): ditto
(WebCore::RenderTableCell::computeCollapsedBeforeBorder):
(WebCore::RenderTableCell::collapsedAfterBorder): ditto
(WebCore::RenderTableCell::computeCollapsedAfterBorder):
(WebCore::RenderTableCell::cachedCollapsedLeftBorder):
 Inline the function since it is only called in paintCollapsedBorders and remove
 includeColor as a parameter. Move the call to the table's style to the caller rather
 than call it 4 times in a row. Use the cached border values directly.
(WebCore::RenderTableCell::cachedCollapsedRightBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedTopBorder): ditto
(WebCore::RenderTableCell::cachedCollapsedBottomBorder): ditto
(WebCore::RenderTableCell::paintCollapsedBorders):
 This function always uses the collapsed border cache now.
* rendering/RenderTableCell.h:
 Make the collapsed border functions private.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::removeCachedCollapsedBorders): The cache is deleted by the HashMap
 since it is the only owner of the cached item.
(WebCore::RenderTableSection::setCachedCollapsedBorder):
(WebCore::RenderTableSection::cachedCollapsedBorder):
 This will assert if there is no cached collapsed border for the side of the
 cell requested by the caller.
* rendering/RenderTableSection.h:
 HashMap wouldn't let me use CollapsedBorderSide in the key value for the cache
 so use int instead.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105029 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHWndDC should be in platform/win instead of wtf.
levin@chromium.org [Sun, 15 Jan 2012 03:14:07 +0000 (03:14 +0000)]
HWndDC should be in platform/win instead of wtf.
https://bugs.webkit.org/show_bug.cgi?id=76314

Reviewed by Sam Weinig.

Source/JavaScriptCore:

* JavaScriptCore.gyp/JavaScriptCore.gyp:
* JavaScriptCore.gypi:

Source/WebCore:

No new functionality, so no new tests.

* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* platform/win/HWndDC.h: Renamed from Source/JavaScriptCore/wtf/win/HWndDCWin.h.
I also made the class non-copyable.
(WebCore::HWndDC::HWndDC):
(WebCore::HWndDC::~HWndDC):
(WebCore::HWndDC::operator HDC):

Source/WebKit/chromium:

* src/win/WebScreenInfoFactory.cpp:
(WebKit::WebScreenInfoFactory::screenInfo):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105028 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=76339
commit-queue@webkit.org [Sun, 15 Jan 2012 01:24:10 +0000 (01:24 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=76339

Take a page from the Gtk and Qt ports and quiet these logs unless they
are explicitly enabled via environment variable.

Patch by Adam Treat <atreat@rim.com> on 2012-01-14
Reviewed by George Staikos.

* platform/blackberry/LoggingBlackBerry.cpp:
(WebCore::initializeLoggingChannelsIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105027 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10696295> Crash in WebProcess at com.apple.CFNetwork: URLCredentialSt...
mitz@apple.com [Sun, 15 Jan 2012 00:31:23 +0000 (00:31 +0000)]
<rdar://problem/10696295> Crash in WebProcess at com.apple.CFNetwork: URLCredentialStorage::CreateCurrentPersistentCredentials + 298

Reviewed by Anders Carlsson.

* WebProcess/mac/SecItemShimMethods.mm:
(WebKit::initializeSecItemShim): Removed an early return that was accidentally added in r105008.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105026 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChromium results for test added by r105021
robert@webkit.org [Sat, 14 Jan 2012 23:53:03 +0000 (23:53 +0000)]
Chromium results for test added by r105021

Unreviewed gardening.

* platform/chromium-linux/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
* platform/chromium-mac-snowleopard/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.
* platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.png: Added.
* platform/chromium-win/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105025 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange expected failures from IMAGE+TEXT to TEXT on Mac.
robert@webkit.org [Sat, 14 Jan 2012 20:46:21 +0000 (20:46 +0000)]
Change expected failures from IMAGE+TEXT to TEXT on Mac.

The Mac bots do not check pixel results so displays results suppressed
as IMAGE+TEXT as unexpected failures. Change the suppressions to TEXT.
These results require rebaseline since the changes landed in r103251.

Unreviewed gardening.

* platform/mac/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105024 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove reference result added in r105021.
robert@webkit.org [Sat, 14 Jan 2012 20:31:48 +0000 (20:31 +0000)]
Remove reference result added in r105021.

This reference result only works in chromium-linux and qt it seems,
so remove it and allow ports to add port-specific png results.

Unreviewed.

* css2.1/20110323/outline-color-applies-to-008-expected.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105023 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
commit-queue@webkit.org [Sat, 14 Jan 2012 19:28:42 +0000 (19:28 +0000)]
[chromium] Failing webkit_unit_tests does not make the cr-linux EWS bubble red
https://bugs.webkit.org/show_bug.cgi?id=76313

Patch by James Robinson <jamesr@chromium.org> on 2012-01-14
Reviewed by Adam Barth.

The exit code of this script should be the exit code of webkit_unit_tests. Tested manually.

* Scripts/run-chromium-webkit-unit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105022 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: outline-color-applies-to* tests fail
robert@webkit.org [Sat, 14 Jan 2012 19:13:35 +0000 (19:13 +0000)]
CSS 2.1 failure: outline-color-applies-to* tests fail
https://bugs.webkit.org/show_bug.cgi?id=71944

Reviewed by Julien Chaffraix.

Source/WebCore:

Paint the outline color for row, row-group, header-group and footer-group
elements.

Tests: css2.1/20110323/outline-color-applies-to-001.htm
       css2.1/20110323/outline-color-applies-to-002.htm
       css2.1/20110323/outline-color-applies-to-003.htm
       css2.1/20110323/outline-color-applies-to-004.htm
       css2.1/20110323/outline-color-applies-to-005.htm
       css2.1/20110323/outline-color-applies-to-006.htm
       css2.1/20110323/outline-color-applies-to-007.htm
       css2.1/20110323/outline-color-applies-to-008.htm
       css2.1/20110323/outline-color-applies-to-009.htm
       css2.1/20110323/outline-color-applies-to-010.htm
       (There is no outline-color-applies-to-011.htm in the test suite.)
       css2.1/20110323/outline-color-applies-to-012.htm
       css2.1/20110323/outline-color-applies-to-013.htm
       css2.1/20110323/outline-color-applies-to-014.htm
       css2.1/20110323/outline-color-applies-to-015.htm
       fast/css/outline-color-self-painting-row.htm

* rendering/RenderTableRow.cpp:
(WebCore::RenderTableRow::paintOutlineForRowIfNeeded): Wrapper function for painting the outline for the row.
 This is used by RenderTableSection::paintObject and RenderTableRow::paint
(WebCore::RenderTableRow::paint): For rows with a self-painting layer, paint the outline. Tested by
 fast/css/outline-color-self-painting-row.htm.
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::paint): Paint the outline for header-group, row-group and footer-groups.
(WebCore::RenderTableSection::paintObject): When iterating through the cells paint the outline of rows as required.
Doing it here avoids the need to walk the RenderTableSection's tree separately elsewhere.

LayoutTests:

* css2.1/20110323/outline-color-applies-to-001-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-001.htm: Added.
* css2.1/20110323/outline-color-applies-to-002-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-002.htm: Added.
* css2.1/20110323/outline-color-applies-to-003-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-003.htm: Added.
* css2.1/20110323/outline-color-applies-to-004-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-004.htm: Added.
* css2.1/20110323/outline-color-applies-to-005-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-005.htm: Added.
* css2.1/20110323/outline-color-applies-to-006-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-006.htm: Added.
* css2.1/20110323/outline-color-applies-to-007-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-007.htm: Added.
* css2.1/20110323/outline-color-applies-to-008-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-008.htm: Added.
* css2.1/20110323/outline-color-applies-to-009-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-009.htm: Added.
* css2.1/20110323/outline-color-applies-to-010-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-010.htm: Added.
* css2.1/20110323/outline-color-applies-to-012-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-012.htm: Added.
* css2.1/20110323/outline-color-applies-to-013-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-013.htm: Added.
* css2.1/20110323/outline-color-applies-to-014-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-014.htm: Added.
* css2.1/20110323/outline-color-applies-to-015-expected.html: Added.
* css2.1/20110323/outline-color-applies-to-015.htm: Added.
* fast/css/outline-color-self-painting-row-expected.html: Added.
* fast/css/outline-color-self-painting-row.htm: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105021 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] Remove WebKit::WebWorker class.
dslomov@google.com [Sat, 14 Jan 2012 19:11:21 +0000 (19:11 +0000)]
[Chromium] Remove WebKit::WebWorker class.
https://bugs.webkit.org/show_bug.cgi?id=76327

Reviewed by Darin Fisher.

* public/WebWorker.h: Removed.
* src/WebWorkerClientImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105020 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnmatched transparency layer begin/end on a filtered element with an opacity ancestor
simon.fraser@apple.com [Sat, 14 Jan 2012 15:51:35 +0000 (15:51 +0000)]
Unmatched transparency layer begin/end on a filtered element with an opacity ancestor
https://bugs.webkit.org/show_bug.cgi?id=76329

Source/WebCore:

Reviewed by Dan Bernstein.

When doing a paint with painting disabled on the GraphicsContext, as we do
for updating control tints, or computing text rectangles on Find, do not
apply filter effects. This is both a performance gain, and fixes an issue
with mismatched begin/end transparency layers.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::paintLayerContents):

Reviewed by Dan Bernstein.

Manual test with a filtered element as a descendant of an element with
opacity. Doing a Find is necessary to exercise the test.

* ManualTests/filters/opacity-above-filter.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105019 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r105017.
commit-queue@webkit.org [Sat, 14 Jan 2012 13:43:37 +0000 (13:43 +0000)]
Unreviewed, rolling out r105017.
http://trac.webkit.org/changeset/105017
https://bugs.webkit.org/show_bug.cgi?id=76333

broke the build (Requested by philn-tp on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-01-14

* gtk/jhbuild.modules:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105018 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Include gtk+3 in the jhbuild modules
commit-queue@webkit.org [Sat, 14 Jan 2012 13:23:21 +0000 (13:23 +0000)]
[GTK] Include gtk+3 in the jhbuild modules
https://bugs.webkit.org/show_bug.cgi?id=76284

Patch by Mario Sanchez Prada <msanchez@igalia.com> on 2012-01-14
Reviewed by Philippe Normand.

* gtk/jhbuild.modules: Add some gtk+3 to the jhbuild moduleset.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105017 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip test that started failing after r105015.
ojan@chromium.org [Sat, 14 Jan 2012 04:41:30 +0000 (04:41 +0000)]
Skip test that started failing after r105015.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105016 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement flex-align
ojan@chromium.org [Sat, 14 Jan 2012 03:03:08 +0000 (03:03 +0000)]
Implement flex-align
https://bugs.webkit.org/show_bug.cgi?id=75782

Reviewed by Tony Chang.

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Intentially gets computed style for flex-item-align:auto wrong.
Will fix this in a followup patch.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::flexAlignForChild):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/flex-align-expected.txt:
* css3/flexbox/flex-align.html:
* css3/flexbox/script-tests/css-properties.js:
* fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105015 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoGCC compiler version is not detected properly for QNX qcc variant
efidler@rim.com [Sat, 14 Jan 2012 02:47:27 +0000 (02:47 +0000)]
GCC compiler version is not detected properly for QNX qcc variant
https://bugs.webkit.org/show_bug.cgi?id=76288

Reviewed by Rob Buis.

Provide an alternative way of getting the compiler version for GCC variants
that don't support -dumpversion (such as qcc).

* Source/cmake/WebKitHelpers.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105014 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Windows, WinCairo] Build correction after r104919.
bfulgham@webkit.org [Sat, 14 Jan 2012 01:13:35 +0000 (01:13 +0000)]
[Windows, WinCairo] Build correction after r104919.

* WebCore.vcproj/WebCore.vcproj: Exclude ShadowContentSelectorQuery.cpp
  from the build, since it is built as part of DOMAllInOne.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105013 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoPointer Lock: Change isLocked() from operator to attribute isLocked
scheib@chromium.org [Sat, 14 Jan 2012 00:28:26 +0000 (00:28 +0000)]
Pointer Lock: Change isLocked() from operator to attribute isLocked
https://bugs.webkit.org/show_bug.cgi?id=76311

Reviewed by Adam Barth.

Source/WebCore:

This patch implements the recent Mouse Lock Specification update
changing navigator.pointer.isLocked() to .isLocked.

Test pointer-lock/pointer-lock-api.html updated to new spec.

* page/PointerLock.idl:

LayoutTests:

* pointer-lock/pointer-lock-api-expected.txt:
* pointer-lock/pointer-lock-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105011 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a test for cross-origin XMLHttpRequest and CORS (which doesn't work currently)
jochen@chromium.org [Sat, 14 Jan 2012 00:13:37 +0000 (00:13 +0000)]
Add a test for cross-origin XMLHttpRequest and CORS (which doesn't work currently)
https://bugs.webkit.org/show_bug.cgi?id=57600

Reviewed by Adam Barth.

* http/tests/security/resources/cors-redirect.php: Added.
* http/tests/security/resources/empty.html: Added.
* http/tests/security/xhr-cors-redirect-expected.txt: Added.
* http/tests/security/xhr-cors-redirect.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105009 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDelay updating the root compositing layer if the layer tree state is frozen
andersca@apple.com [Sat, 14 Jan 2012 00:08:57 +0000 (00:08 +0000)]
Delay updating the root compositing layer if the layer tree state is frozen
https://bugs.webkit.org/show_bug.cgi?id=76316

Reviewed by Dan Bernstein.

When the layer tree is frozen, stash the root layer in m_pendingRootCompositingLayer and set it in flushLayers.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105008 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonoteOn, noteGrainOn and noteOff idl should take doubles
commit-queue@webkit.org [Sat, 14 Jan 2012 00:01:56 +0000 (00:01 +0000)]
noteOn, noteGrainOn and noteOff idl should take doubles
https://bugs.webkit.org/show_bug.cgi?id=76073

Patch by Raymond Toy <rtoy@google.com> on 2012-01-13
Reviewed by Adam Barth.

Source/WebCore:

Existing audiobuffersource-playbackrate and gain tests cover the
noteOn and noteOff changes.

* webaudio/AudioBufferSourceNode.idl: noteOn, noteGrainOn, and
noteOff take doubles.

LayoutTests:

* webaudio/audiobuffersource-playbackrate-expected.wav: Updated
* webaudio/gain-expected.wav: Updated

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105007 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agohttps://bugs.webkit.org/show_bug.cgi?id=71230
bdakin@apple.com [Fri, 13 Jan 2012 23:58:22 +0000 (23:58 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=71230
Clicking where the overlay scroll track would be should not scroll the page
-and corresponding-
<rdar://problem/9585424>

Reviewed by Alexey Proskuryakov.

These new functions indicate whether the scrollbar should participate in hit
testing. Non-overlay scrollbars always should, so they return true. Overlay
scrollbars consult the animator, which checks the current alpha.
* platform/ScrollAnimator.h:
(WebCore::ScrollAnimator::shouldScrollbarParticipateInHitTesting):
* platform/Scrollbar.cpp:
(WebCore::Scrollbar:: shouldParticipateInHitTesting):
* platform/Scrollbar.h:
* platform/mac/ScrollAnimatorMac.h:
* platform/mac/ScrollAnimatorMac.mm:
(WebCore::ScrollAnimatorMac:: shouldScrollbarParticipateInHitTesting):

In these hit-testing functions, only hit-test when the scrollbar should
participate.
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollbarAtPoint):
* rendering/RenderEmbeddedObject.cpp:
(WebCore::RenderEmbeddedObject::nodeAtPoint):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::hitTestOverflowControls):
* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::isPointInOverflowControl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105006 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoREGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer...
mitz@apple.com [Fri, 13 Jan 2012 23:56:26 +0000 (23:56 +0000)]
REGRESSION: svg/custom/use-instanceRoot-event-listeners.xhtml & svg/custom/pointer-events-invalid-fill.svg broken on the Bots
https://bugs.webkit.org/show_bug.cgi?id=76254

Reviewed by Anders Carlsson.

Source/WebCore:

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired): Added a call to
CachedResourceLoader::loadDone() after decrementing the request count. This allows the
frame loader to see that the request count is zero and dispatch didFinishLoad.

LayoutTests:

* svg/custom/pointer-events-invalid-fill.svg: Force layout before sending a mouse event.
Otherwise, the WebHTMLView may have zero size, causing the hit test in
-[EventSendingController mouseMoveToX:Y:] to yield the clip view and the event to go nowhere.
* svg/custom/resources/use-instanceRoot-event-listeners.js: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105005 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebAudio: Optimize calculateNormalizationScale().
jer.noble@apple.com [Fri, 13 Jan 2012 23:52:14 +0000 (23:52 +0000)]
WebAudio: Optimize calculateNormalizationScale().
https://bugs.webkit.org/show_bug.cgi?id=74372

Reviewed by Eric Carlson.

No new tests; optimization of existing code, so covered by existing test cases.

* platform/audio/Reverb.cpp:
(WebCore::calculateNormalizationScale): Replace implementation with optimized vector
    math operation.
(WebCore::Reverb::Reverb):
* platform/audio/VectorMath.cpp:
(WebCore::VectorMath::vsvesq): Vector math operation for squared sum of elements.
* platform/audio/VectorMath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105004 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove a unused variable.
thakis@chromium.org [Fri, 13 Jan 2012 23:40:36 +0000 (23:40 +0000)]
Remove a unused variable.
https://bugs.webkit.org/show_bug.cgi?id=76307

Reviewed by James Robinson.

* platform/mac/ScrollElasticityController.mm:
(WebCore::ScrollElasticityController::snapRubberBandTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105003 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove --dry-run support from webkit-patch
abarth@webkit.org [Fri, 13 Jan 2012 23:35:58 +0000 (23:35 +0000)]
Remove --dry-run support from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=76300

Reviewed by Dirk Pranke.

This is the rest of the patch from Bug 76300.  I landed it separtely
because main.py had some stray conflict markers that I needed to clean
up first.

* Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester._run_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105001 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSource/WebCore: Revert most of the multipart changes in
japhet@chromium.org [Fri, 13 Jan 2012 23:32:42 +0000 (23:32 +0000)]
Source/WebCore: Revert most of the multipart changes in
http://trac.webkit.org/changeset/104756.
https://bugs.webkit.org/show_bug.cgi?id=76297

Reviewed by Alexey Proskuryakov.

http/tests/multipart/invalid-image-data.html
should stop asserting on chromium win dbg.

* loader/SubresourceLoader.cpp:
(WebCore::SubresourceLoader::didReceiveResponse):
(WebCore::SubresourceLoader::didReceiveData):
(WebCore::SubresourceLoader::sendDataToResource):

LayoutTests: http/tests/multipart/invalid-image-data.html should no longer
be crashing on chromium win dbg.
https://bugs.webkit.org/show_bug.cgi?id=76297

Reviewed by Alexey Proskuryakov.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@105000 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest-webkitpy does not run
abarth@webkit.org [Fri, 13 Jan 2012 23:31:40 +0000 (23:31 +0000)]
test-webkitpy does not run
https://bugs.webkit.org/show_bug.cgi?id=76318

Unreviewed.

Looks like some conflict markers got left in the file.

* Scripts/webkitpy/test/main.py:
(Tester.run):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104999 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove --dry-run support from webkit-patch
abarth@webkit.org [Fri, 13 Jan 2012 23:28:17 +0000 (23:28 +0000)]
Remove --dry-run support from webkit-patch
https://bugs.webkit.org/show_bug.cgi?id=76300

Reviewed by Dirk Pranke.

We don't use this functionality for anything, and it doesn't really
work.  Someone in #webkit tried using it and and got sad/confused.  We
should just remove it.

* Scripts/webkitpy/common/checkout/scm/git.py:
(Git.push_local_commits_to_server):
* Scripts/webkitpy/common/checkout/scm/scm.py:
(SCM.__init__):
* Scripts/webkitpy/common/checkout/scm/scm_unittest.py:
(_shared_test_commit_with_message):
(GitSVNTest.test_commit_text_parsing):
* Scripts/webkitpy/common/checkout/scm/svn.py:
(SVN.commit_with_message):
* Scripts/webkitpy/common/net/bugzilla/bugzilla.py:
(Bugzilla.__init__):
(Bugzilla.quips):
(Bugzilla.authenticate):
(Bugzilla.add_attachment_to_bug):
(Bugzilla.add_patch_to_bug):
(Bugzilla.create_bug):
(Bugzilla.clear_attachment_flags):
(Bugzilla.set_flag_on_attachment):
(Bugzilla.obsolete_attachment):
(Bugzilla.add_cc_to_bug):
(Bugzilla.post_comment_to_bug):
(Bugzilla.close_bug_as_fixed):
(Bugzilla.reassign_bug):
(reopen_bug):
* Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester.run_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104998 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agocheck-webkit-style: should encourage the use of Own* classes for Windows DC.
levin@chromium.org [Fri, 13 Jan 2012 22:58:00 +0000 (22:58 +0000)]
check-webkit-style: should encourage the use of Own* classes for Windows DC.
https://bugs.webkit.org/show_bug.cgi?id=76227

Reviewed by Dirk Pranke.

Source/JavaScriptCore:

* wtf/win/HWndDCWin.h:
(WTF::HwndDC::HwndDC): Add a way to do GetDCEx.
There are no users, but I want to catch this in check-webkit-style
and tell any users to use HwndDC to avoid leaks.

Tools:

* Scripts/webkitpy/style/checkers/cpp.py:
(check_for_leaky_patterns): The new check.
(process_line): Added a call to the new check.
(CppChecker): Added the new error type.
* Scripts/webkitpy/style/checkers/cpp_unittest.py:
(CppStyleTestBase):
(CppStyleTestBase.perform_leaky_pattern_check):
The check for only leaky pattern errors.
(LeakyPatternTest): Test cases.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104995 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoVersioning.
lforschler@apple.com [Fri, 13 Jan 2012 22:52:08 +0000 (22:52 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104994 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebAudio: Use float instead of double values for gain operations.
jer.noble@apple.com [Fri, 13 Jan 2012 22:42:46 +0000 (22:42 +0000)]
WebAudio: Use float instead of double values for gain operations.
https://bugs.webkit.org/show_bug.cgi?id=74345

Reviewed by Sam Weinig.

No new tests; optimization of existing code, so covered by existing test cases.

The following functions now take or operate on floats instead of doubles:
(WebCore::AudioBus::scale):
(WebCore::AudioBus::processWithGainFrom):
(WebCore::AudioBus::copyWithGainFrom):
(WebCore::AudioBus::sumWithGainFrom):
* platform/audio/AudioBus.h:
(WebCore::AudioBus::setGain):
(WebCore::AudioBus::gain):
* platform/audio/AudioChannel.cpp:
(WebCore::AudioChannel::scale):
* platform/audio/AudioChannel.h:
* webaudio/AudioBufferSourceNode.cpp:
(WebCore::AudioBufferSourceNode::process):
* webaudio/AudioBufferSourceNode.h:
* webaudio/AudioGainNode.h:
* webaudio/AudioPannerNode.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104993 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDon't use pending activity notification in IntentRequest
commit-queue@webkit.org [Fri, 13 Jan 2012 22:38:19 +0000 (22:38 +0000)]
Don't use pending activity notification in IntentRequest
https://bugs.webkit.org/show_bug.cgi?id=76302

Patch by Greg Billock <gbillock@google.com> on 2012-01-13
Reviewed by Adam Barth.

* Modules/intents/IntentRequest.cpp:
(WebCore::IntentRequest::IntentRequest):
(WebCore::IntentRequest::postResult):
(WebCore::IntentRequest::postFailure):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104991 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEQUALPOWER panner incorrectly computes gain
commit-queue@webkit.org [Fri, 13 Jan 2012 22:18:41 +0000 (22:18 +0000)]
EQUALPOWER panner incorrectly computes gain
https://bugs.webkit.org/show_bug.cgi?id=75767

Source/WebCore:

Patch by Raymond Toy <rtoy@google.com> on 2012-01-13
Reviewed by Kenneth Russell.

Layout test added.

* platform/audio/EqualPowerPanner.cpp:
(WebCore::EqualPowerPanner::pan):  Correct the formula.

LayoutTests:

Patch by Raymond Toy <rtoy@chromium.org> on 2012-01-13
Reviewed by Kenneth Russell.

* webaudio/panner-equalpower.html: Added.
* webaudio/panner-equalpower-expected.txt: Added.
* webaudio/resources/panner-model-testing.js: Added.
* webaudio/resources/audio-testing.js:
(createImpulseBuffer): New common utility function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104987 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen
andersca@apple.com [Fri, 13 Jan 2012 22:15:25 +0000 (22:15 +0000)]
Implement TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen
https://bugs.webkit.org/show_bug.cgi?id=76308

Reviewed by Sam Weinig.

Keep track of whether the layer tree state is frozen and suspend/resume the layer flush scheduler accordingly.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::TiledCoreAnimationDrawingArea):
(WebKit::TiledCoreAnimationDrawingArea::setLayerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::layerTreeStateIsFrozen):
(WebKit::TiledCoreAnimationDrawingArea::scheduleCompositingLayerSync):
(WebKit::TiledCoreAnimationDrawingArea::flushLayers):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104986 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r104972.
ojan@chromium.org [Fri, 13 Jan 2012 22:00:29 +0000 (22:00 +0000)]
Unreviewed, rolling out r104972.
http://trac.webkit.org/changeset/104972
https://bugs.webkit.org/show_bug.cgi?id=75782

Broke some tests

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/flex-align-expected.txt:
* css3/flexbox/flex-align.html:
* css3/flexbox/script-tests/css-properties.js:
* fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-mac-snowleopard/svg/css/getComputedStyle-basic-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-expected.txt:
* platform/chromium-win/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/chromium-win/svg/css/getComputedStyle-basic-expected.txt:
* platform/gtk/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* platform/qt/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104985 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoDisable implicit animations when setting the root compositing layer
andersca@apple.com [Fri, 13 Jan 2012 21:38:32 +0000 (21:38 +0000)]
Disable implicit animations when setting the root compositing layer
https://bugs.webkit.org/show_bug.cgi?id=76304

Reviewed by Sam Weinig.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setRootCompositingLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104983 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agofix changelog
dpranke@chromium.org [Fri, 13 Jan 2012 21:31:04 +0000 (21:31 +0000)]
fix changelog

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104982 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix for Qt SnowLeopard build bot.
alexis.menard@openbossa.org [Fri, 13 Jan 2012 21:24:27 +0000 (21:24 +0000)]
Unreviewed build fix for Qt SnowLeopard build bot.

This is a workaround for the moment.

* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104981 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest-webkitpy: should support classes and individual test names as well as modules
dpranke@chromium.org [Fri, 13 Jan 2012 21:23:59 +0000 (21:23 +0000)]
test-webkitpy: should support classes and individual test names as well as modules
https://bugs.webkit.org/show_bug.cgi?id=76233

Reviewed by Adam Barth.

The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say

  % test-wekbitpy webkitpy.test.cat_unittest.CatTest

and

  % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic

in addition to

  % test-wekbitpy webkitpy.test.cat_unittest

* Scripts/test-webkitpy:
* Scripts/webkitpy/test/cat_unittest.py:
* Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104980 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago-[WebTileCacheLayer setNeedsDisplay] doesn't trigger invalidation
andersca@apple.com [Fri, 13 Jan 2012 21:20:53 +0000 (21:20 +0000)]
-[WebTileCacheLayer setNeedsDisplay] doesn't trigger invalidation
https://bugs.webkit.org/show_bug.cgi?id=76299

Reviewed by Simon Fraser.

Override -[WebTileCacheLayer setNeedsDisplay] and call TileCache::setNeedsDisplay from there,
instead of ending up with a huge rectangle in TileCache::setNeedsDisplayInRect which causes our
tile computation logic to fail due to integer overflow when converting from CGFloats to ints.

* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setNeedsDisplay):
* platform/graphics/ca/mac/WebTileCacheLayer.mm:
(-[WebTileCacheLayer setNeedsDisplay]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104978 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest-webkitpy: should support classes and individual test names as well as modules
dpranke@chromium.org [Fri, 13 Jan 2012 21:16:36 +0000 (21:16 +0000)]
test-webkitpy: should support classes and individual test names as well as modules
https://bugs.webkit.org/show_bug.cgi?id=76233

Reviewed by Adam Barth.

The default unittest.main() supports a list of individual
TestCase classes or individual tests as well as modules. This
change adds support for the same to test-webkitpy, so now you
can say

  % test-wekbitpy webkitpy.test.cat_unittest.CatTest

and

  % test-wekbitpy webkitpy.test.cat_unittest.CatTest.test_basic

in addition to

  % test-wekbitpy webkitpy.test.cat_unittest

* Scripts/test-webkitpy:
* Scripts/webkitpy/test/cat_unittest.py:
* Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester.run):
(Tester):
(Tester._find_modules):
(Tester._exclude):
(Tester._run_tests):
(Tester._is_module):
(Tester._log_exception):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104977 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHeader file is missing header guard.
levin@chromium.org [Fri, 13 Jan 2012 21:16:33 +0000 (21:16 +0000)]
Header file is missing header guard.

Reviewed by Dirk Pranke.

* wtf/win/HWndDCWin.h: Added the guards.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104976 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agotest-webkitpy: add basic code coverage support
dpranke@chromium.org [Fri, 13 Jan 2012 20:59:33 +0000 (20:59 +0000)]
test-webkitpy: add basic code coverage support
https://bugs.webkit.org/show_bug.cgi?id=76201

Reviewed by Adam Barth.

This test adds basic code coverage support to test-webkitpy; if
you pass the -c flag, we will generate a new coverage file. We
can start simply with this and add more features as necessary.

This patch requires coverage to be already installed on the
machine. I am not auto-installing this for now.

* Scripts/webkitpy/test/main.py:
(Tester.parse_args):
(Tester.run_tests):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104975 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStatusBubbleTest.test_build_bubble is failing
dpranke@chromium.org [Fri, 13 Jan 2012 20:54:37 +0000 (20:54 +0000)]
StatusBubbleTest.test_build_bubble is failing
https://bugs.webkit.org/show_bug.cgi?id=76222

Reviewed by Adam Barth.

* QueueStatusServer/handlers/statusbubble_unittest.py:
(StatusBubbleTest.test_build_bubble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd new baselines for various compositing tests which didn't have Mac results.
simon.fraser@apple.com [Fri, 13 Jan 2012 20:53:53 +0000 (20:53 +0000)]
Add new baselines for various compositing tests which didn't have Mac results.

* platform/mac/compositing/animation/busy-indicator-expected.png: Added.
* platform/mac/compositing/animation/busy-indicator-expected.txt: Added.
* platform/mac/compositing/flat-with-transformed-child-expected.png: Added.
* platform/mac/compositing/flat-with-transformed-child-expected.txt: Added.
* platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.png: Added.
* platform/mac/compositing/geometry/fixed-position-composited-page-scale-down-expected.txt: Added.
* platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.png: Added.
* platform/mac/compositing/geometry/fixed-position-composited-page-scale-expected.txt: Added.
* platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.txt: Added.
* platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png: Added.
* platform/mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.txt: Added.
* platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.png: Added.
* platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-down-expected.txt: Added.
* platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.png: Added.
* platform/mac/compositing/geometry/fixed-position-transform-composited-page-scale-expected.txt: Added.
* platform/mac/compositing/repaint/same-size-invalidation-expected.png: Added.
* platform/mac/compositing/repaint/same-size-invalidation-expected.txt: Added.
* platform/mac/compositing/scaling/tiled-layer-recursion-expected.png: Added.
* platform/mac/compositing/scaling/tiled-layer-recursion-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoImplement flex-align
ojan@chromium.org [Fri, 13 Jan 2012 20:43:32 +0000 (20:43 +0000)]
Implement flex-align
https://bugs.webkit.org/show_bug.cgi?id=75782

Reviewed by Tony Chang.

Source/WebCore:

* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
Not 100% sure about this, but I think the computed value of
flex-item-align needs to take the parent's flex-align into
account for computed auto values.
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
* css/CSSProperty.cpp:
(WebCore::CSSProperty::isInheritedProperty):
* css/CSSPropertyNames.in:
* css/CSSStyleApplyProperty.cpp:
(WebCore::CSSStyleApplyProperty::CSSStyleApplyProperty):
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::sizesToIntrinsicLogicalWidth):
* rendering/RenderFlexibleBox.cpp:
(WebCore::flexAlign):
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
(WebCore::RenderFlexibleBox::alignChildren):
* rendering/style/RenderStyle.h:
(WebCore::RenderStyleBitfields::flexAlign):
(WebCore::RenderStyleBitfields::setFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexAlign):
(WebCore::RenderStyleBitfields::initialFlexItemAlign):
* rendering/style/StyleFlexibleBoxData.cpp:
(WebCore::StyleFlexibleBoxData::StyleFlexibleBoxData):
(WebCore::StyleFlexibleBoxData::operator==):
* rendering/style/StyleFlexibleBoxData.h:

LayoutTests:

* css3/flexbox/css-properties-expected.txt:
* css3/flexbox/flex-align-expected.txt:
* css3/flexbox/flex-align.html:
* css3/flexbox/script-tests/css-properties.js:
* fast/css/getComputedStyle/computed-style-expected.txt:
* platform/mac/fast/css/getComputedStyle/computed-style-without-renderer-expected.txt:
* svg/css/getComputedStyle-basic-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Update chromium image baselines for cross-fade-invalidation
jamesr@google.com [Fri, 13 Jan 2012 20:34:31 +0000 (20:34 +0000)]
[chromium] Update chromium image baselines for cross-fade-invalidation

* platform/chromium-linux/css3/images/cross-fade-invalidation-expected.png: Added.
* platform/chromium-mac-snowleopard/css3/images/cross-fade-invalidation-expected.png: Added.
* platform/chromium-win/css3/images/cross-fade-invalidation-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEval in strict mode does not need dynamic checks
commit-queue@webkit.org [Fri, 13 Jan 2012 20:31:41 +0000 (20:31 +0000)]
Eval in strict mode does not need dynamic checks
https://bugs.webkit.org/show_bug.cgi?id=76286

Patch by Andy Wingo <wingo@igalia.com> on 2012-01-13
Reviewed by Oliver Hunt.

* runtime/JSActivation.cpp (JSC::JSActivation::JSActivation):
Eval in strict mode cannot introduce variables, so it not impose
the need for dynamic checks.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix an obviously incorrect expected result image.
jamesr@google.com [Fri, 13 Jan 2012 20:13:01 +0000 (20:13 +0000)]
Fix an obviously incorrect expected result image.

Patch by Simon Fraser <simon.fraser@apple.com> on 2012-01-13

* platform/mac/css3/images/cross-fade-invalidation-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix an obviously incorrect expected result image.
simon.fraser@apple.com [Fri, 13 Jan 2012 19:59:04 +0000 (19:59 +0000)]
Fix an obviously incorrect expected result image.

* platform/mac/css3/images/cross-fade-invalidation-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agonrwt should use multiple http shards
kkristof@inf.u-szeged.hu [Fri, 13 Jan 2012 19:55:10 +0000 (19:55 +0000)]
nrwt should use multiple http shards
https://bugs.webkit.org/show_bug.cgi?id=75958

Add --max-locked-shards option to the nrwt for manual set
the maximum number of the locked shards

Reviewed by Dirk Pranke.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._max_locked_shards):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ShardingTests.get_shards):
(ShardingTests.test_multiple_locked_shards):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRename GraphicsContext* argument in various RenderLayer methods
simon.fraser@apple.com [Fri, 13 Jan 2012 19:45:15 +0000 (19:45 +0000)]
Rename GraphicsContext* argument in various RenderLayer methods
https://bugs.webkit.org/show_bug.cgi?id=76283

Reviewed by James Robinson/Anders Carlsson.

Rename the GraphicsContext* parameter "p" in various RenderLayer
methods to "context". "p" was a historical name from when it was
called Painter.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::beginTransparencyLayers):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::paintOverlayScrollbars):
(WebCore::RenderLayer::restoreClip):
(WebCore::RenderLayer::paintLayer):
(WebCore::RenderLayer::paintLayerContentsAndReflection):
(WebCore::RenderLayer::paintLayerContents):
(WebCore::RenderLayer::paintList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[CSSRegions]Add back region style code removed in r104036
mihnea@adobe.com [Fri, 13 Jan 2012 19:42:53 +0000 (19:42 +0000)]
[CSSRegions]Add back region style code removed in r104036
https://bugs.webkit.org/show_bug.cgi?id=76064

Reviewed by David Hyatt.

No new tests. The region style tests are still skipped. A follow up patch will enable
both region style for background-color and region style tests.

* WebCore.exp.in:
* css/CSSStyleSelector.cpp:
(WebCore::RuleData::useInRegionStyle):
(WebCore::CSSStyleSelector::CSSStyleSelector):
(WebCore::CSSStyleSelector::addMatchedDeclaration):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::CSSStyleSelector::matchAllRules):
(WebCore::CSSStyleSelector::initForRegionStyling):
(WebCore::CSSStyleSelector::initRegionRules):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::RuleData::RuleData):
(WebCore::RuleSet::RuleSet):
(WebCore::RuleSet::addToRuleSet):
(WebCore::CSSStyleSelector::applyDeclarations):
(WebCore::isValidRegionStyleProperty):
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSStyleSelector.h:
(WebCore::CSSStyleSelector::setRegionForStyling):
(WebCore::CSSStyleSelector::regionForStyling):
(WebCore::CSSStyleSelector::applyPropertyToRegionStyle):
* rendering/RenderFlowThread.cpp:
(WebCore::RenderFlowThread::clearRenderObjectCustomStyle):
(WebCore::RenderFlowThread::setRegionRangeForBox):
* rendering/RenderFlowThread.h:
* rendering/RenderLayer.cpp:
(WebCore::CurrentRenderRegionMaintainer::CurrentRenderRegionMaintainer):
(WebCore::CurrentRenderRegionMaintainer::~CurrentRenderRegionMaintainer):
(WebCore::RenderLayer::paint):
(WebCore::RenderLayer::hitTest):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::styleInRegion):
* rendering/RenderObject.h:
(WebCore::RenderObject::canHaveRegionStyle):
* rendering/RenderObjectChildList.cpp:
(WebCore::RenderObjectChildList::removeChildNode):
* rendering/RenderRegion.cpp:
(WebCore::RenderRegion::renderObjectRegionStyle):
(WebCore::RenderRegion::computeStyleInRegion):
(WebCore::RenderRegion::clearObjectStyleInRegion):
* rendering/RenderRegion.h:
* rendering/RenderView.cpp:
(WebCore::RenderView::RenderView):
* rendering/RenderView.h:
(WebCore::RenderView::currentRenderRegion):
(WebCore::RenderView::setCurrentRenderRegion):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed build fix; added project.pbxproj changes lost in r104954.
kbr@google.com [Fri, 13 Jan 2012 19:41:24 +0000 (19:41 +0000)]
Unreviewed build fix; added project.pbxproj changes lost in r104954.
https://bugs.webkit.org/show_bug.cgi?id=75906

* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTextureMapper: Extract layer transform logic to a LayerTransform class.
jocelyn.turcotte@nokia.com [Fri, 13 Jan 2012 19:26:25 +0000 (19:26 +0000)]
TextureMapper: Extract layer transform logic to a LayerTransform class.
https://bugs.webkit.org/show_bug.cgi?id=76291

Reviewed by Noam Rosenthal.

Source/WebCore:

* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* platform/graphics/texmap/LayerTransform.cpp: Added.
(WebCore::LayerTransform::LayerTransform):
(WebCore::LayerTransform::setPosition):
(WebCore::LayerTransform::setSize):
(WebCore::LayerTransform::setAnchorPoint):
(WebCore::LayerTransform::setFlattening):
(WebCore::LayerTransform::setLocalTransform):
(WebCore::LayerTransform::setChildrenTransform):
(WebCore::LayerTransform::combined):
(WebCore::LayerTransform::combinedForChildren):
(WebCore::LayerTransform::combineTransforms):
(WebCore::LayerTransform::combineTransformsForChildren):
* platform/graphics/texmap/LayerTransform.h: Added.
* platform/graphics/texmap/TextureMapperNode.cpp:
(WebCore::TextureMapperNode::setTransform):
(WebCore::TextureMapperNode::computeTransformsRecursive):
(WebCore::TextureMapperNode::collectVisibleContentsRects):
(WebCore::TextureMapperNode::paintSelf):
(WebCore::TextureMapperNode::compareGraphicsLayersZValue):
(WebCore::TextureMapperNode::paintSelfAndChildren):
(WebCore::TextureMapperNode::paintReflection):
(WebCore::TextureMapperNode::syncCompositingStateSelf):
* platform/graphics/texmap/TextureMapperNode.h:
(WebCore::TextureMapperNode::TextureMapperNode):

Source/WebKit2:

Move the paint call before the visible rect collection to make sure that
transforms are computed. This will increase the delay for the visible rects
to get to the WebProcess until we move this calculation out of the UI Process.
This fixes an assert triggering in LayerTransform::combineTransforms.

* UIProcess/qt/LayerTreeHostProxyQt.cpp:
(WebKit::LayerTreeHostProxy::paintToCurrentGLContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@104961 268f45cc-cd09-0410-ab3c-d52691b4dbfc