WebKit-https.git
10 years agoUnreviewed.
ossy@webkit.org [Thu, 13 May 2010 23:22:33 +0000 (23:22 +0000)]
Unreviewed.

[Qt] Platform specific expected file updated after r59385.

Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874

* platform/qt/editing/deleting/5408255-expected.txt: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 13 May 2010 23:14:46 +0000 (23:14 +0000)]
2010-05-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt.

        Fix scrolling in composited iframes
        https://bugs.webkit.org/show_bug.cgi?id=39088
        <rdar://problem/7980099>

        When propagating compositing out of iframes, we have to update the position of the iframe content
        layers on scrolling.

        Test: compositing/iframes/scrolling-iframe.html

        * page/FrameView.cpp:
        (WebCore::FrameView::scrollPositionChanged): Call updateContentLayerScrollPosition() when scrolling.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): Renamed setRootPlatformLayerClippingBox() to updateContentLayerOffset().

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp: Rename m_clippingLayer to m_clipLayer to go better with m_scrollLayer.
        (WebCore::RenderLayerCompositor::updateContentLayerOffset): Renamed from setRootPlatformLayerClippingBox().
            Set the size of the clipping layer from the FrameView now, so that scrollbars are not clipped out.
            Update the scroll layer position too.
        (WebCore::RenderLayerCompositor::updateContentLayerScrollPosition): Set the position of the scroll layer
            when the ScrollView is scrolled.
        (WebCore::RenderLayerCompositor::rootPlatformLayer): m_clippingLayer rename.
        (WebCore::RenderLayerCompositor::ensureRootPlatformLayer): m_clippingLayer rename. Also create m_scrollLayer at
            the same time as the clip layer, and clean it up as necessary.
        (WebCore::RenderLayerCompositor::destroyRootPlatformLayer): m_clippingLayer rename, and clean up the m_scrollLayer too.
        (WebCore::RenderLayerCompositor::detachRootPlatformLayer): m_clippingLayer rename

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 13 May 2010 23:14:05 +0000 (23:14 +0000)]
2010-05-13  Martin Robinson  <mrobinson@igalia.com>

        No review. Adding baselines for many of the css1 tests. I've checked these manually.

        * platform/gtk/Skipped: Unskipping tests.
        * platform/gtk/css1/basic/class_as_selector-expected.txt: Added.
        * platform/gtk/css1/basic/comments-expected.txt: Added.
        * platform/gtk/css1/basic/containment-expected.txt: Added.
        * platform/gtk/css1/basic/contextual_selectors-expected.txt: Added.
        * platform/gtk/css1/basic/grouping-expected.txt: Added.
        * platform/gtk/css1/basic/id_as_selector-expected.txt: Added.
        * platform/gtk/css1/basic/inheritance-expected.txt: Added.
        * platform/gtk/css1/box_properties/acid_test-expected.txt: Added.
        * platform/gtk/css1/box_properties/border-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_bottom-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_bottom_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_bottom_width-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_bottom_width_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_color-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_color_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_left-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_left_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_left_width-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_left_width_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_right-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_right_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_right_width-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_right_width_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_style-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_style_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_top-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_top_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_top_width-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_top_width_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_width-expected.txt: Added.
        * platform/gtk/css1/box_properties/border_width_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/clear-expected.txt: Added.
        * platform/gtk/css1/box_properties/clear_float-expected.txt: Added.
        * platform/gtk/css1/box_properties/float-expected.txt: Added.
        * platform/gtk/css1/box_properties/float_elements_in_series-expected.txt: Added.
        * platform/gtk/css1/box_properties/float_margin-expected.txt: Added.
        * platform/gtk/css1/box_properties/float_on_text_elements-expected.txt: Added.
        * platform/gtk/css1/box_properties/height-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin_bottom-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin_bottom_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin_left-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin_left_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin_right-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin_right_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin_top-expected.txt: Added.
        * platform/gtk/css1/box_properties/margin_top_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding_bottom-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding_bottom_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding_left-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding_left_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding_right-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding_right_inline-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding_top-expected.txt: Added.
        * platform/gtk/css1/box_properties/padding_top_inline-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFollow up to:
weinig@apple.com [Thu, 13 May 2010 22:56:14 +0000 (22:56 +0000)]
Follow up to:
Fix for https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Anders Carlsson.

Fix failing tests on Leopard.

Initialize m_hasCachedCSSText in CSSPrimitiveValue::init methods.

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::init):
(WebCore::CSSPrimitiveValue::cssText): Add extra assertion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 13 May 2010 22:45:56 +0000 (22:45 +0000)]
2010-05-13  Martin Robinson  <mrobinson@igalia.com>

        No review. Rebaselining test after r59385.

        * platform/gtk/editing/deleting/delete-select-all-001-expected.txt: Rebaseline

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding fast/loader/recursive-before-unload-crash-expected.html to the gtk skipped...
beidson@apple.com [Thu, 13 May 2010 22:39:49 +0000 (22:39 +0000)]
Adding fast/loader/recursive-before-unload-crash-expected.html to the gtk skipped list
because it needs more logging in its DRT to pass:
* platform/gtk/Skipped:

Adding fast/loader/recursive-before-unload-crash-expected.html to the qt skipped list
because it's hanging:
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Thu, 13 May 2010 22:39:34 +0000 (22:39 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=39089
        <rdar://problem/7974044> Domain names in Russian '.рф' domain are displayed as punycode

        Add a custom check for this domain. Currently, this is the only non-ASCII TLD, we'll
        investigate a more extensible solution when there are more, and we know what the
        typical restictions are.

        * Misc/WebNSURLExtras.mm:
        (allCharactersAllowedByTLDRules):
        (-[NSString _web_mapHostNameWithRange:encode:makeString:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 13 May 2010 22:33:21 +0000 (22:33 +0000)]
2010-05-13  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Can't submit a form with <input type=checkbox required>
        https://bugs.webkit.org/show_bug.cgi?id=39065

        * fast/forms/interactive-validation-required-checkbox-expected.txt: Added.
        * fast/forms/interactive-validation-required-checkbox.html: Added.
2010-05-13  Kent Tamura  <tkent@chromium.org>

        Reviewed by Darin Adler.

        Can't submit a form with <input type=checkbox required>
        https://bugs.webkit.org/show_bug.cgi?id=39065

        Test: fast/forms/interactive-validation-required-checkbox.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::setChecked):
          Update the validity cache when a checkbox state is changed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=38928
beidson@apple.com [Thu, 13 May 2010 22:12:45 +0000 (22:12 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by NOBODY (Layout test fix)

Add Tiger specific results for my new test.

* platform/mac-tiger/fast/loader/recursive-before-unload-crash-expected.txt: Copied from fast/loader/recursive-before-unload-crash-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 13 May 2010 22:07:31 +0000 (22:07 +0000)]
2010-05-13  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Alias WebGLArray type names to TypedArray type names
        https://bugs.webkit.org/show_bug.cgi?id=39036

        Exposed the existing WebGL<T>Array constructor functions on the
        DOMWindow under the naming convention in the TypedArray spec. The
        implementations will be renamed in a subsequent bug, and the
        aliases to the WebGL<T>Array type names eventually removed. Ran
        all layout tests (including WebGL) in Safari, and WebGL tests in
        Chromium.

        Test: revised array-unit-tests.html to test both type names.
        Revised global prototype and constructor tests to ignore new types.

        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled):
        (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::arrayBuffer):
        (WebCore::JSDOMWindow::int8Array):
        (WebCore::JSDOMWindow::uint8Array):
        (WebCore::JSDOMWindow::int32Array):
        (WebCore::JSDOMWindow::uint32Array):
        (WebCore::JSDOMWindow::int16Array):
        (WebCore::JSDOMWindow::uint16Array):
        (WebCore::JSDOMWindow::floatArray):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::ArrayBufferAccessorGetter):
        (WebCore::V8DOMWindow::Int8ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Int16ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Int32ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter):
        (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
        * page/DOMWindow.idl:
2010-05-13  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Alias WebGLArray type names to TypedArray type names
        https://bugs.webkit.org/show_bug.cgi?id=39036

        Exposed the existing WebGL<T>Array constructor functions on the
        DOMWindow under the naming convention in the TypedArray spec. The
        implementations will be renamed in a subsequent bug, and the
        aliases to the WebGL<T>Array type names eventually removed. Ran
        all layout tests (including WebGL) in Safari, and WebGL tests in
        Chromium.

        Test: revised array-unit-tests.html to test both type names.
        Revised global prototype and constructor tests to ignore new types.

        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties.html:
        * fast/dom/script-tests/prototype-inheritance.js:
        * fast/js/script-tests/global-constructors.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=39084
hyatt@apple.com [Thu, 13 May 2010 21:51:36 +0000 (21:51 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39084

Reviewed by Anders Carlsson.

Improve :visited style resolution to reduce its memory footprint and to make some speed adjustments and
simplifications.

(1) Tie the caching of link state on CSSStyleSelector to the element.  Just clear out the element when
style resolution finishes for the unvisited case to avoid caching across external calls.  The internal
calls share the cache just fine by doing this.

(2) Delete the RenderStyle if the link is unvisited.  This shouldn't take long enough to make us vulnerable
to timing attacks, and it makes sure the overall footprint stays the way it used to be for unvisited links.

(3) Limit the set of properties that can be applied to :visited links to only the colors it supports.  This
stops images from being loadable from :visited rules.

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::init):
(WebCore::CSSStyleSelector::SelectorChecker::determineLinkState):
(WebCore::CSSStyleSelector::initElement):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::styleForElement):
(WebCore::CSSStyleSelector::pseudoStyleForElement):
(WebCore::isValidVisitedLinkProperty):
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSStyleSelector.h:
* rendering/style/RenderStyle.cpp:
(WebCore::colorIncludingFallback):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59387 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=38221
weinig@apple.com [Thu, 13 May 2010 21:32:26 +0000 (21:32 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=38221
Memory issues due to the changes in 36556 (increased CSSPrimitiveValue size).
Part of <rdar://problem/7921275>

Reviewed by Darin Adler.

- Use an external cache to speedup cssText for CSSPrimitiveValue instead
  of an extra member variable.

* css/CSSPrimitiveValue.cpp:
(WebCore::cssTextCache):
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):
(WebCore::CSSPrimitiveValue::cleanup):
(WebCore::CSSPrimitiveValue::cssText):
* css/CSSPrimitiveValue.h:
(WebCore::CSSPrimitiveValue::):
* css/CSSPrimitiveValueMappings.h:
(WebCore::CSSPrimitiveValue::CSSPrimitiveValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding block elements to a block and removing them changes the height of the element.
enrica@apple.com [Thu, 13 May 2010 20:48:52 +0000 (20:48 +0000)]
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock): resetting m_childrenInline flag to true when layout a block with no children.

LayoutTests:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

* editing/deleting/delete-block-contents-004-expected.txt: Added.
* editing/deleting/delete-block-contents-004.html: Added.
The following tests results have been updated to reflect the new renderer structure.
* editing/deleting/in-visibly-empty-root-expected.txt:
* platform/mac/editing/deleting/5408255-expected.txt:
* platform/mac/editing/deleting/delete-select-all-001-expected.txt:
* platform/mac/editing/selection/4895428-1-expected.txt:
* platform/mac/editing/selection/4895428-4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59385 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRepro crash at www.sears.com (infinite recursion in beforeunload handler)
beidson@apple.com [Thu, 13 May 2010 20:31:46 +0000 (20:31 +0000)]
Repro crash at sears.com (infinite recursion in beforeunload handler)
<rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by Darin Adler.

WebCore:

Test: fast/loader/recursive-before-unload-crash.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::shouldClose): Copied from Frame, with the pageDismissal flag set.
* loader/FrameLoader.h:

* page/Frame.cpp:
(WebCore::Frame::shouldClose): Forward to the new FrameLoader::shouldClose().
* page/Frame.h:
(WebCore::Frame::existingDOMWindow):

LayoutTests:

* fast/loader/recursive-before-unload-crash-expected.txt: Added.
* fast/loader/recursive-before-unload-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59384 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Thu, 13 May 2010 20:06:02 +0000 (20:06 +0000)]
2010-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59376.
        http://trac.webkit.org/changeset/59376
        https://bugs.webkit.org/show_bug.cgi?id=39080

        Broke window prototype tests (Requested by jamesr on #webkit).

        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:
2010-05-13  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59376.
        http://trac.webkit.org/changeset/59376
        https://bugs.webkit.org/show_bug.cgi?id=39080

        Broke window prototype tests (Requested by jamesr on #webkit).

        * bindings/generic/RuntimeEnabledFeatures.h:
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::webGLFloatArray):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59383 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Thu, 13 May 2010 19:35:33 +0000 (19:35 +0000)]
2010-05-13  Diego Gonzalez  <diegohcg@webkit.org>

    Reviewed by Kenneth Rohde Christiansen.

    [Qt] Improve QtLauncher user agent dialog resize
    https://bugs.webkit.org/show_bug.cgi?id=39062

    * QtLauncher/main.cpp:
    (LauncherWindow::showUserAgentDialog):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59382 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 13 May 2010 19:24:10 +0000 (19:24 +0000)]
2010-05-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: A disabled style property cannot be deleted.

        https://bugs.webkit.org/show_bug.cgi?id=39057

        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::applyStyleText):

2010-05-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: A disabled style property cannot be deleted.

        https://bugs.webkit.org/show_bug.cgi?id=39057

        * inspector/elements-tests.js:
        (frontend_getSelectedElementStyles):
        * inspector/styles-disable-then-delete-expected.txt: Added.
        * inspector/styles-disable-then-delete.html: Added.
        * inspector/styles-disable-then-enable.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59381 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-11 Diego Gonzalez <diegohcg@webkit.org>
diegohcg@webkit.org [Thu, 13 May 2010 19:15:41 +0000 (19:15 +0000)]
2010-05-11  Diego Gonzalez  <diegohcg@webkit.org>

    Reviewed by Kenneth Rohde Christiansen.

    [Qt] tst_QWebPage::inputMethods failing on Maemo5
    https://bugs.webkit.org/show_bug.cgi?id=38685

    Check if the SIP (Software Input Panel) is triggered, which usually happens
    in the case of a mobile platforms, an user input form receives a mouse click.

    * tests/qwebpage/tst_qwebpage.cpp:
    (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59380 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 May 2010 19:08:42 +0000 (19:08 +0000)]
2010-05-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        Disable compositing/iframes tests on the commit-queue as a workaround for  bug 38912
        https://bugs.webkit.org/show_bug.cgi?id=39067

        Fix yet another typo in my original hack.
        I also added another unit test for this fix.

        * Scripts/webkitpy/common/config/ports.py:
        * Scripts/webkitpy/common/config/ports_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59379 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing
tonikitoo@webkit.org [Thu, 13 May 2010 18:59:08 +0000 (18:59 +0000)]
[Qt] REGRESSION(r58497) tst_QGraphicsWebView::crashOnViewlessWebPages() is failing
https://bugs.webkit.org/show_bug.cgi?id=38655

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-05-11
Reviewed by Laszlo Gombos.

Fix double free by moving the connect till after the resize.

The bug is causes by the fact that a resize of an empty page causes a
layout, thus deleting the qgraphicswebview before setHtml is called,
which then deletes it again, causing a double free.

* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::crashOnViewlessWebPages):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59378 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRegression(r59152): QGraphicsPageClient is not forwarding scroll and update events...
tonikitoo@webkit.org [Thu, 13 May 2010 18:54:16 +0000 (18:54 +0000)]
Regression(r59152): QGraphicsPageClient is not forwarding scroll and update events to view https://bugs.webkit.org/show_bug.cgi?id=39016

Patch by Kenneth Rohde Christiansen <kenneth@webkit.org> on 2010-05-12
Reviewed by Laszlo Gombos.

Some forward calls got lost during the refatory.

* WebCoreSupport/PageClientQt.cpp:
(WebCore::PageClientQGraphicsWidget::scroll):
(WebCore::PageClientQGraphicsWidget::update):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59377 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Kenneth Russell <kbr@google.com>
kbr@google.com [Thu, 13 May 2010 18:51:55 +0000 (18:51 +0000)]
2010-05-12  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Alias WebGLArray type names to TypedArray type names
        https://bugs.webkit.org/show_bug.cgi?id=39036

        Exposed the existing WebGL<T>Array constructor functions on the
        DOMWindow under the naming convention in the TypedArray spec. The
        implementations will be renamed in a subsequent bug, and the
        aliases to the WebGL<T>Array type names eventually removed. Ran
        all WebGL layout tests in Safari and Chromium.

        Test: revised array-unit-tests.html to test both type names.

        * bindings/generic/RuntimeEnabledFeatures.h:
        (WebCore::RuntimeEnabledFeatures::arrayBufferEnabled):
        (WebCore::RuntimeEnabledFeatures::int8ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::uint8ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::int16ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::uint16ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::int32ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::uint32ArrayEnabled):
        (WebCore::RuntimeEnabledFeatures::floatArrayEnabled):
        * bindings/js/JSDOMWindowCustom.cpp:
        (WebCore::JSDOMWindow::arrayBuffer):
        (WebCore::JSDOMWindow::int8Array):
        (WebCore::JSDOMWindow::uint8Array):
        (WebCore::JSDOMWindow::int32Array):
        (WebCore::JSDOMWindow::uint32Array):
        (WebCore::JSDOMWindow::int16Array):
        (WebCore::JSDOMWindow::uint16Array):
        (WebCore::JSDOMWindow::floatArray):
        * bindings/v8/custom/V8DOMWindowCustom.cpp:
        (WebCore::V8DOMWindow::ArrayBufferAccessorGetter):
        (WebCore::V8DOMWindow::Int8ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Uint8ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Int16ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Uint16ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Int32ArrayAccessorGetter):
        (WebCore::V8DOMWindow::Uint32ArrayAccessorGetter):
        (WebCore::V8DOMWindow::FloatArrayAccessorGetter):
        * page/DOMWindow.idl:
2010-05-12  Kenneth Russell  <kbr@google.com>

        Reviewed by Dimitri Glazkov.

        Alias WebGLArray type names to TypedArray type names
        https://bugs.webkit.org/show_bug.cgi?id=39036

        Exposed the existing WebGL<T>Array constructor functions on the
        DOMWindow under the naming convention in the TypedArray spec. The
        implementations will be renamed in a subsequent bug, and the
        aliases to the WebGL<T>Array type names eventually removed. Ran
        all WebGL layout tests in Safari and Chromium.

        Test: revised array-unit-tests.html to test both type names.

        * fast/canvas/webgl/array-unit-tests-expected.txt:
        * fast/canvas/webgl/array-unit-tests.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59376 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 May 2010 18:33:08 +0000 (18:33 +0000)]
2010-05-13  Eric Seidel  <eric@webkit.org>

        Reviewed by Ojan Vafai.

        Disable compositing/iframes tests on the commit-queue as a workaround for  bug 38912
        https://bugs.webkit.org/show_bug.cgi?id=39067

        My previous (unreviewed) hack didn't actually work due to checking "mac" instead of "Mac".
        This change fixes my hack, and unit tests it.

        * Scripts/webkitpy/tool/mocktool.py:
         - Make it possible to make run_command log too.
        * Scripts/webkitpy/tool/steps/runtests.py:
         - Fix my hack to actually work.
        * Scripts/webkitpy/tool/steps/steps_unittest.py:
         - Test my hack (and basic RunTests behavior as well).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59375 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoPart of <rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928
beidson@apple.com [Thu, 13 May 2010 18:17:33 +0000 (18:17 +0000)]
Part of <rdar://problem/7965182> and https://bugs.webkit.org/show_bug.cgi?id=38928

Reviewed by John Sullivan.

No new tests. (No change in behavior)

m_unloadEventBeingDispatched was already overloaded to include both unload and pagehide events.
In general, these are "page dismissal" events, and might also include beforeunload, so let's rename
the flag!

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::FrameLoader):
(WebCore::FrameLoader::stopLoading):
(WebCore::FrameLoader::loadURL):
(WebCore::FrameLoader::loadWithDocumentLoader):
(WebCore::FrameLoader::stopAllLoaders):
(WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
(WebCore::FrameLoader::pageHidden):
* loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59374 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Antonio Gomes <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com>
tonikitoo@webkit.org [Thu, 13 May 2010 17:59:10 +0000 (17:59 +0000)]
2010-05-13  Antonio Gomes  <tonikitoo@webkit.org>, Yi Shen <yi.4.shen@nokia.com>

    Reviewed by Kenneth Christiansen.

    [Qt] Add LayoutTestController interface: computedStyleIncludingVisitedInfo
    https://bugs.webkit.org/show_bug.cgi?id=37759

    WebKit/qt:

    * WebCoreSupport/DumpRenderTreeSupportQt.cpp:
    (DumpRenderTreeSupportQt::markerTextForListItem):
    (DumpRenderTreeSupportQt::computedStyleIncludingVisitedInfo):
    * WebCoreSupport/DumpRenderTreeSupportQt.h:

    WebKitTools:

    * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
    (LayoutTestController::computedStyleIncludingVisitedInfo):
    * DumpRenderTree/qt/LayoutTestControllerQt.h:

    LayoutTests:

    * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59373 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Joseph Pecoraro <joepeck@webkit.org>
joepeck@webkit.org [Thu, 13 May 2010 17:27:15 +0000 (17:27 +0000)]
2010-05-13  Joseph Pecoraro  <joepeck@webkit.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Event Markers should be hidden in Resource's "Size" Graph
        https://bugs.webkit.org/show_bug.cgi?id=39074

        Added Show / Hide event dividers functionality to the timeline grid,
        and included delegation functions in AbstractTimelinePanel.

        * inspector/front-end/AbstractTimelinePanel.js: delegate to the inner grid
        (WebInspector.AbstractTimelinePanel.prototype.hideEventDividers):
        (WebInspector.AbstractTimelinePanel.prototype.showEventDividers):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.populateSidebar): save a reference to the size graph item to know when its selected
        (WebInspector.ResourcesPanel.prototype._graphSelected): if the size graph is selected hide the dividers, otherwise show them
        * inspector/front-end/TimelineGrid.js:
        (WebInspector.TimelineGrid.prototype.hideEventDividers): set the container to display: none
        (WebInspector.TimelineGrid.prototype.showEventDividers): set the container to display: block

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59372 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoConvert status bar text to UTF-8 before logging it on Windows
aroben@apple.com [Thu, 13 May 2010 17:08:29 +0000 (17:08 +0000)]
Convert status bar text to UTF-8 before logging it on Windows

We were previously logging the text using printf("%S", bstr). This
converts the UTF-16 BSTR to a multibyte string using wctomb, which
uses the codepage for the current locale to perform the conversion.
The conversion was failing, causing printf to bail and truncate the
string. By converting to UTF-8 manually before logging, we avoid this
issue (and also end up with UTF-8 output, which is what the expected
results contain). We may have to do this in other places in DRT,
eventually.

Fixes <http://webkit.org/b/38849> REGRESSION (r59016):
plugins/set-status.html fails on Windows

Reviewed by Alexey Proskuryakov.

* DumpRenderTree/win/DumpRenderTree.cpp:
(toUTF8): Moved this here from FrameLoadDelegate. Renamed from
BSTRtoString.

* DumpRenderTree/win/DumpRenderTreeWin.h: Added declaration of toUTF8.

* DumpRenderTree/win/FrameLoadDelegate.cpp: Removed BSTRtoString.
(descriptionSuitableForTestResult): Updated for rename.

* DumpRenderTree/win/UIDelegate.cpp:
(UIDelegate::setStatusText): Convert the status bar text to UTF-8
before logging it so that Windows won't try (and fail) to convert it
to the current locale's codepage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59371 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix typo in sunspider-compare-results.js that caused incorrect two-sample t statistic...
aroben@apple.com [Thu, 13 May 2010 17:07:32 +0000 (17:07 +0000)]
Fix typo in sunspider-compare-results.js that caused incorrect two-sample t statistics to be computed

Fixes <http://webkit.org/b/38768> SunSpider computes incorrect
two-sample t statistics

Reviewed by Darin Adler.

* resources/sunspider-compare-results.js:
(sunspiderCompareResults.resultLine): Fixed the calculation of the t
variable to match the definition of a two-sample t statistic. Looks
like this was just a simple typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59370 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 13 May 2010 15:35:23 +0000 (15:35 +0000)]
2010-05-13  Martin Robinson  <mrobinson@igalia.com>
        Reviewed by Gustavo Noronha.

        Events tests failing
        https://bugs.webkit.org/show_bug.cgi?id=31436

        Unskip these two test which are now passing.

        * platform/gtk/Skipped: Unskip two tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59369 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 13 May 2010 15:34:00 +0000 (15:34 +0000)]
2010-05-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: main inspector toolbar takes noticeable time to expand.

        https://bugs.webkit.org/show_bug.cgi?id=39013

        * src/js/DevTools.js:
        (devtools.domContentLoaded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59368 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 13 May 2010 15:21:21 +0000 (15:21 +0000)]
2010-05-13  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha.

        Two forms tests failing
        https://bugs.webkit.org/show_bug.cgi?id=31435

        Unskip passing tests.

        * platform/gtk/Skipped: Unskip these tests, because they are passing now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59367 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Thu, 13 May 2010 14:56:27 +0000 (14:56 +0000)]
2010-05-13  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Based on the spec and Philip Taylor's test suite, strokeStyle and fillStyle attributes
        must initially have the string value #000000.
        The link to the spec:
        http://philip.html5.org/tests/canvas/suite/tests/spec.html#testrefs.2d.colours.default

        https://bugs.webkit.org/show_bug.cgi?id=39068

        The complete test suite is in the process of checking in.
        https://bugs.webkit.org/show_bug.cgi?id=20553

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::State::State):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59366 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 13 May 2010 14:41:22 +0000 (14:41 +0000)]
2010-05-13  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed, rolling out r59360.
        http://trac.webkit.org/changeset/59360
        https://bugs.webkit.org/show_bug.cgi?id=38667

        It broke Chromium Win build

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane):
        (WebInspector.CallStackSidebarPane.prototype._placardSelected):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeOutline.prototype._keyDown):
        * inspector/front-end/HelpScreen.js: Removed.
        * inspector/front-end/KeyboardShortcut.js:
        (WebInspector.KeyboardShortcut._makeKeyFromCodeAndModifiers):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
        * inspector/front-end/ShortcutsHelp.js: Removed.
        * inspector/front-end/SidebarPane.js:
        (WebInspector.SidebarPane.prototype._onTitleKeyDown):
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.removeSection):
        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype._handleKeyDown):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/helpScreen.css: Removed.
        * inspector/front-end/inspector.html:
        * inspector/front-end/inspector.js:
        (WebInspector.loaded):
        (WebInspector.documentKeyDown):
        (WebInspector._searchKeyDown):
        (WebInspector.startEditing.keyDownEventListener):
        (WebInspector.startEditing):
        * inspector/front-end/utilities.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59365 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 May 2010 14:39:02 +0000 (14:39 +0000)]
2010-05-13  Eric Seidel  <eric@webkit.org>

        Unreviewed hack, attempting to get the commit-queue running again.

        Disable compositing/iframes tests on the commit-queue as a workaround for bug 38912
        https://bugs.webkit.org/show_bug.cgi?id=39067

        I had this hack locally on the commit-queue, but it's fragile
        and broke this morning.  It will work much better if committed
        to the repository.  In either case it's temporary while we
        work up a real fix for bug 38912.

        * Scripts/webkitpy/common/config/ports.py:
         - Expose an is_leopard() method.
        * Scripts/webkitpy/tool/steps/runtests.py:
         - Don't run compositing/iframes tests on the commit-queue under leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59364 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=39063
antti.j.koivisto@nokia.com [Thu, 13 May 2010 14:35:03 +0000 (14:35 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39063
[Qt] Tiled backing store checker pattern does not paint correctly when scaling factor is not 1

Reviewed by Kenneth Rohde Christiansen.

Use the dirty rect that has been adjusted for scaling instead of the original one.

* platform/graphics/TiledBackingStore.cpp:
(WebCore::TiledBackingStore::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59363 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Chang Shu <chang.shu@nokia.com>
chang.shu@nokia.com [Thu, 13 May 2010 14:07:08 +0000 (14:07 +0000)]
2010-05-13  Chang Shu  <chang.shu@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Based on Philip Taylor's test suite, resetting the canvas
        state resets the current path.
        https://bugs.webkit.org/show_bug.cgi?id=38934

        The complete test suite is in the process of checking in.
        https://bugs.webkit.org/show_bug.cgi?id=20553

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::reset):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59362 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Thu, 13 May 2010 13:48:29 +0000 (13:48 +0000)]
2010-05-13  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed. Chromium build fix. Partially rever r59277 which updated Chromium's expectations
        after r59270. r59270 was reverted, so we need to revert Chromium's expectations.

        * platform/chromium-linux/editing/deleting/5408255-expected.checksum:
        * platform/chromium-mac/editing/deleting/5408255-expected.checksum: Removed.
        * platform/chromium-win/editing/deleting/5408255-expected.checksum:
        * platform/chromium-win/editing/deleting/5408255-expected.txt:
        * platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
        * platform/chromium-win/editing/selection/4895428-1-expected.txt:
        * platform/chromium-win/editing/selection/4895428-4-expected.txt:
        * platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59361 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Andrey Kosyakov <caseq@chromium.org>
pfeldman@chromium.org [Thu, 13 May 2010 13:42:24 +0000 (13:42 +0000)]
2010-05-13  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Pavel Feldman.

        Added help screen with keyboard shortcuts.
        https://bugs.webkit.org/show_bug.cgi?id=38667

        * English.lproj/localizedStrings.js:
        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane):
        (WebInspector.CallStackSidebarPane.prototype._placardSelected):
        (WebInspector.CallStackSidebarPane.prototype.registerShortcuts):
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView):
        (WebInspector.ConsoleView.prototype._registerShortcuts):
        * inspector/front-end/ElementsPanel.js:
        (WebInspector.ElementsPanel):
        (WebInspector.ElementsPanel.prototype._registerShortcuts):
        * inspector/front-end/HelpScreen.js: Added.
        * inspector/front-end/KeyboardShortcut.js:
        (WebInspector.KeyboardShortcut.makeDescriptor):
        (WebInspector.KeyboardShortcut.shortcutToString):
        (WebInspector.KeyboardShortcut._modifiersToString):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel):
        (WebInspector.ScriptsPanel.prototype.elementsToRestoreScrollPositionsFor):
        (WebInspector.ScriptsPanel.prototype._registerShortcuts):
        * inspector/front-end/ShortcutsHelp.js: Added.
        * inspector/front-end/StylesSidebarPane.js:
        (WebInspector.StylesSidebarPane.prototype.removeSection):
        (WebInspector.StylesSidebarPane.prototype.registerShortcuts):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/helpScreen.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59360 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Takeshi Yoshino <tyoshino@google.com>
hamaji@chromium.org [Thu, 13 May 2010 12:12:47 +0000 (12:12 +0000)]
2010-05-13  Takeshi Yoshino  <tyoshino@google.com>

        Reviewed by Shinichiro Hamaji.

        Update test_expectations.txt for Chromium.
        fast/forms/implicit-submission.html is flaky on Linux.
        See http://crbug.com/43890 for detail.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59359 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNo review, attempted build fix.
mjs@apple.com [Thu, 13 May 2010 12:05:20 +0000 (12:05 +0000)]
No review, attempted build fix.

Try to fix Tiger build with some gratuitous initialization of
seemingly uninitialized variables.

* wtf/text/StringImpl.h:
(WebCore::StringImpl::tryCreateUninitialized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59358 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Yoshiki Hayashi <yhayashi@google.com>
hamaji@chromium.org [Thu, 13 May 2010 09:43:14 +0000 (09:43 +0000)]
2010-05-13  Yoshiki Hayashi  <yhayashi@google.com>

        Reviewed by Darin Adler.

        Fix a bug in handleRunInChild where only the first child run-in block
        is inserted because removeChildNode clears next sibling.
        https://bugs.webkit.org/show_bug.cgi?id=25047

        * fast/css/run-in-children-expected.txt: Added.
        * fast/css/run-in-children.html: Added.
2010-05-13  Yoshiki Hayashi  <yhayashi@google.com>

        Reviewed by Darin Adler.

        Fix a bug in handleRunInChild where only the first child run-in block
        is inserted because removeChildNode clears next sibling.
        https://bugs.webkit.org/show_bug.cgi?id=25047

        Test: fast/css/run-in-children.html

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::handleRunInChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59357 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Thu, 13 May 2010 09:37:34 +0000 (09:37 +0000)]
2010-05-13  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        In case there is no expose event we render the theme in a pixmap
        and copy it to the cairo context. This is slow but it is used just
        in case we are printing nowadays.

        [GTK] Theme does not render when printing
        https://bugs.webkit.org/show_bug.cgi?id=38896

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::paintMozillaGtkWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59356 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Maciej Stachowiak <mjs@apple.com>
mjs@apple.com [Thu, 13 May 2010 09:36:54 +0000 (09:36 +0000)]
2010-05-13  Maciej Stachowiak  <mjs@apple.com>

        Reviewed by Mark Rowe.

        Various JavaScript string optimizations
        https://bugs.webkit.org/show_bug.cgi?id=39051

        Approximately 1% SunSpider speedup.

        * runtime/ArrayPrototype.cpp:
        (JSC::arrayProtoFuncJoin): Remove branches from the hot code path
        by moving the first pass outside the loop, and duplicating the hot loop
        to extract the loop-invariant branch.
        * runtime/RegExp.cpp:
        (JSC::RegExp::match): resize ovector to 0 instead of clearing to avoid
        thrash in case of large matches.
        * runtime/RegExpConstructor.h:
        (JSC::RegExpConstructor::performMatch): Mark ALWAYS_INLINE to make the
        compiler respect our authority.
        * runtime/StringPrototype.cpp:
        (JSC::jsSpliceSubstringsWithSeparators): Inline.
        (JSC::stringProtoFuncSubstring): Rewrite boundary condition checks to
        reduce the number of floating point comparisons and branches.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59355 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKitTools: Unreviewed fix. Revert previous change.
ukai@chromium.org [Thu, 13 May 2010 08:52:26 +0000 (08:52 +0000)]
WebKitTools: Unreviewed fix.  Revert previous change.

Even if with-statments are changed in websocket_server.py, it also claims syntax error for with statement in http_server.py.
Until python 2.5 is installed on tiger bot, skips websocket/tests on tiger.

* Scripts/webkitpy/layout_tests/port/websocket_server.py: use with statement

LayoutTests: Unreviewed.

Skip websocket/tests on tiger, until Python 2.5 is installed on tiger bot.

* platform/mac-tiger/Skipped: Add websocket/tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59354 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebSocket: pywebsocket 0.5
ukai@chromium.org [Thu, 13 May 2010 08:52:06 +0000 (08:52 +0000)]
WebSocket: pywebsocket 0.5
https://bugs.webkit.org/show_bug.cgi?id=38034

Reviewed by David Levin.

Remove pywebsocket from webkitpy/thirdparty.
Make pywebsocket autoinstalled.

* Scripts/new-run-webkit-websocketserver:
  Add --output-dir option.
* Scripts/old-run-webkit-tests:
  Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
* Scripts/run-webkit-websocketserver:
  Ditto.
* Scripts/webkitpy/layout_tests/port/websocket_server.py:
  Use autoinstalled pywebsocket.
* Scripts/webkitpy/thirdparty/__init__.py:
  Autoinstall pywebsocket
* Scripts/webkitpy/thirdparty/pywebsocket: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59353 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix.
ukai@chromium.org [Thu, 13 May 2010 08:21:05 +0000 (08:21 +0000)]
Unreviewed fix.

On tiger bot, it claims syntax error for with statement.

* Scripts/webkitpy/layout_tests/port/websocket_server.py: rewrite with statement with try-finally.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59352 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Thu, 13 May 2010 07:32:38 +0000 (07:32 +0000)]
2010-05-12  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Fix Bug 35014 - Modifying UA rules from page JS crashes
        https://bugs.webkit.org/show_bug.cgi?id=35014

        * fast/css/modify-ua-rules-from-javascript-expected.txt: Copied from LayoutTests/editing/selection/5136696-expected.txt.
        * fast/css/modify-ua-rules-from-javascript.html: Added.
2010-05-12  Yuzo Fujishima  <yuzo@google.com>

        Reviewed by Darin Adler.

        Fix Bug 35014 - Modifying UA rules from page JS crashes
        Added a NULL check.
        https://bugs.webkit.org/show_bug.cgi?id=35014

        Test: fast/css/modify-ua-rules-from-javascript.html

        * css/CSSMutableStyleDeclaration.cpp:
        (WebCore::CSSMutableStyleDeclaration::setNeedsStyleRecalc):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59351 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-13 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Thu, 13 May 2010 07:28:37 +0000 (07:28 +0000)]
2010-05-13  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by David Levin.

        WebSocket: pywebsocket 0.5
        https://bugs.webkit.org/show_bug.cgi?id=38034

        Remove pywebsocket from webkitpy/thirdparty.
        Make pywebsocket autoinstalled.

        * Scripts/new-run-webkit-websocketserver:
          Add --output-dir option.
        * Scripts/old-run-webkit-tests:
          Use new-run-webkit-websocketserver, rather than directly run pywebsocket's standalone.py
        * Scripts/run-webkit-websocketserver:
          Ditto.
        * Scripts/webkitpy/layout_tests/port/websocket_server.py:
          Use autoinstalled pywebsocket.
        * Scripts/webkitpy/thirdparty/__init__.py:
          Autoinstall pywebsocket
        * Scripts/webkitpy/thirdparty/pywebsocket: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59350 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd the parent class for Database and DatabaseSync.
dumi@chromium.org [Thu, 13 May 2010 06:44:25 +0000 (06:44 +0000)]
Add the parent class for Database and DatabaseSync.
https://bugs.webkit.org/show_bug.cgi?id=39041

Reviewed by Adam Barth.

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* storage/AbstractDatabase.cpp: Added.
* storage/AbstractDatabase.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59349 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Hans Wennborg <hans@chromium.org>
eric@webkit.org [Thu, 13 May 2010 06:39:17 +0000 (06:39 +0000)]
2010-05-12  Hans Wennborg  <hans@chromium.org>

        Reviewed by Jeremy Orlow.

        [Chromium] Remove transitional functions from WebStorageNamespace and WebViewClient.
        https://bugs.webkit.org/show_bug.cgi?id=38985

        These functions are no longer called as of Chromium revision 47020.
        This is part of resolving http://crbug.com/42740

        * public/WebStorageNamespace.h:
        * public/WebViewClient.h:
        (WebKit::WebViewClient::createSessionStorageNamespace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59348 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Noam Rosenthal <noam.rosenthal@nokia.com>
eric@webkit.org [Thu, 13 May 2010 06:27:38 +0000 (06:27 +0000)]
2010-05-12  Noam Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] GraphicsLayer: depth-test causes flicker in certain situations

        This patch removes the simplistic 2D depth test as it leads to flickering side effects.
        https://bugs.webkit.org/show_bug.cgi?id=38370

        Tested by http://webkit.org/blog-files/3d-transforms/morphing-cubes.html

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::updateTransform):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59347 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 13 May 2010 06:20:08 +0000 (06:20 +0000)]
2010-05-12  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        [chromium] disable DRT in chromium again
        https://bugs.webkit.org/show_bug.cgi?id=39049

        * WebKit.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59346 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Thu, 13 May 2010 05:40:53 +0000 (05:40 +0000)]
2010-05-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59272.
        http://trac.webkit.org/changeset/59272
        https://bugs.webkit.org/show_bug.cgi?id=39047

        Original change (59270) was rolled out (Requested by smfr on
        #webkit).

        * platform/qt/editing/deleting/5408255-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed a bug in svn-apply whereby the reviewer would not get set if
cjerdonek@webkit.org [Thu, 13 May 2010 05:39:36 +0000 (05:39 +0000)]
Fixed a bug in svn-apply whereby the reviewer would not get set if
the portion of the patch for the ChangeLog contains "NOBODY (**PS!)"
in the leading junk.

Reviewed by Daniel Bates.

https://bugs.webkit.org/show_bug.cgi?id=38998

* Scripts/VCSUtils.pm:
  - Added the $changeLogTimeZone variable from svn-apply.
  - Added setChangeLogDateAndReviewer() from svn-apply.
  - Added a localTimeInProjectTimeZone() subroutine.
  - In setChangeLogDateAndReviewer():
    - Added an $epochTime parameter to make the subroutine more testable.
    - Made the "NOBODY (**PS!)" regular expression more specific so that
      it will not apply to text in the leading junk.
    - Updated to call localTimeInProjectTimeZone().
* Scripts/svn-apply:
  - Removed the $changeLogTimeZone file variable.
  - Added an $epochTime file variable to represent the current time.
  - Removed the setChangeLogDateAndReviewer() subroutine.
  - Updated patch() to use the new setChangeLogDateAndReviewer() syntax.
* Scripts/webkitperl/VCSUtils_unittest/setChangeLogDateAndReviewer.pl: Added.
  - Added unit tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59344 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Sheriff Bot <webkit.review.bot@gmail.com>
eric@webkit.org [Thu, 13 May 2010 05:38:24 +0000 (05:38 +0000)]
2010-05-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59276.
        http://trac.webkit.org/changeset/59276
        https://bugs.webkit.org/show_bug.cgi?id=39046

        Original change (59270) was rolled out (Requested by smfr on
        #webkit).

        * platform/gtk/editing/deleting/delete-select-all-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 13 May 2010 05:28:58 +0000 (05:28 +0000)]
2010-05-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Mark Rowe.

        Fix layer dump to avoid spurious platform differences
        https://bugs.webkit.org/show_bug.cgi?id=39045

        Only dump the children transform on layers that are not the root layer.
        The children transform on the root layer is used on Leopard to implement
        geometry flipping, so avoid this supurious difference in test output.

        * platform/graphics/GraphicsLayer.cpp:
        (WebCore::GraphicsLayer::dumpProperties):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59342 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Sheriff Bot <webkit.review.bot@gmail.com>
simon.fraser@apple.com [Thu, 13 May 2010 04:45:33 +0000 (04:45 +0000)]
2010-05-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59270.
        http://trac.webkit.org/changeset/59270
        https://bugs.webkit.org/show_bug.cgi?id=39044

        Caused a crash on some pages - bug 39042 (Requested by smfr on
        #webkit).

        * editing/deleting/delete-block-contents-004-expected.txt: Removed.
        * editing/deleting/delete-block-contents-004.html: Removed.
        * editing/deleting/in-visibly-empty-root-expected.txt:
        * platform/mac/editing/deleting/5408255-expected.txt:
        * platform/mac/editing/deleting/delete-select-all-001-expected.txt:
        * platform/mac/editing/selection/4895428-1-expected.txt:
        * platform/mac/editing/selection/4895428-4-expected.txt:
        * platform/mac/fast/events/mouseout-dead-node-expected.txt:
2010-05-12  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r59270.
        http://trac.webkit.org/changeset/59270
        https://bugs.webkit.org/show_bug.cgi?id=39044

        Caused a crash on some pages - bug 39042 (Requested by smfr on
        #webkit).

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 13 May 2010 04:12:16 +0000 (04:12 +0000)]
2010-05-12  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        test-webkitpy fails on windows due to lack of readline module
        https://bugs.webkit.org/show_bug.cgi?id=38884

        Win32 Python does not have a readline module, so we should
        not exit(1) if the import fails.

        Also the failure message is mac-specific and doesn't need to be.
        Only print the mac-specific install instructions on mac.

        * Scripts/webkitpy/common/system/user.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59340 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=39039
barraclough@apple.com [Thu, 13 May 2010 04:01:56 +0000 (04:01 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=39039
Provide support for separate bytecode/JIT code translations for call/construct usage
This will allow us to produce code generated specifically for use as a constructor, not for general function use.

Reviewed by Oliver Hunt.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::CodeBlock):
(JSC::CodeBlock::unlinkCallers):
* bytecode/CodeBlock.h:
(JSC::CodeBlock::getBytecodeIndex):
(JSC::CodeBlock::getJITCode):
(JSC::CodeBlock::executablePool):
(JSC::GlobalCodeBlock::GlobalCodeBlock):
(JSC::FunctionCodeBlock::FunctionCodeBlock):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::executeCall):
(JSC::Interpreter::executeConstruct):
(JSC::Interpreter::prepareForRepeatCall):
(JSC::Interpreter::execute):
(JSC::Interpreter::privateExecute):
* interpreter/Interpreter.h:
* jit/JIT.cpp:
(JSC::JIT::unlinkCallOrConstruct):
(JSC::JIT::linkConstruct):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
* jit/JITOpcodes.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITOpcodes32_64.cpp:
(JSC::JIT::privateCompileCTIMachineTrampolines):
* jit/JITPropertyAccess.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITPropertyAccess32_64.cpp:
(JSC::JIT::emitSlow_op_get_by_val):
* jit/JITStubs.cpp:
(JSC::DEFINE_STUB_FUNCTION):
* jit/JITStubs.h:
(JSC::JITThunks::ctiVirtualConstructLink):
(JSC::JITThunks::ctiVirtualConstruct):
(JSC::):
* jit/SpecializedThunkJIT.h:
(JSC::SpecializedThunkJIT::finalize):
* runtime/Arguments.h:
(JSC::JSActivation::copyRegisters):
* runtime/ArrayPrototype.cpp:
(JSC::isNumericCompareFunction):
* runtime/Executable.cpp:
(JSC::FunctionExecutable::~FunctionExecutable):
(JSC::FunctionExecutable::compileForCall):
(JSC::FunctionExecutable::compileForConstruct):
(JSC::EvalExecutable::generateJITCode):
(JSC::ProgramExecutable::generateJITCode):
(JSC::FunctionExecutable::generateJITCodeForCall):
(JSC::FunctionExecutable::generateJITCodeForConstruct):
(JSC::FunctionExecutable::markAggregate):
(JSC::FunctionExecutable::reparseExceptionInfo):
(JSC::EvalExecutable::reparseExceptionInfo):
(JSC::FunctionExecutable::recompile):
* runtime/Executable.h:
(JSC::ExecutableBase::ExecutableBase):
(JSC::ExecutableBase::isHostFunction):
(JSC::ExecutableBase::generatedJITCodeForCall):
(JSC::ExecutableBase::generatedJITCodeForConstruct):
(JSC::NativeExecutable::NativeExecutable):
(JSC::EvalExecutable::jitCode):
(JSC::ProgramExecutable::jitCode):
(JSC::FunctionExecutable::bytecodeForCall):
(JSC::FunctionExecutable::isGeneratedForCall):
(JSC::FunctionExecutable::generatedBytecodeForCall):
(JSC::FunctionExecutable::bytecodeForConstruct):
(JSC::FunctionExecutable::isGeneratedForConstruct):
(JSC::FunctionExecutable::generatedBytecodeForConstruct):
(JSC::FunctionExecutable::symbolTable):
(JSC::FunctionExecutable::FunctionExecutable):
(JSC::FunctionExecutable::jitCodeForCall):
(JSC::FunctionExecutable::jitCodeForConstruct):
* runtime/JSActivation.h:
(JSC::JSActivation::JSActivationData::JSActivationData):
* runtime/JSFunction.cpp:
(JSC::JSFunction::~JSFunction):
(JSC::JSFunction::call):
(JSC::JSFunction::construct):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::numericCompareFunction):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 13 May 2010 03:27:47 +0000 (03:27 +0000)]
2010-05-12  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by David Hyatt.

        Composited plug-ins can cause missed painting
        https://bugs.webkit.org/show_bug.cgi?id=39033
        <rdar://problem/7972478>

        Fixed missed painting (and assertions in debug builds) related to compositing
        propagating out of iframes that contain plug-ins.

        When an iframe enters or leaves compositing mode, RenderLayerCompositor uses
        setNeedsStyleRecalc(SyntheticStyleChange) to trigger the parent document to re-evaluate
        whether the iframe itself should be composited. However, for iframes containing plug-ins,
        this can happen at inappropriate times. For example, when a browser tab is brought frontmost,
        plug-ins are instantiated for the first time (via -viewDidMoveToWindow), which triggers a
        setNeedsStyleRecalc() on the object element. Soon after, the -viewWillDraw machinery
        does layout from the top down. During layout of the iframe, the iframe enters compositing mode,
        and does a setNeedsStyleRecalc() on the iframe element in its parent document. This leaves the
        FrameView as needsLayout(), so the FrameView::paintContents() asserts and bails.

        The fix is to avoid doing a setNeedsStyleRecalc() on the root while inside a recalcStyle on
        the iframe. We do this by switching the iframe into compositing mode eagerly as soon as we know
        the plug-in needs it.

        A secondary fix is to ensure that if a document has composited iframes, when that document becomes
        composited, we connect compositing layers between the iframes and the parent document.

        Tests: compositing/iframes/connect-compositing-iframe-delayed.html
               compositing/iframes/iframe-src-change.html

        * WebCore.base.exp: Export FrameView::enterCompositingMode()

        * page/FrameView.h: New method, enterCompositingMode(), that we can call from WebKit plug-in code.
        * page/FrameView.cpp:
        (WebCore::FrameView::enterCompositingMode):

        * rendering/RenderLayerCompositor.h:
        * rendering/RenderLayerCompositor.cpp:
        (WebCore::RenderLayerCompositor::enableCompositingMode): When we switch into compositing mode, we
            force a style recaclc on any iframes to get them into compositing layers, so they can hook up
            with their content layers if necessary.
        (WebCore::RenderLayerCompositor::didMoveOnscreen): Only call attachRootPlatformLayer() if we really need to.
        (WebCore::RenderLayerCompositor::willMoveOffscreen): Only call detachRootPlatformLayer() if we really need to.
        (WebCore::RenderLayerCompositor::detachRootPlatformLayer): Whitespace.
        (WebCore::RenderLayerCompositor::notifyIFramesOfCompositingChange): Fetch iframe elements, and send a
            synthetic style recalc on them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59338 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix
oliver@apple.com [Thu, 13 May 2010 03:20:39 +0000 (03:20 +0000)]
Build fix

<rdar://problem/7977960> REGRESSION (r59282): Tiger PPC build broken

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59337 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Oliver Hunt <oliver@apple.com>
oliver@apple.com [Thu, 13 May 2010 03:12:19 +0000 (03:12 +0000)]
2010-05-12  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        <rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
        https://bugs.webkit.org/show_bug.cgi?id=39038

        Correct the use of incorrect comparison operators.

        * jit/JITArithmetic32_64.cpp:
        (JSC::JIT::emit_op_jlesseq):
        (JSC::JIT::emitBinaryDoubleOp):
2010-05-12  Oliver Hunt  <oliver@apple.com>

        Reviewed by Gavin Barraclough.

        <rdar://7969718> Incorrect 32-bit codegen for op_jnlesseq
        https://bugs.webkit.org/show_bug.cgi?id=39038

        Add more tests for <=, <, >, and >=.

        * fast/js/comparison-operators-greater-expected.txt:
        * fast/js/comparison-operators-less-expected.txt:
        * fast/js/script-tests/comparison-operators-greater.js:
        * fast/js/script-tests/comparison-operators-less.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Joe Ligman <joseph.ligman@nokia.com>
eric@webkit.org [Thu, 13 May 2010 02:37:59 +0000 (02:37 +0000)]
2010-05-12  Joe Ligman  <joseph.ligman@nokia.com>

        Reviewed by Laszlo Gombos.

        [Qt] Nested overflow div does not scroll
        https://bugs.webkit.org/show_bug.cgi?id=38641

        Modify qtwebkit_webframe_scrollOverflow, if the current node's render layer
        does not scroll it will try and scroll the parent's render layer. Also export
        qtwebkit_webframe_scrollOverflow so we can use it independently of
        qtwebkit_webframe_scrollRecursively

        * Api/qwebframe.cpp:
        (qtwebkit_webframe_scrollOverflow):
        (qtwebkit_webframe_scrollRecursively):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Caio Marcelo de Oliveira Filho <caio.oliveira@openbossa.org>
eric@webkit.org [Thu, 13 May 2010 02:25:59 +0000 (02:25 +0000)]
2010-05-12  Caio Marcelo de Oliveira Filho  <caio.oliveira@openbossa.org>

        Reviewed by Eric Seidel.

        JavaScriptCore: fix build when some optimizations are disabled
        https://bugs.webkit.org/show_bug.cgi?id=38800

        Remove outdated UNUSED_PARAMs when using JIT but with
        ENABLE_JIT_OPTIMIZE_CALL and ENABLE_JIT_OPTIMIZE_PROPERTY_ACCESS
        disabled.

        * jit/JITOpcodes.cpp:
        * jit/JITOpcodes32_64.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 13 May 2010 01:26:43 +0000 (01:26 +0000)]
2010-05-12  Kent Tamura  <tkent@chromium.org>

        Reviewed by Nate Chapin.

        [DRT/Chromium] Add a missing Sans-serif font setting
        https://bugs.webkit.org/show_bug.cgi?id=38981

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::resetWebSettings):
          Set "Helvetica" for Sans-serif. It is the same as the default setting of test_shell.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 John Abd-El-Malek <jam@chromium.org>
jam@chromium.org [Thu, 13 May 2010 00:46:42 +0000 (00:46 +0000)]
2010-05-12  John Abd-El-Malek  <jam@chromium.org>

        Reviewed by Darin Fisher.

        [chromium] Disable WebScrollbarImpl's scrollbar if it's not needed
        https://bugs.webkit.org/show_bug.cgi?id=39025

        * src/WebScrollbarImpl.cpp:
        (WebKit::WebScrollbarImpl::setLocation):
        (WebKit::WebScrollbarImpl::setDocumentSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoVersioning.
mrowe@apple.com [Thu, 13 May 2010 00:41:10 +0000 (00:41 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 13 May 2010 00:34:42 +0000 (00:34 +0000)]
2010-05-12  Anders Carlsson  <andersca@apple.com>

        Reviewed by Simon Fraser.

        Shrink the size of FillLayer by moving a member variable.
        https://bugs.webkit.org/show_bug.cgi?id=39035

        * rendering/style/FillLayer.cpp:
        (WebCore::FillLayer::FillLayer):
        * rendering/style/FillLayer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-10 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 May 2010 23:55:28 +0000 (23:55 +0000)]
2010-05-10  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        webkit-patch upload --fancy-review now uses the bugzilla bug ID as the rietveld ID
        https://bugs.webkit.org/show_bug.cgi?id=38866

        wkrietveld.appspot.com has already been updated to allow you to
        pass --issue for the issue creation as well as subsequent uploads.

        Also, remove the extra code for trying to read out the issue ID
        from the changelog description since we just use the bugzilla ID now.

        * Scripts/webkitpy/common/config/__init__.py:
        * Scripts/webkitpy/common/net/rietveld.py:
        * Scripts/webkitpy/tool/steps/postcodereview.py:
        * Scripts/webkitpy/tool/steps/postdiff.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Wed, 12 May 2010 23:34:15 +0000 (23:34 +0000)]
2010-05-12  Ojan Vafai  <ojan@chromium.org>

        No review needed.

        Marking myself as a reviewer.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWork around GCC stupidity by either explicitly inlining or by
oliver@apple.com [Wed, 12 May 2010 23:25:32 +0000 (23:25 +0000)]
Work around GCC stupidity by either explicitly inlining or by
using ALWAYS_INLINE

Reviewed by Gaving Barraclough.

* runtime/StringPrototype.cpp:
(JSC::stringProtoFuncReplace):
* runtime/UString.h:
(JSC::UString::~UString):
* wtf/RefPtr.h:
(WTF::RefPtr::RefPtr):
(WTF::RefPtr::~RefPtr):
* wtf/text/StringImpl.h:
(WebCore::StringImpl::create):
(WebCore::StringImpl::tryCreateUninitialized):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoA bunch of nice micro-optimizations for ~1% speedup on PLT.
weinig@apple.com [Wed, 12 May 2010 23:21:59 +0000 (23:21 +0000)]
A bunch of nice micro-optimizations for ~1% speedup on PLT.
- Add fastGetAttribute. The same as getAttribute except can only be
  called when it is known not to be style attribute or one of the SVG
  animatable attributes.
- Inline some functions from Font.
- Return the same string from deprecatedParseURL if there is nothing
  to strip.
- Use a member variable instead of a virtual function to determine
  whether a ScheduledNavigation is a location change.

Reviewed by Anders Carlsson.

* WebCore.base.exp:
* css/CSSHelper.cpp:
(WebCore::deprecatedParseURL):
* css/CSSStyleSelector.cpp:
(WebCore::linkAttribute):
(WebCore::CSSStyleSelector::canShareStyleWithElement):
(WebCore::CSSStyleSelector::SelectorChecker::checkOneSelector):
* dom/Element.cpp:
(WebCore::Element::getAttribute):
* dom/Element.h:
(WebCore::Element::fastHasAttribute):
(WebCore::Element::fastGetAttribute):
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::formControlName):
* html/HTMLInputElement.cpp:
(WebCore::HTMLInputElement::value):
* loader/RedirectScheduler.cpp:
(WebCore::ScheduledNavigation::ScheduledNavigation):
(WebCore::ScheduledNavigation::isLocationChange):
(WebCore::ScheduledURLNavigation::ScheduledURLNavigation):
(WebCore::ScheduledRedirect::ScheduledRedirect):
(WebCore::ScheduledLocationChange::ScheduledLocationChange):
(WebCore::ScheduledRefresh::ScheduledRefresh):
(WebCore::ScheduledHistoryNavigation::ScheduledHistoryNavigation):
(WebCore::ScheduledFormSubmission::ScheduledFormSubmission):
(WebCore::RedirectScheduler::locationChangePending):
* platform/graphics/Font.cpp:
* platform/graphics/Font.h:
(WebCore::Font::~Font):
(WebCore::Font::primaryFont):
(WebCore::Font::fontDataAt):
(WebCore::Font::fontDataForCharacters):
(WebCore::Font::isFixedPitch):
(WebCore::Font::fontSelector):
* platform/graphics/FontFallbackList.h:
* rendering/RenderImage.cpp:
(WebCore::RenderImage::imageMap):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 12 May 2010 22:48:49 +0000 (22:48 +0000)]
2010-05-12  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Change expectation from IMAGE to IMAGE+TEXT for Chromium Linux; I'm
        not sure if this is flaky or not but it seems to be consistent on the
        bot.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 12 May 2010 22:36:32 +0000 (22:36 +0000)]
2010-05-12  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Eric Seidel.

        new-run-webkit-tests: add a --print default option so that you can
        easily get the default output plus something (e.g., you can say
        '--print default,config' instead of '--print misc,one-line-progress,
        one-line-summary,unexpected,unexpected-results,updates,config'.

        Also, add more unit tests for --verbose, --print everything, etc.

        https://bugs.webkit.org/show_bug.cgi?id=38877

        * Scripts/webkitpy/layout_tests/layout_package/printing.py:
        * Scripts/webkitpy/layout_tests/layout_package/printing_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Wed, 12 May 2010 22:35:00 +0000 (22:35 +0000)]
2010-05-12  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Nate Chapin.

        Expectations fix and new chromium baselines resulting from the
        input type=search change in r58313.

        https://bugs.webkit.org/show_bug.cgi?id=38965

        * platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.checksum:
        * platform/chromium-linux/fast/forms/placeholder-pseudo-style-expected.png:
        * platform/chromium-linux/fast/forms/search-vertical-alignment-expected.checksum:
        * platform/chromium-linux/fast/forms/search-vertical-alignment-expected.png: Added.
        * platform/chromium-win/fast/forms/search-vertical-alignment-expected.checksum:
        * platform/chromium-win/fast/forms/search-vertical-alignment-expected.png: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/forms/search-zoomed-expected.checksum:
        * platform/mac/fast/forms/search-zoomed-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Chromium: rebaseline layout tests.
jianli@chromium.org [Wed, 12 May 2010 22:33:56 +0000 (22:33 +0000)]
Unreviewed. Chromium: rebaseline layout tests.

* platform/chromium-linux/editing/deleting/5408255-expected.checksum:
* platform/chromium-linux/editing/deleting/5408255-expected.png:
* platform/chromium-linux/fast/css/pseudo-cache-stale-expected.checksum:
* platform/chromium-linux/fast/css/pseudo-cache-stale-expected.png:
* platform/chromium-mac/editing/deleting/5408255-expected.checksum: Added.
* platform/chromium-mac/editing/deleting/5408255-expected.png: Added.
* platform/chromium-mac/fast/css/pseudo-cache-stale-expected.checksum: Added.
* platform/chromium-win/editing/deleting/5408255-expected.checksum:
* platform/chromium-win/editing/deleting/5408255-expected.png:
* platform/chromium-win/editing/deleting/5408255-expected.txt:
* platform/chromium-win/editing/deleting/delete-select-all-001-expected.txt:
* platform/chromium-win/editing/selection/4895428-1-expected.txt:
* platform/chromium-win/editing/selection/4895428-4-expected.txt:
* platform/chromium-win/fast/css/pseudo-cache-stale-expected.checksum:
* platform/chromium-win/fast/css/pseudo-cache-stale-expected.png:
* platform/chromium-win/fast/css/pseudo-cache-stale-expected.txt:
* platform/chromium-win/fast/events/mouseout-dead-node-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 12 May 2010 22:31:25 +0000 (22:31 +0000)]
2010-05-12  Martin Robinson  <mrobinson@igalia.com>

        No review. Updating the baseline for this test after r59270.

        * platform/gtk/editing/deleting/delete-select-all-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoQt build failures cause SheriffBot false positives
ossy@webkit.org [Wed, 12 May 2010 22:10:36 +0000 (22:10 +0000)]
Qt build failures cause SheriffBot false positives
https://bugs.webkit.org/show_bug.cgi?id=38969

Reviewed by Adam Barth.

Add Qt bots back to the core builders, because bug fixed by r59261.

* Scripts/webkitpy/common/net/buildbot.py:
* Scripts/webkitpy/common/net/buildbot_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake InlineBoxes use an IntRect for dimensions, and eliminate the dynamic computation...
hyatt@apple.com [Wed, 12 May 2010 22:07:46 +0000 (22:07 +0000)]
Make InlineBoxes use an IntRect for dimensions, and eliminate the dynamic computation of height() every time.

Reviewed by Sam Weinig.

* WebCore.xcodeproj/project.pbxproj:
* editing/visible_units.cpp:
(WebCore::previousLinePosition):
(WebCore::nextLinePosition):
* rendering/EllipsisBox.cpp:
(WebCore::EllipsisBox::paint):
(WebCore::EllipsisBox::selectionRect):
(WebCore::EllipsisBox::paintSelection):
(WebCore::EllipsisBox::nodeAtPoint):
* rendering/EllipsisBox.h:
(WebCore::EllipsisBox::EllipsisBox):
* rendering/InlineBox.cpp:
(WebCore::InlineBox::adjustPosition):
(WebCore::InlineBox::canAccommodateEllipsis):
* rendering/InlineBox.h:
(WebCore::InlineBox::InlineBox):
(WebCore::InlineBox::isSVGRootInlineBox):
(WebCore::InlineBox::x):
(WebCore::InlineBox::y):
(WebCore::InlineBox::width):
(WebCore::InlineBox::height):
(WebCore::InlineBox::bottom):
(WebCore::InlineBox::right):
(WebCore::InlineBox::setX):
(WebCore::InlineBox::setY):
(WebCore::InlineBox::setWidth):
(WebCore::InlineBox::setHeight):
(WebCore::InlineBox::location):
(WebCore::InlineBox::size):
(WebCore::InlineBox::setLocation):
(WebCore::InlineBox::setSize):
(WebCore::InlineBox::move):
(WebCore::InlineBox::frameRect):
(WebCore::InlineBox::setFrameRect):
(WebCore::InlineBox::baselinePosition):
(WebCore::InlineBox::lineHeight):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::placeBoxesVertically):
(WebCore::InlineFlowBox::computeVerticalOverflow):
(WebCore::InlineFlowBox::nodeAtPoint):
(WebCore::InlineFlowBox::paintBoxDecorations):
(WebCore::InlineFlowBox::paintMask):
(WebCore::InlineFlowBox::paintTextDecorations):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::visibleOverflowRect):
(WebCore::InlineFlowBox::topLayoutOverflow):
(WebCore::InlineFlowBox::bottomLayoutOverflow):
(WebCore::InlineFlowBox::leftLayoutOverflow):
(WebCore::InlineFlowBox::rightLayoutOverflow):
(WebCore::InlineFlowBox::layoutOverflowRect):
(WebCore::InlineFlowBox::topVisualOverflow):
(WebCore::InlineFlowBox::bottomVisualOverflow):
(WebCore::InlineFlowBox::leftVisualOverflow):
(WebCore::InlineFlowBox::rightVisualOverflow):
(WebCore::InlineFlowBox::visualOverflowRect):
(WebCore::InlineFlowBox::setHorizontalOverflowPositions):
(WebCore::InlineFlowBox::setVerticalOverflowPositions):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::selectionRect):
(WebCore::InlineTextBox::placeEllipsisBox):
(WebCore::InlineTextBox::nodeAtPoint):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintSelection):
(WebCore::InlineTextBox::paintCompositionBackground):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintSpellingOrGrammarMarker):
(WebCore::InlineTextBox::paintTextMatchMarker):
(WebCore::InlineTextBox::computeRectForReplacementMarker):
(WebCore::InlineTextBox::paintCompositionUnderline):
(WebCore::InlineTextBox::offsetForPosition):
(WebCore::InlineTextBox::positionForOffset):
* rendering/InlineTextBox.h:
(WebCore::InlineTextBox::setSpaceAdd):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::positionForPointWithInlineChildren):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeVerticalPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderSVGInline.cpp:
(WebCore::RenderSVGInline::createInlineFlowBox):
* rendering/RenderSVGInlineText.cpp:
(WebCore::RenderSVGInlineText::createTextBox):
* rendering/RenderSVGText.cpp:
(WebCore::RenderSVGText::createRootInlineBox):
* rendering/RenderText.cpp:
(WebCore::RenderText::positionForPoint):
(WebCore::RenderText::firstRunX):
(WebCore::RenderText::firstRunY):
* rendering/RenderTreeAsText.cpp:
(WebCore::writeTextRun):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::placeEllipsis):
(WebCore::RootInlineBox::addHighlightOverflow):
(WebCore::RootInlineBox::closestLeafChildForXPos):
* rendering/SVGInlineFlowBox.h:
(WebCore::SVGInlineFlowBox::SVGInlineFlowBox):
* rendering/SVGInlineTextBox.h:
(WebCore::SVGInlineTextBox::selectionTop):
(WebCore::SVGInlineTextBox::selectionHeight):
* rendering/SVGRootInlineBox.h:
(WebCore::SVGRootInlineBox::SVGRootInlineBox):
(WebCore::SVGRootInlineBox::isSVGRootInlineBox):
* rendering/TrailingFloatsRootInlineBox.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemoving the unnecessary dirfd parameter.
dumi@chromium.org [Wed, 12 May 2010 21:52:17 +0000 (21:52 +0000)]
Removing the unnecessary dirfd parameter.
https://bugs.webkit.org/show_bug.cgi?id=38869

Reviewed by Dimitri Glazkov.

WebCore:

* platform/chromium/ChromiumBridge.h:
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp:

WebKit/chromium:

* public/WebKitClient.h:
(WebKit::WebKitClient::databaseOpenFile):
* src/ChromiumBridge.cpp:
(WebCore::ChromiumBridge::databaseOpenFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed fix after r59270.
ossy@webkit.org [Wed, 12 May 2010 21:47:16 +0000 (21:47 +0000)]
Unreviewed fix after r59270.
Update Qt specific expected result based on IRC discussing with Enrica Casucci.

* platform/qt/editing/deleting/5408255-expected.txt: updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoHide the in-rietveld flag in the UI. It is only used only by tooling and shouldn...
jparent@chromium.org [Wed, 12 May 2010 21:34:13 +0000 (21:34 +0000)]
Hide the in-rietveld flag in the UI.  It is only used only by tooling and shouldn't clutter the UI.
https://bugs.webkit.org/show_bug.cgi?id=39024

Reviewed by Ojan Vafai.

* template/en/custom/attachment/list.html.tmpl:
  Removes this flag entirely from the UI, not needed on this page.
* template/en/custom/flag/list.html.tmpl: Added.
  Copied from template/en/default/flag/list.html.tmpl with only changes inside the if WEBKIT_CHANGES section.
  Hides the flag rather than removing it completely, so tools can still interact with it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdding block elements to a block and removing them changes the height of the element.
enrica@apple.com [Wed, 12 May 2010 21:24:10 +0000 (21:24 +0000)]
Adding block elements to a block and removing them changes the height of the element.
https://bugs.webkit.org/show_bug.cgi?id=38874

Reviewed by Dave Hyatt.

WebCore:

The initial height of an empty editable block is different from the height of the same block after we add block elements
and remove them.

Test: editing/deleting/delete-block-contents-004.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::removeChild): m_childrenInline was set to true only when the Renderer is created
and never reset to true when all the block elements contained are removed.

LayoutTests:

* editing/deleting/delete-block-contents-004-expected.txt: Added.
* editing/deleting/delete-block-contents-004.html: Added.
The following tests have new results because of the height change and because we now have one less renderer after the DOM changes.
* editing/deleting/in-visibly-empty-root-expected.txt:
* platform/mac/editing/deleting/5408255-expected.txt:
* platform/mac/editing/deleting/delete-select-all-001-expected.txt:
* platform/mac/editing/selection/4895428-1-expected.txt:
* platform/mac/editing/selection/4895428-4-expected.txt:
* platform/mac/fast/events/mouseout-dead-node-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Chromium: rebaseline layout tests and mark one failed layout test.
jianli@chromium.org [Wed, 12 May 2010 21:21:14 +0000 (21:21 +0000)]
Unreviewed. Chromium: rebaseline layout tests and mark one failed layout test.

* platform/chromium-linux/fast/forms/placeholder-stripped-expected.checksum: Added.
* platform/chromium-linux/fast/forms/placeholder-stripped-expected.png: Added.
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
* platform/chromium-linux/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/chromium-linux/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
* platform/chromium-mac/fast/forms/placeholder-stripped-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-light-01-f-expected.png: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum: Added.
* platform/chromium-mac/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png: Added.
* platform/chromium-win/fast/forms/placeholder-stripped-expected.checksum: Added.
* platform/chromium-win/fast/forms/placeholder-stripped-expected.png: Added.
* platform/chromium-win/fast/forms/placeholder-stripped-expected.txt: Added.
* platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.checksum:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-diffuse-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.checksum:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-light-01-f-expected.png:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.checksum:
* platform/chromium-win/svg/W3C-SVG-1.1/filters-specular-01-f-expected.png:
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.checksum: Added.
* platform/chromium-win/svg/custom/svg-fonts-with-no-element-reference-expected.png: Added.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Adam Langley <agl@chromium.org>
agl@chromium.org [Wed, 12 May 2010 21:18:36 +0000 (21:18 +0000)]
2010-05-12  Adam Langley  <agl@chromium.org>

        Expectations change. Unreviewed.

        Add baselines for fast/css/font-face-woff.html.

        * platform/chromium-linux/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-linux/fast/css/font-face-woff-expected.png: Added.
        * platform/chromium-mac/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-mac/fast/css/font-face-woff-expected.png: Added.
        * platform/chromium-mac/fast/css/font-face-woff-expected.txt: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.checksum: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.png: Added.
        * platform/chromium-win/fast/css/font-face-woff-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoDo not check if a database needs to be vacuumed after a read-only transaction.
dumi@chromium.org [Wed, 12 May 2010 21:08:10 +0000 (21:08 +0000)]
Do not check if a database needs to be vacuumed after a read-only transaction.
https://bugs.webkit.org/show_bug.cgi?id=38972

Reviewed by Dimitri Glazkov.

* storage/SQLTransaction.cpp:
(WebCore::SQLTransaction::postflightAndCommit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Link error in debug mode without debug_and_release config
ossy@webkit.org [Wed, 12 May 2010 21:04:39 +0000 (21:04 +0000)]
[Qt] Link error in debug mode without debug_and_release config
https://bugs.webkit.org/show_bug.cgi?id=39006

Reviewed by Kenneth Rohde Christiansen.

* WebKit.pri: Unnecessary build_pass guard removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdds support for Rietveld reviews. When there is an associated
jparent@chromium.org [Wed, 12 May 2010 20:57:49 +0000 (20:57 +0000)]
Adds support for Rietveld reviews.  When there is an associated
Rietveld id for a patch, adds a link to do a Rietveld review instead.

Reviewed by David Kilzer.

https://bugs.webkit.org/show_bug.cgi?id=38143

* attachment.cgi:
    Added support for handling action=rietveldreview.
* template/en/custom/attachment/list.html.tmpl:
    Adds a link to use rietveld review iff the in_rietveld flag is set.
* template/en/custom/attachment/reviewform.html.tmpl:
    Detects if we are in rietveld review mode due to query string paramter,
    and customizes the review form slightly:
        - Changes text describing comment field.
        - Comment field does not include quoted patch.
        - Submit button fetches from Rietveld instead of just submitting.
* template/en/custom/attachment/rietveldreview.html.tmpl: Added.
    New template for rietveldreview mode.  Hosts the rietveld frame in the
    top and the regular comments form in the bottom.
    Uses postMessage to communicate with Rietveld frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Detect debug mode consistently
ossy@webkit.org [Wed, 12 May 2010 20:56:51 +0000 (20:56 +0000)]
[Qt] Detect debug mode consistently
https://bugs.webkit.org/show_bug.cgi?id=38863

Patch by Laszlo Gombos <laszlo.1.gombos@nokia.com> on 2010-05-12
Reviewed by Kenneth Rohde Christiansen.

.:

* WebKit.pri:

JavaScriptCore:

* JavaScriptCore.pri:
* JavaScriptCore.pro:
* jsc.pro:
* qt/api/QtScript.pro:

WebCore:

No new tests as there is no new functionality.

* WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 12 May 2010 20:51:06 +0000 (20:51 +0000)]
2010-05-12  James Robinson  <jamesr@chromium.org>

        Patch by Dan Bernstein.

        Reviewed by David Hyatt.

        Fix marking the layout root's parent as needing layout
        https://bugs.webkit.org/show_bug.cgi?id=37760

        If an element gets marked as needing layout due to the recalcStyle()
        call in FrameView::layout(), the m_layoutSchedulingEnabled flag will
        be set to false.  It's possible at this point that a parent of the
        existing FrameView::m_layoutRoot will be marked as needing layout.

        This patch updates FrameView::scheduleRelayoutOfSubtree to account
        for this case.

        Manual test only due to subtle timing issues.

        * manual-tests/layoutroot_detach.xml: Added.
        * page/FrameView.cpp:
        (WebCore::FrameView::scheduleRelayoutOfSubtree):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 12 May 2010 20:50:43 +0000 (20:50 +0000)]
2010-05-12  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        [GTK] svg/custom/svg-fonts-with-no-element-reference.html is one pixel different on x86_64
        https://bugs.webkit.org/show_bug.cgi?id=39022

        Skipping failing tests for GTK+.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Slave losts cause build break on bots
ossy@webkit.org [Wed, 12 May 2010 20:32:27 +0000 (20:32 +0000)]
[Qt] Slave losts cause build break on bots
https://bugs.webkit.org/show_bug.cgi?id=38980

Reviewed by Kenneth Rohde Christiansen.

* Scripts/build-webkit: Remove 0 byte sized files from productDir before build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Eric Seidel <eric@webkit.org>
eric@webkit.org [Wed, 12 May 2010 20:10:05 +0000 (20:10 +0000)]
2010-05-12  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r59245.
        http://trac.webkit.org/changeset/59245
        https://bugs.webkit.org/show_bug.cgi?id=38874

        Broke at least one test on multiple platforms

        * editing/deleting/delete-block-contents-004-expected.txt: Removed.
        * editing/deleting/delete-block-contents-004.html: Removed.
        * editing/deleting/in-visibly-empty-root-expected.txt:
        * platform/mac/editing/deleting/5408255-expected.txt:
        * platform/mac/editing/deleting/delete-select-all-001-expected.txt:
        * platform/mac/editing/selection/4895428-1-expected.txt:
        * platform/mac/editing/selection/4895428-4-expected.txt:
2010-05-12  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r59245.
        http://trac.webkit.org/changeset/59245
        https://bugs.webkit.org/show_bug.cgi?id=38874

        Broke at least one test on multiple platforms

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::removeChild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed trivial fix after r59254.
ossy@webkit.org [Wed, 12 May 2010 20:08:39 +0000 (20:08 +0000)]
Unreviewed trivial fix after r59254.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agorun-webkit-tests --exit-after-N-failures should not count new tests as failures
ossy@webkit.org [Wed, 12 May 2010 20:01:05 +0000 (20:01 +0000)]
run-webkit-tests --exit-after-N-failures should not count new tests as failures
https://bugs.webkit.org/show_bug.cgi?id=31829

Reviewed by Eric Seidel.

* Scripts/old-run-webkit-tests:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Wed, 12 May 2010 19:48:15 +0000 (19:48 +0000)]
2010-05-12  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed. Try number 3 to properly add new baselines and remove remaining
        merge marker from this file.

        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/svg/custom/svg-fonts-with-no-element-reference-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix LayoutTest/ChangeLog bad merge
jamesr@google.com [Wed, 12 May 2010 19:41:38 +0000 (19:41 +0000)]
Fix LayoutTest/ChangeLog bad merge

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-04-29 James Robinson <jamesr@chromium.org>
jamesr@google.com [Wed, 12 May 2010 19:36:01 +0000 (19:36 +0000)]
2010-04-29  James Robinson  <jamesr@chromium.org>

        Reviewed by Simon Fraser.

        Test that when a frame with fixed position elements is scrolled via the
        keyboard that the correct repaints happen.
        https://bugs.webkit.org/show_bug.cgi?id=38286

        * fast/repaint/fixed-move-after-keyboard-scroll.html: Added.
        * fast/repaint/resources/fixed-move-after-keyboard-scroll-iframe.html: Added.
        * platform/chromium/test_expectations.txt:
        * platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.checksum: Added.
        * platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.png: Added.
        * platform/mac/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Wed, 12 May 2010 19:19:33 +0000 (19:19 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=38752
        Strange behaviour after js insertion into a page pointing directly to an object (image, swf, etc)

        Test: fast/images/extra-image-in-image-document.html

        * loader/ImageLoader.cpp: (WebCore::ImageLoader::updateFromElement): Reset setAutoLoadImages
        after manually feeding an image - there may be more coming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-12 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Wed, 12 May 2010 19:12:25 +0000 (19:12 +0000)]
2010-05-12  Martin Robinson  <mrobinson@webkit.org>

        Not reviewed. Trying once more to generate baselines for GTK+.

        * platform/gtk/fast/css/input-search-padding-expected.txt:
        * platform/gtk/fast/forms/placeholder-stripped-expected.txt:
        * platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
        * platform/gtk/fast/images/svg-background-partial-redraw-expected.txt: Added.
        * platform/gtk/fast/repaint/fixed-move-after-keyboard-scroll-expected.txt:
        * platform/gtk/svg/custom/repaint-stroke-width-changes-expected.txt: Copied from LayoutTests/platform/mac/svg/custom/repaint-stroke-width-changes-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59249 268f45cc-cd09-0410-ab3c-d52691b4dbfc