WebKit-https.git
9 years agoplatform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKi...
jberlin@webkit.org [Mon, 19 Mar 2012 18:36:35 +0000 (18:36 +0000)]
platform/mac/accessibility/selected-rows-table.html failing on Lion Intel Debug WebKit2 testers
https://bugs.webkit.org/show_bug.cgi?id=81530

Add expected failing results for mac-wk2 to get the bots green.

* platform/mac-wk2/platform/mac/accessibility/selected-rows-table-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
commit-queue@webkit.org [Mon, 19 Mar 2012 18:36:25 +0000 (18:36 +0000)]
[BlackBerry] Use BlackBerry::Platform::DeviceInfo to generate UserAgent
https://bugs.webkit.org/show_bug.cgi?id=81269

Generate the UserAgent lazily, using it as the default for the
WebSettings object. BlackBerry::Platform::DeviceInfo is used
to ensure the information is accurate to the specific device.

Remove the !isEmpty() assert when fetching the UA from the
WebSettings object, as it will now always be properly initialized.

Add a static initializer block to ensure defaultUserAgent() is
thread-safe from that moment onward.

Patch by Mike Lattanzio <mlattanzio@rim.com> on 2012-03-19
Reviewed by Rob Buis.

* Api/WebPage.cpp:
(WebKit):
(BlackBerry::WebKit::WebPagePrivate::init):
(BlackBerry::WebKit::WebPagePrivate::defaultUserAgent):
* Api/WebPage_p.h:
(WebPagePrivate):
* Api/WebSettings.cpp:
(BlackBerry::WebKit::WebSettings::setUserAgentString):
* Api/WebSettings.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMediaStream API (JSEP): Introducing PeerConnection00Handler
tommyw@google.com [Mon, 19 Mar 2012 18:33:20 +0000 (18:33 +0000)]
MediaStream API (JSEP): Introducing PeerConnection00Handler
https://bugs.webkit.org/show_bug.cgi?id=81333

Reviewed by Adam Barth.

In preparation of the last WebCore patch that will introduce PeerConnection00 here's its platform representation.

Not possible to test until the entire JSEP feature is commited.

* GNUmakefile.list.am:
* WebCore.gypi:
* platform/mediastream/PeerConnection00Handler.cpp: Added.
(WebCore):
(WebCore::PeerConnection00Handler::create):
(WebCore::PeerConnection00Handler::PeerConnection00Handler):
(WebCore::PeerConnection00Handler::~PeerConnection00Handler):
(WebCore::PeerConnection00Handler::createOffer):
(WebCore::PeerConnection00Handler::createAnswer):
(WebCore::PeerConnection00Handler::setLocalDescription):
(WebCore::PeerConnection00Handler::setRemoteDescription):
(WebCore::PeerConnection00Handler::localDescription):
(WebCore::PeerConnection00Handler::remoteDescription):
(WebCore::PeerConnection00Handler::startIce):
(WebCore::PeerConnection00Handler::processIceMessage):
(WebCore::PeerConnection00Handler::addStream):
(WebCore::PeerConnection00Handler::removeStream):
(WebCore::PeerConnection00Handler::stop):
* platform/mediastream/PeerConnection00Handler.h: Added.
(WebCore):
(PeerConnection00Handler):
* platform/mediastream/PeerConnection00HandlerClient.h: Added.
(WebCore):
(PeerConnection00HandlerClient):
(WebCore::PeerConnection00HandlerClient::~PeerConnection00HandlerClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
commit-queue@webkit.org [Mon, 19 Mar 2012 18:27:42 +0000 (18:27 +0000)]
[Chromium] GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query support.
https://bugs.webkit.org/show_bug.cgi?id=80988

Patch by David Reveman <reveman@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

Source/Platform:

Add EXT_occlusion_query API to WebGraphicsContext3D.

* chromium/public/WebGraphicsContext3D.h:
(WebGraphicsContext3D):

Source/WebCore:

Expose EXT_occlusion_query API to WebKit compositor. Add
GL_EXT_occlusion_query_boolean and GL_CHROMIUM_command_buffer_query
enums.

* platform/graphics/chromium/Extensions3DChromium.h:
(Extensions3DChromium):

Source/WebKit/chromium:

Expose EXT_occlusion_query API to WebKit compositor.

* src/Extensions3DChromium.cpp:
(WebCore::Extensions3DChromium::createQueryEXT):
(WebCore):
(WebCore::Extensions3DChromium::deleteQueryEXT):
(WebCore::Extensions3DChromium::isQueryEXT):
(WebCore::Extensions3DChromium::beginQueryEXT):
(WebCore::Extensions3DChromium::endQueryEXT):
(WebCore::Extensions3DChromium::getQueryivEXT):
(WebCore::Extensions3DChromium::getQueryObjectuivEXT):
* src/GraphicsContext3DChromium.cpp:
(WebCore):
* src/GraphicsContext3DPrivate.h:
(GraphicsContext3DPrivate):
* tests/FakeWebGraphicsContext3D.h:
(WebKit::FakeWebGraphicsContext3D::createQueryEXT):
(WebKit::FakeWebGraphicsContext3D::deleteQueryEXT):
(WebKit::FakeWebGraphicsContext3D::isQueryEXT):
(WebKit::FakeWebGraphicsContext3D::beginQueryEXT):
(WebKit::FakeWebGraphicsContext3D::endQueryEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryivEXT):
(WebKit::FakeWebGraphicsContext3D::getQueryObjectuivEXT):
(FakeWebGraphicsContext3D):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Input fields with id of e-mail and url should be styled as such.
mifenton@rim.com [Mon, 19 Mar 2012 18:16:48 +0000 (18:16 +0000)]
[BlackBerry] Input fields with id of e-mail and url should be styled as such.
https://bugs.webkit.org/show_bug.cgi?id=81364

Reviewed by Rob Buis.

Be less aggressive on matching url, and update as suggested by Rob.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::matchesReservedStringUrl):
* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::inputStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS3 calc: make mask images work with mixed percent/absolute
mikelawther@chromium.org [Mon, 19 Mar 2012 18:02:37 +0000 (18:02 +0000)]
CSS3 calc: make mask images work with mixed percent/absolute
https://bugs.webkit.org/show_bug.cgi?id=81477

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/simple-composited-mask-expected.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

* css3/calc/simple-composited-mask-expected.html: Renamed from LayoutTests/css3/calc/simple-composited-mask-expected-mismatch.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoOptimize the cleanup sequence in the start-queue.sh script
abarth@webkit.org [Mon, 19 Mar 2012 17:52:18 +0000 (17:52 +0000)]
Optimize the cleanup sequence in the start-queue.sh script
https://github.com/abarth/webkit/pull/1

Patch by David Michael Barr <davidbarr@google.com> on 2012-03-19
Reviewed by Adam Barth.

Updating the working copy is an expensive operation
for a repository the size of WebKit.
Attempt to reset only to the target revision.

* EWSTools/start-queue.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStyle cleanup in Modules/filesystem/
commit-queue@webkit.org [Mon, 19 Mar 2012 17:46:06 +0000 (17:46 +0000)]
Style cleanup in Modules/filesystem/
https://bugs.webkit.org/show_bug.cgi?id=81520

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-19
Reviewed by Adam Barth.

No new tests, all existing tests pass.

* Modules/filesystem/AsyncFileWriter.h:
(WebCore::AsyncFileWriter::~AsyncFileWriter):
* Modules/filesystem/AsyncFileWriterClient.h:
(WebCore::AsyncFileWriterClient::~AsyncFileWriterClient):
* Modules/filesystem/DOMFilePath.cpp:
(WebCore::DOMFilePath::getDirectory):
* Modules/filesystem/DOMFilePath.h:
(DOMFilePath):
* Modules/filesystem/DOMFileSystemBase.h:
(DOMFileSystemBase):
* Modules/filesystem/DirectoryEntry.h:
* Modules/filesystem/DirectoryEntrySync.h:
* Modules/filesystem/EntryArray.h:
(EntryArray):
* Modules/filesystem/FileEntry.h:
(FileEntry):
* Modules/filesystem/FileSystemCallbacks.h:
(FileSystemCallbacksBase):
* Modules/filesystem/FileWriter.cpp:
(WebCore::FileWriter::abort):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCrash when closing an inspected web page with tiled drawing enabled
andersca@apple.com [Mon, 19 Mar 2012 17:37:18 +0000 (17:37 +0000)]
Crash when closing an inspected web page with tiled drawing enabled
https://bugs.webkit.org/show_bug.cgi?id=81524
<rdar://problem/11062396>

Reviewed by Sam Weinig.

Guard against the WebPage's underlying WebCore Page being null, which can happen
when the inspector highlight overlay is uninstalled by the inspector when the inspected
page goes away.

* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::didUninstallPageOverlay):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago FAILED: m_loadState == LoadStateProvisional on http/tests/multipart/load...
ap@apple.com [Mon, 19 Mar 2012 17:37:01 +0000 (17:37 +0000)]
    FAILED: m_loadState == LoadStateProvisional on http/tests/multipart/load-last-non-html-frame.php
        https://bugs.webkit.org/show_bug.cgi?id=81365

        * platform/wk2/Skipped: Skipped the test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS3 calc: background positioning works with mixed percent/absolute expressions
mikelawther@chromium.org [Mon, 19 Mar 2012 17:34:18 +0000 (17:34 +0000)]
CSS3 calc: background positioning works with mixed percent/absolute expressions
https://bugs.webkit.org/show_bug.cgi?id=81478

Reviewed by Ojan Vafai.

Source/WebCore:

Test: css3/calc/background-position-parsing-expected.html

* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::collectMatchingRulesForList):

LayoutTests:

* css3/calc/background-position-parsing-expected.html: Renamed from LayoutTests/css3/calc/background-position-parsing-expected-mismatch.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMerge _q_commitScaleChange and _q_commitPositionChange
kenneth@webkit.org [Mon, 19 Mar 2012 17:10:17 +0000 (17:10 +0000)]
Merge _q_commitScaleChange and _q_commitPositionChange
https://bugs.webkit.org/show_bug.cgi?id=81511

Reviewed by Simon Hausmann.

Both methods were used for notifying WebCore of the new
viewport and re-tiling. The methods are merge into
_q_contentViewportChanged.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewFlickablePrivate::onComponentComplete):
(QQuickWebViewFlickablePrivate::updateViewportSize):
(QQuickWebViewFlickablePrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate::_q_resume):
* UIProcess/API/qt/qquickwebview_p.h:
* UIProcess/API/qt/qquickwebview_p_p.h:
(QQuickWebViewPrivate::_q_contentViewportChanged):
(QQuickWebViewFlickablePrivate):
* UIProcess/qt/QtViewportInteractionEngine.cpp:
(WebKit::ViewportUpdateDeferrer::~ViewportUpdateDeferrer):
(WebKit::QtViewportInteractionEngine::flickableMovingPositionUpdate):
(WebKit::QtViewportInteractionEngine::wheelEvent):
(WebKit::QtViewportInteractionEngine::pinchGestureStarted):
* UIProcess/qt/QtViewportInteractionEngine.h:
(QtViewportInteractionEngine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd NodeRenderStyle.h to TouchAdjustment.cpp
ahf@0x90.dk [Mon, 19 Mar 2012 17:09:53 +0000 (17:09 +0000)]
Add NodeRenderStyle.h to TouchAdjustment.cpp

Unreviewed build fix after r111185.

* page/TouchAdjustment.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAnother Windows build fix after r111129.
jberlin@webkit.org [Mon, 19 Mar 2012 16:57:29 +0000 (16:57 +0000)]
Another Windows build fix after r111129.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unit test fix, save the sharedQuadState while the quads hold a pointer...
commit-queue@webkit.org [Mon, 19 Mar 2012 16:53:25 +0000 (16:53 +0000)]
[chromium] Unit test fix, save the sharedQuadState while the quads hold a pointer to it
https://bugs.webkit.org/show_bug.cgi?id=81476

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-19
Reviewed by Adrienne Walker.

* tests/CCQuadCullerTest.cpp:
(WebCore::appendQuads):
(WebCore):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCross-platform processor core counter: fix build on FreeBSD.
kubo@profusion.mobi [Mon, 19 Mar 2012 16:48:35 +0000 (16:48 +0000)]
Cross-platform processor core counter: fix build on FreeBSD.
https://bugs.webkit.org/show_bug.cgi?id=81482

Reviewed by Zoltan Herczeg.

The documentation of sysctl(3) shows that <sys/types.h> should be
included before <sys/sysctl.h> (sys/types.h tends to be the first
included header in general).

This should fix the build on FreeBSD and other systems where
sysctl.h really depends on types defined in types.h.

* wtf/NumberOfCores.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add PlatformMediaEngineClassName for blackberry in platform/graphics...
leo.yang@torchmobile.com.cn [Mon, 19 Mar 2012 16:46:02 +0000 (16:46 +0000)]
[BlackBerry] Add PlatformMediaEngineClassName for blackberry in platform/graphics/MediaPlayer.cpp
https://bugs.webkit.org/show_bug.cgi?id=81489

Reviewed by Rob Buis.

* platform/graphics/MediaPlayer.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdjust architecture type of the EFL build bot.
kubo@profusion.mobi [Mon, 19 Mar 2012 16:43:26 +0000 (16:43 +0000)]
Adjust architecture type of the EFL build bot.
https://bugs.webkit.org/show_bug.cgi?id=81452

Patch by Raphael Kubo da Costa <kubo@profusion.mobi> on 2012-03-19
Reviewed by Tony Chang.

* BuildSlaveSupport/build.webkit.org-config/config.json: The
buildslave is a 64-bit machine, therefore describe it as being
x86_64, not i386.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSet the svn:ignore property on the Xcode project.
mitz@apple.com [Mon, 19 Mar 2012 16:37:36 +0000 (16:37 +0000)]
Set the svn:ignore property on the Xcode project.

* WTF.xcodeproj: Added property svn:ignore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h
leo.yang@torchmobile.com.cn [Mon, 19 Mar 2012 16:23:16 +0000 (16:23 +0000)]
[BlackBerry] Upstream the BlackBerry change to platform/PlatformKeyboardEvent.h
https://bugs.webkit.org/show_bug.cgi?id=81312

Reviewed by Rob Buis.

* platform/PlatformKeyboardEvent.h:
(Platform):
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
(PlatformKeyboardEvent):
(WebCore::PlatformKeyboardEvent::unmodifiedCharacter):
Add BlackBerry specific constructor and member fields.
* platform/blackberry/PlatformKeyboardEventBlackBerry.cpp:
(WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent):
Change the parameter type to const reference type to adapt to the declaration.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] printLoadedUrls prints "Object" instead of the actual URL. https://bugs.webkit...
ahf@0x90.dk [Mon, 19 Mar 2012 16:22:37 +0000 (16:22 +0000)]
[Qt] printLoadedUrls prints "Object" instead of the actual URL. https://bugs.webkit.org/show_bug.cgi?id=81514

Reviewed by Simon Hausmann.

* MiniBrowser/qt/qml/BrowserWindow.qml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaselining fixed-position-scroll now that more bots have come in.
leviw@chromium.org [Mon, 19 Mar 2012 16:21:22 +0000 (16:21 +0000)]
[chromium] Rebaselining fixed-position-scroll now that more bots have come in.

* platform/chromium-mac-snowleopard/compositing/layer-creation: Removed.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Removed.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
* platform/chromium-mac/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
* platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.txt: Removed.
* platform/chromium/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWindows build fix after r111129.
jberlin@webkit.org [Mon, 19 Mar 2012 16:18:56 +0000 (16:18 +0000)]
Windows build fix after r111129.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
kubo@profusion.mobi [Mon, 19 Mar 2012 16:07:19 +0000 (16:07 +0000)]
[EFL] jhbuild: Set CMAKE_PREFIX_PATH in jhbuildrc.
https://bugs.webkit.org/show_bug.cgi?id=81491

Reviewed by Philippe Normand.

For the find_path(), find_library() etc CMake calls to find the
dependencies built with jhbuild, CMAKE_PREFIX_PATH must be properly
set, otherwise CMake cannot know the dependencies exist and will only
look in the standard directories.

* efl/jhbuildrc: Set the CMAKE_PREFIX_PATH environment variable with
the jhbuild Root directory.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add XDG env vars to jhbuildrc
kubo@profusion.mobi [Mon, 19 Mar 2012 16:05:17 +0000 (16:05 +0000)]
[EFL] Add XDG env vars to jhbuildrc
https://bugs.webkit.org/show_bug.cgi?id=81510

Needed to ensure correct glib behaviour in jhbuild environment.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Philippe Normand.

* efl/jhbuildrc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSelect best target for tap gesture.
commit-queue@webkit.org [Mon, 19 Mar 2012 15:33:26 +0000 (15:33 +0000)]
Select best target for tap gesture.
https://bugs.webkit.org/show_bug.cgi?id=78801

Source/WebCore:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.
IntRect changes reviewed by Dave Hyatt.

The new API is available through EventHandler::bestClickableNodeForTouchPoint, but
implementation details have been placed in page/TouchAdjustment.

The default hit detection is performed by measuring the distance to the center
lines of the absolute rects of the hit nodes. Absolute rects are used instead
of bounding rects to make hit-detecting against links over line breaks. Distance
to center line is used to make it easier to hit small links next to large links.
For line-rects the distance to the center-line is a better expression of the distance
to a rectangles center than the distance to the center-point.

Tests: touchadjustment/event-triggered-widgets.html
       touchadjustment/html-label.html
       touchadjustment/nested-touch.html
       touchadjustment/touch-inlines.html

* Target.pri:
* page/EventHandler.cpp:
(WebCore::EventHandler::handleGestureTap):
(WebCore::EventHandler::bestClickableNodeForTouchPoint):
* page/EventHandler.h:
* page/TouchAdjustment.cpp: Added.
(WebCore::TouchAdjustment::QuadForHitTest::QuadForHitTest):
(WebCore::TouchAdjustment::QuadForHitTest::node):
(WebCore::TouchAdjustment::QuadForHitTest::quad):
(WebCore::TouchAdjustment::QuadForHitTest::boundingBox):
(WebCore::TouchAdjustment::nodeRespondsToTapGesture):
(WebCore::TouchAdjustment::appendAbsoluteQuadsForNodeToHitTestList):
(WebCore::TouchAdjustment::compileQuadsForHitTesting):
(WebCore::TouchAdjustment::distanceSquaredToQuadCenterLine):
(WebCore::TouchAdjustment::findNodeWithLowestMetric):
(WebCore::findBestClickableCandidate):
* page/TouchAdjustment.h: Added.
* platform/graphics/FloatQuad.h:
(WebCore::FloatQuad::center):
* platform/graphics/IntPoint.h:
(WebCore::IntPoint::distanceSquaredToPoint):
* platform/graphics/IntRect.cpp:
(WebCore::distanceToInterval):
(WebCore::IntRect::differenceToPoint):
(WebCore::IntRect::differenceFromCenterLineToPoint):
* platform/graphics/IntRect.h:
(WebCore::IntRect::distanceSquaredToPoint):
(WebCore::IntRect::distanceSquaredFromCenterLineToPoint):
* platform/graphics/IntSize.h:
(WebCore::IntSize::diagonalLengthSquared):
* testing/Internals.cpp:
(WebCore::Internals::touchPositionAdjustedToBestClickableNode):
(WebCore::Internals::touchNodeAdjustedToBestClickableNode):
* testing/Internals.h:
* testing/Internals.idl:

Source/WebKit2:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Send radius to handlePotentialSingleTapEvent so it can do the same hit
detection the tap gesture later does.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::handlePotentialActivation):
* UIProcess/WebPageProxy.h:
* UIProcess/qt/QtWebPageEventHandler.cpp:
(QtWebPageEventHandler::handlePotentialSingleTapEvent):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::highlightPotentialActivation):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:

Tools:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Add TOUCH_ADJUSTMENT to enabled features.

* qmake/mkspecs/features/features.prf:

LayoutTests:

Patch by Allan Sandfeld Jensen <allan.jensen@nokia.com> on 2012-03-19
Reviewed by Kenneth Rohde Christiansen.

Test of touch adjustments. Tests several both normal and tricky cases.

* platform/chromium/test_expectations.txt:
* platform/efl/Skipped:
* platform/gtk/Skipped:
* platform/mac/Skipped:
* platform/win/Skipped:
* touchadjustment/event-triggered-widgets-expected.txt: Added.
* touchadjustment/event-triggered-widgets.html: Added.
* touchadjustment/html-label-expected.txt: Added.
* touchadjustment/html-label.html: Added.
* touchadjustment/nested-touch-expected.txt: Added.
* touchadjustment/nested-touch.html: Added.
* touchadjustment/touch-inlines-expected.txt: Added.
* touchadjustment/touch-inlines.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd ENABLED(FILE_SYSTEM) to DOMFilePath.h
commit-queue@webkit.org [Mon, 19 Mar 2012 15:11:16 +0000 (15:11 +0000)]
Add ENABLED(FILE_SYSTEM) to DOMFilePath.h
https://bugs.webkit.org/show_bug.cgi?id=81393

Patch by Mark Pilgrim <pilgrim@chromium.org> on 2012-03-19
Reviewed by Kentaro Hara.

No new tests, all existing tests pass.

* Modules/filesystem/DOMFilePath.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed. Rolled DEPS.
commit-queue@webkit.org [Mon, 19 Mar 2012 14:54:33 +0000 (14:54 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-03-19

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] synthesize wheel events for fling on main thread
commit-queue@webkit.org [Mon, 19 Mar 2012 14:51:06 +0000 (14:51 +0000)]
[chromium] synthesize wheel events for fling on main thread
https://bugs.webkit.org/show_bug.cgi?id=81458

Source/WebKit/chromium:

Support track pad fling by generating a sequence of wheel events.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::WebViewImpl):
(WebKit::WebViewImpl::scrollBy): Call-back from PlatformGestureCurve to dispatch wheel event.
(WebKit):
(WebKit::WebViewImpl::gestureEvent): Handle GestureFlingStart and GestureFlingCancel.
(WebKit::WebViewImpl::updateAnimations): Requests a PlatformGestureCurve to animate forward.
(WebKit::WebViewImpl::didCommitLoad): Halt flings on navigations.
* src/WebViewImpl.h:
(WebCore):
(WebViewImpl):

Tools:

Added the ability to dispatch GestureFlingStart and GestureFlingCancel from EventSender.

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

* DumpRenderTree/chromium/EventSender.cpp:
(EventSender::EventSender):
(EventSender::gestureFlingCancel):
(EventSender::gestureFlingStart):
* DumpRenderTree/chromium/EventSender.h:
(EventSender):

LayoutTests:

Show that the GestureFlingStart and GestureFlingEnd events are handled and
connect up with WebViewImpl

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-19
Reviewed by James Robinson.

* fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
* fast/events/touch/gesture/pad-gesture-cancel.html: Added.
* fast/events/touch/gesture/pad-gesture-cancel.js: Added.
(recordWheelEvent):
(if):
* fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.
* fast/events/touch/gesture/pad-gesture-fling.html: Added.
* fast/events/touch/gesture/pad-gesture-fling.js: Added.
(recordWheelEvent):
(if):
* platform/chromium/fast/events/touch/gesture/pad-gesture-cancel-expected.txt: Added.
* platform/chromium/fast/events/touch/gesture/pad-gesture-fling-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Add new platform specific expectation after r110667.
kkristof@inf.u-szeged.hu [Mon, 19 Mar 2012 14:47:07 +0000 (14:47 +0000)]
[Qt] Unreviewed. Add new platform specific expectation after r110667.

* platform/qt-4.8/fast/dom/Window/window-properties-expected.png: Added.
* platform/qt-4.8/fast/dom/Window/window-properties-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate
commit-queue@webkit.org [Mon, 19 Mar 2012 14:45:28 +0000 (14:45 +0000)]
[BlackBerry] Remove obsolete optimization in WebPageCompositorPrivate
https://bugs.webkit.org/show_bug.cgi?id=81115

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-03-19
Reviewed by Benjamin Poulain.

The compositor tried to avoid rendering the same stuff twice, using a
mechanism that didn't work properly and has been redundant since we
introduced deferred blits. Remove this code.

Reviewed internally by Robin Cao.

* Api/WebPageCompositor.cpp:
(BlackBerry::WebKit::WebPageCompositorPrivate::WebPageCompositorPrivate):
(BlackBerry::WebKit::WebPageCompositorPrivate::commit):
(BlackBerry::WebKit::WebPageCompositorPrivate::drawLayers):
* Api/WebPageCompositor_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add command line option to set the user agent in the MiniBrowser https://bugs...
ahf@0x90.dk [Mon, 19 Mar 2012 14:42:42 +0000 (14:42 +0000)]
[Qt] Add command line option to set the user agent in the MiniBrowser https://bugs.webkit.org/show_bug.cgi?id=81508

Reviewed by Simon Hausmann.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::webViewExperimental):
* MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
* MiniBrowser/qt/MiniBrowserApplication.cpp:
(printHelp):
(MiniBrowserApplication::handleUserOptions):
* MiniBrowser/qt/MiniBrowserApplication.h:
(WindowOptions::WindowOptions):
(WindowOptions::setUserAgent):
(WindowOptions::userAgent):
(WindowOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add experimental API for dynamically changing the UA string
ahf@0x90.dk [Mon, 19 Mar 2012 14:42:17 +0000 (14:42 +0000)]
[Qt] Add experimental API for dynamically changing the UA string

Reviewed by Simon Hausmann.

This patch adds a new property named userAgent to the
QQuickWebViewExperimental type which allows us to dynamically change
the user agent string from the QML API.

* UIProcess/API/qt/qquickwebview.cpp:
(QQuickWebViewExperimental::userAgent):
(QQuickWebViewExperimental::setUserAgent):
* UIProcess/API/qt/qquickwebview_p.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Remove dead user agent code from the MiniBrowser.
ahf@0x90.dk [Mon, 19 Mar 2012 14:41:52 +0000 (14:41 +0000)]
[Qt] Remove dead user agent code from the MiniBrowser.

Reviewed by Simon Hausmann.

* MiniBrowser/qt/BrowserWindow.cpp:
* MiniBrowser/qt/BrowserWindow.h:
(BrowserWindow):
* MiniBrowser/qt/MiniBrowser.qrc:
* MiniBrowser/qt/useragentlist.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoinspector highlight of SVG root element with viewbox does not match dimensions of...
commit-queue@webkit.org [Mon, 19 Mar 2012 14:38:20 +0000 (14:38 +0000)]
inspector highlight of SVG root element with viewbox does not match dimensions of element
https://bugs.webkit.org/show_bug.cgi?id=78037

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-03-19
Reviewed by Nikolas Zimmermann.

Source/WebCore:

Functions such as RenderBox::absoluteQuads and DOMNodeHighlighter::getOrDrawNodeHighlight
eventually call RenderSVGRoot::mapLocalToContainer, passing along local CSS box coordinates.

However, before this patch, RenderSVGRoot::mapLocalToContainer expected local SVG viewport
coordinates. This caused the inspector highlight to be incorrectly sized and positioned.

Now, RenderSVGRoot::mapLocalToContainer expects local CSS box coordinates, like other HTML
renderers.

Test: inspector/elements/highlight-svg-root.html

* dom/Element.cpp:
(WebCore::Element::getBoundingClientRect):
    Now, the SVG root element can use the code path for elements with CSS boxes to calculate
    its bounding client rect.

* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::mapLocalToContainer):
    RenderSVGRoot::mapLocalToContainer no longer needs to apply the
    localToBorderBoxTransform to convert from local SVG viewport coordinates to local CSS
    box coordinates. Now, it receives local CSS box coordinates.

* rendering/svg/RenderSVGRoot.h:
(WebCore::RenderSVGRoot::localToBorderBoxTransform):
    RenderSVGRoot::localToBorderBoxTransform has been exposed for child elements in the SVG
    namespace to use when mapping from local SVG viewport coordinates to local CSS box
    coordinates.

(RenderSVGRoot):
* rendering/svg/SVGRenderSupport.cpp:
(WebCore::SVGRenderSupport::mapLocalToContainer):
    Elements in the SVG namespace should now apply the localToBorderBoxTransform at the
    SVG/HTML boundary (aka RenderSVGRoot) when mapping their coordinates up the render tree.

* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::localCoordinateSpaceTransform):
    Same as above. This method is eventually used in the SVGLocatable::getScreenCTM
    calculation.

LayoutTests:

* inspector/elements/highlight-svg-root-expected.txt: Added.
* inspector/elements/highlight-svg-root.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agojhbuild: Call jhbuild's autogen.sh via bash.
kubo@profusion.mobi [Mon, 19 Mar 2012 14:35:02 +0000 (14:35 +0000)]
jhbuild: Call jhbuild's autogen.sh via bash.
https://bugs.webkit.org/show_bug.cgi?id=81485

Reviewed by Philippe Normand.

jhbuild's autogen.sh uses "/bin/bash" in the shebang line, however
this is usually true only on Linux systems, and even then bash for
some reason might not be available in that location. It is safer to
call bash directly and pass autogen.sh to it instead.

* jhbuild/jhbuild-wrapper:
(install_jhbuild):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GTK] Prefix run-launcher with run-with-jhbuild
commit-queue@webkit.org [Mon, 19 Mar 2012 14:30:30 +0000 (14:30 +0000)]
[GTK] Prefix run-launcher with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=81503

Patch by Philippe Normand <pnormand@igalia.com> on 2012-03-19
Reviewed by Hajime Morita.

* Scripts/run-launcher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Adding slow to full-screen-restrictions.html on WIN.
keishi@webkit.org [Mon, 19 Mar 2012 10:47:47 +0000 (10:47 +0000)]
[chromium] Adding slow to full-screen-restrictions.html on WIN.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Prefix run-launcher with run-with-jhbuild
commit-queue@webkit.org [Mon, 19 Mar 2012 10:47:31 +0000 (10:47 +0000)]
[EFL] Prefix run-launcher with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80026

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-19
Reviewed by Hajime Morita.

* Scripts/run-launcher:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a copy constructor to CollapsedBorderValue
hbono@chromium.org [Mon, 19 Mar 2012 10:34:29 +0000 (10:34 +0000)]
Add a copy constructor to CollapsedBorderValue
https://bugs.webkit.org/show_bug.cgi?id=81502

Reviewed by Hajime Morita.

Due to the lack of this copy constructor, GCC (x86) creates a broken copy
constructor and it causes a build break on Google Chrome.

* rendering/style/CollapsedBorderValue.h:
(WebCore::CollapsedBorderValue::CollapsedBorderValue):
(CollapsedBorderValue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Gardening.
ossy@webkit.org [Mon, 19 Mar 2012 09:56:48 +0000 (09:56 +0000)]
[Qt] Gardening.

Patch by Balazs Ankes <bank@inf.u-szeged.hu> on 2012-03-19
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped: Skip a new failing test, remove a non-existent test, order entries.
* platform/qt/fast/events/resize-events-expected.png: Added.
* platform/qt/fast/events/resize-events-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline due to r111139
keishi@webkit.org [Mon, 19 Mar 2012 09:48:25 +0000 (09:48 +0000)]
[chromium] Rebaseline due to r111139

* platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.png: Added.
* platform/chromium-linux-x86/fast/table/max-width-integer-overflow-expected.txt: Added.
* platform/chromium-linux/fast/table/max-width-integer-overflow-expected.png: Added.
* platform/chromium-linux/fast/table/max-width-integer-overflow-expected.txt: Added.
* platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline due to r111156
keishi@webkit.org [Mon, 19 Mar 2012 09:10:25 +0000 (09:10 +0000)]
[chromium] Rebaseline due to r111156

* platform/chromium-win/fast/borders/border-radius-huge-assert-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Adding missing cr-snowleopard layer creation expectations.
leviw@chromium.org [Mon, 19 Mar 2012 08:59:52 +0000 (08:59 +0000)]
Unreviewed gardening. Adding missing cr-snowleopard layer creation expectations.

* platform/chromium-mac-snowleopard/compositing/layer-creation: Added.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r110759 and r108185.
philn@webkit.org [Mon, 19 Mar 2012 08:49:10 +0000 (08:49 +0000)]
Unreviewed, GTK rebaseline after r110759 and r108185.

* platform/gtk/editing/inserting/before-after-input-element-expected.txt:
* platform/gtk/editing/pasteboard/4806874-expected.txt:
* platform/gtk/editing/pasteboard/drop-text-without-selection-expected.txt:
* platform/gtk/editing/pasteboard/input-field-1-expected.txt:
* platform/gtk/editing/selection/3690703-2-expected.txt:
* platform/gtk/editing/selection/3690703-expected.txt:
* platform/gtk/editing/selection/3690719-expected.txt:
* platform/gtk/editing/selection/4895428-3-expected.txt:
* platform/gtk/editing/selection/4975120-expected.txt:
* platform/gtk/editing/selection/drag-select-1-expected.txt:
* platform/gtk/editing/selection/expanding-selections-expected.txt:
* platform/gtk/editing/selection/leave-requested-block-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-1-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-2-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-3-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-4-expected.txt:
* platform/gtk/editing/selection/select-across-readonly-input-5-expected.txt:
* platform/gtk/fast/block/float/032-expected.txt:
* platform/gtk/fast/block/float/033-expected.txt: Added.
* platform/gtk/fast/block/float/avoidance-rtl-expected.txt: Added.
* platform/gtk/fast/block/float/float-not-removed-from-next-sibling3-expected.txt:
* platform/gtk/fast/block/float/float-overflow-hidden-containing-block-width-expected.txt:
* platform/gtk/fast/block/float/in-margin-expected.txt:
* platform/gtk/fast/block/float/overlapping-floats-with-overflow-hidden-expected.txt:
* platform/gtk/fast/block/float/shrink-to-avoid-float-complexity-expected.txt:
* platform/gtk/fast/block/lineboxcontain/block-font-expected.txt:
* platform/gtk/fast/block/lineboxcontain/block-glyphs-expected.txt:
* platform/gtk/fast/block/lineboxcontain/font-expected.txt:
* platform/gtk/fast/block/lineboxcontain/parsing-invalid-expected.txt:
* platform/gtk/fast/block/margin-collapse/103-expected.txt:
* platform/gtk/fast/box-shadow/shadow-buffer-partial-expected.txt:
* platform/gtk/fast/clip/017-expected.txt:
* platform/gtk/fast/css/input-search-padding-expected.txt:
* platform/gtk/fast/css/invalidation-errors-2-expected.txt:
* platform/gtk/fast/css/invalidation-errors-expected.txt:
* platform/gtk/fast/css/line-height-expected.txt:
* platform/gtk/fast/css/nested-layers-with-hover-expected.txt:
* platform/gtk/fast/css/text-input-with-webkit-border-radius-expected.txt:
* platform/gtk/fast/css/text-overflow-input-expected.txt:
* platform/gtk/fast/dom/isindex-001-expected.txt:
* platform/gtk/fast/dom/isindex-002-expected.txt:
* platform/gtk/fast/dynamic/subtree-boundary-percent-height-expected.txt:
* platform/gtk/fast/dynamic/subtree-no-common-root-static-y-expected.txt:
* platform/gtk/fast/dynamic/subtree-table-cell-height-expected.txt:
* platform/gtk/fast/encoding/utf-16-big-endian-expected.txt:
* platform/gtk/fast/encoding/utf-16-little-endian-expected.txt:
* platform/gtk/fast/events/autoscroll-expected.txt:
* platform/gtk/fast/events/context-no-deselect-expected.txt:
* platform/gtk/fast/events/mouse-relative-position-expected.txt: Added.
* platform/gtk/fast/forms/basic-inputs-expected.txt:
* platform/gtk/fast/forms/box-shadow-override-expected.txt:
* platform/gtk/fast/forms/encoding-test-expected.txt:
* platform/gtk/fast/forms/fieldset-align-expected.txt:
* platform/gtk/fast/forms/floating-textfield-relayout-expected.txt:
* platform/gtk/fast/forms/form-element-geometry-expected.txt:
* platform/gtk/fast/forms/input-align-expected.txt:
* platform/gtk/fast/forms/input-appearance-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-default-bkcolor-expected.txt:
* platform/gtk/fast/forms/input-appearance-disabled-expected.txt:
* platform/gtk/fast/forms/input-appearance-focus-expected.txt:
* platform/gtk/fast/forms/input-appearance-height-expected.txt:
* platform/gtk/fast/forms/input-appearance-preventDefault-expected.txt:
* platform/gtk/fast/forms/input-appearance-readonly-expected.txt:
* platform/gtk/fast/forms/input-appearance-selection-expected.txt:
* platform/gtk/fast/forms/input-appearance-visibility-expected.txt:
* platform/gtk/fast/forms/input-appearance-width-expected.txt:
* platform/gtk/fast/forms/input-baseline-expected.txt:
* platform/gtk/fast/forms/input-double-click-selection-gap-bug-expected.txt:
* platform/gtk/fast/forms/input-field-text-truncated-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-1-expected.txt:
* platform/gtk/fast/forms/input-placeholder-visibility-3-expected.txt:
* platform/gtk/fast/forms/input-readonly-empty-expected.txt:
* platform/gtk/fast/forms/input-spaces-expected.txt:
* platform/gtk/fast/forms/input-table-expected.txt:
* platform/gtk/fast/forms/input-text-click-inside-expected.txt:
* platform/gtk/fast/forms/input-text-click-outside-expected.txt:
* platform/gtk/fast/forms/input-text-option-delete-expected.txt:
* platform/gtk/fast/forms/input-text-self-emptying-click-expected.txt:
* platform/gtk/fast/forms/input-value-expected.txt:
* platform/gtk/fast/forms/input-width-expected.txt:
* platform/gtk/fast/forms/number/input-appearance-number-rtl-expected.txt:
* platform/gtk/fast/forms/number/input-appearance-spinbutton-disabled-readonly-expected.txt:
* platform/gtk/fast/forms/number/input-appearance-spinbutton-layer-expected.txt:
* platform/gtk/fast/forms/placeholder-position-expected.txt:
* platform/gtk/fast/forms/placeholder-pseudo-style-expected.txt:
* platform/gtk/fast/forms/search-cancel-button-style-sharing-expected.txt:
* platform/gtk/fast/forms/search-display-none-cancel-button-expected.txt:
* platform/gtk/fast/forms/search-rtl-expected.txt:
* platform/gtk/fast/forms/search-styled-expected.txt:
* platform/gtk/fast/forms/search-vertical-alignment-expected.txt:
* platform/gtk/fast/forms/searchfield-heights-expected.txt:
* platform/gtk/fast/forms/tabbing-input-iframe-expected.txt:
* platform/gtk/fast/forms/text-style-color-expected.txt:
* platform/gtk/fast/forms/textfield-focus-ring-expected.txt:
* platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:
* platform/gtk/fast/frames/take-focus-from-iframe-expected.txt:
* platform/gtk/fast/html/details-no-summary4-expected.txt:
* platform/gtk/fast/html/details-open-javascript-expected.txt:
* platform/gtk/fast/html/details-open2-expected.txt:
* platform/gtk/fast/html/details-open4-expected.txt:
* platform/gtk/fast/inline/continuation-outlines-with-layers-2-expected.txt:
* platform/gtk/fast/inline/continuation-outlines-with-layers-expected.txt:
* platform/gtk/fast/invalid/residual-style-expected.txt:
* platform/gtk/fast/layers/add-layer-with-nested-stacking-expected.txt: Added.
* platform/gtk/fast/layers/remove-layer-with-nested-stacking-expected.txt:
* platform/gtk/fast/layers/self-painting-outline-expected.txt: Added.
* platform/gtk/fast/lists/dynamic-marker-crash-expected.txt:
* platform/gtk/fast/multicol/layers-split-across-columns-expected.txt:
* platform/gtk/fast/overflow/004-expected.txt:
* platform/gtk/fast/overflow/clip-rects-fixed-ancestor-expected.txt:
* platform/gtk/fast/overflow/line-clamp-expected.txt:
* platform/gtk/fast/overflow/overflow-focus-ring-expected.txt:
* platform/gtk/fast/repaint/iframe-scroll-repaint-expected.txt:
* platform/gtk/fast/repaint/inline-relative-positioned-expected.txt:
* platform/gtk/fast/repaint/layer-outline-expected.txt:
* platform/gtk/fast/repaint/layer-outline-horizontal-expected.txt:
* platform/gtk/fast/repaint/lines-with-layout-delta-expected.txt:
* platform/gtk/fast/repaint/opacity-change-on-overflow-float-expected.txt:
* platform/gtk/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
* platform/gtk/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.txt:
* platform/gtk/fast/repaint/repaint-resized-overflow-expected.txt:
* platform/gtk/fast/repaint/search-field-cancel-expected.txt:
* platform/gtk/fast/repaint/subtree-layoutstate-transform-expected.txt:
* platform/gtk/fast/repaint/subtree-root-clip-2-expected.txt: Added.
* platform/gtk/fast/repaint/subtree-root-clip-3-expected.txt: Added.
* platform/gtk/fast/repaint/subtree-root-clip-expected.txt: Added.
* platform/gtk/fast/repaint/subtree-root-skipped-expected.txt:
* platform/gtk/fast/repaint/transform-absolute-in-positioned-container-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-expected.txt:
* platform/gtk/fast/replaced/replaced-breaking-mixture-expected.txt:
* platform/gtk/fast/replaced/width100percent-searchfield-expected.txt:
* platform/gtk/fast/replaced/width100percent-textfield-expected.txt:
* platform/gtk/fast/table/003-expected.txt:
* platform/gtk/fast/table/029-expected.txt:
* platform/gtk/fast/table/colspanMinWidth-expected.txt:
* platform/gtk/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/gtk/fast/table/overflowHidden-expected.txt:
* platform/gtk/fast/table/spanOverlapRepaint-expected.txt:
* platform/gtk/fast/table/text-field-baseline-expected.txt:
* platform/gtk/fast/text/selection-painted-separately-expected.txt:
* platform/gtk/fast/text/selection-rect-rounding-expected.txt:
* platform/gtk/fast/text/textIteratorNilRenderer-expected.txt:
* platform/gtk/fast/transforms/transformed-focused-text-input-expected.txt:
* platform/gtk/plugins/mouse-click-plugin-clears-selection-expected.txt:
* platform/gtk/svg/custom/inline-svg-in-xhtml-expected.txt:
* platform/gtk/svg/hixie/mixed/003-expected.txt:
* platform/gtk/tables/mozilla/bugs/45621-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug1188-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug12384-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug154780-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug18359-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug24200-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-3-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug2479-4-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug28928-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4382-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug44505-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug4527-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46368-1-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug46368-2-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug51037-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug55545-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug7342-expected.txt:
* platform/gtk/tables/mozilla/bugs/bug99948-expected.txt:
* platform/gtk/tables/mozilla/dom/tableDom-expected.txt:
* platform/gtk/tables/mozilla/other/move_row-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug106966-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug45621-expected.txt:
* platform/gtk/tables/mozilla_expected_failures/bugs/bug92647-1-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening. Fixing expectations due to new Mac Lion baselines.
leviw@chromium.org [Mon, 19 Mar 2012 08:36:06 +0000 (08:36 +0000)]
Unreviewed gardening. Fixing expectations due to new Mac Lion baselines.

* platform/chromium-linux-x86/css2.1/20110323: Removed.
* platform/chromium-linux/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-mac-leopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
* platform/chromium-mac/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.
* platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.png: Added.
* platform/chromium-win/css2.1/20110323/border-collapse-offset-002-expected.txt: Added.
* platform/mac-snowleopard/css2.1/20110323/border-collapse-offset-002-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK gardening
philn@webkit.org [Mon, 19 Mar 2012 08:24:01 +0000 (08:24 +0000)]
Unreviewed, GTK gardening

* platform/gtk/Skipped: Move the 2 http tests skipped in r111161
to the showModal section.
* platform/gtk/test_expectations.txt: Unskip tests needing rebaseline.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed gardening: updating max-width-integer-overflow test expectations post...
leviw@chromium.org [Mon, 19 Mar 2012 08:21:41 +0000 (08:21 +0000)]
Unreviewed gardening: updating max-width-integer-overflow test expectations post 111156, which
eliminated code dealing with 28-bit lengths.

* platform/chromium-win-vista/fast/table: Added.
* platform/chromium-win-vista/fast/table/max-width-integer-overflow-expected.txt: Added.
* platform/chromium-win-xp/fast/table/max-width-integer-overflow-expected.txt: Added.
* platform/chromium-win/fast/table/max-width-integer-overflow-expected.png: Added.
* platform/chromium-win/fast/table/max-width-integer-overflow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoJSCallbackFunction::toStringCallback/valueOfCallback do not handle 0 return value...
barraclough@apple.com [Mon, 19 Mar 2012 08:12:05 +0000 (08:12 +0000)]
JSCallbackFunction::toStringCallback/valueOfCallback do not handle 0 return value from convertToType
https://bugs.webkit.org/show_bug.cgi?id=81468 <rdar://problem/11034745>

Reviewed by Oliver Hunt.

The API specifies that convertToType may opt not to handle a conversion:
    "@result The objects's converted value, or NULL if the object was not converted."
In which case, it would propagate first up the JSClass hierarchy, calling its superclass's
conversion functions, and failing that call the JSObject::defaultValue function.

Unfortunately this behaviour was removed in bug#69677/bug#69858, and instead we now rely on
the toStringCallback/valueOfCallback function introduced in bug#69156. Even after a fix in
bug#73368, these will return the result from the first convertToType they find, regardless
of whether this result is null, and if no convertToType method is found in the api class
hierarchy (possible if toStringCallback/valueOfCallback was accessed off the prototype
chain), they will also return a null pointer. This is unsafe.

It would be easy to make the approach based around toStringCallback/valueOfCallback continue
to walk the api class hierarchy, but making the fallback to defaultValue would be problematic
(since defaultValue calls toStringCallback/valueOfCallback, this would infinitely recurse).
Making the fallback work with toString/valueOf methods attached to api objects is probably
not the right thing to do – instead, we should just implement the defaultValue trap for api
objects.

In addition, this bug highlights that fact that JSCallbackFunction::call will allow a hard
null to be returned from C to JavaScript - this is not okay. Handle with an exception.

* API/JSCallbackFunction.cpp:
(JSC::JSCallbackFunction::call):
    - Should be null checking the return value.
(JSC):
    - Remove toStringCallback/valueOfCallback.
* API/JSCallbackFunction.h:
(JSCallbackFunction):
    - Remove toStringCallback/valueOfCallback.
* API/JSCallbackObject.h:
(JSCallbackObject):
    - Add defaultValue mthods to JSCallbackObject.
* API/JSCallbackObjectFunctions.h:
(JSC::::defaultValue):
    - Add defaultValue mthods to JSCallbackObject.
* API/JSClassRef.cpp:
(OpaqueJSClass::prototype):
    - Remove toStringCallback/valueOfCallback.
* API/tests/testapi.js:
    - Revert this test, now we no longer artificially introduce a toString method onto the api object.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, GTK rebaseline after r111156 and skip 2 new http tests.
philn@webkit.org [Mon, 19 Mar 2012 08:01:24 +0000 (08:01 +0000)]
Unreviewed, GTK rebaseline after r111156 and skip 2 new http tests.

* platform/gtk/Skipped:
* platform/gtk/fast/table/max-width-integer-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111161 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix build that was broken by r111137
keishi@webkit.org [Mon, 19 Mar 2012 07:11:31 +0000 (07:11 +0000)]
[chromium] Fix build that was broken by r111137

Fixed was ambiguous because of MacTypes.h

* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::addTransformAnimationToLayer):
* tests/CCOcclusionTrackerTest.cpp:
(WebCore::addTransformAnimationToLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed new baselines of various tests for Mac.
timothy_horton@apple.com [Mon, 19 Mar 2012 07:01:21 +0000 (07:01 +0000)]
Unreviewed new baselines of various tests for Mac.

* compositing/overflow/overflow-scaled-descendant-overlapping-expected.txt: Added (http://trac.webkit.org/changeset/105879).
* platform/mac/compositing/overflow/overflow-scaled-descendant-overlapping-expected.png: Added (http://trac.webkit.org/changeset/105879).
* platform/mac/css2.1/20110323/border-collapse-offset-002-expected.png: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/103877).
* platform/mac/css2.1/20110323/border-collapse-offset-002-expected.txt: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/103877).
* platform/mac/css2.1/20110323/outline-color-applies-to-008-expected.png: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/105023).
* platform/mac/css2.1/20110323/outline-color-applies-to-008-expected.txt: Added (had reftest result, switched to image+text in http://trac.webkit.org/changeset/105023).
* platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.png: Added (platform result removed in http://trac.webkit.org/changeset/110179).
* platform/mac/fast/block/float/float-not-removed-from-next-sibling3-expected.txt: Added (platform result removed in http://trac.webkit.org/changeset/110179).
* platform/mac/fast/css/font-face-synthetic-bold-italic-expected.png: Added (http://trac.webkit.org/changeset/107516).
* platform/mac/fast/css/font-face-synthetic-bold-italic-expected.txt: Added (http://trac.webkit.org/changeset/107516).
* platform/mac/fast/css/font-face-weight-matching-expected.png: Added (http://trac.webkit.org/changeset/107516).
* platform/mac/fast/css/font-face-weight-matching-expected.txt: Added (http://trac.webkit.org/changeset/107516).
* platform/mac/fast/css/non-empty-span-expected.png: Added (http://trac.webkit.org/changeset/108111).
* platform/mac/fast/css/non-empty-span-expected.txt: Added (http://trac.webkit.org/changeset/108111).
* platform/mac/fast/dom/52776-expected.txt: Added (incorrectly moved to mac-future in http://trac.webkit.org/changeset/110189, then deleted by me).
* platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.png: Added (http://trac.webkit.org/changeset/109612).
* platform/mac/fast/forms/fieldset-legend-padding-unclipped-fieldset-border-expected.txt: Added (http://trac.webkit.org/changeset/109612).
* platform/mac/fast/forms/select-overflow-scroll-expected.png: Added (http://trac.webkit.org/changeset/107072).
* platform/mac/fast/forms/select-overflow-scroll-expected.txt: Added (http://trac.webkit.org/changeset/107072).
* platform/mac/fast/forms/select-overflow-scroll-inherited-expected.png: Added (http://trac.webkit.org/changeset/107072).
* platform/mac/fast/forms/select-overflow-scroll-inherited-expected.txt: Added (http://trac.webkit.org/changeset/107072).
* platform/mac/fast/repaint/transform-rotate-and-remove-expected.png: Added (http://trac.webkit.org/changeset/109867).
* platform/mac/fast/repaint/transform-rotate-and-remove-expected.txt: Added (http://trac.webkit.org/changeset/109867).
* platform/mac/test_expectations.txt:
* transforms/3d/general/background-visibility-layers-expected.png: Renamed from LayoutTests/transforms/3d/general/background-visibility-layers-actual.png.
* transforms/3d/general/background-visibility-layers-expected.txt: Renamed from LayoutTests/transforms/3d/general/background-visibility-layers-actual.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Unreviewed. Disable -Werror on x86 until proper fix.
ossy@webkit.org [Mon, 19 Mar 2012 06:59:28 +0000 (06:59 +0000)]
[Qt] Unreviewed. Disable -Werror on x86 until proper fix.
https://bugs.webkit.org/show_bug.cgi?id=81498

* qmake/mkspecs/features/unix/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFallback to common script when per-script font setting is the empty string
commit-queue@webkit.org [Mon, 19 Mar 2012 06:58:19 +0000 (06:58 +0000)]
Fallback to common script when per-script font setting is the empty string
https://bugs.webkit.org/show_bug.cgi?id=81329

Patch by Matt Falkenhagen <falken@chromium.org> on 2012-03-18
Reviewed by Kent Tamura.

Source/WebCore:

Tests: fast/text/international/font-fallback-to-common-script.html

* page/Settings.cpp:
(WebCore::setGenericFontFamilyForScript): Remove the setting when the per-script font family is the empty string.

LayoutTests:

* fast/text/international/font-fallback-to-common-script-expected.html: Added.
* fast/text/international/font-fallback-to-common-script.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoRemove remnants of code that assume Lengths are 28 bit integers.
macpherson@chromium.org [Mon, 19 Mar 2012 06:37:54 +0000 (06:37 +0000)]
Remove remnants of code that assume Lengths are 28 bit integers.
https://bugs.webkit.org/show_bug.cgi?id=67976

Reviewed by Eric Seidel.

Source/WebCore:

Test: LayoutTests/fast/table/max-width-integer-overflow-expected.html

* css/CSSPrimitiveValue.cpp:
(WebCore::CSSPrimitiveValue::computeLength):
Bound by INT_MAX and INT_MIN instead of 28 bit bounds.
* css/CSSStyleApplyProperty.cpp:
(WebCore::ApplyPropertyBorderRadius::applyValue):
Use PrimitiveValue::computeLength function directly.
* platform/Length.h:
Remove 28 bit integer limit constants.
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
Use std::numeric_limits.

LayoutTests:

* platform/mac/fast/table/max-width-integer-overflow-expected.png:
* platform/mac/fast/table/max-width-integer-overflow-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoShould remove RuntimeEnabledFeatures::multipleShadowSubtreesEnabled
shinyak@chromium.org [Mon, 19 Mar 2012 06:16:44 +0000 (06:16 +0000)]
Should remove RuntimeEnabledFeatures::multipleShadowSubtreesEnabled
https://bugs.webkit.org/show_bug.cgi?id=79307

Reviewed by Dimitri Glazkov.

Source/WebCore:

Since RuntimeEnabledFeatures::multipleShadowSubtreesEnabled was introduced for
temporal unstability of multiple shadow roots. We should remove it now, and
enable it by default.

Test: fast/dom/shadow/shadow-root-js-api.html should cover this change.
The other shadow related tests should also covers this change.

* WebCore.exp.in:
* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
* dom/ShadowRoot.cpp:
(WebCore::ShadowRoot::create):
* dom/ShadowTree.cpp:
(WebCore::ShadowTree::addShadowRoot):
* testing/Internals.cpp:
* testing/Internals.h:
(Internals):
* testing/Internals.idl:

LayoutTests:

Removed multipleShadowSubtresEnabled from tests.

* fast/dom/shadow/get-element-by-id-in-shadow-root.html:
* fast/dom/shadow/multiple-shadowroot-adopt.html:
* fast/dom/shadow/multiple-shadowroot-rendering.html:
* fast/dom/shadow/multiple-shadowroot.html:
* fast/dom/shadow/shadow-element-rendering-multiple.html:
* fast/dom/shadow/shadow-element-rendering-single.html:
* fast/dom/shadow/shadow-root-js-api-expected.txt:
* fast/dom/shadow/shadow-root-js-api.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Mark js-late-gradient-creation.svg as flaky
keishi@webkit.org [Mon, 19 Mar 2012 06:07:42 +0000 (06:07 +0000)]
[chromium] Mark js-late-gradient-creation.svg as flaky

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Fix test that was broken by r111128
keishi@webkit.org [Mon, 19 Mar 2012 05:23:11 +0000 (05:23 +0000)]
[chromium] Fix test that was broken by r111128

* tests/ScrollAnimatorNoneTest.cpp:
(TEST): ScrollByPixel no longer animates.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline aria-checkbox-sends-notification.html
keishi@webkit.org [Mon, 19 Mar 2012 04:45:32 +0000 (04:45 +0000)]
[chromium] Rebaseline aria-checkbox-sends-notification.html

* platform/chromium-win-xp/accessibility/aria-checkbox-sends-notification-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip fast/dom/shadow/get-element-id-in-shadow-roots on some ports where SHADOW_DOM...
keishi@webkit.org [Mon, 19 Mar 2012 04:35:37 +0000 (04:35 +0000)]
Skip fast/dom/shadow/get-element-id-in-shadow-roots on some ports where SHADOW_DOM flag is disabled.
https://bugs.webkit.org/show_bug.cgi?id=81336

Patch by Hayato Ito <hayato@chromium.org> on 2012-03-18
Reviewed by Dimitri Glazkov.

* fast/dom/shadow/resources/shadow-dom.js:
(createDOM):
(isShadowRoot):
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Include ICU_INCLUDE_DIRS when building.
kubo@profusion.mobi [Mon, 19 Mar 2012 03:36:39 +0000 (03:36 +0000)]
[EFL] Include ICU_INCLUDE_DIRS when building.
https://bugs.webkit.org/show_bug.cgi?id=81483

Reviewed by Daniel Bates.

So far, only the ICU libraries were being included when building
JavaScriptCore, however the include path is also needed, otherwise the
build will fail when ICU is installed into a non-standard location.

* PlatformEfl.cmake: Include ${ICU_INCLUDE_DIRS}.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip fast/dom/shadow/get-element-id-in-shadow-roots on some ports where SHADOW_DOM...
hayato@chromium.org [Mon, 19 Mar 2012 02:40:19 +0000 (02:40 +0000)]
Skip fast/dom/shadow/get-element-id-in-shadow-roots on some ports where SHADOW_DOM flag is disabled.
https://bugs.webkit.org/show_bug.cgi?id=81336

Reviewed by Dimitri Glazkov.

* fast/dom/shadow/resources/shadow-dom.js:
(createDOM):
(isShadowRoot):
* platform/efl/Skipped:
* platform/mac/Skipped:
* platform/win/Skipped:
* platform/wincairo/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline SL results for video-opacity-overlay.html and load-video-in...
keishi@webkit.org [Mon, 19 Mar 2012 02:21:38 +0000 (02:21 +0000)]
[chromium] Rebaseline SL results for video-opacity-overlay.html and load-video-in-reflection.html

* platform/chromium-mac-snowleopard/compositing/geometry/video-opacity-overlay-expected.png: Added.
* platform/chromium-mac-snowleopard/compositing/reflections/load-video-in-reflection-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline results for win shadow-drawing.html
keishi@webkit.org [Mon, 19 Mar 2012 02:12:36 +0000 (02:12 +0000)]
[chromium] Rebaseline results for win shadow-drawing.html

* platform/chromium-win-vista/compositing/shadows/shadow-drawing-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Rebaseline to add expected results for fixed-position-scroll.html
keishi@webkit.org [Mon, 19 Mar 2012 02:06:16 +0000 (02:06 +0000)]
[chromium] Rebaseline to add expected results for fixed-position-scroll.html

* platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.png: Renamed from LayoutTests/platform/chromium-linux/compositing/layer-creation/fixed-position-scroll-expected.png.
* platform/chromium-win/compositing/layer-creation/fixed-position-scroll-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Don't occlude on main-thread behind layers/surfaces with impl-thread anima...
commit-queue@webkit.org [Mon, 19 Mar 2012 01:07:16 +0000 (01:07 +0000)]
[chromium] Don't occlude on main-thread behind layers/surfaces with impl-thread animations
https://bugs.webkit.org/show_bug.cgi?id=81354

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-18
Reviewed by Adrienne Walker.

Source/WebCore:

Layers and surfaces can have an animating opacity or translation on the
impl thread. In this case, the main thread does not know their actual
values, and treats these values as "unknowns". This means we can't use
them for marking areas of the screen as occluded, and we can't consider
a part of a layer occluded in a space that we can not reliably transform
to.

Unit test: CCOcclusionTrackerTestAnimationOpacity0OnMainThread
           CCOcclusionTrackerTestAnimationOpacity1OnMainThread
           CCOcclusionTrackerTestAnimationTranslateOnMainThread

* platform/graphics/chromium/cc/CCOcclusionTracker.cpp:
(WebCore::layerOpacityKnown):
(WebCore::layerTransformsToTargetKnown):
(WebCore::layerTransformsToScreenKnown):
(WebCore):
(WebCore::surfaceOpacityUnknown):
(WebCore::surfaceTransformsToTargetUnknown):
(WebCore::surfaceTransformsToScreenUnknown):
(WebCore::::finishedTargetRenderSurface):
(WebCore::contentToScreenSpaceTransform):
(WebCore::contentToTargetSurfaceTransform):
(WebCore::::markOccludedBehindLayer):
(WebCore::::occluded):
(WebCore::::unoccludedContentRect):

Source/WebKit/chromium:

* tests/CCOcclusionTrackerTest.cpp:
(WebCore):
(WebCore::addOpacityAnimationToLayer):
(WebCore::addTransformAnimationToLayer):
(CCOcclusionTrackerTestAnimationOpacity1OnMainThread):
(WebCore::CCOcclusionTrackerTestAnimationOpacity1OnMainThread::runMyTest):
(CCOcclusionTrackerTestAnimationOpacity0OnMainThread):
(WebCore::CCOcclusionTrackerTestAnimationOpacity0OnMainThread::runMyTest):
(CCOcclusionTrackerTestAnimationTranslateOnMainThread):
(WebCore::CCOcclusionTrackerTestAnimationTranslateOnMainThread::runMyTest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Animating opacity is not opaque and should create a render surface on...
commit-queue@webkit.org [Mon, 19 Mar 2012 00:58:34 +0000 (00:58 +0000)]
[chromium] Animating opacity is not opaque and should create a render surface on main thread
https://bugs.webkit.org/show_bug.cgi?id=81401

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-18
Reviewed by James Robinson.

Source/WebCore:

Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy

* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::layerOpacityIsOpaque):
(WebCore):
(WebCore::subtreeShouldRenderToSeparateSurface):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore::BitmapImage::getCGImageRef should not be used off the main thread.
weinig@apple.com [Mon, 19 Mar 2012 00:39:44 +0000 (00:39 +0000)]
WebCore::BitmapImage::getCGImageRef should not be used off the main thread.
https://bugs.webkit.org/show_bug.cgi?id=81441

Reviewed by Anders Carlsson.

Covered by existing tests.

* loader/cache/MemoryCache.cpp:
(WebCore::memoryCache):
(WebCore::MemoryCache::add):
(WebCore::MemoryCache::revalidationFailed):
(WebCore::MemoryCache::resourceForURL):
(WebCore::MemoryCache::evict):
Add back main thread assertions.

* platform/graphics/cg/PatternCG.cpp:
(PatternCallbackData):
(WebCore::patternCallback):
(WebCore::patternReleaseOnMainThreadCallback):
(WebCore::Pattern::createPlatformPattern):
Instead of pulling out the CGImageRef in the pattern callback, do it upfront.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Don't prepare SQL statements when the database is not open https://bugs.webkit...
ahf@0x90.dk [Mon, 19 Mar 2012 00:23:00 +0000 (00:23 +0000)]
[Qt] Don't prepare SQL statements when the database is not open https://bugs.webkit.org/show_bug.cgi?id=81470

Reviewed by Kenneth Rohde Christiansen.

Already covered by existing tests.

* platform/qt/CookieJarQt.cpp:
(WebCore::SharedCookieJarQt::deleteCookiesForHostname):
(WebCore::SharedCookieJarQt::deleteAllCookies):
(WebCore::SharedCookieJarQt::setCookiesFromUrl):
(WebCore::SharedCookieJarQt::loadCookies):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r110994 due to Chromium crash
haraken@chromium.org [Sun, 18 Mar 2012 23:50:01 +0000 (23:50 +0000)]
Unreviewed, rolling out r110994 due to Chromium crash

* CMakeLists.txt:
* DerivedSources.make:
* DerivedSources.pri:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* notifications/DOMWindowNotifications.cpp: Removed.
* notifications/DOMWindowNotifications.h: Removed.
* notifications/DOMWindowNotifications.idl: Removed.
* page/DOMWindow.cpp:
(WebCore::DOMWindow::~DOMWindow):
(WebCore::DOMWindow::willDetachPage):
(WebCore::DOMWindow::disconnectDOMWindowProperties):
(WebCore::DOMWindow::clearDOMWindowProperties):
(WebCore):
(WebCore::DOMWindow::webkitNotifications):
(WebCore::DOMWindow::resetNotifications):
* page/DOMWindow.h:
(WebCore):
(DOMWindow):
* page/DOMWindow.idl:
* page/Frame.cpp:
(WebCore::Frame::willDetachPage):
(WebCore::Frame::transferChildFrameToNewDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, rolling out r111086.
haraken@chromium.org [Sun, 18 Mar 2012 23:39:57 +0000 (23:39 +0000)]
Unreviewed, rolling out r111086.
http://trac.webkit.org/changeset/111086
https://bugs.webkit.org/show_bug.cgi?id=81374

Chromium crash

* notifications/DOMWindowNotifications.cpp:
(WebCore::DOMWindowNotifications::disconnectFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoInvalidation issue when creating backing layer for fixed positioned element.
commit-queue@webkit.org [Sun, 18 Mar 2012 23:07:27 +0000 (23:07 +0000)]
Invalidation issue when creating backing layer for fixed positioned element.
https://bugs.webkit.org/show_bug.cgi?id=80647

Patch by David Reveman <reveman@chromium.org> on 2012-03-18
Reviewed by James Robinson.

Source/WebCore:

Ensure that root layer is correctly invalidated by handling scroll and
invalidation from movement of fixed position elements prior to creating
any backing layers.

Test: compositing/layer-creation/fixed-position-scroll.html

* page/FrameView.cpp:
(WebCore::FrameView::repaintFixedElementsAfterScrolling):
(WebCore):
(WebCore::FrameView::updateFixedElementsAfterScrolling):
* page/FrameView.h:
(FrameView):
* platform/ScrollView.cpp:
(WebCore::ScrollView::scrollTo):
* platform/ScrollView.h:
(WebCore::ScrollView::repaintFixedElementsAfterScrolling):
(WebCore::ScrollView::updateFixedElementsAfterScrolling):

LayoutTests:

* compositing/layer-creation/fixed-position-scroll.html: Added.
* platform/chromium-linux/compositing/layer-creation/fixed-position-scroll-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt][WK2] Avoid usage of manual scaling in the Qt scenegraph integration
noam.rosenthal@nokia.com [Sun, 18 Mar 2012 22:52:01 +0000 (22:52 +0000)]
[Qt][WK2] Avoid usage of manual scaling in the Qt scenegraph integration
https://bugs.webkit.org/show_bug.cgi?id=81368

Reviewed by Simon Hausmann.

Moved the QtScenegraph integration classes to a separate file,
QtWebPageSGNode. The nodes created for QQuickWebPage now include
a QSGTransformNode that controls the contentsScale, a
QSGSimpleRectNode that controls the background color, and a
QSGRenderNode subclass that renders the actual contents.
* Target.pri:
* UIProcess/API/qt/qquickwebpage.cpp:
(QQuickWebPage::updatePaintNode):
* UIProcess/qt/QtWebPageSGNode.cpp: Added.
* UIProcess/qt/QtWebPageSGNode.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Transform animation state should be inherited from parents
commit-queue@webkit.org [Sun, 18 Mar 2012 21:58:59 +0000 (21:58 +0000)]
[chromium] Transform animation state should be inherited from parents
https://bugs.webkit.org/show_bug.cgi?id=81363

Patch by Dana Jansens <danakj@chromium.org> on 2012-03-18
Reviewed by Adrienne Walker.

Source/WebCore:

Adds a drawTransformIsAnimating() and screenSpaceTransformIsAnimating()
to the layer classes, and similar to the surface classes. These inherit
the values from their parents in the same way that the transforms
themselves do, and reflect if the layer's transform is being affected
by some active animation.

These can be used in main-thread culling when determining if the layer's
position is static in the given coordinate space or being animated.

Unit test: CCLayerTreeHostCommonTest.verifyAnimationsForRenderSurfaceHierarchy

* platform/graphics/chromium/LayerChromium.cpp:
(WebCore::LayerChromium::LayerChromium):
* platform/graphics/chromium/LayerChromium.h:
(LayerChromium):
(WebCore::LayerChromium::drawTransformIsAnimating):
(WebCore::LayerChromium::setDrawTransformIsAnimating):
(WebCore::LayerChromium::screenSpaceTransformIsAnimating):
(WebCore::LayerChromium::setScreenSpaceTransformIsAnimating):
* platform/graphics/chromium/RenderSurfaceChromium.cpp:
(WebCore::RenderSurfaceChromium::RenderSurfaceChromium):
* platform/graphics/chromium/RenderSurfaceChromium.h:
(WebCore::RenderSurfaceChromium::targetSurfaceTransformsAreAnimating):
(WebCore::RenderSurfaceChromium::setTargetSurfaceTransformsAreAnimating):
(WebCore::RenderSurfaceChromium::screenSpaceTransformsAreAnimating):
(WebCore::RenderSurfaceChromium::setScreenSpaceTransformsAreAnimating):
(RenderSurfaceChromium):
* platform/graphics/chromium/cc/CCLayerImpl.cpp:
(WebCore::CCLayerImpl::CCLayerImpl):
* platform/graphics/chromium/cc/CCLayerImpl.h:
(CCLayerImpl):
(WebCore::CCLayerImpl::drawTransformIsAnimating):
(WebCore::CCLayerImpl::setDrawTransformIsAnimating):
(WebCore::CCLayerImpl::screenSpaceTransformIsAnimating):
(WebCore::CCLayerImpl::setScreenSpaceTransformIsAnimating):
* platform/graphics/chromium/cc/CCLayerTreeHostCommon.cpp:
(WebCore::subtreeShouldBeSkipped):
(WebCore::calculateDrawTransformsAndVisibilityInternal):
* platform/graphics/chromium/cc/CCRenderSurface.cpp:
(WebCore::CCRenderSurface::CCRenderSurface):
* platform/graphics/chromium/cc/CCRenderSurface.h:
(WebCore::CCRenderSurface::targetSurfaceTransformsAreAnimating):
(WebCore::CCRenderSurface::setTargetSurfaceTransformsAreAnimating):
(WebCore::CCRenderSurface::screenSpaceTransformsAreAnimating):
(WebCore::CCRenderSurface::setScreenSpaceTransformsAreAnimating):
(CCRenderSurface):

Source/WebKit/chromium:

* tests/CCLayerTreeHostCommonTest.cpp:
(WebCore::addOpacityAnimationToLayer):
(WebCore):
(WebCore::addTransformAnimationToLayer):
(WebCore::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] The background is visible for tiles inside the contents area which are not ready
noam.rosenthal@nokia.com [Sun, 18 Mar 2012 19:28:16 +0000 (19:28 +0000)]
[Qt] The background is visible for tiles inside the contents area which are not ready
https://bugs.webkit.org/show_bug.cgi?id=81349

Reviewed by Simon Hausmann.

Split PageProxyNode to BackgroundSGNode and ContentsSGNode.
BackgroundSGNode paints a solid background, either white or transparent
(depending on drawsTransparentBackground flag).

* UIProcess/API/qt/qquickwebpage.cpp:
(ContentsSGNode):
(ContentsSGNode::ContentsSGNode):
(ContentsSGNode::changedStates):
(ContentsSGNode::~ContentsSGNode):
(BackgroundSGNode):
(BackgroundSGNode::BackgroundSGNode):
(BackgroundSGNode::contentsNode):
(QQuickWebPage::updatePaintNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix compile when FULLSCREEN_API is not enabled on Mac
psolanki@apple.com [Sun, 18 Mar 2012 19:17:21 +0000 (19:17 +0000)]
Fix compile when FULLSCREEN_API is not enabled on Mac
https://bugs.webkit.org/show_bug.cgi?id=81474

Reviewed by Ada Chan.

Guard the full screen api code inside ENABLE(FULLSCREEN_API).

No new tests because no functional changes.

* platform/mac/WebCoreFullScreenWindow.h:
* platform/mac/WebCoreFullScreenWindow.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoChange the initial buffer size of a plain text
haraken@chromium.org [Sun, 18 Mar 2012 16:59:46 +0000 (16:59 +0000)]
Change the initial buffer size of a plain text
https://bugs.webkit.org/show_bug.cgi?id=81192

Reviewed by Dimitri Glazkov.

r111109 changed the initial buffer size of a plain text
from 1<<16 to 1<<15 in Chromium/Mac only, for the following reasons:

- As far as I experimented locally, while 1<<15 is better than 1<<16 in Chromium/Mac,
1<<15 and 1<<16 are the same in AppleWebKit/Mac and Chromium/Linux (their performance
"gap" exists at between 1<<17 and 1<<18).
- The reason why I changed 1<<16 to 1<<15 in Chromium/Mac only is that
the value highly depends on the underlying malloc system and I was a bit afraid
that changing to 1<<15 _might_ cause unintentional performance regression in some
platform.

That being said, it seems that 1<<15 would not be worse than 1<<16 in all platforms,
and we should just keep the value consistent. In the first place, according to anttik
(who wrote 1<<16 a long time ago), there was no strong reason for 1<<16.

Based on these observations (See https://bugs.webkit.org/show_bug.cgi?id=81192
for more details), this patch unifies the value to 1<<15 in all platforms.

No tests. No change in behavior.

* editing/TextIterator.cpp:
(WebCore::plainTextToMallocAllocatedBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: eof-003.htm fails
robert@webkit.org [Sun, 18 Mar 2012 11:33:04 +0000 (11:33 +0000)]
CSS 2.1 failure: eof-003.htm fails
https://bugs.webkit.org/show_bug.cgi?id=78538

Reviewed by Antti Koivisto.

Source/WebCore:

Tests: css2.1/20110323/eof-001.htm
       css2.1/20110323/eof-003.htm
       css2.1/20110323/eof-004.htm
       css2.1/20110323/eof-005.htm
       css2.1/20110323/eof-006.htm
       css2.1/20110323/eof-007.htm

This patch fixes eof-003.htm, eof-005.htm and eof-006.htm. The other eof-* tests already pass.

* css/CSSGrammar.y: Allow EOF as well as ';' to terminate import rules.
                    This should probably be done for other rules in a separate patch.
* css/CSSParser.cpp:
(WebCore::CSSParser::checkAndSkipString): Allow strings to end with EOF.
(WebCore::CSSParser::parseString): ditto

LayoutTests:

* css2.1/20110323/eof-001-expected.html: Added.
* css2.1/20110323/eof-001.htm: Added.
* css2.1/20110323/eof-003-expected.html: Added.
* css2.1/20110323/eof-003.htm: Added.
* css2.1/20110323/eof-004-expected.html: Added.
* css2.1/20110323/eof-004.htm: Added.
* css2.1/20110323/eof-005-expected.html: Added.
* css2.1/20110323/eof-005.htm: Added.
* css2.1/20110323/eof-006-expected.html: Added.
* css2.1/20110323/eof-006.htm: Added.
* css2.1/20110323/eof-007-expected.html: Added.
* css2.1/20110323/eof-007.htm: Added.
* css2.1/20110323/support/eof-green.css: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium] PlatformContextSkia::m_drawingToImageBuffer is not correctly set when...
commit-queue@webkit.org [Sun, 18 Mar 2012 03:20:21 +0000 (03:20 +0000)]
[Chromium] PlatformContextSkia::m_drawingToImageBuffer is not correctly set when using per-tile painting.
https://bugs.webkit.org/show_bug.cgi?id=81463

Patch by David Reveman <reveman@chromium.org> on 2012-03-17
Reviewed by James Robinson.

Call PlatformContextSkia::setDrawingToImageBuffer() from
SkPictureCanvasLayerTextureUpdater::prepareToUpdate so that sub-pixel
text rendering is not used incorrectly with per-tile painting.

No new tests.

* platform/graphics/chromium/SkPictureCanvasLayerTextureUpdater.cpp:
(WebCore::SkPictureCanvasLayerTextureUpdater::prepareToUpdate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; switch to using my FreeBSD.org email address, the
kubo@profusion.mobi [Sun, 18 Mar 2012 01:57:44 +0000 (01:57 +0000)]
Unreviewed; switch to using my FreeBSD.org email address, the
other one is going to disappear soon.

* Scripts/webkitpy/common/config/committers.py:
* Scripts/webkitpy/common/config/watchlist:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStrength reduction, RegExp.exec -> RegExp.test
barraclough@apple.com [Sun, 18 Mar 2012 01:08:16 +0000 (01:08 +0000)]
Strength reduction, RegExp.exec -> RegExp.test
https://bugs.webkit.org/show_bug.cgi?id=81459

Reviewed by Sam Weinig.

RegExp.prototype.exec & RegExp.prototype.test can both be used to test a regular
expression for a match against a string - however exec is more expensive, since
it allocates a matches array object. In cases where the result is consumed in a
boolean context the allocation of the matches array can be trivially elided.

For example:
    function f()
    {
        for (i =0; i < 10000000; ++i)
            if(!/a/.exec("a"))
                err = true;
    }

This is a 2.5x speedup on this example microbenchmark loop.

In a more advanced form of this optimization, we may be able to avoid allocating
the array where access to the array can be observed.

* create_hash_table:
* dfg/DFGAbstractState.cpp:
(JSC::DFG::AbstractState::execute):
* dfg/DFGByteCodeParser.cpp:
(JSC::DFG::ByteCodeParser::handleIntrinsic):
* dfg/DFGNode.h:
(JSC::DFG::Node::hasHeapPrediction):
* dfg/DFGNodeType.h:
(DFG):
* dfg/DFGOperations.cpp:
* dfg/DFGOperations.h:
* dfg/DFGPredictionPropagationPhase.cpp:
(JSC::DFG::PredictionPropagationPhase::propagate):
* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileRegExpExec):
(DFG):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::callOperation):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* jsc.cpp:
(GlobalObject::addConstructableFunction):
* runtime/Intrinsic.h:
* runtime/JSFunction.cpp:
(JSC::JSFunction::create):
(JSC):
* runtime/JSFunction.h:
(JSFunction):
* runtime/Lookup.cpp:
(JSC::setUpStaticFunctionSlot):
* runtime/RegExpObject.cpp:
(JSC::RegExpObject::exec):
(JSC::RegExpObject::match):
* runtime/RegExpObject.h:
(RegExpObject):
* runtime/RegExpPrototype.cpp:
(JSC::regExpProtoFuncTest):
(JSC::regExpProtoFuncExec):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Make pixel-accurate wheel scrolling be unanimated
commit-queue@webkit.org [Sat, 17 Mar 2012 23:57:24 +0000 (23:57 +0000)]
[chromium] Make pixel-accurate wheel scrolling be unanimated
https://bugs.webkit.org/show_bug.cgi?id=81457

Patch by Robert Kroeger <rjkroege@chromium.org> on 2012-03-17
Reviewed by James Robinson.

* platform/ScrollAnimatorNone.cpp:
(WebCore::ScrollAnimatorNone::scroll):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Implement openTemporaryFile in FileSystem
rwlbuis@webkit.org [Sat, 17 Mar 2012 22:56:02 +0000 (22:56 +0000)]
[BlackBerry] Implement openTemporaryFile in FileSystem
https://bugs.webkit.org/show_bug.cgi?id=81373

Reviewed by George Staikos.

Move the Efl implementation to Posix, this way BlackBerry port can reuse it.

* platform/blackberry/FileSystemBlackBerry.cpp:
* platform/efl/FileSystemEfl.cpp:
* platform/posix/FileSystemPOSIX.cpp:
(WebCore::openTemporaryFile):
(WebCore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agomove calc*Value functions out from Length (and platform)
commit-queue@webkit.org [Sat, 17 Mar 2012 19:54:09 +0000 (19:54 +0000)]
move calc*Value functions out from Length (and platform)
https://bugs.webkit.org/show_bug.cgi?id=80897

Moving the Length calc*Value functions out from Length structure and also from /WebCore/platform/ folder.
This helps to avoid the layering violation while length calculation. Otherwise layer violation can be avoided only by adding a virtual interface(bug 27160).

Patch by Joe Thomas <joethomas@motorola.com> on 2012-03-17
Reviewed by Antti Koivisto.

Source/WebCore:

* GNUmakefile.list.am: Build system changes for adding new files.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* accessibility/gtk/WebKitAccessibleInterfaceText.cpp:
(getAttributeSetForAccessibilityObject):
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/LengthFunctions.h: Added. Moved calc*Value functions of Length.
(WebCore):
(WebCore::calculateMinimumValue):
(WebCore::calculateValue):
(WebCore::calculateFloatValue):
* dom/Document.cpp:
(WebCore::Document::pageSizeAndMarginsInPixels):
* html/HTMLAreaElement.cpp:
(WebCore::HTMLAreaElement::getRegion):
* platform/CalculationValue.h:
(WebCore::CalcExpressionLength::evaluate):
* platform/Length.h: Removed the calc*Value functions from Length structure.
(Length):
(WebCore::Length::getFloatValue):
(WebCore::Length::getIntValue):
* platform/graphics/ca/mac/PlatformCAAnimationMac.mm:
* platform/graphics/ca/mac/PlatformCALayerMac.mm:
(PlatformCALayer::setFilters):
* platform/graphics/chromium/cc/CCRenderSurfaceFilters.cpp:
(WebCore::CCRenderSurfaceFilters::apply):
* platform/graphics/filters/FilterOperations.cpp:
(WebCore::FilterOperations::getOutsets):
* platform/graphics/transforms/PerspectiveTransformOperation.cpp:
(WebCore::PerspectiveTransformOperation::blend):
* platform/graphics/transforms/PerspectiveTransformOperation.h:
(WebCore::PerspectiveTransformOperation::isIdentity):
(WebCore::PerspectiveTransformOperation::apply):
* platform/graphics/transforms/TranslateTransformOperation.h:
(WebCore::TranslateTransformOperation::x):
(WebCore::TranslateTransformOperation::y):
(WebCore::TranslateTransformOperation::z):
(WebCore::TranslateTransformOperation::isIdentity):
* platform/win/PopupMenuWin.cpp:
(WebCore::PopupMenuWin::paint):
* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::layout):
* rendering/FilterEffectRenderer.cpp:
(WebCore::FilterEffectRenderer::build):
* rendering/FixedTableLayout.cpp:
(WebCore::FixedTableLayout::layout):
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::textIndentOffset):
(WebCore::RenderBlock::computeInlinePreferredLogicalWidths):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::reflectionOffset):
(WebCore::RenderBox::clipRect):
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
(WebCore::RenderBox::computeInlineDirectionMargins):
(WebCore::RenderBox::computePercentageLogicalHeight):
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
(WebCore::RenderBox::computeReplacedLogicalHeightUsing):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::computeBlockDirectionMargins):
(WebCore::RenderBox::computePositionedLogicalWidthUsing):
(WebCore::RenderBox::computePositionedLogicalHeightUsing):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::relativePositionOffsetX):
(WebCore::RenderBoxModelObject::relativePositionOffsetY):
(WebCore::RenderBoxModelObject::paddingTop):
(WebCore::RenderBoxModelObject::paddingBottom):
(WebCore::RenderBoxModelObject::paddingLeft):
(WebCore::RenderBoxModelObject::paddingRight):
(WebCore::RenderBoxModelObject::paddingBefore):
(WebCore::RenderBoxModelObject::paddingAfter):
(WebCore::RenderBoxModelObject::paddingStart):
(WebCore::RenderBoxModelObject::paddingEnd):
(WebCore::RenderBoxModelObject::calculateFillTileSize):
(WebCore::RenderBoxModelObject::calculateBackgroundImageGeometry):
(WebCore::computeBorderImageSide):
(WebCore::RenderBoxModelObject::paintNinePieceImage):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::preferredMainAxisContentExtentForChild):
(WebCore::RenderFlexibleBox::computeMainAxisPreferredSizes):
(WebCore::RenderFlexibleBox::runFreeSpaceAllocationAlgorithm):
* rendering/RenderFrameSet.cpp:
(WebCore::RenderFrameSet::layOutAxis):
* rendering/RenderInline.cpp:
(WebCore::computeMargin):
* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::perspectiveTransform):
(WebCore::RenderLayer::perspectiveOrigin):
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::computeTransformOrigin):
(WebCore::RenderLayerBacking::computePerspectiveOrigin):
* rendering/RenderMarquee.cpp:
(WebCore::RenderMarquee::timerFired):
* rendering/RenderMenuList.cpp:
(WebCore::RenderMenuList::updateOptionsWidth):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::repaintAfterLayoutIfNeeded):
* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
* rendering/RenderScrollbarPart.cpp:
(WebCore::calcScrollbarThicknessUsing):
(WebCore::RenderScrollbarPart::computeScrollbarWidth):
(WebCore::RenderScrollbarPart::computeScrollbarHeight):
* rendering/RenderTable.cpp:
(WebCore::RenderTable::computeLogicalWidth):
(WebCore::RenderTable::convertStyleLogicalWidthToComputedWidth):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::logicalHeightForRowSizing):
* rendering/RenderTableSection.cpp:
(WebCore::RenderTableSection::calcRowLogicalHeight):
* rendering/RenderText.h:
(WebCore::RenderText::marginLeft):
(WebCore::RenderText::marginRight):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::verticalPositionForBox):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::applyTransform):
(WebCore::calcRadiiFor):
* rendering/style/RenderStyle.h:
* rendering/svg/RenderSVGRoot.cpp:
(WebCore::RenderSVGRoot::computeIntrinsicRatioInformation):
(WebCore::resolveLengthAttributeForSVG):
* svg/SVGSVGElement.cpp:
(WebCore::SVGSVGElement::currentViewBoxRect):
(WebCore::SVGSVGElement::currentViewportSize):
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::computeIntrinsicDimensions):

Source/WebKit2:

* WebProcess/WebCoreSupport/win/WebPopupMenuWin.cpp:
(WebKit::WebPopupMenu::setUpPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/10263562> Crash in WebCore::Range::startPosition() when dismissing...
mitz@apple.com [Sat, 17 Mar 2012 19:23:28 +0000 (19:23 +0000)]
<rdar://problem/10263562> Crash in WebCore::Range::startPosition() when dismissing the Press and Hold panel by clicking in the menu bar
https://bugs.webkit.org/show_bug.cgi?id=81454

Reviewed by Ada Chan.

When the Press and Hold panel is dismissed by clicking in the menu bar,
-insertText:replacementRange: is called with an NSRange whose location is NSNotFound - 1
(see <rdar://problem/11069374>). Trying to convert this bogus range to a WebCore Range
returns 0, which leads to the crash.

* WebProcess/WebPage/mac/WebPageMac.mm:
(WebKit::WebPage::insertText): Added a null check, to protect the code from bogus ranges.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed; fix webkitpy unit test failures after r111116.
kubo@profusion.mobi [Sat, 17 Mar 2012 18:12:10 +0000 (18:12 +0000)]
Unreviewed; fix webkitpy unit test failures after r111116.

It turns out that cmd_line in the patch in bug 80025 had the right
signature when it was submitted, but r109242 added a few more
required parameters, and since the method (and EflDriver) did not
exist at the time we ended up committing a broken method.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflDriver.cmd_line): Add the `pixel_tests' and `per_test_args'
arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Enable Web Timing for performance profiling and improvement.
charles.wei@torchmobile.com.cn [Sat, 17 Mar 2012 15:45:23 +0000 (15:45 +0000)]
[BlackBerry] Enable Web Timing for performance profiling and improvement.
https://bugs.webkit.org/show_bug.cgi?id=81085

Reviewed by Rob Buis.

.:

* Source/cmake/OptionsBlackBerry.cmake:
* Source/cmakeconfig.h.cmake:

Source/WebKit/blackberry:

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::init):

Tools:

* Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoEnable animVal support for SVGNumberOptionalNumber
zimmermann@webkit.org [Sat, 17 Mar 2012 12:13:10 +0000 (12:13 +0000)]
Enable animVal support for SVGNumberOptionalNumber
https://bugs.webkit.org/show_bug.cgi?id=81448

Reviewed by Antti Koivisto.

Source/WebCore:

Enable animVal support for SVGNumberOptionalNumber. Its a special case as two SVG DOM properties
eg. stdDeviationX/stdDeviationY are mapped to a single XML attribute: SVGNames::stdDeviationAttr.

When animating properties like this, both animVal wrappers need to reflect changes.
Generalize the current animVal code to support more than one SVGAnimatedProperty that gets
animated for a single attributeName. This allows us to remove SVGAnimatedType::variantValue/setVariantValue
which paves the way for removing SVGGenericAnimatedType from even more places.

Covered by existing tests.

* svg/SVGAnimateElement.cpp:
(WebCore::SVGAnimateElement::SVGAnimateElement):
(WebCore::SVGAnimateElement::calculateAnimatedValue):
(WebCore::SVGAnimateElement::resetToBaseValue):
(WebCore::SVGAnimateElement::targetElementWillChange):
* svg/SVGAnimateElement.h:
(SVGAnimateElement):
* svg/SVGAnimatedLength.cpp:
(WebCore::SVGAnimatedLengthAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedLengthAnimator::resetAnimatedTypeToBaseValue):
* svg/SVGAnimatedLength.h:
(SVGAnimatedLengthAnimator):
* svg/SVGAnimatedLengthList.cpp:
(WebCore::SVGAnimatedLengthListAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedLengthListAnimator::resetAnimatedTypeToBaseValue):
* svg/SVGAnimatedLengthList.h:
(SVGAnimatedLengthListAnimator):
* svg/SVGAnimatedNumber.cpp:
(WebCore::SVGAnimatedNumberAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberAnimator::resetAnimatedTypeToBaseValue):
* svg/SVGAnimatedNumber.h:
(SVGAnimatedNumberAnimator):
* svg/SVGAnimatedNumberList.cpp:
(WebCore::SVGAnimatedNumberListAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberListAnimator::resetAnimatedTypeToBaseValue):
* svg/SVGAnimatedNumberList.h:
(SVGAnimatedNumberListAnimator):
* svg/SVGAnimatedNumberOptionalNumber.cpp:
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::constructFromBaseValue):
(WebCore):
(WebCore::SVGAnimatedNumberOptionalNumberAnimator::resetAnimatedTypeToBaseValue):
* svg/SVGAnimatedNumberOptionalNumber.h:
(WebCore):
(SVGAnimatedNumberOptionalNumberAnimator):
* svg/SVGAnimatedTransformList.cpp:
(WebCore::SVGAnimatedTransformListAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTransformListAnimator::resetAnimatedTypeToBaseValue):
(WebCore):
* svg/SVGAnimatedTransformList.h:
(SVGAnimatedTransformListAnimator):
* svg/SVGAnimatedType.cpp:
(WebCore::SVGAnimatedType::supportsAnimVal):
* svg/SVGAnimatedType.h:
(SVGAnimatedType):
* svg/SVGAnimatedTypeAnimator.h:
(SVGAnimatedTypeAnimator):
(WebCore::SVGAnimatedTypeAnimator::constructFromBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeToBaseValue):
(WebCore::SVGAnimatedTypeAnimator::currentBaseValueVariant):
(WebCore::SVGAnimatedTypeAnimator::constructFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeFromOneBaseValue):
(WebCore::SVGAnimatedTypeAnimator::constructFromTwoBaseValues):
(WebCore::SVGAnimatedTypeAnimator::resetAnimatedTypeFromTwoBaseValues):
* svg/SVGAnimationElement.cpp:
(WebCore::findMatchingAnimatedProperties):
(WebCore::SVGAnimationElement::applyAnimatedValue):
(WebCore::notifyAnimatedPropertyAboutAnimationBeginEnd):
(WebCore::SVGAnimationElement::animationStarted):
(WebCore::SVGAnimationElement::animationEnded):
(WebCore::SVGAnimationElement::animatedPropertiesForType):
* svg/SVGAnimationElement.h:
* svg/properties/SVGAnimatedListPropertyTearOff.h:
(WebCore::SVGAnimatedListPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedListPropertyTearOff::animationStarted):
* svg/properties/SVGAnimatedProperty.h:
(SVGAnimatedProperty):
* svg/properties/SVGAnimatedPropertyTearOff.h:
(WebCore::SVGAnimatedPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedPropertyTearOff::animationStarted):
* svg/properties/SVGAnimatedStaticPropertyTearOff.h:
(WebCore::SVGAnimatedStaticPropertyTearOff::currentBaseValueVariant):
(WebCore::SVGAnimatedStaticPropertyTearOff::animationStarted):

LayoutTests:

Extend SVGNumberOptionalNumber tests to cover animVal/baseVal at the same time.

* svg/animations/script-tests/svgnumberoptionalnumber-animation-1.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-2.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-3.js:
(sample1):
(sample2):
(sample3):
* svg/animations/script-tests/svgnumberoptionalnumber-animation-4.js:
(sample1):
(sample2):
(sample3):
* svg/animations/svgnumberoptionalnumber-animation-1-expected.txt:
* svg/animations/svgnumberoptionalnumber-animation-2-expected.txt:
* svg/animations/svgnumberoptionalnumber-animation-3-expected.txt:
* svg/animations/svgnumberoptionalnumber-animation-4-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[GStreamer] run AudioFileReader in a nested loop
philn@webkit.org [Sat, 17 Mar 2012 11:30:21 +0000 (11:30 +0000)]
[GStreamer] run AudioFileReader in a nested loop
https://bugs.webkit.org/show_bug.cgi?id=80823

Reviewed by Martin Robinson.

Use a separate main loop for the file reader, this approach is
much cleaner than polling the default GLib main context.

* platform/audio/gstreamer/AudioFileReaderGStreamer.cpp:
(AudioFileReader):
(WebCore::enteredMainLoopCallback):
(WebCore):
(WebCore::AudioFileReader::AudioFileReader):
(WebCore::AudioFileReader::handleMessage):
(WebCore::AudioFileReader::start):
(WebCore::AudioFileReader::createBus):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoCSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
robert@webkit.org [Sat, 17 Mar 2012 10:48:41 +0000 (10:48 +0000)]
CSS 2.1 failure: fixed-table-layout-013 and fixed-table-layout-015 fail
https://bugs.webkit.org/show_bug.cgi?id=78027

Reviewed by Julien Chaffraix.

Source/WebCore:

Both of these test the (slightly implicit) rule that width set on column-groups cannot
affect the width of columns in a fixed layout table: http://www.w3.org/TR/CSS21/tables.html#fixed-table-layout
FF, Opera and IE all pass these two tests.

Tests: css2.1/20110323/fixed-table-layout-013.htm
       css2.1/20110323/fixed-table-layout-015.htm
       fast/table/fixed-table-layout-toggle-colwidth.html

* rendering/FixedTableLayout.cpp:
(WebCore::nextCol): A helper function for finding the next column along.
(WebCore::FixedTableLayout::calcWidthArray): Ignore width specified by column groups.
* rendering/RenderTableCol.h:
(WebCore::RenderTableCol::isTableColGroup): Convenience function for identifying column groups.

LayoutTests:

* css2.1/20110323/fixed-table-layout-013-expected.html: Added.
* css2.1/20110323/fixed-table-layout-013.htm: Added.
* css2.1/20110323/fixed-table-layout-015-expected.html: Added.
* css2.1/20110323/fixed-table-layout-015.htm: Added.
* fast/table/fixed-table-layout-toggle-colwidth-expected.txt: Added.
* fast/table/fixed-table-layout-toggle-colwidth.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd a dependencies installation step for EFL to buildbot master.cfg
kubo@profusion.mobi [Sat, 17 Mar 2012 07:45:16 +0000 (07:45 +0000)]
Add a dependencies installation step for EFL to buildbot cfg
https://bugs.webkit.org/show_bug.cgi?id=81337

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

* BuildSlaveSupport/build.webkit.org-config/master.cfg:
(InstallEflDependencies):
(Factory.__init__):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Prefixing run-webkit-tests with run-with-jhbuild
kubo@profusion.mobi [Sat, 17 Mar 2012 07:33:58 +0000 (07:33 +0000)]
[EFL] Prefixing run-webkit-tests with run-with-jhbuild
https://bugs.webkit.org/show_bug.cgi?id=80025

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

* Scripts/webkitpy/layout_tests/port/efl.py:
(EflDriver):
(EflDriver.cmd_line):
(EflPort._driver_class):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
kubo@profusion.mobi [Sat, 17 Mar 2012 07:30:12 +0000 (07:30 +0000)]
[EFL] Add and use run-with-jhbuild and update-webkitefl-libs scripts for EFL
https://bugs.webkit.org/show_bug.cgi?id=79904

build-webkit --efl will use jhbuild for fetching and building dependencies.

Patch by Dominik Röttsches <dominik.rottsches@linux.intel.com> on 2012-03-17
Reviewed by Gustavo Noronha Silva.

* Scripts/update-webkitefl-libs: Added.
* Scripts/webkitdirs.pm:
(jhbuildWrapperPrefixIfNeeded):
(generateBuildSystemFromCMakeProject):
(buildCMakeGeneratedProject):
* efl/common.py: Added.
(script_path):
(top_level_path):
(number_of_cpus):
* efl/jhbuild.modules: Added.
* efl/jhbuildrc: Added.
* efl/run-with-jhbuild: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add BlackBerry to NavigatorBase.cpp
leo.yang@torchmobile.com.cn [Sat, 17 Mar 2012 06:42:10 +0000 (06:42 +0000)]
[BlackBerry] Add BlackBerry to NavigatorBase.cpp
https://bugs.webkit.org/show_bug.cgi?id=81303

Reviewed by Rob Buis.

* page/NavigatorBase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[BlackBerry] Add typedef of DragDataRef for blackberry
leo.yang@torchmobile.com.cn [Sat, 17 Mar 2012 06:39:49 +0000 (06:39 +0000)]
[BlackBerry] Add typedef of DragDataRef for blackberry
https://bugs.webkit.org/show_bug.cgi?id=81301

Reviewed by Rob Buis.

* platform/DragData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[chromium] Unify the drawing logic for different layer types that output textures...
commit-queue@webkit.org [Sat, 17 Mar 2012 04:15:22 +0000 (04:15 +0000)]
[chromium] Unify the drawing logic for different layer types that output textures to the compositor
https://bugs.webkit.org/show_bug.cgi?id=81286

Patch by James Robinson <jamesr@chromium.org> on 2012-03-16
Reviewed by Adrienne Walker.

Source/WebCore:

Currently canvas 2d, webgl, and plugin layers all export a texture to the compositor that then needs to be
drawn.  There are a small set of operations that can be applied to the texture at draw time - do a Y flip,
stretch a subrect to the layer bounds, set the blend mode etc but they are fundamentally the same thing. This
collapses the nearly-redundant code into a single impl-side layer type for a texture-backed layer that can
handle the union of the bits needed for each layer type.

Canvas 2d, WebGL and plugin composited rendering are all covered by layout tests.

* WebCore.gypi:
* platform/graphics/chromium/Canvas2DLayerChromium.cpp:
(WebCore::Canvas2DLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/CanvasLayerChromium.cpp:
(WebCore::CanvasLayerChromium::createCCLayerImpl):
* platform/graphics/chromium/LayerRendererChromium.cpp:
(WebCore::LayerRendererChromium::drawQuad):
(WebCore::TexStretchTextureProgramBinding::set):
(WebCore::TexTransformTextureProgramBinding::set):
(WebCore::LayerRendererChromium::drawTextureQuad):
(WebCore::LayerRendererChromium::textureLayerProgramFlip):
(WebCore::LayerRendererChromium::textureLayerProgramStretch):
(WebCore::LayerRendererChromium::textureLayerProgramStretchFlip):
(WebCore::LayerRendererChromium::textureLayerTexRectProgram):
(WebCore::LayerRendererChromium::textureLayerTexRectProgramFlip):
(WebCore::LayerRendererChromium::cleanupSharedObjects):
* platform/graphics/chromium/LayerRendererChromium.h:
(WebCore):
(LayerRendererChromium):
* platform/graphics/chromium/PluginLayerChromium.cpp:
(WebCore::PluginLayerChromium::PluginLayerChromium):
(WebCore::PluginLayerChromium::createCCLayerImpl):
(WebCore::PluginLayerChromium::setIOSurfaceProperties):
(WebCore::PluginLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/PluginLayerChromium.h:
(PluginLayerChromium):
* platform/graphics/chromium/WebGLLayerChromium.cpp:
(WebCore::WebGLLayerChromium::pushPropertiesTo):
* platform/graphics/chromium/cc/CCCanvasDrawQuad.cpp: Removed.
* platform/graphics/chromium/cc/CCCanvasDrawQuad.h: Removed.
* platform/graphics/chromium/cc/CCCanvasLayerImpl.cpp: Removed.
* platform/graphics/chromium/cc/CCCanvasLayerImpl.h: Removed.
* platform/graphics/chromium/cc/CCDrawQuad.cpp:
(WebCore::CCDrawQuad::toTextureDrawQuad):
* platform/graphics/chromium/cc/CCDrawQuad.h:
(WebCore):
(CCDrawQuad):
* platform/graphics/chromium/cc/CCTextureDrawQuad.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginDrawQuad.cpp.
(WebCore):
(WebCore::CCTextureDrawQuad::create):
(WebCore::CCTextureDrawQuad::CCTextureDrawQuad):
* platform/graphics/chromium/cc/CCTextureDrawQuad.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginDrawQuad.h.
(WebCore):
(CCTextureDrawQuad):
(WebCore::CCTextureDrawQuad::textureId):
(WebCore::CCTextureDrawQuad::hasAlpha):
(WebCore::CCTextureDrawQuad::premultipliedAlpha):
(WebCore::CCTextureDrawQuad::uvRect):
(WebCore::CCTextureDrawQuad::flipped):
(WebCore::CCTextureDrawQuad::ioSurfaceSize):
(WebCore::CCTextureDrawQuad::ioSurfaceTextureId):
* platform/graphics/chromium/cc/CCTextureLayerImpl.cpp: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.cpp.
(WebCore):
(WebCore::CCTextureLayerImpl::CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::~CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::willDraw):
(WebCore::CCTextureLayerImpl::appendQuads):
(WebCore::CCTextureLayerImpl::dumpLayerProperties):
(WebCore::CCTextureLayerImpl::didLoseContext):
(WebCore::CCTextureLayerImpl::setIOSurfaceProperties):
* platform/graphics/chromium/cc/CCTextureLayerImpl.h: Renamed from Source/WebCore/platform/graphics/chromium/cc/CCPluginLayerImpl.h.
(WebCore):
(CCTextureLayerImpl):
(WebCore::CCTextureLayerImpl::create):
(WebCore::CCTextureLayerImpl::textureId):
(WebCore::CCTextureLayerImpl::setTextureId):
(WebCore::CCTextureLayerImpl::setHasAlpha):
(WebCore::CCTextureLayerImpl::setPremultipliedAlpha):
(WebCore::CCTextureLayerImpl::setFlipped):
(WebCore::CCTextureLayerImpl::setUVRect):
(WebCore::CCTextureLayerImpl::layerTypeAsString):

Source/WebKit/chromium:

* tests/Canvas2DLayerChromiumTest.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[EFL] Unreviewed gardening after r111110.
kubo@profusion.mobi [Sat, 17 Mar 2012 03:00:40 +0000 (03:00 +0000)]
[EFL] Unreviewed gardening after r111110.

* platform/efl/Skipped: Unskip fast/canvas/fillText-shadow.html
just like GTK+ did.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Cairo] Text extent of shadowed text is calculated incorrectly
mrobinson@webkit.org [Sat, 17 Mar 2012 02:54:48 +0000 (02:54 +0000)]
[Cairo] Text extent of shadowed text is calculated incorrectly
https://bugs.webkit.org/show_bug.cgi?id=65035

Source/WebCore:

Reviewed by Martin Robinson.

No new tests. This is already covered by fast/canvas/fillText-shadow.html.

Correct determine the size of rendered text using x and y bearing from the font
extents.

* platform/graphics/cairo/FontCairo.cpp:
(WebCore::drawGlyphsShadow): Use the x and y bearing to calculate text extents.
This gives a more accurate sizing and avoids clipping the edges of the shadow.

LayoutTests:

Reviewed by Martin Robinson

* platform/gtk/Skipped: Unskip a test that is now passing.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Chromium][Performance] Optimize innerText and outerText in Chromium/Mac
haraken@chromium.org [Sat, 17 Mar 2012 02:32:51 +0000 (02:32 +0000)]
[Chromium][Performance] Optimize innerText and outerText in Chromium/Mac
https://bugs.webkit.org/show_bug.cgi?id=81192

Reviewed by Dimitri Glazkov.

This patch makes innerText and outerText 4 times faster on Chromium/Mac.
A similar performance improvement will be also observed in APIs that are using
TextIterator::plainText() (e.g. Editting, SpellChecker, Clipboard, Pasteboard etc).

Performance test: https://bugs.webkit.org/attachment.cgi?id=131989

- AppleWebKit/JavaScriptCore/Mac:
div.innerText : 2978.4ms
div.outerText : 2944.4ms

- Chromium/V8/Mac without the patch:
div.innerText : 10050.8ms
div.outerText : 10072.2ms

- Chromium/V8/Mac with the patch:
div.innerText: 2536.4ms
div.outerText: 2714ms

This patch just changes the initial buffer size of a plain text buffer on Chromium/Mac.
As shown below, in my local Chromium/Mac environment the performance changes
dramatically between 1<<15 and 1<<16, and in my local Chromium/Linux environment
the performance changes between 1<<17 and 1<<18. I am not yet sure what determines
these figures, but it seems there exists a performance gap at some point
depending on a malloc mechanism.

- div.innerText results on Chromium/V8/Mac:
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 14 ==> 2465.6 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 15 ==> 2447.2 ms   <--- after this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 16 ==> 10250.8 ms  <--- before this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 17 ==> 10278.2 ms

- div.innerText results on Chromium/V8/Linux:
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 14 ==> 1569.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 15 ==> 1531.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 16 ==> 1543.2 ms  <--- before/after this patch
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 17 ==> 1541.6 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 18 ==> 12540.8 ms
WTF_TEXT_ITERATOR_BUFFER_INITIAL_CAPACITY = 1 << 19 ==> 12340.8 ms

* editing/TextIterator.cpp:
(WebCore::plainTextToMallocAllocatedBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoHTMLFrameElementBase::m_remainsAliveOnRemovalFromTree can be cleared without unloadin...
dimich@chromium.org [Sat, 17 Mar 2012 02:27:51 +0000 (02:27 +0000)]
HTMLFrameElementBase::m_remainsAliveOnRemovalFromTree can be cleared without unloading the frame.
https://bugs.webkit.org/show_bug.cgi?id=80766

Reviewed by Adam Barth.

* html/HTMLFrameElementBase.cpp:
(WebCore::HTMLFrameElementBase::insertedIntoDocument):
(WebCore::HTMLFrameElementBase::setRemainsAliveOnRemovalFromTree):
if adoptNode() is called on a detached iframe or with a detached document,
unload the iframe to avoid live iframe to hang around w/o being attached to
a document.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@111108 268f45cc-cd09-0410-ab3c-d52691b4dbfc