WebKit-https.git
7 years ago[GTK] Move feature overriding to the configure phase
mrobinson@webkit.org [Thu, 21 Feb 2013 16:19:47 +0000 (16:19 +0000)]
[GTK] Move feature overriding to the configure phase
https://bugs.webkit.org/show_bug.cgi?id=110293

Reviewed by Gustavo Noronha Silva.

.:

Rework the feature overrides logic so all feature defines go into a
header rather than the command line. This has a few benefits. Most
notably, we can reuse the header in the gyp build. Another nice result
is that changes to the configuration automatically result in a full
rebuild and Debug and Release builds can have different configurations.

All feature define processing happens now during the configuration phase,
instead of when running autogen.sh. This means that we need to distribute
the feature processing script.

* GNUmakefile.am: Read feature defines from WebKitFeatures.txt when kicking
off a build. Also include generate-feature-defines-files in the distribution.
* Source/autotools/SetupAutoconfHeader.m4: Remove an extra ENABLE_3D_RENDERING
from the autoconf header, as it is already provided by the feature configuration.
* Source/autotools/SetupWebKitFeatures.m4: Added.
* Source/autotools/webkitfeature.m4: Removed. The functionality has been moved
to SetupWebKitFeatures.m4.
* autogen.sh: Remove the call to override-feature-defines.
* configure.ac: Now include SetupWebKitFeatures.

Source/WebCore:

* GNUmakefile.am: No longer include GNUmakefile.features.am. We don't
have to process the result of this file or do any modification of
feature_defines_override, because this variable is gone.

Tools:

* Scripts/webkitdirs.pm:
(runAutogenForAutotoolsProjectIfNecessary): Rename the feature file to
WebKitFeatureOverrides.txt to better match the other filenames used in
the new feature processing.
* gtk/generate-feature-defines-files: Added. A script which takes as an argument
the default features, overrides them with the contents of WebKitFeatureOverrrides.txt
and writes WebKitFeatures.txt and WebKitFeatures.h.
* gtk/override-feature-defines: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143604 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Rolling out an unindented change from r143580.
aandrey@chromium.org [Thu, 21 Feb 2013 16:04:11 +0000 (16:04 +0000)]
Unreviewed. Rolling out an unindented change from r143580.

* inspector/Inspector.json:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143603 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
rakuco@webkit.org [Thu, 21 Feb 2013 16:02:46 +0000 (16:02 +0000)]
[EFL] Unreviewed gardening.

Unskip some tests which are passing; too bad nobody cared to file
bugs for them in the first place.

* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143602 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGlyphPage: Bake per-glyph font data array into same allocation as GlyphPage.
akling@apple.com [Thu, 21 Feb 2013 15:44:02 +0000 (15:44 +0000)]
GlyphPage: Bake per-glyph font data array into same allocation as GlyphPage.

A hopeful fix for REGRESSION(r143125): ~5% performance hit on Chromium's intl2 page cycler
<http://webkit.org/b/108835>

Reviewed by Antti Koivisto.

Rewire GlyphPage so that we have to decide at creation time whether there will be a per-glyph
array of SimpleFontData* or not. This removes one allocation and one step of indirection for
pages with glyphs from mixed fonts.

* platform/graphics/GlyphPage.h:
(WebCore::GlyphPage::createForMixedFontData):
(WebCore::GlyphPage::createForSingleFontData):
(WebCore::GlyphPage::createCopiedSystemFallbackPage):
(WebCore::GlyphPage::~GlyphPage):
(WebCore::GlyphPage::glyphDataForIndex):
(WebCore::GlyphPage::fontDataForCharacter):
(WebCore::GlyphPage::setGlyphDataForIndex):
(WebCore::GlyphPage::removeFontDataFromSystemFallbackPage):
(WebCore::GlyphPage::GlyphPage):
(WebCore::GlyphPage::hasPerGlyphFontData):
(GlyphPage):
* platform/graphics/GlyphPageTreeNode.cpp:
(WebCore::GlyphPageTreeNode::initializePage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143601 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] MediaPlayerPrivateBlackBerry: include Logging.h
commit-queue@webkit.org [Thu, 21 Feb 2013 15:38:04 +0000 (15:38 +0000)]
[BlackBerry] MediaPlayerPrivateBlackBerry: include Logging.h
https://bugs.webkit.org/show_bug.cgi?id=110455

Patch by Xan Lopez <xlopez@rim.com> on 2013-02-21
Reviewed by Eric Carlson.

LOG is used in this file, so it is needed.

* platform/graphics/blackberry/MediaPlayerPrivateBlackBerry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143600 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Invalid use of COMPILE_ASSERT macro in WebKitTextCodec.cpp
commit-queue@webkit.org [Thu, 21 Feb 2013 15:33:24 +0000 (15:33 +0000)]
[BlackBerry] Invalid use of COMPILE_ASSERT macro in WebKitTextCodec.cpp
https://bugs.webkit.org/show_bug.cgi?id=110437

Patch by Carlos Garcia Campos <cargarcia@rim.com> on 2013-02-21
Reviewed by Yong Li.

* Api/WebKitTextCodec.cpp:
(WebKit): Define COMPILE_ASSERT_MATCHING_ENUM() macro and use it to
check enum values match between WebKit and WTF.
(BlackBerry::WebKit::base64Decode): Use a static cast directly to
convert from WebKit Base64DecodePolicy to WTF.
(BlackBerry::WebKit::base64Encode): Use a static cast directly to
convert from WebKit Base64EncodePolicy to WTF.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143599 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd animation class for new calendar picker
keishi@webkit.org [Thu, 21 Feb 2013 14:57:41 +0000 (14:57 +0000)]
Add animation class for new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110132

Reviewed by Kent Tamura.

Adding animation related classes as part of the calendar picker
redesign(Bug 109439).

No new tests. Code is not used yet.

* Resources/pagepopups/calendarPicker.js:
(AnimationTimingFunction.Linear): Parameter t should be a number between 0 and 1.
(AnimationTimingFunction.EaseInOut): Ditto.
(AnimationManager): All animators are managed by this class so we
can dispatch "animationFrameWillFinish" event after all the updates.
(AnimationManager.prototype._startAnimation):
(AnimationManager.prototype._stopAnimation):
(AnimationManager.prototype.add): Adds an animator to the list of running animators.
(AnimationManager.prototype.remove): Removes an animator.
(AnimationManager.prototype._animationFrameCallback): Callback for requestAnimationFrame.
(AnimationManager.prototype._needsAnimationFrame): Returns true if we should request the next animation frame.
(AnimationManager.prototype.on): If we add a callback, request animation frame.
(AnimationManager.prototype.removeListener):
(Animator): Animates between the from value and to value.
(Animator.prototype.setFrom): Sets the from value.
(Animator.prototype.setTo): Sets the to value.
(Animator.prototype.start):
(Animator.prototype.stop):
(Animator.prototype.onAnimationFrame): Called by AnimationManager.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143598 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] UI: more intuitive control buttons
aandrey@chromium.org [Thu, 21 Feb 2013 14:26:17 +0000 (14:26 +0000)]
Web Inspector: [Canvas] UI: more intuitive control buttons
https://bugs.webkit.org/show_bug.cgi?id=110327

Reviewed by Pavel Feldman.

Source/WebCore:

Tweaks to the CanvasProfiler replay control buttons.
- NextDrawCall forward button (StepOver) should jump up to the last expanded node, otherwise a noop is not intuitive unless the last node is selected.
- NextDrawCall/PrevDrawCall buttons should not skip draw call nodes themselves.

* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView.prototype._onReplayDrawingCallClick):

LayoutTests:

* inspector/profiler/canvas2d/canvas-replay-log-grid.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143597 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake SpellCheckRequest's constructor private.
g.czajkowski@samsung.com [Thu, 21 Feb 2013 14:19:29 +0000 (14:19 +0000)]
Make SpellCheckRequest's constructor private.
https://bugs.webkit.org/show_bug.cgi?id=110462

Reviewed by Antonio Gomes.

It's no need to expose SpellCheckRequest's constructor.
There is SpellCheckRequest::create() method which is
responsible for creating SpellCheckRequest object.

No new tests, no behavior change.

* editing/SpellChecker.h:
(SpellCheckRequest):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143596 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Canvas] Remove arrays of DataGrid nodes from the View
aandrey@chromium.org [Thu, 21 Feb 2013 14:15:22 +0000 (14:15 +0000)]
Web Inspector: [Canvas] Remove arrays of DataGrid nodes from the View
https://bugs.webkit.org/show_bug.cgi?id=110325

Reviewed by Pavel Feldman.

Remove arrays of DataGrid nodes from the CanvasProfileView and use live DataGrid instead.
This is a prerequisite to support a non-fixed layered tree in the grid (for example, to hide
a single frame group node, or to combine several draw call groups into a pattern group).
Drive-by: added an assert to injected canvas module.
* inspector/InjectedScriptCanvasModuleSource.js:
* inspector/front-end/CanvasProfileView.js:
(WebInspector.CanvasProfileView):
(WebInspector.CanvasProfileView.prototype.dispose):
(WebInspector.CanvasProfileView.prototype._didReceiveTraceLog):
(WebInspector.CanvasProfileView.prototype._requestTraceLog):
(WebInspector.CanvasProfileView.prototype._selectedCallIndex):
(WebInspector.CanvasProfileView.prototype._peekLastRecursively):
(WebInspector.CanvasProfileView.prototype._appendCallNodes):
(WebInspector.CanvasProfileView.prototype.):
(WebInspector.CanvasProfileView.prototype.splitDrawCallGroup):
(WebInspector.CanvasProfileView.prototype._appendCallNodesToFrameNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143595 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[EFL] Unreviewed gardening.
mikhail.pozdnyakov@intel.com [Thu, 21 Feb 2013 14:13:46 +0000 (14:13 +0000)]
[EFL] Unreviewed gardening.

* platform/efl/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
* platform/efl/fast/js/global-constructors-expected.txt: Ditto.
* platform/efl/TestExpectations: Added editing/spelling/spelling-changed-text.html after r143470.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143594 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Web Inspector: Local/session storage tree items in the Resources...
apavlov@chromium.org [Thu, 21 Feb 2013 14:08:29 +0000 (14:08 +0000)]
Source/WebCore: Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
Re-landing r143581 with a build fix for Windows.
https://bugs.webkit.org/show_bug.cgi?id=109572

Reviewed by Vsevolod Vlasov.

This is a complete rework of the DOMStorage domain of the Web Inspector protocol. The most notable changes:
- Session and local DOM storages are considered to implicitly exist for each SecurityOrigin in the page
  (previously, only those that were lazily created by DOMWindow would exist).
- Consequently, the addDOMStorage event is gone.
- StorageId is now an object rather than an opaque numeric identifier.
- DOM storage modifiers no longer return a boolean indicating if the operation was successful.
  Clients should rely on the returned error message instead.

Implementation changes:
- InspectorDOMStorageResource would rely on the frame for which it was created throughout its lifetime.
  As such, the frame removal from the page would break the respective DOM storage inspection.
  Since this concept was entirely flawed, InspectorDOMStorageResource has been removed. Instead, a StorageArea
  is retrieved based on the security origin specified by the client.
- DOM storages can now be dynamically removed (upon the respective SecurityOrigin removal) in the frontend.

* CMakeLists.txt: Remove InspectorDOMStorageResource.
* GNUmakefile.list.am: Ditto.
* Target.pri: Ditto.
* WebCore.gypi: Ditto.
* WebCore.order: Ditto.
* WebCore.vcproj/WebCore.vcproj: Ditto.
* WebCore.vcxproj/WebCore.vcxproj: Ditto.
* WebCore.vcxproj/WebCore.vcxproj.filters: Ditto.
* WebCore.xcodeproj/project.pbxproj: Ditto.
* dom/WebCoreMemoryInstrumentation.cpp: Ditto.
* dom/WebCoreMemoryInstrumentation.h: Ditto.
* inspector/InjectedScriptSource.js: Account for the structured StorageId.
* inspector/Inspector.json: Update structures and API methods.
  Do not return boolean success flag and make use of the error message instead.
* inspector/InspectorAllInOne.cpp: Remove InspectorDOMStorageResource.
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController): Add InspectorPageAgent into InspectorDOMStorageAgent.
* inspector/InspectorDOMStorageAgent.cpp: Mostly remove InspectorDOMStorageResource usages.
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::isEnabled):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems): Renamed.
(WebCore::toErrorString): Stringify ExceptionCode.
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId): Make it structured rather than a plain string.
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::findStorageArea): Added.
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage): Remove InspectorDOMStorageResource map.
* inspector/InspectorDOMStorageAgent.h:
(WebCore::InspectorDOMStorageAgent::create): Update signature.
(InspectorDOMStorageAgent):
* inspector/InspectorDOMStorageResource.cpp: Removed.
* inspector/InspectorDOMStorageResource.h: Removed.
* inspector/InspectorInstrumentation.cpp:
(WebCore::InspectorInstrumentation::didCommitLoadImpl): Do not call the removed clearResources().
* inspector/InspectorInstrumentation.h:
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin): Added.
* inspector/InspectorPageAgent.h:
(InspectorPageAgent):
* inspector/front-end/DOMStorage.js: Entirely reworked to use the SecurityOriginAdded/Removed events.
(WebInspector.DOMStorage):
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get securityOrigin):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
* inspector/front-end/DOMStorageItemsView.js: Rename Entries -> Items to avoid confusion.
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageItems):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageItems):
* inspector/front-end/ResourcesPanel.js: Follow the updated DOMStorage model.
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._domStorageRemoved):
(WebInspector.ResourcesPanel.prototype._populateDOMStorageTree):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
* page/DOMWindow.cpp: Remove instrumentation calls.
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

LayoutTests: Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
https://bugs.webkit.org/show_bug.cgi?id=109572

Reviewed by Vsevolod Vlasov.

* http/tests/inspector-enabled/dom-storage-open-expected.txt:
* http/tests/inspector-enabled/dom-storage-open.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143593 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Fix make distcheck.
carlosgc@webkit.org [Thu, 21 Feb 2013 13:50:05 +0000 (13:50 +0000)]
Unreviewed. Fix make distcheck.

Source/WebCore:

* GNUmakefile.list.am: Add missing files to compilation.

Source/WebKit/gtk:

* GNUmakefile.am: Add -DBUILDING_WEBKIT flags to introspection
scanner.

Source/WebKit2:

* GNUmakefile.am: Add -DBUILDING_WEBKIT flags to introspection
scanner.
* GNUmakefile.list.am: Add missing header to compilation and
remove one that no longer exists.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143591 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Element::getAttributeItem() no longer returns a mutable attribute
commit-queue@webkit.org [Thu, 21 Feb 2013 13:10:25 +0000 (13:10 +0000)]
[BlackBerry] Element::getAttributeItem() no longer returns a mutable attribute
https://bugs.webkit.org/show_bug.cgi?id=110439

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Antonio Gomes.

This was changed in r142827.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143590 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Fix access to ResourceHandle::context
commit-queue@webkit.org [Thu, 21 Feb 2013 12:40:22 +0000 (12:40 +0000)]
[BlackBerry] Fix access to ResourceHandle::context
https://bugs.webkit.org/show_bug.cgi?id=110443

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.

This changed in r141981.

* platform/network/blackberry/ResourceHandleBlackBerry.cpp:
(WebCore::ResourceHandle::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143589 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Replace QWebPageAdaptor::TouchAdjuster
allan.jensen@digia.com [Thu, 21 Feb 2013 12:39:47 +0000 (12:39 +0000)]
[Qt] Replace QWebPageAdaptor::TouchAdjuster
https://bugs.webkit.org/show_bug.cgi?id=110226

Reviewed by Antonio Gomes.

* WebCoreSupport/QWebPageAdapter.cpp:
(QWebPageAdapter::adjustPointForClicking):
* WebCoreSupport/QWebPageAdapter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143588 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] GraphicsLayerBlackBerry: rename showDebugBorder to isShowingDebugBorder
commit-queue@webkit.org [Thu, 21 Feb 2013 12:38:50 +0000 (12:38 +0000)]
[BlackBerry] GraphicsLayerBlackBerry: rename showDebugBorder to isShowingDebugBorder
https://bugs.webkit.org/show_bug.cgi?id=110453

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.

This changed in r133517.

* platform/graphics/blackberry/GraphicsLayerBlackBerry.cpp:
(WebCore::GraphicsLayerBlackBerry::setupContentsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143587 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: take large strings out of CodeGeneratorInspector.py
commit-queue@webkit.org [Thu, 21 Feb 2013 12:37:46 +0000 (12:37 +0000)]
Web Inspector: take large strings out of CodeGeneratorInspector.py
https://bugs.webkit.org/show_bug.cgi?id=110159

Patch by Peter Rybin <prybin@chromium.org> on 2013-02-21
Reviewed by Yury Semikhatsky.

Python script is refactored.

* inspector/CodeGeneratorInspector.py:
* inspector/CodeGeneratorInspectorStrings.py: Added.
(InspectorFrontend_h):
(InspectorFrontendChannel):
(InspectorArray):
(InspectorObject):
(String):
(InspectorFrontend):
(InspectorBackendDispatcher_h):
(InspectorAgent):
(InspectorBackendDispatcherImpl):
(InspectorBackendDispatcher):
(CallbackBase):
(void):
(HashMap):
(OptOutput):
(ExactlyInt):
(RuntimeCastHelper):
(provides):
(typename):
(Array):
(Builder):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143586 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r143581.
commit-queue@webkit.org [Thu, 21 Feb 2013 12:29:42 +0000 (12:29 +0000)]
Unreviewed, rolling out r143581.
http://trac.webkit.org/changeset/143581
https://bugs.webkit.org/show_bug.cgi?id=110457

Breaks Windows builds (compile + link) (Requested by apavlov
on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-21

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::restore):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageEntries):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::getDOMStorageResourceForId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::clearResources):
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
* inspector/InspectorDOMStorageAgent.h:
(WebCore):
(WebCore::InspectorDOMStorageAgent::create):
(InspectorDOMStorageAgent):
* inspector/InspectorDOMStorageResource.cpp: Added.
(WebCore):
(WebCore::InspectorDOMStorageResource::InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::isSameOriginAndType):
(WebCore::InspectorDOMStorageResource::bind):
(WebCore::InspectorDOMStorageResource::unbind):
(WebCore::InspectorDOMStorageResource::reportMemoryUsage):
* inspector/InspectorDOMStorageResource.h: Added.
(WebCore):
(InspectorDOMStorageResource):
(WebCore::InspectorDOMStorageResource::create):
(WebCore::InspectorDOMStorageResource::id):
(WebCore::InspectorDOMStorageResource::storageArea):
(WebCore::InspectorDOMStorageResource::frame):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
(WebCore::InspectorInstrumentation::didUseDOMStorageImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didUseDOMStorage):
(WebCore):
* inspector/InspectorPageAgent.cpp:
* inspector/InspectorPageAgent.h:
(InspectorPageAgent):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get domain):
(WebInspector.DOMStorage.prototype.getEntries):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._addDOMStorage):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
(WebInspector.DOMStorageDispatcher.prototype.addDOMStorage):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageEntries):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageEntries):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._addDOMStorage):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

LayoutTests:

* http/tests/inspector-enabled/dom-storage-open-expected.txt:
* http/tests/inspector-enabled/dom-storage-open.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143585 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] willComposite() and didComposite() are now in InspectorController
commit-queue@webkit.org [Thu, 21 Feb 2013 12:26:45 +0000 (12:26 +0000)]
[BlackBerry] willComposite() and didComposite() are now in InspectorController
https://bugs.webkit.org/show_bug.cgi?id=110343

Patch by Alberto Garcia <albgarcia@rim.com> on 2013-02-21
Reviewed by Carlos Garcia Campos.

This was changed in r142879.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::willComposite):
(BlackBerry::WebKit::WebPagePrivate::didComposite):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143584 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Get rid of parsedURL in uiSourceCode, use name and path for displayNam...
vsevik@chromium.org [Thu, 21 Feb 2013 12:09:38 +0000 (12:09 +0000)]
Web Inspector: Get rid of parsedURL in uiSourceCode, use name and path for displayName instead.
https://bugs.webkit.org/show_bug.cgi?id=110335

Reviewed by Alexander Pavlov.

Source/WebCore:

Replaced UISourceCode.parsedURL with UISourceCode.displayName().

* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._updateScriptTitle):
(WebInspector.NavigatorView.prototype.getOrCreateFolderTreeElement):
(WebInspector.NavigatorFolderTreeElement):
* inspector/front-end/ResourceUtils.js:
(WebInspector.displayNameForURL):
* inspector/front-end/RevisionHistoryView.js:
(WebInspector.RevisionHistoryView.prototype._createUISourceCodeItem):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode):
(WebInspector.UISourceCode.prototype.displayName):
(WebInspector.UISourceCode.prototype.urlChanged):

Source/WebKit/chromium:

* src/js/Tests.js:
(.TestSuite.prototype._scriptsAreParsed):

LayoutTests:

* http/tests/inspector-enabled/dynamic-scripts.html:
* http/tests/inspector/debugger-test.js:
(initialize_DebuggerTest):
* inspector/debugger/dynamic-scripts.html:
* inspector/debugger/scripts-file-selector-expected.txt:
* inspector/debugger/source-url-comment.html:
* inspector/styles/edit-inspector-stylesheet.html:
* inspector/styles/styles-add-new-rule.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143583 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[WK2][EFL] Move PageViewportController and PageViewportControllerClientEfl out from...
mikhail.pozdnyakov@intel.com [Thu, 21 Feb 2013 11:58:51 +0000 (11:58 +0000)]
[WK2][EFL] Move PageViewportController and PageViewportControllerClientEfl out from WebView
https://bugs.webkit.org/show_bug.cgi?id=110345

Reviewed by Andreas Kling.

WebView does not need to know about both PageViewportController and
PageViewportControllerClientEfl. Considering the fact that PageViewportController
will stop being WK2 internal and will be based on WK2 C API, it
should be owned by EwkView rather than WebView.

This patch is also a preparation for WKViewClient API extension to cover all
the places where PageViewportController and PageViewportControllerClientEfl
are accessed directly from WebView at the moment.

* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
* UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView::pageViewportControllerClient):
(EwkView::pageViewportController):
(EwkView):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeContentsSize):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):
* UIProcess/efl/WebView.h:
(WebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143582 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Local/session storage tree items in the Resources panel after page...
apavlov@chromium.org [Thu, 21 Feb 2013 11:57:00 +0000 (11:57 +0000)]
Web Inspector: Local/session storage tree items in the Resources panel after page refresh are not shown
https://bugs.webkit.org/show_bug.cgi?id=109572

Reviewed by Vsevolod Vlasov.

Source/WebCore:

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.order:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* dom/WebCoreMemoryInstrumentation.cpp:
(WebCore):
* dom/WebCoreMemoryInstrumentation.h:
(WebCoreMemoryTypes):
* inspector/InjectedScriptSource.js:
(.):
* inspector/Inspector.json:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::InspectorDOMStorageAgent):
(WebCore::InspectorDOMStorageAgent::clearFrontend):
(WebCore::InspectorDOMStorageAgent::isEnabled):
(WebCore::InspectorDOMStorageAgent::enable):
(WebCore::InspectorDOMStorageAgent::disable):
(WebCore::InspectorDOMStorageAgent::getDOMStorageItems):
(WebCore::toErrorString):
(WebCore::InspectorDOMStorageAgent::setDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::removeDOMStorageItem):
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didDispatchDOMStorageEvent):
(WebCore::InspectorDOMStorageAgent::findStorageArea):
(WebCore::InspectorDOMStorageAgent::reportMemoryUsage):
* inspector/InspectorDOMStorageAgent.h:
(WebCore):
(WebCore::InspectorDOMStorageAgent::create):
(InspectorDOMStorageAgent):
* inspector/InspectorDOMStorageResource.cpp: Removed.
* inspector/InspectorDOMStorageResource.h: Removed.
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
* inspector/InspectorPageAgent.cpp:
(WebCore::InspectorPageAgent::findFrameWithSecurityOrigin):
(WebCore):
* inspector/InspectorPageAgent.h:
(InspectorPageAgent):
* inspector/front-end/DOMStorage.js:
(WebInspector.DOMStorage):
(WebInspector.DOMStorage.storageId):
(WebInspector.DOMStorage.prototype.get id):
(WebInspector.DOMStorage.prototype.get securityOrigin):
(WebInspector.DOMStorage.prototype.getItems):
(WebInspector.DOMStorage.prototype.setItem):
(WebInspector.DOMStorage.prototype.removeItem):
(WebInspector.DOMStorageModel):
(WebInspector.DOMStorageModel.prototype._securityOriginAdded):
(WebInspector.DOMStorageModel.prototype._securityOriginRemoved):
(WebInspector.DOMStorageModel.prototype._storageKey):
(WebInspector.DOMStorageModel.prototype._domStorageItemsCleared):
(WebInspector.DOMStorageModel.prototype._domStorageItemRemoved):
(WebInspector.DOMStorageModel.prototype._domStorageItemAdded):
(WebInspector.DOMStorageModel.prototype.storageForId):
(WebInspector.DOMStorageModel.prototype.storages):
* inspector/front-end/DOMStorageItemsView.js:
(WebInspector.DOMStorageItemsView.prototype._update):
(WebInspector.DOMStorageItemsView.prototype._showDOMStorageItems):
(WebInspector.DOMStorageItemsView.prototype._dataGridForDOMStorageItems):
* inspector/front-end/ResourcesPanel.js:
(WebInspector.ResourcesPanel):
(WebInspector.ResourcesPanel.prototype._initialize):
(WebInspector.ResourcesPanel.prototype._domStorageAdded):
(WebInspector.ResourcesPanel.prototype._domStorageRemoved):
(WebInspector.ResourcesPanel.prototype._populateDOMStorageTree):
(WebInspector.DOMStorageTreeElement):
(WebInspector.DOMStorageTreeElement.prototype.get itemURL):
* page/DOMWindow.cpp:
(WebCore::DOMWindow::sessionStorage):
(WebCore::DOMWindow::localStorage):

LayoutTests:

* http/tests/inspector-enabled/dom-storage-open-expected.txt:
* http/tests/inspector-enabled/dom-storage-open.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143581 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: [Console] Add console API message types for profile/profileEnd.
eustas@chromium.org [Thu, 21 Feb 2013 11:39:17 +0000 (11:39 +0000)]
Web Inspector: [Console] Add console API message types for profile/profileEnd.
https://bugs.webkit.org/show_bug.cgi?id=109790

Reviewed by Pavel Feldman.

With profile/profileEnd message types we will gain more control over
output messages.

* English.lproj/localizedStrings.js: Added corresponging strings.
* inspector/ConsoleAPITypes.h: Added enum members.
* inspector/Inspector.json: Ditto.
* inspector/front-end/ConsoleModel.js: Ditto.
* inspector/ConsoleMessage.cpp:
(WebCore::messageTypeValue): Added cases.
* inspector/InspectorProfilerAgent.cpp: Adopted changes.
* inspector/front-end/inspector.js: Ditto.
* inspector/front-end/ConsoleMessage.js:
Added message generators for introduced message types.
* inspector/front-end/ProfilesPanel.js:
Turned showProfileForURL(url) to showProfile(typeId, uid).
* inspector/front-end/ProfilesPanelDescriptor.js:
(WebInspector.ProfilesPanelDescriptor.resolveProfileTitle): Added.
* inspector/front-end/ResourceUtils.js: Removed linkifier plugins.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143580 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening.
zarvai@inf.u-szeged.hu [Thu, 21 Feb 2013 10:44:04 +0000 (10:44 +0000)]
[Qt] Unreviewed gardening.

* platform/qt-5.0-wk2/TestExpectations: Skip failing reftests.
* platform/qt/TestExpectations: Skip failing tests after r143541 and r110447.
* platform/qt/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
* platform/qt/fast/js/global-constructors-expected.txt: Rebaselining after r143505.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143579 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoOpenCL implementation of FEMerge filter.
commit-queue@webkit.org [Thu, 21 Feb 2013 10:43:03 +0000 (10:43 +0000)]
OpenCL implementation of FEMerge filter.
https://bugs.webkit.org/show_bug.cgi?id=110193

Patch by Tamas Czene <tczene@inf.u-szeged.hu> on 2013-02-21
Reviewed by Zoltan Herczeg.

In case of odd number of parameters the first parameter is copied to the destination image and
the rest of the parameters are merged in pairs.

* Target.pri:
* platform/graphics/filters/FEMerge.h:
(FEMerge):
* platform/graphics/gpu/opencl/FilterContextOpenCL.h:
(WebCore::FilterContextOpenCL::FilterContextOpenCL):
(FilterContextOpenCL):
* platform/graphics/gpu/opencl/OpenCLFEMerge.cpp: Added.
(WebCore):
(WebCore::FilterContextOpenCL::compileFEMerge):
(WebCore::FilterContextOpenCL::copy): This is a simple copy method.
(WebCore::FilterContextOpenCL::applyFEMerge):
(WebCore::FEMerge::platformApplyOpenCL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143578 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed GTK gardening.
zandobersek@gmail.com [Thu, 21 Feb 2013 10:26:48 +0000 (10:26 +0000)]
Unreviewed GTK gardening.

* platform/gtk/TestExpectations: Adding failure expectations for tests introduced in r143470 and r143541.
* platform/gtk/fast/dom/constructed-objects-prototypes-expected.txt: Rebaselining after r143505.
* platform/gtk/fast/js/global-constructors-expected.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143577 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd event dispatch class for the new calendar picker
keishi@webkit.org [Thu, 21 Feb 2013 10:16:32 +0000 (10:16 +0000)]
Add event dispatch class for the new calendar picker
https://bugs.webkit.org/show_bug.cgi?id=110131

Reviewed by Kent Tamura.

Adding event dispatcher class as part of the new calendar picker patch at Bug 109439.

No new tests. Code is not yet used.

* Resources/pagepopups/calendarPicker.js:
(EventEmitter):
(EventEmitter.prototype.on): Adds a callback for an event.
(EventEmitter.prototype.hasListener): Returns true if more than one listeners exist for an event type.
(EventEmitter.prototype.removeListener): Removes an event listener.
(EventEmitter.prototype.dispatchEvent): Dispatches an event to all callbacks. Takes variable number of arguments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143576 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Unreviewed gardening. Skipped failing inpector tests after r143300.
kadam@inf.u-szeged.hu [Thu, 21 Feb 2013 10:09:15 +0000 (10:09 +0000)]
[Qt] Unreviewed gardening. Skipped failing inpector tests after r143300.
https://bugs.webkit.org/show_bug.cgi?id=110440.

* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143575 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: Add command for selecting files for file input element
commit-queue@webkit.org [Thu, 21 Feb 2013 09:18:19 +0000 (09:18 +0000)]
Web Inspector: Add command for selecting files for file input element
https://bugs.webkit.org/show_bug.cgi?id=109308

Patch by Ken Kania <kkania@chromium.org> on 2013-02-21
Reviewed by Pavel Feldman.

Source/WebCore:

Test: inspector-protocol/dom/setFileInputFiles.html

* inspector/Inspector.json:
* inspector/InspectorClient.h:
(WebCore::InspectorClient::canSetFileInputFiles):
(InspectorClient):
* inspector/InspectorController.cpp:
(WebCore::InspectorController::InspectorController):
* inspector/InspectorDOMAgent.cpp:
(WebCore::InspectorDOMAgent::InspectorDOMAgent):
(WebCore::InspectorDOMAgent::setFileInputFiles):
(WebCore):
* inspector/InspectorDOMAgent.h:
(WebCore):
(WebCore::InspectorDOMAgent::create):
(InspectorDOMAgent):

Source/WebKit/chromium:

* src/InspectorClientImpl.cpp:
(WebKit::InspectorClientImpl::canSetFileInputFiles):
(WebKit):
* src/InspectorClientImpl.h:
(InspectorClientImpl):

LayoutTests:

* inspector-protocol/dom/setFileInputFiles-expected.txt: Added.
* inspector-protocol/dom/setFileInputFiles.html: Added.
* platform/chromium/inspector-protocol/dom/setFileInputFiles-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143574 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: [Web Inspector]Add WebSocket networking events in Timeline panel.
commit-queue@webkit.org [Thu, 21 Feb 2013 09:04:02 +0000 (09:04 +0000)]
Source/WebCore: [Web Inspector]Add WebSocket networking events in Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=105527.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-21
Reviewed by Pavel Feldman.

This patch add four WebSocket networking events in Timeline panel. The Events
are CreateWebSocket, SendWebSocketHandshakeRequest, ReceiveWebSocketHandShakeResponse
and DestoryWebSocket. Thanks to Kitamura san's previous work.

Test: http/tests/inspector/websocket/timeline-websocket-event.html

* English.lproj/localizedStrings.js:
* Modules/websockets/WebSocketChannel.cpp: Add protocol information
(WebCore::WebSocketChannel::connect):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCreateWebSocketImpl): Add Timeline agent instrumentation for websocket
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequestImpl): Ditto
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponseImpl): Ditto
(WebCore::InspectorInstrumentation::didCloseWebSocketImpl): Ditto
* inspector/InspectorInstrumentation.h:
(InspectorInstrumentation):
(WebCore::InspectorInstrumentation::didCreateWebSocket):
(WebCore::InspectorInstrumentation::willSendWebSocketHandshakeRequest):
(WebCore::InspectorInstrumentation::didReceiveWebSocketHandshakeResponse):
(WebCore::InspectorInstrumentation::didCloseWebSocket):
* inspector/InspectorTimelineAgent.cpp:
(TimelineRecordType):
(WebCore):
(WebCore::InspectorTimelineAgent::didCreateWebSocket): Add Timeline record for websocket create
(WebCore::InspectorTimelineAgent::addWebSocketRecord): Add general websocket record
(WebCore::InspectorTimelineAgent::willSendWebSocketHandshakeRequest): Add Timeline record for websocket handshake request send
(WebCore::InspectorTimelineAgent::didReceiveWebSocketHandshakeResponse): Add Timeline record for websocket handshake response receive
(WebCore::InspectorTimelineAgent::didDestroyWebSocket): Add Timeline record for websocket destroy
* inspector/InspectorTimelineAgent.h:
(WebCore):
(InspectorTimelineAgent):
* inspector/TimelineRecordFactory.h:
(TimelineRecordFactory):
(WebCore::TimelineRecordFactory::createWebSocketCreateData):
(WebCore::TimelineRecordFactory::createGenericWebSocketData):
* inspector/front-end/TimelineModel.js: Add Timeline record type for websocket
* inspector/front-end/TimelinePresentationModel.js:
(WebInspector.TimelinePresentationModel._initRecordStyles):
(WebInspector.TimelinePresentationModel.prototype.reset): Add slot to store WebSocket Create record
(WebInspector.TimelinePresentationModel.Record):
(WebInspector.TimelinePresentationModel.Record.prototype._generatePopupContentWithImagePreview): Add PopupContent for websocket record, including url and protocol

LayoutTests: [Web Inspector]Add WebSocket networking events in WebInspector Timeline panel.
https://bugs.webkit.org/show_bug.cgi?id=105527.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-21
Reviewed by Pavel Feldman.

This change add the record event type to test expections. The Events are CreateWebSocket,
SendWebSocketHandshakeRequest, ReceiveWebSocketHandShakeResponse and DestoryWebSocket.
timeline-test.js was moved to http folder, since new added websocket test need it from server side.

* http/tests/inspector/timeline-test.js: Renamed from LayoutTests/inspector/timeline/timeline-test.js.
(initialize_Timeline.InspectorTest.startTimeline.addRecord):
(initialize_Timeline.InspectorTest.startTimeline):
(initialize_Timeline.addRecord):
(initialize_Timeline.InspectorTest.waitForRecordType):
(initialize_Timeline.InspectorTest.stopTimeline):
(initialize_Timeline.step1):
(initialize_Timeline.step2):
(initialize_Timeline.InspectorTest.evaluateWithTimeline):
(initialize_Timeline.):
(initialize_Timeline.InspectorTest.performActionsAndPrint):
(initialize_Timeline.InspectorTest.printTimelineRecords):
(initialize_Timeline.InspectorTest.printTimestampRecords):
(initialize_Timeline.InspectorTest.innerPrintTimelineRecords):
(initialize_Timeline.InspectorTest.dumpTimelineRecord):
(initialize_Timeline.InspectorTest.dumpTimelineRecords):
(initialize_Timeline.InspectorTest.printTimelineRecordProperties):
(initialize_Timeline.InspectorTest._timelineAgentTypeToString):
(initialize_Timeline.InspectorTest.findPresentationRecord.findByType):
(initialize_Timeline.InspectorTest.findPresentationRecord):
(initialize_Timeline.InspectorTest.FakeFileReader):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.start):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.cancel):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.loadedSize):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.fileSize):
(initialize_Timeline.InspectorTest.FakeFileReader.prototype.fileName):
(initialize_Timeline.InspectorTest):
(initialize_Timeline):
* http/tests/inspector/websocket/timeline-websocket-event-expected.txt: Added.
* http/tests/inspector/websocket/timeline-websocket-event.html: Added.
* inspector/timeline/timeline-animation-frame.html: Modify address of script "timeline-test.js"
* inspector/timeline/timeline-decode-resize.html:
* inspector/timeline/timeline-dom-content-loaded-event.html:
* inspector/timeline/timeline-enum-stability-expected.txt:
* inspector/timeline/timeline-event-dispatch.html:
* inspector/timeline/timeline-frames.html:
* inspector/timeline/timeline-injected-script-eval.html:
* inspector/timeline/timeline-layout-reason.html:
* inspector/timeline/timeline-layout.html:
* inspector/timeline/timeline-load-event.html:
* inspector/timeline/timeline-load.html:
* inspector/timeline/timeline-mark-timeline.html:
* inspector/timeline/timeline-network-received-data.html:
* inspector/timeline/timeline-network-resource.html:
* inspector/timeline/timeline-paint.html:
* inspector/timeline/timeline-parse-html.html:
* inspector/timeline/timeline-recalculate-styles.html:
* inspector/timeline/timeline-receive-response-event.html:
* inspector/timeline/timeline-script-tag-1.html:
* inspector/timeline/timeline-script-tag-2.html:
* inspector/timeline/timeline-start-time.html:
* inspector/timeline/timeline-time-stamp.html:
* inspector/timeline/timeline-time.html:
* inspector/timeline/timeline-timer-fired-from-eval-call-site.html:
* inspector/timeline/timeline-timer.html:
* inspector/timeline/timeline-trivial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143573 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Remove obsolete DEPENDPATH assignment
hausmann@webkit.org [Thu, 21 Feb 2013 09:03:59 +0000 (09:03 +0000)]
[Qt] Remove obsolete DEPENDPATH assignment

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2013-02-21
Reviewed by Simon Hausmann

qmake now adds CONFIG+=depend_includepath by default, making manual
DEPENDPATH setup unnecessary.

* qmake/mkspecs/features/default_post.prf:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143572 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Qt] Fix pkg-config dependencies of QtWebKit itself
hausmann@webkit.org [Thu, 21 Feb 2013 09:01:38 +0000 (09:01 +0000)]
[Qt] Fix pkg-config dependencies of QtWebKit itself

Patch by Oswald Buddenhagen <oswald.buddenhagen@digia.com> on 2013-02-21
Reviewed by Simon Hausmann.

Don't override QMAKE_PKGCONFIG_REQUIRES needlessly.

* WebCore.pri:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143571 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoFile upload control doesn't apply CSS vertical padding or border to file name
commit-queue@webkit.org [Thu, 21 Feb 2013 09:00:07 +0000 (09:00 +0000)]
File upload control doesn't apply CSS vertical padding or border to file name
https://bugs.webkit.org/show_bug.cgi?id=109011

Patch by Nils Barth <nbarth@google.com> on 2013-02-21
Reviewed by Hajime Morrita.

Source/WebCore:

Test: fast/forms/file/file-vertical-padding-border.html

* rendering/RenderFileUploadControl.cpp:
    Add borderTop() and paddingTop() when computing position.
(WebCore::RenderFileUploadControl::paintObject):

LayoutTests:

* fast/forms/file/file-vertical-padding-border.html: Added.
* fast/forms/file/file-vertical-padding-border-expected.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143570 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago Stop hardcoding knowledge about blob protocol in ResourceHandle
ap@apple.com [Thu, 21 Feb 2013 08:27:10 +0000 (08:27 +0000)]
    Stop hardcoding knowledge about blob protocol in ResourceHandle
        https://bugs.webkit.org/show_bug.cgi?id=110382

        Reviewed by Anders Carlsson.

        * platform/network/BlobRegistry.h:
        * platform/network/chromium/BlobRegistryProxy.h:
        Removed loadResourceSynchronously(). Chromium did not even implement it, and
        cross-platform code doesn't need it any more either.

        * platform/network/BlobRegistryImpl.cpp:
        (WebCore::loadResourceSynchronously): A function to load a blob synchronously,
        suitable for being in a ResourceHandle map.
        (WebCore::registerBlobResourceHandleConstructor): Register loadResourceSynchronously too.
        (WebCore::BlobRegistryImpl::createResourceHandle): Don't make policy decisions here,
        it's just a registry. Moved code for checking request method down to BlobResourceHandle.

        * platform/network/BlobRegistryImpl.h: Removed BlobRegistryImpl::loadResourceSynchronously().
        A registry shouldn't load resources, and it already has enough accessors to implement
        this externally.

        * platform/network/BlobResourceHandle.h:
        * platform/network/BlobResourceHandle.cpp:
        (WebCore::BlobResourceHandle::createAsync): Renamed from create(), to make it clear
        that it's not OK to call from synchronous loader. Moved method check here.
        (WebCore::BlobResourceHandle::loadResourceSynchronously): Moved method check here.
        We used to fall through to NSURLConnection based loader when method was not GET,
        which of course resulted in an error eventually, but was just wrong.

        * platform/network/ResourceHandle.cpp:
        (WebCore::builtinResourceHandleSynchronousLoaderMap): Added a map for synchronous case.
        (WebCore::ResourceHandle::registerBuiltinSynchronousLoader): Ditto.
        (WebCore::ResourceHandle::loadResourceSynchronously): We no longer need to hardcode
        knowledge about blobRegistry and blobs here.

        * platform/network/ResourceHandle.h: Added registerBuiltinSynchronousLoader().

        * platform/network/chromium/ResourceHandle.h: Removed loadResourceSynchronously(),
        which was not implemented for Chromium.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143569 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: TabbedEditorContainer and OpenResourceDialog should show uiSourceCode...
vsevik@chromium.org [Thu, 21 Feb 2013 07:53:49 +0000 (07:53 +0000)]
Web Inspector: TabbedEditorContainer and OpenResourceDialog should show uiSourceCode path and name instead of parsedURL
https://bugs.webkit.org/show_bug.cgi?id=110334

Reviewed by Alexander Pavlov.

Source/WebCore:

Introduced uiSourceCode.name() that returns a name based on uiSourceCode path.
OpenResourceDialog now shows uiSourceCode workspace path as a subtitle.
TabbedEditorContainer now shows uiSourceCode name in the tab header.

* inspector/front-end/FilteredItemSelectionDialog.js:
(WebInspector.OpenResourceDialog.filterOutEmptyURLs):
(WebInspector.OpenResourceDialog):
(WebInspector.OpenResourceDialog.prototype.itemTitleAt):
(WebInspector.OpenResourceDialog.prototype.itemSubtitleAt):
(WebInspector.OpenResourceDialog.prototype.itemKeyAt):
* inspector/front-end/NavigatorView.js:
(WebInspector.NavigatorView.prototype._updateScriptTitle):
* inspector/front-end/TabbedEditorContainer.js:
(WebInspector.TabbedEditorContainer.prototype._titleForFile):
* inspector/front-end/UISourceCode.js:
(WebInspector.UISourceCode.prototype.name):

LayoutTests:

* inspector/debugger/scripts-file-selector-expected.txt:
* inspector/debugger/ui-source-code-display-name-expected.txt:
* inspector/debugger/ui-source-code-display-name.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143568 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWeb Inspector: debugger buttons are scrolled along with the sidebar content.
pfeldman@chromium.org [Thu, 21 Feb 2013 07:33:23 +0000 (07:33 +0000)]
Web Inspector: debugger buttons are scrolled along with the sidebar content.
https://bugs.webkit.org/show_bug.cgi?id=110434

Reviewed by Vsevolod Vlasov.

* inspector/front-end/scriptsPanel.css:
(div.sidebar-pane-stack#scripts-debug-sidebar-contents, #scripts-sidebar-stack-pane):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143567 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoChannelMergerNode may need check for deferred updating of output channels
james.wei@intel.com [Thu, 21 Feb 2013 06:34:16 +0000 (06:34 +0000)]
ChannelMergerNode may need check for deferred updating of output channels
https://bugs.webkit.org/show_bug.cgi?id=108863

There can in rare cases be a slight delay before the output bus is updated
to the new number of channels because of tryLocks() in the context's
updating system. So need to check the channel number before processing.

Reviewed by Chris Rogers.

* Modules/webaudio/ChannelMergerNode.cpp:
(WebCore::ChannelMergerNode::ChannelMergerNode):
(WebCore::ChannelMergerNode::process):
(WebCore::ChannelMergerNode::checkNumberOfChannelsForInput):
* Modules/webaudio/ChannelMergerNode.h:
(ChannelMergerNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143565 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Web Inspector] Fix Sort by Initiator functionality of Network Panel.
commit-queue@webkit.org [Thu, 21 Feb 2013 06:26:04 +0000 (06:26 +0000)]
[Web Inspector] Fix Sort by Initiator functionality of Network Panel.
https://bugs.webkit.org/show_bug.cgi?id=109135.

Patch by Pan Deng <pan.deng@intel.com> on 2013-02-20
Reviewed by Pavel Feldman.

A refactor for request initiator types, and the sort by Initiator functionality
was changed to sort by url and line number that displayed in initiator cell.

No new tests.

* inspector/front-end/NetworkPanel.js:
(WebInspector.NetworkDataGridNode.prototype._refreshInitiatorCell): save initiator displayedURL and displayedLineNumber
(WebInspector.NetworkDataGridNode.InitiatorComparator):
* inspector/front-end/NetworkRequest.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143564 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoWebVTTParser copies character buffer more often than necessary
eric@webkit.org [Thu, 21 Feb 2013 05:36:42 +0000 (05:36 +0000)]
WebVTTParser copies character buffer more often than necessary
https://bugs.webkit.org/show_bug.cgi?id=103319

Reviewed by Eric Carlson.

Previously this codepath was creating a String just to parse the timestamp
and then if the timestamp was valid, was creating a second string.
I've fixed it to only create one string and use it in both places.
I also fixed this codepath to use 8bit strings when possible, per the FIXME.

* html/track/WebVTTParser.cpp:
(WebCore::WebVTTParser::constructTreeFromToken):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143563 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG::SpeculativeJIT::compileInt32ToDouble() has an unnecessary case for constant...
fpizlo@apple.com [Thu, 21 Feb 2013 04:58:08 +0000 (04:58 +0000)]
DFG::SpeculativeJIT::compileInt32ToDouble() has an unnecessary case for constant operands
https://bugs.webkit.org/show_bug.cgi?id=110309

Reviewed by Sam Weinig.

It used to be necessary, back when we didn't have constant folding. Now we have
constant folding. So we don't need it.

* dfg/DFGSpeculativeJIT.cpp:
(JSC::DFG::SpeculativeJIT::compileInt32ToDouble):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143562 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Changing primary email id.
vivek.vg@samsung.com [Thu, 21 Feb 2013 04:38:03 +0000 (04:38 +0000)]
Unreviewed. Changing primary email id.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143561 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMouseup event does not fire on Scroll Bar
mkwst@chromium.org [Thu, 21 Feb 2013 04:21:32 +0000 (04:21 +0000)]
Mouseup event does not fire on Scroll Bar
https://bugs.webkit.org/show_bug.cgi?id=25811

Reviewed by Tony Chang.

Source/WebCore:

Currently, clicking on a scrollbar fires a mousedown event, but not a
mouseup event. This causes problems for code like jQuery UI's
draggable[1], as the drag starts, but is never cancelled. Other use
cases are noted in the slightly old Chromium bug[2].

If a mouseup event is received after a mousedown event on a scrollbar,
this patch dispatches a mouseup event on the same node the mousedown
event dispatched on. This matches Gecko's behavior.

[1]: http://bugs.jqueryui.com/ticket/6925
[2]: http://crbug.com/14204

Tests: fast/scrolling/scrollbar-mousedown-mouseup.html
       fast/scrolling/scrollbar-mousedown-move-mouseup.html

* page/EventHandler.cpp:
(WebCore::EventHandler::handleMouseReleaseEvent):
    If a mouseup event follow a mousedown event on a scrollbar,
    dispatch an event on the same node from which the mousedown event
    was triggered.

LayoutTests:

* fast/scrolling/scrollbar-mousedown-mouseup-expected.txt: Added.
* fast/scrolling/scrollbar-mousedown-mouseup.html: Added.
* fast/scrolling/scrollbar-mousedown-move-mouseup-expected.txt: Added.
* fast/scrolling/scrollbar-mousedown-move-mouseup.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143560 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening, update TestExpectations.
toyoshim@chromium.org [Thu, 21 Feb 2013 03:58:37 +0000 (03:58 +0000)]
Unreviewed gardening, update TestExpectations.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143559 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoProvide WKView SPI to defer telling the WebPageProxy and WebProcess about changes...
timothy_horton@apple.com [Thu, 21 Feb 2013 03:51:40 +0000 (03:51 +0000)]
Provide WKView SPI to defer telling the WebPageProxy and WebProcess about changes in the hosting window
https://bugs.webkit.org/show_bug.cgi?id=110415
<rdar://problem/13095405>

Reviewed by Simon Fraser.

* UIProcess/API/mac/WKView.mm: Add _viewInWindowChangesDeferredCount and _viewInWindowChangeWasDeferred to WKViewData.
(-[WKView viewDidMoveToWindow]): If we're deferring window changes, don't include the ViewIsInWindow flag
when sending viewStateDidChange. Instead, save the fact that we want to do that later aside.
(-[WKView beginDeferringViewInWindowChanges]):
(-[WKView endDeferringViewInWindowChanges]): Straightforward begin/end pair. When we exit the last pair and
have a pending window change, let the WebPageProxy know. WebPageProxy will do the check to ensure that
the in-window state has actually changed.
(-[WKView isDeferringViewInWindowChanges]):
* UIProcess/API/mac/WKViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143558 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed gardening, add chromium-mac specific expectation image.
toyoshim@chromium.org [Thu, 21 Feb 2013 03:50:51 +0000 (03:50 +0000)]
Unreviewed gardening, add chromium-mac specific expectation image.

* platform/chromium-mac/fast/repaint/paint-caret-in-div-with-negative-indent-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143557 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Refactoring] Make m_state an on-stack object
tasak@google.com [Thu, 21 Feb 2013 03:39:42 +0000 (03:39 +0000)]
[Refactoring] Make m_state an on-stack object
https://bugs.webkit.org/show_bug.cgi?id=109909

Reviewed by Antti Koivisto.

Mode m_state, an instance of StyleResolver::State, an on-stack object.
The state is only required in styleForElement, styleForKeyframe and
so on. No need to keep the state outside of those methods.

No new tests, because just refactoring.

* css/BasicShapeFunctions.cpp:
(WebCore::convertToLength):
(WebCore::basicShapeForValue):
* css/BasicShapeFunctions.h:
(WebCore):
Replaced StyleResolver* with StyleResolver::State&.
* css/CSSGradientValue.cpp:
(WebCore::CSSGradientValue::gradientWithStylesResolved):
* css/CSSGradientValue.h:
(CSSGradientValue):
Replaced StyleResolver* with StyleResolver::State&.
* css/CSSToStyleMap.cpp:
(WebCore::CSSToStyleMap::style):
(WebCore::CSSToStyleMap::rootElementStyle):
(WebCore::CSSToStyleMap::useSVGZoomRules):
(WebCore::CSSToStyleMap::styleImage):
* css/CSSToStyleMap.h:
(WebCore):
(WebCore::CSSToStyleMap::CSSToStyleMap):
(CSSToStyleMap):
Replaced StyleResolver* with StyleResolver::State&.
* css/SVGCSSStyleSelector.cpp:
(WebCore::StyleResolver::applySVGProperty):
Replaced m_state with state which is given as an argument of
applySVGProperty.
* css/StyleBuilder.cpp:
(WebCore::ApplyPropertyExpanding::applyInheritValue):
(WebCore::ApplyPropertyExpanding::applyInitialValue):
(WebCore::ApplyPropertyExpanding::applyValue):
(WebCore::ApplyPropertyDefaultBase::applyInheritValue):
(WebCore::ApplyPropertyDefaultBase::applyInitialValue):
(WebCore::ApplyPropertyDefaultBase::applyValue):
(WebCore::ApplyPropertyDefault::applyValue):
(WebCore::ApplyPropertyNumber::applyValue):
(WebCore::ApplyPropertyStyleImage::applyValue):
(WebCore::ApplyPropertyAuto::applyInheritValue):
(WebCore::ApplyPropertyAuto::applyInitialValue):
(WebCore::ApplyPropertyAuto::applyValue):
(WebCore::ApplyPropertyClip::convertToLength):
(WebCore::ApplyPropertyClip::applyInheritValue):
(WebCore::ApplyPropertyClip::applyInitialValue):
(WebCore::ApplyPropertyClip::applyValue):
(WebCore::ApplyPropertyColor::applyInheritValue):
(WebCore::ApplyPropertyColor::applyInitialValue):
(WebCore::ApplyPropertyColor::applyValue):
(WebCore::ApplyPropertyColor::applyColorValue):
(WebCore::ApplyPropertyDirection::applyValue):
(WebCore::ApplyPropertyLength::applyValue):
(WebCore::ApplyPropertyString::applyValue):
(WebCore::ApplyPropertyBorderRadius::applyValue):
(WebCore::ApplyPropertyFillLayer::applyInheritValue):
(WebCore::ApplyPropertyFillLayer::applyInitialValue):
(WebCore::ApplyPropertyFillLayer::applyValue):
(WebCore::ApplyPropertyComputeLength::applyValue):
(WebCore::ApplyPropertyFont::applyInheritValue):
(WebCore::ApplyPropertyFont::applyInitialValue):
(WebCore::ApplyPropertyFont::applyValue):
(WebCore::ApplyPropertyFontSize::applyInheritValue):
(WebCore::ApplyPropertyFontSize::applyInitialValue):
(WebCore::ApplyPropertyFontSize::applyValue):
(WebCore::ApplyPropertyFontWeight::applyValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInheritValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyInitialValue):
(WebCore::ApplyPropertyFontVariantLigatures::applyValue):
(WebCore::ApplyPropertyBorderImage::applyValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInheritValue):
(WebCore::ApplyPropertyBorderImageModifier::applyInitialValue):
(WebCore::ApplyPropertyBorderImageModifier::applyValue):
(WebCore::ApplyPropertyBorderImageSource::applyValue):
(WebCore::ApplyPropertyCounter::emptyFunction):
(WebCore::ApplyPropertyCounter::applyInheritValue):
(WebCore::ApplyPropertyCounter::applyValue):
(WebCore::ApplyPropertyCursor::applyInheritValue):
(WebCore::ApplyPropertyCursor::applyInitialValue):
(WebCore::ApplyPropertyCursor::applyValue):
(WebCore::ApplyPropertyTextAlign::applyValue):
(WebCore::ApplyPropertyTextDecoration::applyValue):
(WebCore::ApplyPropertyLineHeight::applyValue):
(WebCore::ApplyPropertyPageSize::applyInheritValue):
(WebCore::ApplyPropertyPageSize::applyInitialValue):
(WebCore::ApplyPropertyPageSize::applyValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInheritValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyInitialValue):
(WebCore::ApplyPropertyTextEmphasisStyle::applyValue):
(WebCore::ApplyPropertyAnimation::map):
(WebCore::ApplyPropertyAnimation::applyInheritValue):
(WebCore::ApplyPropertyAnimation::applyInitialValue):
(WebCore::ApplyPropertyAnimation::applyValue):
(WebCore::ApplyPropertyOutlineStyle::applyInheritValue):
(WebCore::ApplyPropertyOutlineStyle::applyInitialValue):
(WebCore::ApplyPropertyOutlineStyle::applyValue):
(WebCore::ApplyPropertyResize::applyValue):
(WebCore::ApplyPropertyVerticalAlign::applyValue):
(WebCore::ApplyPropertyAspectRatio::applyInheritValue):
(WebCore::ApplyPropertyAspectRatio::applyInitialValue):
(WebCore::ApplyPropertyAspectRatio::applyValue):
(WebCore::ApplyPropertyZoom::resetEffectiveZoom):
(WebCore::ApplyPropertyZoom::applyInheritValue):
(WebCore::ApplyPropertyZoom::applyInitialValue):
(WebCore::ApplyPropertyZoom::applyValue):
(WebCore::ApplyPropertyDisplay::isValidDisplayValue):
(WebCore::ApplyPropertyDisplay::applyInheritValue):
(WebCore::ApplyPropertyDisplay::applyInitialValue):
(WebCore::ApplyPropertyDisplay::applyValue):
(WebCore::ApplyPropertyClipPath::applyValue):
(WebCore::ApplyPropertyExclusionShape::applyValue):
(WebCore::ApplyPropertyImageResolution::applyInheritValue):
(WebCore::ApplyPropertyImageResolution::applyInitialValue):
(WebCore::ApplyPropertyImageResolution::applyValue):
* css/StyleBuilder.h:
(WebCore):
(PropertyHandler):
(WebCore::PropertyHandler::applyInheritValue):
(WebCore::PropertyHandler::applyInitialValue):
(WebCore::PropertyHandler::applyValue):
Replaced StyleResolver* with StyleResolver::State&.
* css/StyleResolver.cpp:
(WebCore):
(WebCore::StyleResolver::StyleResolver):
Removed m_styleMap. Now m_styleMap is an on-stack object.
(WebCore::StyleResolver::collectMatchingRules):
(WebCore::StyleResolver::collectMatchingRulesForRegion):
(WebCore::StyleResolver::sortAndTransferMatchedRules):
(WebCore::StyleResolver::matchScopedAuthorRules):
(WebCore::StyleResolver::styleSharingCandidateMatchesHostRules):
(WebCore::StyleResolver::matchHostRules):
(WebCore::StyleResolver::matchAuthorRules):
(WebCore::StyleResolver::matchUserRules):
(WebCore::StyleResolver::matchUARules):
(WebCore::StyleResolver::collectMatchingRulesForList):
(WebCore::StyleResolver::sortMatchedRules):
(WebCore::StyleResolver::matchAllRules):
(WebCore::StyleResolver::initElement):
(WebCore::StyleResolver::styleSharingCandidateMatchesRuleSet):
(WebCore::StyleResolver::canShareStyleWithControl):
(WebCore::StyleResolver::sharingCandidateHasIdenticalStyleAffectingAttributes):
(WebCore::StyleResolver::canShareStyleWithElement):
(WebCore::StyleResolver::findSiblingForStyleSharing):
(WebCore::StyleResolver::locateSharedStyle):
(WebCore::StyleResolver::styleForElement):
(WebCore::StyleResolver::styleForKeyframe):
(WebCore::StyleResolver::keyframeStylesForAnimation):
(WebCore::StyleResolver::pseudoStyleForElement):
(WebCore::StyleResolver::styleForPage):
(WebCore::StyleResolver::defaultStyleForElement):
(WebCore::StyleResolver::adjustRenderStyle):
(WebCore::StyleResolver::updateFont):
(WebCore::StyleResolver::pseudoStyleRulesForElement):
(WebCore::StyleResolver::ruleMatches):
(WebCore::StyleResolver::checkRegionSelector):
(WebCore::StyleResolver::applyProperties):
(WebCore::StyleResolver::applyMatchedProperties):
(WebCore::StyleResolver::isLeftPage):
(WebCore::StyleResolver::applyPropertyWithNullCheck):
(WebCore::StyleResolver::applyFontPropertyToStyle):
(WebCore::StyleResolver::resolveVariables):
(WebCore::StyleResolver::applyProperty):
(WebCore::StyleResolver::styleImage):
(WebCore::StyleResolver::cachedOrPendingFromValue):
(WebCore::StyleResolver::generatedOrPendingFromValue):
(WebCore::StyleResolver::setOrPendingFromValue):
(WebCore::StyleResolver::cursorOrPendingFromValue):
(WebCore::StyleResolver::checkForTextSizeAdjust):
(WebCore::StyleResolver::checkForZoomChange):
(WebCore::StyleResolver::checkForGenericFamilyChange):
(WebCore::StyleResolver::initializeFontStyle):
(WebCore::StyleResolver::setFontSize):
(WebCore::StyleResolver::colorFromPrimitiveValue):
(WebCore::StyleResolver::loadPendingSVGDocuments):
(WebCore::StyleResolver::styleShader):
(WebCore::StyleResolver::cachedOrPendingStyleShaderFromValue):
(WebCore::StyleResolver::loadPendingShaders):
(WebCore::StyleResolver::parseCustomFilterTransformParameter):
(WebCore::StyleResolver::parseCustomFilterParameter):
(WebCore::StyleResolver::parseCustomFilterParameterList):
(WebCore::StyleResolver::createCustomFilterOperationWithInlineSyntax):
(WebCore::StyleResolver::createCustomFilterOperation):
(WebCore::StyleResolver::createFilterOperations):
(WebCore::StyleResolver::loadPendingImage):
(WebCore::StyleResolver::loadPendingImages):
(WebCore::StyleResolver::loadPendingResources):
Just replaced m_state with state and added one more parameter to
provide the state.
(WebCore::StyleResolver::reportMemoryUsage):
Since m_state was removed, removed a code for reporting m_state's
memory usage.
* css/StyleResolver.h:
(StyleResolver):
(WebCore::StyleResolver::isRightPage):
(WebCore::StyleResolver::State::State):
(WebCore::StyleResolver::State::document):
Since State::m_element is not always available (sometimes, 0),
added m_document to State and modified to return the m_document.
(WebCore::StyleResolver::State::useSVGZoomRules):
Moved StyleResolver to State.
(State):
* html/canvas/CanvasRenderingContext2D.cpp:
(WebCore::CanvasRenderingContext2D::setFont):
Moved the code, updating a style by using a given StylePropertySet,
to StyleResolver.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143556 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAutoTableLayout applies min-width redundantly with RenderTable
ojan@chromium.org [Thu, 21 Feb 2013 03:26:10 +0000 (03:26 +0000)]
AutoTableLayout applies min-width redundantly with RenderTable
https://bugs.webkit.org/show_bug.cgi?id=110426

Reviewed by Emil A Eklund.

* rendering/AutoTableLayout.cpp:
(WebCore::AutoTableLayout::computePreferredLogicalWidths):
This code used to do something, but has since been superceded by
code in RenderTable::computePreferredLogicalWidths.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143555 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable CANVAS_PATH flag
krit@webkit.org [Thu, 21 Feb 2013 03:22:31 +0000 (03:22 +0000)]
Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508

Source/WebCore:

Uneviewed attempt to fix Qt minimal build.

* html/canvas/DOMPath.h:
(WebCore::DOMPath::DOMPath):

LayoutTests:

Reviewed by Simon Fraser.

Unreviewed rebaseline after landing patch.

* fast/dom/constructed-objects-prototypes-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143554 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDFG inlines Resolves that it doesn't know how to handle correctly
fpizlo@apple.com [Thu, 21 Feb 2013 02:43:36 +0000 (02:43 +0000)]
DFG inlines Resolves that it doesn't know how to handle correctly
https://bugs.webkit.org/show_bug.cgi?id=110405

Source/JavaScriptCore:

Reviewed by Geoffrey Garen.

Don't try to be clever: if there's a failing resolve, we can't inline it, period.

* dfg/DFGCapabilities.h:
(JSC::DFG::canInlineResolveOperations):
(JSC::DFG::canInlineOpcode):

LayoutTests:

Reviewed by Geoffrey Garen.

* fast/js/dfg-inline-resolve-expected.txt: Added.
* fast/js/dfg-inline-resolve.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143553 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoDisable window occlusion notifications for App Store on Mac.
commit-queue@webkit.org [Thu, 21 Feb 2013 02:41:56 +0000 (02:41 +0000)]
Disable window occlusion notifications for App Store on Mac.
https://bugs.webkit.org/show_bug.cgi?id=110417

Patch by Kiran Muppala <cmuppala@apple.com> on 2013-02-20
Reviewed by Simon Fraser.

Temporary fix to workaround issues with window occlusion notifications
in App Store.

* UIProcess/API/mac/WKView.mm:
(+[WKView _registerWindowOcclusionNotificationHandlers]): Return early
if the main bundle identifier matches that of App Store.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143552 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago\2013-02-20 Mark Lam <mark.lam@apple.com>
mark.lam@apple.com [Thu, 21 Feb 2013 02:36:26 +0000 (02:36 +0000)]
\2013-02-20  Mark Lam  <mark.lam@apple.com>

Rename DatabaseBackendAsync to DatabaseBackend.
https://bugs.webkit.org/show_bug.cgi?id=110422.

Reviewed by Geoffrey Garen.

This is a purely cosmetic change to make the naming consistent with
the front-end Database.

No new tests.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
* Modules/webdatabase/Database.cpp:
(WebCore::Database::Database):
(WebCore::Database::from):
(WebCore::Database::backend):
* Modules/webdatabase/Database.h:
* Modules/webdatabase/DatabaseBackend.cpp: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.cpp.
(WebCore::DatabaseBackend::DatabaseBackend):
(WebCore::DatabaseBackend::openAndVerifyVersion):
(WebCore::DatabaseBackend::performOpenAndVerify):
(WebCore::DatabaseBackend::close):
(WebCore::DatabaseBackend::runTransaction):
(WebCore::DatabaseBackend::inProgressTransactionCompleted):
(WebCore::DatabaseBackend::scheduleTransaction):
(WebCore::DatabaseBackend::scheduleTransactionStep):
(WebCore::DatabaseBackend::transactionClient):
(WebCore::DatabaseBackend::transactionCoordinator):
* Modules/webdatabase/DatabaseBackend.h: Copied from Source/WebCore/Modules/webdatabase/DatabaseBackendAsync.h.
* Modules/webdatabase/DatabaseBackendAsync.cpp: Removed.
* Modules/webdatabase/DatabaseBackendAsync.h: Removed.
* Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DatabaseBackendBase::~DatabaseBackendBase):
* Modules/webdatabase/DatabaseManager.cpp:
* Modules/webdatabase/DatabaseServer.cpp:
* Modules/webdatabase/DatabaseTask.cpp:
(WebCore::DatabaseTask::DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseCloseTask::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTransactionTask::DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::~DatabaseTransactionTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTransactionTask::debugTaskName):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::DatabaseTableNamesTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::doPerformTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::debugTaskName):
* Modules/webdatabase/DatabaseTask.h:
(WebCore::DatabaseTask::database):
(DatabaseTask):
(WebCore::DatabaseBackend::DatabaseOpenTask::create):
(DatabaseBackend::DatabaseOpenTask):
(WebCore::DatabaseBackend::DatabaseCloseTask::create):
(DatabaseBackend::DatabaseCloseTask):
(WebCore::DatabaseBackend::DatabaseTableNamesTask::create):
(DatabaseBackend::DatabaseTableNamesTask):
* Modules/webdatabase/DatabaseThread.cpp:
(WebCore::DatabaseThread::recordDatabaseOpen):
(WebCore::DatabaseThread::recordDatabaseClosed):
(WebCore::SameDatabasePredicate::SameDatabasePredicate):
(SameDatabasePredicate):
(WebCore::DatabaseThread::unscheduleDatabaseTasks):
* Modules/webdatabase/DatabaseThread.h:
* Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):
* Modules/webdatabase/SQLStatementBackend.h:
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::create):
(WebCore::SQLTransactionBackend::SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionBackend.h:
(WebCore::SQLTransactionBackend::database):
* Modules/webdatabase/SQLTransactionCoordinator.cpp:
(WebCore::getDatabaseIdentifier):
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143551 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUpstream SharedTimerIOS.mm
ddkilzer@apple.com [Thu, 21 Feb 2013 02:25:54 +0000 (02:25 +0000)]
Upstream SharedTimerIOS.mm
<http://webkit.org/b/110161>

Reviewed by Benjamin Poulain.

* Configurations/WebCore.xcconfig:
(EXCLUDED_SOURCE_FILE_NAMES_iphoneos): Add SharedTimerMac.mm.
* WebCore.xcodeproj/project.pbxproj: Add SharedTimerIOS.mm.
* platform/ios/SharedTimerIOS.mm: Add.
(WebCore):
(-[WebCoreResumeNotifierIOS init]):
(-[WebCoreResumeNotifierIOS dealloc]):
(-[WebCoreResumeNotifierIOS didWake]):
(WebCore::setSharedTimerFiredFunction):
(WebCore::timerFired):
(WebCore::setSharedTimerFireInterval):
(WebCore::stopSharedTimer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143550 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSpeculative fix for EFL and Windows compilers not realizing
ojan@chromium.org [Thu, 21 Feb 2013 02:24:46 +0000 (02:24 +0000)]
Speculative fix for EFL and Windows compilers not realizing
that all possible cases have a return value from this switch.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143549 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoConvert residual-style.html test to a reftest (and fix typos)
commit-queue@webkit.org [Thu, 21 Feb 2013 02:20:08 +0000 (02:20 +0000)]
Convert residual-style.html test to a reftest (and fix typos)
https://bugs.webkit.org/show_bug.cgi?id=109981

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-20
Reviewed by Darin Adler.

* fast/flexbox/box-orient-button.html: clsas->class
* fast/flexbox/resources/box-orient-button.js: DTR->DRT
* fast/invalid/residual-style-expected.html: Added. New reftest
version. Note that some lines are red, which is
https://bugs.webkit.org/show_bug.cgi?id=109984
* fast/invalid/residual-style.html: Add missing semicolon in <style>.
Also close a few more <font> tags, so that the descriptive text is
in black as it should be.

* platform/chromium-android/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-android/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-linux/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-linux/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-mac-lion/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac-snowleopard/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-mac/fast/invalid/residual-style-expected.txt: Removed.
* platform/chromium-win/fast/invalid/residual-style-expected.png: Removed.
* platform/chromium-win/fast/invalid/residual-style-expected.txt: Removed.
* platform/efl/fast/invalid/residual-style-expected.png: Removed.
* platform/efl/fast/invalid/residual-style-expected.txt: Removed.
* platform/gtk/fast/invalid/residual-style-expected.png: Removed.
* platform/gtk/fast/invalid/residual-style-expected.txt: Removed.
* platform/mac/fast/invalid/residual-style-expected.png: Removed.
* platform/mac/fast/invalid/residual-style-expected.txt: Removed.
Removed old expectation files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
jamesr@google.com [Thu, 21 Feb 2013 02:09:53 +0000 (02:09 +0000)]
[chromium] Request WebLayerTreeView for DumpRenderTree via explicit testing path
https://bugs.webkit.org/show_bug.cgi?id=109634

Reviewed by Adrienne Walker.

Source/Platform:

* chromium/public/WebUnitTestSupport.h:

Tools:

* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::createOutputSurface):
(WebViewHost::initializeLayerTreeView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Fix overflow computation for column blocks.
hyatt@apple.com [Thu, 21 Feb 2013 02:02:24 +0000 (02:02 +0000)]
[New Multicolumn] Fix overflow computation for column blocks.
https://bugs.webkit.org/show_bug.cgi?id=110392.

Reviewed by Simon Fraser.

Source/WebCore:

* rendering/RenderBox.cpp:
(WebCore::RenderBox::addOverflowFromChild):
Exclude in-flow RenderFlowThreads from overflow propagation.

* rendering/RenderMultiColumnSet.h:
* rendering/RenderRegion.h:
(WebCore::RenderRegion::shouldHaveAutoLogicalHeight):
 * rendering/RenderRegionSet.h:
(RenderRegionSet):
Override shouldHaveAutoLogicalHeight to always be false
for region sets and for columns. Eventually we're going to try
to leverage this code to do column balancing, and that's why
RenderMultiColumnSet has a unique override.

LayoutTests:

* fast/multicol/newmulticol/column-rules-fixed-height-expected.html:
* fast/multicol/newmulticol/column-rules-fixed-height.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPrinting WebGL canvases in Chrome uses stale data after first print
commit-queue@webkit.org [Thu, 21 Feb 2013 01:35:01 +0000 (01:35 +0000)]
Printing WebGL canvases in Chrome uses stale data after first print
https://bugs.webkit.org/show_bug.cgi?id=110003

Patch by Brandon Jones <bajones@google.com> on 2013-02-20
Reviewed by Kenneth Russell.

Unable to validate printed content automatically. No regression in existing WebGL tests.

 * html/canvas/WebGLRenderingContext.cpp:
 (WebCore):
 (WebCore::WebGLRenderingContext::paintRenderingResultsToCanvas):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<https://webkit.org/b/110410> Specify the plug-in process / service entitlements...
mrowe@apple.com [Thu, 21 Feb 2013 01:29:07 +0000 (01:29 +0000)]
<https://webkit.org/b/110410> Specify the plug-in process / service entitlements via the Xcode configuration.

This is the modern mechanism for applying entitlements to production builds,
and it simplifies the maintenance of entitlements going forward. It also allows
us to fix the new XPC PluginServices to have the same entitlements as PluginProcess.

Reviewed by Alexey Proskuryakov.

* Configurations/Base.xcconfig: Ad-hoc sign all WebKit2 components.
* Configurations/PluginProcess.xcconfig: Specify the entitlements to use.
* Configurations/PluginService.32.xcconfig: Ditto.
* Configurations/PluginService.64.xcconfig: Ditto.
* Configurations/PluginService.Development.xcconfig: Ditto.
* Configurations/PluginService.entitlements: Renamed from Source/WebKit2/PluginProcess/mac/PluginProcess.entitlements.
Move the entitlements in to the Configurations directory to make them easier to find.
* PluginProcess/mac/add-entitlements.sh: Removed. In my testing the dependency issue mentioned
in the script is not an issue with current versions of Xcode. If we see it again we can come
up with a workaround that doesn't involve performing the signing via a script phase.
* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago<https://webkit.org/b/110409> Remove duplication between 32- and 64-bit PluginService...
mrowe@apple.com [Thu, 21 Feb 2013 01:29:03 +0000 (01:29 +0000)]
<https://webkit.org/b/110409> Remove duplication between 32- and 64-bit PluginService plists.

Reviewed by Dan Bernstein.

The only difference between the plists was the CFBundleIdentifier. Since the values are the
same as the product name, we can just use the value of the PRODUCT_NAME configuration setting.

* Configurations/PluginService.32.xcconfig:
* Configurations/PluginService.64.xcconfig:
* PluginProcess/EntryPoint/mac/XPCService/PluginService.32-64.Info.plist: Renamed from Source/WebKit2/PluginProcess/EntryPoint/mac/XPCService/PluginService.32/Info.plist.
* PluginProcess/EntryPoint/mac/XPCService/PluginService.64/Info.plist: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIncorrect rendering for flex boxes with percentage height in a table cell
commit-queue@webkit.org [Thu, 21 Feb 2013 01:22:43 +0000 (01:22 +0000)]
Incorrect rendering for flex boxes with percentage height in a table cell
https://bugs.webkit.org/show_bug.cgi?id=110389

Patch by Christian Biesinger <cbiesinger@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

Source/WebCore:

Tests: css3/flexbox/flex-percentage-height-in-table-standards-mode.html
       css3/flexbox/flex-percentage-height-in-table.html

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutAndPlaceChildren):
Always update the logical height of the flex box, not just when it is
auto. If necessary, the later updateLogicalHeight() call will adjust
it.

LayoutTests:

* css3/flexbox/flex-percentage-height-in-table-expected.html: Added.
* css3/flexbox/flex-percentage-height-in-table-standards-mode-expected.html: Added.
* css3/flexbox/flex-percentage-height-in-table-standards-mode.html: Added.
* css3/flexbox/flex-percentage-height-in-table.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143542 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccount for transform in SVG background images
pdr@google.com [Thu, 21 Feb 2013 01:19:25 +0000 (01:19 +0000)]
Account for transform in SVG background images
https://bugs.webkit.org/show_bug.cgi?id=110295

Reviewed by Dirk Schulze.

Source/WebCore:

Tiled SVG background images are rendererd by drawing the SVG content into a temporary
image buffer, then stamping out a tiled pattern using this buffer. Previously the
image buffer did not account for CSS transforms which could result in pixelated backgrounds.

This patch takes advantage of the context's transform when sizing the temporary tiling
image buffer. Because the context's transform also includes scale, this patch simplifies
the SVG image code to no longer track scale.

Test: svg/as-background-image/svg-transformed-background.html

* loader/cache/CachedImage.cpp:
(WebCore):
(WebCore::CachedImage::imageForRenderer):

    CachedImage::lookupOrCreateImageForRenderer no longer creates images so it has been
    refactored into just "imageForRenderer". Previously there were two versions of
    lookupOrCreateImageForRenderer; these have been folded into imageForRenderer.

* loader/cache/CachedImage.h:
* svg/graphics/SVGImage.cpp:
(WebCore::SVGImage::drawPatternForContainer):

    To create the temporary tiling image buffer, the final size in screen coordinates is
    needed. This is now computed using the current context's CTM. Because the CTM
    already includes the page scale, all page scale tracking can be removed.

    The adjustments to srcRect and the pattern transform are the same as before, just
    refactored to use imageBufferScale which has x and y components.

* svg/graphics/SVGImage.h:
* svg/graphics/SVGImageCache.cpp:
(WebCore::SVGImageCache::setContainerSizeForRenderer):

    Because the page scale needed to be cached between calls to
    setContainerSizeForRenderer, this function was written to modify an existing cache
    entry. Because the page scale no longer needs to be tracked, this code has been
    simplified to re-write any existing cache entry.

(WebCore::SVGImageCache::imageSizeForRenderer):

    This function has been simplified by calling SVGImageForContainer::size() instead
    of computing this value manually. The value returned remains the same, containing
    the container size multiplied by zoom.

(WebCore::SVGImageCache::imageForRenderer):

    Previously we set the page scale on every call to imageForRenderer. Because page scale
    no longer needs to be tracked, this function has been simplified to simply return
    the cached SVGImageForContainer.

* svg/graphics/SVGImageForContainer.cpp:
(WebCore::SVGImageForContainer::drawPattern):
* svg/graphics/SVGImageForContainer.h:
(WebCore::SVGImageForContainer::create):
(WebCore::SVGImageForContainer::SVGImageForContainer):
(SVGImageForContainer):

LayoutTests:

* svg/as-background-image/svg-transformed-background-expected.html: Added.
* svg/as-background-image/svg-transformed-background.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCrash in com.apple.WebKit2.WebProcessService at com.apple.avfoundation: __73-[AVAsset...
jer.noble@apple.com [Thu, 21 Feb 2013 01:09:37 +0000 (01:09 +0000)]
Crash in com.apple.WebKit2.WebProcessService at com.apple.avfoundation: __73-[AVAssetResourceLoader _attemptDelegateHandlingOfRequestWithDictionary:]_block_invoke + 51
https://bugs.webkit.org/show_bug.cgi?id=110385

Reviewed by Eric Carlson.

Ensure AVFoundation does not attempt to message a dead object by explicitly disassociating
the AVAssetResourceLoaderDelegate on MediaPlayerPrivateAVFoundationObjC destruction.

* platform/graphics/avfoundation/objc/MediaPlayerPrivateAVFoundationObjC.mm:
(WebCore::MediaPlayerPrivateAVFoundationObjC::~MediaPlayerPrivateAVFoundationObjC):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoPositioned, replaced elements with intrinsic width keywords compute the wrong width
ojan@chromium.org [Thu, 21 Feb 2013 01:07:56 +0000 (01:07 +0000)]
Positioned, replaced elements with intrinsic width keywords compute the wrong width
https://bugs.webkit.org/show_bug.cgi?id=110393

Reviewed by Emil A Eklund.

Source/WebCore:

Test: fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeReplacedLogicalWidthUsing):
Add the intrinsic size keywords to the switch. Confusingly, we have to
subtract the border and padding since the callers expect the content width.

* rendering/RenderReplaced.cpp:
(WebCore::RenderReplaced::computeReplacedLogicalWidth):
Don't do the intrinsic ratio calculation if the width is an
intrinsic width keyword, as per, http://dev.w3.org/csswg/css3-sizing/#replaced-intrinsic.

(WebCore::RenderReplaced::computeIntrinsicLogicalWidths):
(WebCore::RenderReplaced::computePreferredLogicalWidths):
The old code was trying to apply the intrinsic ratio calculation to
the intrinsic width, which is wrong per spec.

LayoutTests:

* fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes-expected.txt: Added.
* fast/css-intrinsic-dimensions/intrinsic-sized-replaced-absolutes.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLevelDB: Remove excess vector copy
alecflett@chromium.org [Thu, 21 Feb 2013 00:49:57 +0000 (00:49 +0000)]
LevelDB: Remove excess vector copy
https://bugs.webkit.org/show_bug.cgi?id=110399

Reviewed by Tony Chang.

Remove an extra copy introduced by the makeVector function.

No new tests, this is covered by existing tests.

* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::LevelDBDatabase::safeGet):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoZoomed, slow-scrolling pages keep recreating tiles when scrolled
simon.fraser@apple.com [Thu, 21 Feb 2013 00:48:45 +0000 (00:48 +0000)]
Zoomed, slow-scrolling pages keep recreating tiles when scrolled
https://bugs.webkit.org/show_bug.cgi?id=110379

Source/WebCore:

Reviewed by Tim Horton.

On slow-scrolling pages the TileCache makes the tiles the size of
the visible rect to minimize per-tile painting overhead. If the size
of that rect changes, the TileCache re-creates all the tiles.

This was a problem whem zoomed, because mapping the visible rect
through the scale transform and then rounding it would cause the
size to keep changing, causing lots of tile re-creation.

Fix by carrying the visibleRect around as a FloatRect, and doing
the same for the exposedRect. We then only expand to integers
when computing the tile size. This also fixes an issue where we could
sometimes make extra tiles because of fractional bits of tiles at the edges,
as shown by the test result change.

* platform/graphics/TiledBacking.h:
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::updateVisibleRect):
* platform/graphics/ca/mac/TileCache.h:
* platform/graphics/ca/mac/TileCache.mm:
(WebCore::TileCache::setVisibleRect):
(WebCore::TileCache::setExposedRect):
(WebCore::TileCache::prepopulateRect):
(WebCore::TileCache::computeTileCoverageRect):
(WebCore::TileCache::tileSizeForCoverageRect):
(WebCore::TileCache::blankPixelCountForTiles):
(WebCore::TileCache::revalidateTiles):
(WebCore::TileCache::ensureTilesForRect):
* platform/graphics/ca/mac/WebTileLayer.mm:
(-[WebTileLayer logFilledFreshTile]):

Source/WebKit2:

Reviewed by Tim Horton.

Make the visible rect and exposed rects passed through
the drawing area to the tile cache FloatRects instead of IntRects.

* UIProcess/API/mac/WKView.mm:
(-[WKView setFrameSize:]):
(-[WKView _updateWindowAndViewFrames]):
(-[WKView enableFrameSizeUpdates]):
(-[WKView setMinimumWidthForAutoLayout:]):
* UIProcess/WebPageProxy.h:
* UIProcess/mac/WebPageProxyMac.mm:
(WebKit::WebPageProxy::viewExposedRectChanged):
* WebProcess/WebPage/DrawingArea.h:
(WebKit::DrawingArea::setExposedRect):
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::viewExposedRectChanged):
* WebProcess/WebPage/WebPage.h:
* WebProcess/WebPage/WebPage.messages.in:
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.h:
(TiledCoreAnimationDrawingArea):
* WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:
(WebKit::TiledCoreAnimationDrawingArea::setExposedRect):

LayoutTests:

Reviewed by Tim Horton.

This test now just has one tile, rather than four. There is an apparent issue
with the integral tile cache coverage rect being smaller than the visible rect.
This is caused by rounding when dumping the tile coverage rect.

* platform/mac-wk2/tiled-drawing/tile-size-slow-zoomed-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed. Remove references to SAFARI_THEME from Windows Solution.
roger_fong@apple.com [Thu, 21 Feb 2013 00:45:36 +0000 (00:45 +0000)]
Unreviewed. Remove references to SAFARI_THEME from Windows Solution.
<rdar://problem/13258710>

* config.h:
* page/Settings.cpp:
* page/Settings.h:
* platform/win/ScrollbarThemeWin.cpp:
* rendering/RenderThemeWin.cpp:
* WebKitClassFactory.cpp:
* WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[CSS Grid Layout] Implement the auto-placement algorithm without grid growth
jchaffraix@webkit.org [Thu, 21 Feb 2013 00:33:49 +0000 (00:33 +0000)]
[CSS Grid Layout] Implement the auto-placement algorithm without grid growth
https://bugs.webkit.org/show_bug.cgi?id=110277

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-grid-layout/grid-item-addition-auto-placement-update.html
       fast/css-grid-layout/grid-item-removal-auto-placement-update.html
       fast/css-grid-layout/grid-auto-flow-resolution.html (extended to cover more cases)

This change implements most of the auto-placement algorithm per
http://dev.w3.org/csswg/css3-grid-layout/#auto-placement-algo

To limit the size of the code change, it doesn't implement growing the grid if there
are no empty grid areas. If we don't find any empty grid areas, we just insert in the first
one, like what grid-auto-flow: none would do (which explains the test failures).

* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::GridIterator::nextEmptyGridArea):
Added this function to return the GridCoordinate of the next empty grid area along
the iterator's direction.

(WebCore::RenderGrid::placeItemsOnGrid):
Split this function into the different steps below. For efficiency, collect the auto vs specified
major axis grid items in different Vectors.

(WebCore::RenderGrid::placeSpecifiedMajorAxisItemsOnGrid):
Added this function that implements part of step 1 of the algorithm (the grid items without
auto row / column are already handled in placeItemsOnGrid).

(WebCore::RenderGrid::placeAutoMajorAxisItemsOnGrid):
Added this function that iterates over the auto grid items and call placeAutoMajorAxisItemOnGrid.

(WebCore::RenderGrid::placeAutoMajorAxisItemOnGrid):
Added this method to handle the step 4 of the algorithm. Based on the minor axis's position,
it either walks along the major axis once or several times until it finds an empty grid area
for the grid item.

(WebCore::RenderGrid::autoPlacementMajorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMinorAxisPositionForChild):
(WebCore::RenderGrid::autoPlacementMajorAxisDirection):
(WebCore::RenderGrid::autoPlacementMinorAxisDirection):
Added these helper functions that return minor / major axis positions & direction.

* rendering/RenderGrid.h:
Added the previous new RenderGrid functions.

LayoutTests:

* fast/css-grid-layout/grid-auto-flow-resolution-expected.txt:
* fast/css-grid-layout/grid-auto-flow-resolution.html:

* fast/css-grid-layout/grid-item-addition-auto-placement-update-expected.txt: Added.
* fast/css-grid-layout/grid-item-addition-auto-placement-update.html: Added.
* fast/css-grid-layout/grid-item-removal-auto-placement-update-expected.txt: Added.
* fast/css-grid-layout/grid-item-removal-auto-placement-update.html: Added.
The current algorithm doesn't grow the grid but falls back to inserting the element at
position (1, 1). The failures in these tests are due to that.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAccept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
scheib@chromium.org [Thu, 21 Feb 2013 00:32:26 +0000 (00:32 +0000)]
Accept 'allowfullscreen' in addition to 'webkitallowfullscreen'.
https://bugs.webkit.org/show_bug.cgi?id=110374

Reviewed by Adam Barth.

Source/WebCore:

The fullscreen API also includes a new HTML attribute for iframes
which permits its use. That attribute, 'allowfullcreen' is now
included in the HTML specification [1] and is stable enough
to remove the webkit prefix.

[1] http://www.whatwg.org/specs/web-apps/current-work/multipage/the-iframe-element.html#attr-iframe-allowfullscreen

Tests: fullscreen/full-screen-enabled-prefixed.html
       fullscreen/full-screen-iframe-allowed-prefixed.html
       fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html

* dom/Document.cpp:
(WebCore::isAttributeOnAllOwners):
(WebCore::Document::fullScreenIsAllowedForElement):
(WebCore::Document::webkitFullscreenEnabled):
* html/HTMLAttributeNames.in:

LayoutTests:

Two previous tests duplicated to preserve testing webkitallowfullscreen
and then modified to test allowfullscreen.

A new test 'full-screen-iframe-with-mixed-allow-webkitallow-attribute.html'
added to test a mixed nesting of iframs with both allowfullscreen and
webkitallowfullscreen.

* fullscreen/full-screen-enabled-prefixed-expected.txt: Added.
* fullscreen/full-screen-enabled-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-enabled.html.
* fullscreen/full-screen-enabled.html:
* fullscreen/full-screen-iframe-allowed-prefixed-expected.txt: Added.
* fullscreen/full-screen-iframe-allowed-prefixed.html: Copied from LayoutTests/fullscreen/full-screen-iframe-allowed.html.
* fullscreen/full-screen-iframe-allowed.html:
* fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute-expected.txt:
* fullscreen/full-screen-iframe-with-mixed-allow-webkitallow-attribute.html: Added.
* fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe1.html: Added.
* fullscreen/resources/full-screen-iframe-with-mixed-allow-webkitallow-iframe2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[GTK] Re-enable 3D CSS transforms when using build-webkit
commit-queue@webkit.org [Thu, 21 Feb 2013 00:31:58 +0000 (00:31 +0000)]
[GTK] Re-enable 3D CSS transforms when using build-webkit
https://bugs.webkit.org/show_bug.cgi?id=110402

Patch by Martin Robinson <mrobinson@igalia.com> on 2013-02-20
Reviewed by Xan Lopez.

* Scripts/webkitperl/FeatureList.pm: Enable 3D rendering by default
when building WebKitGTK+.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoGet VS2010 Solution B&I ready.
roger_fong@apple.com [Thu, 21 Feb 2013 00:07:29 +0000 (00:07 +0000)]
Get VS2010 Solution B&I ready.
<rdar://problem/1322988>

Rubberstamped by Timothy Horton.

Add Production configuration.
Add a submit solutions with a DebugSuffix configuration.
Modify B&I make files as necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143529 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
adamk@chromium.org [Thu, 21 Feb 2013 00:00:33 +0000 (00:00 +0000)]
[v8] Fix an erroneous WrapperGrouper call in preparation for refactoring
https://bugs.webkit.org/show_bug.cgi?id=110396

Reviewed by Kentaro Hara.

This is in preparation for a refactor to expose a simplified
WrapperGrouper interface to V8 wrapper classes enabling them to
specify multiple roots per wrapper object.

* bindings/v8/V8GCController.cpp: Since MutationObservers are not Nodes, the correct call here is addObjectToGroup, as it is for all other non-Node wrappers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoLine layout (but not pref widths) double-counts word spacing when between inlines
leviw@chromium.org [Wed, 20 Feb 2013 23:44:21 +0000 (23:44 +0000)]
Line layout (but not pref widths) double-counts word spacing when between inlines
https://bugs.webkit.org/show_bug.cgi?id=110381

Reviewed by Emil A Eklund.

Source/WebCore:

When a word break with a space occurs between inlines and word-spacing is non-zero,
line layout incorrectly committed the word-spacing value to the line twice, causing
wrapping in inline-blocks. To fix this, clear the word-spacing value when between
words and ignoring spaces, as we will already have added the word-spacing to the
line.

Test: fast/text/word-space-between-inlines.html

* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::LineBreaker::nextSegmentBreak):

LayoutTests:

* fast/text/word-space-between-inlines-expected.html: Added.
* fast/text/word-space-between-inlines.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[BlackBerry] Check offset for initialized value
nghanavatian@rim.com [Wed, 20 Feb 2013 23:31:31 +0000 (23:31 +0000)]
[BlackBerry] Check offset for initialized value
https://bugs.webkit.org/show_bug.cgi?id=110390

Reviewed by Rob Buis.

Instead of checking isEmpty, which checks for either point being <= 0, we want to explicitly check
for the initialized value of (-1, -1). This would be set in redrawSpellCheckDialogIfRequired, and
triggers the restore from cache in requestSpellingCheckingOptions.

Internally reviewed by Gen Mak.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::requestSpellingCheckingOptions):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoSource/WebCore: Crash in WebCore::FrameLoader::checkCompleted()
japhet@chromium.org [Wed, 20 Feb 2013 23:13:53 +0000 (23:13 +0000)]
Source/WebCore: Crash in WebCore::FrameLoader::checkCompleted()
https://bugs.webkit.org/show_bug.cgi?id=110237

Reviewed by Abhishek Arya.

Test: http/tests/misc/delete-frame-during-readystatechange.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::checkCompleted): Protect before setReadyState() is called.

LayoutTests: Test for https://bugs.webkit.org/show_bug.cgi?id=110237

Reviewed by Abhishek Arya.

* http/tests/misc/delete-frame-during-readystatechange-expected.txt: Added.
* http/tests/misc/delete-frame-during-readystatechange.html: Added.
* http/tests/misc/resources/delete-frame-during-readystatechange-frame.html: Added.
* http/tests/misc/resources/empty.ogv: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoIndexedDB: Limit LevelDB's max open files
dgrogan@chromium.org [Wed, 20 Feb 2013 23:00:43 +0000 (23:00 +0000)]
IndexedDB: Limit LevelDB's max open files
https://bugs.webkit.org/show_bug.cgi?id=109993

Reviewed by Tony Chang.

LevelDB keeps up to 1000 (by default) data files open at a time to
avoid having to open() them. This has caused chromium to hit the
process-wide open file limit. This patch changes max_open_files to 20,
as that's the minimum permitted by LevelDB and we have no reason to
think that performance will suffer because of the extra open calls.

No new tests - a chromium browser test that tracks the open LevelDB
files is plausible but is blocked on http://crbug.com/177249/.

* platform/leveldb/LevelDBDatabase.cpp:
(WebCore::openDB):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoAdd gyp option to switch ENABLE(SQL_DATABASE)
commit-queue@webkit.org [Wed, 20 Feb 2013 22:56:54 +0000 (22:56 +0000)]
Add gyp option to switch ENABLE(SQL_DATABASE)
https://bugs.webkit.org/show_bug.cgi?id=109303
http://code.google.com/p/chromium/issues/detail?id=22208

Patch by Paweł Hajdan, Jr. <phajdan.jr@chromium.org> on 2013-02-20
Reviewed by Tony Chang.

This will be useful to implement build with system sqlite.

* features.gypi:
* src/ChromeClientImpl.cpp:
(WebKit):
* src/ChromeClientImpl.h:
(ChromeClientImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition...
jer.noble@apple.com [Wed, 20 Feb 2013 22:49:41 +0000 (22:49 +0000)]
EME: Enable both ENCRYPTED_MEDIA and ENCRYPTED_MEDIA_V2 until clients transition to the new API.
https://bugs.webkit.org/show_bug.cgi?id=110284

Reviewed by Eric Carlson.

Re-enable the ENCRYPTED_MEDIA flag.

* Configurations/FeatureDefines.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Resize RenderMultiColumnSets around their columns.
hyatt@apple.com [Wed, 20 Feb 2013 22:16:55 +0000 (22:16 +0000)]
[New Multicolumn] Resize RenderMultiColumnSets around their columns.
https://bugs.webkit.org/show_bug.cgi?id=110378.

Reviewed by Dirk Schulze.

Source/WebCore:

Test: fast/multicol/newmulticol/positioned-with-constrained-height.html.

* rendering/RenderBlock.h:
(RenderBlock):
Make computeOverflow public so that RenderMultiColumnFlowThread can
access it.

* rendering/RenderMultiColumnFlowThread.cpp:
(WebCore::RenderMultiColumnFlowThread::layout):
Subclass layout to recompute the overflow for RenderMultiColumnBlock
after the flow thread has finished layout. This way it can account
for changes in RenderMultiColumnSets without having to do a second
layout pass.

* rendering/RenderMultiColumnFlowThread.h:
(RenderMultiColumnFlowThread):
Override layout().

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnCount):
Clean up a comment that referred to portions as region rects still.

(WebCore::RenderMultiColumnSet::setFlowThreadPortionRect):
* rendering/RenderMultiColumnSet.h:
* rendering/RenderRegion.h:
(WebCore::RenderRegion::setFlowThreadPortionRect):
Make setFlowThreadPortionRect virtual and actually mutate the size
and position of RenderMultiColumnSets so that they enclose their
column rects.

LayoutTests:

* fast/multicol/newmulticol/positioned-with-constrained-height-expected.html: Added.
* fast/multicol/newmulticol/positioned-with-constrained-height.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoEnable CANVAS_PATH flag
krit@webkit.org [Wed, 20 Feb 2013 22:14:04 +0000 (22:14 +0000)]
Enable CANVAS_PATH flag
https://bugs.webkit.org/show_bug.cgi?id=108508

Reviewed by Simon Fraser.

Enable CANVAS_PATH flag on trunk.

.:

Existing tests cover the feature.

* Source/cmake/WebKitFeatures.cmake:

Source/JavaScriptCore:

Existing tests cover the feature.

* Configurations/FeatureDefines.xcconfig:

Source/WebCore:

Existing tests cover the feature.

* Configurations/FeatureDefines.xcconfig:

Source/WebKit/chromium:

* features.gypi:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:

Source/WebKit2:

* Configurations/FeatureDefines.xcconfig:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

Existing tests cover the feature.

* fast/canvas/canvas-path-object-expected.txt:
* inspector/profiler/canvas2d/canvas2d-api-changes.html:
* platform/chromium/TestExpectations:
* platform/efl/TestExpectations:
* platform/gtk/TestExpectations:
* platform/mac/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143505 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoParse author names with commas in ChangeLogs
tony@chromium.org [Wed, 20 Feb 2013 22:03:49 +0000 (22:03 +0000)]
Parse author names with commas in ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=110356

Reviewed by Dirk Pranke.

Paweł's name has a comma in it, which was confusing the ChangeLog parser.

* Scripts/webkitpy/common/checkout/changelog.py:
(ChangeLogEntry): Move name splitting regexp into a constant.
(ChangeLogEntry._parse_reviewer_text): Use _split_reviewer_names.
(ChangeLogEntry._split_reviewer_names): Rename to be more specific.
(ChangeLogEntry._split_author_names_with_emails): Rename to be more specific and require emails.
(ChangeLogEntry._parse_author_text): Use _split_author_names_with_emails.
* Scripts/webkitpy/common/checkout/changelog_unittest.py:
(test_parse_authors): Test case with Paweł's name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoUnreviewed, rolling out r143441.
commit-queue@webkit.org [Wed, 20 Feb 2013 21:56:27 +0000 (21:56 +0000)]
Unreviewed, rolling out r143441.
http://trac.webkit.org/changeset/143441
https://bugs.webkit.org/show_bug.cgi?id=110376

May be causing chromium content_browsertests failures.
(Requested by vollick on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-02-20

* bindings/v8/ScriptValue.cpp:
(WebCore::ScriptValue::serialize):
(WebCore::ScriptValue::getString):
(WebCore::ScriptValue::toString):
(WebCore::ScriptValue::toInspectorValue):
* bindings/v8/ScriptValue.h:
(WebCore::ScriptValue::ScriptValue):
(WebCore::ScriptValue::operator=):
(WebCore::ScriptValue::operator==):
(WebCore::ScriptValue::isEqual):
(WebCore::ScriptValue::isFunction):
(WebCore::ScriptValue::isNull):
(WebCore::ScriptValue::isUndefined):
(WebCore::ScriptValue::isObject):
(WebCore::ScriptValue::hasNoValue):
(WebCore::ScriptValue::clear):
(WebCore::ScriptValue::v8Value):
(ScriptValue):
* bindings/v8/SharedPersistent.h:
(WebCore):
* bindings/v8/custom/V8InjectedScriptHostCustom.cpp:
(WebCore::InjectedScriptHost::scriptValueAsNode):
* bindings/v8/custom/V8MessageEventCustom.cpp:
(WebCore::V8MessageEvent::dataAttrGetterCustom):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Add runtime flag for CanvasPath
krit@webkit.org [Wed, 20 Feb 2013 21:53:27 +0000 (21:53 +0000)]
[Chromium] Add runtime flag for CanvasPath
https://bugs.webkit.org/show_bug.cgi?id=109997

Reviewed by Adam Barth.

Source/WebCore:

Add runtime flag for Chromium.

* bindings/generic/RuntimeEnabledFeatures.cpp:
(WebCore):
* bindings/generic/RuntimeEnabledFeatures.h:
(RuntimeEnabledFeatures):
(WebCore::RuntimeEnabledFeatures::setCanvasPathEnabled):
(WebCore::RuntimeEnabledFeatures::canvasPathEnabled):
* html/canvas/DOMPath.idl:
* page/DOMWindow.idl:

Source/WebKit/chromium:

Add runtime flag for Chromium.

* public/WebRuntimeFeatures.h:
(WebRuntimeFeatures):
* src/WebRuntimeFeatures.cpp:
(WebKit::WebRuntimeFeatures::enableCanvasPath):
(WebKit):
(WebKit::WebRuntimeFeatures::isCanvasPathEnabled):

Tools:

Added runtime flag for Canvas Path. Enabled it by default for TestShell. Otherwise
the constructor for Path on DOMWindow would never be activatable, since the script
is running after creating the DOMWindow object.

* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::TestShell):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
wjmaclean@chromium.org [Wed, 20 Feb 2013 21:48:25 +0000 (21:48 +0000)]
[chromium] Unreviewed gardening.

Patch by Ian Vollick <vollick@chromium.org> on 2013-02-20

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove unnecessary includes for Platform.h from headers
commit-queue@webkit.org [Wed, 20 Feb 2013 21:45:56 +0000 (21:45 +0000)]
Remove unnecessary includes for Platform.h from headers
https://bugs.webkit.org/show_bug.cgi?id=110300

Patch by Laszlo Gombos <l.gombos@samsung.com> on 2013-02-20
Reviewed by Alexey Proskuryakov.

Source/WebCore:

wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.

No new tests, no change in functionality.

* platform/SecureTextInput.h:
* platform/audio/Biquad.h:
* platform/audio/FFTFrame.h:
* platform/graphics/cpu/arm/filters/FEBlendNEON.h:
* platform/graphics/cpu/arm/filters/NEONHelpers.h:
* platform/graphics/filters/FELighting.h:

Source/WebKit2:

wtf/Platform.h only need to be included in a few places directly
as it is included in config.h. Remove the unnecessay duplicate as
it can be confusing.

* Shared/PrintInfo.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[SVG] Update of element referenced by multiple 'use' nodes is absurdly slow
fmalita@chromium.org [Wed, 20 Feb 2013 21:43:29 +0000 (21:43 +0000)]
[SVG] Update of element referenced by multiple 'use' nodes is absurdly slow
https://bugs.webkit.org/show_bug.cgi?id=97905

Reviewed by Dirk Schulze.

Rebuilding the shadow and instance trees of dependent use nodes recursively can be
extremely inefficient with non-trivial dependency graphs (the trees are not constructed
in topological order).

To avoid redundant buildShadowAndInstanceTree() invokations, separate the invalidation
phase from the actual tree (re)building phase, and only descend into the dependency DAG
during the invalidation phase (recursion also stops at nodes that have been previously
invalidated).

No new tests: functional coverage provided by existing tests, perfomance tracked by
PerformanceTests/SVG/SvgNestedUse.html.

* svg/SVGUseElement.cpp:
(WebCore::SVGUseElement::buildPendingResource):
(WebCore::SVGUseElement::buildShadowAndInstanceTree):
(WebCore::SVGUseElement::invalidateShadowTree):
(WebCore):
(WebCore::SVGUseElement::invalidateDependentShadowTrees):
* svg/SVGUseElement.h:
(SVGUseElement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] Unreviewed gardening.
wjmaclean@chromium.org [Wed, 20 Feb 2013 21:34:19 +0000 (21:34 +0000)]
[chromium] Unreviewed gardening.

Patch by Ian Vollick <vollick@chromium.org> on 2013-02-20

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[Chromium] Move WebKitPlatformSupport declaration to Platform.h
pilgrim@chromium.org [Wed, 20 Feb 2013 21:31:15 +0000 (21:31 +0000)]
[Chromium] Move WebKitPlatformSupport declaration to Platform.h
https://bugs.webkit.org/show_bug.cgi?id=110262

Reviewed by Adam Barth.

In preparation for removing WebKitPlatformSupport.h entirely (once
downstream references to that file have been updated). Part of a
larger refactoring series; see tracking bug 82948.

Source/Platform:

* chromium/public/Platform.h:
(WebKitPlatformSupport):
(WebKit::WebKitPlatformSupport::~WebKitPlatformSupport):
(WebKit):

Source/WebKit/chromium:

* public/platform/WebKitPlatformSupport.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake the test land in r143482 less platform-specific
robert@webkit.org [Wed, 20 Feb 2013 21:28:08 +0000 (21:28 +0000)]
Make the test land in r143482 less platform-specific

Add outline:none to the test so platform-specific outlines don't kick in and
make us require separate results for Mac and Linux.

Unreviewed, gardening.

* fast/repaint/paint-caret-in-div-with-negative-indent-expected.png:
* fast/repaint/paint-caret-in-div-with-negative-indent.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRenderLayerBacking should initialize TiledBacking's isInWindow state with Page's...
timothy_horton@apple.com [Wed, 20 Feb 2013 21:15:09 +0000 (21:15 +0000)]
RenderLayerBacking should initialize TiledBacking's isInWindow state with Page's isInWindow, not isOnscreen
https://bugs.webkit.org/show_bug.cgi?id=110370
<rdar://problem/13254006>

Reviewed by Simon Fraser.

* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::RenderLayerBacking):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoCleanup the SQLTransaction and SQLTransactionBackend state dispatch
mark.lam@apple.com [Wed, 20 Feb 2013 21:10:18 +0000 (21:10 +0000)]
Cleanup the SQLTransaction and SQLTransactionBackend state dispatch
to only honor a state transition request if the associated database
hasn't been interrupted.
https://bugs.webkit.org/show_bug.cgi?id=110247.

Reviewed by Antti Koivisto.

No new tests.

* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::performPendingCallback):
(WebCore::SQLTransaction::computeNextStateAndCleanupIfNeeded):
* Modules/webdatabase/SQLTransaction.h:
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::computeNextStateAndCleanupIfNeeded):
(WebCore::SQLTransactionBackend::performNextStep):
* Modules/webdatabase/SQLTransactionBackend.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMoar hardening
oliver@apple.com [Wed, 20 Feb 2013 21:09:16 +0000 (21:09 +0000)]
Moar hardening
https://bugs.webkit.org/show_bug.cgi?id=110275

Reviewed by Mark Hahnenberg.

We now poison objects when they get freed, and verify that
any object that is being freed is not poisoned.  If the
object looks like it's poisoned we validate the freelist,
and ensure the object is not already present.  If it is
we crash.

On allocation, we ensure that the object being allocated
is poisoned, then clear the poisoning fields.

* wtf/FastMalloc.cpp:
(WTF::internalEntropyValue):
(WTF):
(WTF::freedObjectStartPoison):
(WTF::freedObjectEndPoison):
(TCMalloc_ThreadCache_FreeList):
(WTF::TCMalloc_ThreadCache_FreeList::Validate):
(WTF::TCMalloc_Central_FreeList::Populate):
(WTF::TCMalloc_ThreadCache::Allocate):
(WTF::TCMalloc_ThreadCache::Deallocate):
(WTF::TCMalloc_ThreadCache::CreateCacheIfNecessary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago ResourceHandle::loadResourceSynchronously should have blob support in cross...
ap@apple.com [Wed, 20 Feb 2013 21:02:36 +0000 (21:02 +0000)]
    ResourceHandle::loadResourceSynchronously should have blob support in cross-platform code
        https://bugs.webkit.org/show_bug.cgi?id=110364

        Reviewed by Anders Carlsson.

        * platform/network/ResourceHandle.h:
        * platform/network/ResourceHandle.cpp: (WebCore::ResourceHandle::loadResourceSynchronously):
        Added a cross-platform version to keep blob-related logic in one place.

        * platform/network/blackberry/ResourceHandleBlackBerry.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/cf/ResourceHandleCFNet.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/curl/ResourceHandleCurl.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/mac/ResourceHandleMac.mm:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/qt/ResourceHandleQt.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/soup/ResourceHandleSoup.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::platformLoadResourceSynchronously):
        Renamed loadResourceSynchronously to platformLoadResourceSynchronously,
        removed blob handling from platforms that had it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] RenderMultiColumnFlowThreads should establish a BFC.
hyatt@apple.com [Wed, 20 Feb 2013 21:00:24 +0000 (21:00 +0000)]
[New Multicolumn] RenderMultiColumnFlowThreads should establish a BFC.
https://bugs.webkit.org/show_bug.cgi?id=110366.

Reviewed by Antti Koivisto.

Source/WebCore:

RenderFlowThreads should establish a block formatting context always.
CSS Regions have named flow thread that they absolutely position, and so
they got this for free by being absolutely positioned.

RenderMultiColumnFlowThreads, however, are relative positioned, so we need
to just add an isRenderFlowThread case specifically so we're not dependent
on the positioning scheme used for the flow thread to establish the BFC.

Test: fast/multicol/newmulticol/float-*.html.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::MarginInfo::MarginInfo):

LayoutTests:

* fast/multicol/newmulticol/float-avoidance-expected.html: Added.
* fast/multicol/newmulticol/float-avoidance.html: Added.
* fast/multicol/newmulticol/float-multicol-expected.html: Added.
* fast/multicol/newmulticol/float-multicol.html: Added.
* fast/multicol/newmulticol/float-paginate-complex-expected.html: Added.
* fast/multicol/newmulticol/float-paginate-complex.html: Added.
* fast/multicol/newmulticol/float-paginate-empty-lines-expected.html: Added.
* fast/multicol/newmulticol/float-paginate-empty-lines.html: Added.
* fast/multicol/newmulticol/float-paginate-expected.html: Added.
* fast/multicol/newmulticol/float-paginate.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[New Multicolumn] Column gap is computed incorrectly.
hyatt@apple.com [Wed, 20 Feb 2013 19:58:16 +0000 (19:58 +0000)]
[New Multicolumn] Column gap is computed incorrectly.
https://bugs.webkit.org/show_bug.cgi?id=110360.

Reviewed by Simon Fraser.

Source/WebCore:

Test: fast/multicol/newmulticol/layers-split-across-columns.html.

* rendering/RenderMultiColumnSet.cpp:
(WebCore::RenderMultiColumnSet::columnGap):
Make sure we ask the RenderMultiColumnBlock for the gap rather than our
own style, since we don't actually have the gap value in our style.

(WebCore::RenderMultiColumnSet::flowThreadPortionOverflowRect):
* rendering/RenderMultiColumnSet.h:
Fix another spot where the columnGap was an int. It should be a LayoutUnit.

LayoutTests:

* fast/multicol/newmulticol/layers-split-across-columns-expected.html: Added.
* fast/multicol/newmulticol/layers-split-across-columns.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoNo caret on empty contenteditable element with negative text-indent
robert@webkit.org [Wed, 20 Feb 2013 19:51:03 +0000 (19:51 +0000)]
No caret on empty contenteditable element with negative text-indent
https://bugs.webkit.org/show_bug.cgi?id=108633

Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: fast/repaint/paint-caret-in-div-with-negative-indent.html

When an editable element has a negative text indent we won't paint the caret when the
element is empty because it falls outside the element's border box. To ensure the caret is painted,
account for any negative indent with our overflow.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::computeOverflow):

LayoutTests:

* fast/repaint/paint-caret-in-div-with-negative-indent-expected.png: Added.
* fast/repaint/paint-caret-in-div-with-negative-indent-expected.txt: Added.
* fast/repaint/paint-caret-in-div-with-negative-indent.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years ago[chromium] use a WebTestProxyBase pointer to identify the window we need the history for
jochen@chromium.org [Wed, 20 Feb 2013 18:45:45 +0000 (18:45 +0000)]
[chromium] use a WebTestProxyBase pointer to identify the window we need the history for
https://bugs.webkit.org/show_bug.cgi?id=110346

Reviewed by Adam Barth.

Using an index is very brittle, as the TestRunner API does not define
any ordering of windows.

Also, make TestRunner::shouldDumpBackForwardList() so content shell can
trigger the capturing in the browser process before generating the
text dump.

* DumpRenderTree/chromium/TestRunner/public/WebTestDelegate.h:
(WebTestRunner):
(WebTestRunner::WebTestDelegate::captureHistoryForWindow):
* DumpRenderTree/chromium/TestRunner/public/WebTestRunner.h:
(WebTestRunner):
* DumpRenderTree/chromium/TestRunner/src/TestRunner.h:
(TestRunner):
* DumpRenderTree/chromium/TestRunner/src/WebTestProxy.cpp:
(WebTestRunner::WebTestProxyBase::captureTree):
* DumpRenderTree/chromium/WebViewHost.cpp:
(WebViewHost::captureHistoryForWindow):
* DumpRenderTree/chromium/WebViewHost.h:
(WebViewHost):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoRemove stretchesToMinIntrinsicLogicalWidth
ojan@chromium.org [Wed, 20 Feb 2013 18:45:22 +0000 (18:45 +0000)]
Remove stretchesToMinIntrinsicLogicalWidth
https://bugs.webkit.org/show_bug.cgi?id=110266

Reviewed by Emil Eklund.

This was only used by fieldsets and now we have a way to express this
concept in CSS.

* WebCore.order:
* css/html.css:
Make fieldsets min-width: -webkit-min-content.

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeLogicalWidthInRegion):
(WebCore::RenderBox::computePositionedLogicalWidth):
* rendering/RenderBox.h:
Remove all calls to stretchesToMinIntrinsicLogicalWidth.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoMake intrinsic width values work for positioned elements
ojan@chromium.org [Wed, 20 Feb 2013 18:37:06 +0000 (18:37 +0000)]
Make intrinsic width values work for positioned elements
https://bugs.webkit.org/show_bug.cgi?id=110264

Reviewed by Tony Chang.

Source/WebCore:

Tests: fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html
       fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html

* rendering/RenderBox.cpp:
(WebCore::RenderBox::computeIntrinsicLogicalWidthUsing):
(WebCore::RenderBox::computeLogicalWidthInRegionUsing):
Move the computation of intrinsic widths out into a helper function so that
computePositionedLogicalWidthUsing can use it. As per the current spec,
fill-available measures shrink to avoid floats. http://dev.w3.org/csswg/css3-sizing/

(WebCore::RenderBox::computePositionedLogicalWidth):
Compute intrinsic min-widths in addition to non-zero ones. Intrinsic widths
return true for isZero. width and max-width don't need modifying since they already
call computePositionedLogicalWidthUsing for intrinsic widths.

(WebCore::RenderBox::computePositionedLogicalWidthUsing):
Compute intrinsic widths and use a Fixed length for the rest of the positioned width
computation. Doesn't include bordersPlusPadding because the caller, expected the content
width and adds in the bordersPlusPadding later.

* rendering/RenderBox.h:

LayoutTests:

* fast/css-intrinsic-dimensions/intrinsic-sized-absolutes-expected.txt: Added.
* fast/css-intrinsic-dimensions/intrinsic-sized-absolutes.html: Added.
* fast/css-intrinsic-dimensions/width-shrinks-avoid-floats-expected.txt: Added.
* fast/css-intrinsic-dimensions/width-shrinks-avoid-floats.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

7 years agoinput element with placeholder text and width set to 100% on focus causes overflow...
robert@webkit.org [Wed, 20 Feb 2013 18:27:03 +0000 (18:27 +0000)]
input element with placeholder text and width set to 100% on focus causes overflow even after losing focus
https://bugs.webkit.org/show_bug.cgi?id=109020

Reviewed by David Hyatt.

Source/WebCore:

Tests: fast/forms/input-placeholder-layout-view.html
       fast/forms/textarea-placeholder-layout-view.html

Placeholder elements don't affect layout so shouldn't contribute overflow either.

* rendering/RenderTextControlSingleLine.cpp:
(WebCore::RenderTextControlSingleLine::layout):

LayoutTests:

* fast/forms/input-placeholder-layout-view-expected.html: Added.
* fast/forms/input-placeholder-layout-view.html: Added.
* fast/forms/textarea-placeholder-layout-view-expected.html: Added.
* fast/forms/textarea-placeholder-layout-view.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@143475 268f45cc-cd09-0410-ab3c-d52691b4dbfc