WebKit-https.git
10 years ago2010-05-21 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Fri, 21 May 2010 18:14:11 +0000 (18:14 +0000)]
2010-05-21  Victor Wang  <victorw@chromium.org>

        Unremivewed. Update test expecations for chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59940 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 21 May 2010 17:20:53 +0000 (17:20 +0000)]
2010-05-21  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Need a short description and bug URL (OOPS!)

        Removed the unused entry in the CallFrame, and reordered CallFrame
        writes on the hot path to be in forwards order.

        SunSpider says 0.3% faster.

        * interpreter/RegisterFile.h:
        (JSC::RegisterFile::):
        * jit/JITCall.cpp:
        (JSC::JIT::compileOpCall):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Robin Cao <robin.cao@torchmobile.com.cn>
eric@webkit.org [Fri, 21 May 2010 16:55:52 +0000 (16:55 +0000)]
2010-05-21  Robin Cao  <robin.cao@torchmobile.com.cn>

        Reviewed by Adam Roben.

        fast/dom/HTMLObjectElement/children-changed.html times out on Windows run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=31315

        * platform/win/Skipped: The test should pass now.
2010-05-21  Robin Cao  <robin.cao@torchmobile.com.cn>

        Reviewed by Adam Roben.

        fast/dom/HTMLObjectElement/children-changed.html times out on Windows run-webkit-tests
        https://bugs.webkit.org/show_bug.cgi?id=31315

        * DumpRenderTree/win/FrameLoadDelegate.cpp:
        (FrameLoadDelegate::didFailProvisionalLoadWithError): Need to invoke locationChangeDone here as mac port does.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed build fix for WebKit2
steveblock@google.com [Fri, 21 May 2010 16:31:18 +0000 (16:31 +0000)]
Unreviewed build fix for WebKit2

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
jparent@chromium.org [Fri, 21 May 2010 16:27:11 +0000 (16:27 +0000)]
Unreviewed.

Updating Chromium test_expectations for newly added test,
svg/animations/animate-points.html which uses unsupported API.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Steve Block <steveblock@google.com>
steveblock@google.com [Fri, 21 May 2010 16:06:54 +0000 (16:06 +0000)]
2010-05-21  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Add DeviceOrientation and DeviceOrientationClient
        https://bugs.webkit.org/show_bug.cgi?id=39479

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
2010-05-21  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Add DeviceOrientation and DeviceOrientationClient
        https://bugs.webkit.org/show_bug.cgi?id=39479

        * Api/qwebpage.cpp:
        (QWebPagePrivate::QWebPagePrivate):
2010-05-21  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Add DeviceOrientation and DeviceOrientationClient
        https://bugs.webkit.org/show_bug.cgi?id=39479

        * webkit/webkitwebview.cpp:
        (webkit_web_view_init):
2010-05-21  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Add DeviceOrientation and DeviceOrientationClient
        https://bugs.webkit.org/show_bug.cgi?id=39479

        * WebView.cpp:
        (WebView::initWithFrame):
2010-05-21  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Add DeviceOrientation and DeviceOrientationClient
        https://bugs.webkit.org/show_bug.cgi?id=39479

        * WebView/WebView.mm:
        (-[WebView _commonInitializationWithFrameName:groupName:usesDocumentViews:]):
2010-05-21  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Add DeviceOrientation and DeviceOrientationClient
        https://bugs.webkit.org/show_bug.cgi?id=39479

        The page owns a DeviceOrientation object, which has a pointer to a
        DeviceOrientationClient object provided by the embedder. The
        DeviceOrientation object forwards requests to start listening to
        orientation to the client, and when updates are available, fires a
        DeviceOrientationEvent on the window object.

        No new tests are possible at this time as the implementation is
        incomplete. Future patches will add LayoutTestController methods
        to provide mock orientation events to test this.

        * Android.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.base.exp:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj
        * WebCore.xcodeproj/project.pbxproj:
        * dom/DeviceOrientation.cpp: Added.
        (WebCore::DeviceOrientation::DeviceOrientation):
        (WebCore::DeviceOrientation::onDeviceOrientationChange):
        * dom/DeviceOrientation.h: Added.
        * dom/DeviceOrientationClient.h: Added.
        (WebCore::DeviceOrientationClient::~DeviceOrientationClient):
        * page/Page.cpp:
        (WebCore::Page::Page):
        * page/Page.h:
        (WebCore::Page::deviceOrientation):
        * svg/graphics/SVGImage.cpp:
        (WebCore::SVGImage::dataChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Tasuku Suzuki <tasuku.suzuki@nokia.com>
eric@webkit.org [Fri, 21 May 2010 15:28:36 +0000 (15:28 +0000)]
2010-05-21  Tasuku Suzuki  <tasuku.suzuki@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] Fix compilation with QT_NO_GRAPHICSEFFECT
        https://bugs.webkit.org/show_bug.cgi?id=38324

        * platform/graphics/qt/GraphicsLayerQt.cpp:
        (WebCore::GraphicsLayerQtImpl::flushChanges):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Fri, 21 May 2010 15:01:23 +0000 (15:01 +0000)]
2010-05-21  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Darin Fisher.

        Fix the HistoryController::pushState.

        It should be possible to call the pushState method from
        the first page in a window.

        history.pushState doesn't work for the first page in a window.
        https://bugs.webkit.org/show_bug.cgi?id=39418

        * loader/HistoryController.cpp:
        (WebCore::HistoryController::pushState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Victoria Kirst <vrk@google.com>
eric@webkit.org [Fri, 21 May 2010 14:44:02 +0000 (14:44 +0000)]
2010-05-21  Victoria Kirst  <vrk@google.com>

        Reviewed by David Levin.

        [chromium] Fix slider status when buffering
        https://bugs.webkit.org/show_bug.cgi?id=39370
        Adjusts the buffering bar to be aligned with the slider thumb.

        No new tests. (Covered by existing layout tests.)

        * rendering/RenderMediaControlsChromium.cpp:
        (WebCore::paintMediaSlider):
        Added logic to align the buffering bar with the thumb. Half of the
        thumb image is transparent, so the buffer bar is adjusted to fill in
        this gap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Jesus Sanchez-Palencia <jesus@webkit.org>
eric@webkit.org [Fri, 21 May 2010 14:21:38 +0000 (14:21 +0000)]
2010-05-21  Jesus Sanchez-Palencia  <jesus@webkit.org>

        Reviewed by Eric Seidel.

        Extra processesArguments() calls in Document::processViewport
        https://bugs.webkit.org/show_bug.cgi?id=39358

        The viewport arguments are only needed when there is a frame->page(),
        therefore we don't need to always call processArguments().

        * dom/Document.cpp:
        (WebCore::Document::processViewport):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
eric@webkit.org [Fri, 21 May 2010 13:42:27 +0000 (13:42 +0000)]
2010-05-21  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Split the QScriptValue autotest into smaller chunks.

        File tst_qscriptvalue_generated.cpp was huge and it was difficult to compile
        it with MSVS2008, because of the code optimization.

        Tests were splited into a few files for better use of distributed
        compilation.
        Repeated calls to insert() and operator<<() where replaced by loops,
        that should reduce time of code optimizing.

        New files were generated by the same application, test logic wasn't changed.

        [Qt] The QScriptValue autotest should be refactored.
        https://bugs.webkit.org/show_bug.cgi?id=38987

        * qt/tests/qscriptvalue/qscriptvalue.pro:
        * qt/tests/qscriptvalue/tst_qscriptvalue.h:
        * qt/tests/qscriptvalue/tst_qscriptvalue_generated.cpp: Removed.
        * qt/tests/qscriptvalue/tst_qscriptvalue_generated_init.cpp: Added.
        (tst_QScriptValue::initScriptValues):
        * qt/tests/qscriptvalue/tst_qscriptvalue_generated_istype.cpp: Added.
        (tst_QScriptValue::isValid_initData):
        (tst_QScriptValue::isValid_makeData):
        (tst_QScriptValue::isValid_test):
        (tst_QScriptValue::isBool_initData):
        (tst_QScriptValue::isBool_makeData):
        (tst_QScriptValue::isBool_test):
        (tst_QScriptValue::isBoolean_initData):
        (tst_QScriptValue::isBoolean_makeData):
        (tst_QScriptValue::isBoolean_test):
        (tst_QScriptValue::isNumber_initData):
        (tst_QScriptValue::isNumber_makeData):
        (tst_QScriptValue::isNumber_test):
        (tst_QScriptValue::isFunction_initData):
        (tst_QScriptValue::isFunction_makeData):
        (tst_QScriptValue::isFunction_test):
        (tst_QScriptValue::isNull_initData):
        (tst_QScriptValue::isNull_makeData):
        (tst_QScriptValue::isNull_test):
        (tst_QScriptValue::isString_initData):
        (tst_QScriptValue::isString_makeData):
        (tst_QScriptValue::isString_test):
        (tst_QScriptValue::isUndefined_initData):
        (tst_QScriptValue::isUndefined_makeData):
        (tst_QScriptValue::isUndefined_test):
        (tst_QScriptValue::isObject_initData):
        (tst_QScriptValue::isObject_makeData):
        (tst_QScriptValue::isObject_test):
        * qt/tests/qscriptvalue/tst_qscriptvalue_generated_totype.cpp: Added.
        (tst_QScriptValue::toString_initData):
        (tst_QScriptValue::toString_makeData):
        (tst_QScriptValue::toString_test):
        (tst_QScriptValue::toNumber_initData):
        (tst_QScriptValue::toNumber_makeData):
        (tst_QScriptValue::toNumber_test):
        (tst_QScriptValue::toBool_initData):
        (tst_QScriptValue::toBool_makeData):
        (tst_QScriptValue::toBool_test):
        (tst_QScriptValue::toBoolean_initData):
        (tst_QScriptValue::toBoolean_makeData):
        (tst_QScriptValue::toBoolean_test):
        (tst_QScriptValue::toInteger_initData):
        (tst_QScriptValue::toInteger_makeData):
        (tst_QScriptValue::toInteger_test):
        (tst_QScriptValue::toInt32_initData):
        (tst_QScriptValue::toInt32_makeData):
        (tst_QScriptValue::toInt32_test):
        (tst_QScriptValue::toUInt32_initData):
        (tst_QScriptValue::toUInt32_makeData):
        (tst_QScriptValue::toUInt32_test):
        (tst_QScriptValue::toUInt16_initData):
        (tst_QScriptValue::toUInt16_makeData):
        (tst_QScriptValue::toUInt16_test):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 21 May 2010 13:18:41 +0000 (13:18 +0000)]
2010-05-17  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GStreamer] video painting support on mac port
        https://bugs.webkit.org/show_bug.cgi?id=39206

        ImageGStreamer support for mac port. A CG Image is created using
        the GstBuffer data. It can then be painted by the gstreamer player.

        * platform/graphics/gstreamer/ImageGStreamer.h:
        * platform/graphics/gstreamer/ImageGStreamerCG.mm: Added.
        (ImageGStreamer::createImage):
        (ImageGStreamer::ImageGStreamer):
        (ImageGStreamer::~ImageGStreamer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Robin Cao <robin.cao@torchmobile.com.cn>
eric@webkit.org [Fri, 21 May 2010 12:53:06 +0000 (12:53 +0000)]
2010-05-21  Robin Cao  <robin.cao@torchmobile.com.cn>

        Reviewed by Eric Seidel.

        animateTransform does not work on gradientTransform
        https://bugs.webkit.org/show_bug.cgi?id=38115

        Tests if gradientTransform of a gradient is animateable.

        * svg/animations/animate-gradient-transform-expected.txt: Added.
        * svg/animations/animate-gradient-transform.html: Added.
        * svg/animations/script-tests/animate-gradient-transform.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
2010-05-21  Robin Cao  <robin.cao@torchmobile.com.cn>

        Reviewed by Eric Seidel.

        animateTransform does not work on gradientTransform
        https://bugs.webkit.org/show_bug.cgi?id=38115

        Tests: svg/animations/animate-gradient-transform.html

        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::hasValidTarget): Check if the target element is gradient.
        (WebCore::transformListFor): Ditto.
        (WebCore::SVGAnimateTransformElement::resetToBaseValue): Ditto.
        (WebCore::SVGAnimateTransformElement::applyResultsToTarget): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Young Han Lee <joybro@company100.net>
eric@webkit.org [Fri, 21 May 2010 12:15:29 +0000 (12:15 +0000)]
2010-05-21  Young Han Lee  <joybro@company100.net>

        Reviewed by Eric Seidel.

        Fix guard around DatabaseSync
        https://bugs.webkit.org/show_bug.cgi?id=38897

        * storage/DatabaseSync.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGeolocation LayoutTests should use standard template pattern
steveblock@google.com [Fri, 21 May 2010 11:59:34 +0000 (11:59 +0000)]
Geolocation LayoutTests should use standard template pattern
https://bugs.webkit.org/show_bug.cgi?id=39301

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Prospective Qt/Mac build fix
hausmann@webkit.org [Fri, 21 May 2010 11:14:53 +0000 (11:14 +0000)]
[Qt] Prospective Qt/Mac build fix

My cpp is paranoid and doesn't like #if Q_WS_MAC:
error: #if with no expression

* page/qt/EventHandlerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Fri, 21 May 2010 11:03:21 +0000 (11:03 +0000)]
2010-05-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Eric Seidel.

        [EFL] Update Localized Strings. Remove markers from strings
        since we are not using them and they are only polluting output.
        https://bugs.webkit.org/show_bug.cgi?id=39371

        No new tests required.

        * platform/efl/LocalizedStringsEfl.cpp:
        (WebCore::contextMenuItemTagOpenLinkInNewWindow):
        (WebCore::contextMenuItemTagDownloadLinkToDisk):
        (WebCore::contextMenuItemTagCopyLinkToClipboard):
        (WebCore::contextMenuItemTagOpenImageInNewWindow):
        (WebCore::contextMenuItemTagDownloadImageToDisk):
        (WebCore::contextMenuItemTagCopyImageToClipboard):
        (WebCore::contextMenuItemTagOpenFrameInNewWindow):
        (WebCore::contextMenuItemTagSelectAll):
        (WebCore::contextMenuItemTagUnicode):
        (WebCore::contextMenuItemTagInputMethods):
        (WebCore::contextMenuItemTagGoBack):
        (WebCore::contextMenuItemTagGoForward):
        (WebCore::contextMenuItemTagReload):
        (WebCore::contextMenuItemTagIgnoreSpelling):
        (WebCore::contextMenuItemTagLearnSpelling):
        (WebCore::contextMenuItemTagSearchWeb):
        (WebCore::contextMenuItemTagLookUpInDictionary):
        (WebCore::contextMenuItemTagOpenLink):
        (WebCore::contextMenuItemTagIgnoreGrammar):
        (WebCore::contextMenuItemTagSpellingMenu):
        (WebCore::contextMenuItemTagCheckSpelling):
        (WebCore::contextMenuItemTagCheckGrammarWithSpelling):
        (WebCore::contextMenuItemTagFontMenu):
        (WebCore::contextMenuItemTagOutline):
        (WebCore::contextMenuItemTagInspectElement):
        (WebCore::searchMenuClearRecentSearchesText):
        (WebCore::missingPluginText): Add missing message.
        (WebCore::multipleFileUploadText):
        (WebCore::crashedPluginText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Lucas De Marchi <lucas.demarchi@profusion.mobi>
eric@webkit.org [Fri, 21 May 2010 10:34:33 +0000 (10:34 +0000)]
2010-05-21  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Eric Seidel.

        [EF] Fix support for focus ring.
        https://bugs.webkit.org/show_bug.cgi?id=39387

        No new tests required.

        * html/HTMLAnchorElement.cpp: Add EFL to #ifdef
        (WebCore::HTMLAnchorElement::isMouseFocusable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 21 May 2010 09:56:55 +0000 (09:56 +0000)]
2010-05-21  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add missing localized string symbols.
        https://bugs.webkit.org/show_bug.cgi?id=39394

        Add missingPluginText and crashedPluginText.

        * platform/brew/LocalizedStringsBrew.cpp:
        (WebCore::missingPluginText):
        (WebCore::crashedPluginText):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59922 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 21 May 2010 09:40:04 +0000 (09:40 +0000)]
2010-05-21  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        Add COMPILER(MSVC) guard for strnstr
        https://bugs.webkit.org/show_bug.cgi?id=39397

        BREWMP uses MSVC for simulator build, but it is not OS(WINDOWS).
        Add COMPILER(MSVC) guard for strnstr.

        * wtf/StringExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-21 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 21 May 2010 09:24:47 +0000 (09:24 +0000)]
2010-05-21  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add !PLATFORM(BREWMP) guard for isMainThread
        https://bugs.webkit.org/show_bug.cgi?id=39396

        BREWMP sets ENABLE(SINGLE_THREADED), so it uses isMainThread from ThreadingNone.cpp.
        Exclude isMainThread in MainThread.cpp.

        * wtf/MainThread.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSymbian build fix.
hausmann@webkit.org [Fri, 21 May 2010 09:23:15 +0000 (09:23 +0000)]
Symbian build fix.

[Qt] Updated the wins def file with one new export.

The DRT symbols are still missing, but I can't build DRT ;(

* symbian/bwins/QtWebKitu.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCalls to CallJNIMethodIDA() in JavaInstance::invokeMethod() are required on Android
steveblock@google.com [Fri, 21 May 2010 08:52:22 +0000 (08:52 +0000)]
Calls to CallJNIMethodIDA() in JavaInstance::invokeMethod() are required on Android

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Tony Chang <tony@chromium.org>
tony@chromium.org [Fri, 21 May 2010 07:57:42 +0000 (07:57 +0000)]
2010-05-20  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        escape link text when copying or dragging links on win or chromium
        https://bugs.webkit.org/show_bug.cgi?id=39413

        * editing/pasteboard/drop-link-expected.txt: Added.
        * editing/pasteboard/drop-link.html:
        * platform/chromium-linux/editing/pasteboard/drop-link-expected.checksum: Removed.
        * platform/chromium-linux/editing/pasteboard/drop-link-expected.png: Removed.
        * platform/chromium-linux/editing/pasteboard/drop-link-expected.txt: Removed.
        * platform/chromium-win/editing/pasteboard/drop-link-expected.checksum: Removed.
        * platform/chromium-win/editing/pasteboard/drop-link-expected.png: Removed.
        * platform/chromium-win/editing/pasteboard/drop-link-expected.txt: Removed.
        * platform/mac/editing/pasteboard/drop-link-expected.checksum: Removed.
        * platform/mac/editing/pasteboard/drop-link-expected.png: Removed.
        * platform/mac/editing/pasteboard/drop-link-expected.txt: Removed.
2010-05-20  Tony Chang  <tony@chromium.org>

        Reviewed by Kent Tamura.

        escape link text when copying or dragging links on win or chromium
        https://bugs.webkit.org/show_bug.cgi?id=39413

        * editing/markup.cpp:
        (WebCore::urlToMarkup):
        * editing/markup.h:
        * platform/chromium/ClipboardUtilitiesChromium.cpp:
        * platform/chromium/ClipboardUtilitiesChromium.h:
        * platform/win/ClipboardUtilitiesWin.cpp:
        * platform/win/ClipboardUtilitiesWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59917 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Fri, 21 May 2010 06:17:42 +0000 (06:17 +0000)]
2010-05-20  Daniel Bates  <dbates@rim.com>

        Rubber-stamped by Simon Fraser.

        Spelling correction; change "acces" [sic] to "access".

        * quality/lifecycle.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59916 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-18 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Fri, 21 May 2010 06:10:12 +0000 (06:10 +0000)]
2010-05-18  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Carlson.

        [GStreamer] PlatformMedia support
        https://bugs.webkit.org/show_bug.cgi?id=39300

        Basic support for PlatformMedia in the gst player. The
        PlatformMedia object contains a GStreamerGWorld object. That
        object is empty for now. XOverlay features will be added later
        on for easy review sake.

        * GNUmakefile.am:
        * platform/graphics/MediaPlayer.h:
        (WebCore::PlatformMedia::):
        * platform/graphics/gstreamer/GStreamerGWorld.cpp: Added.
        (WebCore::GStreamerGWorld::createGWorld):
        (WebCore::GStreamerGWorld::GStreamerGWorld):
        (WebCore::GStreamerGWorld::~GStreamerGWorld):
        * platform/graphics/gstreamer/GStreamerGWorld.h: Added.
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
        (WebCore::MediaPlayerPrivateGStreamer::platformMedia):
        (WebCore::MediaPlayerPrivateGStreamer::createGSTPlayBin):
        * platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59915 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 21 May 2010 05:58:38 +0000 (05:58 +0000)]
2010-05-20  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add dummy SSLKeyGenerator
        https://bugs.webkit.org/show_bug.cgi?id=39403

        Add dummy implementation of SSLKeyGenerator.

        * platform/brew/SSLKeyGeneratorBrew.cpp: Added.
        (WebCore::WebCore::getSupportedKeySizes):
        (WebCore::WebCore::signedPublicKeyAndChallengeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/7848154> Remove the dependency on Foundation's private __COCOA_FORMAL...
mrowe@apple.com [Fri, 21 May 2010 05:23:58 +0000 (05:23 +0000)]
<rdar://problem/7848154> Remove the dependency on Foundation's private __COCOA_FORMAL_PROTOCOLS_2__ define.

Rubber-stamped by Dan Bernstein.

WebCore:

* platform/mac/EmptyProtocolDefinitions.h:

WebKitTools:

* DumpRenderTree/mac/LayoutTestControllerMac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 21 May 2010 05:15:24 +0000 (05:15 +0000)]
2010-05-20  Simon Fraser  <simon.fraser@apple.com>

        Build fix, no review.

        Fix the non-accelerated-compositing Windows build with some
        #if USE(ACCELERATED_COMPOSITING) loving.

        * WebView.cpp:
        * WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 21 May 2010 05:09:03 +0000 (05:09 +0000)]
2010-05-20  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add Editor
        https://bugs.webkit.org/show_bug.cgi?id=39404

        Implement Editor::newGeneralClipboard.

        * editing/brew/EditorBrew.cpp: Added.
        (WebCore::Editor::newGeneralClipboard):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59911 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 21 May 2010 04:49:20 +0000 (04:49 +0000)]
2010-05-20  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Adam Roben.

        Avoid flushing CA layers when a layout is pending
        https://bugs.webkit.org/show_bug.cgi?id=39463
        <rdar://problem/7999463>

        Avoid rendering the compositing layers to the screen if there's a layout pending,
        since the layer tree not in a state that should be presented to the user.

        This fixes flashes in some types of content that dynamically add and remove layers.

        Do this by adding a WKCACFLayerRendererClient for WKCACFLayerRenderer, which it can
        call through to ask whether now is a good time to render. If not, it schedules
        another render soon.

        * platform/graphics/win/WKCACFLayerRenderer.h:
        (WebCore::WKCACFLayerRendererClient::~WKCACFLayerRendererClient):
        * platform/graphics/win/WKCACFLayerRenderer.cpp:
        (WebCore::WKCACFLayerRenderer::acceleratedCompositingAvailable):
        (WebCore::WKCACFLayerRenderer::create):
        (WebCore::WKCACFLayerRenderer::WKCACFLayerRenderer):
        (WebCore::WKCACFLayerRenderer::render):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59910 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 21 May 2010 04:41:54 +0000 (04:41 +0000)]
2010-05-20  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Don't include CoreFoundation.h when building for BREW MP
        https://bugs.webkit.org/show_bug.cgi?id=39405

        Add !defined(BUILDING_BREWMP__) guard for CoreFoundation.h.

        * WebCorePrefix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59909 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 21 May 2010 04:19:35 +0000 (04:19 +0000)]
2010-05-20  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Use skia as BREW MP's graphics backend.
        https://bugs.webkit.org/show_bug.cgi?id=39407

        Define WTF_PLATFORM_SKIA=1 for BREW MP.

        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59908 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Kwang Yul Seo <skyul@company100.net>
eric@webkit.org [Fri, 21 May 2010 03:56:14 +0000 (03:56 +0000)]
2010-05-20  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Eric Seidel.

        [BREWMP] Add ScrollTheme
        https://bugs.webkit.org/show_bug.cgi?id=39406

        As BREW MP always uses frame flattening, there is no need to render scorllbars.
        Use the default scrollbar theme with thickness 0.

        * platform/brew/ScrollbarThemeBrew.cpp: Added.
        (WebCore::ScrollbarTheme::nativeTheme):
        (WebCore::ScrollbarThemeBrew::~ScrollbarThemeBrew):
        * platform/brew/ScrollbarThemeBrew.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Tony Gentilcore <tonyg@chromium.org>
eric@webkit.org [Fri, 21 May 2010 03:42:55 +0000 (03:42 +0000)]
2010-05-20  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Daniel Bates.

        Look in /proc/registry64 for the Platform SDK on 64-bit Windows.
        https://bugs.webkit.org/show_bug.cgi?id=39296

        The build-webkit script failed for me on Vista 64. A web search turned
        up this blog post with a patch that worked for me:
        http://www.nicholaswilson.me.uk/2010/04/hacking-webkit-fail/

        * Scripts/webkitdirs.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFixed naming mixup: it's op_call_put_result, not ret_result.
ggaren@apple.com [Fri, 21 May 2010 03:39:00 +0000 (03:39 +0000)]
Fixed naming mixup: it's op_call_put_result, not ret_result.

Reviewed by Beth Dakin.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::privateExecute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59905 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoREGRESSION(r53637): DivX plug-in fails to start until window is resized
jhoneycutt@apple.com [Fri, 21 May 2010 03:20:27 +0000 (03:20 +0000)]
REGRESSION(r53637): DivX plug-in fails to start until window is resized
https://bugs.webkit.org/show_bug.cgi?id=39457
<rdar://problem/8006102>

Before r53637, we called Widget::move() (which caused us to call
NPP_SetWindow) before painting a plug-in. r53637 removed the call to
Widget::move(), and we end up never calling NPP_SetWindow for plug-ins
with the "DeferFirstSetWindowCall" quirk, including the DivX plug-in.

Reviewed by Simon Fraser.

* manual-tests/divx-plugin-fails-to-draw.html: Added.

* plugins/PluginView.cpp:
(WebCore::PluginView::PluginView):
Initialize new member to false.

* plugins/PluginView.h:
Added new member.

* plugins/win/PluginViewWin.cpp:
(WebCore::PluginView::paint):
Call setNPWindowRect() before painting to ensure that NPP_SetWindow gets
called.
(WebCore::PluginView::setNPWindowRect):
Set m_haveCalledSetWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59904 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Fumitoshi Ukai <ukai@chromium.org>
ukai@chromium.org [Fri, 21 May 2010 03:06:42 +0000 (03:06 +0000)]
2010-05-20  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
        https://bugs.webkit.org/show_bug.cgi?id=35572

        Fix LayoutTests for new WebSocket protocol.
        It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.

        * websocket/tests/handshake-error-expected.txt: Update expected data.
        * websocket/tests/handshake-error_wsh.py: Without CRLF, the wsh will sends "ThisWillCauseHandshakeErrorHTTP/1.1 101 WebSocket Protocol Handshake\r\n", which is legal for the first line of draft 76 WebSocket opening handshake. (4.1 Opening Handhshake, step 28 to 30).  To fail handshake, it needs \r\n.
        * websocket/tests/long-invalid-header-expected.txt:  Originally, it expects Upgrade header after status line.  In draft 76, order is not important.  But "pppp..\r\n" would fail because it misses ":" (end of name) before \r.
2010-05-20  Fumitoshi Ukai  <ukai@chromium.org>

        Reviewed by Alexey Proskuryakov.

        WebSocket handshake incompatible change in draft-hixie-thewebsocketprotocol-76
        https://bugs.webkit.org/show_bug.cgi?id=35572

        WebSocket opening handshake is changed.  New protocol draft could be found at http://www.whatwg.org/specs/web-socket-protocol/
        It requires https://bugs.webkit.org/show_bug.cgi?id=38034 to pass websocket tests.

        * websockets/WebSocketHandshake.cpp:
        (WebCore::extractResponseCode):
        add lineLength parameter to return length of status line.
        (WebCore::hostName): Added.
        (WebCore::generateSecWebSocketKey): Added.
        (WebCore::generateKey3): Added.
        (WebCore::setChallengeNumber): Added.
        (WebCore::generateChallengeResponseExpected): Added.
        (WebCore::WebSocketHandshake::WebSocketHandshake):
         generate challenge response key and expected data.
        (WebCore::WebSocketHandshake::clientLocation):
         use hostName.
        (WebCore::WebSocketHandshake::clientHandshakeMessage):
         changed for draft 76 spec.
        (WebCore::WebSocketHandshake::clientHandshakeRequest):
        (WebCore::WebSocketHandshake::readServerHandshake):
         changed for draft 76 spec.
         m_mode is managed in this method.
        (WebCore::WebSocketHandshake::readHTTPHeaders):
         change error log messages.
        (WebCore::WebSocketHandshake::processHeaders):
         chagned for draft 76 spec.
        (WebCore::WebSocketHandshake::checkResponseHeaders):
         return boolean whether response header is ok or not and not change m_mode in it.
        * websockets/WebSocketHandshake.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59903 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 21 May 2010 03:04:28 +0000 (03:04 +0000)]
2010-05-20  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        ThreadedMessageQueue should use with_statement for exception safety
        https://bugs.webkit.org/show_bug.cgi?id=39233

        * Scripts/webkitpy/common/thread/threadedmessagequeue.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Viet-Trung Luu <viettrungluu@chromium.org>
eric@webkit.org [Fri, 21 May 2010 02:52:36 +0000 (02:52 +0000)]
2010-05-20  Viet-Trung Luu  <viettrungluu@chromium.org>

        Reviewed by Darin Fisher.

        [Chromium] Don't rely on focused node to route mouse events to plugins.
        https://bugs.webkit.org/show_bug.cgi?id=39375
        http://crbug.com/43935

        On mouse down, do a hit test and check if a plugin was hit. If so, then
        save the node for future mouse events (until mouse up or capture lost).

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::mouseDown):
        (WebKit::WebViewImpl::handleInputEvent):
        (WebKit::WebViewImpl::mouseCaptureLost):
        * src/WebViewImpl.h: Remove m_haveMouseCapture; add m_mouseCaptureNode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Fri, 21 May 2010 02:44:41 +0000 (02:44 +0000)]
2010-05-20  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update test expectations for chromium.

        * platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
        * platform/chromium-linux/fast/css/font-face-in-shadow-DOM-expected.png: Added.
        * platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
        * platform/chromium-win/fast/css/font-face-in-shadow-DOM-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 21 May 2010 02:34:43 +0000 (02:34 +0000)]
2010-05-20  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        fast/canvas/webgl/texture-npot.html failed on leopard bot
        https://bugs.webkit.org/show_bug.cgi?id=39128

        * fast/canvas/webgl/texture-npot-expected.txt: Adding the failed test cases back.
        * fast/canvas/webgl/texture-npot.html:
        * platform/mac-leopard/Skipped: Skip texture-npot.html on leopard for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59899 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Dominic Mazzoni <dmazzoni@chromium.org>
eric@webkit.org [Fri, 21 May 2010 02:19:35 +0000 (02:19 +0000)]
2010-05-20  Dominic Mazzoni  <dmazzoni@chromium.org>

        Reviewed by Darin Fisher.

        Add headingLevel and setFocused methods.

        https://bugs.webkit.org/show_bug.cgi?id=39238

        * public/WebAccessibilityObject.h:
        * src/WebAccessibilityObject.cpp:
        (WebKit::WebAccessibilityObject::headingLevel):
        (WebKit::WebAccessibilityObject::setFocused):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59898 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoStop leaking all CACFContexts
aroben@apple.com [Fri, 21 May 2010 02:14:10 +0000 (02:14 +0000)]
Stop leaking all CACFContexts

Fixes <http://webkit.org/b/39466> <rdar://problem/8007141>.

Reviewed by Simon Fraser.

* platform/graphics/win/WKCACFContextFlusher.cpp:
(WebCore::WKCACFContextFlusher::addContext): Only retain the context
when we first add it to the m_contexts set. Otherwise we'll retain the
same context multiple times, causing it to leak.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59897 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Diego Gonzalez <diegohcg@webkit.org>
eric@webkit.org [Fri, 21 May 2010 02:02:29 +0000 (02:02 +0000)]
2010-05-20  Diego Gonzalez  <diegohcg@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] QtTestBrowser does not support websites which requires HTTP Authentication via dialogs
        https://bugs.webkit.org/show_bug.cgi?id=38456

        * QtTestBrowser/webpage.cpp:
        (WebPage::WebPage):
        (WebPage::authenticationRequired):
        * QtTestBrowser/webpage.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59896 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Fri, 21 May 2010 02:01:25 +0000 (02:01 +0000)]
2010-05-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Whittling away at CodeBlock use: Removed a little wonkiness in closure lookup
        https://bugs.webkit.org/show_bug.cgi?id=39444

        Calculate all lookup depths at compile time. I'm not sure why we couldn't
        do this before, but whatever the reason, it seems to be gone now.

        * bytecompiler/BytecodeGenerator.cpp:
        (JSC::BytecodeGenerator::findScopedProperty):
        * bytecompiler/BytecodeGenerator.h:
        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::resolveSkip):
        (JSC::Interpreter::resolveGlobalDynamic):
        (JSC::Interpreter::privateExecute):
        * jit/JITOpcodes.cpp:
        (JSC::JIT::emit_op_get_scoped_var):
        (JSC::JIT::emit_op_put_scoped_var):
        (JSC::JIT::emit_op_resolve_skip):
        (JSC::JIT::emit_op_resolve_global_dynamic):
        (JSC::JIT::emitSlow_op_resolve_global_dynamic):
        * jit/JITOpcodes32_64.cpp:
        (JSC::JIT::emit_op_get_scoped_var):
        (JSC::JIT::emit_op_put_scoped_var):
        (JSC::JIT::emit_op_resolve_skip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59895 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Young Han Lee <joybro@company100.net>
eric@webkit.org [Fri, 21 May 2010 01:45:42 +0000 (01:45 +0000)]
2010-05-20  Young Han Lee  <joybro@company100.net>

        Reviewed by Darin Adler.

        Create filenameFromString for all ports except GTK and EFL.
        https://bugs.webkit.org/show_bug.cgi?id=39348

        * platform/FileSystem.cpp: Added.
        (WebCore::filenameFromString):
        * platform/FileSystem.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59894 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWhen using a scale factor > 1, scrollbars sometimes appear when not necessary
mthole@apple.com [Fri, 21 May 2010 01:40:26 +0000 (01:40 +0000)]
When using a scale factor > 1, scrollbars sometimes appear when not necessary
https://bugs.webkit.org/show_bug.cgi?id=39458

Reviewed by Dave Hyatt.

* WebView/WebDynamicScrollBarsView.mm:
(-[WebDynamicScrollBarsView updateScrollers]): Round up non-integral sizes from AppKit
so that they can be compared against the integral document size.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59891 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Young Han Lee <joybro@company100.net>
eric@webkit.org [Fri, 21 May 2010 01:19:40 +0000 (01:19 +0000)]
2010-05-20  Young Han Lee  <joybro@company100.net>

        Reviewed by Darin Adler.

        Port SharedBuffer to POSIX.
        https://bugs.webkit.org/show_bug.cgi?id=39283

        * platform/posix/SharedBufferPOSIX.cpp: Added.
        (WebCore::SharedBuffer::createWithContentsOfFile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59890 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Zhenyao Mo <zmo@google.com>
eric@webkit.org [Fri, 21 May 2010 01:06:34 +0000 (01:06 +0000)]
2010-05-20  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
        https://bugs.webkit.org/show_bug.cgi?id=39077

        * fast/canvas/webgl/framebuffer-object-attachment-expected.txt: Add the test cases for color renderbuffer creation and attachment to framebuffer.
        * fast/canvas/webgl/framebuffer-object-attachment.html: Ditto.
2010-05-20  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
        https://bugs.webkit.org/show_bug.cgi?id=39077

        * platform/graphics/mac/GraphicsContext3DMac.cpp:
        (WebCore::GraphicsContext3D::renderbufferStorage): Mapping the enums.
2010-05-20  Zhenyao Mo  <zmo@google.com>

        Reviewed by Dimitri Glazkov.

        Map RGBA4/RGB5_A1 to RGBA and RGB565 to RGB in RenderbufferStorage
        https://bugs.webkit.org/show_bug.cgi?id=39077

        * src/WebGraphicsContext3DDefaultImpl.cpp:
        (WebKit::WebGraphicsContext3DDefaultImpl::renderbufferStorage): Mapping the enums.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8007953> Textarea using custom font appears blank
mitz@apple.com [Fri, 21 May 2010 00:37:06 +0000 (00:37 +0000)]
<rdar://problem/8007953> Textarea using custom font appears blank

Reviewed by Dave Hyatt.

WebCore:

Test: fast/css/font-face-in-shadow-DOM.html

When a remote font is loaded, CSSFontSelector forces a style recalc, which replaces all
RenderSyles that have FontFallbackLists referencing the placeholder font with fresh
RenderStyles. However, it does not descend into shadow DOM trees, so those may end up with
styles that still reference the placeholder font.

The fix is to add RenderObject::requiresForcedStyleRecalcPropagation() and have it return
true from renderers that maintain shadow DOM trees or otherwise keep their own RenderStyles.

* dom/Element.cpp:
(WebCore::Element::recalcStyle): Check if forced style recalc needs to propagated.
* rendering/RenderButton.h:
(WebCore::RenderButton::requiresForcedStyleRecalcPropagation):
* rendering/RenderDataGrid.h:
(WebCore::RenderDataGrid::requiresForcedStyleRecalcPropagation):
* rendering/RenderFileUploadControl.h:
(WebCore::RenderFileUploadControl::requiresForcedStyleRecalcPropagation):
* rendering/RenderListItem.h:
(WebCore::RenderListItem::requiresForcedStyleRecalcPropagation):
* rendering/RenderMedia.h:
(WebCore::RenderMedia::requiresForcedStyleRecalcPropagation):
* rendering/RenderMenuList.h:
(WebCore::RenderMenuList::RenderMenuList::requiresForcedStyleRecalcPropagation):
* rendering/RenderObject.h:
(WebCore::RenderObject::requiresForcedStyleRecalcPropagation):
* rendering/RenderProgress.h:
(WebCore::RenderProgress::requiresForcedStyleRecalcPropagation):
* rendering/RenderSlider.h:
(WebCore::RenderSlider::requiresForcedStyleRecalcPropagation):
* rendering/RenderTextControl.h:
(WebCore::RenderTextControl::requiresForcedStyleRecalcPropagation):

LayoutTests:

* fast/css/font-face-in-shadow-DOM.html: Added.
* platform/mac/fast/css/font-face-in-shadow-DOM-expected.checksum: Added.
* platform/mac/fast/css/font-face-in-shadow-DOM-expected.png: Added.
* platform/mac/fast/css/font-face-in-shadow-DOM-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNo review; build fix only.
jer.noble@apple.com [Thu, 20 May 2010 23:02:40 +0000 (23:02 +0000)]
No review; build fix only.

When WTF_USE_ACCELERATED_COMPOSITING is turned off, MediaPlayerPrivateQuickTimeVisualContext.cpp
must include CoreGraphics/CGContext.h.

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 20 May 2010 22:51:52 +0000 (22:51 +0000)]
2010-05-20  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        Tests that use Geolocation.getCurrentPosition fail
        https://bugs.webkit.org/show_bug.cgi?id=39454

        * platform/gtk/Skipped: Skip failing tests until this bug is resolved.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59872 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 20 May 2010 22:41:42 +0000 (22:41 +0000)]
2010-05-20  Jer Noble  <jer.noble@apple.com>

        Reviewed by Sam Weinig.

        Video elements show no video on Windows machines that do not support accelerated compositing
        https://bugs.webkit.org/show_bug.cgi?id=39446
        rdar://problem/7999794

        Implement the paint() method in MediaPlayerPrivateQuickTimeVisualContext.  The visual context should
        be set up in load() and torn down in the destructor (as opposed to setUpVideoRendering and
        tearDownVideoRendering, which won't get called in a non-accelerated compositing case).

        * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::~MediaPlayerPrivateQuickTimeVisualContext):
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::load):
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint):
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::visualContextTimerFired):
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::setUpVideoRendering):
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::tearDownVideoRendering):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59871 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Abhishek Arya <inferno@chromium.org>
victorw@chromium.org [Thu, 20 May 2010 22:32:45 +0000 (22:32 +0000)]
2010-05-20  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Added method to WebSecurityOrigin for invoking
        SecurityOrigin::canAccessPasswordManager.
        https://bugs.webkit.org/show_bug.cgi?id=38916

        * public/WebSecurityOrigin.h:
        * src/WebSecurityOrigin.cpp:
        (WebKit::WebSecurityOrigin::canAccessPasswordManager):
2010-05-20  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Adam Barth.

        Added a method to check if the security origin can access
        password manager.
        https://bugs.webkit.org/show_bug.cgi?id=38916

        * page/SecurityOrigin.h:
        (WebCore::SecurityOrigin::canAccessPasswordManager):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59870 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Thu, 20 May 2010 22:27:39 +0000 (22:27 +0000)]
2010-05-20  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update test expectations for chromium.

        * platform/chromium-mac/svg/filters/feLighting-crash-expected.checksum: Added.
        * platform/chromium-mac/svg/filters/feLighting-crash-expected.png: Added.
        * platform/chromium-win/svg/filters/feLighting-crash-expected.checksum: Added.
        * platform/chromium-win/svg/filters/feLighting-crash-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Darin Adler <darin@apple.com>
darin@apple.com [Thu, 20 May 2010 22:17:49 +0000 (22:17 +0000)]
2010-05-20  Darin Adler  <darin@apple.com>

        Reviewed by Eric Seidel.

        Fix warnings seen on the buildbots today
        https://bugs.webkit.org/show_bug.cgi?id=39368

        * profiler/ProfileNode.cpp:
        (JSC::getCount): Removed unneeded initialization of global variable.
        These are all initialized to zero anyway, so no need to try to initialize
        it and get a warning.

        * wtf/CurrentTime.cpp:
        (WTF::currentTime): Removed unused global variable.
2010-05-20  Darin Adler  <darin@apple.com>

        Reviewed by Eric Seidel.

        Fix warnings seen on the buildbots today
        https://bugs.webkit.org/show_bug.cgi?id=39368

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::pruneUnretainedIcons): Use the type "long long" for
        things being printed with "%lli". There is no guaranteed that int64_t is the
        same thing as long long.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::handleMousePressEvent): Added parentheses as suggested
        by warnings in newer versions of GCC.

        * platform/ContextMenu.cpp: Fix #if around the functions to match the #if
        around the call sites to avoid unused function warning.

        * platform/graphics/gtk/ImageGtk.cpp:
        (WebCore::Image::loadPlatformResource): Use NULL to end a variable argument list
        rather than 0. This is a case where the WebKit "use 0 instead of NULL" guideline
        is incorrect and won't work properly.

        * platform/win/SystemTimeWin.cpp:
        (WebCore::userIdleTime): Removed unnecessary initialization of LASTINPUTINFO.

        * platform/win/WebCoreInstanceHandle.h: Added property svn:eol-style.
        Made functions inline instead of static. It's not correct to have functions with
        internal linkage in a header file. Marking them inline makes more sense.

        * plugins/win/PluginMessageThrottlerWin.cpp:
        (WebCore::PluginMessageThrottlerWin::PluginMessageThrottlerWin): Reordered the
        initializers to match the order of the data members from the class definition.

        * plugins/win/PluginViewWin.cpp:
        (WebCore::PluginView::paintIntoTransformedContext): Initialized all the fields
        of WINDOWPOS. I know this goes against the traditions of Windows programming,
        but it's correct and silences the warning. Also removed the unneeded separate
        code path for non-WinCE platforms that translates only the corner of the window
        rectangle; the WinCE version is correct for normal Windows as well. Not sure
        why this wasn't caught when the code was originally checked in.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 20 May 2010 22:05:24 +0000 (22:05 +0000)]
2010-05-20  Martin Robinson  <mrobinson@igalia.com>

        Not reviewed.

        https://bugs.webkit.org/show_bug.cgi?id=39388
        Re-enable geolocation tests on GTK+ now that this bug is closed.

        * platform/gtk/Skipped: Re-enable geolocation tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Justin Schuh <jschuh@chromium.org>
yaar@chromium.org [Thu, 20 May 2010 21:56:45 +0000 (21:56 +0000)]
2010-05-20  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        Moving frame.src checks out of the bindings
        https://bugs.webkit.org/show_bug.cgi?id=37815

        Moved JavaScript frame.src checks out of bindings and into
        HTMLFrameElementBase. Added main thread state stack to JavaScriptCore
        so ExecState is available inside core DOM. Updated affected bindings
        (except for GObject, which will need to be updated to avoid origin
        failures inside native code).

        * Android.jscbindings.mk:
        * CMakeLists.txt:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSBindingsAllInOne.cpp:
        * bindings/js/JSCallbackData.cpp:
        (WebCore::JSCallbackData::invokeCallback):
        * bindings/js/JSEventListener.cpp:
        (WebCore::JSEventListener::handleEvent):
        * bindings/js/JSInjectedScriptHostCustom.cpp:
        (WebCore::InjectedScriptHost::createInjectedScript):
        * bindings/js/JSMainThreadExecState.cpp: Added.
        * bindings/js/JSMainThreadExecState.h: Added.
        (WebCore::JSMainThreadExecState::currentState):
        (WebCore::JSMainThreadExecState::call):
        (WebCore::JSMainThreadExecState::evaluate):
        (WebCore::JSMainThreadExecState::JSMainThreadExecState):
        (WebCore::JSMainThreadExecState::~JSMainThreadExecState):
        (WebCore::JSMainThreadNullState::JSMainThreadNullState):
        * bindings/js/ScheduledAction.cpp:
        (WebCore::ScheduledAction::executeFunctionInContext):
        (WebCore::ScheduledAction::execute):
        * bindings/js/ScheduledAction.h:
        * bindings/js/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInWorld):
        (WebCore::ScriptController::canAccessFromCurrentOrigin):
        * bindings/js/ScriptController.h:
        * bindings/js/ScriptFunctionCall.cpp:
        (WebCore::ScriptFunctionCall::call):
        * bindings/objc/ObjCEventListener.mm:
        * bindings/objc/WebScriptObject.mm:
        (-[WebScriptObject callWebScriptMethod:withArguments:]):
        (-[WebScriptObject evaluateWebScript:]):
        * bindings/scripts/CodeGeneratorObjC.pm:
        * bindings/scripts/test/ObjC/DOMTestCallback.mm:
        (-[DOMTestCallback callbackWithClass1Param:]):
        (-[DOMTestCallback callbackWithClass2Param:strArg:]):
        (-[DOMTestCallback callbackWithNonBoolReturnType:]):
        (-[DOMTestCallback customCallback:class6Param:]):
        * bindings/scripts/test/ObjC/DOMTestInterface.mm:
        * bindings/scripts/test/ObjC/DOMTestObj.mm:
        (-[DOMTestObj readOnlyIntAttr]):
        (-[DOMTestObj readOnlyStringAttr]):
        (-[DOMTestObj readOnlyTestObjAttr]):
        (-[DOMTestObj intAttr]):
        (-[DOMTestObj setIntAttr:]):
        (-[DOMTestObj longLongAttr]):
        (-[DOMTestObj setLongLongAttr:]):
        (-[DOMTestObj unsignedLongLongAttr]):
        (-[DOMTestObj setUnsignedLongLongAttr:]):
        (-[DOMTestObj stringAttr]):
        (-[DOMTestObj setStringAttr:]):
        (-[DOMTestObj testObjAttr]):
        (-[DOMTestObj setTestObjAttr:]):
        (-[DOMTestObj attrWithException]):
        (-[DOMTestObj setAttrWithException:]):
        (-[DOMTestObj attrWithSetterException]):
        (-[DOMTestObj setAttrWithSetterException:]):
        (-[DOMTestObj attrWithGetterException]):
        (-[DOMTestObj setAttrWithGetterException:]):
        (-[DOMTestObj customAttr]):
        (-[DOMTestObj setCustomAttr:]):
        (-[DOMTestObj scriptStringAttr]):
        (-[DOMTestObj voidMethod]):
        (-[DOMTestObj voidMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj intMethod]):
        (-[DOMTestObj intMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj objMethod]):
        (-[DOMTestObj objMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj methodThatRequiresAllArgs:objArg:]):
        (-[DOMTestObj methodThatRequiresAllArgsAndThrows:objArg:]):
        (-[DOMTestObj serializedValue:]):
        (-[DOMTestObj methodWithException]):
        (-[DOMTestObj customMethod]):
        (-[DOMTestObj customMethodWithArgs:strArg:objArg:]):
        (-[DOMTestObj customArgsAndException:]):
        (-[DOMTestObj addEventListener:listener:useCapture:]):
        (-[DOMTestObj removeEventListener:listener:useCapture:]):
        (-[DOMTestObj withDynamicFrame]):
        (-[DOMTestObj withDynamicFrameAndArg:]):
        (-[DOMTestObj withDynamicFrameAndOptionalArg:optionalArg:]):
        (-[DOMTestObj withDynamicFrameAndUserGesture:]):
        (-[DOMTestObj withDynamicFrameAndUserGestureASAD:optionalArg:]):
        (-[DOMTestObj withScriptStateVoid]):
        (-[DOMTestObj withScriptStateObj]):
        (-[DOMTestObj withScriptStateVoidException]):
        (-[DOMTestObj withScriptStateObjException]):
        (-[DOMTestObj methodWithOptionalArg:]):
        (-[DOMTestObj methodWithNonOptionalArgAndOptionalArg:opt:]):
        (-[DOMTestObj methodWithNonOptionalArgAndTwoOptionalArgs:opt1:opt2:]):
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::canAccessFromCurrentOrigin):
        * bindings/v8/ScriptController.h:
        * html/HTMLFrameElementBase.cpp:
        (WebCore::HTMLFrameElementBase::isURLAllowed):
2010-05-20  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Adam Barth.

        Moving frame.src checks out of the bindings
        https://bugs.webkit.org/show_bug.cgi?id=37815

        * http/tests/security/xss-DENIED-iframe-src-alias-expected.txt:
        * http/tests/security/xss-DENIED-iframe-src-alias.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Anders Carlsson.
kdecker@apple.com [Thu, 20 May 2010 21:55:56 +0000 (21:55 +0000)]
    Reviewed by Anders Carlsson.

        https://bugs.webkit.org/show_bug.cgi?id=39441
        <rdar://problem/7985715> Flash context menu is both horizontally and vertically offset from point of click
        <rdar://problem/7986109> Youtube video controller UI entirely missing
        <rdar://problem/7986154> Flash content paints at horizontally and vertically shifted locations (within the plug-in region)

        * Plugins/Hosted/WebHostedNetscapePluginView.mm:
        (-[WebHostedNetscapePluginView updateAndSetWindow]): The base coordinates of a window and
         it's contentView happen to be the equal at a userSpaceScaleFactor of 1. For non-1.0 scale
         factors this assumption is false. Accordingly we now convert to the window contentView
        coordinate system when computing bounds in "window" and the visible rect.
        * Plugins/WebNetscapePluginView.mm:
        (-[WebNetscapePluginView saveAndSetNewPortStateForUpdate:]): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix an HRGN leak in WKCACFLayerRenderer
aroben@apple.com [Thu, 20 May 2010 21:30:59 +0000 (21:30 +0000)]
Fix an HRGN leak in WKCACFLayerRenderer

Fixes <http://webkit.org/b/39312> <rdar://problem/7998728> REGRESSION
(r53686-r55990): Graphics corruption when watching video (affects
youtube.com)

Reviewed by Darin Adler.

* platform/graphics/win/WKCACFLayerRenderer.cpp:
(WebCore::getDirtyRects): Use an OwnPtr to hold the HRGN we allocate.
That way we don't have to remember to destroy it (as we were
forgetting to do) when we bail out of this function early.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 20 May 2010 21:20:03 +0000 (21:20 +0000)]
2010-05-20  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Darin Adler.

        Removed some reliance on callFame[CodeBlock] by storing CodeBlock in a
        local variable in the Interpreter.
        https://bugs.webkit.org/show_bug.cgi?id=39447

        Small speedup on SunSpider in Interpreter mode.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::privateExecute):
        * jsc.cpp:
        * wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Darin Fisher <darin@chromium.org>
darin@chromium.org [Thu, 20 May 2010 20:49:26 +0000 (20:49 +0000)]
2010-05-20  Darin Fisher  <darin@chromium.org>

        Reviewed by Nate Chapin.

        [chromium] Provide a way to catch exceptions thrown while interacting
        with a NPObject via WebBindings methods.
        https://bugs.webkit.org/show_bug.cgi?id=39378

        This change also includes a small bit of cleanup in V8NPObject and
        friends.  I moved code into the WebCore namespace where appropriate.

        In _NPN_Invoke, I also moved the call to _NPN_Evaluate outside of the
        context scope.  I did this to avoid having nested ExceptionCatcher
        objects, which is not strictly necessary, but it seemed cleaner.
        _NPN_Evaluate already takes care of creating a context scope.

        * bindings/v8/NPV8Object.cpp:
        (WebCore::v8ObjectToNPObject):
        (WebCore::npCreateV8ScriptObject):
        (_NPN_Invoke):
        (_NPN_InvokeDefault):
        (_NPN_Evaluate):
        (_NPN_EvaluateHelper):
        (_NPN_GetProperty):
        (_NPN_SetProperty):
        (_NPN_RemoveProperty):
        (_NPN_HasProperty):
        (_NPN_HasMethod):
        (_NPN_SetException):
        (_NPN_Enumerate):
        (_NPN_Construct):
        * bindings/v8/NPV8Object.h:
        * bindings/v8/V8NPObject.cpp:
        * bindings/v8/V8NPObject.h:
        * bindings/v8/V8NPUtils.cpp:
        (WebCore::convertV8ObjectToNPVariant):
        (WebCore::pushExceptionHandler):
        (WebCore::popExceptionHandler):
        (WebCore::ExceptionCatcher::ExceptionCatcher):
        (WebCore::ExceptionCatcher::~ExceptionCatcher):
        * bindings/v8/V8NPUtils.h:
        * bindings/v8/npruntime.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 20 May 2010 20:20:57 +0000 (20:20 +0000)]
2010-05-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Eric Seidel.

        editingBehavior settings needs to be set back to a reasonable default between tests
        https://bugs.webkit.org/show_bug.cgi?id=39433

        For now, hard code the default setting during reset, so that the serialized
        version of the setting stays in sync with expectations.

        * DumpRenderTree/mac/DumpRenderTree.mm:
        (resetDefaultsToConsistentValues): Reset editing behavior to the appropriate platform default.
        * DumpRenderTree/win/DumpRenderTree.cpp:
        (resetDefaultsToConsistentValues): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBug 39408 - Unify JIT/interpreter return behaviour.
barraclough@apple.com [Thu, 20 May 2010 20:12:44 +0000 (20:12 +0000)]
Bug 39408 - Unify JIT/interpreter return behaviour.

Reviewed by Oliver Hunt.

Presently the JIT and the interpreter have differing implementations in how
they handle storing the result of a function call back to the register file.
In both cases the op_call ( / _eval / _varargs / op_construct) opcode has an
operand indicating the VM register in which the result should be stored.
The JIT plants code after the call to store the result, so the value will be
stored as soon as the callee has returned.  In the interpreter the call
passes the return value register id into the callee via the callee callframe,
and the callee is responsible for writing the result back into its callers
register file after it has restored the parents callframe pointer, but before
returning.

Instead, move the task of writing the call result to the register file into a
new opcode (op_call_put_result), and after returning the callee should leave
the return value in a canonical location.  In the case of the interpreter,
this canonical location is a local variable in privateExecute
(functionReturnValue), in the case of the JIT this is the normal return value
registers (regT0, or regT1:regT0 in JSVALUE32_64).  op_call_put_result stores
the result from the canonical location to the registerfile.

In addition to unifying JIT & interpreter behaviour this change allows us to
remove a slot from the callframe, omit the write of the result where the
return value from the call is not used, and provides a 2% speedup on sunspider
in the interpreter.

* bytecode/CodeBlock.cpp:
(JSC::CodeBlock::dump):
* bytecode/Opcode.h:
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitCall):
(JSC::BytecodeGenerator::emitCallVarargs):
(JSC::BytecodeGenerator::emitConstruct):
* bytecompiler/BytecodeGenerator.h:
(JSC::BytecodeGenerator::finalDestinationOrIgnored):
* bytecompiler/NodesCodegen.cpp:
(JSC::NewExprNode::emitBytecode):
(JSC::FunctionCallValueNode::emitBytecode):
(JSC::FunctionCallResolveNode::emitBytecode):
(JSC::FunctionCallBracketNode::emitBytecode):
(JSC::FunctionCallDotNode::emitBytecode):
(JSC::CallFunctionCallDotNode::emitBytecode):
(JSC::ApplyFunctionCallDotNode::emitBytecode):
* interpreter/CallFrame.h:
(JSC::ExecState::init):
(JSC::ExecState::noCaller):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::throwException):
(JSC::Interpreter::privateExecute):
* interpreter/RegisterFile.h:
(JSC::RegisterFile::):
* jit/JIT.cpp:
(JSC::JIT::privateCompileMainPass):
* jit/JIT.h:
* jit/JITCall.cpp:
(JSC::JIT::compileOpCallSetupArgs):
(JSC::JIT::compileOpConstructSetupArgs):
(JSC::JIT::emit_op_call_put_result):
(JSC::JIT::compileOpCallVarargs):
(JSC::JIT::compileOpCallVarargsSlowCase):
(JSC::JIT::compileOpCall):
(JSC::JIT::compileOpCallSlowCase):
(JSC::JIT::compileOpCallVarargsSetupArgs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Marcus Bulach <bulach@chromium.org>
steveblock@google.com [Thu, 20 May 2010 20:10:12 +0000 (20:10 +0000)]
2010-05-20  Marcus Bulach  <bulach@chromium.org>

        Reviewed by Steve Block.

        Ensure timers are stopped on Geolocation::disconnectFrame()
        https://bugs.webkit.org/show_bug.cgi?id=39388

        fast/dom/Geolocation/notimer-after-unload.html, plus it should be possible to re-enable Gtk LayoutTests.

        * page/Geolocation.cpp:
        (WebCore::Geolocation::disconnectFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoBuild fix. No review.
bfulgham@webkit.org [Thu, 20 May 2010 19:44:30 +0000 (19:44 +0000)]
Build fix.  No review.

The WebKitAPITest targets do not use the "_debug" suffix needed
by the WinCairo port.  Added Debug_Cairo target to correct this.

* WebKitAPITest/WebKitAPITest.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 20 May 2010 19:32:07 +0000 (19:32 +0000)]
2010-05-20  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        editingBehavior settings needs to be set back to a reasonable default between tests
        https://bugs.webkit.org/show_bug.cgi?id=39433

        I forgot to revert the expected results for this test after reverting it.

        * editing/selection/extend-selection-after-double-click-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 20 May 2010 19:18:29 +0000 (19:18 +0000)]
2010-05-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        Ensures styles are up-to-date before determining selection
        https://bugs.webkit.org/show_bug.cgi?id=39389

        This adds a call to document::updateStyleIfNeeded() to
        Frame::notifyRendererOfSelectionChange(). Without this call, if there
        is a pending style update that will detach part of the DOM and the
        the selection is within that part of the DOM when
        notifyRendererOfSeletionChange is called, the rootEditableElement
        algorithm ends up walking through detached parts of the render tree.

        Test: editing/selection/focus-and-display-none.html

        * page/Frame.cpp:
        (WebCore::Frame::notifyRendererOfSelectionChange):
2010-05-20  James Robinson  <jamesr@chromium.org>

        Reviewed by Eric Seidel.

        Tests putting focus into a textarea and setting display:none
        https://bugs.webkit.org/show_bug.cgi?id=39389

        * editing/selection/focus-and-display-none-expected.txt: Added.
        * editing/selection/focus-and-display-none.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[WinCairo] Correct scaling for print preview
bfulgham@webkit.org [Thu, 20 May 2010 19:14:37 +0000 (19:14 +0000)]
[WinCairo] Correct scaling for print preview
https://bugs.webkit.org/show_bug.cgi?id=39329

Reviewed by Adam Roben.

Cairo does not properly deal with Windows HDCs that have been
scaled using MM_ANISOTROPIC mapping mode, and a WindowExt and
ViewportExt setting.
(see http://bugs.freedesktop.org/show_bug.cgi?id=28161)

Instead, reset the HDC's WorldTransform to be unscaled, then
scale the cairo context to the desired scaling, and perform
the drawing operation.

* WebFrame.cpp:
(WebFrame::drawHeader): Use pre-positioned context to simplify
  this method.
(WebFrame::drawFooter): Use pre-positioned context to simplify
  this method.
(WebFrame::spoolPage): Revise scaling logic to turn off HDC
  scaling, and scale using only Cairo.  Revert scaling at end
  so that user-defined GDI-based routines (e.g., header/footer)
  will draw in the right position.
(WebFrame::spoolPages): Identify print preview case, and
  retrieve scaling factors from preview context.  Set the
  Cairo context to use these factors during the spoolPage
  operation.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove code that fetched, but did nothing useful with, a CFDictionary in MediaPlayerP...
aroben@apple.com [Thu, 20 May 2010 18:51:54 +0000 (18:51 +0000)]
Remove code that fetched, but did nothing useful with, a CFDictionary in MediaPlayerPrivateQuickTimeVisualContext

I also removed the code in QTPixelBuffer that vended the dictionary.

Fixes <http://webkit.org/b/39435> <rdar://problem/8009278>
QTPixelBuffer passes CFDictionaries across the DLL boundary, which can
lead to crashes

Reviewed by Darin Adler.

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::MediaPlayerPrivateQuickTimeVisualContext::retrieveCurrentImage):
Deleted code that fetched the attachments dictionary, which was never
used other than to pass it to CFRetain/CFRelease, which could be
enough to cause a crash due to incompatible copies of
CoreFoundation.dll.

* platform/graphics/win/QTMovieVisualContext.h: Added a now-needed
forward declaration.

* platform/graphics/win/QTPixelBuffer.cpp:
* platform/graphics/win/QTPixelBuffer.h:
Removed the now-unused attachments function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix a CFData leak in MediaPlayerPrivateQuickTimeVisualContext
aroben@apple.com [Thu, 20 May 2010 18:51:33 +0000 (18:51 +0000)]
Fix a CFData leak in MediaPlayerPrivateQuickTimeVisualContext

Fixes <http://webkit.org/b/39432> <rdar://problem/8008992>

Reviewed by Ada Chan

* platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
(WebCore::QTCFDictionaryCreateWithDataCallback): Use a RetainPtr to
hold the CFData we allocate so it will get released when this function
is exited. Also pass kCFAllocatorNull as the bytes deallocator to
CFDataCreateWithBytesNoCopy so that CF doesn't try to deallocate the
bytes we pass to it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 20 May 2010 18:36:30 +0000 (18:36 +0000)]
2010-05-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Ojan Vafai.

        editingBehavior settings needs to be set back to a reasonable default between tests
        https://bugs.webkit.org/show_bug.cgi?id=39433

        Revert the changes from r59840 to this test until there is a method
        in the WebKit APIs to consistently reset the editingBehavior setting
        to a reasonable default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename GenericTask* to CrossThreadTask* in CrossThreadTask.h.
jianli@chromium.org [Thu, 20 May 2010 18:32:42 +0000 (18:32 +0000)]
Rename GenericTask* to CrossThreadTask* in CrossThreadTask.h.
https://bugs.webkit.org/show_bug.cgi?id=39437

Reviewed by David Levin.

* dom/CrossThreadTask.h:
(WebCore::):
(WebCore::CrossThreadTask1::create):
(WebCore::CrossThreadTask1::CrossThreadTask1):
(WebCore::CrossThreadTask2::create):
(WebCore::CrossThreadTask2::CrossThreadTask2):
(WebCore::CrossThreadTask3::create):
(WebCore::CrossThreadTask3::CrossThreadTask3):
(WebCore::CrossThreadTask4::create):
(WebCore::CrossThreadTask4::CrossThreadTask4):
(WebCore::CrossThreadTask5::create):
(WebCore::CrossThreadTask5::CrossThreadTask5):
(WebCore::CrossThreadTask6::create):
(WebCore::CrossThreadTask6::CrossThreadTask6):
(WebCore::CrossThreadTask7::create):
(WebCore::CrossThreadTask7::CrossThreadTask7):
(WebCore::CrossThreadTask8::create):
(WebCore::CrossThreadTask8::CrossThreadTask8):
(WebCore::createCallbackTask):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Victor Wang <victorw@chromium.org>
victorw@chromium.org [Thu, 20 May 2010 18:31:45 +0000 (18:31 +0000)]
2010-05-20  Victor Wang  <victorw@chromium.org>

        Unreviewed. Update test expectations from chromium.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory.
jianli@chromium.org [Thu, 20 May 2010 17:57:38 +0000 (17:57 +0000)]
Rename GenericWorkerTask.h to CrossThreadTask.h and move it to dom directory.
https://bugs.webkit.org/show_bug.cgi?id=39135

Reviewed by David Levin.

WebCore:

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* dom/CrossThreadTask.h: Renamed from WebCore/workers/GenericWorkerTask.h.
* html/FileStreamProxy.cpp:
* loader/WorkerThreadableLoader.cpp:
* websockets/WorkerThreadableWebSocketChannel.cpp:
* workers/DefaultSharedWorkerRepository.cpp:
* workers/WorkerMessagingProxy.cpp:
* workers/WorkerScriptLoader.cpp:

WebKit/chromium:

* src/WebSharedWorkerImpl.cpp:
* src/WebWorkerBase.cpp:
* src/WebWorkerClientImpl.cpp:
* src/WebWorkerImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove the Safari welcome page site-specific quirk, since its no longer needed.
adele@apple.com [Thu, 20 May 2010 17:44:13 +0000 (17:44 +0000)]
Remove the Safari welcome page site-specific quirk, since its no longer needed.

Reviewed by Mark Rowe.

* css/CSSStyleSheet.cpp: (WebCore::CSSStyleSheet::cssRules):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Steve Block <steveblock@google.com>
steveblock@google.com [Thu, 20 May 2010 17:37:43 +0000 (17:37 +0000)]
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.

        * Configurations/FeatureDefines.xcconfig:
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Adds ENABLE_DEVICE_ORIENTATION to VisualStudio project files, always disabled.

        * win/tools/vsprops/FeatureDefines.vsprops:
        * win/tools/vsprops/FeatureDefinesCairo.vsprops:
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Adds ENABLE_DEVICE_ORIENTATION to XCode project file, always disabled.

        * Configurations/FeatureDefines.xcconfig:
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Tests: fast/dom/DeviceOrientation/window-property.html
               fast/dom/Window/window-properties-on-device-orientation.html

        Adds bindings for DeviceOrientation as defined in
        http://dev.w3.org/geo/api/spec-source-orientation.html
        This is guarded by ENABLE(DEVICE_ORIENTATION) which is currently disabled on
        all platforms but Android.

        * Android.derived.jscbindings.mk:
        * Android.derived.v8bindings.mk:
        * Android.mk:
        * Configurations/FeatureDefines.xcconfig:
        * DerivedSources.cpp:
        * DerivedSources.make:
        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pri:
        * WebCore.pro:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/v8/custom/V8EventCustom.cpp:
        (WebCore::toV8):
        * dom/DeviceOrientationEvent.cpp: Added.
        (WebCore::DeviceOrientationEvent::DeviceOrientationEvent):
        (WebCore::DeviceOrientationEvent::initDeviceOrientationEvent):
        * dom/DeviceOrientationEvent.h: Added.
        (WebCore::DeviceOrientationEvent::create):
        (WebCore::DeviceOrientationEvent::alpha):
        (WebCore::DeviceOrientationEvent::beta):
        (WebCore::DeviceOrientationEvent::gamma):
        (WebCore::DeviceOrientationEvent::isDeviceOrientationEvent):
        * dom/DeviceOrientationEvent.idl: Added.
        * dom/Event.cpp:
        (WebCore::Event::isDeviceOrientationEvent):
        * dom/Event.h:
        * dom/EventNames.h:
        * page/DOMWindow.h:
        * page/DOMWindow.idl:
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Jeremy Orlow.

        Provide bindings for DeviceOrientation
        https://bugs.webkit.org/show_bug.cgi?id=39210

        Modifies existing fast/dom/Window tests to skip window.ondeviceorientation until
        it is widely supported.
        Adds new fast/dom/Window/window-properties-on-device-orientation.html to test
        type and presence of window.ondeviceorientation.
        Adds new fast/dom/DeviceOrientation directory and initial test.
        Adds all DeviceOrientation tests to all skipped lists.

        * fast/dom/DeviceOrientation: Added.
        * fast/dom/DeviceOrientation/script-tests: Added.
        * fast/dom/DeviceOrientation/script-tests/TEMPLATE.html: Added.
        * fast/dom/DeviceOrientation/script-tests/window-property.js: Added.
        (hasOnDeviceOrientationProperty):
        * fast/dom/DeviceOrientation/window-property-expected.txt: Added.
        * fast/dom/DeviceOrientation/window-property.html: Added.
        * fast/dom/Window/script-tests/window-property-descriptors.js:
        * fast/dom/Window/window-properties-on-device-orientation-expected.txt: Added.
        * fast/dom/Window/window-properties-on-device-orientation.html: Added.
        * fast/dom/Window/window-properties.html:
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUse 0.15 as text drag delay when Q_WS_MAC is defined, which is
kenneth@webkit.org [Thu, 20 May 2010 17:26:42 +0000 (17:26 +0000)]
Use 0.15 as text drag delay when Q_WS_MAC is defined, which is
consistent with the Mac OS X platform.

Rubberstamped by Antti Koivisto.

* page/qt/EventHandlerQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 20 May 2010 17:24:31 +0000 (17:24 +0000)]
2010-05-20  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Touch WebKit.idl to ensure that interfaces rebuild.

        * Interfaces/WebKit.idl: Touched.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 20 May 2010 17:15:03 +0000 (17:15 +0000)]
2010-05-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Ojan Vafai.

        editing/selection/extend-selection-after-double-click.html crashes on the Leopard Intel release bot
        https://bugs.webkit.org/show_bug.cgi?id=39431

        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setEditingBehavior):
        Prevent a double-free by not having this variable be in the auto-release pool.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 20 May 2010 16:48:01 +0000 (16:48 +0000)]
2010-05-20  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Adam Roben.

        Fix the Windows build and move new IDL declarations to the bottom of the file.

        * Interfaces/IWebPreferences.idl: Move new API to the bottom of the IDL file to prevent vtable mismatch.
        * WebPreferences.cpp:
        (WebPreferences::setEditingBehavior): Change the type of the parameter to setEditingBehavior to the proper type.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 20 May 2010 16:19:54 +0000 (16:19 +0000)]
2010-05-20  Martin Robinson  <mrobinson@igalia.com>

        Unreviewed.

        Fix the Windows build.

        * WebView.cpp:
        (WebView::notifyPreferencesChanged): Change behavior to 'editingBehavior'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Touch WebKit.idl as usual.
tkent@chromium.org [Thu, 20 May 2010 16:11:21 +0000 (16:11 +0000)]
Unreviewed.  Touch WebKit.idl as usual.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Martin Robinson <mrobinson@webkit.org>
mrobinson@webkit.org [Thu, 20 May 2010 15:48:37 +0000 (15:48 +0000)]
2010-05-20  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Ojan Vafai.

        Expose the editing behavior setting in DRT to test all editing code paths
        https://bugs.webkit.org/show_bug.cgi?id=38603

        * editing/selection/extend-selection-after-double-click.html: Use the new DRT support for changing editing behavior.
        * editing/selection/extend-selection-after-double-click-expected.txt: Update expected results to reflect both behaviors.
2010-05-20  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Ojan Vafai.

        Expose the editing behavior setting in DRT to test all editing code paths
        https://bugs.webkit.org/show_bug.cgi?id=38603

        * public/WebSettings.h:
        (WebKit::WebSettings::): Added an enum for EditingBehavior types.
        * src/WebSettingsImpl.cpp:
        (WebKit::WebSettingsImpl::setEditingBehavior): Added.
        * src/WebSettingsImpl.h:
2010-05-20  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Ojan Vafai.

        Expose the editing behavior setting in DRT to test all editing code paths
        https://bugs.webkit.org/show_bug.cgi?id=38603

        * WebView/WebFrame.mm:
        (core):
        * WebView/WebFrameInternal.h: Added a conversion method from the API enum to the WebCore enum.
        * WebView/WebPreferenceKeysPrivate.h: Added a preference key for the new setting.
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]): Initialize the EditingBehavior to Mac style.
        (-[WebPreferences editingBehavior]): Added.
        (-[WebPreferences setEditingBehavior:]): Added.
        * WebView/WebPreferencesPrivate.h: Added the new API points to the private API.
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]): Set the editing behavior via the WebPreferences setting.
2010-05-20  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Ojan Vafai.

        Expose the editing behavior setting in DRT to test all editing code paths
        https://bugs.webkit.org/show_bug.cgi?id=38603

        Expose the EditingBehavior setting in the Windows API.

        * Interfaces/IWebPreferences.idl: Add the API point for setting the editing behavior.
        * WebPreferenceKeysPrivate.h: Add a key for the editing behavior setting.
        * WebPreferences.cpp:
        (WebPreferences::editingBehavior): Added.
        (WebPreferences::setEditingBehavior): Added.
        * WebPreferences.h: Add method declarations.
        * WebView.cpp:
        (WebView::notifyPreferencesChanged): Update the WebCore setting based on the WebPreferences setting.
2010-05-20  Martin Robinson  <mrobinson@webkit.org>

        Reviewed by Ojan Vafai.

        Expose the editing behavior setting in DRT to test all editing code paths
        https://bugs.webkit.org/show_bug.cgi?id=38603

        * DumpRenderTree/LayoutTestController.cpp:
        (setEditingBehaviorCallback): Added.
        (LayoutTestController::staticFunctions): Expose the setEditingBehaviorCallback function.
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp: Add callback method for setting editing behavior.
        * DumpRenderTree/chromium/LayoutTestController.h: Declaration for this method.
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setEditingBehavior): Implementation of editing behavior control.
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setEditingBehavior): Ditto
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control.
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        (LayoutTestController::setEditingBehavior): Add slot for controlling editor behavior.
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setEditingBehavior): Implementation of editing behavior control.
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setEditingBehavior): Added stub implementation of editing behavior control.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Thu, 20 May 2010 15:46:07 +0000 (15:46 +0000)]
2010-05-20  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        [DRT/Chromium] Increase the time out value
        https://bugs.webkit.org/show_bug.cgi?id=39203

        Change the time out value of Chromium DRT to 30 seconds, which is
        the same as other ports.
        If a DRT process exits before new-run-webkit-tests detects time
        out, new-run-webkit-tests assumes the DRT process crashed.

        * DumpRenderTree/chromium/TestShell.cpp:
        (TestShell::layoutTestTimeout):
          Change the time out value from 10 seconds to 30 seconds.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Janne Koskinen <janne.p.koskinen@digia.com>
eric@webkit.org [Thu, 20 May 2010 15:22:39 +0000 (15:22 +0000)]
2010-05-20  Janne Koskinen  <janne.p.koskinen@digia.com>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] WINSCW compile fix for qwebframe test
        https://bugs.webkit.org/show_bug.cgi?id=38722

        WINSCW cannot determine template type up the hierarchy
        to common base class.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix painting when using clipToImageBuffer()
hausmann@webkit.org [Thu, 20 May 2010 15:13:09 +0000 (15:13 +0000)]
Fix painting when using clipToImageBuffer()

Reviewed by Simon Hausmann.

When we apply the transform of the parent painter to the painter of
the transparency layer, we adopt its coordinate system, thus offset
should not be in page coordinates, but in the coordinate system of
the parent painter.

* platform/graphics/qt/GraphicsContextQt.cpp:
(WebCore::TransparencyLayer::TransparencyLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Thu, 20 May 2010 15:01:00 +0000 (15:01 +0000)]
2010-05-20  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        Remove unused "old style" private APIs

        These symbols were introduced after QtWebKit v4.6
        so no-one should be using them

        * WebCoreSupport/DumpRenderTreeSupportQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Adam Langley <agl@chromium.org>
agl@chromium.org [Thu, 20 May 2010 14:21:13 +0000 (14:21 +0000)]
2010-05-20  Adam Langley  <agl@chromium.org>

        Reviewed by David Levin.

        [chromium] Avoid crash when msttcorefonts aren't provided

        https://bugs.webkit.org/show_bug.cgi?id=39015
        http://code.google.com/p/chromium/issues/detail?id=43831

        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::createFontPlatformData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed. Update Qt specific expected file.
zherczeg@webkit.org [Thu, 20 May 2010 14:15:51 +0000 (14:15 +0000)]
Unreviewed. Update Qt specific expected file.

* platform/qt/svg/filters/feLighting-crash-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Rajiv Ramanasankaran <rajiv.ramanasankaran@nokia.com>
eric@webkit.org [Thu, 20 May 2010 13:56:59 +0000 (13:56 +0000)]
2010-05-20  Rajiv Ramanasankaran  <rajiv.ramanasankaran@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] QWebPage::inputMethodQuery() returns wrong values for Qt::ImCursorPosition, Qt::ImAnchorPosition
        https://bugs.webkit.org/show_bug.cgi?id=38779

        The earlier implementation was written with the assumption that in this scenario the
        anchor position always corresponds to the START index and that the current cursor position
        always corresponds to the END index in WebKit.

        Updated the implementation of QWebPage::inputMethodQuery(Qt::ImCursorPosition) and
        QWebPage::inputMethodQuery(Qt::ImAnchorPosition) for the case where the Editor is not in
        composition mode. In the non-composition mode, the Anchor and the Current cursor positions
        correspond to the Base and Extent position offsets in WebKit.

        Also added the auto-tests for the RIGHT to LEFT and LEFT to RIGHT selections.

        * Api/qwebpage.cpp:
        (QWebPage::inputMethodQuery): Now returning correct values for Qt::ImCursorPosition and
        Qt::ImAnchorPosition when the Editor is not in composition mode.
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods): Added auto-tests for RIGHT to LEFT and LEFT to RIGHT selections

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebCore: Fix a crash caused by feLigthing::apply()
zherczeg@webkit.org [Thu, 20 May 2010 13:53:06 +0000 (13:53 +0000)]
WebCore: Fix a crash caused by feLigthing::apply()
https://bugs.webkit.org/show_bug.cgi?id=39004

Reviewed by Dirk Schulze.

Make FELighting::apply() similar to other filters' applies
to avoid an assertion fail in putUnmultipliedImageData(),
when effectDrawingRect has negative location (x or y is less than 0).

Test: svg/filters/feLighting-crash.svg

* svg/graphics/filters/SVGFELighting.cpp:
(WebCore::FELighting::apply):

LayoutTests: In case of lighting SVG effects, a wider output rectangle
than the input image size should not cause crash.
https://bugs.webkit.org/show_bug.cgi?id=39004

Reviewed by Dirk Schulze.

* platform/mac/svg/filters/feLighting-crash-expected.checksum: Added.
* platform/mac/svg/filters/feLighting-crash-expected.png: Added.
* platform/mac/svg/filters/feLighting-crash-expected.txt: Added.
* platform/qt/svg/filters/feLighting-crash-expected.txt: Added.
* svg/filters/feLighting-crash.svg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Luiz Agostini <luiz.agostini@openbossa.org>
eric@webkit.org [Thu, 20 May 2010 13:43:58 +0000 (13:43 +0000)]
2010-05-20  Luiz Agostini  <luiz.agostini@openbossa.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Qt] Skipping popup focus test for maemo
        https://bugs.webkit.org/show_bug.cgi?id=39314

        Skipping popup focus test for maemo in qwebframe auto test.

        The test method tst_QWebFrame::popupFocus() was testing popup focus AND input
        field focus. The input field focus has been removed from the method popupFocus()
        and a new test method named inputFieldFocus() has been added. Finally the test
        method popupFocus() has been skipped for maemo.

        * tests/qwebframe/tst_qwebframe.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed.
cevans@google.com [Thu, 20 May 2010 13:02:31 +0000 (13:02 +0000)]
Unreviewed.

Marking myself as a committer.

* Scripts/webkitpy/common/config/committers.py: Add cevans@google.com.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Chris Jerdonek <cjerdonek@webkit.org>
cjerdonek@webkit.org [Thu, 20 May 2010 11:48:42 +0000 (11:48 +0000)]
2010-05-20  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Eric Seidel.

        Modified FrameLoader::urlSelected() to accept a KURL instead of a
        ResourceRequest.

        https://bugs.webkit.org/show_bug.cgi?id=39320

        Since ResourceRequest has non-explicit single-parameter constructors for
        String and KURL, urlSelected() previously accepted any of String, KURL,
        and ResourceRequest.  This revision changes urlSelected() to accept only
        a KURL to make the API tighter and easier to refactor.

        No new functionality, so no new tests.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::urlSelected):
          - Changed the public overload to accept a KURL instead of a ResourceRequest.
        * loader/FrameLoader.h:
          - Changed the public overload to accept a KURL instead of a ResourceRequest.
        * wml/WMLAElement.cpp:
        (WebCore::WMLAElement::defaultEventHandler):
          - Updated the call to urlSelected().
2010-05-20  Chris Jerdonek  <cjerdonek@webkit.org>

        Reviewed by Eric Seidel.

        Modified FrameLoader::urlSelected() to accept a KURL instead of a
        ResourceRequest.

        https://bugs.webkit.org/show_bug.cgi?id=39320

        Since ResourceRequest has non-explicit single-parameter constructors for
        String and KURL, urlSelected() previously accepted any of String, KURL,
        and ResourceRequest.  This revision changes urlSelected() to accept only
        a KURL to make the API tighter and easier to refactor.

        * WebCoreSupport/WebContextMenuClient.cpp:
        (WebContextMenuClient::searchWithGoogle):
          - Updated the call to urlSelected().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 MORITA Hajime <morrita@google.com>
morrita@google.com [Thu, 20 May 2010 11:07:10 +0000 (11:07 +0000)]
2010-05-20  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        2x execCommand ReadAV@NULL
        https://bugs.webkit.org/show_bug.cgi?id=35791

        This test passes if it doesn't crash.

        * editing/execCommand/35791-expected.txt: Added.
        * editing/execCommand/35791.html: Added.
2010-05-20  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        2x execCommand ReadAV@NULL
        https://bugs.webkit.org/show_bug.cgi?id=35791

        In applyBlockStyle(), a node which is referred from
        nextParagraphStart sometimes removed from the document and goes
        orphan, and that causes an assertion failed. This is because
        moveParagraphs() replaces the node with a new one with some new
        styles applied. So we re-compute nextParagraphStart in that case.

        Test: editing/execCommand/35791.html

        * dom/Position.h:
        (WebCore::Position::isOrphan):
        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::applyBlockStyle):
        * editing/VisiblePosition.h:
        (WebCore::VisiblePosition::isOrphan):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Weekly binary builds on Mac OS X don't work when launched in the Finder
hausmann@webkit.org [Thu, 20 May 2010 11:04:48 +0000 (11:04 +0000)]
[Qt] Weekly binary builds on Mac OS X don't work when launched in the Finder
https://bugs.webkit.org/show_bug.cgi?id=37273

Reviewed by Tor Arne Vestbo.

* QtTestBrowser/QtTestBrowser.pro: Build QtLauncher as bundle in package builds

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-20 Steve Block <steveblock@google.com>
steveblock@google.com [Thu, 20 May 2010 09:06:15 +0000 (09:06 +0000)]
2010-05-20  Steve Block  <steveblock@google.com>

        Reviewed by Eric Seidel.

        PluginView contains JSC-specific code
        https://bugs.webkit.org/show_bug.cgi?id=38907

        Build fix only, no new tests.

        * plugins/PluginView.cpp:
        (WebCore::PluginView::start):
        (WebCore::PluginView::stop):
        (WebCore::PluginView::performRequest):
        * plugins/PluginView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-05-17 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Thu, 20 May 2010 08:44:11 +0000 (08:44 +0000)]
2010-05-17  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Eric Seidel.

        [GStreamer] enable gst support if USE_GSTREAMER macro is defined
        https://bugs.webkit.org/show_bug.cgi?id=39205

        Include gstreamer private player in the build when the
        USE_GSTREAMER macro is enabled.

        * platform/graphics/MediaPlayer.cpp:
        (WebCore::installedMediaEngines):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@59825 268f45cc-cd09-0410-ab3c-d52691b4dbfc