WebKit-https.git
13 years ago * Makefile: Build DumpRenderTree too.
darin [Sun, 22 Oct 2006 01:15:59 +0000 (01:15 +0000)]
    * Makefile: Build DumpRenderTree too.
        * Scripts/do-webcore-rename: Removed bogus comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
thatcher [Sat, 21 Oct 2006 18:40:03 +0000 (18:40 +0000)]
WebCore:

        Reviewed by Geoff.

        <rdar://problem/4478625> HTML Editing: Basic table editing and culling

        Initial implementaltion of table deletion user interface:
        * Interface shows up on the nearest table containing the entire selection.
        * Shows a Dashboard style close button in the top left corner.
        * Shows a 60% opaque black outline around the table.
        * Adds a new EditorClient function shouldShowDeleteInterface.

        Also adds a new constructor CachedImage and setter functions on
        HTMLImageElement and HTMLImageLoader allowing an Image object to be set
        and image element in the page. This change also paves the way to allow an
        NSImage setter on DOMHTMLImageElement.

        * Resources/deleteButton.tiff: Added.
        * Resources/deleteButtonPressed.tiff: Added.
        * WebCore.xcodeproj/project.pbxproj:
        * bridge/EditorClient.h:
        * editing/DeleteButton.cpp: Added.
        (WebCore::DeleteButton::DeleteButton):
        (WebCore::DeleteButton::defaultEventHandler): notify the controller to delete on click
        * editing/DeleteButton.h: Added.
        * editing/DeleteButtonController.cpp: Added.
        (WebCore::DeleteButtonController::DeleteButtonController):
        (WebCore::DeleteButtonController::respondToChangedSelection): move the interface to the new element, or hide
        (WebCore::DeleteButtonController::respondToChangedContents): call updateOutlineStyle
        (WebCore::DeleteButtonController::updateOutlineStyle): resize the outline if the table changed size
        (WebCore::DeleteButtonController::show): shows the interface on a new element
        (WebCore::DeleteButtonController::hide): hides the existing interface
        (WebCore::DeleteButtonController::deleteTarget): deletes the targeted element
        * editing/DeleteButtonController.h: Added.
        (WebCore::DeleteButtonController::target): getter for the current target
        * editing/Editor.cpp:
        (WebCore::Editor::shouldShowDeleteInterface): call the new shouldShowDeleteInterface client function
        (WebCore::Editor::Editor): remove the manual ref now that we use RefPtr for m_client
        (WebCore::Editor::~Editor): remove the manual deref now that we use RefPtr for m_client
        * editing/Editor.h:
        (WebCore::Editor::frame): new getter
        (WebCore::Editor::deleteButtonController): ditto
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection): notify the DeleteButtonController about the new selection
        * html/HTMLImageElement.h:
        (WebCore::HTMLImageElement::setCachedImage): new setter that replaces the CachedImage
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::setImage): ditto
        * html/HTMLImageLoader.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage): new constructor that takes an Image
        * loader/CachedImage.h: ditto
        * page/Frame.cpp:
        (WebCore::Frame::selectionController): cleanup coding style
        (WebCore::Frame::editor): ditto
        (WebCore::Frame::command): ditto
        (WebCore::Frame::appliedEditing): tell the delete button outline to update
        (WebCore::Frame::unappliedEditing): ditto
        (WebCore::Frame::reappliedEditing): ditto
        * rendering/RenderTable.cpp:
        (WebCore::RenderTable::addChild): workaround until bug 11363 is fixed

WebKit:

        Reviewed by Geoff.

        <rdar://problem/4478625> HTML Editing: Basic table editing and culling

        Initial implementaltion of table deletion user interface:
        * Adds a new editing delegate method, webView:shouldShowDeleteInterfaceForElement:.
        * The new delegate method is called from the new shouldShowDeleteInterface EditorClient function.

        * DefaultDelegates/WebDefaultEditingDelegate.m:
        (-[WebDefaultEditingDelegate webView:shouldShowDeleteInterfaceForElement:]):
        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::WebEditorClient):
        (WebEditorClient::shouldDeleteRange):
        (WebEditorClient::shouldShowDeleteInterface):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebEditingDelegatePrivate.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Sat, 21 Oct 2006 18:37:50 +0000 (18:37 +0000)]
    Reviewed by Tim H.

        Cleanup bindings generation a little through re-factoring
        and general style cleanup.

        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
weinig [Sat, 21 Oct 2006 15:41:07 +0000 (15:41 +0000)]
    Reviewed by Mitz.

        Fix crashes on Qt/Linux. Offer a default EditorClient and pass it down to Frame ctor.

        * CMakeLists.txt:
        * platform/qt/EditorClientQt.cpp: Added.
        (WebCore::EditorClientQt::shouldDeleteRange):
        * platform/qt/EditorClientQt.h: Added.
        (WebCore::EditorClientQt::~EditorClientQt):
        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::FrameQt):
        * platform/qt/FrameQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Sat, 21 Oct 2006 13:34:58 +0000 (13:34 +0000)]
    Reviewed by Tim H.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=11372
        Auto-generate a few more Objective-C DOM methods.

        - Auto-generate getMatchedCSSRules and getComputedStyle methods.

        * bindings/objc/DOMCSS.h:
        * bindings/objc/DOMCSS.mm:
        * bindings/objc/DOMExtensions.h:
        * bindings/objc/PublicDOMInterfaces.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * dom/Document.idl:
        * page/DOMWindow.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-21 Nikolas Zimmermann <zimmermann@kde.org>
aliceli1 [Sat, 21 Oct 2006 10:15:45 +0000 (10:15 +0000)]
2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by aliu, landed by aliu.

        Fix Qt/Linux build.

        * CMakeLists.txt:
        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::FrameQt):
        * platform/qt/SoundQt.cpp: Added.
        (WebCore::systemBeep):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
aliceli1 [Sat, 21 Oct 2006 10:01:58 +0000 (10:01 +0000)]
    Reviewed by Maciej.

        fix leaks.

        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::setWebView):
        only change webview if its different

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
        actually use the client allocated in the line above instead of
        allocation again, duh.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-21 Nikolas Zimmermann <zimmermann@kde.org>
ap [Sat, 21 Oct 2006 09:12:19 +0000 (09:12 +0000)]
2006-10-21  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Mitz, landed by ap.

        Fix obscure crashes in RenderTableSection on Rob's musicdb file.
        The problem was a missing layout() call on the frame view.
        Thanks go to Mitz Pettel for the initial hint!

        * platform/qt/ScrollViewCanvasQt.cpp:
        (WebCore::ScrollViewCanvasQt::paintEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
aliceli1 [Sat, 21 Oct 2006 08:45:14 +0000 (08:45 +0000)]
    Build fix.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::setWebView):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim Hatcher.
aliceli1 [Sat, 21 Oct 2006 06:43:54 +0000 (06:43 +0000)]
    Reviewed by Tim Hatcher.

        Fixed a problem where the webview passed to the EditorClient wasn't valid yet.

        * WebCoreSupport/WebEditorClient.h:
        (WebEditorClient::setWebView):
        added webview setter

        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::WebEditorClient):
        add default constructor

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
        use [page webView] since _webview isn't valid yet
        (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
        use webview setter on editorclient

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-20 Steve Falkenburg <sfalken@apple.com>
sfalken [Sat, 21 Oct 2006 06:20:55 +0000 (06:20 +0000)]
2006-10-20  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Anders.

        Send User-Agent on requests.
        Send custom request headers properly.

        * platform/cf/ResourceLoaderCFNet.cpp:
        (WebCore::addHeadersFromHashMap): Switch over to HashMap iteration from string parsing
        (WebCore::ResourceLoader::start): Send proper User-Agent, change call to add headers

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
thatcher [Sat, 21 Oct 2006 04:57:35 +0000 (04:57 +0000)]
    Reviewed by Hyatt.

        Fix some bad formatting.

        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::checkOneSelector):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Tweak cache sizes so that they are back to the way they were,
hyatt [Sat, 21 Oct 2006 04:45:30 +0000 (04:45 +0000)]
    Tweak cache sizes so that they are back to the way they were,
        except for < 512, which will stay doubled.

        Reviewed by Tim H.

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge getObjectCacheSize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Sat, 21 Oct 2006 04:42:06 +0000 (04:42 +0000)]
    Reviewed by Tim H.

        Bug 11367: Inline Breakpoint Editor Improvements: Act III
        http://bugs.webkit.org/show_bug.cgi?id=11367

        Major breakpoint editor changes:
        * Breakpoints can now either pause or log to console
        * Code cleanup through use of XPath and converting breakpoints to objects
        * Breakpoints now track how many times they've been reached
        * UI tweaks
        * The breakpoint editor now saves changes as they're entered
        * Because changes are auto-saved now, the save button has been converted to a close button (images from PSMTabBarControl, BSD licensed)
        * If an expression with no return is entered as a condition, it will be wrapped transparently with a return statement.

        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject breakpointEditorHTML]): A way of loading this from an external file, as it was getting too complex to include inline.
        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * Drosera/Images/close.tif: Added.
        * Drosera/Images/close_active.tif: Added.
        * Drosera/Images/close_hover.tif: Added.
        * Drosera/breakpointEditor.html: Added.
        * Drosera/console.js: Added a way to append messages from outside the console window.
        * Drosera/debugger.js:
        * Drosera/viewer.css:
        * Drosera/viewer.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago RS by Beth "pants on fire" Dakin.
ggaren [Sat, 21 Oct 2006 02:02:51 +0000 (02:02 +0000)]
    RS by Beth "pants on fire" Dakin.

        Put some layout tests in their place.

        * fast/dom/Window/window-object-cross-frame-calls-expected.txt: Added.
        * fast/dom/Window/window-object-cross-frame-calls.html: Added.
        * fast/dom/Window/window-onFocus-expected.checksum: Added.
        * fast/dom/Window/window-onFocus-expected.png: Added.
        * fast/dom/Window/window-onFocus-expected.txt: Added.
        * fast/dom/Window/window-onFocus.html: Added.
        * fast/dom/Window/window-xy-properties-expected.txt: Added.
        * fast/dom/Window/window-xy-properties.html: Added.
        * fast/dom/window-object-cross-frame-calls-expected.txt: Removed.
        * fast/dom/window-object-cross-frame-calls.html: Removed.
        * fast/dom/window-onFocus-expected.checksum: Removed.
        * fast/dom/window-onFocus-expected.png: Removed.
        * fast/dom/window-onFocus-expected.txt: Removed.
        * fast/dom/window-onFocus.html: Removed.
        * fast/dom/window-xy-properties-expected.txt: Removed.
        * fast/dom/window-xy-properties.html: Removed.
        * fast/html/xhtml-serialize-expected.txt: Added.
        * fast/html/xhtml-serialize.html: Added.
        * fast/js/resources/xhtml-serialize.js: Removed.
        * fast/js/resources/xslt-fragment-in-empty-doc.js: Removed.
        * fast/js/xhtml-serialize-expected.txt: Removed.
        * fast/js/xhtml-serialize.html: Removed.
        * fast/js/xslt-fragment-in-empty-doc-expected.txt: Removed.
        * fast/js/xslt-fragment-in-empty-doc.html: Removed.
        * fast/xsl/xslt-fragment-in-empty-doc-expected.txt: Added.
        * fast/xsl/xslt-fragment-in-empty-doc.html: Added.
        * fast/dom/resources/child.html: Removed.
        * fast/dom/Window/resources/child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
bdakin [Sat, 21 Oct 2006 01:34:37 +0000 (01:34 +0000)]
    Reviewed by Geoff.

        Changing these counters tests because they fail on some people's
        machines. They fail for people who have the Armenian glyphs the
        tests were looking for in the "expected" line. There is no point in
        testing that anyway, since we do not currently support Armenian in
        counters or in list markers.

        * fast/css/counters/counter10-expected.checksum:
        * fast/css/counters/counter10-expected.png:
        * fast/css/counters/counter10-expected.txt:
        * fast/css/counters/counter10.html:
        * fast/css/counters/counters10-expected.checksum:
        * fast/css/counters/counters10-expected.png:
        * fast/css/counters/counters10-expected.txt:
        * fast/css/counters/counters10.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
ggaren [Sat, 21 Oct 2006 01:07:18 +0000 (01:07 +0000)]
    Reviewed by Anders.

        Removed old window property tests because they didn't quite work and they
        were looking at me funny. Replaced with new, comprehensive test.

        * fast/dom/Window/window-properties-expected.txt: Added.
        * fast/dom/Window/window-properties.html: Added.
        * fast/js/window-properties-expected.txt: Removed.
        * fast/js/window-properties.html: Removed.
        * fast/js/window-properties2-expected.txt: Removed.
        * fast/js/window-properties2.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
darin [Sat, 21 Oct 2006 00:43:39 +0000 (00:43 +0000)]
    Reviewed by John.

        - fixed <rdar://problem/4795716> REGRESSION: User names and passwords aren't being saved (.Mac, etc.) -- WebKit formState passing empty strings

        * loader/mac/WebFormState.mm: (WebCore::FormState::FormState): Fix typo -- need to pass "key"
        as the key, not the dictionary itself.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
aliceli1 [Fri, 20 Oct 2006 23:57:05 +0000 (23:57 +0000)]
WebCore:

        Reviewed by Maciej.

        This is the initial foundation for the EditingController class and
        everything else it needs to work.  The idea is that the Frame has an
        EditingController object that it calls to handle editing commands, the
        most simple examples being copy/paste.  This controller will handle
        these editing commands in WebCore, and only hand off to WebKit to call
        editing delegates (to the let the app intercept editing actions if it
        wants to).  Thus we need a platform-specific client to which the
        EditingController hands off the delegate calls,
        WebCoreEditingControllerClient.  On the WebCore side this is an
        abstract base class, and on the WebKit(Mac) side this is an ObjC++
        subclass, WebEditingControllerClient.  How does the EditingController
        get a handle to its platform-specific client?  In WebKit, the creator
        of a platform-specific Frame creates the client (which is ref-counted)
        and passes it down the chain of constructors until it gets back to the
        EditingController, which then refs it in its constructor and derefs in
        its destructor.

        No Layout tests needed.

        * WebCore.xcodeproj/project.pbxproj:
        Added files and made DomRangeInternal.h and EditingClient.h private headers, necessary for WebKit to compile

        * bridge/EditorClient.h: Added.
        (WebCore::EditorClient::~EditorClient):

        * bridge/mac/FrameMac.h:
        Added an EditingClient to the constructor, to pass down to Frame constructor

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::FrameMac):
        Passed client down to Frame constructor

        * bridge/mac/WebCoreFrameBridge.h:
        Added an EditingClient to the constructor, to pass down to FrameMac constructor

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge initMainFrameWithPage:withEditorClient:]):
        (-[WebCoreFrameBridge initSubframeWithOwnerElement:withEditorClient:]):
        Passed client down to FrameMac constructor

        * editing/Editor.cpp: Added.
        Mostly stuf implementations of the following functions, except for a couple.  These are all needed by cut, copy, paste, delete.
        (WebCore::generalPasteboard):
        (WebCore::Editor::canCopy):
        (WebCore::Editor::canCut):
        (WebCore::Editor::canDelete):
        (WebCore::Editor::canDeleteRange):
        (WebCore::Editor::canPaste):
        (WebCore::Editor::canSmartCopyOrDelete):
        (WebCore::Editor::deleteSelection):
        (WebCore::Editor::deleteSelectionWithSmartDelete):
        (WebCore::Editor::isSelectionRichlyEditable):
        (WebCore::Editor::pasteAsPlainTextWithPasteboard):
        (WebCore::Editor::pasteWithPasteboard):
        (WebCore::Editor::selectedRange):
        (WebCore::Editor::shouldDeleteRange):
        (WebCore::Editor::tryDHTMLCopy):
        (WebCore::Editor::tryDHTMLCut):
        (WebCore::Editor::tryDHTMLPaste):
        (WebCore::Editor::writeSelectionToPasteboard):
        (WebCore::Editor::Editor):
        (WebCore::Editor::~Editor):
        (WebCore::Editor::cut):
        (WebCore::Editor::copy):
        (WebCore::Editor::paste):
        (WebCore::Editor::performDelete):

        * editing/Editor.h: Added.

        * page/Frame.h:
        Added an EditingClient to the constructor, to pass down to Editor constructor

        * page/Frame.cpp:
        (WebCore::Frame::Frame):
        Passed down to Editor constructor
        (WebCore::Frame::editor):
        Accessfor for Editor stored in FramePrivate

        * page/FramePrivate.h:
        (WebCore::FramePrivate::FramePrivate):
        Added an Editor object to the FramePrivate data

        * platform/Sound.h: Added.
        Made a platform-independent accessor to a beep function

        * platform/mac/SoundMac.mm: Added.
        (WebCore::systemBeep):
        calls mac system beep

WebKit:

        Reviewed by Maciej.

        Adding knowledge of EditorClient to WebKit

        * WebCoreSupport/WebEditorClient.h: Added.

        * WebCoreSupport/WebEditorClient.mm: Added.
        (WebEditorClient::WebEditorClient):
        (WebEditorClient::~WebEditorClient):
        (WebEditorClient::shouldDeleteRange):
        Implementation of mac EditorClient

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge initMainFrameWithPage:frameName:view:]):
        (-[WebFrameBridge initSubframeWithOwnerElement:frameName:view:]):
        create an editor client to pass down the chain of constructors

        * WebKit.xcodeproj/project.pbxproj:
        Added related EditorClient files

        * WebKitPrefix.h:
        Added tiger build flag in order to make certain private headers from webcore compile successfully

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd encoding layout test for forms.
hyatt [Fri, 20 Oct 2006 23:32:30 +0000 (23:32 +0000)]
Add encoding layout test for forms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make sure to support the "encoding" property on form elements for
hyatt [Fri, 20 Oct 2006 23:13:26 +0000 (23:13 +0000)]
    Make sure to support the "encoding" property on form elements for
        legacy compatibility.

        Reviewed by darin/john

        No test cases added.  Not sure how to do a form submission of
        various encodings as a layout test.

        * html/HTMLFormElement.h:
        (WebCore::HTMLFormElement::encoding):
        (WebCore::HTMLFormElement::setEncoding):
        * html/HTMLFormElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Fri, 20 Oct 2006 22:55:41 +0000 (22:55 +0000)]
2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and by Anders.

        Fix warnings in JS generation by killing the whole isRefPtr logic,
        and just using WTF::getPtr as Sam Weinig suggested. Also kill some
        places using get() where getPtr() is cleaner - not for m_impl.get().

        * CMakeLists.txt: Tiny cleanup + add deps for CodeGenerator(JS).pm on all IDLs.
        * bindings/scripts/CodeGeneratorJS.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin [Fri, 20 Oct 2006 22:21:29 +0000 (22:21 +0000)]
WebCore:

        - rolled out my loader change; caused world leak and possibly a plug-in crash

WebKit:

        - rolled out my loader change; caused world leak and possibly a plug-in crash

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-20 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 20 Oct 2006 22:21:04 +0000 (22:21 +0000)]
2006-10-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Tim H

        * loader/mac/LoaderFunctionsMac.mm:
        Autorelease the header NSDictionary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
andersca [Fri, 20 Oct 2006 21:53:01 +0000 (21:53 +0000)]
WebCore:

2006-10-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * bindings/js/kjs_window.cpp:
        (KJS::Window::timerFired):
        Check if the timeout id is still in the table before trying to access it. If it isn't in the table
        it has been deleted inside of the execute method.

LayoutTests:

2006-10-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Goeff.

        Add test case for timer crash.

        * fast/dom/timer-clear-interval-in-handler-expected.txt: Added.
        * fast/dom/timer-clear-interval-in-handler.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-20 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 20 Oct 2006 21:05:39 +0000 (21:05 +0000)]
2006-10-20  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Darin and Geoff.

        Remove debugging output.
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by John.
harrison [Fri, 20 Oct 2006 20:55:16 +0000 (20:55 +0000)]
    Reviewed by John.

        <rdar://problem/4792755> REGRESSON: Drag selecting is erratic

        No test because it would require autoscrolling, which is not available to layout tests.

        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::autoscroll):
        Use hitTest() to find the correct node.

        (WebCore::RenderLayer::hitTest):
        Trivial source formatting.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Fri, 20 Oct 2006 20:07:35 +0000 (20:07 +0000)]
2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by Anders.

        Fix regression introduced during the ResourceLoader transition (Maciej's rewrite).

        * platform/qt/ResourceLoaderManager.cpp:
        (WebCore::ResourceLoaderManager::add):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
darin [Fri, 20 Oct 2006 20:05:44 +0000 (20:05 +0000)]
WebCore:

        Reviewed by Adele.

        - convert WebLoader and its 3 subclasses to C++

        Renamed WebLoader to WebCore::WebResourceLoader (should be ResourceLoader, but
        there's currently another class with that name).
        Renamed WebMainResourceLoader to WebCore::MainResourceLoader.
        Renamed WebSubresourceLoader to WebCore::SubresourceLoader.
        Renamed WebNetscapePlugInStreamLoader to WebCore::NetscapePlugInStreamLoader.

        Converted the classes to C++ and added Objective-C delegates to forward from
        API that still requires Objective-C.

        Did not yet rename the source files.

        * WebCore.exp: Removed WebLoader, WebNetscapePlugInStreamLoader, and WebSubresourceLoader
        classes. Added 5 functions from the WebResourceLoader and NetscapePlugInStreamLoader
        classes.

        * WebCore.xcodeproj/project.pbxproj: Made RetainPtr.h a private header instead of project.

        * platform/cf/RetainPtr.h: Put into the WebCore namespace rather than the WTF namespace.

        * loader/mac/WebLoader.h:
        * loader/mac/WebLoader.mm:
        * loader/mac/WebMainResourceLoader.h:
        * loader/mac/WebMainResourceLoader.mm:
        * loader/mac/WebNetscapePlugInStreamLoader.h:
        * loader/mac/WebNetscapePlugInStreamLoader.mm:
        * loader/mac/WebSubresourceLoader.h:
        * loader/mac/WebSubresourceLoader.mm:
        Translate to C++.

        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:]):
        (-[WebCoreFrameBridge startLoadingResource:withMethod:URL:customHeaders:postData:]):
        * loader/mac/WebFrameLoader.h:
        * loader/mac/WebFrameLoader.mm:
        (isCaseInsensitiveEqual):
        (isBackForwardLoadType):
        (-[WebFrameLoader dealloc]):
        (-[WebFrameLoader addPlugInStreamLoader:]):
        (-[WebFrameLoader removePlugInStreamLoader:]):
        (-[WebFrameLoader setDefersCallbacks:]):
        (-[WebFrameLoader stopLoadingPlugIns]):
        (-[WebFrameLoader isLoadingMainResource]):
        (-[WebFrameLoader isLoadingSubresources]):
        (-[WebFrameLoader isLoadingPlugIns]):
        (-[WebFrameLoader stopLoadingSubresources]):
        (-[WebFrameLoader addSubresourceLoader:]):
        (-[WebFrameLoader removeSubresourceLoader:]):
        (-[WebFrameLoader mainResourceData]):
        (-[WebFrameLoader releaseMainResourceLoader]):
        (-[WebFrameLoader cancelMainResourceLoad]):
        (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
        (-[WebFrameLoader stopLoadingWithError:]):
        (-[WebFrameLoader willUseArchiveForRequest:originalURL:loader:]):
        (-[WebFrameLoader archiveLoadPendingForLoader:]):
        (-[WebFrameLoader cancelPendingArchiveLoadForLoader:]):
        * loader/mac/WebFrameLoaderClient.h:
        Call the new C++ API.

WebKit:

        Reviewed by Adele.

        - convert WebLoader and its 3 subclasses to C++

        * Plugins/WebNetscapePluginStream.h:
        * Plugins/WebNetscapePluginStream.m:
        (-[WebNetscapePluginStream dealloc]):
        (-[WebNetscapePluginStream finalize]):
        (-[WebNetscapePluginStream start]):
        (-[WebNetscapePluginStream cancelLoadWithError:]):
        (-[WebNetscapePluginStream stop]):
        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge canRunModalNow]):
        * WebView/WebFrame.m:
        (-[WebFramePrivate dealloc]):
        (-[WebFramePrivate finalize]):
        (frame): Changed from uppercase to lowercase so that it won't conflict
        with the WebCore class named Frame.
        (-[WebFrame _firstChildFrame]):
        (-[WebFrame _lastChildFrame]):
        (-[WebFrame _previousSiblingFrame]):
        (-[WebFrame _nextSiblingFrame]):
        (-[WebFrame _traverseNextFrameStayWithin:]):
        (-[WebFrame _immediateChildFrameNamed:]):
        (-[WebFrame _nextFrameWithWrap:]):
        (-[WebFrame _previousFrameWithWrap:]):
        (-[WebFrame findFrameNamed:]):
        (-[WebFrame parentFrame]):
        (-[WebFrame _dispatchSourceFrame:willSubmitForm:withValues:submissionDecider:]):
        (-[WebFrame _deliverArchivedResourcesAfterDelay]):
        (-[WebFrame _willUseArchiveForRequest:originalURL:loader:]):
        (-[WebFrame _archiveLoadPendingForLoader:]):
        (-[WebFrame _cancelPendingArchiveLoadForLoader:]):
        (-[WebFrame _clearArchivedResources]):
        (-[WebFrame _deliverArchivedResources]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoForgot to add these.
andersca [Fri, 20 Oct 2006 20:03:59 +0000 (20:03 +0000)]
Forgot to add these.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Fri, 20 Oct 2006 19:14:55 +0000 (19:14 +0000)]
2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by Anders.

        Adapt to FrameQtClient changes, and provide some kind of status
        information to the KPart wheter we're loading or not (started/completed signaling).

        * WebKitPart/CMakeLists.txt:
        * WebKitPart/WebKitPart.cpp:
        (WebKitPart::WebKitPart):
        (WebKitPart::~WebKitPart):
        (WebKitPart::openUrl):
        (WebKitPart::initView):
        * WebKitPart/WebKitPart.h:
        * WebKitPart/WebKitPartBrowserExtension.cpp: Added.
        (WebKitPartBrowserExtension::WebKitPartBrowserExtension):
        (WebKitPartBrowserExtension::~WebKitPartBrowserExtension):
        * WebKitPart/WebKitPartBrowserExtension.h: Added.
        * WebKitPart/WebKitPartClient.cpp:
        (WebKitPartClient::WebKitPartClient):
        (WebKitPartClient::loadFinished):
        * WebKitPart/WebKitPartClient.h:
        * WebKitPart/WebKitPartInterface.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Beth, approved in principle by Adele, who couldn't be troubled
ggaren [Fri, 20 Oct 2006 19:14:17 +0000 (19:14 +0000)]
    Reviewed by Beth, approved in principle by Adele, who couldn't be troubled
        for an actual review.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=11345
        1 fewer shouldChangeSelection delegate call for fast/forms/focus-control-to-page

        I updated this test to use <input type="search"> because that's the only
        remaining AppKit control, and the test's intention is verify tabbing
        between AppKit and non-AppKit controls.

        I updated the results because the behavior change is good.

        Here's why the test regressed:

        Our editing code is cra-zay. When AppKit calls nextKeyView, we not only
        calculate the next key element in the page, we also focus it as a side-effect.
        As a result, we used to fire a focus delegate twice, because AppKit happened
        to call nextKeyView twice.

        This test first regressed when Adele changed listboxes to be non-AppKit
        controls (r16718). That change took AppKit out of test.

        The regression redoubled itself when Adam moved TAB handling into the DOM
        (r16741), taking AppKit out of TABing completely.

        * fast/forms/focus-control-to-page-expected.txt:
        * fast/forms/focus-control-to-page.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17166 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-20 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Fri, 20 Oct 2006 19:14:00 +0000 (19:14 +0000)]
2006-10-20  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by Anders.

        Offer a way for WebKitPart to be able to detect when
        the webpage has been completly loaded (including subresources).

        Also fix Qt/Linux build by removing PopupMenu.cpp from CMakeLists.txt
        and removing some functions from PopupMenuQt.cpp, and alter FrameQt.cpp.

        * CMakeLists.txt:
        * platform/qt/FrameQt.cpp:
        (WebCore::FrameQt::submitForm):
        (WebCore::FrameQt::client):
        * platform/qt/FrameQt.h:
        * platform/qt/FrameQtClient.cpp:
        (WebCore::FrameQtClientDefault::setFrame):
        (WebCore::FrameQtClientDefault::openURL):
        (WebCore::FrameQtClientDefault::submitForm):
        (WebCore::FrameQtClientDefault::checkLoaded):
        (WebCore::FrameQtClientDefault::traverseNextFrameStayWithin):
        (WebCore::FrameQtClientDefault::numPendingOrLoadingRequests):
        (WebCore::FrameQtClientDefault::receivedAllData):
        * platform/qt/FrameQtClient.h:
        * platform/qt/LoaderFunctionsQt.cpp:
        (WebCore::CheckCacheObjectStatus):
        * platform/qt/PopupMenuQt.cpp:
        * platform/qt/ResourceLoaderManager.cpp:
        (WebCore::ResourceLoaderManager::ResourceLoaderManager):
        (WebCore::ResourceLoaderManager::slotResult):
        (WebCore::ResourceLoaderManager::add):
        * platform/qt/ResourceLoaderManager.h:
        * platform/qt/ResourceLoaderQt.cpp:
        (WebCore::ResourceLoader::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-20 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 20 Oct 2006 19:04:07 +0000 (19:04 +0000)]
2006-10-20  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Geoff.

        Fix compiler warnings

        * platform/ResourceLoaderClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geof.
kmccullo [Fri, 20 Oct 2006 18:27:46 +0000 (18:27 +0000)]
    Reviewed by Geof.

        Changed test to make us pass Georgian case changing for Unicode 4.0 and 5.0.  This incorporates changes from the 1.4 revision of the same mozilla test.
        On Tiger we are still using Unicode 4.0 but on win and Leopard we are using Unicode 5.0, so this test currently allows for either answer.

        * tests/mozilla/ecma/String/15.5.4.11-2.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin
sullivan [Fri, 20 Oct 2006 17:58:21 +0000 (17:58 +0000)]
    Reviewed by Darin

        - fixed <rdar://problem/4794935> setAcceptsMouseMovedEvents: is called for every layout,
          taking ~1% on the PLT test

        * WebView/WebHTMLView.m:
        (-[NSArray layoutToMinimumPageWidth:maximumPageWidth:adjustingViewSize:]):
        Don't call setAcceptsMouseMovedEvents: and WKSetNSWindowShouldPostEventNotifications() here
        because this is called too often.

        * WebView/WebView.m:
        (-[WebView viewWillMoveToWindow:]):
        Do call them here, because this is guaranteed to be called at least once for each window
        containing a webview, but isn't called too often. Also restructured this method a little.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
weinig [Fri, 20 Oct 2006 15:48:35 +0000 (15:48 +0000)]
    Reviewed by Mitz.

        Win32 build fix and cleanup.

        * WebCore.vcproj/WebCore/WebCore.vcproj:
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::FrameWin):
        (WebCore::FrameWin::submitForm):
        * page/ResourceRequest.h:
        (WebCore::ResourceRequest::addHTTPHeaderField):
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::Slider::~Slider):
        (WebCore::Slider::setMinValue):
        (WebCore::searchableIndexIntroduction):
        (WebCore::findNextSentenceFromIndex):
        (WebCore::findSentenceBoundary):
        (WebCore::findNextWordFromIndex):
        (WebCore::FrameWin::getObjectInstanceForWidget):
        (WebCore::FrameWin::getEmbedInstanceForWidget):
        (WebCore::FrameWin::runJavaScriptPrompt):
        (WebCore::FrameWin::restoreDocumentState):
        (WebCore::FrameWin::partClearedInBegin):
        (WebCore::FrameWin::createEmptyDocument):
        (WebCore::FrameWin::overrideMediaType):
        (WebCore::FrameWin::markedTextRange):
        (WebCore::FrameWin::passSubframeEventToSubframe):
        (WebCore::FrameWin::lastEventIsMouseUp):
        (WebCore::FrameWin::addMessageToConsole):
        (WebCore::FrameWin::shouldChangeSelection):
        (WebCore::FrameWin::respondToChangedSelection):
        (WebCore::FrameWin::createFrame):
        (WebCore::FrameWin::saveDocumentState):
        (WebCore::FrameWin::clearUndoRedoOperations):
        (WebCore::FrameWin::incomingReferrer):
        (WebCore::FrameWin::markMisspellingsInAdjacentWords):
        (WebCore::FrameWin::respondToChangedContents):
        (WebCore::FrameWin::handledOnloadEvents):
        (WebCore::FrameWin::createPlugin):
        (WebCore::FrameWin::objectContentType):
        (WebCore::screenDepthPerComponent):
        (WebCore::screenIsMonochrome):
        (WebCore::historyContains):
        (WebCore::submitButtonDefaultLabel):
        (WebCore::inputElementAltText):
        (WebCore::resetButtonDefaultLabel):
        (WebCore::fileButtonChooseFileLabel):
        (WebCore::fileButtonNoFileSelectedLabel):
        (WebCore::defaultLanguage):
        (WebCore::findWordBoundary):
        (WebCore::PlugInInfoStore::createPluginInfoForPluginAtIndex):
        (WebCore::PlugInInfoStore::supportsMIMEType):
        (WebCore::refreshPlugins):
        (WebCore::ResourceLoader::assembleResponseHeaders):
        (WebCore::ResourceLoader::retrieveResponseEncoding):
        (WebCore::ResourceLoader::startHTTPRequest):
        (WebCore::TextField::TextField):
        (WebCore::focusRingColor):
        (WebCore::setFocusRingColorChangeFunction):
        (WebCore::PopupMenu::~PopupMenu):
        (WebCore::PopupMenu::hide):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
rwlbuis [Fri, 20 Oct 2006 15:44:12 +0000 (15:44 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11303
        Path::transform() should be implemented on Qt build

        Use QPainterPath API to implement Path::transform.
        This fixes svg/custom/clip-path-with-transform.svg on
        the qt build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
rwlbuis [Fri, 20 Oct 2006 10:29:33 +0000 (10:29 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=11217
        Cleanup svg coding style

        Cleanup coding style in svg clipping and painting classes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Make sure to do the code that checks the repeatInterval before the timer...
hyatt [Fri, 20 Oct 2006 09:48:12 +0000 (09:48 +0000)]
    Make sure to do the code that checks the repeatInterval before the timer has been
        deleted. (Duh.)

        Reviewed by andersca

        * bindings/js/kjs_window.cpp:
        (KJS::DOMWindowTimer::setNestingLevel):
        (KJS::Window::timerFired):
        (KJS::DOMWindowTimer::fired):
        * platform/Timer.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Honor tiny timer intervals for JS timeouts as they are nested until a cutoff...
hyatt [Fri, 20 Oct 2006 07:25:02 +0000 (07:25 +0000)]
    Honor tiny timer intervals for JS timeouts as they are nested until a cutoff point is reached.
        At that point clamp to 10ms to prevent excessive CPU usage.

        Reviewed by anders

        * bindings/js/kjs_window.cpp:
        (KJS::DOMWindowTimer::DOMWindowTimer):
        (KJS::DOMWindowTimer::nestingLevel):
        (KJS::Window::installTimeout):
        (KJS::Window::pauseTimeouts):
        (KJS::Window::resumeTimeouts):
        (KJS::DOMWindowTimer::fired):
        * platform/Timer.h:
        (WebCore::TimerBase::startRepeating):
        (WebCore::TimerBase::startOneShot):
        (WebCore::TimerBase::repeatInterval):
        (WebCore::TimerBase::augmentRepeatInterval):
        (WebCore::TimerBase::inHeap):
        (WebCore::Timer::Timer):
        (WebCore::Timer::fired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-20 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 20 Oct 2006 07:10:48 +0000 (07:10 +0000)]
2006-10-20  Steve Falkenburg  <sfalken@apple.com>

        Build fix

        * ksvg2/svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-19 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 20 Oct 2006 07:01:55 +0000 (07:01 +0000)]
2006-10-19  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam.

        Use GetKeyState rather than GetAsyncKeyState since we're
        calling in these cases in direct response to an event, and want the
        key state associated with that event.

        Pass triggering event to url selection method.

        * bridge/mac/FrameMac.h: Add triggeringEvent parameter
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::urlSelected): Add triggeringEvent parameter
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::urlSelected): Add triggeringEvent parameter
        * bridge/win/FrameWin.h: Add triggeringEvent parameter
        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::defaultEventHandler): Pass triggering event to URL selection method
        * page/Frame.cpp:
        (WebCore::Frame::changeLocation): Add 0 as triggeringEvent
        (WebCore::Frame::urlSelected): Pass through triggeringEvent
        * page/Frame.h: Add triggeringEvent parameter to urlSelected methods
        * platform/win/KeyEventWin.cpp:
        (WebCore::PlatformKeyboardEvent::PlatformKeyboardEvent): Use GetKeyState instead of GetAsyncKeyState
        * platform/win/MouseEventWin.cpp: Use GetKeyState instead of GetAsyncKeyState
        (WebCore::PlatformMouseEvent::PlatformMouseEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Correct typos from changing "flush" to "prune" using automated search/replace.
hyatt [Fri, 20 Oct 2006 05:14:49 +0000 (05:14 +0000)]
    Correct typos from changing "flush" to "prune" using automated search/replace.

        Change the cache heuristic for flushing to allow a higher watermark before initiating an
        aggressive prune.  This ensures that small cache sizes are no worse in terms of performance
        than the old buggy cache.

        Make sizes unsigned instead of ints in the cache's APIs and member variables.

        * loader/Cache.cpp:
        (WebCore::Cache::prune):
        (WebCore::Cache::setMaximumSize):
        * loader/Cache.h:
        (WebCore::Cache::maximumSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-19 Anders Carlsson <acarlsson@apple.com>
andersca [Fri, 20 Oct 2006 04:24:30 +0000 (04:24 +0000)]
2006-10-19  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Daddy Hyatt.

        Use a real hash map for the headers.

        * loader/LoaderFunctions.h:
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::ServeSynchronousRequest):
        * platform/ResourceLoader.cpp:
        (WebCore::ResourceLoader::setRequestHeaders):
        (WebCore::ResourceLoader::requestHeaders):
        * platform/ResourceLoader.h:
        * platform/ResourceLoaderInternal.h:
        * platform/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::start):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::open):
        (WebCore::XMLHttpRequest::send):
        (WebCore::XMLHttpRequest::setRequestHeader):
        (WebCore::XMLHttpRequest::getRequestHeader):
        * xml/xmlhttprequest.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Ada.
aroben [Fri, 20 Oct 2006 03:02:53 +0000 (03:02 +0000)]
    Reviewed by Ada.

        Pippity-poppity popup tweaks.

        * WebCore.xcodeproj/project.pbxproj: Removed PopupMenu.cpp from project.
        * html/HTMLSelectElement.cpp:
        (WebCore::HTMLSelectElement::setSelectedIndex): Only fire onChange if
        requested and the new index is actually different than the old one.
        * platform/IntPoint.h: Added another casting operator.
        * platform/PopupMenu.cpp: Removed. The code in here, while
        platform-independent, was only useful for the NSPopUpButtonCell
        implementation of popup menus, so I've moved it to PopupMenuMac.mm.
        * platform/PopupMenu.h: Moved the definition of PopupMenu::create into
        the header since it's fairly simple. Made some more methods private now
        that we don't have subclasses and virtual methods anymore.
        (WebCore::PopupMenu::create):
        (WebCore::PopupMenu::menuList):
        (WebCore::PopupMenu::itemHeight):
        (WebCore::PopupMenu::windowRect):
        (WebCore::PopupMenu::listIndexAtPoint):
        (WebCore::PopupMenu::focusedIndex):
        (WebCore::PopupMenu::setWasClicked):
        (WebCore::PopupMenu::wasClicked):
        (WebCore::PopupMenu::setScrollOffset):
        (WebCore::PopupMenu::scrollOffset):
        (WebCore::PopupMenu::wheelDelta):
        * platform/mac/PopupMenuMac.mm: Added the code from PopupMenu.cpp.
        (WebCore::PopupMenu::populate): Call our own clear() method to clear
        the menu.
        * platform/win/IntPointWin.cpp: New casting operator.
        (WebCore::IntPoint::IntPoint):
        (WebCore::IntPoint::operator POINTS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17151 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
thatcher [Fri, 20 Oct 2006 03:00:37 +0000 (03:00 +0000)]
    Reviewed by Anders.

        Bug 11366: Web Inspector should show user agent style rules
        http://bugs.webkit.org/show_bug.cgi?id=11366

        * WebInspector/WebInspector.m:
        (-[WebInspector init]):
        (-[WebInspector showOptionsMenu]):
        (-[WebInspector _toggleShowUserAgentStyles:]):
        * WebInspector/WebInspectorInternal.h:
        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17150 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix - 2gig is on that pesky signed/unsigned limit...
beidson [Fri, 20 Oct 2006 01:57:53 +0000 (01:57 +0000)]
    Build fix - 2gig is on that pesky signed/unsigned limit...

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge getObjectCacheSize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17149 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
beidson [Fri, 20 Oct 2006 00:26:51 +0000 (00:26 +0000)]
    Reviewed by Hyatt.

        Death to 16777216.  Long live 33554432.
        (Cache size changed needs to be reflected in localization file)

        * English.lproj/StringsNotToBeLocalized.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt
beidson [Fri, 20 Oct 2006 00:16:26 +0000 (00:16 +0000)]
    Reviewed by Hyatt

        Added an larger in-memory level of cache for machines with 2+gb ram

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge getObjectCacheSize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
aroben [Fri, 20 Oct 2006 00:08:11 +0000 (00:08 +0000)]
    Reviewed by Darin.

        Cleaning up Document::nextFocusNode and Document::previousFocusNode.

        * dom/Document.cpp:
        (WebCore::Document::nextFocusNode):
        (WebCore::Document::previousFocusNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt
beidson [Fri, 20 Oct 2006 00:06:14 +0000 (00:06 +0000)]
    Reviewed by Hyatt

        Double the default memory cache size

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17145 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
mjs [Fri, 20 Oct 2006 00:00:23 +0000 (00:00 +0000)]
    Reviewed by Geoff.

        - implement new ResourceRequest API and fix up code as appropriate

        * bindings/js/kjs_window.cpp:
        (KJS::createNewWindow):
        (KJS::WindowFunc::callAsFunction):
        * bridge/mac/BrowserExtensionMac.mm:
        (WebCore::BrowserExtensionMac::createNewWindow):
        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::submitForm):
        (WebCore::FrameMac::openURLRequest):
        (WebCore::FrameMac::urlSelected):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge openURL:reload:contentType:refresh:lastModified:pageCache:]):
        * dom/DOMImplementation.cpp:
        (WebCore::addString):
        (WebCore::isSVG10Feature):
        (WebCore::isSVG11Feature):
        * dom/Document.h:
        * editing/CommandByName.cpp:
        * editing/JSEditor.cpp:
        * page/Frame.cpp:
        (WebCore::Frame::changeLocation):
        (WebCore::Frame::urlSelected):
        (WebCore::Frame::requestFrame):
        (WebCore::Frame::submitForm):
        * page/Frame.h:
        * page/FramePrivate.h:
        * page/ResourceRequest.h:
        (WebCore::):
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::cachePolicy):
        (WebCore::ResourceRequest::setCachePolicy):
        (WebCore::ResourceRequest::timeoutInterval):
        (WebCore::ResourceRequest::setTimeoutInterval):
        (WebCore::ResourceRequest::mainDocumentURL):
        (WebCore::ResourceRequest::setMainDocumentURL):
        (WebCore::ResourceRequest::httpMethod):
        (WebCore::ResourceRequest::setHTTPMethod):
        (WebCore::ResourceRequest::httpHeaderField):
        (WebCore::ResourceRequest::setHTTPHeaderField):
        (WebCore::ResourceRequest::httpContentType):
        (WebCore::ResourceRequest::setHTTPContentType):
        (WebCore::ResourceRequest::httpReferrer):
        (WebCore::ResourceRequest::setHTTPReferrer):
        (WebCore::ResourceRequest::httpUserAgent):
        (WebCore::ResourceRequest::setHTTPUserAgent):
        (WebCore::ResourceRequest::httpBody):
        (WebCore::ResourceRequest::setHTTPBody):
        (WebCore::ResourceRequest::addHTTPHeaderField):
        * platform/FontCache.cpp:
        (WebCore::computeHash):
        * platform/StringHash.h:
        (WTF::):
        * platform/StringImpl.cpp:
        (WebCore::equalIgnoringCase):
        * rendering/RenderPartObject.cpp:
        (WebCore::RenderPartObject::updateWidget):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Thu, 19 Oct 2006 23:21:35 +0000 (23:21 +0000)]
LayoutTests:

        Reviewed by levi

        <rdar://problem/4447885>
        API: WebView should have a method something like incrementLeftMarginBy: or indentBy:

        Changed blockquotes in these tests to blockquote class="webkit-indent-blockquote".
        * editing/execCommand/indent-empty-root-expected.txt:
        * editing/execCommand/indent-selection-expected.checksum:
        * editing/execCommand/indent-selection-expected.png:
        * editing/execCommand/indent-selection-expected.txt:
        * editing/execCommand/indent-selection.html:
        * editing/execCommand/nsresponder-indent-expected.txt:
        * editing/execCommand/nsresponder-outdent.html:
        * editing/execCommand/outdent-selection-expected.checksum:
        * editing/execCommand/outdent-selection-expected.png:
        * editing/execCommand/outdent-selection-expected.txt:

        Ditto.  Added a FIXME:
        * editing/execCommand/outdent-selection.html:

WebCore:

        Reviewed by levi

        <rdar://problem/4447885>
        API: WebView should have a method something like incrementLeftMarginBy: or indentBy:

        Fixed indent/outdent to only increment the left margin, to match other browsers.
        Used blockquote class="webkit-indent-blockquote" to do this.  Mail can now
        implement indent/outdent by customizing the appearance of these blockquotes,
        instead of using a new API.

        * css/html4.css: Added margin: 0 0 0 40px for webkit-indent-blockquotes.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::indentBlockquoteString): Added.
        (WebCore::createIndentBlockquoteElement): Added.
        (WebCore::isIndentBlockquote): Added.
        (WebCore::isListOrBlockquote): Added.
        (WebCore::IndentOutdentCommand::IndentOutdentCommand):
        (WebCore::IndentOutdentCommand::prepareBlockquoteLevelForInsertion): Fixed
        a bug in the code that added an extra br if the placeholder collapsed upon insertion.
        Used the new indentBlockquote checks and enclosing element getters.
        (WebCore::IndentOutdentCommand::indentRegion): Ditto.
        (WebCore::IndentOutdentCommand::outdentParagraph): Ditto.  Cleaned up the
        logic to pull the selection out of a list a bit.
        * editing/htmlediting.cpp:
        (WebCore::enclosingNodeOfType): Added this generic enclosing element getter.
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin D and Geoff
sullivan [Thu, 19 Oct 2006 21:57:03 +0000 (21:57 +0000)]
    Reviewed by Kevin D and Geoff

        * WebKit.xcodeproj/project.pbxproj:
        version wars

        Cleaned up this file, as follows:
        - renamed all file-internal methods to start with underscores
        - moved all file-internal methods into a FileInternal category block, and alphabetized them
        - grouped all other methods by where/how they were defined (delegate methods, protocol methods, overrides, etc.)
        - removed unstylish braces around one-line clauses

        * WebView/WebPDFView.m:
        (_applicationInfoForMIMEType):
        (_PDFSelectionsAreEqual):
        (+[WebPDFView supportedMIMETypes]):
        (-[WebPDFView setPDFDocument:]):
        (-[WebPDFView dealloc]):
        (-[WebPDFView centerSelectionInVisibleArea:]):
        (-[WebPDFView scrollPageDown:]):
        (-[WebPDFView scrollPageUp:]):
        (-[WebPDFView scrollLineDown:]):
        (-[WebPDFView scrollLineUp:]):
        (-[WebPDFView scrollToBeginningOfDocument:]):
        (-[WebPDFView scrollToEndOfDocument:]):
        (-[WebPDFView jumpToSelection:]):
        (-[WebPDFView acceptsFirstResponder]):
        (-[WebPDFView becomeFirstResponder]):
        (-[WebPDFView hitTest:]):
        (-[WebPDFView initWithFrame:]):
        (-[WebPDFView menuForEvent:]):
        (-[WebPDFView setNextKeyView:]):
        (-[WebPDFView viewDidMoveToWindow]):
        (-[WebPDFView viewWillMoveToWindow:]):
        (-[WebPDFView validateUserInterfaceItem:]):
        (-[WebPDFView copy:]):
        (-[WebPDFView takeFindStringFromSelection:]):
        (-[WebPDFView canPrintHeadersAndFooters]):
        (-[WebPDFView printOperationWithPrintInfo:]):
        (-[WebPDFView viewWillMoveToHostWindow:]):
        (-[WebPDFView viewDidMoveToHostWindow]):
        (-[WebPDFView elementAtPoint:]):
        (-[WebPDFView elementAtPoint:allowShadowContent:]):
        (-[WebPDFView searchFor:direction:caseSensitive:wrap:]):
        (-[WebPDFView viewState]):
        (-[WebPDFView setViewState:]):
        (-[WebPDFView writeSelectionWithPasteboardTypes:toPasteboard:]):
        (-[WebPDFView PDFViewWillClickOnLink:withURL:]):
        (+[WebPDFView _PDFPreviewViewClass]):
        (+[WebPDFView _PDFViewClass]):
        (-[WebPDFView _anyPDFTagsFoundInMenu:]):
        (-[WebPDFView _applyPDFDefaults]):
        (-[WebPDFView _fakeKeyEventWithFunctionKey:]):
        (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
        (-[WebPDFView _openWithFinder:]):
        (-[WebPDFView _path]):
        (-[WebPDFView _PDFSubview]):
        (-[WebPDFView _pointIsInSelection:]):
        (-[WebPDFView _receivedPDFKitLaunchNotification:]):
        (-[WebPDFView _scaledAttributedString:]):
        (-[WebPDFView _trackFirstResponder]):
        (-[PDFPrefUpdatingProxy forwardInvocation:]):
        (-[PDFPrefUpdatingProxy methodSignatureForSelector:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by ap.
ggaren [Thu, 19 Oct 2006 20:42:21 +0000 (20:42 +0000)]
    Reviewed by ap.

        Added a delay before printing the last line of text to ensure that the two
        lines consistently decode as separate chunks.

        * http/tests/incremental/slow-utf8-css.pl:
        * http/tests/incremental/slow-utf8-css-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rolling out the this change since it caused a bad regression:
thatcher [Thu, 19 Oct 2006 20:13:37 +0000 (20:13 +0000)]
    Rolling out the this change since it caused a bad regression:
        <rdar://problem/4788524> REGRESSION: Incomplete repaint of text area when deleting (11277)

    2006-10-12  Adele Peterson  <adele@apple.com>

        Reviewed by Dave Harrison.

        - Fixed <rdar://problem/4650813> REGRESSION: typing in a textarea in Safari is extremely slow (sample shows focus ring drawing)

        * rendering/RenderObject.cpp: (WebCore::RenderObject::markContainingBlocksForLayout):
        Make subtree layouts work for textareas as well as text fields.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Kevin Decker
sullivan [Thu, 19 Oct 2006 18:43:01 +0000 (18:43 +0000)]
    Reviewed by Kevin Decker

        - fixed <rdar://problem/4792761> Safari should use fancier embedded PDFKit stuff when it's available

        * WebKit.xcodeproj/project.pbxproj:
        version wars

        * WebView/WebFrameView.m:
        (-[WebFrameView _makeDocumentViewForDataSource:]):
        initialize document view with frame view's rect instead of empty rect. This avoids some problems when
        constructing view hierarchies from nibs

        * WebView/WebPreferencesPrivate.h:
        declare new _usePDFPreviewView and _setUsePDFPreviewView:, used for debugging
        * WebView/WebPreferenceKeysPrivate.h:
        declare new preference key string
        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):
        initialize new preference to true (we will by default use the new view if it's available)
        (-[WebPreferences _usePDFPreviewView]):
        new accessor for new pref
        (-[WebPreferences _setUsePDFPreviewView:]):
        ditto

        * WebView/WebPDFView.h:
        new previewView ivar

        * WebView/WebPDFView.m:
        (+[WebPDFView PDFPreviewViewClass]):
        new method, returns class to use for fancier embedded PDFKit stuff, or nil if fancy stuff isn't available
        (-[WebPDFView initWithFrame:]):
        now tries to use fancier embedded PDFKit stuff if it's available and the pref is set to use it; falls back
        to old behavior otherwise
        (-[WebPDFView dealloc]):
        release new previewView ivar (retained in initWithFrame:)
        (-[WebPDFView viewWillMoveToWindow:]):
        stop observing PDFKit notification when we're removed from window
        (-[WebPDFView viewDidMoveToWindow]):
        start observing PDFKit notification when we're added to window
        (-[WebPDFView _receivedPDFKitLaunchNotification:]):
        respond to this new PDFKit notification by opening the document via NSWorkspace

        * English.lproj/StringsNotToBeLocalized.txt:
        updated for lots of recent changes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-19 Nikolas Zimmermann <zimmermann@kde.org>
andersca [Thu, 19 Oct 2006 18:07:21 +0000 (18:07 +0000)]
2006-10-19  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed and landed by Anders.

        Fix Qt/Linux build.

        * CMakeLists.txt:
        * loader/Cache.h:
        * platform/qt/BrowserExtensionQt.cpp:
        * platform/qt/BrowserExtensionQt.h:
        * platform/qt/CursorQt.cpp:
        (WebCore::pointerCursor):
        * platform/qt/LoaderFunctionsQt.cpp:
        (WebCore::NumberOfPendingOrLoadingRequests):
        (WebCore::CheckCacheObjectStatus):
        * platform/qt/ResourceLoaderQt.cpp:
        (WebCore::ResourceLoader::retrieveResponseEncoding):
        (WebCore::ResourceLoader::receivedResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Thu, 19 Oct 2006 17:09:11 +0000 (17:09 +0000)]
WebCore:

        Reviewed by ap.

        Win32 build fix.

        * bridge/win/FrameWin.cpp:
        * bridge/win/FrameWin.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (WebCore::ResourceLoader::retrieveResponseEncoding):

WebKit:

        Reviewed by ap.

        Win32 build fix.

        * COM/WebFrame.cpp:
        (WebFrame::initWithName):
        (WebFrame::createNewWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17137 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
ap [Thu, 19 Oct 2006 16:41:03 +0000 (16:41 +0000)]
    Reviewed by Mitz.

        http://bugs.webkit.org/show_bug.cgi?id=11141
        REGRESSION(r16681-r16691): CSS '@import' doesn't respect HTML Base element

        Undo one misguided change made in bug 11011 - stop setting inline stylesheet's href
        to document URL. This matches WinIE and partially matches Firefox - although the latter
        reports the href as if it were inherited, it still doesn't use it when resolving URIs in
        @import rules.

        Test: http/tests/uri/css-href.php

        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::childrenChanged):
        * ksvg2/svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::childrenChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17136 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-19 Mitz Pettel <mitz@webkit.org>
ap [Thu, 19 Oct 2006 16:37:48 +0000 (16:37 +0000)]
2006-10-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed and landed by ap.

        - fixed the inspector's tree popup

        * WebInspector/webInspector/inspector.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-19 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 19 Oct 2006 16:15:21 +0000 (16:15 +0000)]
2006-10-19  Anders Carlsson  <acarlsson@apple.com>

        * loader/Cache.cpp:
        Get rid of #include "loader.h", Cache.h already includes this and it breaks on operating systems
        with case-sensitive file systems.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-19 Anders Carlsson <acarlsson@apple.com>
andersca [Thu, 19 Oct 2006 16:09:00 +0000 (16:09 +0000)]
2006-10-19  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Maciej, Brady.

        Remove "charset" from the ResourceLoader metadata map and use
        a getter function instead. Also, rename charset to encoding in a couple of places.

        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::setEncoding):
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedResource.h:
        (WebCore::CachedResource::setEncoding):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::setEncoding):
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        (WebCore::CachedXBLDocument::setEncoding):
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::setEncoding):
        * loader/CachedXSLStyleSheet.h:
        * loader/loader.cpp:
        (WebCore::Loader::receivedResponse):
        * platform/ResourceLoader.cpp:
        (WebCore::ResourceLoader::responseEncoding):
        (WebCore::ResourceLoader::queryMetaData):
        * platform/ResourceLoader.h:
        * platform/ResourceLoaderInternal.h:
        (WebCore::ResourceLoaderInternal::ResourceLoaderInternal):
        * platform/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::retrieveResponseEncoding):
        (WebCore::ResourceLoader::receivedResponse):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::receivedData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17133 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Updated this test to avoid machine-specific results.
ggaren [Thu, 19 Oct 2006 14:58:51 +0000 (14:58 +0000)]
    Updated this test to avoid machine-specific results.

        * fast/js/window-properties2-expected.txt:
        * fast/js/window-properties2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17132 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Rewrite of the WebCore memory cache. The following changes have been made...
hyatt [Thu, 19 Oct 2006 09:21:54 +0000 (09:21 +0000)]
    Rewrite of the WebCore memory cache.  The following changes have been made (along with many more):

        (1) Referenced objects are now also cached.

        (2) Pruning of the cache will occur once the cache is both full and in addition
        more than half full with unreferenced objects.

        (3) The prune is much more aggressive now, since referenced objects are counted when
        pruning.  The cache will therefore often prune out every unreferenced object if lots of
        windows/tabs are open.

        (4) Consolidated the request methods for various types of resources to go through a single
        requestResource bottleneck function.

        (5) deref on CachedResource is no longer virtual, since the implementation in every subclass was
        identical.

        (6) Changed "object" to "resource" everywhere.

        (7) The Cache is now an actual object, obtained via cache().

        (8) Fixed bugs with the autoload images preference so that it would really work properly when disabled
        and enabled.

        (9) Tweaked ImageDocuments to set up the status properly for the CachedResource that they use.

        (10) Fixed the LRU-SP algorithm so that the LRU aspect really kicks in (by leaving the live objects
        in the LRU lists).  Also fixed a bug with the "-SP" part of the algorithm where the access count was
        being incorrectly weighted too much due to a math error.

        (11) Fixed a bug where the old cache could grow without bound because it didn't know anything about
        the size of referenced resources.

        Reviewed by Maciej, bradee-oh

        * bridge/mac/WebCoreCache.mm:
        (+[WebCoreCache statistics]):
        (+[WebCoreCache empty]):
        (+[WebCoreCache setDisabled:]):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge initMainFrameWithPage:]):
        (-[WebCoreFrameBridge getData:andResponse:forURL:]):
        (-[WebCoreFrameBridge getAllResourceDatas:andResponses:]):
        * css/CSSImageValue.cpp:
        (WebCore::CSSImageValue::image):
        * dom/XMLTokenizer.cpp:
        (WebCore::openFunc):
        * html/HTMLImageLoader.cpp:
        (WebCore::HTMLImageLoader::updateFromElement):
        * loader/Cache.cpp:
        (WebCore::cache):
        (WebCore::Cache::Cache):
        (WebCore::createResource):
        (WebCore::Cache::requestResource):
        (WebCore::Cache::resourceForURL):
        (WebCore::Cache::prune):
        (WebCore::Cache::setMaximumSize):
        (WebCore::Cache::remove):
        (WebCore::Cache::addDocLoader):
        (WebCore::Cache::removeDocLoader):
        (WebCore::fastLog2):
        (WebCore::Cache::lruListFor):
        (WebCore::Cache::removeFromLRUList):
        (WebCore::Cache::insertInLRUList):
        (WebCore::Cache::resourceAccessed):
        (WebCore::Cache::adjustSize):
        (WebCore::Cache::getStatistics):
        (WebCore::Cache::setDisabled):
        * loader/Cache.h:
        (WebCore::LRUList::LRUList):
        (WebCore::Cache::loader):
        (WebCore::Cache::maximumSize):
        (WebCore::Cache::disabled):
        (WebCore::Cache::addToLiveObjectSize):
        (WebCore::Cache::removeFromLiveObjectSize):
        (WebCore::Cache::TypeStatistic::TypeStatistic):
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::CachedCSSStyleSheet):
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::CachedImage):
        (WebCore::CachedImage::~CachedImage):
        (WebCore::brokenImage):
        (WebCore::nullImage):
        (WebCore::CachedImage::image):
        (WebCore::CachedImage::data):
        * loader/CachedImage.h:
        (WebCore::CachedImage::stillNeedsLoad):
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::CachedResource):
        (WebCore::CachedResource::~CachedResource):
        (WebCore::CachedResource::finish):
        (WebCore::CachedResource::setExpireDate):
        (WebCore::CachedResource::isExpired):
        (WebCore::CachedResource::setRequest):
        (WebCore::CachedResource::ref):
        (WebCore::CachedResource::deref):
        (WebCore::CachedResource::setSize):
        * loader/CachedResource.h:
        (WebCore::CachedResource::):
        (WebCore::CachedResource::setCharset):
        (WebCore::CachedResource::url):
        (WebCore::CachedResource::type):
        (WebCore::CachedResource::referenced):
        (WebCore::CachedResource::count):
        (WebCore::CachedResource::status):
        (WebCore::CachedResource::size):
        (WebCore::CachedResource::isLoaded):
        (WebCore::CachedResource::setLoading):
        (WebCore::CachedResource::isImage):
        (WebCore::CachedResource::accessCount):
        (WebCore::CachedResource::increaseAccessCount):
        (WebCore::CachedResource::setInCache):
        (WebCore::CachedResource::inCache):
        (WebCore::CachedResource::cachePolicy):
        (WebCore::CachedResource::response):
        (WebCore::CachedResource::allData):
        (WebCore::CachedResource::canDelete):
        (WebCore::CachedResource::schedule):
        (WebCore::CachedResource::accept):
        (WebCore::CachedResource::setAccept):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::CachedScript):
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::CachedXSLStyleSheet):
        * loader/CachedXSLStyleSheet.h:
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::DocLoader):
        (WebCore::DocLoader::~DocLoader):
        (WebCore::DocLoader::checkForReload):
        (WebCore::DocLoader::requestImage):
        (WebCore::DocLoader::requestCSSStyleSheet):
        (WebCore::DocLoader::requestScript):
        (WebCore::DocLoader::requestXSLStyleSheet):
        (WebCore::DocLoader::requestXBLDocument):
        (WebCore::DocLoader::requestResource):
        (WebCore::DocLoader::setAutoLoadImages):
        (WebCore::DocLoader::removeCachedResource):
        * loader/DocLoader.h:
        (WebCore::DocLoader::cachedResource):
        (WebCore::DocLoader::allCachedResources):
        (WebCore::DocLoader::autoLoadImages):
        (WebCore::DocLoader::cachePolicy):
        (WebCore::DocLoader::expireDate):
        (WebCore::DocLoader::frame):
        (WebCore::DocLoader::doc):
        (WebCore::DocLoader::loadInProgress):
        * loader/ImageDocument.cpp:
        (WebCore::ImageTokenizer::finish):
        * loader/loader.cpp:
        (WebCore::Loader::receivedAllData):
        (WebCore::Loader::cancelRequests):
        * loader/mac/LoaderFunctionsMac.mm:
        (WebCore::NumberOfPendingOrLoadingRequests):
        (WebCore::CheckCacheObjectStatus):
        * page/Frame.cpp:
        (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
        (WebCore::Frame::Frame):
        (WebCore::Frame::stopLoading):
        (WebCore::Frame::setAutoLoadImages):
        (WebCore::Frame::autoLoadImages):
        (WebCore::Frame::begin):
        (WebCore::Frame::checkCompleted):
        (WebCore::Frame::reparseConfiguration):
        * page/Frame.h:
        * xml/XSLTProcessor.cpp:
        (WebCore::docLoaderFunc):
        * xml/xmlhttprequest.cpp:
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Test for some window properties that WebCore previously didn't enumerate.
ggaren [Thu, 19 Oct 2006 06:17:15 +0000 (06:17 +0000)]
    Test for some window properties that WebCore previously didn't enumerate.

        * fast/js/window-properties2-expected.txt: Added.
        * fast/js/window-properties2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Thu, 19 Oct 2006 05:09:44 +0000 (05:09 +0000)]
    Reviewed by Tim H.

        Improve the doubleclick behavior of breakpoints, and make breakpoints with no custom condition set appear blank instead of return [-1, 1] depending on enabled state.

        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject getDoubleClickMillis]): Add an ObjC wrapper for GetDblTime() so that JS can call it
        * Drosera/Drosera.xcodeproj/project.pbxproj: link Carbon for GetDblTime()
        * Drosera/debugger.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
thatcher [Thu, 19 Oct 2006 05:02:54 +0000 (05:02 +0000)]
    Reviewed by Anders.

        Bug 10851: Crash with Drosera
        http://bugs.webkit.org/show_bug.cgi?id=10851

        This crash results in an assert in debug builds.

        assert(implementsCall());

        The __drosera_introspection propery was not callable. Now we just assign
        this.__drosera_introspection in the evaluateWebScript call.
        This change also removes one DO message.

        * Drosera/DebuggerDocument.m:
        (-[WebScriptObject webScriptAttributeKeysForScriptObject:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
mjs [Thu, 19 Oct 2006 02:42:55 +0000 (02:42 +0000)]
JavaScriptCore:

        Reviewed by Geoff.

        - remove vestiges of KXMLCore name (former name of WTF).

        * wtf/Assertions.h:
        * wtf/FastMalloc.h:
        (operator new):
        (operator delete):
        (operator new[]):
        (operator delete[]):
        * wtf/FastMallocInternal.h:
        * wtf/Forward.h:
        * wtf/GetPtr.h:
        * wtf/HashCountedSet.h:
        * wtf/HashFunctions.h:
        * wtf/HashMap.h:
        * wtf/HashSet.h:
        * wtf/HashTable.h:
        * wtf/HashTraits.h:
        * wtf/ListRefPtr.h:
        * wtf/MathExtras.h:
        * wtf/Noncopyable.h:
        * wtf/OwnArrayPtr.h:
        * wtf/OwnPtr.h:
        * wtf/PassRefPtr.h:
        * wtf/Platform.h:
        * wtf/RefPtr.h:
        * wtf/StringExtras.h:
        (snprintf):
        * wtf/UnusedParam.h:
        * wtf/Vector.h:
        * wtf/VectorTraits.h:

WebCore:

        Reviewed by Geoff.

        - remove vestiges of KXMLCore name (former name of WTF).

        * config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17127 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Thu, 19 Oct 2006 01:43:01 +0000 (01:43 +0000)]
LayoutTests:

        Reviewed by Beth.

        Updated some results now that some global JS objects repeatably report their
        statically declared properties.

        * fast/js/window-properties-expected.txt:
        * fast/js/window-properties.html:

WebCore:

        Reviewed by Beth.

        Fixed http://bugs.webkit.org/show_bug.cgi?id=11222

        Some global JS objects lacked references to their property hashtables,
        so for-in enumeration didn't work. I added the references, and then removed
        a few bogus properties from the tables. The bogus ones got in there through
        bit rot.

        We should come up with some solution to these hand-written bindings bugs.
        Maybe we could use a script to autogenerate them or something.

        * bindings/js/kjs_window.cpp:
        (KJS::):
        (KJS::History::getValueProperty):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
aroben [Thu, 19 Oct 2006 01:05:16 +0000 (01:05 +0000)]
    Reviewed by Maciej.

        Fix: http://bugs.webkit.org/show_bug.cgi?id=11342
        fast/repaint/4774354 is failing

        It seems that this test got checked in with incorrect results, as it
        has been failing since its introduction in r17093.

        * fast/repaint/4774354-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17125 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
aroben [Thu, 19 Oct 2006 00:11:57 +0000 (00:11 +0000)]
LayoutTests:

        Reviewed by Brady.

        New test to make sure we're generating the correct keycodes for Tab
        and Shift-Tab keypresses.

        * fast/events/js-keyboard-event-creation-expected.txt: Added.
        * fast/events/js-keyboard-event-creation.html: Added.

WebCore:

        Reviewed by Brady.

        Change Shift-Tab to generate keyIdentifier U+000009 (Tab) instead of
        U+000019 (Backtab). This matches our windowsKeyCode for this key
        combination.

        * platform/mac/KeyEventMac.mm:
        (WebCore::keyIdentifierForKeyEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-18 Steve Falkenburg <sfalken@apple.com>
sfalken [Wed, 18 Oct 2006 23:28:27 +0000 (23:28 +0000)]
2006-10-18  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Adam, Brady.

        Loader tweaks.

        * platform/cf/ResourceLoaderCFNet.cpp:
        (WebCore::didFinishLoading):
        (WebCore::didFail):
        (WebCore::didReceiveChallenge):
        (WebCore::runLoaderThread):
        (WebCore::ResourceLoader::start):
        (WebCore::ResourceLoader::cancel):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady.
aroben [Wed, 18 Oct 2006 23:15:54 +0000 (23:15 +0000)]
    Reviewed by Brady.

        Fix: http://bugs.webkit.org/show_bug.cgi?id=11344
        REGRESSION (r16741): webViewDidChangeSelection delegate not firing in
        2 layout tests

        The behavior for display-none-in-onchange-keyboard is still correct
        (we don't crash when the element about to receive focus gets
        display:none set), so I've just generated new results for it.

        The behavior of tabbing-input-iframe has changed a little. iframe
        elements are now in the tab order, so I've changed the test to take
        that into account and generated new results.

        * fast/forms/display-none-in-onchange-keyboard-expected.txt:
        * fast/forms/tabbing-input-iframe-expected.txt:
        * fast/forms/tabbing-input-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
thatcher [Wed, 18 Oct 2006 22:56:13 +0000 (22:56 +0000)]
    Reviewed by Darin.

        <rdar://problem/4752138> Manipulating popup in HTML page crashed Xcode

        - Store the Mac popup button cell as a RetainPtr to prevent GC collection.
        - Convert more ObjC local statics and member variables to use RetainPtr.
        - Convert more CFRetain/CFRelease to HardRetain/HardRelease.

        * bindings/objc/DOM.mm:
        (ObjCNodeFilterCondition::ObjCNodeFilterCondition): use HardRetain and not CFRetain
        (ObjCNodeFilterCondition::~ObjCNodeFilterCondition): use HardRelease and not CFRelease
        * bridge/mac/AXObjectCacheMac.mm:
        (WebCore::AXObjectCache::~AXObjectCache): use HardRelease and not CFRelease
        (WebCore::AXObjectCache::get): use HardRetain and not CFRetain
        (WebCore::AXObjectCache::remove): use HardRelease and not CFRelease
        * bridge/mac/WebCoreFrameBridge.mm:
        (+[WebCoreFrameBridge supportedImageResourceMIMETypes]): use RetainPtr
        (+[WebCoreFrameBridge supportedImageMIMETypes]): ditto
        * bridge/mac/WebCoreIconDatabaseBridge.mm:
        (+[WebCoreIconDatabaseBridge sharedInstance]): use RetainPtr
        * platform/PopupMenu.h: renamed popup to m_popup and switched to RetainPtr<NSPopUpButtonCell>
        * platform/cf/RetainPtr.h:
        (WTF::::operator): implement a missing operator= template function
        * platform/mac/PopupMenuMac.mm:
        (WebCore::PopupMenu::PopupMenu): remove nil initialization
        (WebCore::PopupMenu::~PopupMenu): use .get(), remove release message and rename to m_popup
        (WebCore::PopupMenu::clear): use .get() when sending a message and rename to m_popup
        (WebCore::PopupMenu::populate): ditto
        (WebCore::PopupMenu::show): ditto
        (WebCore::PopupMenu::hide): ditto
        (WebCore::PopupMenu::addSeparator): ditto
        (WebCore::PopupMenu::addGroupLabel): ditto
        (WebCore::PopupMenu::addOption): ditto

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
ggaren [Wed, 18 Oct 2006 22:45:56 +0000 (22:45 +0000)]
    Reviewed by Adele.

        Fixed <rdar://problem/3673233> JavaScript timers do not fire if controls
        are tracking or menus are down (run loop modes)

        I spent a few hours trying to write an automated test, but DRT doesn't
        seem to support it. Manual tests attached to related bugs.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::passMouseDownEventToWidget):
        * platform/mac/SharedTimerMac.cpp:
        (WebCore::setSharedTimerFireTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-18 Mark Rowe <bdash@webkit.org>
bdash [Wed, 18 Oct 2006 21:30:08 +0000 (21:30 +0000)]
2006-10-18  Mark Rowe  <bdash@webkit.org>

        Reviewed by Tim H.

        http://bugs.webkit.org/show_bug.cgi?id=11304
        Bug 11304: Drosera fails to link as universal binary on PowerPC machine

        * Drosera/Drosera.xcodeproj/project.pbxproj: Use -weak_framework to link against JavaScriptCore and WebCore directly
        when they are not part of the WebKit umbrella framework.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17119 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoWebCore:
weinig [Wed, 18 Oct 2006 21:12:33 +0000 (21:12 +0000)]
WebCore:

        Reviewed by Maciej.

        More Win32 buildfix.

        * bridge/win/FrameWin.h:

WebKit:

        Reviewed by Maciej.

        Win32 build fix.

        * COM/WebFrame.cpp:
        (WebFrame::createNewWindow):
        * COM/WebFrame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-18 Anders Carlsson <acarlsson@apple.com>
andersca [Wed, 18 Oct 2006 20:51:49 +0000 (20:51 +0000)]
2006-10-18  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Adam.

        http://bugs.webkit.org/show_bug.cgi?id=11000
        REGRESSION (r16101): css2.1/t0801-c412-hz-box-00-b-a is failing because the QuickTime plugin is taking over but not rendering the png

        * WebCoreSupport/WebFrameBridge.m:
        (-[WebFrameBridge determineObjectFromMIMEType:URL:]):
        Return ObjectElementFrame if the MIME type is one of the image ones we support.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz
weinig [Wed, 18 Oct 2006 20:17:22 +0000 (20:17 +0000)]
    Reviewed by Mitz

        Win32 build fix.

        * bridge/win/BrowserExtensionWin.cpp:
        (WebCore::BrowserExtensionWin::BrowserExtensionWin):
        (WebCore::BrowserExtensionWin::createNewWindow):
        * bridge/win/BrowserExtensionWin.h:
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::createNewWindow):
        * bridge/win/FrameWin.h:
        * platform/win/CursorWin.cpp:
        * platform/win/TemporaryLinkStubs.cpp:
        (Image::getHBITMAP):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago fixo el buildo II: Release's Pride.
aroben [Wed, 18 Oct 2006 19:35:46 +0000 (19:35 +0000)]
    fixo el buildo II: Release's Pride.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17115 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 18 Oct 2006 19:27:19 +0000 (19:27 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4784823>
        GMail Editor: Hang occurs when removing list styling on text in a rich text message

        * editing/execCommand/remove-list-1-expected.checksum: Added.
        * editing/execCommand/remove-list-1-expected.png: Added.
        * editing/execCommand/remove-list-1-expected.txt: Added.
        * editing/execCommand/remove-list-1.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/4784823>
        GMail Editor: Hang occurs when removing list styling on text in a rich text message

        List removal moves the contents of every list item out of the list it's
        in. When the code tried to move the contents of an empty list item (an li
        with no child nodes, not even a placeholder br), moveParagraph didn't prune
        the li, like it would if the li had a placeholder inside it.  So the list
        removal code went into an infinite loop, continually attempting to de-list
        an empty list item.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::moveParagraphs): If the selection
        to move was empty and in an empty block that doesn't require a
        placeholder to prop itself open (like a bordered div or an li),
        remove it during the move.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17114 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
justing [Wed, 18 Oct 2006 19:22:45 +0000 (19:22 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4765600>
        REGRESSION: Mail.app: smart deletion of words does not work

        * editing/deleting/smart-delete-003-expected.checksum: Added.
        * editing/deleting/smart-delete-003-expected.png: Added.
        * editing/deleting/smart-delete-003-expected.txt: Added.
        * editing/deleting/smart-delete-003.html: Added.
        * editing/deleting/smart-delete-004-expected.checksum: Added.
        * editing/deleting/smart-delete-004-expected.png: Added.
        * editing/deleting/smart-delete-004-expected.txt: Added.
        * editing/deleting/smart-delete-004.html: Added.

WebKit:

        Reviewed by harrison

        <rdar://problem/4765600>
        REGRESSION: Mail.app: smart deletion of words does not work

        Regressed when we pushed selecion expansion down into WebCore.  It's OK
        to try a smart delete from _deleteWithDirection:, which is called by
        deleteFoward: and deleteBackward: if the current selection is a
        range.

        * WebView/WebHTMLView.m:
        (-[NSArray _deleteWithDirection:granularity:killRing:isTypingAction:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17113 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago fixo el buildo.
ggaren [Wed, 18 Oct 2006 18:59:12 +0000 (18:59 +0000)]
    fixo el buildo.

        Work around #import of <PDFKit/PDFView.h>.

        * DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Beth.
adele [Wed, 18 Oct 2006 18:47:25 +0000 (18:47 +0000)]
    Reviewed by Beth.

        - Fixed http://bugs.webkit.org/show_bug.cgi?id=11343
          REGRESSION (r16975): fast/events/objc-event-api is failing

          When I moved the autoscroll code from FrameMac to Frame, I mistakingly changed the order of
          a call to invalidateClick.  This change moves it back to the sequence that existed before.  This allows
          the click count to get properly reset during a selection.

        * page/Frame.cpp: (WebCore::Frame::handleMouseMoveEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRemoving SVGZoomEvent.idl from Copy Resources.
thatcher [Wed, 18 Oct 2006 17:42:29 +0000 (17:42 +0000)]
Removing SVGZoomEvent.idl from Copy Resources.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
kmccullo [Wed, 18 Oct 2006 17:37:04 +0000 (17:37 +0000)]
    Reviewed by Maciej.

        Adjust include paths

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17108 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Wed, 18 Oct 2006 16:29:44 +0000 (16:29 +0000)]
    Reviewed by Tim H.

        Add Xcode 3 style inline breakpoint editor. Credit to xenon for the CSS wizardry to get the appearance working properly.

        * Drosera/Drosera.xcodeproj/project.pbxproj:
        * Drosera/Images/breakpointeditor.png: Added.
        * Drosera/breakpointEditor.css: Removed.
        * Drosera/breakpointEditor.html: Removed.
        * Drosera/breakpointEditor.js: Removed.
        * Drosera/debugger.js:
        * Drosera/viewer.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
thatcher [Wed, 18 Oct 2006 15:25:48 +0000 (15:25 +0000)]
    Reviewed by Tim H.

        Bug 11341: REGRESSION (r16760): editing/selection/editable-links is failing
        http://bugs.webkit.org/show_bug.cgi?id=11341

        Link editing behavior became a preference. DumpRenderTree needs to specify the
        non-default behavior it wants (WebKitEditableLinkOnlyLiveWithShiftKey).

        * DumpRenderTree/DumpRenderTree.m:
        (main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
aroben [Wed, 18 Oct 2006 07:45:54 +0000 (07:45 +0000)]
    Reviewed by Maciej.

        Fix: http://bugs.webkit.org/show_bug.cgi?id=11340
        editing/pasteboard/4641033 needs new results

        Update results after r17071.

        * editing/pasteboard/4641033-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17105 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
ggaren [Wed, 18 Oct 2006 06:04:03 +0000 (06:04 +0000)]
    Reviewed by Anders.

        Factored common scaling code into a helper function.

        * platform/mac/ScreenMac.mm:
        (WebCore::scale):
        (WebCore::scaleScreenRectToPageCoordinates):
        (WebCore::scalePageRectToScreenCoordinates):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-17 Steve Falkenburg <sfalken@apple.com>
sfalken [Wed, 18 Oct 2006 05:46:21 +0000 (05:46 +0000)]
2006-10-17  Steve Falkenburg  <sfalken@apple.com>

        Build fixes

        * bridge/win/BrowserExtensionWin.cpp:
        (WebCore::BrowserExtensionWin::createNewWindow):
        * bridge/win/BrowserExtensionWin.h:
        * bridge/win/FrameWin.cpp:
        (WebCore::FrameWin::createNewWindow):
        * bridge/win/FrameWin.h:
        * platform/gdk/BrowserExtensionGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        (BrowserExtensionGdk::createNewWindow):
        * platform/qt/BrowserExtensionQt.cpp:
        (WebCore::BrowserExtensionQt::createNewWindow):
        * platform/qt/BrowserExtensionQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
ggaren [Wed, 18 Oct 2006 05:13:41 +0000 (05:13 +0000)]
    Reviewed by Anders.

        Renamed WindowArgs to WindowFeatures, and moved it into its own header.
        ("Features" is the term of art in IE documentation. "Args" is pirate
        talk.)

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_window.cpp:
        (KJS::createNewWindow):
        (KJS::showModalDialog):
        (KJS::setWindowFeature):
        (KJS::parseWindowFeatures):
        (KJS::constrainToVisible):
        (KJS::WindowFunc::callAsFunction):
        * bridge/BrowserExtension.h:
        * bridge/WindowFeatures.h: Added.
        * bridge/mac/BrowserExtensionMac.h:
        * bridge/mac/BrowserExtensionMac.mm:
        (WebCore::BrowserExtensionMac::createNewWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-17 Steve Falkenburg <sfalken@apple.com>
sfalken [Wed, 18 Oct 2006 04:09:51 +0000 (04:09 +0000)]
2006-10-17  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Maciej.

        Adjust include paths

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17101 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Wed, 18 Oct 2006 03:04:58 +0000 (03:04 +0000)]
    Reviewed by Tim H.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11268
        Implement the Objective-C DOM bindings for SVGNumber, SVGRect, and SVGPoint

        - Adds implementation for DOMSVGNumber, DOMSVGRect, and DOMSVGPoint.

        - Moves the contents of ksvg/bindings/js/ to bindings/js/.

        - Moves SVGZoomEvent.idl from ksvg/svg/ to ksvg/events/.

        - Adds isSVGColor() and isSVGPaint() methods to StyleBase, matching
          the other CSSValue classing, and allowing the bindings to allocate
          appropriately.

        - Removes #ifdefs around the getBBox() method in SVGLocatable.idl allowing
          generation for Objective-C.

        - Assorted style cleanups.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMCSS.mm:
        (+[DOMCSSValue _CSSValueWith:WebCore::]):
        * bindings/objc/DOMEvents.mm:
        (+[DOMEvent _eventWith:WebCore::]):
        * bindings/objc/DOMSVG.h:
        * bindings/objc/DOMSVGNumber.mm:
        (-[DOMSVGNumber dealloc]):
        (-[DOMSVGNumber finalize]):
        (-[DOMSVGNumber value]):
        (-[DOMSVGNumber setValue:]):
        (-[DOMSVGNumber _SVGNumber]):
        (-[DOMSVGNumber _initWithFloat:]):
        (+[DOMSVGNumber _SVGNumberWith:]):
        * bindings/objc/DOMSVGPoint.mm:
        (-[DOMSVGPoint dealloc]):
        (-[DOMSVGPoint finalize]):
        (-[DOMSVGPoint x]):
        (-[DOMSVGPoint setX:]):
        (-[DOMSVGPoint y]):
        (-[DOMSVGPoint setY:]):
        (-[DOMSVGPoint WebCore::]):
        (-[DOMSVGPoint _initWithFloatPoint:WebCore::]):
        (+[DOMSVGPoint _SVGPointWith:WebCore::]):
        * bindings/objc/DOMSVGRect.mm:
        (-[DOMSVGRect dealloc]):
        (-[DOMSVGRect finalize]):
        (-[DOMSVGRect x]):
        (-[DOMSVGRect setX:]):
        (-[DOMSVGRect y]):
        (-[DOMSVGRect setY:]):
        (-[DOMSVGRect width]):
        (-[DOMSVGRect setWidth:]):
        (-[DOMSVGRect height]):
        (-[DOMSVGRect setHeight:]):
        (-[DOMSVGRect WebCore::]):
        (-[DOMSVGRect _initWithFloatRect:WebCore::]):
        (+[DOMSVGRect _SVGRectWith:WebCore::]):
        * bindings/scripts/CodeGeneratorObjC.pm:
        * css/StyleBase.h:
        (WebCore::StyleBase::isSVGColor):
        (WebCore::StyleBase::isSVGPaint):
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.cpp: Removed.
        * ksvg2/bindings/js/JSSVGElementWrapperFactory.h: Removed.
        * ksvg2/bindings/js/JSSVGNumber.cpp: Removed.
        * ksvg2/bindings/js/JSSVGNumber.h: Removed.
        * ksvg2/bindings/js/JSSVGPoint.cpp: Removed.
        * ksvg2/bindings/js/JSSVGPoint.h: Removed.
        * ksvg2/bindings/js/JSSVGRect.cpp: Removed.
        * ksvg2/bindings/js/JSSVGRect.h: Removed.
        * ksvg2/svg/SVGColor.h:
        (WebCore::SVGColor::isSVGColor):
        * ksvg2/svg/SVGFECompositeElement.idl:
        * ksvg2/svg/SVGFEFloodElement.idl:
        * ksvg2/svg/SVGLocatable.idl:
        * ksvg2/svg/SVGMarkerElement.idl:
        * ksvg2/svg/SVGPaint.h:
        (WebCore::SVGPaint::isSVGPaint):
        * ksvg2/svg/SVGRectElement.idl:
        * ksvg2/svg/SVGZoomEvent.idl: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix changelog file list. It wasn't right.
hyatt [Wed, 18 Oct 2006 02:12:14 +0000 (02:12 +0000)]
Fix changelog file list.  It wasn't right.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17099 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Prepare for the elimination of the RenderLayer for <html> elements. The...
hyatt [Wed, 18 Oct 2006 02:10:17 +0000 (02:10 +0000)]
    Prepare for the elimination of the RenderLayer for <html> elements.  The layer is still present,
        but this patch makes everything work without a root layer being around.

        Reviewed by beth

        * WebCore.xcodeproj/project.pbxproj:
        * platform/KURL.cpp: Removed.
        * platform/KURL.h: Removed.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::paint):
        (WebCore::RenderBlock::paintChildren):
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderLayer.cpp:
        (WebCore::frameVisibleRect):
        (WebCore::RenderLayer::hitTest):
        (WebCore::RenderLayer::hitTestLayer):
        (WebCore::RenderLayer::intersectsDamageRect):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setInnerNode):
        * rendering/RenderView.cpp:
        (WebCore::RenderView::paint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Back out my previous patch to the WebCore memory cache.
hyatt [Wed, 18 Oct 2006 01:56:21 +0000 (01:56 +0000)]
    Back out my previous patch to the WebCore memory cache.

        * loader/Cache.cpp:
        (WebCore::Cache::flush):
        (WebCore::Cache::setSize):
        (WebCore::Cache::getLRUListFor):
        (WebCore::Cache::removeFromLRUList):
        (WebCore::Cache::insertInLRUList):
        * loader/Cache.h:
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::deref):
        * loader/CachedCSSStyleSheet.h:
        * loader/CachedImage.cpp:
        (WebCore::CachedImage::deref):
        * loader/CachedImage.h:
        * loader/CachedResource.cpp:
        (WebCore::CachedResource::setRequest):
        (WebCore::CachedResource::deref):
        * loader/CachedResource.h:
        (WebCore::CachedResource::allowInLRUList):
        * loader/CachedScript.cpp:
        (WebCore::CachedScript::deref):
        * loader/CachedScript.h:
        * loader/CachedXBLDocument.cpp:
        (WebCore::CachedXBLDocument::deref):
        * loader/CachedXBLDocument.h:
        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::deref):
        * loader/CachedXSLStyleSheet.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17097 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-17 Oliver Hunt <oliver@apple.com>
oliver [Wed, 18 Oct 2006 01:31:33 +0000 (01:31 +0000)]
2006-10-17  Oliver Hunt  <oliver@apple.com>

        Reviewed by Anders.

        Make north and east resize cursors use correct image

        * platform/win/CursorWin.cpp:
        (WebCore::eastResizeCursor):
        (WebCore::northResizeCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@17096 268f45cc-cd09-0410-ab3c-d52691b4dbfc