WebKit-https.git
12 years ago Reviewed by Darin.
mjs [Fri, 20 Apr 2007 22:20:15 +0000 (22:20 +0000)]
    Reviewed by Darin.

        - <rdar://problem/5149915> use mergesort when possible, since it leads to fewer compares (2% JS iBench speedup)

        * kjs/array_object.cpp:
        (ArrayInstance::sort): Use mergesort(3) on platforms that have it, since it tends
        to do fewer compares than qsort; but avoid it very on large arrays since it uses extra
        memory. Also added comments identifying possibly even better sorting algorithms
        for sort by string value and sort by compare function.
        * kjs/config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20974 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
mjs [Fri, 20 Apr 2007 22:00:06 +0000 (22:00 +0000)]
    Reviewed by Darin.

        - bump optimization flags up to -O3 for 1% JS iBench speed improvement

        * Configurations/Base.xcconfig:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20973 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
darin [Fri, 20 Apr 2007 21:52:14 +0000 (21:52 +0000)]
LayoutTests:

        Reviewed by Geoff Garen and John Sullivan.

        - test changes for <rdar://problem/4671964> document property on <iframe> elements causes problems for SAP application

        * fast/dom/iframe-document-expected.txt: Added.
        * fast/dom/iframe-document.html: Added.

        * fast/dom/attr_dead_doc.html: Changed to use contentDocument instead of relying on the document property
        on HTMLIFrameElement.
        * fast/events/mouseover-mouseout.html: Ditto.
        * fast/frames/repaint-display-none-crash.html: Ditto.

WebCore:

        Reviewed by Geoff Garen and John Sullivan.

        - fix <rdar://problem/4671964> document property on <iframe> elements causes problems for SAP application

        Test: fast/dom/iframe-document.html

        * bindings/js/kjs_html.h: Removed IFrameDocument.
        * bindings/js/kjs_html.cpp: (KJS::JSHTMLElement::iFrameGetter): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20972 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-20 Mark Rowe <mrowe@apple.com>
bdash [Fri, 20 Apr 2007 08:47:42 +0000 (08:47 +0000)]
2007-04-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Maciej.

        Fix bogus optimisation in the generic pthread code path.

        * kjs/collector.cpp:
        (KJS::currentThreadStackBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20971 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-20 Mark Rowe <mrowe@apple.com>
bdash [Fri, 20 Apr 2007 07:50:14 +0000 (07:50 +0000)]
2007-04-20  Mark Rowe  <mrowe@apple.com>

        Reviewed by Anders.

        Improve FreeBSD compatibility, as suggested by Alexander Botero-Lowry.

        * kjs/collector.cpp:
        (KJS::currentThreadStackBase): FreeBSD requires that pthread_attr_t's are
        initialized via pthread_attr_init before being used in any context.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20970 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Maciej.
andersca [Fri, 20 Apr 2007 07:13:24 +0000 (07:13 +0000)]
    Reviewed by Maciej.

        <rdar://problem/5085897> REGRESSION: Some Flash links at www.jumpskyhigh.com just reload the page

        Get rid of the check that would prevent plugin requests from being loaded if a new page load was underway.
        www.jumpskyhigh.com had a flash movie that was embedded inside an <a> tag and clicking on the plug-in would cause the
        URL pointed to by the <a> tag to start loading and thus preventing the plug-in from loading the real URL.

        This check was added by Maciej and we should be able to remove it with the loader changes that have happened now,
        (mainly the fact that resource loaders are handled by the document loader instead of the frame loader).

        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView loadRequest:inTarget:withNotifyData:sendNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20969 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-19 Alp Toker <alp@atoker.com>
bdash [Fri, 20 Apr 2007 06:54:25 +0000 (06:54 +0000)]
2007-04-19  Alp Toker  <alp@atoker.com>

        Reviewed by Mark.

        * platform/gdk/FontGdk.cpp:
        (WebCore::Font::drawGlyphs):
        * platform/gdk/FontPlatformDataGdk.cpp:
        (WebCore::FontPlatformData::FontPlatformData): Fix font support in Gdk port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20968 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Fix for bug 13208, implement word-break. This patch produces a partial
hyatt [Fri, 20 Apr 2007 05:02:19 +0000 (05:02 +0000)]
    Fix for bug 13208, implement word-break.  This patch produces a partial
        implementation of word-break.  word-break: break-all is implemented.  In
        addition, a custom value, word-break: break-word is added that is a hybrid
        of word-wrap: break-word and word-break: break-all (and more useful than
        either).

        Reviewed by beth

        Added fast/text/word-break.html

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSPropertyNames.in:
        * css/CSSValueKeywords.in:
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue):
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleRareInheritedData::StyleRareInheritedData):
        (WebCore::StyleRareInheritedData::operator==):
        (WebCore::RenderStyle::diff):
        * rendering/RenderStyle.h:
        (WebCore::):
        (WebCore::RenderStyle::breakWords):
        (WebCore::RenderStyle::wordBreak):
        (WebCore::RenderStyle::setWordBreak):
        (WebCore::RenderStyle::initialWordBreak):
        (WebCore::RenderStyle::initialWordWrap):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::calcMinMaxWidthInternal):
        * rendering/RenderTextControl.cpp:
        (WebCore::RenderTextControl::createInnerTextStyle):
        (WebCore::RenderTextControl::calcHeight):
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20967 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-20 Mark Rowe <mrowe@apple.com>
bdash [Fri, 20 Apr 2007 04:59:28 +0000 (04:59 +0000)]
2007-04-20  Mark Rowe  <mrowe@apple.com>

        Qt build fix for FreeBSD.

        * WebCore.pro: FreeBSD needs HAVE_PTHREAD_NP_H defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20966 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-19 Oliver Hunt <oliver@apple.com>
oliver [Fri, 20 Apr 2007 02:50:14 +0000 (02:50 +0000)]
2007-04-19  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Fix for <rdar://problem/4960912> -- REGRESSION: Content-Disposition:
        filename is ignored for drag-and-drop.

        * WebView/WebResource.mm:
        (-[WebResource _fileWrapperRepresentation]):
          When creating the NSFileWrapper check the response for a preferred
          filename, rather than just blindly hoping for the best.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20965 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-19 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 20 Apr 2007 02:09:35 +0000 (02:09 +0000)]
2007-04-19  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13403
          REGRESSION (r18875-r18899): Can no longer type into search form field after searching and then clicking "back"

        The problem was that the page was loaded from the page cache with a subtree
        marked for layout and the layout timer stopped (having been stopped when the
        page entered the page cache). FrameView::needsLayout() was returning false
        which prevented the pending layout from completing.

        * page/FrameView.cpp:
        (WebCore::FrameView::clear): Removed the call to stop the layout timer, since
        reset() does that already.
        (WebCore::FrameView::needsLayout): Changed to return true if there's a subtree
        pending relayout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20964 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-19 Mitz Pettel <mitz@webkit.org>
bdash [Fri, 20 Apr 2007 02:08:01 +0000 (02:08 +0000)]
2007-04-19  Mitz Pettel  <mitz@webkit.org>

        Rubber-stamped by Adam.

        - http://bugs.webkit.org/show_bug.cgi?id=13412
          Replace abe.jpg with a PNG file

        * editing/abe.jpg: Removed.
        * editing/deleting/4866671.html:
        * editing/deleting/delete-3608462-fix.html:
        * editing/deleting/delete-image-001.html:
        * editing/deleting/delete-image-002.html:
        * editing/deleting/delete-image-003.html:
        * editing/deleting/delete-image-004.html:
        * editing/execCommand/5080333-1-expected.checksum:
        * editing/execCommand/5080333-1-expected.png:
        * editing/execCommand/5080333-1.html:
        * editing/execCommand/5080333-2-expected.checksum:
        * editing/execCommand/5080333-2-expected.png:
        * editing/execCommand/5080333-2.html:
        * editing/execCommand/createLink-expected.txt:
        * editing/execCommand/createLink.html:
        * editing/execCommand/insertImage-expected.checksum:
        * editing/execCommand/insertImage-expected.png:
        * editing/execCommand/insertImage.html:
        * editing/execCommand/unlink-expected.txt:
        * editing/execCommand/unlink.html:
        * editing/inserting/12882.html:
        * editing/inserting/typing-around-image-001.html:
        * editing/pasteboard/4641033-expected.checksum:
        * editing/pasteboard/4641033-expected.png:
        * editing/pasteboard/4641033.html:
        * editing/pasteboard/4947130-expected.checksum:
        * editing/pasteboard/4947130-expected.png:
        * editing/pasteboard/4947130.html:
        * editing/pasteboard/4989774-expected.checksum:
        * editing/pasteboard/4989774-expected.png:
        * editing/pasteboard/4989774.html:
        * editing/pasteboard/copy-standalone-image.html:
        * editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum:
        * editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png:
        * editing/pasteboard/drag-image-to-contenteditable-in-iframe.html:
        * editing/pasteboard/drag-selected-image-to-contenteditable-expected.checksum:
        * editing/pasteboard/drag-selected-image-to-contenteditable-expected.png:
        * editing/pasteboard/drag-selected-image-to-contenteditable.html:
        * editing/pasteboard/styled-element-markup-expected.checksum:
        * editing/pasteboard/styled-element-markup-expected.png:
        * editing/pasteboard/styled-element-markup.html:
        * editing/resources/abe.jpg: Removed.
        * editing/resources/abe.png: Added.
        * editing/selection/4402375-expected.checksum:
        * editing/selection/4402375-expected.png:
        * editing/selection/4402375.html:
        * editing/selection/4932260-1-expected.checksum:
        * editing/selection/4932260-1-expected.png:
        * editing/selection/4932260-1.html:
        * editing/selection/4932260-2-expected.checksum:
        * editing/selection/4932260-2-expected.png:
        * editing/selection/4932260-2.html:
        * editing/selection/4932260-3-expected.checksum:
        * editing/selection/4932260-3-expected.png:
        * editing/selection/4932260-3.html:
        * editing/selection/drag-to-contenteditable-iframe-expected.checksum:
        * editing/selection/drag-to-contenteditable-iframe-expected.png:
        * editing/selection/drag-to-contenteditable-iframe.html:
        * editing/selection/extend-by-character-002-expected.checksum:
        * editing/selection/extend-by-character-002-expected.png:
        * editing/selection/extend-by-character-002.html:
        * editing/selection/extend-by-character-004-expected.checksum:
        * editing/selection/extend-by-character-004-expected.png:
        * editing/selection/extend-by-character-004.html:
        * editing/selection/image-before-linebreak-expected.checksum:
        * editing/selection/image-before-linebreak-expected.png:
        * editing/selection/image-before-linebreak.html:
        * editing/selection/legal-positions.html:
        * editing/selection/move-by-character-002-expected.checksum:
        * editing/selection/move-by-character-002-expected.png:
        * editing/selection/move-by-character-002.html:
        * editing/selection/move-by-character-004-expected.checksum:
        * editing/selection/move-by-character-004-expected.png:
        * editing/selection/move-by-character-004.html:
        * editing/selection/replaced-boundaries-1-expected.checksum:
        * editing/selection/replaced-boundaries-1-expected.png:
        * editing/selection/replaced-boundaries-1.html:
        * editing/selection/replaced-boundaries-2-expected.checksum:
        * editing/selection/replaced-boundaries-2-expected.png:
        * editing/selection/replaced-boundaries-2.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20963 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Fri, 20 Apr 2007 01:53:22 +0000 (01:53 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/5144139>
        On delete, <BR> inserted into non-editable ToDo <TABLE> element

        * editing/deleting/5144139-2-expected.checksum: Added.
        * editing/deleting/5144139-2-expected.png: Added.
        * editing/deleting/5144139-2-expected.txt: Added.
        * editing/deleting/5144139-2.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/5144139>
        On delete, <BR> inserted into non-editable ToDo <TABLE> element

        The fact that the br was being inserted at a bad position
        (a non-editable position and one inside a table instead of
        before it) was fixed in the previous checkin. This change
        stops us from inserting a br at all, to fix the bug.

        After a delete, we need a placeholder if the selection
        started at the start of a paragraph and ended at the end
        of a paragraph. But not if it starts just before a table
        and ends inside that table.  We need placeholders to hold
        open emptied out table cells, but that is handled separately.

        Also, moved lineBreakExistsAtPosition to htmlediting.cpp
        so that it can be used in more places.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::removePlaceholderAt):
        (WebCore::CompositeEditCommand::moveParagraphs):
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::doApply):
        * editing/InsertLineBreakCommand.cpp:
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/htmlediting.cpp:
        (WebCore::lineBreakExistsAtPosition):
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20962 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Fri, 20 Apr 2007 00:08:50 +0000 (00:08 +0000)]
LayoutTests:

        Reviewed by harrison

        * editing/execCommand/5144139-1-expected.checksum: Added.
        * editing/execCommand/5144139-1-expected.png: Added.
        * editing/execCommand/5144139-1-expected.txt: Added.
        * editing/execCommand/5144139-1.html: Added.

WebCore:

        Reviewed by harrison

        Fixes some issues found while investigating:
        <rdar://problem/5144139> On delete, <BR> inserted into non-editable ToDo <TABLE> element

        Move the code to handle inserting content before/after
        tables for [table, 0/max] to insertNodeAt, so that
        all insertions get it, not just some.
        Changed insertNodeAt to take in a position instead of a
        node and an offset.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::insertNodeAt):
        (WebCore::CompositeEditCommand::insertNodeAtTabSpanPosition):
        (WebCore::CompositeEditCommand::insertBlockPlaceholder):
        (WebCore::CompositeEditCommand::moveParagraphContentsToNewBlockIfNecessary):
        If paragrahStart.node() is an atomic node, insertNodeAt can handle
        insertion, we don't need to special case it.
        (WebCore::CompositeEditCommand::moveParagraphs):
        (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
        * editing/CompositeEditCommand.h:
        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::mergeParagraphs):
        (WebCore::DeleteSelectionCommand::doApply):
        * editing/FormatBlockCommand.cpp:
        (WebCore::FormatBlockCommand::doApply):
        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion):
        (WebCore::IndentOutdentCommand::outdentParagraph):
        * editing/InsertLineBreakCommand.cpp:
        (WebCore::InsertLineBreakCommand::doApply):
        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply):
        * editing/InsertParagraphSeparatorCommand.cpp:
        (WebCore::InsertParagraphSeparatorCommand::doApply):
        * editing/InsertTextCommand.cpp:
        (WebCore::InsertTextCommand::prepareForTextInsertion): Removed some
        dead code that handled insertion at non-editable positions.
        (WebCore::InsertTextCommand::insertTab):
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::doApply):
        (WebCore::ReplaceSelectionCommand::insertNodeAtAndUpdateNodesInserted):
        * editing/ReplaceSelectionCommand.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20960 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
andrew [Thu, 19 Apr 2007 22:35:06 +0000 (22:35 +0000)]
    Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13336
          REGRESSION (r20646): editing/execCommand/hilitecolor.html crashes under guardMalloc

        Avoid calling selectionRect() and selectionGapRects() on a renderer that needs
        layout.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::selectionGapRects):
        * rendering/RenderBlock.h:
        (WebCore::RenderBlock::BlockSelectionInfo::BlockSelectionInfo):
        * rendering/RenderListMarker.cpp:
        (WebCore::RenderListMarker::selectionRect):
        * rendering/RenderObject.h:
        (WebCore::RenderObject::SelectionInfo::SelectionInfo):
        * rendering/RenderReplaced.cpp:
        (WebCore::RenderReplaced::selectionRect):
        * rendering/RenderText.cpp:
        (WebCore::RenderText::selectionRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20959 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Thu, 19 Apr 2007 20:27:47 +0000 (20:27 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5142012>
        GoogleDocs: Crash at WebCore::Range::startPosition() when creating a list from a link

        Tests the change to pushAnchorElementDown, where we remove
        the anchor element that has had copies of it pushed down:
        * editing/execCommand/5142012-1-expected.checksum: Added.
        * editing/execCommand/5142012-1-expected.png: Added.
        * editing/execCommand/5142012-1-expected.txt: Added.
        * editing/execCommand/5142012-1.html: Added.

        Demonstrates the crash (fixed by adding nil-checks
        to moveParagraphs):
        * editing/execCommand/5142012-2-expected.checksum: Added.
        * editing/execCommand/5142012-2-expected.png: Added.
        * editing/execCommand/5142012-2-expected.txt: Added.
        * editing/execCommand/5142012-2.html: Added.

        Tests the changes to positionAvoidingSpecialElementBoundary,
        where we push down anchors before we avoid them so that
        we don't also avoid structural elements like lists and paragraphs:
        * editing/execCommand/5142012-3-expected.checksum: Added.
        * editing/execCommand/5142012-3-expected.png: Added.
        * editing/execCommand/5142012-3-expected.txt: Added.
        * editing/execCommand/5142012-3.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/5142012>
        GoogleDocs: Crash at WebCore::Range::startPosition() when creating a list from a link

        List creation uses moveParagraphs to push content into list items.
        Its fragment creation (using createMarkup) incorrectly uses regular
        spaces instead of nbsps for spaces that were rendered (11475), which
        causes spaces to be collapsed during the move operation.  This results
        in a call to rangeFromLocationAndLength with a location past the end
        of the document.  We use the result from rangeFromLocationAndLength
        (null) and crash.

        Also when moveParagraphs tries to push content into a list item surrounded
        by an anchor, it fails because positionAvoidingSpecialElementBoundary avoids
        the anchor, which also avoids the list item.  This was fixed by pushing
        down anchors before avoiding them.

        * editing/CompositeEditCommand.cpp:
        (WebCore::CompositeEditCommand::pushAnchorElementDown): Remove the
        old anchor after we push down clones of it, this is what callers
        expect.
        (WebCore::CompositeEditCommand::pushPartiallySelectedAnchorElementsDown):
        Call the new enclosingAnchorElement, that takes in a position instead
        of a node.
        (WebCore::CompositeEditCommand::moveParagraphs): If spaces collapsed
        as a result of the move, rangeFromLocationAndLength can return null,
        bail and don't try to preserve the selection in that case.
        (WebCore::CompositeEditCommand::positionAvoidingSpecialElementBoundary):
        Moved from htmlediting.cpp.
        Make sure anchors are pushed down before avoiding them so that we don't
        also avoid structural elements like lists and blocks.
        * editing/CompositeEditCommand.h:
        * editing/TypingCommand.cpp: Moved isFirst/LastPositionBefore/AfterTable
        to htmlediting.cpp.
        * editing/htmlediting.cpp:
        Moved positionAvoidingSpecialElementBoundary so that it could call
        pushAnchorElementDown.
        (WebCore::isFirstPositionAfterTable): Moved here.
        (WebCore::isLastPositionBeforeTable): Moved here.
        (WebCore::enclosingAnchorElement): Moved here.
        (WebCore::enclosingListChild): Removed an extraneous space.
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20958 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
bdakin [Thu, 19 Apr 2007 19:58:20 +0000 (19:58 +0000)]
WebCore:
       Reviewed by Hyatt.

        Fix for <rdar://problem/5120889> Sized table cells w/borders not
        drawn to correct size

        When table cells have children with %-height, the cells were
        incorrectly shrinking down to be the size of the child. This
        exposed another problem with replaced children and sizing.

        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcReplacedHeightUsing): The exposed problem.
        Subtract our borders and padding in the auto or percent table cell
        containing block case.
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::layoutRows): When our children can
        flex, do not always set the cellTopExtra and cellBottomExtra to 0!
        That is bad! We should do the same as the non-flex case.

Layout Tests:
        Reviewed by Hyatt.

        Series of new/rearranged results after fix for <rdar://problem/
        5120889> Sized table cells w/borders not drawn to correct size

        These tests are different by tiny, barely noticeable amounts. The
        new results are more correct. We didn't catch the problem before
        because it was so subtle here:
        * fast/replaced/width100percent-expected.txt:
        * fast/table/003-expected.checksum:
        * fast/table/003-expected.png:
        * fast/table/003-expected.txt:

        This is the test that exposed the other problem with replaced
        children. Now we fit snugly inside the border on the bottom, which
        is different than Firefox, but seems right.
        * tables/mozilla/bugs/bug131020-expected.checksum:
        * tables/mozilla/bugs/bug131020-expected.png:
        * tables/mozilla/bugs/bug131020-expected.txt:

        This test actually always failed and was incorrectly filed as a
        success. Moving to failures.
        * tables/mozilla/bugs/bug137388-2-expected.checksum: Removed.
        * tables/mozilla/bugs/bug137388-2-expected.png: Removed.
        * tables/mozilla/bugs/bug137388-2-expected.txt: Removed.
        * tables/mozilla/bugs/bug137388-2.html: Removed.
        * tables/mozilla_expected_failures/bugs/bug137388-2-expected.checksum: Added.
        * tables/mozilla_expected_failures/bugs/bug137388-2-expected.png: Added.
        * tables/mozilla_expected_failures/bugs/bug137388-2-expected.txt: Added.

        This test was actually wrong before, and now it is right!
        * tables/mozilla/bugs/bug149275-2-expected.checksum:
        * tables/mozilla/bugs/bug149275-2-expected.png:
        * tables/mozilla/bugs/bug149275-2-expected.txt:

        This was a failing test that now passes. YAY!
        * tables/mozilla/bugs/bug18440-expected.checksum: Added.
        * tables/mozilla/bugs/bug18440-expected.png: Added.
        * tables/mozilla/bugs/bug18440-expected.txt: Added.
* tables/mozilla_expected_failures/bugs/bug18440-expected.checksum: Removed.
        * tables/mozilla_expected_failures/bugs/bug18440-expected.png: Removed.
        * tables/mozilla_expected_failures/bugs/bug18440-expected.txt: Removed.
        * tables/mozilla_expected_failures/bugs/bug18440.html: Removed.

        This was slightly wrong before and is now correct.
        * tables/mozilla/bugs/bug30692-expected.checksum:
        * tables/mozilla/bugs/bug30692-expected.png:
        * tables/mozilla/bugs/bug30692-expected.txt:

        Still wrong, but slightly more correct.
        * tables/mozilla_expected_failures/bugs/bug137388-1-expected.checksum:
        * tables/mozilla_expected_failures/bugs/bug137388-1-expected.png:
        * tables/mozilla_expected_failures/bugs/bug137388-1-expected.txt:

        So much closer to being correct!! But still slightly wrong.
        * tables/mozilla_expected_failures/bugs/bug19526-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20957 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
andersca [Thu, 19 Apr 2007 19:19:16 +0000 (19:19 +0000)]
LayoutTests:

        Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=13333
        Support naturalWidth/naturalHeight on image elements

        * fast/dom/HTMLImageElement/image-natural-width-height-expected.txt: Added.
        * fast/dom/HTMLImageElement/image-natural-width-height.html: Added.

WebCore:

        Reviewed by Geoff.

        http://bugs.webkit.org/show_bug.cgi?id=13333
        Support naturalWidth/naturalHeight on image elements

        * html/HTMLImageElement.cpp:
        (WebCore::HTMLImageElement::naturalWidth):
        (WebCore::HTMLImageElement::naturalHeight):
        * html/HTMLImageElement.h:
        * html/HTMLImageElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20954 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - review suggestion for rdar://5145011 code change
pyeh [Thu, 19 Apr 2007 18:56:25 +0000 (18:56 +0000)]
    - review suggestion for rdar://5145011 code change

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject value]):
        return early if value attribute is not supported by the attachment view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20953 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago <rdar://problem/5145011> Allow attachment view of web object to handle access...
pyeh [Thu, 19 Apr 2007 18:21:06 +0000 (18:21 +0000)]
    <rdar://problem/5145011> Allow attachment view of web object to handle accessibility actions

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject value]):
        Only allow asking the attachmentView for value if attachmentView supports this value attribute
        (-[WebCoreAXObject title]):
        (-[WebCoreAXObject accessibilityAttributeNames]):
        Should not return that long list of unrelated attributes for attachmentView.
        (-[WebCoreAXObject accessibilityActionNames]):
        (-[WebCoreAXObject accessibilityPerformAction:]):
        Allow attachmentView a chance to handle actions.
        (-[WebCoreAXObject accessibilityParameterizedAttributeNames]):
        Should not return that long list of unrelated attributes for attachmentView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20952 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by John.
andersca [Thu, 19 Apr 2007 16:47:51 +0000 (16:47 +0000)]
    Reviewed by John.

        <rdar://problem/5137002>
        REGRESSION (r20812): [WebFrame DOMDocument] is returning non-nil value in bookmarks view, causing trouble in Safari

        Put back the MIME type check as a workaround.
        * WebView/WebFrame.mm:
        (-[WebFrame DOMDocument]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20951 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
weinig [Thu, 19 Apr 2007 14:47:21 +0000 (14:47 +0000)]
LayoutTests:

        Reviewed by Hyatt

        - updated results for http://bugs.webkit.org/show_bug.cgi?id=13291
          REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse

        * editing/deleting/4845371-expected.txt:
        * editing/deleting/collapse-whitespace-3587601-fix-expected.txt:
        * editing/deleting/delete-3608430-fix-expected.txt:
        * editing/deleting/delete-3608445-fix-expected.txt:
        * editing/deleting/delete-3608462-fix-expected.txt:
        * editing/deleting/delete-3775172-fix-expected.txt:
        * editing/deleting/delete-3800834-fix-expected.txt:
        * editing/deleting/delete-3857753-fix-expected.txt:
        * editing/deleting/delete-3865854-fix-expected.txt:
        * editing/deleting/delete-3928305-fix-expected.txt:
        * editing/deleting/delete-3959464-fix-expected.txt:
        * editing/deleting/delete-4038408-fix-expected.txt:
        * editing/deleting/delete-4083333-fix-expected.txt:
        * editing/deleting/delete-after-span-ws-001-expected.txt:
        * editing/deleting/delete-after-span-ws-002-expected.txt:
        * editing/deleting/delete-after-span-ws-003-expected.txt:
        * editing/deleting/delete-all-text-in-text-field-assertion-expected.txt:
        * editing/deleting/delete-and-undo-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-001-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-002-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-003-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-004-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-005-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-006-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-007-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-008-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-009-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-010-expected.txt:
        * editing/deleting/delete-at-paragraph-boundaries-011-expected.txt:
        * editing/deleting/delete-at-start-or-end-expected.txt:
        * editing/deleting/delete-block-contents-001-expected.txt:
        * editing/deleting/delete-block-contents-002-expected.txt:
        * editing/deleting/delete-block-contents-003-expected.txt:
        * editing/deleting/delete-block-merge-contents-001-expected.txt:
        * editing/deleting/delete-block-merge-contents-002-expected.txt:
        * editing/deleting/delete-block-merge-contents-003-expected.txt:
        * editing/deleting/delete-block-merge-contents-004-expected.txt:
        * editing/deleting/delete-block-merge-contents-005-expected.txt:
        * editing/deleting/delete-block-merge-contents-006-expected.txt:
        * editing/deleting/delete-block-merge-contents-007-expected.txt:
        * editing/deleting/delete-block-merge-contents-008-expected.txt:
        * editing/deleting/delete-block-merge-contents-009-expected.txt:
        * editing/deleting/delete-block-merge-contents-010-expected.txt:
        * editing/deleting/delete-block-merge-contents-011-expected.txt:
        * editing/deleting/delete-block-merge-contents-012-expected.txt:
        * editing/deleting/delete-block-merge-contents-013-expected.txt:
        * editing/deleting/delete-block-merge-contents-014-expected.txt:
        * editing/deleting/delete-block-merge-contents-015-expected.txt:
        * editing/deleting/delete-block-merge-contents-016-expected.txt:
        * editing/deleting/delete-block-merge-contents-017-expected.txt:
        * editing/deleting/delete-block-merge-contents-018-expected.txt:
        * editing/deleting/delete-block-merge-contents-019-expected.txt:
        * editing/deleting/delete-block-merge-contents-020-expected.txt:
        * editing/deleting/delete-block-merge-contents-021-expected.txt:
        * editing/deleting/delete-block-merge-contents-022-expected.txt:
        * editing/deleting/delete-block-merge-contents-023-expected.txt:
        * editing/deleting/delete-block-merge-contents-024-expected.txt:
        * editing/deleting/delete-block-table-expected.txt:
        * editing/deleting/delete-br-001-expected.txt:
        * editing/deleting/delete-br-002-expected.txt:
        * editing/deleting/delete-br-003-expected.txt:
        * editing/deleting/delete-br-004-expected.txt:
        * editing/deleting/delete-br-005-expected.txt:
        * editing/deleting/delete-br-006-expected.txt:
        * editing/deleting/delete-br-007-expected.txt:
        * editing/deleting/delete-br-008-expected.txt:
        * editing/deleting/delete-br-009-expected.txt:
        * editing/deleting/delete-br-010-expected.txt:
        * editing/deleting/delete-br-011-expected.txt:
        * editing/deleting/delete-br-012-expected.txt:
        * editing/deleting/delete-by-word-001-expected.txt:
        * editing/deleting/delete-by-word-002-expected.txt:
        * editing/deleting/delete-character-001-expected.txt:
        * editing/deleting/delete-contiguous-ws-001-expected.txt:
        * editing/deleting/delete-first-list-item-expected.txt:
        * editing/deleting/delete-hr-expected.txt:
        * editing/deleting/delete-image-001-expected.txt:
        * editing/deleting/delete-image-002-expected.txt:
        * editing/deleting/delete-image-003-expected.txt:
        * editing/deleting/delete-image-004-expected.txt:
        * editing/deleting/delete-leading-ws-001-expected.txt:
        * editing/deleting/delete-line-001-expected.txt:
        * editing/deleting/delete-line-002-expected.txt:
        * editing/deleting/delete-line-003-expected.txt:
        * editing/deleting/delete-line-004-expected.txt:
        * editing/deleting/delete-line-005-expected.txt:
        * editing/deleting/delete-line-006-expected.txt:
        * editing/deleting/delete-line-007-expected.txt:
        * editing/deleting/delete-line-008-expected.txt:
        * editing/deleting/delete-line-009-expected.txt:
        * editing/deleting/delete-line-010-expected.txt:
        * editing/deleting/delete-line-011-expected.txt:
        * editing/deleting/delete-line-012-expected.txt:
        * editing/deleting/delete-line-013-expected.txt:
        * editing/deleting/delete-line-014-expected.txt:
        * editing/deleting/delete-line-015-expected.txt:
        * editing/deleting/delete-line-016-expected.txt:
        * editing/deleting/delete-line-017-expected.txt:
        * editing/deleting/delete-line-end-ws-001-expected.txt:
        * editing/deleting/delete-line-end-ws-002-expected.txt:
        * editing/deleting/delete-link-1-expected.txt:
        * editing/deleting/delete-listitem-001-expected.txt:
        * editing/deleting/delete-listitem-002-expected.txt:
        * editing/deleting/delete-mixed-editable-content-001-expected.txt:
        * editing/deleting/delete-select-all-001-expected.txt:
        * editing/deleting/delete-select-all-002-expected.txt:
        * editing/deleting/delete-select-all-003-expected.txt:
        * editing/deleting/delete-selection-001-expected.txt:
        * editing/deleting/delete-tab-001-expected.txt:
        * editing/deleting/delete-tab-002-expected.txt:
        * editing/deleting/delete-tab-003-expected.txt:
        * editing/deleting/delete-tab-004-expected.txt:
        * editing/deleting/delete-to-end-of-paragraph-expected.txt:
        * editing/deleting/delete-to-select-table-expected.txt:
        * editing/deleting/delete-trailing-ws-001-expected.txt:
        * editing/deleting/delete-trailing-ws-002-expected.txt:
        * editing/deleting/delete-ws-fixup-001-expected.txt:
        * editing/deleting/delete-ws-fixup-002-expected.txt:
        * editing/deleting/delete-ws-fixup-003-expected.txt:
        * editing/deleting/delete-ws-fixup-004-expected.txt:
        * editing/deleting/forward-delete-expected.txt:
        * editing/deleting/list-item-1-expected.txt:
        * editing/deleting/merge-different-styles-expected.txt:
        * editing/deleting/merge-endOfParagraph-expected.txt:
        * editing/deleting/merge-into-empty-block-1-expected.txt:
        * editing/deleting/merge-into-empty-block-2-expected.txt:
        * editing/deleting/merge-no-br-expected.txt:
        * editing/deleting/merge-unrendered-space-expected.txt:
        * editing/deleting/paragraph-in-preserveNewline-expected.txt:
        * editing/deleting/pruning-after-merge-1-expected.txt:
        * editing/deleting/pruning-after-merge-2-expected.txt:
        * editing/deleting/smart-delete-001-expected.txt:
        * editing/deleting/smart-delete-002-expected.txt:
        * editing/deleting/smart-delete-003-expected.txt:
        * editing/deleting/smart-delete-004-expected.txt:
        * editing/deleting/table-cells-expected.txt:
        * editing/deleting/transpose-empty-expected.txt:
        * editing/deleting/whitespace-pre-1-expected.txt:
        * editing/execCommand/4641880-1-expected.txt:
        * editing/execCommand/4641880-2-expected.txt:
        * editing/execCommand/boldSelection-expected.txt:
        * editing/execCommand/create-list-from-range-selection-expected.txt:
        * editing/execCommand/create-list-with-hr-expected.txt:
        * editing/execCommand/createLink-expected.txt:
        * editing/execCommand/format-block-expected.txt:
        * editing/execCommand/format-block-from-range-selection-expected.txt:
        * editing/execCommand/format-block-with-braces-expected.txt:
        * editing/execCommand/format-block-with-trailing-br-expected.txt:
        * editing/execCommand/hilitecolor-expected.txt:
        * editing/execCommand/indent-empty-root-expected.txt:
        * editing/execCommand/indent-list-item-expected.txt:
        * editing/execCommand/indent-selection-expected.txt:
        * editing/execCommand/insert-list-and-stitch-expected.txt:
        * editing/execCommand/insert-list-with-id-expected.txt:
        * editing/execCommand/insertHTML-expected.txt:
        * editing/execCommand/insertHorizontalRule-expected.txt:
        * editing/execCommand/insertImage-expected.txt:
        * editing/execCommand/italicizeByCharacter-expected.txt:
        * editing/execCommand/modifyForeColorByCharacter-expected.txt:
        * editing/execCommand/nsresponder-indent-expected.txt:
        * editing/execCommand/nsresponder-outdent-expected.txt:
        * editing/execCommand/outdent-selection-expected.txt:
        * editing/execCommand/print-expected.txt:
        * editing/execCommand/queryCommandState-01-expected.txt:
        * editing/execCommand/remove-formatting-2-expected.txt:
        * editing/execCommand/remove-formatting-expected.txt:
        * editing/execCommand/remove-list-from-range-selection-expected.txt:
        * editing/execCommand/remove-list-item-1-expected.txt:
        * editing/execCommand/remove-list-items-expected.txt:
        * editing/execCommand/selectAll-expected.txt:
        * editing/execCommand/strikethroughSelection-expected.txt:
        * editing/execCommand/switch-list-type-expected.txt:
        * editing/execCommand/unlink-expected.txt:
        * editing/input/firstrectforcharacterrange-plain-expected.txt:
        * editing/input/firstrectforcharacterrange-styled-expected.txt:
        * editing/input/wrapped-line-char-rect-expected.txt:
        * editing/inserting/4278698-expected.txt:
        * editing/inserting/before-after-input-element-expected.txt:
        * editing/inserting/editable-html-element-expected.txt:
        * editing/inserting/editing-empty-divs-expected.txt:
        * editing/inserting/insert-3654864-fix-expected.txt:
        * editing/inserting/insert-3659587-fix-expected.txt:
        * editing/inserting/insert-3775316-fix-expected.txt:
        * editing/inserting/insert-3778059-fix-expected.txt:
        * editing/inserting/insert-3786362-fix-expected.txt:
        * editing/inserting/insert-3800346-fix-expected.txt:
        * editing/inserting/insert-3851164-fix-expected.txt:
        * editing/inserting/insert-3907422-fix-expected.txt:
        * editing/inserting/insert-after-delete-001-expected.txt:
        * editing/inserting/insert-at-end-01-expected.txt:
        * editing/inserting/insert-at-end-02-expected.txt:
        * editing/inserting/insert-before-link-1-expected.txt:
        * editing/inserting/insert-br-001-expected.txt:
        * editing/inserting/insert-br-002-expected.txt:
        * editing/inserting/insert-br-003-expected.txt:
        * editing/inserting/insert-br-004-expected.txt:
        * editing/inserting/insert-br-005-expected.txt:
        * editing/inserting/insert-br-006-expected.txt:
        * editing/inserting/insert-br-007-expected.txt:
        * editing/inserting/insert-br-008-expected.txt:
        * editing/inserting/insert-br-009-expected.txt:
        * editing/inserting/insert-br-at-tabspan-001-expected.txt:
        * editing/inserting/insert-br-at-tabspan-002-expected.txt:
        * editing/inserting/insert-br-at-tabspan-003-expected.txt:
        * editing/inserting/insert-br-quoted-001-expected.txt:
        * editing/inserting/insert-br-quoted-002-expected.txt:
        * editing/inserting/insert-br-quoted-003-expected.txt:
        * editing/inserting/insert-br-quoted-004-expected.txt:
        * editing/inserting/insert-br-quoted-005-expected.txt:
        * editing/inserting/insert-br-quoted-006-expected.txt:
        * editing/inserting/insert-div-001-expected.txt:
        * editing/inserting/insert-div-002-expected.txt:
        * editing/inserting/insert-div-003-expected.txt:
        * editing/inserting/insert-div-004-expected.txt:
        * editing/inserting/insert-div-005-expected.txt:
        * editing/inserting/insert-div-006-expected.txt:
        * editing/inserting/insert-div-007-expected.txt:
        * editing/inserting/insert-div-008-expected.txt:
        * editing/inserting/insert-div-009-expected.txt:
        * editing/inserting/insert-div-010-expected.txt:
        * editing/inserting/insert-div-011-expected.txt:
        * editing/inserting/insert-div-012-expected.txt:
        * editing/inserting/insert-div-013-expected.txt:
        * editing/inserting/insert-div-014-expected.txt:
        * editing/inserting/insert-div-015-expected.txt:
        * editing/inserting/insert-div-016-expected.txt:
        * editing/inserting/insert-div-017-expected.txt:
        * editing/inserting/insert-div-018-expected.txt:
        * editing/inserting/insert-div-019-expected.txt:
        * editing/inserting/insert-div-020-expected.txt:
        * editing/inserting/insert-div-021-expected.txt:
        * editing/inserting/insert-div-022-expected.txt:
        * editing/inserting/insert-div-023-expected.txt:
        * editing/inserting/insert-div-024-expected.txt:
        * editing/inserting/insert-div-025-expected.txt:
        * editing/inserting/insert-div-026-expected.txt:
        * editing/inserting/insert-div-027-expected.txt:
        * editing/inserting/insert-paragraph-01-expected.txt:
        * editing/inserting/insert-paragraph-02-expected.txt:
        * editing/inserting/insert-paragraph-03-expected.txt:
        * editing/inserting/insert-paragraph-04-expected.txt:
        * editing/inserting/insert-space-in-empty-doc-expected.txt:
        * editing/inserting/insert-tab-001-expected.txt:
        * editing/inserting/insert-tab-002-expected.txt:
        * editing/inserting/insert-tab-003-expected.txt:
        * editing/inserting/insert-tab-004-expected.txt:
        * editing/inserting/insert-text-at-tabspan-001-expected.txt:
        * editing/inserting/insert-text-at-tabspan-002-expected.txt:
        * editing/inserting/insert-text-at-tabspan-003-expected.txt:
        * editing/inserting/insert-text-with-newlines-expected.txt:
        * editing/inserting/line-break-expected.txt:
        * editing/inserting/multiple-lines-selected-expected.txt:
        * editing/inserting/paragraph-separator-01-expected.txt:
        * editing/inserting/paragraph-separator-02-expected.txt:
        * editing/inserting/paragraph-separator-03-expected.txt:
        * editing/inserting/paragraph-separator-in-table-1-expected.txt:
        * editing/inserting/paragraph-separator-in-table-2-expected.txt:
        * editing/inserting/redo-expected.txt:
        * editing/inserting/return-key-with-selection-001-expected.txt:
        * editing/inserting/return-key-with-selection-002-expected.txt:
        * editing/inserting/return-key-with-selection-003-expected.txt:
        * editing/inserting/typing-001-expected.txt:
        * editing/inserting/typing-002-expected.txt:
        * editing/inserting/typing-003-expected.txt:
        * editing/inserting/typing-around-br-001-expected.txt:
        * editing/inserting/typing-around-image-001-expected.txt:
        * editing/pasteboard/3976872-expected.txt:
        * editing/pasteboard/4076267-2-expected.txt:
        * editing/pasteboard/4076267-3-expected.txt:
        * editing/pasteboard/4076267-expected.txt:
        * editing/pasteboard/4242293-1-expected.txt:
        * editing/pasteboard/4242293-expected.txt:
        * editing/pasteboard/4631972-expected.txt:
        * editing/pasteboard/4641033-expected.txt:
        * editing/pasteboard/4700297-expected.txt:
        * editing/pasteboard/4744008-expected.txt:
        * editing/pasteboard/8145-1-expected.txt:
        * editing/pasteboard/8145-2-expected.txt:
        * editing/pasteboard/8145-3-expected.txt:
        * editing/pasteboard/bad-placeholder-expected.txt:
        * editing/pasteboard/block-wrappers-necessary-expected.txt:
        * editing/pasteboard/copy-in-password-field-expected.txt:
        * editing/pasteboard/copy-standalone-image-expected.txt:
        * editing/pasteboard/cut-text-001-expected.txt:
        * editing/pasteboard/displaced-generic-placeholder-expected.txt:
        * editing/pasteboard/displaced-placeholder-expected.txt:
        * editing/pasteboard/display-block-on-spans-expected.txt:
        * editing/pasteboard/drag-drop-modifies-page-expected.txt:
        * editing/pasteboard/drag-selected-image-to-contenteditable-expected.txt:
        * editing/pasteboard/drop-link-expected.txt:
        * editing/pasteboard/emacs-cntl-y-001-expected.txt:
        * editing/pasteboard/emacs-ctrl-a-k-y-expected.txt:
        * editing/pasteboard/emacs-ctrl-k-y-001-expected.txt:
        * editing/pasteboard/interchange-newline-1-expected.txt:
        * editing/pasteboard/interchange-newline-2-expected.txt:
        * editing/pasteboard/interchange-newline-3-expected.txt:
        * editing/pasteboard/interchange-newline-4-expected.txt:
        * editing/pasteboard/merge-after-delete-1-expected.txt:
        * editing/pasteboard/merge-after-delete-2-expected.txt:
        * editing/pasteboard/merge-after-delete-expected.txt:
        * editing/pasteboard/merge-end-3-expected.txt:
        * editing/pasteboard/merge-end-4-expected.txt:
        * editing/pasteboard/merge-end-5-expected.txt:
        * editing/pasteboard/merge-end-blockquote-expected.txt:
        * editing/pasteboard/merge-end-borders-expected.txt:
        * editing/pasteboard/merge-end-list-expected.txt:
        * editing/pasteboard/merge-end-table-expected.txt:
        * editing/pasteboard/merge-start-blockquote-expected.txt:
        * editing/pasteboard/merge-start-list-expected.txt:
        * editing/pasteboard/nested-blocks-with-text-area-expected.txt:
        * editing/pasteboard/nested-blocks-with-text-field-expected.txt:
        * editing/pasteboard/paste-4035648-fix-expected.txt:
        * editing/pasteboard/paste-4038267-fix-expected.txt:
        * editing/pasteboard/paste-4039777-fix-expected.txt:
        * editing/pasteboard/paste-RTFD-expected.txt:
        * editing/pasteboard/paste-TIFF-expected.txt:
        * editing/pasteboard/paste-line-endings-001-expected.txt:
        * editing/pasteboard/paste-line-endings-002-expected.txt:
        * editing/pasteboard/paste-line-endings-003-expected.txt:
        * editing/pasteboard/paste-line-endings-004-expected.txt:
        * editing/pasteboard/paste-line-endings-005-expected.txt:
        * editing/pasteboard/paste-line-endings-006-expected.txt:
        * editing/pasteboard/paste-line-endings-007-expected.txt:
        * editing/pasteboard/paste-line-endings-008-expected.txt:
        * editing/pasteboard/paste-line-endings-009-expected.txt:
        * editing/pasteboard/paste-line-endings-010-expected.txt:
        * editing/pasteboard/paste-list-001-expected.txt:
        * editing/pasteboard/paste-match-style-001-expected.txt:
        * editing/pasteboard/paste-match-style-002-expected.txt:
        * editing/pasteboard/paste-pre-001-expected.txt:
        * editing/pasteboard/paste-pre-002-expected.txt:
        * editing/pasteboard/paste-table-001-expected.txt:
        * editing/pasteboard/paste-table-002-expected.txt:
        * editing/pasteboard/paste-table-003-expected.txt:
        * editing/pasteboard/paste-text-001-expected.txt:
        * editing/pasteboard/paste-text-002-expected.txt:
        * editing/pasteboard/paste-text-003-expected.txt:
        * editing/pasteboard/paste-text-004-expected.txt:
        * editing/pasteboard/paste-text-005-expected.txt:
        * editing/pasteboard/paste-text-006-expected.txt:
        * editing/pasteboard/paste-text-007-expected.txt:
        * editing/pasteboard/paste-text-008-expected.txt:
        * editing/pasteboard/paste-text-009-expected.txt:
        * editing/pasteboard/paste-text-010-expected.txt:
        * editing/pasteboard/paste-text-011-expected.txt:
        * editing/pasteboard/paste-text-012-expected.txt:
        * editing/pasteboard/paste-text-013-expected.txt:
        * editing/pasteboard/paste-text-014-expected.txt:
        * editing/pasteboard/paste-text-015-expected.txt:
        * editing/pasteboard/paste-text-016-expected.txt:
        * editing/pasteboard/paste-text-017-expected.txt:
        * editing/pasteboard/paste-text-018-expected.txt:
        * editing/pasteboard/paste-text-019-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-001-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-002-expected.txt:
        * editing/pasteboard/paste-text-at-tabspan-003-expected.txt:
        * editing/pasteboard/paste-xml-expected.txt:
        * editing/pasteboard/pasting-object-expected.txt:
        * editing/pasteboard/pasting-tabs-expected.txt:
        * editing/pasteboard/prevent-block-nesting-01-expected.txt:
        * editing/pasteboard/quirks-mode-br-1-expected.txt:
        * editing/pasteboard/quirks-mode-br-2-expected.txt:
        * editing/pasteboard/smart-paste-001-expected.txt:
        * editing/pasteboard/smart-paste-002-expected.txt:
        * editing/pasteboard/smart-paste-003-expected.txt:
        * editing/pasteboard/smart-paste-004-expected.txt:
        * editing/pasteboard/smart-paste-005-expected.txt:
        * editing/pasteboard/smart-paste-006-expected.txt:
        * editing/pasteboard/smart-paste-007-expected.txt:
        * editing/pasteboard/smart-paste-008-expected.txt:
        * editing/pasteboard/styled-element-markup-expected.txt:
        * editing/pasteboard/subframe-dragndrop-1-expected.txt:
        * editing/pasteboard/testcase-9507-expected.txt:
        * editing/pasteboard/undoable-fragment-removes-expected.txt:
        * editing/pasteboard/unrendered-br-expected.txt:
        * editing/selection/3690703-2-expected.txt:
        * editing/selection/3690703-expected.txt:
        * editing/selection/3690719-expected.txt:
        * editing/selection/4397952-expected.txt:
        * editing/selection/4932260-1-expected.txt:
        * editing/selection/4932260-2-expected.txt:
        * editing/selection/4932260-3-expected.txt:
        * editing/selection/4947387-expected.txt:
        * editing/selection/6476-expected.txt:
        * editing/selection/7152-1-expected.txt:
        * editing/selection/7152-2-expected.txt:
        * editing/selection/after-line-wrap-expected.txt:
        * editing/selection/caret-rtl-2-expected.txt:
        * editing/selection/caret-rtl-expected.txt:
        * editing/selection/click-before-and-after-table-expected.txt:
        * editing/selection/click-start-of-line-expected.txt:
        * editing/selection/designmode-no-caret-expected.txt:
        * editing/selection/editable-links-expected.txt:
        * editing/selection/editable-non-editable-crash-expected.txt:
        * editing/selection/end-of-document-expected.txt:
        * editing/selection/expanding-selections-expected.txt:
        * editing/selection/expanding-selections2-expected.txt:
        * editing/selection/extend-by-character-001-expected.txt:
        * editing/selection/extend-by-character-002-expected.txt:
        * editing/selection/extend-by-character-003-expected.txt:
        * editing/selection/extend-by-character-004-expected.txt:
        * editing/selection/extend-by-character-005-expected.txt:
        * editing/selection/extend-by-character-006-expected.txt:
        * editing/selection/extend-by-sentence-001-expected.txt:
        * editing/selection/extend-by-word-001-expected.txt:
        * editing/selection/extend-by-word-002-expected.txt:
        * editing/selection/fake-doubleclick-expected.txt:
        * editing/selection/fake-drag-expected.txt:
        * editing/selection/iframe-expected.txt:
        * editing/selection/image-before-linebreak-expected.txt:
        * editing/selection/inline-table-expected.txt:
        * editing/selection/leave-requested-block-expected.txt:
        * editing/selection/mixed-editability-1-expected.txt:
        * editing/selection/mixed-editability-3-expected.txt:
        * editing/selection/mixed-editability-4-expected.txt:
        * editing/selection/mixed-editability-5-expected.txt:
        * editing/selection/move-3875618-fix-expected.txt:
        * editing/selection/move-3875641-fix-expected.txt:
        * editing/selection/move-backwords-by-word-001-expected.txt:
        * editing/selection/move-between-blocks-no-001-expected.txt:
        * editing/selection/move-between-blocks-yes-001-expected.txt:
        * editing/selection/move-by-character-001-expected.txt:
        * editing/selection/move-by-character-002-expected.txt:
        * editing/selection/move-by-character-003-expected.txt:
        * editing/selection/move-by-character-004-expected.txt:
        * editing/selection/move-by-character-005-expected.txt:
        * editing/selection/move-by-character-6-expected.txt:
        * editing/selection/move-by-line-001-expected.txt:
        * editing/selection/move-by-line-002-expected.txt:
        * editing/selection/move-by-word-001-expected.txt:
        * editing/selection/previous-line-position-expected.txt:
        * editing/selection/replace-selection-1-expected.txt:
        * editing/selection/replaced-boundaries-1-expected.txt:
        * editing/selection/replaced-boundaries-2-expected.txt:
        * editing/selection/replaced-boundaries-3-expected.txt:
        * editing/selection/select-all-001-expected.txt:
        * editing/selection/select-all-002-expected.txt:
        * editing/selection/select-all-003-expected.txt:
        * editing/selection/select-all-004-expected.txt:
        * editing/selection/select-all-005-expected.txt:
        * editing/selection/select-all-006-expected.txt:
        * editing/selection/select-all-iframe-expected.txt:
        * editing/selection/select-box-expected.txt:
        * editing/selection/select-element-paragraph-boundary-expected.txt:
        * editing/selection/select-missing-image-expected.txt:
        * editing/selection/selection-3748164-fix-expected.txt:
        * editing/selection/skip-non-editable-1-expected.txt:
        * editing/selection/skip-non-editable-2-expected.txt:
        * editing/selection/table-caret-1-expected.txt:
        * editing/selection/table-caret-2-expected.txt:
        * editing/selection/table-caret-3-expected.txt:
        * editing/selection/triple-click-in-pre-expected.txt:
        * editing/selection/unrendered-001-expected.txt:
        * editing/selection/unrendered-002-expected.txt:
        * editing/selection/unrendered-003-expected.txt:
        * editing/selection/unrendered-004-expected.txt:
        * editing/selection/unrendered-005-expected.txt:
        * editing/selection/unrendered-space-expected.txt:
        * editing/spelling/spelling-expected.txt:
        * editing/style/apple-style-editable-mix-expected.txt:
        * editing/style/block-style-001-expected.txt:
        * editing/style/block-style-002-expected.txt:
        * editing/style/block-style-003-expected.txt:
        * editing/style/block-style-004-expected.txt:
        * editing/style/block-style-005-expected.txt:
        * editing/style/block-style-006-expected.txt:
        * editing/style/block-styles-007-expected.txt:
        * editing/style/create-block-for-style-001-expected.txt:
        * editing/style/create-block-for-style-002-expected.txt:
        * editing/style/create-block-for-style-003-expected.txt:
        * editing/style/create-block-for-style-004-expected.txt:
        * editing/style/create-block-for-style-005-expected.txt:
        * editing/style/create-block-for-style-006-expected.txt:
        * editing/style/create-block-for-style-007-expected.txt:
        * editing/style/create-block-for-style-008-expected.txt:
        * editing/style/create-block-for-style-009-expected.txt:
        * editing/style/create-block-for-style-010-expected.txt:
        * editing/style/create-block-for-style-011-expected.txt:
        * editing/style/create-block-for-style-012-expected.txt:
        * editing/style/create-block-for-style-013-expected.txt:
        * editing/style/designmode-expected.txt:
        * editing/style/non-inheritable-styles-expected.txt:
        * editing/style/relative-font-size-change-001-expected.txt:
        * editing/style/relative-font-size-change-002-expected.txt:
        * editing/style/relative-font-size-change-003-expected.txt:
        * editing/style/relative-font-size-change-004-expected.txt:
        * editing/style/remove-underline-across-paragraph-expected.txt:
        * editing/style/remove-underline-across-paragraph-in-bold-expected.txt:
        * editing/style/remove-underline-after-paragraph-expected.txt:
        * editing/style/remove-underline-after-paragraph-in-bold-expected.txt:
        * editing/style/remove-underline-expected.txt:
        * editing/style/remove-underline-from-stylesheet-expected.txt:
        * editing/style/remove-underline-in-bold-expected.txt:
        * editing/style/smoosh-styles-001-expected.txt:
        * editing/style/smoosh-styles-002-expected.txt:
        * editing/style/smoosh-styles-003-expected.txt:
        * editing/style/style-3681552-fix-001-expected.txt:
        * editing/style/style-3681552-fix-002-expected.txt:
        * editing/style/style-3690704-fix-expected.txt:
        * editing/style/style-3998892-fix-expected.txt:
        * editing/style/style-boundary-001-expected.txt:
        * editing/style/style-boundary-002-expected.txt:
        * editing/style/style-boundary-003-expected.txt:
        * editing/style/style-boundary-004-expected.txt:
        * editing/style/style-boundary-005-expected.txt:
        * editing/style/table-selection-expected.txt:
        * editing/style/typing-style-001-expected.txt:
        * editing/style/typing-style-002-expected.txt:
        * editing/style/typing-style-003-expected.txt:
        * editing/style/unbold-in-bold-expected.txt:
        * editing/style/underline-expected.txt:
        * editing/undo/4063751-expected.txt:
        * editing/undo/redo-typing-001-expected.txt:
        * editing/undo/undo-iframe-location-change-expected.txt:
        * editing/undo/undo-misspellings-expected.txt:
        * editing/undo/undo-typing-001-expected.txt:
        * editing/unsupported-content/list-delete-001-expected.txt:
        * editing/unsupported-content/list-delete-002-expected.txt:
        * editing/unsupported-content/list-delete-003-expected.txt:
        * editing/unsupported-content/list-type-after-expected.txt:
        * editing/unsupported-content/list-type-before-expected.txt:
        * editing/unsupported-content/table-delete-001-expected.txt:
        * editing/unsupported-content/table-delete-002-expected.txt:
        * editing/unsupported-content/table-delete-003-expected.txt:
        * editing/unsupported-content/table-type-after-expected.txt:
        * editing/unsupported-content/table-type-before-expected.txt:
        * fast/forms/focus-selection-input-expected.txt:

WebCore:

        Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13291
          REGRESSION (r19595): WebViewDidBeginEditingNotification not posted when focusing with the mouse

        Covered by editing tests.

        * dom/Document.cpp:
        (WebCore::Document::setFocusedNode): Moved the call to Editor::didBeginEditing()
        back into here.
        * dom/Element.cpp:
        (WebCore::Element::updateFocusAppearance): Removed the call to didBeginEditing().
        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::updateFocusAppearance): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20950 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-19 Mark Rowe <mrowe@apple.com>
bdash [Thu, 19 Apr 2007 14:02:25 +0000 (14:02 +0000)]
2007-04-19  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin.

        Fix http://bugs.webkit.org/show_bug.cgi?id=13401
        Bug 13401: Reproducible crash calling myArray.sort(compareFn) from within
        a sort comparison function

        * kjs/array_object.cpp:
        (ArrayInstance::sort): Save/restore the static variables around calls to qsort
        to ensure nested calls to ArrayInstance::sort behave correctly.

2007-04-19  Mark Rowe  <mrowe@apple.com>

        Reviewed by Darin.

        Test for http://bugs.webkit.org/show_bug.cgi?id=13401
        Bug 13401: Reproducible crash calling myArray.sort(compareFn) from within
        a sort comparison function

        * fast/js/array-sort-reentrance-expected.txt: Added.
        * fast/js/array-sort-reentrance.html: Added.
        * fast/js/resources/array-sort-reentrance.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20949 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
weinig [Thu, 19 Apr 2007 13:09:49 +0000 (13:09 +0000)]
LayoutTests:

        Reviewed by Darin.

        - Test for http://bugs.webkit.org/show_bug.cgi?id=12249
          FCKeditor: <hr>, <ul> and <ol> have id="undefined"

        * editing/execCommand/arguments-combinations-expected.txt: Added.
        * editing/execCommand/arguments-combinations.html: Added.

WebCore:

        Reviewed by Darin.

        - Patch for http://bugs.webkit.org/show_bug.cgi?id=12249
          FCKeditor: <hr>, <ul> and <ol> have id="undefined"

        Convert undefined and null to a null string for third argument of
        execCommand();

        Test: editing/execCommand/arguments-combinations.html

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/kjs_binding.cpp:
        (KJS::valueToStringWithUndefinedOrNullCheck):
        * bindings/js/kjs_binding.h:
        * bindings/scripts/CodeGeneratorJS.pm:
        * dom/Document.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20948 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by hyatt.
andrew [Thu, 19 Apr 2007 08:51:49 +0000 (08:51 +0000)]
    Reviewed by hyatt.

        * WebCoreSources.bkl: Remove obsolete source file from build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20944 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd in a missing word.
bdash [Thu, 19 Apr 2007 04:07:55 +0000 (04:07 +0000)]
Add in a missing word.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20943 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-19 Mark Rowe <mrowe@apple.com>
bdash [Thu, 19 Apr 2007 03:02:41 +0000 (03:02 +0000)]
2007-04-19  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver and Adam.

        <rdar://problem/5141290> WebAssertions.h is still needed some internal clients.

        * Misc/WebAssertions.h: Added.
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20941 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-18 Alp Toker <alp@atoker.com>
bdash [Thu, 19 Apr 2007 00:48:10 +0000 (00:48 +0000)]
2007-04-18  Alp Toker  <alp@atoker.com>

        Gdk build fix.  Reviewed by Sam Weinig.

        Track changes to make GdkLauncher work again.

        * WebCoreSources.bkl:
        * platform/gdk/ChromeClientGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        (ChromeClientGdk::createWindow):
        (ChromeClientGdk::createModalDialog):
        (Editor::markBadGrammar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20939 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRemoved unintentional garbage left after an #endif in my previous patch
beidson [Thu, 19 Apr 2007 00:42:50 +0000 (00:42 +0000)]
Removed unintentional garbage left after an #endif in my previous patch

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20938 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
beidson [Thu, 19 Apr 2007 00:39:18 +0000 (00:39 +0000)]
LayoutTests:

        Reviewed by Tim

        <rdar://problem/5008925>
        Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

        * http/tests/misc/willCacheResponse-delegate-callback-expected.txt: Added.
        * http/tests/misc/willCacheResponse-delegate-callback.html: Added.

WebCore:

        Reviewed by Tim

        <rdar://problem/5008925>
        Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

        * WebCore.xcodeproj/project.pbxproj: Added ResourceLoaderMac.mm

        * loader/FrameLoaderClient.h: Add the willCacheResponse SPI for WebKit to implement

        * loader/ResourceLoader.h:
        * loader/mac/ResourceLoaderMac.mm: Added.
        (WebCore::ResourceLoader::willCacheResponse): Return the new cachedResponse from the client

        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyFrameLoaderClient::willCacheResponse): Stub

        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::willCacheResponse):  Return the new cachedResponse from the client

        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:willCacheResponse:]): Call to get the new
          cachedURLResponse before calling for the cache policy

WebKit:

        Reviewed by Tim

        <rdar://problem/5008925>
        Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::willCacheResponse): Call
          [WebResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:];

        * WebView/WebView.mm:
        (-[WebView _cacheResourceLoadDelegateImplementations]): Pull out the willCacheResponse impl

        * WebView/WebViewPrivate.h: Add WebResourceLoadDelegatePrivate category for this new SPI

WebKitTools:

        Reviewed by Tim

        <rdar://problem/5008925>
        Expose the NSURLConnection delegate willCacheResponse API to WebResourceLoadDelegate

        * DumpRenderTree/ResourceLoadDelegate.m:
        (-[ResourceLoadDelegate webView:resource:willCacheResponse:fromDataSource:]):
          Add the willCacheResponse delegate call

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20937 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Hyatt.
darin [Thu, 19 Apr 2007 00:33:29 +0000 (00:33 +0000)]
    Reviewed by Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13375
          REGRESSION (r20901): failing fast/overflow/scrollRevealButton.html

        * dom/Document.cpp: (WebCore::Document::updateLayout):
        If we have a parent frame, update its layout too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20936 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by David Kilzer.
aroben [Wed, 18 Apr 2007 23:59:43 +0000 (23:59 +0000)]
    Reviewed by David Kilzer.

        * Scripts/webkitdirs.pm:
        (sub setConfiguration): Added an optional argument to set the
        configuration instead of parsing it from ARGV.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20935 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Adam
sullivan [Wed, 18 Apr 2007 21:11:46 +0000 (21:11 +0000)]
    Reviewed by Adam

        - fixed <rdar://problem/5103009> REGRESSION: Activity window shows blank name for untitled pages

        * WebView/WebHTMLRepresentation.mm:
        (-[WebHTMLRepresentation title]):
        return nil for empty string, to match old behavior

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20934 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by AP.
kmccullo [Wed, 18 Apr 2007 20:05:06 +0000 (20:05 +0000)]
    Reviewed by AP.

        - Consolidated encoding tests.

        * fast/encoding/char-decoding-expected.txt:
        * fast/encoding/char-decoding.html:
        * fast/encoding/charset-x-nextstep-expected.txt: Removed.
        * fast/encoding/charset-x-nextstep.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20933 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-18 Alp Toker <alp@atoker.com>
bdash [Wed, 18 Apr 2007 14:55:35 +0000 (14:55 +0000)]
2007-04-18  Alp Toker  <alp@atoker.com>

        Gdk build fix.  Reviewed by Mark.

        * loader/gdk/FrameLoaderClientGdk.cpp:
        (WebCore::FrameLoaderClientGdk::loadedFromCachedPage):
        (WebCore::FrameLoaderClientGdk::setDocumentViewFromCachedPage):
        (WebCore::FrameLoaderClientGdk::saveDocumentViewToCachedPage):
        * loader/gdk/FrameLoaderClientGdk.h:
        * platform/gdk/TemporaryLinkStubs.cpp:
        (CachedPage::close): Track PageCache to CachedPage refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20932 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-17 Mitz Pettel <mitz@webkit.org>
bdash [Wed, 18 Apr 2007 04:58:54 +0000 (04:58 +0000)]
2007-04-17  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13369
          REGRESSION (r13366): Invisible table cell background is painted

        Test: fast/table/invisible-cell-background.html

        * rendering/RenderTableCell.cpp:
        (WebCore::RenderTableCell::paintBackgroundsBehindCell): Don't paint any
        background if the cell is not visible. This behavior matches WinIE and Opera.

2007-04-17  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Darin.

        - pixel test for http://bugs.webkit.org/show_bug.cgi?id=13369
          REGRESSION (r13366): Invisible table cell background is painted

        * fast/table/invisible-cell-background-expected.checksum: Added.
        * fast/table/invisible-cell-background-expected.png: Added.
        * fast/table/invisible-cell-background-expected.txt: Added.
        * fast/table/invisible-cell-background.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20931 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoRolling out my previous checkin, as the compiler bug still exists on Leopard.
justing [Wed, 18 Apr 2007 03:50:25 +0000 (03:50 +0000)]
Rolling out my previous checkin, as the compiler bug still exists on Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20930 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * Scripts/find-included-framework-headers: Search Obj-C and Obj-C++
aroben [Wed, 18 Apr 2007 03:22:32 +0000 (03:22 +0000)]
    * Scripts/find-included-framework-headers: Search Obj-C and Obj-C++
        files as well.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20929 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Added a simple shell script to find all the headers from a specified
aroben [Wed, 18 Apr 2007 03:18:43 +0000 (03:18 +0000)]
    Added a simple shell script to find all the headers from a specified
        framework or frameworks that are included by files beneath the working
        directory.

        * Scripts/find-included-framework-headers: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20928 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
justing [Wed, 18 Apr 2007 02:23:47 +0000 (02:23 +0000)]
WebCore:

        Reviewed by adam

        Removed workarounds for compiler bug 4213314.

        * platform/mac/CursorMac.mm:
        (WebCore::leakNamedCursor):
        * platform/mac/ScrollViewMac.mm:
        (WebCore::ScrollView::resizeContents):
        (WebCore::ScrollView::contentsToWindow):
        (WebCore::ScrollView::windowToContents):

WebKit:

        Reviewed by adam

        Removed workarounds for compiler bug 4213314.

        * Misc/WebNSAttributedStringExtras.mm:
        (+[NSAttributedString _web_attributedStringFromRange:]):
        * WebKit.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20927 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Wed, 18 Apr 2007 01:20:44 +0000 (01:20 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/5119244>
        Crash when indenting a selected ToDo

        * editing/execCommand/5119244-expected.checksum: Added.
        * editing/execCommand/5119244-expected.png: Added.
        * editing/execCommand/5119244-expected.txt: Added.
        * editing/execCommand/5119244.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/5119244>
        Crash when indenting a selected ToDo

        indentRegion() was using the old (incorrect) editable root
        getter, which returned null for a valid, editable position,
        causing the crash.

        * editing/IndentOutdentCommand.cpp:
        (WebCore::IndentOutdentCommand::indentRegion):
        The editable root for a position is editableRootForPosition(p),
        not p.node()->rootEditableElement(), because of VisiblePositions
        before/after tables, replaced elements and others.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20926 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Wed, 18 Apr 2007 00:13:15 +0000 (00:13 +0000)]
LayoutTests:

        Reviewed by hyatt

        <rdar://problem/5138441>
        GoogleDocs: Indented text looks like text that's been Quoted

        Demonstrates the bug:
        * editing/execCommand/5138441-expected.checksum: Added.
        * editing/execCommand/5138441-expected.png: Added.
        * editing/execCommand/5138441-expected.txt: Added.
        * editing/execCommand/5138441.html: Added.

        Added inline style declarations for indent blockquotes
        to match those that the engine creates:
        * editing/execCommand/indent-selection.html:
        * editing/execCommand/outdent-selection.html:

WebCore:

        Reviewed by hyatt

        <rdar://problem/5138441>
        GoogleDocs: Indented text looks like text that's been Quoted

        GoogleDocs uses FormatBlock, blockquotes and a style rule
        for blockquotes to implement a "Quote Text" feature.  Styles
        intended only for those blockquotes were added to the
        blockquotes that we use for indenting.

        * css/html4.css: Removed the webkit-indent-blockquote class rule.
        * editing/IndentOutdentCommand.cpp:
        (WebCore::createIndentBlockquoteElement): Use custom margins
        and turn off border and padding to override author rules for
        blockquotes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20925 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Tim Hatcher
sullivan [Tue, 17 Apr 2007 23:00:07 +0000 (23:00 +0000)]
    Reviewed by Tim Hatcher

        - fixed <rdar://problem/5138492> Safari doesn't remember some changes to the PDF scale and display mode

        Some of the user interactions that could change the PDF scale and display mode were not going through
        the proxy mechanism in WebPDFView that updates preferences. Now we also listen to PDFKit notifications
        in order to catch the other cases.

        * WebView/WebPDFView.h:
        new _ignoreScaleAndDisplayModeNotifications and _updatePreferencesTimer ivars

        * WebView/WebPDFView.mm:
        (-[WebPDFView setPDFDocument:]):
        ignore scale and display mode notifications while we're setting up a fresh document
        (-[WebPDFView dealloc]):
        cancel the new timer (which releases it)
        (-[WebPDFView viewDidMoveToWindow]):
        listen for two PDFKit notifications
        (-[WebPDFView viewWillMoveToWindow:]):
        stop listening to the two PDFKit notifications
        (-[WebPDFView _applyPDFDefaults]):
        white space change
        (-[WebPDFView _cancelUpdatePreferencesTimer]):
        invalidate, release, and nil out the timer
        (-[WebPDFView _scaleOrDisplayModeChanged:]):
        update preferences soon, unless deliberately ignoring these notifications
        (-[WebPDFView _updatePreferencesNow]):
        cancel timer, then save data to preferences (code for saving the data was extracted from
        -[PDFPrefUpdatingProxy forwardInvocation:])
        (-[WebPDFView _updatePreferencesSoon]):
        use timer to consolidate multiple calls into one action; formerly we were setting preferences
        multiple times for some atomic user actions
        (-[PDFPrefUpdatingProxy forwardInvocation:]):
        call _updatePreferencesSoon where we used to immediately set preferences

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20924 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Tue, 17 Apr 2007 20:27:58 +0000 (20:27 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5136770>
        Gmail Editor: Hang when turning a particular multi-line selection into a list

        Demonstrates the bug:
        * editing/execCommand/5136770-expected.checksum: Added.
        * editing/execCommand/5136770-expected.png: Added.
        * editing/execCommand/5136770-expected.txt: Added.
        * editing/execCommand/5136770.html: Added.

        Added placeholders in empty list items:
        * editing/execCommand/4747450-expected.txt:
        * editing/execCommand/insert-list-empty-div-expected.txt:
        * editing/execCommand/4917055-expected.txt:

        A horizontal rule pushed into a list item appears *before*
        the list marker in the render tree, although, the new results
        look more correct (13376):
        * editing/execCommand/create-list-with-hr-expected.checksum:
        * editing/execCommand/create-list-with-hr-expected.png:
        * editing/execCommand/create-list-with-hr-expected.txt:
        * editing/execCommand/create-list-with-hr.html:

WebCore:

        Reviewed by darin

        <rdar://problem/5136770>
        Gmail Editor: Hang when turning a particular multi-line selection into a list

        When InsertListCommand pushes content into list items,
        it creates an empty list item and then calls moveParagraphs.
        But moveParagraphs' selection preservation code fails when
        it encounters empty list items (list items w/o placeholders).
        This causes InsertListCommand to lose track of where it has
        already been performed, which causes the hang.

        * editing/InsertListCommand.cpp:
        (WebCore::InsertListCommand::doApply): Use brs to hold open
        empty list items.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20923 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Oops, rolled that last change out. I'll redo it again later after making
darin [Tue, 17 Apr 2007 19:58:16 +0000 (19:58 +0000)]
    Oops, rolled that last change out. I'll redo it again later after making
        som additional refinments.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20921 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Kevin Decker
sullivan [Tue, 17 Apr 2007 19:00:43 +0000 (19:00 +0000)]
    Reviewed by Kevin Decker

        - fixed <rdar://problem/4184640> "Look Up in Dictionary" item is always disabled for PDF pages

        * WebView/WebPDFView.mm:
        (-[WebPDFView validateUserInterfaceItem:]):
        enable "Look Up in Dictionary" only if we're using a version of PDFKit that knows how to do so
        (-[WebPDFView _canLookUpInDictionary]):
        use respondsToSelector to test whether the current version of PDFKit supports this non-API feature
        (-[WebPDFView _lookUpInDictionaryFromMenu:]):
        implement this method, which WebKit includes in the context menu when there's selected text
        (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
        updated comment for this change

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20920 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Brady.
darin [Tue, 17 Apr 2007 18:44:21 +0000 (18:44 +0000)]
    Reviewed by Brady.

        - a few baby steps to try to make lockHistory and userGesture less confusing

        * page/FrameLoadRequest.h:
        (WebCore::FrameLoadRequest::FrameLoadRequest): Add initialization of m_isUserGesture
        to true.
        (WebCore::FrameLoadRequest::shouldLockHistory): Renamed from lockHistory to avoid having
        a getter that sounds like a verb phrase.
        (WebCore::FrameLoadRequest::setShouldLockHistory): Ditto.
        (WebCore::FrameLoadRequest::isUserGesture): Added.
        (WebCore::FrameLoadRequest::setIsUserGesture): Ditto.

        * loader/FrameLoader.h: Remove userGesture parameter from load that takes
        FrameLoadRequest. Remove default values for lockHistory and userGesture parameters,
        since that just makes it more likely we'll forget to pass them in. Remove one of
        the overloads of urlSelected, since it's only called one place.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow): Remove userGesture parameter, relying on
        the true default in FrameLoadRequest.
        (WebCore::FrameLoader::urlSelected): Call setShouldLockHistory and setIsUserGesture
        on the FrameLoadRequest, and call load directly; also eliminate the other urlSelected
        overload since this was the only place it was called.
        (WebCore::FrameLoader::load): Remove userGesture parameter, relying on the true
        default in FrameLoadRequest. In the other overload, clean up logic to eliminate the
        argsReferrer variable and get rid of the userGesture parameter, using the value from
        FrameLoadRequest.
        (WebCore::FrameLoader::submitForm): Remove userGesture parameter, relying on the value
        in the FrameLoadRequest. This actually changes behavior.

        * bindings/js/kjs_html.cpp: (KJS::JSHTMLDocument::putValueProperty): Pass
        false for userGesture explicitly instead of relying on default argument.

        * page/ContextMenuController.cpp: (WebCore::ContextMenuController::contextMenuItemSelected):
        Remove userGesture parameter, relying on the true default in FrameLoadRequest.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20919 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoMore elegant fix for the 64-bit build failure.
thatcher [Tue, 17 Apr 2007 17:49:16 +0000 (17:49 +0000)]
More elegant fix for the 64-bit build failure.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20918 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ddkilzer [Tue, 17 Apr 2007 01:15:36 +0000 (01:15 +0000)]
WebCore:

        Reviewed by NOBODY (fixed misspelling).

        * manual-tests/containing-block-position-chage.html: Removed.
        * manual-tests/containing-block-position-change.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20914 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago64-bit build fix.
thatcher [Tue, 17 Apr 2007 00:25:29 +0000 (00:25 +0000)]
64-bit build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20913 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Mon, 16 Apr 2007 21:06:46 +0000 (21:06 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5134759>
        GMail Editor: Hang after pasting underlined text multiple times

        Demonstrates the bug:
        * editing/pasteboard/5134759-expected.checksum: Added.
        * editing/pasteboard/5134759-expected.png: Added.
        * editing/pasteboard/5134759-expected.txt: Added.
        * editing/pasteboard/5134759.html: Added.

        A unnecessary extra space was added to an element's
        inline style declaration, because of the way cssText behaves:
        * editing/pasteboard/paste-table-002-expected.txt:

WebCore:

        Reviewed by darin

        <rdar://problem/5134759>
        GMail Editor: Hang after pasting underlined text multiple times

        The moveParagraphs call that ReplaceSelectionCommand
        performs must receive only inline content from createMarkup,
        or else it will result in another call to moveParagraphs
        when it performs the move, resulting in infinite recursion.

        * editing/markup.cpp:
        (WebCore::startMarkup): We were only converting a block to
        an inline if it had an inline style declaration or styles
        coming from matched rules.  Cleaned up this code a bit by
        handling an element's style separately from its other
        attributes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20912 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * Drosera/debugger.css: hide the borders for iframes
thatcher [Mon, 16 Apr 2007 18:31:08 +0000 (18:31 +0000)]
    * Drosera/debugger.css: hide the borders for iframes

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20907 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubber stamped by Tim Hatcher.
darin [Mon, 16 Apr 2007 18:29:10 +0000 (18:29 +0000)]
    Rubber stamped by Tim Hatcher.

        * WebKit.xcodeproj/project.pbxproj: Added Radar bug number to the error message
        for the "version number ending in 4" check so folks from Apple can find the
        original bug that motivated for this. To summarize what's in that bug, it says that
        <http://my.fedex.com> was failing, that it was because of the OpenCube DHTML Menu,
        and that some other affected sites were not using OpenCube (so the error is presumably
        more widespread).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20906 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago - get layout tests going again
darin [Mon, 16 Apr 2007 16:52:09 +0000 (16:52 +0000)]
    - get layout tests going again

        * page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry):
        Replace assertion with a runtime check. We can consider changing it back to
        an assertion some day, but it's not important.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20902 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
darin [Mon, 16 Apr 2007 15:41:04 +0000 (15:41 +0000)]
WebCore:

        Reviewed by John Sullivan.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13303
          <rdar://problem/5126341> REGRESSION: controls in a background Safari window
          maintain active appearance if the address bar has focus (13303)

        - fix a related problem where elements could look focused in non-active windows

        - simplify secure keyboard entry logic in Frame::setIsActive

        * WebCore.exp: Add two new symbols for use by WebKit.

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::dispatchFocusEvent): Call setUseSecureKeyboardEntryWhenActive
        rather than calling setSecureKeyboardEntry directly -- does nothing if the frame is not active.
        (WebCore::HTMLInputElement::dispatchBlurEvent): Ditto.

        * page/Frame.cpp:
        (WebCore::Frame::setUseSecureKeyboardEntryWhenActive): Added. Calls
        setUseSecureKeyboardEntry only if the frame is active, but also stores away the state,
        so that the setIsActive function doesn't have to recompute it.
        (WebCore::Frame::setIsActive): Rewrote all the comments in the function. Removed the code
        to manage control tints, which are not based on the whether the frame is active but rather
        on AppKit's concept of whether the window should have "key appearance". Simplified the
        logic about when to call setUseSecureKeyboardEntry by using the value of
        m_useSecureKeyboardEntryWhenActive.
        (WebCore::FramePrivate::FramePrivate): Initialize m_useSecureKeyboardEntryWhenActive.
        * page/Frame.h: Made setSecureKeyboardEntry private and renamed it to
        setUseSecureKeyboardEntry, removed isSecureKeyboardEntry, and
        added a public setUseSecureKeyboardEntryWhenActive.
        * page/FramePrivate.h: Added m_useSecureKeyboardEntryWhenActive.
        * page/mac/FrameMac.mm: (WebCore::Frame::setUseSecureKeyboardEntry): Added an assertion,
        and removed isSecureKeyboardEntry().

        * page/FrameView.h: Added updateControlTints.
        * page/FrameView.cpp: (WebCore::FrameView::updateControlTints): Added. Code was moved
        here from setIsActive for two reasons: (1) it makes more sense in the view class, and
        (2) it needs to be called at the appropriate time for AppKit, not when active changes.

        * rendering/RenderTheme.cpp: (WebCore::RenderTheme::isFocused): Added an isActive
        check here to match the logic in the implementation of the CSS pseudo-state.
        * rendering/RenderThemeMac.mm:
        (WebCore::RenderThemeMac::updateFocusedState): Use the isFocused function instead of
        repeating the logic here. Removed the "need to add a key window test here" comment.
        (WebCore::RenderThemeMac::controlSupportsTints): Added a comment about the NSCell
        SPI that's related to the _windowChangedKeyState method we now use in WebHTMLView.

WebKit:

        Reviewed by John Sullivan.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13303
          <rdar://problem/5126341> REGRESSION: controls in a background Safari window
          maintain active appearance if the address bar has focus (13303)

        * WebView/WebHTMLView.mm: (-[WebHTMLView _windowChangedKeyState]):
        Added. Calls FrameView::updateControlTints.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20901 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by John Sullivan.
darin [Mon, 16 Apr 2007 15:15:01 +0000 (15:15 +0000)]
    Reviewed by John Sullivan.

        - fix http://bugs.webkit.org/show_bug.cgi?id=13227
          StringImpl::isLower incorrectly assumes islower returns 1 (it can return any non-0)

        * platform/StringImpl.cpp:
        (WebCore::StringImpl::isLower): Based on test application results, changed to use &&
        instead of trying to use & to avoid branches. Use U16_NEXT so we can handle characters
        outside the BMP. Improved comments.
        (WebCore::StringImpl::lower): Improved comments.
        (WebCore::equalIgnoringCase): Changed to use && instead of trying to use & to avoid
        branches. Improved comments. Added an assertion about the assumption we're
        making that characters in the char* are all ASCII.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20900 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdding wx sources and changes to wxWebKit branch.
kevino [Sat, 14 Apr 2007 22:33:17 +0000 (22:33 +0000)]
Adding wx sources and changes to wxWebKit branch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20893 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
ddkilzer [Sat, 14 Apr 2007 01:26:07 +0000 (01:26 +0000)]
LayoutTests:

        Patch and review by hyatt.  Testing and landing by ddkilzer.

        <rdar://problem/5078866>
        tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

        Test tables/mozilla_expected_failures/bugs/bug11384s.html progressed after this fix, so
        it was moved to tables/mozilla/bugs/bug11384s.html.

        * fast/css/table-text-align-quirk-expected.checksum: Added.
        * fast/css/table-text-align-quirk-expected.png: Added.
        * fast/css/table-text-align-quirk-expected.txt: Added.
        * fast/css/table-text-align-quirk.html: Added.
        * fast/css/table-text-align-strict-expected.checksum: Added.
        * fast/css/table-text-align-strict-expected.png: Added.
        * fast/css/table-text-align-strict-expected.txt: Added.
        * fast/css/table-text-align-strict.html: Added.
        * fast/table/border-collapsing/rtl-border-collapsing.html: Replaced "text-align: -khtml-center"
        style with "text-align: center" style.
        * tables/mozilla/bugs/bug11384s-expected.checksum: Added.
        * tables/mozilla/bugs/bug11384s-expected.png: Added.
        * tables/mozilla/bugs/bug11384s-expected.txt: Added.
        * tables/mozilla/bugs/bug11384s.html: Added.
        * tables/mozilla_expected_failures/bugs/bug11384s-expected.checksum: Removed.
        * tables/mozilla_expected_failures/bugs/bug11384s-expected.png: Removed.
        * tables/mozilla_expected_failures/bugs/bug11384s-expected.txt: Removed.
        * tables/mozilla_expected_failures/bugs/bug11384s.html: Removed.

WebCore:

        Patch and review by hyatt.  Testing and landing by ddkilzer.

        <rdar://problem/5078866>
        tables don't inherit text-align (in strict mode; they're not supposed to in quirks mode)

        Test: fast/css/table-text-align-quirk.html
              fast/css/table-text-align-strict.html

        Previous commit (r20731) removed the wrong property from WebCore/css/html4.css.  However,
        when the correct property was removed, it caused tables to inherit alignment properties
        from tags like <center> and <div align="center">.  This is fixed in
        WebCore::CSSStyleSelector::adjustRenderStyle() by special-casing tables to reset the
        text-align property.

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::valueForTextAlign): Renamed KHTML_CENTER, KHTML_LEFT and KHTML_RIGHT to
        WEBKIT_CENTER, WEBKIT_LEFT and WEBKIT_RIGHT.
        * css/cssparser.cpp:
        (WebCore::CSSParser::parseValue): Ditto.
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::adjustRenderStyle): Tables should not support -webkit-center,
        -webkit-left or -webkit-right values for text-align, so reset them back to auto.
        * css/html4.css: Removed "text-align: -webkit-auto;" property from tables selector.  It
        was previously added to css/quirks.css in r20731.
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::determineHorizontalPosition): Renamed KHTML_* to WEBKIT_*.
        * rendering/RenderBox.cpp:
        (WebCore::RenderBox::calcHorizontalMargins): Ditto.
        * rendering/RenderFlow.cpp:
        (WebCore::RenderFlow::caretRect): Ditto.
        * rendering/RenderStyle.h: Ditto.
        (WebCore::):
        * rendering/bidi.cpp:
        (WebCore::RenderBlock::computeHorizontalPositionsForLine): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20889 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-13 Oliver Hunt <oliver@apple.com>
oliver [Sat, 14 Apr 2007 00:57:13 +0000 (00:57 +0000)]
2007-04-13  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        Due to rdar://problem/5133910 -- WebArchives should not be constructed
        using resource from the cache -- We may try to create a potentially
        incorrect WebArchive when dragging an image multiple times.

        This patch retains the assertion for invalid behaviour, but adds a
        branch to make sure we don't try to do anything with the WebArchive
        in release builds.

        * Misc/WebNSPasteboardExtras.mm:
        (-[NSPasteboard _web_writeImage:element:URL:title:archive:types:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20888 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by a sanity check
beidson [Fri, 13 Apr 2007 21:47:56 +0000 (21:47 +0000)]
    Reviewed by a sanity check

        My layout test *has* to be http, since dumping history in DRT with hard coded file paths
        will never match up to expected results across machines.

        Lame

        * history/new-window-redirect-history-expected.txt: Removed.
        * history/new-window-redirect-history.html: Removed.
        * history/resources/redirect-1.html: Removed.
        * history/resources/redirect-2.html: Removed.
        * http/tests/navigation/new-window-redirect-history-expected.txt: Added.
        * http/tests/navigation/new-window-redirect-history.html: Added.
        * http/tests/navigation/resources/redirect-1.html: Added.
        * http/tests/navigation/resources/redirect-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20883 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Rubberstamped by Anders.
aroben [Fri, 13 Apr 2007 20:34:14 +0000 (20:34 +0000)]
    Rubberstamped by Anders.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: #include
        stdio.h so that snprintf is defined.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20879 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
beidson [Fri, 13 Apr 2007 20:28:27 +0000 (20:28 +0000)]
LayoutTests:

        Reviewed by Geoose

        <rdar://problem/4664154> and http://bugs.webkit.org/show_bug.cgi?id=3546

        Layout test that covers opening an empty new window, then starting to navigate around in it

        * history/new-window-redirect-history-expected.txt: Added.
        * history/new-window-redirect-history.html: Added.
        * history/resources/redirect-1.html: Added.
        * history/resources/redirect-2.html: Added.

WebCore:

        Reviewed by Black Sheep

        <rdar://problem/4664154> and http://bugs.webkit.org/show_bug.cgi?id=3546

        When you click on a link that opens in a new window from within gmail, they first create a new window
        with an empty URL, then immediately document.write() into the window to schedule a redirect.

        Since the initial page doesn't have a URL associated with it, a history item never gets created.  The
        reasonable solution?  To actually create the history item after the redirect (in updateHistoryForInternalLoad)

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::addHistoryForCurrentLocation): Updates global and B/F history with a new history item
        (WebCore::FrameLoader::updateHistoryForStandardLoad): Call addHistoryForCurrentLocation
        (WebCore::FrameLoader::updateHistoryForInternalLoad): Call addHistoryForCurrentLocation if there is not already
          a current history item
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20878 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders
beidson [Fri, 13 Apr 2007 20:09:15 +0000 (20:09 +0000)]
    Reviewed by Anders

        Add the ability to dump the back/forward history of all windows open at the end of a test

        * DumpRenderTree/DumpRenderTree.m:
        (dumpBackForwardListForWebView): Dump B/F list for the given WebView
        (dump): Call dumpBackForwardListForWebView for each WebView open after the test

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20877 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
andersca [Fri, 13 Apr 2007 19:54:13 +0000 (19:54 +0000)]
LayoutTests:

        Reviewed by Brady.

        * plugins/open-and-close-window-with-plugin.html:
        Manage open windows manually for this test.

WebKitTools:

        Reviewed by Brady.

        By default, close any windows that have been opened during a test. This can be overridden by
        calling setCloseRemainingWindowsWhenComplete(false).

        Change the windows set to an array so we can gurantee the enumeration order.

        * DumpRenderTree/DumpRenderTree.m:
        (+[LayoutTestController isSelectorExcludedFromWebScript:]):
        (+[LayoutTestController webScriptNameForSelector:]):
        (-[LayoutTestController setCloseRemainingWindowsWhenComplete:]):
        (runTest):
        (-[DumpRenderTreeWindow initWithContentRect:styleMask:backing:defer:]):
        (-[DumpRenderTreeWindow dealloc]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20876 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Dave Harrison.
thatcher [Fri, 13 Apr 2007 19:13:33 +0000 (19:13 +0000)]
    Reviewed by Dave Harrison.

        <rdar://problem/5132727> Soho Mail build fails because of renamed SPI

        * WebView/WebUIDelegatePrivate.h: define WebMenuItemTagSearchInGoogle as OldWebMenuItemTagSearchWeb

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20874 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix.
ggaren [Fri, 13 Apr 2007 19:12:51 +0000 (19:12 +0000)]
    Build fix.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c:
        (handleCallback): Explicitly cast the void* returned by malloc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20873 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-13 Mark Rowe <mrowe@apple.com>
bdash [Fri, 13 Apr 2007 07:56:16 +0000 (07:56 +0000)]
2007-04-13  Mark Rowe  <mrowe@apple.com>

        Reviewed by Oliver.

        <rdar://problem/5130686> Using WebPreferencesPrivate.h requires modifying framework search path

        * WebView/WebPreferencesPrivate.h: Remove unneeded #ifdef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20869 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-12 Oliver Hunt <oliver@apple.com>
oliver [Fri, 13 Apr 2007 06:38:38 +0000 (06:38 +0000)]
2007-04-12  Oliver Hunt  <oliver@apple.com>

        Reviewed by Adam.

        This fixes <rdar://problem/5060766> -- Frameset with
        an empty frame crashes due to null document.  Debug
        builds hit the frame->document() assertion in
        EventHandler::prepareMouseEvent

        This null check seems necessary now, having run through
        all the logic on the path to this crash it appears that
        we can't avoid this null check.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::updateDragAndDrop):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20868 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoJavaScriptCore:
ggaren [Fri, 13 Apr 2007 04:32:51 +0000 (04:32 +0000)]
JavaScriptCore:

        Reviewed by Darin Adler.

        http://bugs.webkit.org/show_bug.cgi?id=13029
        rdar://problem/4994849
        Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
        This doesn't actually change JavaScriptCore, but that's where npapi.h is.

        * bindings/npapi.h:
        Add headers member to NPStream struct.  Also increase NP_VERSION_MINOR to 18.
        Increasing to >= 17 allows plug-ins to safely detect whether to look for
        NPStream::headers.  Increasing from 17 to 18 reflects presence of NPObject
        enumeration, which was added in a prior patch, and which has been agreed to
        constitute version 18 by the plugin-futures list.  Also add other missing
        bits of npapi.h to catch up from 14 to 18.  This includes features that are
        not implemented in WebKit, but those are safely stubbed.

LayoutTests:

        Reviewed by Darin Adler.

        http://bugs.webkit.org/show_bug.cgi?id=13029
        rdar://problem/4994849
        Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

        * http/tests/plugins/npapi-response-headers-expected.txt: Added.
        * http/tests/plugins/npapi-response-headers.html: Added.
        * http/tests/plugins/resources/load-me-1.txt: Added.
        * http/tests/plugins/resources/load-me-2.txt: Added.

WebKit:

        Reviewed by Darin Adler.

        http://bugs.webkit.org/show_bug.cgi?id=13029
        rdar://problem/4994849
        Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.

        * Plugins/WebBaseNetscapePluginStream.h: declarations.
        * Plugins/WebBaseNetscapePluginStream.mm: main implementation.
        (-[WebBaseNetscapePluginStream dealloc]): cleanup.
        (-[WebBaseNetscapePluginStream finalize]): cleanup.
        (-[WebBaseNetscapePluginStream startStreamResponseURL:expectedContentLength:lastModifiedDate:MIMEType:headers:]):
        Pass headers along.
        (-[WebBaseNetscapePluginStream startStreamWithResponse:]):
        Main work is here.  Extract headers from NSHTTPURLResponse object into a byte sequence.
        See comments here about how it would be nice to have low-level access to the HTTP response.
        (-[WebBaseNetscapePluginStream _destroyStream]): cleanup.
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView evaluateJavaScriptPluginRequest:]):
        Conform to new startStream params.  Not applicable here, pass nil.

WebKitTools:

        Reviewed by Darin Adler.

        http://bugs.webkit.org/show_bug.cgi?id=13029
        rdar://problem/4994849
        Bug 13029: Permit NPAPI plug-ins to see HTTP response headers.
        Changes in WebKitTools are only for the NPAPI test plugin.

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.c: main test logic.
        (pluginInvoke): support null window argument for NPStream creation.
        (pluginAllocate): initialization.
        (pluginDeallocate): cleanup.
        (handleCallback): add second JS callback arg: header dump.
        (notifyStream): added; hook from NPP_NewStream to record headers.
        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.h: declarations.
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.c: call new header hook.
        (NPP_NewStream): call new header hook.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20867 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Fri, 13 Apr 2007 01:10:15 +0000 (01:10 +0000)]
LayoutTests:

        Reviewed by darin

        <rdar://problem/5131716>
        Clicking just before a ToDo doesn't put the caret before the ToDo

        * editing/selection/5131716-1-expected.checksum: Added.
        * editing/selection/5131716-1-expected.png: Added.
        * editing/selection/5131716-1-expected.txt: Added.
        * editing/selection/5131716-1.html: Added.
        * editing/selection/5131716-2-expected.checksum: Added.
        * editing/selection/5131716-2-expected.png: Added.
        * editing/selection/5131716-2-expected.txt: Added.
        * editing/selection/5131716-2.html: Added.
        * editing/selection/5131716-3-expected.checksum: Added.
        * editing/selection/5131716-3-expected.png: Added.
        * editing/selection/5131716-3-expected.txt: Added.
        * editing/selection/5131716-3.html: Added.
        * editing/selection/5131716-4-expected.checksum: Added.
        * editing/selection/5131716-4-expected.png: Added.
        * editing/selection/5131716-4-expected.txt: Added.
        * editing/selection/5131716-4.html: Added.

WebCore:

        Reviewed by darin

        <rdar://problem/5131716>
        Clicking just before a ToDo doesn't put the caret before the ToDo

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::positionForCoordinates):
        Consider clicks inside the blocks padding, instead of
        incorrectly sending them to the position before the block.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Build fix for case sensitive file systems
beidson [Thu, 12 Apr 2007 16:56:49 +0000 (16:56 +0000)]
    Build fix for case sensitive file systems

        * Misc/WebNSPasteboardExtras.mm:
        * WebCoreSupport/WebPasteboardHelper.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
sullivan [Thu, 12 Apr 2007 16:12:19 +0000 (16:12 +0000)]
WebCore:

        Reviewed by Anders

        - WebCore part of fix for:
        <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard

        * platform/ContextMenuItem.h:
        (WebCore::):
        add two PDF-related context menu items to enum to keep it in sync with WebKit

        * platform/ContextMenu.cpp:
        (WebCore::ContextMenu::checkOrEnableIfNeeded):
        add the new context menu items to the do-nothing case of a big switch statement

WebKit:

        Reviewed by Anders

        - WebKit part of fix for:
        <rdar://problem/5128697> REGRESSION: At least one PDF context menu item isn't appearing on Leopard

        * Misc/WebNSArrayExtras.h: Added.
        * Misc/WebNSArrayExtras.m: Added.
        (-[NSMutableArray _webkit_removeUselessMenuItemSeparators]):
        New file, includes this method to strip leading, trailing, and duplicate separators from arrays
        of NSMenuItems (copied from Safari)

        * WebView/WebUIDelegatePrivate.h:
        new MenuItemTag enum values for new PDFKit context menu items

        * WebKit.xcodeproj/project.pbxproj:
        updated for new files

        * WebView/WebPDFView.mm:
        (-[WebPDFView _anyPDFTagsFoundInMenu:]):
        check for new PDFKit context menu items
        (-[WebPDFView _menuItemsFromPDFKitForEvent:]):
        associate new PDFKit context menu item selectors with the new tags; skip certain selectors that
        correspond to menu items that WebKit already includes; remove useless menu item separators when
        we're done, since we might have removed arbitrarily-placed menu items

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoFixed drawing of justified text in the Qt port.
hausmann [Thu, 12 Apr 2007 15:28:39 +0000 (15:28 +0000)]
Fixed drawing of justified text in the Qt port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-11 Oliver Hunt <oliver@apple.com>
oliver [Thu, 12 Apr 2007 06:42:45 +0000 (06:42 +0000)]
2007-04-11  Oliver Hunt  <oliver@apple.com>

        Reviewed by Maciej.

WebCore:
        Adding RetainPtr to the many global obj-c pointers we use in
        C/C++ methods.  This is necessary to prevent GC from collecting
        globals we want to keep around.

        We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
        obj-c.

        Also made the Pasteboard::m_pasteboard a RetainPtr although it
        shouldn't be necessary as the only NSPasteboard instances that
        should ever be inserted are the system clipboard and dragging
        pasteboard.  Neither of which should ever be collected.

        * page/mac/WebCoreFrameBridge.mm:
        (_getPreSmartSet):
        (_getPostSmartSet):
        * platform/Pasteboard.h:
        * platform/graphics/mac/ColorMac.mm:
        (WebCore::nsColor):
        * platform/graphics/mac/GraphicsContextMac.mm:
        (WebCore::GraphicsContext::drawLineForMisspellingOrBadGrammar):
        * platform/mac/FontDataMac.mm:
        (WebCore::webFallbackFontFamily):
        * platform/mac/PasteboardMac.mm:
        (WebCore::writableTypesForURL):
        (WebCore::writableTypesForImage):
        (WebCore::Pasteboard::clear):
        (WebCore::Pasteboard::writeSelection):
        (WebCore::Pasteboard::writeURL):
        (WebCore::Pasteboard::writeFileWrapperAsRTFDAttachment):
        (WebCore::Pasteboard::writeImage):
        (WebCore::Pasteboard::canSmartReplace):
        (WebCore::Pasteboard::plainText):
        (WebCore::Pasteboard::documentFragment):

WebKit:
        Adding RetainPtr to the many global obj-c pointers we use in
        C/C++ methods.  This is necessary to prevent GC from collecting
        globals we want to keep around.

        We use RetainPtr in obj-c++ and c++ files, and CFRetain/Release in pure
        obj-c.

        This fixes <rdar://problem/5058731> -- Crash in
        WebCore::DragData::containsCompatibleContent due to early release
        of types array

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-11 Mitz Pettel <mitz@webkit.org>
bdash [Thu, 12 Apr 2007 04:45:48 +0000 (04:45 +0000)]
2007-04-11  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - fix http://bugs.webkit.org/show_bug.cgi?id=11362
          Native popup with size="1" wraps options

        Test: fast/forms/menulist-option-wrap.html

        * css/html4.css: Added white-space declaration for select[size="0"] and
        select[size="1"]. Added border-radius declaration for select.

2007-04-11  Mitz Pettel  <mitz@webkit.org>

        Reviewed by Dave Hyatt.

        - test and updated results for http://bugs.webkit.org/show_bug.cgi?id=11362
          Native popup with size="1" wraps options

        * fast/forms/menulist-option-wrap-expected.checksum: Added.
        * fast/forms/menulist-option-wrap-expected.png: Added.
        * fast/forms/menulist-option-wrap-expected.txt: Added.
        * fast/forms/menulist-option-wrap.html: Added.
        * fast/forms/select-empty-option-height-expected.checksum:
        * fast/forms/select-empty-option-height-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-11 MorganL <morganl.webkit@yahoo.com>
bdash [Thu, 12 Apr 2007 04:21:48 +0000 (04:21 +0000)]
2007-04-11  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Maciej.

        Add a Frame pointer to ChromeClient methods:
        http://bugs.webkit.org/show_bug.cgi?id=13127

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::createWindow):
        * page/Chrome.cpp:
        (WebCore::Chrome::createWindow):
        (WebCore::Chrome::createModalDialog):
        * page/Chrome.h:
        * page/ChromeClient.h:
        * page/ContextMenuController.cpp:
        (WebCore::openNewWindow):
        * platform/graphics/svg/SVGImageEmptyClients.h:
        (WebCore::SVGEmptyChromeClient::createWindow):
        (WebCore::SVGEmptyChromeClient::createModalDialog):

2007-04-11  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Maciej.

        Add a Frame pointer to ChromeClient methods:
        http://bugs.webkit.org/show_bug.cgi?id=13127

        * COM/ChromeClientWin.cpp:
        (ChromeClientWin::createWindow):
        (ChromeClientWin::createModalDialog):
        * COM/ChromeClientWin.h:
        * WebCoreSupport/WebChromeClient.h:
        * WebCoreSupport/WebChromeClient.mm:
        (WebChromeClient::createWindow):
        (WebChromeClient::createModalDialog):

2007-04-11  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Maciej.

        Add a Frame pointer to ChromeClient methods:
        http://bugs.webkit.org/show_bug.cgi?id=13127

        * WebCoreSupport/ChromeClientQt.cpp:
        (WebCore::ChromeClientQt::createWindow):
        (WebCore::ChromeClientQt::createModalDialog):
        * WebCoreSupport/ChromeClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Ada
beidson [Thu, 12 Apr 2007 01:38:41 +0000 (01:38 +0000)]
    Reviewed by Ada

        <rdar://problem/5080987> - Crash in DocumentLoader::frameLoader() const

        This was free nil checking lost during the ObjC -> C++ conversion

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::checkLoadCompleteForThisFrame): Null check the DocumentLoader

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Thu, 12 Apr 2007 01:25:35 +0000 (01:25 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/5126166>
        Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo

        * editing/deleting/5126166-expected.checksum: Added.
        * editing/deleting/5126166-expected.png: Added.
        * editing/deleting/5126166-expected.txt: Added.
        * editing/deleting/5126166.html: Added.

WebCore:

        Reviewed by harrison

        <rdar://problem/5126166>
        Deleting selection starting at before ToDo checkbox to end of line, inserts a BR in the subsequent ToDo

        If a selection ends in a table cell, we shouldn't perform
        a merge after deleting that selection.  We have code in
        place to prevent those merges, but it failed here.

        It fails because the end of the selection was [tableCell, 0],
        (normally not a valid VisiblePosition, but valid here
        because the table cell is empty).  We prevent the merge
        if the node of the position at the end of the selection
        has an enclosingTableCell.  Even though [tableCell, 0] has
        an enclosing table cell, the node tableCell doesn't, so
        the check fails.

        Fixed this by changing enclosingTableCell to take in
        a position, instead of a node.  The other enclosing element
        getters should be changed in this way as well.

        * editing/DeleteSelectionCommand.cpp:
        (WebCore::DeleteSelectionCommand::initializePositionData):
        Call the new enclosingTableCell.
        * editing/ReplaceSelectionCommand.cpp:
        (WebCore::ReplaceSelectionCommand::shouldMerge): Ditto.
        * editing/htmlediting.cpp:
        (WebCore::enclosingTableCell): Take in a position instead
        of a node.
        * editing/htmlediting.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-12 Mark Rowe <mrowe@apple.com>
bdash [Wed, 11 Apr 2007 21:30:37 +0000 (21:30 +0000)]
2007-04-12  Mark Rowe  <mrowe@apple.com>

        Second part of Qt build fix.

        * WebCoreSupport/FrameLoaderClientQt.cpp:
        (WebCore::FrameLoaderClientQt::loadedFromCachedPage):
        (WebCore::FrameLoaderClientQt::setDocumentViewFromCachedPage):
        (WebCore::FrameLoaderClientQt::saveDocumentViewToCachedPage):
        * WebCoreSupport/FrameLoaderClientQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-12 Mark Rowe <mrowe@apple.com>
bdash [Wed, 11 Apr 2007 20:58:25 +0000 (20:58 +0000)]
2007-04-12  Mark Rowe  <mrowe@apple.com>

        Qt build fix.

        * WebCore.pro:
        * editing/qt/EditorQt.cpp:
        (WebCore::Editor::markBadGrammar):
        * history/qt/CachedPageQt.cpp: Added.
        (WebCore::CachedPage::close):
        * history/qt/PageCacheQt.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Antti
beidson [Wed, 11 Apr 2007 18:22:20 +0000 (18:22 +0000)]
    Reviewed by Antti

        <rdar://problem/5125648> and http://bugs.webkit.org/show_bug.cgi?id=13326

        Crash opening a link in a new window from Gmail

        Problem here is that the currentHistoryItem in the new window is null.  This *shouldn't* be the case,
        and is the cause of a very long standing bug -
        http://bugs.webkit.org/show_bug.cgi?id=3546 - Can't go back to first page in new window opened from gmail

        For now, adding a null check prevents this crash and restores the original, long standing regression

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::updateHistoryForInternalLoad): NULL check

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Anders.
aroben [Wed, 11 Apr 2007 17:51:52 +0000 (17:51 +0000)]
    Reviewed by Anders.

        Made image document copying more cross-platform.

        All layout tests pass.

        * editing/Editor.cpp:
        (WebCore::imageNodeFromImageDocument): Added.
        (WebCore::Editor::canCopy): Called imageNodeFromImageDocument.
        (WebCore::Editor::copy): Ditto.
        (WebCore::Editor::copyImage): Updated for changes to Pasteboard.
        * platform/Pasteboard.h: Made writeImage more general, which allowed
        getting rid of its second incarnation.
        * platform/gdk/TemporaryLinkStubs.cpp:
        * platform/mac/PasteboardMac.mm:
        (WebCore::Pasteboard::writeImage): Collapsed logic from the two
        writeImage methods into one.
        (Pasteboard::writeImage): Updated for Pasteboard changes.
        * platform/qt/PasteboardQt.cpp:
        (WebCore::Pasteboard::writeImage): Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * css/CSSValueKeywords.in: Fix a comment.
darin [Wed, 11 Apr 2007 07:50:59 +0000 (07:50 +0000)]
    * css/CSSValueKeywords.in: Fix a comment.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
justing [Wed, 11 Apr 2007 02:43:33 +0000 (02:43 +0000)]
LayoutTests:

        Reviewed by harrison

        <rdar://problem/4932260>
        Invalid attributed string for attachment range obtained via AXPreviousWordStartTextMarkerForTextMarker

        Forgot to check these in in my previous checkin:
        * editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
        * editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.

        Tests for a bug where replaced elements would act
        as sentence boundaries:
        * editing/selection/4932260-1-expected.checksum: Added.
        * editing/selection/4932260-1-expected.png: Added.
        * editing/selection/4932260-1-expected.txt: Added.
        * editing/selection/4932260-1.html: Added.

        Tests to see that replaced elements do not act as word
        boundaries when moving forward through the document:
        * editing/selection/4932260-2-expected.checksum: Added.
        * editing/selection/4932260-2-expected.png: Added.
        * editing/selection/4932260-2-expected.txt: Added.
        * editing/selection/4932260-2.html: Added.

        Ditto but tests moving backward:
        * editing/selection/4932260-3-expected.checksum: Added.
        * editing/selection/4932260-3-expected.png: Added.
        * editing/selection/4932260-3-expected.txt: Added.
        * editing/selection/4932260-3.html: Added.

        No way to test accessibility APIs atm, and had trouble
        making a test for selection creation with double-click
        and drag.

WebCore:

        Reviewed by harrison

        <rdar://problem/4932260>
        Invalid attributed string for attachment range obtained via AXPreviousWordStartTextMarkerForTextMarker

        By default, text iterators don't emit anything for replaced
        elements.  Boundary finding code works around this but has
        bugs: replaced elements act as sentence boundaries and the
        above bug, where previousBoundary moves past the start of a
        word if there is a replaced element just before it. This
        patch fixes these issues by treating replaced elements as
        punctuation for boundary finding.

        * editing/TextIterator.cpp:
        (WebCore::SimplifiedBackwardsTextIterator::SimplifiedBackwardsTextIterator):
        Set m_pastStartNode, the node after (in a reverse pre-order traversal) the
        last one that should be processed.
        (WebCore::SimplifiedBackwardsTextIterator::advance):
        Stop at m_pastStartNode.
        Iterate over nodes in reverse pre-order (TextIterator traverses in
        pre-orer). This makes knowing when to emit characters after nodes vs. when
        to emit characters before nodes easier.
        Remove the special case for entering a new block, emitting characters
        after nodes can now be handled generally, in handleNonTextNode(), because
        of the way we traverse.
        Set m_handledChildren to false every iteration since we now do traverse in
        reverse pre-order.
        (WebCore::SimplifiedBackwardsTextIterator::handleReplacedElement):
        Emit a comma for replaced elements.  We only use this kind of iterator
        for finding boundaries, so we can do this unconditionally.
        (WebCore::SimplifiedBackwardsTextIterator::handleNonTextNode):
        Don't use emitNewline, instead specify where the newline should be positioned.
        A node is handled before its children, so characters emitted here should
        be positioned after the node, not before it.
        (WebCore::SimplifiedBackwardsTextIterator::exitNode):
        Don't use emitNewline, instead specify where the newline should be positioned.
        (WebCore::CharacterIterator::CharacterIterator):
        Create a TextIterator that emits content for replaced elements, if requested.
        * editing/TextIterator.h:
        * editing/visible_units.cpp:
        (WebCore::previousBoundary):
        Removed replaced element handling code.
        If the start of the chunk that contained the boundary was in a non-text
        node, then the boundary is not necessarily in that node.  Particularly
        because it is only the end of the chunk that is guaranteed to be a valid
        position in those cases.  We must iterate backwards by character from
        the end of the chunk to find the boundary.
        (WebCore::nextBoundary): Removed replaced element handling code.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
beidson [Tue, 10 Apr 2007 23:55:56 +0000 (23:55 +0000)]
WebCore:

        Reviewed by Darin

        <rdar://problem/4887095> - PageCache and PageState should be combined

        These two objects are a relic of when the PageCache was split between WebCore and WebKit
        It just makes good sense to combine them now, and the new object is more appropriately
        called "CachedPage"

        This patch is vast in scope, but simple in depth - anywhere a PageCache or PageState object
        was used has been adjusted to use a CachedPage object instead.  The most notable change is
        that HistoryItem - which always used to have a PageCache object which may or may not have
        had a PageState - now may or may not have a CachedPage.  This actually simplifies the
        HistoryItem code a bit while making the role of CachedPage much more clear.

        * WebCore.exp:
        * WebCore.xcodeproj/project.pbxproj:

        * history/BackForwardList.cpp:
        (WebCore::BackForwardList::addItem):
        (WebCore::BackForwardList::setCapacity):
        (WebCore::BackForwardList::setPageCacheSize):
        (WebCore::BackForwardList::clearPageCache):
        (WebCore::BackForwardList::close):

        * history/PageCache.cpp: Removed.
        * history/PageCache.h: Removed.
        * page/PageState.cpp: Removed.
        * page/PageState.h: Removed.
        * history/CachedPage.cpp: Added.
        (WebCore::CachedPage::create):
        (WebCore::CachedPage::CachedPage):
        (WebCore::CachedPage::~CachedPage):
        (WebCore::CachedPage::restore):
        (WebCore::CachedPage::clear):
        (WebCore::CachedPage::setDocumentLoader):
        (WebCore::CachedPage::documentLoader):
        (WebCore::CachedPage::setTimeStamp):
        (WebCore::CachedPage::setTimeStampToNow):
        (WebCore::CachedPage::timeStamp):
        * history/CachedPage.h: Added.
        (WebCore::CachedPage::document):
        (WebCore::CachedPage::mousePressNode):
        (WebCore::CachedPage::URL):

        * history/HistoryItem.cpp:
        (WebCore::HistoryItem::HistoryItem):
        (WebCore::HistoryItem::setCachedPage):
        (WebCore::HistoryItem::setURL):
        (WebCore::HistoryItem::alwaysAttemptToUseCachedPage):
        (WebCore::HistoryItem::setAlwaysAttemptToUseCachedPage):
        (WebCore::HistoryItem::cachedPage):
        (WebCore::cachedPagesPendingRelease):
        (WebCore::HistoryItem::releaseCachedPagesOrReschedule):
        (WebCore::HistoryItem::releaseAllPendingCachedPages):
        (WebCore::HistoryItem::scheduleCachedPageForRelease):
        * history/HistoryItem.h:
        * history/mac/HistoryItemMac.mm:

        * history/HistoryItemTimer.cpp:
        (WebCore::HistoryItemTimer::HistoryItemTimer):
        (WebCore::HistoryItemTimer::callReleaseCachedPagesOrReschedule):
        * history/HistoryItemTimer.h:

        * history/mac/PageCacheMac.mm: Removed.
        * history/mac/CachedPageMac.mm: Added.
        (WebCore::CachedPage::close):
        (WebCore::CachedPage::setDocumentView):
        (WebCore::CachedPage::documentView):

        * loader/DocumentLoader.cpp:
        (WebCore::DocumentLoader::DocumentLoader):
        (WebCore::DocumentLoader::loadFromCachedPage):
        (WebCore::DocumentLoader::setLoadingFromCachedPage):
        (WebCore::DocumentLoader::isLoadingFromCachedPage):
        * loader/DocumentLoader.h:

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::provisionalLoadStarted):
        (WebCore::FrameLoader::commitProvisionalLoad):
        (WebCore::FrameLoader::transitionToCommitted):
        (WebCore::FrameLoader::open):
        (WebCore::FrameLoader::startLoading):
        (WebCore::FrameLoader::receivedMainResourceError):
        (WebCore::FrameLoader::opened):
        (WebCore::FrameLoader::continueLoadAfterNavigationPolicy):
        (WebCore::FrameLoader::loadProvisionalItemFromCachedPage):
        (WebCore::FrameLoader::cachePageToHistoryItem):
        (WebCore::FrameLoader::createHistoryItem):
        (WebCore::FrameLoader::purgePageCache):
        (WebCore::FrameLoader::invalidateCurrentItemCachedPage):
        (WebCore::FrameLoader::loadItem):
        (WebCore::FrameLoader::updateHistoryForStandardLoad):
        (WebCore::FrameLoader::updateHistoryForClientRedirect):
        (WebCore::FrameLoader::updateHistoryForBackForwardNavigation):
        (WebCore::FrameLoader::updateHistoryForReload):
        (WebCore::FrameLoader::updateHistoryForInternalLoad):
        (WebCore::FrameLoader::updateHistoryForCommit):
        * loader/FrameLoader.h:
        * loader/FrameLoaderClient.h:

        * page/mac/WebCoreFrameBridge.h: Got rid of unused WebCorePageCacheStateKey
        * page/mac/WebCoreFrameBridge.mm: Ditto

        * platform/graphics/svg/SVGImage.cpp:
        * platform/graphics/svg/SVGImageEmptyClients.h: Update to reflect the new names
        (WebCore::SVGEmptyFrameLoaderClient::loadProvisionalItemFromCachedPage):
        (WebCore::SVGEmptyFrameLoaderClient::invalidateCurrentItemCachedPage):
        (WebCore::SVGEmptyFrameLoaderClient::loadedFromCachedPage):
        (WebCore::SVGEmptyFrameLoaderClient::clearLoadingFromCachedPage):
        (WebCore::SVGEmptyFrameLoaderClient::isLoadingFromCachedPage):
        (WebCore::SVGEmptyFrameLoaderClient::setDocumentViewFromCachedPage):
        (WebCore::SVGEmptyFrameLoaderClient::saveDocumentViewToCachedPage):

WebKit:

        Reviewed by Darin

        <rdar://problem/4887095> - PageCache and PageState should be combined

        WebKit side of the change to reflect the new object name of CachedPage and new Client method names

        * History/WebHistoryItem.mm:
        (-[WebHistoryItem setAlwaysAttemptToUsePageCache:]):
        (+[WebHistoryItem _releaseAllPendingPageCaches]):
        (-[WebWindowWatcher windowWillClose:]):

        * WebCoreSupport/WebFrameLoaderClient.h:
        * WebCoreSupport/WebFrameLoaderClient.mm:
        (WebFrameLoaderClient::setDocumentViewFromCachedPage):
        (WebFrameLoaderClient::loadedFromCachedPage):
        (WebFrameLoaderClient::saveDocumentViewToCachedPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mark Rowe.
ggaren [Tue, 10 Apr 2007 22:40:00 +0000 (22:40 +0000)]
    Reviewed by Mark Rowe.

        Fixed last check-in to print in release builds, too.

        * kjs/collector.cpp:
        (KJS::getPlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by John Sullivan, Darin Adler.
ggaren [Tue, 10 Apr 2007 22:27:26 +0000 (22:27 +0000)]
    Reviewed by John Sullivan, Darin Adler.

        Fixed <rdar://problem/5121899> JavaScript garbage collection leads to
        later crash under Rosetta (should abort or leak instead?)

        Log an error message and crash if the kernel reports failure during GC.
        We decided to do this instead of just leaking because we don't want people
        to get the mistaken impression that running in Rosetta is a supported
        configurtion.

        The CRASH macro will also hook into CrashReporter, which will tell us if
        many (any?) users run into this issue.

        * kjs/collector.cpp:
        (KJS::getPlatformThreadRegisters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
antti [Tue, 10 Apr 2007 21:44:53 +0000 (21:44 +0000)]
LayoutTests:

        Reviewed by Hyatt.

        Layout test for <rdar://5057686>
        Flex box layout example hangs in WebCore::RenderFlexibleBox::allowedChildFlex

        * fast/flexbox/flex-hang-expected.checksum: Added.
        * fast/flexbox/flex-hang-expected.png: Added.
        * fast/flexbox/flex-hang-expected.txt: Added.
        * fast/flexbox/flex-hang.html: Added.

WebCore:

        Reviewed by Hyatt.

        Fix <rdar://5057686>
        Flex box layout example hangs in WebCore::RenderFlexibleBox::allowedChildFlex

        Forcibly distribute remaining pixels if the algorithm is not advancing.

        * rendering/RenderFlexibleBox.cpp:
        (WebCore::RenderFlexibleBox::layoutHorizontalBox):
        (WebCore::RenderFlexibleBox::layoutVerticalBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago2007-04-11 Mark Rowe <mrowe@apple.com>
bdash [Tue, 10 Apr 2007 21:37:35 +0000 (21:37 +0000)]
2007-04-11  Mark Rowe  <mrowe@apple.com>

        Build fix.

        * bridge/mac/WebCoreAXObject.mm:
        (-[WebCoreAXObject accessibilityDescription]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago<rdar://problem/5122276> Allow focused frame to fire off notification
pyeh [Tue, 10 Apr 2007 21:00:53 +0000 (21:00 +0000)]
<rdar://problem/5122276> Allow focused frame to fire off notification
Improve accessibility support for Mail WebView embedded Notes.
* bridge/mac/AXObjectCacheMac.mm:
(WebCore::AXObjectCache::postNotification):
The focused document with the selection change should fire the selection changed notification, not the top level document
* bridge/mac/WebCoreAXObject.mm:
(-[WebCoreAXObject accessibilityDescription]):
Allow the name attribute of the html body to be used as the accessibility description

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
ggaren [Tue, 10 Apr 2007 18:19:51 +0000 (18:19 +0000)]
WebCore:

        Reviewed by Maciej Stachowiak.

        Support for fixing fast/forms/textarea-paste-newline.html.

        Changed clients to use new preference specifying whether a Page should
        allow pasting through the DOM API, instead of a global flag.

        Removed old behavior of always allowing DOM paste in debug builds. In
        light of the new preference-based API, that behavior makes no sense anymore.
        Instead, developers who want to test paste inside Safari can set the
        preference for themselves.

        * WebCore.exp:
        * editing/CommandByName.cpp: Removed crazy hack to keep an identically
        named but invalid copy of the global "pate allowed" flag in this file.
        (WebCore::Frame::enabledPaste):
        * editing/JSEditor.cpp: Removed "always allow" behavior for debug builds.
        (WebCore::JSEditor::queryCommandSupported):
        * editing/JSEditor.h:
        * page/Settings.cpp:
        (WebCore::Settings::setDOMPasteAllowed):
        * page/Settings.h:
        (WebCore::Settings::isDOMPasteAllowed):
        * rendering/RenderTreeAsText.cpp:
        (WebCore::externalRepresentation): Removed crazy hack to allow DOM paste
        after this function has been called.

WebKit:

        Reviewed by Maciej Stachowiak.

        Support for fixing fast/forms/textarea-paste-newline.html.

        Added SPI for specifying whether a WebView should allow pasting through the
        DOM API.

        * ChangeLog:
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.m:
        (+[WebPreferences standardPreferences]):
        (-[WebPreferences isDOMPasteAllowed]):
        (-[WebPreferences setDOMPasteAllowed:]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _updateWebCoreSettingsFromPreferences:]):

WebKitTools:

        Reviewed by Maciej Stachowiak.

        Fixed fast/forms/textarea-paste-newline.html.

        This failure was pretty funny. run-webkit-tests kills and respawns
        DumpRenderTree once every 1000 runs. Adding a few tests caused
        textarea-paste-newline.html to run right at the beginning of DumpRenderTree's
        lifetime, before any render tree dumps had occurred. However, WebCore
        used a render tree dump as the hook that set a global flag to allow
        pasting through the DOM API, so running before any render tree dumps had
        occurred caused this test to fail.

        * DumpRenderTree/DumpRenderTree.m:
        (dumpRenderTree): Explicitly tell WebKit to allow pasting through the DOM
        API, instead of hoping it will read the tea leaves.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Tim Hatcher
sullivan [Tue, 10 Apr 2007 16:28:40 +0000 (16:28 +0000)]
    Reviewed by Tim Hatcher

        - fixed <rdar://problem/4859132> Grammar must always be checked in entire-sentence chunks,
          and shouldn't show markers for current sentence

        * editing/Editor.h:
        add markBadGrammar, now distinct from markMisspellings

        * editing/mac/EditorMac.mm:
        (WebCore::Editor::markMisspellingsAfterTypingToPosition):
        call markMisspellings on one word, and markBadGrammar on entire sentence
        (WebCore::markMisspellingsOrBadGrammar):
        new static function, extracted from markMisspellings
        (WebCore::Editor::markMisspellings):
        now calls extracted function
        (WebCore::Editor::markBadGrammar):
        new method, calls extracted function

        * page/Frame.cpp:
        (WebCore::Frame::respondToChangedSelection):
        update grammar markers for entire new and old sentences

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago * blog/wp-content/chrome.jpg: Added.
adele [Tue, 10 Apr 2007 01:05:19 +0000 (01:05 +0000)]
    * blog/wp-content/chrome.jpg: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20815 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoWebCore:
andersca [Tue, 10 Apr 2007 00:06:35 +0000 (00:06 +0000)]
WebCore:

        Reviewed by John.

        * WebCore.exp:
        Add __ZNK7WebCore11FrameLoader10isCompleteEv.

WebKit:

        Reviewed by John.

        <rdar://problem/5081860>
        REGRESSION: Select All for standalone image has no visible effect but does change state

        <rdar://problem/5081840>
        REGRESSION: context menu in white space beyond standalone image is different after Select All

        Have validateUserInterface emulate the old behavior for full-frame images and plugins, which is:

        - For full-frame plugins, always return false.
        - For images, only return true if the selector is copy: and the image has finished loading.

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView validateUserInterfaceItem:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoLayoutTests:
beidson [Tue, 10 Apr 2007 00:00:21 +0000 (00:00 +0000)]
LayoutTests:

        Reviewed by Darin

        Layout test for the fix for <rdar://4921797> and http://bugs.webkit.org/show_bug.cgi?id=12005

        * http/tests/navigation/multiple-back-forward-entries-expected.txt: Added.
        * http/tests/navigation/multiple-back-forward-entries.html: Added.
        * http/tests/navigation/resources/slow-resource.pl: Added.

WebCore:

        Reviewed by Darin

        Fixes <rdar://4921797> and http://bugs.webkit.org/show_bug.cgi?id=12005

        The original regression was to claim that more loads were the result of a "user gesture" than really
        were.  A lot of the ways a frame load could be kicked off didn't properly set up this flag, and it
        wasn't properly propagated and respected where it should've been.

        This patch cleans much of that up.  One loose end is the "treatAsUserGesture" flag which is a stop
        gap measure to keep "slow redirects" working to create a new history item.  In the future, we need
        to cleanup the meaning and use of "userGesture" and "lockHistory."  This includes integrating them
        in to FrameLoadRequest and being very clear of what their meaning actually is at different stages of
        the Frame load process.

        * dom/Document.cpp:
        (WebCore::Document::processHttpEquiv): Pass only the delay for the redirect

        * html/HTMLAnchorElement.cpp:
        (WebCore::HTMLAnchorElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true

        * ksvg2/svg/SVGAElement.cpp:
        (WebCore::SVGAElement::defaultEventHandler): Pass "lockHistory" false, "userGesture" true

        * loader/FrameLoader.cpp:
        (WebCore::ScheduledRedirection::ScheduledRedirection): Figure "lockHistory" and "userGesture" from the
          delay here, instead of at 3 other different sites that call this method
        (WebCore::FrameLoader::changeLocation): Set userGesture correctly
        (WebCore::FrameLoader::urlSelected): Propagate userGesture down
        (WebCore::FrameLoader::requestFrame):
        (WebCore::FrameLoader::receivedFirstData):
        (WebCore::FrameLoader::scheduleRedirection): Pass only the delay here
        (WebCore::FrameLoader::redirectionTimerFired): Set userGesture correctly
        (WebCore::FrameLoader::load):
        (WebCore::FrameLoader::updateHistoryForInternalLoad): Insteading of asserting we aren't a redirect,
          handle the case where we *are* a redirect by updating the previous history item
        * loader/FrameLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20813 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Darin.
andersca [Mon, 9 Apr 2007 23:31:50 +0000 (23:31 +0000)]
    Reviewed by Darin.

        <rdar://problem/5026893>
        REGRESSION: "Mail Contents of this Page" for standalone image in Safari results in a broken image in Mail

        * WebView/WebFrame.mm:
        (-[WebFrame DOMDocument]):
        We can't check for _isHTMLDocument here since image and plugin documents inherit from HTMLDocument. Instead,
        check for those two document types explicitly.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Geoff, Ada and John.
andersca [Mon, 9 Apr 2007 22:52:11 +0000 (22:52 +0000)]
    Reviewed by Geoff, Ada and John.

        <rdar://problem/4600978> Would like a way to test whether a WebView is displaying a standalone image

        * WebView/WebFrame.mm:
        (-[WebFrame _isDisplayingStandaloneImage]):
        * WebView/WebFramePrivate.h:
        Add _isDisplayingStandaloneImage SPI.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years agoAdd bug number to ChangeLog.
andersca [Mon, 9 Apr 2007 22:11:50 +0000 (22:11 +0000)]
Add bug number to ChangeLog.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20809 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by ggaren
justing [Mon, 9 Apr 2007 20:07:00 +0000 (20:07 +0000)]
    Reviewed by ggaren

        These were never checked in:
        * editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.checksum: Added.
        * editing/pasteboard/drag-image-to-contenteditable-in-iframe-expected.png: Added.

        New results were never checked in after some selection
        gap filling fixes:
        * editing/style/remove-underline-across-paragraph-expected.checksum:
        * editing/style/remove-underline-across-paragraph-expected.png:
        * editing/style/remove-underline-across-paragraph-in-bold-expected.checksum:
        * editing/style/remove-underline-across-paragraph-in-bold-expected.png:
        * editing/style/style-3690704-fix-expected.checksum:
        * editing/style/style-3690704-fix-expected.png:
        * editing/style/table-selection-expected.checksum:
        * editing/style/table-selection-expected.png:
        * editing/undo/4063751-expected.checksum:
        * editing/undo/4063751-expected.png:
        * editing/style/apple-style-editable-mix-expected.checksum:
        * editing/style/apple-style-editable-mix-expected.png:
        * editing/inserting/paragraph-separator-in-table-1-expected.checksum:
        * editing/inserting/paragraph-separator-in-table-1-expected.png:
        * editing/inserting/paragraph-separator-in-table-2-expected.checksum:
        * editing/inserting/paragraph-separator-in-table-2-expected.png:

        Checking in incorrect results and adding a FIXME that references the
        bug that this test demonstrates:
        * editing/style/smoosh-styles-003-expected.checksum:
        * editing/style/smoosh-styles-003-expected.png:
        * editing/style/smoosh-styles-003-expected.txt:
        * editing/style/smoosh-styles-003.html:

        Misspelling marker correctly removed:
        * editing/deleting/delete-to-select-table-expected.checksum:
        * editing/deleting/delete-to-select-table-expected.png:

        Horizontal rules and parts of table borders were made very slightly
        darker, and these results were never updated:
        * editing/inserting/4278698-expected.checksum:
        * editing/inserting/4278698-expected.png:
        * editing/unsupported-content/table-type-after-expected.checksum:
        * editing/unsupported-content/table-type-after-expected.png:
        * editing/unsupported-content/table-type-before-expected.checksum:
        * editing/unsupported-content/table-type-before-expected.png:
        * editing/deleting/table-cells-expected.checksum:
        * editing/deleting/table-cells-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20808 268f45cc-cd09-0410-ab3c-d52691b4dbfc

12 years ago Reviewed by Mitz.
andersca [Mon, 9 Apr 2007 19:51:27 +0000 (19:51 +0000)]
    Reviewed by Mitz.

        * plugins/resources/open-and-close-window-with-plugin.html:
        Try to fix the ASSERT on the build bot by scheduling a timeout that schedules a timeout.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@20807 268f45cc-cd09-0410-ab3c-d52691b4dbfc