WebKit-https.git
10 years ago2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 23:29:07 +0000 (23:29 +0000)]
2011-03-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81683.
        http://trac.webkit.org/changeset/81683
        https://bugs.webkit.org/show_bug.cgi?id=56872

        Crashing in some tests (Requested by weinig on #webkit).

        * win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 22 Mar 2011 23:23:15 +0000 (23:23 +0000)]
2011-03-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add support to build-webkit for building with gyp-generated project files
        https://bugs.webkit.org/show_bug.cgi?id=56877

        Found a couple missing Private headers while trying to make WebCore build.

        * JavaScriptCore.gypi:
2011-03-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add support to build-webkit for building with gyp-generated project files
        https://bugs.webkit.org/show_bug.cgi?id=56877

        build-webkit is a cesspool.  This change just hacks in --gyp support for Mac.
        Eventually we'll want to support gyp-generated projects in a more general manner.

        * Scripts/build-webkit:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=56869
hyatt@apple.com [Tue, 22 Mar 2011 23:21:54 +0000 (23:21 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56869

Reviewed by Simon Fraser.

Make horizontal writing mode a bit on RenderObject with a fast inlined method for access. This should be
a little faster than having to access the information from the RenderStyle's sub-structure.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
(WebCore::RenderBlock::addOverflowFromChildren):
(WebCore::RenderBlock::computeOverflow):
(WebCore::RenderBlock::adjustPositionedBlock):
(WebCore::RenderBlock::setLogicalLeftForChild):
(WebCore::RenderBlock::setLogicalTopForChild):
(WebCore::RenderBlock::layoutPositionedObjects):
(WebCore::RenderBlock::paintColumnRules):
(WebCore::RenderBlock::paintColumnContents):
(WebCore::RenderBlock::flipFloatForWritingMode):
(WebCore::blockDirectionOffset):
(WebCore::inlineDirectionOffset):
(WebCore::RenderBlock::logicalRectToPhysicalRect):
(WebCore::RenderBlock::inlineSelectionGaps):
(WebCore::RenderBlock::addOverhangingFloats):
(WebCore::RenderBlock::addIntrudingFloats):
(WebCore::RenderBlock::hitTestColumns):
(WebCore::positionForPointRespectingEditingBoundaries):
(WebCore::RenderBlock::positionForPointWithInlineChildren):
(WebCore::RenderBlock::positionForPoint):
(WebCore::RenderBlock::columnRectAt):
(WebCore::RenderBlock::adjustPointToColumnContents):
(WebCore::RenderBlock::adjustRectForColumns):
(WebCore::RenderBlock::flipForWritingModeIncludingColumns):
(WebCore::RenderBlock::adjustForColumns):
(WebCore::RenderBlock::lastLineBoxBaseline):
(WebCore::RenderBlock::nextPageLogicalTop):
(WebCore::RenderBlock::adjustForUnsplittableChild):
(WebCore::RenderBlock::adjustLinePositionForPagination):
(WebCore::RenderBlock::collapsedMarginBeforeForChild):
(WebCore::RenderBlock::collapsedMarginAfterForChild):
(WebCore::RenderBlock::marginStartForChild):
(WebCore::RenderBlock::marginEndForChild):
(WebCore::RenderBlock::setMarginStartForChild):
(WebCore::RenderBlock::setMarginEndForChild):
(WebCore::RenderBlock::marginValuesForChild):
* rendering/RenderBlock.h:
(WebCore::RenderBlock::logicalWidthForChild):
(WebCore::RenderBlock::logicalHeightForChild):
(WebCore::RenderBlock::logicalTopForChild):
(WebCore::RenderBlock::logicalRightOffsetForContent):
(WebCore::RenderBlock::logicalLeftOffsetForContent):
(WebCore::RenderBlock::logicalTopForFloat):
(WebCore::RenderBlock::logicalBottomForFloat):
(WebCore::RenderBlock::logicalLeftForFloat):
(WebCore::RenderBlock::logicalRightForFloat):
(WebCore::RenderBlock::logicalWidthForFloat):
(WebCore::RenderBlock::setLogicalTopForFloat):
(WebCore::RenderBlock::setLogicalLeftForFloat):
(WebCore::RenderBlock::setLogicalHeightForFloat):
(WebCore::RenderBlock::setLogicalWidthForFloat):
(WebCore::RenderBlock::xPositionForFloatIncludingMargin):
(WebCore::RenderBlock::yPositionForFloatIncludingMargin):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::createLineBoxes):
(WebCore::RenderBlock::layoutInlineChildren):
(WebCore::RenderBlock::checkFloatsInCleanLine):
(WebCore::setStaticPositions):
(WebCore::RenderBlock::findNextLineBreak):
(WebCore::RenderBlock::beforeSideVisualOverflowForLine):
(WebCore::RenderBlock::afterSideVisualOverflowForLine):
(WebCore::RenderBlock::beforeSideLayoutOverflowForLine):
(WebCore::RenderBlock::afterSideLayoutOverflowForLine):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::marginStart):
(WebCore::RenderBox::marginEnd):
(WebCore::RenderBox::setMarginStart):
(WebCore::RenderBox::setMarginEnd):
(WebCore::RenderBox::styleDidChange):
(WebCore::RenderBox::logicalScroll):
(WebCore::RenderBox::computeLogicalWidth):
(WebCore::RenderBox::computeLogicalHeight):
(WebCore::RenderBox::availableLogicalHeightUsing):
(WebCore::RenderBox::containingBlockLogicalWidthForPositioned):
(WebCore::RenderBox::containingBlockLogicalHeightForPositioned):
(WebCore::RenderBox::computePositionedLogicalWidth):
(WebCore::computeLogicalLeftPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalHeight):
(WebCore::computeLogicalTopPositionedOffset):
(WebCore::RenderBox::computePositionedLogicalWidthReplaced):
(WebCore::RenderBox::computePositionedLogicalHeightReplaced):
(WebCore::RenderBox::addLayoutOverflow):
(WebCore::RenderBox::flipForWritingMode):
* rendering/RenderBoxModelObject.cpp:
(WebCore::RenderBoxModelObject::updateBoxModelInfoFromStyle):
* rendering/RenderObject.cpp:
(WebCore::RenderObject::RenderObject):
(WebCore::RenderObject::styleWillChange):
* rendering/RenderObject.h:
(WebCore::RenderObject::isHorizontalWritingMode):
(WebCore::RenderObject::setHorizontalWritingMode):
* rendering/RenderTableCell.cpp:
(WebCore::RenderTableCell::paddingTop):
(WebCore::RenderTableCell::paddingBottom):
(WebCore::RenderTableCell::paddingLeft):
(WebCore::RenderTableCell::paddingRight):
(WebCore::RenderTableCell::scrollbarsChanged):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::RootInlineBox):
(WebCore::RootInlineBox::lineSelectionGap):
(WebCore::RootInlineBox::verticalPositionForBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Tue, 22 Mar 2011 23:17:23 +0000 (23:17 +0000)]
2011-03-22  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Beth Dakin.

        Incorrect rendering of composited element with negative z-index child
        https://bugs.webkit.org/show_bug.cgi?id=56846

        When a composited element has a child with negative z-index, we make
        a separate layer for that element's foreground content. This layer
        was positioned incorrectly (but the content happened to paint at
        the right location), resulting in right/bottom clipping.

        Fix this, remove the little-used graphicsLayerToContentsCoordinates()
        contentsToGraphicsLayerCoordinates() methods, and optimize incremental
        repaints in the foreground and mask layers.

        Tests: compositing/geometry/foreground-layer.html
               compositing/geometry/repaint-foreground-layer.html

        * platform/graphics/ca/GraphicsLayerCA.cpp:
        (WebCore::GraphicsLayerCA::setNeedsDisplayInRect): Cull repaints
        which fall outside the layer bounds, so callers don't have to,
        and to avoid unnecessary layer commits.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::updateGraphicsLayerGeometry): If
        we have a foreground layer inside a clipping layer, the foreground
        layer's offset is zero, since the clipping layer is its parent.

        (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect): Use
        offsetFromRenderer() directly instead of contentsToGraphicsLayerCoordinates().
        Also do incremental repaints of the foreground and mask layers.

        (WebCore::RenderLayerBacking::paintContents): It was incorrect to always
        use compositedBounds() to compute the painting offset, since that's
        per-RenderLayerBacking, but a single RenderLayerBacking can have different
        GraphicsLayers with different offsets (e.g. the foreground layer).
        Instead, use offsetFromRenderer(), which gives has the correct offset.

        * rendering/RenderLayerBacking.h: Remove unused methods.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 22:45:07 +0000 (22:45 +0000)]
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        gyp/configure shouldn&apos;t require GYP to be in your path
        https://bugs.webkit.org/show_bug.cgi?id=56873

        Now that GYP is on Source/ThirdParty/gyp, we can just use that copy
        instead of requiring GYP to be in the user's path.

        * Source/gyp/configure:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 22 Mar 2011 22:43:47 +0000 (22:43 +0000)]
2011-03-22  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Use default-output instead of default-input to get hardware sample-rate
        https://bugs.webkit.org/show_bug.cgi?id=56858

        No new tests since audio API is not yet implemented.

        * platform/audio/mac/AudioDestinationMac.cpp:
        (WebCore::AudioDestination::hardwareSampleRate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Pratik Solanki <psolanki@apple.com>
psolanki@apple.com [Tue, 22 Mar 2011 22:42:20 +0000 (22:42 +0000)]
2011-03-22  Pratik Solanki  <psolanki@apple.com>

        Reviewed by David Kilzer.

        Implement -connection:didReceiveDataArray: NSURLConnection delegate method
        https://bugs.webkit.org/show_bug.cgi?id=56838

        Add experimental support for the didReceiveDataArray callback on
        NSURLConnection. A RessourceHandleClient indicates its ability to
        handle this callback by returning true from supportsDataArray() method.
        Currently only SubresourceLoader uses this so we get the benefit for
        CSS, JS and image loads. For other clients we call didReceiveData with
        the CFData contents as before.

        * WebCore.xcodeproj/project.pbxproj:
        * loader/ResourceLoader.h:
        * loader/SubresourceLoader.h:
        (WebCore::SubresourceLoader::supportsDataArray):
        * loader/cf/SubresourceLoaderCF.cpp: Added.
        (WebCore::SubresourceLoader::didReceiveDataArray):
        * loader/mac/ResourceLoaderMac.mm:
        (WebCore::ResourceLoader::didReceiveDataArray):
        * platform/SharedBuffer.cpp:
        (WebCore::SharedBuffer::clear):
        (WebCore::SharedBuffer::buffer):
        * platform/SharedBuffer.h:
        * platform/cf/SharedBufferCF.cpp:
        (WebCore::SharedBuffer::append):
        (WebCore::SharedBuffer::copyDataArrayAndClear):
        * platform/network/ResourceHandleClient.h:
        (WebCore::ResourceHandleClient::supportsDataArray):
        (WebCore::ResourceHandleClient::didReceiveDataArray):
        * platform/network/mac/ResourceHandleMac.mm:
        (-[WebCoreResourceHandleAsDelegate connection:didReceiveDataArray:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 22:36:52 +0000 (22:36 +0000)]
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add GYP to Source/ThirdParty
        https://bugs.webkit.org/show_bug.cgi?id=56870

        We probably don't need all the test files, but it seems cleaner to just
        check in the whole GYP tree.  GYP is BSD licensed, so it is compatible
        with the WebKit license.

        * Source/ThirdParty/gyp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 22 Mar 2011 22:09:57 +0000 (22:09 +0000)]
2011-03-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
        https://bugs.webkit.org/show_bug.cgi?id=56867

        This should make it possible to build the gyp-generated JavaScriptCore.xcodeproj
        from a JavaScriptCore directory outside of Source.

        * gyp/JavaScriptCore.gyp:
        * gyp/run-if-exists.sh: Added.
        * gyp/update-info-plist.sh: Added.
2011-03-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
        https://bugs.webkit.org/show_bug.cgi?id=56867

        This should make it possible to build the gyp-generated JavaScriptGlue.xcodeproj
        from a JavaScriptGlue directory outside of Source.

        * gyp/JavaScriptGlue.gyp:
        * gyp/run-if-exists.sh: Added.
        * gyp/update-info-plist.sh: Added.
2011-03-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Make it possible to build JavaScriptCore and WebCore gyp builds outside of Source
        https://bugs.webkit.org/show_bug.cgi?id=56867

        This should make it possible to build the gyp-generated WebCore.xcodeproj
        from a WebCore directory outside of Source.

        * gyp/WebCore.gyp:
        * gyp/run-if-exists.sh: Added.
        * gyp/update-info-plist.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix WebKit2 build.
andersca@apple.com [Tue, 22 Mar 2011 21:57:32 +0000 (21:57 +0000)]
Fix WebKit2 build.

* WebCore.exp.in:
Export a symbol needed by WebKit2.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 21:51:59 +0000 (21:51 +0000)]
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add the remaining steps to WebCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=56864

        These steps match the normal build.  After this patch, I believe the
        WebCore GYP build is complete.

        * WebCore.gypi:
        * gyp/WebCore.gyp:
        * gyp/copy-inspector-resources.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 22 Mar 2011 21:41:18 +0000 (21:41 +0000)]
2011-03-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Microsoft Silverlight playback shows artifacts
        https://bugs.webkit.org/show_bug.cgi?id=56863
        <rdar://problem/9103136>

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::paint):
        If the plug-in is transparent, clear the dirty rect before painting.

        * Shared/Plugins/Netscape/mac/NetscapePluginModuleMac.mm:
        (WebKit::NetscapePluginModule::determineQuirks):
        Add the MakeTransparentIfBackgroundAttributeExists quirk for Silverlight plug-ins.

        * Shared/Plugins/PluginQuirks.h:
        Add MakeTransparentIfBackgroundAttributeExists quirk.

        * WebProcess/Plugins/Netscape/NetscapeBrowserFuncs.cpp:
        (WebKit::NPN_SetValue):
        Handle NPPVpluginTransparentBool.

        * WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
        (WebKit::NetscapePlugin::NetscapePlugin):
        Initialize m_isTransparent to false.

        (WebKit::NetscapePlugin::setIsTransparent):
        Set m_isTransparent.

        (WebKit::NetscapePlugin::initialize):
        If the plug-in has the MakeTransparentIfBackgroundAttributeExists quirk, make it transparent
        if there's a 'background' attribute.

        (WebKit::NetscapePlugin::isTransparent):
        Add getter.

        * WebProcess/Plugins/Plugin.h:
        Add isTransparent().

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::paint):
        Always copy the plug-in backing store to the plug-in proxy backing store.

        (WebKit::PluginProxy::isTransparent):
        Add getter that should never be called.

        (WebKit::PluginProxy::update):
        Always copy the plug-in backing store to the plug-in proxy backing store.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=56856 RenderListBox needs to be
bdakin@apple.com [Tue, 22 Mar 2011 21:33:27 +0000 (21:33 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=56856 RenderListBox needs to be
added to Page::scrollableAreaSet()

Reviewed by Simon Fraser.

* rendering/RenderListBox.cpp:
(WebCore::RenderListBox::RenderListBox):
(WebCore::RenderListBox::~RenderListBox):
* rendering/RenderListBox.h:
(WebCore::RenderListBox::disconnectFromPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Tue, 22 Mar 2011 21:33:14 +0000 (21:33 +0000)]
2011-03-22  James Simonsen  <simonjam@chromium.org>

        [Chromium] Unreviewed, rebaseline chromium tests after r81684.

        * platform/chromium-linux/fast/block/lineboxcontain/block-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/block-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/block-font-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/block-font-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/block-replaced-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/font-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/font-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/font-replaced-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-box-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/none-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/none-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/replaced-expected.checksum: Added.
        * platform/chromium-linux/fast/block/lineboxcontain/replaced-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-font-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-font-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/block-replaced-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/font-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/font-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/font-replaced-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/glyphs-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/none-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/none-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/replaced-expected.checksum: Added.
        * platform/chromium-mac-leopard/fast/block/lineboxcontain/replaced-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-font-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-font-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-font-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/font-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/font-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/font-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-box-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/none-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/none-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/none-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/parsing-invalid-expected.txt: Added.
        * platform/chromium-win/fast/block/lineboxcontain/replaced-expected.checksum: Added.
        * platform/chromium-win/fast/block/lineboxcontain/replaced-expected.png: Added.
        * platform/chromium-win/fast/block/lineboxcontain/replaced-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 22 Mar 2011 21:32:58 +0000 (21:32 +0000)]
2011-03-22  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add high-quality band-limited audio resampling algorithm
        https://bugs.webkit.org/show_bug.cgi?id=56692

        No new tests since audio API is not yet implemented.

        * platform/audio/SincResampler.cpp: Added.
        (WebCore::SincResampler::SincResampler):
        (WebCore::SincResampler::initializeKernel):
        (WebCore::SincResampler::consumeSource):
        (WebCore::SincResampler::process):
        * platform/audio/SincResampler.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 22 Mar 2011 21:28:52 +0000 (21:28 +0000)]
2011-03-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add Profiling Configuration to JavaScriptCore gyp build
        https://bugs.webkit.org/show_bug.cgi?id=56862

        It appears this is identical to Release, but I suspect
        there is someone/thing who uses the Profiling target
        so we're adding it for completeness.

        * gyp/JavaScriptCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate computed style results.
hyatt@apple.com [Tue, 22 Mar 2011 21:17:57 +0000 (21:17 +0000)]
Update computed style results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate computed style results.
hyatt@apple.com [Tue, 22 Mar 2011 21:13:44 +0000 (21:13 +0000)]
Update computed style results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate computed style results.
hyatt@apple.com [Tue, 22 Mar 2011 21:12:31 +0000 (21:12 +0000)]
Update computed style results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate computed style results.
hyatt@apple.com [Tue, 22 Mar 2011 21:10:46 +0000 (21:10 +0000)]
Update computed style results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate computed style results.
hyatt@apple.com [Tue, 22 Mar 2011 21:10:35 +0000 (21:10 +0000)]
Update computed style results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 21:07:18 +0000 (21:07 +0000)]
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        WebCore GYP build should build without help from normal WebCore build
        https://bugs.webkit.org/show_bug.cgi?id=56860

        Before this patch, the WebCore GYP build wasn't generating the derived
        sources quite right because the ENABLE macros were not being
        communicated to the "Derived Sources" target.

        This patch also adds the "Copy Forwarding and ICU Headers" as well as
        the "Streamline Inspector Source" steps, which are present in the
        normal build.  Unlike the normal build, these steps occur in a new
        target, called "WebCore Support", which is less than aesthetically
        beautiful.  Hopefully we'll be able to move them into the WebCore
        target proper in the future, but that will likely require some GYP
        changes.

        This patch probably could have been broken down into a couple smaller
        patches, but that doesn't seem necessary.

        * WebCore.gypi:
            - This file appears to no longer exist.
        * gyp/WebCore.gyp:
        * gyp/copy-forwarding-and-icu-headers.sh: Added.
        * gyp/streamline-inspector-source.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 21:05:00 +0000 (21:05 +0000)]
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Remove os_win32_files variable from the GYP build
        https://bugs.webkit.org/show_bug.cgi?id=56804

        Now that our understanding of GYP is sufficiently advanced, we don't
        need os_win32_files any more.  (Turns out Eric was right, as he always
        is.)

        * JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 21:02:44 +0000 (21:02 +0000)]
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        GYP build of JavaScriptCore should be able to link from an empty WebKitBuild directory
        https://bugs.webkit.org/show_bug.cgi?id=56803

        Previously, we thought we should generate the derived source files in
        the shared intermediate build products directory, but there are
        assumptions built into other parts of the Mac build system that the
        derived source files will be generated in a particular subdirectory of
        the build products directory.

        This patch is a partial revert of the change that moved the derived
        source files to the shared intermediate directory.  After this patch,
        the GYP build can build JavaScriptCore without help from the main
        normal build system.

        * JavaScriptCore.gypi:
        * gyp/JavaScriptCore.gyp:
        * gyp/generate-derived-sources.sh:
        * gyp/generate-dtrace-header.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Matthew Delaney <mdelaney@apple.com>
mdelaney@apple.com [Tue, 22 Mar 2011 20:41:22 +0000 (20:41 +0000)]
2011-03-22  Matthew Delaney  <mdelaney@apple.com>

        Reviewed by Simon Fraser.

        Have WebKit push acceleratedDrawing preferences to settings
        https://bugs.webkit.org/show_bug.cgi?id=56792

        * WebView/WebView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=56859
hyatt@apple.com [Tue, 22 Mar 2011 20:18:41 +0000 (20:18 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56859

Reviewed by Simon Fraser.

Floats in the floating object list occur in the order that they are positioned. This means
that for a given vertical offset, the last left object in the list that intersects that offset
will be the rightmost float. There is no need to check any previous floats, since they have to be
further left than that rightmost float. The same rules hold true for right-aligned floats.

Change logicalLeft/RightOffsetForLine to iterate backwards instead of forwards and to stop the moment
they encounter a float that intersects the vertical range.

This cuts the maze solving time for a 20x20 maze in the IE MazeSolver test in half.

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::logicalLeftOffsetForLine):
(WebCore::RenderBlock::logicalRightOffsetForLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/56781> Add --dsym switch to enable dsym generation when building...
ddkilzer@apple.com [Tue, 22 Mar 2011 20:13:46 +0000 (20:13 +0000)]
<webkit.org/b/56781> Add --dsym switch to enable dsym generation when building with Xcode

Reviewed by Joseph Pecoraro.

* Scripts/build-webkit: Updated usage statement to include
--dsym.
* Scripts/webkitdirs.pm: Added $generateDsym variable.
(generateDsym): Added. Call determineGenerateDsym() and
return $generateDsym.
(determineGenerateDsym): Added.  Parse @ARGV for --dsym and set
$generateDsym.
(argumentsForXcode): Added.  Returns additional arguments for
xcodebuild based on command-line switches.
(XcodeOptions): Updated to include argumentsForXcode() in the
array returned.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Tue, 22 Mar 2011 19:21:39 +0000 (19:21 +0000)]
2011-03-22  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dirk Schulze.

        SVG displacement map should validate channel selections
        https://bugs.webkit.org/show_bug.cgi?id=56794

        * svg/filters/feDisplacementMap-crash-test-expected.txt: Added.
        * svg/filters/feDisplacementMap-crash-test.xhtml: Added.
2011-03-22  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Dirk Schulze.

        SVG displacement map should validate channel selections
        https://bugs.webkit.org/show_bug.cgi?id=56794

        Test: svg/filters/feDisplacementMap-crash-test.xhtml

        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::svgAttributeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix EFL bustage.
hyatt@apple.com [Tue, 22 Mar 2011 19:21:29 +0000 (19:21 +0000)]
Fix EFL bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Leopard build bustage.
hyatt@apple.com [Tue, 22 Mar 2011 19:18:39 +0000 (19:18 +0000)]
Fix Leopard build bustage.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Jay Civelli <jcivelli@chromium.org>
jcivelli@chromium.org [Tue, 22 Mar 2011 19:17:58 +0000 (19:17 +0000)]
2011-03-22  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Adding a contains method to Vector.
        https://bugs.webkit.org/show_bug.cgi?id=55859

        * wtf/Vector.h:
        (WTF::Vector::contains):
2011-03-22  Jay Civelli  <jcivelli@chromium.org>

        Reviewed by David Levin.

        Relanding:
        Moving the method that is used to retrieve all the resources in
        a page from the Chromium code (dom_operations.cc) to WebKit.
        https://bugs.webkit.org/show_bug.cgi?id=55859

        * WebKit.gyp:
        * public/WebPageSerializer.h:
        * public/WebURL.h:
        (WebKit::operator==):
        (WebKit::operator!=):
        * public/WebVector.h:
        (WebKit::WebVector::contains):
        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::WebDataSourceImpl):
        * src/WebPageSerializer.cpp:
        (WebCore::getSubResourceURLFromElement):
        (WebCore::retrieveResourcesForElement):
        (WebCore::retrieveResourcesForFrame):
        (WebKit::WebPageSerializer::retrieveAllResources):
        * tests/WebFrameTest.cpp:
        * tests/WebPageSerializerTest.cpp: Added.
        * tests/data/pageserialization/awesome.png: Added.
        * tests/data/pageserialization/embed_iframe.html: Added.
        * tests/data/pageserialization/object_iframe.html: Added.
        * tests/data/pageserialization/simple_iframe.html: Added.
        * tests/data/pageserialization/simple_page.html: Added.
        * tests/data/pageserialization/top_frame.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Huahui Wu <mediadependent@gmail.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 19:16:10 +0000 (19:16 +0000)]
2011-03-22  Huahui Wu  <mediadependent@gmail.com>

        Reviewed by Steve Block.

        [Android] Update PlatformTouchEvent for android so it can pass IDs and states around.
        https://bugs.webkit.org/show_bug.cgi?id=56763

        No new tests as no new functionality is exposed.

        * platform/PlatformTouchEvent.h:
        * platform/android/PlatformTouchEventAndroid.cpp:
        (WebCore::PlatformTouchEvent::PlatformTouchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSource/WebCore: Implement the CSS3 line-box-contain property. This property provides...
hyatt@apple.com [Tue, 22 Mar 2011 19:03:50 +0000 (19:03 +0000)]
Source/WebCore: Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
fit to the font size. You can ignore replaced elements, etc.

Reviewed by Simon Fraser.

Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
height based off the block's line-box-contain value.

GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.

RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.

Added new tests in fast/block/lineboxcontain

* GNUmakefile.am:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* css/CSSComputedStyleDeclaration.cpp:
(WebCore::createLineBoxContainValue):
(WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
* css/CSSLineBoxContainValue.cpp: Added.
(WebCore::CSSLineBoxContainValue::CSSLineBoxContainValue):
(WebCore::CSSLineBoxContainValue::cssText):
* css/CSSLineBoxContainValue.h: Added.
(WebCore::CSSLineBoxContainValue::create):
(WebCore::CSSLineBoxContainValue::value):
(WebCore::CSSLineBoxContainValue::isCSSLineBoxContainValue):
* css/CSSParser.cpp:
(WebCore::CSSParser::parseValue):
(WebCore::CSSParser::parseLineBoxContain):
* css/CSSParser.h:
* css/CSSPropertyNames.in:
* css/CSSStyleSelector.cpp:
(WebCore::CSSStyleSelector::applyProperty):
* css/CSSValue.h:
(WebCore::CSSValue::isCSSLineBoxContainValue):
* css/CSSValueKeywords.in:
* platform/graphics/Font.cpp:
(WebCore::Font::width):
* platform/graphics/Font.h:
(WebCore::GlyphOverflow::GlyphOverflow):
* platform/graphics/FontFastPath.cpp:
(WebCore::Font::floatWidthForSimpleText):
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::floatWidthForComplexText):
* platform/graphics/win/FontWin.cpp:
(WebCore::Font::floatWidthForComplexText):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeLogicalBoxHeights):
* rendering/InlineFlowBox.h:
* rendering/RenderBlock.h:
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::computeInlineDirectionPositionsForLine):
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderInline.cpp:
(WebCore::RenderInline::marginLeft):
(WebCore::RenderInline::marginRight):
(WebCore::RenderInline::marginTop):
(WebCore::RenderInline::marginBottom):
(WebCore::RenderInline::marginBefore):
(WebCore::RenderInline::marginAfter):
* rendering/RenderInline.h:
* rendering/RenderText.cpp:
(WebCore::RenderText::widthFromCache):
(WebCore::RenderText::width):
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::alignBoxesInBlockDirection):
(WebCore::setAscentAndDescent):
(WebCore::RootInlineBox::ascentAndDescentForBox):
(WebCore::RootInlineBox::verticalPositionForBox):
(WebCore::RootInlineBox::includeLeadingForBox):
(WebCore::RootInlineBox::includeFontForBox):
(WebCore::RootInlineBox::includeGlyphsForBox):
(WebCore::RootInlineBox::includeMarginForBox):
(WebCore::RootInlineBox::fitsToGlyphs):
(WebCore::RootInlineBox::includesRootLineBoxFontOrLeading):
* rendering/RootInlineBox.h:
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::diff):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::lineBoxContain):
(WebCore::InheritedFlags::setLineBoxContain):
(WebCore::InheritedFlags::initialLineBoxContain):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::StyleRareInheritedData):
(WebCore::StyleRareInheritedData::operator==):
* rendering/style/StyleRareInheritedData.h:

LayoutTests: https://bugs.webkit.org/show_bug.cgi?id=56388

Reviewed by Simon Fraser.

Implement the CSS3 line-box-contain property. This property provides authors with more control over spacing between lines. For example,
you can fix the height of lines and cause all line contents to be ignored. You can make lines fit to glyphs. You can ignore leading and
fit to the font size. You can ignore replaced elements, etc.

Refactor the code in computeLogicalBoxHeights into helper methods on RootInlineBox. verticalPositionForBox moved over to RootInlineBox
so that it could be called from RenderBlockLineLayout. ascentAndDescentForBox is the new method that computes the appropriate box
height based off the block's line-box-contain value.

GlyphOverflow can now have a computeBounds parameter set, in which case glyph bounds will be computed and stored in the overflow struct.

RenderInline no longer returns 0 margins in the block direction, since line-box-contain can size around the margin box.

* fast/block/lineboxcontain: Added.
* fast/block/lineboxcontain/block-font.html: Added.
* fast/block/lineboxcontain/block-glyphs-replaced.html: Added.
* fast/block/lineboxcontain/block-glyphs.html: Added.
* fast/block/lineboxcontain/block-replaced.html: Added.
* fast/block/lineboxcontain/block.html: Added.
* fast/block/lineboxcontain/font-replaced.html: Added.
* fast/block/lineboxcontain/font.html: Added.
* fast/block/lineboxcontain/glyphs.html: Added.
* fast/block/lineboxcontain/inline-box-replaced.html: Added.
* fast/block/lineboxcontain/inline-box-vertical.html: Added.
* fast/block/lineboxcontain/inline-box.html: Added.
* fast/block/lineboxcontain/inline-replaced.html: Added.
* fast/block/lineboxcontain/inline.html: Added.
* fast/block/lineboxcontain/none.html: Added.
* fast/block/lineboxcontain/replaced.html: Added.
* platform/mac/fast/block/lineboxcontain: Added.
* platform/mac/fast/block/lineboxcontain/block-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/block-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/block-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/block-font-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/block-font-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/block-font-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/block-glyphs-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/block-glyphs-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/block-glyphs-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/block-glyphs-replaced-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/block-replaced-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/block-replaced-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/block-replaced-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/font-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/font-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/font-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/font-replaced-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/font-replaced-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/font-replaced-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/glyphs-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/glyphs-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/glyphs-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/inline-box-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/inline-box-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/inline-box-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/inline-box-replaced-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/inline-box-vertical-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/inline-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/inline-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/inline-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/inline-replaced-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/inline-replaced-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/inline-replaced-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/none-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/none-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/none-expected.txt: Added.
* platform/mac/fast/block/lineboxcontain/replaced-expected.checksum: Added.
* platform/mac/fast/block/lineboxcontain/replaced-expected.png: Added.
* platform/mac/fast/block/lineboxcontain/replaced-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGoing to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com...
weinig@apple.com [Tue, 22 Mar 2011 19:03:23 +0000 (19:03 +0000)]
Going to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com, etc.)
<rdar://problem/9139245>

Reviewed by Adam Roben.

"Windows edition".

* win/lib/WebKitSystemInterface.lib:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Gabor Loki <loki@webkit.org>
loki@webkit.org [Tue, 22 Mar 2011 18:52:48 +0000 (18:52 +0000)]
2011-03-22  Gabor Loki  <loki@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Fix a bunch of typos in DFG.
        https://bugs.webkit.org/show_bug.cgi?id=56813

        * dfg/DFGByteCodeParser.cpp:
        (JSC::DFG::parse):
        * dfg/DFGGenerationInfo.h:
        (JSC::DFG::GenerationInfo::setSpilled):
        * dfg/DFGGraph.cpp:
        (JSC::DFG::Graph::dump):
        * dfg/DFGGraph.h:
        * dfg/DFGJITCodeGenerator.h:
        (JSC::DFG::JITCodeGenerator::setupStubArguments):
        * dfg/DFGJITCompiler.cpp:
        (JSC::DFG::JITCompiler::compileFunction):
        * dfg/DFGJITCompiler.h:
        * dfg/DFGNode.h:
        * dfg/DFGNonSpeculativeJIT.h:
        * dfg/DFGOperations.h:
        * dfg/DFGRegisterBank.h:
        (JSC::DFG::RegisterBank::allocate):
        * dfg/DFGScoreBoard.h:
        (JSC::DFG::ScoreBoard::~ScoreBoard):
        (JSC::DFG::ScoreBoard::allocate):
        * dfg/DFGSpeculativeJIT.cpp:
        (JSC::DFG::SpeculativeJIT::compile):
        * dfg/DFGSpeculativeJIT.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoGoing to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com...
weinig@apple.com [Tue, 22 Mar 2011 18:48:30 +0000 (18:48 +0000)]
Going to certain pages causes a download of "st.html" or "jsp.html" (news.yahoo.com, etc.)
<rdar://problem/9139245>

Reviewed by Brady Eidson.

* libWebKitSystemInterfaceLeopard.a:
* libWebKitSystemInterfaceSnowLeopard.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 22 Mar 2011 18:40:52 +0000 (18:40 +0000)]
2011-03-22  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Crash when calling PluginProxy::evaluate on a destroyed plug-in
        https://bugs.webkit.org/show_bug.cgi?id=56848
        <rdar://problem/9168975>

        Return early if the NPObject doesn't exist anymore.

        * WebProcess/Plugins/PluginProxy.cpp:
        (WebKit::PluginProxy::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)
weinig@apple.com [Tue, 22 Mar 2011 18:26:12 +0000 (18:26 +0000)]
WebKit2: Cannot make a selection past the end of the visible page (no autoscrolling)
<rdar://problem/8823874>
https://bugs.webkit.org/show_bug.cgi?id=56847

Reviewed by Adam Roben.

* Shared/mac/WebEventFactory.mm:
(WebKit::currentMouseButton):
(WebKit::mouseButtonForEvent):
Add mouse button for mouseEnter/Exit events. [NSEvent buttonNumber] doesn't seem to give the right result
for these events, but getting the currentMouseButton does work.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 17:33:42 +0000 (17:33 +0000)]
2011-03-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81664.
        http://trac.webkit.org/changeset/81664
        https://bugs.webkit.org/show_bug.cgi?id=56840

        Rolling out followups to 81653 with expectations. (Requested
        by pfeldman on #webkit).

        * platform/win/fast/forms/listbox-bidi-align-expected.checksum: Removed.
        * platform/win/fast/forms/listbox-bidi-align-expected.png: Removed.
        * platform/win/fast/forms/listbox-bidi-align-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Noel Gordon <noel.gordon@gmail.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 17:27:35 +0000 (17:27 +0000)]
2011-03-22  Noel Gordon  <noel.gordon@gmail.com>

        Reviewed by Tony Chang.

        [chromium] Remove Gears from Chromium WebKit
        https://bugs.webkit.org/show_bug.cgi?id=56808

        Gears has been removed from Chromium 12. Remove Gears drag drop support
        from WebKit. That work lead to http://webkit.org/b/25916, a proposal to
        add native file drag drop, and its subsequent standardization in HTML5.

        * public/WebBindings.h:
        * public/WebView.h:
        * src/WebBindings.cpp:
        (WebKit::getRangeImpl): FIXME note added.
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        (WebKit::WebViewImpl::dragTargetDragEnter):
        (WebKit::WebViewImpl::dragTargetDragLeave):
        (WebKit::WebViewImpl::dragTargetDrop):
        (WebKit::WebViewImpl::dragTargetDragEnterOrOver):
        * src/WebViewImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Sheriff Bot <webkit.review.bot@gmail.com>
pfeldman@chromium.org [Tue, 22 Mar 2011 17:09:07 +0000 (17:09 +0000)]
2011-03-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81653.
        http://trac.webkit.org/changeset/81653
        https://bugs.webkit.org/show_bug.cgi?id=56839

        Breaks fast/text/drawBidiText.html on Chromium. (Requested by
        pfeldman on #webkit).

        * fast/forms/listbox-bidi-align.html: Removed.
        * platform/mac/fast/forms/listbox-bidi-align-expected.checksum: Removed.
        * platform/mac/fast/forms/listbox-bidi-align-expected.png: Removed.
        * platform/mac/fast/forms/listbox-bidi-align-expected.txt: Removed.
2011-03-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81653.
        http://trac.webkit.org/changeset/81653
        https://bugs.webkit.org/show_bug.cgi?id=56839

        Breaks fast/text/drawBidiText.html on Chromium. (Requested by
        pfeldman on #webkit).

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintItemForeground):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 22 Mar 2011 16:59:31 +0000 (16:59 +0000)]
2011-03-22  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.

        * inspector/Inspector.json:
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/front-end/Database.js:
        (WebInspector.DatabaseDispatcher.prototype.addDatabase):
2011-03-22  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Rolling out 81657, 81654, 81651 for breaking tests on chromium.

        * inspector/protocol/database-agent-expected.txt: Removed.
        * inspector/protocol/database-agent.html: Removed.
        * platform/chromium/inspector/protocol/database-agent-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Tue, 22 Mar 2011 16:25:15 +0000 (16:25 +0000)]
2011-03-21  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION] scripts panel is broken when frontend is reopened.
        https://bugs.webkit.org/show_bug.cgi?id=56747

        Debugger should be enabled on front-end side to guarantee initialization sequence (resources come before scripts).

        * inspector/Inspector.json:
        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::showProfilesPanel):
        * inspector/InspectorAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::InspectorController):
        (WebCore::InspectorController::connectFrontend):
        (WebCore::InspectorController::showAndEnableDebugger):
        * inspector/InspectorController.h:
        * inspector/InspectorDebuggerAgent.cpp:
        (WebCore::InspectorDebuggerAgent::setFrontend):
        (WebCore::InspectorDebuggerAgent::clearFrontend):
        * inspector/InspectorDebuggerAgent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Jarkko Sakkinen <jarkko.j.sakkinen@gmail.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 16:21:06 +0000 (16:21 +0000)]
2011-03-22  Jarkko Sakkinen  <jarkko.j.sakkinen@gmail.com>

        Reviewed by Benjamin Poulain.

        [Qt] WebGL: renderbufferStorage() fails with internal format GL_RGBA4
        https://bugs.webkit.org/show_bug.cgi?id=56824

        On desktop OpenGL substitute in renderbufferStorage:
        - GL_DEPTH24_STENCIL8 for GL_DEPTH_STENCIL
        - GL_DEPTH_COMPONENT for GL_DEPTH_COMPONENT16
        - GL_RGBA for GL_RGBA4 and GL_RGBA565
        - GL_RGB for RGB5_A1.

        Tests: fast/canvas/webgl/uninitialized-test.html

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3D::renderbufferStorage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-16 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Tue, 22 Mar 2011 16:16:38 +0000 (16:16 +0000)]
2011-03-16  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Eric Seidel.

        Move volume slider positioning logic to a custom renderer.
        https://bugs.webkit.org/show_bug.cgi?id=56498

        No functional change, covered by existing tests.

        * html/shadow/MediaControls.cpp:
        (WebCore::MediaControls::updateVolumeSliderContainer): Removed positioning logic.
        * rendering/MediaControlElements.cpp:
        (WebCore::RenderMediaVolumeSliderContainer::RenderMediaVolumeSliderContainer): Added.
        (WebCore::RenderMediaVolumeSliderContainer::layout): Added.
        (WebCore::MediaControlVolumeSliderContainerElement::MediaControlVolumeSliderContainerElement): Removed storing of coordinates.
        (WebCore::MediaControlVolumeSliderContainerElement::createRenderer): Added.
        (WebCore::MediaControlVolumeSliderContainerElement::styleForElement): Removed setting of coordinates.
        * rendering/MediaControlElements.h: Changed corresponding decls.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Gyuyoung Kim <gyuyoung.kim@samsung.com>
gyuyoung.kim@samsung.com [Tue, 22 Mar 2011 16:03:37 +0000 (16:03 +0000)]
2011-03-22  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Reviewed by Antonio Gomes.

        [EFL] Change return values with better one in ewk_setting's functions
        https://bugs.webkit.org/show_bug.cgi?id=56819

        In ewk_settings_cache_directory_path_set_xxx, they return false value
        when soup is disabled. It is better to use EINA_SAFETY_ON_TRUE_RETURN_XXX.

        * ewk/ewk_settings.cpp:
        (ewk_settings_proxy_uri_get):
        (ewk_settings_cache_directory_path_set):
        (ewk_settings_cache_directory_path_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Andrew Wason <rectalogic@rectalogic.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 15:49:02 +0000 (15:49 +0000)]
2011-03-22  Andrew Wason  <rectalogic@rectalogic.com>

        Reviewed by Benjamin Poulain.

        [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
        https://bugs.webkit.org/show_bug.cgi?id=54138

        * platform/graphics/qt/GraphicsContext3DQt.cpp:
        (WebCore::GraphicsContext3DInternal::getViewportGLWidget):
         Check if we actually have a QWebPageClient before dereferencing it.
2011-03-22  Andrew Wason  <rectalogic@rectalogic.com>

        Reviewed by Benjamin Poulain.

        [Qt] QWebPage with WebGL content crashes when rendering if no QWebView parent
        https://bugs.webkit.org/show_bug.cgi?id=54138

        * tests/qwebpage/tst_qwebpage.cpp:
        (webGLScreenshotWithoutView):
        (tst_QWebPage::acceleratedWebGLScreenshotWithoutView):
        (tst_QWebPage::unacceleratedWebGLScreenshotWithoutView):
         Render a QWebPage (with and without accelerated compositing)
         with a WebGL context that has no owning view.  Shouldn't crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Gustavo Noronha Silva <gustavo.noronha@collabora.co.uk>
kov@webkit.org [Tue, 22 Mar 2011 14:57:25 +0000 (14:57 +0000)]
2011-03-22  Gustavo Noronha Silva  <gustavo.noronha@collabora.co.uk>

        Rubber-stamped by Xan Lopez.

        Applications that include WebKit headers fail to build when using strict warnings
        because the signature for webkit_application_cache_get_maximum_size is missing a
        'void' to make it explicit it takes no arguments.

        * webkit/webkitapplicationcache.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake Leopard Debug bots and Windows XP Debug (Tests) core builders
aroben@apple.com [Tue, 22 Mar 2011 14:37:23 +0000 (14:37 +0000)]
Make Leopard Debug bots and Windows XP Debug (Tests) core builders

These bots are consistently green again.

Fixes <http://webkit.org/b/56830> Leopard Debug bots and Windows XP Debug (Tests) should be
core builders

Rubber-stamped by Antti Koivisto.

* Scripts/webkitpy/common/net/buildbot/buildbot.py:
(BuildBot.__init__): Loosened the regexps for Leopard and Windows.

* Scripts/webkitpy/common/net/buildbot/buildbot_unittest.py:
(BuildBotTest.test_builder_name_regexps): Updated expectations.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows expected failure results after r81625
aroben@apple.com [Tue, 22 Mar 2011 14:11:05 +0000 (14:11 +0000)]
Add Windows expected failure results after r81625

The failure is tracked by <http://webkit.org/b/56829>.

* platform/win/fast/css/percentage-non-integer-expected.checksum: Added.
* platform/win/fast/css/percentage-non-integer-expected.png: Added.
* platform/win/fast/css/percentage-non-integer-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix new http tests added in r81635 on Windows
aroben@apple.com [Tue, 22 Mar 2011 14:07:57 +0000 (14:07 +0000)]
Fix new http tests added in r81635 on Windows

* http/tests/cache/post-redirect-get.php:
* http/tests/cache/post-with-cached-subresources.php:
* http/tests/cache/resources/post-image-to-verify.php:
Pull in portabilityLayer.php, which implements sys_get_temp_dir for PHP 4.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd Windows results for new test added in r81653
aroben@apple.com [Tue, 22 Mar 2011 13:52:04 +0000 (13:52 +0000)]
Add Windows results for new test added in r81653

Windows differs from Mac due to a different scrollbar width within the listboxes.

* platform/win/fast/forms/listbox-bidi-align-expected.checksum: Added.
* platform/win/fast/forms/listbox-bidi-align-expected.png: Added.
* platform/win/fast/forms/listbox-bidi-align-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 22 Mar 2011 13:50:39 +0000 (13:50 +0000)]
2011-03-22  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: document DOM domain types and protocol methods.
        https://bugs.webkit.org/show_bug.cgi?id=56807

        * inspector/InjectedScript.cpp:
        (WebCore::InjectedScript::wrapNode):
        * inspector/InjectedScript.h:
        * inspector/Inspector.json:
        * inspector/InspectorBrowserDebuggerAgent.cpp:
        (WebCore::InspectorBrowserDebuggerAgent::descriptionForDOMEvent):
        * inspector/InspectorDOMAgent.cpp:
        (WebCore::InspectorDOMAgent::removeNode):
        (WebCore::InspectorDOMAgent::setNodeValue):
        * inspector/InspectorDOMAgent.h:
        * inspector/front-end/ElementsTreeOutline.js:
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode.resolvedNode):
        (WebInspector.ElementsTreeElement.prototype._createTooltipForNode):
        * inspector/front-end/EventListenersSidebarPane.js:
        * inspector/front-end/PropertiesSidebarPane.js:
        (WebInspector.PropertiesSidebarPane.prototype.update.nodeResolved):
        * inspector/front-end/RemoteObject.js:
        (WebInspector.RemoteObject.resolveNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Windows results for new test added in r81652
aroben@apple.com [Tue, 22 Mar 2011 13:49:13 +0000 (13:49 +0000)]
Update Windows results for new test added in r81652

The checked-in results were trying to show that Windows would fail this test, but weren't
quite accurate. Even with these new results Windows still fails the test; the failure is
tracked by <http://webkit.org/b/56828>.

* platform/win/fast/forms/reset-autofilled-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] Update expectations.
ossy@webkit.org [Tue, 22 Mar 2011 13:32:59 +0000 (13:32 +0000)]
[Qt] Update expectations.

* platform/qt/Skipped:# Add fast/forms/input-autofilled.html because of missing layoutTestController.setAutofilled()
* platform/qt/css2.1/t09-c5526c-display-00-e-expected.checksum: Updated.
* platform/qt/css2.1/t09-c5526c-display-00-e-expected.png: Updated.
* platform/qt/css2.1/t09-c5526c-display-00-e-expected.txt: Updated.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoSkip a new test that relies on unimplemented LayoutTestController functionality in WTR
aroben@apple.com [Tue, 22 Mar 2011 13:02:32 +0000 (13:02 +0000)]
Skip a new test that relies on unimplemented LayoutTestController functionality in WTR

* platform/mac-wk2/Skipped: Added fast/forms/reset-autofilled.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Grzegorz Czajkowski <g.czajkowski@samsung.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 12:21:54 +0000 (12:21 +0000)]
2011-03-22  Grzegorz Czajkowski  <g.czajkowski@samsung.com>

        Reviewed by Kent Tamura.

        Add void to function without parameters
        https://bugs.webkit.org/show_bug.cgi?id=56821

        * ewk/ewk_cookies.cpp:
        (ewk_cookies_clear):
        (ewk_cookies_policy_get):
        * ewk/ewk_cookies.h:
        * ewk/ewk_private.h:
        * ewk/ewk_settings.cpp:
        (ewk_settings_web_database_default_quota_get):
        (ewk_settings_web_database_path_get):
        (ewk_settings_proxy_uri_get):
        (ewk_settings_default_user_agent_get):
        * ewk/ewk_settings.h:
        * ewk/ewk_view.cpp:
        (ewk_view_dpi_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Mar 2011 11:54:17 +0000 (11:54 +0000)]
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed update of database-agent test expectations.
        Empty line added at the end.

        * inspector/protocol/database-agent-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 22 Mar 2011 11:44:06 +0000 (11:44 +0000)]
2011-03-22  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, Skipped one test failing because of the same reason.

        [GTK] Some test results are one pixel different between the x86_64 and i386 bots
        https://bugs.webkit.org/show_bug.cgi?id=39022

        * platform/gtk/Skipped: Skip fast/css/percentage-non-integer.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 10:49:45 +0000 (10:49 +0000)]
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Production configuration in GYP isn&apos;t set up correctly
        https://bugs.webkit.org/show_bug.cgi?id=56786

        Update JavaScriptCore.gyp with information mined from
        JavaScriptCore.xcodeproj.

        * JavaScriptCore.gypi:
        * gyp/JavaScriptCore.gyp:
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Production configuration in GYP isn&apos;t set up correctly
        https://bugs.webkit.org/show_bug.cgi?id=56786

        Update JavaScriptGlue.gyp with information mined from
        JavaScriptGlue.xcodeproj.

        * gyp/JavaScriptGlue.gyp:
        * gyp/JavaScriptGlue.gypi:
2011-03-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Production configuration in GYP isn&apos;t set up correctly
        https://bugs.webkit.org/show_bug.cgi?id=56786

        Update WebCore.gyp with information mined from WebCore.xcodeproj.

        * WebCore.gypi:
        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Mar 2011 10:36:19 +0000 (10:36 +0000)]
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Unreviewed fix for database-agent test.

        * inspector/protocol/database-agent-expected.txt:
        * platform/chromium/inspector/protocol/database-agent-expected.txt: Copied from LayoutTests/inspector/protocol/database-agent-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ofri Wolfus <ofri@google.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 10:14:32 +0000 (10:14 +0000)]
2011-03-22  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        * fast/forms/listbox-bidi-align.html: Added.
        * platform/mac/fast/forms/listbox-bidi-align-expected.txt: Added.
2011-03-22  Ofri Wolfus  <ofri@google.com>

        Reviewed by Eric Seidel.

        RTL: Select elements with a size attribute are always left aligned.
        https://bugs.webkit.org/show_bug.cgi?id=50928

        Added support for alignment in RenderListBox.

        Test: fast/forms/listbox-bidi-align.html

        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::paintItemForeground): Add support for alignment and directionality.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Tue, 22 Mar 2011 09:48:43 +0000 (09:48 +0000)]
2011-03-22  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        Clear autofilled flag when reseting a form
        https://bugs.webkit.org/show_bug.cgi?id=56802

        * fast/forms/reset-autofilled-expected.txt: Added.
        * fast/forms/reset-autofilled.html: Added.
        * platform/chromium/fast/forms/reset-autofilled-expected.txt: Added.
        * platform/win/fast/forms/reset-autofilled-expected.txt: Added.
2011-03-22  Ilya Sherman  <isherman@chromium.org>

        Reviewed by Kent Tamura.

        Clear autofilled flag when reseting a form
        In service of https://code.google.com/p/chromium/issues/detail?id=70037
        https://bugs.webkit.org/show_bug.cgi?id=56802

        Test: fast/forms/reset-autofilled.html

        * html/HTMLInputElement.cpp:
        (WebCore::HTMLInputElement::reset): Clear the autofilled flag.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Mar 2011 09:42:24 +0000 (09:42 +0000)]
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol cleanup. DatabaseAgent.
        https://bugs.webkit.org/show_bug.cgi?id=56815

        see protocol metabug:
        - All events should use notification wording, not command wording:

        addDatabase was renamed to DatabaseOpened.

        * inspector/protocol/database-agent-expected.txt: Added.
        * inspector/protocol/database-agent.html: Added.
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol cleanup. DatabaseAgent.
        https://bugs.webkit.org/show_bug.cgi?id=56815

        see protocol metabug:
        - All events should use notification wording, not command wording:

        addDatabase was renamed to DatabaseOpened.

        Test: inspector/protocol/database-agent.html

        * inspector/Inspector.json:
        * inspector/InspectorDatabaseResource.cpp:
        (WebCore::InspectorDatabaseResource::bind):
        * inspector/front-end/Database.js:
        (WebInspector.DatabaseDispatcher.prototype.DatabaseOpened):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Ilya Tikhonovsky <loislo@chromium.org>
loislo@chromium.org [Tue, 22 Mar 2011 09:21:58 +0000 (09:21 +0000)]
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol cleanup. ConsoleAgent.
        https://bugs.webkit.org/show_bug.cgi?id=56806

        renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
        new method: disable()
        deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

        * inspector/protocol/console-agent-expected.txt:
        * inspector/protocol/console-agent.html:
2011-03-22  Ilya Tikhonovsky  <loislo@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: protocol cleanup. ConsoleAgent.
        https://bugs.webkit.org/show_bug.cgi?id=56806

        renamed method: void setConsoleMessagesEnabled(in boolean enabled, out boolean newState); => void enable(out long expiredMessagesCount);
        new method: disable()
        deleted method: [event] void consoleMessageExpiredCountUpdate(out unsigned long count); delete it. The counter will be transfered as out argument of enable command.

        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::updateRepeatCountInConsole):
        * inspector/Inspector.json:
        * inspector/InspectorConsoleAgent.cpp:
        (WebCore::InspectorConsoleAgent::enable):
        (WebCore::InspectorConsoleAgent::disable):
        * inspector/InspectorConsoleAgent.h:
        * inspector/front-end/ConsoleView.js:
        (WebInspector.ConsoleView.prototype._registerConsoleDomainDispatcher.dispatcher.consoleMessageRepeatCountUpdated):
        (WebInspector.ConsoleView.prototype.setConsoleMessageExpiredCount):
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-22 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 22 Mar 2011 07:43:21 +0000 (07:43 +0000)]
2011-03-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        REGRESSION(r80096): Number type input unexpectedly rounds fractional values
        https://bugs.webkit.org/show_bug.cgi?id=56367

        Introduce clampToInteger(unsigned).

        * wtf/MathExtras.h:
        (clampToInteger): Added.
2011-03-22  Kent Tamura  <tkent@chromium.org>

        Reviewed by Eric Seidel.

        REGRESSION(r80096): Number type input unexpectedly rounds fractional values
        https://bugs.webkit.org/show_bug.cgi?id=56367

        Because the default value of the maximum fractional digits of NSNumberFormatter
        and ICU NumberFormat is 3, the value 0.55555 is rounded to 0.556 in a
        localized representation. This bug affects only in Mac and Chromium.

        To fix this bug,
         - Add "maximum fractional digits" parameter to formatLocalizedNumber(), and
         - NumberInputType::visibleValue uses parseToDoubleForNumberTypeWithDecimalPlaces()
          instead of parseToDoubleForNumberType().

        No automated tests because the behavior is locale-dependent. This change
        updates a manual test.

        * html/NumberInputType.cpp:
        (WebCore::NumberInputType::visibleValue):
          Use parseToDoubleForNumberTypeWithDecimalPlaces() and passing fractional
          part length to formatLocalizedNumber().
        * manual-tests/input-number-localization.html:
          Update the test to cover this change.
        * platform/text/LocalizedNumber.h: Add a parameter to formatLocalizedNumber().
        * platform/text/LocalizedNumberICU.cpp:
        (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().
        * platform/text/LocalizedNumberNone.cpp:
        (WebCore::formatLocalizedNumber):
        * platform/text/mac/LocalizedNumberMac.mm:
        (WebCore::formatLocalizedNumber): Call setMaximumFractionalDigits().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 22 Mar 2011 06:27:50 +0000 (06:27 +0000)]
2011-03-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Anonymous blocks need isRenderBlock cast check. Also, need
        to allow display BOX for flexible boxes.
        https://bugs.webkit.org/show_bug.cgi?id=56709

        Test: accessibility/anchor-linked-anonymous-block-crash.html

        * rendering/RenderBlock.cpp:
        (WebCore::canMergeContiguousAnonymousBlocks): remove specific
        fix in r81088 which is no longer needed.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isAnonymousBlock): Add isRenderBlock cast
        check.
2011-03-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Tests that we do not crash when searching up the render tree
        for an anchor element in accessibility code.
        https://bugs.webkit.org/show_bug.cgi?id=56709

        * accessibility/anchor-linked-anonymous-block-crash-expected.txt: Added.
        * accessibility/anchor-linked-anonymous-block-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 05:39:44 +0000 (05:39 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        GYP build should not have include paths that point within the source tree
        https://bugs.webkit.org/show_bug.cgi?id=56788

        Turns out we don't need these include paths anymore now that we have
        header maps working properly.

        * gyp/JavaScriptCore.gyp:
            - Also, remove jsc.cpp from the excluded list because it's not part
              of the jsc_files variable instead of the javascriptcore_files
              variable.
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        GYP build should not have include paths that point within the source tree
        https://bugs.webkit.org/show_bug.cgi?id=56788

        Turns out we don't need these include paths anymore now that we have
        header maps working properly.

        * gyp/JavaScriptGlue.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81647 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 22 Mar 2011 05:24:50 +0000 (05:24 +0000)]
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: updating Chromium test expectataions.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81646 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>
pfeldman@chromium.org [Tue, 22 Mar 2011 05:21:22 +0000 (05:21 +0000)]
2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81597.
        http://trac.webkit.org/changeset/81597
        https://bugs.webkit.org/show_bug.cgi?id=56801

        Change results in lots of unexpected flaky on the dashboard.
        (Requested by pfeldman on #webkit).

        * Scripts/webkitpy/layout_tests/layout_package/test_runner.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Tue, 22 Mar 2011 04:59:37 +0000 (04:59 +0000)]
2011-03-21  Hayato Ito  <hayato@chromium.org>

        Reviewed by Ojan Vafai.

        Add the first reftest so that we can make sure that reftests won't cause
        any issues on all buildbots.
        This patch will also act as a sample reftest which a Wiki page will refer.

        https://bugs.webkit.org/show_bug.cgi?id=56450

        * fast/harness/font-weight-bold-expected.html: Added.
        * fast/harness/font-weight-bold.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81644 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Tue, 22 Mar 2011 04:32:26 +0000 (04:32 +0000)]
2011-03-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Tests that we do not crash when adjusting position for inline boxes.
        https://bugs.webkit.org/show_bug.cgi?id=56300

        * fast/inline/inline-box-adjust-position-crash-expected.txt: Added.
        * fast/inline/inline-box-adjust-position-crash.html: Added.
        * fast/inline/inline-box-adjust-position-crash2-expected.txt: Added.
        * fast/inline/inline-box-adjust-position-crash2.html: Added.
2011-03-21  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Eric Seidel.

        Revert small change made in r78846 of replacing move with positionLineBox
        in the adjusting position function for inline box.
        https://bugs.webkit.org/show_bug.cgi?id=56300

        The change in r78846 caused positioning line boxes during the step of adjusting
        position for inline box, thereby causing line boxes to be nuked. This happens as
        part of aligning boxes in block direction in RenderBlock::computeBlockDirectionPositionsForLine.
        Later on, we do the positioning of line boxes again later in that function. This
        causes use of removed inline box leading to crash. Also, it is unnecessary to do
        this twice.

        Tests: fast/inline/inline-box-adjust-position-crash.html
               fast/inline/inline-box-adjust-position-crash2.html

        * rendering/InlineBox.cpp:
        (WebCore::InlineBox::adjustPosition):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81643 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 22 Mar 2011 04:14:40 +0000 (04:14 +0000)]
2011-03-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] 1.3.13 release bump
        https://bugs.webkit.org/show_bug.cgi?id=56795

        Version bump for 1.3.13 and updated NEWS file with release notes.

        * configure.ac:

2011-03-21  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] 1.3.13 release bump
        https://bugs.webkit.org/show_bug.cgi?id=56795

        Version bump for 1.3.13 and updated NEWS file with release notes.

        * NEWS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Klein <adamk@chromium.org>
commit-queue@webkit.org [Tue, 22 Mar 2011 03:35:06 +0000 (03:35 +0000)]
2011-03-21  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Add URI resolution support to WorkerContext
        https://bugs.webkit.org/show_bug.cgi?id=55644

        Note that these tests do not run as part of new-run-webkit-tests,
        but rather in Chromium's ui_test. I've run them locally and confirmed
        they pass; a subsequent Chromium change will be submitted to run them
        on the Chromium build bots.

        * http/tests/filesystem/resources/fs-worker-common.js: Added.
        * http/tests/filesystem/resources/fs-worker-test-util.js: Added.
        Copied from fast/filesystem/resources for use by HTTP tests.
        * http/tests/filesystem/script-tests/resolve-uri.js:
        Updated to be used either in window or worker context.
        * http/tests/filesystem/workers/resolve-url-expected.txt: Added.
        * http/tests/filesystem/workers/resolve-url-sync-expected.txt: Added.
        * http/tests/filesystem/workers/resolve-url-sync.html: Added.
        * http/tests/filesystem/workers/resolve-url.html: Added.
        * http/tests/filesystem/workers/script-tests/TEMPLATE.html: Added.
        * http/tests/filesystem/workers/script-tests/resolve-url-sync.js: Added.
2011-03-21  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Add URI resolution support to WorkerContext
        https://bugs.webkit.org/show_bug.cgi?id=55644

        Tests: http/tests/filesystem/workers/resolve-url-sync.html
               http/tests/filesystem/workers/resolve-url.html

        * fileapi/LocalFileSystem.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        Add support for workers.
        * fileapi/LocalFileSystem.h:
        * workers/WorkerContext.cpp:
        (WebCore::WorkerContext::resolveLocalFileSystemURL):
        (WebCore::WorkerContext::resolveLocalFileSystemSyncURL):
        * workers/WorkerContext.h:
        * workers/WorkerContext.idl:
2011-03-21  Adam Klein  <adamk@chromium.org>

        Reviewed by David Levin.

        [fileapi] Add URI resolution support to WorkerContext
        https://bugs.webkit.org/show_bug.cgi?id=55644

        Pass "create" bool through to allow opening
        a filesystem without allowing creation.

        * src/LocalFileSystemChromium.cpp:
        (WebCore::LocalFileSystem::readFileSystem):
        (WebCore::LocalFileSystem::requestFileSystem):
        * src/WebWorkerBase.cpp:
        (WebKit::WebWorkerBase::openFileSystemForWorker):
        * src/WebWorkerBase.h:
        * src/WorkerFileSystemCallbacksBridge.cpp:
        (WebKit::WorkerFileSystemCallbacksBridge::postOpenFileSystemToMainThread):
        (WebKit::WorkerFileSystemCallbacksBridge::openFileSystemOnMainThread):
        * src/WorkerFileSystemCallbacksBridge.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81640 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 22 Mar 2011 03:28:03 +0000 (03:28 +0000)]
2011-03-21  David Levin  <levin@chromium.org>

        Reviewed by Adam Barth.

        XHR in Workers doesn't set the referrer correctly.
        https://bugs.webkit.org/show_bug.cgi?id=24683

        * http/tests/xmlhttprequest/workers/referer-expected.txt: Fixed expectations now that this works correctly.
        * http/tests/xmlhttprequest/workers/shared-worker-referer-expected.txt: Ditto.
2011-03-21  David Levin  <levin@chromium.org>

        Reviewed by Adam Barth.

        XHR in Workers doesn't set the referrer correctly.
        https://bugs.webkit.org/show_bug.cgi?id=24683

        Tests: http/tests/xmlhttprequest/workers/referer.html
               http/tests/xmlhttprequest/workers/shared-worker-referer.html

        * loader/DocumentThreadableLoader.cpp:
        (WebCore::DocumentThreadableLoader::loadResourceSynchronously): Fill in empty string for the outgoing referrer.
        (WebCore::DocumentThreadableLoader::create): Added the ability to set the outgoing referrer.
        (WebCore::DocumentThreadableLoader::DocumentThreadableLoader): Ditto.
        (WebCore::DocumentThreadableLoader::loadRequest): Ditto.
        * loader/DocumentThreadableLoader.h: Ditto.
        * loader/ResourceLoadScheduler.cpp:
        (WebCore::ResourceLoadScheduler::scheduleSubresourceLoad): Ditto.
        * loader/ResourceLoadScheduler.h: Ditto.
        * loader/SubresourceLoader.cpp:
        (WebCore::SubresourceLoader::create): Fixed bug (caught by the test) in last minute change done in previous check-in.
        * loader/WorkerThreadableLoader.cpp:
        (WebCore::WorkerThreadableLoader::WorkerThreadableLoader): Fill in the outgoing referrer.
        (WebCore::WorkerThreadableLoader::MainThreadBridge::MainThreadBridge): Plumbing for the outgoing referrer.
        (WebCore::WorkerThreadableLoader::MainThreadBridge::mainThreadCreateLoader): Plumbing for the outgoing referrer.
        * loader/WorkerThreadableLoader.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81639 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 03:15:43 +0000 (03:15 +0000)]
2011-03-21  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Antonio Gomes.

        [CMAKE] Add exception handling when PORT was missing.
        https://bugs.webkit.org/show_bug.cgi?id=56728

        * Source/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81638 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Ilya Sherman <isherman@chromium.org>
commit-queue@webkit.org [Tue, 22 Mar 2011 03:06:19 +0000 (03:06 +0000)]
2011-03-21  Ilya Sherman  <isherman@chromium.org>

        Reviewed by James Robinson.

        Remove WebInputElement::isEnabledFormControl() from Chromium WebKit API
        Clients should instead call into WebFormControlElement::isEnabled().
        https://bugs.webkit.org/show_bug.cgi?id=56364

        * public/WebInputElement.h: Removed isEnabledFormControl().
        * src/WebInputElement.cpp: Removed isEnabledFormControl().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Tue, 22 Mar 2011 02:35:43 +0000 (02:35 +0000)]
2011-03-21  James Simonsen  <simonjam@chromium.org>

        [Chromium] Unreviewed, rebaseline win/linux after r81625.

        * platform/chromium-linux/fast/css/percentage-non-integer-expected.checksum:
        * platform/chromium-linux/fast/css/percentage-non-integer-expected.png:
        * platform/chromium-linux/fast/css/percentage-non-integer-expected.txt: Copied from LayoutTests/platform/chromium-win/fast/css/percentage-non-integer-expected.txt.
        * platform/chromium-win/fast/css/percentage-non-integer-expected.checksum:
        * platform/chromium-win/fast/css/percentage-non-integer-expected.png:
        * platform/chromium-win/fast/css/percentage-non-integer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81636 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Tue, 22 Mar 2011 02:32:42 +0000 (02:32 +0000)]
2011-03-21  Nate Chapin  <japhet@chromium.org>

        Reviewed by Brady Eidson.

        Tests for https://bugs.webkit.org/show_bug.cgi?id=38690.

        * http/tests/cache/post-redirect-get-expected.txt: Added.
        * http/tests/cache/post-redirect-get.php: Added.
        * http/tests/cache/post-with-cached-subresources-expected.txt: Added.
        * http/tests/cache/post-with-cached-subresources.php: Added.
        * http/tests/cache/resources/post-image-to-verify.php: Added.
2011-03-21  Nate Chapin  <japhet@chromium.org>

        Reviewed by Brady Eidson.

        Do not check the DocumentLoader's request cache policy
        in determining whether we should force revalidation of a cached
        subresource. If the main resource received headers telling it not
        to cache, that policy will be propagated to subresources.

        The previous behavior is left in behind a flag in Settings, since
        QuickLook depends on it.

        https://bugs.webkit.org/show_bug.cgi?id=38690

        Tests: http/tests/cache/post-redirect-get.php
               http/tests/cache/post-with-cached-subresources.php

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::subresourceCachePolicy):
        (WebCore::FrameLoader::loadPostRequest):
        * page/Settings.cpp:
        (WebCore::Settings::Settings):
        * page/Settings.h:
        (WebCore::Settings::setUseQuickLookResourceCachingQuirks):
        (WebCore::Settings::useQuickLookResourceCachingQuirks):
2011-03-21  Nate Chapin  <japhet@chromium.org>

        Reviewed by Brady Eidson.

        Expose a preference to use caching quirks for QuickLook,
        and use it if the QuickLook framework is loaded.

        https://bugs.webkit.org/show_bug.cgi?id=38690

        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (useQuickLookQuirks):
        (+[WebPreferences initialize]):
        (-[WebPreferences useQuickLookResourceCachingQuirks]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebView _preferencesChangedNotification:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81635 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Tue, 22 Mar 2011 01:15:17 +0000 (01:15 +0000)]
2011-03-21  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        Remove dependency on default font from data-transfer-items.html
        https://bugs.webkit.org/show_bug.cgi?id=56791

        * editing/pasteboard/data-transfer-items-expected.txt:
        * editing/pasteboard/data-transfer-items.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Mac release builds after https://bugs.webkit.org/show_bug.cgi?id=56783
beidson@apple.com [Tue, 22 Mar 2011 00:58:41 +0000 (00:58 +0000)]
Fix Mac release builds after https://bugs.webkit.org/show_bug.cgi?id=56783

* Platform/mac/Logging.mac.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=56783
beidson@apple.com [Tue, 22 Mar 2011 00:47:05 +0000 (00:47 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=56783
Actually hook up WebKit2 logging on Mac.

Reviewed by Brian Weinstein.

* Platform/Logging.cpp:
(WebKit::initializeLogChannel):
* Platform/Logging.h:
* Platform/mac/Logging.mac.mm: Added.
(WebKit::initializeLogChannel):

       * UIProcess/WebContext.cpp:
(WebKit::WebContext::WebContext): Initialize logging if necessary.

* WebKit2.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Rik Cabanier <cabanier@gmail.com>
commit-queue@webkit.org [Tue, 22 Mar 2011 00:24:01 +0000 (00:24 +0000)]
2011-03-21  Rik Cabanier  <cabanier@gmail.com>

        Reviewed by James Robinson.

        bug 56052: percentages are incorrectly rounded in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=56052

        * platform/mac/fast/css/percentage-non-integer-expected.txt:
2011-03-21  Rik Cabanier  <cabanier@adobe.com>

        Reviewed by James Robinson.

        bug 56052: percentages are incorrectly rounded in WebKit
        https://bugs.webkit.org/show_bug.cgi?id=56052

        test: fast/css/percentage-non-integer.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        * page/PrintContext.cpp:
        (WebCore::PrintContext::pageProperty):
        * platform/Length.h:
        (WebCore::Length::Length):
        (WebCore::Length::operator*=):
        (WebCore::Length::value):
        (WebCore::Length::percent):
        (WebCore::Length::setValue):
        (WebCore::Length::calcValue):
        (WebCore::Length::calcMinValue):
        (WebCore::Length::isUndefined):
        (WebCore::Length::isZero):
        (WebCore::Length::isPositive):
        (WebCore::Length::isNegative):
        * rendering/AutoTableLayout.cpp:
        (WebCore::AutoTableLayout::recalcColumn):
        (WebCore::AutoTableLayout::computePreferredLogicalWidths):
        (WebCore::AutoTableLayout::calcEffectiveLogicalWidth):
        (WebCore::AutoTableLayout::layout):
        * rendering/FixedTableLayout.cpp:
        (WebCore::FixedTableLayout::calcWidthArray):
        (WebCore::FixedTableLayout::layout):
        * rendering/RenderTableSection.cpp:
        (WebCore::RenderTableSection::addCell):
        (WebCore::RenderTableSection::layoutRows):
        * rendering/style/BorderData.h:
        (WebCore::BorderData::hasBorderRadius):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81625 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 00:16:41 +0000 (00:16 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Solve the Assertions.cpp / -Wno-missing-format-attribute mystery
        https://bugs.webkit.org/show_bug.cgi?id=56780

        The reason we couldn't resolve this warning in the GYP build was that
        the normal build disables this warning specifically for this file.
        This patch takes the same approach as the previous patch to
        WebCoreObjCExtras.mm in that it uses a pragma to suppress the warning
        (rather than a build system configuration).

        * JavaScriptCore.xcodeproj/project.pbxproj:
            - Remove the special-case for this file.
        * gyp/JavaScriptCore.gyp:
            - Remove the work-around for this issue.
        * wtf/Assertions.cpp:
            - Add a pragma disabling this warning for this file.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 00:14:21 +0000 (00:14 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add WebCoreExportFileGenerator to WebCore GYP build
        https://bugs.webkit.org/show_bug.cgi?id=56778

        This target mirrors the eponymous target from WebCore.xcodeproj.

        * WebCore.gypi:
        * gyp/WebCore.gyp:
        * generate-webcore-export-file-generator.sh: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 22 Mar 2011 00:11:47 +0000 (00:11 +0000)]
    Reviewed by Darin Adler.

        REGRESSION (r81269): WebKit2 gets into an infinite recursion after an unhandled command key
        https://bugs.webkit.org/show_bug.cgi?id=56782
        <rdar://problem/9151993>

        * UIProcess/API/mac/PageClientImpl.mm: (WebKit::PageClientImpl::doneWithKeyEvent):
        Factored out code for resending an event and moved it to WKView.

        * UIProcess/API/mac/WKView.mm:
        (-[WKView performKeyEquivalent:]): Don't zero out _keyDownEventBeingResent, it's easier
        to just do that in _resendKeyDownEvent:.
        (-[WKView keyDown:]): Ditto.
        (-[WKView _resendKeyDownEvent:]): Moved from PageClientImpl.mm. Added an assertion that we
        are not already resending an event - it would be too confusing if we ever had to do that,
        but looks like this never happens.

        * UIProcess/API/mac/WKViewInternal.h: Exposed _resendKeyDownEvent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 22 Mar 2011 00:11:44 +0000 (00:11 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        WebCore GYP build shouldn't crash on startup
        https://bugs.webkit.org/show_bug.cgi?id=56776

        Debug builds shouldn't define NDEBUG.  This same logic exists in the
        project.pbxproj file.

        * gyp/JavaScriptCore.gyp:
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        WebCore GYP build shouldn&apos;t crash on startup
        https://bugs.webkit.org/show_bug.cgi?id=56776

        Debug builds shouldn't define NDEBUG.  This same logic exists in the
        project.pbxproj file.

        * gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Daniel Cheng <dcheng@chromium.org>
dcheng@chromium.org [Tue, 22 Mar 2011 00:03:12 +0000 (00:03 +0000)]
2011-03-21  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Implement glue between DataTransferItems and the pasteboard.
        https://bugs.webkit.org/show_bug.cgi?id=56330

        Update the layout test to take into account that the actual contents of the clipboard
        are exposed in a paste via DataTransferItems now.
        Also fix the flakiness in the layout test.

        * editing/pasteboard/data-transfer-items-expected.txt:
        * editing/pasteboard/data-transfer-items.html:
        * platform/chromium/test_expectations.txt:
2011-03-21  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Implement glue between DataTransferItems and the pasteboard.
        https://bugs.webkit.org/show_bug.cgi?id=56330

        Support retrieving clipboard data in a paste through DataTransferItems.

        Test: editing/pasteboard/data-transfer-items.html

        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::items):
        * platform/chromium/DataTransferItemChromium.cpp:
        (WebCore::DataTransferItemChromium::createFromPasteboard):
        (WebCore::DataTransferItemChromium::create):
        (WebCore::DataTransferItemChromium::DataTransferItemChromium):
        (WebCore::DataTransferItemChromium::getAsString):
        * platform/chromium/DataTransferItemChromium.h:
        * platform/chromium/DataTransferItemsChromium.cpp:
        (WebCore::DataTransferItemsChromium::addPasteboardItem):
        * platform/chromium/DataTransferItemsChromium.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: showContextMenu not working in WK2
cfleizach@apple.com [Mon, 21 Mar 2011 23:34:31 +0000 (23:34 +0000)]
AX: showContextMenu not working in WK2
https://bugs.webkit.org/show_bug.cgi?id=56734

Reviewed by Darin Adler.

../WebCore:

WebKit2 is not able to directly open a context menu because the UI is in the other process.
Instead the chrome client should be used. This also means implementing showContextMenu() in WebKit1
code.

* accessibility/mac/AccessibilityObjectWrapper.mm:
(-[AccessibilityObjectWrapper accessibilityShowContextMenu]):

../WebKit/mac:

Implement showContextMenu() so accessibility related code can call this
independent of whether WK1 or WK2 is running.

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::showContextMenu):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81619 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Robert Kroeger <rjkroege@chromium.org>
commit-queue@webkit.org [Mon, 21 Mar 2011 23:19:13 +0000 (23:19 +0000)]
2011-03-21  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by Antonio Gomes.

        Flag to enable/disable a GestureReocognizer framework

        https://bugs.webkit.org/show_bug.cgi?id=49345

        * wtf/Platform.h:
2011-03-21  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by Antonio Gomes.

        Add Support to WebCore to optionally call a platform-specific gesture recognizer
        https://bugs.webkit.org/show_bug.cgi?id=49345

        Added an ability for the EventHandler to invoke an optional platform
        specific gesture recognizer.

        No tests added because the change should be functionally invisible.

        * WebCore.gypi:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::EventHandler):
        (WebCore::EventHandler::handleTouchEvent):
        * page/EventHandler.h:
        * platform/PlatformGestureRecognizer.cpp: Added.
        (WebCore::PlatformGestureRecognizer::PlatformGestureRecognizer):
        (WebCore::PlatformGestureRecognizer::~PlatformGestureRecognizer):
        (WebCore::PlatformGestureRecognizer::create):
        * platform/PlatformGestureRecognizer.h: Added.
2011-03-21  Robert Kroeger  <rjkroege@chromium.org>

        Reviewed by Antonio Gomes.

        Flag to enable a platform specific GestureReocognizer framework in Chromium.

        https://bugs.webkit.org/show_bug.cgi?id=49345

        * features.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81618 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 21 Mar 2011 23:11:21 +0000 (23:11 +0000)]
2011-03-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        QT plug-in fails to load contextual menu
        https://bugs.webkit.org/show_bug.cgi?id=56777
        <rdar://problem/8979033>

        Open a Carbon resource map and make it the current map when calling NP_Initialize.

        * Platform/Module.cpp:
        (WebKit::Module::Module):
        Initialize m_bundleResourceMap to -1.

        * Platform/Module.h:
        Add m_bundleResourceMap.

        * Platform/mac/ModuleMac.mm:
        (WebKit::Module::unload):
        Close the resource map.

        (WebKit::Module::bundleResourceMap):
        Open a resource map if necessary.

        * Shared/Plugins/Netscape/NetscapePluginModule.cpp:
        (WebKit::NetscapePluginModule::tryLoad):
        Get the resource map and make it current before calling NP_Initialize.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81617 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 21 Mar 2011 22:56:12 +0000 (22:56 +0000)]
2011-03-21  Anders Carlsson  <andersca@apple.com>

        Reviewed by Sam Weinig.

        Plug-in process crashes if it fails to load a plug-in module
        https://bugs.webkit.org/show_bug.cgi?id=56775

        * PluginProcess/PluginControllerProxy.cpp:
        (WebKit::PluginControllerProxy::initialize):
        If NetscapePlugin::create returns null, call removePluginControllerProxy with a null plug-in.

        * PluginProcess/WebProcessConnection.cpp:
        (WebKit::WebProcessConnection::removePluginControllerProxy):
        Remove an incorrect assertion. Don't invalidate the remote object map if the plug-in is null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 21 Mar 2011 22:17:04 +0000 (22:17 +0000)]
2011-03-21  Tony Chang  <tony@chromium.org>

        Reviewed by Pavel Feldman.

        [chromium] remove devtools_html's dependency on WebKit.gypi
        https://bugs.webkit.org/show_bug.cgi?id=56661

        We want to depend on the values in the gypi file, not the gypi file
        itself.  Actually, if someone edits a gypi file, s/he should re-run
        gyp to pick up the new dependencies.

        It turns out that this doesn't matter much for this target anymore
        since we pull the .js dependencies from the inspector html file.

        * WebKit.gyp: cleanup dependencies
        * scripts/generate_devtools_html.py: remove unused param

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Dean Jackson <dino@apple.com>
dino@apple.com [Mon, 21 Mar 2011 22:05:11 +0000 (22:05 +0000)]
2011-03-21  Dean Jackson  <dino@apple.com>

        Reviewed by Chris Marrin and Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=56325
        ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

        AnimationBase had a custom linked-list/self-pointer for keeping
        track of animations that needed to be notified of style updates
        and start progress. This caused problems when AnimationBase was
        destroyed, since the pointer wasn't managed in any way. I replaced
        these pointers with HashSets and moved the code that removes animations
        from the sets into AnimationControllerPrivate, where it belongs.
        CompositeAnimation is also more careful to tell AnimationControllerPrivate
        when it no longer needs to keep track of waiting animations.

        This should stop the style updates being called on non-active animations
        (which was the cause of the state machine error here) and should also
        stop a few of the related flakey test failures and occasional crashes.

        Test: animations/body-removal-crash.html

        * page/animation/AnimationBase.cpp:
        (WebCore::AnimationBase::AnimationBase):
        (WebCore::AnimationBase::updateStateMachine):
        * page/animation/AnimationBase.h:
        (WebCore::AnimationBase::~AnimationBase):
        - Remove the linked-list
        * page/animation/AnimationController.cpp:
        (WebCore::AnimationControllerPrivate::AnimationControllerPrivate):
        (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStyle):
        (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStyle):
        (WebCore::AnimationControllerPrivate::styleAvailable):
        (WebCore::AnimationControllerPrivate::addToAnimationsWaitingForStartTimeResponse):
        (WebCore::AnimationControllerPrivate::removeFromAnimationsWaitingForStartTimeResponse):
        (WebCore::AnimationControllerPrivate::startTimeResponse):
        (WebCore::AnimationControllerPrivate::animationWillBeRemoved):
        - New method to remove animations from the waiting lists
        * page/animation/AnimationControllerPrivate.h:
        - use a HashSet rather than an AnimationBase* pointer.
        * page/animation/CompositeAnimation.cpp:
        (WebCore::CompositeAnimation::~CompositeAnimation):
        (WebCore::CompositeAnimation::clearRenderer):
        (WebCore::CompositeAnimation::updateTransitions):
        (WebCore::CompositeAnimation::updateKeyframeAnimations):
        - remove the animations and transitions from the lists when we know
          they are no longer active (rather than waiting for the AnimationBase
          to do it when destructing)

2011-03-21  Dean Jackson  <dino@apple.com>

        Reviewed by Chris Marrin and Simon Fraser.

        https://bugs.webkit.org/show_bug.cgi?id=56325
        ASSERTION FAILED: paused() in AnimationBase::updateStateMachine()

        Add a test that triggers the assertion by removing the <body>
        element and re-inserting it.

        While not directly related to this bug, the
        transform-origin-vs-functions test would occasionally fail because it
        depended on the order of events being fired. The update to the way
        animations are keeping their state triggered this more often. Now the
        output is sorted before finishing the test.

        * animations/3d/transform-origin-vs-functions.html:
        * animations/body-removal-crash.html: Added.
        * platform/mac/animations/body-removal-crash-expected.checksum: Added.
        * platform/mac/animations/body-removal-crash-expected.png: Added.
        * platform/mac/animations/body-removal-crash-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 James Simonsen <simonjam@chromium.org>
simonjam@chromium.org [Mon, 21 Mar 2011 21:58:01 +0000 (21:58 +0000)]
2011-03-21  James Simonsen  <simonjam@chromium.org>

        [Chromium] Unreviewed, add flaky and failing tests after r81597.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Mon, 21 Mar 2011 21:51:41 +0000 (21:51 +0000)]
2011-03-21  Justin Schuh  <jschuh@chromium.org>

        Reviewed by James Robinson.

        Stop inserting when the parent is removed
        https://bugs.webkit.org/show_bug.cgi?id=56690

        * fast/dom/insertedIntoDocument-child-expected.txt: Added.
        * fast/dom/insertedIntoDocument-child.html: Added.
        * fast/dom/insertedIntoDocument-iframe-expected.txt: Added.
        * fast/dom/insertedIntoDocument-iframe.html: Added.
        * fast/dom/insertedIntoDocument-sibling-expected.txt: Added.
        * fast/dom/insertedIntoDocument-sibling.html: Added.
2011-03-21  Justin Schuh  <jschuh@chromium.org>

        Reviewed by James Robinson.

        Stop inserting when the parent is removed
        https://bugs.webkit.org/show_bug.cgi?id=56690

        Tests: fast/dom/insertedIntoDocument-child.html
               fast/dom/insertedIntoDocument-iframe.html
               fast/dom/insertedIntoDocument-sibling.html

        * dom/ContainerNode.cpp:
        (WebCore::ContainerNode::insertedIntoDocument):
        * html/HTMLEmbedElement.cpp:
        (WebCore::HTMLEmbedElement::insertedIntoDocument):
        * html/HTMLObjectElement.cpp:
        (WebCore::HTMLObjectElement::insertedIntoDocument):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 21 Mar 2011 21:44:33 +0000 (21:44 +0000)]
2011-03-21  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        Add new files to JavaScriptCore.gypi
        https://bugs.webkit.org/show_bug.cgi?id=56766

        * JavaScriptCore.gypi:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Mon, 21 Mar 2011 21:41:04 +0000 (21:41 +0000)]
2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81377.
        http://trac.webkit.org/changeset/81377
        https://bugs.webkit.org/show_bug.cgi?id=56765

        WebPageSerializerTest.MultipleFrames is broken (Requested by
        simonjam on #webkit).

        * wtf/Vector.h:
2011-03-21  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r81377.
        http://trac.webkit.org/changeset/81377
        https://bugs.webkit.org/show_bug.cgi?id=56765

        WebPageSerializerTest.MultipleFrames is broken (Requested by
        simonjam on #webkit).

        * WebKit.gyp:
        * public/WebPageSerializer.h:
        * public/WebURL.h:
        * public/WebVector.h:
        (WebKit::WebVector::operator[]):
        * src/WebDataSourceImpl.cpp:
        (WebKit::WebDataSourceImpl::WebDataSourceImpl):
        * src/WebPageSerializer.cpp:
        * tests/WebFrameTest.cpp:
        * tests/WebPageSerializerTest.cpp: Removed.
        * tests/data/pageserialization/awesome.png: Removed.
        * tests/data/pageserialization/embed_iframe.html: Removed.
        * tests/data/pageserialization/object_iframe.html: Removed.
        * tests/data/pageserialization/simple_iframe.html: Removed.
        * tests/data/pageserialization/simple_page.html: Removed.
        * tests/data/pageserialization/top_frame.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 21 Mar 2011 21:39:39 +0000 (21:39 +0000)]
2011-03-21  Tony Chang  <tony@chromium.org>

        Reviewed by Eric Seidel.

        Convert fake-drag into a dumpAsText test and remove 1s timeout
        https://bugs.webkit.org/show_bug.cgi?id=56674

        This test was added with eventSender, so there was no leapForward
        at the time.  Also convert to dumpAsText while I'm here.

        * editing/selection/fake-drag.html:
        * platform/chromium-linux/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/chromium-linux/editing/selection/fake-drag-expected.png: Removed.
        * platform/chromium-win/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/chromium-win/editing/selection/fake-drag-expected.png: Removed.
        * platform/chromium-win/editing/selection/fake-drag-expected.txt:
        * platform/gtk/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/gtk/editing/selection/fake-drag-expected.png: Removed.
        * platform/gtk/editing/selection/fake-drag-expected.txt: Removed.
        * platform/mac-leopard/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/mac-leopard/editing/selection/fake-drag-expected.png: Removed.
        * platform/mac/editing/selection/fake-drag-expected.checksum: Removed.
        * platform/mac/editing/selection/fake-drag-expected.png: Removed.
        * platform/mac/editing/selection/fake-drag-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2011-03-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 21 Mar 2011 21:19:59 +0000 (21:19 +0000)]
2011-03-21  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: skipping new inspector test on GTK unless harness is fixed.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@81607 268f45cc-cd09-0410-ab3c-d52691b4dbfc