WebKit-https.git
9 years agoModify ASSERT_UNUSED and UNUSED_PARAM similar to Qt's Q_UNUSED.
ossy@webkit.org [Tue, 31 Aug 2010 16:23:04 +0000 (16:23 +0000)]
Modify ASSERT_UNUSED and UNUSED_PARAM similar to Qt's Q_UNUSED.
https://bugs.webkit.org/show_bug.cgi?id=44870

Reviewed by Darin Adler.

* wtf/Assertions.h:
* wtf/UnusedParam.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Gyuyoung Kim <gyuyoung.kim@samsung.com>
commit-queue@webkit.org [Tue, 31 Aug 2010 15:58:47 +0000 (15:58 +0000)]
2010-08-31  Gyuyoung Kim  <gyuyoung.kim@samsung.com>

        Unreviewed build fix.

        [EFL] Build break for r66456
        https://bugs.webkit.org/post_bug.cgi

        Replace firstRectsForMarkers with renderedRectsForMarkers.

        * ewk/ewk_frame.cpp:
        (ewk_frame_text_matches_nth_pos_get):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 31 Aug 2010 15:55:27 +0000 (15:55 +0000)]
2010-08-31  Philippe Normand  <pnormand@igalia.com>

        Unreviewed, unskip fixed test for the GTK port.

        media/video-loop.html fails intermittently on GTK and Chromium bots
        https://bugs.webkit.org/show_bug.cgi?id=33671

        * platform/gtk/Skipped: Unskip media/video-loop.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago Reviewed by Darin Adler.
ap@apple.com [Tue, 31 Aug 2010 15:49:18 +0000 (15:49 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=36515
        CSS style definitions are ignored if they just follow a "@charset" which appears in lines
        other than the first line in stylesheet.

        Test: fast/css/misplaced-charset.html

        * css/CSSGrammar.y: Ignore a misplaced charset rule without consuming extra characters and
        thus breaking subsequent rules.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Tue, 31 Aug 2010 15:43:02 +0000 (15:43 +0000)]
2010-08-31  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Antonio Gomes.

        [CMake] Add IF (ENABLE_MATHML) around MathML sources
        https://bugs.webkit.org/show_bug.cgi?id=44927

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66485 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Patrick Gansterer <paroga@paroga.com>
commit-queue@webkit.org [Tue, 31 Aug 2010 14:59:36 +0000 (14:59 +0000)]
2010-08-31  Patrick Gansterer  <paroga@paroga.com>

        Reviewed by Kenneth Rohde Christiansen.

        [CMake] Unify GENERATE_DOM_NAMES code
        https://bugs.webkit.org/show_bug.cgi?id=44842

        * CMakeLists.txt: Added property svn:eol-style.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Daniel Cheng <dcheng@chromium.org>
commit-queue@webkit.org [Tue, 31 Aug 2010 14:38:51 +0000 (14:38 +0000)]
2010-08-31  Daniel Cheng  <dcheng@chromium.org>

        Reviewed by Tony Chang.

        [chromium] Add an interface for platform copy/paste drag/drop data objects
        https://bugs.webkit.org/show_bug.cgi?id=44914

        Currently, Chromium only supports a few hardcoded data types in
        event.dataTransfer. This is the first of several patches to add support
        for arbitrary data types.

        No new tests.

        * WebCore.gypi:
        * platform/chromium/ChromiumDataObjectNew.h: Added.
        * platform/chromium/ClipboardChromium.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 31 Aug 2010 14:22:00 +0000 (14:22 +0000)]
2010-08-31  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Update in-test expectations to account for HTML5 parsing changes
        https://bugs.webkit.org/show_bug.cgi?id=44889

        We've already updated the -expected.txt files for these tests to
        account for the behavior changes with the HTML5 parser.  This patch
        updates the redundant "in-test" expectations so that the results say
        "PASS" instead of "FAIL".

        * fast/forms/datalist-nonoption-child.html:
        * fast/forms/state-restore-to-non-edited-controls-expected.txt:
        * fast/forms/state-restore-to-non-edited-controls.html:
        * fast/parser/fragment-parser-expected.txt:
        * fast/parser/residual-style-close-across-n-blocks-expected.txt:
        * fast/parser/residual-style-close-across-n-blocks.html:
        * fast/parser/script-tests/fragment-parser.js:
        * http/tests/misc/isindex-formdata-expected.txt:
        * http/tests/misc/isindex-formdata.html:
        * http/tests/misc/isindex-with-no-form-base-href-expected.txt:
        * http/tests/misc/resources/isindex-with-no-form-base-href.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Tue, 31 Aug 2010 14:06:08 +0000 (14:06 +0000)]
2010-08-31  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Tony Chang.

        Remove passing tests from Chromium's test_expectations.txt
        https://bugs.webkit.org/show_bug.cgi?id=44906

        Remove test expectations from Chromium's test_expectations.txt that are
        incorrect (the tests now pass).

        fast/events/special-key-events-in-input-text.html
            fixed by http://crrev.com/57503

        fast/events/tabindex-focus-chain.html
            fixed by http://trac.webkit.org/changeset/66311

        fast/forms/tabs-with-modifiers.html
            fixed by http://trac.webkit.org/changeset/65748

        editing/selection/drag-in-iframe.html
            fixed by http://trac.webkit.org/changeset/66269/ (appeared twice in
            the file)

        * platform/chromium/drt_expectations.txt:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 31 Aug 2010 13:49:20 +0000 (13:49 +0000)]
2010-08-31  Andrey Kosyakov  <caseq@chromium.org>

        Unreviewed. Attempt to fix flakiness of inspector extensions API audits tests on Qt.
        Synchronize last output() with signalling test completion.

        * inspector/resources/extension-main.html:
        * inspector/resources/extension-main.js:
        (onTestsDone):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 31 Aug 2010 13:26:06 +0000 (13:26 +0000)]
2010-08-31  Philippe Normand  <pnormand@igalia.com>

        Rubber-stamped by Xan Lopez.

        fast/parser/xml-declaration-missing-ending-mark.html crashed on Gtk bot
        https://bugs.webkit.org/show_bug.cgi?id=33027

        * platform/gtk/Skipped: Unskip now passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Tue, 31 Aug 2010 12:57:44 +0000 (12:57 +0000)]
2010-08-31  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        JSC TimeoutChecker::didTimeOut overflows on ARM
        https://bugs.webkit.org/show_bug.cgi?id=38538

        Re-enabled the test that was skipped for Maemo 5.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::infiniteLoopJS):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Andrey Kosyakov <caseq@chromium.org>
caseq@chromium.org [Tue, 31 Aug 2010 12:38:51 +0000 (12:38 +0000)]
2010-08-30  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add audits support to extension API
        Exposed (late) adding of categories from AuditPanel.
        Removed indexOfObjectInListSortedByFunction in favor of
        insertionIndexForObjectInListSortedByFunction (the former had
        weird interface always returning negative numbers and was only used in
        the latter).
        https://bugs.webkit.org/show_bug.cgi?id=44518

        Tests: inspector/extensions-audits-api.html
               inspector/extensions-audits.html

        * WebCore.gypi:
        * WebCore.vcproj/WebCore.vcproj:
        * inspector/front-end/AuditFormatters.js: Added.
        (WebInspector.applyFormatters):
        (WebInspector.AuditFormatters.text):
        (WebInspector.AuditFormatters.snippet):
        (WebInspector.AuditFormatters.concat):
        (WebInspector.AuditFormatters.url):
        * inspector/front-end/AuditLauncherView.js:
        (WebInspector.AuditLauncherView):
        (WebInspector.AuditLauncherView.prototype.addCategory.compareCategories):
        (WebInspector.AuditLauncherView.prototype.addCategory):
        (WebInspector.AuditLauncherView.prototype._launchButtonClicked):
        (WebInspector.AuditLauncherView.prototype._selectAllClicked):
        (WebInspector.AuditLauncherView.prototype._categoryClicked):
        (WebInspector.AuditLauncherView.prototype._createCategoryElement):
        (WebInspector.AuditLauncherView.prototype._createLauncherUI):
        * inspector/front-end/AuditResultView.js:
        (WebInspector.AuditCategoryResultPane.prototype._appendResult):
        * inspector/front-end/AuditsPanel.js:
        (WebInspector.AuditsPanel):
        (WebInspector.AuditsPanel.prototype.addCategory):
        (WebInspector.AuditsPanel.prototype.getCategory):
        (WebInspector.AuditsPanel.prototype._executeAudit):
        (WebInspector.AuditCategory.prototype.run):
        * inspector/front-end/ExtensionAPI.js:
        (WebInspector.injectedExtensionAPI):
        (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype.addListener):
        (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype._fire):
        (WebInspector.injectedExtensionAPI.EventSinkImpl.prototype._dispatch):
        (WebInspector.injectedExtensionAPI.EventSink):
        (WebInspector.injectedExtensionAPI.InspectorExtensionAPI):
        (WebInspector.injectedExtensionAPI.Panels.prototype.create):
        (WebInspector.injectedExtensionAPI.Audits):
        (WebInspector.injectedExtensionAPI.Audits.prototype.addCategory):
        (WebInspector.injectedExtensionAPI.AuditCategory.customDispatch):
        (WebInspector.injectedExtensionAPI.AuditCategory):
        (WebInspector.injectedExtensionAPI.AuditCategoryImpl):
        (WebInspector.injectedExtensionAPI.AuditResult):
        (WebInspector.injectedExtensionAPI.AuditResult.prototype.get Severity):
        (WebInspector.injectedExtensionAPI.AuditResultImpl):
        (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.addResult):
        (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.createResult):
        (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype.done):
        (WebInspector.injectedExtensionAPI.AuditResultImpl.prototype._nodeFactory):
        (WebInspector.injectedExtensionAPI.AuditResultNode):
        (WebInspector.injectedExtensionAPI.AuditResultNode.prototype.addChild):
        * inspector/front-end/ExtensionAuditCategory.js: Added.
        (WebInspector.ExtensionAuditCategory):
        (WebInspector.ExtensionAuditCategory.prototype.get id):
        (WebInspector.ExtensionAuditCategory.prototype.get displayName):
        (WebInspector.ExtensionAuditCategory.prototype.get ruleCount):
        (WebInspector.ExtensionAuditCategory.prototype.run):
        (WebInspector.ExtensionAuditCategoryResults):
        (WebInspector.ExtensionAuditCategoryResults.prototype.get complete):
        (WebInspector.ExtensionAuditCategoryResults.prototype.cancel):
        (WebInspector.ExtensionAuditCategoryResults.prototype.addResult):
        (WebInspector.ExtensionAuditCategoryResults.prototype._addNode):
        (WebInspector.ExtensionAuditCategoryResults.prototype._addResult):
        * inspector/front-end/ExtensionCommon.js: Added.
        (WebInspector.commonExtensionSymbols):
        * inspector/front-end/ExtensionServer.js:
        (WebInspector.ExtensionServer):
        (WebInspector.ExtensionServer.prototype.startAuditRun):
        (WebInspector.ExtensionServer.prototype.stopAuditRun):
        (WebInspector.ExtensionServer.prototype._postNotification):
        (WebInspector.ExtensionServer.prototype._onAddAuditCategory):
        (WebInspector.ExtensionServer.prototype._onAddAuditResult):
        (WebInspector.ExtensionServer.prototype._onStopAuditCategoryRun):
        (WebInspector.ExtensionServer.prototype._addExtensions):
        (WebInspector.ExtensionServer.prototype._buildExtensionAPIInjectedScript):
        (WebInspector.ExtensionStatus):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.html:
        * inspector/front-end/utilities.js:
        ():

2010-08-30  Andrey Kosyakov  <caseq@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: add audits support to extension API
        https://bugs.webkit.org/show_bug.cgi?id=44518

        * http/tests/inspector/inspector-test2.js:
        (initialize_InspectorTest):
        (runTest.runTestInFrontend):
        (runTest):
        * inspector/audits-panel-functional.html:
        * inspector/audits-tests.js: Added.
        (frontend_collectAuditResults):
        (frontend_collectTextContent):
        * inspector/audits-tests2.js: Added.
        (initialize_AuditTests.InspectorTest.collectAuditResults):
        (initialize_AuditTests.InspectorTest.collectTextContent):
        (initialize_AuditTests):
        * inspector/extensions-api-expected.txt:
        * inspector/extensions-api.html:
        * inspector/extensions-audits-api-expected.txt: Added.
        * inspector/extensions-audits-api.html: Added.
        * inspector/extensions-audits-expected.txt: Added.
        * inspector/extensions-audits-tests.js: Added.
        (extension_runAudits.onMessage):
        (extension_runAudits):
        (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits.onAuditsDone):
        (initialize_ExtensionsAuditsTest.InspectorTest.startExtensionAudits):
        (initialize_ExtensionsAuditsTest):
        (test):
        * inspector/extensions-audits.html: Added.
        * inspector/extensions-expected.txt:
        * inspector/extensions-test.js:
        (extensionFunctions):
        (initialize_ExtensionsTest.InspectorTest.dispatchOnMessage):
        (initialize_ExtensionsTest.InspectorTest.runExtensionTests):
        (test):
        * inspector/extensions.html:
        * inspector/resources/audits-script3.js: Removed.
        * inspector/resources/extension-main.js:
        (onTestsDone):
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Justin Schuh <jschuh@chromium.org>
jschuh@chromium.org [Tue, 31 Aug 2010 12:26:33 +0000 (12:26 +0000)]
2010-08-31  Justin Schuh  <jschuh@chromium.org>

        Reviewed by Nate Chapin.

        Remove unused canReferToParentFrameEncoding() function from FrameLoader.cpp
        https://bugs.webkit.org/show_bug.cgi?id=44895

        No new tests; no behavior changed.

        * loader/FrameLoader.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Tue, 31 Aug 2010 12:02:10 +0000 (12:02 +0000)]
2010-08-31  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Kenneth Rohde Christiansen.

        JSC TimeoutChecker::didTimeOut overflows on ARM
        https://bugs.webkit.org/show_bug.cgi?id=38538

        Make getCPUTime() return values relative to the first call.
        The previous implementation relied on simply on currentTime(), which
        return a time since epoch and not a time since the thread started. This
        made the return value of getCPUTime() overflow on 32 bits.

        * runtime/TimeoutChecker.cpp:
        (JSC::getCPUTime):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 31 Aug 2010 11:33:10 +0000 (11:33 +0000)]
2010-08-31  Jeremy Orlow  <jorlow@chromium.org>

        Build fix.

        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::IDBObjectStoreBackendImpl::openCursor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-24 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 31 Aug 2010 10:46:09 +0000 (10:46 +0000)]
2010-08-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Implement the rest of IDBCursors + make them persistent
        https://bugs.webkit.org/show_bug.cgi?id=44546

        * storage/indexeddb/keyrange-expected.txt:
        * storage/indexeddb/objectstore-cursor.html: Added.
        * storage/indexeddb/open-cursor-expected.txt:
        * storage/indexeddb/script-tests/keyrange.js:
        (checkLeftBoundKeyRange):
        ():
        * storage/indexeddb/script-tests/open-cursor.js:
        (emptyCursorSuccess):
2010-08-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Implement the rest of IDBCursors + make them persistent
        https://bugs.webkit.org/show_bug.cgi?id=44546

        Because the old (memory only) backend didn't support ranges, IDBCursors
        were never really finished.  This completes them on top of SQLite like
        the rest of IndexedDB.

        Test: storage/indexeddb/objectstore-cursor.html

        * storage/IDBCursor.cpp:
        (WebCore::IDBCursor::value):
        * storage/IDBCursorBackendImpl.cpp:
        (WebCore::IDBCursorBackendImpl::IDBCursorBackendImpl):
        (WebCore::IDBCursorBackendImpl::key):
        (WebCore::IDBCursorBackendImpl::value):
        (WebCore::IDBCursorBackendImpl::update):
        (WebCore::IDBCursorBackendImpl::continueFunction):
        (WebCore::IDBCursorBackendImpl::remove):
        (WebCore::IDBCursorBackendImpl::loadCurrentRow):
        * storage/IDBCursorBackendImpl.h:
        (WebCore::IDBCursorBackendImpl::create):
        * storage/IDBCursorBackendInterface.h:
        * storage/IDBKey.cpp:
        (WebCore::IDBKey::isEqual):
        * storage/IDBKey.h:
        * storage/IDBKeyRange.cpp:
        (WebCore::IDBKeyRange::leftBound):
        (WebCore::IDBKeyRange::rightBound):
        (WebCore::IDBKeyRange::bound):
        * storage/IDBObjectStoreBackendImpl.cpp:
        (WebCore::cursorWhereFragment):
        (WebCore::IDBObjectStoreBackendImpl::openCursor):
2010-08-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Steve Block.

        Implement the rest of IDBCursors + make them persistent
        https://bugs.webkit.org/show_bug.cgi?id=44546

        * src/IDBCursorBackendProxy.cpp:
        (WebCore::IDBCursorBackendProxy::value):
        * src/IDBCursorBackendProxy.h:
        * src/WebIDBCursorImpl.cpp:
        (WebKit::WebIDBCursorImpl::value):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Tue, 31 Aug 2010 09:56:27 +0000 (09:56 +0000)]
2010-08-31  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        fast/dom/frame-loading-via-document-write.html fails on Chromium and is otherwise flaky
        https://bugs.webkit.org/show_bug.cgi?id=44894

        Detect all frames loading more reliably (add a counter to count down when each of
        the three frames has loaded). Install onload handler on images instead of the document
        to not tickle bug 29615.

        * fast/dom/frame-loading-via-document-write.html:
        * fast/dom/resources/frame-loading-via-document-write.js:
        (didImageLoad):
        * platform/chromium/test_expectations.txt:
        * platform/mac-leopard/Skipped:
        * platform/mac-snowleopard/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 31 Aug 2010 09:40:06 +0000 (09:40 +0000)]
2010-08-31  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [reviewtool] Allow reviewer to select lines of context by dragging over the line numbers
        https://bugs.webkit.org/show_bug.cgi?id=44936

        * PrettyPatch/PrettyPatch.rb:
            - Add a version number to bust through bugs.webkit.org's aggressive
              cacheing.
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-27 John Gregg <johnnyg@google.com>
johnnyg@google.com [Tue, 31 Aug 2010 08:58:28 +0000 (08:58 +0000)]
2010-08-27  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Notifications should support a click event
        https://bugs.webkit.org/show_bug.cgi?id=44800

        * public/WebNotification.h:
        * src/WebNotification.cpp:
        (WebKit::WebNotification::dispatchClickEvent):
2010-08-27  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Notifications should support a click event
        https://bugs.webkit.org/show_bug.cgi?id=44800

        Test: fast/notifications/notifications-click-event.html

        * notifications/Notification.h:
        * notifications/Notification.idl:
2010-08-27  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Notifications should support a click event
        https://bugs.webkit.org/show_bug.cgi?id=44800

        * fast/notifications/notifications-click-event-expected.txt: Added.
        * fast/notifications/notifications-click-event.html: Added.
        * platform/qt/Skipped:
2010-08-27  John Gregg  <johnnyg@google.com>

        Reviewed by David Levin.

        Notifications should support a click event.
        Adds necessary hooks to chromium's DRT so that clicks on desktop notifications
        can be simulated during a layout test.  Requires storing a list of active
        notifications so that they can be referred to later for clicking.
        https://bugs.webkit.org/show_bug.cgi?id=44800

        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::LayoutTestController):
        (LayoutTestController::simulateDesktopNotificationClick):
        * DumpRenderTree/chromium/LayoutTestController.h:
        * DumpRenderTree/chromium/NotificationPresenter.cpp:
        (NotificationPresenter::simulateClick):
        (NotificationPresenter::show):
        (NotificationPresenter::cancel):
        (NotificationPresenter::objectDestroyed):
        * DumpRenderTree/chromium/NotificationPresenter.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Tue, 31 Aug 2010 08:25:00 +0000 (08:25 +0000)]
2010-08-31  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed.

        [GTK] canvas/philip/tests/2d.path.isPointInPath.edge-actual.txt
        fails in the bots
        https://bugs.webkit.org/show_bug.cgi?id=44932

        Skip a test that is failing in the bots.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSkip fast/files/apply-blob-url-to-img.html for now until finding out
jianli@chromium.org [Tue, 31 Aug 2010 08:21:22 +0000 (08:21 +0000)]
Skip fast/files/apply-blob-url-to-img.html for now until finding out
how to generate the right result.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[V8] Custom binding for "dataset"
tkent@chromium.org [Tue, 31 Aug 2010 08:10:21 +0000 (08:10 +0000)]
[V8] Custom binding for "dataset"
https://bugs.webkit.org/show_bug.cgi?id=44930

Reviewed by Adam Barth.

WebCore:

* WebCore.gyp/WebCore.gyp: Remove the exclusion of DOMStringMap.idl.
* WebCore.gypi: Add V8DOMStringMapCustom.cpp.
* bindings/v8/custom/V8DOMStringMapCustom.cpp: Added.
(WebCore::V8DOMStringMap::namedPropertyQuery):
(WebCore::V8DOMStringMap::namedPropertyGetter):
(WebCore::V8DOMStringMap::namedPropertyEnumerator):
(WebCore::V8DOMStringMap::namedPropertyDeleter):
(WebCore::V8DOMStringMap::namedPropertySetter):
* dom/Element.idl: Remove V8 exclusion.
* page/DOMWindow.idl: ditto.

LayoutTests:

* platform/chromium/test_expectations.txt:
 Remove dataset.html and dataset-xhtml.xhtml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix after r66448 on WebKit2.
zoltan@webkit.org [Tue, 31 Aug 2010 08:06:41 +0000 (08:06 +0000)]
Build fix after r66448 on WebKit2.

[Qt] qt_wk_didFinishDocumentLoadForFrame needs to be implemented
https://bugs.webkit.org/show_bug.cgi?id=44934

* UIProcess/API/qt/ClientImpl.cpp:
(qt_wk_didFinishDocumentLoadForFrame):
* UIProcess/API/qt/ClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate chromium test result.
jianli@chromium.org [Tue, 31 Aug 2010 07:56:32 +0000 (07:56 +0000)]
Update chromium test result.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix chromium build break.
jianli@chromium.org [Tue, 31 Aug 2010 07:39:29 +0000 (07:39 +0000)]
Fix chromium build break.

* page/DOMWindow.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-31 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 31 Aug 2010 07:35:01 +0000 (07:35 +0000)]
2010-08-31  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Stale document crashes at multiple URLs (with new parser)
        https://bugs.webkit.org/show_bug.cgi?id=44885

        We're not supposed to load resources in detached documents.  According
        to several locations I examined, it's the job of the caller of
        DocLoader to check this invariant.  Like most code dealing with
        detached documents, this check isn't overly consistent.  At some point,
        we'll need to rationalize all the different patterns here.  However, at
        this point, this patch appears correct because it matches what we do
        for <link rel="stylesheet">.

        Test: fast/dom/HTMLLinkElement/prefetch-detached.html

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestLinkPrefetch):
2010-08-31  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Stale document crashes at multiple URLs (with new parser)
        https://bugs.webkit.org/show_bug.cgi?id=44885

        Test what happens when you insert a link prefetch element into a
        detached document.

        * fast/dom/HTMLLinkElement/prefetch-detached-expected.txt: Added.
        * fast/dom/HTMLLinkElement/prefetch-detached.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoExpose window.createBlobURL and window.revokeBlobURL.
jianli@chromium.org [Tue, 31 Aug 2010 07:25:37 +0000 (07:25 +0000)]
Expose window.createBlobURL and window.revokeBlobURL.
https://bugs.webkit.org/show_bug.cgi?id=44908

Reviewed by David Levin.

WebCore:

Tests: fast/files/apply-blob-url-to-img.html
       fast/files/apply-blob-url-to-xhr.html

* page/DOMWindow.cpp:
(WebCore::DOMWindow::createBlobURL):
(WebCore::DOMWindow::revokeBlobURL):
* page/DOMWindow.h:
* page/DOMWindow.idl:
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::createRequest):

LayoutTests:

* fast/dom/Window/script-tests/window-property-descriptors.js:
* fast/dom/Window/window-properties.html:
* fast/dom/script-tests/prototype-inheritance.js:
* fast/files/apply-blob-url-to-img.html: Added.
* fast/files/apply-blob-url-to-xhr-expected.txt: Added.
* fast/files/apply-blob-url-to-xhr.html: Added.
* fast/files/resources/abe.png: Copied from LayoutTests/editing/resources/abe.png.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/mac/fast/files/apply-blob-url-to-img-expected.checksum: Added.
* platform/mac/fast/files/apply-blob-url-to-img-expected.png: Added.
* platform/mac/fast/files/apply-blob-url-to-img-expected.txt: Added.
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSupport FileReaderSync in workers.
jianli@chromium.org [Tue, 31 Aug 2010 07:06:30 +0000 (07:06 +0000)]
Support FileReaderSync in workers.
https://bugs.webkit.org/show_bug.cgi?id=44657

Reviewed by David Levin.

WebCore:

Also add FileException interface and make Blob/File/FileError useable in
workers.

Tests: fast/files/workers/worker-read-blob-async.html
       fast/files/workers/worker-read-blob-sync.html
       fast/files/workers/worker-read-file-async.html
       fast/files/workers/worker-read-file-sync.html

* DerivedSources.cpp:
* DerivedSources.make:
* WebCore.gypi:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* fileapi/Blob.idl: Added NoStaticTables attribute.
* fileapi/File.idl: Added NoStaticTables attribute.
* fileapi/FileError.idl: Added NoStaticTables attribute.
* fileapi/FileException.h: Added.
* fileapi/FileException.idl: Added.
* fileapi/FileReaderSync.cpp: Added.
* fileapi/FileReaderSync.h: Added.
* fileapi/FileReaderSync.idl: Added.
* workers/WorkerContext.idl: Expose FileReaderSync and BlodBuilder in workers.

LayoutTests:

Added 4 test files to test FileReaderSync in workers.

* fast/files/read-blob-async.html:
* fast/files/read-file-async.html:
* fast/files/resources/read-common.js:
(readBlobAsBinaryString):
(readBlobAsText):
(readBlobAsDataURL):
(_readBlobAsBinaryStringAsync):
(_readBlobAsTextAsync):
(_readBlobAsDataURLAsync):
(_readBlobAsBinaryStringSync):
(_readBlobAsTextSync):
(_readBlobAsDataURLSync):
(createReaderSync):
* fast/files/resources/read-blob-test-cases.js:
(runNextTest):
* fast/files/resources/read-file-test-cases.js:
(runNextTest):
(testMultipleReads):
* fast/files/resources/setup-for-read-common.js:
(log):
(startWorker.worker.onmessage):
(startWorker.worker.onerror):
(startWorker):
* fast/files/workers/resources/worker-read-blob-async.js: Added.
* fast/files/workers/resources/worker-read-blob-sync.js: Added.
* fast/files/workers/resources/worker-read-common.js: Added.
* fast/files/workers/resources/worker-read-file-async.js: Added.
* fast/files/workers/resources/worker-read-file-sync.js: Added.
* fast/files/workers/worker-read-blob-async-expected.txt: Added.
* fast/files/workers/worker-read-blob-async.html: Added.
* fast/files/workers/worker-read-blob-sync-expected.txt: Added.
* fast/files/workers/worker-read-blob-sync.html: Added.
* fast/files/workers/worker-read-file-async-expected.txt: Added.
* fast/files/workers/worker-read-file-async.html: Added.
* fast/files/workers/worker-read-file-sync-expected.txt: Added.
* fast/files/workers/worker-read-file-sync.html: Added.
* platform/chromium/test_expectations.txt:
* platform/gtk/Skipped:
* platform/mac-wk2/Skipped:
* platform/qt/Skipped:
* platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Philippe Normand <pnormand@igalia.com>
philn@webkit.org [Tue, 31 Aug 2010 06:44:41 +0000 (06:44 +0000)]
2010-08-30  Philippe Normand  <pnormand@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Buffered ranges drawing support
        https://bugs.webkit.org/show_bug.cgi?id=44869

        Refactored the media slider track painting code to support
        multiple buffered ranges painting. This change introduces no
        functional regression.

        * platform/gtk/RenderThemeGtk.cpp:
        (WebCore::RenderThemeGtk::paintMediaSliderTrack):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUpdate WebCore/ChangeLog to add missing entries.
jianli@chromium.org [Tue, 31 Aug 2010 05:51:35 +0000 (05:51 +0000)]
Update WebCore/ChangeLog to add missing entries.

* loader/RedirectScheduler.cpp:
(WebCore::RedirectScheduler::scheduleHistoryNavigation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Mihai Parparita <mihaip@chromium.org>
commit-queue@webkit.org [Tue, 31 Aug 2010 05:39:21 +0000 (05:39 +0000)]
2010-08-30  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
        https://bugs.webkit.org/show_bug.cgi?id=44315

        Remove ENABLE_HISTORY_ALWAYS_ASYNC #define.

        * wtf/Platform.h:
2010-08-30  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
        https://bugs.webkit.org/show_bug.cgi?id=44315

        Add test that checks history.back() asynchronous behavior. Modifies
        location-hash.html to not assume synchronous traversal and removes it
        from the Chromium test expectations, since it passes there now too.

        * fast/dom/location-hash-expected.txt:
        * fast/dom/location-hash.html:
        * fast/history/history-traversal-is-asynchronous-expected.txt: Added.
        * fast/history/history-traversal-is-asynchronous.html: Added.
        * platform/chromium/test_expectations.txt:
2010-08-30  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Adam Barth.

        HISTORY_ALWAYS_ASYNC should be removed (history should always be async)
        https://bugs.webkit.org/show_bug.cgi?id=44315

        Remove check in RedirectScheduler::scheduleHistoryNavigation that would
        dispatch some navigations synchronously.

        Test: fast/history/history-traversal-is-asynchronous.html

        * loader/RedirectScheduler.cpp:
        (WebCore::RedirectScheduler::scheduleHistoryNavigation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 31 Aug 2010 05:37:41 +0000 (05:37 +0000)]
2010-08-30  Jian Li  <jianli@chromium.org>

        Try to fix break again.

        * fileapi/ThreadableBlobRegistry.cpp:
        (WebCore::ThreadableBlobRegistry::registerBlobURL):
        (WebCore::ThreadableBlobRegistry::unregisterBlobURL):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 31 Aug 2010 05:26:47 +0000 (05:26 +0000)]
2010-08-30  Jian Li  <jianli@chromium.org>

        Fix another build break. Also fix directory upload test break.

        * fileapi/File.cpp:
        (WebCore::File::File):
        * fileapi/ThreadableBlobRegistry.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 31 Aug 2010 05:17:02 +0000 (05:17 +0000)]
2010-08-30  Jian Li  <jianli@chromium.org>

        Fix build break.

        * xml/XMLHttpRequest.cpp:
        (WebCore::XMLHttpRequest::send):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66455 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Kamil Blank <k.blank@samsung.com>
commit-queue@webkit.org [Tue, 31 Aug 2010 05:05:40 +0000 (05:05 +0000)]
2010-08-30  Kamil Blank  <k.blank@samsung.com>

        Reviewed by Adam Barth.

        [EFL] Added API which returns position of n-th text matches mark
        https://bugs.webkit.org/show_bug.cgi?id=44258

        * ewk/ewk_frame.cpp:
        (_ewk_frame_rect_cmp_less_than): Private.
        (_ewk_frame_rect_is_negative_value): Private.
        (ewk_frame_text_matches_nth_pos_get): Added. Function returns position of
        n-th text match in frame.
        * ewk/ewk_frame.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Jian Li <jianli@chromium.org>
jianli@chromium.org [Tue, 31 Aug 2010 04:56:39 +0000 (04:56 +0000)]
2010-08-30  Jian Li  <jianli@chromium.org>

        Fix qt/gtk build break.

        * platform/network/BlobRegistryImpl.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoSwitch the Blob implementation to using the blob data registration model
jianli@chromium.org [Tue, 31 Aug 2010 04:45:21 +0000 (04:45 +0000)]
Switch the Blob implementation to using the blob data registration model
https://bugs.webkit.org/show_bug.cgi?id=44389

Reviewed by Darin Fisher.

WebCore:

Tests: fast/files/read-blob-async.html
       fast/files/read-file-async.html

With this switch, File/Blob/BlobBuilder are changed to register the blob
data. FileReader is changed to route through loading the blob resource.
FormData is also updated to take BlobData. The WebKit mac implementation
is updated to resolve the blob references in the BlobData.

* CMakeLists.txt: Update the project file to remove BlobItem.*.
* GNUmakefile.am: Update the project file to remove BlobItem.*.
* WebCore.gypi: Update the project file to remove BlobItem.*.
* WebCore.pro: Update the project file to remove BlobItem.*.
* WebCore.vcproj/WebCore.vcproj: Update the project file to remove BlobItem.*.
* WebCore.xcodeproj/project.pbxproj: Update the project file to remove BlobItem.*.
* fileapi/Blob.cpp: Switch to using BlobData.
(WebCore::Blob::Blob):
(WebCore::Blob::slice):
* fileapi/Blob.h: Switch to using BlobData.
(WebCore::Blob::create):
(WebCore::Blob::size):
(WebCore::Blob::isFile):
* fileapi/BlobBuilder.cpp: Switch to using BlobData.
(WebCore::BlobBuilder::BlobBuilder):
(WebCore::BlobBuilder::append):
(WebCore::BlobBuilder::getBlob):
* fileapi/BlobBuilder.h: Switch to using BlobData.
* fileapi/BlobURL.cpp: Add a new helper method used in FormData.
(WebCore::BlobURL::getIdentifier):
* fileapi/BlobURL.h:
* fileapi/File.cpp: Switch to using BlobData.
(WebCore::createBlobDataForFile):
(WebCore::File::File):
(WebCore::File::size):
(WebCore::File::captureSnapshot):
* fileapi/File.h: Switch to using BlobData.
(WebCore::File::create):
(WebCore::File::path):
(WebCore::File::name):
(WebCore::File::webkitRelativePath):
* fileapi/FileReader.cpp: Change the reading to route through blob resource loading.
(WebCore::FileReader::FileReader):
(WebCore::FileReader::readAsBinaryString):
(WebCore::FileReader::readAsText):
(WebCore::FileReader::readAsDataURL):
(WebCore::delayedStart):
(WebCore::FileReader::readInternal):
(WebCore::FileReader::terminate):
(WebCore::FileReader::start):
(WebCore::FileReader::didReceiveResponse):
(WebCore::FileReader::didReceiveData):
(WebCore::FileReader::didFinishLoading):
(WebCore::FileReader::didFail):
(WebCore::FileReader::failed):
(WebCore::FileReader::httpStatusCodeToExceptionCode):
(WebCore::FileReader::result):
(WebCore::FileReader::convertToDataURL):
* fileapi/FileReader.h:
* html/FormDataList.cpp: Account to BlobData change.
(WebCore::FormDataList::appendString):
(WebCore::FormDataList::appendBlob):
* html/FormDataList.h: Account to BlobData change.
(WebCore::FormDataList::appendBlob):
(WebCore::FormDataList::Item::Item):
(WebCore::FormDataList::Item::data):
(WebCore::FormDataList::Item::blob):
(WebCore::FormDataList::items):
* loader/FormSubmission.cpp: Account to BlobData change.
(WebCore::FormSubmission::create):
* platform/BlobItem.cpp: Removed.
* platform/BlobItem.h: Removed.
* platform/network/BlobRegistryImpl.cpp: Add the implementations for resource loading.
(WebCore::BlobRegistryImpl::createResourceHandle):
(WebCore::BlobRegistryImpl::loadResourceSynchronously):
* platform/network/BlobResourceHandle.cpp: Fix a bug that the ref is not added.
(WebCore::BlobResourceHandle::BlobResourceHandle):
* platform/network/FormData.cpp: Account to BlobData change.
(WebCore::FormData::create):
(WebCore::FormData::createMultiPart):
(WebCore::FormData::deepCopy):
(WebCore::FormData::appendFile):
(WebCore::FormData::appendKeyValuePairItems):
* platform/network/FormData.h: Account to BlobData change.
* platform/network/mac/FormDataStreamMac.mm: Resolve blob references in the form data.
(WebCore::closeCurrentStream):
(WebCore::advanceCurrentStream):
(WebCore::formCreate):
(WebCore::formRead):
(WebCore::setHTTPBody):
* xml/XMLHttpRequest.cpp: Account to BlobData change.
(WebCore::XMLHttpRequest::send):

WebKit/chromium:

* src/WebSearchableFormData.cpp:
(WebCore::HasSuitableTextElement):

LayoutTests:

Add a new test and change an existing test. Both tests are written in
better organized utility files and modules.

* fast/files/file-reader-expected.txt: Removed.
* fast/files/file-reader.html: Removed.
* fast/files/read-blob-async-expected.txt: Added.
* fast/files/read-blob-async.html: Added.
* fast/files/read-file-async-expected.txt: Added.
* fast/files/read-file-async.html: Added.
* fast/files/resources/UTF8-2.txt: Added.
* fast/files/resources/UTF8-3.txt: Added.
* fast/files/resources/read-blob-test-cases.js: Added.
* fast/files/resources/read-common.js: Added.
* fast/files/resources/read-file-test-cases.js: Added.
* fast/files/resources/setup-for-read-common.js: Added.
* platform/gtk/Skipped: Account to the test changes for gtk.
* platform/mac-wk2/Skipped: Account to the test changes for mac-wk2.
* platform/qt/Skipped: Account to the test changes for qt.
* platform/win/Skipped: Account to the test changes for win.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66452 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Tue, 31 Aug 2010 04:41:43 +0000 (04:41 +0000)]
2010-08-30  Ryuan Choi  <ryuan.choi@samsung.com>

        Reviewed by Adam Barth.

        [EFL]Url of HistoryItem was broken for special character like korean
        https://bugs.webkit.org/show_bug.cgi?id=44495

        Remove unnecessary code. This makes a bug with complicated URL.

        * ewk/ewk_frame.cpp:
        (ewk_frame_view_state_save):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Nat Duca <nduca@chromium.org>
commit-queue@webkit.org [Tue, 31 Aug 2010 04:24:05 +0000 (04:24 +0000)]
2010-08-30  Nat Duca  <nduca@chromium.org>

        Reviewed by Adam Barth.

        [chromium] Accelerated Compositing: Artifacts/blink when enabling compositor.
        https://bugs.webkit.org/show_bug.cgi?id=44196

        If accelerated compositing enables after a page loads, the dirtied
        portion of the screen will be only a subset of the full screen,
        leading to artefacts. Avoid these artefacts by invalidating the
        visible content rect on compositor initialization.

        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::setIsAcceleratedCompositingActive):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Eric Seidel <eric@webkit.org>
eric@webkit.org [Tue, 31 Aug 2010 03:44:23 +0000 (03:44 +0000)]
2010-08-30  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r66418.
        http://trac.webkit.org/changeset/66418
        https://bugs.webkit.org/show_bug.cgi?id=44896

        Adam tried to roll this out with:
        https://bugs.webkit.org/show_bug.cgi?id=44924
        but we hit a commit-queue edgecase and it failed, trying again.

        Causing test failures on multiple bots

        * platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum:
        * platform/mac-leopard/svg/css/composite-shadow-example-expected.png:
        * platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.checksum:
        * platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.png:
        * platform/mac/svg/css/composite-shadow-example-expected.txt:
        * platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:
2010-08-30  Eric Seidel  <eric@webkit.org>

        Unreviewed, rolling out r66418.
        http://trac.webkit.org/changeset/66418
        https://bugs.webkit.org/show_bug.cgi?id=44896

        Adam tried to roll this out with:
        https://bugs.webkit.org/show_bug.cgi?id=44924
        but we hit a commit-queue edgecase and it failed, trying again.

        Causing test failures on multiple bots

        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::layout):
        * rendering/RenderObject.cpp:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::setNeedsBoundariesUpdate):
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::removeChildNode):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::layout):
        (WebCore::RenderPath::paint):
        (WebCore::RenderPath::styleWillChange):
        * rendering/RenderPath.h:
        (WebCore::RenderPath::setNeedsBoundariesUpdate):
        * rendering/RenderSVGBlock.cpp:
        * rendering/RenderSVGBlock.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::RenderSVGContainer):
        (WebCore::RenderSVGContainer::layout):
        (WebCore::RenderSVGContainer::paint):
        (WebCore::RenderSVGContainer::objectBoundingBox):
        (WebCore::RenderSVGContainer::strokeBoundingBox):
        (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::calculateLocalTransform):
        * rendering/RenderSVGGradientStop.h:
        * rendering/RenderSVGHiddenContainer.cpp:
        (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
        (WebCore::RenderSVGHiddenContainer::objectBoundingBox):
        (WebCore::RenderSVGHiddenContainer::repaintRectInLocalCoordinates):
        * rendering/RenderSVGHiddenContainer.h:
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGInline.cpp:
        * rendering/RenderSVGInline.h:
        * rendering/RenderSVGModelObject.cpp:
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::RenderSVGRoot):
        (WebCore::RenderSVGRoot::layout):
        (WebCore::RenderSVGRoot::objectBoundingBox):
        (WebCore::RenderSVGRoot::strokeBoundingBox):
        (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
        * rendering/RenderSVGRoot.h:
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout):
        * rendering/RenderSVGTransformableContainer.cpp:
        (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
        * rendering/RenderSVGTransformableContainer.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::calcViewport):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::computeContainerBoundingBox):
        * rendering/SVGRenderSupport.h:
        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::diff):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd missing parts of didFinishDocumentLoadForFrame
alice.liu@apple.com [Tue, 31 Aug 2010 03:34:33 +0000 (03:34 +0000)]
Add missing parts of didFinishDocumentLoadForFrame
https://bugs.webkit.org/show_bug.cgi?id=44913

Reviewed by Darin Adler.

WebKit2:

* Shared/CoreIPCSupport/WebPageProxyMessageKinds.h: Added new kind
* UIProcess/API/C/WKPage.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage): Updated struct
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::didFinishDocumentLoadForFrame): Added
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::didReceiveMessage): Added case for WebPageProxyMessage::DidFinishDocumentLoadForFrame
(WebKit::WebPageProxy::didFinishDocumentLoadForFrame): Added
* UIProcess/WebPageProxy.h:

Just rearranging existing code in these:
* WebProcess/InjectedBundle/API/c/WKBundlePage.h:
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.cpp:
(WebKit::InjectedBundlePageLoaderClient::didFinishDocumentLoadForFrame):
* WebProcess/InjectedBundle/InjectedBundlePageLoaderClient.h:

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(didFinishDocumentLoadForFrame): Added
(-[BrowserWindowController awakeFromNib]): Updated struct
* WebKitTestRunner/InjectedBundle/InjectedBundlePage.cpp:
(WTR::InjectedBundlePage::InjectedBundlePage): Rearranged function ptr
* WebKitTestRunner/TestController.cpp:
(WTR::TestController::initialize): Updated struct

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 31 Aug 2010 02:14:26 +0000 (02:14 +0000)]
2010-08-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement CDATASection state for the HTMLTokenizer
        https://bugs.webkit.org/show_bug.cgi?id=44923

        In the spec, this state refers back to the HTMLTreeBuilder from the
        HTMLTokenizer.  Rather that introduce that (backwards) dependencies, we
        have the tree builder set a bit on the tokenizer.

        * html/parser/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::reset):
        (WebCore::HTMLTokenizer::nextToken):
        * html/parser/HTMLTokenizer.h:
        (WebCore::HTMLTokenizer::shouldAllowCDATA):
        (WebCore::HTMLTokenizer::setShouldAllowCDATA):
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::constructTreeFromToken):
2010-08-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Implement CDATASection state for the HTMLTokenizer
        https://bugs.webkit.org/show_bug.cgi?id=44923

        Large test progression.

        * html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Chris Rogers <crogers@google.com>
crogers@google.com [Tue, 31 Aug 2010 02:04:46 +0000 (02:04 +0000)]
2010-08-30  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Fix namespace for wtf/Complex.h and wtf/Vector3.h
        https://bugs.webkit.org/show_bug.cgi?id=44892

        * wtf/Complex.h:
        * wtf/Vector3.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 31 Aug 2010 01:32:47 +0000 (01:32 +0000)]
2010-08-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Enable HTML5lib's test_innerHTML01.dat
        https://bugs.webkit.org/show_bug.cgi?id=44919

        These tests provoked two branches that we hadn't implemented yet.

        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::processStartTag):
        (WebCore::HTMLTreeBuilder::processEndTag):
2010-08-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Enable HTML5lib's test_innerHTML01.dat
        https://bugs.webkit.org/show_bug.cgi?id=44919

        Enable these tests now that they don't ASSERT.  Yay!  They pass.  :)

        * html5lib/runner-expected.txt:
        * html5lib/runner.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66443 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago<rdar://problem/8369736> WebKit build fails.
mrowe@apple.com [Tue, 31 Aug 2010 01:07:09 +0000 (01:07 +0000)]
<rdar://problem/8369736> WebKit build fails.

Reviewed by Darin Adler.

Temporarily add some extra includes in order to get things building again until <rdar://problem/8374711> is addressed.

* Carbon/HIViewAdapter.m:
* Carbon/HIWebView.mm:
* Plugins/WebNetscapePluginView.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66441 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoStop using a QuickDraw function that was only used for debugging purposes.
mrowe@apple.com [Tue, 31 Aug 2010 01:06:59 +0000 (01:06 +0000)]
Stop using a QuickDraw function that was only used for debugging purposes.

Reviewed by Darin Adler.

* platform/graphics/mac/SimpleFontDataMac.mm:
(WebCore::pathFromFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66440 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTry and fix the WebKit2 buildbot.
weinig@apple.com [Tue, 31 Aug 2010 01:04:59 +0000 (01:04 +0000)]
Try and fix the WebKit2 buildbot.

* WebProcess/WebCoreSupport/mac/WebSystemInterface.mm:
(InitWebCoreSystemInterface): Add missing initialization of QTMovieDisableComponent.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66439 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix crash on launch on Windows due to changing IWebFramePrivate's vtable
aroben@apple.com [Tue, 31 Aug 2010 01:04:44 +0000 (01:04 +0000)]
Fix crash on launch on Windows due to changing IWebFramePrivate's vtable

This regressed in r65107.

Fixes <http://webkit.org/b/44755>.

Rubber-stamped by Jon Honeycutt.

* Interfaces/IWebFramePrivate.idl: Moved suspendAnimations and
resumeAnimations to the end of the interface so that the vtable will
match what Safari expects.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66438 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebKit: Add 'application/x-snkp' to StringsNotToBeLocalized.txt.
aestes@apple.com [Tue, 31 Aug 2010 01:01:22 +0000 (01:01 +0000)]
WebKit: Add 'application/x-snkp' to StringsNotToBeLocalized.txt.

Reviewed by Darin Adler.

* StringsNotToBeLocalized.txt:

WebKit/mac: REGRESSION (r66156): Sites using AppleConnect for authentication fail to log in.
https://bugs.webkit.org/show_bug.cgi?id=44865

Reviewed by Darin Adler.

After http://trac.webkit.org/changeset/66156, sites using the AppleConnect plug-in
for authentication fail to log in. This is due to a bug in AppleConnect that r66156
exposed, but since this will have a significant impact on users of WebKit nightly
builds, a plugin-specific hack should be added while the underlying issue is being
addressed.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin): Convert plug-in parameter names to lowercase
if the plugin is of type 'application/x-snkp'.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66437 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoAdd URLRequest API for WebKit2
weinig@apple.com [Tue, 31 Aug 2010 00:51:30 +0000 (00:51 +0000)]
Add URLRequest API for WebKit2
https://bugs.webkit.org/show_bug.cgi?id=44910

Reviewed by Anders Carlsson.

Add WebURLRequest class and WKURLRequestRef C API to go with it. Right now,
instance of WKURLRequestRef are manipulated via platform types, a la the
WKStringRef and WKURLRef types.

- Pipes WKPageLoadURLRequest through to the WebProcess.

* Shared/APIObject.h:
* Shared/CoreIPCSupport/WebPageMessageKinds.h:
* Shared/WebCoreArgumentCoders.h:
* Shared/WebURLRequest.cpp: Added.
(WebKit::WebURLRequest::WebURLRequest):
* Shared/WebURLRequest.h: Added.
(WebKit::WebURLRequest::create):
(WebKit::WebURLRequest::resourceRequest):
(WebKit::WebURLRequest::type):
* Shared/mac/WebCoreArgumentCodersMac.mm: Added.
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
* Shared/mac/WebURLRequestMac.mm: Added.
(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::platformRequest):
* Shared/qt/WebCoreArgumentCodersQt.cpp: Added.
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
* Shared/qt/WebURLRequestQt.cpp: Added.
(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::platformRequest):
* Shared/win/WebCoreArgumentCodersWin.cpp: Added.
(CoreIPC::encodeResourceRequest):
(CoreIPC::decodeResourceRequest):
* Shared/win/WebURLRequestWin.cpp: Added.
(WebKit::WebURLRequest::WebURLRequest):
(WebKit::WebURLRequest::platformRequest):
* UIProcess/API/C/WKAPICast.h:
* UIProcess/API/C/WKBase.h:
* UIProcess/API/C/WKPage.cpp:
(WKPageLoadURLRequest):
* UIProcess/API/C/WKPage.h:
* UIProcess/API/C/WKURLRequest.cpp: Added.
(WKURLRequestGetTypeID):
* UIProcess/API/C/WKURLRequest.h: Added.
* UIProcess/API/C/WebKit2.h:
* UIProcess/API/C/cf/WKURLRequestCF.cpp: Added.
(WKURLRequestCreateWithCFURLRequest):
(WKURLRequestCopyCFURLRequest):
* UIProcess/API/C/cf/WKURLRequestCF.h: Added.
* UIProcess/API/C/mac: Added.
* UIProcess/API/C/mac/WKURLRequestNS.h: Added.
* UIProcess/API/C/mac/WKURLRequestNS.mm: Added.
(WKURLRequestCreateWithNSURLRequest):
(WKURLRequestCopyNSURLRequest):
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::loadURL):
(WebKit::WebPageProxy::loadURLRequest):
* UIProcess/WebPageProxy.h:
* WebKit2.pro:
* WebKit2.xcodeproj/project.pbxproj:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::loadURL):
(WebKit::WebPage::loadURLRequest):
(WebKit::WebPage::didReceiveMessage):
* WebProcess/WebPage/WebPage.h:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66436 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Tue, 31 Aug 2010 00:44:45 +0000 (00:44 +0000)]
2010-08-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Import new tests from HTML5lib
        https://bugs.webkit.org/show_bug.cgi?id=44912

        * html5lib/resources/tests10.dat:
        * html5lib/resources/tests20.dat:
        * html5lib/resources/tests21.dat: Added.
        * html5lib/resources/tests_innerHTML_1.dat: Added.
        * html5lib/runner-expected.txt:
        * html5lib/runner.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66435 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Yuta Kitamura <yutak@chromium.org>
morrita@google.com [Tue, 31 Aug 2010 00:39:25 +0000 (00:39 +0000)]
2010-08-30  Yuta Kitamura  <yutak@chromium.org>

        Unreviewed test expectation update.

        Update Chromium test expectations
        https://bugs.webkit.org/show_bug.cgi?id=44859

        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum: Removed. Test expectation was wrong.
        * platform/chromium-linux/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Ditto.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
        * platform/chromium-linux/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.checksum: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1/animate-elem-80-t-expected.png: Removed.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.checksum:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-01-f-expected.png:
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.checksum: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.png: Added.
        * platform/chromium-win/svg/W3C-SVG-1.1/filters-turb-02-f-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66434 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Vangelis Kokkevis <vangelis@chromium.org>
vangelis@chromium.org [Tue, 31 Aug 2010 00:38:31 +0000 (00:38 +0000)]
2010-08-30  Vangelis Kokkevis  <vangelis@chromium.org>

        Unreviewed: Add myself to the list of Committers.

        * Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66433 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations.
dumi@chromium.org [Tue, 31 Aug 2010 00:29:44 +0000 (00:29 +0000)]
Unreviewed, updating Chromium expectations.

* platform/chromium-win/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Removed.
* platform/chromium-win/fast/lists/w3-css3-list-styles-numeric-expected.png: Removed.
* platform/chromium-win/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66432 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 31 Aug 2010 00:26:14 +0000 (00:26 +0000)]
2010-08-30  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        queryCommandValue("BackColor") returns rgb(0,0,0) for elements with transparent background
        https://bugs.webkit.org/show_bug.cgi?id=21680

        The bug was caused by WebKit's using the computed style to obtain the background color,
        which is rgba(0,0,0,0) for nodes with transparent background color. While this is correct
        in the accordance to CSS2 because background-color is not inherited by default,
        it is not desirable for editing purposes where the background color in effect is expected.

        Modified valueStyle in EditorCommand.cpp to call Editor::selectionStartCSSPropertyValue,
        instead of Frame::selectionStartStylePropertyValue, which traverses common ancestors of
        the selected range or caret to retrieve the effective background color of the selected region
        instead of the background color at the start of the selection.
        This takes effect when the original background color is transparent or the selection is range
        (to avoid picking up the background color only present at the start of paragraph).

        Removed selectionStartStylePropertyValue and migrated it to Editor::selectionStartCSSPropertyValue.

        Test: editing/execCommand/query-command-value-background-color.html

        * editing/Editor.cpp:
        (WebCore::hasTransparentBackgroundColor): Checks whether the specified style's background color is transparent or not.
        (WebCore::Editor::selectionStartCSSPropertyValue): Migrated the contents of selectionStartStylePropertyValue and
          added the special case for background color.
        * editing/Editor.h: Added the prototype for selectionStartCSSPropertyValue.
        * editing/EditorCommand.cpp:
        (WebCore::valueStyle): Calls Editor::selectionStartCSSPropertyValue.
        * page/Frame.cpp: Removed selectionStartStylePropertyValue.
        * page/Frame.h: Ditto.
2010-08-30  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        queryCommandValue("BackColor") returns rgb(0,0,0) for elements with transparent background
        https://bugs.webkit.org/show_bug.cgi?id=21680

        Tests queryCommandValue("BackColor") on various cases, especially the cases where
        the background color of the selected node is transparent but that of its ancestor has a color.

        * editing/execCommand/query-command-value-background-color-expected.txt: Added.
        * editing/execCommand/query-command-value-background-color.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66431 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Kent Tamura <tkent@chromium.org>
tkent@chromium.org [Tue, 31 Aug 2010 00:19:17 +0000 (00:19 +0000)]
2010-08-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        Fix fast/notifications/notifications-display-close-events.html failure
        https://bugs.webkit.org/show_bug.cgi?id=44585

        * platform/chromium/drt_expectations.txt:
2010-08-30  Kent Tamura  <tkent@chromium.org>

        Reviewed by Adam Barth.

        Fix fast/notifications/notifications-display-close-events.html failure
        https://bugs.webkit.org/show_bug.cgi?id=44585

        Apply http://crrev.com/48893. We should dispatch display events
        asynchronously.

        * DumpRenderTree/chromium/NotificationPresenter.cpp:
        (deferredDisplayDispatch):
        (NotificationPresenter::show):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66430 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Tue, 31 Aug 2010 00:11:49 +0000 (00:11 +0000)]
2010-08-30  Tony Chang  <tony@chromium.org>

        Unreviewed, rebaseline plugins/mouse-event.html on chromium win/linux
        after http://trac.webkit.org/changeset/66408.

        * platform/chromium-linux/plugins/mouse-events-expected.txt:
        * platform/chromium-win/plugins/mouse-events-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66429 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Lei Zhang <thestig@chromium.org>
commit-queue@webkit.org [Tue, 31 Aug 2010 00:02:22 +0000 (00:02 +0000)]
2010-08-30  Lei Zhang  <thestig@chromium.org>

        Reviewed by Shinichiro Hamaji.

        Defer printing until the FrameLoader finishes loading.
        https://bugs.webkit.org/show_bug.cgi?id=43658

        * manual-tests/print-before-load.html: Added.

        * loader/FrameLoader.cpp:
        (WebCore::FrameLoader::finishedLoading):
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::DOMWindow):
        (WebCore::DOMWindow::print):
        * page/DOMWindow.h:
        (WebCore::DOMWindow::printDeferred):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66428 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Lucas De Marchi <lucas.demarchi@profusion.mobi>
demarchi@webkit.org [Tue, 31 Aug 2010 00:00:55 +0000 (00:00 +0000)]
2010-08-30  Lucas De Marchi  <lucas.demarchi@profusion.mobi>

        Reviewed by Adam Barth.

        [EFL] Remove compiler optimization for gcc 4.5.1
        https://bugs.webkit.org/show_bug.cgi?id=44520

        GCC 4.5.1 generates wrong code because of -ftree-sra which is enabled
        by default at any optimization level.

        Newer and older versions are not affected, so check for compiler
        version before disabling this.

        * cmake/WebKitHelpers.cmake: add flag depending on compiler version.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66426 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 30 Aug 2010 23:37:51 +0000 (23:37 +0000)]
2010-08-30  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adele Peterson.

        REGRESSION(r51939): platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html fails
        https://bugs.webkit.org/show_bug.cgi?id=44897

        Fixed the path to fast/js/resources/

        * platform/chromium/test_expectations.txt: No longer fails.
        * platform/win/editing/selection/doubleclick-should-not-expand-across-lines.html: Fixed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66425 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 30 Aug 2010 23:29:41 +0000 (23:29 +0000)]
2010-08-30  Tony Chang  <tony@chromium.org>

        Unreviewed, fixing chromium test_expectations after r66299.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66424 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Evan Martin <evan@chromium.org>
evan@chromium.org [Mon, 30 Aug 2010 23:14:26 +0000 (23:14 +0000)]
2010-08-30  Evan Martin  <evan@chromium.org>

        Reviewed by Tony Chang.

        [chromium] incorrect baselines on all platforms for fast/css/font-weight-1
        https://bugs.webkit.org/show_bug.cgi?id=44904

        This test uses a custom font.  From the change that checked them in, it
        required build changes to make this custom font available for the tests.
        The Chromium baselines were obviously wrong.

        * platform/chromium-linux/fast/css/font-weight-1-expected.checksum: Removed.
        * platform/chromium-linux/fast/css/font-weight-1-expected.png: Removed.
        * platform/chromium-linux/fast/css/font-weight-1-expected.txt: Removed.
        * platform/chromium-win/fast/css/font-weight-1-expected.checksum: Removed.
        * platform/chromium-win/fast/css/font-weight-1-expected.png: Removed.
        * platform/chromium-win/fast/css/font-weight-1-expected.txt: Removed.
        * platform/chromium/test_expectations.txt: mark as failing on all platforms.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66423 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoTypo fix.
abarth@webkit.org [Mon, 30 Aug 2010 22:57:28 +0000 (22:57 +0000)]
Typo fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66422 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoUnreviewed, updating Chromium expectations.
dumi@chromium.org [Mon, 30 Aug 2010 22:53:32 +0000 (22:53 +0000)]
Unreviewed, updating Chromium expectations.

* platform/chromium-linux/fast/lists/li-values-expected.checksum: Removed.
* platform/chromium-linux/fast/lists/li-values-expected.png: Removed.
* platform/chromium-linux/fast/lists/li-values-expected.txt: Removed.
* platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
* platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
* platform/chromium-linux/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
* platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.checksum: Removed.
* platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.png: Removed.
* platform/chromium-linux/fast/lists/w3-css3-list-styles-numeric-expected.txt: Removed.
* platform/chromium-linux/fast/lists/w3-list-styles-expected.checksum: Removed.
* platform/chromium-linux/fast/lists/w3-list-styles-expected.png: Removed.
* platform/chromium-linux/fast/lists/w3-list-styles-expected.txt: Removed.
* platform/chromium-win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
* platform/chromium-win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
* platform/chromium-win-xp/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
* platform/chromium-win/fast/lists/alpha-boundary-values-expected.checksum: Removed.
* platform/chromium-win/fast/lists/alpha-boundary-values-expected.png: Removed.
* platform/chromium-win/fast/lists/alpha-boundary-values-expected.txt: Removed.
* platform/chromium-win/fast/lists/alpha-list-wrap-expected.checksum: Removed.
* platform/chromium-win/fast/lists/alpha-list-wrap-expected.png: Removed.
* platform/chromium-win/fast/lists/alpha-list-wrap-expected.txt: Removed.
* platform/chromium-win/fast/lists/decimal-leading-zero-expected.checksum: Removed.
* platform/chromium-win/fast/lists/decimal-leading-zero-expected.png: Removed.
* platform/chromium-win/fast/lists/decimal-leading-zero-expected.txt: Removed.
* platform/chromium-win/fast/lists/list-style-type-dynamic-change-expected.checksum: Removed.
* platform/chromium-win/fast/lists/list-style-type-dynamic-change-expected.png: Removed.
* platform/chromium-win/fast/lists/list-style-type-dynamic-change-expected.txt: Removed.
* platform/chromium-win/fast/lists/w3-css3-list-styles-alphabetic-expected.checksum: Removed.
* platform/chromium-win/fast/lists/w3-css3-list-styles-alphabetic-expected.png: Removed.
* platform/chromium-win/fast/lists/w3-css3-list-styles-alphabetic-expected.txt: Removed.
* platform/chromium-win/fast/lists/w3-list-styles-expected.checksum: Removed.
* platform/chromium-win/fast/lists/w3-list-styles-expected.png: Removed.
* platform/chromium-win/fast/lists/w3-list-styles-expected.txt: Removed.
* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66421 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 30 Aug 2010 22:52:27 +0000 (22:52 +0000)]
2010-08-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        [review tool] Let reviewer select how much context to show in snippet
        https://bugs.webkit.org/show_bug.cgi?id=44905

        We now highlight the context for a comment in yellow on the left (where
        the line numbers are).  Clicking a line number expands or contracts the
        amount of context, as appropriate.  Informal user testing indicates
        that we might want to support drag as well.

        This patch also changes the "open a comment box here" action to
        double-click to avoid issues with mis-clicks.

        * PrettyPatch/PrettyPatch.rb:
        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66420 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Chris Rogers <crogers@google.com>
crogers@google.com [Mon, 30 Aug 2010 22:43:07 +0000 (22:43 +0000)]
2010-08-30  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        audio engine: add ReverbConvolver class
        https://bugs.webkit.org/show_bug.cgi?id=34912

        No new tests since audio API is not yet implemented.

        * platform/audio: Added.
        * platform/audio/ReverbAccumulationBuffer.cpp: Added.
        (WebCore::ReverbAccumulationBuffer::ReverbAccumulationBuffer):
        (WebCore::ReverbAccumulationBuffer::readAndClear):
        (WebCore::ReverbAccumulationBuffer::updateReadIndex):
        (WebCore::ReverbAccumulationBuffer::accumulate):
        (WebCore::ReverbAccumulationBuffer::reset):
        * platform/audio/ReverbAccumulationBuffer.h: Added.
        (WebCore::ReverbAccumulationBuffer::readIndex):
        (WebCore::ReverbAccumulationBuffer::readTimeFrame):
        * platform/audio/ReverbConvolver.cpp: Added.
        (WebCore::backgroundThreadEntry):
        (WebCore::ReverbConvolver::ReverbConvolver):
        (WebCore::ReverbConvolver::~ReverbConvolver):
        (WebCore::ReverbConvolver::backgroundThreadEntry):
        (WebCore::ReverbConvolver::process):
        (WebCore::ReverbConvolver::reset):
        * platform/audio/ReverbConvolver.h: Added.
        (WebCore::ReverbConvolver::impulseResponseLength):
        (WebCore::ReverbConvolver::inputBuffer):
        (WebCore::ReverbConvolver::useBackgroundThreads):
        * platform/audio/ReverbConvolverStage.cpp: Added.
        (WebCore::ReverbConvolverStage::ReverbConvolverStage):
        (WebCore::ReverbConvolverStage::processInBackground):
        (WebCore::ReverbConvolverStage::process):
        (WebCore::ReverbConvolverStage::reset):
        * platform/audio/ReverbConvolverStage.h: Added.
        (WebCore::ReverbConvolverStage::inputReadIndex):
        * platform/audio/ReverbInputBuffer.cpp: Added.
        (WebCore::ReverbInputBuffer::ReverbInputBuffer):
        (WebCore::ReverbInputBuffer::write):
        (WebCore::ReverbInputBuffer::directReadFrom):
        (WebCore::ReverbInputBuffer::reset):
        * platform/audio/ReverbInputBuffer.h: Added.
        (WebCore::ReverbInputBuffer::writeIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66419 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Mon, 30 Aug 2010 22:37:15 +0000 (22:37 +0000)]
2010-08-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Add culling to RenderSVGContainer
        https://bugs.webkit.org/show_bug.cgi?id=44896

        Cache object/strokeBoundingBox and repaintRectInLocalCoordinates() in RenderSVGContainer & RenderSVGRoot, just like it's done in RenderPath.
        Propagate boundary changes up the render tree, in layout phase, in order to notify parents that they should update their cached boundaries.

        This is a huge speed benefit when interacting with an already layouted document, as there's no need anymore to traverse all children
        of any container or <svg> element, just to retrieve the repaint rect.

        * rendering/RenderForeignObject.cpp:
        (WebCore::RenderForeignObject::layout):
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::setNeedsBoundariesUpdate):
        * rendering/RenderObject.h:
        * rendering/RenderObjectChildList.cpp:
        (WebCore::RenderObjectChildList::removeChildNode):
        * rendering/RenderPath.cpp:
        (WebCore::RenderPath::layout):
        (WebCore::RenderPath::paint):
        * rendering/RenderPath.h:
        (WebCore::RenderPath::path):
        (WebCore::RenderPath::setNeedsBoundariesUpdate):
        * rendering/RenderSVGBlock.cpp:
        (WebCore::RenderSVGBlock::styleWillChange):
        * rendering/RenderSVGBlock.h:
        * rendering/RenderSVGContainer.cpp:
        (WebCore::RenderSVGContainer::RenderSVGContainer):
        (WebCore::RenderSVGContainer::layout):
        (WebCore::RenderSVGContainer::paint):
        (WebCore::RenderSVGContainer::updateCachedBoundaries):
        * rendering/RenderSVGContainer.h:
        (WebCore::RenderSVGContainer::setNeedsBoundariesUpdate):
        (WebCore::RenderSVGContainer::objectBoundingBox):
        (WebCore::RenderSVGContainer::strokeBoundingBox):
        (WebCore::RenderSVGContainer::repaintRectInLocalCoordinates):
        (WebCore::RenderSVGContainer::calculateLocalTransform):
        * rendering/RenderSVGGradientStop.h:
        (WebCore::RenderSVGGradientStop::strokeBoundingBox):
        * rendering/RenderSVGHiddenContainer.cpp:
        * rendering/RenderSVGHiddenContainer.h:
        (WebCore::RenderSVGHiddenContainer::clippedOverflowRectForRepaint):
        * rendering/RenderSVGImage.cpp:
        (WebCore::RenderSVGImage::layout):
        (WebCore::RenderSVGImage::styleWillChange):
        * rendering/RenderSVGImage.h:
        * rendering/RenderSVGInline.cpp:
        (WebCore::RenderSVGInline::styleWillChange):
        * rendering/RenderSVGInline.h:
        * rendering/RenderSVGModelObject.cpp:
        (WebCore::RenderSVGModelObject::styleWillChange):
        * rendering/RenderSVGModelObject.h:
        * rendering/RenderSVGRoot.cpp:
        (WebCore::RenderSVGRoot::RenderSVGRoot):
        (WebCore::RenderSVGRoot::layout):
        (WebCore::RenderSVGRoot::styleWillChange):
        (WebCore::RenderSVGRoot::updateCachedBoundaries):
        * rendering/RenderSVGRoot.h:
        (WebCore::RenderSVGRoot::setNeedsBoundariesUpdate):
        (WebCore::RenderSVGRoot::setNeedsTransformUpdate):
        (WebCore::RenderSVGRoot::objectBoundingBox):
        (WebCore::RenderSVGRoot::strokeBoundingBox):
        (WebCore::RenderSVGRoot::repaintRectInLocalCoordinates):
        * rendering/RenderSVGText.cpp:
        (WebCore::RenderSVGText::layout):
        * rendering/RenderSVGTransformableContainer.cpp:
        (WebCore::RenderSVGTransformableContainer::calculateLocalTransform):
        * rendering/RenderSVGTransformableContainer.h:
        * rendering/RenderSVGViewportContainer.cpp:
        (WebCore::RenderSVGViewportContainer::calcViewport):
        * rendering/SVGRenderSupport.cpp:
        (WebCore::SVGRenderSupport::computeContainerBoundingBoxes):
        (WebCore::SVGRenderSupport::paintInfoIntersectsRepaintRect):
        * rendering/SVGRenderSupport.h:
        * rendering/style/SVGRenderStyle.cpp:
        (WebCore::SVGRenderStyle::diff):

2010-08-30  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Add culling to RenderSVGContainer
        https://bugs.webkit.org/show_bug.cgi?id=44896

        Update some pixel test results, that show marginal changes.

        * platform/mac-leopard/svg/css/composite-shadow-example-expected.checksum:
        * platform/mac-leopard/svg/css/composite-shadow-example-expected.png:
        * platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.checksum:
        * platform/mac-leopard/svg/css/composite-shadow-with-opacity-expected.png:
        * platform/mac/svg/css/composite-shadow-example-expected.txt:
        * platform/mac/svg/css/composite-shadow-with-opacity-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66418 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Leandro Pereira <leandro@profusion.mobi>
leandro@webkit.org [Mon, 30 Aug 2010 22:31:53 +0000 (22:31 +0000)]
2010-08-30  Leandro Pereira  <leandro@profusion.mobi>

        [EFL] Unreviewed. Build fix when ENABLE_WEB_SOCKETS=ON.

        EFL port does not yet support automated tests.

        * CMakeLists.txt: Add missing files.
        * CMakeListsEfl.txt: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66417 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Kenneth Russell <kbr@google.com>
kbr@google.com [Mon, 30 Aug 2010 22:28:04 +0000 (22:28 +0000)]
2010-08-30  Kenneth Russell  <kbr@google.com>

        Reviewed by Chris Marrin.

        Expose Vector3 and associated operations
        https://bugs.webkit.org/show_bug.cgi?id=44666

        Rolling out earlier patch exposing Vector3 class in
        TransformationMatrix.h. A different approach will be taken under
        another bug.

        * platform/graphics/transforms/TransformationMatrix.cpp:
        (WebCore::v3Length):
        (WebCore::v3Scale):
        (WebCore::v3Dot):
        (WebCore::v3Combine):
        (WebCore::v3Cross):
        (WebCore::decompose):
        * platform/graphics/transforms/TransformationMatrix.ha:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66416 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoBuild fix; Unreviewed.
jer.noble@apple.com [Mon, 30 Aug 2010 22:25:08 +0000 (22:25 +0000)]
Build fix; Unreviewed.

Added a export symbol to the WebCore.exp.in list.

* WebCore.exp.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66415 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Chris Rogers <crogers@google.com>
crogers@google.com [Mon, 30 Aug 2010 22:20:39 +0000 (22:20 +0000)]
2010-08-30  Chris Rogers  <crogers@google.com>

        Reviewed by Kenneth Russell.

        Add audio cone effect files.  The cone effect operates as defined in the OpenAL specification.
        https://bugs.webkit.org/show_bug.cgi?id=44712

        No new tests since audio API not implemented yet.

        * platform/audio: Added.
        * platform/audio/Cone.cpp: Added.
        (WebCore::ConeEffect::ConeEffect):
        (WebCore::ConeEffect::gain):
        * platform/audio/Cone.h: Added.
        (WebCore::ConeEffect::setInnerAngle):
        (WebCore::ConeEffect::innerAngle):
        (WebCore::ConeEffect::setOuterAngle):
        (WebCore::ConeEffect::outerAngle):
        (WebCore::ConeEffect::setOuterGain):
        (WebCore::ConeEffect::outerGain):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66414 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Chris Rogers <crogers@google.com>
crogers@google.com [Mon, 30 Aug 2010 22:16:20 +0000 (22:16 +0000)]
2010-08-30  Chris Rogers  <crogers@google.com>

        Reviewed by Chris Marrin.

        audio engine: add Reverb class
        https://bugs.webkit.org/show_bug.cgi?id=36466

        No new tests since audio API is not yet implemented.

        * platform/audio: Added.
        * platform/audio/Reverb.cpp: Added.
        (WebCore::calculateNormalizationScale):
        (WebCore::Reverb::Reverb):
        (WebCore::Reverb::initialize):
        (WebCore::Reverb::process):
        (WebCore::Reverb::reset):
        * platform/audio/Reverb.h: Added.
        (WebCore::Reverb::):
        (WebCore::Reverb::impulseResponseLength):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66413 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Chris Rogers <crogers@google.com>
crogers@google.com [Mon, 30 Aug 2010 22:10:01 +0000 (22:10 +0000)]
2010-08-30  Chris Rogers  <crogers@google.com>

        Unreviewed

        Add WebCore/platform/audio directory
        in preparation for landing: https://bugs.webkit.org/show_bug.cgi?id=36466

        * platform/audio: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66412 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-27 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Mon, 30 Aug 2010 21:47:07 +0000 (21:47 +0000)]
2010-08-27  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        text/plain non-video files cause <video> to hang (while reading them?)
        https://bugs.webkit.org/show_bug.cgi?id=44212

        Add the new WebKitSystemInterface function WKQTMovieDisableComponent to
        the initialization routine.

        * WebCoreSupport/WebSystemInterface.mm:
        (InitWebCoreSystemInterface): Initialize WKQTMovieDisableComponent.
2010-08-27  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        text/plain non-video files cause <video> to hang (while reading them?)
        https://bugs.webkit.org/show_bug.cgi?id=44212

        Disable all the QuickTime components which ingest .txt files.

        New tests:
        * http/tests/media/video-served-as-text.html: Added.
        * http/tests/media/text-served-as-text.html: Added.

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie): Disable all four text
            'eat' components.
        * platform/mac/WebCoreSystemInterface.h: Add wkQTMovieDisableComponent.
        * platform/mac/WebCoreSystemInterface.mm: Add wkQTMovieDisableComponent.
2010-08-27  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        text/plain non-video files cause <video> to hang (while reading them?)
        https://bugs.webkit.org/show_bug.cgi?id=44212

        Added two new tests: video-served-as-text.html and
        text-served-as-text.html.  The second checks that a text file does not
        generates an error when loaded by a <video> element. The first checks
        that media served as text/plain still loads without errors.

        * http/tests/media/resources/test.txt: Added.
        * http/tests/media/text-served-as-text-expected.txt: Added.
        * http/tests/media/text-served-as-text.html: Added.
        * http/tests/media/video-served-as-text-expected.txt: Added.
        * http/tests/media/video-served-as-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66411 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Evan Martin <evan@chromium.org>
evan@chromium.org [Mon, 30 Aug 2010 21:39:23 +0000 (21:39 +0000)]
2010-08-30  Evan Martin  <evan@chromium.org>

        Unreviewed, updating Chromium expectations.

        Revert part of my update in r66406 that was wrong.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66410 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 30 Aug 2010 21:26:00 +0000 (21:26 +0000)]
2010-08-30  Adam Barth  <abarth@webkit.org>

        Reviewed by Alexey Proskuryakov.

        Update LayoutTest for file inputs to show "pass" for fakepath
        https://bugs.webkit.org/show_bug.cgi?id=44882

        As requested by Alexey.

        * editing/pasteboard/file-input-files-access-expected.txt:
        * editing/pasteboard/script-tests/file-input-files-access.js:
        (draggingPathsShouldResultInFiles):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66409 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Robert Hogan <robert@webkit.org>
robert@webkit.org [Mon, 30 Aug 2010 21:16:45 +0000 (21:16 +0000)]
2010-08-30  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        allow ports with windowed plugins to support windowless plugin tests

        https://bugs.webkit.org/show_bug.cgi?id=40730

        Ports that implement plugins windowed by default need to have a way of
        supporting plugin tests that assume the plugin is windowless. Add this
        feature to the tests and support it in the webkit test plugin. Also
        add mouse and keyboard event logging to the webkit-test plugin on Unix.

        Unskip the following tests on Qt:

        plugins/mouse-events.html
        plugins/keyboard-events.html
        plugins/mouse-events-fixedpos.html

        * platform/qt/Skipped:
        * plugins/keyboard-events.html:
        * plugins/mouse-events-fixedpos.html:
        * plugins/mouse-events.html:
2010-08-30  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        allow ports with windowed plugins to support windowless plugin tests

        https://bugs.webkit.org/show_bug.cgi?id=40730

        Ports that implement plugins windowed by default need to have a way of
        supporting plugin tests that assume the plugin is windowless. Add this
        feature to the tests and support it in the webkit test plugin. Also
        add mouse and keyboard event logging to the webkit-test plugin on Unix.

        Unskip the following tests on Qt:

        plugins/mouse-events.html
        plugins/keyboard-events.html
        plugins/mouse-events-fixedpos.html

        * plugins/qt/PluginViewQt.cpp:
        (WebCore::PluginView::setFocus):
        (WebCore::setXKeyEventSpecificFields):
2010-08-30  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        allow ports with windowed plugins to support windowless plugin tests

        https://bugs.webkit.org/show_bug.cgi?id=40730

        Ports that implement plugins windowed by default need to have a way of
        supporting plugin tests that assume the plugin is windowless. Add this
        feature to the tests and support it in the webkit test plugin. Also
        add mouse and keyboard event logging to the webkit-test plugin on Unix.

        Unskip the following tests on Qt:

        plugins/mouse-events.html
        plugins/keyboard-events.html
        plugins/mouse-events-fixedpos.html

        * DumpRenderTree/TestNetscapePlugIn.subproj/PluginObject.cpp:
        (pluginSetProperty):
        * DumpRenderTree/TestNetscapePlugIn.subproj/main.cpp:
        (NPP_New):
        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_handle_event):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66408 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Kinuko Yasuda <kinuko@chromium.osrc>
kinuko@chromium.org [Mon, 30 Aug 2010 20:50:19 +0000 (20:50 +0000)]
2010-08-30  Kinuko Yasuda  <kinuko@chromium.osrc>

        Reviewed by Darin Fisher.

        Add DOMFileSystem implementation to support Entry manipulation operations
        https://bugs.webkit.org/show_bug.cgi?id=44732

        Fixed virtual-path / platform-path conversion timing. (The conversion needs to be done before calling AsyncFileSystem methods to support cross-filesystem operations.)

        * src/AsyncFileSystemChromium.cpp:
        (WebCore::AsyncFileSystemChromium::move):
        (WebCore::AsyncFileSystemChromium::copy):
        (WebCore::AsyncFileSystemChromium::remove):
        (WebCore::AsyncFileSystemChromium::readMetadata):
        (WebCore::AsyncFileSystemChromium::createFile):
        (WebCore::AsyncFileSystemChromium::createDirectory):
        (WebCore::AsyncFileSystemChromium::fileExists):
        (WebCore::AsyncFileSystemChromium::directoryExists):
        (WebCore::AsyncFileSystemChromium::readDirectory):
2010-08-30  Kinuko Yasuda  <kinuko@chromium.org>

        Reviewed by Darin Fisher.

        Add DOMFileSystem implementation to support Entry manipulation operations
        https://bugs.webkit.org/show_bug.cgi?id=44732

        No new tests; tests will be added later.

        * storage/DOMFileSystem.cpp:
        (WebCore::DOMFileSystem::root):
        (WebCore::checkValidityForForCopyOrMove): Added.
        (WebCore::DOMFileSystem::getMetadata): Added.
        (WebCore::DOMFileSystem::move): Added.
        (WebCore::DOMFileSystem::copy): Added.
        (WebCore::DOMFileSystem::remove): Added.
        (WebCore::DOMFileSystem::getParent): Added.
        (WebCore::DOMFileSystem::getFile): Added.
        (WebCore::DOMFileSystem::getDirectory): Added.
        (WebCore::DOMFileSystem::readDirectory): Added.
        * storage/DirectoryEntry.cpp:
        (WebCore::DirectoryEntry::getFile): Added implementation.
        (WebCore::DirectoryEntry::getDirectory): Added implementation.
        * storage/DirectoryReader.cpp:
        (WebCore::DirectoryReader::DirectoryReader): Added implementation.
        (WebCore::DirectoryReader::readEntries): Added implementation.
        * storage/DirectoryReader.h:
        * storage/Entry.cpp:
        (WebCore::Entry::getMetadata): Added implementation.
        (WebCore::Entry::moveTo): Added implementation.
        (WebCore::Entry::copyTo): Added implementation.
        (WebCore::Entry::remove): Added implementation.
        (WebCore::Entry::getParent): Added implementation.
        * storage/Entry.h:
        * storage/FileEntry.h:

        Added a helper template to schedule callbacks.
        * storage/DOMFileSystem.h:
        (WebCore::DOMFileSystem::DispatchCallbackTask): Added to schedule callbacks.
        (WebCore::DOMFileSystem::scheduleCallback): Added to schedule callbacks.

        Changed to fire callbacks asynchronously.
        * storage/LocalFileSystem.cpp:
        (WebCore::LocalFileSystem::requestFileSystem):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66407 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Evan Martin <evan@chromium.org>
evan@chromium.org [Mon, 30 Aug 2010 20:39:05 +0000 (20:39 +0000)]
2010-08-30  Evan Martin  <evan@chromium.org>

        Unreviewed, updating Chromium expectations.

        Simplify some obsolete test expectations based on looking at their
        current behavior on the dashboard.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66406 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[wx] Build fix after addition of fileapi directory in WebCore.
kevino@webkit.org [Mon, 30 Aug 2010 20:20:49 +0000 (20:20 +0000)]
[wx] Build fix after addition of fileapi directory in WebCore.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66405 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 30 Aug 2010 20:16:37 +0000 (20:16 +0000)]
2010-08-30  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        Fixed compilation error, now that we have included the
        GtkVersioning.h we have to remove some version dependent code from
        EventSender.

        * platform/gtk/GtkVersioning.c:
        (gdk_window_get_root_coords):
        * platform/gtk/GtkVersioning.h:

2010-08-30  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        Fixed compilation error, now that we have included the
        GtkVersioning.h we have to remove some version dependent code from
        EventSender.

        * DumpRenderTree/gtk/EventSender.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66404 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=44804 Crashes in
bdakin@apple.com [Mon, 30 Aug 2010 20:03:20 +0000 (20:03 +0000)]
WebCore: Fix for https://bugs.webkit.org/show_bug.cgi?id=44804 Crashes in
RenderMathMLRoot::layout() and RenderMathMLRoot::paint()
-and corresponding-
<rdar://problem/8342055>

Reviewed by Sam Weinig.

All of the calls to firstChild() and lastChild() in
RenderMathMLRoot::layout() and RenderMathMLRoot::paint() need to be
null checked.

* mathml/RenderMathMLRoot.cpp:
(WebCore::RenderMathMLRoot::paint):
(WebCore::RenderMathMLRoot::layout):

LayoutTests: Tests for https://bugs.webkit.org/show_bug.cgi?id=44804 Crashes in
RenderMathMLRoot::layout() and RenderMathMLRoot::paint()
-and-
https://bugs.webkit.org/show_bug.cgi?id=44801 Crash in
RenderMathMLSubSup::layout()

Reviewed by Sam Weinig.

* mathml/empty-mroot-crash-expected.txt: Added.
* mathml/empty-mroot-crash.xhtml: Added.
* mathml/msubsup-no-grandchild-expected.txt: Added.
* mathml/msubsup-no-grandchild.xhtml: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66403 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoFix for https://bugs.webkit.org/show_bug.cgi?id=44801 Crash in
bdakin@apple.com [Mon, 30 Aug 2010 19:56:57 +0000 (19:56 +0000)]
Fix for https://bugs.webkit.org/show_bug.cgi?id=44801 Crash in
RenderMathMLSubSup::layout()
-and corresponding-
<rdar://problem/8325203>

Reviewed by Darin Adler.

Null-check m_scripts. It is null-checked everywhere else in the
class and can legitimately be null.

* mathml/RenderMathMLSubSup.cpp:
(WebCore::RenderMathMLSubSup::layout):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66402 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Andy Estes <aestes@apple.com>
aestes@apple.com [Mon, 30 Aug 2010 19:27:36 +0000 (19:27 +0000)]
2010-08-30  Andy Estes  <aestes@apple.com>

        Reviewed by Eric Carlson.

        Strings returned by asciiDebug() should be NULL-terminated.
        https://bugs.webkit.org/show_bug.cgi?id=44866

        * wtf/text/WTFString.cpp:
        (asciiDebug):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66401 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 30 Aug 2010 19:21:18 +0000 (19:21 +0000)]
2010-08-30  Martin Robinson  <mrobinson@igalia.com>

        Unskip passing philip canvas tests and unskip and add results for some more shadow tests.

        * platform/gtk/Skipped:
        * platform/gtk/svg/css/composite-shadow-example-expected.checksum: Added.
        * platform/gtk/svg/css/composite-shadow-example-expected.png: Added.
        * platform/gtk/svg/css/composite-shadow-example-expected.txt: Added.
        * platform/gtk/svg/css/composite-shadow-text-expected.checksum: Added.
        * platform/gtk/svg/css/composite-shadow-text-expected.png: Added.
        * platform/gtk/svg/css/composite-shadow-text-expected.txt: Added.
        * platform/gtk/svg/css/shadow-with-large-radius-expected.checksum: Added.
        * platform/gtk/svg/css/shadow-with-large-radius-expected.png: Added.
        * platform/gtk/svg/css/shadow-with-large-radius-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-with-large-radius-expected.txt.
        * platform/gtk/svg/css/shadow-with-negative-offset-expected.checksum: Added.
        * platform/gtk/svg/css/shadow-with-negative-offset-expected.png: Added.
        * platform/gtk/svg/css/shadow-with-negative-offset-expected.txt: Copied from LayoutTests/platform/mac/svg/css/shadow-with-negative-offset-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66400 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoMoved my name from committer to reviewer
cmarrin@apple.com [Mon, 30 Aug 2010 19:06:36 +0000 (19:06 +0000)]
Moved my name from committer to reviewer

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66399 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 30 Aug 2010 19:06:06 +0000 (19:06 +0000)]
2010-08-30  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
        are deprecated
        https://bugs.webkit.org/show_bug.cgi?id=44787

        We have replaced GtkVersioning.cpp with GtkVersioning.c and
        created a function (getDefaultGDKPointerDevice) to get the pointer
        of the window with the new APIs. We added that function to DRT and
        copyandpaste unit test.

        * GNUmakefile.am:
        * platform/gtk/GtkVersioning.c: Added.
        (gtk_adjustment_set_value):
        (gtk_adjustment_configure):
        (getDefaultGDKPointerDevice):
        * platform/gtk/GtkVersioning.cpp: Removed.
        * platform/gtk/GtkVersioning.h:

2010-08-30  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
        are deprecated
        https://bugs.webkit.org/show_bug.cgi?id=44787

        We have replaced GtkVersioning.cpp with GtkVersioning.c and
        created a function (getDefaultGDKPointerDevice) to get the pointer
        of the window with the new APIs. We added that function to DRT and
        copyandpaste unit test.

        * GNUmakefile.am:

2010-08-30  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Martin Robinson.

        [Gtk] gdk_display_get_core_pointer and gdk_device_get_core_pointer
        are deprecated
        https://bugs.webkit.org/show_bug.cgi?id=44787

        We have replaced GtkVersioning.cpp with GtkVersioning.c and
        created a function (getDefaultGDKPointerDevice) to get the pointer
        of the window with the new APIs. We added that function to DRT and
        copyandpaste unit test.

        * DumpRenderTree/gtk/EventSender.cpp:
        (prepareMouseButtonEvent):
        (mouseMoveToCallback):
        (keyDownCallback):
        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66398 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 30 Aug 2010 18:44:06 +0000 (18:44 +0000)]
2010-08-30  Darin Adler  <darin@apple.com>

        Reviewed by Sam Weinig.

        Make SVG constructors private to make sure callers all use create
        https://bugs.webkit.org/show_bug.cgi?id=44872

        Made as many members private and protected as possible, and got rid of many
        unneeded empty constructor and destructor definitions, in some cases changing
        a class to be non-polymorphic. Made some functions inline. Used the word document
        instead of the abbreviation doc. Removed unneeded explicit base class
        initialization in cases where it is no different from the default behavior.

        * svg/SVGAElement.cpp:
        (WebCore::SVGAElement::SVGAElement):
        (WebCore::SVGAElement::childShouldCreateRenderer):
        * svg/SVGAElement.h:
        * svg/SVGAltGlyphElement.cpp:
        (WebCore::SVGAltGlyphElement::SVGAltGlyphElement):
        * svg/SVGAltGlyphElement.h:
        * svg/SVGAngle.cpp:
        * svg/SVGAngle.h:
        * svg/SVGAnimateColorElement.cpp:
        (WebCore::SVGAnimateColorElement::SVGAnimateColorElement):
        * svg/SVGAnimateColorElement.h:
        * svg/SVGAnimateElement.cpp:
        (WebCore::SVGAnimateElement::SVGAnimateElement):
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimateMotionElement.cpp:
        (WebCore::SVGAnimateMotionElement::SVGAnimateMotionElement):
        * svg/SVGAnimateMotionElement.h:
        * svg/SVGAnimateTransformElement.cpp:
        (WebCore::SVGAnimateTransformElement::SVGAnimateTransformElement):
        * svg/SVGAnimateTransformElement.h:
        * svg/SVGAnimatedPathData.cpp:
        * svg/SVGAnimatedPathData.h:
        * svg/SVGAnimatedPoints.cpp:
        * svg/SVGAnimatedPoints.h:
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::SVGAnimationElement):
        * svg/SVGAnimationElement.h:
        * svg/SVGCircleElement.cpp:
        (WebCore::SVGCircleElement::SVGCircleElement):
        * svg/SVGCircleElement.h:
        * svg/SVGClipPathElement.cpp:
        (WebCore::SVGClipPathElement::SVGClipPathElement):
        * svg/SVGClipPathElement.h:
        * svg/SVGColor.cpp:
        * svg/SVGColor.h:
        * svg/SVGComponentTransferFunctionElement.cpp:
        (WebCore::SVGComponentTransferFunctionElement::SVGComponentTransferFunctionElement):
        * svg/SVGComponentTransferFunctionElement.h:
        * svg/SVGCursorElement.cpp:
        (WebCore::SVGCursorElement::SVGCursorElement):
        * svg/SVGCursorElement.h:
        * svg/SVGDefsElement.cpp:
        (WebCore::SVGDefsElement::SVGDefsElement):
        * svg/SVGDefsElement.h:
        * svg/SVGDescElement.cpp:
        (WebCore::SVGDescElement::SVGDescElement):
        * svg/SVGDescElement.h:
        * svg/SVGDocument.cpp:
        * svg/SVGDocument.h:
        * svg/SVGDocumentExtensions.cpp:
        (WebCore::SVGDocumentExtensions::SVGDocumentExtensions):
        (WebCore::SVGDocumentExtensions::reportWarning):
        (WebCore::SVGDocumentExtensions::reportError):
        * svg/SVGDocumentExtensions.h:
        * svg/SVGElement.h:
        * svg/SVGElementInstanceList.h:
        * svg/SVGEllipseElement.cpp:
        (WebCore::SVGEllipseElement::SVGEllipseElement):
        * svg/SVGEllipseElement.h:
        * svg/SVGExternalResourcesRequired.cpp:
        * svg/SVGExternalResourcesRequired.h:
        * svg/SVGFEBlendElement.cpp:
        (WebCore::SVGFEBlendElement::SVGFEBlendElement):
        * svg/SVGFEBlendElement.h:
        * svg/SVGFEColorMatrixElement.cpp:
        (WebCore::SVGFEColorMatrixElement::SVGFEColorMatrixElement):
        * svg/SVGFEColorMatrixElement.h:
        * svg/SVGFEComponentTransferElement.cpp:
        (WebCore::SVGFEComponentTransferElement::SVGFEComponentTransferElement):
        * svg/SVGFEComponentTransferElement.h:
        * svg/SVGFECompositeElement.cpp:
        (WebCore::SVGFECompositeElement::SVGFECompositeElement):
        * svg/SVGFECompositeElement.h:
        * svg/SVGFEConvolveMatrixElement.cpp:
        (WebCore::SVGFEConvolveMatrixElement::SVGFEConvolveMatrixElement):
        * svg/SVGFEConvolveMatrixElement.h:
        * svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::SVGFEDiffuseLightingElement):
        * svg/SVGFEDiffuseLightingElement.h:
        * svg/SVGFEDisplacementMapElement.cpp:
        (WebCore::SVGFEDisplacementMapElement::SVGFEDisplacementMapElement):
        * svg/SVGFEDisplacementMapElement.h:
        * svg/SVGFEDistantLightElement.cpp:
        (WebCore::SVGFEDistantLightElement::SVGFEDistantLightElement):
        * svg/SVGFEDistantLightElement.h:
        * svg/SVGFEFloodElement.cpp:
        (WebCore::SVGFEFloodElement::SVGFEFloodElement):
        * svg/SVGFEFloodElement.h:
        * svg/SVGFEFuncAElement.cpp:
        (WebCore::SVGFEFuncAElement::SVGFEFuncAElement):
        * svg/SVGFEFuncAElement.h:
        * svg/SVGFEFuncBElement.cpp:
        (WebCore::SVGFEFuncBElement::SVGFEFuncBElement):
        * svg/SVGFEFuncBElement.h:
        * svg/SVGFEFuncGElement.cpp:
        (WebCore::SVGFEFuncGElement::SVGFEFuncGElement):
        * svg/SVGFEFuncGElement.h:
        * svg/SVGFEFuncRElement.cpp:
        (WebCore::SVGFEFuncRElement::SVGFEFuncRElement):
        * svg/SVGFEFuncRElement.h:
        * svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::SVGFEGaussianBlurElement):
        * svg/SVGFEGaussianBlurElement.h:
        * svg/SVGFEImageElement.cpp:
        (WebCore::SVGFEImageElement::SVGFEImageElement):
        * svg/SVGFEImageElement.h:
        * svg/SVGFELightElement.cpp:
        (WebCore::SVGFELightElement::SVGFELightElement):
        * svg/SVGFELightElement.h:
        * svg/SVGFEMergeElement.cpp:
        (WebCore::SVGFEMergeElement::SVGFEMergeElement):
        * svg/SVGFEMergeElement.h:
        * svg/SVGFEMergeNodeElement.cpp:
        (WebCore::SVGFEMergeNodeElement::SVGFEMergeNodeElement):
        * svg/SVGFEMergeNodeElement.h:
        * svg/SVGFEMorphologyElement.cpp:
        (WebCore::SVGFEMorphologyElement::SVGFEMorphologyElement):
        * svg/SVGFEMorphologyElement.h:
        * svg/SVGFEOffsetElement.cpp:
        (WebCore::SVGFEOffsetElement::SVGFEOffsetElement):
        * svg/SVGFEOffsetElement.h:
        * svg/SVGFEPointLightElement.cpp:
        (WebCore::SVGFEPointLightElement::SVGFEPointLightElement):
        (WebCore::SVGFEPointLightElement::lightSource):
        * svg/SVGFEPointLightElement.h:
        * svg/SVGFESpecularLightingElement.cpp:
        (WebCore::SVGFESpecularLightingElement::SVGFESpecularLightingElement):
        * svg/SVGFESpecularLightingElement.h:
        * svg/SVGFESpotLightElement.cpp:
        (WebCore::SVGFESpotLightElement::SVGFESpotLightElement):
        * svg/SVGFESpotLightElement.h:
        * svg/SVGFETileElement.cpp:
        (WebCore::SVGFETileElement::SVGFETileElement):
        * svg/SVGFETileElement.h:
        * svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::SVGFETurbulenceElement):
        * svg/SVGFETurbulenceElement.h:
        * svg/SVGFilterElement.cpp:
        (WebCore::SVGFilterElement::SVGFilterElement):
        * svg/SVGFilterElement.h:
        * svg/SVGFilterPrimitiveStandardAttributes.cpp:
        (WebCore::SVGFilterPrimitiveStandardAttributes::SVGFilterPrimitiveStandardAttributes):
        * svg/SVGFilterPrimitiveStandardAttributes.h:
        * svg/SVGFitToViewBox.cpp:
        * svg/SVGFitToViewBox.h:
        * svg/SVGFontData.cpp:
        * svg/SVGFontData.h:
        * svg/SVGFontElement.cpp:
        (WebCore::SVGFontElement::SVGFontElement):
        * svg/SVGFontElement.h:
        * svg/SVGFontFaceElement.cpp:
        (WebCore::SVGFontFaceElement::SVGFontFaceElement):
        * svg/SVGFontFaceElement.h:
        * svg/SVGFontFaceFormatElement.cpp:
        (WebCore::SVGFontFaceFormatElement::SVGFontFaceFormatElement):
        * svg/SVGFontFaceFormatElement.h:
        * svg/SVGFontFaceNameElement.cpp:
        (WebCore::SVGFontFaceNameElement::SVGFontFaceNameElement):
        * svg/SVGFontFaceNameElement.h:
        * svg/SVGFontFaceSrcElement.cpp:
        (WebCore::SVGFontFaceSrcElement::SVGFontFaceSrcElement):
        * svg/SVGFontFaceSrcElement.h:
        * svg/SVGFontFaceUriElement.cpp:
        (WebCore::SVGFontFaceUriElement::SVGFontFaceUriElement):
        * svg/SVGFontFaceUriElement.h:
        * svg/SVGForeignObjectElement.cpp:
        (WebCore::SVGForeignObjectElement::SVGForeignObjectElement):
        * svg/SVGForeignObjectElement.h:
        * svg/SVGGElement.cpp:
        (WebCore::SVGGElement::SVGGElement):
        * svg/SVGGElement.h:
        * svg/SVGGlyphElement.cpp:
        (WebCore::SVGGlyphElement::SVGGlyphElement):
        * svg/SVGGlyphElement.h:
        * svg/SVGGradientElement.cpp:
        (WebCore::SVGGradientElement::SVGGradientElement):
        * svg/SVGGradientElement.h:
        * svg/SVGHKernElement.cpp:
        (WebCore::SVGHKernElement::SVGHKernElement):
        * svg/SVGHKernElement.h:
        * svg/SVGImageElement.cpp:
        (WebCore::SVGImageElement::SVGImageElement):
        * svg/SVGImageElement.h:
        * svg/SVGImageLoader.cpp:
        * svg/SVGImageLoader.h:
        * svg/SVGLangSpace.cpp:
        * svg/SVGLangSpace.h:
        * svg/SVGLengthList.cpp:
        * svg/SVGLengthList.h:
        * svg/SVGLineElement.cpp:
        (WebCore::SVGLineElement::SVGLineElement):
        * svg/SVGLineElement.h:
        * svg/SVGLinearGradientElement.cpp:
        (WebCore::SVGLinearGradientElement::SVGLinearGradientElement):
        * svg/SVGLinearGradientElement.h:
        * svg/SVGLocatable.cpp:
        * svg/SVGLocatable.h:
        * svg/SVGMPathElement.cpp:
        (WebCore::SVGMPathElement::SVGMPathElement):
        * svg/SVGMPathElement.h:
        * svg/SVGMarkerElement.cpp:
        (WebCore::SVGMarkerElement::SVGMarkerElement):
        * svg/SVGMarkerElement.h:
        * svg/SVGMaskElement.cpp:
        (WebCore::SVGMaskElement::SVGMaskElement):
        * svg/SVGMaskElement.h:
        * svg/SVGMetadataElement.cpp:
        (WebCore::SVGMetadataElement::SVGMetadataElement):
        * svg/SVGMetadataElement.h:
        * svg/SVGMissingGlyphElement.cpp:
        (WebCore::SVGMissingGlyphElement::SVGMissingGlyphElement):
        * svg/SVGMissingGlyphElement.h:
        * svg/SVGNumberList.cpp:
        * svg/SVGNumberList.h:
        * svg/SVGPaint.cpp:
        * svg/SVGPaint.h:
        * svg/SVGParserUtilities.cpp:
        (WebCore::genericParseNumber):
        (WebCore::parseNumber):
        * svg/SVGPathBlender.cpp:
        * svg/SVGPathBlender.h:
        * svg/SVGPathBuilder.h:
        * svg/SVGPathByteStreamBuilder.h:
        * svg/SVGPathByteStreamSource.cpp:
        * svg/SVGPathByteStreamSource.h:
        * svg/SVGPathConsumer.h:
        * svg/SVGPathElement.cpp:
        (WebCore::SVGPathElement::SVGPathElement):
        * svg/SVGPathElement.h:
        * svg/SVGPathParser.cpp:
        * svg/SVGPathParser.h:
        * svg/SVGPathSeg.cpp:
        * svg/SVGPathSeg.h:
        * svg/SVGPathSegArc.h:
        * svg/SVGPathSegClosePath.cpp:
        * svg/SVGPathSegClosePath.h:
        * svg/SVGPathSegCurvetoCubic.h:
        * svg/SVGPathSegCurvetoCubicSmooth.h:
        * svg/SVGPathSegCurvetoQuadratic.h:
        * svg/SVGPathSegCurvetoQuadraticSmooth.h:
        * svg/SVGPathSegLineto.h:
        * svg/SVGPathSegLinetoHorizontal.h:
        * svg/SVGPathSegLinetoVertical.h:
        * svg/SVGPathSegList.cpp:
        * svg/SVGPathSegList.h:
        * svg/SVGPathSegListBuilder.h:
        * svg/SVGPathSegListSource.cpp:
        * svg/SVGPathSegListSource.h:
        * svg/SVGPathSegMoveto.h:
        * svg/SVGPathSource.h:
        * svg/SVGPathStringBuilder.cpp:
        * svg/SVGPathStringBuilder.h:
        * svg/SVGPathStringSource.cpp:
        * svg/SVGPathStringSource.h:
        * svg/SVGPatternElement.cpp:
        (WebCore::SVGPatternElement::SVGPatternElement):
        * svg/SVGPatternElement.h:
        * svg/SVGPointList.cpp:
        * svg/SVGPointList.h:
        * svg/SVGPolyElement.cpp:
        (WebCore::SVGPolyElement::SVGPolyElement):
        * svg/SVGPolyElement.h:
        * svg/SVGPolygonElement.cpp:
        (WebCore::SVGPolygonElement::SVGPolygonElement):
        * svg/SVGPolygonElement.h:
        * svg/SVGPolylineElement.cpp:
        (WebCore::SVGPolylineElement::SVGPolylineElement):
        * svg/SVGPolylineElement.h:
        * svg/SVGPreserveAspectRatio.cpp:
        * svg/SVGPreserveAspectRatio.h:
        * svg/SVGRadialGradientElement.cpp:
        (WebCore::SVGRadialGradientElement::SVGRadialGradientElement):
        * svg/SVGRadialGradientElement.h:
        * svg/SVGRectElement.cpp:
        (WebCore::SVGRectElement::SVGRectElement):
        * svg/SVGRectElement.h:
        * svg/SVGSVGElement.h:
        * svg/SVGScriptElement.cpp:
        (WebCore::SVGScriptElement::SVGScriptElement):
        * svg/SVGScriptElement.h:
        * svg/SVGSetElement.cpp:
        (WebCore::SVGSetElement::SVGSetElement):
        * svg/SVGSetElement.h:
        * svg/SVGStopElement.cpp:
        (WebCore::SVGStopElement::SVGStopElement):
        * svg/SVGStopElement.h:
        * svg/SVGStringList.cpp:
        * svg/SVGStringList.h:
        * svg/SVGStylable.cpp:
        * svg/SVGStylable.h:
        * svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::SVGStyleElement):
        * svg/SVGStyleElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::SVGStyledElement):
        * svg/SVGStyledElement.h:
        * svg/SVGStyledLocatableElement.cpp:
        (WebCore::SVGStyledLocatableElement::SVGStyledLocatableElement):
        * svg/SVGStyledLocatableElement.h:
        * svg/SVGStyledTransformableElement.cpp:
        (WebCore::SVGStyledTransformableElement::SVGStyledTransformableElement):
        * svg/SVGStyledTransformableElement.h:
        * svg/SVGSwitchElement.cpp:
        (WebCore::SVGSwitchElement::SVGSwitchElement):
        (WebCore::SVGSwitchElement::childShouldCreateRenderer):
        * svg/SVGSwitchElement.h:
        * svg/SVGSymbolElement.cpp:
        (WebCore::SVGSymbolElement::SVGSymbolElement):
        * svg/SVGSymbolElement.h:
        * svg/SVGTRefElement.cpp:
        (WebCore::SVGTRefElement::SVGTRefElement):
        * svg/SVGTRefElement.h:
        * svg/SVGTSpanElement.cpp:
        (WebCore::SVGTSpanElement::SVGTSpanElement):
        * svg/SVGTests.cpp:
        * svg/SVGTests.h:
        * svg/SVGTextContentElement.cpp:
        (WebCore::SVGTextContentElement::SVGTextContentElement):
        * svg/SVGTextContentElement.h:
        * svg/SVGTextElement.cpp:
        (WebCore::SVGTextElement::SVGTextElement):
        * svg/SVGTextElement.h:
        * svg/SVGTextPathElement.cpp:
        (WebCore::SVGTextPathElement::SVGTextPathElement):
        * svg/SVGTextPathElement.h:
        * svg/SVGTextPositioningElement.cpp:
        (WebCore::SVGTextPositioningElement::SVGTextPositioningElement):
        * svg/SVGTextPositioningElement.h:
        * svg/SVGTitleElement.cpp:
        (WebCore::SVGTitleElement::SVGTitleElement):
        * svg/SVGTransform.cpp:
        * svg/SVGTransform.h:
        * svg/SVGTransformable.cpp:
        * svg/SVGTransformable.h:
        * svg/SVGURIReference.cpp:
        * svg/SVGURIReference.h:
        * svg/SVGUseElement.cpp:
        (WebCore::SVGUseElement::SVGUseElement):
        (WebCore::SVGUseElement::expandSymbolElementsInShadowTree):
        * svg/SVGUseElement.h:
        * svg/SVGViewElement.cpp:
        (WebCore::SVGViewElement::SVGViewElement):
        * svg/SVGViewElement.h:
        * svg/SVGViewSpec.cpp:
        (WebCore::SVGViewSpec::SVGViewSpec):
        * svg/SVGViewSpec.h:
        * svg/SVGZoomAndPan.cpp:
        * svg/SVGZoomAndPan.h:
        * svg/SVGZoomEvent.cpp:
        * svg/SVGZoomEvent.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66397 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years agoWorkQueue leaks its dispatch queue
andersca@apple.com [Mon, 30 Aug 2010 17:35:33 +0000 (17:35 +0000)]
WorkQueue leaks its dispatch queue
<rdar://problem/8358509>
https://bugs.webkit.org/show_bug.cgi?id=44689

Reviewed by Sam Weinig.

* Platform/mac/WorkQueueMac.cpp:
(WorkQueue::platformInvalidate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66396 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Eric Carlson <eric.carlson@apple.com>
eric.carlson@apple.com [Mon, 30 Aug 2010 17:18:32 +0000 (17:18 +0000)]
2010-08-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Disable automatic looping
        https://bugs.webkit.org/show_bug.cgi?id=44844

        Test: media/video-does-not-loop.html

        * platform/graphics/mac/MediaPlayerPrivateQTKit.mm:
        (WebCore::MediaPlayerPrivate::createQTMovie): Disable QuickTime automatic looping.

        * platform/graphics/win/QTMovie.cpp:
        (QTMoviePrivate::createMovieController): Ditto.

2010-08-30  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Dan Bernstein.

        Disable automatic looping
        https://bugs.webkit.org/show_bug.cgi?id=44844

        * media/content/silence-loop.mov: Added.
        * media/video-does-not-loop-expected.txt: Added.
        * media/video-does-not-loop.html: Added.
        * platform/chromium/test_expectations.txt: Skip new test.
        * platform/gtk/Skipped: Ditto.
        * platform/qt/Skipped: Ditto.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66395 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Mon, 30 Aug 2010 17:12:10 +0000 (17:12 +0000)]
2010-08-30  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Darin Adler.

        ApplyStyleCommand::applyInlineStyle needs cleanup
        https://bugs.webkit.org/show_bug.cgi?id=44458

        Cleanup:
        1. Isolated code to find the highest ancestor with embedding style, and deployed it in
           ApplyStyleCommand::applyInlineStyle.
        2. Combined the code to remove embedding style up to enclosing block and the code to
           remove unicode-bidi and direction properties between start and end nodes.
        3. Simplified the conditionals to apply embedding styles.

        No new tests are added since this is a cleanup.

        * editing/ApplyStyleCommand.cpp:
        (WebCore::highestEmbeddingAncestor): Added.
        (WebCore::ApplyStyleCommand::applyInlineStyle): See above.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66394 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 30 Aug 2010 16:45:57 +0000 (16:45 +0000)]
2010-08-30  Martin Robinson  <mrobinson@igalia.com>

        Adding layout and pixel results in preparation for landing GTK+ shadow performance improvements.

        * platform/gtk/Skipped: Unskip tests that now have results, skip tests that are definitely failing.
        * platform/gtk/fast/box-shadow/basic-shadows-expected.checksum: Added.
        * platform/gtk/fast/box-shadow/basic-shadows-expected.png: Added.
        * platform/gtk/fast/box-shadow/basic-shadows-expected.txt: Added.
        * platform/gtk/fast/box-shadow/border-radius-big-expected.checksum: Added.
        * platform/gtk/fast/box-shadow/border-radius-big-expected.png: Added.
        * platform/gtk/fast/box-shadow/border-radius-big-expected.txt: Added.
        * platform/gtk/fast/box-shadow/inset-expected.checksum: Added.
        * platform/gtk/fast/box-shadow/inset-expected.png: Added.
        * platform/gtk/fast/box-shadow/inset-expected.txt: Added.
        * platform/gtk/fast/box-shadow/spread-expected.checksum: Added.
        * platform/gtk/fast/box-shadow/spread-expected.png: Added.
        * platform/gtk/fast/box-shadow/spread-expected.txt: Copied from LayoutTests/platform/mac/fast/box-shadow/spread-expected.txt.
        * platform/gtk/fast/box-shadow/transform-fringing-expected.checksum: Added.
        * platform/gtk/fast/box-shadow/transform-fringing-expected.png: Added.
        * platform/gtk/fast/box-shadow/transform-fringing-expected.txt: Added.
        * platform/gtk/fast/canvas/shadow-offset-1-expected.checksum: Added.
        * platform/gtk/fast/canvas/shadow-offset-1-expected.png: Added.
        * platform/gtk/fast/canvas/shadow-offset-1-expected.txt: Added.
        * platform/gtk/fast/canvas/shadow-offset-2-expected.checksum: Added.
        * platform/gtk/fast/canvas/shadow-offset-2-expected.png: Added.
        * platform/gtk/fast/canvas/shadow-offset-2-expected.txt: Added.
        * platform/gtk/fast/canvas/shadow-offset-3-expected.checksum: Added.
        * platform/gtk/fast/canvas/shadow-offset-3-expected.png: Added.
        * platform/gtk/fast/canvas/shadow-offset-3-expected.txt: Added.
        * platform/gtk/fast/canvas/shadow-offset-4-expected.checksum: Added.
        * platform/gtk/fast/canvas/shadow-offset-4-expected.png: Added.
        * platform/gtk/fast/canvas/shadow-offset-4-expected.txt: Added.
        * platform/gtk/fast/canvas/shadow-offset-5-expected.checksum: Added.
        * platform/gtk/fast/canvas/shadow-offset-5-expected.png: Added.
        * platform/gtk/fast/canvas/shadow-offset-5-expected.txt: Added.
        * platform/gtk/fast/canvas/shadow-offset-6-expected.checksum: Added.
        * platform/gtk/fast/canvas/shadow-offset-6-expected.png: Added.
        * platform/gtk/fast/canvas/shadow-offset-6-expected.txt: Added.
        * platform/gtk/fast/canvas/shadow-offset-7-expected.checksum: Added.
        * platform/gtk/fast/canvas/shadow-offset-7-expected.png: Added.
        * platform/gtk/fast/canvas/shadow-offset-7-expected.txt: Added.
        * platform/gtk/fast/css/shadow-multiple-expected.checksum: Added.
        * platform/gtk/fast/css/shadow-multiple-expected.png: Added.
        * platform/gtk/fast/css/shadow-multiple-expected.txt: Added.
        * platform/gtk/fast/forms/box-shadow-override-expected.checksum: Added.
        * platform/gtk/fast/forms/box-shadow-override-expected.png: Added.
        * platform/gtk/fast/forms/box-shadow-override-expected.txt: Added.
        * platform/gtk/fast/text/shadow-no-blur-expected.checksum: Added.
        * platform/gtk/fast/text/shadow-no-blur-expected.png: Added.
        * platform/gtk/fast/text/shadow-no-blur-expected.txt: Added.
        * platform/gtk/fast/transforms/shadows-expected.checksum: Added.
        * platform/gtk/fast/transforms/shadows-expected.png: Added.
        * platform/gtk/fast/transforms/shadows-expected.txt: Copied from LayoutTests/platform/mac/fast/transforms/shadows-expected.txt.
        * platform/gtk/svg/css/arrow-with-shadow-expected.checksum: Added.
        * platform/gtk/svg/css/arrow-with-shadow-expected.png: Added.
        * platform/gtk/svg/css/arrow-with-shadow-expected.txt: Copied from LayoutTests/platform/mac/svg/css/arrow-with-shadow-expected.txt.
        * platform/gtk/svg/css/group-with-shadow-expected.checksum: Added.
        * platform/gtk/svg/css/group-with-shadow-expected.png: Added.
        * platform/gtk/svg/css/group-with-shadow-expected.txt: Added.
        * platform/gtk/svg/css/mask-with-shadow-expected.checksum: Added.
        * platform/gtk/svg/css/mask-with-shadow-expected.png: Added.
        * platform/gtk/svg/css/mask-with-shadow-expected.txt: Added.
        * platform/gtk/svg/css/path-with-shadow-expected.checksum: Added.
        * platform/gtk/svg/css/path-with-shadow-expected.png: Added.
        * platform/gtk/svg/css/path-with-shadow-expected.txt: Copied from LayoutTests/platform/mac/svg/css/path-with-shadow-expected.txt.
        * platform/gtk/svg/css/stars-with-shadow-expected.checksum: Added.
        * platform/gtk/svg/css/stars-with-shadow-expected.png: Added.
        * platform/gtk/svg/css/stars-with-shadow-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66393 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 30 Aug 2010 16:18:47 +0000 (16:18 +0000)]
2010-08-30  Simon Fraser  <simon.fraser@apple.com>

        Disable http/tests/css/css-image-loading.html on Windows.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66392 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-29 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 30 Aug 2010 15:58:03 +0000 (15:58 +0000)]
2010-08-29  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        Fix RenderStyle::addCursor to use a StyleImage, not a CachedImage
        https://bugs.webkit.org/show_bug.cgi?id=44719

        Modernize the CSS cursor code to use a StyleImage, rather
        than a CachedImage in the CursorData, and handle the loading
        of pending images for the cursor property.

        Covered by manual tests in WebCore/manual-tests

        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue):
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty):
        (WebCore::CSSStyleSelector::loadPendingImages):
        * html/canvas/WebGLRenderingContext.cpp:
        * page/EventHandler.cpp:
        (WebCore::EventHandler::selectCursor):
        * rendering/style/CursorData.h:
        (WebCore::CursorData::CursorData):
        (WebCore::CursorData::image):
        (WebCore::CursorData::setImage):
        * rendering/style/CursorList.h:
        (WebCore::CursorList::operator[]):
        * rendering/style/RenderStyle.cpp:
        (WebCore::RenderStyle::addCursor):
        * rendering/style/RenderStyle.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66391 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 30 Aug 2010 15:48:16 +0000 (15:48 +0000)]
2010-08-30  Martin Robinson  <mrobinson@igalia.com>

        Build fix. Add the new fileapi directory to the IDL vpath.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66390 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Mon, 30 Aug 2010 15:16:09 +0000 (15:16 +0000)]
2010-08-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] WebKit DOM bindings build should not depend on output GNUMakefile
        https://bugs.webkit.org/show_bug.cgi?id=44805

        Move the DOM bindings source lists and generator rules to
        WebCore/bindings/gobject/GNUmakefile.am. This will prevent a full WebKit API
        rebuild whenever the automake files change, decreasing build times.

        * GNUmakefile.am:
2010-08-30  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] WebKit DOM bindings build should not depend on output GNUMakefile
        https://bugs.webkit.org/show_bug.cgi?id=44805

        Move WebKit DOM bindings build rules to bindings/gobject/GNUmakefile.am to
        prevent full WebKit API rebuilds when the automake files change.

        No new tests as this is just a build change.

        * bindings/gobject/GNUmakefile.am: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66389 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 30 Aug 2010 14:27:53 +0000 (14:27 +0000)]
2010-08-30  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: event listener properties are rendered as [object Object].
        https://bugs.webkit.org/show_bug.cgi?id=44779

        * inspector/front-end/EventListenersSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66388 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago[Qt] Add new window menu to MiniBrowser
zoltan@webkit.org [Mon, 30 Aug 2010 14:10:47 +0000 (14:10 +0000)]
[Qt] Add new window menu to MiniBrowser

Reviewed by Kenneth Rohde Christiansen.

Implement newWindow function and add a menu item for opening new window in MiniBrowser.

* MiniBrowser/qt/BrowserWindow.cpp:
(BrowserWindow::BrowserWindow):
(BrowserWindow::newWindow):
* MiniBrowser/qt/BrowserWindow.h:
* MiniBrowser/qt/main.cpp:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66386 268f45cc-cd09-0410-ab3c-d52691b4dbfc

9 years ago2010-08-30 Ryuan Choi <ryuan.choi@samsung.com>
commit-queue@webkit.org [Mon, 30 Aug 2010 12:40:17 +0000 (12:40 +0000)]
2010-08-30  Ryuan Choi  <ryuan.choi@samsung.com>

        Unreviewed build fix with Blob Support

        [EFL] Build break with Blob support
        https://bugs.webkit.org/show_bug.cgi?id=44858

        No new features added, so no new tests.

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@66385 268f45cc-cd09-0410-ab3c-d52691b4dbfc