WebKit-https.git
13 years agoLayoutTests:
justing [Tue, 3 Oct 2006 01:08:36 +0000 (01:08 +0000)]
LayoutTests:

        Reviewed by john

        * editing/execCommand/create-list-with-hr-expected.checksum: Added.
        * editing/execCommand/create-list-with-hr-expected.png: Added.
        * editing/execCommand/create-list-with-hr-expected.txt: Added.
        * editing/execCommand/create-list-with-hr.html: Added.

WebCore:

        Reviewed by john

        <rdar://problem/4755287>
        Writely Editor: Crash occurs at WebCore::maxDeepOffset(WebCore::Node const*) when attempting to create a OL/UL following a HR element

        * editing/markup.cpp:
        (WebCore::createMarkup): Migrate to isBlock (isBlockFlow is true for inline replaced
        elements).  Don't skip blocks that aren't containers (like horizontal rules).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-03 Darin Adler <darin@apple.com>
darin [Tue, 3 Oct 2006 01:06:57 +0000 (01:06 +0000)]
2006-10-03  Darin Adler  <darin@apple.com>

        Reviewed by Justin Garcia.

        - correct mistaken code that would restart blinking every
          time "invalidateSelection" is called even if the caret
          has not moved

        * editing/SelectionController.h:
        * editing/SelectionController.cpp:
        (WebCore::SelectionController::setSelection): Update for name change.
        (WebCore::SelectionController::recomputeCaretRect): New function.
        Computes caret rect and does any necessary invalidation if the rect
        changes.
        (WebCore::SelectionController::invalidateCaretRect): Renamed from
        needsCaretRepaint. Invalidates the caret rect unconditionally. Also
        calls recomputeCaretRect as a side effect.

        * page/Frame.cpp:
        (WebCore::Frame::invalidateSelection): Remove unneeded call to
        clearCaretRectIfNeeded.
        (WebCore::Frame::clearCaretRectIfNeeded): Updated for name change.
        (WebCore::Frame::selectionLayoutChanged): Restructured to use the new
        recomputeCaretRect function and not restart blinking if caret has
        not changed position.
        (WebCore::Frame::caretBlinkTimerFired): Removed some checks that
        are not needed since selectionLayoutChanged already checks these.

        * page/FramePrivate.h: Removed unused m_blinkCaret.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
bdakin [Tue, 3 Oct 2006 01:05:40 +0000 (01:05 +0000)]
    Reviewed by Adam.

        Build fix. Add counters to vcproj.

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
mjs [Mon, 2 Oct 2006 23:54:02 +0000 (23:54 +0000)]
    Reviewed by Darin.

        - move a big slice of data and logic from WebDataSource to WebDocumentLoadState

        * Loader/WebDocumentLoadState.h:
        * Loader/WebDocumentLoadState.m:
        (-[WebDocumentLoadState initWithRequest:]):
        (-[WebDocumentLoadState dealloc]):
        (-[WebDocumentLoadState originalRequestCopy]):
        (-[WebDocumentLoadState request]):
        (-[WebDocumentLoadState replaceRequestURLForAnchorScrollWithURL:]):
        (-[WebDocumentLoadState setRequest:]):
        (-[WebDocumentLoadState setResponse:]):
        (-[WebDocumentLoadState isStopping]):
        (-[WebDocumentLoadState bridge]):
        (-[WebDocumentLoadState setMainDocumentError:]):
        (-[WebDocumentLoadState mainDocumentError]):
        (-[WebDocumentLoadState clearErrors]):
        (-[WebDocumentLoadState mainReceivedError:complete:]):
        (-[WebDocumentLoadState stopLoading]):
        (-[WebDocumentLoadState setupForReplace]):
        (-[WebDocumentLoadState commitIfReady]):
        (-[WebDocumentLoadState finishedLoading]):
        (-[WebDocumentLoadState setCommitted:]):
        (-[WebDocumentLoadState isCommitted]):
        (-[WebDocumentLoadState setLoading:]):
        (-[WebDocumentLoadState isLoading]):
        (-[WebDocumentLoadState commitLoadWithData:]):
        (-[WebDocumentLoadState doesProgressiveLoadWithMIMEType:]):
        (-[WebDocumentLoadState receivedData:]):
        (-[WebDocumentLoadState setupForReplaceByMIMEType:]):
        (-[WebDocumentLoadState updateLoading]):
        (-[WebDocumentLoadState response]):
        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader activeDocumentLoadState]):
        (-[WebFrameLoader activeDataSource]):
        (-[WebFrameLoader _archivedSubresourceForURL:]):
        (-[WebFrameLoader addPlugInStreamLoader:]):
        (-[WebFrameLoader removePlugInStreamLoader:]):
        (-[WebFrameLoader addSubresourceLoader:]):
        (-[WebFrameLoader removeSubresourceLoader:]):
        (-[WebFrameLoader documentLoadState]):
        (-[WebFrameLoader provisionalDocumentLoadState]):
        (-[WebFrameLoader stopLoading]):
        (-[WebFrameLoader _originalRequest]):
        (-[WebFrameLoader _receivedData:]):
        (-[WebFrameLoader _setRequest:]):
        (-[WebFrameLoader bridge]):
        (-[WebFrameLoader _handleFallbackContent]):
        (-[WebFrameLoader _isStopping]):
        (-[WebFrameLoader _setupForReplaceByMIMEType:]):
        (-[WebFrameLoader _setResponse:]):
        (-[WebFrameLoader _mainReceivedError:complete:]):
        (-[WebFrameLoader _finishedLoading]):
        (-[WebFrameLoader didReceiveServerRedirectForProvisionalLoadForFrame]):
        (-[WebFrameLoader finishedLoadingDocumentLoadState:]):
        (-[WebFrameLoader commitProvisitionalLoad]):
        (-[WebFrameLoader committedLoadWithDocumentLoadState:data:]):
        (-[WebFrameLoader isReplacing]):
        (-[WebFrameLoader setReplacing]):
        (-[WebFrameLoader revertToProvisionalWithDocumentLoadState:]):
        (-[WebFrameLoader documentLoadState:setMainDocumentError:]):
        (-[WebFrameLoader documentLoadState:mainReceivedCompleteError:]):
        (-[WebFrameLoader finalSetupForReplaceWithDocumentLoadState:]):
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _prepareForLoadStart]):
        (-[WebDataSource _mainDocumentError]):
        (-[WebDataSource _finishedLoading]):
        (-[WebDataSource _receivedData:]):
        (-[WebDataSource _setMainDocumentError:]):
        (-[WebDataSource _clearUnarchivingState]):
        (-[WebDataSource _revertToProvisionalState]):
        (-[WebDataSource _receivedMainResourceError:complete:]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _loadFromPageCache:]):
        (-[WebDataSource _bridge]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource _URLForHistory]):
        (-[WebDataSource _setTitle:]):
        (-[WebDataSource _initWithDocumentLoadState:]):
        (-[WebDataSource request]):
        (-[WebDataSource response]):
        (-[WebDataSource isLoading]):
        (-[WebDataSource webArchive]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebDocumentLoadStateMac.m:
        (-[WebDocumentLoadStateMac initWithRequest:]):
        * WebView/WebFrame.m:
        (-[WebFrame _createItem:]):
        (-[WebFrame _receivedMainResourceError:]):
        (-[WebFrame _transitionToCommitted:]):
        (-[WebFrame _commitProvisionalLoad:]):
        (-[WebFrame _checkLoadCompleteForThisFrame]):
        (-[WebFrame _loadItem:withLoadType:]):
        (-[WebFrame _continueFragmentScrollAfterNavigationPolicy:formState:]):
        (-[WebFrame _didReceiveServerRedirectForProvisionalLoadForFrame]):
        (-[WebFrame _provisionalLoadStarted]):
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele
beidson [Mon, 2 Oct 2006 23:51:21 +0000 (23:51 +0000)]
    Reviewed by Adele

        If the Icon DB schema changes underneath you, the latest ToT can crash and burn when writing
        icon data out because we don't correctly check SQL error conditions.

        * loader/icon/IconDataCache.cpp:
        (WebCore::IconDataCache::writeToDatabase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-02 Steve Falkenburg <sfalken@apple.com>
sfalken [Mon, 2 Oct 2006 23:36:07 +0000 (23:36 +0000)]
2006-10-02  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Hyatt.

        Added method to find out whether a layout has occurred.

        * page/FrameView.cpp:
        (WebCore::FrameView::didFirstLayout):
        * page/FrameView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Minor harassment followed by abject surrender provided by ggggaren.
bdakin [Mon, 2 Oct 2006 23:25:58 +0000 (23:25 +0000)]
    Minor harassment followed by abject surrender provided by ggggaren.

        Tests for counters.

        * fast/css/counters/contentNone-expected.checksum: Added.
        * fast/css/counters/contentNone-expected.png: Added.
        * fast/css/counters/contentNone-expected.txt: Added.
        * fast/css/counters/contentNone.html: Added.
        * fast/css/counters/counter00-expected.checksum: Added.
        * fast/css/counters/counter00-expected.png: Added.
        * fast/css/counters/counter00-expected.txt: Added.
        * fast/css/counters/counter00.html: Added.
        * fast/css/counters/counter01-expected.checksum: Added.
        * fast/css/counters/counter01-expected.png: Added.
        * fast/css/counters/counter01-expected.txt: Added.
        * fast/css/counters/counter01.html: Added.
        * fast/css/counters/counter02-expected.checksum: Added.
        * fast/css/counters/counter02-expected.png: Added.
        * fast/css/counters/counter02-expected.txt: Added.
        * fast/css/counters/counter02.html: Added.
        * fast/css/counters/counter03-expected.checksum: Added.
        * fast/css/counters/counter03-expected.png: Added.
        * fast/css/counters/counter03-expected.txt: Added.
        * fast/css/counters/counter03.html: Added.
        * fast/css/counters/counter04-expected.checksum: Added.
        * fast/css/counters/counter04-expected.png: Added.
        * fast/css/counters/counter04-expected.txt: Added.
        * fast/css/counters/counter04.html: Added.
        * fast/css/counters/counter05-expected.checksum: Added.
        * fast/css/counters/counter05-expected.png: Added.
        * fast/css/counters/counter05-expected.txt: Added.
        * fast/css/counters/counter05.html: Added.
        * fast/css/counters/counter06-expected.checksum: Added.
        * fast/css/counters/counter06-expected.png: Added.
        * fast/css/counters/counter06-expected.txt: Added.
        * fast/css/counters/counter06.html: Added.
        * fast/css/counters/counter07-expected.checksum: Added.
        * fast/css/counters/counter07-expected.png: Added.
        * fast/css/counters/counter07-expected.txt: Added.
        * fast/css/counters/counter07.html: Added.
        * fast/css/counters/counter08-expected.checksum: Added.
        * fast/css/counters/counter08-expected.png: Added.
        * fast/css/counters/counter08-expected.txt: Added.
        * fast/css/counters/counter08.html: Added.
        * fast/css/counters/counter09-expected.checksum: Added.
        * fast/css/counters/counter09-expected.png: Added.
        * fast/css/counters/counter09-expected.txt: Added.
        * fast/css/counters/counter09.html: Added.
        * fast/css/counters/counter10-expected.checksum: Added.
        * fast/css/counters/counter10-expected.png: Added.
        * fast/css/counters/counter10-expected.txt: Added.
        * fast/css/counters/counter10.html: Added.
        * fast/css/counters/counter11-expected.checksum: Added.
        * fast/css/counters/counter11-expected.png: Added.
        * fast/css/counters/counter11-expected.txt: Added.
        * fast/css/counters/counter11.html: Added.
        * fast/css/counters/counter12-expected.checksum: Added.
        * fast/css/counters/counter12-expected.png: Added.
        * fast/css/counters/counter12-expected.txt: Added.
        * fast/css/counters/counter12.html: Added.
        * fast/css/counters/counter13-expected.checksum: Added.
        * fast/css/counters/counter13-expected.png: Added.
        * fast/css/counters/counter13-expected.txt: Added.
        * fast/css/counters/counter13.html: Added.
        * fast/css/counters/counter14-expected.checksum: Added.
        * fast/css/counters/counter14-expected.png: Added.
        * fast/css/counters/counter14-expected.txt: Added.
        * fast/css/counters/counter14.html: Added.
        * fast/css/counters/counter15-expected.checksum: Added.
        * fast/css/counters/counter15-expected.png: Added.
        * fast/css/counters/counter15-expected.txt: Added.
        * fast/css/counters/counter15.html: Added.
        * fast/css/counters/counter16-expected.checksum: Added.
        * fast/css/counters/counter16-expected.png: Added.
        * fast/css/counters/counter16-expected.txt: Added.
        * fast/css/counters/counter16.html: Added.
        * fast/css/counters/counters00-expected.checksum: Added.
        * fast/css/counters/counters00-expected.png: Added.
        * fast/css/counters/counters00-expected.txt: Added.
        * fast/css/counters/counters00.html: Added.
        * fast/css/counters/counters01-expected.checksum: Added.
        * fast/css/counters/counters01-expected.png: Added.
        * fast/css/counters/counters01-expected.txt: Added.
        * fast/css/counters/counters01.html: Added.
        * fast/css/counters/counters02-expected.checksum: Added.
        * fast/css/counters/counters02-expected.png: Added.
        * fast/css/counters/counters02-expected.txt: Added.
        * fast/css/counters/counters02.html: Added.
        * fast/css/counters/counters03-expected.checksum: Added.
        * fast/css/counters/counters03-expected.png: Added.
        * fast/css/counters/counters03-expected.txt: Added.
        * fast/css/counters/counters03.html: Added.
        * fast/css/counters/counters04-expected.checksum: Added.
        * fast/css/counters/counters04-expected.png: Added.
        * fast/css/counters/counters04-expected.txt: Added.
        * fast/css/counters/counters04.html: Added.
        * fast/css/counters/counters05-expected.checksum: Added.
        * fast/css/counters/counters05-expected.png: Added.
        * fast/css/counters/counters05-expected.txt: Added.
        * fast/css/counters/counters05.html: Added.
        * fast/css/counters/counters06-expected.checksum: Added.
        * fast/css/counters/counters06-expected.png: Added.
        * fast/css/counters/counters06-expected.txt: Added.
        * fast/css/counters/counters06.html: Added.
        * fast/css/counters/counters07-expected.checksum: Added.
        * fast/css/counters/counters07-expected.png: Added.
        * fast/css/counters/counters07-expected.txt: Added.
        * fast/css/counters/counters07.html: Added.
        * fast/css/counters/counters08-expected.checksum: Added.
        * fast/css/counters/counters08-expected.png: Added.
        * fast/css/counters/counters08-expected.txt: Added.
        * fast/css/counters/counters08.html: Added.
        * fast/css/counters/counters09-expected.checksum: Added.
        * fast/css/counters/counters09-expected.png: Added.
        * fast/css/counters/counters09-expected.txt: Added.
        * fast/css/counters/counters09.html: Added.
        * fast/css/counters/counters10-expected.checksum: Added.
        * fast/css/counters/counters10-expected.png: Added.
        * fast/css/counters/counters10-expected.txt: Added.
        * fast/css/counters/counters10.html: Added.
        * fast/css/counters/counters11-expected.checksum: Added.
        * fast/css/counters/counters11-expected.png: Added.
        * fast/css/counters/counters11-expected.txt: Added.
        * fast/css/counters/counters11.html: Added.
        * fast/css/counters/counters12-expected.checksum: Added.
        * fast/css/counters/counters12-expected.png: Added.
        * fast/css/counters/counters12-expected.txt: Added.
        * fast/css/counters/counters12.html: Added.
        * fast/css/counters/counters13-expected.checksum: Added.
        * fast/css/counters/counters13-expected.png: Added.
        * fast/css/counters/counters13-expected.txt: Added.
        * fast/css/counters/counters13.html: Added.
        * fast/css/counters/counters14-expected.checksum: Added.
        * fast/css/counters/counters14-expected.png: Added.
        * fast/css/counters/counters14-expected.txt: Added.
        * fast/css/counters/counters14.html: Added.
        * fast/css/counters/counters15-expected.checksum: Added.
        * fast/css/counters/counters15-expected.png: Added.
        * fast/css/counters/counters15-expected.txt: Added.
        * fast/css/counters/counters15.html: Added.
        * fast/css/counters/counters18-expected.checksum: Added.
        * fast/css/counters/counters18-expected.png: Added.
        * fast/css/counters/counters18-expected.txt: Added.
        * fast/css/counters/counters18.html: Added.
        * fast/css/counters/implied00-expected.checksum: Added.
        * fast/css/counters/implied00-expected.png: Added.
        * fast/css/counters/implied00-expected.txt: Added.
        * fast/css/counters/implied00.html: Added.
        * fast/css/counters/root-expected.checksum: Added.
        * fast/css/counters/root-expected.png: Added.
        * fast/css/counters/root-expected.txt: Added.
        * fast/css/counters/root.html: Added.
        * fast/css/counters/visibilityNone-expected.checksum: Added.
        * fast/css/counters/visibilityNone-expected.png: Added.
        * fast/css/counters/visibilityNone-expected.txt: Added.
        * fast/css/counters/visibilityNone.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
bdakin [Mon, 2 Oct 2006 23:15:31 +0000 (23:15 +0000)]
    Reviewed by Darin.

        Initial implementation of CSS2 counters. See http://
        bugs.webkit.org/show_bug.cgi?id=4980 for more details.

        * WebCore.xcodeproj/project.pbxproj:
        * css/CSSComputedStyleDeclaration.cpp:
        (WebCore::CSSComputedStyleDeclaration::getPropertyCSSValue): Return
        the increment/reset list now that this is implemented.
        * css/CSSPrimitiveValue.cpp:
        (WebCore::CSSPrimitiveValue::cssText):
        * css/Counter.h:
        (WebCore::Counter::Counter):
        (WebCore::Counter::~Counter):
        (WebCore::Counter::identifier):
        (WebCore::Counter::listStyle):
        (WebCore::Counter::separator):
        (WebCore::Counter::listStyleNumber):
        (WebCore::Counter::setIdentifier):
        (WebCore::Counter::setListStyle):
        (WebCore::Counter::setSeparator):
        * css/cssparser.cpp:
        (WebCore::CSSParser::addProperty): Take care of reset/increment
        (WebCore::CSSParser::parseValue):
        (WebCore::CSSParser::parseContent): content can now take counters
        (WebCore::CSSParser::parseCounterContent): Parse counter() and
        counters()
        (WebCore::CSSParser::parseCounter): Parse counter-reset and
        counter-increment
        * css/cssparser.h:
        * css/cssstyleselector.cpp:
        (WebCore::CSSStyleSelector::matchUARules):
        (WebCore::CSSStyleSelector::applyProperty):
        * platform/PlatformString.h:
        * platform/String.cpp:
        (WebCore::String::insert): Implemented a version of insert that
        accepts a UChar* and a length.
        * platform/StringImpl.cpp:
        (WebCore::StringImpl::insert): Same as above.
        * platform/StringImpl.h:
        * rendering/CounterListItem.h: Added.
        * rendering/CounterNode.cpp: Added.
        (WebCore::CounterNode::CounterNode):
        (WebCore::CounterNode::insertAfter):
        (WebCore::CounterNode::removeChild):
        (WebCore::CounterNode::remove):
        (WebCore::CounterNode::setUsesSeparator):
        (WebCore::CounterNode::recountAndGetNext):
        (WebCore::CounterNode::recountTree):
        (WebCore::CounterNode::setSelfDirty):
        (WebCore::CounterNode::setParentDirty):
        * rendering/CounterNode.h: Added.
        (WebCore::CounterNode::~CounterNode):
        (WebCore::CounterNode::parent):
        (WebCore::CounterNode::previousSibling):
        (WebCore::CounterNode::nextSibling):
        (WebCore::CounterNode::firstChild):
        (WebCore::CounterNode::lastChild):
        (WebCore::CounterNode::value):
        (WebCore::CounterNode::setValue):
        (WebCore::CounterNode::count):
        (WebCore::CounterNode::setCount):
        (WebCore::CounterNode::setHasSeparator):
        (WebCore::CounterNode::isReset):
        (WebCore::CounterNode::hasSeparator):
        (WebCore::CounterNode::willNeedLayout):
        (WebCore::CounterNode::setWillNeedLayout):
        (WebCore::CounterNode::isRoot):
        (WebCore::CounterNode::setRenderer):
        (WebCore::CounterNode::renderer):
        * rendering/CounterResetNode.cpp: Added.
        (WebCore::CounterResetNode::CounterResetNode):
        (WebCore::CounterResetNode::insertAfter):
        (WebCore::CounterResetNode::removeChild):
        (WebCore::CounterResetNode::recountAndGetNext):
        (WebCore::CounterResetNode::setParentDirty):
        (WebCore::CounterResetNode::updateTotal):
        * rendering/CounterResetNode.h: Added.
        (WebCore::CounterResetNode::firstChild):
        (WebCore::CounterResetNode::lastChild):
        (WebCore::CounterResetNode::isReset):
        (WebCore::CounterResetNode::total):
        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::updatePseudoChildForObject): Account for
        counter content.
        * rendering/RenderCounter.cpp: Added.
        (WebCore::RenderCounter::RenderCounter):
        (WebCore::RenderCounter::layout):
        (WebCore::toRoman):
        (WebCore::toLetterString):
        (WebCore::toHebrew):
        (WebCore::RenderCounter::convertValueToType):
        (WebCore::RenderCounter::calcMinMaxWidth):
        * rendering/RenderCounter.h: Added.
        (WebCore::RenderCounter::renderName):
        (WebCore::RenderCounter::isCounter):
        * rendering/RenderObject.cpp:
        (WebCore::getRenderObjectsToCounterNodeMaps): Maps RenderObjects to
        maps of CounterNodes
        (WebCore::RenderObject::RenderObject):
        (WebCore::RenderObject::destroy): Destroy the maps.
        (WebCore::RenderObject::findCounter): Finds/creates counters.
        * rendering/RenderObject.h:
        (WebCore::RenderObject::isCounter):
        * rendering/RenderStyle.cpp:
        (WebCore::StyleVisualData::StyleVisualData):
        (WebCore::RenderStyle::arenaDelete):
        (WebCore::RenderStyle::RenderStyle):
        (WebCore::RenderStyle::diff):
        (WebCore::RenderStyle::setContent):
        (WebCore::ContentData::clearContent):
        (WebCore::RenderStyle::counterDataEquivalent):
        (WebCore::hasCounter):
        (WebCore::RenderStyle::hasCounterReset):
        (WebCore::RenderStyle::hasCounterIncrement):
        (WebCore::readCounter):
        (WebCore::RenderStyle::counterReset):
        (WebCore::RenderStyle::counterIncrement):
        * rendering/RenderStyle.h:
        (WebCore::StyleVisualData::operator==):
        (WebCore::CounterData::CounterData):
        (WebCore::CounterData::identifier):
        (WebCore::CounterData::listStyle):
        (WebCore::CounterData::separator):
        (WebCore::ContentData::contentCounter):
        (WebCore::ContentData::):
        (WebCore::RenderStyle::counterIncrement):
        (WebCore::RenderStyle::counterReset):
        (WebCore::RenderStyle::setCounterIncrement):
        (WebCore::RenderStyle::setCounterReset):
        (WebCore::RenderStyle::setCounterResetList):
        (WebCore::RenderStyle::setCounterIncrementList):
        (WebCore::RenderStyle::counterResetValueList):
        (WebCore::RenderStyle::counterIncrementValueList):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
aroben [Mon, 2 Oct 2006 21:03:31 +0000 (21:03 +0000)]
    Reviewed by Tim H.

        This change fixes a couple of problems with the window-properties
        test. window-properties' output changes depending on the presence or
        non-presence of session history (see
        http://bugs.webkit.org/show_bug.cgi?id=10965 for details). For this
        reason, the test must always be run as part of a run of ALL layout
        tests. The test results checked in were generated from an individual
        run of this test, so the buildbots were always failing since they run
        all the tests at once.

        This change regenerates the results for the test using a full run of
        layout tests. The test now also prints out object class names, and
        will print an error message when the test is run by itself.

        * fast/js/window-properties-expected.txt:
        * fast/js/window-properties.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by john
justing [Mon, 2 Oct 2006 20:44:13 +0000 (20:44 +0000)]
    Reviewed by john

        <rdar://problem/4757583>
        REGRESSION: tabbing into page focuses wrong control on 2nd pass
        <rdar://problem/4757594>
        REGRESSION: Form field is left with secondary selection after tabbing out of WebView

        * WebView/WebHTMLView.m:
        (-[NSArray maintainsInactiveSelection]): Replace code that I removed in error in the patch
        for 9642.  Only leave inactive editable selections in the WebHTMLView if the nextResponder
        is in the same WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
adele [Mon, 2 Oct 2006 20:30:43 +0000 (20:30 +0000)]
LayoutTests:

        Reviewed by Adam.

        - Updated results for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>

        * fast/forms/HTMLOptionElement_label05-expected.checksum:
        * fast/forms/HTMLOptionElement_label05-expected.png:
        * fast/forms/HTMLOptionElement_label05-expected.txt:
        * fast/forms/form-element-geometry-expected.checksum:
        * fast/forms/form-element-geometry-expected.png:
        * fast/forms/form-element-geometry-expected.txt:
        * fast/forms/option-strip-whitespace-expected.checksum:
        * fast/forms/option-strip-whitespace-expected.png:
        * fast/forms/option-strip-whitespace-expected.txt:
        * fast/forms/password-doubleclick-selection-expected.txt: Added.
        * fast/forms/password-doubleclick-selection.html: Added.
        * fast/forms/select-change-popup-to-listbox-expected.checksum:
        * fast/forms/select-change-popup-to-listbox-expected.png:
        * fast/forms/select-change-popup-to-listbox-expected.txt:
        * fast/text/updateNewFont-expected.checksum:
        * fast/text/updateNewFont-expected.png:
        * fast/text/updateNewFont-expected.txt:

WebCore:

        Reviewed by Adam.

        - Fix for <rdar://problem/4463841> Switch to use new list box implementation for <select multiple>

        There are a few outstanding issues, so I've left the old code in for now.  So you can use the old-style listboxes
        by using "-webkit-appearance:none".

        * css/html4.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Backing out these accidental commits.
aroben [Mon, 2 Oct 2006 16:46:49 +0000 (16:46 +0000)]
    Backing out these accidental commits.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
aroben [Mon, 2 Oct 2006 16:33:48 +0000 (16:33 +0000)]
2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>

JavaScriptCore:

        Reviewed/landed by Adam.

        Build testkjs on Qt/Linux.

        * CMakeLists.txt:

WebKitTools:

        Reviewed/landed by Adam.

        Proper build-webkit support for Qt/Linux.

        Compilation process is similar to OSX now, aka.
        the build directory is RootCheckoutDir/WebKitBuild now.

        * Scripts/build-webkit: Recognize Qt.
        * Scripts/webkitdirs.pm: Add buildCMakeProject() logic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reverted the code part of r16696, my patch for <rdar://problem/4641262>,...
harrison [Mon, 2 Oct 2006 15:32:17 +0000 (15:32 +0000)]
    Reverted the code part of r16696, my patch for <rdar://problem/4641262>, because the problem was
        addressed at a deeper level by r16696, the patch for <http://bugs.webkit.org/show_bug.cgi?id=10842>.
        Left the layout test.

        * rendering/bidi.cpp:
        (WebCore::checkMidpoints):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Mon, 2 Oct 2006 10:57:23 +0000 (10:57 +0000)]
2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Fix win32 build, which has no inttypes.h

        * wtf/Assertions.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Mon, 2 Oct 2006 10:30:45 +0000 (10:30 +0000)]
2006-10-02  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.  Landed by eseidel.

        Fix Qt/Linux build.

        * platform/qt/TemporaryLinkStubs.cpp: s/DeprecatedStringList/Vector<String>/
        (WebCore::supportedKeySizes):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-02 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Mon, 2 Oct 2006 10:26:58 +0000 (10:26 +0000)]
2006-10-02  Nikolas Zimmermann <zimmermann@kde.org>

        Reviewed by eseidel & mjs.  Landed by eseidel.

        Fix Qt/Linux build with older gcc 3.3.4.
        http://bugs.webkit.org/show_bug.cgi?id=11116

        As discussed with Maciej, the GCC_ROOT_NS_HACK
        can be completely removed, as well as the friendship
        between cacheGlobalObject & the JS* objects.

        * bindings/scripts/CodeGeneratorJS.pm: Remove friendship.
        * platform/image-decoders/png/pnggccrd.c: Fix comments for gcc3.
        (png_read_filter_row_mmx_avg):
        * platform/image-decoders/png/pngvcrd.c: Ditto.
        (png_mmx_support):
        (png_read_filter_row_mmx_avg):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
mjs [Mon, 2 Oct 2006 07:46:30 +0000 (07:46 +0000)]
    Reviewed by Anders.

        - remove webFrame field from WebDataSourcePrivate, it can get it from WebDocumentLoadState now

        * Loader/WebDocumentLoadState.h:
        * Loader/WebDocumentLoadState.m:
        (-[WebDocumentLoadState frameLoader]):
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _revertToProvisionalState]):
        (-[WebDataSource _setupForReplaceByMIMEType:]):
        (-[WebDataSource _updateLoading]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _defersCallbacksChanged]):
        (-[WebDataSource _stopLoading]):
        (-[WebDataSource _webView]):
        (-[WebDataSource _stopLoadingWithError:]):
        (-[WebDataSource _setPrimaryLoadComplete:]):
        (-[WebDataSource dealloc]):
        (-[WebDataSource webFrame]):
        (-[WebDataSource isLoading]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Anders.
mjs [Mon, 2 Oct 2006 07:39:32 +0000 (07:39 +0000)]
    Reviewed by Anders.

        - fix crash on back/forward - reattach WebDocumentLoadState to data source when needed

        * WebView/WebDataSource.m:
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _initWithDocumentLoadState:]):
        * WebView/WebDataSourceInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix, not reviewed.
mjs [Mon, 2 Oct 2006 07:16:48 +0000 (07:16 +0000)]
    Build fix, not reviewed.

        - Added missing files to fix build.

        * WebView/WebDocumentLoadStateMac.h: Added.
        * WebView/WebDocumentLoadStateMac.m: Added.
        (-[WebDocumentLoadStateMac initWithRequest:]):
        (-[WebDocumentLoadStateMac dealloc]):
        (-[WebDocumentLoadStateMac setDataSource:]):
        (-[WebDocumentLoadStateMac dataSource]):
        (-[WebDocumentLoadStateMac setFrameLoader:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Brady and Oliver.
mjs [Mon, 2 Oct 2006 07:00:16 +0000 (07:00 +0000)]
    Reviewed by Brady and Oliver.

        - move things around so that WebDataSource and WebDocumentLoadState know about each other in
        the right way. This lines things up to move nearly all functionality down to WebDocumentLoadState.

        * Loader/WebDocumentLoadState.h:
        * Loader/WebDocumentLoadState.m:
        (-[WebDocumentLoadState initWithRequest:]):
        (-[WebDocumentLoadState dealloc]):
        (-[WebDocumentLoadState originalRequest]):
        * Loader/WebFrameLoader.h:
        * Loader/WebFrameLoader.m:
        (-[WebFrameLoader dealloc]):
        (-[WebFrameLoader addSubresourceLoader:]):
        (-[WebFrameLoader startLoadingMainResourceWithRequest:identifier:]):
        (-[WebFrameLoader dataSource]):
        (-[WebFrameLoader _setDocumentLoadState:]):
        (-[WebFrameLoader policyDataSource]):
        (-[WebFrameLoader _setPolicyDocumentLoadState:]):
        (-[WebFrameLoader clearDataSource]):
        (-[WebFrameLoader provisionalDataSource]):
        (-[WebFrameLoader _setProvisionalDocumentLoadState:]):
        (-[WebFrameLoader _clearProvisionalDataSource]):
        (-[WebFrameLoader _setState:]):
        (-[WebFrameLoader clearProvisionalLoad]):
        (-[WebFrameLoader commitProvisionalLoad]):
        (-[WebFrameLoader stopLoading]):
        (-[WebFrameLoader startLoading]):
        (-[WebFrameLoader startProvisionalLoad:]):
        (-[WebFrameLoader setupForReplace]):
        (-[WebFrameLoader activeDocumentLoadState]):
        (-[WebFrameLoader activeDataSource]):
        (-[WebFrameLoader _loadRequest:archive:]):
        (-[WebFrameLoader _loadRequest:triggeringAction:loadType:formState:]):
        (-[WebFrameLoader _reloadAllowingStaleDataWithOverrideEncoding:]):
        (-[WebFrameLoader reload]):
        * WebKit.xcodeproj/project.pbxproj:
        * WebView/WebDataSource.m:
        (-[WebDataSourcePrivate dealloc]):
        (-[WebDataSource _startLoading]):
        (-[WebDataSource _setWebFrame:]):
        (-[WebDataSource _documentLoadState]):
        (-[WebDataSource _initWithDocumentLoadState:]):
        (-[WebDataSource initWithRequest:]):
        (-[WebDataSource initialRequest]):
        (-[WebDataSource unreachableURL]):
        * WebView/WebDataSourceInternal.h:
        * WebView/WebFrame.m:
        (-[WebFramePrivate dealloc]):
        (-[WebFrame _continueLoadRequestAfterNavigationPolicy:formState:]):
        (-[WebFrame _loadDataSource:withLoadType:formState:]):
        (-[WebFrame _policyDataSource]):
        (-[WebFrame _shouldReloadToHandleUnreachableURLFromRequest:]):
        (-[WebFrame _dataSourceForDocumentLoadState:]):
        (-[WebFrame _createDocumentLoadStateWithRequest:]):
        * WebView/WebFrameInternal.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
mjs [Mon, 2 Oct 2006 05:16:21 +0000 (05:16 +0000)]
LayoutTests:

        Rubber stamped by Alexey.

        - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes

        * fast/dom/css-insert-import-rule-expected.txt: Removed.
        * fast/dom/css-insert-import-rule.html: Removed.

WebCore:

        Rubber stamped by Alexey.

        - reverted fix for http://bugs.webkit.org/show_bug.cgi?id=10893 since it led to layout test crashes

        * css/CSSGrammar.y:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-01 Eric Seidel <eric@webkit.org>
eseidel [Mon, 2 Oct 2006 04:36:23 +0000 (04:36 +0000)]
2006-10-01  Eric Seidel  <eric@webkit.org>

        Reviewed by mjs.

        Eliminate a few more hotspots in SVG drawing code.

        No test cases were harmed in the making of this patch.  (And SVG has no perf tests.)

        * kcanvas/device/quartz/KRenderingPaintServerQuartz.mm:
        (WebCore::KRenderingPaintServerSolidQuartz::setup): use a single shared colorspace, avoid a few mallocs
        * platform/mac/ColorMac.mm:
        (+[WebCoreControlTintObserver WebCore]): store a single shared colorspace instance

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-01 Mark Rowe <opendarwin.org@bdash.net.nz>
bdash [Mon, 2 Oct 2006 01:20:05 +0000 (01:20 +0000)]
2006-10-01  Mark Rowe  <opendarwin.org@bdash.net.nz>

        Reviewed by Maciej.

        Add QT build slave to Buildbot.

        * BuildSlaveSupport/build.webkit.org-config/webkit/builders.py: Add QT build slave, fix existing errors.
        * BuildSlaveSupport/build.webkit.org-config/webkit/factories.py: Add QT build factory.
        * BuildSlaveSupport/build.webkit.org-config/webkit/status.py: Disable forcing of builds via web interface to prevent spamming.  Use the IRC bot in #webkit-build instead.
        * BuildSlaveSupport/build.webkit.org-config/webkit/steps.py: Add CMake build step.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Mon, 2 Oct 2006 01:02:49 +0000 (01:02 +0000)]
LayoutTests:

        Added test for the viewource attribute, which applies to <frame> and
        <iframe> elements.

        * fast/frames/viewsource-attribute-expected.txt: Added.
        * fast/frames/viewsource-attribute.html: Added.

        * fast/frames/frameElement-widthheight.html: Removed stray character.

WebCore:

        Reviewed by Maciej.

        More frame/iframe merging.

        - Removed needWidgetUpdate and related code. needWidgetUpdate is always
        false, so this was dead code.
        - Removed FIXME about setInViewSourceMode inside openURL(). openURL(), rather
        than attach(), is the correct place for setInViewSourceMode, because
        openURL() is the function that creates our frame.
        - Moved IFRAME insertedIntoDocument() code into FRAME, and removed FRAME
        code that did the same thing in other places.
        - Made FRAME's attach() method suffuciently generic so that IFRAME could
        call up to it, rather than skipping its superclass and calling up directly
        to ELEMENT.
        - Changed a few IFRAME up-calls to ELEMENT into up-calls to FRAME.
        - Replaced ad hoc frame loading code in FRAME::attach() with call to
        openURL(), the designated frame loading function.

        Layout tests pass. I added a layout test for viewsource mode, since I
        broke it in the course of writing this patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-01 Nikolas Zimmermann <zimmermann@kde.org>
eseidel [Mon, 2 Oct 2006 00:04:56 +0000 (00:04 +0000)]
2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by eseidel.

        * CMakeLists.txt: add option to disable colored output when building on the buildbot

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-01 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 1 Oct 2006 20:45:15 +0000 (20:45 +0000)]
2006-10-01  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Geoff.

        * dom/Document.cpp:
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        Get rid of availableStyleSheets() and remove DeprecatedStringList.h include.

        * dom/Node.h:
        Remove DeprecatedStringList class forward declaration.

        * editing/markup.cpp:
        Include DeprecatedStringList.h here since it's not included by Document.h anymore.

        * kcanvas/KCanvasTreeDebug.cpp:
        * kcanvas/KCanvasTreeDebug.h:
        Remove unused functions.

        * loader/loader.cpp:
        * page/Frame.cpp:
        * page/Frame.h:
        * page/FrameView.h:
        Fixup DeprecatedStringList.h includes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
harrison [Sun, 1 Oct 2006 16:06:11 +0000 (16:06 +0000)]
LayoutTests:

        Reviewed by John Sullivan.

        <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point

        * fast/text/international/wrap-CJK-001-expected.checksum: Added.
        * fast/text/international/wrap-CJK-001-expected.png: Added.
        * fast/text/international/wrap-CJK-001-expected.txt: Added.
        * fast/text/international/wrap-CJK-001.html: Added.

WebCore:

        Reviewed by John Sullivan.

        <rdar://problem/4641262> REGRESSION: Japanese text corrupts on wrapping point

        Problem was that the decision to trim was based only on whether the character
        is a soft hyphen, which caused pretty much any Japanese character to go.
        Changed to decide based on whether the character is ignorable whitespace.

        Test:
        * fast/text/international/wrap-CJK-001.html

        * rendering/bidi.cpp:
        (WebCore::isTrimmableChar):
        New. Checks whether character is whitespace that can be ignored
        according to the text node's style.
        trimmed from the end of wrapped line.
        (WebCore::checkMidpoints):
        Call isTrimmable() rather than checking for char != SOFT_HYPHEN.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-01 Anders Carlsson <acarlsson@apple.com>
andersca [Sun, 1 Oct 2006 15:40:02 +0000 (15:40 +0000)]
2006-10-01  Anders Carlsson  <acarlsson@apple.com>

        Reviewed by Mitz Pettel.

        Convert the SVG code to use Vector<String> instead of DeprecatedStringList.

        * ksvg2/svg/SVGColor.cpp:
        (WebCore::SVGColor::setRGBColor):
        * ksvg2/svg/SVGComponentTransferFunctionElement.cpp:
        * ksvg2/svg/SVGFEDiffuseLightingElement.cpp:
        (WebCore::SVGFEDiffuseLightingElement::parseMappedAttribute):
        * ksvg2/svg/SVGFEGaussianBlurElement.cpp:
        (WebCore::SVGFEGaussianBlurElement::parseMappedAttribute):
        * ksvg2/svg/SVGFESpecularLightingElement.cpp:
        (SVGFESpecularLightingElement::parseMappedAttribute):
        * ksvg2/svg/SVGFETurbulenceElement.cpp:
        (WebCore::SVGFETurbulenceElement::parseMappedAttribute):
        * ksvg2/svg/SVGLengthList.cpp:
        * ksvg2/svg/SVGNumberList.cpp:
        (SVGNumberList::parse):
        * ksvg2/svg/SVGNumberList.h:
        * ksvg2/svg/SVGPreserveAspectRatio.cpp:
        (WebCore::SVGPreserveAspectRatio::parsePreserveAspectRatio):
        * ksvg2/svg/SVGStringList.cpp:
        (WebCore::SVGStringList::reset):
        * ksvg2/svg/SVGStringList.h:
        * ksvg2/svg/SVGTransformable.cpp:
        (SVGTransformable::parseTransformAttribute):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-01 Nikolas Zimmermann <zimmermann@kde.org>
ap [Sun, 1 Oct 2006 10:05:01 +0000 (10:05 +0000)]
2006-10-01  Nikolas Zimmermann  <zimmermann@kde.org>

        Reviewed by Eric, tweaked and landed by ap.

        Fix Qt/Linux build.

        * CMakeLists.txt:
        * platform/qt/PlatformScrollBar.h:
        * platform/qt/TemporaryLinkStubs.cpp:
        (WebCore::ScrollBar::ScrollBar):
        (WebCore::PlatformScrollBar::PlatformScrollBar):
        (FrameView::passMousePressEventToSubframe):
        (FrameView::passMouseMoveEventToSubframe):
        (FrameView::passMouseReleaseEventToSubframe):
        (FrameView::passWheelEventToSubframe):
        (FrameView::passMousePressEventToScrollbar):
        * ksvg2/svg/SVGDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-10-01 Mitz Pettel <opendarwin.org@mitzpettel.com>
ap [Sun, 1 Oct 2006 09:11:35 +0000 (09:11 +0000)]
2006-10-01  Mitz Pettel  <opendarwin.org@mitzpettel.com>

        Reviewed by Darin.

        Fix for http://bugs.webkit.org/show_bug.cgi?id=10190
        REGRESSION: Repro crash when navigating away from an image document that hasn't finished loading

        No test case added (probably requires new DumpRenderTree functionality)

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::imageChanged): Added early return if the document is
        being destroyed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
ap [Sun, 1 Oct 2006 09:06:09 +0000 (09:06 +0000)]
    Reviewed by Hyatt.

        Fix for http://bugzilla.opendarwin.org/show_bug.cgi?id=10842
        REGRESSION (r15418): contenteditable div truncates rightmost Japanese character

        Make sure we only break after a space (and not any other valid line-break) if
        the style is -webkit-line-break: after-white-space (e.g. for a contentEditable div).
        I also did a logic shuffle at Mitz's request to prevent doing an if on the same expression
        twice in quick succession.

        Test: fast/text/line-breaks-after-white-space.html

        * rendering/bidi.cpp:
        (WebCore::RenderBlock::findNextLineBreak):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixed Bugzilla references in ChangeLogs for my previous commit.
ap [Sun, 1 Oct 2006 08:37:29 +0000 (08:37 +0000)]
Fixed Bugzilla references in ChangeLogs for my previous commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej and Darin.
ap [Sun, 1 Oct 2006 08:35:29 +0000 (08:35 +0000)]
    Reviewed by Maciej and Darin.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=4372
        JavaScript document.write page form does not submit in Safari

        Test: fast/forms/document-write.html

        * page/Frame.cpp:
        (WebCore::Frame::submitForm): Don't check for parsing().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix.
ap [Sun, 1 Oct 2006 08:13:04 +0000 (08:13 +0000)]
    Build fix.

        * bridge/mac/FrameViewMac.mm: Add missing #imports.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRefactor the code that sends the mouse down to scrollbars.
hyatt [Sun, 1 Oct 2006 07:26:55 +0000 (07:26 +0000)]
Refactor the code that sends the mouse down to scrollbars.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
weinig [Sat, 30 Sep 2006 23:33:25 +0000 (23:33 +0000)]
    Reviewed by Darin.

        Patch for http://bugs.webkit.org/show_bug.cgi?id=11102
        Add more SVG Objective-C DOM bindings

        - Auto-generate Objective-C DOM bindings for DOMSVGAElement,
          DOMSVGAnimateColorElement, DOMSVGAnimateElement, DOMSVGAnimateTransformElement,
          DOMSVGAnimatedPathData, DOMSVGAnimatedPoints, DOMSVGAnimatedPreserveAspectRatio,
          DOMSVGAnimationElement, DOMSVGCircleElement, DOMSVGClipPathElement, DOMSVGColor,
          DOMSVGCursorElement, DOMSVGDefsElement, DOMSVGDescElement, DOMSVGDocument,
          DOMSVGEllipseElement, DOMSVGPreserveAspectRatio, and DOMSVGURIReference.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMSVG.h:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * ksvg2/svg/SVGAElement.idl:
        * ksvg2/svg/SVGAnimateColorElement.idl:
        * ksvg2/svg/SVGAnimateElement.idl:
        * ksvg2/svg/SVGAnimateTransformElement.idl:
        * ksvg2/svg/SVGAnimatedPathData.idl:
        * ksvg2/svg/SVGAnimatedPoints.idl:
        * ksvg2/svg/SVGAnimatedPreserveAspectRatio.idl:
        * ksvg2/svg/SVGAnimationElement.idl:
        * ksvg2/svg/SVGCircleElement.idl:
        * ksvg2/svg/SVGClipPathElement.idl:
        * ksvg2/svg/SVGColor.idl:
        * ksvg2/svg/SVGCursorElement.idl:
        * ksvg2/svg/SVGDefsElement.idl:
        * ksvg2/svg/SVGDescElement.idl:
        * ksvg2/svg/SVGDocument.idl:
        * ksvg2/svg/SVGEllipseElement.idl:
        * ksvg2/svg/SVGPointList.idl:
        * ksvg2/svg/SVGPreserveAspectRatio.idl:
        * ksvg2/svg/SVGRect.idl:
        * ksvg2/svg/SVGSVGElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
mjs [Sat, 30 Sep 2006 23:18:59 +0000 (23:18 +0000)]
    Reviewed by Adele.

        - fix build

        * platform/FloatRect.h:
        (WebCore::FloatRect::contains): Added; not exactly the same semantic as IntRect containment
        but more appropriate for path-type stuff.
        * platform/cg/PathCG.cpp:
        (WebCore::Path::contains): Don't use enclosingIntRect, just use FloatRect::contains.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
ap [Sat, 30 Sep 2006 21:14:44 +0000 (21:14 +0000)]
    Reviewed by Darin.

        http://bugs.webkit.org/show_bug.cgi?id=11011
        External CSS is parsed as iso-8859-1 even though the main document is utf-8

        Test: fast/encoding/css-charset-default.xhtml

        * loader/CachedResourceClient.h:
        (WebCore::CachedResourceClient::setCSSStyleSheet):
        (WebCore::CachedResourceClient::setXSLStyleSheet):
        Divided setStyleSheet into setCSSStyleSheet and setXSLStyleSheet. The former
        takes an additional charset parameter, to be passed to CSSStyleSheet constructor.

        * css/CSSImportRule.cpp:
        (WebCore::CSSImportRule::setCSSStyleSheet):
        (WebCore::CSSImportRule::insertedIntoParent): Default to parent stylesheet's charset.
        * css/CSSImportRule.h:

        * css/CSSStyleSheet.cpp:
        (WebCore::CSSStyleSheet::CSSStyleSheet):
        * css/CSSStyleSheet.h:
        Added an m_charset member to be used when loading child stylesheets. Removed an unused m_implicit
        member. Changed some String parameters to const String&.

        * css/StyleSheet.cpp:
        (WebCore::StyleSheet::StyleSheet):
        * css/StyleSheet.h:
        Changed some String parameters to const String&. Removed an unused (even unimplemented) constructor.

        * css/StyleSheetList.cpp:
        (WebCore::StyleSheetList::length):
        (WebCore::StyleSheetList::item):
        * css/StyleSheetList.h:
        Special-casing implicit stylesheets seemed to be dead code, removed.

        * dom/Document.cpp:
        (WebCore::Document::setCSSStyleSheet):
        (WebCore::Document::recalcStyleSelector):
        * dom/Document.h:
        Renamed setStyleSheet() to setCSSStyleSheet().

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::checkStyleSheet): Pass a correct charset to requestCSSStyleSheet().
        (WebCore::ProcessingInstruction::setCSSStyleSheet):
        (WebCore::ProcessingInstruction::setXSLStyleSheet):
        (WebCore::ProcessingInstruction::parseStyleSheet):
        * dom/ProcessingInstruction.h:

        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::process): Default to document encoding if a charset attribute
        is not specified.
        (WebCore::HTMLLinkElement::setCSSStyleSheet):
        * html/HTMLLinkElement.h:

        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::childrenChanged):
        * ksvg2/svg/SVGStyleElement.cpp:
        (WebCore::SVGStyleElement::childrenChanged):
        Inherit URL and charset from the document.

        * loader/Cache.cpp:
        (WebCore::Cache::requestCSSStyleSheet):
        * loader/Cache.h:
        Adjust for setStyleSheet() renaming.

        * loader/CachedCSSStyleSheet.h: Removed an unused constructor.
        * loader/CachedCSSStyleSheet.cpp:
        (WebCore::CachedCSSStyleSheet::ref):
        (WebCore::CachedCSSStyleSheet::deref):
        (WebCore::CachedCSSStyleSheet::checkNotify):
        Pass the encoding to setCSSStyleSheet().

        * loader/CachedXSLStyleSheet.cpp:
        (WebCore::CachedXSLStyleSheet::ref):
        (WebCore::CachedXSLStyleSheet::checkNotify):
        * loader/DocLoader.cpp:
        (WebCore::DocLoader::requestCSSStyleSheet):
        * loader/DocLoader.h:
        * page/Frame.cpp:
        (WebCore::UserStyleSheetLoader::UserStyleSheetLoader):
        (WebCore::UserStyleSheetLoader::setCSSStyleSheet):
        * xml/XSLImportRule.cpp:
        (WebCore::XSLImportRule::setXSLStyleSheet):
        (WebCore::XSLImportRule::loadSheet):
        * xml/XSLImportRule.h:
        Adjust for setStyleSheet() renaming.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by eseidel.
rwlbuis [Sat, 30 Sep 2006 17:08:39 +0000 (17:08 +0000)]
    Reviewed by eseidel.

        http://bugs.webkit.org/show_bug.cgi?id=11096
        Hit testing for polylines fails

        Fix Path::contains so it handles filled, non-closed paths too.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix win32.
hyatt [Sat, 30 Sep 2006 10:11:11 +0000 (10:11 +0000)]
Fix win32.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoRevert minimum font size pref back to 1.
hyatt [Sat, 30 Sep 2006 09:49:30 +0000 (09:49 +0000)]
Revert minimum font size pref back to 1.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix win32 bustage caused by a typo.
hyatt [Sat, 30 Sep 2006 09:48:24 +0000 (09:48 +0000)]
Fix win32 bustage caused by a typo.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFix mac bustage in FrameMac.mm and FrameViewMac.mm
hyatt [Sat, 30 Sep 2006 09:46:07 +0000 (09:46 +0000)]
Fix mac bustage in FrameMac.mm and FrameViewMac.mm

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEvent refactoring.
hyatt [Sat, 30 Sep 2006 09:30:31 +0000 (09:30 +0000)]
Event refactoring.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
adele [Sat, 30 Sep 2006 05:42:00 +0000 (05:42 +0000)]
    Reviewed by Adele.

        Fixes windows bustage:
        http://bugs.webkit.org/show_bug.cgi?id=11093

        * platform/win/PlatformScrollBar.h:
        * platform/win/TemporaryLinkStubs.cpp:
        (PlatformScrollBar::PlatformScrollBar):
        (ScrollBar::ScrollBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Bug 11041: fast/dom/isindex-001 needs new results
thatcher [Sat, 30 Sep 2006 03:25:38 +0000 (03:25 +0000)]
    Bug 11041: fast/dom/isindex-001 needs new results
        http://bugs.webkit.org/show_bug.cgi?id=11041

        * fast/dom/isindex-001-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Change the default minimum font size pref to 0 in order to allow
hyatt [Sat, 30 Sep 2006 01:57:48 +0000 (01:57 +0000)]
    Change the default minimum font size pref to 0 in order to allow
        font-size:0 to work.

        * WebView/WebPreferences.m:
        (+[WebPreferences initialize]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
hyatt [Sat, 30 Sep 2006 01:55:05 +0000 (01:55 +0000)]
    Eliminate RenderLayer::gScrollBar in favor of caching the scrollbar hit
        in RenderObject::NodeInfo (and then propagating that Widget to
        MouseEventWithHitTestResults).

        This allows RenderListBox and RenderBlock to do the same thing when the
        mouse is over the scrollbar.

        Also land fix to support font-size: 0.

        Reviewed by mjs (scrollbar), eric (font-size)

        * dom/Document.cpp:
        (WebCore::Document::prepareMouseEvent):
        * page/Frame.cpp:
        (WebCore::Frame::passWidgetMouseDownEventToWidget):
        * page/FrameView.cpp:
        (WebCore::selectCursor):
        (WebCore::FrameView::handleMouseMoveEvent):
        (WebCore::FrameView::dispatchMouseEvent):
        * page/MouseEventWithHitTestResults.cpp:
        (WebCore::MouseEventWithHitTestResults::MouseEventWithHitTestResults):
        * page/MouseEventWithHitTestResults.h:
        (WebCore::MouseEventWithHitTestResults::scrollbar):
        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::isPointInScrollbar):
        (WebCore::RenderBlock::nodeAtPoint):
        * rendering/RenderBlock.h:
        * rendering/RenderLayer.cpp:
        (WebCore::RenderLayer::hitTest):
        * rendering/RenderLayer.h:
        (WebCore::RenderLayer::getHiddenBehavior):
        * rendering/RenderListBox.cpp:
        (WebCore::RenderListBox::RenderListBox):
        (WebCore::RenderListBox::~RenderListBox):
        (WebCore::RenderListBox::isPointInScrollbar):
        * rendering/RenderListBox.h:
        * rendering/RenderObject.h:
        (WebCore::RenderObject::NodeInfo::NodeInfo):
        (WebCore::RenderObject::NodeInfo::scrollbar):
        (WebCore::RenderObject::NodeInfo::setScrollbar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
adele [Sat, 30 Sep 2006 01:50:56 +0000 (01:50 +0000)]
    Reviewed by Adele.

        Fixes: http://bugs.webkit.org/show_bug.cgi?id=11092

        * platform/win/ScrollViewWin.cpp:
        (WebCore::ScrollView::convertToContainingWindow):
        (WebCore::ScrollView::convertFromContainingWindow):
        * platform/win/WidgetWin.cpp:
        (WebCore::Widget::convertToContainingWindow):
        (WebCore::Widget::convertFromContainingWindow):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Updated with new argument for PlatformScrollBar.
adele [Sat, 30 Sep 2006 01:44:59 +0000 (01:44 +0000)]
    Updated with new argument for PlatformScrollBar.

        * platform/win/TemporaryLinkStubs.cpp:
        (PlatformScrollBar::PlatformScrollBar):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoBuild fix.
thatcher [Sat, 30 Sep 2006 00:06:25 +0000 (00:06 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
adele [Fri, 29 Sep 2006 23:59:27 +0000 (23:59 +0000)]
    Reviewed by Hyatt.

        Fixing build bustage with cast to int.

        * html/HTMLSelectElement.cpp: (WebCore::HTMLSelectElement::lastSelectedListIndex):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fixing accidental include.
adele [Fri, 29 Sep 2006 23:45:55 +0000 (23:45 +0000)]
    Fixing accidental include.

        * rendering/RenderListBox.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdding RenderListBox files.
adele [Fri, 29 Sep 2006 23:41:23 +0000 (23:41 +0000)]
Adding RenderListBox files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoFixing typo. No problem in the ned. Just the end.
bdakin [Fri, 29 Sep 2006 23:15:37 +0000 (23:15 +0000)]
Fixing typo. No problem in the ned. Just the end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adam.
adele [Fri, 29 Sep 2006 23:13:49 +0000 (23:13 +0000)]
    Reviewed by Adam.

        Initial implementation of engine-based list box control.

        * WebCore.xcodeproj/project.pbxproj: Added RenderListBox.h and RenderListBox.cpp

        * bridge/mac/FrameMac.h: Added _mouseDownMayStartAutoscroll.
        * bridge/mac/FrameMac.mm: Updated autoscroll code to use renderers instead of layers, so any renderer that implements autoscroll will work.
        (WebCore::FrameMac::FrameMac):
        (WebCore::FrameMac::handleMousePressEvent):
        (WebCore::FrameMac::handleMouseMoveEvent):
        (WebCore::FrameMac::mouseDown):

        * page/Frame.cpp:
        (WebCore::Frame::handleMouseMoveEvent):
        (WebCore::Frame::scrollOverflow): Don't scroll list box here- this would cause arrow keys to scroll instead of select.
        (WebCore::Frame::handleAutoscroll): Updated to use a renderer instead of a layer when setting up autoscroll.
        (WebCore::Frame::autoscrollTimerFired): ditto.
        (WebCore::Frame::stopAutoscrollTimer): ditto.
        (WebCore::Frame::passWidgetMouseDownEventToWidget): Updated to check for list box's scroll bar.
        * page/Frame.h:
        * page/FramePrivate.h: (WebCore::FramePrivate::FramePrivate): Updated to use renderer unstead of layer for autoscroll.

        * page/FrameView.cpp: Keep track of current mouse position so this can be used for list box autoscroll.
        (WebCore::FrameViewPrivate::reset):
        (WebCore::FrameView::currentMousePosition):
        (WebCore::FrameView::handleMousePressEvent):
        (WebCore::FrameView::handleMouseDoubleClickEvent):
        (WebCore::selectCursor):
        (WebCore::FrameView::handleMouseMoveEvent):
        (WebCore::FrameView::handleMouseReleaseEvent):
        * page/FrameView.h:

        * platform/ScrollBar.cpp: (WebCore::ScrollBar::ScrollBar): Added controlSize argument.  The list box will use a smaller scroll bar size.
        * platform/ScrollBar.h:
        (WebCore::):
        (WebCore::ScrollBar::controlSize):
        * platform/mac/PlatformScrollBar.h:
        * platform/mac/PlatformScrollBarMac.mm:
        (NSControlSizeForScrollBarControlSize):
        (-[WebCoreScrollBar initWithPlatformScrollBar:]):
        (WebCore::PlatformScrollBar::PlatformScrollBar):

        * rendering/RenderBlock.h:
        * rendering/RenderLayer.cpp: (WebCore::RenderLayer::createScrollbar): Updated to pass regular control size to scrollbar constructor.
        * rendering/RenderLayer.h:
        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::shouldAutoscroll):
        (WebCore::RenderObject::autoscroll):
        * rendering/RenderObject.h: (WebCore::RenderObject::isListBox):

        * css/html4.css: Added properties for new list boxes.

        * html/HTMLOptionElement.cpp:
        (WebCore::HTMLOptionElement::setSelected): Doesn't allow selection to be changed here if the option is disabled.
        (WebCore::HTMLOptionElement::disabled): Added. Checks the parent's disabled status.
        * html/HTMLOptionElement.h: Added disabled method.

        * html/HTMLSelectElement.cpp: Added appearance switch for new list box implementation.
        (WebCore::HTMLSelectElement::recalcStyle):
        (WebCore::HTMLSelectElement::lastSelectedListIndex):
        (WebCore::HTMLSelectElement::deselectItems):
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::isKeyboardFocusable):
        (WebCore::HTMLSelectElement::isMouseFocusable):
        (WebCore::HTMLSelectElement::createRenderer):
        (WebCore::HTMLSelectElement::recalcListItems):
        (WebCore::HTMLSelectElement::setRecalcListItems):
        (WebCore::HTMLSelectElement::reset):
        (WebCore::HTMLSelectElement::notifyOptionSelected):
        (WebCore::HTMLSelectElement::defaultEventHandler): Added code to select options for list box when clicking and using arrow keys.
        (WebCore::HTMLSelectElement::nextSelectableListIndex):
        (WebCore::HTMLSelectElement::previousSelectableListIndex):
        * html/HTMLSelectElement.h:

        * rendering/RenderTheme.cpp: Added support for ListBoxAppearance
        (WebCore::RenderTheme::paint):
        (WebCore::RenderTheme::paintBorderOnly):
        (WebCore::RenderTheme::paintDecorations):
        (WebCore::RenderTheme::activeListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::activeListBoxSelectionForegroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionBackgroundColor):
        (WebCore::RenderTheme::inactiveListBoxSelectionForegroundColor):
        (WebCore::RenderTheme::isControlStyled):
        (WebCore::RenderTheme::supportsFocusRing):
        * rendering/RenderTheme.h:
        * rendering/RenderThemeMac.mm: (WebCore::RenderThemeMac::isControlStyled):

        * rendering/RenderListBox.cpp: Added.
        (WebCore::RenderListBox::RenderListBox):
        (WebCore::RenderListBox::~RenderListBox):
        (WebCore::RenderListBox::setStyle):
        (WebCore::RenderListBox::updateFromElement):
        (WebCore::RenderListBox::calcMinMaxWidth):
        (WebCore::RenderListBox::size):
        (WebCore::RenderListBox::numItems):
        (WebCore::RenderListBox::calcHeight):
        (WebCore::RenderListBox::baselinePosition):
        (WebCore::RenderListBox::itemBoundingBoxRect):
        (WebCore::RenderListBox::paintObject):
        (WebCore::RenderListBox::paintScrollbar):
        (WebCore::RenderListBox::paintItemForeground):
        (WebCore::RenderListBox::paintItemBackground):
        (WebCore::RenderListBox::scrollBarTarget):
        (WebCore::RenderListBox::isPointInScrollbar):
        (WebCore::RenderListBox::optionAtPoint):
        (WebCore::RenderListBox::autoscroll):
        (WebCore::RenderListBox::scrollToRevealElementAtListIndex):
        (WebCore::RenderListBox::scroll):
        (WebCore::RenderListBox::valueChanged):
        * rendering/RenderListBox.h: Added.
        (WebCore::RenderListBox::isListBox):
        (WebCore::RenderListBox::selectionChanged):
        (WebCore::RenderListBox::setSelectionChanged):
        (WebCore::RenderListBox::canHaveChildren):
        (WebCore::RenderListBox::renderName):
        (WebCore::RenderListBox::setOptionsChanged):
        (WebCore::RenderListBox::shouldAutoscroll):
        (WebCore::RenderListBox::listIndexIsVisible):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Darin.
bdakin [Fri, 29 Sep 2006 23:10:27 +0000 (23:10 +0000)]
    Reviewed by Darin.

        We had a bug where html4.css was ignoring Media Queries. In the ned
        the problem was that we were trying to send a char* to the
        MediaQueryEvaluator constructor that expects a String, but the
        char* got interpreted as a bool, the wrong constructor was called,
        and the media type was never set.

        No test case possible since this only affects html4.css

        * css/MediaQueryEvaluator.cpp: New constructor that expects takes a
        char*
        (WebCore::MediaQueryEvaluator):
        * css/MediaQueryEvaluator.h: Same.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
ggaren [Fri, 29 Sep 2006 22:57:04 +0000 (22:57 +0000)]
LayoutTests:

        Reviewed by John, Maciej.

        Added test for whether a frame element reports its src attribute as a
        complete, rather than relative, URL.

        * fast/frames/frame-src-attribute-expected.txt: Added.
        * fast/frames/frame-src-attribute.html: Added.
        * fast/frames/resources/frame-src-attribute-subframe.html: Added.

WebCore:

        Reviewed by John, Maciej.

        Integrated some frame and iframe code. I'm trying to fix up frame ownership
        and loading. Reducing the number of different code paths involved
        seemed like a good first step.

        As a side effect, I fixed a bug where FRAME elements would report their
        src attributes as relative, rather than compelete, URLs. (IFRAME elements
        had the correct complete URL behavior.)

        * html/HTMLFrameElement.cpp:
        (WebCore::HTMLFrameElement::isURLAllowed): Fixed comment typo
        (WebCore::HTMLFrameElement::openURL):
            (1) Removed checks that requestFrame does for us
            (2) Added isURLAllowed check, to have one clear bottleneck for it
            (3) Added viewsource check, to have one clear bottleneck for it
        (WebCore::HTMLFrameElement::close): Changed to use the common contentFrame()
        method, instead of finding our content frame in our own unique way.
        (WebCore::HTMLFrameElement::setLocation): Removed isURLAllowed check,
        since openURL does this for us now.
        (WebCore::HTMLFrameElement::src): Return complete URL instead of relative.
        This is what FF does, and it made no sense to have different behaviors
        for FRAME and IFRAME elements.
        * html/HTMLIFrameElement.cpp:
        (WebCore::HTMLIFrameElement::HTMLIFrameElement): Removed duplicate init
        code.
        * html/HTMLIFrameElement.h: Removed src() and openURL() methods, since
        HTMLFrameElement now does everything we need.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Hyatt.
rwlbuis [Fri, 29 Sep 2006 22:33:52 +0000 (22:33 +0000)]
    Reviewed by Hyatt.

        Fix Qt/Linux build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:24:15 +0000 (22:24 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:22:31 +0000 (22:22 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:21:53 +0000 (22:21 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:21:13 +0000 (22:21 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16654 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:20:06 +0000 (22:20 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16653 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:17:46 +0000 (22:17 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16652 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:16:47 +0000 (22:16 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16651 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:14:50 +0000 (22:14 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16650 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:12:15 +0000 (22:12 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16649 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoReplace bugzilla.opendarwin.org with bugs.webkit.org.
thatcher [Fri, 29 Sep 2006 22:08:31 +0000 (22:08 +0000)]
Replace bugzilla.opendarwin.org with bugs.webkit.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16648 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Fri, 29 Sep 2006 20:29:16 +0000 (20:29 +0000)]
    Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11082
        Simplify Internal methods for the auto-generated Objective-C DOM code

        - Auto-generate the internal methods for more Objective-C classes.

        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOM.mm:
        * bindings/objc/DOMCSS.mm:
        (-[DOMStyleSheet WebCore::]):
        (+[DOMStyleSheet _styleSheetWith:WebCore::]):
        (-[DOMCSSRule WebCore::]):
        (-[DOMCSSRule _initWithCSSRule:WebCore::]):
        (+[DOMCSSRule _CSSRuleWith:WebCore::]):
        (-[DOMCSSValue WebCore::]):
        (-[DOMCSSValue _initWithCSSValue:WebCore::]):
        (+[DOMCSSValue _CSSValueWith:WebCore::]):
        * bindings/objc/DOMHTMLAppletElement.mm:
        (-[DOMHTMLAppletElement WebCore::]):
        (+[DOMHTMLAppletElement _HTMLOptionElementWith:WebCore::]):
        * bindings/objc/DOMHTMLEmbedElement.mm:
        (-[DOMHTMLEmbedElement WebCore::]):
        (+[DOMHTMLEmbedElement _HTMLEmbedElementWith:WebCore::]):
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMInternal.mm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * css/CSSCharsetRule.idl:
        * css/CSSFontFaceRule.idl:
        * css/CSSImportRule.idl:
        * css/CSSMediaRule.idl:
        * css/CSSPageRule.idl:
        * css/CSSPrimitiveValue.idl:
        * css/CSSStyleRule.idl:
        * css/CSSStyleSheet.idl:
        * css/CSSUnknownRule.idl:
        * css/CSSValueList.idl:
        * dom/KeyboardEvent.idl:
        * dom/MouseEvent.idl:
        * dom/MutationEvent.idl:
        * dom/NodeIterator.idl:
        * dom/OverflowEvent.idl:
        * dom/UIEvent.idl:
        * dom/WheelEvent.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16645 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
harrison [Fri, 29 Sep 2006 16:57:38 +0000 (16:57 +0000)]
LayoutTests:

        Reviewed by John Sullivan.

        <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
        <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

        * fast/text/attributed-substring-from-range-001-expected.txt: Added.
        * fast/text/attributed-substring-from-range-001.html: Added.

        Check attributed string results when starting or ending at a br element.

WebCore:

        Reviewed by John Sullivan.

        <rdar://problem/4663772> REGRESSION: Cannot type in Japanese after replying to a particular message
        <rdar://problem/4673293> REGRESSION: Can't enter the Japanese characters in Mail or Blot

        Test added
        * fast/text/attributed-substring-from-range-001.html

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::attributedString):
        Handle non-zero offsets when start and/or end node is a container. Offset used to be ignored in this case.
        Also, add validation of the range.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16642 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
thatcher [Fri, 29 Sep 2006 16:10:44 +0000 (16:10 +0000)]
    Reviewed by Maciej.

        Switch the inspector over to use border-image with styled buttons and selects.

        * WebInspector/WebInspector.m:
        (-[NSWindow window]):
        (-[NSWindow setWebFrame:]):
        (-[WebInspector _updateRoot]):
        * WebInspector/webInspector/Images/button.png: Added.
        * WebInspector/webInspector/Images/buttonDivider.png: Added.
        * WebInspector/webInspector/Images/buttonPressed.png: Added.
        * WebInspector/webInspector/Images/popup.png: Added.
        * WebInspector/webInspector/Images/popupFill.png: Removed.
        * WebInspector/webInspector/Images/popupFillPressed.png: Removed.
        * WebInspector/webInspector/Images/popupLeft.png: Removed.
        * WebInspector/webInspector/Images/popupLeftPressed.png: Removed.
        * WebInspector/webInspector/Images/popupPressed.png: Added.
        * WebInspector/webInspector/Images/popupRight.png: Removed.
        * WebInspector/webInspector/Images/popupRightPressed.png: Removed.
        * WebInspector/webInspector/Images/squareButtonRight.png: Removed.
        * WebInspector/webInspector/Images/squareButtonRightPressed.png: Removed.
        * WebInspector/webInspector/inspector.css:
        * WebInspector/webInspector/inspector.html:
        * WebInspector/webInspector/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16641 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoI commited old expected results, this one is correct.
rwlbuis [Fri, 29 Sep 2006 15:27:49 +0000 (15:27 +0000)]
I commited old expected results, this one is correct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16637 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoAdd the ability to set the click count after the fact on a mouse event.
hyatt [Fri, 29 Sep 2006 08:40:25 +0000 (08:40 +0000)]
Add the ability to set the click count after the fact on a mouse event.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16634 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Maciej.
rwlbuis [Fri, 29 Sep 2006 08:30:12 +0000 (08:30 +0000)]
    Reviewed by Maciej.

        http://bugzilla.opendarwin.org/show_bug.cgi?id=10893
        InsertRule can not handle @import statements

        Allow @import as part of a css rule.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16633 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-28 Steve Falkenburg <sfalken@apple.com>
sfalken [Fri, 29 Sep 2006 02:07:24 +0000 (02:07 +0000)]
2006-09-28  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Maciej.

        Use $(ConfigSuffix) set via vsprops files to add _debug
        to end of debug filenames.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/debug.vsprops: Added.
        * JavaScriptCore.vcproj/dftables/dftables.vcproj:
        * JavaScriptCore.vcproj/release.vsprops: Added.
        * JavaScriptCore.vcproj/testkjs/testkjs.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16632 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Switch over the Mac-specific uses of viewportToContents/contentsToViewport.
hyatt [Fri, 29 Sep 2006 00:39:48 +0000 (00:39 +0000)]
    Switch over the Mac-specific uses of viewportToContents/contentsToViewport.

        * bridge/mac/FrameMac.mm:
        (WebCore::FrameMac::eventMayStartDrag):
        (WebCore::FrameMac::dragHysteresisExceeded):
        (WebCore::FrameMac::mouseDown):
        (WebCore::FrameMac::shouldDragAutoNode):
        (WebCore::FrameMac::sendContextMenuEvent):
        * bridge/mac/WebCoreFrameBridge.mm:
        (-[WebCoreFrameBridge _visiblePositionForPoint:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16631 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoEliminate viewportToContents and contentsToViewport
hyatt [Fri, 29 Sep 2006 00:17:01 +0000 (00:17 +0000)]
Eliminate viewportToContents and contentsToViewport

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16630 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Build fix by adding missing files for CommandByName
aliceli1 [Thu, 28 Sep 2006 23:32:36 +0000 (23:32 +0000)]
    Build fix by adding missing files for CommandByName

        * WebCore.xcodeproj/project.pbxproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16629 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Adding CommandByName files to the vcproj
aliceli1 [Thu, 28 Sep 2006 22:47:41 +0000 (22:47 +0000)]
    Adding CommandByName files to the vcproj

        * WebCore.vcproj/WebCore/WebCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16628 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago fixing the windows build
aliceli1 [Thu, 28 Sep 2006 22:23:34 +0000 (22:23 +0000)]
    fixing the windows build

        * COM/WebView.cpp:
        (WebView::mouseMoved):
        (WebView::mouseDown):
        (WebView::mouseUp):
        (WebView::mouseDoubleClick):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16627 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agogit-svn-id: https://svn.webkit.org/repository/webkit/trunk@16626 268f45cc-cd09-0410...
aliceli1 [Thu, 28 Sep 2006 21:39:47 +0000 (21:39 +0000)]
git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16626 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
aroben [Thu, 28 Sep 2006 21:33:07 +0000 (21:33 +0000)]
    Reviewed by Adele.

        Remove no-longer-used PopUpButton.

        * WebCore.vcproj/WebCore/WebCore.vcproj: Remove PopUpButton.h
        * WebCore.xcodeproj/project.pbxproj: Remove PopUpButton.h,
PopUpButtonMac.mm
        * platform/PopUpButton.h: Removed.
        * platform/mac/PopUpButtonMac.mm: Removed.
        * platform/win/TemporaryLinkStubs.cpp: Remove PopUpButton:: methods
        * rendering/DeprecatedRenderSelect.cpp: Change #include of
PopUpButton.h to ListBox.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16624 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Suggested by Darin.
harrison [Thu, 28 Sep 2006 21:28:49 +0000 (21:28 +0000)]
    Suggested by Darin.

        Moved an extern declaration from inside a method to the top of the file.

        * DumpRenderTree/EventSendingController.m:
        (-[EventSendingController clearKillRing]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16623 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoJavaScriptCore:
darin [Thu, 28 Sep 2006 21:07:39 +0000 (21:07 +0000)]
JavaScriptCore:

        Reviewed by Alice.

        - support for change that should fix <rdar://problem/4733044>
          REGRESSION: XML iBench shows 10% perf. regression (copying
          strings while decoding)

        * wtf/Vector.h: Changed VectorBuffer so that the general case
        contains an instance of the 0 case, since deriving from it
        was violating the Liskov Substitution Principle.
        (WTF::VectorBuffer::releaseBuffer): Added. Releases the buffer so it can
        be adopted by another data structure that uses the FastMalloc.h allocator.
        Returns 0 if the internal buffer was being used.
        (WTF::Vector::releaseBuffer): Added. Releases the buffer as above or creates
        a new one in the case where the internal buffer was being used.

WebCore:

        Reviewed by Alice.

        - change that should fix <rdar://problem/4733044> REGRESSION: XML iBench shows
          10% perf. regression (copying strings while decoding)

        Use Vector<UChar> instead of String when building up the decoded string in
        the ICU and Mac decoders. Using String leads to O(n^2) behavior because
        String grows the buffer every single time that append is called. Using
        Vector::append instead of String::append also avoids constructing a string
        each time just to append and a questionable copy that is done inside the
        String::append function which also contributed to the slowness.

        * platform/PlatformString.h:
        * platform/String.cpp: (WebCore::String::adopt): Added. Makes a String from a
        Vector<UChar>, adopting the buffer from the vector to avoid copying and memory
        allocation.
        * platform/StringImpl.h:
        * platform/StringImpl.cpp: (WebCore::StringImpl::adopt): Ditto.

        * platform/StreamingTextDecoder.h:
        * platform/StreamingTextDecoder.cpp: (WebCore::TextCodec::appendOmittingBOM):
        Change to use a Vector<UChar> instead of a String, since vectors have better
        resizing performance (they store a separate capacity).

        * platform/StreamingTextDecoderICU.cpp: (WebCore::TextCodecICU::decode):
        * platform/mac/StreamingTextDecoderMac.cpp: (WebCore::TextCodecMac::decode):
        Change to use Vector<UChar> instead of String and then create a string at
        the end of the process using the new adopt function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16622 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoExplicitly specify stabs for Debug and Production.
thatcher [Thu, 28 Sep 2006 21:05:56 +0000 (21:05 +0000)]
Explicitly specify stabs for Debug and Production.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16621 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoLayoutTests:
harrison [Thu, 28 Sep 2006 20:25:15 +0000 (20:25 +0000)]
LayoutTests:

        Reviewed by Justin.

        Call clearKillRing() so we are guaranteed to start with empty kill ring.

        * editing/pasteboard/emacs-cntl-y-001.html:

WebKitTools:

        Reviewed by Justin.

        Add clearKillRing so we can test emacs support with empty kill ring.

        * DumpRenderTree/EventSendingController.m:
        (+[EventSendingController isSelectorExcludedFromWebScript:]):
        (+[EventSendingController webScriptNameForSelector:]):
        (-[EventSendingController clearKillRing]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16620 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Tim H.
weinig [Thu, 28 Sep 2006 18:33:45 +0000 (18:33 +0000)]
    Reviewed by Tim H.

        Patch for http://bugzilla.opendarwin.org/show_bug.cgi?id=11057
        Auto-generate more SVG Objective-C bindings

        - Auto-generates DOMSVGAnimatedAngle, DOMSVGAnimatedBoolean,
          DOMSVGAnimatedEnumeration, DOMSVGAnimatedInteger, DOMSVGAnimatedLength,
          DOMSVGAnimatedLengthList, DOMSVGAnimatedNumber, DOMSVGAnimatedString,
          DOMSVGAnimatedTransformList, DOMSVGExternalResourcesRequired,
          DOMSVGLangSpace, DOMSVGLocatable, DOMSVGMetadataElement, DOMSVGRectElement,
          DOMSVGStringList, DOMSVGStylable, DOMSVGStyleElement, DOMSVGTests,
          and DOMSVGTransformable.

        - Adds ability to CodeGeneratorObjC.pm to handle interfaces with mulitple
          parent interfaces and the SVG animated classes.

        - Corrects CodeGenerator.pm to only skip the first parent for the main
          interface.

        * DerivedSources.make:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/objc/DOMInternal.h:
        * bindings/objc/DOMSVG.h:
        * bindings/scripts/CodeGenerator.pm:
        * bindings/scripts/CodeGeneratorObjC.pm:
        * ksvg2/svg/SVGAnimatedAngle.idl:
        * ksvg2/svg/SVGAnimatedBoolean.idl:
        * ksvg2/svg/SVGAnimatedEnumeration.idl:
        * ksvg2/svg/SVGAnimatedInteger.idl:
        * ksvg2/svg/SVGAnimatedLength.idl:
        * ksvg2/svg/SVGAnimatedLengthList.idl:
        * ksvg2/svg/SVGAnimatedNumber.idl:
        * ksvg2/svg/SVGAnimatedPathData.idl:
        * ksvg2/svg/SVGAnimatedString.idl:
        * ksvg2/svg/SVGAnimatedTransformList.idl:
        * ksvg2/svg/SVGExternalResourcesRequired.idl:
        * ksvg2/svg/SVGFilterPrimitiveStandardAttributes.idl:
        * ksvg2/svg/SVGFitToViewBox.idl:
        * ksvg2/svg/SVGLangSpace.idl:
        * ksvg2/svg/SVGLocatable.idl:
        * ksvg2/svg/SVGMetadataElement.idl:
        * ksvg2/svg/SVGStringList.idl:
        * ksvg2/svg/SVGStylable.idl:
        * ksvg2/svg/SVGStyleElement.idl:
        * ksvg2/svg/SVGTests.idl:
        * ksvg2/svg/SVGTransformable.idl:
        * ksvg2/svg/SVGURIReference.idl:
        * ksvg2/svg/SVGUnitTypes.idl:
        * ksvg2/svg/SVGZoomAndPan.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16616 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz Pettel!!!
beidson [Thu, 28 Sep 2006 18:24:01 +0000 (18:24 +0000)]
    Reviewed by Mitz Pettel!!!

        Change the error code check for common functions from SQLResultOk to SQLResultDone

        * loader/icon/IconDatabase.cpp:
        (WebCore::IconDatabase::forgetPageURLQuery):
        (WebCore::IconDatabase::setIconIDForPageURLQuery):
        (WebCore::IconDatabase::addIconForIconURLQuery):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16615 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Geoff.
mjs [Thu, 28 Sep 2006 09:13:03 +0000 (09:13 +0000)]
    Reviewed by Geoff.

        - change garbage collection to happen at increments proportional to number of live objects, not always
        every 1000 allocations

        * kjs/collector.cpp:
        (KJS::Collector::allocate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16614 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Mitz.
mjs [Thu, 28 Sep 2006 09:11:30 +0000 (09:11 +0000)]
    Reviewed by Mitz.

        - fixed REGRESSION (r16606): javascriptCore Crash on website load

        Plus style fixes.

            - fixed some possible off-by-one bugs
            - use indexing, not iterators, for Vectors
            - store Vector by pointer instead of by value to avoid blowing out FunctionImp size

        * kjs/function.cpp:
        (KJS::FunctionImp::addParameter):
        (KJS::FunctionImp::parameterString):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::lengthGetter):
        (KJS::FunctionImp::getParameterName):
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16613 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years agoDump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewp...
hyatt [Thu, 28 Sep 2006 08:49:38 +0000 (08:49 +0000)]
Dump the use of MapWindowPoints on Win32 and just let the outermost HWND be the viewport point of reference for events and such.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16612 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in...
hyatt [Thu, 28 Sep 2006 06:46:35 +0000 (06:46 +0000)]
    Fix for bug 9222, cursor is wrong when mousing over overflow scrollbars in textareas.  Make sure
        selectCursor checks for whether or not a scrollbar was hit.  Also stub out a mouseMoved method for
        scrollbars to provide hover feedback if needed.

        Reviewed by Eric

        * page/FrameView.cpp:
        (WebCore::selectCursor):
        (WebCore::FrameView::handleMouseMoveEvent):
        * platform/ScrollBar.h:
        (WebCore::ScrollBar::mouseMoved):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16611 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-27 Steve Falkenburg <sfalken@apple.com>
sfalken [Thu, 28 Sep 2006 06:32:47 +0000 (06:32 +0000)]
2006-09-27  Steve Falkenburg  <sfalken@apple.com>

        Reviewed by Maciej.

        More build tweaks

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:
        * JavaScriptCore.vcproj/JavaScriptCore/dstroot-to-sdk.cmd: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16610 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-27 MorganL <morganl.webkit@yahoo.com>
aroben [Thu, 28 Sep 2006 04:56:19 +0000 (04:56 +0000)]
2006-09-27  MorganL  <morganl.webkit@yahoo.com>

        Reviewed by Maciej and Adam, landed by Adam

        Fixes: http://bugzilla.opendarwin.org/show_bug.cgi?id=11072
        Windows build is busted

        * platform/win/TemporaryLinkStubs.cpp:
        (ScrollView::paint):
        (ScrollView::themeChanged):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16609 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago * kjs/function.cpp:
sullivan [Thu, 28 Sep 2006 04:35:29 +0000 (04:35 +0000)]
    * kjs/function.cpp:
        (KJS::FunctionImp::getParameterName):
        removed assertion that displeased gcc 4.0.1 (build 5420):
        ASSERT(static_cast<size_t>(index) == index);

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16608 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by GGaren.
kmccullo [Thu, 28 Sep 2006 02:00:32 +0000 (02:00 +0000)]
    Reviewed by GGaren.

        Cleanup of previous fix which was to address Radar: 4752492

        * kjs/function.cpp:
        (KJS::FunctionImp::addParameter):
        (KJS::FunctionImp::parameterString):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::lengthGetter):
        (KJS::FunctionImp::getParameterName):
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16607 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago Reviewed by Adele.
kmccullo [Thu, 28 Sep 2006 00:58:52 +0000 (00:58 +0000)]
    Reviewed by Adele.

        Fixes a GC stack overflow crash.
        The change is to move from a linked list implementation of Parameters to a Vector.
        The problem with the linked list is that each one creates it's own stack frame when being destroyed and in extreme cases this caused the stack to overflow.

        * kjs/function.cpp:
        (KJS::Parameter::Parameter):
        (KJS::FunctionImp::addParameter):
        (KJS::FunctionImp::parameterString):
        (KJS::FunctionImp::processParameters):
        (KJS::FunctionImp::lengthGetter):
        (KJS::FunctionImp::getParameterName):
        * kjs/function.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16606 268f45cc-cd09-0410-ab3c-d52691b4dbfc

13 years ago2006-09-27 Steve Falkenburg <sfalken@apple.com>
sfalken [Thu, 28 Sep 2006 00:54:24 +0000 (00:54 +0000)]
2006-09-27  Steve Falkenburg  <sfalken@apple.com>

        Fix last path fix.

        * JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCore.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@16605 268f45cc-cd09-0410-ab3c-d52691b4dbfc