WebKit-https.git
8 years ago2011-02-15 Gavin Peters <gavinp@chromium.org>
commit-queue@webkit.org [Tue, 15 Feb 2011 13:09:13 +0000 (13:09 +0000)]
2011-02-15  Gavin Peters  <gavinp@chromium.org>

        Reviewed by Antti Koivisto.

        SharedBuffer::buffer() does not do what you think.
        https://bugs.webkit.org/show_bug.cgi?id=54420

        No new tests.

        * inspector/InspectorResourceAgent.cpp:
        (WebCore::InspectorResourceAgent::resourceContentBase64):
        * platform/SharedBuffer.h:
        * platform/image-decoders/jpeg/JPEGImageDecoder.cpp:
        (WebCore::JPEGImageReader::decode):
        (WebCore::JPEGImageDecoder::decode):
        * platform/image-decoders/webp/WEBPImageDecoder.cpp:
        (WebCore::WEBPImageDecoder::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78548 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 15 Feb 2011 11:44:13 +0000 (11:44 +0000)]
2011-02-15  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, unskip passing test after r78541.

        r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
        https://bugs.webkit.org/show_bug.cgi?id=54418

        * platform/gtk/Skipped: Unskip passing test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78547 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 15 Feb 2011 11:33:27 +0000 (11:33 +0000)]
2011-02-15  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, GTK baselines for 4 new tests added in r78396.

        * platform/gtk/fast/inline/inline-box-background-expected.checksum: Added.
        * platform/gtk/fast/inline/inline-box-background-expected.png: Added.
        * platform/gtk/fast/inline/inline-box-background-expected.txt: Added.
        * platform/gtk/fast/inline/inline-box-background-long-image-expected.checksum: Added.
        * platform/gtk/fast/inline/inline-box-background-long-image-expected.png: Added.
        * platform/gtk/fast/inline/inline-box-background-long-image-expected.txt: Added.
        * platform/gtk/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
        * platform/gtk/fast/inline/inline-box-background-repeat-x-expected.png: Added.
        * platform/gtk/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
        * platform/gtk/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
        * platform/gtk/fast/inline/inline-box-background-repeat-y-expected.png: Added.
        * platform/gtk/fast/inline/inline-box-background-repeat-y-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78546 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 David Levin <levin@chromium.org>
levin@chromium.org [Tue, 15 Feb 2011 11:27:00 +0000 (11:27 +0000)]
2011-02-15  David Levin  <levin@chromium.org>

        Reviewed by Shinichiro Hamaji.

        check-webkit-style should do some detection for valid uses of WEBKIT_API (in chromium public api).
        https://bugs.webkit.org/show_bug.cgi?id=52271

        * Scripts/webkitpy/style/checkers/cpp.py: Added the check for WEBKIT_API usage.
        * Scripts/webkitpy/style/checkers/cpp_unittest.py: Added tests.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78545 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 15 Feb 2011 11:26:16 +0000 (11:26 +0000)]
2011-02-15  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: update inspector expectation path for mac-leopard.

        * platform/mac-leopard/inspector/extensions/extensions-resources-expected.txt: Renamed from LayoutTests/platform/mac-leopard/inspector/extensions-resources-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78544 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 Dirk Schulze <krit@webkit.org>
krit@webkit.org [Tue, 15 Feb 2011 11:16:12 +0000 (11:16 +0000)]
2011-02-15  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation doesn't support attribute value 'inherit'
        https://bugs.webkit.org/show_bug.cgi?id=54410

        Check support for 'inherit' and 'currentColor' on SVG animations.

        * svg/animations/animate-currentColor-expected.txt: Added.
        * svg/animations/animate-currentColor.html: Added.
        * svg/animations/animate-inherit-css-property-expected.txt: Added.
        * svg/animations/animate-inherit-css-property.html: Added.
        * svg/animations/script-tests/animate-currentColor.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
        * svg/animations/script-tests/animate-inherit-css-property.js: Added.
        (sample1):
        (sample2):
        (sample3):
        (executeTest):
2011-02-15  Dirk Schulze  <krit@webkit.org>

        Reviewed by Nikolas Zimmermann.

        SVG animation doesn't support attribute value 'inherit'
        https://bugs.webkit.org/show_bug.cgi?id=54410

        SVG animation does not support 'inherit' as value for CSS property animations. With the patch, SVG determines
        if the attribute of the target element is an animatable CSS Property and computes the style during the
        animation.

        This fixes the following tests on the W3C test suite:
        * animate-elem-84-t.svg
        * animate-elem-85-t.svg

        Tests: svg/animations/animate-currentColor.html
               svg/animations/animate-inherit-css-property.html

        * svg/SVGAnimateElement.cpp:
        (WebCore::adjustForCurrentColor):
        (WebCore::adjustForInheritance):
        (WebCore::SVGAnimateElement::calculateAnimatedValue): When a property value is 'inherit' or 'currentColor'
        during the animation, get the computed style of the property since the values could be animated themselves.
        (WebCore::inheritsFromProperty):
        (WebCore::attributeValueIsCurrentColor):
        (WebCore::SVGAnimateElement::calculateFromAndToValues): Check if 'from', 'by' or 'to' value has the
        string 'inherit' or 'currentColor' and if the attribute supports one of these values.
        (WebCore::SVGAnimateElement::calculateFromAndByValues): Ditto.
        * svg/SVGAnimateElement.h:
        * svg/SVGAnimationElement.cpp:
        (WebCore::SVGAnimationElement::isTargetAttributeCSSProperty): Check if target element is stylable and
        the attribute is an animatable CSS property by using the CSS property map in SVGStyledElement.
        (WebCore::SVGAnimationElement::setTargetAttributeAnimatedValue): s/target/targetElement/ for consistency.
        * svg/SVGAnimationElement.h:
        * svg/SVGStyledElement.cpp:
        (WebCore::SVGStyledElement::isAnimatableCSSProperty): Checks if the CSS property is animatable.
        * svg/SVGStyledElement.h:
        * svg/animation/SMILTimeContainer.cpp: Use the new function isTargetAttributeCSSProperty to determine
        if the target element is stylable and the attribute is an animatable CSS property.
        (WebCore::SMILTimeContainer::baseValueFor):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78543 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agor78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
antti@apple.com [Tue, 15 Feb 2011 11:03:26 +0000 (11:03 +0000)]
r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
https://bugs.webkit.org/show_bug.cgi?id=54418

Reviewed by Andreas Kling.

Check for zero buffer length.

* platform/text/TextCodecUTF8.cpp:
(WebCore::TextCodecUTF8::decode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78541 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 15 Feb 2011 10:55:28 +0000 (10:55 +0000)]
2011-02-15  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: inspector tests expectations update.

        * platform/chromium/inspector/console/console-format-collections-expected.txt:
        * platform/mac-wk2/Skipped:
        * platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78540 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 15 Feb 2011 10:49:53 +0000 (10:49 +0000)]
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

        [Chromium] Update image results for CSS tests on Mac Leopard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78539 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 Mikhail Naganov <mnaganov@chromium.org>
mnaganov@chromium.org [Tue, 15 Feb 2011 10:35:54 +0000 (10:35 +0000)]
2011-02-15 Mikhail Naganov <mnaganov@chromium.org>

    [Chromium] Unreviewed test expectations update after r78525

    LayoutTests/platform/chromium/fast/dom/prototype-inheritance-expected.txt

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78538 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 Mario Sanchez Prada <msanchez@igalia.com>
mario@webkit.org [Tue, 15 Feb 2011 10:26:49 +0000 (10:26 +0000)]
2011-02-15  Mario Sanchez Prada  <msanchez@igalia.com>

        Unreviewed, skipping test timing out on SnowLeopard, GTK and Chromium bots.

        r78499 causes assertion failure in http/tests/xmlhttprequest/cache-override.html
        https://bugs.webkit.org/show_bug.cgi?id=54418

        * platform/gtk/Skipped: Skipped test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78537 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed.
ossy@webkit.org [Tue, 15 Feb 2011 10:22:17 +0000 (10:22 +0000)]
Unreviewed.

[Qt]REGRESSION?(78477): inspector/timeline-network-resource.html and inspector/timeline-script-tag-1.html fail
https://bugs.webkit.org/show_bug.cgi?id=54442

* platform/qt/Skipped: inspector/timeline-network-resource.html and inspector/timeline-script-tag-1.html added until fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78536 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Tue, 15 Feb 2011 10:02:26 +0000 (10:02 +0000)]
2011-02-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move rest of the tests off old harness.
        https://bugs.webkit.org/show_bug.cgi?id=54437

        * http/tests/inspector-enabled/console-log-before-frame-navigation.html:
        * http/tests/inspector/change-iframe-src-expected.txt:
        * http/tests/inspector/change-iframe-src.html:
        * http/tests/inspector/console-resource-errors.html:
        * http/tests/inspector/console-websocket-error.html:
        * http/tests/inspector/console-xhr-logging.html:
        * http/tests/inspector/extensions-headers.html:
        * http/tests/inspector/extensions-resources-redirect-expected.txt:
        * http/tests/inspector/extensions-resources-redirect.html:
        * http/tests/inspector/extensions-test.js:
        * http/tests/inspector/inspect-iframe-from-different-domain-expected.txt:
        * http/tests/inspector/inspect-iframe-from-different-domain.html:
        * http/tests/inspector/inspector-test.js:
        * http/tests/inspector/inspector-test2.js: Removed.
        * http/tests/inspector/network-preflight-options.html:
        * http/tests/inspector/resource-har-conversion-expected.txt:
        * http/tests/inspector/resource-har-conversion.html:
        * http/tests/inspector/resource-parameters.html:
        * http/tests/inspector/resources/extension-main.html:
        * http/tests/inspector/resources/iframe-from-different-domain-data.html:
        * inspector/audits/audits-panel-functional-expected.txt: Renamed from LayoutTests/inspector/audits-panel-functional-expected.txt.
        * inspector/audits/audits-panel-functional.html: Renamed from LayoutTests/inspector/audits-panel-functional.html.
        * inspector/audits/audits-test.js: Renamed from LayoutTests/inspector/audits-tests2.js.
        * inspector/audits/resources/Ahem.ttf: Copied from LayoutTests/inspector/resources/Ahem.ttf.
        * inspector/audits/resources/abe.png: Copied from LayoutTests/inspector/resources/abe.png.
        * inspector/audits/resources/audits-script1.js: Renamed from LayoutTests/inspector/resources/audits-script1.js.
        * inspector/audits/resources/audits-script2.js: Renamed from LayoutTests/inspector/resources/audits-script2.js.
        * inspector/audits/resources/audits-style1.css: Copied from LayoutTests/inspector/resources/audits-style1.css.
        * inspector/console/command-line-api-expected.txt: Renamed from LayoutTests/inspector/command-line-api-expected.txt.
        * inspector/console/command-line-api.html: Renamed from LayoutTests/inspector/command-line-api.html.
        * inspector/console/console-api-on-call-frame-expected.txt: Renamed from LayoutTests/inspector/console-api-on-call-frame-expected.txt.
        * inspector/console/console-api-on-call-frame.html: Renamed from LayoutTests/inspector/console-api-on-call-frame.html.
        * inspector/console/console-assert-expected.txt: Renamed from LayoutTests/inspector/console-assert-expected.txt.
        * inspector/console/console-assert.html: Renamed from LayoutTests/inspector/console-assert.html.
        * inspector/console/console-clear-expected.txt: Renamed from LayoutTests/inspector/console-clear-expected.txt.
        * inspector/console/console-clear.html: Renamed from LayoutTests/inspector/console-clear.html.
        * inspector/console/console-command-clear-expected.txt: Renamed from LayoutTests/inspector/console-command-clear-expected.txt.
        * inspector/console/console-command-clear.html: Renamed from LayoutTests/inspector/console-command-clear.html.
        * inspector/console/console-dir-expected.txt: Renamed from LayoutTests/inspector/console-dir-expected.txt.
        * inspector/console/console-dir-global-expected.txt: Renamed from LayoutTests/inspector/console-dir-global-expected.txt.
        * inspector/console/console-dir-global.html: Renamed from LayoutTests/inspector/console-dir-global.html.
        * inspector/console/console-dir.html: Renamed from LayoutTests/inspector/console-dir.html.
        * inspector/console/console-dirxml-expected.txt: Renamed from LayoutTests/inspector/console-dirxml-expected.txt.
        * inspector/console/console-dirxml.html: Renamed from LayoutTests/inspector/console-dirxml.html.
        * inspector/console/console-eval-expected.txt: Renamed from LayoutTests/inspector/console-eval-expected.txt.
        * inspector/console/console-eval-global-expected.txt: Renamed from LayoutTests/inspector/console-eval-global-expected.txt.
        * inspector/console/console-eval-global.html: Renamed from LayoutTests/inspector/console-eval-global.html.
        * inspector/console/console-eval.html: Renamed from LayoutTests/inspector/console-eval.html.
        * inspector/console/console-format-collections-expected.txt: Renamed from LayoutTests/inspector/console-format-collections-expected.txt.
        * inspector/console/console-format-collections.html: Renamed from LayoutTests/inspector/console-format-collections.html.
        * inspector/console/console-format-expected.txt: Renamed from LayoutTests/inspector/console-format-expected.txt.
        * inspector/console/console-format.html: Renamed from LayoutTests/inspector/console-format.html.
        * inspector/console/console-log-before-inspector-open-expected.txt: Renamed from LayoutTests/inspector/console-log-before-inspector-open-expected.txt.
        * inspector/console/console-log-before-inspector-open.html: Renamed from LayoutTests/inspector/console-log-before-inspector-open.html.
        * inspector/console/console-log-native-funcs-expected.txt: Renamed from LayoutTests/inspector/console-log-native-funcs-expected.txt.
        * inspector/console/console-log-syntax-error-expected.txt: Renamed from LayoutTests/inspector/console-log-syntax-error-expected.txt.
        * inspector/console/console-log-syntax-error.html: Renamed from LayoutTests/inspector/console-log-syntax-error.html.
        * inspector/console/console-object-constructor-name-expected.txt: Renamed from LayoutTests/inspector/console-object-constructor-name-expected.txt.
        * inspector/console/console-object-constructor-name.html: Renamed from LayoutTests/inspector/console-object-constructor-name.html.
        * inspector/console/console-substituted-expected.txt: Renamed from LayoutTests/inspector/console-substituted-expected.txt.
        * inspector/console/console-substituted.html: Renamed from LayoutTests/inspector/console-substituted.html.
        * inspector/console/console-tests-expected.txt: Renamed from LayoutTests/inspector/console-tests-expected.txt.
        * inspector/console/console-tests.html: Renamed from LayoutTests/inspector/console-tests.html.
        * inspector/console/console-trace-expected.txt: Renamed from LayoutTests/inspector/console-trace-expected.txt.
        * inspector/console/console-trace-in-eval-expected.txt: Renamed from LayoutTests/inspector/console-trace-in-eval-expected.txt.
        * inspector/console/console-trace-in-eval.html: Renamed from LayoutTests/inspector/console-trace-in-eval.html.
        * inspector/console/console-trace.html: Renamed from LayoutTests/inspector/console-trace.html.
        * inspector/console/console-uncaught-exception-expected.txt: Renamed from LayoutTests/inspector/console-uncaught-exception-expected.txt.
        * inspector/console/console-uncaught-exception-in-eval-expected.txt: Renamed from LayoutTests/inspector/console-uncaught-exception-in-eval-expected.txt.
        * inspector/console/console-uncaught-exception-in-eval.html: Renamed from LayoutTests/inspector/console-uncaught-exception-in-eval.html.
        * inspector/console/console-uncaught-exception.html: Renamed from LayoutTests/inspector/console-uncaught-exception.html.
        * inspector/console/resources/syntax-error.js: Copied from LayoutTests/inspector/resources/syntax-error.js.
        * inspector/cookie-parser.html:
        * inspector/cookie-resource-match.html:
        * inspector/cpu-profiler-profiling.html:
        * inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt: Renamed from LayoutTests/inspector/debugger-autocontinue-on-syntax-error-expected.txt.
        * inspector/debugger/debugger-autocontinue-on-syntax-error.html: Renamed from LayoutTests/inspector/debugger-autocontinue-on-syntax-error.html.
        * inspector/debugger/debugger-breakpoints-not-activated-on-reload-expected.txt: Renamed from LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload-expected.txt.
        * inspector/debugger/debugger-breakpoints-not-activated-on-reload.html: Renamed from LayoutTests/inspector/debugger-breakpoints-not-activated-on-reload.html.
        * inspector/debugger/debugger-cyclic-ref-expected.txt: Renamed from LayoutTests/inspector/debugger-cyclic-ref-expected.txt.
        * inspector/debugger/debugger-cyclic-ref.html: Renamed from LayoutTests/inspector/debugger-cyclic-ref.html.
        * inspector/debugger/debugger-eval-on-call-frame-expected.txt: Renamed from LayoutTests/inspector/debugger-eval-on-call-frame-expected.txt.
        * inspector/debugger/debugger-eval-on-call-frame.html: Renamed from LayoutTests/inspector/debugger-eval-on-call-frame.html.
        * inspector/debugger/debugger-eval-while-paused-expected.txt: Renamed from LayoutTests/inspector/debugger-eval-while-paused-expected.txt.
        * inspector/debugger/debugger-eval-while-paused.html: Renamed from LayoutTests/inspector/debugger-eval-while-paused.html.
        * inspector/debugger/debugger-expand-scope-expected.txt: Renamed from LayoutTests/inspector/debugger-expand-scope-expected.txt.
        * inspector/debugger/debugger-expand-scope.html: Renamed from LayoutTests/inspector/debugger-expand-scope.html.
        * inspector/debugger/debugger-no-nested-pause-expected.txt: Renamed from LayoutTests/inspector/debugger-no-nested-pause-expected.txt.
        * inspector/debugger/debugger-no-nested-pause.html: Renamed from LayoutTests/inspector/debugger-no-nested-pause.html.
        * inspector/debugger/debugger-pause-in-eval-script-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-in-eval-script-expected.txt.
        * inspector/debugger/debugger-pause-in-eval-script.html: Renamed from LayoutTests/inspector/debugger-pause-in-eval-script.html.
        * inspector/debugger/debugger-pause-on-breakpoint-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-on-breakpoint-expected.txt.
        * inspector/debugger/debugger-pause-on-breakpoint.html: Renamed from LayoutTests/inspector/debugger-pause-on-breakpoint.html.
        * inspector/debugger/debugger-pause-on-debugger-statement-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-on-debugger-statement-expected.txt.
        * inspector/debugger/debugger-pause-on-debugger-statement.html: Renamed from LayoutTests/inspector/debugger-pause-on-debugger-statement.html.
        * inspector/debugger/debugger-pause-on-exception-expected.txt: Renamed from LayoutTests/inspector/debugger-pause-on-exception-expected.txt.
        * inspector/debugger/debugger-pause-on-exception.html: Renamed from LayoutTests/inspector/debugger-pause-on-exception.html.
        * inspector/debugger/debugger-proto-property-expected.txt: Renamed from LayoutTests/inspector/debugger-proto-property-expected.txt.
        * inspector/debugger/debugger-proto-property.html: Renamed from LayoutTests/inspector/debugger-proto-property.html.
        * inspector/debugger/debugger-scripts-expected.txt: Renamed from LayoutTests/inspector/debugger-scripts-expected.txt.
        * inspector/debugger/debugger-scripts.html: Renamed from LayoutTests/inspector/debugger-scripts.html.
        * inspector/debugger/debugger-step-in-expected.txt: Renamed from LayoutTests/inspector/debugger-step-in-expected.txt.
        * inspector/debugger/debugger-step-in.html: Renamed from LayoutTests/inspector/debugger-step-in.html.
        * inspector/debugger/debugger-step-out-expected.txt: Renamed from LayoutTests/inspector/debugger-step-out-expected.txt.
        * inspector/debugger/debugger-step-out.html: Renamed from LayoutTests/inspector/debugger-step-out.html.
        * inspector/debugger/debugger-step-over-expected.txt: Renamed from LayoutTests/inspector/debugger-step-over-expected.txt.
        * inspector/debugger/debugger-step-over.html: Renamed from LayoutTests/inspector/debugger-step-over.html.
        * inspector/debugger/debugger-suspend-active-dom-objects-expected.txt: Renamed from LayoutTests/inspector/debugger-suspend-active-dom-objects-expected.txt.
        * inspector/debugger/debugger-suspend-active-dom-objects.html: Renamed from LayoutTests/inspector/debugger-suspend-active-dom-objects.html.
        * inspector/debugger/dom-breakpoints-expected.txt: Renamed from LayoutTests/inspector/dom-breakpoints-expected.txt.
        * inspector/debugger/dom-breakpoints.html: Renamed from LayoutTests/inspector/dom-breakpoints.html.
        * inspector/debugger/resources/syntax-error.js: Renamed from LayoutTests/inspector/resources/syntax-error.js.
        * inspector/elements/elements-delete-inline-style-expected.txt: Renamed from LayoutTests/inspector/elements-delete-inline-style-expected.txt.
        * inspector/elements/elements-delete-inline-style.html: Renamed from LayoutTests/inspector/elements-delete-inline-style.html.
        * inspector/elements/elements-img-tooltip-expected.txt: Renamed from LayoutTests/inspector/elements-img-tooltip-expected.txt.
        * inspector/elements/elements-img-tooltip.html: Renamed from LayoutTests/inspector/elements-img-tooltip.html.
        * inspector/elements/elements-panel-limited-children-expected.txt: Renamed from LayoutTests/inspector/elements-panel-limited-children-expected.txt.
        * inspector/elements/elements-panel-limited-children.html: Renamed from LayoutTests/inspector/elements-panel-limited-children.html.
        * inspector/elements/elements-panel-rewrite-href-expected.txt: Renamed from LayoutTests/inspector/elements-panel-rewrite-href-expected.txt.
        * inspector/elements/elements-panel-rewrite-href.html: Renamed from LayoutTests/inspector/elements-panel-rewrite-href.html.
        * inspector/elements/elements-panel-search-expected.txt: Renamed from LayoutTests/inspector/elements-panel-search-expected.txt.
        * inspector/elements/elements-panel-search.html: Renamed from LayoutTests/inspector/elements-panel-search.html.
        * inspector/elements/elements-panel-selection-on-refresh-expected.txt: Renamed from LayoutTests/inspector/elements-panel-selection-on-refresh-expected.txt.
        * inspector/elements/elements-panel-selection-on-refresh.html: Renamed from LayoutTests/inspector/elements-panel-selection-on-refresh.html.
        * inspector/elements/elements-panel-structure-expected.txt: Renamed from LayoutTests/inspector/elements-panel-structure-expected.txt.
        * inspector/elements/elements-panel-structure.html: Renamed from LayoutTests/inspector/elements-panel-structure.html.
        * inspector/elements/elements-panel-styles-expected.txt: Renamed from LayoutTests/inspector/elements-panel-styles-expected.txt.
        * inspector/elements/elements-panel-styles.html: Renamed from LayoutTests/inspector/elements-panel-styles.html.
        * inspector/elements/elements-panel-xhtml-structure-expected.txt: Renamed from LayoutTests/inspector/elements-panel-xhtml-structure-expected.txt.
        * inspector/elements/elements-panel-xhtml-structure.xhtml: Renamed from LayoutTests/inspector/elements-panel-xhtml-structure.xhtml.
        * inspector/elements/resources/elements-panel-styles.css: Renamed from LayoutTests/inspector/resources/elements-panel-styles.css.
        * inspector/evaluate-in-page.html:
        * inspector/extensions/extensions-api-expected.txt: Renamed from LayoutTests/inspector/extensions-api-expected.txt.
        * inspector/extensions/extensions-api.html: Renamed from LayoutTests/inspector/extensions-api.html.
        * inspector/extensions/extensions-audits-api-expected.txt: Renamed from LayoutTests/inspector/extensions-audits-api-expected.txt.
        * inspector/extensions/extensions-audits-api.html: Renamed from LayoutTests/inspector/extensions-audits-api.html.
        * inspector/extensions/extensions-audits-expected.txt: Renamed from LayoutTests/inspector/extensions-audits-expected.txt.
        * inspector/extensions/extensions-audits-tests.js: Renamed from LayoutTests/inspector/extensions-audits-tests.js.
        * inspector/extensions/extensions-audits.html: Renamed from LayoutTests/inspector/extensions-audits.html.
        * inspector/extensions/extensions-eval-expected.txt: Renamed from LayoutTests/inspector/extensions-eval-expected.txt.
        * inspector/extensions/extensions-eval.html: Renamed from LayoutTests/inspector/extensions-eval.html.
        * inspector/extensions/extensions-events-expected.txt: Renamed from LayoutTests/inspector/extensions-events-expected.txt.
        * inspector/extensions/extensions-events.html: Renamed from LayoutTests/inspector/extensions-events.html.
        * inspector/extensions/extensions-expected.txt: Renamed from LayoutTests/inspector/extensions-expected.txt.
        * inspector/extensions/extensions-resources-expected.txt: Renamed from LayoutTests/inspector/extensions-resources-expected.txt.
        * inspector/extensions/extensions-resources.html: Renamed from LayoutTests/inspector/extensions-resources.html.
        * inspector/extensions/extensions.html: Renamed from LayoutTests/inspector/extensions.html.
        * inspector/extensions/resources/Ahem.ttf: Renamed from LayoutTests/inspector/resources/Ahem.ttf.
        * inspector/extensions/resources/abe.png: Renamed from LayoutTests/inspector/resources/abe.png.
        * inspector/extensions/resources/audits-style1.css: Renamed from LayoutTests/inspector/resources/audits-style1.css.
        * inspector/inspected-objects-not-overriden.html:
        * inspector/report-API-errors.html:
        * inspector/report-protocol-errors.html:
        * inspector/storage-panel-dom-storage.html:
        * inspector/styles/resources/styles-iframe-data.html: Renamed from LayoutTests/inspector/resources/styles-iframe-data.html.
        * inspector/styles/resources/styles-new-API-1.css: Renamed from LayoutTests/inspector/resources/styles-new-API-1.css.
        * inspector/styles/resources/styles-new-API.css: Renamed from LayoutTests/inspector/resources/styles-new-API.css.
        * inspector/styles/resources/styles-source-lines-inline-iframe.html: Renamed from LayoutTests/inspector/resources/styles-source-lines-inline-iframe.html.
        * inspector/styles/resources/styles-source-offsets.css: Renamed from LayoutTests/inspector/resources/styles-source-offsets.css.
        * inspector/styles/resources/styles-url-linkify-iframe.html: Renamed from LayoutTests/inspector/resources/styles-url-linkify-iframe.html.
        * inspector/styles/resources/styles-url-linkify.css: Renamed from LayoutTests/inspector/resources/styles-url-linkify.css.
        * inspector/styles/styles-add-blank-property-expected.txt: Renamed from LayoutTests/inspector/styles-add-blank-property-expected.txt.
        * inspector/styles/styles-add-blank-property.html: Renamed from LayoutTests/inspector/styles-add-blank-property.html.
        * inspector/styles/styles-computed-trace-expected.txt: Renamed from LayoutTests/inspector/styles-computed-trace-expected.txt.
        * inspector/styles/styles-computed-trace.html: Renamed from LayoutTests/inspector/styles-computed-trace.html.
        * inspector/styles/styles-disable-inherited-expected.txt: Renamed from LayoutTests/inspector/styles-disable-inherited-expected.txt.
        * inspector/styles/styles-disable-inherited.html: Renamed from LayoutTests/inspector/styles-disable-inherited.html.
        * inspector/styles/styles-disable-then-change-expected.txt: Renamed from LayoutTests/inspector/styles-disable-then-change-expected.txt.
        * inspector/styles/styles-disable-then-change.html: Renamed from LayoutTests/inspector/styles-disable-then-change.html.
        * inspector/styles/styles-disable-then-delete-expected.txt: Renamed from LayoutTests/inspector/styles-disable-then-delete-expected.txt.
        * inspector/styles/styles-disable-then-delete.html: Renamed from LayoutTests/inspector/styles-disable-then-delete.html.
        * inspector/styles/styles-disable-then-enable-expected.txt: Renamed from LayoutTests/inspector/styles-disable-then-enable-expected.txt.
        * inspector/styles/styles-disable-then-enable.html: Renamed from LayoutTests/inspector/styles-disable-then-enable.html.
        * inspector/styles/styles-iframe-expected.txt: Renamed from LayoutTests/inspector/styles-iframe-expected.txt.
        * inspector/styles/styles-iframe.html: Renamed from LayoutTests/inspector/styles-iframe.html.
        * inspector/styles/styles-new-API-expected.txt: Renamed from LayoutTests/inspector/styles-new-API-expected.txt.
        * inspector/styles/styles-new-API.html: Renamed from LayoutTests/inspector/styles-new-API.html.
        * inspector/styles/styles-source-lines-expected.txt: Renamed from LayoutTests/inspector/styles-source-lines-expected.txt.
        * inspector/styles/styles-source-lines-inline-expected.txt: Renamed from LayoutTests/inspector/styles-source-lines-inline-expected.txt.
        * inspector/styles/styles-source-lines-inline.html: Renamed from LayoutTests/inspector/styles-source-lines-inline.html.
        * inspector/styles/styles-source-lines.html: Renamed from LayoutTests/inspector/styles-source-lines.html.
        * inspector/styles/styles-source-offsets-expected.txt: Renamed from LayoutTests/inspector/styles-source-offsets-expected.txt.
        * inspector/styles/styles-source-offsets.html: Renamed from LayoutTests/inspector/styles-source-offsets.html.
        * inspector/styles/styles-url-linkify-expected.txt: Renamed from LayoutTests/inspector/styles-url-linkify-expected.txt.
        * inspector/styles/styles-url-linkify.html: Renamed from LayoutTests/inspector/styles-url-linkify.html.
        * inspector/syntax-highlight-css.html:
        * inspector/syntax-highlight-html.html:
        * inspector/syntax-highlight-javascript.html:
        * inspector/timeline/resources/timeline-iframe-data.html: Renamed from LayoutTests/inspector/resources/timeline-iframe-data.html.
        * inspector/timeline/timeline-enum-stability-expected.txt: Renamed from LayoutTests/inspector/timeline-enum-stability-expected.txt.
        * inspector/timeline/timeline-enum-stability.html: Renamed from LayoutTests/inspector/timeline-enum-stability.html.
        * inspector/timeline/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/inspector/timeline-event-dispatch-expected.txt.
        * inspector/timeline/timeline-event-dispatch.html: Renamed from LayoutTests/inspector/timeline-event-dispatch.html.
        * inspector/timeline/timeline-layout-expected.txt: Renamed from LayoutTests/inspector/timeline-layout-expected.txt.
        * inspector/timeline/timeline-layout.html: Renamed from LayoutTests/inspector/timeline-layout.html.
        * inspector/timeline/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/inspector/timeline-mark-timeline-expected.txt.
        * inspector/timeline/timeline-mark-timeline.html: Renamed from LayoutTests/inspector/timeline-mark-timeline.html.
        * inspector/timeline/timeline-network-resource-expected.txt: Renamed from LayoutTests/inspector/timeline-network-resource-expected.txt.
        * inspector/timeline/timeline-network-resource.html: Renamed from LayoutTests/inspector/timeline-network-resource.html.
        * inspector/timeline/timeline-network-resource.js: Renamed from LayoutTests/inspector/timeline-network-resource.js.
        * inspector/timeline/timeline-paint-expected.txt: Renamed from LayoutTests/inspector/timeline-paint-expected.txt.
        * inspector/timeline/timeline-paint.html: Renamed from LayoutTests/inspector/timeline-paint.html.
        * inspector/timeline/timeline-parse-html-expected.txt: Renamed from LayoutTests/inspector/timeline-parse-html-expected.txt.
        * inspector/timeline/timeline-parse-html.html: Renamed from LayoutTests/inspector/timeline-parse-html.html.
        * inspector/timeline/timeline-recalculate-styles-expected.txt: Renamed from LayoutTests/inspector/timeline-recalculate-styles-expected.txt.
        * inspector/timeline/timeline-recalculate-styles.html: Renamed from LayoutTests/inspector/timeline-recalculate-styles.html.
        * inspector/timeline/timeline-script-tag-1-expected.txt: Renamed from LayoutTests/inspector/timeline-script-tag-1-expected.txt.
        * inspector/timeline/timeline-script-tag-1.html: Renamed from LayoutTests/inspector/timeline-script-tag-1.html.
        * inspector/timeline/timeline-script-tag-2-expected.txt: Renamed from LayoutTests/inspector/timeline-script-tag-2-expected.txt.
        * inspector/timeline/timeline-script-tag-2.html: Renamed from LayoutTests/inspector/timeline-script-tag-2.html.
        * inspector/timeline/timeline-script-tag-2.js: Renamed from LayoutTests/inspector/timeline-script-tag-2.js.
        * inspector/timeline/timeline-test.js: Renamed from LayoutTests/inspector/timeline-test.js.
        * inspector/timeline/timeline-trivial-expected.txt: Renamed from LayoutTests/inspector/timeline-trivial-expected.txt.
        * inspector/timeline/timeline-trivial.html: Renamed from LayoutTests/inspector/timeline-trivial.html.
        * platform/chromium/inspector/console/console-dir-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-dir-expected.txt.
        * platform/chromium/inspector/console/console-dir-global-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-dir-global-expected.txt.
        * platform/chromium/inspector/console/console-eval-global-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-eval-global-expected.txt.
        * platform/chromium/inspector/console/console-format-collections-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-format-collections-expected.txt.
        * platform/chromium/inspector/console/console-format-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-format-expected.txt.
        * platform/chromium/inspector/console/console-log-native-funcs-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-log-native-funcs-expected.txt.
        * platform/chromium/inspector/console/console-log-syntax-error-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-log-syntax-error-expected.txt.
        * platform/chromium/inspector/console/console-object-constructor-name-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-object-constructor-name-expected.txt.
        * platform/chromium/inspector/console/console-trace-in-eval-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-trace-in-eval-expected.txt.
        * platform/chromium/inspector/console/console-uncaught-exception-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-uncaught-exception-expected.txt.
        * platform/chromium/inspector/console/console-uncaught-exception-in-eval-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt.
        * platform/chromium/inspector/debugger/debugger-autocontinue-on-syntax-error-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-autocontinue-on-syntax-error-expected.txt.
        * platform/chromium/inspector/debugger/debugger-expand-scope-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-expand-scope-expected.txt.
        * platform/chromium/inspector/debugger/debugger-pause-on-exception-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-pause-on-exception-expected.txt.
        * platform/chromium/inspector/debugger/debugger-step-in-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/debugger-step-in-expected.txt.
        * platform/chromium/inspector/timeline/timeline-event-dispatch-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-event-dispatch-expected.txt.
        * platform/chromium/inspector/timeline/timeline-mark-timeline-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-mark-timeline-expected.txt.
        * platform/chromium/inspector/timeline/timeline-network-resource-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-network-resource-expected.txt.
        * platform/chromium/inspector/timeline/timeline-paint-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-paint-expected.txt.
        * platform/chromium/inspector/timeline/timeline-parse-html-expected.txt: Renamed from LayoutTests/platform/chromium/inspector/timeline-parse-html-expected.txt.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/Skipped:
        * platform/mac/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78535 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-15 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 15 Feb 2011 09:57:59 +0000 (09:57 +0000)]
2011-02-15  MORITA Hajime  <morrita@google.com>

        Unreviewed build fix.

        * page/EditorClient.h: Changed GrammarDetail forward declaration from class to struct.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78534 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-01-26 MORITA Hajime <morrita@google.com>
morrita@google.com [Tue, 15 Feb 2011 08:28:20 +0000 (08:28 +0000)]
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        Created new abstract class TextCheckerClient. The class has
        spellcheck related API which is split.
        This is the first step for sharing spell-checking codebase
        between ports. A standalone TextCheckerClient implementation
        should be done in future changes.

        No new tests. No behavioral change.

        * GNUmakefile.am:
        * WebCore.gypi:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * accessibility/mac/AccessibilityObjectWrapper.mm:
        (AXAttributeStringSetSpelling):
        * editing/Editor.cpp: Replacing some client() call with textChecker().
        (WebCore::Editor::textChecker): Added.
        (WebCore::Editor::ignoreSpelling):
        (WebCore::Editor::learnSpelling):
        (WebCore::Editor::isSelectionMisspelled):
        (WebCore::Editor::guessesForMisspelledSelection):
        (WebCore::Editor::markMisspellingsAfterTypingToWord):
        (WebCore::Editor::markAllMisspellingsAndBadGrammarInRanges):
        (WebCore::Editor::correctionPanelTimerFired):
        * editing/Editor.h:
        * editing/SpellChecker.cpp:
        (WebCore::SpellChecker::SpellChecker):
        * editing/TextCheckingHelper.cpp: Replacing some client() call with textChecker().
        (WebCore::TextCheckingHelper::findFirstMisspelling):
        (WebCore::TextCheckingHelper::findFirstMisspellingOrBadGrammar):
        (WebCore::TextCheckingHelper::findFirstBadGrammar):
        (WebCore::TextCheckingHelper::guessesForMisspelledOrUngrammaticalRange):
        * loader/EmptyClients.h: Added EmptyTextCheckerClient.
        (WebCore::EmptyTextCheckerClient::ignoreWordInSpellDocument):
        (WebCore::EmptyTextCheckerClient::learnWord):
        (WebCore::EmptyTextCheckerClient::checkSpellingOfString):
        (WebCore::EmptyTextCheckerClient::getAutoCorrectSuggestionForMisspelledWord):
        (WebCore::EmptyTextCheckerClient::checkGrammarOfString):
        (WebCore::EmptyTextCheckerClient::checkTextOfParagraph):
        (WebCore::EmptyTextCheckerClient::getGuessesForWord):
        (WebCore::EmptyTextCheckerClient::requestCheckingOfString):
        (WebCore::EmptyEditorClient::textChecker):
        * page/EditorClient.h: Extracted TextCheckerClient.
        * page/Page.h:
        * platform/text/TextCheckerClient.h: Added.
        (WebCore::TextCheckerClient::~TextCheckerClient):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * src/EditorClientImpl.h:
        (WebKit::EditorClientImpl::textChecker):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * WebCoreSupport/EditorClientEfl.h:
        (WebCore::EditorClientEfl::textChecker):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * WebCoreSupport/EditorClientGtk.h:
        (WebKit::EditorClient::textChecker):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * WebCoreSupport/EditorClientHaiku.h:
        (WebCore::EditorClientHaiku::textChecker):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * WebCoreSupport/WebEditorClient.h:
        (WebEditorClient::textChecker):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * WebCoreSupport/EditorClientQt.h:
        (WebCore::EditorClientQt::textChecker):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * WebCoreSupport/WebEditorClient.h:
        (WebEditorClient::textChecker):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * WebCoreSupport/EditorClientWinCE.h:
        (WebKit::EditorClientWinCE::textChecker):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * WebKitSupport/EditorClientWx.h:
        (WebCore::EditorClientWx::textChecker):
2011-01-26  MORITA Hajime  <morrita@google.com>

        Reviewed by Ryosuke Niwa.

        Refactoring: Extract TextCheckerClient from EditorClient
        https://bugs.webkit.org/show_bug.cgi?id=53213

        * Shared/WebCoreArgumentCoders.h:
        * UIProcess/TextChecker.h:
        * WebProcess/WebCoreSupport/WebEditorClient.h:
        (WebKit::WebEditorClient::textChecker):
        * Scripts/webkit2/messages.py: Re-arranged the include file

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78533 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-07 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Tue, 15 Feb 2011 08:21:50 +0000 (08:21 +0000)]
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * src/EditorClientImpl.cpp:
        (WebKit::EditorClientImpl::canCopyCut): Added.
        (WebKit::EditorClientImpl::canPaste): Added.
        * src/EditorClientImpl.h:
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * WebCoreSupport/EditorClientQt.cpp:
        (WebCore::EditorClientQt::canCopyCut): Added.
        (WebCore::EditorClientQt::canPaste): Added.
        * WebCoreSupport/EditorClientQt.h:
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::canCopyCut): Added.
        (WebKit::EditorClient::canPaste): Added.
        * WebCoreSupport/EditorClientGtk.h:
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * WebCoreSupport/WebEditorClient.cpp:
        (WebEditorClient::canCopyCut): Added.
        (WebEditorClient::canPaste): Added.
        * WebCoreSupport/WebEditorClient.h:
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * WebKitSupport/EditorClientWx.cpp:
        (WebCore::EditorClientWx::canCopyCut): Added.
        (WebCore::EditorClientWx::canPaste): Added.
        * WebKitSupport/EditorClientWx.h:
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * WebCoreSupport/WebEditorClient.h:
        * WebCoreSupport/WebEditorClient.mm:
        (WebEditorClient::canCopyCut): Added.
        (WebEditorClient::canPaste): Added.
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * WebCoreSupport/EditorClientHaiku.cpp:
        (WebCore::EditorClientHaiku::canCopyCut): Added.
        (WebCore::EditorClientHaiku::canPaste): Added.
        * WebCoreSupport/EditorClientHaiku.h:
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * WebCoreSupport/EditorClientWinCE.cpp:
        (WebKit::EditorClientWinCE::canCopyCut): Added.
        (WebKit::EditorClientWinCE::canPaste): Added.
        * WebCoreSupport/EditorClientWinCE.h:
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * WebCoreSupport/EditorClientEfl.cpp:
        (WebCore::EditorClientEfl::canCopyCut): Added.
        (WebCore::EditorClientEfl::canPaste): Added.
        * WebCoreSupport/EditorClientEfl.h:
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. These functions
        returns true iff the current frame should be able to copy/cut and paste respectively.
        They take the default value determined by isDOMPasteAllowed and javaScriptCanAccessClipboard.

        These callbacks allows embedders to decide whether or not copy/cut/paste should be enabled
        per frame and thus per origin rather than per page.

        No new tests are added since this is a WebKit/WebCore interface change.

        * editing/EditorCommand.cpp:
        (WebCore::supportedCopyCut): Calls canCopyCut.
        (WebCore::supportedPaste): Calls canPaste.
        * loader/EmptyClients.h:
        (WebCore::EmptyEditorClient::canCopyCut): Added.
        (WebCore::EmptyEditorClient::canPaste): Added.
        * page/EditorClient.h:
2011-02-07  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Adam Barth.

        Add EditorClient callbacks to override isDOMPasteAllowed and javaScriptCanAccessClipboard
        https://bugs.webkit.org/show_bug.cgi?id=52417

        Added two callback functions, canCopyCut and canPaste to EditorClient. They are currently
        not implemented.

        * WebProcess/WebCoreSupport/WebEditorClient.cpp:
        (WebKit::WebEditorClient::canCopyCut): Added.
        (WebKit::WebEditorClient::canPaste): Added.
        * WebProcess/WebCoreSupport/WebEditorClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78532 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 15 Feb 2011 05:53:48 +0000 (05:53 +0000)]
2011-02-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        allow for modifying comments without the mouse
        https://bugs.webkit.org/show_bug.cgi?id=54433

        Use n/p to navigate the comments.
        Enter to begin editing a comment.
        Escape to finish editing a comment.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78531 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Tue, 15 Feb 2011 05:46:44 +0000 (05:46 +0000)]
2011-02-14  Ojan Vafai  <ojan@chromium.org>

        Reviewed by Adam Barth.

        improve line selection in the code review tool
        https://bugs.webkit.org/show_bug.cgi?id=54430

        -shift+click now extends the comment context
        -selecting outside of a diff section no longer clears the selected lines.
         Instead it just restricts the selected lines to that diff section.

        * code-review.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78530 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 15 Feb 2011 02:23:24 +0000 (02:23 +0000)]
2011-02-14  Dirk Pranke  <dpranke@chromium.org>

        Unreviewed, build fix.

        Fix minor regression introduced in r78522. For some reason, Python
        provides a platform.mac_ver() routine on Linux, so we need to
        check to make sure it's returning something in addition to
        checking for its existence.

        * Scripts/webkitpy/layout_tests/port/mac.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78528 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 15 Feb 2011 01:49:11 +0000 (01:49 +0000)]
2011-02-14  Jeremy Orlow  <jorlow@chromium.org>

        efl build fix

        * CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78527 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Tue, 15 Feb 2011 01:38:44 +0000 (01:38 +0000)]
2011-02-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Add WKPageSetMemoryCacheClientCallsEnabled API
        https://bugs.webkit.org/show_bug.cgi?id=54422

        * UIProcess/API/C/WKPage.cpp:
        (WKPageSetMemoryCacheClientCallsEnabled):
        * UIProcess/API/C/WKPage.h:
        * UIProcess/WebPageProxy.cpp:
        (WebKit::WebPageProxy::setMemoryCacheClientCallsEnabled):
        * UIProcess/WebPageProxy.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::setMemoryCacheMessagesEnabled):
        * WebProcess/WebPage/WebPage.h:
        * WebProcess/WebPage/WebPage.messages.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78526 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-11 Jeremy Orlow <jorlow@chromium.org>
jorlow@chromium.org [Tue, 15 Feb 2011 01:18:57 +0000 (01:18 +0000)]
2011-02-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Finish up implementing the new event model in IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=54331

        Make the requried changes + s/result/request/g (where it should
        have always been that way) + remove the verify functions (since
        these days they mostly just add noise) + get rid of the callback
        in the delete object store funciton.

        * storage/indexeddb/basics-expected.txt:
        * storage/indexeddb/basics.html:
        * storage/indexeddb/create-and-remove-object-store-expected.txt:
        * storage/indexeddb/create-and-remove-object-store.html:
        * storage/indexeddb/create-object-store-options-expected.txt:
        * storage/indexeddb/create-object-store-options.html:
        * storage/indexeddb/cursor-delete-expected.txt:
        * storage/indexeddb/cursor-delete.html:
        * storage/indexeddb/cursor-index-delete-expected.txt:
        * storage/indexeddb/cursor-index-delete.html:
        * storage/indexeddb/cursor-skip-deleted-expected.txt:
        * storage/indexeddb/cursor-skip-deleted.html:
        * storage/indexeddb/cursor-update-expected.txt:
        * storage/indexeddb/cursor-update.html:
        * storage/indexeddb/data-corruption-expected.txt:
        * storage/indexeddb/data-corruption.html:
        * storage/indexeddb/database-basics-expected.txt:
        * storage/indexeddb/database-basics.html:
        * storage/indexeddb/database-quota-expected.txt:
        * storage/indexeddb/database-quota.html:
        * storage/indexeddb/duplicates-expected.txt:
        * storage/indexeddb/duplicates.html:
        * storage/indexeddb/error-causes-abort-by-default-expected.txt:
        * storage/indexeddb/error-causes-abort-by-default.html:
        * storage/indexeddb/index-basics-expected.txt:
        * storage/indexeddb/index-basics.html:
        * storage/indexeddb/index-cursor-expected.txt:
        * storage/indexeddb/index-cursor.html:
        * storage/indexeddb/objectstore-autoincrement-expected.txt:
        * storage/indexeddb/objectstore-autoincrement.html:
        * storage/indexeddb/objectstore-basics-expected.txt:
        * storage/indexeddb/objectstore-basics.html:
        * storage/indexeddb/objectstore-cursor-expected.txt:
        * storage/indexeddb/objectstore-cursor.html:
        * storage/indexeddb/objectstore-removeobjectstore-expected.txt:
        * storage/indexeddb/objectstore-removeobjectstore.html:
        * storage/indexeddb/open-cursor-expected.txt:
        * storage/indexeddb/open-cursor.html:
        * storage/indexeddb/queued-commands-expected.txt:
        * storage/indexeddb/queued-commands.html:
        * storage/indexeddb/request-event-propagation-expected.txt:
        * storage/indexeddb/request-event-propagation.html:
        * storage/indexeddb/resources/shared.js:
        (unexpectedSuccessCallback):
        (unexpectedErrorCallback):
        (unexpectedAbortCallback):
        (unexpectedCompleteCallback):
        (evalAndExpectException):
        (deleteAllObjectStores):
        * storage/indexeddb/transaction-after-close-expected.txt:
        * storage/indexeddb/transaction-after-close.html:
        * storage/indexeddb/transaction-and-objectstore-calls-expected.txt:
        * storage/indexeddb/transaction-and-objectstore-calls.html:
        * storage/indexeddb/transaction-basics-expected.txt:
        * storage/indexeddb/transaction-basics.html:
        * storage/indexeddb/transaction-crash-on-abort-expected.txt:
        * storage/indexeddb/transaction-crash-on-abort.html:
        * storage/indexeddb/transaction-event-propagation-expected.txt:
        * storage/indexeddb/transaction-event-propagation.html:
        * storage/indexeddb/transaction-read-only-expected.txt:
        * storage/indexeddb/transaction-read-only.html:
        * storage/indexeddb/tutorial.html:
2011-02-11  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Nate Chapin.

        Finish up implementing the new event model in IndexedDB
        https://bugs.webkit.org/show_bug.cgi?id=54331

        We shouldn't have our own event subclasses. Instead, we
        should just fire Event's with the proper type and bubble
        settings. All the attributes on the events before should
        just be on the request. IDBRequest should throw if they're
        accessed before the success event fires.

        * WebCore.gypi:
        * bindings/generic/RuntimeEnabledFeatures.h:
        * bindings/js/JSEventCustom.cpp:
        (WebCore::toJS):
        * bindings/v8/custom/V8EventCustom.cpp:
        (WebCore::toV8):
        * dom/Event.cpp:
        * dom/Event.h:
        * page/DOMWindow.idl:
        * storage/IDBAbortEvent.h: Removed.
        * storage/IDBCompleteEvent.cpp: Removed.
        * storage/IDBCompleteEvent.h: Removed.
        * storage/IDBDatabase.cpp:
        (WebCore::IDBDatabase::~IDBDatabase):
        * storage/IDBDatabaseException.h:
        * storage/IDBDatabaseException.idl:
        * storage/IDBErrorEvent.cpp: Removed.
        * storage/IDBErrorEvent.h: Removed.
        * storage/IDBErrorEvent.idl: Removed.
        * storage/IDBEvent.h: Removed.
        * storage/IDBEvent.idl: Removed.
        * storage/IDBEventDispatcher.cpp:
        (WebCore::IDBEventDispatcher::dispatch):
        * storage/IDBRequest.cpp:
        (WebCore::IDBRequest::IDBRequest):
        (WebCore::IDBRequest::result):
        (WebCore::IDBRequest::errorCode):
        (WebCore::IDBRequest::webkitErrorMessage):
        (WebCore::IDBRequest::source):
        (WebCore::IDBRequest::transaction):
        (WebCore::IDBRequest::readyState):
        (WebCore::IDBRequest::resetReadyState):
        (WebCore::IDBRequest::onError):
        (WebCore::createSuccessEvent):
        (WebCore::IDBRequest::onSuccess):
        (WebCore::IDBRequest::dispatchEvent):
        * storage/IDBRequest.h:
        * storage/IDBRequest.idl:
        * storage/IDBSuccessEvent.cpp: Removed.
        * storage/IDBSuccessEvent.h: Removed.
        * storage/IDBSuccessEvent.idl: Removed.
        * storage/IDBTransaction.cpp:
        (WebCore::IDBTransaction::onAbort):
        (WebCore::IDBTransaction::onComplete):
        (WebCore::IDBTransaction::dispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78525 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Add myself to the list of committers.
kalman@chromium.org [Tue, 15 Feb 2011 01:14:14 +0000 (01:14 +0000)]
Unreviewed.  Add myself to the list of committers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78524 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWebKit2: View not updated completely when coming back from a cached back/forward...
weinig@apple.com [Tue, 15 Feb 2011 00:03:16 +0000 (00:03 +0000)]
WebKit2: View not updated completely when coming back from a cached back/forward navigation
<rdar://problem/8787264>
https://bugs.webkit.org/show_bug.cgi?id=54419

Reviewed by Anders Carlsson.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::restoreViewState): Invalidate the entire page
when completing a restore from the back/forward cache.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78523 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Tue, 15 Feb 2011 00:03:06 +0000 (00:03 +0000)]
2011-02-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        Clean up the way we handle platform names in
        new-run-webkit-tests. Previously, if you specified
        '--platform mac' or '--platform chromium-mac' on the command
        line, it would use that platform name to determine baseline search
        paths, etc. This is almost never the right thing to do, because
        it ignores the existence of version-specific baselines.

        So, I changed this so that ports that support versions must
        always use a version, and the version should default to the
        version of the operating system that the port is being run on
        (e.g., if you're running on Leopard, then passing '--platform
        mac' will default to the 'mac-leopard' port). This means that
        port.name() should always include a version-specific suffix if
        the port supports versions.

        However, we still support things like '--platform mac' as input
        so that the user doesn't have to explicitly specify a version,
        both for convenience and so we don't have to make buildbot
        configs more complicated than they already are.

        Also, I cleaned up how the baselines were being searched
        on the chromium-mac port (this is one of the two bugs that
        prompted this refactoring), and made the logic easier to follow
        and more consistent across the mac and chromium ports

        Lastly, I added a port.get_all_names() method that could be used
        to get the names of all of the ports to search, rather than having
        to guess (incorrectly) from the list of directories under
        LayoutTests/platform (this last thing was necessary because the
        deduplicate_tests unittest broke as the fallback dirs changed).

        https://bugs.webkit.org/show_bug.cgi?id=54248

        * Scripts/webkitpy/layout_tests/deduplicate_tests.py:
        * Scripts/webkitpy/layout_tests/port/factory.py:
        * Scripts/webkitpy/layout_tests/port/factory_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_gpu_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac.py:
        * Scripts/webkitpy/layout_tests/port/chromium_mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_unittest.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win.py:
        * Scripts/webkitpy/layout_tests/port/chromium_win_unittest.py:
        * Scripts/webkitpy/layout_tests/port/mac.py:
        * Scripts/webkitpy/layout_tests/port/mac_unittest.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78522 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Chromium test expectations update.
pkasting@chromium.org [Tue, 15 Feb 2011 00:01:30 +0000 (00:01 +0000)]
Unreviewed, Chromium test expectations update.

https://bugs.webkit.org/show_bug.cgi?id=54418
Fix a Linux expectation, mark another test as expected-failing.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78521 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 14 Feb 2011 23:59:48 +0000 (23:59 +0000)]
2011-02-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Adam Barth.

        update-webkit hangs in a git-only checkout

        Previously it would hang forever trying to do a 'git svn
        rebase'. Now, it will default to a 'git pull' if the
        svn-remote.svn.fetch variable isn't set, and bail out if it
        doesn't know where to pull from.

        https://bugs.webkit.org/show_bug.cgi?id=54265

        * Scripts/update-webkit:
        * Scripts/VCSUtils.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78520 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 14 Feb 2011 23:51:25 +0000 (23:51 +0000)]
2011-02-14  Alejandro G. Castro  <alex@igalia.com>

        Reviewed by Xan Lopez.

        [GTK] testwebdatasource test fails in the bots
        https://bugs.webkit.org/show_bug.cgi?id=54414

        Changed the uri we check, added www to avoid the rewrite that we
        get when we as the uri to the request in case it finishes.

        * tests/testwebdatasource.c:
        (notify_load_status_cb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78519 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 14 Feb 2011 23:46:11 +0000 (23:46 +0000)]
2011-02-14  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, rolling out r78516.
        http://trac.webkit.org/changeset/78516

        The rebaseline was previously done

        * platform/gtk/fast/css/rtl-ordering-expected.checksum:
        * platform/gtk/fast/css/rtl-ordering-expected.png:
        * platform/gtk/fast/css/rtl-ordering-expected.txt:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.png:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78518 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCopy/paste from a WebKit window to a TextEdit window loses fonts.
enrica@apple.com [Mon, 14 Feb 2011 23:35:34 +0000 (23:35 +0000)]
Copy/paste from a WebKit window to a TextEdit window loses fonts.
<rdar://problem/8623090>
https://bugs.webkit.org/show_bug.cgi?id=54416

Reviewed by Dan Bernstein.

We don't have the complete solution that fixes this problem for WebKit2 yet.
This patch fixes the regression in WebKit.

* platform/mac/PasteboardMac.mm:
(WebCore::Pasteboard::writeSelection): For WebKit2 use only plain text,
for WebKit use the original API to create the NSAttributedString.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78517 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 14 Feb 2011 23:29:35 +0000 (23:29 +0000)]
2011-02-14  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed. Rebaseline GTK test results after r78491.

        * platform/gtk/fast/css/rtl-ordering-expected.checksum:
        * platform/gtk/fast/css/rtl-ordering-expected.png:
        * platform/gtk/fast/css/rtl-ordering-expected.txt:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.checksum:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.png:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.checksum:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.png:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78516 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Levi Weintraub <leviw@chromium.org>
leviw@chromium.org [Mon, 14 Feb 2011 23:15:16 +0000 (23:15 +0000)]
2011-02-14  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Strikethrough disappears when posting a message on odnoklassniki.ru
        https://bugs.webkit.org/show_bug.cgi?id=53475

        Changing the behavior of the strikethrough execCommand when styleWithCSS
        is false. We formerly created <s> tags, which was different than both IE
        and FF and caused problems with some rich text editors that would strip
        out unexpected tags such as <s>.

        Test: editing/execCommand/strikethrough-uses-strike-tag.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::addInlineStyleIfNeeded):
2011-02-14  Levi Weintraub  <leviw@chromium.org>

        Reviewed by Alexey Proskuryakov.

        Strikethrough disappears when posting a message on odnoklassniki.ru
        https://bugs.webkit.org/show_bug.cgi?id=53475

        Updating test expectations and creating a test in an attempt to prevent the
        uninformed WebKit dev from switching back to using <s> tags for strikethrough.
        As explained in the bug, this is bad for compatibility with various rich text
        editors.

        * editing/execCommand/query-text-decoration-with-typing-style-expected.txt:
        * editing/execCommand/script-tests/strikethrough-uses-strike-tag.js: Added.
        (test):
        * editing/execCommand/script-tests/toggle-style-2.js:
        * editing/execCommand/strikethrough-uses-strike-tag-expected.txt: Added.
        * editing/execCommand/strikethrough-uses-strike-tag.html: Added.
        * editing/execCommand/strikethroughSelection-expected.txt:
        * editing/execCommand/toggle-style-2-expected.txt:
        * editing/style/inline-style-container-expected.txt:
        * editing/style/inline-style-extend-run-expected.txt:
        * editing/style/push-down-implicit-styles-around-list-expected.txt:
        * editing/style/push-down-implicit-styles-expected.txt:
        * editing/style/script-tests/inline-style-container.js:
        * editing/style/script-tests/inline-style-extend-run.js:
        * editing/style/script-tests/push-down-implicit-styles-around-list.js:
        * editing/style/script-tests/push-down-implicit-styles.js:
        * editing/style/style-text-node-without-editable-parent-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78515 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoBuild fix. Unreviewed.
enrica@apple.com [Mon, 14 Feb 2011 23:02:48 +0000 (23:02 +0000)]
Build fix. Unreviewed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78514 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Mon, 14 Feb 2011 23:01:29 +0000 (23:01 +0000)]
2011-02-14  Anders Carlsson  <andersca@apple.com>

        Reviewed by Dan Bernstein.

        Shared memory should be made shared immediately
        https://bugs.webkit.org/show_bug.cgi?id=54413
        <rdar://problem/8972153>

        Under some circumstances, mach_make_memory_entry_64 may only return parts of a
        memory allocation. Work around this by creating a mach port representing the shared memory
        right away. Also, hand out this mach port in createHandle when using the default memory protection.

        * Platform/SharedMemory.h:
        * Platform/mac/SharedMemoryMac.cpp:
        (WebKit::SharedMemory::create):
        (WebKit::SharedMemory::~SharedMemory):
        (WebKit::SharedMemory::createHandle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78513 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 14 Feb 2011 22:58:21 +0000 (22:58 +0000)]
2011-02-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        This patch modifies NRWT's Worker clas to use the new
        WorkerMixin class to actually run tests. With this patch, the
        multiprocess version of NRWT is fully functional and just needs
        the values for --worker-model and --child-processes to be corrected
        in the port/* classes to start using the new code by default.

        https://bugs.webkit.org/show_bug.cgi?id=54082

        * Scripts/webkitpy/layout_tests/layout_package/worker.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78512 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 14 Feb 2011 22:56:45 +0000 (22:56 +0000)]
2011-02-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Mihai Parparita.

        This patch shuffles code out of dump_render_tree_thread and
        single_test_runner and into a new worker_mixin class that will
        be shared by both TestShellThread and Worker. This change
        restores single_test_runner to its state as of r77606 - it is
        stateless again. It also prunes TestShellThread to pretty much
        just the logic used for the original shared-memory access.

        https://bugs.webkit.org/show_bug.cgi?id=54079

        * Scripts/webkitpy/layout_tests/layout_package/dump_render_tree_thread.py:
        * Scripts/webkitpy/layout_tests/layout_package/single_test_runner.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker_mixin.py: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78511 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Chromium test expectations update.
pkasting@chromium.org [Mon, 14 Feb 2011 22:56:09 +0000 (22:56 +0000)]
Unreviewed, Chromium test expectations update.

Try using the right syntax this time.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78510 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Chromium test expectations update.
pkasting@chromium.org [Mon, 14 Feb 2011 22:26:01 +0000 (22:26 +0000)]
Unreviewed, Chromium test expectations update.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78509 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove dead code in FormDataStreamCFNet.cpp
psolanki@apple.com [Mon, 14 Feb 2011 22:20:47 +0000 (22:20 +0000)]
Remove dead code in FormDataStreamCFNet.cpp
https://bugs.webkit.org/show_bug.cgi?id=54401

Reviewed by Darin Adler.

The static functions in this file are no longer reachable. We added a conditional branch to
use new CFNetwork functions in r30329 and later made that code path permanent in r41517
which made these functions unreachable.

* platform/network/cf/FormDataStreamCFNet.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78508 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 14 Feb 2011 22:15:49 +0000 (22:15 +0000)]
2011-02-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Ojan Vafai.

        This patch updates NRWT to add per-worker and per-shard test stats
        into TestRunner2, bringing it to parity with TestRunner.

        https://bugs.webkit.org/show_bug.cgi?id=54074

        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78507 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 14 Feb 2011 22:13:15 +0000 (22:13 +0000)]
2011-02-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        nrwt multiprocessing: add code to handle interrupts and wedged
        threads.
        https://bugs.webkit.org/show_bug.cgi?id=54072

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker.py:
        Adds the cancel(), is_alive(), join(), and log_wedged_worker()
        methods to the WorkerConnection class

        * Scripts/webkitpy/layout_tests/layout_package/manager_worker_broker_unittest.py:
        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:
        * Scripts/webkitpy/layout_tests/layout_package/worker.py:
        Adds the cancel() method to the Worker class

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78506 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Chromium test expectations update.
pkasting@chromium.org [Mon, 14 Feb 2011 21:55:34 +0000 (21:55 +0000)]
Unreviewed, Chromium test expectations update.

https://bugs.webkit.org/show_bug.cgi?id=54409
Mark tests as failing due to r78484.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78504 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 14 Feb 2011 21:54:01 +0000 (21:54 +0000)]
2011-02-14  Andreas Kling  <kling@webkit.org>

        Reviewed by Darin Adler.

        GraphicsContext: Add clip(IntRect) overload for Qt
        https://bugs.webkit.org/show_bug.cgi?id=54365

        Qt has special code paths for clipping to integer rectangles.
        Add a GraphicsContext::clip() overload to allow us to take
        advantage of the optimized code.

        * platform/graphics/GraphicsContext.cpp:
        (WebCore::GraphicsContext::clip):
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        (WebCore::GraphicsContext::clip):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78503 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Dirk Pranke <dpranke@chromium.org>
dpranke@chromium.org [Mon, 14 Feb 2011 21:48:25 +0000 (21:48 +0000)]
2011-02-14  Dirk Pranke  <dpranke@chromium.org>

        Reviewed by Tony Chang.

        update the NRWT multiprocessing code to spawn multiple workers
        instead of just using one.

        https://bugs.webkit.org/show_bug.cgi?id=54071

        * Scripts/webkitpy/layout_tests/layout_package/test_runner2.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78502 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSome MarkedBlock refactoring.
ggaren@apple.com [Mon, 14 Feb 2011 21:29:17 +0000 (21:29 +0000)]
Some MarkedBlock refactoring.

Rubber-stamped by Gavin Barraclough.

Made cells private.

Renamed cells => m_cells
        marked => m_marks.

* runtime/JSCell.h:
(JSC::JSCell::MarkedBlock::allocate):
* runtime/MarkedBlock.cpp:
(JSC::MarkedBlock::destroy):
(JSC::MarkedBlock::MarkedBlock):
(JSC::MarkedBlock::sweep):
* runtime/MarkedBlock.h:
(JSC::MarkedBlock::isEmpty):
(JSC::MarkedBlock::clearMarks):
(JSC::MarkedBlock::markCount):
(JSC::MarkedBlock::isMarked):
(JSC::MarkedBlock::testAndSetMarked):
(JSC::MarkedBlock::setMarked):
(JSC::MarkedBlock::forEach):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78501 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Mon, 14 Feb 2011 21:27:59 +0000 (21:27 +0000)]
2011-02-14  Xiaomei Ji  <xji@chromium.org>

        Unreviewed.
        Rebaseline after r78491. Since select-visual-hebrew.html and visual-hebrew-text-field.html
        are marked as FAIL in Chromium WIN and LINUX, rebaseline for them are done manually and
        only changed the part related to r78491.

        * platform/chromium-linux/fast/css/rtl-ordering-expected.txt:
        * platform/chromium-linux/fast/forms/select-visual-hebrew-expected.txt:
        * platform/chromium-linux/fast/forms/visual-hebrew-text-field-expected.txt:
        * platform/chromium-win/fast/css/rtl-ordering-expected.txt:
        * platform/chromium-win/fast/forms/select-visual-hebrew-expected.txt:
        * platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.txt:
        * platform/gtk/fast/css/rtl-ordering-expected.txt:
        * platform/gtk/fast/forms/select-visual-hebrew-expected.txt:
        * platform/gtk/fast/forms/visual-hebrew-text-field-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78500 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 14 Feb 2011 21:23:45 +0000 (21:23 +0000)]
2011-02-14  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Add built-in decoder for UTF-8 for improved performance
        https://bugs.webkit.org/show_bug.cgi?id=53898

        Covered by existing tests; not adding new tests at this time.

        This patch now handles errors in the same way the existing codecs do,
        and so passes our tests. The first version failed some tests because
        of incorrect error handling. The second version was missing one line
        of code that made it decode incomplete sequences at the end of the
        buffer twice.

        * platform/text/TextCodecICU.cpp:
        (WebCore::create): Renamed from newTextCodecICU, made a static member
        function, and added a call to adoptPtr.
        (WebCore::TextCodecICU::registerEncodingNames): Renamed from
        registerExtendedEncodingNames since this class is no longer used for
        base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8.
        (WebCore::TextCodecICU::registerCodecs): Renamed.
        (WebCore::fallbackForGBK): Renamed to conform to our current style.

        * platform/text/TextCodecICU.h: Updated for above changes. Changed
        indentation. Made most functions private, including virtual function
        overrides. Marked ICUConverterWrapper noncopyable.

        * platform/text/TextCodecUTF8.cpp:
        (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases
        that were formerly added by TextCodecICU.
        (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for
        bytes F5-FF instead of failing.
        (WebCore::decodeNonASCIISequence): Tweaked coding style.
        (WebCore::appendCharacter): Added. Makes it easier to share code between
        the partial-character handling and main loop.
        (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case
        where there is a partial sequence. Fixed partial sequence handling so that
        goto is no longer needed, since compilers sometimes make poor code when
        goto is involved. Added a loop for partial sequences since we consume only
        one byte when a partial sequence is invalid. Fixed logic in main decoding
        loop so goto is not needed. Used early-exit style in both loops so the main
        flow is not nested inside if statements. Added correct error handling for
        flush when a partial sequence remains, which involved wrapping the function
        in yet another loop.

        * platform/text/TextCodecUTF8.h: Made virtual function overrides private.

        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed
        calls to TextCodecICU. Added FIXMEs for other codecs that no longer need
        to be included here.
        (WebCore::extendTextCodecMaps): Updated for the name change of the
        TextCodecICU functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78499 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNeed WebKit API to determine whether we have a site icon for a given URL
bweinstein@apple.com [Mon, 14 Feb 2011 21:13:56 +0000 (21:13 +0000)]
Need WebKit API to determine whether we have a site icon for a given URL
https://bugs.webkit.org/show_bug.cgi?id=54400

Reviewed by Brady Eidson.

This patch implements IWebIconDatabase::hasIconForURL which tells us whether or not
we have a site icon for the given URL.

* Interfaces/IWebIconDatabase.idl: Added new function.
* Interfaces/WebKit.idl: Touched to make sure Interfaces rebuilds.
* WebIconDatabase.cpp:
(WebIconDatabase::hasIconForURL): Call IconDatabase::iconForPageURL to make sure we
    load the icon from disk, and call iconURLForPageURL to determine whether or not
    we actually have an icon.
* WebIconDatabase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78498 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Mon, 14 Feb 2011 20:48:12 +0000 (20:48 +0000)]
2011-02-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add basic parser for Content Security Policy
        https://bugs.webkit.org/show_bug.cgi?id=54379

        Add a constructor for copying a Vector into a String.  I suspect there
        are a number of call sites that are doing this manually that would
        benefit from being moved to this API.

        * wtf/text/WTFString.h:
        (WTF::String::String):
2011-02-14  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        Add basic parser for Content Security Policy
        https://bugs.webkit.org/show_bug.cgi?id=54379

        The parser in this patch is very basic.  It just segments the CSP
        header into directives.  The exactly syntax will likely change a bit as
        we discuss the details in public-web-security, but this parser will
        allow us to make progress.

        Sadly, this patch does not contain any tests.  That's because CSP
        policies do not have any observable effects yet.  Hopefully we'll get
        enough sketched out in the next couple patches to begin writing tests.

        * page/ContentSecurityPolicy.cpp:
        (WebCore::CSPDirective::CSPDirective):
        (WebCore::CSPDirective::name):
        (WebCore::CSPDirective::value):
        (WebCore::ContentSecurityPolicy::~ContentSecurityPolicy):
        (WebCore::ContentSecurityPolicy::didReceiveHeader):
        (WebCore::ContentSecurityPolicy::parse):
        * page/ContentSecurityPolicy.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78497 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 14 Feb 2011 20:03:54 +0000 (20:03 +0000)]
2011-02-14  Tony Chang  <tony@chromium.org>

        Unreviewed, updating chromium test expectations, missed a test
        in my last checkin.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78496 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Andrew Wason <rectalogic@rectalogic.com>
commit-queue@webkit.org [Mon, 14 Feb 2011 19:48:14 +0000 (19:48 +0000)]
2011-02-14  Andrew Wason  <rectalogic@rectalogic.com>

        Reviewed by Kenneth Russell.

        [Qt] WebKit fails to compile for Qt when WebGL enabled
        https://bugs.webkit.org/show_bug.cgi?id=53431

        No new tests.

        * WebCore.pro:
          Add source and header files and include directory to Qt project.
        * html/canvas/WebGLRenderingContext.cpp:
          File uses 'emit' which is a Qt keyword - #undef emit.
        * platform/graphics/gpu/qt: Added.
        * platform/graphics/gpu/qt/DrawingBufferQt.cpp: Added.
          Partial implementation of DrawingBuffer for Qt.
        (WebCore::DrawingBuffer::DrawingBuffer):
        (WebCore::DrawingBuffer::~DrawingBuffer):
        (WebCore::DrawingBuffer::didReset):
        (WebCore::DrawingBuffer::platformLayer):
        (WebCore::DrawingBuffer::platformColorBuffer):
        * platform/graphics/qt/Extensions3DQt.cpp:
          Noop implementation for pure virtual methods added to Extensions3D.h
        (WebCore::Extensions3DQt::blitFramebuffer):
        (WebCore::Extensions3DQt::renderbufferStorageMultisample):
        * platform/graphics/qt/Extensions3DQt.h:
          Declare new methods added to Extensions3D.h
        * platform/graphics/qt/GraphicsContext3DQt.cpp:
          Remove method implementations no longer in GraphicsContext3D.h.
          Change m_syntheticErrors to use unsigned int to match new
          GC3Denum type.
        (WebCore::GraphicsContext3D::create):
         Change return type to match GraphicsContext3D.h
        (WebCore::GraphicsContext3D::lineWidth):
         Change argument type to GC3Dfloat to match GraphicsContext3D.h
        (WebCore::GraphicsContext3D::getUniformLocation):
         Change return type to GC3Dfloat to match GraphicsContext3D.h
        (WebCore::GraphicsContext3D::getExtensions):
         Need to call get() on OwnPtr.
        (WebCore::GraphicsContext3D::getImageData):
         Rename enum values to match declarations in GraphicsContext3D.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78495 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Jay Soffian <jaysoffian@gmail.com>
commit-queue@webkit.org [Mon, 14 Feb 2011 19:45:46 +0000 (19:45 +0000)]
2011-02-14  Jay Soffian  <jaysoffian@gmail.com>

        Reviewed by Darin Fisher.

        Expose checked field of HTMLInputElement to Chromium API
        https://bugs.webkit.org/show_bug.cgi?id=54333

        * public/WebInputElement.h:
        * src/WebInputElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78494 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Tony Chang <tony@chromium.org>
tony@chromium.org [Mon, 14 Feb 2011 19:40:11 +0000 (19:40 +0000)]
2011-02-14  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        <select> elements don't honor border:0px in chromium-linux
        https://bugs.webkit.org/show_bug.cgi?id=51152

        No new tests, covered by existing pixel results (fast/forms/basic-selects.html
        convers lots of cases).

        * css/themeChromiumLinux.css:
        (select):
        * platform/chromium/PlatformBridge.h:
        * rendering/RenderThemeChromiumLinux.cpp:
        (WebCore::RenderThemeChromiumLinux::paintButton):
        (WebCore::RenderThemeChromiumLinux::paintMenuList):
          match border logic in RenderThemeChromiumWin.cpp:
          http://trac.webkit.org/browser/trunk/Source/WebCore/rendering/RenderThemeChromiumWin.cpp#L463
2011-02-14  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        <select> elements don't honor border:0px in chromium-linux
        https://bugs.webkit.org/show_bug.cgi?id=51152

        * public/linux/WebThemeEngine.h:
        * src/PlatformBridge.cpp:
        (WebCore::GetWebThemeExtraParams):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78493 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, Chromium test expectations update.
pkasting@chromium.org [Mon, 14 Feb 2011 19:25:19 +0000 (19:25 +0000)]
Unreviewed, Chromium test expectations update.

http://code.google.com/p/v8/issues/detail?id=1154
Temporarily mark a test as failing due to a new V8 version.

* platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78492 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Mon, 14 Feb 2011 19:21:12 +0000 (19:21 +0000)]
2011-02-14  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix rendering of ISO-8859-8 when dir="rtl".
        https://bugs.webkit.org/show_bug.cgi?id=52128

        Test: fast/text/international/iso-8859-8.html

        * platform/text/BidiResolver.h: Add VisualDirectionOverride enum.
        (WebCore::::createBidiRunsForLine): For lines with visual direction override,
        create bidi runs without resolving bidi levels (one run per render object),
        set bidi level as 0 or 1 depending on LTR or RTL override,
        and reverse runs for RTL override.
        * rendering/RenderBlockLineLayout.cpp:
        (WebCore::RenderBlock::constructLine): Set inline box bidi level the same as
        BidiRun's bidi level without special handling of VisualDirectionOverride.
        (WebCore::RenderBlock::layoutInlineChildren): Pass in VisualDirectionOverride
        to createBidiRunsForLine().
2011-02-14  Xiaomei Ji  <xji@chromium.org>

        Reviewed by Dan Bernstein.

        Fix rendering of ISO-8859-8 when dir="rtl".
        https://bugs.webkit.org/show_bug.cgi?id=52128

        * fast/text/international/iso-8859-8-expected.txt: Added.
        * fast/text/international/iso-8859-8.html: Added.
        * platform/mac/fast/css/rtl-ordering-expected.txt:
        * platform/mac/fast/forms/select-visual-hebrew-expected.txt:
        * platform/mac/fast/forms/visual-hebrew-text-field-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78491 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Alexis Menard <alexis.menard@nokia.com>
commit-queue@webkit.org [Mon, 14 Feb 2011 18:52:09 +0000 (18:52 +0000)]
2011-02-14  Alexis Menard  <alexis.menard@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Crash on application exit after constructing and destroying a QWebView twice
        https://bugs.webkit.org/show_bug.cgi?id=54000

        Check the value is valid before use it.

        * platform/qt/SharedTimerQt.cpp:
        (WebCore::SharedTimerQt::~SharedTimerQt):
2011-02-14  Alexis Menard  <alexis.menard@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] Crash on application exit after constructing and destroying a QWebView twice
        https://bugs.webkit.org/show_bug.cgi?id=54000

        Test case to cover the crash.

        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::deleteQWebViewTwice):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78490 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReact to accelerated compositing changes and allocation failures in DrawingAreaImpl...
aroben@apple.com [Mon, 14 Feb 2011 18:25:38 +0000 (18:25 +0000)]
React to accelerated compositing changes and allocation failures in DrawingAreaImpl::display

Fixes <http://webkit.org/b/54398> DrawingAreaImpl::display handles error cases poorly.

Reviewed by Darin Adler and Anders Carlsson.

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::display): Bail out if the layout we perform puts us into
accelerated compositing mode. Moved the layout earlier in this function so we can bail
before doing other work that would be unnecessary in this case. Moved the allocation of the
ShareableBitmap earlier so we will leave our state (e.g., dirty region) intact even if the
allocation fails.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78489 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a way to flash backing store and view updates
aroben@apple.com [Mon, 14 Feb 2011 18:24:21 +0000 (18:24 +0000)]
Add a way to flash backing store and view updates

The new WKPageSetDebugPaintFlags SPI can be used to control whether backing store and/or
view updates are flashed. A blueish color is used for view updates, and a purpleish color is
used for backing store updates. The flashing currently only works on Windows.

Fixes <http://webkit.org/b/54303>.

Reviewed by Anders Carlsson.

* UIProcess/API/C/WKPage.cpp:
(WKPageSetDebugPaintFlags):
(WKPageGetDebugPaintFlags):
* UIProcess/API/C/WKPagePrivate.h:
Added. These call through to WebPageProxy.

* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::flashBackingStoreUpdates):
* UIProcess/API/qt/qwkpage.cpp:
(QWKPagePrivate::flashBackingStoreUpdates):
* UIProcess/API/qt/qwkpage_p.h:
Stubbed out new PageClient functions.

* UIProcess/DrawingAreaProxyImpl.cpp:
(WebKit::DrawingAreaProxyImpl::incorporateUpdate): Tell the WebPageProxy to flash the
backing store updates we're performing.

* UIProcess/PageClient.h: Added flashBackingStoreUpdates.

* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::flashBackingStoreUpdates): Call through to the PageClient.
(WebKit::WebPageProxy::viewUpdatesFlashColor): Return the blueish color used for view
updates.
(WebKit::WebPageProxy::backingStoreUpdatesFlashColor): Return the purpleish color used for
backing store updates.

* UIProcess/WebPageProxy.h:
(WebKit::WebPageProxy::setDebugPaintFlags):
(WebKit::WebPageProxy::debugPaintFlags):
Added these simple accessors.

* UIProcess/win/WebView.cpp:
(WebKit::flashRects):
(WebKit::createBrush):
New helper functions.

(WebKit::WebView::onPaintEvent): Flash the dirty region if requested.
(WebKit::WebView::flashBackingStoreUpdates): Added. Calls through to flashRects.

* UIProcess/win/WebView.h: Added flashBackingStoreUpdates.

* win/WebKit2Generated.make: Export WKPagePrivate.h so clients can use it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78488 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Feb 2011 18:13:06 +0000 (18:13 +0000)]
2011-02-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: unflake inspector/styles-iframe.html

        * inspector/resources/styles-iframe-data.html:
        * inspector/styles-iframe-expected.txt:
        * inspector/styles-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78487 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Mon, 14 Feb 2011 17:54:21 +0000 (17:54 +0000)]
2011-02-14  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: 304 Not Modified responses have a yellow icon in Web Inspector Resources panel
        https://bugs.webkit.org/show_bug.cgi?id=33220

        * inspector/front-end/ResourceHeadersView.js:
        (WebInspector.ResourceHeadersView.prototype._refreshHTTPInformation):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78486 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Adrienne Walker <enne@google.com>
enne@google.com [Mon, 14 Feb 2011 17:29:48 +0000 (17:29 +0000)]
2011-02-14  Adrienne Walker  <enne@google.com>

        Reviewed by James Robinson.

        [chromium] Modify LayerTilerChromium to use TilingData.
        https://bugs.webkit.org/show_bug.cgi?id=54143

        Most of the previous data in LayerTilerChromium is now calculated
        from TilingData.  TilingData was modified to allow for a dynamic
        tile size and page size.  LayerTilerChromium also gets its own
        shader with a texture transform to handle drawing from a texture
        that is larger than a tile.

        * platform/graphics/chromium/LayerChromium.h:
        * platform/graphics/chromium/LayerRendererChromium.cpp:
        (WebCore::LayerRendererChromium::LayerRendererChromium):
        (WebCore::LayerRendererChromium::updateAndDrawRootLayer):
        (WebCore::LayerRendererChromium::initializeSharedObjects):
        (WebCore::LayerRendererChromium::cleanupSharedObjects):
        * platform/graphics/chromium/LayerRendererChromium.h:
        (WebCore::LayerRendererChromium::tilerSharedValues):
        * platform/graphics/chromium/LayerTilerChromium.cpp:
        (WebCore::LayerTilerChromium::create):
        (WebCore::LayerTilerChromium::LayerTilerChromium):
        (WebCore::LayerTilerChromium::setTileSize):
        (WebCore::LayerTilerChromium::reset):
        (WebCore::LayerTilerChromium::contentRectToTileIndices):
        (WebCore::LayerTilerChromium::tileIndex):
        (WebCore::LayerTilerChromium::tileContentRect):
        (WebCore::LayerTilerChromium::tileLayerRect):
        (WebCore::LayerTilerChromium::layerSize):
        (WebCore::LayerTilerChromium::layerTileSize):
        (WebCore::LayerTilerChromium::invalidateEntireLayer):
        (WebCore::LayerTilerChromium::draw):
        (WebCore::LayerTilerChromium::resizeLayer):
        (WebCore::LayerTilerChromium::growLayerToContain):
        (WebCore::LayerTilerChromium::drawTexturedQuad):
        (WebCore::LayerTilerChromium::SharedValues::SharedValues):
        (WebCore::LayerTilerChromium::SharedValues::~SharedValues):
        * platform/graphics/chromium/LayerTilerChromium.h:
        (WebCore::LayerTilerChromium::SharedValues::tilerShaderProgram):
        (WebCore::LayerTilerChromium::SharedValues::shaderSamplerLocation):
        (WebCore::LayerTilerChromium::SharedValues::shaderMatrixLocation):
        (WebCore::LayerTilerChromium::SharedValues::shaderAlphaLocation):
        (WebCore::LayerTilerChromium::SharedValues::shaderTexTransformLocation):
        (WebCore::LayerTilerChromium::SharedValues::initialized):
        * platform/graphics/gpu/TilingData.cpp:
        (WebCore::computeNumTiles):
        (WebCore::TilingData::TilingData):
        (WebCore::TilingData::setTotalSize):
        (WebCore::TilingData::setMaxTextureSize):
        (WebCore::TilingData::tileSizeX):
        (WebCore::TilingData::tileSizeY):
        (WebCore::TilingData::textureOffset):
        (WebCore::TilingData::recomputeNumTiles):
        * platform/graphics/gpu/TilingData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78484 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Andrey Adaikin <aandrey@google.com>
podivilov@chromium.org [Mon, 14 Feb 2011 17:17:14 +0000 (17:17 +0000)]
2011-02-14  Andrey Adaikin  <aandrey@google.com>

        Reviewed by Pavel Feldman.

        Web Inspector: [Text editor] First implementation of the editable TextViewer without optimization
        https://bugs.webkit.org/show_bug.cgi?id=54388

        * inspector/front-end/TextViewer.js:
        (WebInspector.TextViewer.prototype.set readOnly):
        (WebInspector.TextEditorChunkedPanel):
        (WebInspector.TextEditorChunkedPanel.prototype._buildChunks):
        (WebInspector.TextEditorChunkedPanel.prototype.makeLineAChunk):
        (WebInspector.TextEditorChunkedPanel.prototype.beginDomUpdates):
        (WebInspector.TextEditorChunkedPanel.prototype.endDomUpdates):
        (WebInspector.TextEditorChunkedPanel.prototype._repaintAll):
        (WebInspector.TextEditorGutterChunk.prototype.set expanded):
        (WebInspector.TextEditorMainPanel):
        (WebInspector.TextEditorMainPanel.prototype.set readOnly):
        (WebInspector.TextEditorMainPanel.prototype._buildChunks):
        (WebInspector.TextEditorMainPanel.prototype._highlightDataReady):
        (WebInspector.TextEditorMainPanel.prototype._paintLine):
        (WebInspector.TextEditorMainPanel.prototype.textChanged):
        (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates.return):
        (WebInspector.TextEditorMainPanel.prototype._handleDOMUpdates):
        (WebInspector.TextEditorMainPanel.prototype._handleDOMSubtreeModified):
        (WebInspector.TextEditorMainPanel.prototype._applyDomUpdates):
        (WebInspector.TextEditorMainPanel.prototype._collectLinesFromDiv):
        (WebInspector.TextEditorMainChunk.prototype.addDecoration):
        (WebInspector.TextEditorMainChunk.prototype.removeDecoration):
        (WebInspector.TextEditorMainChunk.prototype.set expanded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78483 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 14 Feb 2011 16:40:10 +0000 (16:40 +0000)]
2011-02-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: use call frame column to determine execution line in source frame.
        https://bugs.webkit.org/show_bug.cgi?id=54001

        * http/tests/inspector/debugger-test.js:
        (initialize_DebuggerTest.InspectorTest.captureStackTrace):
2011-02-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: use call frame column to determine execution line in source frame.
        https://bugs.webkit.org/show_bug.cgi?id=54001

        * wtf/text/TextPosition.h:
        (WTF::ZeroBasedNumber::convertAsOneBasedInt):
2011-02-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: use call frame column to determine execution line in source frame.
        https://bugs.webkit.org/show_bug.cgi?id=54001

        - Make call frame line and column zero based
        - Set execution line in source frame based on call frame line:column
        - Determine currently hit breakpoint based on call frame line:column

        * bindings/js/JavaScriptCallFrame.cpp:
        (WebCore::JavaScriptCallFrame::JavaScriptCallFrame):
        * bindings/js/JavaScriptCallFrame.h:
        (WebCore::JavaScriptCallFrame::create):
        (WebCore::JavaScriptCallFrame::line):
        (WebCore::JavaScriptCallFrame::column):
        (WebCore::JavaScriptCallFrame::update):
        * bindings/js/ScriptDebugServer.cpp:
        (WebCore::ScriptDebugServer::createCallFrameAndPauseIfNeeded):
        (WebCore::ScriptDebugServer::updateCallFrameAndPauseIfNeeded):
        * bindings/v8/DebuggerScript.js:
        ():
        * inspector/front-end/BreakpointsSidebarPane.js:
        (WebInspector.JavaScriptBreakpointsSidebarPane.prototype._debuggerPaused):
        * inspector/front-end/CallStackSidebarPane.js:
        (WebInspector.CallStackSidebarPane.prototype.update):
        * inspector/front-end/DebuggerModel.js:
        (WebInspector.DebuggerModel.prototype.continueToLocation):
        (WebInspector.DebuggerModel.prototype._pausedScript):
        (WebInspector.DebuggerModel.prototype._breakpointForCallFrame):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._debuggerPaused):
        (WebInspector.ScriptsPanel.prototype._clearCurrentExecutionLine):
        (WebInspector.ScriptsPanel.prototype._callFrameSelected):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._setTextViewerDecorations):
        (WebInspector.SourceFrame.prototype.setExecutionLocation):
        (WebInspector.SourceFrame.prototype.clearExecutionLocation):
        (WebInspector.SourceFrame.prototype._setExecutionLocation):
        (WebInspector.SourceFrame.prototype._breakpointAdded):
        (WebInspector.SourceFrame.prototype._continueToLine):
        (WebInspector.SourceFrame.prototype._originalLocationToTextViewerLineNumber):
2011-02-14  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: use call frame column to determine execution line in source frame.
        https://bugs.webkit.org/show_bug.cgi?id=54001

        * src/js/Tests.js:
        (.TestSuite.prototype._checkExecutionLine):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78482 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Feb 2011 16:34:11 +0000 (16:34 +0000)]
2011-02-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium expectations update.

        * platform/chromium/inspector/timeline-network-resource-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78481 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression: Back, Forward, Reload hidden in context menu
christian@webkit.org [Mon, 14 Feb 2011 16:31:49 +0000 (16:31 +0000)]
Regression: Back, Forward, Reload hidden in context menu
https://bugs.webkit.org/show_bug.cgi?id=54393

Reviewed by Gustavo Noronha Silva.

* page/ContextMenuController.cpp: Always show Back, Forward,
    Reload and Stop context menu items for the GTK+ port.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78480 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd some .messages.in and script files to WebKit2 projects
aroben@apple.com [Mon, 14 Feb 2011 16:12:55 +0000 (16:12 +0000)]
Add some .messages.in and script files to WebKit2 projects

This is just for convenience. It doesn't affect the build.

* win/WebKit2.vcproj: Also let VS resort some files.
* win/WebKit2Generated.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78479 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Johnny Ding <jnd@chromium.org>
jnd@chromium.org [Mon, 14 Feb 2011 16:04:37 +0000 (16:04 +0000)]
2011-02-14  Johnny Ding  <jnd@chromium.org>

        Reviewed by Andreas Kling.

        Move the finiteness check into common code.

        Test covered by canvas/philip/tests/2d.path.isPointInPath.nonfinite.html

        * html/canvas/CanvasRenderingContext2D.cpp:
        (WebCore::CanvasRenderingContext2D::isPointInPath):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78478 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Feb 2011 15:43:42 +0000 (15:43 +0000)]
2011-02-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: move timeline and highlighter tests to the new harness.
        https://bugs.webkit.org/show_bug.cgi?id=54390

        * inspector/cookie-resource-match.html:
        * inspector/elements-panel-search.html:
        * inspector/evaluate-in-frontend-expected.txt: Removed.
        * inspector/evaluate-in-frontend.html: Removed.
        * inspector/inspected-objects-not-overriden.html:
        * inspector/resources/timeline-iframe-data.html:
        * inspector/syntax-highlight-css.html:
        * inspector/syntax-highlight-html.html:
        * inspector/syntax-highlight-javascript-expected.txt:
        * inspector/syntax-highlight-javascript.html:
        * inspector/syntax-highlight.js:
        (initialize_SyntaxHighlight.InspectorTest.dumpSyntaxHighlight):
        (initialize_SyntaxHighlight):
        * inspector/timeline-enum-stability-expected.txt:
        * inspector/timeline-enum-stability.html:
        * inspector/timeline-event-dispatch.html:
        * inspector/timeline-layout-expected.txt:
        * inspector/timeline-layout.html:
        * inspector/timeline-mark-timeline.html:
        * inspector/timeline-network-resource-expected.txt:
        * inspector/timeline-network-resource.html:
        * inspector/timeline-network-resource.js:
        * inspector/timeline-paint.html:
        * inspector/timeline-parse-html-expected.txt:
        * inspector/timeline-parse-html.html:
        * inspector/timeline-recalculate-styles-expected.txt:
        * inspector/timeline-recalculate-styles.html:
        * inspector/timeline-script-tag-1-expected.txt:
        * inspector/timeline-script-tag-1.html:
        * inspector/timeline-script-tag-2-expected.txt:
        * inspector/timeline-script-tag-2.html:
        * inspector/timeline-script-tag-2.js:
        * inspector/timeline-test.js:
        (initialize_Timeline.InspectorTest.performActionsAndPrint.step1):
        (initialize_Timeline.InspectorTest.performActionsAndPrint.step2):
        (initialize_Timeline.InspectorTest.performActionsAndPrint.step3):
        (initialize_Timeline.InspectorTest.performActionsAndPrint):
        (initialize_Timeline.InspectorTest.printTimelineRecords):
        (initialize_Timeline.InspectorTest._timelineResults):
        (initialize_Timeline.InspectorTest.dumpTimelineRecord):
        (initialize_Timeline.InspectorTest.dumpTimelineRecords):
        (initialize_Timeline.InspectorTest.printTimelineRecordProperties):
        (initialize_Timeline.InspectorTest._timelineAgentTypeToString):
        (initialize_Timeline):
        * inspector/timeline-trivial.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78477 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Feb 2011 15:29:06 +0000 (15:29 +0000)]
2011-02-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: update chromium expectation for inspector test.

        * inspector/console-uncaught-exception-in-eval.html:
        * platform/chromium/inspector/console-uncaught-exception-in-eval-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78476 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Feb 2011 14:27:21 +0000 (14:27 +0000)]
2011-02-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: chromium expectations update.

        * platform/chromium-win/inspector/console-format-expected.txt: Removed.
        * platform/chromium-win/inspector/console-uncaught-exception-expected.txt: Removed.
        * platform/chromium-win/inspector/debugger-expand-scope-expected.txt: Removed.
        * platform/chromium/inspector/console-dir-global-expected.txt: Renamed from LayoutTests/platform/chromium-win/inspector/console-dir-global-expected.txt.
        * platform/chromium/inspector/console-format-collections-expected.txt:
        * platform/chromium/inspector/console-format-expected.txt:
        * platform/chromium/inspector/console-trace-in-eval-expected.txt:
        * platform/chromium/inspector/console-uncaught-exception-expected.txt:
        * platform/chromium/inspector/debugger-expand-scope-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78475 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 14 Feb 2011 14:23:03 +0000 (14:23 +0000)]
2011-02-14  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skipped some tests that were causing problems just in
        one of the bots, apparently rounding issues.
        https://bugs.webkit.org/show_bug.cgi?id=39022

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78474 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Roland Steiner <rolandsteiner@chromium.org>
rolandsteiner@chromium.org [Mon, 14 Feb 2011 14:08:50 +0000 (14:08 +0000)]
2011-02-14  Roland Steiner  <rolandsteiner@chromium.org>

        Reviewed by Kent Tamura.

        Bug 54377 - Clean up RenderTextControlSingleLine::createSubtreeIfNeeded()
        https://bugs.webkit.org/show_bug.cgi?id=54377

        Rearranged the condition blocks, removed superfluous conditions:
        .) if-statements where it's already clear that a search field is being generated
        .) testing for spin-buttons on field types that can never have them.

        createInnerBlockStyle(): only search fields create an inner block, and
        these can never have spin buttons.

        No new tests. (Refactoring - covered by existing tests)

        * rendering/RenderTextControlSingleLine.cpp:
        (WebCore::RenderTextControlSingleLine::createInnerBlockStyle):
        (WebCore::RenderTextControlSingleLine::createSubtreeIfNeeded):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78473 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-10 Pavel Podivilov <podivilov@chromium.org>
podivilov@chromium.org [Mon, 14 Feb 2011 14:06:10 +0000 (14:06 +0000)]
2011-02-10  Pavel Podivilov  <podivilov@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: refactoring, extract SourceMapping from SourceFrameContent.
        https://bugs.webkit.org/show_bug.cgi?id=54195

        Add SourceMapping interface with two implementations - IdenticalSourceMapping and SourceMappingForFormattedScript.
        Rewrite SourceFrameContent based on SourceMapping. Make SourceFrame unaware of source mapping details.

        * inspector/front-end/ResourceView.js:
        (WebInspector.SourceFrameContentProviderForResource.prototype.requestContent):
        * inspector/front-end/ScriptFormatter.js:
        (WebInspector.ScriptFormatter.locationToPosition):
        (WebInspector.ScriptFormatter.positionToLocation):
        (WebInspector.ScriptFormatter.prototype.formatContent.didFormatChunks):
        (WebInspector.ScriptFormatter.prototype.formatContent):
        (WebInspector.ScriptFormatter.prototype._splitContentIntoChunks):
        (WebInspector.SourceMappingForFormattedScript):
        (WebInspector.SourceMappingForFormattedScript.prototype.fromScriptLocation):
        (WebInspector.SourceMappingForFormattedScript.prototype.toScriptLocation):
        (WebInspector.SourceMappingForFormattedScript.prototype.originalPositionToFormattedLocation):
        (WebInspector.SourceMappingForFormattedScript.prototype._convertPosition):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.SourceFrameContentProviderForScript.prototype.requestContent):
        * inspector/front-end/SourceFrame.js:
        (WebInspector.SourceFrame.prototype._createTextViewer):
        (WebInspector.SourceFrame.prototype._shouldDisplayBreakpoint):
        (WebInspector.SourceFrame.prototype.setExecutionLine):
        (WebInspector.SourceFrame.prototype.clearExecutionLine):
        (WebInspector.SourceFrame.prototype._breakpointAdded):
        (WebInspector.SourceFrame.prototype.formatSource.didFormat):
        (WebInspector.SourceFrame.prototype.formatSource):
        (WebInspector.SourceFrame.prototype._continueToLine):
        (WebInspector.SourceFrame.prototype._setBreakpoint):
        (WebInspector.SourceFrame.prototype._findBreakpoint):
        (WebInspector.SourceFrameContentProvider.prototype.requestContent):
        * inspector/front-end/SourceFrameContent.js:
        (WebInspector.SourceFrameContent):
        (WebInspector.SourceFrameContent.prototype.sourceFrameLineNumberToScriptLocation):
        (WebInspector.SourceFrameContent.prototype.scriptLocationToSourceFrameLineNumber):
        (WebInspector.SourceFrameContent.prototype._sourceIDForSourceFrameLineNumber):
        (WebInspector.SourceMapping):
        (WebInspector.SourceMapping.prototype.fromScriptLocation):
        (WebInspector.SourceMapping.prototype.toScriptLocation):
        (WebInspector.IdenticalSourceMapping):
        (WebInspector.IdenticalSourceMapping.prototype.fromScriptLocation):
        (WebInspector.IdenticalSourceMapping.prototype.toScriptLocation):
        * inspector/front-end/utilities.js:
        (String.prototype.lineEndings):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78472 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 14 Feb 2011 14:00:17 +0000 (14:00 +0000)]
2011-02-14  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, skipped generated-content-inside-table.htm test, it
        fails in the bots, opened bug:
        https://bugs.webkit.org/show_bug.cgi?id=54389

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78471 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Feb 2011 13:20:30 +0000 (13:20 +0000)]
2011-02-14  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [REGRESSION introduced in r77950] Develop -> Start Debugging JavaScript does not open Web Inspector.
        https://bugs.webkit.org/show_bug.cgi?id=54277

        * inspector/InspectorAgent.cpp:
        (WebCore::InspectorAgent::populateScriptObjects):
        (WebCore::InspectorAgent::stopUserInitiatedProfiling):
        (WebCore::InspectorAgent::showAndEnableDebugger):
        (WebCore::InspectorAgent::showPanel):
        * inspector/InspectorAgent.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::showAndEnableDebugger):
        (WebCore::InspectorController::stopUserInitiatedProfiling):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78470 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Kenichi Ishibashi <bashi@chromium.org>
commit-queue@webkit.org [Mon, 14 Feb 2011 13:13:49 +0000 (13:13 +0000)]
2011-02-14  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Andreas Kling.

        css style="max-width:none" works wrong
        https://bugs.webkit.org/show_bug.cgi?id=53743

        Adds a test to ensure style 'max-width: none' works correctly.

        * fast/css/max-width-none-expected.txt: Added.
        * fast/css/max-width-none.html: Added.
2011-02-14  Kenichi Ishibashi  <bashi@chromium.org>

        Reviewed by Andreas Kling.

        css style="max-width:none" works wrong
        https://bugs.webkit.org/show_bug.cgi?id=53743

        Fix a bug that "max-width:none" works wrong.
        See also: http://trac.webkit.org/changeset/13462

        Test: fast/css/max-width-none.html

        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): For max-width of none,
        set it to Length(undefinedLength, Fixed), which is the correct
        value.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78469 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION (r77834): Assertion failing in svg/custom/use-multiple-on-nested-disallowe...
antti@apple.com [Mon, 14 Feb 2011 13:13:05 +0000 (13:13 +0000)]
REGRESSION (r77834): Assertion failing in svg/custom/use-multiple-on-nested-disallowed-font.svg
https://bugs.webkit.org/show_bug.cgi?id=54344

Reviewed by Andreas Kling.

Intead of recomputing, just mark style selector dirty if it is invalidated in the middle of a style recalc.

* dom/Document.cpp:
(WebCore::Document::Document):
(WebCore::Document::recalcStyle):
(WebCore::Document::recalcStyleSelector):
* dom/Document.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78468 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Naoki Takano <takano.naoki@gmail.com>
commit-queue@webkit.org [Mon, 14 Feb 2011 13:11:59 +0000 (13:11 +0000)]
2011-02-14  Naoki Takano  <takano.naoki@gmail.com>

        Reviewed by Kent Tamura.

        [Chromium] Fix wrong popup position for RTL(again)
        https://bugs.webkit.org/show_bug.cgi?id=54375

        Fix right position bug introduce by https://bugs.webkit.org/show_bug.cgi?id=53567, because the previous fix was correct for the current behaviour, but not good for http://crbug.com/60427. To calculate the correct right offset value and apply to the position, change WebCore::PopupContainer::layout() to return right offset value and use the returned value to calculate position.

        No new tests. However we can check manually with select_dropdown_box_alignment.html, autofill_alignment.html, select_alignment.html, select_dropdown_box_alignment.html, autofill-popup-width-and-item-direction.html

        * platform/chromium/PopupMenuChromium.cpp:
        (WebCore::PopupContainer::layoutAndCalculateWidgetRect): Change the input parameter to take popupInitialCoordinate again. And calculate correct right position with returned right offset from layoutAndGetRightOffset().
        (WebCore::PopupContainer::showPopup): Change the passing parameter to layoutAndCalculateWidgetRect().
        (WebCore::PopupContainer::layoutAndGetRightOffset): Change the name from layout() and to return rightOffset value.
        (WebCore::PopupContainer::refresh): Change the passing parameter to layoutAndCalculateWidgetRect().
        * platform/chromium/PopupMenuChromium.h: Change the function name and parameters.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78467 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Feb 2011 13:06:47 +0000 (13:06 +0000)]
2011-02-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow up to r78460 with more expectation updates.

        * inspector/styles-iframe-expected.txt:
        * inspector/styles-iframe.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78466 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Alejandro G. Castro <alex@igalia.com>
alex@webkit.org [Mon, 14 Feb 2011 12:31:42 +0000 (12:31 +0000)]
2011-02-14  Alejandro G. Castro  <alex@igalia.com>

        Unreviewed, rolling out r78451.
        http://trac.webkit.org/changeset/78451
        https://bugs.webkit.org/show_bug.cgi?id=53898

        It is causing crashes in some bots

        * platform/text/TextCodecICU.cpp:
        (WebCore::newTextCodecICU):
        (WebCore::TextCodecICU::registerBaseEncodingNames):
        (WebCore::TextCodecICU::registerBaseCodecs):
        (WebCore::TextCodecICU::registerExtendedEncodingNames):
        (WebCore::TextCodecICU::registerExtendedCodecs):
        (WebCore::ErrorCallbackSetter::~ErrorCallbackSetter):
        (WebCore::getGbkEscape):
        (WebCore::urlEscapedEntityCallback):
        (WebCore::gbkCallbackEscape):
        (WebCore::gbkUrlEscapedEntityCallack):
        (WebCore::gbkCallbackSubstitute):
        * platform/text/TextCodecICU.h:
        (WebCore::ICUConverterWrapper::ICUConverterWrapper):
        * platform/text/TextCodecUTF8.cpp:
        (WebCore::TextCodecUTF8::registerEncodingNames):
        (WebCore::nonASCIISequenceLength):
        (WebCore::decodeNonASCIISequence):
        (WebCore::TextCodecUTF8::decode):
        * platform/text/TextCodecUTF8.h:
        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps):
        (WebCore::extendTextCodecMaps):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78465 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Mon, 14 Feb 2011 11:32:32 +0000 (11:32 +0000)]
2011-02-14  Shinichiro Hamaji  <hamaji@chromium.org>

        Rebaseline chromium's test expectations for SVG tests.

        * platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.checksum: Added.
        * platform/chromium-mac/svg/W3C-SVG-1.1/text-intro-05-t-expected.png: Added.
        * platform/chromium-mac/svg/text/text-intro-05-t-expected.checksum:
        * platform/chromium-mac/svg/text/text-intro-05-t-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78464 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Feb 2011 11:29:38 +0000 (11:29 +0000)]
2011-02-14  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed: follow up to r78460 with expectation updates.

        * inspector/styles-iframe-expected.txt:
        * platform/mac-leopard/http/tests/inspector/console-websocket-error-expected.txt:
        * platform/mac/http/tests/inspector/console-websocket-error-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78463 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Mon, 14 Feb 2011 11:22:22 +0000 (11:22 +0000)]
2011-02-14  Shinichiro Hamaji  <hamaji@chromium.org>

        Rebaseline chromium's test expectation for http://trac.webkit.org/changeset/78449

        * platform/chromium-win/fast/gradients/css3-repeating-end-fill-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78462 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Mon, 14 Feb 2011 11:14:40 +0000 (11:14 +0000)]
2011-02-14  Shinichiro Hamaji  <hamaji@chromium.org>

        Rebaseline chromium's test expectations for inline-box-background-*

        * platform/chromium-linux/fast/inline/inline-box-background-expected.checksum: Added.
        * platform/chromium-linux/fast/inline/inline-box-background-expected.png: Added.
        * platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.checksum: Added.
        * platform/chromium-linux/fast/inline/inline-box-background-long-image-expected.png: Added.
        * platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
        * platform/chromium-linux/fast/inline/inline-box-background-repeat-x-expected.png: Added.
        * platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
        * platform/chromium-linux/fast/inline/inline-box-background-repeat-y-expected.png: Added.
        * platform/chromium-mac/fast/inline/inline-box-background-expected.checksum: Added.
        * platform/chromium-mac/fast/inline/inline-box-background-expected.png: Added.
        * platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.checksum: Added.
        * platform/chromium-mac/fast/inline/inline-box-background-long-image-expected.png: Added.
        * platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
        * platform/chromium-mac/fast/inline/inline-box-background-repeat-x-expected.png: Added.
        * platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
        * platform/chromium-mac/fast/inline/inline-box-background-repeat-y-expected.png: Added.
        * platform/chromium-win/fast/inline/inline-box-background-expected.checksum: Added.
        * platform/chromium-win/fast/inline/inline-box-background-expected.png: Added.
        * platform/chromium-win/fast/inline/inline-box-background-expected.txt: Added.
        * platform/chromium-win/fast/inline/inline-box-background-long-image-expected.checksum: Added.
        * platform/chromium-win/fast/inline/inline-box-background-long-image-expected.png: Added.
        * platform/chromium-win/fast/inline/inline-box-background-long-image-expected.txt: Added.
        * platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.checksum: Added.
        * platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.png: Added.
        * platform/chromium-win/fast/inline/inline-box-background-repeat-x-expected.txt: Added.
        * platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.checksum: Added.
        * platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.png: Added.
        * platform/chromium-win/fast/inline/inline-box-background-repeat-y-expected.txt: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78461 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-13 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Mon, 14 Feb 2011 10:58:58 +0000 (10:58 +0000)]
2011-02-13  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: [layout tests] get rid of elements-tests.js in favor of elements-tests2.js
        https://bugs.webkit.org/show_bug.cgi?id=54354

        * http/tests/inspector/console-resource-errors.html:
        * http/tests/inspector/console-test.js: Renamed from LayoutTests/http/tests/inspector/console-tests2.js.
        * http/tests/inspector/console-tests.js: Removed.
        * http/tests/inspector/console-websocket-error.html:
        * http/tests/inspector/console-xhr-logging-expected.txt:
        * http/tests/inspector/console-xhr-logging.html:
        * http/tests/inspector/debugger-test.js: Renamed from LayoutTests/http/tests/inspector/debugger-test2.js.
        * http/tests/inspector/elements-test.js: Added.
        * http/tests/inspector/inspector-test2.js:
        * http/tests/inspector/resource-har-conversion-expected.txt:
        * http/tests/inspector/resource-har-conversion.html:
        * http/tests/inspector/resource-parameters-expected.txt:
        * http/tests/inspector/resource-parameters.html:
        * http/tests/inspector/resource-tests.js: Removed.
        * http/tests/inspector/resources-test.js: Renamed from LayoutTests/http/tests/inspector/resource-test2.js.
        * inspector/command-line-api.html:
        * inspector/console-api-on-call-frame.html:
        * inspector/console-assert.html:
        * inspector/console-clear.html:
        * inspector/console-command-clear-expected.txt:
        * inspector/console-command-clear.html:
        * inspector/console-dir-global.html:
        * inspector/console-dir.html:
        * inspector/console-dirxml.html:
        * inspector/console-eval-global.html:
        * inspector/console-eval.html:
        * inspector/console-format-collections-expected.txt:
        * inspector/console-format-collections.html:
        * inspector/console-format-expected.txt:
        * inspector/console-format.html:
        * inspector/console-log-before-inspector-open.html:
        * inspector/console-log-syntax-error.html:
        * inspector/console-object-constructor-name.html:
        * inspector/console-tests.html:
        * inspector/console-trace-in-eval.html:
        * inspector/console-trace.html:
        * inspector/console-uncaught-exception-in-eval.html:
        * inspector/console-uncaught-exception.html:
        * inspector/debugger-autocontinue-on-syntax-error.html:
        * inspector/debugger-breakpoints-not-activated-on-reload.html:
        * inspector/debugger-cyclic-ref.html:
        * inspector/debugger-eval-on-call-frame.html:
        * inspector/debugger-eval-while-paused.html:
        * inspector/debugger-expand-scope.html:
        * inspector/debugger-no-nested-pause.html:
        * inspector/debugger-pause-in-eval-script.html:
        * inspector/debugger-pause-on-breakpoint.html:
        * inspector/debugger-pause-on-debugger-statement.html:
        * inspector/debugger-pause-on-exception.html:
        * inspector/debugger-proto-property.html:
        * inspector/debugger-scripts.html:
        * inspector/debugger-step-in.html:
        * inspector/debugger-step-out.html:
        * inspector/debugger-step-over.html:
        * inspector/debugger-suspend-active-dom-objects.html:
        * inspector/dom-breakpoints.html:
        * inspector/elements-delete-inline-style.html:
        * inspector/elements-img-tooltip-expected.txt:
        * inspector/elements-img-tooltip.html:
        * inspector/elements-panel-limited-children-expected.txt:
        * inspector/elements-panel-limited-children.html:
        * inspector/elements-panel-rewrite-href-expected.txt:
        * inspector/elements-panel-rewrite-href.html:
        * inspector/elements-panel-selection-on-refresh-expected.txt:
        * inspector/elements-panel-selection-on-refresh.html:
        * inspector/elements-panel-structure-expected.txt:
        * inspector/elements-panel-structure.html:
        * inspector/elements-panel-styles.html:
        * inspector/elements-panel-xhtml-structure-expected.txt:
        * inspector/elements-panel-xhtml-structure.xhtml:
        * inspector/elements-tests.js: Removed.
        * inspector/elements-tests2.js: Removed.
        * inspector/resources/elements-panel-styles.css:
        * inspector/resources/styles-iframe-data.html:
        * inspector/storage-panel-dom-storage.html:
        * inspector/styles-add-blank-property.html:
        * inspector/styles-computed-trace.html:
        * inspector/styles-disable-inherited.html:
        * inspector/styles-disable-then-change.html:
        * inspector/styles-disable-then-delete.html:
        * inspector/styles-disable-then-enable.html:
        * inspector/styles-iframe-expected.txt:
        * inspector/styles-iframe.html:
        * inspector/styles-new-API.html:
        * inspector/styles-source-lines-expected.txt:
        * inspector/styles-source-lines-inline.html:
        * inspector/styles-source-lines.html:
        * inspector/styles-source-offsets.html:
        * inspector/styles-url-linkify.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78460 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Mon, 14 Feb 2011 10:54:29 +0000 (10:54 +0000)]
2011-02-14  Shinichiro Hamaji  <hamaji@chromium.org>

        Rebaseline chromium's test_expectations.

        * platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.checksum: Added.
        * platform/chromium-win/fast/box-shadow/shadow-buffer-partial-expected.png: Added.
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78459 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-14 Balazs Kelemen <kbalazs@webkit.org>
kbalazs@webkit.org [Mon, 14 Feb 2011 09:28:02 +0000 (09:28 +0000)]
2011-02-14  Balazs Kelemen  <kbalazs@webkit.org>

        Reviewed by Csaba Osztrogon√°c.

        [Qt] Need implementation of ResourceRequest and ResourceResponse serialization
        https://bugs.webkit.org/show_bug.cgi?id=54339

        Add dummy implementation with FIXME and let the core go with it for now.
        * Shared/qt/WebCoreArgumentCodersQt.cpp:
        (CoreIPC::decodeResourceRequest):
        (CoreIPC::decodeResourceResponse):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78458 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agohttps://bugs.webkit.org/show_bug.cgi?id=54376
antti@apple.com [Mon, 14 Feb 2011 08:05:15 +0000 (08:05 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=54376
Make sorting of matched rules faster

Reviewed by Dan Bernstein.

- use std::sort
- cache specificity, it is slow to compute
- inline compare function

* css/CSSStyleSelector.cpp:
(WebCore::RuleData::specificity):
(WebCore::CSSStyleSelector::matchRules):
(WebCore::compareRules):
(WebCore::CSSStyleSelector::sortMatchedRules):
(WebCore::RuleData::RuleData):
(WebCore::CSSStyleSelector::matchPageRules):
* css/CSSStyleSelector.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78457 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-13 Hayato Ito <hayato@chromium.org>
hayato@chromium.org [Mon, 14 Feb 2011 07:58:23 +0000 (07:58 +0000)]
2011-02-13  Hayato Ito  <hayato@chromium.org>

        Reviewed by Kent Tamura.

        Update .gitignore to ignore files which Ninja build system generates.

        https://bugs.webkit.org/show_bug.cgi?id=54378

        * .gitignore:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78456 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 14 Feb 2011 04:02:39 +0000 (04:02 +0000)]
2011-02-13  Simon Fraser  <simon.fraser@apple.com>

        Change previous test to dump as text, with pixel output, to fix
        Qt failure.

        * fast/gradients/css3-repeating-end-fill-expected.txt:
        * fast/gradients/css3-repeating-end-fill.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78454 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoVersioning.
mrowe@apple.com [Mon, 14 Feb 2011 04:00:23 +0000 (04:00 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78453 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-12 Darin Adler <darin@apple.com>
darin@apple.com [Mon, 14 Feb 2011 03:28:37 +0000 (03:28 +0000)]
2011-02-12  Darin Adler  <darin@apple.com>

        Reviewed by Alexey Proskuryakov.

        Add built-in decoder for UTF-8 for improved performance
        https://bugs.webkit.org/show_bug.cgi?id=53898

        Covered by existing tests; not adding new tests at this time.

        This patch now handles errors in the same way the existing codecs do,
        and so passes our tests. The previous version failed some tests because
        of incorrect error handling.

        * platform/text/TextCodecICU.cpp:
        (WebCore::create): Renamed from newTextCodecICU, made a static member
        function, and added a call to adoptPtr.
        (WebCore::TextCodecICU::registerEncodingNames): Renamed from
        registerExtendedEncodingNames since this class is no longer used for
        base codecs. Removed aliases for UTF-8; now handled by TextCodecUTF8.
        (WebCore::TextCodecICU::registerCodecs): Renamed.
        (WebCore::fallbackForGBK): Renamed to conform to our current style.

        * platform/text/TextCodecICU.h: Updated for above changes. Changed
        indentation. Made most functions private, including virtual function
        overrides. Marked ICUConverterWrapper noncopyable.

        * platform/text/TextCodecUTF8.cpp:
        (WebCore::TextCodecUTF8::registerEncodingNames): Added the UTF-8 aliases
        that were formerly added by TextCodecICU.
        (WebCore::nonASCIISequenceLength): Fixed bug where this would return 4 for
        bytes F5-FF instead of failing.
        (WebCore::decodeNonASCIISequence): Tweaked coding style.
        (WebCore::appendCharacter): Added. Makes it easier to share code between
        the partial-character handling and main loop.
        (WebCore::TextCodecUTF8::decode): Fixed buffer size computation for case
        where there is a partial sequence. Fixed partial sequence handling so that
        goto is no longer needed, since compilers sometimes make poor code when
        goto is involved. Added a loop for partial sequences since we consume only
        one byte when a partial sequence is invalid. Fixed logic in main decoding
        loop so goto is not needed. Used early-exit style in both loops so the main
        flow is not nested inside if statements. Added correct error handling for
        flush when a partial sequence remains, which involved wrapping the function
        in yet another loop.

        * platform/text/TextCodecUTF8.h: Made virtual function overrides private.

        * platform/text/TextEncodingRegistry.cpp:
        (WebCore::buildBaseTextCodecMaps): Added calls to TextCodecUTF8. Removed
        calls to TextCodecICU. Added FIXMEs for other codecs that no longer need
        to be included here.
        (WebCore::extendTextCodecMaps): Updated for the name change of the
        TextCodecICU functions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78451 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago<rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't impleme...
mrowe@apple.com [Mon, 14 Feb 2011 02:50:19 +0000 (02:50 +0000)]
<rdar://problem/8995490> WebCoreAuthenticationClientAsChallengeSender doesn't implement some necessary methods.

Reviewed by Maciej Stachowiak.

* platform/network/mac/AuthenticationMac.mm:
(-[WebCoreAuthenticationClientAsChallengeSender performDefaultHandlingForAuthenticationChallenge:]):
(-[WebCoreAuthenticationClientAsChallengeSender rejectProtectionSpaceAndContinueWithChallenge:]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78450 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-13 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 14 Feb 2011 02:09:15 +0000 (02:09 +0000)]
2011-02-13  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Andreas Kling.

        Repeating gradients drawn incorrectly
        https://bugs.webkit.org/show_bug.cgi?id=53502

        The 'forward-fill' logic for repeating gradients used the wrong
        starting stop index (0 rather than the original first index), which
        resulted in incorrect gradients if backwards-fill had already been
        applied.

        Test: fast/gradients/css3-repeating-end-fill.html

        * css/CSSGradientValue.cpp:
        (WebCore::CSSGradientValue::addStops):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78449 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-13 Benjamin Poulain <benjamin.poulain@nokia.com>
benjamin.poulain@nokia.com [Mon, 14 Feb 2011 01:19:55 +0000 (01:19 +0000)]
2011-02-13  Benjamin Poulain  <benjamin.poulain@nokia.com>

        Reviewed by Andreas Kling.

        Unused variable result in RenderBlock::addOverflowFromFloats()
        https://bugs.webkit.org/show_bug.cgi?id=54363

        Remove the unused variable.

        * rendering/RenderBlock.cpp:
        (WebCore::RenderBlock::addOverflowFromFloats):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78448 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoReviewed by Anders Carlsson.
cwzwarich@webkit.org [Mon, 14 Feb 2011 00:14:07 +0000 (00:14 +0000)]
Reviewed by Anders Carlsson.

WebCore fails to build with Clang's -Woverloaded-virtual
https://bugs.webkit.org/show_bug.cgi?id=54367

* loader/PingLoader.h:
(WebCore::PingLoader::didReceiveData): Change the method signature to match the signature
in the base class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78447 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-13 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Mon, 14 Feb 2011 00:12:16 +0000 (00:12 +0000)]
2011-02-13  Andreas Kling  <kling@webkit.org>

        Unreviewed, remove unnecessary platform expectations for now-passing test.

        * platform/chromium/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.
        * platform/mac/canvas/philip/tests/2d.fillStyle.parse.system-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78446 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeculative fix for
andersca@apple.com [Mon, 14 Feb 2011 00:09:19 +0000 (00:09 +0000)]
Speculative fix for

Reviewed by Maciej Stachowiak.

<rdar://problem/8995361>
CrashTracer: [USER] 47 crashes in WebProcess at com.apple.WebKit2: WebKit::WebPage::layoutIfNeeded + 4

* WebProcess/WebPage/DrawingAreaImpl.cpp:
(WebKit::DrawingAreaImpl::~DrawingAreaImpl):
Invalidate the layer tree host.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78445 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-13 Nico Weber <thakis@chromium.org>
andersca@apple.com [Sun, 13 Feb 2011 23:19:33 +0000 (23:19 +0000)]
2011-02-13  Nico Weber  <thakis@chromium.org>

        Reviewed by Anders Carlsson.

        RenderBR::width() tries but fails to override RenderText::width()
        https://bugs.webkit.org/show_bug.cgi?id=54301

        The superclass method's signature changed, e.g. in
        http://trac.webkit.org/changeset/57215, but the subclass was not
        updated.

        * rendering/RenderBR.h:
        (WebCore::RenderBR::width):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78444 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago2011-02-13 Shinichiro Hamaji <hamaji@chromium.org>
hamaji@chromium.org [Sun, 13 Feb 2011 23:11:36 +0000 (23:11 +0000)]
2011-02-13  Shinichiro Hamaji  <hamaji@chromium.org>

        Fix chromium's test_expectations

        - fast/inline/inline-box-background-* should be IMAGE instead of IMAGE+TEXTfor Mac
        - fast/css/test-setting-canvas-color.html is failing

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@78443 268f45cc-cd09-0410-ab3c-d52691b4dbfc