WebKit-https.git
6 years ago2013-04-06 Laszlo Gombos <l.gombos@samsung.com>
l.gombos@samsung.com [Sun, 7 Apr 2013 03:52:05 +0000 (03:52 +0000)]
2013-04-06  Laszlo Gombos  <l.gombos@samsung.com>

        Build fix after r147857, remove remaining USE(JSC) guards.

        Unreviewed.

        * DumpRenderTree/config.h:
        * TestWebKitAPI/config.h:
        * WebKitTestRunner/config.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147866 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRename sheriffbot to webkitbot
rniwa@webkit.org [Sun, 7 Apr 2013 01:59:39 +0000 (01:59 +0000)]
Rename sheriffbot to webkitbot
https://bugs.webkit.org/show_bug.cgi?id=114109

Reviewed by Benjamin Poulain.

Renamed since sheriffbot will be used in Blink.

* Scripts/webkitpy/tool/commands/sheriffbot.py:
(SheriffBot):
(SheriffBot.begin_work_queue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147865 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoGet rid of skia
benjamin@webkit.org [Sun, 7 Apr 2013 01:32:53 +0000 (01:32 +0000)]
Get rid of skia
https://bugs.webkit.org/show_bug.cgi?id=114108

Reviewed by Anders Carlsson.

* platform/graphics/filters/skia/*: Removed.
* platform/graphics/skia/*: Removed.
* platform/image-decoders/skia/*: Removed.
* platform/image-encoders/skia/*: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147864 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the chromium code from platform/graphics/mac
benjamin@webkit.org [Sun, 7 Apr 2013 01:31:33 +0000 (01:31 +0000)]
Remove the chromium code from platform/graphics/mac
https://bugs.webkit.org/show_bug.cgi?id=114107

Reviewed by Anders Carlsson.

* platform/graphics/mac/FontCacheMac.mm:
(WebCore::FontCache::getFontDataForCharacters):
(WebCore::FontCache::createFontPlatformData):
* platform/graphics/mac/FontComplexTextMac.cpp:
(WebCore::Font::selectionRectForComplexText):
(WebCore::Font::drawComplexText):
(WebCore::Font::floatWidthForComplexText):
(WebCore::Font::offsetForPositionForComplexText):
* platform/graphics/mac/FontMac.mm:
(WebCore::hasBrokenCTFontGetVerticalTranslationsForGlyphs):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147863 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean platform/graphics/cg of the chromium bits
benjamin@webkit.org [Sun, 7 Apr 2013 01:30:21 +0000 (01:30 +0000)]
Clean platform/graphics/cg of the chromium bits
https://bugs.webkit.org/show_bug.cgi?id=114106

Reviewed by Anders Carlsson.

* platform/graphics/cg/BitmapImageCG.cpp:
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::roundToDevicePixels):
* platform/graphics/cg/GraphicsContextPlatformPrivateCG.h:
(GraphicsContextPlatformPrivate):
* platform/graphics/cg/ImageBufferCG.cpp:
* platform/graphics/cg/ImageCG.cpp:
* platform/graphics/cg/PathCG.cpp:
* platform/graphics/cg/PatternCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147862 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove InjectedScriptHost.evaluateReturnsEvalFunction.
timothy@apple.com [Sat, 6 Apr 2013 23:48:05 +0000 (23:48 +0000)]
Remove InjectedScriptHost.evaluateReturnsEvalFunction.

https://webkit.org/b/114099

Source/WebCore:

* inspector/InjectedScriptHost.h:
(InjectedScriptHost):
* inspector/InjectedScriptHost.idl:
* inspector/InjectedScriptSource.js:
(InjectedScript.prototype._evaluateOn):

LayoutTests:

Reviewed by Joseph Pecoraro.

* inspector/console/command-line-api-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147861 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the chromium code from WebCore/platform/mac
benjamin@webkit.org [Sat, 6 Apr 2013 23:23:17 +0000 (23:23 +0000)]
Remove the chromium code from WebCore/platform/mac
https://bugs.webkit.org/show_bug.cgi?id=114104

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-06
Reviewed by Sam Weinig.

* platform/mac/NSScrollerImpDetails.h:
(WebCore::isScrollbarOverlayAPIAvailable):
* platform/mac/NSScrollerImpDetails.mm:
* platform/mac/ScrollAnimatorMac.mm:
(-[WebScrollbarPainterDelegate layer]):
(WebCore::scrollAnimationEnabledForSystem):
* platform/mac/ScrollElasticityController.mm:
(WebCore):
* platform/mac/ScrollbarThemeMac.h:
(ScrollbarThemeMac):
* platform/mac/ScrollbarThemeMac.mm:
(WebCore::ScrollbarTheme::nativeTheme):
(WebCore::ScrollbarThemeMac::paint):
(WebCore):
* platform/mac/ThemeMac.mm:
(WebCore::ThemeMac::ensuredView):
* platform/mac/WebCoreNSCellExtras.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147860 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the Chromium code from Mac's FontPlatformData
benjamin@webkit.org [Sat, 6 Apr 2013 23:19:08 +0000 (23:19 +0000)]
Remove the Chromium code from Mac's FontPlatformData
https://bugs.webkit.org/show_bug.cgi?id=114103

Reviewed by Sam Weinig.

* platform/graphics/FontPlatformData.h:
(WebCore):
(FontPlatformData):
* platform/graphics/cocoa/FontPlatformDataCocoa.mm:
(WebCore::FontPlatformData::FontPlatformData):
(WebCore::FontPlatformData::platformDataInit):
(WebCore::FontPlatformData::platformDataAssign):
(WebCore::FontPlatformData::setFont):
(WebCore::FontPlatformData::ctFont):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147859 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnify the many and varied stack trace mechanisms, and make the result sane.
oliver@apple.com [Sat, 6 Apr 2013 22:47:56 +0000 (22:47 +0000)]
Unify the many and varied stack trace mechanisms, and make the result sane.
https://bugs.webkit.org/show_bug.cgi?id=114072

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Makes JSC::StackFrame record the bytecode offset and other necessary data
rather than requiring us to perform eager evaluation of the line number, etc.
Then remove most of the users of retrieveLastCaller, as most of them were
using it to create a stack trace in a fairly incomplete and inefficient way.

StackFrame now also has a couple of helpers to get the line and column info.

* API/JSContextRef.cpp:
(JSContextCreateBacktrace):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getBytecodeOffsetForCallFrame):
(JSC::getCallerInfo):
(JSC::StackFrame::line):
(JSC::StackFrame::column):
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(StackFrame):
(Interpreter):
* runtime/Error.cpp:
(JSC::throwError):
* runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):

Source/WebCore:

Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
WebCore can just ask us for a stack trace rather than implementing its own
stack walking.

* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::isEqual):
* inspector/ScriptCallFrame.h:
(ScriptCallFrame):
(WebCore::ScriptCallFrame::columnNumber):

Tools:

The commandline jsc executable no longer requires arguments, so
I've made run-jsc work without them.

* Scripts/run-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147858 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved v8 bindings hooks from IDL files
weinig@apple.com [Sat, 6 Apr 2013 22:42:32 +0000 (22:42 +0000)]
Removed v8 bindings hooks from IDL files
https://bugs.webkit.org/show_bug.cgi?id=114091

Patch by Geoffrey Garen <ggaren@apple.com> on 2013-04-06
Reviewed by Anders Carlsson and Sam Weinig.

Source/JavaScriptCore:

* heap/HeapStatistics.h:

Source/WebCore:

* Modules/encryptedmedia/MediaKeySession.idl:
* Modules/filesystem/DOMWindowFileSystem.idl:
* Modules/filesystem/WorkerContextFileSystem.idl:
* Modules/gamepad/NavigatorGamepad.idl:
* Modules/geolocation/NavigatorGeolocation.idl:
* Modules/indexeddb/DOMWindowIndexedDatabase.idl:
* Modules/indexeddb/WorkerContextIndexedDatabase.idl:
* Modules/mediastream/DOMWindowMediaStream.idl:
* Modules/mediastream/NavigatorMediaStream.idl:
* Modules/notifications/DOMWindowNotifications.idl:
* Modules/notifications/NotificationCenter.idl:
* Modules/notifications/WorkerContextNotifications.idl:
* Modules/quota/DOMWindowQuota.idl:
* Modules/speech/DOMWindowSpeech.idl:
* Modules/webaudio/AudioBufferSourceNode.idl:
* Modules/webaudio/AudioContext.idl:
* Modules/webaudio/AudioParam.idl:
* Modules/webaudio/DOMWindowWebAudio.idl:
* Modules/webdatabase/DOMWindowWebDatabase.idl:
* Modules/webdatabase/WorkerContextWebDatabase.idl:
* Modules/websockets/DOMWindowWebSocket.idl:
* Modules/websockets/WorkerContextWebSocket.idl:
* bindings/js/JSDOMBinding.cpp:
* bindings/js/ScriptController.h:
(ScriptController):
* bindings/scripts/test/TestNode.idl:
* bindings/scripts/test/TestObj.idl:
* css/CSSFontFaceLoadEvent.idl:
* css/CSSHostRule.idl:
* css/CSSRule.idl:
* css/CSSRuleList.idl:
* css/CSSStyleDeclaration.idl:
* css/CSSStyleSheet.idl:
* css/CSSValue.idl:
* css/FontLoader.idl:
* css/StyleSheet.idl:
* css/WebKitCSSRegionRule.idl:
* dom/Clipboard.idl:
* dom/CustomElementConstructor.idl:
* dom/CustomEvent.idl:
* dom/DOMNamedFlowCollection.idl:
* dom/DOMStringMap.idl:
* dom/DataTransferItemList.idl:
* dom/Document.idl:
* dom/DocumentFragment.idl:
* dom/Element.idl:
* dom/Event.idl:
* dom/EventTarget.idl:
* dom/MessageChannel.idl:
* dom/MouseEvent.idl:
* dom/MutationRecord.idl:
* dom/NamedNodeMap.idl:
* dom/Node.idl:
* dom/NodeList.idl:
* dom/RequestAnimationFrameCallback.idl:
* dom/ShadowRoot.idl:
* dom/Text.idl:
* history/HistoryItem.cpp:
(WebCore::HistoryItem::encodeBackForwardTreeNode):
(WebCore::HistoryItem::decodeBackForwardTree):
* html/DOMSettableTokenList.idl:
* html/DOMTokenList.idl:
* html/HTMLAllCollection.idl:
* html/HTMLAppletElement.idl:
* html/HTMLCollection.idl:
* html/HTMLDialogElement.idl:
* html/HTMLDivElement.idl:
* html/HTMLDocument.idl:
* html/HTMLElement.idl:
* html/HTMLEmbedElement.idl:
* html/HTMLFormControlsCollection.idl:
* html/HTMLFormElement.idl:
* html/HTMLImageElement.idl:
* html/HTMLInputElement.idl:
* html/HTMLMediaElement.idl:
* html/HTMLObjectElement.idl:
* html/HTMLOptionsCollection.idl:
* html/HTMLSelectElement.idl:
* html/HTMLSpanElement.idl:
* html/HTMLStyleElement.idl:
* html/HTMLTemplateElement.idl:
* html/HTMLTrackElement.idl:
* html/HTMLUnknownElement.idl:
* html/MediaKeyError.idl:
* html/MediaKeyEvent.idl:
* html/MicroDataItemValue.idl:
* html/canvas/CanvasRenderingContext2D.idl:
* html/canvas/DOMPath.idl:
* html/shadow/HTMLContentElement.idl:
* html/shadow/HTMLShadowElement.idl:
* html/track/TextTrack.idl:
* inspector/InjectedScriptHost.idl:
* inspector/InspectorIndexedDBAgent.cpp:
(WebCore::InspectorIndexedDBAgent::requestDatabaseNames):
(WebCore::InspectorIndexedDBAgent::requestDatabase):
(WebCore::InspectorIndexedDBAgent::requestData):
(WebCore::InspectorIndexedDBAgent::clearObjectStore):
(WebCore):
* loader/EmptyClients.h:
(EmptyFrameLoaderClient):
* loader/FrameLoaderClient.h:
(FrameLoaderClient):
* page/Console.idl:
* page/DOMWindow.idl:
* page/DOMWindowPagePopup.idl:
* page/History.idl:
* page/Location.idl:
* platform/graphics/skia/PatternSkia.cpp:
(WebCore::Pattern::platformDestroy):
(WebCore::Pattern::platformPattern):
* testing/Internals.cpp:
(WebCore::Internals::serializeObject):
(WebCore::Internals::deserializeBuffer):

Source/WTF:

* wtf/ArrayBuffer.h:
(WTF):
(WTF::ArrayBufferContents::ArrayBufferContents):
(WTF::ArrayBufferContents::transfer):
(ArrayBufferContents):
(ArrayBuffer):
(WTF::ArrayBufferContents::~ArrayBufferContents):
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147857 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWindows VS2010 build fix.
roger_fong@apple.com [Sat, 6 Apr 2013 22:05:35 +0000 (22:05 +0000)]
Windows VS2010 build fix.

* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147856 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the USE(SKIA_ON_MAC_CHROMIUM) guards
zandobersek@gmail.com [Sat, 6 Apr 2013 21:38:46 +0000 (21:38 +0000)]
Remove the USE(SKIA_ON_MAC_CHROMIUM) guards
https://bugs.webkit.org/show_bug.cgi?id=114084

Reviewed by Ryosuke Niwa.

Source/WebCore:

Remove the USE(SKIA_ON_MAC_CHROMIUM) guards. The guards were enabled only
for the Chromium port via the features.gypi file that was removed in r147714.

* platform/graphics/FloatPoint.h:
(FloatPoint):
* platform/graphics/FloatRect.h:
(FloatRect):
* platform/graphics/FloatSize.h:
(FloatSize):
* platform/graphics/FontPlatformData.cpp:
(WebCore):
* platform/graphics/FontPlatformData.h:
(FontPlatformData):
(WebCore::FontPlatformData::hash):
* platform/graphics/IntPoint.h:
(IntPoint):
* platform/graphics/IntRect.h:
(IntRect):
(WebCore):
* platform/graphics/IntSize.h:
(IntSize):
* platform/graphics/SimpleFontData.h:
(SimpleFontData):
(WebCore::SimpleFontData::widthForGlyph):
* platform/graphics/cg/FloatPointCG.cpp:
* platform/graphics/cg/FloatRectCG.cpp:
* platform/graphics/cg/FloatSizeCG.cpp:
* platform/graphics/cg/IntPointCG.cpp:
* platform/graphics/cg/IntRectCG.cpp:
* platform/graphics/cg/IntSizeCG.cpp:
* platform/graphics/mac/FontCustomPlatformData.cpp:
(WebCore::FontCustomPlatformData::~FontCustomPlatformData):
(WebCore::createFontCustomPlatformData):
* platform/graphics/mac/FontCustomPlatformData.h:
(WebCore::FontCustomPlatformData::FontCustomPlatformData):
(FontCustomPlatformData):

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataUseFeatures.in: Remove the SKIA_ON_MAC_(CHROME|CHROMIUM) reference.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147855 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] build fails with error: 'UINT_MAX' was not declared in this scope
commit-queue@webkit.org [Sat, 6 Apr 2013 21:21:32 +0000 (21:21 +0000)]
[EFL] build fails with error: 'UINT_MAX' was not declared in this scope
https://bugs.webkit.org/show_bug.cgi?id=114086

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-06
Reviewed by Tim Horton.

* DumpRenderTree/AccessibilityUIElement.cpp: Included limits.h

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147854 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
zandobersek@gmail.com [Sat, 6 Apr 2013 21:19:38 +0000 (21:19 +0000)]
Remove remaining PLATFORM(CHROMIUM) guards in TestWebKitAPI, WebKitTestRunner
https://bugs.webkit.org/show_bug.cgi?id=114083

Reviewed by Ryosuke Niwa.

Remove the remaining three occurrences of the PLATFORM(CHROMIUM) build guards
in TestWebKitAPI and WebKitTestRunner.

* TestWebKitAPI/config.h:
* TestWebKitAPI/mac/InjectedBundleControllerMac.mm:
(TestWebKitAPI::InjectedBundleController::platformInitialize):
* WebKitTestRunner/InjectedBundle/mac/InjectedBundleMac.mm:
(WTR::InjectedBundle::platformInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147853 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the remaining PLATFORM(CHROMIUM) guard in JavaScriptCore
zandobersek@gmail.com [Sat, 6 Apr 2013 21:18:32 +0000 (21:18 +0000)]
Remove the remaining PLATFORM(CHROMIUM) guard in JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=114082

Reviewed by Ryosuke Niwa.

* runtime/JSExportMacros.h: Remove the remaining PLATFORM(CHROMIUM) guard.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147852 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago--minimal build fails with error: control reaches end of non-void function
commit-queue@webkit.org [Sat, 6 Apr 2013 20:04:05 +0000 (20:04 +0000)]
--minimal build fails with error: control reaches end of non-void function
https://bugs.webkit.org/show_bug.cgi?id=114085

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-06
Reviewed by Oliver Hunt.

* interpreter/Interpreter.cpp: return 0 if JIT is not enabled
(JSC::getBytecodeOffsetForCallFrame):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147851 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoREGRESSION(r142152): Text wraps in menu
robert@webkit.org [Sat, 6 Apr 2013 19:48:51 +0000 (19:48 +0000)]
REGRESSION(r142152): Text wraps in menu
https://bugs.webkit.org/show_bug.cgi?id=113706

Reviewed by David Hyatt.

Source/WebCore:

* rendering/RenderBlockLineLayout.cpp:
(WebCore::inlineLogicalWidth): Empty inline elements add their inline border/padding/margin to the width of the
line when we iterate through them in nextLineBreak(), so no need to add them again here when climbing back up
from their first child looking for border/padding/margin to add. (An empty inline element can have floating children.)

LayoutTests:

* fast/inline/inline-with-empty-inline-children-expected.txt:
* fast/inline/inline-with-empty-inline-children.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147850 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix the Windows build.
ggaren@apple.com [Sat, 6 Apr 2013 19:17:05 +0000 (19:17 +0000)]
Try to fix the Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Added back a symbol that is exported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147849 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix the WebKit2 build.
ggaren@apple.com [Sat, 6 Apr 2013 18:58:08 +0000 (18:58 +0000)]
Try to fix the WebKit2 build.

* NetworkProcess/NetworkResourceLoader.cpp:
(WebKit):
* NetworkProcess/NetworkResourceLoader.h:
(NetworkResourceLoader): Removed a defunct function.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147848 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTry to fix the Windows build.
ggaren@apple.com [Sat, 6 Apr 2013 18:54:18 +0000 (18:54 +0000)]
Try to fix the Windows build.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
Removed symbols that aren't exported.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147847 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRolled out 147820 and 147818 because they caused plugins tests to ASSERT
ggaren@apple.com [Sat, 6 Apr 2013 18:24:37 +0000 (18:24 +0000)]
Rolled out 147820 and 147818 because they caused plugins tests to ASSERT
https://bugs.webkit.org/show_bug.cgi?id=114094

Reviewed by Anders Carlsson.

Source/JavaScriptCore:

* API/JSContextRef.cpp:
(JSContextCreateBacktrace):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getLineNumberForCallFrame):
(JSC::getCallerInfo):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(StackFrame):
(JSC::StackFrame::toString):
(JSC::StackFrame::friendlyLineNumber):
(Interpreter):
* runtime/Error.cpp:
(JSC::throwError):
* runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):

Source/WebCore:

* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::isEqual):
* inspector/ScriptCallFrame.h:
(ScriptCallFrame):
(WebCore::ScriptCallFrame::lineNumber):

Tools:

* Scripts/run-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147846 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed WinCE build fix after r145849.
paroga@webkit.org [Sat, 6 Apr 2013 18:24:02 +0000 (18:24 +0000)]
Unreviewed WinCE build fix after r145849.

* WebCoreSupport/EditorClientWinCE.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147845 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CMake] Remove general include directories from platform specific files
paroga@webkit.org [Sat, 6 Apr 2013 18:23:12 +0000 (18:23 +0000)]
[CMake] Remove general include directories from platform specific files

Move the include directories, which are required by all CMake ports
to the general CMakeLists.txt to fix the build for Windows CE port.

* CMakeLists.txt:
* PlatformBlackBerry.cmake:
* PlatformEfl.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147844 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove VisitedLinks.{cpp|h}
andersca@apple.com [Sat, 6 Apr 2013 18:15:03 +0000 (18:15 +0000)]
Remove VisitedLinks.{cpp|h}
https://bugs.webkit.org/show_bug.cgi?id=114095

Reviewed by Geoffrey Garen.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* platform/VisitedLinks.cpp: Removed.
* platform/VisitedLinks.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147843 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed build fix after r146932.
paroga@webkit.org [Sat, 6 Apr 2013 18:10:18 +0000 (18:10 +0000)]
Unreviewed build fix after r146932.

* profiler/ProfilerDatabase.cpp:
(Profiler):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147842 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAnother build fix.
andersca@apple.com [Sat, 6 Apr 2013 18:07:37 +0000 (18:07 +0000)]
Another build fix.

Actually remove the right files from WebCore.vcxproj.

* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147841 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFix build.
andersca@apple.com [Sat, 6 Apr 2013 18:03:39 +0000 (18:03 +0000)]
Fix build.

ThreadableLoaderClientWrapper was still calling didReceiveCachedMetadata; I didn't notice it
because the file was not in the Xcode project so I went ahead and added it.

* WebCore.xcodeproj/project.pbxproj:
* loader/ThreadableLoaderClientWrapper.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147840 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove dead CachedMetadata code
andersca@apple.com [Sat, 6 Apr 2013 17:55:06 +0000 (17:55 +0000)]
Remove dead CachedMetadata code
https://bugs.webkit.org/show_bug.cgi?id=114093

Reviewed by Geoffrey Garen.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.vcxproj/WebCore.vcxproj.filters:
* WebCore.xcodeproj/project.pbxproj:
* loader/CachedMetadata.cpp: Removed.
* loader/CachedMetadata.h: Removed.
* loader/ResourceLoader.h:
(ResourceLoader):
* loader/SubresourceLoader.cpp:
* loader/SubresourceLoader.h:
(SubresourceLoader):
* loader/ThreadableLoaderClient.h:
* loader/WorkerThreadableLoader.cpp:
* loader/WorkerThreadableLoader.h:
(MainThreadBridge):
* loader/cache/CachedResource.cpp:
(WebCore::CachedResource::reportMemoryUsage):
* loader/cache/CachedResource.h:
(WebCore):
(CachedResource):
* platform/network/ResourceHandle.cpp:
* platform/network/ResourceHandle.h:
(ResourceHandle):
* platform/network/ResourceHandleClient.h:
(ResourceHandleClient):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147839 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove more dead Chromium code
andersca@apple.com [Sat, 6 Apr 2013 16:57:06 +0000 (16:57 +0000)]
Remove more dead Chromium code
https://bugs.webkit.org/show_bug.cgi?id=114090

Reviewed by Alp Toker.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.vcxproj/WebCore.vcxproj:
* WebCore.xcodeproj/project.pbxproj:
* platform/StatsCounter.cpp: Removed.
* platform/StatsCounter.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147838 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix for WinCE after r143046.
paroga@webkit.org [Sat, 6 Apr 2013 10:06:46 +0000 (10:06 +0000)]
Build fix for WinCE after r143046.

* platform/graphics/wince/ImageWinCE.cpp:
(WebCore::Image::drawPattern):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147837 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoDo not call getenv() on Windows CE where it does not exist.
paroga@webkit.org [Sat, 6 Apr 2013 09:54:03 +0000 (09:54 +0000)]
Do not call getenv() on Windows CE where it does not exist.

* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::JSGlobalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147836 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCE] Do not call missing method createDragImageFromImage()
paroga@webkit.org [Sat, 6 Apr 2013 09:31:25 +0000 (09:31 +0000)]
[WinCE] Do not call missing method createDragImageFromImage()
https://bugs.webkit.org/show_bug.cgi?id=110421

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-06

* platform/win/ClipboardWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147835 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WinCE] Compile missing NetworkStorageSession methods
paroga@webkit.org [Sat, 6 Apr 2013 09:22:20 +0000 (09:22 +0000)]
[WinCE] Compile missing NetworkStorageSession methods
https://bugs.webkit.org/show_bug.cgi?id=110419

Patch by Mark Salisbury <mark.salisbury@hp.com> on 2013-04-05

* PlatformWinCE.cmake:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147834 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMove the flakiness dashboard to the new instance at webkit-test-results.appspot.com
ojan@chromium.org [Sat, 6 Apr 2013 06:27:37 +0000 (06:27 +0000)]
Move the flakiness dashboard to the new instance at webkit-test-results.appspot.com
https://bugs.webkit.org/show_bug.cgi?id=114080

Reviewed by Ryosuke Niwa.

This way, the WebKit and Blink dashboard code can change as appropriate without
needing to consider the other project's needs. This still doesn't update the
buildbots to upload to the new location, or the dashboard code to pull the
results.json files from the new location, but it at least allows for changing the
UI code (e.g. the WebKit one can remove all knowledge of the Chromium bots).

* TestResultServer/app.yaml:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147833 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoPrefer prefix ++/-- operators for non-primitive types
kangil.han@samsung.com [Sat, 6 Apr 2013 04:41:38 +0000 (04:41 +0000)]
Prefer prefix ++/-- operators for non-primitive types
https://bugs.webkit.org/show_bug.cgi?id=114033

Reviewed by Alexey Proskuryakov.

Post ++/-- creates a copy of current value and it is not necessary, so use prefix instead.

* bindings/js/Dictionary.cpp:
(WebCore::Dictionary::getOwnPropertiesAsStringHashMap):
(WebCore::Dictionary::getOwnPropertyNames):
* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* dom/ContainerNode.cpp:
(WebCore::willRemoveChildren):
* dom/Range.cpp:
(WebCore::Range::processAncestorsAndTheirSiblings):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::detachChildren):
* platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
(WebCore):
(WebCore::LoopBlinnPathProcessor::subdivideCurvesSlow):
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::paintDocumentMarkers):
* xml/XPathFunctions.cpp:
(WebCore::XPath::Function::setArguments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147832 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Exclusions] Add support for the simple case of shape-margin polygonal shape...
hmuller@adobe.com [Sat, 6 Apr 2013 04:21:08 +0000 (04:21 +0000)]
[CSS Exclusions] Add support for the simple case of shape-margin polygonal shape-outside
https://bugs.webkit.org/show_bug.cgi?id=113726

Reviewed by Dirk Schulze.

Source/WebCore:

Add support for computing the shape-outside shape-margin boundary for a polygon.
This change is similar to the one added for padding polygons, see bug 112592.
The algorithm used for computing the margin boundary is is provisional. It works
correctly for convex polygons and will work correctly for non self-intersecting
polygons whose margin boundary is the same shape as the original polygon.

Tests: fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html
       fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html
       fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html

* rendering/ExclusionPolygon.cpp:
(WebCore::appendArc): Generalized this method a little, to deal with margin and padding connecting arcs.
(WebCore::computeShapePaddingBounds): Pass the new appendArc() parameter.
(WebCore::computeShapeMarginBounds): Compute the margin boundary for a polygon, per the constraints summarized above.
(WebCore::ExclusionPolygon::getExcludedIntervals): Use the margin polygon for this computation.

LayoutTests:

Verify that shape-outside layout works correctly on floats, when shape-margin is specifed.

* fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon-expected.txt: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-diamond-margin-polygon.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-left-margin-polygon.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon-expected.html: Added.
* fast/exclusions/shape-outside-floats/shape-outside-floats-right-margin-polygon.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147831 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoModernize fast/events/autoscroll.html
benjamin@webkit.org [Sat, 6 Apr 2013 03:33:54 +0000 (03:33 +0000)]
Modernize fast/events/autoscroll.html
https://bugs.webkit.org/show_bug.cgi?id=112508

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Jer Noble.

The test fast/events/autoscroll.html was introduced in
https://bugs.webkit.org/show_bug.cgi?id=12331 (r19102) to verify the page
does not scroll when the text is selected.

It seems reasonable to test the use case with a text dump instead of a pixel test.
This should reduces the maintenance needed to keep the test useful.

* fast/events/autoscroll.html: Removed.
* fast/events/no-scroll-on-input-text-selection-expected.txt: Added.
* fast/events/no-scroll-on-input-text-selection.html: Added.
* platform/efl/fast/events/autoscroll-expected.png: Removed.
* platform/efl/fast/events/autoscroll-expected.txt: Removed.
* platform/gtk/fast/events/autoscroll-expected.png: Removed.
* platform/gtk/fast/events/autoscroll-expected.txt: Removed.
* platform/mac-wk2/TestExpectations:
* platform/mac/fast/events/autoscroll-expected.png: Removed.
* platform/mac/fast/events/autoscroll-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147830 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoReturning NULL from willSendRequest should cancel a load from the memory cache
aestes@apple.com [Sat, 6 Apr 2013 03:09:25 +0000 (03:09 +0000)]
Returning NULL from willSendRequest should cancel a load from the memory cache
https://bugs.webkit.org/show_bug.cgi?id=114075

Reviewed by Darin Adler.

Source/WebCore:

When a resource is loaded from the memory cache and the client does not
implement the didLoadResourceFromMemoryCache delegate method, WebKit
synthesizes the typical sequence of resource load callbacks. One of
these is willSendRequest, which gives the client the opportunity to
modify the request. We should respect these modifications.

Handling any arbitrary modification is difficult given where in the
loading process we check the memory cache (see <http://webkit.org/b/113251>),
but we can handle the common case where the client cancels the load by
returning a NULL request.

Test: fast/loader/willsendrequest-returns-null-for-memory-cache-load.html

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::willLoadMediaElementURL): Passed request to sendRemainingDelegateMessages.
(WebCore::FrameLoader::commitProvisionalLoad): Ditto.
(WebCore::FrameLoader::loadResourceSynchronously): Ditto.
(WebCore::FrameLoader::loadedResourceFromMemoryCache): Added an out
parameter to pass back a request potentially modified by
requestFromDelegate, which is also passed to sendRemainingDelegateMessages.
* loader/FrameLoader.h:
* loader/ResourceLoadNotifier.cpp:
(WebCore::ResourceLoadNotifier::dispatchDidFailLoading): Added a
function to dispatch didFailLoading and to call the correct InspectorInstrumentation.
(WebCore::ResourceLoadNotifier::sendRemainingDelegateMessages): If the
request is NULL, call dispatchDidFailLoading and return. This matches
the delegate callback sequence of a non memory cache load that is
cancelled by willSendRequest.
* loader/ResourceLoadNotifier.h:
* loader/cache/CachedResourceLoader.cpp:
(WebCore::CachedResourceLoader::shouldContinueAfterNotifyingLoadedFromMemoryCache):
Return false if the memory cache load is cancelled by the client.
(WebCore::CachedResourceLoader::requestResource): Return early if
shouldContinueAfterNotifyingLoadedFromMemoryCache is false.

LayoutTests:

* fast/loader/resources/cached-image.html: Added.
* fast/loader/willsendrequest-returns-null-for-memory-cache-load-expected.txt: Added.
* fast/loader/willsendrequest-returns-null-for-memory-cache-load.html: Added.
* platform/wk2/TestExpectations: Expect the test to fail in WKTR due to <http://webkit.org/b/114074>.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147829 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSecond attempt to fix the Windows bot
benjamin@webkit.org [Sat, 6 Apr 2013 02:57:56 +0000 (02:57 +0000)]
Second attempt to fix the Windows bot

Unreviewed.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147828 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAttempt to fix the Windows bot
benjamin@webkit.org [Sat, 6 Apr 2013 02:40:13 +0000 (02:40 +0000)]
Attempt to fix the Windows bot

Unreviewed.

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:
r147825 removed the symbol for nullptr_t. Add it back.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147827 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRe-enable testing on the commit queue
rniwa@webkit.org [Sat, 6 Apr 2013 02:05:18 +0000 (02:05 +0000)]
Re-enable testing on the commit queue
https://bugs.webkit.org/show_bug.cgi?id=114078

Reviewed by Darin Adler.

Re-enabled the feature and the associated tests.

* Scripts/webkitpy/tool/bot/commitqueuetask.py:
(CommitQueueTask.run):
* Scripts/webkitpy/tool/bot/commitqueuetask_unittest.py:
(CommitQueueTaskTest._run_through_task):
* Scripts/webkitpy/tool/commands/queues_unittest.py:
(CommitQueueTest._mock_test_result):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147826 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
roger_fong@apple.com [Sat, 6 Apr 2013 01:22:51 +0000 (01:22 +0000)]
Build fix.

* JavaScriptCore.vcproj/JavaScriptCore/JavaScriptCoreExports.def:
* JavaScriptCore.vcxproj/JavaScriptCoreExportGenerator/JavaScriptCoreExports.def.in:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147825 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: VoiceOver can't press on items
cfleizach@apple.com [Sat, 6 Apr 2013 01:08:24 +0000 (01:08 +0000)]
AX: VoiceOver can't press on items
https://bugs.webkit.org/show_bug.cgi?id=114071

Reviewed by Tim Horton.

Source/WebCore:

The AXScrollToVisibleAction should not be used on earlier Mac versions because
it confuses VoiceOver.

Updated existing tests.

* accessibility/mac/WebAccessibilityObjectWrapperMac.mm:
(-[WebAccessibilityObjectWrapper accessibilityActionNames]):

LayoutTests:

* platform/mac-future/accessibility: Added.
* platform/mac-future/accessibility/press-action-is-first-expected.txt: Added.
* platform/mac/accessibility/press-action-is-first-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147824 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[WK2] --no-tiled-backing-store build fails because FloatPoint is not declared
commit-queue@webkit.org [Sat, 6 Apr 2013 00:49:26 +0000 (00:49 +0000)]
[WK2] --no-tiled-backing-store build fails because FloatPoint is not declared
https://bugs.webkit.org/show_bug.cgi?id=113618

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.

* WebProcess/Plugins/Plugin.h: Forward declared FloatPoint

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147823 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoStop building Objective-C bindings for the SVG DOM
andersca@apple.com [Sat, 6 Apr 2013 00:42:49 +0000 (00:42 +0000)]
Stop building Objective-C bindings for the SVG DOM
https://bugs.webkit.org/show_bug.cgi?id=114076

Reviewed by Geoffrey Garen.

The DOM SVG Objective-C bindings have never been exposed as API, and not building them cuts WebCore build by 10%.

Source/WebCore:

* Configurations/FeatureDefines.xcconfig:
* Configurations/WebCore.xcconfig:
* WebCore.exp.in:
* WebCore.xcodeproj/project.pbxproj:
* bindings/objc/DOM.mm:
(WebCore::createElementClassMap):
(kitClass):
* bindings/objc/DOMCSS.mm:
(kitClass):
* bindings/objc/DOMEvents.mm:
* bindings/objc/DOMSVG.h: Removed.
* bindings/objc/DOMSVGException.h: Removed.
* bindings/objc/DOMSVGPathSegInternal.mm: Removed.
* bindings/objc/ExceptionHandlers.mm:
* html/HTMLEmbedElement.idl:
* html/HTMLFrameElement.idl:
* html/HTMLIFrameElement.idl:
* html/HTMLObjectElement.idl:

Source/WebKit/mac:

* Configurations/FeatureDefines.xcconfig:
* MigrateHeaders.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147822 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
oliver@apple.com [Sat, 6 Apr 2013 00:07:46 +0000 (00:07 +0000)]
Build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147820 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoChange css1/basic/comments-expected.html to be a ref-test
benjamin@webkit.org [Sat, 6 Apr 2013 00:06:09 +0000 (00:06 +0000)]
Change css1/basic/comments-expected.html to be a ref-test
https://bugs.webkit.org/show_bug.cgi?id=113996

Patch by Benjamin Poulain <bpoulain@apple.com> on 2013-04-05
Reviewed by Jer Noble.

The test css1/basic/comments.html verifies the handling
of comments inside a CSS declaration.

The test is changed to a ref-test by simply defining the style
directly on each element on the reference.

* css1/basic/comments-expected.html: Added.
* platform/efl/css1/basic/comments-expected.png: Removed.
* platform/efl/css1/basic/comments-expected.txt: Removed.
* platform/gtk/css1/basic/comments-expected.txt: Removed.
* platform/mac/css1/basic/comments-expected.png: Removed.
* platform/mac/css1/basic/comments-expected.txt: Removed.
* platform/qt/css1/basic/comments-expected.png: Removed.
* platform/qt/css1/basic/comments-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147819 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnify the many and varied stack trace mechanisms, and make the result sane.
oliver@apple.com [Fri, 5 Apr 2013 23:53:12 +0000 (23:53 +0000)]
Unify the many and varied stack trace mechanisms, and make the result sane.
https://bugs.webkit.org/show_bug.cgi?id=114072

Reviewed by Filip Pizlo.

Source/JavaScriptCore:

Makes JSC::StackFrame record the bytecode offset and other necessary data
rather than requiring us to perform eager evaluation of the line number, etc.
Then remove most of the users of retrieveLastCaller, as most of them were
using it to create a stack trace in a fairly incomplete and inefficient way.

StackFrame now also has a couple of helpers to get the line and column info.

* API/JSContextRef.cpp:
(JSContextCreateBacktrace):
* bytecompiler/BytecodeGenerator.cpp:
(JSC::BytecodeGenerator::emitDebugHook):
* interpreter/Interpreter.cpp:
(JSC):
(JSC::Interpreter::dumpRegisters):
(JSC::Interpreter::unwindCallFrame):
(JSC::getBytecodeOffsetForCallFrame):
(JSC::getCallerInfo):
(JSC::StackFrame::line):
(JSC::StackFrame::column):
(JSC::StackFrame::expressionInfo):
(JSC::StackFrame::toString):
(JSC::Interpreter::getStackTrace):
(JSC::Interpreter::addStackTraceIfNecessary):
(JSC::Interpreter::retrieveCallerFromVMCode):
* interpreter/Interpreter.h:
(StackFrame):
(Interpreter):
* runtime/Error.cpp:
(JSC::throwError):
* runtime/JSGlobalData.h:
(JSC):
(JSGlobalData):
* runtime/JSGlobalObject.cpp:
(JSC::DynamicGlobalObjectScope::DynamicGlobalObjectScope):

Source/WebCore:

Now that we've fleshed out the StackFrames from Interpreter::getStackTrace
WebCore can just ask us for a stack trace rather than implementing its own
stack walking.

* bindings/js/ScriptCallStackFactory.cpp:
(WebCore::createScriptCallStack):
* inspector/ScriptCallFrame.cpp:
(WebCore::ScriptCallFrame::isEqual):
* inspector/ScriptCallFrame.h:
(ScriptCallFrame):
(WebCore::ScriptCallFrame::columnNumber):

Tools:

The commandline jsc executable no longer requires arguments, so
I've made run-jsc work without them.

* Scripts/run-jsc:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147818 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agotryCacheGetByID sets StructureStubInfo accessType to an incorrect value
mhahnenberg@apple.com [Fri, 5 Apr 2013 23:52:20 +0000 (23:52 +0000)]
tryCacheGetByID sets StructureStubInfo accessType to an incorrect value
https://bugs.webkit.org/show_bug.cgi?id=114068

Reviewed by Geoffrey Garen.

In the case where we have a non-Value cacheable property, we set the StructureStubInfo accessType to
get_by_id_self, but then we don't patch self and instead patch in a get_by_id_self_fail. This leads to
incorrect profiling data so when the DFG compiles the function, it uses a GetByOffset rather than a GetById,
which leads to loading a GetterSetter directly out of an object.

Source/JavaScriptCore:

* jit/JITStubs.cpp:
(JSC::tryCacheGetByID):
(JSC::DEFINE_STUB_FUNCTION):

LayoutTests:

* fast/js/jit-set-profiling-access-type-only-for-get-by-id-self-expected.txt: Added.
* fast/js/jit-set-profiling-access-type-only-for-get-by-id-self.html: Added.
* fast/js/script-tests/jit-set-profiling-access-type-only-for-get-by-id-self.js: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147816 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoTranslation of WebKitGTK+ for Malayalam (ml)
kov@webkit.org [Fri, 5 Apr 2013 23:50:15 +0000 (23:50 +0000)]
Translation of WebKitGTK+ for Malayalam (ml)
https://bugs.webkit.org/show_bug.cgi?id=113280

Patch by Ani Peter <peter.ani@gmail.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

* ml.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147814 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agowebkit translations for gujarati
kov@webkit.org [Fri, 5 Apr 2013 23:44:54 +0000 (23:44 +0000)]
webkit translations for gujarati
https://bugs.webkit.org/show_bug.cgi?id=113190

Patch by Sweta Kothari <swkothar@redhat.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

* gu.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147812 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[l10n] [hi] Updated WebKit Translation in Hindi [hi] language
kov@webkit.org [Fri, 5 Apr 2013 23:35:18 +0000 (23:35 +0000)]
[l10n] [hi] Updated WebKit Translation in Hindi [hi] language
https://bugs.webkit.org/show_bug.cgi?id=113180

Patch by Rajesh Ranjan <rajeshkajha@yahoo.com> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

* hi.po:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147811 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[BlackBerry] FatFingers Don't check the shadow tree for all elements.
commit-queue@webkit.org [Fri, 5 Apr 2013 23:22:31 +0000 (23:22 +0000)]
[BlackBerry] FatFingers Don't check the shadow tree for all elements.
https://bugs.webkit.org/show_bug.cgi?id=114066

Patch by Tiancheng Jiang <tijiang@rim.com> on 2013-04-05
Reviewed by Rob Buis.

BlackBerry PR 263078
Internally reviewed by Genevieve Mak.

No need to check shadow tree since sliders use touch events.

* WebKitSupport/FatFingers.cpp:
(BlackBerry::WebKit::FatFingers::isElementClickable):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147807 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoSetting a header or footer should cause a relayout
bdakin@apple.com [Fri, 5 Apr 2013 22:52:47 +0000 (22:52 +0000)]
Setting a header or footer should cause a relayout
https://bugs.webkit.org/show_bug.cgi?id=114070

Reviewed by Sam Weinig.

Mark the RenderView as needing layout in order to adjust everything for the new
header/footer.

* page/FrameView.cpp:
(WebCore::FrameView::setHeaderHeight):
(WebCore::FrameView::setFooterHeight):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147806 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAX: Make SVG Group containers accessible elements
cfleizach@apple.com [Fri, 5 Apr 2013 21:56:58 +0000 (21:56 +0000)]
AX: Make SVG Group containers accessible elements
https://bugs.webkit.org/show_bug.cgi?id=113939

Reviewed by Simon Fraser.

Source/WebCore:

SVG group containers are currently not exposed in the AX tree.
When an SVG element has a <title> child, that is not being used for the AX label.
When hit-testing, from Accessibility, SVG groups are never returned.

All these issues are fixed for Mac and iOS.
There are two tests because right now iOS skips all the top-level accessibility tests
due to fundamental architectural differences.

Tests: accessibility/svg-group-element-with-title.html
       platform/iphone-simulator/accessibility/svg-group-element-with-title.html

* accessibility/AccessibilityNodeObject.cpp:
(WebCore::AccessibilityNodeObject::alternativeText):
(WebCore::AccessibilityNodeObject::accessibilityDescription):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::accessibilityHitTest):
(WebCore::AccessibilityRenderObject::determineAccessibilityRole):
* accessibility/ios/WebAccessibilityObjectWrapperIOS.mm:
(-[WebAccessibilityObjectWrapper isSVGGroupElement]):
(-[WebAccessibilityObjectWrapper determineIsAccessibilityElement]):
(-[WebAccessibilityObjectWrapper accessibilityClickPoint]):
* rendering/HitTestRequest.h:
    Add a new option, AccessibilityHitTest, that will allow us to override normal behavior.
* rendering/svg/RenderSVGContainer.cpp:
(WebCore::RenderSVGContainer::nodeAtFloatPoint):
   Allow a SVG group to be the node at a point, for accessibility hit tests.

Tools:

Implement axController.elementAtPoint for iOS.
Implement a correct version of clickPoint for iOS.

* DumpRenderTree/ios/AccessibilityControllerIOS.mm:
(AccessibilityController::elementAtPoint):
* DumpRenderTree/ios/AccessibilityUIElementIOS.mm:
(AccessibilityUIElement::clickPointX):
(AccessibilityUIElement::clickPointY):

LayoutTests:

* accessibility/svg-group-element-with-title-expected.txt: Added.
* accessibility/svg-group-element-with-title.html: Added.
* platform/iphone-simulator/accessibility/svg-group-element-with-title-expected.txt: Added.
* platform/iphone-simulator/accessibility/svg-group-element-with-title.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147802 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebSpeech: event.elapsedTime is always 1364484608
cfleizach@apple.com [Fri, 5 Apr 2013 21:54:22 +0000 (21:54 +0000)]
WebSpeech: event.elapsedTime is always 1364484608
https://bugs.webkit.org/show_bug.cgi?id=114045

Reviewed by Tim Horton.

Source/WebCore:

We were calculating elapsed time incorrectly.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::fireEvent):

LayoutTests:

* platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-elapsed-time.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147801 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoWebSpeech: crash at WebCore::SpeechSynthesis::speak
cfleizach@apple.com [Fri, 5 Apr 2013 21:51:17 +0000 (21:51 +0000)]
WebSpeech: crash at WebCore::SpeechSynthesis::speak
https://bugs.webkit.org/show_bug.cgi?id=113937

Reviewed by Tim Horton.

Source/WebCore:

Protect against the case when invalid data is passed in.

Test: platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html

* Modules/speech/SpeechSynthesis.cpp:
(WebCore::SpeechSynthesis::speak):
* Modules/speech/SpeechSynthesisUtterance.cpp:
(WebCore::SpeechSynthesisUtterance::setVoice):

LayoutTests:

* platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance-expected.txt: Added.
* platform/mac/fast/speechsynthesis/speech-synthesis-crash-on-bad-utterance.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147800 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp
commit-queue@webkit.org [Fri, 5 Apr 2013 21:47:17 +0000 (21:47 +0000)]
[GTK] Change from PLATFORM(GTK) to USE(GLIB) in WTF/CurrentTime.cpp
https://bugs.webkit.org/show_bug.cgi?id=114061

Patch by Jesus Sanchez-Palencia <jesus.palencia@openbossa.org> on 2013-04-05
Reviewed by Gustavo Noronha Silva.

Now other ports using GLib can use the correct implementation
and not the fallback one without adding any other PLATFORM guards
here.

* wtf/CurrentTime.cpp:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147799 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoIf CallFrame::trueCallFrame() knows that it's about to read garbage instead of a...
fpizlo@apple.com [Fri, 5 Apr 2013 21:34:15 +0000 (21:34 +0000)]
If CallFrame::trueCallFrame() knows that it's about to read garbage instead of a valid CodeOrigin/InlineCallFrame, then it should give up and return 0 and all callers should be robust against this
https://bugs.webkit.org/show_bug.cgi?id=114062

Reviewed by Oliver Hunt.

* bytecode/CodeBlock.h:
(JSC::CodeBlock::canGetCodeOrigin):
(CodeBlock):
* interpreter/CallFrame.cpp:
(JSC::CallFrame::trueCallFrame):
* interpreter/Interpreter.cpp:
(JSC::Interpreter::getStackTrace):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147798 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoThrottle compositing layer flushes during page loading
antti@apple.com [Fri, 5 Apr 2013 21:19:56 +0000 (21:19 +0000)]
Throttle compositing layer flushes during page loading
https://bugs.webkit.org/show_bug.cgi?id=113786

Reviewed by Simon Fraser.

Page content can change rapidly during page loading triggering excessive layer flushes and repainting. We should avoid this unnecessary work.

This patch reduces layer flushes (and painting) during loading by 50-70% on many popular pages.

* loader/FrameLoader.cpp:
(WebCore::FrameLoader::loadProgressingStatusChanged):
* loader/FrameLoader.h:
* loader/ProgressTracker.cpp:
(WebCore::ProgressTracker::ProgressTracker):
(WebCore::ProgressTracker::reset):
(WebCore::ProgressTracker::progressStarted):
(WebCore::ProgressTracker::finalProgressComplete):
(WebCore::ProgressTracker::isLoadProgressing):
(WebCore::ProgressTracker::progressHeartbeatTimerFired):
* loader/ProgressTracker.h:

    Track if the document load is progressing. This is done with a heartbeat timer that checks every 100ms if we have received more than 1k of data.
    If four heartbeats pass without progress then we consider the load stalled.

* page/FrameView.cpp:
(WebCore::FrameView::resetDeferredRepaintDelay):

    Disable throttling temporary on user interaction so the page stays as responsive as possible even during loading.

(WebCore::FrameView::updateLayerFlushThrottling):

    Enable throttling when the load is progressing, disable otherwise.

* page/FrameView.h:
* platform/graphics/GraphicsLayer.h:
(WebCore::GraphicsLayer::canThrottleLayerFlush):
* platform/graphics/ca/GraphicsLayerCA.cpp:
(WebCore::GraphicsLayerCA::platformCALayerDidCreateTiles):
(WebCore::GraphicsLayerCA::canThrottleLayerFlush):

    Don't throttle if new tiles have been added by the tile controller. They may have stale content and need to be flushed immediately.

(WebCore::GraphicsLayerCA::noteLayerPropertyChanged):

    Set the new TilesAdded change flag.

* platform/graphics/ca/GraphicsLayerCA.h:
* rendering/RenderLayerBacking.cpp:
(WebCore::RenderLayerBacking::notifyFlushRequired):
* rendering/RenderLayerCompositor.cpp:
(WebCore::RenderLayerCompositor::RenderLayerCompositor):
(WebCore::RenderLayerCompositor::notifyFlushRequired):
(WebCore::RenderLayerCompositor::scheduleLayerFlushNow):

    Factor the actual flush scheduling to private function.

(WebCore::RenderLayerCompositor::scheduleLayerFlush):

    Mark the compositor for flush and return without flushing if the flushes are currently being throttled.

(WebCore::RenderLayerCompositor::flushPendingLayerChanges):

    After a flush, start the throtting timer (currently 0.5s) coalescing the subsequent flushes.

(WebCore::RenderLayerCompositor::didChangeVisibleRect):

    Do immediately flush if needed.

(WebCore::RenderLayerCompositor::setLayerFlushThrottlingEnabled):

    Flush immediately if disabled.

(WebCore::RenderLayerCompositor::disableLayerFlushThrottlingTemporarilyForInteraction):
(WebCore::RenderLayerCompositor::isThrottlingLayerFlushes):
(WebCore::RenderLayerCompositor::startLayerFlushTimerIfNeeded):
(WebCore::RenderLayerCompositor::layerFlushTimerFired):

    Flush when the timer fires timer.

* rendering/RenderLayerCompositor.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147797 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoClean the chromium bits of WebCore's WebDatabase
benjamin@webkit.org [Fri, 5 Apr 2013 20:52:10 +0000 (20:52 +0000)]
Clean the chromium bits of WebCore's WebDatabase
https://bugs.webkit.org/show_bug.cgi?id=114010

Reviewed by Ryosuke Niwa.

* Modules/webdatabase/AbstractDatabaseServer.h:
* Modules/webdatabase/ChangeVersionWrapper.cpp:
(WebCore::ChangeVersionWrapper::performPreflight):
(WebCore::ChangeVersionWrapper::performPostflight):
* Modules/webdatabase/Database.cpp:
* Modules/webdatabase/Database.h:
(Database):
* Modules/webdatabase/DatabaseBackend.cpp:
(WebCore::DatabaseBackend::openAndVerifyVersion):
* Modules/webdatabase/DatabaseBackendBase.cpp:
(WebCore::DoneCreatingDatabaseOnExitCaller::~DoneCreatingDatabaseOnExitCaller):
(WebCore::DatabaseBackendBase::performOpenAndVerify):
(WebCore::DatabaseBackendBase::getActualVersionForTransaction):
(WebCore::DatabaseBackendBase::incrementalVacuumIfNeeded):
* Modules/webdatabase/DatabaseBackendBase.h:
(DatabaseBackendBase):
* Modules/webdatabase/DatabaseBackendSync.cpp:
(WebCore::DatabaseBackendSync::openAndVerifyVersion):
* Modules/webdatabase/DatabaseContext.cpp:
(WebCore::DatabaseContext::databaseExceededQuota):
* Modules/webdatabase/DatabaseManager.cpp:
* Modules/webdatabase/DatabaseManager.h:
(DatabaseManager):
* Modules/webdatabase/DatabaseServer.cpp:
(WebCore::DatabaseServer::initialize):
(WebCore::DatabaseServer::setClient):
(WebCore::DatabaseServer::databaseDirectoryPath):
(WebCore::DatabaseServer::setDatabaseDirectoryPath):
(WebCore::DatabaseServer::openDatabase):
* Modules/webdatabase/DatabaseServer.h:
* Modules/webdatabase/DatabaseSync.cpp:
(WebCore::DatabaseSync::changeVersion):
* Modules/webdatabase/DatabaseTracker.cpp:
(WebCore::DatabaseTracker::canEstablishDatabase):
(WebCore::DatabaseTracker::retryCanEstablishDatabase):
* Modules/webdatabase/DatabaseTracker.h:
(WebCore):
(DatabaseTracker):
* Modules/webdatabase/SQLStatementBackend.cpp:
(WebCore::SQLStatementBackend::execute):
(WebCore::SQLStatementBackend::setDatabaseDeletedError):
(WebCore::SQLStatementBackend::setVersionMismatchedError):
(WebCore::SQLStatementBackend::setFailureDueToQuota):
* Modules/webdatabase/SQLStatementBackend.h:
(SQLStatementBackend):
* Modules/webdatabase/SQLTransaction.cpp:
(WebCore::SQLTransaction::deliverTransactionCallback):
(WebCore::SQLTransaction::deliverStatementCallback):
* Modules/webdatabase/SQLTransactionBackend.cpp:
(WebCore::SQLTransactionBackend::executeSQL):
(WebCore::SQLTransactionBackend::openTransactionAndPreflight):
(WebCore::SQLTransactionBackend::runCurrentStatementAndGetNextState):
(WebCore::SQLTransactionBackend::nextStateForCurrentStatementError):
(WebCore::SQLTransactionBackend::postflightAndCommit):
(WebCore::SQLTransactionBackend::acquireOriginLock):
(WebCore::SQLTransactionBackend::releaseOriginLockIfNeeded):
* Modules/webdatabase/SQLTransactionBackend.h:
(SQLTransactionBackend):
* Modules/webdatabase/SQLTransactionBackendSync.cpp:
(WebCore::SQLTransactionBackendSync::begin):
(WebCore::SQLTransactionBackendSync::commit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147796 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoMade USE(JSC) unconditional
ggaren@apple.com [Fri, 5 Apr 2013 20:44:20 +0000 (20:44 +0000)]
Made USE(JSC) unconditional
https://bugs.webkit.org/show_bug.cgi?id=114058

Reviewed by Anders Carlsson.

../JavaScriptCore:

* config.h:

../ThirdParty:

* gtest/include/gtest/internal/gtest-port.h:

../WebCore:

* Modules/webdatabase/Database.cpp:
* bindings/ScriptControllerBase.cpp:
(WebCore::ScriptController::executeIfJavaScriptURL):
* bindings/js/JavaScriptCallFrame.cpp:
* bindings/js/JavaScriptCallFrame.h:
* bindings/scripts/InFilesCompiler.pm:
(generateHeadersHeader):
* css/MediaQueryListListener.cpp:
(WebCore::MediaQueryListListener::queryChanged):
* dom/ContainerNode.cpp:
(WebCore::dispatchChildRemovalEvents):
* dom/EventListener.h:
(EventListener):
(WebCore::EventListener::visitJSFunction):
* dom/EventTarget.h:
(EventTarget):
(WebCore):
(WebCore::EventTarget::visitJSEventListeners):
* dom/Node.cpp:
* dom/Node.h:
* dom/ScriptExecutionContext.cpp:
(WebCore):
(WebCore::ScriptExecutionContext::globalData):
* dom/ScriptExecutionContext.h:
(ScriptExecutionContext):
* html/HTMLCanvasElement.cpp:
(WebCore::HTMLCanvasElement::createImageBuffer):
* html/HTMLImageLoader.cpp:
(WebCore::HTMLImageLoader::notifyFinished):
* inspector/InjectedScriptHost.h:
(InjectedScriptHost):
(WebCore::InjectedScriptHost::evaluateReturnsEvalFunction):
* inspector/InspectorInstrumentation.cpp:
(WebCore):
(WebCore::InspectorInstrumentation::didCommitLoadImpl):
* page/Frame.cpp:
* page/Settings.cpp:
(WebCore):
(WebCore::Settings::shouldRespectPriorityInCSSAttributeSetters):
* page/Settings.h:
(Settings):
* plugins/PluginView.cpp:
(WebCore::PluginView::start):
(WebCore::PluginView::stop):
(WebCore::PluginView::performRequest):
(WebCore::PluginView::npObject):
(WebCore):
(WebCore::PluginView::bindingInstance):
(WebCore::PluginView::privateBrowsingStateChanged):
* plugins/PluginView.h:
(PluginView):
* plugins/PluginViewBase.h:
(PluginViewBase):
(WebCore::PluginViewBase::scriptObject):
* plugins/PluginViewNone.cpp:
(WebCore):
(WebCore::PluginView::bindingInstance):
* plugins/qt/PluginViewQt.cpp:
(WebCore::PluginView::dispatchNPEvent):
(WebCore::PluginView::setNPWindowIfNeeded):
* xml/XMLHttpRequest.cpp:
(WebCore::XMLHttpRequest::dropProtection):

../WebKit/efl:

* ewk/ewk_frame.cpp:
(ewk_frame_script_execute):

../WebKit/qt:

* Api/qwebscriptworld.cpp:
(QWebScriptWorld::QWebScriptWorld):

../WebKit2:

* Shared/linux/WebMemorySamplerLinux.cpp:
(WebKit::WebMemorySampler::sampleWebKit):
* config.h:

../WTF:

* wtf/ThreadRestrictionVerifier.h:
(WTF):
* wtf/WTFThreadData.cpp:
(WTF::WTFThreadData::WTFThreadData):
(WTF::WTFThreadData::~WTFThreadData):
* wtf/WTFThreadData.h:
(WTFThreadData):
* wtf/text/StringImpl.cpp:
(WTF::StringImpl::~StringImpl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147795 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out http://trac.webkit.org/changeset/147729
fpizlo@apple.com [Fri, 5 Apr 2013 20:41:01 +0000 (20:41 +0000)]
Unreviewed, rolling out trac.webkit.org/changeset/147729

It's causing a bunch of breakage on some more strict compilers:
<inline asm>:1267:2: error: ambiguous instructions require an explicit suffix (could be 'ficomps', or 'ficompl')

* offlineasm/x86.rb:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147794 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed. More VS2010 solution makefile fixes.
roger_fong@apple.com [Fri, 5 Apr 2013 20:38:35 +0000 (20:38 +0000)]
Unreviewed. More VS2010 solution makefile fixes.
<rdar://problem/13588964>

* WTF.vcxproj/WTF.make:
* JavaScriptCore.vcxproj/JavaScriptCore.make:
* WebCore.vcxproj/WebCore.make:
* WebKit.vcxproj/WebKit.make:
* win/tools/WinTools.make:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147793 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] --no-tiled-backing-store build fails because of not used #if USE(ACCELERATED_CO...
commit-queue@webkit.org [Fri, 5 Apr 2013 20:29:44 +0000 (20:29 +0000)]
[EFL] --no-tiled-backing-store build fails because of not used #if USE(ACCELERATED_COMPOSITING)
https://bugs.webkit.org/show_bug.cgi?id=113627

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.

.:

* Source/cmake/OptionsEfl.cmake: Disabled 3D_GRAPHICS and WEB_GL when accelerated compositing is on

Source/WebCore:

       Wrapped code with #if USE(ACCELERATED_COMPOSITING) to make it compilable
       with --no-tiled-backing-store build option:
* page/animation/ImplicitAnimation.cpp:
(WebCore::ImplicitAnimation::animate):
* page/animation/KeyframeAnimation.cpp:
(WebCore::KeyframeAnimation::animate):
* platform/graphics/TextTrackRepresentation.cpp:
(NullTextTrackRepresentation):
* platform/graphics/TextTrackRepresentation.h:
(TextTrackRepresentation):
* testing/Internals.cpp:
(WebCore::Internals::resetToConsistentState):
(WebCore::Internals::setHeaderHeight):
(WebCore::Internals::setFooterHeight):

Source/WebKit2:

Wrapped code with #if USE(ACCELERATED_COMPOSITING) to make it compilable
with --no-tiled-backing-store build option:
* UIProcess/API/C/efl/WKView.cpp:
* UIProcess/API/efl/EvasGLContext.cpp:
* UIProcess/API/efl/EvasGLContext.h:
* UIProcess/API/efl/EvasGLSurface.cpp:
* UIProcess/API/efl/EvasGLSurface.h:
* UIProcess/API/efl/EwkView.cpp:
(EwkView::EwkView):
(EwkView::displayTimerFired):
(EwkView::takeSnapshot):
* UIProcess/API/efl/EwkView.h:
(WebKit):
(EwkView):
* UIProcess/API/efl/SnapshotImageGL.cpp:
* UIProcess/API/efl/SnapshotImageGL.h:
* UIProcess/PageViewportController.cpp:
* UIProcess/PageViewportController.h:
* UIProcess/efl/PageViewportControllerClientEfl.cpp:
* UIProcess/efl/ViewClientEfl.cpp:
(WebKit::ViewClientEfl::didChangeContentsSize):
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::didCommitLoad):
(WebKit::WebView::updateViewportSize):
(WebKit::WebView::didChangeViewportProperties):
(WebKit::WebView::pageDidRequestScroll):
(WebKit::WebView::didRenderFrame):
(WebKit::WebView::pageTransitionViewportReady):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147792 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoUnreviewed, rolling out r147773 and r147774.
rniwa@webkit.org [Fri, 5 Apr 2013 20:04:25 +0000 (20:04 +0000)]
Unreviewed, rolling out r147773 and r147774.
http://trac.webkit.org/changeset/147773
http://trac.webkit.org/changeset/147774
https://bugs.webkit.org/show_bug.cgi?id=114056

Causing some exceptions on AppEngine I don't understand
(Requested by rniwa on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2013-04-05

* QueueStatusServer/config/queues.py:
* QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
* QueueStatusServer/model/queues_unittest.py:
(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147791 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the remaining Chromium files from WebCore
rniwa@webkit.org [Fri, 5 Apr 2013 19:55:35 +0000 (19:55 +0000)]
Remove the remaining Chromium files from WebCore
https://bugs.webkit.org/show_bug.cgi?id=114055

Reviewed by Benjamin Poulain.

Removed.

* Resources/pagepopups/chromium: Removed.
* Resources/pagepopups/chromium/calendarPickerChromium.css: Removed.
* Resources/pagepopups/chromium/pickerCommonChromium.css: Removed.
* html/shadow/MediaControlsChromium.cpp: Removed.
* html/shadow/MediaControlsChromium.h: Removed.
* html/shadow/MediaControlsChromiumAndroid.cpp: Removed.
* html/shadow/MediaControlsChromiumAndroid.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147790 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoFixed run-bindings-tests by removing V8
ggaren@apple.com [Fri, 5 Apr 2013 19:49:20 +0000 (19:49 +0000)]
Fixed run-bindings-tests by removing V8
https://bugs.webkit.org/show_bug.cgi?id=114053

Reviewed by Benjamin Poulain.

* Scripts/run-bindings-tests:
(main):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147789 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Chromium code from WebCore/css
rniwa@webkit.org [Fri, 5 Apr 2013 19:48:12 +0000 (19:48 +0000)]
Remove Chromium code from WebCore/css
https://bugs.webkit.org/show_bug.cgi?id=114052

Reviewed by Benjamin Poulain.

Removed.

* css/mediaControlsChromium.css: Removed.
* css/mediaControlsChromiumAndroid.css: Removed.
* css/themeChromium.css: Removed.
* css/themeChromiumAndroid.css: Removed.
* css/themeChromiumLinux.css: Removed.
* css/themeChromiumSkia.css: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147788 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[GStreamer] Segfault when attempting to install missing plugins
commit-queue@webkit.org [Fri, 5 Apr 2013 19:45:03 +0000 (19:45 +0000)]
[GStreamer] Segfault when attempting to install missing plugins
https://bugs.webkit.org/show_bug.cgi?id=114046

gst_install_plugins_async expects a null terminated list, but we weren't
adding a null terminator.

Patch by Brendan Long <self@brendanlong.com> on 2013-04-05
Reviewed by Philippe Normand.

No new tests since this just fixes a segfault.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::handleMessage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147787 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove the chromium code for WebCore's indexeddb module
benjamin@webkit.org [Fri, 5 Apr 2013 19:40:18 +0000 (19:40 +0000)]
Remove the chromium code for WebCore's indexeddb module
https://bugs.webkit.org/show_bug.cgi?id=114004

Reviewed by Ryosuke Niwa.

* Modules/indexeddb/IDBBackingStore.cpp:
(WebCore::IDBBackingStore::IDBBackingStore):
* Modules/indexeddb/IDBDatabaseBackendImpl.cpp:
(WebCore::IDBDatabaseBackendImpl::openConnection):
(WebCore::IDBDatabaseBackendImpl::close):
* Modules/indexeddb/IDBFactoryBackendInterface.cpp:
* Modules/indexeddb/IDBTracing.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147786 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I...
ggaren@apple.com [Fri, 5 Apr 2013 19:36:19 +0000 (19:36 +0000)]
Removed a chunk of the v8 bindings.  Reviewed by Sam 'Anders Carlsson' Weinig.  I'm using a direct http commit to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147785 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I...
ggaren@apple.com [Fri, 5 Apr 2013 19:36:11 +0000 (19:36 +0000)]
Removed a chunk of the v8 bindings.  Reviewed by Sam 'Anders Carlsson' Weinig.  I'm using a direct http commit to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147784 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I...
ggaren@apple.com [Fri, 5 Apr 2013 19:34:17 +0000 (19:34 +0000)]
Removed a chunk of the v8 bindings.  Reviewed by Sam 'Anders Carlsson' Weinig.  I'm using a direct http commit to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147783 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I...
ggaren@apple.com [Fri, 5 Apr 2013 19:34:13 +0000 (19:34 +0000)]
Removed a chunk of the v8 bindings.  Reviewed by Sam 'Anders Carlsson' Weinig.  I'm using a direct http commit to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147782 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I...
ggaren@apple.com [Fri, 5 Apr 2013 19:34:10 +0000 (19:34 +0000)]
Removed a chunk of the v8 bindings.  Reviewed by Sam 'Anders Carlsson' Weinig.  I'm using a direct http commit to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147781 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I...
ggaren@apple.com [Fri, 5 Apr 2013 19:34:04 +0000 (19:34 +0000)]
Removed a chunk of the v8 bindings.  Reviewed by Sam 'Anders Carlsson' Weinig.  I'm using a direct http commit to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147780 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemoved a chunk of the v8 bindings. Reviewed by Sam 'Anders Carlsson' Weinig. I...
ggaren@apple.com [Fri, 5 Apr 2013 19:33:57 +0000 (19:33 +0000)]
Removed a chunk of the v8 bindings.  Reviewed by Sam 'Anders Carlsson' Weinig.  I'm using a direct http commit to reduce email traffic.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147779 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoCleanup after git svn left empty directories.
rniwa@webkit.org [Fri, 5 Apr 2013 19:30:42 +0000 (19:30 +0000)]
Cleanup after git svn left empty directories.

* loader/chromium: Removed.
* page/chromium: Removed.
* page/scrolling/chromium: Removed.
* plugins/chromium: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147778 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoActually delete platform/chromium.
rniwa@webkit.org [Fri, 5 Apr 2013 19:27:33 +0000 (19:27 +0000)]
Actually delete platform/chromium.

* platform/chromium: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147777 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL][WK2] --no-tiled-backing-store build fails because of not used #if USE(COORDINAT...
commit-queue@webkit.org [Fri, 5 Apr 2013 19:27:11 +0000 (19:27 +0000)]
[EFL][WK2] --no-tiled-backing-store build fails because of not used #if USE(COORDINATED_GRAPHICS)
https://bugs.webkit.org/show_bug.cgi?id=113629

Patch by Ed Bartosh <bartosh@gmail.com> on 2013-04-05
Reviewed by Simon Fraser.

Wrapped code related to coordinated graphics with #if USE(COORDINATED_GRAPHICS)
* UIProcess/API/CoordinatedGraphics/WKCoordinatedScene.cpp:
* UIProcess/efl/WebView.cpp:
(WebKit::WebView::initialize):
(WebKit):
(WebKit::WebView::paintToCairoSurface):
(WebKit::WebView::updateViewportSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147776 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Chromium code from WebCore/platform
rniwa@webkit.org [Fri, 5 Apr 2013 19:24:05 +0000 (19:24 +0000)]
Remove Chromium code from WebCore/platform
https://bugs.webkit.org/show_bug.cgi?id=114014

Reviewed by Anders Carlsson.

Removed.

* platform/audio/chromium: Removed.
* platform/audio/chromium/AudioBusChromium.cpp: Removed.
* platform/audio/chromium/AudioDestinationChromium.cpp: Removed.
* platform/audio/chromium/AudioDestinationChromium.h: Removed.
* platform/audio/chromium/FFTFrameOpenMAXDLAndroid.cpp: Removed.
* platform/graphics/FontPlatformData.h:
* platform/graphics/chromium: Removed.
* platform/graphics/chromium/AnimationTranslationUtil.cpp: Removed.
* platform/graphics/chromium/AnimationTranslationUtil.h: Removed.
* platform/graphics/chromium/Canvas2DLayerBridge.cpp: Removed.
* platform/graphics/chromium/Canvas2DLayerBridge.h: Removed.
* platform/graphics/chromium/Canvas2DLayerManager.cpp: Removed.
* platform/graphics/chromium/Canvas2DLayerManager.h: Removed.
* platform/graphics/chromium/CrossProcessFontLoading.h: Removed.
* platform/graphics/chromium/CrossProcessFontLoading.mm: Removed.
* platform/graphics/chromium/DeferredImageDecoder.cpp: Removed.
* platform/graphics/chromium/DeferredImageDecoder.h: Removed.
* platform/graphics/chromium/DiscardablePixelRef.cpp: Removed.
* platform/graphics/chromium/DiscardablePixelRef.h: Removed.
* platform/graphics/chromium/DrawingBufferChromium.cpp: Removed.
* platform/graphics/chromium/Extensions3DChromium.h: Removed.
* platform/graphics/chromium/FontCacheAndroid.cpp: Removed.
* platform/graphics/chromium/FontCacheChromiumLinux.cpp: Removed.
* platform/graphics/chromium/FontCacheChromiumWin.cpp: Removed.
* platform/graphics/chromium/FontChromiumWin.cpp: Removed.
* platform/graphics/chromium/FontPlatformData.h: Removed.
* platform/graphics/chromium/FontPlatformDataChromiumWin.cpp: Removed.
* platform/graphics/chromium/FontPlatformDataChromiumWin.h: Removed.
* platform/graphics/chromium/FontRenderStyle.h: Removed.
* platform/graphics/chromium/FontUtilsChromiumWin.cpp: Removed.
* platform/graphics/chromium/FontUtilsChromiumWin.h: Removed.
* platform/graphics/chromium/GlyphPageTreeNodeChromiumWin.cpp: Removed.
* platform/graphics/chromium/GraphicsLayerChromium.cpp: Removed.
* platform/graphics/chromium/GraphicsLayerChromium.h: Removed.
* platform/graphics/chromium/IconChromium.cpp: Removed.
* platform/graphics/chromium/IconChromiumAndroid.cpp: Removed.
* platform/graphics/chromium/ImageBufferDataSkia.h: Removed.
* platform/graphics/chromium/ImageChromium.cpp: Removed.
* platform/graphics/chromium/ImageDecodingStore.cpp: Removed.
* platform/graphics/chromium/ImageDecodingStore.h: Removed.
* platform/graphics/chromium/ImageFrameGenerator.cpp: Removed.
* platform/graphics/chromium/ImageFrameGenerator.h: Removed.
* platform/graphics/chromium/LayerPainterChromium.h: Removed.
* platform/graphics/chromium/LazyDecodingPixelRef.cpp: Removed.
* platform/graphics/chromium/LazyDecodingPixelRef.h: Removed.
* platform/graphics/chromium/MediaPlayerPrivateChromium.cpp: Removed.
* platform/graphics/chromium/MediaPlayerPrivateChromium.h: Removed.
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.cpp: Removed.
* platform/graphics/chromium/OpaqueRectTrackingContentLayerDelegate.h: Removed.
* platform/graphics/chromium/PlatformIcon.h: Removed.
* platform/graphics/chromium/ScaledImageFragment.cpp: Removed.
* platform/graphics/chromium/ScaledImageFragment.h: Removed.
* platform/graphics/chromium/SimpleFontDataChromiumWin.cpp: Removed.
* platform/graphics/chromium/SkSizeHash.h: Removed.
* platform/graphics/chromium/TextureUploader.h: Removed.
* platform/graphics/chromium/ThreadSafeDataTransport.cpp: Removed.
* platform/graphics/chromium/ThreadSafeDataTransport.h: Removed.
* platform/graphics/chromium/TransformSkMatrix44Conversions.cpp: Removed.
* platform/graphics/chromium/TransformSkMatrix44Conversions.h: Removed.
* platform/graphics/chromium/TransparencyWin.cpp: Removed.
* platform/graphics/chromium/TransparencyWin.h: Removed.
* platform/graphics/chromium/UniscribeHelper.cpp: Removed.
* platform/graphics/chromium/UniscribeHelper.h: Removed.
* platform/graphics/chromium/UniscribeHelperTextRun.cpp: Removed.
* platform/graphics/chromium/UniscribeHelperTextRun.h: Removed.
* platform/graphics/chromium/VDMXParser.cpp: Removed.
* platform/graphics/chromium/VDMXParser.h: Removed.
* platform/graphics/gpu/DrawingBuffer.cpp:
(WebCore):
* platform/graphics/gpu/SharedGraphicsContext3D.cpp:
(WebCore::SharedGraphicsContext3DImpl::getOrCreateContext):
* platform/mediastream/chromium: Removed.
* platform/mediastream/chromium/MediaStreamCenterChromium.cpp: Removed.
* platform/mediastream/chromium/MediaStreamCenterChromium.h: Removed.
* platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.cpp: Removed.
* platform/mediastream/chromium/RTCDTMFSenderHandlerChromium.h: Removed.
* platform/mediastream/chromium/RTCDataChannelHandlerChromium.cpp: Removed.
* platform/mediastream/chromium/RTCDataChannelHandlerChromium.h: Removed.
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.cpp: Removed.
* platform/mediastream/chromium/RTCPeerConnectionHandlerChromium.h: Removed.
* platform/network/chromium: Removed.
* platform/network/chromium/AuthenticationChallenge.h: Removed.
* platform/network/chromium/AuthenticationChallengeChromium.cpp: Removed.
* platform/network/chromium/BlobRegistryProxy.cpp: Removed.
* platform/network/chromium/BlobRegistryProxy.h: Removed.
* platform/network/chromium/CookieJarChromium.cpp: Removed.
* platform/network/chromium/DNSChromium.cpp: Removed.
* platform/network/chromium/ResourceError.h: Removed.
* platform/network/chromium/ResourceHandle.cpp: Removed.
* platform/network/chromium/ResourceHandleInternal.h: Removed.
* platform/network/chromium/ResourceRequest.cpp: Removed.
* platform/network/chromium/ResourceRequest.h: Removed.
* platform/network/chromium/ResourceResponse.cpp: Removed.
* platform/network/chromium/ResourceResponse.h: Removed.
* platform/network/chromium/SocketStreamError.h: Removed.
* platform/network/chromium/SocketStreamHandle.cpp: Removed.
* platform/network/chromium/SocketStreamHandle.h: Removed.
* platform/network/chromium/SocketStreamHandleInternal.h: Removed.
* platform/sql/chromium: Removed.
* platform/sql/chromium/SQLiteFileSystemChromium.cpp: Removed.
* platform/sql/chromium/SQLiteFileSystemChromiumPosix.cpp: Removed.
* platform/sql/chromium/SQLiteFileSystemChromiumWin.cpp: Removed.
* platform/text/chromium: Removed.
* platform/text/chromium/Hyphenation.cpp: Removed.
* platform/text/chromium/TextBreakIteratorInternalICUChromium.cpp: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147775 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoBuild fix.
rniwa@webkit.org [Fri, 5 Apr 2013 19:17:36 +0000 (19:17 +0000)]
Build fix.

* QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147774 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Chromium EWS bots from the queue status server
rniwa@webkit.org [Fri, 5 Apr 2013 19:08:49 +0000 (19:08 +0000)]
Remove Chromium EWS bots from the queue status server
https://bugs.webkit.org/show_bug.cgi?id=113988

Reviewed by Benjamin Poulain.

Removed Chromium EWS bots.

* QueueStatusServer/config/queues.py:
* QueueStatusServer/model/queues.py:
(Queue.short_name):
(Queue.display_name):
* QueueStatusServer/model/queues_unittest.py:
(QueueTest.test_short_name):
(QueueTest.test_display_name):
(QueueTest.test_name_with_underscores):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147773 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Chromium code from WebCore/workers
rniwa@webkit.org [Fri, 5 Apr 2013 18:57:07 +0000 (18:57 +0000)]
Remove Chromium code from WebCore/workers
https://bugs.webkit.org/show_bug.cgi?id=114050

Reviewed by Anders Carlsson.

Removed.

* workers/WorkerLoaderProxy.h:
(WorkerLoaderProxy):
* workers/chromium: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147772 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Chromium code from WebCore/storage
rniwa@webkit.org [Fri, 5 Apr 2013 18:54:50 +0000 (18:54 +0000)]
Remove Chromium code from WebCore/storage
https://bugs.webkit.org/show_bug.cgi?id=114049

Reviewed by Anders Carlsson.

Removed.

* storage/StorageNamespace.cpp:
* storage/chromium: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147771 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[SOUP] Remove unnecessary explicit keyword in SocketStreamError.h
commit-queue@webkit.org [Fri, 5 Apr 2013 18:42:21 +0000 (18:42 +0000)]
[SOUP] Remove unnecessary explicit keyword in SocketStreamError.h
https://bugs.webkit.org/show_bug.cgi?id=113913

Patch by Seokju Kwon <seokju.kwon@gmail.com> on 2013-04-05
Reviewed by Martin Robinson.

No new tests, just removing an unnecessary code.

* platform/network/soup/SocketStreamError.h:
(WebCore::SocketStreamError::SocketStreamError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147769 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[EFL] Enable indexed database
commit-queue@webkit.org [Fri, 5 Apr 2013 18:39:45 +0000 (18:39 +0000)]
[EFL] Enable indexed database
https://bugs.webkit.org/show_bug.cgi?id=107248

Patch by Rijubrata Bhaumik <rijubrata.bhaumik@intel.com> on 2013-04-05
Reviewed by Alexis Menard.

.:

* Source/cmake/OptionsEfl.cmake:

Tools:

* Scripts/webkitperl/FeatureList.pm:

LayoutTests:

* platform/efl-wk1/TestExpectations:
* platform/efl/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147768 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove vestiges of Chromium bits from watchlists.
dglazkov@chromium.org [Fri, 5 Apr 2013 18:35:04 +0000 (18:35 +0000)]
Remove vestiges of Chromium bits from watchlists.
https://bugs.webkit.org/show_bug.cgi?id=114047

Reviewed by Ryosuke Niwa.

* Scripts/webkitpy/common/config/watchlist: Removed vestiges.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147767 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove WTF_USE_GOOGLEURL-guarded code
commit-queue@webkit.org [Fri, 5 Apr 2013 18:18:49 +0000 (18:18 +0000)]
Remove WTF_USE_GOOGLEURL-guarded code
https://bugs.webkit.org/show_bug.cgi?id=114028

Patch by Zan Dobersek <zdobersek@igalia.com> on 2013-04-05
Reviewed by Ryosuke Niwa.

Source/WebCore:

The only remaining usage of the USE(GOOGLEURL) guards is in LinkHashChromium.cpp that will
get removed when purging the Source/WebCore/platform/chromium directory.

* config.h: Remove the define that was Chromium-specific.
* platform/KURL.cpp:
(WebCore):
(WebCore::KURL::reportMemoryUsage):
(WebCore::KURL::isSafeToSendToAnotherThread):
* platform/KURL.h:
(KURL):
* platform/KURLGoogle.cpp: Removed.
* platform/KURLGooglePrivate.h: Removed.

Source/WebKit/blackberry:

* WebCoreSupport/AboutDataUseFeatures.in: Remove GOOGLEURL from the list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147766 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[regression] Security: Heap-use-after-free in WebCore::RenderBlock::logicalRightOffse...
zoltan@webkit.org [Fri, 5 Apr 2013 18:13:17 +0000 (18:13 +0000)]
[regression] Security: Heap-use-after-free in WebCore::RenderBlock::logicalRightOffsetForLine
https://bugs.webkit.org/show_bug.cgi?id=111594

Patch by Bem Jones-Bey <bjonesbe@adobe.com> on 2013-04-05
Reviewed by David Hyatt.

Source/WebCore:

Swapping the bases was causing any floats in the right base to be
lost, so change the code so that it no longer swaps the bases.

Test: fast/ruby/float-object-doesnt-crash.html

* rendering/RenderRubyRun.cpp:
(WebCore::RenderRubyRun::removeChild): Don't swap the bases anymore.

LayoutTests:

Add test to verify that the use-after-free is fixed. Note that it will
only crash when run under a memory checking tool like ASAN.

* fast/ruby/float-object-doesnt-crash-expected.txt: Added.
* fast/ruby/float-object-doesnt-crash.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147765 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove dead code
andersca@apple.com [Fri, 5 Apr 2013 17:54:25 +0000 (17:54 +0000)]
Remove dead code
https://bugs.webkit.org/show_bug.cgi?id=114043

Reviewed by Beth Dakin.

* platform/PublicSuffix.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147762 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove dead Chromium code from WebCore/workers
andersca@apple.com [Fri, 5 Apr 2013 17:48:28 +0000 (17:48 +0000)]
Remove dead Chromium code from WebCore/workers
https://bugs.webkit.org/show_bug.cgi?id=114039

Reviewed by Antti Koivisto.

* workers/WorkerContext.cpp:
(WebCore::WorkerContext::importScripts):
* workers/WorkerLoaderProxy.h:
* workers/WorkerMessagingProxy.cpp:
(WebCore::WorkerContextProxy::create):
* workers/WorkerScriptLoader.cpp:
(WebCore::WorkerScriptLoader::WorkerScriptLoader):
(WebCore::WorkerScriptLoader::createResourceRequest):
* workers/WorkerScriptLoader.h:
* workers/WorkerThread.cpp:
(WebCore::WorkerThread::workerThread):
* workers/chromium/WorkerContextProxyChromium.cpp: Removed.
* workers/chromium/WorkerContextProxyChromium.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147761 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove Chromium code from WebCore/plugins
rniwa@webkit.org [Fri, 5 Apr 2013 17:44:22 +0000 (17:44 +0000)]
Remove Chromium code from WebCore/plugins
https://bugs.webkit.org/show_bug.cgi?id=114015

Reviewed by Andreas Kling.

Removed.

* plugins/chromium: Removed.
* plugins/chromium/PluginDataChromium.cpp: Removed.
* plugins/chromium/PluginDataChromium.h: Removed.
* plugins/chromium/PluginListBuilder.cpp: Removed.
* plugins/chromium/PluginListBuilder.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147760 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoASSERTION FAILED: m_repaintRect == renderer()->clippedOverflowRectForRepaint(renderer...
simon.fraser@apple.com [Fri, 5 Apr 2013 17:36:12 +0000 (17:36 +0000)]
ASSERTION FAILED: m_repaintRect == renderer()->clippedOverflowRectForRepaint(renderer()->containerForRepaint()) after r135816
https://bugs.webkit.org/show_bug.cgi?id=103432

Reviewed by Allan Sandfeld Jensen.

Remove optimization added in r99752 that attempted to avoid clip rect
updates for table cells. As the assertions show, this optimization
is not always correct, so remove it. Bug 108272 tracks adding it back in.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::RenderLayer):
(WebCore::RenderLayer::updateLayerPositionsAfterScroll): Remove m_canSkipRepaintRectsUpdateOnScroll
check when updating clip rects.
* rendering/RenderLayer.h: Remove the m_canSkipRepaintRectsUpdateOnScroll bit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147759 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[css exclusions] Dynamically removing shape-inside should cause relayout of child...
betravis@adobe.com [Fri, 5 Apr 2013 17:30:27 +0000 (17:30 +0000)]
[css exclusions] Dynamically removing shape-inside should cause relayout of child blocks' inline content
https://bugs.webkit.org/show_bug.cgi?id=111029

Reviewed by David Hyatt.

Source/WebCore:

Preserve a removed ExclusionShapeInsideInfo for one additional layout pass
so that it can notify descendant inline content to relayout. This patch adds
a new 'needsRemoval' boolean to ExclusionShapeInsideInfo, which is set when
a style change removes but does not replace a shape-inside. When determining
whether a block needs to relayout inline children, ExclusionShapeInsideInfos with
the needsRemoval boolean set are included, but at other times (such as during
inline layout), they are ignored.

Added tests to the existing dynamic shape testfile
fast/exclusions/shape-inside/shape-inside-dynamic-nested.html

* rendering/ExclusionShapeInsideInfo.h:
(WebCore::ExclusionShapeInsideInfo::setNeedsRemoval): Get/Set the
needsRemoval boolean.
(WebCore::ExclusionShapeInsideInfo::needsRemoval): Ditto.
(ExclusionShapeInsideInfo):
(WebCore::ExclusionShapeInsideInfo::ExclusionShapeInsideInfo):
Initialize the needsRemoval boolean.
* rendering/LayoutState.cpp:
(WebCore::LayoutState::LayoutState): Propagate removed shape insides
for layout correctly. You only need to track one at a time, and a
removed shape inside should not take precedence over a set shape-inside.
* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::updateExclusionShapeInsideInfoAfterStyleChange):
Set the ExclusionShapeInsideInfo needsRemoval boolean, rather than immediately
removing the info.
(WebCore::exclusionInfoRequiresRelayout): Account for the needsRemoval
boolean as another way of requiring relayout.
(WebCore::RenderBlock::updateRegionsAndExclusionsBeforeChildLayout):
Look up whether an ExclusionShapeInsideInfo has been removed.
(WebCore::RenderBlock::updateRegionsAndExclusionsAfterChildLayout):
Remove any ExclusionShapeInsides marked for removal after a layout pass.
(WebCore):
(WebCore::RenderBlock::layoutBlock): Call the new updateRegionsAndExclusions
Before/After methods.
* rendering/RenderBlock.h:
(WebCore::RenderBlock::exclusionShapeInsideInfo): Filter the result based
on whether it should include removed infos.
(RenderBlock):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutExclusionShapeInsideInfo): Ditto.
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
Same as RenderBlock::layoutBlock.
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock): Ditto.
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock): Ditto.

LayoutTests:

Test that removed shape-insides correctly cause relayout in their blocks'
inline content.

* fast/exclusions/shape-inside/shape-inside-dynamic-nested-expected.html:
* fast/exclusions/shape-inside/shape-inside-dynamic-nested.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147758 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAdd James Craig to the contributors list.
cfleizach@apple.com [Fri, 5 Apr 2013 17:28:10 +0000 (17:28 +0000)]
Add James Craig to the contributors list.

* Scripts/webkitpy/common/config/committers.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147757 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years ago[CSS Regions] Elements in a region should be assignable to a named flow
commit-queue@webkit.org [Fri, 5 Apr 2013 17:15:09 +0000 (17:15 +0000)]
[CSS Regions] Elements in a region should be assignable to a named flow
https://bugs.webkit.org/show_bug.cgi?id=74144

Patch by Mihai Maerean <mmaerean@adobe.com> on 2013-04-05
Reviewed by David Hyatt.

Source/WebCore:

DOM children of a region must not be rendered as children of the region, but can be collected in flow threads.

NodeRenderingContext::parentRenderer now creates the parent render flow thread if it doesn't exist.

Element::moveToFlowThreadIsNeeded is a virtual method that is overriden in PseudoElement to return false and
in SVGElement so only svg root elements can directly be collected by a render flow thread.

RenderObject::canDOMChildrenHaveRenderParent exists to optimize the code so nodes inside regions (and maybe
other types of renderers in the future) can still have renderers if they need to be in a flow thread while the
rest of renderers that can't have children skip the new instructions.

Tests: fast/regions/flow-body-in-html.html . To test the duplicate bug #103685.
       fast/regions/region-content-flown-into-region.html
       fast/regions/universal-selector-children-to-the-same-region.html . To test the duplicate bug #103685.

* dom/Element.cpp:
(WebCore::Element::moveToFlowThreadIsNeeded):
* dom/Element.h:
* dom/NodeRenderingContext.cpp:
(WebCore::NodeRenderingContext::parentRenderer): the renderer that will be the parent for this node's renderer.
In the case of RenderFlowThreads, it may need to create it.
(WebCore::NodeRenderingContext::shouldCreateRenderer): In a region, only the children that need to be in a flow
thread should have a renderer.
(WebCore::NodeRenderingContext::moveToFlowThreadIfNeeded):
(WebCore::NodeRenderingContext::moveToFlowThread):
* dom/NodeRenderingContext.h:
(NodeRenderingContext):
* dom/PseudoElement.h: pseudo-elements cannot be directly collected into a named flow.
* dom/Text.cpp:
(WebCore::Text::textRendererIsNeeded):
(WebCore::Text::updateTextRenderer): Because calling textRendererIsNeeded(NodeRenderingContext(...)) on a
non-const l-value NodeRenderingContext cannot be done on a temporary object on the stack.
* dom/Text.h:
* rendering/FlowThreadController.cpp:
(WebCore::FlowThreadController::isContentNodeRegisteredWithAnyNamedFlow):
* rendering/FlowThreadController.h:
* rendering/RenderObject.h:
(WebCore::RenderObject::canDOMChildrenHaveRenderParent): Even if this render object can't have render children,
the children in the DOM tree may have a render parent (that is different from this render object).
* rendering/RenderRegion.h:
* svg/SVGElement.cpp:
(WebCore::SVGElement::moveToFlowThreadIsNeeded): Allow only svg root elements to be directly collected by a
render flow thread.
* svg/SVGElement.h:
(SVGElement):

LayoutTests:

* fast/regions/flow-body-in-html-expected.txt: Added.
* fast/regions/flow-body-in-html.html: Added. To test the duplicate bug #103685.
* fast/regions/region-content-flown-into-region-expected.html: Added.
* fast/regions/region-content-flown-into-region.html: Added.
* fast/regions/universal-selector-children-to-the-same-region-expected.txt: Added.
* fast/regions/universal-selector-children-to-the-same-region.html: Added. To test the duplicate bug #103685.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147756 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoRemove more dead Chromium code from WTF
andersca@apple.com [Fri, 5 Apr 2013 16:51:39 +0000 (16:51 +0000)]
Remove more dead Chromium code from WTF
https://bugs.webkit.org/show_bug.cgi?id=114037

Reviewed by Allan Sandfeld Jensen.

* wtf/CurrentTime.cpp:
(WTF):
* wtf/DisallowCType.h:
* wtf/ExportMacros.h:
* wtf/MainThread.cpp:
* wtf/Platform.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147755 268f45cc-cd09-0410-ab3c-d52691b4dbfc

6 years agoAllow the Web Inspector to use WebSQL.
timothy@apple.com [Fri, 5 Apr 2013 16:40:31 +0000 (16:40 +0000)]
Allow the Web Inspector to use WebSQL.

This fixes an exception on load in the Safari Web Inspector.

https://webkit.org/b/114040
rdar://problem/13581422

Reviewed by Anders Carlsson.

Source/WebKit/mac:

* WebCoreSupport/WebInspectorClient.mm:
(-[WebInspectorWindowController webView:frame:exceededDatabaseQuotaForSecurityOrigin:database:]): Added.

Source/WebKit2:

* UIProcess/mac/WebInspectorProxyMac.mm:
(WebKit::exceededDatabaseQuota): Added.
(WebKit::WebInspectorProxy::platformCreateInspectorPage): Hook up exceededDatabaseQuota.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@147754 268f45cc-cd09-0410-ab3c-d52691b4dbfc