11 years ago Fixes a bug where Safari's find banner would be permanently hidden
timothy@apple.com [Thu, 14 Aug 2008 16:12:43 +0000 (16:12 +0000)]
    Fixes a bug where Safari's find banner would be permanently hidden
        when attaching or closing the Web Inspector while attached.


        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController close]):
        Carefully manipulate the WebFrameView's frame when closing to
        not assume the WebFrameView's frame fills the inspected WebView.
        (-[WebInspectorWindowController setAttachedWindowHeight:]):
        Carefully manipulate the WebFrameView's frame when docking to
        not assume the WebFrameView plus the Web Inspector WebViews fills
        the full inspected WebView.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35754 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-14 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Thu, 14 Aug 2008 15:07:41 +0000 (15:07 +0000)]
2008-08-14  Jan Michael Alonzo  <jmalonzo@webkit.org>

        partial Gtk build fix, not reviewed

        * platform/graphics/cairo/PatternCairo.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35753 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 14 Aug 2008 04:49:30 +0000 (04:49 +0000)]
2008-08-13  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlson.

        Fix style issue.

        * html/HTMLMediaElement.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35752 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Stephanie Lewis <slewis@apple.com>
slewis@apple.com [Thu, 14 Aug 2008 04:26:18 +0000 (04:26 +0000)]
2008-08-13  Stephanie Lewis  <slewis@apple.com>

        fix 64bit build

        * WebCoreSupport/WebInspectorClient.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35751 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2007-08-13 Geoffrey Garen <ggaren@apple.com>
ggaren@apple.com [Thu, 14 Aug 2008 03:43:57 +0000 (03:43 +0000)]
2007-08-13  Geoffrey Garen  <ggaren@apple.com>

        Reviewed by Oliver Hunt.

        Nixed a PIC branch from JSObject::getOwnPropertySlot, by forcing
        fillGetterProperty, which references a global function pointer,

        .2% SunSpider speedup, 4.3% access-nbody speedup, 8.7% speedup on a
        custom property access benchmark for objects with one property.

        * kjs/JSObject.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35750 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Thu, 14 Aug 2008 03:16:01 +0000 (03:16 +0000)]

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35749 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for Cairo, not reviewed. (exposed by gtk build slave)
zimmermann@webkit.org [Thu, 14 Aug 2008 03:06:01 +0000 (03:06 +0000)]
Build fix for Cairo, not reviewed. (exposed by gtk build slave)
Continue Erics build fixes, after the Image cleanup.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35747 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix for Qt, not reviewed.
zimmermann@webkit.org [Thu, 14 Aug 2008 02:38:16 +0000 (02:38 +0000)]
Build fix for Qt, not reviewed.
Don't declare eventuallyMarkAsParserCreated in a block wrapped by !USE_QXMLSTREAM.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35746 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBuild fix, not reviewed.
zimmermann@webkit.org [Thu, 14 Aug 2008 02:26:00 +0000 (02:26 +0000)]
Build fix, not reviewed.
Add ScriptElement.cpp to Gtk build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35745 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Eric.
zimmermann@webkit.org [Thu, 14 Aug 2008 02:22:35 +0000 (02:22 +0000)]
Reviewed by Eric.
Fixes: https://bugs.webkit.org/show_bug.cgi?id=20372

Refactor HTMLScriptElement's code into a common base class: ScriptElement.
SVGScriptElement will be converted to use ScriptElement in a follow-up patch.

This resolves code duplications and allows us to completly replace the old
SVGScriptElement (which doesn't use CachedScript, no dynamic injected scripts etc..)

As ScriptElement, doesn't actually inherit from Element, we may want to rename
it, though StyleElement uses the same naming convention, so I left it as is for now.
Eventually we'll rename both files in future.

No functional changes yet, as SVGScriptElement doesn't yet use the new base class.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35744 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Attempt to fix the Gtk build, no review.
eric@webkit.org [Thu, 14 Aug 2008 02:17:29 +0000 (02:17 +0000)]
    Attempt to fix the Gtk build, no review.

        I removed the bogus GraphicsContext::translatePoint() hack for Gtk in the process.

        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/qt/GradientQt.cpp:
        * platform/graphics/qt/GraphicsContextQt.cpp:
        * platform/gtk/RenderThemeGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35743 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Attempt to fix the windows build, not review.
eric@webkit.org [Thu, 14 Aug 2008 02:06:29 +0000 (02:06 +0000)]
    Attempt to fix the windows build, not review.

        * WebIconDatabase.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35742 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Attempt to fix the Windows build, no review.
eric@webkit.org [Thu, 14 Aug 2008 02:03:09 +0000 (02:03 +0000)]
    Attempt to fix the Windows build, no review.

        * platform/win/CursorWin.cpp:
        * platform/win/ScrollViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35741 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Attempt to fix the Windows build, no review.
eric@webkit.org [Thu, 14 Aug 2008 01:29:34 +0000 (01:29 +0000)]
    Attempt to fix the Windows build, no review.

        * platform/win/CursorWin.cpp:
        * platform/win/ScrollViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35740 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Attempt to fix the Qt build, no review.
eric@webkit.org [Thu, 14 Aug 2008 01:24:15 +0000 (01:24 +0000)]
    Attempt to fix the Qt build, no review.

        * platform/graphics/qt/ImageBufferQt.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35739 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Attempt to fix the Windows build, no review.
eric@webkit.org [Thu, 14 Aug 2008 01:21:34 +0000 (01:21 +0000)]
    Attempt to fix the Windows build, no review.

        * platform/graphics/win/ImageWin.cpp:
        * plugins/win/PluginViewWin.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35738 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Another attempt to fix the Qt build, no review.
eric@webkit.org [Thu, 14 Aug 2008 01:15:50 +0000 (01:15 +0000)]
    Another attempt to fix the Qt build, no review.

        * platform/graphics/qt/ImageQt.cpp:
        * platform/graphics/qt/StillImageQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35737 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago No review, build fix only.
eric@webkit.org [Thu, 14 Aug 2008 01:05:42 +0000 (01:05 +0000)]
    No review, build fix only.

        Fix mac build, due to change in new code since my patch was written.

        * svg/graphics/cg/SVGResourceMaskerCg.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35736 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix only, no review.
eric@webkit.org [Thu, 14 Aug 2008 00:59:20 +0000 (00:59 +0000)]
    Build fix only, no review.

        Attempt to fix the Qt build.

        * platform/graphics/qt/ImageBufferQt.cpp:
        * platform/graphics/qt/StillImageQt.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35735 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fix only, no review.
eric@webkit.org [Thu, 14 Aug 2008 00:42:54 +0000 (00:42 +0000)]
    Build fix only, no review.

        Attempt to fix the Qt build.

        * html/CanvasStyle.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35734 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam.
eric@webkit.org [Thu, 14 Aug 2008 00:30:04 +0000 (00:30 +0000)]
    Reviewed by Sam.

        Match HTML5 spec by throwing INVALID_STATE_ERR when
        createPattern is called and the HTMLImageElement is not
        yet done loading the image (!isComplete)

        Test: http/misc/canvas-pattern-from-incremental-image.html

        * html/CanvasRenderingContext2D.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35733 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Niko.
eric@webkit.org [Thu, 14 Aug 2008 00:29:50 +0000 (00:29 +0000)]
    Reviewed by Niko.

        Split out a Pattern class from CanvasPattern
        and remove all the Pattern-related #ifdefs
        (This will break non-mac platforms!  I will fix them.)

        * GNUmakefile.am:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * html/CanvasPattern.cpp:
        * html/CanvasPattern.h:
        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasRenderingContext2D.h:
        * html/HTMLCanvasElement.cpp:
        * html/HTMLCanvasElement.h:
        * loader/FrameLoader.cpp:
        * platform/graphics/GraphicsContext.h:
        * platform/graphics/cairo/GraphicsContextCairo.cpp:
        * platform/graphics/cg/GraphicsContextCG.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35732 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Niko.
eric@webkit.org [Thu, 14 Aug 2008 00:29:26 +0000 (00:29 +0000)]
    Reviewed by Niko.

        Make Images RefCounted (and clean up callers)

        * editing/DeleteButtonController.cpp:
        * loader/CachedImage.cpp:
        * loader/CachedImage.h:
        * loader/icon/IconRecord.cpp:
        * loader/icon/IconRecord.h:
        * platform/graphics/BitmapImage.h:
        * platform/graphics/GeneratedImage.h:
        * platform/graphics/Gradient.cpp:
        * platform/graphics/Gradient.h:
        * platform/graphics/Image.cpp:
        * platform/graphics/Image.h:
        * platform/graphics/ImageBuffer.h:
        * platform/graphics/cairo/ImageBufferCairo.cpp:
        * platform/graphics/cg/ImageBufferCG.cpp:
        * platform/graphics/cg/PDFDocumentImage.h:
        * platform/graphics/gtk/ImageGtk.cpp:
        * platform/graphics/mac/ImageMac.mm:
        * rendering/RenderImage.cpp:
        * rendering/RenderLayer.cpp:
        * svg/graphics/SVGImage.cpp:
        * svg/graphics/SVGImage.h:
        * svg/graphics/cairo/SVGPaintServerPatternCairo.cpp:
        * svg/graphics/cairo/SVGResourceMaskerCairo.cpp:
        * svg/graphics/cg/SVGPaintServerPatternCg.cpp:
        * svg/graphics/cg/SVGResourceMaskerCg.mm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35731 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam.
eric@webkit.org [Thu, 14 Aug 2008 00:28:51 +0000 (00:28 +0000)]
    Reviewed by Sam.

        Remove #ifdefs from CanvasStyle by using platform/Color.h

        There are some down-sides to this commit.
        This commit limits us to 255 levels of grey for calls like:
        context.setStrokeStyle(.37, 1.0)
        previously CG might have used up to 32bits to store the grey level
        Since setStrokeStyle is not part of HTML5, I don't suspect the web will notice.

        Likewise, setStrokeStyle/setFillStyle calls which used float colors are now limited
        to RGBA32 (like all the rest of colors in WebCore), thus:
        context.setStrokStyle(.37, .24, .456, .99) will now have the same precision as:
        context.strokeStyle = "rgba(.37, .24, .456, .99)", which is to say RGBA32

        If this is a problem for Dashboard, we can either roll out this commit
        or add a beefier Color abstraction, which can be used internally by GraphicsContext
        when keeping state, and then GraphicsContext can grow some additional set* routines
        for setting the a grey/float/whatever fill and stroke.

        * html/CanvasRenderingContext2D.cpp:
        * html/CanvasStyle.cpp:
        * html/CanvasStyle.h:
        * platform/graphics/Color.cpp:
        * platform/graphics/Color.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35730 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
adele@apple.com [Wed, 13 Aug 2008 23:50:41 +0000 (23:50 +0000)]

2008-08-13  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson.

        Fix for <rdar://problem/6137931>
        Remove all parameters from the MIME type before checking with the MIME type registry

        Tests: media/video-source-type-params.html

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::pickMedia): only pass the portion before the first ';'
        to isSupportedMediaMIMEType()


2008-08-13  Eric Carlson  <eric.carlson@apple.com>

        Reviewed by Adele Peterson.

        Add test case for parameters on a <source> element 'type' attribute.

        * media/video-source-type-params-expected.txt: Added.
        * media/video-source-type-params.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35729 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Beth Dakin <bdakin@apple.com>
bdakin@apple.com [Wed, 13 Aug 2008 21:36:15 +0000 (21:36 +0000)]
2008-08-13  Beth Dakin  <bdakin@apple.com>

        Reviewed by Sam Weinig.

        Fix for <rdar://problem/6141345>

        This patch refines findString and markAllMatchesForText functions'
        interactions with disconnected frames. They no longer rely on
        knowing where a range is relative to the visible region and work
        with disconnected frames that contain frames.

        * editing/Editor.cpp:
        (WebCore::Editor::insideVisibleArea): Now returns a bool instead of
        the visiblity enum.
        (WebCore::Editor::firstVisibleRange): This now returns the very
        first visible range in the document. It's no longer dependent on
        searching forward.
        (WebCore::Editor::lastVisibleRange): This now returns the very last
        visible range in the document. It's no longer dependent on
        searching backwards.
        (WebCore::Editor::nextVisibleRange): This returns the next visible
        range in the appropriate direction from the current range.
        * editing/Editor.h:
        * page/Frame.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35728 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agowx build fix for case-sensitive platforms, like Linux.
kevino@webkit.org [Wed, 13 Aug 2008 20:07:16 +0000 (20:07 +0000)]
wx build fix for case-sensitive platforms, like Linux.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35727 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Alp Toker <alp@nuanti.com>
jmalonzo@webkit.org [Wed, 13 Aug 2008 20:00:51 +0000 (20:00 +0000)]
2008-08-13  Alp Toker  <alp@nuanti.com>

        Reviewed by Eric Seidel.

        WTF::initializeThreading() fails if threading is already initialized

        Fix threading initialization logic to support cases where
        g_thread_init() has already been called elsewhere.

        Resolves database-related crashers reported in several applications.

        * wtf/ThreadingGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35726 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Marco Barisione <marco.barisione@collabora.co.uk>
jmalonzo@webkit.org [Wed, 13 Aug 2008 19:56:20 +0000 (19:56 +0000)]
2008-08-13  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Holger Freyther.

        [GTK] PlatformScreenGtk is unimplemented

        Original patch by Christian Dywan.

        * platform/gtk/PlatformScreenGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35725 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 13 Aug 2008 19:42:08 +0000 (19:42 +0000)]
2008-08-13  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Holger Freyther.

        SharedTimerGtk should use G_PRIORITY_DEFAULT_IDLE for g_idle_add

        g_idle_add is the same as g_idle_add_full with a priority of
        G_PRIORITY_DEFAULT_IDLE, so we can safely use that.

        * platform/gtk/SharedTimerGtk.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35724 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
adachan@apple.com [Wed, 13 Aug 2008 19:03:27 +0000 (19:03 +0000)]
    Implemented DOMHTMLElement::idName() and WebFrame::frameElement().
        Added IWebFrame::paintDocumentRectToContext() so we can paint a frame's
        content into a device context.  Changed WebView::paintDocumentRectToContext()
        to call that WebFrame method.

        Reviewed by Adam Roben.

        * DOMHTMLClasses.cpp:
        * Interfaces/IWebFramePrivate.idl:
        * WebFrame.cpp:
        * WebFrame.h:
        * WebView.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35723 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRemember the docked state of the Web Inspector, so it can be reopened docked if it...
timothy@apple.com [Wed, 13 Aug 2008 18:11:01 +0000 (18:11 +0000)]
Remember the docked state of the Web Inspector, so it can be reopened docked if it was last docked.


2008-08-13  Timothy Hatcher  <timothy@apple.com>

        Changed the InspectorController so it can be notified when the
        attached state of the Inspector changes in WebKit.

        Reviewed by Kevin McCullough.

        * WebCore.base.exp: Updated the symbol for setWindowVisible.
        * page/InspectorController.cpp:
        (WebCore::InspectorController::setWindowVisible): Added an attached argument,
        that defaults to false.Call setAttachedWindow with the attached argument.
        (WebCore::InspectorController::setAttachedWindow): Call the script version
        of setAttachedWindow.
        * page/InspectorController.h:
        * page/inspector/inspector.js:
        (WebInspector.setAttachedWindow): Set the attached property.


2008-08-13  Timothy Hatcher  <timothy@apple.com>

        Remember the docked state of the Web Inspector, so it can be
        reopened docked if it was last docked.


        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController init]): Initialize _shouldAttach
        to the value stored in the user defaults. If there has never
        been a value stored, default to being attached.
        (-[WebInspectorWindowController showWindow:]): Pass the attached
        state to InspectorController::setWindowVisible.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35722 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove the Inspector's WebView for the view hierarchy when closed
timothy@apple.com [Wed, 13 Aug 2008 18:10:53 +0000 (18:10 +0000)]
    Remove the Inspector's WebView for the view hierarchy when closed
        while attached. This prevents it from showing in the background
        while the page changes.

        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController close:]): Call removeFromSuperview
        on the Inspector's WebView if it isn't attached, so it will not
        be visible when navigating pages while closed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35721 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Added a close button to the Inspector's toolbar when docked.
timothy@apple.com [Wed, 13 Aug 2008 18:10:45 +0000 (18:10 +0000)]
    Added a close button to the Inspector's toolbar when docked.


        Reviewed by Kevin McCullough.

        * page/InspectorController.cpp:
        (WebCore::closeWindow): Call InspectorController::closeWindow.
        Added closeWindow to the script class.
        * page/InspectorController.h:
        * page/inspector/Images/closeButtons.png: Added.
        * page/inspector/inspector.css: Added and changed styles.
        * page/inspector/inspector.html: Added the close button.
        * page/inspector/inspector.js:
        (WebInspector.loaded): Added click event listener to the close button.
        (WebInspector.close): Call InspectorController.closeWindow.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35720 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMake the docked Web Inspector resizable.
timothy@apple.com [Wed, 13 Aug 2008 18:10:36 +0000 (18:10 +0000)]
Make the docked Web Inspector resizable.


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Make the docked Web Inspector resizable. This is the cross platform
        portion of the code. Each InspectorClient needs to implement the
        real resize code.


        Reviewed by Kevin McCullough.

        * loader/EmptyClients.h: Added an empty setAttachedWindowHeight.
        * page/InspectorClient.h: Added setAttachedWindowHeight.
        * page/InspectorController.cpp:
        (WebCore::setAttachedWindowHeight): Call setAttachedWindowHeight
        on the InspectorController.
        (WebCore::InspectorController::setAttachedWindowHeight): Call
        setAttachedWindowHeight on the client.
        Added setAttachedWindowHeight to the script class.
        * page/InspectorController.h:
        * page/inspector/inspector.css: Make the cursor on the toolbar be
        row-resize when docked.
        * page/inspector/inspector.js:
        (WebInspector.loaded): Always add the toolbarDragStart event listener.
        (WebInspector.toolbarDragStart): Return early if we are not attached
        and not on Leopard. Call WebInspector.elementDragStart.
        (WebInspector.toolbarDragEnd): Call WebInspector.elementDragEnd.
        (WebInspector.toolbarDrag): When attached call setAttachedWindowHeight,
        otherwise call moveByUnrestricted.


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Add a stub for InspectorClient::setAttachedWindowHeight.

        * WebCoreSupport/InspectorClientGtk.cpp:
        Call notImplemented().
        * WebCoreSupport/InspectorClientGtk.h:


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Make the docked Web Inspector resizable.


        Reviewed by Kevin McCullough.

        * WebCoreSupport/WebInspectorClient.h:
        * WebCoreSupport/WebInspectorClient.mm:
        (WebInspectorClient::setAttachedWindowHeight): Call setAttachedWindowHeight:
        on the WebInspectorWindowController.
        (-[WebInspectorWindowController showWindow:]): Call setAttachedWindowHeight:.
        (-[WebInspectorWindowController setAttachedWindowHeight:]): Moved code
        from showWindow: and generalized to allow being called multiple times.
        Remembers the last height passed, which is used by showWindow: the next
        time the Inspector attaches.


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Add a stub for InspectorClient::setAttachedWindowHeight.

        * WebCoreSupport/InspectorClientQt.cpp:
        Call notImplemented().
        * WebCoreSupport/InspectorClientQt.h:


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Add a stub for InspectorClient::setAttachedWindowHeight.

        * WebCoreSupport/WebInspectorClient.cpp:
        (WebInspectorClient::setAttachedWindowHeight): Add a FIXME to implement this.
        * WebCoreSupport/WebInspectorClient.h:


2008-08-12  Timothy Hatcher  <timothy@apple.com>

        Add a stub for InspectorClient::setAttachedWindowHeight.

        * WebKitSupport/InspectorClientWx.cpp:
        Call notImplemented().
        * WebKitSupport/InspectorClientWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35719 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 14:32:16 +0000 (14:32 +0000)]
2008-08-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Use full-page zoom in QtLauncher.

        * QtLauncher/main.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35718 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 14:32:02 +0000 (14:32 +0000)]
2008-08-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Fix linking with QtWebKit.

        * Api/qwebframe.h: remove non-existing function/property.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35717 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Wed, 13 Aug 2008 13:43:34 +0000 (13:43 +0000)]

    2008-08-13  Simon Hausmann  <hausmann@webkit.org>

            Reviewed by Holger.

            Initialize m_zoomsTextOnly in the Settings constructor.


    2008-08-13  Simon Hausmann  <hausmann@webkit.org>

            Reviewed by Holger.

            Based on patch by Siraj razick <siraj.razick@collabora.co.uk>


            Added functions to get/set the zoom factor.

            Added a QWebFrame/QWebView::zoomFactor as well as a boolean
            ZoomTextOnly attribute in QWebSettings.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35716 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Removing http/tests/xmlhttprequest/readystatechange.html from Windows skipped...
ap@webkit.org [Wed, 13 Aug 2008 13:33:03 +0000 (13:33 +0000)]
    Removing http/tests/xmlhttprequest/readystatechange.html from Windows skipped list -
        this test hasn't been failing locally for a long time.

        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35715 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Brad Hughes <bhughes@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 13:31:11 +0000 (13:31 +0000)]
2008-08-13  Brad Hughes <bhughes@trolltech.com>

        Reviewed by Simon.

        Fix compiling of QtWebKit in release mode with the Intel C++ Compiler for Linux

        The latest upgrade of the intel compiler allows us to compile all of
        Qt with optimizations enabled (yay!).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35714 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Prasanth Ullattil <prasanth.ullattil@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 13:24:56 +0000 (13:24 +0000)]
2008-08-13  Prasanth Ullattil  <prasanth.ullattil@trolltech.com>

        Reviewed by Simon.

        Fix QtWebKit not displaying content on 403 HTTP responses

        Just like with 404 responses also display content with 403, as
        used by http://audiio.ejamming.proteus-tech.com/audiio/profile/original_signup/

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35713 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hausmann@webkit.org [Wed, 13 Aug 2008 13:16:15 +0000 (13:16 +0000)]

    2008-08-13  Simon Hausmann  <hausmann@webkit.org>

            Reviewed by Holger.

            Qt part of https://bugs.webkit.org/show_bug.cgi?id=18994

            Make the formatting of String::format() locale independent through the use of QString::vsprintf.


    2008-08-13  Simon Hausmann  <hausmann@webkit.org>

            Reviewed by Holger.

            Adjusted the length-list-parser layout test to compensate for the subtle difference of
            dropping a sign for a "negative zero" as a result of the QString::vsprintf use.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35712 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 13 Aug 2008 12:07:50 +0000 (12:07 +0000)]
2008-08-13  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Holger.

        Revert r31585 and disable http tests for the Qt build again unless
        explicitly enabled.

        Running the http tests unfortunately currently still triggers
        failures in non-http tests due to side-effects. Disable them by default for
        now, for more reliable results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35711 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 13 Aug 2008 12:02:00 +0000 (12:02 +0000)]
2008-08-13  Simon Hausmann  <hausmann@webkit.org>

        Reviewed by Lars.

        Fix QWebFrame::setHtml() not setting the new contents immediately.

        Added a setter to the DocumentLoader to toggle the deferred loading of the main
        resource when it comes from substitute data.

        Disable deferred loading of the main resource when we have valid substitute data,
        as used by QWebFrame::setHtml.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35710 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Simon Hausmann <hausmann@webkit.org>
hausmann@webkit.org [Wed, 13 Aug 2008 11:51:53 +0000 (11:51 +0000)]
2008-08-13  Simon Hausmann  <hausmann@webkit.org>

        Rubber-stamped by Holger.

        Fix QWebPage::isModified().

        isModified() would return true after loading a new page or it would continue to
        return true after undoing modifications. Fix this by eliminating the
        QWebPagePrivate::modified variable and use the undoStack's canUndo() property


git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35709 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 David Boddie <dboddie@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 11:38:02 +0000 (11:38 +0000)]
2008-08-13  David Boddie  <dboddie@trolltech.com>

        Reviewed by Simon.

        Updated docs with the signal emission behavior of urlChanged()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35708 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Ariya Hidayat <ariya.hidayat@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 11:35:48 +0000 (11:35 +0000)]
2008-08-13  Ariya Hidayat  <ariya.hidayat@trolltech.com>

        Reviewed by Simon.

        Fix Ctrl+Y to work again when editing text in contextEditable mode.

        This fixes regression in LayoutTests/editing/pasteboard/emacs-cntl-y-001.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35707 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSpeculative GTK build fix.
mrowe@apple.com [Wed, 13 Aug 2008 09:58:32 +0000 (09:58 +0000)]
Speculative GTK build fix.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35706 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-13 Thiago Macieira <tjmaciei@trolltech.com>
hausmann@webkit.org [Wed, 13 Aug 2008 09:11:23 +0000 (09:11 +0000)]
2008-08-13  Thiago Macieira  <tjmaciei@trolltech.com>

        Reviewed by Simon.

        Fix encoding of [ and ] in the host part of the URL

        Until QUrl is fixed (making QUrl's tolerant parser more tolerant), we have to
        add this workaround to the QUrl <> WebCore::KURL conversion operator so that it
        doesn't encode [ and ] when they are found in the host part. That is, the
        following URL:
        is valid and should not be reencoded to:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35705 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-12 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 13 Aug 2008 04:35:37 +0000 (04:35 +0000)]
2008-08-12  Sam Weinig  <sam@webkit.org>

        Reviewed by Anders Carlsson.

        * platform/mac/Skipped: Add fast/dom/cssTarget-crash.html to the skipped list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35704 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd peephole optimisation to 'op_not... jfalse...' (eg. if(!...) )
oliver@apple.com [Wed, 13 Aug 2008 03:17:19 +0000 (03:17 +0000)]
Add peephole optimisation to 'op_not... jfalse...' (eg. if(!...) )

Reviewed by Geoff Garen

This is a very slight win in sunspider, and a fairly substantial win
in hot code that does if(!...), etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35703 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed.
zimmermann@webkit.org [Tue, 12 Aug 2008 22:49:16 +0000 (22:49 +0000)]
Not reviewed.

Revert the last SVGLineElement commit. It's not needed, the first run on buildbot showed them as failures
the next build doesn't complain anymore (this was before adjusting the offsets.) No idea what's going on,
but if it's fixed I'm happy.

While I'm at it, regenerate struct-image-02-b.svg (invisible differences) to have a clean baseline.
All SVG pixel test results are accurate on Leopard now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35702 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. The last SVGLineElement* fix attempt, fixed 4/8 failing tests.
zimmermann@webkit.org [Tue, 12 Aug 2008 22:26:49 +0000 (22:26 +0000)]
Not reviewed. The last SVGLineElement* fix attempt, fixed 4/8 failing tests.
Trying two variations in two tests to find out the right offset to make the other four tests work on Tiger.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35701 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber stamped by Eric.
zimmermann@webkit.org [Tue, 12 Aug 2008 22:18:42 +0000 (22:18 +0000)]
Rubber stamped by Eric.
Add new dynamic-update layout tests covering SVGRectElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35700 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Trying to modify mouseevent target location, to work around known CG...
zimmermann@webkit.org [Tue, 12 Aug 2008 22:13:25 +0000 (22:13 +0000)]
Not reviewed. Trying to modify mouseevent target location, to work around known CG/Tiger hit test problem.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35699 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Sam.
zimmermann@webkit.org [Tue, 12 Aug 2008 21:59:54 +0000 (21:59 +0000)]
Reviewed by Sam.
Forgot to include these in my last commit.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35698 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Tue, 12 Aug 2008 21:49:07 +0000 (21:49 +0000)]

2008-08-12  Mihnea Ovidenie  <mihnea@adobe.com>

        Fix for https://bugs.webkit.org/show_bug.cgi?id=19891
        Broken HTML object elements cause de-reference of pointer to freed memory.
        If we fail to load an image for an object tag and we no longer believe the object tag points at
        an image, then clear m_imageLoader in the HTMLObjectElement so that we attempt to render the
        fall back content.

        Reviewed by Dave Hyatt and Alexey Proskuryakov.

        Test: http/tests/misc/object-image-error-with-onload.html

        * html/HTMLObjectElement.cpp:
        * page/Frame.cpp:


2008-08-12  Mihnea Ovidenie  <mihnea@adobe.com>

        Test for https://bugs.webkit.org/show_bug.cgi?id=19891
        Broken HTML object elements cause de-reference of pointer to freed memory.

        Reviewed by Dave Hyatt and Alexey Proskuryakov.

        * http/tests/misc/object-image-error-with-onload-expected.txt: Added.
        * http/tests/misc/object-image-error-with-onload.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35697 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Eric.
zimmermann@webkit.org [Tue, 12 Aug 2008 21:46:14 +0000 (21:46 +0000)]
Reviewed by Eric.

Fix typo in most files: "mesage" -> "message".
Remove unused code in SVGTestCase.js

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35696 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber stamped by Eric.
zimmermann@webkit.org [Tue, 12 Aug 2008 21:18:19 +0000 (21:18 +0000)]
Rubber stamped by Eric.

Add new dynamic-update layout tests covering SVGPatternElement.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35695 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Dave.
zimmermann@webkit.org [Tue, 12 Aug 2008 21:11:17 +0000 (21:11 +0000)]
Reviewed by Dave.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=19798
Masks are translated, and the mask images are swapped on the y-axis.

Turned out that http://trac.webkit.org/changeset/31830/trunk/WebCore/svg/graphics/cg/SVGResourceMaskerCg.mm
is guilty. GraphicsContext::clipToImageBuffer() does some extra transformations that SVGResourcesMaskerCg does not want.

Long term goal is to remove the SVGResource*/SVGPaintServer* classes anyway, so it's okay to duplicate
the "clip to image buffer" functionality, in the CG specific SVGResourceMaskerCg class - as it was before.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35694 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Sam.
zimmermann@webkit.org [Tue, 12 Aug 2008 21:05:19 +0000 (21:05 +0000)]
Reviewed by Sam.

Speculative fix for hit testing problems in dynamic-updates/SVGLineElement* on Tiger.
Supposed to fix the hanging tests on the buildbot.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35693 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-12 Sam Weinig <sam@webkit.org>
weinig@apple.com [Tue, 12 Aug 2008 21:00:13 +0000 (21:00 +0000)]
2008-08-12  Sam Weinig  <sam@webkit.org>

        * fast/dom/Window/window-properties-expected.txt: Update results.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35692 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
mitz@apple.com [Tue, 12 Aug 2008 20:54:12 +0000 (20:54 +0000)]

        - JavaScriptCore part of <rdar://problem/6121636>
          Make fast*alloc() abort() on failure and add "try" variants that
          return NULL on failure.

        Reviewed by Darin Adler.

        * JavaScriptCore.exp: Exported tryFastCalloc().
        * VM/RegisterFile.h:
        (KJS::RegisterFile::RegisterFile): Removed an ASSERT().
        * kjs/JSArray.cpp:
        (KJS::JSArray::putSlowCase): Changed to use tryFastRealloc().
        (KJS::JSArray::increaseVectorLength): Ditto.
        * kjs/ustring.cpp:
        (KJS::allocChars): Changed to use tryFastMalloc().
        (KJS::reallocChars): Changed to use tryFastRealloc().
        * wtf/FastMalloc.cpp:
        (WTF::fastZeroedMalloc): Removed null checking of fastMalloc()'s result
        and removed extra call to InvokeNewHook().
        (WTF::tryFastZeroedMalloc): Added. Uses tryFastMalloc().
        (WTF::tryFastMalloc): Renamed fastMalloc() to this.
        (WTF::fastMalloc): Added. This version abort()s if allocation fails.
        (WTF::tryFastCalloc): Renamed fastCalloc() to this.
        (WTF::fastCalloc): Added. This version abort()s if allocation fails.
        (WTF::tryFastRealloc): Renamed fastRealloc() to this.
        (WTF::fastRealloc): Added. This version abort()s if allocation fails.
        (WTF::do_malloc): Made this a function template. When the abortOnFailure
        template parameter is set, the function abort()s on failure to allocate.
        Otherwise, it sets errno to ENOMEM and returns zero.
        (WTF::TCMallocStats::fastMalloc): Defined to abort() on failure.
        (WTF::TCMallocStats::tryFastMalloc): Added. Does not abort() on
        (WTF::TCMallocStats::fastCalloc): Defined to abort() on failure.
        (WTF::TCMallocStats::tryFastCalloc): Added. Does not abort() on
        (WTF::TCMallocStats::fastRealloc): Defined to abort() on failure.
        (WTF::TCMallocStats::tryFastRealloc): Added. Does not abort() on
        * wtf/FastMalloc.h: Declared the "try" variants.


        - WebCore part of <rdar://problem/6121636>
          Make fast*alloc() abort() on failure and add "try" variants that
          return NULL on failure.

        Reviewed by Darin Adler.

        * platform/Arena.cpp:
        (WebCore::ArenaAllocate): Removed null checking of fastMalloc()'s
        * platform/graphics/cg/ImageBufferCG.cpp:
        (WebCore::ImageBuffer::create): Changed to use tryFastCalloc().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35691 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Tue, 12 Aug 2008 18:27:58 +0000 (18:27 +0000)]

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=19348
          <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works

        Test: fast/frames/frameset-style-recalc.html

        * html/HTMLFrameSetElement.cpp:
        (WebCore::HTMLFrameSetElement::recalcStyle): Changed to call the base
        class implementation after marking for layout.


        Reviewed by Darin Adler.

        - test for https://bugs.webkit.org/show_bug.cgi?id=19348
          <rdar://problem/5978447> REGRESSION (r34193): Setting the size of a frame with javascript document.body.row no longer works

        * fast/frames/frameset-style-recalc.html: Added.
        * platform/mac/fast/frames/frameset-style-recalc-expected.checksum: Added.
        * platform/mac/fast/frames/frameset-style-recalc-expected.png: Added.
        * platform/mac/fast/frames/frameset-style-recalc-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35690 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove unneeded header imports from some Web Inspector files.
timothy@apple.com [Tue, 12 Aug 2008 17:45:56 +0000 (17:45 +0000)]
    Remove unneeded header imports from some Web Inspector files.

        Reviewed by Adam Roben.

        * WebCoreSupport/WebInspectorClient.mm:
        * WebInspector/WebInspector.mm:
        * WebInspector/WebNodeHighlightView.m:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35689 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Remove the call to WKNSWindowMakeBottomCornersSquare on the
timothy@apple.com [Tue, 12 Aug 2008 17:45:47 +0000 (17:45 +0000)]
    Remove the call to WKNSWindowMakeBottomCornersSquare on the
        Web Inspector's window. This isn't needed anymore since the
        window style masks used always have square bottom corners.

        Reviewed by Adam Roben.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController window]): Remove the call
        to WKNSWindowMakeBottomCornersSquare.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35688 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Make attaching and detaching the Web Inspector instantaneous.
timothy@apple.com [Tue, 12 Aug 2008 17:45:39 +0000 (17:45 +0000)]
    Make attaching and detaching the Web Inspector instantaneous.
        This also preserves the current view, other state, and keeps
        the script debugger attached.


        Reviewed by Adam Roben.

        * WebCoreSupport/WebInspectorClient.mm:
        (-[WebInspectorWindowController close]): Only call setWindowVisible(false)
        when not moving windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35687 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Export WTFLog in Debug builds
aroben@apple.com [Tue, 12 Aug 2008 17:13:50 +0000 (17:13 +0000)]
    Export WTFLog in Debug builds

        Reviewed by John Sullivan.

        * WebKit.vcproj/WebKit_debug.def:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35686 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Tue, 12 Aug 2008 17:04:42 +0000 (17:04 +0000)]

        Reviewed by John Sullivan.

        - move shouldUpdateWhenOffscreen from Settings to FrameView and rename it shouldUpdateWhileHidden

        * WebCore.base.exp:
        * page/FrameView.cpp:
        * page/FrameView.h:
        * page/Settings.cpp:
        * page/Settings.h:


        Reviewed by John Sullivan.

        - replace -[WebPreferences updatesWhenOffscreen] with -[WebView shouldUpdateWhileHidden]

        * WebCoreSupport/WebFrameLoaderClient.mm:
        * WebView/WebFrame.mm:
        (-[WebFrame _updateBackgroundAndUpdatesWhileHidden]):
        * WebView/WebFrameInternal.h:
        * WebView/WebHTMLView.mm:
        (-[WebHTMLView windowWillOrderOnScreen:]):
        * WebView/WebPreferenceKeysPrivate.h:
        * WebView/WebPreferences.mm:
        (+[WebPreferences initialize]):
        * WebView/WebPreferencesPrivate.h:
        * WebView/WebView.mm:
        (-[WebViewPrivate init]):
        (-[WebView _preferencesChangedNotification:]):
        (-[WebView setBackgroundColor:]):
        (-[WebView setDrawsBackground:]):
        (-[WebView shouldUpdateWhileHidden]):
        (-[WebView setShouldUpdateWhileHidden:]):
        * WebView/WebViewPrivate.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35685 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Tue, 12 Aug 2008 14:58:51 +0000 (14:58 +0000)]
    Windows build fix

        * bindings/js/JSSVGPODTypeWrapper.h: Align
        JSSVGDynamicPODTypeWrapper's and JSSVGStaticPODTypeWrapperWithParent's
        members on 16-byte boundaries to avoid an alignment warning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35684 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber stamped by Anders.
zimmermann@webkit.org [Tue, 12 Aug 2008 14:40:46 +0000 (14:40 +0000)]
Rubber stamped by Anders.

Add new dynamic-update layout tests covering SVGCursorElement.

Scale svg/webarchive/resources/green-checker.png to a value < 128x128,
as this is the maximum hardcoded cursor size (fixes manual testing of svg-cursor-subresources.png).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35683 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber stamped by Oliver.
zimmermann@webkit.org [Tue, 12 Aug 2008 12:01:07 +0000 (12:01 +0000)]
Rubber stamped by Oliver.

Add new dynamice-update layout tests covering SVGMaskElement.
Move pixel tests results of SVGMarkerElement* to the right positions, while I'm at it.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35682 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-12 Urs Wolfer <uwolfer@kde.org>
hausmann@webkit.org [Tue, 12 Aug 2008 11:59:05 +0000 (11:59 +0000)]
2008-08-12  Urs Wolfer  <uwolfer@kde.org>

        Reviewed by Simon.


        Fix crash in QWebPage in case contextMenuEvent has been overwritten
        because context menu has the view as parent and thus is deleted too early.

        Add testcase for this crash.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35681 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Oliver.
zimmermann@webkit.org [Tue, 12 Aug 2008 10:35:09 +0000 (10:35 +0000)]
Reviewed by Oliver.

Add new dynamice-update layout tests covering SVGMarkerElement.
Fix bug: SVGMarkerElement's SVG DOM function calls don't update rendering.
Fix orientAngle/orientType confusion: "auto" orient should always return "0" as angle.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35680 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Oliver.
zimmermann@webkit.org [Tue, 12 Aug 2008 10:27:53 +0000 (10:27 +0000)]
Reviewed by Oliver.

Add new dynamic-update layout tests covering SVGImageElement.
Fix bug: SVGImageElement doesn't react on 'preserveAspectRatio' changes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35679 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Changed Option/Alt-Up or Down in CSS editing when the value is
timothy@apple.com [Tue, 12 Aug 2008 04:28:16 +0000 (04:28 +0000)]
    Changed Option/Alt-Up or Down in CSS editing when the value is
        near zero to jump to the next integer.

        Reviewed by Tim Hatcher.


        * page/inspector/StylesSidebarPane.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35678 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Changed the line highlight transition for an easier animation.
timothy@apple.com [Tue, 12 Aug 2008 04:20:25 +0000 (04:20 +0000)]
    Changed the line highlight transition for an easier animation.

        Reviewed by Tim Hatcher.

        * page/inspector/SourceFrame.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35677 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Added support for some Firebug Command Line APIs.
timothy@apple.com [Tue, 12 Aug 2008 03:57:39 +0000 (03:57 +0000)]
    Added support for some Firebug Command Line APIs.

        Reviewed by Tim Hatcher.


        * page/inspector/Console.js:
        Create an object on the inspected window that holds the console
        command line API functions. This object is used in a with statement
        around the typed expression.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35676 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRubber stamped by Oliver.
zimmermann@webkit.org [Tue, 12 Aug 2008 02:55:03 +0000 (02:55 +0000)]
Rubber stamped by Oliver.

Add a bunch of new dynamic-updates tests covering SVGLineElement & SVGRadialGradientElement.
No functional changes needed, all work out of the box.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35675 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Antti.
zimmermann@webkit.org [Tue, 12 Aug 2008 02:22:26 +0000 (02:22 +0000)]
Reviewed by Antti.

Fixes: http://bugs.webkit.org/show_bug.cgi?id=17736

JS wrapper objects around SVG POD types, that contain other SVG POD types with writable properties
failed to update. Modification of the values were completly ignored (ie. transform.matrix.a = 50, didn't take any effect)

Added tests: svg/custom/svg-modify-currentTranslate.html

Fixed tests: svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop.html

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35674 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-11 Brady Eidson <beidson@apple.com>
beidson@apple.com [Tue, 12 Aug 2008 00:34:46 +0000 (00:34 +0000)]
2008-08-11  Brady Eidson  <beidson@apple.com>

        Reviewed by John and Anders

        Fix for <rdar://problem/6141797>

        When WebArchives were entirely a WebKit concept, there was a guarantee that a WebResource
        would never have nil data.

        When they were pushed down into WebCore, that guarantee was lost, subtly changing a few
        semantics with some WebKit applications.

        The guarantee was a good one and should be restored.

        Note that ApplicationCacheResource doesn't need any updates to follow this rule as it already
        creates an empty data object in the case of null data for its own purposes.

        * loader/SubstituteResource.h:
        (WebCore::SubstituteResource::SubstituteResource): ASSERT that the data is not null.  This
          well help any future subclassers not make this mistake.

        * loader/archive/ArchiveResource.cpp:
        (WebCore::ArchiveResource::create): Return 0 if the data is null.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35673 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-11 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Mon, 11 Aug 2008 22:44:06 +0000 (22:44 +0000)]
2008-08-11  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Dave Hyatt

        Fix a problem when an 'all' transition transition with more than
        one property changing is interrupted, and did some AnimationController

        Test: transitions/interrupted-all-transition.html

        * page/AnimationController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35672 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-11 Kevin McCullough <kmccullough@apple.com>
kmccullough@apple.com [Mon, 11 Aug 2008 20:45:19 +0000 (20:45 +0000)]
2008-08-11  Kevin McCullough  <kmccullough@apple.com>

        Reviewed by Tim.

        - Because console messages have group levels now, newly created messages
        that do not specify the level lose their message since the number of
        arguments is wrong.

        * page/inspector/Console.js:
        * page/inspector/Resource.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35671 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-11 Alp Toker <alp@nuanti.com>
alp@webkit.org [Mon, 11 Aug 2008 19:52:14 +0000 (19:52 +0000)]
2008-08-11  Alp Toker  <alp@nuanti.com>

        Build fix. Add new files from r35666 (WebKitAnimationEvent). Also take
        the opportunity to sort the sources lists.

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35670 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Speed up the the JavaScript syntax highlighter by generating
timothy@apple.com [Mon, 11 Aug 2008 18:48:37 +0000 (18:48 +0000)]
    Speed up the the JavaScript syntax highlighter by generating
        the finders only once per script instead of per line.


        Reviewed by Adam Roben.

        * page/inspector/SourceFrame.js:
        Removed, factored into syntaxHighlightJavascript as an inline function.
        Pulled in the _syntaxHighlightJavascriptLine so it will create a closure.
        Generate the finders before iterating the lines.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35669 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Windows build fix
aroben@apple.com [Mon, 11 Aug 2008 18:31:37 +0000 (18:31 +0000)]
    Windows build fix

        * WebCore.vcproj/WebCore.vcproj: Added JSWebKitAnimationEvent.cpp and
        JSWebKitTransitionEvent.cpp to the project. Let VS reformat the file,

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35668 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Mon, 11 Aug 2008 18:04:46 +0000 (18:04 +0000)]

        Reviewed by Darin Adler.

        - fix <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc

        Test: fast/css/counters/invalidate-cached-counter-node.html

        * rendering/RenderContainer.cpp:
        (WebCore::RenderContainer::invalidateCounters): Added. Invalidates all
        RenderCounters in :before and :after content.
        * rendering/RenderContainer.h:
        * rendering/RenderCounter.cpp:
        (WebCore::RenderCounter::isCounter): Renamed isRenderCounter() to this
        to match the RenderObject method.
        (WebCore::RenderCounter::invalidate): Added. Resets the cached
        CounterNode and invalidates the object's layout and preferred widths.
        (WebCore::destroyCounterNodeChildren): Added a call to
        * rendering/RenderCounter.h:
        * rendering/RenderObject.h:


        Reviewed by Darin Adler.

        - test for <rdar://problem/6131096> Reproducible crash in CounterNode::isReset under guard malloc

        * fast/css/counters/invalidate-cached-counter-node.html: Added.
        * platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.checksum: Added.
        * platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.png: Added.
        * platform/mac/fast/css/counters/invalidate-cached-counter-node-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35667 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoImplement CSS Animation and Transition Events
dino@apple.com [Mon, 11 Aug 2008 17:24:36 +0000 (17:24 +0000)]
Implement CSS Animation and Transition Events

Implement the events defined in the CSS Animations
and Transitions specifications so code can react
to animations and transitions.

Reviewed by Tim Hatcher and Dave Hyatt.

* DerivedSources.make:
* GNUmakefile.am:
* WebCore.pro:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* WebCoreSources.bkl:
    Build configs for new files

* bindings/js/JSDOMWindowBase.cpp:
* bindings/js/JSDOMWindowBase.h:
* bindings/js/JSEventCustom.cpp:
* dom/Document.h:
* dom/Event.cpp:
* dom/Event.h:
* dom/EventTarget.cpp:
* dom/EventTargetNode.cpp:
* dom/EventTargetNode.h:
* html/HTMLElement.cpp:
* page/AnimationController.cpp:
    do all the new event stuff

* html/HTMLAttributeNames.in:
    the onwebkitanimation* and onwebkittransitionend attrs

* dom/WebKitAnimationEvent.cpp: Added.
* dom/WebKitAnimationEvent.h: Added.
* dom/WebKitAnimationEvent.idl: Added.
* dom/WebKitTransitionEvent.cpp: Added.
* dom/WebKitTransitionEvent.h: Added.
* dom/WebKitTransitionEvent.idl: Added.
    New files for the events

* manual-tests/transition-events.html: Added.
    New testfile

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35666 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoMove WTF::notFound into its own header so that it can be used independently of Vector
aroben@apple.com [Mon, 11 Aug 2008 17:21:23 +0000 (17:21 +0000)]
Move WTF::notFound into its own header so that it can be used independently of Vector


        Move WTF::notFound into its own header so that it can be used
        independently of Vector

        Rubberstamped by Darin Adler.

        * JavaScriptCore.vcproj/WTF/WTF.vcproj:
        * JavaScriptCore.xcodeproj/project.pbxproj:
        Added NotFound.h to the project.
        * wtf/NotFound.h: Added. Moved the notFound constant here...
        * wtf/Vector.h: ...from here.


        Add a ForwardingHeader for wtf/NotFound.h

        Rubberstamped by Darin Adler.

        * ForwardingHeaders/wtf/NotFound.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35665 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Fixes a bug where error bubbles in JavaScript resources would
timothy@apple.com [Mon, 11 Aug 2008 16:53:30 +0000 (16:53 +0000)]
    Fixes a bug where error bubbles in JavaScript resources would
        be clobbered by the syntax highlighter.


        Reviewed by Adam Roben.

        * manual-tests/inspector/resources/script-error.js: Added.
        * manual-tests/inspector/styled-error-bubbles-in-scripts.html: Added.
        * page/inspector/SourceFrame.js:
        Check the nodeType and not the nodeName, this is less fragile.
        Check if the lastChild is an error bubble, if so remove it before
        getting the line's textContent. Add the error bubble back at the end.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35664 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Mark Rowe.
ap@webkit.org [Mon, 11 Aug 2008 12:01:26 +0000 (12:01 +0000)]
    Reviewed by Mark Rowe.

        <rdar://problem/6130393> REGRESSION: PhotoBooth hangs after launching under TOT Webkit

        * API/JSContextRef.cpp: (JSGlobalContextRelease): Corrected a comment.

        * kjs/collector.cpp: (KJS::Heap::~Heap): Ensure that JSGlobalData is not deleted while
        sweeping the heap.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35663 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRoll over three large ChangeLogs.
mrowe@apple.com [Mon, 11 Aug 2008 05:07:42 +0000 (05:07 +0000)]
Roll over three large ChangeLogs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35662 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Eric Seidel.
mitz@apple.com [Mon, 11 Aug 2008 04:51:38 +0000 (04:51 +0000)]
    Reviewed by Eric Seidel.

        - fix https://bugs.webkit.org/show_bug.cgi?id=20339
          REGRESSION (r35531-r35615): Acid3 crashes on Windows in CachedFont::getSVGFontById

        * dom/make_names.pl: Removed "using namespace WebCore::*Names"
        from *ElementFactory.cpp files.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35661 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix crash in Acid3 in Windows and Gtk ports, introduced in r35590.
mrowe@apple.com [Mon, 11 Aug 2008 02:17:01 +0000 (02:17 +0000)]
Fix crash in Acid3 in Windows and Gtk ports, introduced in r35590.

Reviewed by Cameron Zwarich.

* bindings/js/ScriptControllerGtk.cpp: Fix the logic.
* bindings/js/ScriptControllerWin.cpp: Ditto.
* bindings/js/ScriptControllerQt.cpp: Switch to isPluginView for consistency with Gtk and Windows.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35660 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Sun, 10 Aug 2008 22:36:29 +0000 (22:36 +0000)]

        Reviewed by Darin Adler.

        - fix <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty

        Test: fast/tokenizer/ampersand-in-special-tag.html

        * html/HTMLTokenizer.cpp:
        (WebCore::HTMLTokenizer::parseSpecial): Changed to only advance
        lastDecodedEntityPosition if an entity was found and decoded.


        Reviewed by Darin Adler.

        - test for <rdar://problem/6074587> REGRESSION (34722): Unable to view AT&T wireless bill - window title contains markup, window is empty

        * fast/tokenizer/ampersand-in-special-tag-expected.txt: Added.
        * fast/tokenizer/ampersand-in-special-tag.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35659 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-10 Jan Michael Alonzo <jmalonzo@webkit.org>
alp@webkit.org [Sun, 10 Aug 2008 18:21:21 +0000 (18:21 +0000)]
2008-08-10  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed (and updated) by Alp Toker.

        [GTK] Autotools make dist and make check support

        Get make dist working.

        Note that not all possible configurations have been tested yet.

        * GNUmakefile.am:

2008-08-10  Alp Toker  <alp@nuanti.com>

        Remove leftover qmake/GTK+ build files.

        * DumpRenderTree/gtk/DumpRenderTree.pro: Removed.
        * GtkLauncher/GtkLauncher.pro: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35658 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
ap@webkit.org [Sun, 10 Aug 2008 10:06:13 +0000 (10:06 +0000)]
    Reviewed by Sam Weinig.

        Added same heap debug checks to more code paths.

        * kjs/JSActivation.cpp:
        * kjs/JSGlobalObject.cpp:
        * kjs/JSObject.h:
        * kjs/JSVariableObject.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35657 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-09 Marco Barisione <marco.barisione@collabora.co.uk>
alp@webkit.org [Sun, 10 Aug 2008 03:11:28 +0000 (03:11 +0000)]
2008-08-09  Marco Barisione  <marco.barisione@collabora.co.uk>

        Reviewed by Alp Toker.

        [gtk] ./configure doesn't check for x toolkit availability

        Some old versions of Xt do not provide xt.pc, in this case use
        AC_CHECK_LIB to check if the library is installed and then fall back
        to using just -lXt.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35656 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-09 Alp Toker <alp@nuanti.com>
alp@webkit.org [Sun, 10 Aug 2008 03:00:29 +0000 (03:00 +0000)]
2008-08-09  Alp Toker  <alp@nuanti.com>

        GTK+ build fixes.

        Back out r20338 libxslt check (conditional check already exists and
        this broke the build).

        Make the flex version check a warning rather than fatal to fix the
        build bot.

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35655 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2008-08-08 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Sun, 10 Aug 2008 02:03:42 +0000 (02:03 +0000)]
2008-08-08  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Mark Rowe.

        [Gtk] Autotools should check for libxslt

        Autotools check for libxslt

        * configure.ac:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@35654 268f45cc-cd09-0410-ab3c-d52691b4dbfc