WebKit-https.git
8 years agoAudioPannerNode should raise exception when distanceModel is set incorrectly
commit-queue@webkit.org [Tue, 31 Jul 2012 19:14:07 +0000 (19:14 +0000)]
AudioPannerNode should raise exception when distanceModel is set incorrectly
https://bugs.webkit.org/show_bug.cgi?id=90952

Patch by Li Yin <li.yin@intel.com> on 2012-07-31
Reviewed by Chris Rogers.

Source/WebCore:

Spec: http://www.w3.org/TR/webaudio/#AudioPannerNode-section
The distance model can be only set to LINEAR_DISTANCE, INVERSE_DISTANCE or EXPONENTIAL_DISTANCE.
If the incorrect value is set, it will raise the exception.
Use the unsigned short to replace unsigned long in AudioPannerNode.idl.

Test: webaudio/audiopannernode-basic.html

* Modules/webaudio/AudioPannerNode.cpp:
(WebCore::AudioPannerNode::setDistanceModel): raise exception
(WebCore):
* Modules/webaudio/AudioPannerNode.h:
(AudioPannerNode):
* Modules/webaudio/AudioPannerNode.idl: using unsigned short to replace unsigned long

LayoutTests:

Spec: http://www.w3.org/TR/webaudio/#AudioPannerNode-section
Add tests for distanceModel,numberOfInputs and numberOfInputs of AudioPannerNode.

* webaudio/audiopannernode-basic-expected.txt: Added.
* webaudio/audiopannernode-basic.html: Added.
* webaudio/panner-set-model-expected.txt: Removed.
* webaudio/panner-set-model.html: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124237 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: clean up self._test_files_list vs. self._test_files, other nits
dpranke@chromium.org [Tue, 31 Jul 2012 19:11:09 +0000 (19:11 +0000)]
nrwt: clean up self._test_files_list vs. self._test_files, other nits
https://bugs.webkit.org/show_bug.cgi?id=92702

Reviewed by Ojan Vafai.

Get rid of self._test_files, rename self._test_files_list to
self._test_names (removing the confusion between the two fields).

Also inline the one call to _parse_expectations, remove the one
use of more_tests_to_skip, and fix a couple of minor nits.

* Scripts/webkitpy/layout_tests/controllers/finder.py:
(LayoutTestFinder.split_into_chunks):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.__init__):
(Manager._collect_tests):
(Manager._http_tests):
(Manager._websocket_tests):
(Manager._is_perf_test):
(Manager.prepare_lists_and_print_output):
(Manager.needs_servers):
(Manager.run):
(Manager._mark_interrupted_tests_as_skipped):
(Manager._update_summary_with_result):
(Manager._upload_json_files):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_needs_servers.get_manager_with_tests):
(ManagerTest.test_servers_started):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: --verbose logging does not work right on windows
dpranke@chromium.org [Tue, 31 Jul 2012 19:09:51 +0000 (19:09 +0000)]
nrwt: --verbose logging does not work right on windows
https://bugs.webkit.org/show_bug.cgi?id=92673

Reviewed by Ojan Vafai.

Add a test for r124090.

* Scripts/webkitpy/layout_tests/run_webkit_tests_integrationtest.py:
(MainTest.test_verbose):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124235 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoREGRESSION(124116): Number of skipped tests isn't printed anymore
dpranke@chromium.org [Tue, 31 Jul 2012 19:05:27 +0000 (19:05 +0000)]
REGRESSION(124116): Number of skipped tests isn't printed anymore
https://bugs.webkit.org/show_bug.cgi?id=92736

Reviewed by Tony Chang.

Add the skipped number back in; it was useful ... also clean up
the formatting a little bit.

* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS Shaders] CSS parser rejects parameter names that are also CSS keywords
commit-queue@webkit.org [Tue, 31 Jul 2012 19:04:04 +0000 (19:04 +0000)]
[CSS Shaders] CSS parser rejects parameter names that are also CSS keywords
https://bugs.webkit.org/show_bug.cgi?id=92537

Patch by Max Vujovic <mvujovic@adobe.com> on 2012-07-31
Reviewed by Dirk Schulze.

Source/WebCore:

Remove the CSS keyword check for CSS Shaders parameter names. Parameters are allowed to be
any valid CSS identifier, including CSS keywords. See the spec:
https://dvcs.w3.org/hg/FXTF/raw-file/tip/custom/index.html#feCustom

The CSS parser was rejecting input like the following because it uses a CSS keyword
"background" as a parameter name:
-webkit-filter: custom(none url(fragment.shader), background 0 1 0 1);

Test: css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html

* css/CSSParser.cpp:
(WebCore::CSSParser::parseCustomFilter): Do not return early when the parameter name is a
CSS keyword (i.e. when the CSSParserValue has a non-zero id).

LayoutTests:

Add a pixel test that uses the CSS keyword "background" as a CSS Shaders parameter name.
Add a parsing test case that uses the CSS keyword "background".

* css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.png: Added.
* css3/filters/custom/custom-filter-css-keyword-as-parameter-name-expected.txt: Added.
* css3/filters/custom/custom-filter-css-keyword-as-parameter-name.html: Added.
* css3/filters/custom/custom-filter-property-parsing-expected.txt:
* css3/filters/resources/css-keyword-as-parameter-name.fs: Added.
* css3/filters/script-tests/custom-filter-property-parsing.js:
* platform/chromium/TestExpectations:
* platform/chromium/css3/filters/custom/custom-filter-property-parsing-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124233 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoTypo: doubleTa*b*ZoomAnimationDurationInSeconds in WebViewImpl.cpp
abarth@webkit.org [Tue, 31 Jul 2012 19:01:46 +0000 (19:01 +0000)]
Typo: doubleTa*b*ZoomAnimationDurationInSeconds in WebViewImpl.cpp
https://bugs.webkit.org/show_bug.cgi?id=92135

Reviewed by Kentaro Hara.

This patch fixes a typo.

* src/WebViewImpl.cpp:
(WebKit::WebViewImpl::animateZoomAroundPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCaret position is wrong when a editable container has word-wrap:normal set
commit-queue@webkit.org [Tue, 31 Jul 2012 18:56:26 +0000 (18:56 +0000)]
Caret position is wrong when a editable container has word-wrap:normal set
https://bugs.webkit.org/show_bug.cgi?id=89649

Patch by Pravin D <pravind.2k4@gmail.com> on 2012-07-31
Reviewed by Levi Weintraub.

Source/WebCore:

Correcting the incorrect addumption that the min and max position for the caret rect is constrained to
the logical containing block width. This assumption is incorrect when the text has word-wrap:normal and
flows beyound the visible rect of the container.

Test: editing/input/editable-container-with-word-wrap-normal.html

* rendering/RenderText.cpp:
(WebCore::RenderText::localCaretRect):

LayoutTests:

* editing/input/editable-container-with-word-wrap-normal-expected.txt: Added.
* editing/input/editable-container-with-word-wrap-normal.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124231 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoDFG OSR exit profiling has unusual oversights
fpizlo@apple.com [Tue, 31 Jul 2012 18:48:17 +0000 (18:48 +0000)]
DFG OSR exit profiling has unusual oversights
https://bugs.webkit.org/show_bug.cgi?id=92728

Reviewed by Geoffrey Garen.

* dfg/DFGOSRExit.cpp:
(JSC::DFG::OSRExit::considerAddingAsFrequentExitSiteSlow):
* dfg/DFGSpeculativeJIT.h:
(JSC::DFG::SpeculativeJIT::speculationWatchpoint):
* dfg/DFGSpeculativeJIT32_64.cpp:
(JSC::DFG::SpeculativeJIT::compile):
* dfg/DFGSpeculativeJIT64.cpp:
(JSC::DFG::SpeculativeJIT::compile):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoCrash in FrameLoader::checkLoadComplete with non-browser client app
antti@apple.com [Tue, 31 Jul 2012 18:47:33 +0000 (18:47 +0000)]
Crash in FrameLoader::checkLoadComplete with non-browser client app
https://bugs.webkit.org/show_bug.cgi?id=92774

Reviewed by Alexey Proskuryakov..

Speculative fix. It is possible that CSSFontSelector could get deleted during the timer callback
and memory reused, making m_document point to some garbage when it is tested at the end.

* css/CSSFontSelector.cpp:
(WebCore::CSSFontSelector::beginLoadTimerFired):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124229 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd MIPS add32 function
commit-queue@webkit.org [Tue, 31 Jul 2012 18:44:03 +0000 (18:44 +0000)]
Add MIPS add32 function
https://bugs.webkit.org/show_bug.cgi?id=91522

Patch by Chao-ying Fu <fu@mips.com> on 2012-07-31
Reviewed by Oliver Hunt.

Add isCompactPtrAlignedAddressOffset.
Add a new version of add32 that accepts AbsoluteAddress as inputs.

* assembler/MacroAssemblerMIPS.h:
(JSC::MacroAssemblerMIPS::isCompactPtrAlignedAddressOffset): New.
(MacroAssemblerMIPS):
(JSC::MacroAssemblerMIPS::add32): Support AbsoluteAddress as inputs.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Fix crash in InputHandler spell checking.
mifenton@rim.com [Tue, 31 Jul 2012 18:43:02 +0000 (18:43 +0000)]
[BlackBerry] Fix crash in InputHandler spell checking.
https://bugs.webkit.org/show_bug.cgi?id=92763

Reviewed by Antonio Gomes.

PR 185574.

Fix crash in getSpellChecker by guarding the calling paths
to ensure that m_currentFocusElement is valid.

Also add ASSERTs for previous crash.

* WebKitSupport/InputHandler.cpp:
(BlackBerry::WebKit::InputHandler::spellCheckingRequestProcessed):
(BlackBerry::WebKit::InputHandler::spellCheckingRequestCancelled):
(BlackBerry::WebKit::InputHandler::getSpellChecker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[EFL] Gardening of failing tests and new passes
commit-queue@webkit.org [Tue, 31 Jul 2012 18:31:41 +0000 (18:31 +0000)]
[EFL] Gardening of failing tests and new passes
https://bugs.webkit.org/show_bug.cgi?id=92770

Unreviewed gardening.

New baselines, skipped some failing tests and removed test
expectations that are the same as the global expectations.

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31

* platform/efl/TestExpectations:
* platform/efl/compositing/iframes/leave-compositing-iframe-expected.txt: Removed.
* platform/efl/compositing/plugins/1x1-composited-plugin-expected.txt: Removed.
* platform/efl/compositing/plugins/large-to-small-composited-plugin-expected.txt: Removed.
* platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
* platform/efl/fast/block/positioning/rtl-fixed-positioning-expected.txt: Removed.
* platform/efl/fast/css-generated-content/nested-tables-with-before-after-content-crash-expected.txt: Removed.
* platform/efl/fast/forms/listbox-clip-expected.txt: Removed.
* platform/efl/fast/html/details-position-expected.txt: Removed.
* platform/efl/mathml/msub-anonymous-child-render-crash-expected.txt: Removed.
* platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.png: Added.
* platform/efl/svg/as-image/animated-svg-repaints-completely-in-hidpi-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124226 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSpeech JavaScript API: Throw exception for start() when already started
hans@chromium.org [Tue, 31 Jul 2012 18:26:45 +0000 (18:26 +0000)]
Speech JavaScript API: Throw exception for start() when already started
https://bugs.webkit.org/show_bug.cgi?id=92756

Reviewed by Adam Barth.

Source/WebCore:

Make the start() function throw an exception if the SpeechRecognition
object was already started.

Test: fast/speech/scripted/start-exception.html

* Modules/speech/SpeechRecognition.cpp:
(WebCore::SpeechRecognition::start):
(WebCore::SpeechRecognition::stopFunction):
(WebCore::SpeechRecognition::abort):
(WebCore::SpeechRecognition::didReceiveError):
(WebCore::SpeechRecognition::didEnd):
(WebCore::SpeechRecognition::SpeechRecognition):
* Modules/speech/SpeechRecognition.h:
(SpeechRecognition):
* Modules/speech/SpeechRecognition.idl:

Tools:

Fix the task queue in MockWebSpeechRecognizer.
It's important that we remove the task from the queue before we run
it, as running the task could alter the queue's state.

* DumpRenderTree/chromium/MockWebSpeechRecognizer.cpp:
(MockWebSpeechRecognizer::abort):
(MockWebSpeechRecognizer::setError):
(MockWebSpeechRecognizer::clearTaskQueue):
(MockWebSpeechRecognizer::StepTask::runIfValid):
* DumpRenderTree/chromium/MockWebSpeechRecognizer.h:
(MockWebSpeechRecognizer):

LayoutTests:

Layout test for checking that calling start on an already started
SpeechRecognition object throws an exception.

* fast/speech/scripted/start-exception-expected.txt: Added.
* fast/speech/scripted/start-exception.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124225 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: move handling the initial list of tests to skip to finder
dpranke@chromium.org [Tue, 31 Jul 2012 18:19:42 +0000 (18:19 +0000)]
nrwt: move handling the initial list of tests to skip to finder
https://bugs.webkit.org/show_bug.cgi?id=92701

Reviewed by Ryosuke Niwa.

More refactoring of manager ...

* Scripts/webkitpy/layout_tests/controllers/finder.py:
(LayoutTestFinder.skip_tests):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager.prepare_lists_and_print_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r124207.
zandobersek@gmail.com [Tue, 31 Jul 2012 18:16:48 +0000 (18:16 +0000)]
Unreviewed, rolling out r124207.
http://trac.webkit.org/changeset/124207
https://bugs.webkit.org/show_bug.cgi?id=92773

Patch causes crashes on the 64-bit debug builder (and other
builders likely) (Requested by zdobersek on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

Source/WebCore:

* GNUmakefile.am:
* GNUmakefile.list.am:
* platform/text/gtk/TextCheckerEnchant.cpp: Removed.
* platform/text/gtk/TextCheckerEnchant.h: Removed.

Source/WebKit/gtk:

* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(createEnchantBrokerIfNeeded):
(freeSpellCheckingLanguage):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(wordEndIsAContractionApostrophe):
(checkSpellingOfString):
(getGuessesForWord):
(getAvailableDictionariesCallback):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124223 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] transforms/3d/point-mapping/3d-point-mapping-*.html failing on Win
enne@google.com [Tue, 31 Jul 2012 18:13:41 +0000 (18:13 +0000)]
[Chromium] transforms/3d/point-mapping/3d-point-mapping-*.html failing on Win
https://bugs.webkit.org/show_bug.cgi?id=92707

Unreviewed, updating expectations after r124052.

For efficiency's sake, ScrollbarLayerChromium doesn't draw the top and
bottom part of the track differently on "native" scrollbars. This
changes the way the mock Windows scrollbars look in tests.

* platform/chromium-linux-x86/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png: Removed.
* platform/chromium-win-xp/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Removed.
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-origins-expected.png:
* platform/chromium-win/transforms/3d/point-mapping/3d-point-mapping-preserve-3d-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124222 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoinspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebVi...
msaboff@apple.com [Tue, 31 Jul 2012 17:43:30 +0000 (17:43 +0000)]
inspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebView closing
<rdar://problem/11991881>

* platform/mac-lion/Skipped: Added inspector/debugger/debugger-expand-scope.html to skip list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Kill the concept of secondary shared process
ap@apple.com [Tue, 31 Jul 2012 17:42:46 +0000 (17:42 +0000)]
[WK2] Kill the concept of secondary shared process
https://bugs.webkit.org/show_bug.cgi?id=92676

Reviewed by Sam Weinig.

* MiniBrowser/win/BrowserView.cpp: (BrowserView::create): Update Windows build fix.
Don't create a new context for every view.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Don't use ninja for building Chromium for Android
peter@chromium.org [Tue, 31 Jul 2012 17:26:50 +0000 (17:26 +0000)]
[Chromium] Don't use ninja for building Chromium for Android
https://bugs.webkit.org/show_bug.cgi?id=92764

Reviewed by Adam Barth.

When Ninja projects files are generated (which will be done for Android),
make sure that the Android builder doesn't unintentionally switch to
using Ninja. We should make that switch at a predetermined time.

* Scripts/webkitdirs.pm:
(buildChromium):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSend an onContextMenu event to the page content
commit-queue@webkit.org [Tue, 31 Jul 2012 17:21:01 +0000 (17:21 +0000)]
Send an onContextMenu event to the page content
so that context menus can be prevented. We use
the node's event handler because we want to use
the fat finger's node. If we use  the EventHandler's
sendContextMenuEvent it will hit test with the mouse
position which may not be what we want.
PR #184032
https://bugs.webkit.org/show_bug.cgi?id=92766

Patch by Genevieve Mak <gmak@rim.com> on 2012-07-31
Reviewed by Antonio Gomes.
Reviewed Internally by Antonio Gomes.

* Api/WebPage.cpp:
(BlackBerry::WebKit::WebPagePrivate::webContext):
(BlackBerry::WebKit::WebPagePrivate::contextNode):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124218 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GStreamer] Live stream support is weak
philn@webkit.org [Tue, 31 Jul 2012 17:16:24 +0000 (17:16 +0000)]
[GStreamer] Live stream support is weak
https://bugs.webkit.org/show_bug.cgi?id=90084

Reviewed by Martin Robinson.

Make sure on-disk buffering is disabled for live streams. It is
enabled initially when loading any remote media file if preload is
set to Auto. Later on if the player detects that the media is live
it disables on-disk buffering. This patch also adds support for
caching the total size of the media.

* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:
(WebCore::MediaPlayerPrivateGStreamer::MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::load): Keep track of the
media url as an instance attribute.
(WebCore::MediaPlayerPrivateGStreamer::duration): Logging improvement.
(WebCore::MediaPlayerPrivateGStreamer::setRate): use the new
isLiveStream() method.
(WebCore::MediaPlayerPrivateGStreamer::buffered): Ditto.
(WebCore::MediaPlayerPrivateGStreamer::handleMessage): Indicate
source of duration message.
(WebCore::MediaPlayerPrivateGStreamer::fillTimerFired): Perform an
anonymous duration change emission, mostly to cache its value.
(WebCore::MediaPlayerPrivateGStreamer::totalBytes): Return
cached size when available.
(WebCore::MediaPlayerPrivateGStreamer::updateStates): Use the new
isLiveStream() method and handle state change corner cases for live streams.
(WebCore::MediaPlayerPrivateGStreamer::durationChanged): Cache
media total size and re-enable on-disk buffering if caching succeeds.
(WebCore::MediaPlayerPrivateGStreamer::movieLoadType): New
implementation handling on-disk buffered and live streaming cases.
(WebCore::MediaPlayerPrivateGStreamer::setPreload): Remember the
case where preload is updated from Auto to another value, do
on-disk buffering only for Auto preload attribute.
* platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.h:
(MediaPlayerPrivateGStreamer):
(WebCore::MediaPlayerPrivateGStreamer::isLiveStream): Utility
method, a stream is live if it goes to PAUSE without prerolling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124217 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed gardening, last attempt to paint the WK2 bot green today.
ossy@webkit.org [Tue, 31 Jul 2012 17:02:10 +0000 (17:02 +0000)]
[Qt][WK2] Unreviewed gardening, last attempt to paint the WK2 bot green today.

* platform/qt-5.0-wk2/Skipped: Skip a failing test.
* platform/qt-5.0-wk2/compositing/columns/composited-in-paginated-expected.txt: Added.
* platform/qt-5.0-wk2/compositing/geometry/bounds-ignores-hidden-composited-descendant-expected.txt: Added.
* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124216 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a mechanism to dump the stack trace in case of a crash
commit-queue@webkit.org [Tue, 31 Jul 2012 16:42:20 +0000 (16:42 +0000)]
Add a mechanism to dump the stack trace in case of a crash
https://bugs.webkit.org/show_bug.cgi?id=92666

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Csaba Osztrogonác.

Source/WTF:

Unix based ports can make use of signal handlers to dump the stack
trace in case of a crash. This is specially handy when a test crashes on
the bot without hitting an assertion, we might have a chance to see
some insightful information at the reports.

* wtf/Assertions.cpp:
* wtf/Assertions.h:

Tools:

Move crash signal handlers to WTFInstallReportBacktraceOnCrashHook()
and eliminate some duplicated code.

* DumpRenderTree/qt/main.cpp:
(main):
* WebKitTestRunner/InjectedBundle/qt/InjectedBundleQt.cpp:
(WTR::InjectedBundle::platformInitialize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Blackberry][FullScreen] HTML5 <video> controls are scaled differently depending...
tonikitoo@webkit.org [Tue, 31 Jul 2012 16:21:12 +0000 (16:21 +0000)]
[Blackberry][FullScreen] HTML5 <video> controls are scaled differently depending on the current webpage scale
https://bugs.webkit.org/show_bug.cgi?id=90884
PR #162839

Reviewed by Rob Buis.
Patch by Antonio Gomes <agomes@rim.com>

The way the BlackBerry port implements the FULLSCREEN_API for media
elements might result in the controls being oversized, proportionally
to the current page scale. That happens because the fullscreen element
gets sized to be as big as the viewport size, and the viewport size might
get outstretched to fit to the screen dimensions.

In order to fix that, the patch strips out the Page scale factor from
the media controls multiplier.

Patch also changes many integer-based calculations to be float-based, in
order to get the needed precision.

Internally reviewed by Jacky Jiang.

* platform/blackberry/RenderThemeBlackBerry.cpp:
(WebCore):
(WebCore::determineFullScreenMultiplier):
(WebCore::RenderThemeBlackBerry::adjustSliderThumbSize):
(WebCore::RenderThemeBlackBerry::adjustMediaControlStyle):
(WebCore::RenderThemeBlackBerry::adjustSliderTrackStyle):
(WebCore::RenderThemeBlackBerry::paintMediaSliderTrack):
(WebCore::RenderThemeBlackBerry::paintMediaSliderThumb):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove the clone() method from FilterOperation (and subclasses).
senorblanco@chromium.org [Tue, 31 Jul 2012 16:10:39 +0000 (16:10 +0000)]
Remove the clone() method from FilterOperation (and subclasses).
https://bugs.webkit.org/show_bug.cgi?id=92757

Reviewed by Kentaro Hara.

Since the move to WebFilterOperation in Chromium, this is now dead
code.

Covered by existing tests in css3/filters.

* platform/graphics/filters/CustomFilterOperation.h:
* platform/graphics/filters/FilterOperation.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124213 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRegression(r124135): SVG tests crashing on ports using Cairo
commit-queue@webkit.org [Tue, 31 Jul 2012 16:08:56 +0000 (16:08 +0000)]
Regression(r124135): SVG tests crashing on ports using Cairo
https://bugs.webkit.org/show_bug.cgi?id=92752

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-31
Reviewed by Martin Robinson.

* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::operator=):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124212 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r124208.
loislo@chromium.org [Tue, 31 Jul 2012 16:05:11 +0000 (16:05 +0000)]
Unreviewed, rolling out r124208.
http://trac.webkit.org/changeset/124208
https://bugs.webkit.org/show_bug.cgi?id=92765

it broke compilation on mac (Requested by loislo on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* inspector/MemoryInstrumentationImpl.cpp: Removed.
* inspector/MemoryInstrumentationImpl.h: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124211 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoxmlserializer strips xlink from xlink:html svg image tag
schenney@chromium.org [Tue, 31 Jul 2012 16:02:14 +0000 (16:02 +0000)]
xmlserializer strips xlink from xlink:html svg image tag
https://bugs.webkit.org/show_bug.cgi?id=79586

Reviewed by Nikolas Zimmermann.

Source/WebCore:

Adding code to ensure the correct prefix on attributes in the xml,
xmlns and xlink namespaces. We now follow the rules in
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#serializing-html-fragments
(circa the time of this change).

Rob Buis wrote the original test for this patch and did the initial work.

Tests: fast/dom/XMLSerializer-xml-namespace.html
       svg/custom/xlink-prefix-in-attributes.html

* editing/MarkupAccumulator.cpp:
(WebCore::attributeIsInSerializedNamespace): Test for an attribute in
a specially serialized namespace: xml, xmlns, xlink.
(WebCore):
(WebCore::MarkupAccumulator::appendAttribute): Check the namespace of
attributes upon serialization, and add any necessary prefixes.
* html/parser/HTMLTreeBuilder.cpp:
(WebCore::adjustForeignAttributes): Use WTF::xmlAtom etc for AtomicString arguments.

Source/WTF:

Add WTF::xlinkAtom as a global AtomicString constant.

* wtf/text/AtomicString.h:
(WTF): Add xlinkAtom.
* wtf/text/StringStatics.cpp:
(WTF): Add xlinkAtom.
(WTF::AtomicString::init): Add xlinkAtom.

LayoutTests:

Adding code to ensure the correct prefix on attributes in the xml,
xmlns and xlink namespaces. We now follow the rules in
http://www.whatwg.org/specs/web-apps/current-work/multipage/the-end.html#serializing-html-fragments
(circa the time of this change).

Rob Buis wrote the original test for this patch and did the initial work.

* editing/pasteboard/paste-noscript-svg-expected.txt: Updated.
* fast/dom/XMLSerializer-xml-namespace-expected.txt: Added.
* fast/dom/XMLSerializer-xml-namespace.html: Added. Tests serializing attributes with the xml namespace.
* svg/custom/xlink-prefix-in-attributes-expected.txt: Added.
* svg/custom/xlink-prefix-in-attributes.html: Added. Tests serializing attributes in the xmlns and xlink namespaces.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoskia: switch to conical gradient to match css/svg spec for two-point gradients
reed@google.com [Tue, 31 Jul 2012 15:55:48 +0000 (15:55 +0000)]
skia: switch to conical gradient to match css/svg spec for two-point gradients
https://bugs.webkit.org/show_bug.cgi?id=92754

Reviewed by Stephen White.

Source/WebCore:

Switching to skia's TwoPointConical gradient, which has been written explicitly to match the css/svg spec.
Leaving the existing TwoPointRadial gradient in skia, for other callers that may want the old behavior.

No new tests. existing layouttests exercise this change (9 pending rebaselines associated with this CL).

* platform/graphics/skia/GradientSkia.cpp:
(WebCore::Gradient::platformGradient):

LayoutTests:

Update expectations to rebaseline 9 images after this change lands

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124209 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: extract MemoryInstrumentationImpl into separate files for future reusi...
loislo@chromium.org [Tue, 31 Jul 2012 15:53:15 +0000 (15:53 +0000)]
Web Inspector: extract MemoryInstrumentationImpl into separate files for future reusing in unit tests
https://bugs.webkit.org/show_bug.cgi?id=92751

Reviewed by Yury Semikhatsky.

* CMakeLists.txt:
* GNUmakefile.list.am:
* Target.pri:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* inspector/InspectorAllInOne.cpp:
* inspector/InspectorMemoryAgent.cpp:
(WebCore):
* inspector/MemoryInstrumentationImpl.cpp: Added.
(WebCore):
(WebCore::MemoryInstrumentationImpl::MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::processDeferredInstrumentedPointers):
(WebCore::MemoryInstrumentationImpl::countObjectSize):
(WebCore::MemoryInstrumentationImpl::deferInstrumentedPointer):
(WebCore::MemoryInstrumentationImpl::visited):
(WebCore::MemoryInstrumentationImpl::selfSize):
* inspector/MemoryInstrumentationImpl.h: Added.
(WebCore):
(MemoryInstrumentationImpl):
(WebCore::MemoryInstrumentationImpl::totalTypeSize):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] Add a new and reusable enchant-based spellchecker in WebCore
mario@webkit.org [Tue, 31 Jul 2012 15:51:29 +0000 (15:51 +0000)]
[GTK] Add a new and reusable enchant-based spellchecker in WebCore
https://bugs.webkit.org/show_bug.cgi?id=90269

Reviewed by Martin Robinson.

Source/WebCore:

Move enchant specific code down to WebCore, into a new class
TextCheckerEnchant, that we can use from WK1 and WK2.

* GNUmakefile.am: Add flags to handle the SPELLCHECK feature.
* GNUmakefile.list.am: Added new files.
* platform/text/gtk/TextCheckerEnchant.cpp: Added.
(getAvailableDictionariesCallback):
(TextCheckerEnchant::TextCheckerEnchant):
(TextCheckerEnchant::~TextCheckerEnchant):
(TextCheckerEnchant::ignoreWord):
(TextCheckerEnchant::learnWord):
(TextCheckerEnchant::checkSpellingOfString):
(TextCheckerEnchant::getGuessesForWord):
(TextCheckerEnchant::updateSpellCheckingLanguages):
(TextCheckerEnchant::freeEnchantBrokerDictionaries):
* platform/text/gtk/TextCheckerEnchant.h: Added.
(WebCore):
(TextCheckerEnchant):
(WebCore::TextCheckerEnchant::create):

Source/WebKit/gtk:

Remove enchant specific code from WebKitSpellCheckerEnchant and
implement it relying in the new TextCheckerEnchant class in WebCore.

* webkit/webkitspellcheckerenchant.cpp:
(_WebKitSpellCheckerEnchantPrivate):
(webkit_spell_checker_enchant_finalize):
(webkit_spell_checker_enchant_class_init):
(webkit_spell_checker_enchant_init):
(checkSpellingOfString):
(getGuessesForWord):
(updateSpellCheckingLanguages):
(learnWord):
(ignoreWord):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline fast/ruby/overhang-horizontal.html.
apavlov@chromium.org [Tue, 31 Jul 2012 15:44:32 +0000 (15:44 +0000)]
[Chromium] Unreviewed, rebaseline fast/ruby/overhang-horizontal.html.

* platform/chromium-win/fast/ruby/overhang-horizontal-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124206 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Support Negotiate auth
commit-queue@webkit.org [Tue, 31 Jul 2012 15:41:12 +0000 (15:41 +0000)]
[BlackBerry] Support Negotiate auth
https://bugs.webkit.org/show_bug.cgi?id=91871

Patch by Joe Mason <jmason@rim.com> on 2012-07-31
Reviewed by George Staikos.

Add Negotiate to the list of auth schemes allowed in the platform request.

Add "success" and "requireCredentials" parameters to notifyAuthReceived (which is now called
with success = true on successful authentication, as well as on failures).

When success is true, update the stored credential to use the auth scheme actually reported
rather than that set in the request. (This is used when Negotiate auth can't get a ticket
and falls back to a different supported auth type.)

When requireCredentials is false, just set the auth type and start a new request using empty
credentials.

RIM PR# 166514
Internally reviewed by Jonathan Dong

* platform/network/blackberry/NetworkJob.cpp:
(WebCore::NetworkJob::notifyAuthReceived): Add Negotiate to the auth scheme switch. Handle
success param by updating auth type in stored credentials; pass requireCredentials param on
to sendRequestWithCredentials.
(WebCore::NetworkJob::startNewJobWithRequest): Fix typo in increaseRedirectCount parameter
name.
(WebCore::NetworkJob::sendRequestWithCredentials): Use empty credentials if
requireCredentials is false.
* platform/network/blackberry/NetworkJob.h:
(NetworkJob):
* platform/network/blackberry/NetworkManager.cpp:
(WebCore::NetworkManager::startJob): Add Negotiate to the auth scheme switch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124205 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, skip new failing tests.
ossy@webkit.org [Tue, 31 Jul 2012 15:37:40 +0000 (15:37 +0000)]
[Qt] Unreviewed gardening, skip new failing tests.

* platform/qt/Skipped:
* platform/qt/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][WK2] Unreviewed gardening. Skip failing tests and remove unnecessary expected...
ossy@webkit.org [Tue, 31 Jul 2012 15:20:54 +0000 (15:20 +0000)]
[Qt][WK2] Unreviewed gardening. Skip failing tests and remove unnecessary expected files. (bug85203)

* platform/qt-5.0-wk2/Skipped:
* platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
* platform/qt-5.0-wk2/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/dynamic/008-expected.png: Removed.
* platform/qt-5.0-wk2/fast/dynamic/008-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.png: Removed.
* platform/qt-5.0-wk2/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
* platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.png: Removed.
* platform/qt-5.0-wk2/fast/parser/open-comment-in-textarea-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, rebaseline some platform/chromium/virtual/gpu/fast/canvas...
apavlov@chromium.org [Tue, 31 Jul 2012 15:15:28 +0000 (15:15 +0000)]
[Chromium] Unreviewed, rebaseline some platform/chromium/virtual/gpu/fast/canvas tests due to antialiasing changes.

* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png: Added.
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/arc360-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-composite-transformclip-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/canvas-transform-skewed-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124202 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWeb Inspector: take into account the whole security origin instead of just host
commit-queue@webkit.org [Tue, 31 Jul 2012 15:05:44 +0000 (15:05 +0000)]
Web Inspector: take into account the whole security origin instead of just host
https://bugs.webkit.org/show_bug.cgi?id=92740

Patch by Alexei Filippov <alexeif@chromium.org> on 2012-07-31
Reviewed by Pavel Feldman.

Source/WebCore:

Make the DOM Storage Agent take into account all the
information relevant to the security origin, i.e. protocol, host, and
port. Previously only the host was taken into account. That caused
inspector to show the first storage only in the case a page operated
over several security origins sharing the same host (but having
different protocols e.g. http and https).

* inspector/InspectorDOMStorageAgent.cpp:
(WebCore::InspectorDOMStorageAgent::storageId):
(WebCore::InspectorDOMStorageAgent::didUseDOMStorage):
* inspector/InspectorDOMStorageResource.cpp:
(WebCore::InspectorDOMStorageResource::isSameOriginAndType):
(WebCore::InspectorDOMStorageResource::bind):
* inspector/InspectorDOMStorageResource.h:
(InspectorDOMStorageResource):

LayoutTests:

* http/tests/inspector-enabled/dom-storage-open-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[WK2] Visible content rect update with null trajectory vector does not reach the...
abecsi@webkit.org [Tue, 31 Jul 2012 14:41:37 +0000 (14:41 +0000)]
[WK2] Visible content rect update with null trajectory vector does not reach the backing store
https://bugs.webkit.org/show_bug.cgi?id=92750

Reviewed by Jocelyn Turcotte.

Make sure that notifications with a null trajectory vector reach the backing store
since a null vector means that all tiles around the viewport were requested.

* WebProcess/WebPage/LayerTreeCoordinator/LayerTreeCoordinator.cpp:
(WebKit::LayerTreeCoordinator::setVisibleContentsRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124200 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[BlackBerry] Backing store output flickers when using WebPageCompositor
commit-queue@webkit.org [Tue, 31 Jul 2012 14:35:24 +0000 (14:35 +0000)]
[BlackBerry] Backing store output flickers when using WebPageCompositor
https://bugs.webkit.org/show_bug.cgi?id=90291

Patch by Arvid Nilsson <anilsson@rim.com> on 2012-07-31
Reviewed by Antonio Gomes.

The backing store doesn't know when the API client swaps the buffers,
so it doesn't know when to signal the blit generation condition
variable. Fixed by using EGL fence sync instead, when available, so we
don't have to know.

Reviewed internally by Filip Spacek.

* Api/BackingStore.cpp:
(BlackBerry::WebKit::BackingStorePrivate::BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::~BackingStorePrivate):
(BlackBerry::WebKit::BackingStorePrivate::render):
(BlackBerry::WebKit::BackingStorePrivate::blitContents):
(BlackBerry::WebKit::BackingStorePrivate::compositeContents):
* Api/BackingStore_p.h:
(BackingStorePrivate):
* WebKitSupport/BackingStoreTile.cpp:
(BlackBerry::WebKit::TileBuffer::TileBuffer):
* WebKitSupport/BackingStoreTile.h:
(BlackBerry::WebKit::TileBuffer::syncObject):
(BlackBerry::WebKit::TileBuffer::setSyncObject):
(TileBuffer):
* WebKitSupport/SurfacePool.cpp:
(WebKit):
(BlackBerry::WebKit::SurfacePool::SurfacePool):
(BlackBerry::WebKit::SurfacePool::initialize):
(BlackBerry::WebKit::SurfacePool::waitForBuffer):
(BlackBerry::WebKit::SurfacePool::notifyBuffersComposited):
* WebKitSupport/SurfacePool.h:
(SurfacePool):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoSlider ticks are drawn at wrong positions
keishi@webkit.org [Tue, 31 Jul 2012 13:50:39 +0000 (13:50 +0000)]
Slider ticks are drawn at wrong positions
https://bugs.webkit.org/show_bug.cgi?id=92720

Reviewed by Kent Tamura.

Source/WebCore:

Slider tick marks for vertical sliders were drawn reversed. And the tick
mark positions were slightly off from the thumb position because of rounding.

No new tests. Covered in input-appearance-range-with-datalist.html.

* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::paintSliderTicks):

LayoutTests:

* fast/forms/datalist/input-appearance-range-with-datalist.html: Added values to input elements so we can see if the slider thumb position matches with the tick marks.
* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
* platform/chromium-linux/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-expected.png:
* platform/chromium-mac/fast/forms/datalist/input-appearance-range-with-datalist-zoomed-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Input method update should also include hints
commit-queue@webkit.org [Tue, 31 Jul 2012 13:42:08 +0000 (13:42 +0000)]
[Qt] Input method update should also include hints
https://bugs.webkit.org/show_bug.cgi?id=92744

Patch by Marcelo Lira <marcelo.lira@openbossa.org> on 2012-07-31
Reviewed by Simon Hausmann.

The QInputMethod is told to query for input method hints when updated.

* UIProcess/qt/QtWebPageEventHandler.cpp:
(WebKit::QtWebPageEventHandler::updateTextInputState):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoOlder ShadowDOM is still rendered when a new ShadowDOM is added when they don't have...
shinyak@chromium.org [Tue, 31 Jul 2012 13:15:26 +0000 (13:15 +0000)]
Older ShadowDOM is still rendered when a new ShadowDOM is added when they don't have any InsertionPoints.
https://bugs.webkit.org/show_bug.cgi?id=92456

Reviewed by Hajime Morita.

Source/WebCore:

When adding a new ShadowRoot to an element having other ShadowRoots, and they don't have any InsretionPoint,
the older ShadowDOM is still rendered.

When ContentDistributor's validity is 'Undetermined', ElementShadow reattaches the host and the whole shadow
subtree. Since adding a new ShadowRoot makes the validity 'Undetermined', we have had to make it 'Undetermined'.

This change enables us to remove a unnecessary InvalidationType flag from the code. We should call
setValidityUndetermined() instead of using InvalidateAndForceReattach.

Test: fast/dom/shadow/invalidate-distribution.html

* dom/ElementShadow.cpp:
(WebCore::ElementShadow::addShadowRoot): Calls setValidityUndetermined().
(WebCore::ElementShadow::removeAllShadowRoots):
(WebCore::ElementShadow::setValidityUndetermined):
(WebCore::ElementShadow::invalidateDistribution): When validity is undetermined, we will reattach the
host and the shadow subtree.
* dom/ElementShadow.h:
(ElementShadow):
* html/shadow/ContentDistributor.cpp:
* html/shadow/ContentDistributor.h:
(WebCore::ContentDistributor::setValidity):
(ContentDistributor):
* html/shadow/InsertionPoint.cpp:
(WebCore::InsertionPoint::insertedInto): Calls setValidityUndetermined().

LayoutTests:

* fast/dom/shadow/invalidate-distribution-expected.html: Added.
* fast/dom/shadow/invalidate-distribution.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124196 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] move EventSender into TestRunner.a
jochen@chromium.org [Tue, 31 Jul 2012 13:02:39 +0000 (13:02 +0000)]
[chromium] move EventSender into TestRunner.a
https://bugs.webkit.org/show_bug.cgi?id=92277

Reviewed by Adam Barth.

* DumpRenderTree/DumpRenderTree.gypi:
* DumpRenderTree/DumpRenderTree.gyp/DumpRenderTree.gyp:
* DumpRenderTree/chromium/TestRunner/EventSender.cpp: Renamed from Tools/DumpRenderTree/chromium/EventSender.cpp.
* DumpRenderTree/chromium/TestRunner/EventSender.h: Renamed from Tools/DumpRenderTree/chromium/EventSender.h.
* DumpRenderTree/chromium/TestRunner/TestInterfaces.cpp:
(TestInterfaces::Internal::eventSender):
(TestInterfaces::Internal):
(TestInterfaces::Internal::Internal):
(TestInterfaces::Internal::~Internal):
(TestInterfaces::Internal::setWebView):
(TestInterfaces::Internal::setDelegate):
(TestInterfaces::Internal::bindTo):
(TestInterfaces::Internal::resetAll):
(TestInterfaces::eventSender):
* DumpRenderTree/chromium/TestRunner/TestInterfaces.h:
(TestInterfaces):
* DumpRenderTree/chromium/TestShell.cpp:
(TestShell::initialize):
(TestShell::createMainWindow):
(TestShell::~TestShell):
(TestShell::resetTestController):
(TestShell::bindJSObjectsToWindow):
* DumpRenderTree/chromium/TestShell.h:
(TestShell::eventSender):
(TestShell):
* DumpRenderTree/chromium/WebViewHost.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124195 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening, remove unnecessary expected files.
ossy@webkit.org [Tue, 31 Jul 2012 12:57:34 +0000 (12:57 +0000)]
[Qt] Unreviewed gardening, remove unnecessary expected files.

* platform/qt-5.0/fast/css/beforeSelectorOnCodeElement-expected.txt: Removed.
* platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.png: Removed.
* platform/qt-5.0/fast/dom/HTMLTextAreaElement/reset-textarea-expected.txt: Removed.
* platform/qt-5.0/fast/dynamic/008-expected.png: Removed.
* platform/qt-5.0/fast/dynamic/008-expected.txt: Removed.
* platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.png: Removed.
* platform/qt-5.0/fast/html/font-weight-bold-for-b-and-strong-expected.txt: Removed.
* platform/qt-5.0/fast/inline/left-right-center-inline-alignment-in-ltr-and-rtl-blocks-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124194 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIntroduce a minimal RTCPeerConnection together with Dictionary changes
tommyw@google.com [Tue, 31 Jul 2012 11:59:37 +0000 (11:59 +0000)]
Introduce a minimal RTCPeerConnection together with Dictionary changes
https://bugs.webkit.org/show_bug.cgi?id=92380

Reviewed by Kentaro Hara.

Source/WebCore:

This patch introduces a shell RTCPeerConnection together with neccecary changes to
Dictionary.

The W3C specification can be found here:
http://dev.w3.org/2011/webrtc/editor/webrtc.html#rtcpeerconnection

Since Dictionaries can't be fully copied around adding
get(const String& name, Vector<Dictionary>& result)
isn't feasible so I have added a new ArrayValue class.

Test: fast/mediastream/RTCPeerConnection.html

* CMakeLists.txt:
* GNUmakefile.list.am:
* Modules/mediastream/DOMWindowMediaStream.idl:
* Modules/mediastream/RTCPeerConnection.cpp: Added.
(WebCore):
(RTCIceServer):
(WebCore::RTCIceServer::create):
(WebCore::RTCIceServer::~RTCIceServer):
(WebCore::RTCIceServer::uri):
(WebCore::RTCIceServer::credential):
(WebCore::RTCIceServer::RTCIceServer):
(RTCConfiguration):
(WebCore::RTCConfiguration::create):
(WebCore::RTCConfiguration::~RTCConfiguration):
(WebCore::RTCConfiguration::appendServer):
(WebCore::RTCConfiguration::numberOfServers):
(WebCore::RTCConfiguration::server):
(WebCore::RTCConfiguration::RTCConfiguration):
(WebCore::RTCPeerConnection::parseConfiguration):
(WebCore::RTCPeerConnection::create):
(WebCore::RTCPeerConnection::RTCPeerConnection):
(WebCore::RTCPeerConnection::~RTCPeerConnection):
(WebCore::RTCPeerConnection::interfaceName):
(WebCore::RTCPeerConnection::scriptExecutionContext):
(WebCore::RTCPeerConnection::stop):
(WebCore::RTCPeerConnection::eventTargetData):
(WebCore::RTCPeerConnection::ensureEventTargetData):
* Modules/mediastream/RTCPeerConnection.h: Added.
(WebCore):
(RTCPeerConnection):
(WebCore::RTCPeerConnection::refEventTarget):
(WebCore::RTCPeerConnection::derefEventTarget):
* Modules/mediastream/RTCPeerConnection.idl: Added.
* Target.pri:
* UseJSC.cmake:
* WebCore.gypi:
* WebCore.vcproj/WebCore.vcproj:
* WebCore.xcodeproj/project.pbxproj:
* bindings/generic/RuntimeEnabledFeatures.h:
(WebCore::RuntimeEnabledFeatures::webkitRTCPeerConnectionEnabled):
* bindings/js/ArrayValue.cpp: Added.
(WebCore):
(WebCore::ArrayValue::ArrayValue):
(WebCore::ArrayValue::operator=):
(WebCore::ArrayValue::isUndefinedOrNull):
(WebCore::ArrayValue::length):
(WebCore::ArrayValue::get):
* bindings/js/ArrayValue.h: Added.
(WebCore):
(ArrayValue):
* bindings/js/JSBindingsAllInOne.cpp:
* bindings/js/JSDictionary.cpp:
(WebCore::JSDictionary::convertValue):
(WebCore):
* bindings/js/JSDictionary.h:
(WebCore):
* bindings/v8/ArrayValue.cpp: Added.
(WebCore):
(WebCore::ArrayValue::operator=):
(WebCore::ArrayValue::isUndefinedOrNull):
(WebCore::ArrayValue::length):
(WebCore::ArrayValue::get):
* bindings/v8/ArrayValue.h: Added.
(WebCore):
(ArrayValue):
(WebCore::ArrayValue::ArrayValue):
(WebCore::ArrayValue::~ArrayValue):
* bindings/v8/Dictionary.cpp:
(WebCore::Dictionary::get):
(WebCore):
* bindings/v8/Dictionary.h:
(WebCore):
(Dictionary):
* dom/EventTargetFactory.in:

LayoutTests:

* fast/mediastream/RTCPeerConnection-expected.txt: Added.
* fast/mediastream/RTCPeerConnection.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt][EFL] New inspector/styles/region-style-crash.html introduced in r124186 fails
ossy@webkit.org [Tue, 31 Jul 2012 11:28:49 +0000 (11:28 +0000)]
[Qt][EFL] New inspector/styles/region-style-crash.html introduced in r124186 fails
https://bugs.webkit.org/show_bug.cgi?id=91503

Patch by János Badics <jbadics@inf.u-szeged.hu> on 2012-07-31
Reviewed by Csaba Osztrogonác.

* platform/qt/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening after r124189, remove unnecessary expected files.
ossy@webkit.org [Tue, 31 Jul 2012 11:27:53 +0000 (11:27 +0000)]
[Qt] Unreviewed gardening after r124189, remove unnecessary expected files.

* platform/qt-4.8/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt: Renamed from LayoutTests/platform/qt/http/tests/security/xss-DENIED-xsl-document-securityOrigin-expected.txt.
* platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.png: Removed.
* platform/qt-5.0/fast/dynamic/insert-before-table-part-in-continuation-expected.txt: Removed.
* platform/qt-5.0/fast/images/object-image-expected.txt: Added.
* platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.png: Removed.
* platform/qt-5.0/fast/parser/entity-comment-in-textarea-expected.txt: Removed.
* platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.png: Removed.
* platform/qt-5.0/fast/parser/open-comment-in-textarea-expected.txt: Removed.
* platform/qt-5.0/fast/repaint/continuation-after-outline-expected.txt: Removed.
* platform/qt-5.0/fast/replaced/three-selects-break-expected.png: Removed.
* platform/qt-5.0/fast/replaced/three-selects-break-expected.txt: Removed.
* platform/qt-5.0/fast/writing-mode/fallback-orientation-expected.txt: Removed.
* platform/qt-5.0/fast/xsl/document-function-expected.png: Removed.
* platform/qt-5.0/fast/xsl/document-function-expected.txt: Removed.
* platform/qt-5.0/fast/xsl/xslt-entity-expected.png: Removed.
* platform/qt-5.0/fast/xsl/xslt-entity-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/coords-units-03-b-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1-SE/styling-css-04-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/animate-elem-06-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/filters-light-04-f-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-06-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-07-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-elems-08-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-01-b-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/render-groups-03-t-expected.txt: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.png: Removed.
* platform/qt-5.0/svg/W3C-SVG-1.1/text-text-01-b-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Update watchlist
jochen@chromium.org [Tue, 31 Jul 2012 10:46:04 +0000 (10:46 +0000)]
Unreviewed. Update watchlist

* Scripts/webkitpy/common/config/watchlist: Turned out to be less useful than I had hoped

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124190 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Qt] Unreviewed gardening. Unskip passing tests and add new expected files. (bug85203)
ossy@webkit.org [Tue, 31 Jul 2012 10:33:02 +0000 (10:33 +0000)]
[Qt] Unreviewed gardening. Unskip passing tests and add new expected files. (bug85203)

* platform/qt-5.0/Skipped: Unskip passing tests.
* platform/qt/Skipped: Skip the remaining failing tests and add bug reports.
* platform/qt/css2.1/t040103-ident-03-c-expected.png: Added.
* platform/qt/css2.1/t040103-ident-03-c-expected.txt: Added.
* platform/qt/editing/pasteboard/4242293-1-expected.txt:
* platform/qt/editing/pasteboard/5761530-1-expected.txt: Added.
* platform/qt/fast/backgrounds/mask-box-image-expected.png:
* platform/qt/fast/backgrounds/mask-box-image-expected.txt:
* platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.png: Copied from LayoutTests/platform/qt/fast/invalid/020-expected.png.
* platform/qt/fast/backgrounds/repeat/noRepeatCorrectClip-expected.txt:
* platform/qt/fast/backgrounds/svg-as-mask-expected.png:
* platform/qt/fast/backgrounds/svg-as-mask-expected.txt:
* platform/qt/fast/block/positioning/051-expected.png:
* platform/qt/fast/block/positioning/051-expected.txt:
* platform/qt/fast/compact/003-expected.png:
* platform/qt/fast/compact/003-expected.txt:
* platform/qt/fast/css-generated-content/010-expected.png:
* platform/qt/fast/css-generated-content/010-expected.txt:
* platform/qt/fast/css-grid-layout/place-cell-by-index-expected.txt: Added.
* platform/qt/fast/css/font-face-descending-unicode-range-expected.txt:
* platform/qt/fast/css/font-face-font-family-descriptor-expected.txt:
* platform/qt/fast/css/imageTileOpacity-expected.png:
* platform/qt/fast/css/imageTileOpacity-expected.txt:
* platform/qt/fast/css/live-cssrules-expected.png:
* platform/qt/fast/css/live-cssrules-expected.txt:
* platform/qt/fast/css/rgba-custom-text-expected.txt: Added.
* platform/qt/fast/css/rtl-to-viewport-expected.png:
* platform/qt/fast/css/rtl-to-viewport-expected.txt:
* platform/qt/fast/css/vertical-align-lengths-expected.png:
* platform/qt/fast/css/vertical-align-lengths-expected.txt:
* platform/qt/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.png:
* platform/qt/fast/dom/HTMLDocument/frameless-location-bugzilla10837-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead1-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead1-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead2-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead2-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead3-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead3-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead4-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead4-expected.txt:
* platform/qt/fast/dom/HTMLHeadElement/textInHead5-expected.png:
* platform/qt/fast/dom/HTMLHeadElement/textInHead5-expected.txt:
* platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.txt:
* platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png:
* platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.txt:
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.png:
* platform/qt/fast/dom/HTMLProgressElement/progress-element-expected.txt:
* platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png:
* platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.txt:
* platform/qt/fast/dom/comment-not-documentElement-expected.png:
* platform/qt/fast/dom/comment-not-documentElement-expected.txt:
* platform/qt/fast/dom/icon-url-change-expected.txt: Added.
* platform/qt/fast/dom/icon-url-list-expected.txt: Added.
* platform/qt/fast/dynamic/010-expected.png:
* platform/qt/fast/dynamic/010-expected.txt:
* platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png.
* platform/qt/fast/dynamic/float-in-trailing-whitespace-after-last-line-break-2-expected.txt:
* platform/qt/fast/dynamic/genContentDestroyChildren-expected.png: Added.
* platform/qt/fast/dynamic/genContentDestroyChildren-expected.txt:
* platform/qt/fast/dynamic/move-node-with-selection-expected.png:
* platform/qt/fast/dynamic/move-node-with-selection-expected.txt:
* platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.png:
* platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.txt:
* platform/qt/fast/html/details-add-summary-1-expected.png:
* platform/qt/fast/html/details-add-summary-1-expected.txt:
* platform/qt/fast/html/details-add-summary-10-expected.png:
* platform/qt/fast/html/details-add-summary-10-expected.txt:
* platform/qt/fast/html/details-add-summary-2-expected.png:
* platform/qt/fast/html/details-add-summary-2-expected.txt:
* platform/qt/fast/html/details-add-summary-3-expected.png:
* platform/qt/fast/html/details-add-summary-3-expected.txt:
* platform/qt/fast/html/details-add-summary-4-expected.png:
* platform/qt/fast/html/details-add-summary-4-expected.txt:
* platform/qt/fast/html/details-add-summary-5-expected.png:
* platform/qt/fast/html/details-add-summary-5-expected.txt:
* platform/qt/fast/html/details-add-summary-6-expected.png:
* platform/qt/fast/html/details-add-summary-6-expected.txt:
* platform/qt/fast/html/details-add-summary-7-expected.png:
* platform/qt/fast/html/details-add-summary-7-expected.txt:
* platform/qt/fast/html/details-add-summary-8-expected.png:
* platform/qt/fast/html/details-add-summary-8-expected.txt:
* platform/qt/fast/html/details-add-summary-9-expected.png:
* platform/qt/fast/html/details-add-summary-9-expected.txt:
* platform/qt/fast/html/details-no-summary1-expected.png:
* platform/qt/fast/html/details-no-summary1-expected.txt:
* platform/qt/fast/html/details-no-summary2-expected.png:
* platform/qt/fast/html/details-no-summary2-expected.txt:
* platform/qt/fast/html/details-no-summary3-expected.png:
* platform/qt/fast/html/details-no-summary3-expected.txt:
* platform/qt/fast/html/details-open1-expected.png:
* platform/qt/fast/html/details-open1-expected.txt:
* platform/qt/fast/html/details-open3-expected.png:
* platform/qt/fast/html/details-open3-expected.txt:
* platform/qt/fast/html/details-open5-expected.png:
* platform/qt/fast/html/details-open5-expected.txt:
* platform/qt/fast/html/details-open6-expected.png:
* platform/qt/fast/html/details-open6-expected.txt:
* platform/qt/fast/html/details-remove-summary-1-expected.png:
* platform/qt/fast/html/details-remove-summary-1-expected.txt:
* platform/qt/fast/html/details-remove-summary-2-expected.png:
* platform/qt/fast/html/details-remove-summary-2-expected.txt:
* platform/qt/fast/html/details-remove-summary-3-expected.png:
* platform/qt/fast/html/details-remove-summary-3-expected.txt:
* platform/qt/fast/html/details-remove-summary-4-expected.png:
* platform/qt/fast/html/details-remove-summary-4-expected.txt:
* platform/qt/fast/html/details-remove-summary-5-expected.png:
* platform/qt/fast/html/details-remove-summary-5-expected.txt:
* platform/qt/fast/html/details-remove-summary-6-expected.png:
* platform/qt/fast/html/details-remove-summary-6-expected.txt:
* platform/qt/fast/images/image-in-map-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/selection-clear-expected.png.
* platform/qt/fast/images/image-in-map-expected.txt:
* platform/qt/fast/inline/002-expected.png: Copied from LayoutTests/platform/qt/fast/dynamic/010-expected.png.
* platform/qt/fast/inline/002-expected.txt:
* platform/qt/fast/inline/inline-fixed-position-boundingbox-expected.txt: Added.
* platform/qt/fast/inline/inline-relative-offset-boundingbox-expected.txt: Added.
* platform/qt/fast/inline/positioned-object-between-replaced-elements-expected.txt:
* platform/qt/fast/inline/positionedLifetime-expected.png: Copied from LayoutTests/platform/qt/fast/repaint/continuation-after-outline-expected.png.
* platform/qt/fast/inline/positionedLifetime-expected.txt:
* platform/qt/fast/invalid/005-expected.png: Copied from LayoutTests/platform/qt/fast/dom/comment-not-documentElement-expected.png.
* platform/qt/fast/invalid/005-expected.txt:
* platform/qt/fast/invalid/007-expected.png: Copied from LayoutTests/platform/qt/fast/html/details-remove-summary-6-expected.png.
* platform/qt/fast/invalid/007-expected.txt:
* platform/qt/fast/invalid/020-expected.png:
* platform/qt/fast/invalid/020-expected.txt:
* platform/qt/fast/lists/004-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
* platform/qt/fast/lists/004-expected.txt:
* platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
* platform/qt/fast/lists/inlineBoxWrapperNullCheck-expected.txt:
* platform/qt/fast/lists/ol-start-dynamic-expected.png: Copied from LayoutTests/platform/qt/fast/html/details-no-summary2-expected.png.
* platform/qt/fast/lists/ol-start-dynamic-expected.txt:
* platform/qt/fast/multicol/hit-test-gap-between-pages-expected.txt: Added.
* platform/qt/fast/multicol/table-vertical-align-expected.txt:
* platform/qt/fast/multicol/vertical-rl/rule-style-expected.txt:
* platform/qt/fast/parser/tabs-in-scripts-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-element-repaint-on-update-value-expected.png.
* platform/qt/fast/parser/tabs-in-scripts-expected.txt:
* platform/qt/fast/reflections/reflection-direction-expected.png: Added.
* platform/qt/fast/reflections/reflection-direction-expected.txt:
* platform/qt/fast/reflections/reflection-masks-expected.png: Added.
* platform/qt/fast/reflections/reflection-masks-expected.txt:
* platform/qt/fast/reflections/reflection-masks-opacity-expected.png: Added.
* platform/qt/fast/reflections/reflection-masks-opacity-expected.txt:
* platform/qt/fast/repaint/block-no-inflow-children-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLProgressElement/progress-writing-mode-expected.png.
* platform/qt/fast/repaint/block-no-inflow-children-expected.txt:
* platform/qt/fast/repaint/button-spurious-layout-hint-expected.txt:
* platform/qt/fast/repaint/clip-with-layout-delta-expected.txt:
* platform/qt/fast/repaint/continuation-after-outline-expected.png:
* platform/qt/fast/repaint/continuation-after-outline-expected.txt:
* platform/qt/fast/repaint/float-overflow-expected.png:
* platform/qt/fast/repaint/float-overflow-expected.txt:
* platform/qt/fast/repaint/float-overflow-right-expected.png:
* platform/qt/fast/repaint/float-overflow-right-expected.txt:
* platform/qt/fast/repaint/gradients-em-stops-repaint-expected.png:
* platform/qt/fast/repaint/gradients-em-stops-repaint-expected.txt:
* platform/qt/fast/repaint/iframe-scroll-repaint-expected.txt:
* platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.png: Copied from LayoutTests/platform/qt/fast/dom/HTMLMeterElement/meter-writing-mode-expected.png.
* platform/qt/fast/repaint/line-in-scrolled-clipped-block-expected.txt:
* platform/qt/fast/repaint/lines-with-layout-delta-expected.png:
* platform/qt/fast/repaint/lines-with-layout-delta-expected.txt:
* platform/qt/fast/repaint/reflection-repaint-test-expected.png:
* platform/qt/fast/repaint/reflection-repaint-test-expected.txt:
* platform/qt/fast/repaint/repaint-svg-after-style-change-expected.png: Copied from LayoutTests/platform/qt/fast/dynamic/positioned-movement-with-positioned-children-expected.png.
* platform/qt/fast/repaint/repaint-svg-after-style-change-expected.txt:
* platform/qt/fast/repaint/selection-clear-expected.png:
* platform/qt/fast/repaint/selection-clear-expected.txt:
* platform/qt/fast/repaint/transform-layout-repaint-expected.png:
* platform/qt/fast/repaint/transform-layout-repaint-expected.txt:
* platform/qt/fast/replaced/image-onload-expected.png:
* platform/qt/fast/replaced/image-onload-expected.txt:
* platform/qt/fast/runin/002-expected.png:
* platform/qt/fast/runin/002-expected.txt:
* platform/qt/fast/runin/generated4-expected.png:
* platform/qt/fast/runin/generated4-expected.txt:
* platform/qt/svg/custom/use-instanceRoot-event-listeners-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, update watchlist
tkent@chromium.org [Tue, 31 Jul 2012 10:22:02 +0000 (10:22 +0000)]
Unreviewed, update watchlist

* Scripts/webkitpy/common/config/watchlist:
- Improve "Forms" filename pattern.
- tkent stops watching Chromium DRT. It was not so helpful.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Unreviewed, handle more tests failing after r124052.
apavlov@chromium.org [Tue, 31 Jul 2012 10:20:33 +0000 (10:20 +0000)]
[Chromium] Unreviewed, handle more tests failing after r124052.

* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoInspector crashes when trying to inspect a page with CSS region styling
commit-queue@webkit.org [Tue, 31 Jul 2012 10:08:45 +0000 (10:08 +0000)]
Inspector crashes when trying to inspect a page with CSS region styling
https://bugs.webkit.org/show_bug.cgi?id=91503

Patch by Raul Hudea <rhudea@adobe.com> on 2012-07-31
Reviewed by Alexander Pavlov.

Source/WebCore:

Fix by making sure a CSSRuleSourceData is always created when parsing @-webkit-region rules.

Test: inspector/styles/region-style-crash.html

* css/CSSGrammar.y: Made ruleset called explicitly markRuleBodyStart instead of depending on updateLastSelectorLineAndPosition to call it.
* css/CSSParser.cpp:
(WebCore::CSSParser::updateLastSelectorLineAndPosition): markRuleBodyStart should be called via at_rule_body_start.
* css/CSSPropertySourceData.h:

LayoutTests:

Test to make sure inspector is not crashing when having to parse @-webkit-region rules

* inspector/styles/region-style-crash-expected.txt: Added.
* inspector/styles/region-style-crash.html: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r124179.
commit-queue@webkit.org [Tue, 31 Jul 2012 09:41:08 +0000 (09:41 +0000)]
Unreviewed, rolling out r124179.
http://trac.webkit.org/changeset/124179
https://bugs.webkit.org/show_bug.cgi?id=92730

Breaks Chromium Linux 32 bots with "error: integer constant is
too large for 'long' type" in IDBLevelDBCodingTest.cpp
(Requested by apavlov on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-31

Source/WebCore:

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeByte):
(WebCore::IDBLevelDBCoding::encodeBool):
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):
(WebCore::IDBLevelDBCoding::encodeDouble):
(WebCore::IDBLevelDBCoding::encodeIDBKey):
(WebCore::IDBLevelDBCoding::encodeIDBKeyPath):
(WebCore::IDBLevelDBCoding::KeyPrefix::encode):
* Modules/indexeddb/IDBLevelDBCoding.h:
(IDBLevelDBCoding):

Source/WebKit/chromium:

* tests/IDBLevelDBCodingTest.cpp:
(IDBLevelDBCoding::TEST):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoPerf-o-matic: dashboard images are not generated properly from incrementally updated...
rniwa@webkit.org [Tue, 31 Jul 2012 09:00:33 +0000 (09:00 +0000)]
Perf-o-matic: dashboard images are not generated properly from incrementally updated JSON
https://bugs.webkit.org/show_bug.cgi?id=92717

Reviewed by Hajime Morita.

Sort the values by timestamp. Unfortunately, there isn't a good way of testing this fix.

* Websites/webkit-perf.appspot.com/models.py:
(Runs.chart_params):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124184 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[jhbuild] Also try to load jhbuild Python module from the source checkout
mrobinson@webkit.org [Tue, 31 Jul 2012 08:53:05 +0000 (08:53 +0000)]
[jhbuild] Also try to load jhbuild Python module from the source checkout

Reviewed by Philippe Normand.

JHBuild also seems to have an installation mode where it prefers to load its
Python modules from the source checkout. This seems to be used particularly
on the GTK+ 64-bit release bot. We should fall back to this mode.

* jhbuild/jhbuildutils.py:
(enter_jhbuild_environment_if_available): Use the source checkout if there
is no installation path.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoadd Farstream flags/deps to WebKit, for WebRTC
commit-queue@webkit.org [Tue, 31 Jul 2012 08:46:59 +0000 (08:46 +0000)]
add Farstream flags/deps to WebKit, for WebRTC
https://bugs.webkit.org/show_bug.cgi?id=87524

Patch by Danilo Cesar Lemes de Paula <danilo.cesar@collabora.co.uk> on 2012-07-31
Reviewed by Philippe Normand.

Since Farstream will be used as the backend for GTK's WebRTC, this
patch adds it as a dependency to the build system.

.:

* GNUmakefile.am:
* configure.ac:

Source/WebCore:

No new features or code changes were added, so new tests aren't necessary.

* GNUmakefile.am:

Source/WebKit2:

* GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed crash fix after r124135.
zandobersek@gmail.com [Tue, 31 Jul 2012 08:09:49 +0000 (08:09 +0000)]
Unreviewed crash fix after r124135.

* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path): Ensure the Cairo path when acquiring its context,
crashes ensue otherwise.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124181 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoChange Element::isReadOnlyFormControl to Element::shouldMatchReadOnlySelector/shouldM...
yosin@chromium.org [Tue, 31 Jul 2012 07:58:47 +0000 (07:58 +0000)]
Change Element::isReadOnlyFormControl to Element::shouldMatchReadOnlySelector/shouldMatchReadWriteSelector or HTMLFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602

Reviewed by Kent Tamura.

This patch replaces Element::isReadOnlyFormControl() by
Element::shouldMatchReadOnlySelector/shouldMatchReadOnlySelector or
HTMLFormControlElement::readOnly() to make intention of functions
self descriptive.

No new tests. This patch doesn't change behavior.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class, and replaced isReadOnlyFormControl() by shouldMatchReadOnlySelector() for :read-only pseudo class.
* dom/Element.cpp:
(WebCore::Element::shouldMatchReadOnlySelector): Added for default implementation.
(WebCore::Element::shouldMatchReadWriteSelector): for default implementation.
* dom/Element.h:
(Element): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
* html/HTMLFormControlElement.cpp:
(WebCore::HTMLFormControlElement::shouldMatchReadOnlySelector): Added.
(WebCore::HTMLFormControlElement::shouldMatchReadWriteSelector): Added.
* html/HTMLFormControlElement.h:
(HTMLFormControlElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shouldMatchReadOnlySelector): Added.
(WebCore::SliderThumbElement::shouldMatchReadWriteSelector): Added.
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SliderThumbElement::willRespondToMouseClickEvents): ditto.
(SliderThumbElement):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): ditto.
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): ditto.
(WebCore::SpinButtonElement::shouldMatchReadOnlySelector): Added.
(WebCore::SpinButtonElement::shouldMatchReadWriteSelector): Added.
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
* html/shadow/TextControlInnerElements.h:
(SpinButtonElement): Removed isReadOnlyFormControl() and added shouldMatchReadOnlySelector and shouldMatchReadWriteSelector.
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl): Replaced isReadOnlyControl() by shouldMatchReadOnlySelector().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoIndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
commit-queue@webkit.org [Tue, 31 Jul 2012 07:12:23 +0000 (07:12 +0000)]
IndexedDB: Size the Vector in encodeInt/encodeVarInt/encodeString
https://bugs.webkit.org/show_bug.cgi?id=91813

Patch by Xingnan Wang <xingnan.wang@intel.com> on 2012-07-31
Reviewed by Kentaro Hara.

To avoid memory re-allocation in Vector, init the capability or size of Vector in encodeInt(), encodeVarInt(),
encodeBool(), encodeIDBKey() etc.

No new tests - Low level functions covered by existing layout tests and also covered by Chromium
webkit_unit_tests IDBLevelIDBCodingTest.* which validates the sizes of buffers returned by encodeVarInt.

* Modules/indexeddb/IDBLevelDBCoding.cpp:
(WebCore::IDBLevelDBCoding::encodeInt):
(WebCore::IDBLevelDBCoding::encodeVarInt):
(WebCore::IDBLevelDBCoding::encodeString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Texmap] Remove the backing store after 'style.visibility' for an element sets 'hidden'.
commit-queue@webkit.org [Tue, 31 Jul 2012 06:55:55 +0000 (06:55 +0000)]
[Texmap] Remove the backing store after 'style.visibility' for an element sets 'hidden'.
https://bugs.webkit.org/show_bug.cgi?id=92492

Patch by Huang Dongsung <luxtella@company100.net> on 2012-07-30
Reviewed by Noam Rosenthal.

Source/WebCore:

This patch's purpose is to save vram memory.
When visibility of the element sets hidden, we do not need to draw the element,
so we do not need to keep a texture of the backing store.
Currently, Texmap does not draw the element with visibility:hidden because
RenderLayerBacking::paintIntoLayer does not draw anything.
This patch just removes unused textures.

No new tests - no new testable functionality.

* platform/graphics/texmap/GraphicsLayerTextureMapper.cpp:
(WebCore::GraphicsLayerTextureMapper::setContentsVisible):
(WebCore):
* platform/graphics/texmap/GraphicsLayerTextureMapper.h:
(GraphicsLayerTextureMapper):
* platform/graphics/texmap/TextureMapperLayer.cpp:
(WebCore::TextureMapperLayer::updateBackingStore):
(WebCore::TextureMapperLayer::paintSelf):
(WebCore::TextureMapperLayer::isVisible):
(WebCore::TextureMapperLayer::syncCompositingStateSelf):
* platform/graphics/texmap/TextureMapperLayer.h:
(State):
(WebCore::TextureMapperLayer::State::State):

Source/WebKit2:

Texmap handles visibility:hidden in this patch, so WebGraphicsLayer
sends the LayerTreeCoordinatorProxyMessages with additional infomation
to UIProcess.

* Shared/WebLayerTreeInfo.h:
* UIProcess/WebLayerTreeRenderer.cpp:
(WebKit::WebLayerTreeRenderer::setLayerState):
* WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.cpp:
(WebCore::WebGraphicsLayer::setContentsVisible):
(WebCore):
(WebCore::WebGraphicsLayer::syncLayerState):
* WebProcess/WebPage/LayerTreeCoordinator/WebGraphicsLayer.h:
(WebGraphicsLayer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[GTK] New lines automatically and repeatedly added to list items in Etherpad
commit-queue@webkit.org [Tue, 31 Jul 2012 06:52:49 +0000 (06:52 +0000)]
[GTK] New lines automatically and repeatedly added to list items in Etherpad
https://bugs.webkit.org/show_bug.cgi?id=89971

Patch by Martin Robinson <mrobinson@igalia.com> on 2012-07-30
Reviewed by Ryosuke Niwa.

Disable the deletion UI by default. This UI, which was enabled as a side-effect
of the addition of the private editing API, seems to expose a bug in Etherpad
which causes the continuous insertion of bullet points.

* WebCoreSupport/EditorClientGtk.cpp:
(WebKit::EditorClient::shouldShowDeleteInterface): Disable the deletion UI by default.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124177 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoImplement datalist UI for input type color for Chromium
keishi@webkit.org [Tue, 31 Jul 2012 06:27:00 +0000 (06:27 +0000)]
Implement datalist UI for input type color for Chromium
https://bugs.webkit.org/show_bug.cgi?id=92075

Reviewed by Kent Tamura.

Source/Platform:

* chromium/public/WebLocalizedString.h: Added OtherColorLabel.

Source/WebCore:

Test: platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html

* rendering/RenderThemeChromiumCommon.cpp:
(WebCore::RenderThemeChromiumCommon::supportsDataListUI): Added color to types supporting datalist.

Source/WebKit/chromium:

Integrated ColorChooserProxy and WebColorChooserClientImpl into ColorChooserUIController.
ColorChooserUIController can control whether to open the color suggestion picker
popup or the color chooser depending on the responses from ColorChooserClient.

* WebKit.gyp:
* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createColorChooser): Returns ColorChooserUIController which is a ColorChooser.
(WebKit::ChromeClientImpl::createWebColorChooser): Returns WebColorChooser that was created by Chromium.
* src/ChromeClientImpl.h:
(WebKit):
(ChromeClientImpl):
* src/ColorChooserProxy.cpp: Removed.
* src/ColorChooserProxy.h: Removed.
* src/ColorChooserUIController.cpp: Added.
(WebKit):
(WebKit::ColorChooserUIController::ColorChooserUIController): Controls the UI for color chooser. Opens the color suggestion picker popup or color chooser depending on the ColorChooserClient.
(WebKit::ColorChooserUIController::~ColorChooserUIController):
(WebKit::ColorChooserUIController::setSelectedColor):
(WebKit::ColorChooserUIController::endChooser): This is called by WebCore so we close both the popup and the color chooser.
(WebKit::ColorChooserUIController::didChooseColor):
(WebKit::ColorChooserUIController::didEndChooser):
(WebKit::ColorChooserUIController::contentSize): The popup will be resized later from JS so we return an arbitrary size.
(WebKit::ColorChooserUIController::writeDocument):
(WebKit::ColorChooserUIController::setValueAndClosePopup): Performs action based on the numValue.
(WebKit::ColorChooserUIController::didClosePopup):
(WebKit::ColorChooserUIController::openPopup): Opens color chooser suggestion popup.
(WebKit::ColorChooserUIController::closePopup):
(WebKit::ColorChooserUIController::openColorChooser): Opens color chooser.
* src/ColorChooserUIController.h: Renamed from Source/WebKit/chromium/src/WebColorChooserClientImpl.h.
(WebCore):
(WebKit):
(ColorChooserUIController):
* src/WebColorChooserClientImpl.cpp: Removed.

LayoutTests:

* platform/chromium-mac/platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.png: Added.
* platform/chromium/TestExpectations:
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance-expected.txt: Added.
* platform/chromium/fast/forms/color/color-suggestion-picker-appearance.html: Added. Tests color suggestion picker popup appearance.
* platform/chromium/fast/forms/datalist/input-list-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago/api/test/runs/chart expires on perf-o-matic
rniwa@webkit.org [Tue, 31 Jul 2012 06:19:17 +0000 (06:19 +0000)]
/api/test/runs/chart expires on perf-o-matic
https://bugs.webkit.org/show_bug.cgi?id=92714

Reviewed by Hajime Morita.

Don't update the entire JSON while generating the dashboard images.
This is a bug and not doing this will reduce the server load significantly.

* Websites/webkit-perf.appspot.com/controller.py:
(RunsChartHandler.post):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r124171.
commit-queue@webkit.org [Tue, 31 Jul 2012 05:46:43 +0000 (05:46 +0000)]
Unreviewed, rolling out r124171.
http://trac.webkit.org/changeset/124171
https://bugs.webkit.org/show_bug.cgi?id=92712

Start failing fast/css/square-button-appearance.html
(Requested by yosin on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector):
* dom/Element.cpp:
* dom/Element.h:
(Element):
(WebCore::Element::isReadOnlyFormControl):
* html/HTMLFormControlElement.h:
(WebCore::HTMLFormControlElement::isReadOnlyFormControl):
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::isReadOnlyFormControl):
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents):
(WebCore::SliderThumbElement::willRespondToMouseClickEvents):
* html/shadow/SliderThumbElement.h:
(SliderThumbElement):
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents):
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents):
(WebCore::SpinButtonElement::willRespondToMouseClickEvents):
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents):
* html/shadow/TextControlInnerElements.h:
(WebCore::SpinButtonElement::isReadOnlyFormControl):
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Layout Test fast/forms/date/calendar-picker-appearance.html is flaky
tkent@chromium.org [Tue, 31 Jul 2012 05:28:37 +0000 (05:28 +0000)]
[Chromium] Layout Test fast/forms/date/calendar-picker-appearance.html is flaky
https://bugs.webkit.org/show_bug.cgi?id=92710

* fast/forms/date/calendar-picker-appearance.html:
 Attempt to fix the flakiness.
* platform/chromium/TestExpectations: Add an entry for calendar-picker-appearance.html.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Baseline and expectation followups after r124142.
pkasting@chromium.org [Tue, 31 Jul 2012 04:20:24 +0000 (04:20 +0000)]
[Chromium] Baseline and expectation followups after r124142.
https://bugs.webkit.org/show_bug.cgi?id=62754
https://bugs.webkit.org/show_bug.cgi?id=80531
http://crbug.com/47826

Unreviewed, test updates.

* platform/chromium-linux-x86/css2.1/20110323: Added.
* platform/chromium-linux-x86/css2.1/20110323/block-replaced-width-001-expected.png: Added.
* platform/chromium-linux-x86/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
* platform/chromium-linux/css2.1/20110323/block-replaced-width-001-expected.png: Added.
* platform/chromium-linux/fast/table/colspanMinWidth-vertical-expected.txt: Removed.
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-linux/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/table/colspanMinWidth-vertical-expected.png: Removed.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png: Added.
* platform/chromium-mac-snowleopard/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-boundary-values-expected.png:
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-element-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-optimums-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-changing-pseudo-expected.txt: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.png: Added.
* platform/chromium-mac/fast/dom/HTMLMeterElement/meter-styles-expected.txt: Added.
* platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.png: Added.
* platform/chromium-mac/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-win-xp/css2.1/20110323/block-replaced-width-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/block-replaced-width-001-expected.png: Added.
* platform/chromium-win/css2.1/20110323/block-replaced-width-001-expected.txt: Added.
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.png:
* platform/chromium-win/fast/table/colspanMinWidth-vertical-expected.txt:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-win/platform/chromium/virtual/gpu/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CSS] Change Element::isReadOnlyFormControl to shouldMatchReadWriteSelector or HTMLTe...
yosin@chromium.org [Tue, 31 Jul 2012 04:19:30 +0000 (04:19 +0000)]
[CSS] Change Element::isReadOnlyFormControl to shouldMatchReadWriteSelector or HTMLTextFormControlElement::readOnly
https://bugs.webkit.org/show_bug.cgi?id=92602

Reviewed by Kent Tamura.

This patch renames Element::isReadOnlyFormControl() to Element::shouldMatchReadWriteSelector()
or HTMLTextFormControlElement::readOnly() to make intention of
shouldMatchReadWriteSelector(was isReadOnlyFormControl) self descriptive.

No new tests. This patch doesn't change behavior.

* css/SelectorChecker.cpp:
(WebCore::SelectorChecker::checkOneSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
* dom/Element.cpp:
(WebCore::Element::shouldMatchReadWriteSelector): Added default implementation.
* dom/Element.h:
(WebCore::Element::shouldMatchReadWriteSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
* html/HTMLFormControlElement.h:
* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::shouldMatchReadWriteSelector): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
(WebCore::SliderThumbElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SliderThumbElement::willRespondToMouseClickEvents): ditto.
* html/shadow/SliderThumbElement.h:
(SliderThumbElement): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseMoveEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::SpinButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
(WebCore::InputFieldSpeechButtonElement::willRespondToMouseClickEvents): Replaced isReadOnlyFormControl() by readOnly().
* html/shadow/TextControlInnerElements.h:
* rendering/RenderTheme.cpp:
(WebCore::RenderTheme::isReadOnlyControl): Replaced isReadOnlyFormControl() by shouldMatchReadWriteSelector().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Add baseline files for calendar-picker-appearance.html
tkent@chromium.org [Tue, 31 Jul 2012 03:49:06 +0000 (03:49 +0000)]
[Chromium] Add baseline files for calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=84827

* platform/chromium-linux-x86/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-linux/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/forms/date/calendar-picker-appearance-expected.png:
* platform/chromium-mac/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-win-xp/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium-win/fast/forms/date/calendar-picker-appearance-expected.png: Added.
* platform/chromium/TestExpectations:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd a proper umbrella header for the public WebKit2 API headers
weinig@apple.com [Tue, 31 Jul 2012 03:39:01 +0000 (03:39 +0000)]
Add a proper umbrella header for the public WebKit2 API headers
https://bugs.webkit.org/show_bug.cgi?id=92708
<rdar://problem/11970825>

Reviewed by Dan Bernstein.

Create a new umbrella WebKit2.h and add the currently public (as decided by their
status in Xcode) Objective-C headers.

* UIProcess/API/mac/WebKit2.h: Added.
* WebKit2.xcodeproj/project.pbxproj:
While we are here, make WebKit2_C.h a private header.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove overflow: scroll handling in block flow layout methods
jchaffraix@webkit.org [Tue, 31 Jul 2012 03:38:53 +0000 (03:38 +0000)]
Remove overflow: scroll handling in block flow layout methods
https://bugs.webkit.org/show_bug.cgi?id=92689

Reviewed by Simon Fraser.

The overflow: scroll scrollbars creation was done at layout time for all RenderBlocks and
descendants. This was not only wrong ('overflow' only changes at style change time) but it
was also introducing some code duplication.

The gist of this change is to share the code by moving it to RenderLayer::updateScrollbarsAfterStyleChange,
this includes the code from bug 69993 to special case list box part.

Covered by existing tests:
- All fast/overflow ones.
- For the list box change:
    fast/forms/select-overflow-scroll-inherited.html
    fast/forms/select-overflow-scroll.html
- For the flexbox:
    css3/flexbox/preferred-widths-orthogonal.html
    css3/flexbox/preferred-widths.html

* rendering/RenderBlock.cpp:
(WebCore::RenderBlock::layoutBlock):
* rendering/RenderDeprecatedFlexibleBox.cpp:
(WebCore::RenderDeprecatedFlexibleBox::layoutBlock):
* rendering/RenderGrid.cpp:
(WebCore::RenderGrid::layoutBlock):
* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::layoutBlock):
Removed the common code here.

* rendering/RenderFlexibleBox.cpp:
(WebCore::RenderFlexibleBox::computePreferredLogicalWidths):
Changed to an ASSERT now that the right scrollbars are created. This is
fine as overflow-x/y are physical coordinates and our access was following that.

* rendering/RenderLayer.cpp:
(WebCore::RenderLayer::invalidateScrollbarRect):
Added an early return here if we are not attached yet as RenderLayer::styleChanged
is called at attachment time before we are inserted in the tree. This is fine as the
scrollbars are part of the object which will be painted after the first layout.

(WebCore::overflowRequiresAScrollbar):
(WebCore::overflowDefinesAutomaticScrollbar):
Split the logic in those 2 functions.

(WebCore::RenderLayer::updateScrollbarsAfterLayout):
Updated to use the require / can-have functions. Also added
an early return for list box parts as required by bug 69993.

(WebCore::RenderLayer::updateScrollbarsAfterStyleChange):
Added an early return for list box parts as required by bug 69993,
also removed some unneeded NULL-checks that were added for list box parts.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRoll out the DEPS roll (r124164) for now since it broke Chromium Mac builds.
rniwa@webkit.org [Tue, 31 Jul 2012 03:36:44 +0000 (03:36 +0000)]
Roll out the DEPS roll (r124164) for now since it broke Chromium Mac builds.

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124167 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRevert r124153 and land the "right" build fix per ap's comment on the bug 92676.
rniwa@webkit.org [Tue, 31 Jul 2012 03:22:11 +0000 (03:22 +0000)]
Revert r124153 and land the "right" build fix per ap's comment on the bug 92676.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed. Rolled DEPS.
rniwa@webkit.org [Tue, 31 Jul 2012 03:17:40 +0000 (03:17 +0000)]
Unreviewed.  Rolled DEPS.

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

* DEPS:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124164 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRename WebKit2.h to WebKit2_C.h
weinig@apple.com [Tue, 31 Jul 2012 03:15:51 +0000 (03:15 +0000)]
Rename WebKit2.h to WebKit2_C.h
https://bugs.webkit.org/show_bug.cgi?id=92704

Reviewed by Dan Bernstein.

Source/WebKit2:

* GNUmakefile.list.am:
* Target.pri:
* UIProcess/API/C/WebKit2_C.h: Renamed from Source/WebKit2/UIProcess/API/C/WebKit2.h.
* UIProcess/API/gtk/WebKitBackForwardListPrivate.h:
* UIProcess/API/gtk/WebKitPolicyDecisionPrivate.h:
* UIProcess/API/gtk/WebKitPrivate.h:
* UIProcess/API/gtk/WebKitSettingsPrivate.h:
* UIProcess/API/gtk/WebKitWebViewPrivate.h:
* WebKit2.xcodeproj/project.pbxproj:
* win/WebKit2.vcproj:
* win/WebKit2Generated.make:
Update for changed header file name.

Tools:

* MiniBrowser/mac/MiniBrowser_Prefix.pch:
* MiniBrowser/win/BrowserView.h:
* TestWebKitAPI/config.h:
* WebKitTestRunner/InjectedBundle/InjectedBundle.cpp:
* WebKitTestRunner/InjectedBundle/LayoutTestController.cpp:
* WebKitTestRunner/WebKitTestRunnerPrefix.h:
* WebKitTestRunner/config.h:
Update for changed header file name.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124163 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agofillWithEmptyClients method should also initialize chromeClient with EmptyChromeClient
commit-queue@webkit.org [Tue, 31 Jul 2012 03:15:20 +0000 (03:15 +0000)]
fillWithEmptyClients method should also initialize chromeClient with EmptyChromeClient
https://bugs.webkit.org/show_bug.cgi?id=92703

Patch by Vivek Galatage <vivekgalatage@gmail.com> on 2012-07-30
Reviewed by Kent Tamura.

fillWithEmptyClients should also intialize PageClients.chromeClient with EmptyChromeClient
as its required for creating a Empty page and to minimize the exported symbols.

No new tests as no change in functionality.

* loader/EmptyClients.cpp:
(WebCore::fillWithEmptyClients):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
enne@google.com [Tue, 31 Jul 2012 03:02:52 +0000 (03:02 +0000)]
[chromium] Wrap ScrollbarLayerChromium in WebScrollbarLayer
https://bugs.webkit.org/show_bug.cgi?id=91032

Reviewed by James Robinson.

Source/Platform:

Add WebScrollbarLayer class to the Platform API.

* Platform.gypi:
* chromium/public/WebScrollbarLayer.h: Added.
(WebCore):
(WebKit):
(WebScrollbarLayer):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::~WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):

Source/WebCore:

Modify ScrollingCoordinatorChromium to operate on WebScrollbarLayer
instead of ScrollbarLayerChromium. This removes the dependency on
ScrollbarLayerChromium.

No change in functionality, so no new tests.

* page/scrolling/chromium/ScrollingCoordinatorChromium.cpp:
(WebCore::ScrollingCoordinatorPrivate::setScrollLayer):
(WebCore::ScrollingCoordinatorPrivate::setHorizontalScrollbarLayer):
(WebCore::ScrollingCoordinatorPrivate::setVerticalScrollbarLayer):
(ScrollingCoordinatorPrivate):
(WebCore::createScrollbarLayer):

Source/WebKit/chromium:

Add implementation of WebScrollbarLayer to the client API.

* WebKit.gyp:
* src/WebScrollbarLayer.cpp: Added.
(WebKit):
(WebKit::WebScrollbarLayer::setScrollLayer):
(WebKit::WebScrollbarLayer::create):
(WebKit::WebScrollbarLayer::WebScrollbarLayer):
(WebKit::WebScrollbarLayer::operator=):
(WebKit::WebScrollbarLayer::operator PassRefPtr<ScrollbarLayerChromium>):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAnother Qt build fix attempt after r124098.
rniwa@webkit.org [Tue, 31 Jul 2012 02:57:28 +0000 (02:57 +0000)]
Another Qt build fix attempt after r124098.
"interface" is a keyword. Don't use it.

* dom/GestureEvent.cpp:
(WebCore::GestureEvent::interfaceName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124159 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agochromium win compile broken after removing webkit.py
dpranke@chromium.org [Tue, 31 Jul 2012 02:56:50 +0000 (02:56 +0000)]
chromium win compile broken after removing webkit.py
https://bugs.webkit.org/show_bug.cgi?id=92549

Reviewed by Ryosuke Niwa.

Remove the stub file for webkit.py now that it's no longer
necessary.

* Scripts/webkitpy/layout_tests/port/webkit.py: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124158 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoMake QuotesData use a Vector of pairs
commit-queue@webkit.org [Tue, 31 Jul 2012 02:56:09 +0000 (02:56 +0000)]
Make QuotesData use a Vector of pairs
https://bugs.webkit.org/show_bug.cgi?id=92448

Patch by Elliott Sprehn <esprehn@gmail.com> on 2012-07-30
Reviewed by Julien Chaffraix.

Source/WebCore:

QuotesData::create returned an array of memory that contained in place instantiations
of a QuotesData and then String instances. This changes the code to use a Vector of
pairs making it safer and ensuring that quotes are always balanced. This also uses a
HashMap directly in the QuoteRenderer instead of building it on first access reducing
the amount of code needed for picking quotes by language.

Test: fast/css-generated-content/close-quote-negative-depth.html

* css/StyleResolver.cpp:
(WebCore::StyleResolver::collectMatchingRulesForList): Create pairs and use the new QuotesData API.
* rendering/RenderQuote.cpp:
(WebCore):
(WebCore::quotesDataLanguageMap): New function that returns the HashMap of languages.
(WebCore::basicQuotesData): Returns the simple form of quotes, " and '.
(WebCore::defaultQuotes): Changed to use the new map.
(WebCore::RenderQuote::styleDidChange):
(WebCore::RenderQuote::originalText): Changed to use the new getOpenQuote and getCloseQuote which ensure bounds checks.
* rendering/style/QuotesData.cpp:
(WebCore::QuotesData::create): Now returns a plain instance of QuotesData without the in place allocation.
(WebCore):
(WebCore::QuotesData::addPair): Adds an std::pair of strings ensuring quotes are always balanced.
(WebCore::QuotesData::getOpenQuote):
(WebCore::QuotesData::getCloseQuote):
(WebCore::QuotesData::equals): Renamed equals (added the s).
* rendering/style/QuotesData.h:
(WebCore::QuotesData::create):
(QuotesData):
(WebCore::QuotesData::QuotesData):
* rendering/style/RenderStyle.cpp:
(WebCore::RenderStyle::setQuotes):
* rendering/style/StyleRareInheritedData.cpp:
(WebCore::StyleRareInheritedData::operator==):

LayoutTests:

Test that when quote depths go negative we do not output quotes. The expected result
is wrong right now because we output quotes in this case when we should not.

* fast/css-generated-content/close-quote-negative-depth-expected.html: Added.
* fast/css-generated-content/close-quote-negative-depth.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124157 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoNode::replaceChild() can create bad DOM topology with MutationEvent
morrita@google.com [Tue, 31 Jul 2012 02:48:33 +0000 (02:48 +0000)]
Node::replaceChild() can create bad DOM topology with MutationEvent
https://bugs.webkit.org/show_bug.cgi?id=92619

Reviewed by Ryosuke Niwa.

Source/WebCore:

Node::replaceChild() calls insertBeforeCommon() after dispatching
a MutationEvent event for removeChild(). But insertBeforeCommon()
expects call sites to check the invariant and doesn't have
suffient check. So a MutationEvent handler can let some bad tree
topology to slip into insertBeforeCommon().

This change adds a guard for checking the invariant using
checkReplaceChild() between removeChild() and insertBeforeCommon().

Test: fast/events/mutation-during-replace-child.html

* dom/ContainerNode.cpp:
(WebCore::ContainerNode::replaceChild): Added a guard.

LayoutTests:

* fast/events/mutation-during-replace-child-expected.txt: Added.
* fast/events/mutation-during-replace-child.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124156 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoQt Windows build fix attempt after r124098.
rniwa@webkit.org [Tue, 31 Jul 2012 02:46:58 +0000 (02:46 +0000)]
Qt Windows build fix attempt after r124098.

* dom/GestureEvent.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124155 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Enable web audio IPP for x86 chromium android
commit-queue@webkit.org [Tue, 31 Jul 2012 02:46:17 +0000 (02:46 +0000)]
[Chromium] Enable web audio IPP for x86 chromium android
https://bugs.webkit.org/show_bug.cgi?id=91973

Patch by Wei James <james.wei@intel.com> on 2012-07-30
Reviewed by Tony Chang.

Include the IPP libraries at link-time for Android builds when
compiling the Web Audio API with IPP support.

* WebCore.gyp/WebCore.gyp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124154 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoWindows build fix attempt after r124092.
rniwa@webkit.org [Tue, 31 Jul 2012 02:43:44 +0000 (02:43 +0000)]
Windows build fix attempt after r124092.

* MiniBrowser/win/BrowserView.cpp:
(BrowserView::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoRemove erroneously committed debugging print call from a test.
rniwa@webkit.org [Tue, 31 Jul 2012 02:06:08 +0000 (02:06 +0000)]
Remove erroneously committed debugging print call from a test.

* Scripts/webkitpy/performance_tests/perftestsrunner_unittest.py:
(test_run_generates_results_page):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124148 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Forms] Get rid of Element::isReadOnlyFormControl other than CSS related
yosin@chromium.org [Tue, 31 Jul 2012 02:01:24 +0000 (02:01 +0000)]
[Forms] Get rid of Element::isReadOnlyFormControl other than CSS related
https://bugs.webkit.org/show_bug.cgi?id=92612

Reviewed by Kent Tamura.

Source/WebCore:

This patch replaces Element::isReadOnlyFormControl() not related to
CSS selector matching to HTMLFormControlElement::readOnly() for
preparation of introducing Element::shouldMatchReadWriteSelector(), bug 92602.

No new tests. This patch doesn't change behavior.

* html/shadow/SliderThumbElement.cpp:
(WebCore::SliderThumbElement::defaultEventHandler): Changed isReadOnlyFormControl() to readOnly().
* html/shadow/TextControlInnerElements.cpp:
(WebCore::SearchFieldCancelButtonElement::defaultEventHandler): Changed isReadOnlyFormControl() to readOnly().
(WebCore::SpinButtonElement::defaultEventHandler): ditto.
(WebCore::SpinButtonElement::step): ditto.
(WebCore::InputFieldSpeechButtonElement::defaultEventHandler): ditto.
(WebCore::InputFieldSpeechButtonElement::setRecognitionResult): ditto.
* rendering/RenderTextControl.cpp:
(updateUserModifyProperty): Changed isReadOnlyFormControl() to readOnly().
* rendering/RenderThemeMac.mm:
(WebCore::RenderThemeMac::paintSearchFieldCancelButton): Changed isReadOnlyFormControl() to readOnly().

Source/WebKit/blackberry:

This patch replaces Element::isReadOnlyFormControl() to
HTMLFormControlElement::readOnly() for preparation of introducing
Element::shouldMatchReadWriteSelector(), bug 92602.

* WebKitSupport/DOMSupport.cpp:
(BlackBerry::WebKit::DOMSupport::isTextBasedContentEditableElement): Replaced isReadOnlyFormControl() by HTMLTextFormControlElement::readOnly().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124146 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoFix a popup position issue of fast/forms/date/calendar-picker-appearance.html
tkent@chromium.org [Tue, 31 Jul 2012 01:57:02 +0000 (01:57 +0000)]
Fix a popup position issue of fast/forms/date/calendar-picker-appearance.html
https://bugs.webkit.org/show_bug.cgi?id=92609

Reviewed by Hajime Morita.

Force to lay out the document before opening a popup.

* fast/forms/date/calendar-picker-appearance.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[Chromium] Rebaselines and test expectation updates.
pkasting@chromium.org [Tue, 31 Jul 2012 01:50:54 +0000 (01:50 +0000)]
[Chromium] Rebaselines and test expectation updates.
​https://bugs.webkit.org/show_bug.cgi?id=62754
​https://bugs.webkit.org/show_bug.cgi?id=63937
​https://bugs.webkit.org/show_bug.cgi?id=70298
​https://bugs.webkit.org/show_bug.cgi?id=74374
​https://bugs.webkit.org/show_bug.cgi?id=77368
​https://bugs.webkit.org/show_bug.cgi?id=79615
​https://bugs.webkit.org/show_bug.cgi?id=80531
https://bugs.webkit.org/show_bug.cgi?id=80879
​https://bugs.webkit.org/show_bug.cgi?id=81631
https://bugs.webkit.org/show_bug.cgi?id=83717
​https://bugs.webkit.org/show_bug.cgi?id=87880
http://crbug.com/10350
http://crbug.com/26291
http://crbug.com/47826
http://crbug.com/131189

Unreviewed, test updates.

Most of the baselines here are for
http://trac.webkit.org/changeset/119431 and
http://trac.webkit.org/changeset/119748 , as well as some changes to
antialiasing (generally to improve it) for which I couldn't find a CL;
when these were originally landed and new baselines committed, a
Chromium test expectation override file was masking the fact that the
tests here needed new baselines as well.

There is also a small number of other changes mixed in.

* platform/chromium-linux-x86/css1: Added.
* platform/chromium-linux-x86/css1/basic: Added.
* platform/chromium-linux-x86/css1/basic/class_as_selector-expected.png: Added.
* platform/chromium-linux-x86/css1/basic/id_as_selector-expected.png: Added.
* platform/chromium-linux-x86/css1/box_properties: Added.
* platform/chromium-linux-x86/css1/box_properties/border_bottom-expected.png: Added.
* platform/chromium-linux-x86/css1/box_properties/margin_left-expected.png: Added.
* platform/chromium-linux-x86/css1/box_properties/padding_right-expected.png: Added.
* platform/chromium-linux-x86/css1/pseudo: Added.
* platform/chromium-linux-x86/css1/pseudo/anchor-expected.png: Added.
* platform/chromium-linux-x86/editing/input: Added.
* platform/chromium-linux-x86/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
* platform/chromium-linux-x86/editing/selection: Removed.
* platform/chromium-linux-x86/fast/backgrounds/repeat: Added.
* platform/chromium-linux-x86/fast/backgrounds/repeat/negative-offset-repeat-transformed-expected.png: Added.
* platform/chromium-linux-x86/fast/block/float: Added.
* platform/chromium-linux-x86/fast/block/float/float-avoidance-expected.png: Added.
* platform/chromium-linux-x86/fast/canvas/image-pattern-rotate-expected.png: Added.
* platform/chromium-linux-x86/fast/events: Added.
* platform/chromium-linux-x86/fast/events/autoscroll-expected.png: Added.
* platform/chromium-linux-x86/fast/events/reveal-link-when-focused-expected.png: Added.
* platform/chromium-linux-x86/fast/forms/textarea: Added.
* platform/chromium-linux-x86/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/chromium-linux-x86/fast/overflow: Added.
* platform/chromium-linux-x86/fast/overflow/overflow-with-local-background-attachment-expected.png: Added.
* platform/chromium-linux-x86/fast/selectors: Added.
* platform/chromium-linux-x86/fast/selectors/166-expected.png: Added.
* platform/chromium-linux-x86/fast/selectors/unqualified-hover-strict-expected.png: Added.
* platform/chromium-linux-x86/fast/selectors/unqualified-hover-strict-expected.txt: Added.
* platform/chromium-linux-x86/fast/transforms: Added.
* platform/chromium-linux-x86/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
* platform/chromium-linux-x86/fonts: Added.
* platform/chromium-linux-x86/fonts/monospace-expected.png: Added.
* platform/chromium-linux-x86/http/tests/navigation: Added.
* platform/chromium-linux-x86/http/tests/navigation/javascriptlink-frames-expected.png: Added.
* platform/chromium-linux-x86/ietestcenter: Added.
* platform/chromium-linux-x86/ietestcenter/css3: Added.
* platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds: Added.
* platform/chromium-linux-x86/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png: Added.
* platform/chromium-linux-x86/svg/as-image: Added.
* platform/chromium-linux-x86/svg/as-image/image-respects-pageScaleFactor-expected.png: Added.
* platform/chromium-linux-x86/svg/dom: Added.
* platform/chromium-linux-x86/svg/dom/SVGTransformList-basics-expected.png: Added.
* platform/chromium-linux-x86/svg/dom/css-transforms-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/chromium-linux-x86/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-linux-x86/svg/wicd: Added.
* platform/chromium-linux-x86/svg/wicd/test-rightsizing-b-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/marvin: Added.
* platform/chromium-linux-x86/tables/mozilla/marvin/backgr_index-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla/marvin/backgr_layers-opacity-expected.png: Added.
* platform/chromium-linux-x86/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
* platform/chromium-linux-x86/transforms: Added.
* platform/chromium-linux-x86/transforms/2d: Added.
* platform/chromium-linux-x86/transforms/2d/hindi-rotated-expected.png: Added.
* platform/chromium-linux-x86/transforms/2d/hindi-rotated-expected.txt: Added.
* platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-linux/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/chromium-linux/css1/basic/class_as_selector-expected.png:
* platform/chromium-linux/css1/basic/id_as_selector-expected.png:
* platform/chromium-linux/css1/box_properties/border_bottom-expected.png:
* platform/chromium-linux/css1/box_properties/margin_left-expected.png:
* platform/chromium-linux/css1/box_properties/padding_right-expected.png:
* platform/chromium-linux/css1/pseudo/anchor-expected.png:
* platform/chromium-linux/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-linux/editing/selection/iframe-expected.png:
* platform/chromium-linux/editing/selection/select-all-001-expected.png:
* platform/chromium-linux/editing/selection/select-all-002-expected.png:
* platform/chromium-linux/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-linux/fast/block/float/float-avoidance-expected.png:
* platform/chromium-linux/fast/borders/border-radius-valid-border-clipping-expected.png:
* platform/chromium-linux/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-linux/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-linux/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-linux/fast/events/autoscroll-expected.png:
* platform/chromium-linux/fast/events/reveal-link-when-focused-expected.png:
* platform/chromium-linux/fast/forms/fieldset-align-expected.png:
* platform/chromium-linux/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-linux/fast/forms/input-placeholder-paint-order-expected.png:
* platform/chromium-linux/fast/forms/input-table-expected.png:
* platform/chromium-linux/fast/forms/listbox-bidi-align-expected.png:
* platform/chromium-linux/fast/forms/placeholder-position-expected.png:
* platform/chromium-linux/fast/forms/select-overflow-scroll-expected.png:
* platform/chromium-linux/fast/forms/select-overflow-scroll-inherited-expected.png:
* platform/chromium-linux/fast/forms/textarea-scrollbar-expected.png:
* platform/chromium-linux/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
* platform/chromium-linux/fast/html/details-position-expected.png:
* platform/chromium-linux/fast/html/details-writing-mode-expected.png:
* platform/chromium-linux/fast/overflow/overflow-update-transform-expected.png:
* platform/chromium-linux/fast/overflow/overflow-with-local-background-attachment-expected.png:
* platform/chromium-linux/fast/replaced/width100percent-radio-expected.png: Added.
* platform/chromium-linux/fast/selectors/166-expected.png:
* platform/chromium-linux/fast/selectors/unqualified-hover-strict-expected.png:
* platform/chromium-linux/fast/selectors/unqualified-hover-strict-expected.txt: Added.
* platform/chromium-linux/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
* platform/chromium-linux/fonts/monospace-expected.png:
* platform/chromium-linux/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-linux/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-linux/svg/as-image/image-respects-pageScaleFactor-expected.png:
* platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
* platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/chromium-linux/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
* platform/chromium-linux/svg/custom/pattern-rotate-expected.png:
* platform/chromium-linux/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-linux/svg/dom/css-transforms-expected.png:
* platform/chromium-linux/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
* platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-linux/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-linux/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-linux/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-linux/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-linux/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/chromium-linux/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-linux/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/backgr_index-expected.png:
* platform/chromium-linux/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/chromium-linux/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/chromium-linux/transforms/2d/hindi-rotated-expected.png:
* platform/chromium-linux/transforms/2d/hindi-rotated-expected.txt:
* platform/chromium-mac-snowleopard/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac-snowleopard/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png: Added.
* platform/chromium-mac-snowleopard/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac-snowleopard/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-mac-snowleopard/svg/as-border-image: Removed.
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-2-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/as-border-image/svg-as-border-image-expected.png: Removed.
* platform/chromium-mac-snowleopard/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-mac-snowleopard/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac-snowleopard/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-mac-snowleopard/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac-snowleopard/transforms/2d/hindi-rotated-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-mac/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/chromium-mac/fast/borders/border-radius-valid-border-clipping-expected.png:
* platform/chromium-mac/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
* platform/chromium-mac/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-mac/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-2-expected.png:
* platform/chromium-mac/svg/as-border-image/svg-as-border-image-expected.png:
* platform/chromium-mac/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-mac/svg/custom/pattern-rotate-expected.png:
* platform/chromium-mac/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-mac/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-mac/tables/mozilla_expected_failures/bugs/bug85016-expected.png:
* platform/chromium-mac/transforms/2d/hindi-rotated-expected.png: Added.
* platform/chromium-mac/transforms/2d/hindi-rotated-expected.txt: Added.
* platform/chromium-win-xp/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png: Added.
* platform/chromium-win-xp/css1: Added.
* platform/chromium-win-xp/css1/basic: Added.
* platform/chromium-win-xp/css1/basic/class_as_selector-expected.png: Added.
* platform/chromium-win-xp/css1/basic/containment-expected.png: Added.
* platform/chromium-win-xp/css1/basic/id_as_selector-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties: Added.
* platform/chromium-win-xp/css1/box_properties/border_bottom-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/border_left-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/border_right_inline-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/border_top-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/clear_float-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/margin_left-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/margin_right-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/padding_left-expected.png: Added.
* platform/chromium-win-xp/css1/box_properties/padding_right-expected.png: Added.
* platform/chromium-win-xp/css1/cascade: Added.
* platform/chromium-win-xp/css1/cascade/cascade_order-expected.png: Added.
* platform/chromium-win-xp/css1/classification: Added.
* platform/chromium-win-xp/css1/classification/list_style_type-expected.png: Added.
* platform/chromium-win-xp/css1/pseudo: Added.
* platform/chromium-win-xp/css1/pseudo/anchor-expected.png: Added.
* platform/chromium-win-xp/css3/selectors3: Added.
* platform/chromium-win-xp/css3/selectors3/html: Added.
* platform/chromium-win-xp/css3/selectors3/html/css3-modsel-161-expected.png: Added.
* platform/chromium-win-xp/css3/selectors3/xhtml: Added.
* platform/chromium-win-xp/css3/selectors3/xhtml/css3-modsel-161-expected.png: Added.
* platform/chromium-win-xp/css3/selectors3/xml: Added.
* platform/chromium-win-xp/css3/selectors3/xml/css3-modsel-161-expected.png: Added.
* platform/chromium-win-xp/editing/input: Added.
* platform/chromium-win-xp/editing/input/caret-at-the-edge-of-input-expected.png: Added.
* platform/chromium-win-xp/editing/input/reveal-caret-of-multiline-contenteditable-expected.png: Added.
* platform/chromium-win-xp/editing/input/reveal-caret-of-multiline-input-expected.png: Added.
* platform/chromium-win-xp/fast/backgrounds/repeat: Removed.
* platform/chromium-win-xp/fast/block/float: Added.
* platform/chromium-win-xp/fast/block/float/float-avoidance-expected.png: Added.
* platform/chromium-win-xp/fast/block/margin-collapse: Added.
* platform/chromium-win-xp/fast/block/margin-collapse/103-expected.png: Added.
* platform/chromium-win-xp/fast/events: Added.
* platform/chromium-win-xp/fast/events/autoscroll-expected.png: Added.
* platform/chromium-win-xp/fast/events/context-no-deselect-expected.png: Added.
* platform/chromium-win-xp/fast/events/reveal-link-when-focused-expected.png: Added.
* platform/chromium-win-xp/fast/forms/date: Added.
* platform/chromium-win-xp/fast/forms/date/date-appearance-expected.png: Added.
* platform/chromium-win-xp/fast/forms/select: Added.
* platform/chromium-win-xp/fast/forms/select/optgroup-rendering-expected.png: Added.
* platform/chromium-win-xp/fast/forms/textarea: Added.
* platform/chromium-win-xp/fast/forms/textarea/textarea-placeholder-paint-order-expected.png: Added.
* platform/chromium-win-xp/fast/frames: Added.
* platform/chromium-win-xp/fast/frames/take-focus-from-iframe-expected.png: Added.
* platform/chromium-win-xp/fast/gradients: Added.
* platform/chromium-win-xp/fast/gradients/background-clipped-expected.png: Added.
* platform/chromium-win-xp/fast/html: Removed.
* platform/chromium-win-xp/fast/html/details-writing-mode-expected.png: Removed.
* platform/chromium-win-xp/fast/invalid: Added.
* platform/chromium-win-xp/fast/invalid/014-expected.png: Added.
* platform/chromium-win-xp/fast/layers: Added.
* platform/chromium-win-xp/fast/layers/scroll-with-transform-composited-layer-expected.png: Added.
* platform/chromium-win-xp/fast/layers/scroll-with-transform-layer-expected.png: Added.
* platform/chromium-win-xp/fast/lists: Added.
* platform/chromium-win-xp/fast/lists/008-expected.png: Added.
* platform/chromium-win-xp/fast/lists/008-vertical-expected.png: Added.
* platform/chromium-win-xp/fast/lists/dynamic-marker-crash-expected.png: Added.
* platform/chromium-win-xp/fast/overflow: Added.
* platform/chromium-win-xp/fast/overflow/overflow-rtl-expected.png: Added.
* platform/chromium-win-xp/fast/overflow/overflow-rtl-vertical-expected.png: Added.
* platform/chromium-win-xp/fast/selectors: Added.
* platform/chromium-win-xp/fast/selectors/166-expected.png: Added.
* platform/chromium-win-xp/fast/selectors/unqualified-hover-strict-expected.png: Added.
* platform/chromium-win-xp/fast/selectors/unqualified-hover-strict-expected.txt: Added.
* platform/chromium-win-xp/fast/speech: Added.
* platform/chromium-win-xp/fast/speech/input-appearance-numberandspeech-expected.png: Added.
* platform/chromium-win-xp/fast/speech/input-appearance-searchandspeech-expected.png: Added.
* platform/chromium-win-xp/fast/speech/input-appearance-speechbutton-expected.png: Added.
* platform/chromium-win-xp/fast/speech/speech-bidi-rendering-expected.png: Added.
* platform/chromium-win-xp/fast/text/drawBidiText-expected.png:
* platform/chromium-win-xp/fast/transforms: Added.
* platform/chromium-win-xp/fast/transforms/rotated-transform-affects-scrolling-1-expected.png: Added.
* platform/chromium-win-xp/fast/transforms/rotated-transform-affects-scrolling-2-expected.png: Added.
* platform/chromium-win-xp/fast/transforms/transformed-focused-text-input-expected.png: Added.
* platform/chromium-win-xp/fonts: Added.
* platform/chromium-win-xp/fonts/monospace-expected.png: Added.
* platform/chromium-win-xp/http/tests/misc: Added.
* platform/chromium-win-xp/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png: Added.
* platform/chromium-win-xp/http/tests/navigation: Added.
* platform/chromium-win-xp/http/tests/navigation/javascriptlink-frames-expected.png: Added.
* platform/chromium-win-xp/plugins: Added.
* platform/chromium-win-xp/plugins/mouse-click-plugin-clears-selection-expected.png: Added.
* platform/chromium-win-xp/svg/as-image/image-respects-pageScaleFactor-expected.png: Removed.
* platform/chromium-win-xp/svg/dom: Removed.
* platform/chromium-win-xp/svg/hixie/mixed: Added.
* platform/chromium-win-xp/svg/hixie/mixed/003-expected.png: Added.
* platform/chromium-win-xp/svg/in-html: Added.
* platform/chromium-win-xp/svg/in-html/circle-expected.png: Added.
* platform/chromium-win-xp/svg/transforms: Added.
* platform/chromium-win-xp/svg/transforms/text-with-pattern-inside-transformed-html-expected.png: Added.
* platform/chromium-win-xp/svg/transforms/text-with-pattern-with-svg-transform-expected.png: Added.
* platform/chromium-win-xp/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-win-xp/svg/zoom/page/zoom-mask-with-percentages-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/core: Added.
* platform/chromium-win-xp/tables/mozilla/core/margins-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/dom: Added.
* platform/chromium-win-xp/tables/mozilla/dom/tableDom-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla/other: Added.
* platform/chromium-win-xp/tables/mozilla/other/move_row-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/bugs: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug1725-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/marvin: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png: Added.
* platform/chromium-win-xp/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png: Added.
* platform/chromium-win-xp/transforms/2d/hindi-rotated-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-down-expected.png:
* platform/chromium-win/compositing/geometry/fixed-position-iframe-composited-page-scale-expected.png:
* platform/chromium-win/css1/basic/class_as_selector-expected.png:
* platform/chromium-win/css1/basic/containment-expected.png:
* platform/chromium-win/css1/basic/id_as_selector-expected.png:
* platform/chromium-win/css1/box_properties/border_bottom-expected.png:
* platform/chromium-win/css1/box_properties/border_left-expected.png:
* platform/chromium-win/css1/box_properties/border_right_inline-expected.png:
* platform/chromium-win/css1/box_properties/border_top-expected.png:
* platform/chromium-win/css1/box_properties/clear_float-expected.png:
* platform/chromium-win/css1/box_properties/margin_left-expected.png:
* platform/chromium-win/css1/box_properties/margin_right-expected.png:
* platform/chromium-win/css1/box_properties/padding_left-expected.png:
* platform/chromium-win/css1/box_properties/padding_right-expected.png:
* platform/chromium-win/css1/cascade/cascade_order-expected.png:
* platform/chromium-win/css1/classification/list_style_type-expected.png:
* platform/chromium-win/css1/pseudo/anchor-expected.png:
* platform/chromium-win/css2.1/20110323/replaced-intrinsic-ratio-001-expected.png:
* platform/chromium-win/css3/selectors3/html/css3-modsel-161-expected.png:
* platform/chromium-win/css3/selectors3/xhtml/css3-modsel-161-expected.png:
* platform/chromium-win/css3/selectors3/xml/css3-modsel-161-expected.png:
* platform/chromium-win/editing/deleting/delete-after-span-ws-001-expected.png:
* platform/chromium-win/editing/deleting/delete-after-span-ws-002-expected.png:
* platform/chromium-win/editing/deleting/delete-after-span-ws-003-expected.png:
* platform/chromium-win/editing/deleting/delete-line-end-ws-001-expected.png:
* platform/chromium-win/editing/deleting/delete-line-end-ws-002-expected.png:
* platform/chromium-win/editing/input/caret-at-the-edge-of-input-expected.png:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-contenteditable-expected.png:
* platform/chromium-win/editing/input/reveal-caret-of-multiline-input-expected.png:
* platform/chromium-win/editing/inserting/4960120-1-expected.png:
* platform/chromium-win/editing/inserting/before-after-input-element-expected.png:
* platform/chromium-win/editing/pasteboard/4806874-expected.png:
* platform/chromium-win/editing/pasteboard/4944770-1-expected.png:
* platform/chromium-win/editing/pasteboard/4944770-2-expected.png:
* platform/chromium-win/editing/pasteboard/drop-text-without-selection-expected.png:
* platform/chromium-win/editing/pasteboard/input-field-1-expected.png:
* platform/chromium-win/editing/pasteboard/pasting-tabs-expected.png:
* platform/chromium-win/editing/selection/3690703-2-expected.png:
* platform/chromium-win/editing/selection/3690703-expected.png:
* platform/chromium-win/editing/selection/3690719-expected.png:
* platform/chromium-win/editing/selection/4397952-expected.png:
* platform/chromium-win/editing/selection/4895428-3-expected.png:
* platform/chromium-win/editing/selection/4975120-expected.png:
* platform/chromium-win/editing/selection/caret-before-select-expected.png:
* platform/chromium-win/editing/selection/drag-select-1-expected.png:
* platform/chromium-win/editing/selection/iframe-expected.png:
* platform/chromium-win/editing/selection/replaced-boundaries-3-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-1-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-2-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-3-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-4-expected.png:
* platform/chromium-win/editing/selection/select-across-readonly-input-5-expected.png:
* platform/chromium-win/editing/selection/select-all-001-expected.png:
* platform/chromium-win/editing/selection/select-all-002-expected.png:
* platform/chromium-win/editing/selection/select-box-expected.png:
* platform/chromium-win/editing/selection/select-element-paragraph-boundary-expected.png:
* platform/chromium-win/editing/selection/unrendered-001-expected.png:
* platform/chromium-win/editing/selection/unrendered-002-expected.png:
* platform/chromium-win/editing/selection/unrendered-003-expected.png:
* platform/chromium-win/editing/selection/unrendered-004-expected.png:
* platform/chromium-win/editing/selection/unrendered-005-expected.png:
* platform/chromium-win/fast/backgrounds/background-inherit-color-bug-expected.png:
* platform/chromium-win/fast/backgrounds/background-leakage-transforms-expected.png:
* platform/chromium-win/fast/block/float/float-avoidance-expected.png:
* platform/chromium-win/fast/block/margin-collapse/103-expected.png:
* platform/chromium-win/fast/borders/border-radius-valid-border-clipping-expected.png:
* platform/chromium-win/fast/borders/mixed-border-styles-radius2-expected.png:
* platform/chromium-win/fast/box-shadow/basic-shadows-expected.png:
* platform/chromium-win/fast/canvas/canvas-imageSmoothingEnabled-patterns-expected.png:
* platform/chromium-win/fast/canvas/canvas-incremental-repaint-expected.png:
* platform/chromium-win/fast/canvas/canvas-text-alignment-expected.png:
* platform/chromium-win/fast/canvas/image-object-in-canvas-expected.png:
* platform/chromium-win/fast/canvas/image-pattern-rotate-expected.png:
* platform/chromium-win/fast/css/input-search-padding-expected.png:
* platform/chromium-win/fast/css/line-height-expected.png:
* platform/chromium-win/fast/css/nested-rounded-corners-expected.png:
* platform/chromium-win/fast/css/text-input-with-webkit-border-radius-expected.png:
* platform/chromium-win/fast/css/text-overflow-input-expected.png:
* platform/chromium-win/fast/css/text-transform-select-expected.png:
* platform/chromium-win/fast/dom/52776-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-capacity-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-appearances-rating-relevancy-expected.png:
* platform/chromium-win/fast/dom/HTMLMeterElement/meter-optimums-expected.png:
* platform/chromium-win/fast/dom/focus-contenteditable-expected.png:
* platform/chromium-win/fast/dom/isindex-001-expected.png:
* platform/chromium-win/fast/dom/isindex-002-expected.png:
* platform/chromium-win/fast/events/autoscroll-expected.png:
* platform/chromium-win/fast/events/context-no-deselect-expected.png:
* platform/chromium-win/fast/events/reveal-link-when-focused-expected.png:
* platform/chromium-win/fast/forms/001-expected.png:
* platform/chromium-win/fast/forms/003-expected.png:
* platform/chromium-win/fast/forms/004-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label01-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label02-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label03-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label04-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label05-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label06-expected.png:
* platform/chromium-win/fast/forms/HTMLOptionElement_label07-expected.png:
* platform/chromium-win/fast/forms/basic-buttons-expected.png:
* platform/chromium-win/fast/forms/basic-inputs-expected.png:
* platform/chromium-win/fast/forms/basic-selects-expected.png:
* platform/chromium-win/fast/forms/button-generated-content-expected.png:
* platform/chromium-win/fast/forms/button-inner-block-reuse-expected.png:
* platform/chromium-win/fast/forms/control-clip-overflow-expected.png:
* platform/chromium-win/fast/forms/control-restrict-line-height-expected.png:
* platform/chromium-win/fast/forms/date/date-appearance-expected.png:
* platform/chromium-win/fast/forms/disabled-select-change-index-expected.png:
* platform/chromium-win/fast/forms/encoding-test-expected.png:
* platform/chromium-win/fast/forms/fieldset-align-expected.png:
* platform/chromium-win/fast/forms/floating-textfield-relayout-expected.png:
* platform/chromium-win/fast/forms/form-element-geometry-expected.png:
* platform/chromium-win/fast/forms/input-align-expected.png:
* platform/chromium-win/fast/forms/input-appearance-default-bkcolor-expected.png:
* platform/chromium-win/fast/forms/input-appearance-disabled-expected.png:
* platform/chromium-win/fast/forms/input-appearance-focus-expected.png:
* platform/chromium-win/fast/forms/input-appearance-height-expected.png:
* platform/chromium-win/fast/forms/input-appearance-preventDefault-expected.png:
* platform/chromium-win/fast/forms/input-appearance-readonly-expected.png:
* platform/chromium-win/fast/forms/input-appearance-selection-expected.png:
* platform/chromium-win/fast/forms/input-appearance-visibility-expected.png:
* platform/chromium-win/fast/forms/input-appearance-width-expected.png:
* platform/chromium-win/fast/forms/input-baseline-expected.png:
* platform/chromium-win/fast/forms/input-disabled-color-expected.png:
* platform/chromium-win/fast/forms/input-double-click-selection-gap-bug-expected.png:
* platform/chromium-win/fast/forms/input-field-text-truncated-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-paint-order-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-visibility-1-expected.png:
* platform/chromium-win/fast/forms/input-placeholder-visibility-3-expected.png:
* platform/chromium-win/fast/forms/input-readonly-autoscroll-expected.png:
* platform/chromium-win/fast/forms/input-readonly-dimmed-expected.png:
* platform/chromium-win/fast/forms/input-readonly-empty-expected.png:
* platform/chromium-win/fast/forms/input-spaces-expected.png:
* platform/chromium-win/fast/forms/input-table-expected.png:
* platform/chromium-win/fast/forms/input-text-click-inside-expected.png:
* platform/chromium-win/fast/forms/input-text-click-outside-expected.png:
* platform/chromium-win/fast/forms/input-text-double-click-expected.png:
* platform/chromium-win/fast/forms/input-text-option-delete-expected.png:
* platform/chromium-win/fast/forms/input-text-scroll-left-on-blur-expected.png:
* platform/chromium-win/fast/forms/input-text-self-emptying-click-expected.png:
* platform/chromium-win/fast/forms/input-text-word-wrap-expected.png:
* platform/chromium-win/fast/forms/input-type-text-min-width-expected.png:
* platform/chromium-win/fast/forms/input-value-expected.png:
* platform/chromium-win/fast/forms/input-width-expected.png:
* platform/chromium-win/fast/forms/listbox-bidi-align-expected.png:
* platform/chromium-win/fast/forms/listbox-clip-expected.png:
* platform/chromium-win/fast/forms/listbox-scrollbar-incremental-load-expected.png:
* platform/chromium-win/fast/forms/listbox-width-change-expected.png:
* platform/chromium-win/fast/forms/menulist-deselect-update-expected.png:
* platform/chromium-win/fast/forms/menulist-narrow-width-expected.png:
* platform/chromium-win/fast/forms/menulist-no-overflow-expected.png:
* platform/chromium-win/fast/forms/menulist-restrict-line-height-expected.png:
* platform/chromium-win/fast/forms/menulist-separator-painting-expected.png:
* platform/chromium-win/fast/forms/menulist-style-color-expected.png:
* platform/chromium-win/fast/forms/menulist-width-change-expected.png:
* platform/chromium-win/fast/forms/minWidthPercent-expected.png:
* platform/chromium-win/fast/forms/option-script-expected.png:
* platform/chromium-win/fast/forms/option-strip-whitespace-expected.png:
* platform/chromium-win/fast/forms/option-text-clip-expected.png:
* platform/chromium-win/fast/forms/placeholder-position-expected.png:
* platform/chromium-win/fast/forms/placeholder-pseudo-style-expected.png:
* platform/chromium-win/fast/forms/plaintext-mode-2-expected.png:
* platform/chromium-win/fast/forms/search-cancel-button-style-sharing-expected.png:
* platform/chromium-win/fast/forms/search-display-none-cancel-button-expected.png:
* platform/chromium-win/fast/forms/search-rtl-expected.png:
* platform/chromium-win/fast/forms/searchfield-heights-expected.png:
* platform/chromium-win/fast/forms/select-align-expected.png:
* platform/chromium-win/fast/forms/select-background-none-expected.png:
* platform/chromium-win/fast/forms/select-baseline-expected.png:
* platform/chromium-win/fast/forms/select-block-background-expected.png:
* platform/chromium-win/fast/forms/select-change-listbox-size-expected.png:
* platform/chromium-win/fast/forms/select-change-listbox-to-popup-expected.png:
* platform/chromium-win/fast/forms/select-change-popup-to-listbox-expected.png:
* platform/chromium-win/fast/forms/select-dirty-parent-pref-widths-expected.png:
* platform/chromium-win/fast/forms/select-disabled-appearance-expected.png:
* platform/chromium-win/fast/forms/select-initial-position-expected.png:
* platform/chromium-win/fast/forms/select-list-box-with-height-expected.png:
* platform/chromium-win/fast/forms/select-listbox-multiple-no-focusring-expected.png:
* platform/chromium-win/fast/forms/select-overflow-scroll-expected.png:
* platform/chromium-win/fast/forms/select-overflow-scroll-inherited-expected.png:
* platform/chromium-win/fast/forms/select-selected-expected.png:
* platform/chromium-win/fast/forms/select-size-expected.png:
* platform/chromium-win/fast/forms/select-style-expected.png:
* platform/chromium-win/fast/forms/select-visual-hebrew-expected.png:
* platform/chromium-win/fast/forms/select-writing-direction-natural-expected.png:
* platform/chromium-win/fast/forms/select/optgroup-rendering-expected.png:
* platform/chromium-win/fast/forms/selectlist-minsize-expected.png:
* platform/chromium-win/fast/forms/stuff-on-my-optgroup-expected.png:
* platform/chromium-win/fast/forms/tabbing-input-iframe-expected.png:
* platform/chromium-win/fast/forms/text-style-color-expected.png:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-1-expected.png:
* platform/chromium-win/fast/forms/textarea-placeholder-visibility-2-expected.png:
* platform/chromium-win/fast/forms/textarea-scrollbar-expected.png:
* platform/chromium-win/fast/forms/textarea-scrolled-type-expected.png:
* platform/chromium-win/fast/forms/textarea/textarea-placeholder-paint-order-expected.png:
* platform/chromium-win/fast/forms/textfield-focus-ring-expected.png:
* platform/chromium-win/fast/forms/textfield-overflow-expected.png:
* platform/chromium-win/fast/forms/validation-message-appearance-expected.png:
* platform/chromium-win/fast/forms/visual-hebrew-text-field-expected.png:
* platform/chromium-win/fast/frames/take-focus-from-iframe-expected.png:
* platform/chromium-win/fast/gradients/background-clipped-expected.png:
* platform/chromium-win/fast/html/details-no-summary4-expected.png:
* platform/chromium-win/fast/html/details-open-javascript-expected.png:
* platform/chromium-win/fast/html/details-open2-expected.png:
* platform/chromium-win/fast/html/details-open4-expected.png:
* platform/chromium-win/fast/html/details-position-expected.png:
* platform/chromium-win/fast/html/details-replace-summary-child-expected.png:
* platform/chromium-win/fast/html/details-replace-text-expected.png:
* platform/chromium-win/fast/html/details-writing-mode-expected.png:
* platform/chromium-win/fast/html/keygen-expected.png:
* platform/chromium-win/fast/invalid/014-expected.png:
* platform/chromium-win/fast/layers/scroll-with-transform-composited-layer-expected.png:
* platform/chromium-win/fast/layers/scroll-with-transform-layer-expected.png:
* platform/chromium-win/fast/lists/008-expected.png:
* platform/chromium-win/fast/lists/008-vertical-expected.png:
* platform/chromium-win/fast/lists/dynamic-marker-crash-expected.png:
* platform/chromium-win/fast/overflow/overflow-rtl-expected.png:
* platform/chromium-win/fast/overflow/overflow-rtl-vertical-expected.png:
* platform/chromium-win/fast/overflow/overflow-update-transform-expected.png:
* platform/chromium-win/fast/overflow/overflow-with-local-background-attachment-expected.png:
* platform/chromium-win/fast/parser/document-write-option-expected.png:
* platform/chromium-win/fast/repaint/control-clip-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-container-expected.png:
* platform/chromium-win/fast/repaint/moving-shadow-on-path-expected.png:
* platform/chromium-win/fast/repaint/renderer-destruction-by-invalidateSelection-crash-expected.png:
* platform/chromium-win/fast/repaint/select-option-background-color-expected.png:
* platform/chromium-win/fast/repaint/subtree-root-skipped-expected.png:
* platform/chromium-win/fast/repaint/transform-absolute-in-positioned-container-expected.png:
* platform/chromium-win/fast/replaced/replaced-breaking-expected.png:
* platform/chromium-win/fast/replaced/replaced-breaking-mixture-expected.png:
* platform/chromium-win/fast/replaced/three-selects-break-expected.png:
* platform/chromium-win/fast/replaced/width100percent-searchfield-expected.png:
* platform/chromium-win/fast/replaced/width100percent-textfield-expected.png:
* platform/chromium-win/fast/selectors/166-expected.png:
* platform/chromium-win/fast/selectors/unqualified-hover-strict-expected.png:
* platform/chromium-win/fast/selectors/unqualified-hover-strict-expected.txt:
* platform/chromium-win/fast/speech/input-appearance-numberandspeech-expected.png:
* platform/chromium-win/fast/speech/input-appearance-searchandspeech-expected.png:
* platform/chromium-win/fast/speech/input-appearance-speechbutton-expected.png:
* platform/chromium-win/fast/speech/speech-bidi-rendering-expected.png:
* platform/chromium-win/fast/table/003-expected.png:
* platform/chromium-win/fast/table/colspanMinWidth-expected.png:
* platform/chromium-win/fast/table/spanOverlapRepaint-expected.png:
* platform/chromium-win/fast/table/text-field-baseline-expected.png:
* platform/chromium-win/fast/text/drawBidiText-expected.png:
* platform/chromium-win/fast/text/international/bidi-listbox-atsui-expected.png:
* platform/chromium-win/fast/text/international/bidi-listbox-expected.png:
* platform/chromium-win/fast/text/international/bidi-menulist-expected.png:
* platform/chromium-win/fast/text/international/pop-up-button-text-alignment-and-direction-expected.png:
* platform/chromium-win/fast/text/textIteratorNilRenderer-expected.png:
* platform/chromium-win/fast/text/updateNewFont-expected.png:
* platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-1-expected.png:
* platform/chromium-win/fast/transforms/rotated-transform-affects-scrolling-2-expected.png:
* platform/chromium-win/fast/transforms/transformed-focused-text-input-expected.png:
* platform/chromium-win/fast/writing-mode/border-radius-clipping-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/box-shadow-vertical-lr-expected.png:
* platform/chromium-win/fast/writing-mode/box-shadow-vertical-rl-expected.png:
* platform/chromium-win/fonts/monospace-expected.png:
* platform/chromium-win/http/tests/misc/object-embedding-svg-delayed-size-negotiation-expected.png:
* platform/chromium-win/http/tests/navigation/javascriptlink-frames-expected.png:
* platform/chromium-win/ietestcenter/css3/bordersbackgrounds/border-radius-sum-of-radii-002-expected.png:
* platform/chromium-win/plugins/mouse-click-plugin-clears-selection-expected.png:
* platform/chromium-win/svg/as-image/image-respects-pageScaleFactor-expected.png:
* platform/chromium-win/svg/css/composite-shadow-example-expected.png:
* platform/chromium-win/svg/css/composite-shadow-with-opacity-expected.png:
* platform/chromium-win/svg/css/stars-with-shadow-expected.png:
* platform/chromium-win/svg/custom/foreign-object-skew-expected.png:
* platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-expected.png:
* platform/chromium-win/svg/custom/getscreenctm-in-scrollable-div-area-nested-expected.png:
* platform/chromium-win/svg/custom/getscreenctm-in-scrollable-svg-area-expected.png:
* platform/chromium-win/svg/custom/inline-svg-in-xhtml-expected.png:
* platform/chromium-win/svg/custom/non-scaling-stroke-expected.png:
* platform/chromium-win/svg/custom/object-sizing-no-width-height-expected.png:
* platform/chromium-win/svg/custom/pattern-rotate-expected.png:
* platform/chromium-win/svg/dom/SVGTransformList-basics-expected.png:
* platform/chromium-win/svg/dom/css-transforms-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVG-dynamic-css-transform-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGLinearGradientElement-svgdom-gradientTransform-prop-expected.png:
* platform/chromium-win/svg/dynamic-updates/SVGRadialGradientElement-svgdom-gradientTransform-prop-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-objectBoundingBox-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-objectBoundingBox-expected.png:
* platform/chromium-win/svg/filters/feImage-filterUnits-userSpaceOnUse-primitiveUnits-userSpaceOnUse-expected.png:
* platform/chromium-win/svg/hixie/mixed/003-expected.png:
* platform/chromium-win/svg/in-html/circle-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-inside-transformed-html-expected.png:
* platform/chromium-win/svg/transforms/text-with-pattern-with-svg-transform-expected.png:
* platform/chromium-win/svg/wicd/rightsizing-grid-expected.png:
* platform/chromium-win/svg/wicd/test-rightsizing-b-expected.png:
* platform/chromium-win/svg/wicd/test-scalable-background-image1-expected.png:
* platform/chromium-win/svg/zoom/page/absolute-sized-document-scrollbars-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-hixie-mixed-008-expected.png:
* platform/chromium-win/svg/zoom/page/zoom-mask-with-percentages-expected.png:
* platform/chromium-win/tables/mozilla/bugs/45621-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug1188-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug12384-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug18359-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug24200-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2479-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug2479-3-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug28928-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug29326-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug30692-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug33855-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4382-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug44505-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug4527-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug46368-1-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug46368-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug51037-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug55545-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug59354-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug7342-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug92647-2-expected.png:
* platform/chromium-win/tables/mozilla/bugs/bug96334-expected.png:
* platform/chromium-win/tables/mozilla/core/margins-expected.png:
* platform/chromium-win/tables/mozilla/dom/tableDom-expected.png:
* platform/chromium-win/tables/mozilla/marvin/backgr_index-expected.png:
* platform/chromium-win/tables/mozilla/marvin/backgr_layers-opacity-expected.png:
* platform/chromium-win/tables/mozilla/other/move_row-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug1725-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/bugs/bug92647-1-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_fixed-bg-expected.png:
* platform/chromium-win/tables/mozilla_expected_failures/marvin/backgr_layers-show-expected.png:
* platform/chromium-win/transforms/2d/hindi-rotated-expected.png:
* platform/chromium-win/transforms/2d/hindi-rotated-expected.txt:
* platform/chromium-win/transforms/2d/zoom-menulist-expected.png:
* platform/chromium/TestExpectations:
* platform/efl/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.
* platform/gtk/css2.1/20110323/block-replaced-width-001-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124142 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoUnreviewed, rolling out r124123.
commit-queue@webkit.org [Tue, 31 Jul 2012 01:48:18 +0000 (01:48 +0000)]
Unreviewed, rolling out r124123.
http://trac.webkit.org/changeset/124123
https://bugs.webkit.org/show_bug.cgi?id=92700

ASSERT crashes terminate webkit Layout tests (Requested by
msaboff on #webkit).

Patch by Sheriff Bot <webkit.review.bot@gmail.com> on 2012-07-30

* heap/Heap.cpp:
* heap/Heap.h:
(Heap):
* heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::doSweep):
(JSC::IncrementalSweeper::startSweeping):
(JSC::IncrementalSweeper::IncrementalSweeper):
(JSC):
* heap/IncrementalSweeper.h:
(IncrementalSweeper):
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper):
(JSC::MarkedAllocator::addBlock):
* heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList):
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper):
* heap/MarkedSpace.cpp:
* heap/MarkedSpace.h:
(JSC::MarkedSpace::sweep):
(JSC):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124141 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agowebkit-patch: system keyring is not used to read my password
commit-queue@webkit.org [Tue, 31 Jul 2012 01:45:44 +0000 (01:45 +0000)]
webkit-patch: system keyring is not used to read my password
https://bugs.webkit.org/show_bug.cgi?id=92532

Patch by Arnaud Renevier <a.renevier@sisa.samsung.com> on 2012-07-30
Reviewed by Dirk Pranke.

In case no username can be fetched from environment, git or keychain,
prompt for username, and try to get password from keyring associated
with that username.

* Scripts/webkitpy/common/net/credentials.py:
(Credentials.read_credentials):
* Scripts/webkitpy/common/net/credentials_unittest.py:
(test_keyring_without_git_repo_nor_keychain):
(test_keyring_without_git_repo_nor_keychain.MockKeyring):
(test_keyring_without_git_repo_nor_keychain.MockKeyring.get_password):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_keychain):
(test_keyring_without_git_repo_nor_keychain.FakeCredentials._credentials_from_environment):
(test_keyring_without_git_repo_nor_keychain.FakeUser):
(test_keyring_without_git_repo_nor_keychain.FakeUser.prompt):
(test_keyring_without_git_repo_nor_keychain.FakeUser.prompt_password):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124140 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: move the code that identifies the chunk of tests to run into finder
dpranke@chromium.org [Tue, 31 Jul 2012 01:40:34 +0000 (01:40 +0000)]
nrwt: move the code that identifies the chunk of tests to run into finder
https://bugs.webkit.org/show_bug.cgi?id=92694

Reviewed by Ryosuke Niwa.

Another patch to make manager.py smaller and clearer; this patch moves
the handling of breaking the list of tests into chunks (--run-part,
--run-chunk) from manager.py to finder.py.

There are no functional changes and this is covered by existing tests.

* Scripts/webkitpy/layout_tests/controllers/finder.py:
(Finder.__init__):
(Finder._read_test_files):
(Finder):
(Finder.split_into_chunks_if_necessary):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager.__init__):
(Manager._collect_tests):
(Manager._parse_expectations):
(Manager.prepare_lists_and_print_output):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124139 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoGrid Demo spends 1.5% of total time allocating Path objects in RenderBoxModelObject...
eric@webkit.org [Tue, 31 Jul 2012 01:14:15 +0000 (01:14 +0000)]
Grid Demo spends 1.5% of total time allocating Path objects in RenderBoxModelObject::paintBorderSides
https://bugs.webkit.org/show_bug.cgi?id=92252

Reviewed by Simon Fraser.

This change introduces the concept of a "null Path" very similar to a null WTF::String.
Just like String functions as a RefPtr around a StringImpl, Path (for most ports)
functions as an OwnPtr around a PlatformPathPtr.

In various places in the code, we declare a local Path variable, but don't necessarily
use that Path variable in all code paths, or might pass that Path variable along to GraphicsContext
functions, without ever actually adding points to that Path.
On most platforms, this Path default constructor was causing a malloc!
In some of these case, the code-path in question (like paintBorderSides) can be quite hot.
Introducing this null-Path and delaying instantiation of the PlatformPath object
until it's actually needed, saves a malloc for these hot paths.

To test this, I loaded a few popular pages, and added printfs to both the Path constructor
and destructor, logging during construction and destruction when the path was still null at destruction time.

This simple testing showed this to be a small win (avoiding mallocs) on many sites and a huge win for Google Spreadsheets:
apple.com: 147 Paths created, 9 (6%) destroyed null.
google.com: 58 Paths created, 26 (44%) destroyed null (google seems creating 5 paths every second after load?  1 of which is destroyed empty.)
amazon.com: 130 Paths created, 130 (100%) destroyed null.
Loading an empty spreadsheet from drive.google.com: 5237 created, 4861 destroyed null (92%!) :)

* platform/graphics/Path.h:
(Path):
(WebCore::Path::isNull):
(WebCore::Path::ensurePlatformPath):
* platform/graphics/cairo/CairoUtilities.cpp:
(WebCore::appendWebCorePathToCairoContext):
* platform/graphics/cairo/GraphicsContextCairo.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clip):
* platform/graphics/cairo/PathCairo.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::ensurePlatformPath):
(WebCore):
(WebCore::Path::operator=):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::currentPoint):
(WebCore::Path::translate):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addRect):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArc):
(WebCore::Path::addArcTo):
(WebCore::Path::addEllipse):
(WebCore::Path::closeSubpath):
(WebCore::Path::boundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::apply):
(WebCore::Path::transform):
* platform/graphics/cg/GraphicsContextCG.cpp:
(WebCore::GraphicsContext::drawPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::clipOut):
* platform/graphics/cg/PathCG.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore):
(WebCore::Path::ensurePlatformPath):
(WebCore::Path::operator=):
(WebCore::Path::contains):
(WebCore::Path::strokeContains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::fastBoundingRect):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::platformAddPathForRoundedRect):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::clear):
(WebCore::Path::isEmpty):
(WebCore::Path::currentPoint):
(WebCore::Path::apply):
* platform/graphics/gpu/LoopBlinnPathProcessor.cpp:
(WebCore):
(WebCore::LoopBlinnPathProcessor::buildContours):
* platform/graphics/mac/GraphicsContextMac.mm:
(WebCore::GraphicsContext::drawFocusRing):
* platform/graphics/openvg/PainterOpenVG.cpp:
(WebCore::PainterOpenVG::drawPath):
* platform/graphics/skia/GraphicsContextSkia.cpp:
(WebCore::GraphicsContext::clip):
(WebCore::GraphicsContext::canvasClip):
(WebCore::GraphicsContext::clipOut):
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/graphics/skia/PathSkia.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore):
(WebCore::Path::ensurePlatformPath):
(WebCore::Path::operator=):
(WebCore::Path::isEmpty):
(WebCore::Path::hasCurrentPoint):
(WebCore::Path::currentPoint):
(WebCore::Path::contains):
(WebCore::Path::translate):
(WebCore::Path::boundingRect):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::clear):
(WebCore::Path::apply):
(WebCore::Path::transform):
(WebCore::Path::strokeBoundingRect):
(WebCore::Path::strokeContains):
* platform/graphics/wince/GraphicsContextWinCE.cpp:
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/graphics/wx/GraphicsContextWx.cpp:
(WebCore::GraphicsContext::clipPath):
(WebCore::GraphicsContext::fillPath):
(WebCore::GraphicsContext::strokePath):
* platform/graphics/wx/PathWx.cpp:
(WebCore::Path::Path):
(WebCore::Path::~Path):
(WebCore::Path::boundingRect):
(WebCore::Path::operator=):
(WebCore::Path::ensurePlatformPath):
(WebCore):
(WebCore::Path::clear):
(WebCore::Path::moveTo):
(WebCore::Path::addLineTo):
(WebCore::Path::addQuadCurveTo):
(WebCore::Path::addBezierCurveTo):
(WebCore::Path::addArcTo):
(WebCore::Path::closeSubpath):
(WebCore::Path::addArc):
(WebCore::Path::addRect):
(WebCore::Path::addEllipse):
(WebCore::Path::transform):
(WebCore::Path::currentPoint):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124135 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd WTF_EXPORT_PRIVATE to deleteOwnedPtr()
paroga@webkit.org [Tue, 31 Jul 2012 01:13:48 +0000 (01:13 +0000)]
Add WTF_EXPORT_PRIVATE to deleteOwnedPtr()
https://bugs.webkit.org/show_bug.cgi?id=92668

Reviewed by Hajime Morita.

When using export macros all non-inlined deleteOwnedPtr()
functions need to be declared with WTF_EXPORT_PRIVATE.

* wtf/OwnPtrCommon.h:
(WTF):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: split test-finding code out from manager.py
dpranke@chromium.org [Tue, 31 Jul 2012 01:02:13 +0000 (01:02 +0000)]
nrwt: split test-finding code out from manager.py
https://bugs.webkit.org/show_bug.cgi?id=92693

Reviewed by Ryosuke Niwa.

In the interest of making manager.py smaller, this patch moves
the code that actually takes the command line arguments and
--test-file lists of tests to run and expands them into an
actual list of tests out into a separate module.

* Scripts/webkitpy/layout_tests/controllers/finder.py: Added.
(LayoutTestFinder):
(LayoutTestFinder.__init__):
(LayoutTestFinder.find_tests):
(LayoutTestFinder._strip_test_dir_prefixes):
(LayoutTestFinder._strip_test_dir_prefix):
(LayoutTestFinder._read_test_names_from_file):
* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._collect_tests):
(Manager._handle_finished_test):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(strip_comments):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agocommit-queue is corrupting ChangeLogs
abarth@webkit.org [Tue, 31 Jul 2012 00:49:39 +0000 (00:49 +0000)]
commit-queue is corrupting ChangeLogs
https://bugs.webkit.org/show_bug.cgi?id=92681

Reviewed by Tony Chang.

Some commits made with the commit-queue are ending up with duplicate
ChangeLog entries. I've hot-patched the servers to not use a special
merge driver for ChangeLogs, which should fix this issue. This patch
removes the merge driver from our cold-boot.sh script so that we won't
use it on new commit-queue instances.

* EWSTools/cold-boot.sh:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoinspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebVi...
msaboff@apple.com [Tue, 31 Jul 2012 00:46:23 +0000 (00:46 +0000)]
inspector/profiler/heap-snapshot-containment-show-all.html test crashing during WebView closing
<rdar://problem/11991881>

* platform/mac-lion/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124126 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoStructures should be swept after all other objects
mhahnenberg@apple.com [Tue, 31 Jul 2012 00:33:53 +0000 (00:33 +0000)]
Structures should be swept after all other objects
https://bugs.webkit.org/show_bug.cgi?id=92679

Reviewed by Filip Pizlo.

In order to get rid of ClassInfo from our objects, we need to be able to safely get the
ClassInfo during the destruction of objects. We'd like to get the ClassInfo out of the
Structure, but currently it is not safe to do so because the order of destruction of objects
is not guaranteed to sweep objects before their corresponding Structure. We can fix this by
sweeping Structures after everything else.

* heap/Heap.cpp:
(JSC::Heap::isSafeToSweepStructures): Add a function that checks if it is safe to sweep Structures.
If the Heap's IncrementalSweeper member is null, that means we're shutting down this VM and it is
safe to sweep structures since we'll always do Structures last anyways due to the ordering of
MarkedSpace::forEachBlock.
(JSC):
(JSC::Heap::didStartVMShutdown): Add this intermediate function to the Heap that ~JSGlobalData now
calls rather than calling the two HeapTimer objects individually. This allows the Heap to null out
these pointers after it has invalidated them to prevent accidental use-after-free in the sweep()
calls during lastChanceToFinalize().
* heap/Heap.h:
(Heap):
* heap/HeapTimer.h:
(HeapTimer):
* heap/IncrementalSweeper.cpp:
(JSC::IncrementalSweeper::structuresCanBeSwept): Determines if it is currently safe to sweep Structures.
This decision is based on whether we have gotten to the end of the vector of blocks that need sweeping
the first time.
(JSC):
(JSC::IncrementalSweeper::doSweep): We add a second pass over the vector to sweep Structures after we
make our first pass. We now null out the slots as we sweep them so that we can quickly find the
Structures during the second pass.
(JSC::IncrementalSweeper::startSweeping): Initialize our new Structure sweeping index.
(JSC::IncrementalSweeper::willFinishSweeping): Callback that is called by MarkedSpace::sweep to notify
the IncrementalSweeper that we are going to sweep all of the remaining blocks in the Heap so it can
assume that everything is taken care of in the correct order. Since MarkedSpace::forEachBlock
iterates over the Structure blocks after all other blocks, the ordering property for sweeping Structures holds.
(JSC::IncrementalSweeper::IncrementalSweeper): Initialize Structure sweeping index.
* heap/IncrementalSweeper.h: Add declarations for new stuff.
(IncrementalSweeper):
* heap/MarkedAllocator.cpp:
(JSC::MarkedAllocator::tryAllocateHelper): We now check if the current block only contains structures and
if so and it isn't safe to sweep Structures according to the Heap, we just return early instead of doing
the normal lazy sweep. If this proves to be too much of a waste in the future we can add an extra clause that
will sweep some number of other blocks in place of the current block to mitigate the cost of the floating
Structure garbage.
(JSC::MarkedAllocator::addBlock):
* heap/MarkedAllocator.h:
(JSC::MarkedAllocator::zapFreeList): When we zap the free list in the MarkedAllocator, the current block is no
longer valid to allocate from, so we set the current block to null.
* heap/MarkedBlock.cpp:
(JSC::MarkedBlock::sweepHelper): Added a couple assertions to make sure that we weren't trying to sweep Structures
at an unsafe time.
* heap/MarkedSpace.cpp:
(JSC::MarkedSpace::sweep): Notify the IncrementalSweeper that the MarkedSpace will finish all currently remaining sweeping.
(JSC):
* heap/MarkedSpace.h:
(JSC):
* runtime/JSGlobalData.cpp:
(JSC::JSGlobalData::~JSGlobalData): Call the new Heap::didStartVMShutdown.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoAdd ability to load from a string to the ObjC WK API
weinig@apple.com [Tue, 31 Jul 2012 00:24:36 +0000 (00:24 +0000)]
Add ability to load from a string to the ObjC WK API
https://bugs.webkit.org/show_bug.cgi?id=92590

Reviewed by Dan Bernstein.

Source/WebKit2:

This adds an often used method to the new Objective-C API and will
be helpful for writing API tests.

* UIProcess/API/mac/WKBrowsingContextController.h:
* UIProcess/API/mac/WKBrowsingContextController.mm:
(-[WKBrowsingContextController loadHTMLString:baseURL:]):
Implement via calling down to WKPageLoadHTMLString.

Tools:

Add tests for [WKBrowsingContextController loadHTMLString:baseURL:]. We will be able
to greatly improve these tests (to test more than just not crashing) when methods to
access page content are added (soon!).

Adds:
    Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString
    Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilBaseURL
    Test: WKBrowsingContextLoadDelegateTest_SimpleLoadOfHTMLString_NilHTMLStringAndBaseURL

* TestWebKitAPI/Tests/WebKit2ObjC/WKBrowsingContextLoadDelegateTest.mm:
Adds tests and refactors delegates to not use global state.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years ago[CMake] TestWebKitAPI bundle should link with WTF
commit-queue@webkit.org [Tue, 31 Jul 2012 00:11:51 +0000 (00:11 +0000)]
[CMake] TestWebKitAPI bundle should link with WTF
https://bugs.webkit.org/show_bug.cgi?id=92616

Patch by Thiago Marcos P. Santos <thiago.santos@intel.com> on 2012-07-30
Reviewed by Antonio Gomes.

Fixes build when shared core is disabled.

* TestWebKitAPI/CMakeLists.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124118 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agonrwt: clean up handling of 'expected' stats
dpranke@chromium.org [Tue, 31 Jul 2012 00:01:52 +0000 (00:01 +0000)]
nrwt: clean up handling of 'expected' stats
https://bugs.webkit.org/show_bug.cgi?id=92527

Reviewed by Tony Chang.

This patch alters the way we compute and log the "expected"
results and how we treat skipped tests; we will now log the
number of skipped tests separately from the categories, e.g.:

Found 31607 tests; running 24464.
Expect: 23496 passes   (23496 now,    0 wontfix)
Expect:   548 failures (  543 now,    5 wontfix)
Expect:   420 flaky    (  245 now,  175 wontfix)

(so that the "expect" totals add up to the "running" totals);
in addition, the totals in the one-line-progress reflect the
number of tests we will actually run. If --iterations or
--repeat-each are specified, the number of tests we run are
multiplied as appropriate, but the "expect" numbers are
unchanged, since we don't count multiple invocations of the same
test multiple times. In addition, if we are using --run-part or
--run-chunk, the tests we don't run are treated as skipped
for consistency. We will also log the values for --iterations
and --repeat each as part of the found/running line.

Previously the code had parsed and re-parsed the
TestExpectations files several times in an attempt to come up
with some sane statistics, but this was expensive and lead to
confusing layer; treating files as skipped in the way described
above is more consistent and cleaner.

* Scripts/webkitpy/layout_tests/controllers/manager.py:
(Manager._split_into_chunks_if_necessary):
(Manager.prepare_lists_and_print_output):
(Manager.run):
* Scripts/webkitpy/layout_tests/controllers/manager_unittest.py:
(ManagerTest.test_interrupt_if_at_failure_limits):
(ManagerTest.test_update_summary_with_result):
(ManagerTest.test_look_for_new_crash_logs):
(ResultSummaryTest.get_result_summary):
* Scripts/webkitpy/layout_tests/models/result_summary.py:
(ResultSummary.__init__):
* Scripts/webkitpy/layout_tests/models/test_expectations.py:
(TestExpectationParser.expectation_for_skipped_test):
(TestExpectations.__init__):
(TestExpectations.add_skipped_tests):
  Here we make add_skipped_tests() public, so that we can update
  the expectations for tests that we are skipping due to
  --run-part or --run-chunk; we use the wontfix flag so that
  the tests that are intentionally skipped aren't considered
  "fixable".
* Scripts/webkitpy/layout_tests/models/test_expectations_unittest.py:
(SkippedTests.check):
* Scripts/webkitpy/layout_tests/run_webkit_tests.py:
(parse_args):
* Scripts/webkitpy/layout_tests/views/printing.py:
(Printer.print_found):
(Printer):
(Printer.print_expected):
(Printer._print_result_summary):
(Printer._print_result_summary_entry):
  Here we split out printing the number of tests found and run
  from the expected results, to be clearer and so that we don't
  have to reparse the expectations to update the stats.
* Scripts/webkitpy/layout_tests/views/printing_unittest.py:
(Testprinter.get_result_summary):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124116 268f45cc-cd09-0410-ab3c-d52691b4dbfc

8 years agoatomicDecrement() never reach 0 on Android so no deref() will be called
commit-queue@webkit.org [Mon, 30 Jul 2012 23:53:20 +0000 (23:53 +0000)]
atomicDecrement() never reach 0 on Android so no deref() will be called
https://bugs.webkit.org/show_bug.cgi?id=92635

Patch by Wei James <james.wei@intel.com> on 2012-07-30
Reviewed by Adam Barth.

With Android NDK 7b and later, __atomic_dec()  is implemented by
__sync_fetch_and_sub(), which will result in that atomicDecrement()
returns the old value instead of new one.

* wtf/Atomics.h:
(WTF):
(WTF::atomicIncrement):
(WTF::atomicDecrement):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@124115 268f45cc-cd09-0410-ab3c-d52691b4dbfc