WebKit-https.git
10 years agoWindows build fix. Update the createNewPage callback to account for the new
bweinstein@apple.com [Fri, 22 Oct 2010 21:43:59 +0000 (21:43 +0000)]
Windows build fix. Update the createNewPage callback to account for the new
arguments.

* MiniBrowser/win/BrowserView.cpp:
(createNewPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70345 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 22 Oct 2010 21:40:44 +0000 (21:40 +0000)]
2010-10-22  Patrick Gansterer  <paroga@webkit.org>

        Unreviewed.

        [WINCE] Build fix after r70143.

        * platform/graphics/wince/ImageBufferWinCE.cpp:
        (WebCore::ImageBuffer::ImageBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70343 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix windows build.
weinig@apple.com [Fri, 22 Oct 2010 21:32:20 +0000 (21:32 +0000)]
Fix windows build.

* WebCoreSupport/WebChromeClient.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70341 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWindows build fix
aroben@apple.com [Fri, 22 Oct 2010 21:16:26 +0000 (21:16 +0000)]
Windows build fix

r70319 added Windows-native versions of the various platform/network
headers to platform/network/win. WebCoreGenerated was copying these
headers over the CFNetwork-specific versions in $WebKitOutputDir,
leading to the wrong headers being used in WebKit.

This patch changes WebCoreGenerated not to copy any headers from
platform/network/win into $WebKitOutputDir. Instead, only headers from
platform/network/cf or platform/network/curl (as specified) are copied.
There were some CFNetwork-specific files still hanging around in
platform/network/win; these have been moved to platform/network/cf.

* WebCore.vcproj/WebCore.vcproj: Updated for file moves and let VS
* format the file as it saw fit.

* WebCore.vcproj/WebCoreGenerated.vcproj: Added the various scripts
* this project uses to make editing them easier.

* WebCore.vcproj/copyForwardingHeaders.cmd: Changed not to copy any
* headers from platform/network/win.

* platform/network/cf/CookieJarCFNet.cpp: Renamed from WebCore/platform/network/win/CookieJarCFNetWin.cpp.
* platform/network/cf/CookieStorageCFNet.cpp: Renamed from WebCore/platform/network/win/CookieStorageWin.cpp.
* platform/network/cf/CookieStorageCFNet.h: Renamed from WebCore/platform/network/win/CookieStorageWin.h.

* platform/network/cf/ResourceHandleCFNet.cpp: Updated for rename.

* platform/network/cf/AuthenticationChallenge.h:
* platform/network/cf/ResourceError.h:
* platform/network/cf/ResourceRequest.h:
* platform/network/cf/ResourceResponse.h:
* platform/network/cf/SocketStreamError.h:
* platform/network/cf/SocketStreamHandle.h:
Touched to force a re-copy.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70339 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFix Qt build.
weinig@apple.com [Fri, 22 Oct 2010 21:08:18 +0000 (21:08 +0000)]
Fix Qt build.

* UIProcess/API/qt/ClientImpl.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70336 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Abhishek Arya <inferno@chromium.org>
inferno@chromium.org [Fri, 22 Oct 2010 21:05:16 +0000 (21:05 +0000)]
2010-10-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Add code in getMatchedCSSRules to block cross origin access to stylesheet data. Prevent access
        in Javascript to non author stylesheets.
        https://bugs.webkit.org/show_bug.cgi?id=46853

        Tests: http/tests/security/cross-origin-getMatchedCSSRules.html
               http/tests/security/cross-origin-getMatchedCSSRules2.html

        * css/CSSRule.h:
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::matchRulesForList):
        (WebCore::CSSStyleSelector::SelectorChecker::SelectorChecker):
        (WebCore::CSSStyleSelector::styleRulesForElement):
        (WebCore::CSSStyleSelector::pseudoStyleRulesForElement):
        * css/CSSStyleSelector.h:
        * page/DOMWindow.cpp:
        (WebCore::DOMWindow::getMatchedCSSRules):
        * page/DOMWindow.idl:
2010-10-22  Abhishek Arya  <inferno@chromium.org>

        Reviewed by Dave Hyatt.

        Tests that cross origin bypass does not work with getMatchedCSSRules. Rebaseline existing tests
        that try to access non-author stylesheets. This functionality is no longer supported. So, css rules
        should return null for those cases.
        https://bugs.webkit.org/show_bug.cgi?id=46853

        * fast/backgrounds/repeat/background-repeat-shorthand-expected.txt:
        * fast/backgrounds/repeat/margin-shorthand-expected.txt:
        * fast/backgrounds/repeat/resources/background-repeat-shorthand.js:
        * fast/backgrounds/repeat/resources/margin-shorthand.js:
        * fast/css/disabled-author-styles.html:
        * fast/css/modify-ua-rules-from-javascript-expected.txt:
        * fast/css/modify-ua-rules-from-javascript.html:
        * fast/css/word-break-user-modify-allowed-values.html:
        * http/tests/security/cross-frame-access-call-expected.txt:
        * http/tests/security/cross-frame-access-call.html:
        * http/tests/security/cross-origin-getMatchedCSSRules-expected.txt: Added.
        * http/tests/security/cross-origin-getMatchedCSSRules.html: Added.
        * http/tests/security/cross-origin-getMatchedCSSRules2-expected.txt: Added.
        * http/tests/security/cross-origin-getMatchedCSSRules2.html: Added.
        * http/tests/security/resources/cross-origin-getMatchedCSSRules-frame.html: Added.
        * platform/chromium/http/tests/security/cross-frame-access-call-expected.txt:
        * platform/qt/http/tests/security/cross-frame-access-call-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70335 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd the tests for r70332.
aestes@apple.com [Fri, 22 Oct 2010 21:01:44 +0000 (21:01 +0000)]
Add the tests for r70332.
https://bugs.webkit.org/show_bug.cgi?id=48046

Reviewed by Eric Carlson.

* plugins/invalid-mime-with-valid-extension-shows-missing-plugin-expected.txt: Added.
* plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70334 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit2 needs to pass the current event modifier flags when requesting a new window
weinig@apple.com [Fri, 22 Oct 2010 20:59:02 +0000 (20:59 +0000)]
WebKit2 needs to pass the current event modifier flags when requesting a new window
https://bugs.webkit.org/show_bug.cgi?id=48140

Reviewed by Anders Carlsson.

WebCore:

Store the NavigationAction used for the newWindowPolicyDecision in the PolicyCallback
so that it can be used after the decision has been made in further callbacks.

* WebCore.exp.in: Fix export name for new function signature.
* loader/EmptyClients.h:
(WebCore::EmptyChromeClient::createWindow):
(WebCore::EmptyFrameLoaderClient::dispatchCreatePage):
* loader/FrameLoader.cpp:
(WebCore::FrameLoader::callContinueLoadAfterNewWindowPolicy):
(WebCore::FrameLoader::continueLoadAfterNewWindowPolicy):
(WebCore::createWindow):
* loader/FrameLoader.h:
* loader/FrameLoaderClient.h:
* loader/PolicyCallback.cpp:
(WebCore::PolicyCallback::set):
(WebCore::PolicyCallback::call):
(WebCore::PolicyCallback::cancel):
* loader/PolicyCallback.h:
* loader/PolicyChecker.cpp:
(WebCore::PolicyChecker::checkNewWindowPolicy):
* page/Chrome.cpp:
(WebCore::Chrome::createWindow):
* page/Chrome.h:
* page/ChromeClient.h:
* page/ContextMenuController.cpp:
(WebCore::openNewWindow):

WebKit/chromium:

* src/ChromeClientImpl.cpp:
(WebKit::ChromeClientImpl::createWindow):
* src/ChromeClientImpl.h:
* src/FrameLoaderClientImpl.cpp:
(WebKit::FrameLoaderClientImpl::dispatchCreatePage):
* src/FrameLoaderClientImpl.h:
Add NavigationAction parameter.

WebKit/efl:

* WebCoreSupport/ChromeClientEfl.cpp:
(WebCore::ChromeClientEfl::createWindow):
* WebCoreSupport/ChromeClientEfl.h:
* WebCoreSupport/FrameLoaderClientEfl.cpp:
(WebCore::FrameLoaderClientEfl::dispatchCreatePage):
* WebCoreSupport/FrameLoaderClientEfl.h:
Add NavigationAction parameter.

WebKit/gtk:

* WebCoreSupport/ChromeClientGtk.cpp:
(WebKit::ChromeClient::createWindow):
* WebCoreSupport/ChromeClientGtk.h:
* WebCoreSupport/FrameLoaderClientGtk.cpp:
(WebKit::FrameLoaderClient::dispatchCreatePage):
* WebCoreSupport/FrameLoaderClientGtk.h:
Add NavigationAction parameter.

WebKit/haiku:

* WebCoreSupport/ChromeClientHaiku.cpp:
(WebCore::ChromeClientHaiku::createWindow):
* WebCoreSupport/ChromeClientHaiku.h:
* WebCoreSupport/FrameLoaderClientHaiku.cpp:
(WebCore::FrameLoaderClientHaiku::dispatchCreatePage):
* WebCoreSupport/FrameLoaderClientHaiku.h:
Add NavigationAction parameter.

WebKit/mac:

* WebCoreSupport/WebChromeClient.h:
* WebCoreSupport/WebChromeClient.mm:
(WebChromeClient::createWindow):
* WebCoreSupport/WebFrameLoaderClient.h:
* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::dispatchCreatePage):
Add NavigationAction parameter.

WebKit/qt:

* Api/qwebpage.cpp:
(openNewWindow):
* WebCoreSupport/ChromeClientQt.cpp:
(WebCore::ChromeClientQt::createWindow):
* WebCoreSupport/ChromeClientQt.h:
* WebCoreSupport/FrameLoaderClientQt.cpp:
(WebCore::FrameLoaderClientQt::dispatchCreatePage):
* WebCoreSupport/FrameLoaderClientQt.h:
Add NavigationAction parameter.

WebKit/win:

* WebCoreSupport/WebChromeClient.cpp:
(WebChromeClient::createWindow):
* WebCoreSupport/WebFrameLoaderClient.cpp:
(WebFrameLoaderClient::dispatchCreatePage):
* WebCoreSupport/WebFrameLoaderClient.h:
Add NavigationAction parameter.

WebKit/wince:

* WebCoreSupport/ChromeClientWinCE.cpp:
(WebKit::ChromeClientWinCE::createWindow):
* WebCoreSupport/ChromeClientWinCE.h:
* WebCoreSupport/FrameLoaderClientWinCE.cpp:
(WebKit::FrameLoaderClientWinCE::dispatchCreatePage):
* WebCoreSupport/FrameLoaderClientWinCE.h:
Add NavigationAction parameter.

WebKit/wx:

* WebKitSupport/ChromeClientWx.cpp:
(WebCore::ChromeClientWx::createWindow):
* WebKitSupport/ChromeClientWx.h:
* WebKitSupport/FrameLoaderClientWx.cpp:
(WebCore::FrameLoaderClientWx::dispatchCreatePage):
* WebKitSupport/FrameLoaderClientWx.h:
Add NavigationAction parameter.

WebKit2:

In addition to passing modifier flags from the now passed NavigationAction, also pass
the WindowFeatures to the UIProcess.

* Platform/CoreIPC/HandleMessage.h:
(CoreIPC::callMemberFunction):
* Shared/WebCoreArgumentCoders.h:
* Shared/WebEvent.h:
(WebKit::WebEvent::modifiers):
* UIProcess/API/C/WKPage.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::createNewPage):
* UIProcess/WebPageProxy.h:
* UIProcess/WebPageProxy.messages.in:
* UIProcess/WebUIClient.cpp:
(WebKit::WebUIClient::createNewPage):
* UIProcess/WebUIClient.h:
* WebProcess/WebCoreSupport/WebChromeClient.cpp:
(WebKit::WebChromeClient::createWindow):
* WebProcess/WebCoreSupport/WebChromeClient.h:
* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::dispatchCreatePage):
(WebKit::modifiersForNavigationAction):
(WebKit::mouseButtonForNavigationAction):
* WebProcess/WebCoreSupport/WebFrameLoaderClient.h:

WebKitTools:

* MiniBrowser/mac/BrowserWindowController.m:
(createNewPage):
* WebKitTestRunner/TestController.cpp:
(WTR::createOtherPage):
Update for new signature for the WKPageCreateNewPageCallback.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70333 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoWebKit shouldn't load a plug-in based on file extension if a MIME type
aestes@apple.com [Fri, 22 Oct 2010 20:55:51 +0000 (20:55 +0000)]
WebKit shouldn't load a plug-in based on file extension if a MIME type
is specified.
https://bugs.webkit.org/show_bug.cgi?id=48046

Reviewed by Eric Carlson.

WebKit/mac:

If a MIME type is specified in an object or embed element, and that MIME
type isn't supported by an installed plug-in, WebKit shouldn't attempt
to find a plug-in based on the file extension of the url attribute.
Doing so can lead to cases where a plug-in is loaded that can't handle
resources of the MIME type specified by the author.

* WebCoreSupport/WebFrameLoaderClient.mm:
(WebFrameLoaderClient::createPlugin): Only check for a pluginPackage by
extension if MIME type is the empty string.

LayoutTests:

* plugins/invalid-mime-with-valid-extension-shows-missing-plugin-expected.txt: Added.
* plugins/invalid-mime-with-valid-extension-shows-missing-plugin.html: Added.
* plugins/resources/test.testnetscape: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70332 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 22 Oct 2010 20:52:58 +0000 (20:52 +0000)]
2010-10-22  Eric Seidel  <eric@webkit.org>

        Unreviewed.  Just adding a test case.

        The style-queue was not recognizing new patches.  It turns
        out I had fixed this in an earlier change, but just not
        deployed to queues.webkit.org.  As part of investigating why it
        was broken, I wrote a test for my previous change which I'm now landing.

        * QueueStatusServer/model/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70331 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=48149
hyatt@apple.com [Fri, 22 Oct 2010 20:29:21 +0000 (20:29 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=48149

Reviewed by Sam Weinig.

Update block direction line overflow computation to be writing-mode-aware.

* rendering/InlineBox.h:
(WebCore::InlineBox::logicalBottom):
* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::computeBlockDirectionOverflow):
* rendering/InlineFlowBox.h:
(WebCore::InlineFlowBox::setInlineDirectionOverflowPositions):
(WebCore::InlineFlowBox::setBlockDirectionOverflowPositions):
* rendering/RenderBlockLineLayout.cpp:
(WebCore::RenderBlock::layoutInlineChildren):
* rendering/RenderBox.cpp:
(WebCore::RenderBox::blockDirectionOverflow):
* rendering/RenderBox.h:
* rendering/RootInlineBox.cpp:
(WebCore::RootInlineBox::addHighlightOverflow):
* rendering/style/RenderStyle.h:
(WebCore::InheritedFlags::getTextShadowBlockDirectionExtent):
(WebCore::InheritedFlags::getBoxShadowBlockDirectionExtent):
(WebCore::InheritedFlags::getShadowBlockDirectionExtent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70330 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRename processDidExit to processDidCrash
andersca@apple.com [Fri, 22 Oct 2010 20:21:14 +0000 (20:21 +0000)]
Rename processDidExit to processDidCrash
https://bugs.webkit.org/show_bug.cgi?id=48146

Reviewed by Sam Weinig.

* UIProcess/API/C/WKPage.h:
* UIProcess/API/mac/PageClientImpl.h:
* UIProcess/API/mac/PageClientImpl.mm:
(WebKit::PageClientImpl::processDidCrash):
* UIProcess/API/mac/WKView.mm:
(-[WKView _processDidCrash]):
* UIProcess/API/mac/WKViewInternal.h:
* UIProcess/API/qt/qwkpage.cpp:
(QWKPage::QWKPage):
* UIProcess/API/qt/qwkpage_p.h:
(QWKPagePrivate::processDidCrash):
* UIProcess/PageClient.h:
* UIProcess/WebLoaderClient.cpp:
(WebKit::WebLoaderClient::processDidBecomeUnresponsive):
(WebKit::WebLoaderClient::processDidBecomeResponsive):
(WebKit::WebLoaderClient::processDidCrash):
* UIProcess/WebLoaderClient.h:
* UIProcess/WebPageProxy.cpp:
(WebKit::WebPageProxy::processDidBecomeUnresponsive):
(WebKit::WebPageProxy::processDidBecomeResponsive):
(WebKit::WebPageProxy::processDidCrash):
* UIProcess/WebPageProxy.h:
* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::didClose):
* UIProcess/win/WebView.cpp:
(WebKit::WebView::processDidCrash):
* UIProcess/win/WebView.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70329 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 22 Oct 2010 20:19:20 +0000 (20:19 +0000)]
2010-10-22  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        EWS does not need to process obsolete patches
        https://bugs.webkit.org/show_bug.cgi?id=48093

        This was an easy change, but to test it I had to pipe
        real Attachment objects into the queue testing system.
        Doing so revealed a whole bunch of bugs in our unit tests,
        which I fixed as part of this patch.

        * Scripts/webkitpy/tool/commands/earlywarningsystem.py:
         - This is the actual code change.  This will not reduce the
           backlog in the EWS queues much, but it will make rejections
           much quicker for obsolete patches or closed bugs.
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
         - Test my new code.
         - Used a real attachment object and got rid of MockPatch
         - Shared code between the mac-ews and cr-mac-ews tests.
        * Scripts/webkitpy/tool/commands/queues_unittest.py:
         - Can't use MockPatch anymore.
         - Removing MockPatch found more bugs here!
        * Scripts/webkitpy/tool/commands/queuestest.py:
        * Scripts/webkitpy/tool/commands/sheriffbot_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
         - MockBugzilla should not be a "Mock" object.  Right now tool.bugs()
           is allowed, but wrong.  Making it not a Mock will make tool.bugs() correctly fail.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70328 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Oct 2010 20:06:20 +0000 (20:06 +0000)]
2010-10-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        ASSERT while viewing Google C++ style guide
        https://bugs.webkit.org/show_bug.cgi?id=48148

        Make sure we don't hit an ASSERT when an XSLT outputs HTML.

        * fast/xsl/resources/to-html.xsl: Added.
        * fast/xsl/transform-to-html-expected.txt: Added.
        * fast/xsl/transform-to-html.xml: Added.
2010-10-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Eric Seidel.

        ASSERT while viewing Google C++ style guide
        https://bugs.webkit.org/show_bug.cgi?id=48148

        This code used to stop the parser twice.  Instead of reaching in an
        trying to stop the parser manually, we now just let close() do the work
        for us.

        Test: fast/xsl/transform-to-html.xml

        * xml/XSLTProcessor.cpp:
        (WebCore::XSLTProcessor::createDocumentFromSource):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70327 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCorrected target dependencies.
mitz@apple.com [Fri, 22 Oct 2010 20:01:23 +0000 (20:01 +0000)]
Corrected target dependencies.

Reviewed by Sam Weinig.

* WebKit2.xcodeproj/project.pbxproj: Made WebKit2 depend on DerivedSources and removed
the explicit dependency of All on DerivedSources and WebKit2, since WebProcess depends on
them.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70326 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 22 Oct 2010 19:31:17 +0000 (19:31 +0000)]
2010-10-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Implement GraphicsContext::(get|release)WindowsContext
        https://bugs.webkit.org/show_bug.cgi?id=48136

        * platform/graphics/wince/GraphicsContextWinCE.cpp:
        (WebCore::GraphicsContext::getWindowsContext):
        (WebCore::GraphicsContext::releaseWindowsContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70325 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAttempt to fix the Windows build
aroben@apple.com [Fri, 22 Oct 2010 19:27:20 +0000 (19:27 +0000)]
Attempt to fix the Windows build

* platform/network/win/CookieJarCFNetWin.cpp: Add a missing #include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70324 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Cosmin Truta <ctruta@chromium.org>
krit@webkit.org [Fri, 22 Oct 2010 19:00:36 +0000 (19:00 +0000)]
2010-10-22  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Dirk Schulze.

        getBoundingClientRect does not work with SVG <text>
        https://bugs.webkit.org/show_bug.cgi?id=46775

        Added back to SVGStyledTransformableElement overloads of the following
        methods: nearestViewportElement, farthestViewportElement, getBBox.
        This was necessary to appease the Visual C++ compiler, which warned on
        inheritance via dominance.

        * svg/SVGStyledTransformableElement.cpp:
        * svg/SVGStyledTransformableElement.h:
        (SVGStyledTransformableElement::nearestViewportElement):
        (SVGStyledTransformableElement::farthestViewportElement):
        (SVGStyledTransformableElement::getBBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70323 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Fri, 22 Oct 2010 18:45:37 +0000 (18:45 +0000)]
2010-10-22  Dimitri Glazkov  <dglazkov@chromium.org>

        Updated expectations for flaky/passing tests.

        * platform/chromium/test_expectations.txt: Tweaked.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70322 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Chris Marrin <cmarrin@apple.com>
cmarrin@apple.com [Fri, 22 Oct 2010 18:44:59 +0000 (18:44 +0000)]
2010-10-21  Chris Marrin  <cmarrin@apple.com>

        Reviewed by Adam Roben.

        Content in <iframe> doesn't appear when going back to http://webkit.org/blog/386/3d-transforms/
        https://bugs.webkit.org/show_bug.cgi?id=32447

        Added documentDidBecomeActive() when document comes back from cache to cause compositing
        layers in iframes to be reattached.

        There is no layout test, but I added a manual test. This test is ready to be a layout test
        but currently DRT disables the WebCore page cache, so the back/forward essentially do a
        page load which does not exhibit the bug.

        * history/CachedFrame.cpp:
        (WebCore::CachedFrameBase::restore):
        * manual-tests/compositing/show-composited-iframe-on-back-button.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70321 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoTurn on ENABLE_3D_RENDERING on all Windows builds
aroben@apple.com [Fri, 22 Oct 2010 18:40:30 +0000 (18:40 +0000)]
Turn on ENABLE_3D_RENDERING on all Windows builds

Reviewed by Sam Weinig.

JavaScriptCore:

Remove the QuartzCorePresent.h mechanism

This header was used to detect whether QuartzCore headers were present
on the system. Everyone should have these headers now so we no longer
need to detect.

* JavaScriptCore.vcproj/JavaScriptCore/build-generated-files.sh: Remove
code to generate QuartzCorePresent.h.

* wtf/Platform.h: Stop including QuartzCorePresent.h on Windows and
collapse all USE_ACCELERATED_COMPOSITING settings into one #ifdef.

WebKitLibraries:

* win/tools/vsprops/FeatureDefines.vsprops:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70320 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 22 Oct 2010 18:22:30 +0000 (18:22 +0000)]
2010-10-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Add Windows specific files for platform/network/win
        https://bugs.webkit.org/show_bug.cgi?id=27376

        * platform/network/win/AuthenticationChallenge.h: Added.
        (WebCore::AuthenticationChallenge::AuthenticationChallenge):
        * platform/network/win/ResourceError.h: Added.
        (WebCore::ResourceError::ResourceError):
        * platform/network/win/ResourceRequest.h: Added.
        (WebCore::ResourceRequest::ResourceRequest):
        (WebCore::ResourceRequest::doUpdatePlatformRequest):
        (WebCore::ResourceRequest::doUpdateResourceRequest):
        (WebCore::ResourceRequest::doPlatformCopyData):
        (WebCore::ResourceRequest::doPlatformAdopt):
        * platform/network/win/ResourceResponse.h: Added.
        (WebCore::ResourceResponse::ResourceResponse):
        (WebCore::ResourceResponse::doPlatformCopyData):
        (WebCore::ResourceResponse::doPlatformAdopt):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70319 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Oct 2010 17:54:21 +0000 (17:54 +0000)]
2010-10-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r70290.
        http://trac.webkit.org/changeset/70290
        https://bugs.webkit.org/show_bug.cgi?id=48111

        Undelete Android build files.

        * Android.mk: Added.
2010-10-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r70290.
        http://trac.webkit.org/changeset/70290
        https://bugs.webkit.org/show_bug.cgi?id=48111

        Undelete Android build files.

        * Android.mk: Added.
2010-10-22  Adam Barth  <abarth@webkit.org>

        Unreviewed, rolling out r70290.
        http://trac.webkit.org/changeset/70290
        https://bugs.webkit.org/show_bug.cgi?id=48111

        Undelete Android build files.

        * Android.mk: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70318 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Cosmin Truta <ctruta@chromium.org>
krit@webkit.org [Fri, 22 Oct 2010 17:43:31 +0000 (17:43 +0000)]
2010-10-22  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Nikolas Zimmermann.

        getBoundingClientRect does not work with SVG <text>
        https://bugs.webkit.org/show_bug.cgi?id=46775

        Dispatched the calls from Element::getBoundingClientRect to getBBox
        through SVGElement::boundingBox.
        Recognized SVGTextElement in addition to SVGStyledLocatableElement
        as a class that provides getBBox.
        Fixed the result of zooming: adjusted the getBoundingClientRect rectangle
        for absolute zoom, even for SVG elements.

        Additional cleanup task:
        Removed redundant overloads of SVGStyledTransformableElement
        methods: nearestViewportElement, farthestViewportElement, getBBox.
        These methods are already inherited from SVGStyledLocatableElement.

        Test: css3/zoom-coords.xhtml

        * WebCore.xcodeproj/project.pbxproj: Set role of SVGLocatable.h to private.
        * dom/Element.cpp:
        (Element::getBoundingClientRect): Used SVGElement::boundingBox.
        Adjusted coordinates for absolute zoom, for all kinds of elements.
        * svg/SVGElement.cpp:
        * svg/SVGElement.h:
        (SVGElement::boundingBox): Added.
        * svg/SVGStyledTransformableElement.cpp:
        * svg/SVGStyledTransformableElement.h:
        (SVGStyledTransformableElement::nearestViewportElement): Removed.
        (SVGStyledTransformableElement::farthestViewportElement): Removed.
        (SVGStyledTransformableElement::getBBox): Removed.
2010-10-22  Cosmin Truta  <ctruta@chromium.org>

        Reviewed by Nikolas Zimmermann.

        getBoundingClientRect does not work with SVG <text>
        https://bugs.webkit.org/show_bug.cgi?id=46775

        Added coordinate checks on various zoomed-in and zoomed-out
        XHTML and SVG elements, using getBoundingClientRect.

        * css3/zoom-coords.xhtml: Added.
        * css3/zoom-coords-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70317 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUpdate Windows html5lib results after r70293
aroben@apple.com [Fri, 22 Oct 2010 17:31:21 +0000 (17:31 +0000)]
Update Windows html5lib results after r70293

* platform/win/html5lib/runner-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70316 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Jedrzej Nowacki <jedrzej.nowacki@nokia.com>
commit-queue@webkit.org [Fri, 22 Oct 2010 17:15:30 +0000 (17:15 +0000)]
2010-10-22  Jedrzej Nowacki  <jedrzej.nowacki@nokia.com>

        Reviewed by Antonio Gomes.

        Add new LayoutTest checking web history on document.location change.

        The new test enforce the current behavior; If redirection is caused by
        document.location change, immediately after a page load and without using
        setTimeout, a web history item shouldn't be created.

        History item and document.location change.
        https://bugs.webkit.org/show_bug.cgi?id=48117

        * http/tests/navigation/document-location-script-expected.txt: Added.
        * http/tests/navigation/document-location-script.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70315 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 22 Oct 2010 17:12:56 +0000 (17:12 +0000)]
2010-10-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WIN] Add stubs for SocketStream classes
        https://bugs.webkit.org/show_bug.cgi?id=47983

        * platform/network/win/SocketStreamError.h: Copied from WebCore/platform/network/curl/SocketStreamError.h.
        (WebCore::SocketStreamError::SocketStreamError):
        * platform/network/win/SocketStreamHandle.h: Copied from WebCore/platform/network/curl/SocketStreamHandle.h.
        (WebCore::SocketStreamHandle::create):
        * platform/network/win/SocketStreamHandleWin.cpp: Copied from WebCore/platform/network/curl/SocketStreamHandleCurl.cpp.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 22 Oct 2010 16:57:55 +0000 (16:57 +0000)]
2010-10-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        [WINCE] Implement EditorClient::handleKeyboardEvent
        https://bugs.webkit.org/show_bug.cgi?id=48118

        Copy the implementation from the EFL port.

        * WebCoreSupport/EditorClientWinCE.cpp:
        (WebKit::EditorClientWinCE::interpretKeyEvent):
        (WebKit::EditorClientWinCE::handleEditingKeyboardEvent):
        (WebKit::EditorClientWinCE::handleKeyboardEvent):
        * WebCoreSupport/EditorClientWinCE.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70313 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Patrick Gansterer <paroga@webkit.org>
paroga@webkit.org [Fri, 22 Oct 2010 16:55:58 +0000 (16:55 +0000)]
2010-10-22  Patrick Gansterer  <paroga@webkit.org>

        Reviewed by Adam Roben.

        Disable cache in ResourceHandleWin
        https://bugs.webkit.org/show_bug.cgi?id=48128

        The caching of windows does not work correctly, so disable it for now.

        * platform/network/win/ResourceHandleWin.cpp:
        (WebCore::ResourceHandle::start):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70312 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Jia Pu <jpu@apple.com>
commit-queue@webkit.org [Fri, 22 Oct 2010 16:11:40 +0000 (16:11 +0000)]
2010-10-22  Jia Pu  <jpu@apple.com>

        Reviewed by Dan Bernstein.

        Regression (r69548): cancelled autocorrection suggestion is still applied.
        https://bugs.webkit.org/show_bug.cgi?id=48081
        <rdar://problem/8579765>

        The test requires a 0.3 second delay using setTimeout(). So we put it in manual-tests.

        * editing/Editor.cpp:
        (WebCore::Editor::handleRejectedCorrection): Clear autocorrection info when user dismissed the panel.
        * manual-tests/autocorrection/autocorrection-cancelled-by-ESC.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70310 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Yi Shen <yi.4.shen@nokia.com>
commit-queue@webkit.org [Fri, 22 Oct 2010 15:35:38 +0000 (15:35 +0000)]
2010-10-22  Yi Shen  <yi.4.shen@nokia.com>

        Reviewed by Andreas Kling.

        [Qt] InspectorClientQt crashes when deleting a qwebpage which has an inspector
        https://bugs.webkit.org/show_bug.cgi?id=48079

        * Api/qwebpage.cpp:
        (QWebPagePrivate::~QWebPagePrivate):
        (QWebPage::~QWebPage):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70308 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Andreas Kling <kling@webkit.org>
commit-queue@webkit.org [Fri, 22 Oct 2010 15:35:01 +0000 (15:35 +0000)]
2010-10-22  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Gtk] Fix canvas/philip/tests/2d.path.isPointInPath.nonfinite.html
        https://bugs.webkit.org/show_bug.cgi?id=48133

        * platform/gtk/Skipped: Unskip the now passing test.
2010-10-22  Andreas Kling  <kling@webkit.org>

        Reviewed by Kenneth Rohde Christiansen.

        [Gtk] Fix canvas/philip/tests/2d.path.isPointInPath.nonfinite.html
        https://bugs.webkit.org/show_bug.cgi?id=48133

        * platform/graphics/cairo/PathCairo.cpp:
        (WebCore::Path::contains): Return false if any x or y are nonfinite.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70307 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Alexander Pavlov <apavlov@chromium.org>
apavlov@chromium.org [Fri, 22 Oct 2010 15:04:52 +0000 (15:04 +0000)]
2010-10-22  Alexander Pavlov  <apavlov@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: Implement property toggling in InspectorCSSAgent

        This change implements enablement/disablement and setting of style properties.
        Disabled properties are persisted in the (top-level) scope of InspectorStyleSheet.
        https://bugs.webkit.org/show_bug.cgi?id=47339

Drive-by: fixes for the Web Inspector Protocol format.
        * inspector/InspectorCSSAgent.cpp:
        (WebCore::InspectorCSSAgent::getComputedStyleForNode2):
        (WebCore::InspectorCSSAgent::getInheritedStylesForNode2):
        (WebCore::InspectorCSSAgent::setPropertyText2):
        (WebCore::InspectorCSSAgent::toggleProperty2):
        (WebCore::InspectorCSSAgent::setRuleSelector2):
        (WebCore::InspectorCSSAgent::buildObjectForAttributeStyles):
        * inspector/InspectorCSSAgent.h:
        * inspector/InspectorStyleSheet.cpp:
        (WebCore::InspectorStyle::buildObjectForStyle):
        (WebCore::InspectorStyle::setPropertyText):
        (WebCore::InspectorStyle::toggleProperty):
        (WebCore::InspectorStyle::disabledIndexByOrdinal):
        (WebCore::InspectorStyle::styleText):
        (WebCore::InspectorStyle::disableProperty):
        (WebCore::InspectorStyle::enableProperty):
        (WebCore::InspectorStyle::populateAllProperties):
        (WebCore::InspectorStyle::populateObjectWithStyleProperties):
        (WebCore::InspectorStyle::shiftDisabledProperties):
        (WebCore::InspectorStyle::replacePropertyInStyleText):
        (WebCore::InspectorStyle::shorthandValue):
        (WebCore::InspectorStyle::shorthandPriority):
        (WebCore::InspectorStyle::longhandProperties):
        (WebCore::InspectorStyleSheet::setText):
        (WebCore::InspectorStyleSheet::setRuleSelector):
        (WebCore::InspectorStyleSheet::addRule):
        (WebCore::InspectorStyleSheet::ruleForId):
        (WebCore::InspectorStyleSheet::buildObjectForStyleSheet):
        (WebCore::InspectorStyleSheet::buildObjectForRule):
        (WebCore::InspectorStyleSheet::buildObjectForStyle):
        (WebCore::InspectorStyleSheet::setPropertyText):
        (WebCore::InspectorStyleSheet::toggleProperty):
        (WebCore::InspectorStyleSheet::styleForId):
        (WebCore::InspectorStyleSheet::inspectorStyleForId):
        (WebCore::InspectorStyleSheet::rememberInspectorStyle):
        (WebCore::InspectorStyleSheet::forgetInspectorStyle):
        (WebCore::InspectorStyleSheet::ruleOrStyleId):
        (WebCore::InspectorStyleSheet::ensureText):
        (WebCore::InspectorStyleSheet::setStyleText):
        (WebCore::InspectorStyleSheet::styleSheetTextWithChangedStyle):
        (WebCore::InspectorStyleSheet::ruleId):
        (WebCore::InspectorStyleSheet::revalidateStyle):
        (WebCore::InspectorStyleSheet::originalStyleSheetText):
        (WebCore::InspectorStyleSheet::resourceStyleSheetText):
        (WebCore::InspectorStyleSheetForInlineStyle::InspectorStyleSheetForInlineStyle):
        (WebCore::InspectorStyleSheetForInlineStyle::setStyleText):
        (WebCore::InspectorStyleSheetForInlineStyle::inspectorStyleForId):
        * inspector/InspectorStyleSheet.h:
        (WebCore::InspectorCSSId::createFromParts):
        (WebCore::InspectorCSSId::InspectorCSSId):
        (WebCore::InspectorCSSId::styleSheetId):
        (WebCore::InspectorCSSId::ordinal):
        (WebCore::InspectorCSSId::isEmpty):
        (WebCore::InspectorCSSId::asString):
        (WebCore::InspectorStyleProperty::InspectorStyleProperty):
        (WebCore::InspectorStyle::create):
        (WebCore::InspectorStyle::InspectorStyle):
        (WebCore::InspectorStyle::cssStyle):
        (WebCore::InspectorStyle::hasDisabledProperties):
        (WebCore::InspectorStyleSheet::styleId):
        (WebCore::InspectorStyleSheetForInlineStyle::styleForId):
        (WebCore::InspectorStyleSheetForInlineStyle::ruleSourceDataFor):
        (WebCore::InspectorStyleSheetForInlineStyle::rememberInspectorStyle):
        (WebCore::InspectorStyleSheetForInlineStyle::forgetInspectorStyle):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70306 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Fri, 22 Oct 2010 13:33:14 +0000 (13:33 +0000)]
2010-10-22  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: update resources tree in storage panel upon network events.
        https://bugs.webkit.org/show_bug.cgi?id=48121

        * inspector/Inspector.idl:
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForDocumentLoader):
        (WebCore::buildObjectForFrameTree):
        (WebCore::InspectorResourceAgent::didCommitLoad):
        (WebCore::InspectorResourceAgent::frameDetachedFromParent):
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager):
        (WebInspector.ResourceManager.prototype._createResource):
        (WebInspector.ResourceManager.prototype.didReceiveResponse):
        (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache):
        (WebInspector.ResourceManager.prototype.didCommitLoadForFrame):
        (WebInspector.ResourceManager.prototype._addResourceToStorageFrame):
        (WebInspector.ResourceManager.prototype.frameDetachedFromParent):
        (WebInspector.ResourceManager.prototype._clearResources):
        (WebInspector.ResourceManager.prototype._processCachedResources):
        (WebInspector.ResourceManager.prototype._addFramesRecursively):
        (WebInspector.ResourceManager.getContents):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel.prototype.addOrUpdateFrame):
        (WebInspector.StoragePanel.prototype.removeFrame):
        (WebInspector.StoragePanel.prototype.addResourceToFrame):
        (WebInspector.StoragePanel.prototype.removeResourcesFromFrame):
        (WebInspector.BaseStorageTreeElement.prototype.onattach):
        (WebInspector.BaseStorageTreeElement.prototype.onreveal):
        (WebInspector.BaseStorageTreeElement.prototype.set titleText):
        (WebInspector.FrameTreeElement):
        (WebInspector.FrameTreeElement.prototype.onselect):
        (WebInspector.FrameTreeElement.prototype.get displayName):
        (WebInspector.FrameTreeElement.prototype.set displayName):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70305 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 François Sausset <sausset@gmail.com>
commit-queue@webkit.org [Fri, 22 Oct 2010 13:31:40 +0000 (13:31 +0000)]
2010-10-22  François Sausset  <sausset@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Fix wrong xHeight() value for Apple Symbols font.
        https://bugs.webkit.org/show_bug.cgi?id=41535

        * mathml/xHeight.xhtml: Added.
        * platform/mac/mathml/presentation/fenced-expected.checksum:
        * platform/mac/mathml/presentation/fenced-expected.png:
        * platform/mac/mathml/presentation/fenced-expected.txt:
        * platform/mac/mathml/presentation/row-alignment-expected.checksum:
        * platform/mac/mathml/presentation/row-alignment-expected.png:
        * platform/mac/mathml/presentation/row-alignment-expected.txt:
        * platform/mac/mathml/presentation/tables-expected.checksum:
        * platform/mac/mathml/presentation/tables-expected.png:
        * platform/mac/mathml/presentation/tables-expected.txt:
        * platform/mac/mathml/xHeight-expected.checksum: Added.
        * platform/mac/mathml/xHeight-expected.png: Added.
        * platform/mac/mathml/xHeight-expected.txt: Added.
2010-10-22  François Sausset  <sausset@gmail.com>

        Reviewed by Kenneth Rohde Christiansen.

        Fix wrong xHeight() value for Apple Symbols font.
        https://bugs.webkit.org/show_bug.cgi?id=41535

        Test: mathml/xHeight.xhtml

        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformInit):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70304 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Nikolas Zimmermann <nzimmermann@rim.com>
zimmermann@webkit.org [Fri, 22 Oct 2010 13:26:25 +0000 (13:26 +0000)]
2010-10-22  Nikolas Zimmermann  <nzimmermann@rim.com>

        Reviewed by Dirk Schulze.

        Further preparations to deploy the new SVGAnimatedProperty concept for the rest of the SVG datatypes
        https://bugs.webkit.org/show_bug.cgi?id=48125

        Model SVGListPropertyTearOff similar to SVGPropertyTearOff, allow it to be used for SVGXXXList datatypes, that are not animated. (SVGStringList)
        Recognize all SVG primitive datatypes in SVGPropertyTraits.
        Add a new - temporary - macro to support multiple animated properties that map to a single DOM attribute (kernelUnitLength attribute vs. kernelUnitLengthX/Y properties).
        These macros will all be removed and expanded by their content, as soon as the transition to the new SVGAnimatedProperty concept is done.

        Doesn't affect any tests yet, as the code is still unused.

        * svg/properties/SVGAnimatedProperty.h:
        (WebCore::SVGAnimatedProperty::lookupOrCreateWrapper):
        (WebCore::SVGAnimatedProperty::lookupWrapper):
        * svg/properties/SVGAnimatedPropertyMacros.h:
        * svg/properties/SVGAnimatedPropertySynchronizer.h:
        * svg/properties/SVGListPropertyTearOff.h:
        (WebCore::SVGListPropertyTearOff::create):
        (WebCore::SVGListPropertyTearOff::removeItemFromList):
        (WebCore::SVGListPropertyTearOff::detachListWrappers):
        (WebCore::SVGListPropertyTearOff::clear):
        (WebCore::SVGListPropertyTearOff::numberOfItems):
        (WebCore::SVGListPropertyTearOff::initialize):
        (WebCore::SVGListPropertyTearOff::getItem):
        (WebCore::SVGListPropertyTearOff::insertItemBefore):
        (WebCore::SVGListPropertyTearOff::replaceItem):
        (WebCore::SVGListPropertyTearOff::removeItem):
        (WebCore::SVGListPropertyTearOff::appendItem):
        (WebCore::SVGListPropertyTearOff::SVGListPropertyTearOff):
        (WebCore::SVGListPropertyTearOff::~SVGListPropertyTearOff):
        (WebCore::SVGListPropertyTearOff::commitChange):
        * svg/properties/SVGPropertyTearOff.h:
        * svg/properties/SVGPropertyTraits.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70303 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Sheriff Bot <webkit.review.bot@gmail.com>
commit-queue@webkit.org [Fri, 22 Oct 2010 13:13:24 +0000 (13:13 +0000)]
2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r70301.
        http://trac.webkit.org/changeset/70301
        https://bugs.webkit.org/show_bug.cgi?id=48126

        "Lang attribute layout tests failing" (Requested by satish on
        #webkit).

        * fast/speech/input-text-language-tag-expected.txt: Removed.
        * fast/speech/input-text-language-tag.html: Removed.
        * fast/speech/input-text-speechbutton.html:
        * fast/speech/speech-button-ignore-generated-events.html:
        * platform/chromium/test_expectations.txt:
2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r70301.
        http://trac.webkit.org/changeset/70301
        https://bugs.webkit.org/show_bug.cgi?id=48126

        "Lang attribute layout tests failing" (Requested by satish on
        #webkit).

        * dom/Element.cpp:
        (WebCore::Element::computeInheritedLanguage):
        * page/SpeechInput.cpp:
        (WebCore::SpeechInput::startRecognition):
        * page/SpeechInput.h:
        * page/SpeechInputClient.h:
        * platform/mock/SpeechInputClientMock.cpp:
        (WebCore::SpeechInputClientMock::startRecognition):
        (WebCore::SpeechInputClientMock::setRecognitionResult):
        (WebCore::SpeechInputClientMock::timerFired):
        * platform/mock/SpeechInputClientMock.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::attachInnerElement):
        (WebCore::SearchFieldCancelButtonElement::detach):
        (WebCore::SpinButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::detach):
2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r70301.
        http://trac.webkit.org/changeset/70301
        https://bugs.webkit.org/show_bug.cgi?id=48126

        "Lang attribute layout tests failing" (Requested by satish on
        #webkit).

        * public/WebSpeechInputController.h:
        (WebKit::WebSpeechInputController::startRecognition):
        * public/WebSpeechInputControllerMock.h:
        * src/SpeechInputClientImpl.cpp:
        (WebKit::SpeechInputClientImpl::startRecognition):
        * src/SpeechInputClientImpl.h:
        * src/WebSpeechInputControllerMockImpl.cpp:
        (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult):
        (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
        * src/WebSpeechInputControllerMockImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        * src/WebViewImpl.h:
2010-10-22  Sheriff Bot  <webkit.review.bot@gmail.com>

        Unreviewed, rolling out r70301.
        http://trac.webkit.org/changeset/70301
        https://bugs.webkit.org/show_bug.cgi?id=48126

        "Lang attribute layout tests failing" (Requested by satish on
        #webkit).

        * DumpRenderTree/LayoutTestController.cpp:
        (setMockSpeechInputResultCallback):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setMockSpeechInputResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70302 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Leandro Gracia Gil <leandrogracia@google.com>
jorlow@chromium.org [Fri, 22 Oct 2010 12:09:08 +0000 (12:09 +0000)]
2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>

        Reviewed by Jeremy Orlow.

        Added a layout test for the language tag in speech input. Updated
        the speech button tests to include the new language parameter in the
        mock result.
        https://bugs.webkit.org/show_bug.cgi?id=47089

        * fast/speech/input-text-language-tag-expected.txt: Added.
        * fast/speech/input-text-language-tag.html: Added.
        * fast/speech/input-text-speechbutton.html: Added an empty language
          parameter.
        * fast/speech/speech-button-ignore-generated-events.html: Added an
          empty language parameter.
        * platform/chromium/test_expectations.txt: language tag test is expected
          to fail until the chromium-side patch has been applied.
2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>

        Reviewed by Jeremy Orlow.

        Patch the current speech input implementation to use and validate the
        nearest language tag. The language is now passed to the startRecognition
        methods so that language-specific recognition could be used. Also added
        a second parameter to setMockSpeechInputResult for the language used in
        speech recognition.
        https://bugs.webkit.org/show_bug.cgi?id=47089

        This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
        details see http://codereview.chromium.org/3615005/show and
        http://codereview.chromium.org/3595018/show.

        Test: fast/speech/input-text-language-tag.html

        * dom/Element.cpp:
        (WebCore::Element::computeInheritedLanguage): includes a brief character
          validation for the BCP 47 language tag.
        * page/SpeechInput.cpp:
        (WebCore::SpeechInput::startRecognition):
        * page/SpeechInput.h:
        * page/SpeechInputClient.h:
        * platform/mock/SpeechInputClientMock.cpp:
        (WebCore::SpeechInputClientMock::startRecognition):
        (WebCore::SpeechInputClientMock::setRecognitionResult): results are now
          stored by language using a hash map.
        (WebCore::SpeechInputClientMock::timerFired):
        * platform/mock/SpeechInputClientMock.h:
        * rendering/TextControlInnerElements.cpp:
        (WebCore::TextControlInnerElement::attachInnerElement):
        (WebCore::SearchFieldCancelButtonElement::detach):
        (WebCore::SpinButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::defaultEventHandler):
        (WebCore::InputFieldSpeechButtonElement::detach):
2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>

        Reviewed by Jeremy Orlow.

        Patch the current speech input implementation to use and validate the
        nearest language tag. The language is now passed to the startRecognition
        methods so that language-specific recognition could be used. Also added
        a second parameter to setMockSpeechInputResult for the language used in
        speech recognition.
        https://bugs.webkit.org/show_bug.cgi?id=47089

        This is the 2nd of a 4-sided patch in Chromium and WebKit. For more
        details see http://codereview.chromium.org/3615005/show and
        http://codereview.chromium.org/3595018/show.

        * public/WebSpeechInputController.h:
        (WebKit::WebSpeechInputController::startRecognition):
        * public/WebSpeechInputControllerMock.h:
        * src/SpeechInputClientImpl.cpp:
        (WebKit::SpeechInputClientImpl::create):
        (WebKit::SpeechInputClientImpl::startRecognition):
        * src/SpeechInputClientImpl.h:
        * src/WebSpeechInputControllerMockImpl.cpp:
        (WebKit::WebSpeechInputControllerMockImpl::setMockRecognitionResult):
        (WebKit::WebSpeechInputControllerMockImpl::startRecognition):
        * src/WebSpeechInputControllerMockImpl.h:
        * src/WebViewImpl.cpp:
        (WebKit::WebViewImpl::WebViewImpl):
        * src/WebViewImpl.h:
2010-10-22  Leandro Gracia Gil  <leandrogracia@google.com>

        Reviewed by Jeremy Orlow.

        Added a second parameter to setMockSpeechInputResult for
        the language used in speech input.
        https://bugs.webkit.org/show_bug.cgi?id=47089

        * DumpRenderTree/LayoutTestController.cpp:
        (setMockSpeechInputResultCallback):
        * DumpRenderTree/LayoutTestController.h:
        * DumpRenderTree/chromium/LayoutTestController.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/gtk/LayoutTestControllerGtk.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/mac/LayoutTestControllerMac.mm:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/qt/LayoutTestControllerQt.h:
        * DumpRenderTree/qt/LayoutTestControllerQt.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::setMockSpeechInputResult):
        * DumpRenderTree/wx/LayoutTestControllerWx.cpp:
        (LayoutTestController::setMockSpeechInputResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70301 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 22 Oct 2010 11:40:11 +0000 (11:40 +0000)]
2010-10-21  Yury Semikhatsky  <yurys@chromium.org>

        Unreviewed, rolling out r70298.WebKit win compilation failure.
        http://trac.webkit.org/changeset/70298
        https://bugs.webkit.org/show_bug.cgi?id=48122

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70300 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 Zoltan Herczeg <zherczeg@webkit.org>
zherczeg@webkit.org [Fri, 22 Oct 2010 10:54:23 +0000 (10:54 +0000)]
2010-10-22  Zoltan Herczeg  <zherczeg@webkit.org>

        Reviewed by Csaba Osztrogonác.

        JSC interpreter regressions after r69940
        https://bugs.webkit.org/show_bug.cgi?id=47839

        Wrong "if": It should test whether the result exists,
        and not the opposite. It is an interpreter bug, hence
        the bots does not capture it.

        * interpreter/Interpreter.cpp:
        (JSC::Interpreter::resolveBase):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70299 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Yury Semikhatsky <yurys@chromium.org>
yurys@chromium.org [Fri, 22 Oct 2010 10:49:58 +0000 (10:49 +0000)]
2010-10-21  Yury Semikhatsky  <yurys@chromium.org>

        Reviewed by Pavel Feldman.

        Web Inspector: decouple ScriptArguments from ScriptCallStack
        https://bugs.webkit.org/show_bug.cgi?id=48058

        ScriptCallFrame and ScriptCallStack are now the same for both JSC and V8.
        The factory functions that allow to create ScriptCallStack from VM-specific
        objects are defined in ScriptCallStackFactory.cpp.

        ScriptArguments class is used for passing arguments from JS code to the native
        part.

        No new tests. This refactoring is covered with existing Console tests.

        * WebCore.gypi:
        * WebCore.xcodeproj/project.pbxproj:
        * bindings/js/ScriptCallFrame.cpp: Removed.
        * bindings/js/ScriptCallFrame.h: Removed.
        * bindings/js/ScriptCallStack.cpp: Removed.
        * bindings/js/ScriptCallStack.h: Removed.
        * bindings/js/ScriptCallStackFactory.cpp: Added.
        (WebCore::createScriptCallStack):
        (WebCore::createScriptArguments):
        (WebCore::ScriptCallStack::stackTrace):
        * bindings/js/ScriptCallStackFactory.h: Added.
        * bindings/js/ScriptState.h:
        (WebCore::ScriptStateProtectedPtr::get):
        * bindings/scripts/CodeGeneratorJS.pm:
        * bindings/scripts/CodeGeneratorV8.pm:
        * bindings/v8/ScriptCallFrame.cpp: Removed.
        * bindings/v8/ScriptCallFrame.h: Removed.
        * bindings/v8/ScriptCallStack.cpp: Removed.
        * bindings/v8/ScriptCallStack.h: Removed.
        * bindings/v8/ScriptCallStackFactory.cpp: Added.
        (WebCore::toScriptCallFrame):
        (WebCore::toScriptCallFramesVector):
        (WebCore::createScriptCallStack):
        (WebCore::createScriptArguments):
        (WebCore::ScriptCallStack::stackTrace):
        * bindings/v8/ScriptCallStackFactory.h: Added.
        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::setCaptureCallStackForUncaughtExceptions):
        * bindings/v8/ScriptState.h:
        (WebCore::ScriptStateProtectedPtr::get):
        * bindings/v8/V8ConsoleMessage.cpp:
        (WebCore::V8ConsoleMessage::handler):
        (WebCore::V8ConsoleMessage::dispatchNow):
        * bindings/v8/V8ConsoleMessage.h:
        * bindings/v8/custom/V8ConsoleCustom.cpp:
        (WebCore::V8Console::traceCallback):
        (WebCore::V8Console::assertCallback):
        * inspector/ConsoleMessage.cpp:
        (WebCore::ConsoleMessage::ConsoleMessage):
        (WebCore::ConsoleMessage::addToFrontend):
        (WebCore::ConsoleMessage::updateRepeatCountInConsole):
        (WebCore::ConsoleMessage::isEqual):
        * inspector/ConsoleMessage.h:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::addMessageToConsole):
        (WebCore::InspectorController::startGroup):
        * inspector/InspectorController.h:
        * inspector/ScriptArguments.cpp: Added.
        (WebCore::ScriptArguments::ScriptArguments):
        (WebCore::ScriptArguments::~ScriptArguments):
        (WebCore::ScriptArguments::argumentAt):
        (WebCore::ScriptArguments::globalState):
        (WebCore::ScriptArguments::getFirstArgumentAsString):
        (WebCore::ScriptArguments::isEqual):
        * inspector/ScriptArguments.h: Added.
        (WebCore::ScriptArguments::argumentCount):
        * inspector/ScriptCallFrame.cpp: Added.
        (WebCore::ScriptCallFrame::ScriptCallFrame):
        (WebCore::ScriptCallFrame::~ScriptCallFrame):
        (WebCore::ScriptCallFrame::isEqual):
        (WebCore::ScriptCallFrame::buildInspectorObject):
        * inspector/ScriptCallFrame.h: Added.
        (WebCore::ScriptCallFrame::functionName):
        (WebCore::ScriptCallFrame::sourceURL):
        (WebCore::ScriptCallFrame::lineNumber):
        * inspector/ScriptCallStack.cpp: Added.
        (WebCore::ScriptCallStack::ScriptCallStack):
        (WebCore::ScriptCallStack::~ScriptCallStack):
        (WebCore::ScriptCallStack::at):
        (WebCore::ScriptCallStack::size):
        (WebCore::ScriptCallStack::isEqual):
        (WebCore::ScriptCallStack::buildInspectorObject):
        * inspector/ScriptCallStack.h: Added.
        * page/Console.cpp:
        (WebCore::Console::addMessage):
        (WebCore::Console::debug):
        (WebCore::Console::error):
        (WebCore::Console::info):
        (WebCore::Console::log):
        (WebCore::Console::dir):
        (WebCore::Console::dirxml):
        (WebCore::Console::trace):
        (WebCore::Console::assertCondition):
        (WebCore::Console::count):
        (WebCore::Console::markTimeline):
        (WebCore::Console::profile):
        (WebCore::Console::profileEnd):
        (WebCore::Console::timeEnd):
        (WebCore::Console::group):
        (WebCore::Console::groupCollapsed):
        (WebCore::Console::shouldCaptureFullStackTrace):
        (WebCore::Console::warn):
        * page/Console.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70298 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago[Qt] All widgets are rendered incorrectly when rendered through a cache
benjamin.poulain@nokia.com [Fri, 22 Oct 2010 09:57:59 +0000 (09:57 +0000)]
[Qt] All widgets are rendered incorrectly when rendered through a cache
https://bugs.webkit.org/show_bug.cgi?id=47767

Reviewed by Simon Hausmann.

WebCore:

When a widget is not available to the RenderTheme, default
value are used for the state.

* platform/qt/RenderThemeQt.cpp:
(WebCore::initStyleOption):
(WebCore::RenderThemeQt::paintButton):
(WebCore::RenderThemeQt::paintTextField):
(WebCore::RenderThemeQt::paintMenuList):
(WebCore::RenderThemeQt::paintMenuListButton):
(WebCore::RenderThemeQt::paintProgressBar):
(WebCore::RenderThemeQt::paintSliderTrack):

WebKit/qt:

Add a new test for rendering with tiling.

* tests/qgraphicswebview/tst_qgraphicswebview.cpp:
(tst_QGraphicsWebView::widgetsRenderingThroughCache):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70297 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMoving all bounding box related calculation to RenderSVGResourceFilterPrimitive
zherczeg@webkit.org [Fri, 22 Oct 2010 08:37:33 +0000 (08:37 +0000)]
Moving all bounding box related calculation to RenderSVGResourceFilterPrimitive
https://bugs.webkit.org/show_bug.cgi?id=47174

Reviewed by Dirk Schulze.

The primitive sub-region calculation was spread in many
files across in WebKit source code, and all of them are moved
to RenderSVGResourceFilterPrimitive, where they should be.
In this patch the calculation is a static method which will
be turned to a real member function in the near future.

* platform/graphics/filters/FETile.cpp:
* platform/graphics/filters/FETile.h:
(WebCore::FETile::filterEffectType):
* platform/graphics/filters/Filter.h:
* platform/graphics/filters/FilterEffect.cpp:
* platform/graphics/filters/FilterEffect.h:
* rendering/RenderSVGResourceFilter.cpp:
(WebCore::RenderSVGResourceFilter::applyResource):
* rendering/RenderSVGResourceFilterPrimitive.cpp:
(WebCore::RenderSVGResourceFilterPrimitive::determineFilterPrimitiveSubregion):
* rendering/RenderSVGResourceFilterPrimitive.h:
(WebCore::RenderSVGResourceFilterPrimitive::RenderSVGResourceFilterPrimitive):
* svg/graphics/filters/SVGFilter.cpp:
* svg/graphics/filters/SVGFilter.h:
(WebCore::SVGFilter::mapLocalRectToAbsoluteRect):
(WebCore::SVGFilter::targetBoundingBox):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70296 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-22 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 22 Oct 2010 08:21:17 +0000 (08:21 +0000)]
2010-10-22  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        https://bugs.webkit.org/show_bug.cgi?id=47645
        Conversion to text test: editing/spelling/spellcheck-attribute.html

        Replaced a pixel test with test-based test using
        LayoutTestController.hasSpellingMarker().

        * editing/spelling/spellcheck-attribute-expected.txt: Added.
        * editing/spelling/spellcheck-attribute.html:
        * platform/chromium-win/editing/spelling/spellcheck-attribute-expected.checksum: Removed.
        * platform/chromium-win/editing/spelling/spellcheck-attribute-expected.png: Removed.
        * platform/chromium-win/editing/spelling/spellcheck-attribute-expected.txt: Removed.
        * platform/chromium/test_expectations.txt:
        * platform/gtk/editing/spelling/spellcheck-attribute-expected.txt: Removed.
        * platform/mac-leopard/editing/spelling/spellcheck-attribute-expected.checksum: Removed.
        * platform/mac-leopard/editing/spelling/spellcheck-attribute-expected.png: Removed.
        * platform/mac/editing/spelling/spellcheck-attribute-expected.checksum: Removed.
        * platform/mac/editing/spelling/spellcheck-attribute-expected.png: Removed.
        * platform/mac/editing/spelling/spellcheck-attribute-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70295 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Fri, 22 Oct 2010 05:52:24 +0000 (05:52 +0000)]
2010-10-21  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Add a String constructor which takes AECHAR*
        https://bugs.webkit.org/show_bug.cgi?id=45043

        Implement String(const AECHAR*) constructor.

        * platform/text/brew/StringBrew.cpp: Added.
        (WTF::String::String):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70294 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 James Simonsen <simonjam@chromium.org>
commit-queue@webkit.org [Fri, 22 Oct 2010 05:49:12 +0000 (05:49 +0000)]
2010-10-21  James Simonsen  <simonjam@chromium.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder's InForeignContent code needs a re-write

        Foreign Content mode was changed significantly by:
        http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314

        The differences can be seen here:
        http://html5.org/tools/web-apps-tracker?from=5520&to=5522

        This bug addresses all spec changes in the diff except the select scope
        changes, which have already been fixed in a separate bug.

        https://bugs.webkit.org/show_bug.cgi?id=46676

        * html5lib/resources/webkit01.dat: Added the demo case for the new code. Added a case that exposes crash when not using hasTagName().
        * html5lib/runner-expected.txt: Since the behavior of InForeignContentMode has changed, the expectations need to be updated. These have been manually verified.
        * platform/chromium/html5lib/runner-expected.txt: Ditto.
        * platform/win/html5lib/runner-expected.txt: Ditto.
2010-10-21  James Simonsen  <simonjam@chromium.org>

        Reviewed by Adam Barth.

        HTMLTreeBuilder's InForeignContent code needs a re-write

        Foreign Content mode was changed significantly by:
        http://www.w3.org/Bugs/Public/show_bug.cgi?id=10314

        The differences can be seen here:
        http://html5.org/tools/web-apps-tracker?from=5520&to=5522

        This bug addresses all spec changes in the diff except the select scope
        changes, which have already been fixed in a separate bug.

        https://bugs.webkit.org/show_bug.cgi?id=46676

        * html/parser/HTMLElementStack.cpp:
        (WebCore::HTMLNames::isScopeMarker): Add foreign elements to list.
        * html/parser/HTMLTreeBuilder.cpp:
        (WebCore::HTMLTreeBuilder::HTMLTreeBuilder):
        (WebCore::HTMLTreeBuilder::processDoctypeToken): Switch mode before reprocessing any tokens.
        (WebCore::HTMLTreeBuilder::processStartTagForInBody): Ditto. Remove secondary insertion mode.
        (WebCore::HTMLTreeBuilder::processStartTagForInTable): Switch mode before reprocessing any tokens.
        (WebCore::HTMLTreeBuilder::processStartTag): Ditto. Remove secondary insertion mode.
        (WebCore::HTMLTreeBuilder::resetInsertionModeAppropriately): Remove foreign var. Use hasTagName() instead of == localName() to fix bug with foreign elements.
        (WebCore::HTMLTreeBuilder::processEndTagForInTableBody): Switch mode before reprocessing any tokens.
        (WebCore::HTMLTreeBuilder::processEndTagForInRow): Ditto.
        (WebCore::HTMLTreeBuilder::processEndTagForInCell): Ditto.
        (WebCore::HTMLTreeBuilder::processEndTagForInBody): Ditto.
        (WebCore::HTMLTreeBuilder::processEndTag): Ditto.
        (WebCore::HTMLTreeBuilder::prepareToReprocessToken): Added.
        (WebCore::HTMLTreeBuilder::reprocessStartTag): Added.
        (WebCore::HTMLTreeBuilder::reprocessEndTag): Added.
        (WebCore::HTMLTreeBuilder::processForeignContentUsingInBodyModeAndResetMode): Added.
        (WebCore::HTMLTreeBuilder::resetForeignInsertionMode): Added.
        (WebCore::HTMLTreeBuilder::processComment): Switch mode before reprocessing any tokens.
        (WebCore::HTMLTreeBuilder::processCharacterBuffer): Ditto.
        (WebCore::HTMLTreeBuilder::processEndOfFile): Ditto.
        * html/parser/HTMLTreeBuilder.h: Functions and member for tracking potential switch from InForeignContentMode.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70293 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 22 Oct 2010 05:47:39 +0000 (05:47 +0000)]
2010-10-21 MORITA Hajime  <morrita@google.com>

        Unreviewed, touched it to fix the build.

        * Interfaces/WebKit.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70292 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 MORITA Hajime <morrita@google.com>
morrita@google.com [Fri, 22 Oct 2010 05:35:17 +0000 (05:35 +0000)]
2010-10-21  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Win][DRT] should have LayoutTestController.hasSpellingMarker()
        https://bugs.webkit.org/show_bug.cgi?id=47885

        Added IWebFramePrivate::hasSpellingMarker() and impelmented it for
        LayoutTestController.

        * Interfaces/IWebFramePrivate.idl:
        * WebFrame.cpp:
        (WebFrame::hasSpellingMarker):
        * WebFrame.h:
2010-10-21  MORITA Hajime  <morrita@google.com>

        Reviewed by Kent Tamura.

        [Win][DRT] should have LayoutTestController.hasSpellingMarker()
        https://bugs.webkit.org/show_bug.cgi?id=47885

        - Implemented LayoutTestController.hasSpellingMarker(),
        - Added fake spellcheck implementation.

        * DumpRenderTree/win/DumpRenderTree.cpp:
        (main):
        * DumpRenderTree/win/EditingDelegate.cpp:
        (indexOfFirstWordCharacter):
        (wordLength):
        (EditingDelegate::checkSpellingOfString):
        * DumpRenderTree/win/EditingDelegate.h:
        * DumpRenderTree/win/LayoutTestControllerWin.cpp:
        (LayoutTestController::hasSpellingMarker):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70291 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Fri, 22 Oct 2010 05:34:41 +0000 (05:34 +0000)]
2010-10-21  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Remove Android build system
        https://bugs.webkit.org/show_bug.cgi?id=48111

        * Android.mk: Removed.
2010-10-21  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Remove Android build system
        https://bugs.webkit.org/show_bug.cgi?id=48111

        * Android.mk: Removed.
2010-10-21  Adam Barth  <abarth@webkit.org>

        Reviewed by David Levin.

        Remove Android build system
        https://bugs.webkit.org/show_bug.cgi?id=48111

        As far as I can tell, these files are not maintained.  They are a
        mantaince burden on the project.  If folks would like to come out of
        the woodwork and maintain these files, that's great.  At the moment,
        they seem like dead weight for the project.

        * Android.mk: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70290 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Fri, 22 Oct 2010 05:16:24 +0000 (05:16 +0000)]
2010-10-21  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed build fix attempt for Chromium Linux Debug Clang

        * public/WebExternalPopupMenu.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70289 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Fri, 22 Oct 2010 04:43:24 +0000 (04:43 +0000)]
2010-10-21  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by Kent Tamura.

        [BREWMP] Add a String constructor which takes AECHAR*
        https://bugs.webkit.org/show_bug.cgi?id=45043

        Add String(const AECHAR*) constructor for convenience.

        * wtf/text/WTFString.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70288 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Kwang Yul Seo <skyul@company100.net>
commit-queue@webkit.org [Fri, 22 Oct 2010 03:39:52 +0000 (03:39 +0000)]
2010-10-21  Kwang Yul Seo  <skyul@company100.net>

        Reviewed by James Robinson.

        Make sure skia is not Chromium specific
        https://bugs.webkit.org/show_bug.cgi?id=39672

        GlyphPageTreeNodeLinux does not depend on Linux or Chromium.
        Move GlyphPageTreeNodeLinux to platform/graphics/skia and rename it to
        GlyphPageTreeNodeSkia.cpp so that other ports can use it.

        * WebCore.gyp/WebCore.gyp:
        * WebCore.gypi:
        * platform/graphics/chromium/GlyphPageTreeNodeLinux.cpp: Removed.
        * platform/graphics/skia/GlyphPageTreeNodeSkia.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70287 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 22 Oct 2010 02:58:02 +0000 (02:58 +0000)]
2010-10-21  Ryosuke Niwa  <rniwa@webkit.org>

        Unreviewed; rebaseline for r70240.

        * platform/mac-leopard/inspector/extensions-resources-expected.txt: Replaced XHR by xhr.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70286 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 22 Oct 2010 02:45:57 +0000 (02:45 +0000)]
2010-10-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Kent Tamura.

        REGRESSION(r70283): editing/execCommand/remove-format-elements.html fails on qt, gtk, and chromium
        https://bugs.webkit.org/show_bug.cgi?id=48108

        Modified the test to ignore the contents of keygen element.

        * editing/execCommand/remove-format-elements-expected.txt:
        * editing/execCommand/remove-format-elements.html:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70285 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Yuzo Fujishima <yuzo@google.com>
yuzo@google.com [Fri, 22 Oct 2010 01:50:18 +0000 (01:50 +0000)]
2010-10-21  Yuzo Fujishima  <yuzo@google.com>

        Unreviewed Chromium test expectation change.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70284 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Ryosuke Niwa <rniwa@webkit.org>
rniwa@webkit.org [Fri, 22 Oct 2010 01:30:04 +0000 (01:30 +0000)]
2010-10-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        removeFormat needs to be reimplemented
        https://bugs.webkit.org/show_bug.cgi?id=43017

        Reimplemented execCommand('RemoveFormat', false, null). New implementation removes
        the same elements removed by Internet Explorer. Because WebKit supports StyleWithCSS
        we also reset any editing styles to match that of the root editable element
        while Internet Explorer does not remove any CSS styles.

        New implementation uses ApplyStyleCommand to remove appropriate elements and reset the style.
        Added new constructor and member variable to ApplyStyleCommand to support mass-removal of elements
        since it's inefficient to call ApplyStyleCommand on each element we're removing.

        To avoid an infinite loop in pushDownInlineStyleAroundNode when mass-removing, WebKit no longer
        push down element one level at a time. Instead, we keep a stack of styled elements to be applied,
        and apply wrap siblings of targetNode's ancestors by all of them at once.

        Tests: editing/execCommand/remove-format-elements.html
               editing/execCommand/remove-format-multiple-elements.html

        * editing/ApplyStyleCommand.cpp:
        (WebCore::ApplyStyleCommand::ApplyStyleCommand): Added; this version takes style and a function pointer
        to a boolean function that determines which element needs to removed, and set m_removeOnly to true.
        (WebCore::ApplyStyleCommand::doApply): Added support for m_isInlineElementToRemoveFunction.
        (WebCore::ApplyStyleCommand::applyBlockStyle): Ditto.
        (WebCore::ApplyStyleCommand::applyInlineStyleToNodeRange): Exits early if m_removeOnly is true.
        (WebCore::ApplyStyleCommand::isStyledInlineElementToRemove): Added.
        (WebCore::ApplyStyleCommand::removeStyleFromRunBeforeApplyingStyle): Calls isStyledInlineElementToRemove.
        (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Ditto.
        (WebCore::ApplyStyleCommand::removeInlineStyle): Ditto.
        (WebCore::ApplyStyleCommand::pushDownInlineStyleAroundNode): See above.
        * editing/ApplyStyleCommand.h:
        (WebCore::ApplyStyleCommand::create): Added.
        * editing/RemoveFormatCommand.cpp:
        (WebCore::isElementForRemoveFormatCommand): Added.
        (WebCore::RemoveFormatCommand::doApply): Rewritten.
2010-10-21  Ryosuke Niwa  <rniwa@webkit.org>

        Reviewed by Tony Chang.

        removeFormat needs to be reimplemented
        https://bugs.webkit.org/show_bug.cgi?id=43017

        * editing/execCommand/19403-expected.txt: hr element is no longer removed erroneously.
        * editing/execCommand/19403.html: Updated the test description.
        * editing/execCommand/4786404-1-expected.txt: Change in text nodes but identical rendering.
        * editing/execCommand/4786404-2-expected.txt: Ditto.
        * editing/execCommand/4920488-expected.txt: Preserves anchor element on RemoveFormat.
        * editing/execCommand/4920488.html: Updated the test description.
        * editing/execCommand/4920742-1-expected.txt: Preserves div elements.
        * editing/execCommand/5049671.html: Updated the test to dump twice before and after RemoveFormat.
        This was a test to ensure WebKit removes anchor elements but we no longer removes anchor elements.
        * editing/execCommand/5049671-expected.txt:
        * editing/execCommand/5573879.html: Updated the test description because WebKit no longer removes
        lists on RemoveFormat.
        * editing/execCommand/5573879-expected.txt:
        * editing/execCommand/5770834-1-expected.txt: Removed redundant text-align property value.
        * editing/execCommand/remove-format-elements-expected.txt: Added.
        * editing/execCommand/remove-format-elements.html: Added.
        * editing/execCommand/remove-format-multiple-elements-expected.txt: Added.
        * editing/execCommand/remove-format-multiple-elements.html: Added.
        * editing/execCommand/remove-formatting-2-expected.txt: Change in text nodes but identical rendering.
        * editing/execCommand/remove-formatting-expected.txt: WebKit no longer removes anchor, table,
        tbody, tr, and td elements.
        * editing/execCommand/script-tests/remove-format-multiple-elements.js: Added.
        (testRemoveFormat):
        (selectAll):
        (selectSecondWord):
        (selectFirstTwoWords):
        (selectLastTwoWords):
        (selectLastWord):
        * editing/execCommand/script-tests/toggle-link.js: Anchor wraps div instead of div wrapping anchor.
        * editing/execCommand/script-tests/toggle-unlink.js: Ditto.
        * editing/execCommand/toggle-link-expected.txt: Ditto.
        * editing/execCommand/toggle-unlink-expected.txt: Ditto.
        * editing/execCommand/unlink-expected.txt: i wraps div instead of i wrapping anchor.
        * editing/inserting/space-after-removeformat-expected.txt: Editing delegate change.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70283 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Tony Gentilcore <tonyg@chromium.org>
tonyg@chromium.org [Fri, 22 Oct 2010 01:27:27 +0000 (01:27 +0000)]
2010-10-21  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Ignore document.write() when it comes from a network task
        https://bugs.webkit.org/show_bug.cgi?id=47560

        write()s from deferred scripts are now ignored. This matches the latest
        Firefox 4 beta behavior. The defer-write expectations are updated, and
        the other tests are now all moot since deferred scrits can't write().

        * fast/dom/HTMLScriptElement/defer-double-defer-write-expected.txt: Removed.
        * fast/dom/HTMLScriptElement/defer-double-defer-write.html: Removed.
        * fast/dom/HTMLScriptElement/defer-double-write-expected.txt: Removed.
        * fast/dom/HTMLScriptElement/defer-double-write.html: Removed.
        * fast/dom/HTMLScriptElement/defer-write.html: Updated to match FF4.
        * fast/dom/HTMLScriptElement/remove-source-expected.txt: Added.
        * fast/dom/HTMLScriptElement/remove-source.html: Added. Verifies that writes are still ignored when the src is removed after the script is requested but before it is executed.
        * fast/dom/HTMLScriptElement/two-defer-writes-expected.txt: Removed.
        * fast/dom/HTMLScriptElement/two-defer-writes.html: Removed.
        * fast/dom/HTMLScriptElement/write-after-ignored-write-expected.txt: Added. Verifies that after a write from a network task is ignored, a write which is not from a network task still blows away the document.
        * fast/dom/HTMLScriptElement/write-after-ignored-write.html: Added.
2010-10-21  Tony Gentilcore  <tonyg@chromium.org>

        Reviewed by Adam Barth.

        Ignore document.write() when it comes from a network task
        https://bugs.webkit.org/show_bug.cgi?id=47560

        This implements the update to the spec made by:
        http://www.w3.org/Bugs/Public/show_bug.cgi?id=9767

        It also matches the latest Firefox 4 beta. The notable change is that
        document.write from a deferred script no longer works. This avoids
        blowing the patch away.

        * dom/Document.cpp:
        (WebCore::Document::Document):
        (WebCore::Document::write):
        * dom/Document.h:
        (WebCore::DestructiveWriteCountIncrementer::DestructiveWriteCountIncrementer):
        (WebCore::Document::ignoreDestructiveWriteCountIncrementer):
        * dom/ScriptElement.cpp:
        (WebCore::ScriptElement::insertedIntoDocument):
        (WebCore::ScriptElementData::ScriptElementData):
        (WebCore::ScriptElementData::evaluateScript):
        * dom/ScriptElement.h:
        * html/parser/HTMLScriptRunner.cpp:
        (WebCore::HTMLScriptRunner::executePendingScriptAndDispatchEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70282 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnreviewed Leopard build fix attempt.
rniwa@webkit.org [Fri, 22 Oct 2010 01:03:52 +0000 (01:03 +0000)]
Unreviewed Leopard build fix attempt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70281 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 22 Oct 2010 01:03:18 +0000 (01:03 +0000)]
2010-10-21  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed. Re-enable test that was mistakenly disabled by r67974.

        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70280 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 22 Oct 2010 00:52:10 +0000 (00:52 +0000)]
2010-10-21  Mihai Parparita  <mihaip@chromium.org>

        Unreviewed fix for rebaseline-chromium-webkit-tests.

        Port.diff_image no longer has a tolerance parameter. Also, use
        get_option('tolerance') which is safer if the options object doesn't
        define a tolerance attribute (it doesn't for the one used in
        rebaseline_chromium_webkit_tests).

        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/rebaseline_chromium_webkit_tests.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70279 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 James Robinson <jamesr@chromium.org>
jamesr@google.com [Fri, 22 Oct 2010 00:22:59 +0000 (00:22 +0000)]
2010-10-21  James Robinson  <jamesr@chromium.org>

        Update chromium baselines, primarly for underline pixel changes.

        * platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.checksum:
        * platform/chromium-linux/css2.1/t09-c5526c-display-00-e-expected.png:
        * platform/chromium-linux/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum:
        * platform/chromium-linux/css2.1/t1504-c543-txt-decor-00-d-g-expected.png:
        * platform/chromium-linux/fast/backgrounds/background-clip-text-expected.checksum:
        * platform/chromium-linux/fast/backgrounds/background-clip-text-expected.png:
        * platform/chromium-linux/fast/backgrounds/background-inherit-color-bug-expected.checksum:
        * platform/chromium-linux/fast/backgrounds/background-inherit-color-bug-expected.png:
        * platform/chromium-linux/fast/css-generated-content/010-expected.checksum:
        * platform/chromium-linux/fast/css-generated-content/010-expected.png:
        * platform/chromium-linux/fast/css/compare-content-style-expected.checksum:
        * platform/chromium-linux/fast/css/compare-content-style-expected.png:
        * platform/chromium-linux/fast/css/css1_forward_compatible_parsing-expected.checksum:
        * platform/chromium-linux/fast/css/css1_forward_compatible_parsing-expected.png:
        * platform/chromium-linux/fast/css/line-height-font-order-expected.checksum:
        * platform/chromium-linux/fast/css/line-height-font-order-expected.png:
        * platform/chromium-linux/fast/css/text-overflow-ellipsis-strict-expected.checksum:
        * platform/chromium-linux/fast/css/text-overflow-ellipsis-strict-expected.png:
        * platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.checksum:
        * platform/chromium-linux/fast/forms/button-cannot-be-nested-expected.png:
        * platform/chromium-linux/fast/layers/normal-flow-hit-test-expected.checksum:
        * platform/chromium-linux/fast/layers/normal-flow-hit-test-expected.png:
        * platform/chromium-linux/fast/lists/003-expected.checksum:
        * platform/chromium-linux/fast/lists/003-expected.png:
        * platform/chromium-linux/fast/multicol/float-multicol-expected.checksum:
        * platform/chromium-linux/fast/multicol/float-multicol-expected.png:
        * platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.checksum:
        * platform/chromium-linux/fast/parser/remove-block-in-residual-style-expected.png:
        * platform/chromium-linux/fast/reflections/reflection-overflow-hidden-expected.checksum:
        * platform/chromium-linux/fast/reflections/reflection-overflow-hidden-expected.png:
        * platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.checksum:
        * platform/chromium-linux/fast/repaint/overflow-scroll-body-appear-expected.png:
        * platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
        * platform/chromium-linux/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
        * platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
        * platform/chromium-linux/fast/repaint/shadow-multiple-strict-vertical-expected.png:
        * platform/chromium-linux/fast/selectors/016-expected.checksum:
        * platform/chromium-linux/fast/selectors/016-expected.png:
        * platform/chromium-linux/fast/selectors/017-expected.checksum:
        * platform/chromium-linux/fast/selectors/017-expected.png:
        * platform/chromium-linux/fast/selectors/020-expected.checksum:
        * platform/chromium-linux/fast/selectors/020-expected.png:
        * platform/chromium-linux/fast/selectors/061-expected.checksum:
        * platform/chromium-linux/fast/selectors/061-expected.png:
        * platform/chromium-linux/fast/selectors/062-expected.checksum:
        * platform/chromium-linux/fast/selectors/062-expected.png:
        * platform/chromium-linux/fast/selectors/065-expected.checksum:
        * platform/chromium-linux/fast/selectors/065-expected.png:
        * platform/chromium-linux/fast/selectors/166-expected.checksum:
        * platform/chromium-linux/fast/selectors/166-expected.png:
        * platform/chromium-linux/fast/text/international/bidi-LDB-2-CSS-expected.checksum:
        * platform/chromium-linux/fast/text/international/bidi-LDB-2-CSS-expected.png:
        * platform/chromium-linux/fast/text/international/bidi-LDB-2-HTML-expected.checksum:
        * platform/chromium-linux/fast/text/international/bidi-LDB-2-HTML-expected.png:
        * platform/chromium-linux/fast/text/international/bidi-LDB-2-formatting-characters-expected.checksum:
        * platform/chromium-linux/fast/text/international/bidi-LDB-2-formatting-characters-expected.png:
        * platform/chromium-linux/fast/text/international/khmer-selection-expected.checksum:
        * platform/chromium-linux/fast/text/international/khmer-selection-expected.png:
        * platform/chromium-linux/fast/transforms/transform-positioned-ancestor-expected.checksum:
        * platform/chromium-linux/fast/transforms/transform-positioned-ancestor-expected.png:
        * platform/chromium-linux/fast/transforms/transformed-caret-expected.checksum:
        * platform/chromium-linux/fast/transforms/transformed-caret-expected.png:
        * platform/chromium-linux/svg/custom/rootmost-svg-xy-attrs-expected.checksum:
        * platform/chromium-linux/svg/custom/rootmost-svg-xy-attrs-expected.png:
        * platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum:
        * platform/chromium-linux/tables/mozilla/collapsing_borders/bug41262-3-expected.png:
        * platform/chromium-mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum: Added.
        * platform/chromium-mac/css2.1/t1504-c543-txt-decor-00-d-g-expected.png: Added.
        * platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.checksum: Added.
        * platform/chromium-mac/fast/backgrounds/background-inherit-color-bug-expected.png: Added.
        * platform/chromium-mac/fast/css-generated-content/010-expected.checksum: Added.
        * platform/chromium-mac/fast/css-generated-content/010-expected.png: Added.
        * platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.checksum: Added.
        * platform/chromium-mac/fast/css/text-overflow-ellipsis-strict-expected.png: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-horizontal-expected.png: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.checksum: Added.
        * platform/chromium-mac/fast/repaint/shadow-multiple-strict-vertical-expected.png: Added.
        * platform/chromium-mac/fast/selectors: Added.
        * platform/chromium-mac/fast/selectors/166-expected.checksum: Added.
        * platform/chromium-mac/fast/selectors/166-expected.png: Added.
        * platform/chromium-mac/tables/mozilla/collapsing_borders: Added.
        * platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.checksum: Added.
        * platform/chromium-mac/tables/mozilla/collapsing_borders/bug41262-3-expected.png: Added.
        * platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.checksum:
        * platform/chromium-win/css2.1/t1504-c543-txt-decor-00-d-g-expected.png:
        * platform/chromium-win/fast/css-generated-content/010-expected.checksum:
        * platform/chromium-win/fast/css-generated-content/010-expected.png:
        * platform/chromium-win/fast/css/text-overflow-ellipsis-strict-expected.checksum:
        * platform/chromium-win/fast/css/text-overflow-ellipsis-strict-expected.png:
        * platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.checksum:
        * platform/chromium-win/fast/repaint/shadow-multiple-strict-horizontal-expected.png:
        * platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.checksum:
        * platform/chromium-win/fast/repaint/shadow-multiple-strict-vertical-expected.png:
        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70278 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Fri, 22 Oct 2010 00:04:39 +0000 (00:04 +0000)]
2010-10-21  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by Ojan Vafai.

        Add support for --tolerance in NRWT
        https://bugs.webkit.org/show_bug.cgi?id=47959

        Add support for the --tolerance flag in NRWT. The Port.diff_image
        signature shouldn't need a tolerance parameter (it's not set per test),
        just have ports that use it (currently only WebKitPort) read it from
        the options object.

        * Scripts/webkitpy/layout_tests/port/chromium.py:
        * Scripts/webkitpy/layout_tests/port/port_testcase.py:
        * Scripts/webkitpy/layout_tests/port/test.py:
        * Scripts/webkitpy/layout_tests/port/webkit.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests.py:
        * Scripts/webkitpy/layout_tests/run_webkit_tests_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70277 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Ojan Vafai <ojan@chromium.org>
ojan@chromium.org [Fri, 22 Oct 2010 00:00:25 +0000 (00:00 +0000)]
2010-10-21  Ojan Vafai  <ojan@chromium.org>

        Update some expectations to match the bots. A couple of these are to
        green the new webkit linux debug build slaves. For some reason these
        tests crashed on the old slaves, but now match other platforms on
        the new slaves.

        * platform/chromium/test_expectations.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70276 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<rdar://problem/8423766> Cursor does not become "busy" when a page is
jhoneycutt@apple.com [Thu, 21 Oct 2010 23:50:59 +0000 (23:50 +0000)]
<rdar://problem/8423766> Cursor does not become "busy" when a page is
loading with WebKit2

Reviewed by Sam Weinig.

* UIProcess/API/C/win/WKViewPrivate.cpp: Added.
(WKViewSetOverrideCursor):
Call the WebView's setOverrideCursor().

* UIProcess/API/C/win/WKViewPrivate.h: Added.
Declare WKViewSetOVerrideCursor().

* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
Initialize new member vars to 0.
(WebKit::WebView::updateNativeCursor):
If there is an override cursor, and the last cursor set from the web
process was the arrow cursor, use the override cursor. Otherwise, use
the cursor from the web process.
(WebKit::WebView::setCursor):
Record the web process's cursor, and call updateNativeCursor().
(WebKit::WebView::setOverrideCursor):
Record the override cursor, and call updateNativeCursor().

* UIProcess/win/WebView.h:
Declare setOverrideCursor() and updateNativeCursor(). Add members to
hold the last cursor set from the web process and the override cursor.

* win/WebKit2.vcproj:
Add new files to project.

* win/WebKit2Generated.make:
Copy WKViewPrivate.h with other headers.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70275 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 21 Oct 2010 23:00:45 +0000 (23:00 +0000)]
2010-10-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        Add --suggest-reviewers option to upload to auto-suggest reviewers for your patch
        https://bugs.webkit.org/show_bug.cgi?id=48088

        This is a first-pass.  Works, but we'll eventually
        turn this on by default, refine the suggestion algorithm
        and possibly move it to a different place in the upload step order.

        * Scripts/webkitpy/common/checkout/api.py:
        * Scripts/webkitpy/tool/commands/download_unittest.py:
        * Scripts/webkitpy/tool/commands/upload.py:
        * Scripts/webkitpy/tool/commands/upload_unittest.py:
        * Scripts/webkitpy/tool/mocktool.py:
        * Scripts/webkitpy/tool/steps/__init__.py:
        * Scripts/webkitpy/tool/steps/options.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70274 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Tony Chang <tony@chromium.org>
tony@chromium.org [Thu, 21 Oct 2010 22:58:39 +0000 (22:58 +0000)]
2010-10-21  Tony Chang  <tony@chromium.org>

        Reviewed by Dimitri Glazkov.

        [chromium] roll chromium DEPS to include forwarding headers refactor
        https://bugs.webkit.org/show_bug.cgi?id=48097

        * DEPS: Roll chromium forward to include new forwarding headers script
        * WebKit.gyp: This dependency always existed, it's just exposed now
            that the header files are in a different include dir.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70273 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Mihai Parparita <mihaip@chromium.org>
mihaip@chromium.org [Thu, 21 Oct 2010 22:37:31 +0000 (22:37 +0000)]
2010-10-21  Mihai Parparita  <mihaip@chromium.org>

        Reviewed by James Robinson.

        [Chromium] Fix Chromium Mac build
        https://bugs.webkit.org/show_bug.cgi?id=48096

        Fix Chromium Mac build after r70225 (Chromium uses Core Text but is not
        PLATFORM(MAC)).

        * platform/graphics/SimpleFontData.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70272 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Julie Parent <jparent@chromium.org>
jparent@chromium.org [Thu, 21 Oct 2010 22:17:30 +0000 (22:17 +0000)]
2010-10-21  Julie Parent  <jparent@chromium.org>

        Reviewed by Tony Chang.

        [Chromium] Remove chromium baseline for http/tests/plugins/geturlnotify-from-npp-destroystream.html
        https://bugs.webkit.org/show_bug.cgi?id=48025

        * platform/chromium-win/http/tests/plugins/geturlnotify-from-npp-destroystream-expected.txt: Removed.
        * platform/chromium/test_expectations.txt: updated to account for expected results after this change

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70271 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Mario Sanchez Prada <msanchez@igalia.com>
commit-queue@webkit.org [Thu, 21 Oct 2010 22:14:07 +0000 (22:14 +0000)]
2010-10-21  Mario Sanchez Prada  <msanchez@igalia.com>

        Reviewed by Chris Fleizach.

        [GTK] Segfault while testing accessibility/iframe-bastardization.html
        https://bugs.webkit.org/show_bug.cgi?id=30123

        Check m_element before actually using it to get the parent.

        * DumpRenderTree/gtk/AccessibilityUIElementGtk.cpp:
        (AccessibilityUIElement::parentElement): Add an extra check to
        make sure m_element points to a valid value before actually using
        it to get the parent. Also, assert ATK_IS_OBJECT(m_element).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70270 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAdd two plug-in tests to the WebKit2 Skipped list.
andersca@apple.com [Thu, 21 Oct 2010 22:04:43 +0000 (22:04 +0000)]
Add two plug-in tests to the WebKit2 Skipped list.

Reviewed by Adam Roben.

* platform/mac-wk2/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70269 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCheck in ugly result for now.
hyatt@apple.com [Thu, 21 Oct 2010 21:46:30 +0000 (21:46 +0000)]
Check in ugly result for now.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70268 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoCrash evaluating JavaScript string that throws an exception
andersca@apple.com [Thu, 21 Oct 2010 21:46:10 +0000 (21:46 +0000)]
Crash evaluating JavaScript string that throws an exception
https://bugs.webkit.org/show_bug.cgi?id=48092
<rdar://problem/8487657>

Reviewed by Adam Roben.

WebKit2:

* UIProcess/WebProcessProxy.cpp:
(WebKit::WebProcessProxy::sendMessage):
m_connection can be null here; just return false if that is the case.

* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::runJavaScriptInMainFrame):
If the JSValue returned is null we just send along a null string.

WebKitTools:

Add a test that evaluates a JavaScript string that throws an exception and check that
the callback is called.

* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/EvaluateJavaScript.cpp: Added.
(TestWebKitAPI::didRunJavaScript):
(TestWebKitAPI::WebKit2_EvaluateJavaScript):
* TestWebKitAPI/win/TestWebKitAPI.vcproj:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70267 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Xiaomei Ji <xji@chromium.org>
xji@chromium.org [Thu, 21 Oct 2010 21:43:16 +0000 (21:43 +0000)]
2010-10-21  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Levin.

        Performance improvement for FontLinux.
        https://bugs.webkit.org/show_bug.cgi?id=47019

        Reduce the number of calls for the normalization function because converting
        to NFC form is very expensive.

        Combine space normalization and character mirroring into one text scan.

        Test: platform/chromium/fast/text/font-linux-normalize.html

        * platform/graphics/chromium/FontLinux.cpp:
        (WebCore::TextRunWalker::TextRunWalker):
        (WebCore::TextRunWalker::~TextRunWalker):
        (WebCore::TextRunWalker::getNormalizedTextRun):
        (WebCore::TextRunWalker::normalizeSpacesAndMirrorChars):
2010-10-21  Xiaomei Ji  <xji@chromium.org>

        Reviewed by David Levin.

        Performance improvement for FontLinux.
        https://bugs.webkit.org/show_bug.cgi?id=47019

        Reduce the number of calls for the normalization function because converting
        to NFC form is very expensive.

        Combine space normalization and character mirroring into one text scan.

        * platform/chromium/fast/text/font-linux-normalize-expected.txt: Added.
        * platform/chromium/fast/text/font-linux-normalize.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70266 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoInvalidate the plugin's HWND when NPN_InvalidateRect is called
aroben@apple.com [Thu, 21 Oct 2010 21:40:47 +0000 (21:40 +0000)]
Invalidate the plugin's HWND when NPN_InvalidateRect is called

Fixes <http://webkit.org/b/48086> <rdar://problem/8482944> Silverlight
doesn't repaint in WebKit2

Reviewed by Anders Carlsson.

WebKit2:

* WebProcess/Plugins/Netscape/NetscapePlugin.cpp:
(WebKit::NetscapePlugin::invalidate): Call platformInvalidate before
invalidating via the PluginController.

* WebProcess/Plugins/Netscape/NetscapePlugin.h: Added platformInvalidate.

* WebProcess/Plugins/Netscape/mac/NetscapePluginMac.mm:
(WebKit::NetscapePlugin::platformInvalidate):
* WebProcess/Plugins/Netscape/qt/NetscapePluginQt.cpp:
(WebKit::NetscapePlugin::platformInvalidate):
Stubbed out.

* WebProcess/Plugins/Netscape/win/NetscapePluginWin.cpp:
(WebKit::NetscapePlugin::platformInvalidate): If the plugin is
windowed, invalidate its HWND via ::InvalidateRect.

WebKitTools:

Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
called

* DumpRenderTree/TestNetscapePlugIn/PluginTest.cpp:
(PluginTest::NPN_InvalidateRect): Added. Calls through to the browser.
(executeScript): Added. Asks the browser to evaluate the script.

(PluginTest::waitUntilDone):
(PluginTest::notifyDone):
Added. Calls through to layoutTestController.

* DumpRenderTree/TestNetscapePlugIn/PluginTest.h: Added
* NPN_InvalidateRect and waitUntilDone/notifyDone.

* DumpRenderTree/TestNetscapePlugIn/Tests/win/NPNInvalidateRectInvalidatesWindow.cpp: Added.
(TemporaryWindowMover::moveSucceeded):
(TemporaryWindowMover::TemporaryWindowMover):
(TemporaryWindowMover::~TemporaryWindowMover):
This class moves a window on-screen and shows it, then moves it back and hides it.

(NPNInvalidateRectInvalidatesWindow::NPNInvalidateRectInvalidatesWindow):
Initialize our members.
(NPNInvalidateRectInvalidatesWindow::~NPNInvalidateRectInvalidatesWindow):
Delete our window mover if it hasn't been deleted already.
(NPNInvalidateRectInvalidatesWindow::NPP_SetWindow): Subclass the
plugin HWND and move the test harness window on screen.
(NPNInvalidateRectInvalidatesWindow::wndProc): Call through to onPaint
when we get a WM_PAINT message.
(NPNInvalidateRectInvalidatesWindow::onPaint): Do the test and tell
LayoutTestController we're done.
(NPNInvalidateRectInvalidatesWindow::testInvalidateRect): Validate
ourselves, invalidate our lower-right quadrant via NPN_InvalidateRect,
then check that our HWND's invalid region is the rect that we
invalidated.

* DumpRenderTree/TestNetscapePlugIn/win/TestNetscapePlugin.vcproj:
* Added NPNInvalidateRectInvalidatesWindow.

LayoutTests:

Test that the plugin's HWND is invalidated when NPN_InvalidateRect is
called

* platform/win/plugins/npn-invalidate-rect-invalidates-window-expected.txt: Added.
* platform/win/plugins/npn-invalidate-rect-invalidates-window.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70265 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Daniel Bates <dbates@rim.com>
dbates@webkit.org [Thu, 21 Oct 2010 21:21:00 +0000 (21:21 +0000)]
2010-10-21  Daniel Bates  <dbates@rim.com>

        Add Git-support to do-file-rename
        https://bugs.webkit.org/show_bug.cgi?id=48015

        Fix tools. Export function scmMoveOrRenameFile so that it can be called from
        do-file-rename and do-webcore-rename. I inadvertently left this out of the patch.

        * Scripts/VCSUtils.pm:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70264 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agohttps://bugs.webkit.org/show_bug.cgi?id=48085
hyatt@apple.com [Thu, 21 Oct 2010 21:16:55 +0000 (21:16 +0000)]
https://bugs.webkit.org/show_bug.cgi?id=48085

Reviewed by Darin Adler.

Make basic vertical text painting work.  This includes the text itself, underlines, overlines, line-throughs and shadows.

Added fast/blockflow/english-lr-text.html

WebCore:

* rendering/InlineFlowBox.cpp:
(WebCore::InlineFlowBox::paint):
* rendering/InlineFlowBox.h:
* rendering/InlineTextBox.cpp:
(WebCore::InlineTextBox::applyShadowToGraphicsContext):
(WebCore::paintTextWithShadows):
(WebCore::InlineTextBox::paint):
(WebCore::InlineTextBox::paintDecoration):
(WebCore::InlineTextBox::paintTextMatchMarker):
* rendering/InlineTextBox.h:
* rendering/svg/SVGInlineTextBox.cpp:
(WebCore::SVGInlineTextBox::paintTextWithShadows):

LayoutTests:

* fast/blockflow/english-lr-text.html: Added.
* platform/mac/fast/blockflow/english-lr-text-expected.checksum: Added.
* platform/mac/fast/blockflow/english-lr-text-expected.png: Added.
* platform/mac/fast/blockflow/english-lr-text-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70263 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 No'am Rosenthal <noam.rosenthal@nokia.com>
noam.rosenthal@nokia.com [Thu, 21 Oct 2010 20:31:17 +0000 (20:31 +0000)]
2010-10-21  No'am Rosenthal  <noam.rosenthal@nokia.com>

        Reviewed by Simon Hausmann.

        [Qt] When doing rendering through tiling, it seems the tiles are not initialized before rendering
        https://bugs.webkit.org/show_bug.cgi?id=48070

        No new tests. Auto-tests for Tiled Backing Store should be added, see bug 48082

        * page/Frame.cpp:
        (WebCore::Frame::tiledBackingStoreBackgroundColor):
        * page/Frame.h:
        * platform/graphics/TiledBackingStoreClient.h:
        * platform/graphics/qt/TileQt.cpp:
        (WebCore::Tile::updateBackBuffer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70262 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoFind indicator does not draw found text in WebKit2 when page is not scrolled to top
andersca@apple.com [Thu, 21 Oct 2010 20:24:22 +0000 (20:24 +0000)]
Find indicator does not draw found text in WebKit2 when page is not scrolled to top
<rdar://problem/8562647>
https://bugs.webkit.org/show_bug.cgi?id=48089

Reviewed by John Sullivan.

We always want the selection rectangle in "WebCore window coordinates" which is the same
as WKView coordinates in WebKit2.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::updateFindIndicator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70261 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 21 Oct 2010 20:08:48 +0000 (20:08 +0000)]
2010-10-21  James Robinson  <jamesr@chromium.org>

        Reviewed by Darin Adler.

        Spurious reference to undefined variable 'test' in fast/text/international/vertical-text-glyph-test.html
        https://bugs.webkit.org/show_bug.cgi?id=48084

        * fast/text/international/vertical-text-glyph-test.html:
        * platform/mac/fast/text/international/vertical-text-glyph-test-expected.txt:
        * platform/mac-leopard/fast/text/international/vertical-text-glyph-test-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70260 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Robert Hogan <robert@webkit.org>
robert@webkit.org [Thu, 21 Oct 2010 19:53:09 +0000 (19:53 +0000)]
2010-10-21  Robert Hogan  <robert@webkit.org>

        Reviewed by Simon Hausmann.

        [Qt] Sending a QInputMethodEvent::Selection event forces the
             Editor to go into Composition mode

        Improve QWebPage handling of input method events:
         - Selections don't trigger entering composition mode.
         - Handle multiple selections

        Also remove redundant cancellation of composition in tst_qwebpage.
        There is no composition in progress at that point.

        Finally, move infiniteLoopJS() to the end of the tst_qwebpage unit
        tests - so you don't have to wait for it to complete when running
        other tests.

        https://bugs.webkit.org/show_bug.cgi?id=39625

        * Api/qwebpage.cpp:
        (QWebPagePrivate::inputMethodEvent):
        (QWebPage::inputMethodQuery):
        * tests/qwebpage/tst_qwebpage.cpp:
        (tst_QWebPage::inputMethods):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70259 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAlways clear the selection when the find string isn't found
andersca@apple.com [Thu, 21 Oct 2010 19:51:54 +0000 (19:51 +0000)]
Always clear the selection when the find string isn't found
https://bugs.webkit.org/show_bug.cgi?id=48087
<rdar://problem/8564640>

Reviewed by David Hyatt.

* WebProcess/WebPage/FindController.cpp:
(WebKit::FindController::findString):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com>
commit-queue@webkit.org [Thu, 21 Oct 2010 19:33:10 +0000 (19:33 +0000)]
2010-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use GCharsetConverter instead of g_iconv in TextCodecGtk
        https://bugs.webkit.org/show_bug.cgi?id=47896

        * wtf/gobject/GTypedefs.h:
2010-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] Use GCharsetConverter instead of g_iconv in TextCodecGtk
        https://bugs.webkit.org/show_bug.cgi?id=47896

        It makes error handling easier. Fixes tests:
         fast/encoding/invalid-multi-byte-over-consumption.html
         fast/encoding/invalid-xml.html
         fast/encoding/japanese-encoding-mix.html
        when building with glib unicode

        * platform/text/gtk/TextCodecGtk.cpp:
        (WebCore::TextCodecGtk::TextCodecGtk):
        (WebCore::TextCodecGtk::~TextCodecGtk):
        (WebCore::TextCodecGtk::createIConvDecoder):
        (WebCore::TextCodecGtk::createIConvEncoder):
        (WebCore::TextCodecGtk::decode):
        (WebCore::TextCodecGtk::encode):
        * platform/text/gtk/TextCodecGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAX: contenteditable nodes do not return correct AXSelectedText* attributes
cfleizach@apple.com [Thu, 21 Oct 2010 19:22:43 +0000 (19:22 +0000)]
AX: contenteditable nodes do not return correct AXSelectedText* attributes
https://bugs.webkit.org/show_bug.cgi?id=48080

Reviewed by Beth Dakin.

WebCore:

The ariaSelectedDOMTextRange() method was not returning the correct values.
The fix is to return a plain text range that represents the current selection.

Test: platform/mac/accessibility/content-editable-range-properties.html

* accessibility/AccessibilityObject.h:
(WebCore::AccessibilityObject::accessibilityDescription):
* accessibility/AccessibilityRenderObject.cpp:
(WebCore::AccessibilityRenderObject::ariaSelectedTextRange):
(WebCore::AccessibilityRenderObject::selectedText):
(WebCore::AccessibilityRenderObject::selectedTextRange):
* accessibility/AccessibilityRenderObject.h:

LayoutTests:

* platform/mac/accessibility/content-editable-range-properties-expected.txt: Added.
* platform/mac/accessibility/content-editable-range-properties.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago Reviewed by John Sullivan.
ap@apple.com [Thu, 21 Oct 2010 19:21:09 +0000 (19:21 +0000)]
    Reviewed by John Sullivan.

        https://bugs.webkit.org/show_bug.cgi?id=48083
        <rdar://problem/8489082> Need WebKit2 API for private browsing

        This just adds glue code for passing the preference from embedder to WebCore. The aspects of
        private browsing that WebCore is responsible for do work, but cookies are not handled yet.

        * Shared/WebPreferencesStore.cpp:
        (WebKit::WebPreferencesStore::WebPreferencesStore):
        (WebKit::WebPreferencesStore::encode):
        (WebKit::WebPreferencesStore::decode):
        * Shared/WebPreferencesStore.h:
        * UIProcess/API/C/WKPreferences.cpp:
        (WKPreferencesSetPrivateBrowsingEnabled):
        (WKPreferencesGetPrivateBrowsingEnabled):
        * UIProcess/API/C/WKPreferences.h:
        * UIProcess/WebPreferences.cpp:
        (WebKit::WebPreferences::setPrivateBrowsingEnabled):
        (WebKit::WebPreferences::privateBrowsingEnabled):
        * UIProcess/WebPreferences.h:
        * WebProcess/WebPage/WebPage.cpp:
        (WebKit::WebPage::updatePreferences):
        Do what it takes to pass a single boolean from WebKit2 to WebCore. And we aren't even syncing
        the preference to user defaults yet.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 21 Oct 2010 19:19:38 +0000 (19:19 +0000)]
2010-10-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Adam Barth.

        mac-ews is not properly releasing patches
        https://bugs.webkit.org/show_bug.cgi?id=48076

        mac-ews overrides process_work_item, so it was not calling
        release_work_item like the default process_work_item would.
        To fix this I made all the status-reporting methods just
        release the patch.  I expect we'll iterate on this design further.

        * Scripts/webkitpy/common/net/statusserver.py:
        * Scripts/webkitpy/tool/commands/earlywarningsystem_unittest.py:
        * Scripts/webkitpy/tool/commands/queues.py:
        * Scripts/webkitpy/tool/commands/queues_unittest.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-18 Martin Robinson <mrobinson@igalia.com>
mrobinson@webkit.org [Thu, 21 Oct 2010 19:11:27 +0000 (19:11 +0000)]
2010-10-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] mathml flaky tests after adding SystemFonts to the theme
        https://bugs.webkit.org/show_bug.cgi?id=47727

        Rebaseline, add pixel results for, and unskip all MathML tests.

        * platform/gtk/Skipped: Unskip MathML tests.
        * platform/gtk/mathml/presentation/attributes-expected.checksum:
        * platform/gtk/mathml/presentation/attributes-expected.png:
        * platform/gtk/mathml/presentation/attributes-expected.txt:
        * platform/gtk/mathml/presentation/fenced-expected.checksum: Added.
        * platform/gtk/mathml/presentation/fenced-expected.png: Added.
        * platform/gtk/mathml/presentation/fenced-expected.txt:
        * platform/gtk/mathml/presentation/fenced-mi-expected.checksum:
        * platform/gtk/mathml/presentation/fenced-mi-expected.png:
        * platform/gtk/mathml/presentation/fenced-mi-expected.txt:
        * platform/gtk/mathml/presentation/fractions-expected.checksum:
        * platform/gtk/mathml/presentation/fractions-expected.png:
        * platform/gtk/mathml/presentation/fractions-expected.txt:
        * platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.checksum:
        * platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.png:
        * platform/gtk/mathml/presentation/fractions-vertical-alignment-expected.txt:
        * platform/gtk/mathml/presentation/mo-expected.checksum:
        * platform/gtk/mathml/presentation/mo-expected.png:
        * platform/gtk/mathml/presentation/mo-expected.txt:
        * platform/gtk/mathml/presentation/over-expected.checksum:
        * platform/gtk/mathml/presentation/over-expected.png:
        * platform/gtk/mathml/presentation/over-expected.txt:
        * platform/gtk/mathml/presentation/roots-expected.checksum: Added.
        * platform/gtk/mathml/presentation/roots-expected.png: Added.
        * platform/gtk/mathml/presentation/roots-expected.txt:
        * platform/gtk/mathml/presentation/row-alignment-expected.checksum:
        * platform/gtk/mathml/presentation/row-alignment-expected.png:
        * platform/gtk/mathml/presentation/row-alignment-expected.txt:
        * platform/gtk/mathml/presentation/row-expected.checksum:
        * platform/gtk/mathml/presentation/row-expected.png:
        * platform/gtk/mathml/presentation/row-expected.txt:
        * platform/gtk/mathml/presentation/style-expected.checksum:
        * platform/gtk/mathml/presentation/style-expected.png:
        * platform/gtk/mathml/presentation/style-expected.txt:
        * platform/gtk/mathml/presentation/sub-expected.checksum: Added.
        * platform/gtk/mathml/presentation/sub-expected.png: Added.
        * platform/gtk/mathml/presentation/sub-expected.txt:
        * platform/gtk/mathml/presentation/subsup-expected.checksum: Added.
        * platform/gtk/mathml/presentation/subsup-expected.png: Added.
        * platform/gtk/mathml/presentation/subsup-expected.txt:
        * platform/gtk/mathml/presentation/sup-expected.checksum: Added.
        * platform/gtk/mathml/presentation/sup-expected.png: Added.
        * platform/gtk/mathml/presentation/sup-expected.txt:
        * platform/gtk/mathml/presentation/tables-expected.checksum: Added.
        * platform/gtk/mathml/presentation/tables-expected.png: Added.
        * platform/gtk/mathml/presentation/tables-expected.txt:
        * platform/gtk/mathml/presentation/tokenElements-expected.checksum:
        * platform/gtk/mathml/presentation/tokenElements-expected.png:
        * platform/gtk/mathml/presentation/tokenElements-expected.txt:
        * platform/gtk/mathml/presentation/under-expected.checksum:
        * platform/gtk/mathml/presentation/under-expected.png:
        * platform/gtk/mathml/presentation/under-expected.txt:
        * platform/gtk/mathml/presentation/underover-expected.checksum:
        * platform/gtk/mathml/presentation/underover-expected.png:
        * platform/gtk/mathml/presentation/underover-expected.txt:
2010-10-18  Martin Robinson  <mrobinson@igalia.com>

        Reviewed by Gustavo Noronha Silva.

        [GTK] mathml flaky tests after adding SystemFonts to the theme
        https://bugs.webkit.org/show_bug.cgi?id=47727

        The Fontconfig setup in the GTK+ now specifically checks for and
        loads the STIX fonts for MathML tests.

        * DumpRenderTree/gtk/DumpRenderTree.cpp:
        (initializeFonts): Add hooks for loading the STIX fonts specifically.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-20 Jer Noble <jer.noble@apple.com>
jer.noble@apple.com [Thu, 21 Oct 2010 18:19:04 +0000 (18:19 +0000)]
2010-10-20  Jer Noble  <jer.noble@apple.com>

        Reviewed by Eric Carlson.

        Video -> Canvas doesn't work on Windows
        https://bugs.webkit.org/show_bug.cgi?id=47996
        rdar://problem/7884690

        * WebCore.vcproj/QTMovieWin.vcproj: Added QTDecompressionSession.{cpp,h}
        * platform/graphics/win/MediaPlayerPrivateQuickTimeVisualContext.cpp:
        (WebCore::MediaPlayerPrivateQuickTimeVisualContext::paint): Create a
            QTDecompressionSession if necessary and convert the QTPixelBuffer
            into a CG-compatible one.
        * platform/graphics/win/QTDecompressionSession.cpp: Added.
        * platform/graphics/win/QTDecompressionSession.h: Added.
        * platform/graphics/win/QTPixelBuffer.cpp:
        (SetNumberValue): Moved from QTMovieVisualContext.
        (QTPixelBuffer::createPixelBufferAttributesDictionary): Moved from inside
            QTMovieVisualContext::createPixelBufferOptionsDictionary().
        * platform/graphics/win/QTPixelBuffer.h: Moved the Type enum
            from QTMovieVisualContext.h.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Carlos Garcia Campos <cgarcia@igalia.com>
commit-queue@webkit.org [Thu, 21 Oct 2010 18:13:34 +0000 (18:13 +0000)]
2010-10-21  Carlos Garcia Campos  <cgarcia@igalia.com>

        Reviewed by Martin Robinson.

        [GTK] TextBreakIteratorGtk should initialize its internal index to 0
        https://bugs.webkit.org/show_bug.cgi?id=48065

        It fixes the following tests when using glib unicode:
          fast/forms/ValidityState-tooLong-input.html
          fast/forms/ValidityState-tooLong-textarea.html
          fast/forms/input-appearance-maxlength.html
          fast/forms/input-implicit-length-limit.html
          fast/forms/input-maxlength.html
          fast/forms/textarea-live-pseudo-selectors.html
          fast/forms/mailto/advanced-get.html
          fast/forms/mailto/advanced-put.html

        * platform/text/gtk/TextBreakIteratorGtk.cpp:
        (WebCore::setUpIterator):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 takano takumi <takano1@asia.apple.com>
mitz@apple.com [Thu, 21 Oct 2010 18:03:47 +0000 (18:03 +0000)]
2010-10-21  takano takumi  <takano1@asia.apple.com>

        Reviewed by Dan Bernstein.

        Need to swap glyphs for vertical writing
        https://bugs.webkit.org/show_bug.cgi?id=46973

        Made changes to pass the writing-mode orientation flag in RenderStyle down to FontPlatformData,
        and ultimately to CoreText APIs in both font complex path and fast path.

        Tests: fast/text/international/vertical-text-glyph-test.html
               fast/text/international/vertical-text-metrics-test.html

        * WebCore.exp.in:
        * WebCore.xcodeproj/project.pbxproj: Added platform/graphics/FontOrientation.h.
        * css/CSSFontFaceSource.cpp:
        (WebCore::CSSFontFaceSource::getFontData): Added font orientation parameter to SimpleFontData.
        * css/CSSStyleSelector.cpp:
        (WebCore::CSSStyleSelector::applyProperty): Set appropriate font orientation to the font description
        when writing-mode is being specified.
        * loader/CachedFont.cpp:
        (WebCore::CachedFont::platformDataFromCustomData): Made to pass font orientation to FontPlatformData.
        * loader/CachedFont.h:
        * platform/graphics/FontCache.cpp: Added font orientation to FontPlatformDataCacheKey
        (WebCore::FontPlatformDataCacheKey::FontPlatformDataCacheKey):
        (WebCore::FontPlatformDataCacheKey::operator==):
        (WebCore::computeHash):
        (WebCore::FontCache::getCachedFontPlatformData):
        * platform/graphics/FontDescription.h: Added font orientation support to FontDescription class
        (WebCore::FontDescription::FontDescription):
        (WebCore::FontDescription::orientation):
        (WebCore::FontDescription::setOrientation):
        (WebCore::FontDescription::operator==):
        * platform/graphics/FontOrientation.h: Added.
        * platform/graphics/SimpleFontData.h:
        * platform/graphics/cairo/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData()
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/cairo/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
        * platform/graphics/cocoa/FontPlatformData.h: Added font orientation support to FontPlatformData class
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::orientation):
        (WebCore::FontPlatformData::hash):
        (WebCore::FontPlatformData::operator==):
        * platform/graphics/cocoa/FontPlatformDataCocoa.mm: Added font orientation support
        (WebCore::FontPlatformData::FontPlatformData):
        (WebCore::FontPlatformData::operator=):
        (WebCore::FontPlatformData::allowsLigatures): Don't allow ligatures when the font is vertical orientation.
        (WebCore::FontPlatformData::description):
        * platform/graphics/gtk/FontCustomPlatformDataPango.cpp: Changed to pass font orientation to fontPlatformData()
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/haiku/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData()
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/haiku/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
        * platform/graphics/mac/FontCacheMac.mm: Added font orientation parameter when creating FontPlatformData object.
        (WebCore::FontCache::getFontDataForCharacters):
        (WebCore::FontCache::createFontPlatformData):
        * platform/graphics/mac/FontCustomPlatformData.cpp: Added font orientation parameter when creating FontPlatformData object.
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/mac/FontCustomPlatformData.h: Changed to pass font orientation parameter to fontPlatformData()
        * platform/graphics/mac/GlyphPageTreeNodeMac.cpp:
        (WebCore::GlyphPage::fill): Changed to use CoreText to extract glyphs when the current font is vertical orientation.
        CoreText automatically swaps glyphs with vertical variants when the font orientation is vertical.
        * platform/graphics/mac/SimpleFontDataCoreText.cpp: Added vertical form attribute to the attribute dictionary for a CTLine.
        (WebCore::SimpleFontData::getCFStringAttributes):
        * platform/graphics/mac/SimpleFontDataMac.mm:
        (WebCore::SimpleFontData::platformBoundsForGlyph): Changed to use CoreText (from CG) to support vertical metrics.
        (WebCore::SimpleFontData::platformWidthForGlyph): Made to use CoreText, instead of wkGetGlyphTransformedAdvances,
        to get vertical metrics when the font orientation is vertical.
        * platform/graphics/qt/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
        * platform/graphics/qt/FontCustomPlatformDataQt.cpp: Changed to pass font orientation to fontPlatformData()
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/skia/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData()
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/skia/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
        * platform/graphics/win/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData()
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/win/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
        * platform/graphics/win/FontCustomPlatformDataCairo.cpp: Changed to pass font orientation to fontPlatformData()
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/win/FontCustomPlatformDataCairo.h: Changed to pass font orientation to fontPlatformData()
        * platform/graphics/wince/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData()
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/wince/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()
        * platform/graphics/wx/FontCustomPlatformData.cpp: Changed to pass font orientation to fontPlatformData()
        (WebCore::FontCustomPlatformData::fontPlatformData):
        * platform/graphics/wx/FontCustomPlatformData.h: Changed to pass font orientation to fontPlatformData()

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 James Robinson <jamesr@chromium.org>
jamesr@google.com [Thu, 21 Oct 2010 17:53:38 +0000 (17:53 +0000)]
2010-10-21  James Robinson  <jamesr@chromium.org>

        Add chromium pixel baselines for new SVG length tests.

        * platform/chromium-linux/svg/dom/SVGLengthList-appendItem-expected.checksum: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-appendItem-expected.png: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.checksum: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-basics-expected.png: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-getItem-expected.checksum: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-getItem-expected.png: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-initialize-expected.checksum: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-initialize-expected.png: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-removeItem-expected.checksum: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-removeItem-expected.png: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-replaceItem-expected.checksum: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Added.
        * platform/chromium-linux/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.checksum: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-appendItem-expected.png: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.checksum: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-initialize-expected.png: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.checksum: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-removeItem-expected.png: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.checksum: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Added.
        * platform/chromium-mac/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-appendItem-expected.checksum: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-appendItem-expected.png: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-basics-expected.checksum: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-basics-expected.png: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-getItem-expected.checksum: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-getItem-expected.png: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-initialize-expected.checksum: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-initialize-expected.png: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-insertItemBefore-expected.checksum: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-insertItemBefore-expected.png: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-removeItem-expected.checksum: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-removeItem-expected.png: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-replaceItem-expected.checksum: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-replaceItem-expected.png: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-xml-dom-modifications-expected.checksum: Added.
        * platform/chromium-win/svg/dom/SVGLengthList-xml-dom-modifications-expected.png: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 21 Oct 2010 17:20:48 +0000 (17:20 +0000)]
2010-10-21  Pavel Feldman  <pfeldman@chromium.org>

        Not reviewed. Fixed inspector extensions test expectations.

        * inspector/extensions-api-expected.txt:
        * inspector/extensions-resources-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoAsk the UI client to close the page when the WKView receives a WM_CLOSE message
aroben@apple.com [Thu, 21 Oct 2010 17:04:16 +0000 (17:04 +0000)]
Ask the UI client to close the page when the WKView receives a WM_CLOSE message

Fixes <http://webkit.org/b/48044> <rdar://problem/8488446> Pressing
Ctrl+W when viewing a full-page PDF destroys the WKView but doesn't
close its parent window

Reviewed by Jon Honeycutt.

WebKit2:

* UIProcess/win/WebView.cpp:
(WebKit::WebView::wndProc): Call through to WebPageProxy::tryClose when
we receive a WM_CLOSE message, rather than passing the message along to
::DefWindowProcW. tryClose will end up asking the UI client to close
the page, while ::DefWindowProcW would destroy us synchronously without
notifying the UI client at all. One case where we'll get sent a
WM_CLOSE message is when the user presses Ctrl+W when using the Adobe
Reader plugin to view a PDF.

WebKitTools:

Test that the UI client gets notified when WKView receives a WM_CLOSE message

* TestWebKitAPI/Tests/WebKit2/win/WMCloseCallsUIClientClose.cpp: Added.
(TestWebKitAPI::close): Record that this function was called.
(TestWebKitAPI::WebKit2_WMCloseCallsUIClientClose): Create a WKView,
send it a WM_CLOSE message, and test that the UI client's close
callback got called. Note that this will hang if the bug is
reintroduced; <http://webkit.org/b/48043> covers making TestWebKitAPI
able to handle hangs.

* TestWebKitAPI/win/TestWebKitAPI.vcproj: Added the new test.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoMake prepare-ChangeLog much faster when using git
aroben@apple.com [Thu, 21 Oct 2010 17:03:47 +0000 (17:03 +0000)]
Make prepare-ChangeLog much faster when using git

This change also seems to make it detect renames better in some cases.

Fixes <http://webkit.org/b/48040> prepare-ChangeLog is slow when using
git

Reviewed by David Kilzer.

* Scripts/prepare-ChangeLog:
(statusCommand):
(createPatchCommand):
Use "-M -C" instead of "-C -C -M" to tell git-diff to detect renames
and copies. The two "-C"s were making it read many more files than were
necessary.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70246 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoRemove confusing and redundant "host window" terminology from WKView on Windows
aroben@apple.com [Thu, 21 Oct 2010 17:03:18 +0000 (17:03 +0000)]
Remove confusing and redundant "host window" terminology from WKView on Windows

WKView's "host window" is really just its HWND's parent window. The
terminology has been updated to reflect this. The unnecessary
WKViewGetHostWindow function has been removed, as it was a synonym for
::GetParent(WKViewGetWindow(view)).

Fixes <http://webkit.org/b/48039> WKView's "host window" API is
confusing

Reviewed by Sam Weinig.

* UIProcess/API/C/win/WKView.cpp:
(WKViewCreate):
(WKViewSetParentWindow):
* UIProcess/API/C/win/WKView.h:
Replaced "host window" with "parent window". Removed
WKViewGetHostWindow.

* UIProcess/win/WebView.cpp:
(WebKit::WebView::WebView):
(WebKit::WebView::setParentWindow):
(WebKit::WebView::windowAncestryDidChange):
(WebKit::WebView::close):
* UIProcess/win/WebView.h:
(WebKit::WebView::create):
Replaced "host window" with "parent window". Removed m_hostWindow and
hostWindow().

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoNull frame passed when running alert from UserScript run at document start
weinig@apple.com [Thu, 21 Oct 2010 16:45:39 +0000 (16:45 +0000)]
Null frame passed when running alert from UserScript run at document start
<rdar://problem/8573809>
https://bugs.webkit.org/show_bug.cgi?id=48036

Reviewed by Adam Roben.

WebKit2:

Don't initialize a Frame until after we have notified the UIProcess of its creation.
This is necessary since arbitrary actions can happen during the call to Frame::init()
such as the running of UserScripts.

* WebProcess/WebCoreSupport/WebFrameLoaderClient.cpp:
(WebKit::WebFrameLoaderClient::createFrame):
* WebProcess/WebPage/WebFrame.cpp:
(WebKit::WebFrame::createMainFrame):
(WebKit::WebFrame::createSubframe):
(WebKit::WebFrame::create):
(WebKit::WebFrame::WebFrame):
(WebKit::WebFrame::init):
* WebProcess/WebPage/WebFrame.h:
* WebProcess/WebPage/WebPage.cpp:
(WebKit::WebPage::WebPage):

WebKitTools:

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
* TestWebKitAPI/InjectedBundleController.cpp:
(TestWebKitAPI::InjectedBundleController::didReceiveMessage):
(TestWebKitAPI::InjectedBundleController::initializeTestNamed):
* TestWebKitAPI/InjectedBundleController.h:
* TestWebKitAPI/InjectedBundleTest.h:
(TestWebKitAPI::InjectedBundleTest::initialize):
* TestWebKitAPI/TestWebKitAPI.xcodeproj/project.pbxproj:
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash.cpp: Added.
(TestWebKitAPI::runJavaScriptAlert):
(TestWebKitAPI::TEST):
* TestWebKitAPI/Tests/WebKit2/DocumentStartUserScriptAlertCrash_Bundle.cpp: Added.
(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::DocumentStartUserScriptAlertCrashTest):
(TestWebKitAPI::DocumentStartUserScriptAlertCrashTest::initialize):
Add test for invoking an alert during a UserScript run at document start.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70244 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years agoUnskip plugins/pass-different-npp-struct.html on SnowLeopard
aroben@apple.com [Thu, 21 Oct 2010 16:44:34 +0000 (16:44 +0000)]
Unskip plugins/pass-different-npp-struct.html on SnowLeopard

The test seems to be passing when run manually on the bots.

* platform/mac/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70243 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Andreas Kling <kling@webkit.org>
andreas.kling@nokia.com [Thu, 21 Oct 2010 16:44:05 +0000 (16:44 +0000)]
2010-10-21  Andreas Kling  <kling@webkit.org>

        Reviewed by Adam Roben.

        TestNetscapePlugIn: Actually call NPP_SetWindow on Unix

        We were just returning NPERR_NO_ERROR previously.

        * DumpRenderTree/unix/TestNetscapePlugin/TestNetscapePlugin.cpp:
        (webkit_test_plugin_set_window):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70242 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h
ddkilzer@apple.com [Thu, 21 Oct 2010 16:38:35 +0000 (16:38 +0000)]
<webkit.org/b/48051> Move macros from DumpRenderTreeMac.h to config.h

Reviewed by Adam Roben.

* DumpRenderTree/config.h: Moved macros to here...
* DumpRenderTree/mac/DumpRenderTreeMac.h: ...from here.
Addresses a FIXME comment from r28419.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70241 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago2010-10-21 Pavel Feldman <pfeldman@chromium.org>
pfeldman@chromium.org [Thu, 21 Oct 2010 16:31:35 +0000 (16:31 +0000)]
2010-10-21  Pavel Feldman  <pfeldman@chromium.org>

        Reviewed by Yury Semikhatsky.

        Web Inspector: provide resource tree in the Storage panel (behind the flag).
        https://bugs.webkit.org/show_bug.cgi?id=48069

        * WebCore.gypi:
        * inspector/Inspector.idl:
        * inspector/InspectorController.cpp:
        (WebCore::InspectorController::frameDetachedFromParent):
        * inspector/InspectorResourceAgent.cpp:
        (WebCore::buildObjectForDocumentLoader):
        (WebCore::buildObjectForFrameResource):
        (WebCore::buildObjectForCachedResource):
        (WebCore::populateObjectWithFrameResources):
        (WebCore::InspectorResourceAgent::identifierForInitialRequest):
        (WebCore::InspectorResourceAgent::didLoadResourceFromMemoryCache):
        (WebCore::buildObjectForFrameTree):
        (WebCore::InspectorResourceAgent::didCommitLoad):
        (WebCore::InspectorResourceAgent::frameDetachedFromParent):
        (WebCore::InspectorResourceAgent::cachedResources):
        (WebCore::InspectorResourceAgent::resourceContent):
        * inspector/InspectorResourceAgent.h:
        * inspector/front-end/Images/frame.png: Added.
        * inspector/front-end/NetworkPanel.js:
        (WebInspector.NetworkPanel.prototype.refreshResource):
        (WebInspector.NetworkPanel.prototype._showResource):
        * inspector/front-end/Resource.js:
        (WebInspector.Resource.Type.toString):
        (WebInspector.Resource.prototype.getContents):
        * inspector/front-end/ResourceManager.js:
        (WebInspector.ResourceManager):
        (WebInspector.ResourceManager.prototype.identifierForInitialRequest):
        (WebInspector.ResourceManager.prototype._createResource):
        (WebInspector.ResourceManager.prototype.willSendRequest):
        (WebInspector.ResourceManager.prototype._appendRedirect):
        (WebInspector.ResourceManager.prototype.markResourceAsCached):
        (WebInspector.ResourceManager.prototype.didReceiveResponse):
        (WebInspector.ResourceManager.prototype._updateResourceWithResponse):
        (WebInspector.ResourceManager.prototype.didReceiveContentLength):
        (WebInspector.ResourceManager.prototype.didFinishLoading):
        (WebInspector.ResourceManager.prototype.didFailLoading):
        (WebInspector.ResourceManager.prototype.didLoadResourceFromMemoryCache):
        (WebInspector.ResourceManager.prototype._updateResourceWithCachedResource):
        (WebInspector.ResourceManager.prototype.setOverrideContent):
        (WebInspector.ResourceManager.prototype.didCommitLoadForFrame):
        (WebInspector.ResourceManager.prototype.frameDetachedFromParent):
        (WebInspector.ResourceManager.prototype._clearResources):
        (WebInspector.ResourceManager.prototype.didCreateWebSocket):
        (WebInspector.ResourceManager.prototype.willSendWebSocketHandshakeRequest):
        (WebInspector.ResourceManager.prototype.didReceiveWebSocketHandshakeResponse):
        (WebInspector.ResourceManager.prototype.didCloseWebSocket):
        (WebInspector.ResourceManager.prototype._processCachedResources):
        (WebInspector.ResourceManager.prototype._appendFramesRecursively.comparator):
        (WebInspector.ResourceManager.prototype._appendFramesRecursively):
        (WebInspector.ResourceManager.createResourceView):
        (WebInspector.ResourceManager.resourceViewTypeMatchesResource):
        (WebInspector.ResourceManager.resourceViewForResource):
        (WebInspector.ResourceManager.getContents):
        * inspector/front-end/ResourcesPanel.js:
        (WebInspector.ResourcesPanel.prototype.get searchableViews):
        (WebInspector.ResourcesPanel.prototype.addMessageToResource):
        (WebInspector.ResourcesPanel.prototype._recreateViewForResourceIfNeeded):
        (WebInspector.ResourcesPanel.prototype.showResource):
        (WebInspector.ResourcesPanel.prototype.sourceFrameForResource):
        * inspector/front-end/ScriptsPanel.js:
        (WebInspector.ScriptsPanel.prototype._showScriptOrResource):
        * inspector/front-end/StoragePanel.js:
        (WebInspector.StoragePanel):
        (WebInspector.StoragePanel.prototype.addFrame):
        (WebInspector.StoragePanel.prototype.removeFrame):
        (WebInspector.StoragePanel.prototype.addFrameResource):
        (WebInspector.StoragePanel.prototype.removeFrameResources):
        (WebInspector.StoragePanel.prototype.showResource):
        (WebInspector.BaseStorageTreeElement.prototype.onattach):
        (WebInspector.BaseStorageTreeElement.prototype.onreveal):
        (WebInspector.FrameTreeElement):
        (WebInspector.FrameTreeElement.prototype.onselect):
        (WebInspector.FrameResourceTreeElement):
        (WebInspector.FrameResourceTreeElement.prototype.onselect):
        (WebInspector.FrameResourceTreeElement.prototype.onattach):
        * inspector/front-end/WebKit.qrc:
        * inspector/front-end/inspector.css:
        (.frame-storage-tree-item .icon):
        (.storage.panel .sidebar.outline-disclosure > ol):
        (.resources-category-images .image-resource-icon-preview):
        (.children.small .resources-category-images .image-resource-icon-preview):
        * inspector/front-end/inspector.js:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70240 268f45cc-cd09-0410-ab3c-d52691b4dbfc

10 years ago<http://webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types
ddkilzer@apple.com [Thu, 21 Oct 2010 16:21:29 +0000 (16:21 +0000)]
<webkit.org/b/48047> Fix warnings found by check-Xcode-source-file-types

Reviewed by Adam Roben.

WebCore:

Fixes the following warning:

    WARNING: Unknown file type 'sourcecode' for file 'CSSPrimitiveValue.idl'.
    1 issues found for WebCore/WebCore.xcodeproj/project.pbxproj.

* WebCore.xcodeproj/project.pbxproj: Removed explicit file type
for CSSPrimitiveValue.idl to make it match other IDL files.

WebKit:

Fixes the following warning:

    WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WebStringTruncator.h'.
    1 issues found for WebKit/WebKit.xcodeproj/project.pbxproj.

* WebKit.xcodeproj/project.pbxproj: Removed explicit file type
for WebStringTruncator.h to make it match other header files.

WebKitTools:

Fixes the following warnings:

    WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'PixelDumpSupport.cpp'.
    WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'LayoutTestController.cpp'.
    WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'WorkQueue.cpp'.
    WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'cg/PixelDumpSupportCG.cpp'.
    WARNING: Incorrect file type 'sourcecode.cpp.objcpp' for file 'GCController.cpp'.
    5 issues found for WebKitTools/DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj.

* DumpRenderTree/DumpRenderTree.xcodeproj/project.pbxproj:
Removed explicit file type for *.cpp files above to make them
match other C++ source files.  This exposed the fact that
DumpRenderTreeMac.h was not safe to include in C++ source, which
caused PixelDumpSupport.cpp and PixelDumpSupportCG.cpp to fail
to build.
* DumpRenderTree/PixelDumpSupport.cpp: Adjusted header order.
* DumpRenderTree/mac/DumpRenderTreeMac.h: Made safe to include
in C++ source files.  Included CoreFoundation/CoreFoundation.h
to make sure all CF types were defined.  Removed CFStringRef
typedef.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@70239 268f45cc-cd09-0410-ab3c-d52691b4dbfc