WebKit-https.git
11 years ago2009-06-26 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 26 Jun 2009 10:07:57 +0000 (10:07 +0000)]
2009-06-26  Eric Seidel  <eric@webkit.org>

        Reviewed by Tor Arne Vestbø.

        Remove non-sense --update option to land-patches
        and make land-patches update before every patch application.
        This makes it slightly less likely that multi-patch landings will fail.

        Also updated git diff command to include staged modifications.

        * Scripts/bugzilla-tool:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45258 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-26 Yongjun Zhang <yongjun.zhang@nokia.com>
eric@webkit.org [Fri, 26 Jun 2009 10:06:33 +0000 (10:06 +0000)]
2009-06-26  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Eric Seidel.

        Bug 20303: [Qt] Key events are not working in frames.

        Add a layout test to test the event is sent to the right sub-frame.

        * platform/qt/fast/events/event-sender-keydown-frame-expected.txt: Added.
        * platform/qt/fast/events/event-sender-keydown-frame.html: Added.

2009-06-26  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Eric Seidel.

        Test: platform/qt/fast/events/event-sender-keydown-frame.html

        Bug 20303: [Qt] Key events are not working in frames.

        Merge scrolling handling code in qt and win port, move it to
        EventHandler.

        * page/EventHandler.cpp:
        (WebCore::EventHandler::scrollRecursively):
        * page/EventHandler.h:

2009-06-26  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Eric Seidel.

        Bug 20303: [Qt] Key events are not working in frames.

        Send scrolling events to current focused frame, bubble the event
        up to parent frame if it is not handled.  Use EventHandler's new
        shared scrolling code.

        * Api/qwebpage.cpp:
        (QWebPagePrivate::keyPressEvent):
        (QWebPagePrivate::handleScrolling):
        * Api/qwebpage_p.h:

2009-06-26  Yongjun Zhang  <yongjun.zhang@nokia.com>

        Reviewed by Eric Seidel.

        Bug 20303: [Qt] Key events are not working in frames.

        Move the scroll handling code to EventHandler so that other
        ports can share the functionality.

        * WebView.cpp:
        (WebView::keyDown):
        (EnumTextMatches::QueryInterface):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45257 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Eric Seidel.
rwlbuis@webkit.org [Fri, 26 Jun 2009 09:42:40 +0000 (09:42 +0000)]
    Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26682
        Bug 26682: It should be possible to add image to SVG DOM programmatically (using JavaScript)

        Make sure the xlink:href animated property setting syncs the corresponding attribute with the right namespace.

        Test: svg/custom/createImageElement.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45256 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-26 Takeshi Yoshino <tyoshino@google.com>
eric@webkit.org [Fri, 26 Jun 2009 09:36:57 +0000 (09:36 +0000)]
2009-06-26  Takeshi Yoshino  <tyoshino@google.com>

        Reviewed by Timothy Hatcher.

        Bug 26156: In view-source mode, always render the contents using HTMLViewSourceDocument
        https://bugs.webkit.org/show_bug.cgi?id=26156

        When in view-source mode, render the contents using HTMLViewSourceDocument
        regardless it's applicable for any plugin or not.

        Chromium tells WebCore to render the contents of specified URL when
        view-source: prefix is added to the URL. But currently, DOMImplementation
        ignores inViewSourceMode() when the MIME type is indicating that the contents
        are neither texts nor HTML family documents.

        For example, we can check the contents of asf file without launching media
        player. Rendering contents for view-source:-specified input is not what user
        expects.

        http://code.google.com/p/chromium/issues/detail?id=10545

        I want to fix this issue by this patch. IMHO, regardless of this Chromium
        specific issue, I think we should force use of HTMLViewSourceDocument when
        inViewSourceMode() is specified.

        * fast/frames/resources/viewsource-fake-image-file.png: Added.
        * fast/frames/viewsource-on-image-file.html: Added.
        * platform/mac/fast/frames/viewsource-on-image-file-expected.txt: Added.

2009-06-26  Takeshi Yoshino  <tyoshino@google.com>

        Reviewed by Timothy Hatcher.

        Bug 26156: In view-source mode, always render the contents using HTMLViewSourceDocument
        https://bugs.webkit.org/show_bug.cgi?id=26156

        When in view-source mode, render the contents using HTMLViewSourceDocument
        regardless it's applicable for any plugin or not.

        Chromium tells WebCore to render the contents of specified URL when
        view-source: prefix is added to the URL. But currently, DOMImplementation
        ignores inViewSourceMode() when the MIME type is indicating that the contents
        are neither texts nor HTML family documents.

        For example, we can check the contents of asf file without launching media
        player. Rendering contents for view-source:-specified input is not what user
        expects.

        http://code.google.com/p/chromium/issues/detail?id=10545

        I want to fix this issue by this patch. IMHO, regardless of this Chromium
        specific issue, I think we should force use of HTMLViewSourceDocument when
        inViewSourceMode() is specified.

        Test: fast/frames/viewsource-on-image-file.html

        * dom/DOMImplementation.cpp:
        (WebCore::DOMImplementation::createDocument):
        * html/HTMLViewSourceDocument.cpp:
        (WebCore::HTMLViewSourceDocument::createTokenizer):
        * html/HTMLViewSourceDocument.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45255 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Sam Weinig.
ap@webkit.org [Fri, 26 Jun 2009 09:25:12 +0000 (09:25 +0000)]
    Reviewed by Sam Weinig.

        <rdar://problem/6651201> Update lookalike character list.

        * Misc/WebNSURLExtras.mm: (isLookalikeCharacter): Added more characters to the list.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45254 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-26 Jungshik Shin <jshin@chromium.org>
eric@webkit.org [Fri, 26 Jun 2009 09:20:02 +0000 (09:20 +0000)]
2009-06-26  Jungshik Shin  <jshin@chromium.org>

        Reviewed by Eric Seidel.

        Add an additional test for bug 23786 (mistreatment of CR/LF
        as zero-width characters in Chromium port).  Tests using Bidi text were
        added when the fix was checked in. Without the patch, Chromium used
        to fail the same way with LTR complex scripts as well. (that is,
        CR and LF were treated as zero-width space). To prevent a potential
        regression in the future, a new test with Hindi (a LTR complex script)
        is added.

        The expected results for Mac and Windows are added while this test
        is added to Skipped file for gtk. I guess this test just needs
        a new test result generated on gtk.

        https://bugs.webkit.org/show_bug.cgi?id=25698

        * fast/text/international/hindi-whitespace.html: Added.
        * platform/gtk/Skipped:
        * platform/mac/fast/text/international/hindi-whitespace-expected.checksum: Added.
        * platform/mac/fast/text/international/hindi-whitespace-expected.png: Added.
        * platform/mac/fast/text/international/hindi-whitespace-expected.txt: Added.
        * platform/win/fast/text/international/hindi-whitespace-expected.checksum: Added.
        * platform/win/fast/text/international/hindi-whitespace-expected.png: Added.
        * platform/win/fast/text/international/hindi-whitespace-expected.txt: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45253 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-26 Xan Lopez <xlopez@igalia.com>
xan@webkit.org [Fri, 26 Jun 2009 09:12:44 +0000 (09:12 +0000)]
2009-06-26  Xan Lopez  <xlopez@igalia.com>

        Reviewed by Jan Alonzo.

        https://bugs.webkit.org/show_bug.cgi?id=25529
        [Gtk] Expected states not exposed to assistive technologies

        Add support for VISIBLE, EDITABLE and SENSITIVE states.

        * accessibility/gtk/AccessibilityObjectWrapperAtk.cpp:
        (setAtkStateSetFromCoreObject):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45252 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 26 Jun 2009 08:40:02 +0000 (08:40 +0000)]
2009-06-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Darin Adler.

        "Pointer to incomplete class type is not allowed" error with RVCT
        https://bugs.webkit.org/show_bug.cgi?id=26721

        Based on Norbert Leser's work.

        * dom/Document.cpp:
        (WebCore::Document::setFocusedNode):
        * dom/Node.cpp:
        (WebCore::Node::dispatchMouseEvent):
        * dom/Node.h: Remove the default value for PassRefPtr<Event> args,
        to eliminate dependency on the Event class definition

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45251 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Fri, 26 Jun 2009 08:32:16 +0000 (08:32 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Jan Alonzo.

        Fix obsolete_attachment to work when passed a comment.
        https://bugs.webkit.org/show_bug.cgi?id=26745

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45250 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
eric@webkit.org [Fri, 26 Jun 2009 08:28:00 +0000 (08:28 +0000)]
2009-06-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Mark Rowe.

        bugzilla-tool apply-patch throws exception in Linux
        https://bugs.webkit.org/show_bug.cgi?id=26738

        HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
        the scm module.

        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45249 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-26 Laszlo Gombos <laszlo.1.gombos@nokia.com>
eric@webkit.org [Fri, 26 Jun 2009 07:58:43 +0000 (07:58 +0000)]
2009-06-26  Laszlo Gombos  <laszlo.1.gombos@nokia.com>

        Reviewed by Maciej Stachowiak.

        [Qt] Build fix after r45183
        https://bugs.webkit.org/show_bug.cgi?id=26748

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45248 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Darin Adler.
ap@webkit.org [Fri, 26 Jun 2009 04:44:55 +0000 (04:44 +0000)]
    Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26681
        <rdar://problem/7003461> Problem updating applicationCache when server returns 304

        Test: http/tests/appcache/update-cache.html

        * loader/appcache/ApplicationCacheGroup.cpp: (WebCore::ApplicationCacheGroup::didReceiveResponse):
        We're already done with the resource, don't try to load it again.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45247 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 26 Jun 2009 03:32:30 +0000 (03:32 +0000)]
2009-06-25  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6990481>

        Handle perspective computation on non-layer objects.

        Test: transforms/3d/general/perspective-non-layer.html

        * rendering/RenderObject.cpp:
        (WebCore::RenderObject::getTransformFromContainer):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45245 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Ryosuke Niwa <rniwa@google.com>
eric@webkit.org [Fri, 26 Jun 2009 02:32:29 +0000 (02:32 +0000)]
2009-06-25  Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Eric Seidel.

        The following pixel tests have been converted into dumpastext tests. This
        fixes the bug 26336 partially.

        * editing/execCommand/remove-list-1-expected.txt: Added.
        * editing/execCommand/remove-list-1.html:
        * editing/execCommand/remove-list-items-expected.txt: Added.
        * editing/execCommand/remove-list-items.html:
        * platform/mac/editing/execCommand/remove-list-1-expected.checksum: Removed.
        * platform/mac/editing/execCommand/remove-list-1-expected.png: Removed.
        * platform/mac/editing/execCommand/remove-list-1-expected.txt: Removed.
        * platform/mac/editing/execCommand/remove-list-items-expected.checksum: Removed.
        * platform/mac/editing/execCommand/remove-list-items-expected.png: Removed.
        * platform/mac/editing/execCommand/remove-list-items-expected.txt: Removed.
        * platform/qt/editing/execCommand/remove-list-1-expected.txt: Removed.
        * platform/qt/editing/execCommand/remove-list-items-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45239 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 26 Jun 2009 02:19:47 +0000 (02:19 +0000)]
2009-06-25  Simon Fraser  <simon.fraser@apple.com>

        Rubber-stamped by Eric Seidel

        Update this test after the video controller changes.

        * platform/mac/fast/layers/video-layer-expected.txt:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45236 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 26 Jun 2009 02:12:10 +0000 (02:12 +0000)]
2009-06-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Not reviewed. Skip another failing test due to lack of eventSender impl.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45234 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Fri, 26 Jun 2009 01:38:34 +0000 (01:38 +0000)]
2009-06-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Not reviewed. Skip failing gtk tests due to missing DRT features.

        * platform/gtk/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45232 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 26 Jun 2009 01:16:00 +0000 (01:16 +0000)]
2009-06-25  Simon Fraser  <simon.fraser@apple.com>

        Rubber-stamped by Dan Bernstein.

        Add Windows-specific test results, since Windows does not have
        3d transforms enabled.

        * platform/win/fast/media/mq-transform-02-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-02-expected.txt.
        * platform/win/fast/media/mq-transform-03-expected.txt: Copied from LayoutTests/platform/mac-leopard/fast/media/mq-transform-03-expected.txt.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45230 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Pierre d'Herbemont <pdherbemont@apple.com>
simon.fraser@apple.com [Fri, 26 Jun 2009 01:06:29 +0000 (01:06 +0000)]
2009-06-25  Pierre d'Herbemont  <pdherbemont@apple.com>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26653

        Use flex box in the mediaControls.css style, to nicely scale if a button gets
        dynamically added or removed.

        Media tests results are affected by this changes.

        * css/mediaControls.css:
        * css/mediaControlsQT.css:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45228 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Fri, 26 Jun 2009 01:03:44 +0000 (01:03 +0000)]
2009-06-25  Simon Fraser  <simon.fraser@apple.com>

        Rubber-stamped by Mark Rowe.

        <rdar://problem/6999737>

        Update the media controller images.

        * libWebKitSystemInterfaceLeopard.a:
        * libWebKitSystemInterfaceSnowLeopard.a:
        * libWebKitSystemInterfaceTiger.a:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45227 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Ryosuke Niwa <rniwa@google.com>
eric@webkit.org [Fri, 26 Jun 2009 00:49:36 +0000 (00:49 +0000)]
2009-06-25  Ryosuke Niwa  <rniwa@google.com>

        Reviewed by Eric Seidel.

        The following pixel tests have been converted into dumpastext tests. This
        fixes the bug 26336 partially.

        * editing/execCommand/5432254-2-expected.txt: Added.
        * editing/execCommand/5432254-2.html:
        * editing/execCommand/5700414-1-expected.txt: Added.
        * editing/execCommand/5700414-1.html:
        * editing/execCommand/5700414-2-expected.txt: Added.
        * editing/execCommand/5700414-2.html:
        * platform/mac/editing/execCommand/5432254-2-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5432254-2-expected.png: Removed.
        * platform/mac/editing/execCommand/5432254-2-expected.txt: Removed.
        * platform/mac/editing/execCommand/5700414-1-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5700414-1-expected.png: Removed.
        * platform/mac/editing/execCommand/5700414-1-expected.txt: Removed.
        * platform/mac/editing/execCommand/5700414-2-expected.checksum: Removed.
        * platform/mac/editing/execCommand/5700414-2-expected.png: Removed.
        * platform/mac/editing/execCommand/5700414-2-expected.txt: Removed.
        * platform/qt/editing/execCommand/5432254-2-expected.txt: Removed.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45224 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Fri, 26 Jun 2009 00:26:18 +0000 (00:26 +0000)]
2009-06-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Mark Rowe

        * demos/index.html: Fix more typos etc.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45221 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Jakub Wieczorek <faw217@gmail.com>
eric@webkit.org [Fri, 26 Jun 2009 00:24:39 +0000 (00:24 +0000)]
2009-06-25  Jakub Wieczorek  <faw217@gmail.com>

        Reviewed by Adam Treat.

        Add highlight functionality to the QWebPage::findText() method. Introduced is
        new HighlightAllOccurrences flag which passed to the function will make it mark
        all existing occurrences of specified string in the page.

        * Api/qwebpage.cpp:
        (QWebPage::findText):
        * Api/qwebpage.h:
        * Api/qwebview.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45220 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Duy Nguyen <pclouds@gmail.com>
jmalonzo@webkit.org [Fri, 26 Jun 2009 00:22:25 +0000 (00:22 +0000)]
2009-06-25  Duy Nguyen  <pclouds@gmail.com>

        Rubber-stamped by Jan Alonzo.

        Gtk port Vietnamese translation
        https://bugs.webkit.org/show_bug.cgi?id=26739

        * vi.po: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45219 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Albert J. Wong <ajwong@chromium.org>
darin@chromium.org [Thu, 25 Jun 2009 23:58:50 +0000 (23:58 +0000)]
2009-06-25  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=26724

        Move relavent part of setDefaultFontSize from RenderThemeChromiumWin
        up into RenderThemeChromiumSkia.

        * rendering/RenderThemeChromiumSkia.cpp:
        (WebCore::RenderThemeChromiumSkia::setDefaultFontSize):
        * rendering/RenderThemeChromiumSkia.h:
        * rendering/RenderThemeChromiumWin.cpp:
        (WebCore::RenderThemeChromiumWin::setDefaultFontSize):
        * rendering/RenderThemeChromiumWin.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45215 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Anders Carlsson <andersca@apple.com>
andersca@apple.com [Thu, 25 Jun 2009 23:54:59 +0000 (23:54 +0000)]
2009-06-25  Anders Carlsson  <andersca@apple.com>

        Reviewed by Oliver Hunt.

        <rdar://problem/6989017>
        REGRESSION (SnowLeopard): RealPlayer content replays when opening a new tab or switching back to the RealPlayer tab

        If a plug-in fails in NPP_New, we would try to recreate it whenever the preferences for a web view would change.

        Fix this by setting a flag when we fail to instantiate the plug-in, so we only try once.

        * Plugins/WebBaseNetscapePluginView.h:
        * Plugins/WebBaseNetscapePluginView.mm:
        (-[WebBaseNetscapePluginView start]):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45214 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Thu, 25 Jun 2009 23:36:31 +0000 (23:36 +0000)]
2009-06-25  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Reviewed by Mark Rowe.

        bugzilla-tool apply-patch throws exception in Linux
        https://bugs.webkit.org/show_bug.cgi?id=26738

        HEAD is case-sensitive in Linux. Convert uses of head to HEAD in
        the scm module.

        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45210 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Matt Perry <mpcomplete@chromium.org>
darin@chromium.org [Thu, 25 Jun 2009 23:21:28 +0000 (23:21 +0000)]
2009-06-25  Matt Perry  <mpcomplete@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=26733

        Add V8-only methods to FrameLoaderClient that V8 can use to send
        out notifications when it creates/destroys a script context.

        * loader/EmptyClients.h:
        (WebCore::EmptyFrameLoaderClient::didCreateScriptContext):
        (WebCore::EmptyFrameLoaderClient::didDestroyScriptContext):
        * loader/FrameLoaderClient.h:
        (WebCore::FrameLoaderClient::didCreateScriptContext):
        (WebCore::FrameLoaderClient::didDestroyScriptContext):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45208 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 25 Jun 2009 23:11:53 +0000 (23:11 +0000)]
2009-06-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by David Levin.

        Correct a few typos that snuck in when I was reformatting CodeGeneratorV8.pm
        to match WebKit style.

        * bindings/scripts/CodeGeneratorV8.pm: Corrected lots of typos.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45207 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoSome cosmetic fixes I missed in my last checkin
cmarrin@apple.com [Thu, 25 Jun 2009 22:35:21 +0000 (22:35 +0000)]
Some cosmetic fixes I missed in my last checkin

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45204 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Adam Langley <agl@google.com>
agl@chromium.org [Thu, 25 Jun 2009 22:32:40 +0000 (22:32 +0000)]
2009-06-25  Adam Langley  <agl@google.com>

        TBRed: fix for Chromium tree.

        Add missing include for r45199.

        https://bugs.webkit.org/show_bug.cgi?id=26736

        r45199 added a reference to throwError without including V8Proxy.h

        * bindings/v8/WorkerScriptController.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45203 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Adam Langley <agl@google.com>
agl@chromium.org [Thu, 25 Jun 2009 22:13:39 +0000 (22:13 +0000)]
2009-06-25  Adam Langley  <agl@google.com>

        TBRed: fix for Chromium tree.

        https://bugs.webkit.org/show_bug.cgi?id=26735

        Fix V8IsolatedWorld to point to the correct include file.

        The deprecated v8_index.h was removed from the Chromium tree in r19291
        and upstreamed into WebKit with r45193. However V8IsolatedWorld
        slipped in between the cracks and broke the build.

        * bindings/v8/V8IsolatedWorld.h: update with new header location.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45201 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago https://bugs.webkit.org/show_bug.cgi?id=26651
cmarrin@apple.com [Thu, 25 Jun 2009 22:03:59 +0000 (22:03 +0000)]
    https://bugs.webkit.org/show_bug.cgi?id=26651

        Preference is named "WebKitAcceleratedCompositingEnabled"
        and is a boolean value. When false, prevents compositing layers from
        being created, which prevents hardware animation from running.
        Also forces video to do software rendering. Added a cache for
        the flag in RenderLayerCompositing and made it all work
        on-the-fly when the flag is changed while a page is loaded.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45199 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Jian Li <jianli@chromium.org>
jianli@chromium.org [Thu, 25 Jun 2009 21:54:04 +0000 (21:54 +0000)]
2009-06-25  Jian Li  <jianli@chromium.org>

        Reviewed by Dimitri Glazkov.

        Bug 26701: Implement the missing code for "FIXME: Need to return an
        exception" in WorkerScriptController::evaluate for v8 bindings.
        https://bugs.webkit.org/show_bug.cgi?id=26701

        * bindings/v8/WorkerScriptController.cpp:
        (WebCore::WorkerScriptController::evaluate):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45198 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 21:52:21 +0000 (21:52 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Mark Rowe.

        Call WebKitTools/Scripts scripts by their absolute paths
        https://bugs.webkit.org/show_bug.cgi?id=26704

        bugzilla-tool used to use whatever build-webkit was in your path.
        That could end up building the wrong copy of WebKit.

        * Scripts/bugzilla-tool:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45197 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Nate Chapin <japhet@chromium.org>
japhet@chromium.org [Thu, 25 Jun 2009 21:39:07 +0000 (21:39 +0000)]
2009-06-25  Nate Chapin  <japhet@chromium.org>

        Reviewed by Dimitri Glazkov.

        Upstream V8Index.

        https://bugs.webkit.org/show_bug.cgi?id=26495

        * bindings/v8/V8Index.cpp: Added.
        (WebCore::V8ClassIndex::GetFactory): Moved from src.chromium.org.
        (WebCore::V8ClassIndex::GetCache): Moved from src.chromium.org.
        * bindings/v8/V8Index.h:
        (WebCore::V8ClassIndex::): Moved from src.chromium.org.
        (WebCore::V8ClassIndex::ToInt): Moved from src.chromium.org.
        (WebCore::V8ClassIndex::FromInt): Moved from src.chromium.org.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45193 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
eric@webkit.org [Thu, 25 Jun 2009 21:26:24 +0000 (21:26 +0000)]
2009-06-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Dave Levin.

        Use unicode() instead of str when reading from bugzilla.
        Also add Simon Fraser as a reviewer.
        https://bugs.webkit.org/show_bug.cgi?id=26719

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45192 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Adam Langley <agl@google.com>
agl@chromium.org [Thu, 25 Jun 2009 21:15:23 +0000 (21:15 +0000)]
2009-06-25  Adam Langley  <agl@google.com>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=26529

        This is hopefully the last step before our renderers can run
        cleanly in a chroot.

        WebKit needs to be able to ask for the correct font to use in
        the case that the current font doesn't include glyphs for
        certain code points. Currently we make a fontconfig call in our
        WebKit port to handle this.

        This patch changes this so that the call is sent our via
        ChromiumBridge.

        http://codereview.chromium.org/132007

        This should not affect any layout tests.

        * platform/chromium/ChromiumBridge.h:
        * platform/graphics/chromium/FontCacheLinux.cpp:
        (WebCore::FontCache::getFontDataForCharacters):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45191 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Albert J. Wong <ajwong@chromium.org>
levin@chromium.org [Thu, 25 Jun 2009 20:34:27 +0000 (20:34 +0000)]
2009-06-25  Albert J. Wong  <ajwong@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26566
        Upstream these files from the chromium v8 code.  No tests were
        affected because this is essentially a code move.

        * bindings/v8/NPV8Object.cpp: Added.
        (allocV8NPObject):
        (freeV8NPObject):
        (listFromVariantArgs):
        (npIdentifierToV8Identifier):
        (npCreateV8ScriptObject):
        (NPN_Invoke):
        (NPN_InvokeDefault):
        (NPN_Evaluate):
        (NPN_EvaluateHelper):
        (NPN_GetProperty):
        (NPN_SetProperty):
        (NPN_RemoveProperty):
        (NPN_HasProperty):
        (NPN_HasMethod):
        (NPN_SetException):
        (NPN_Enumerate):
        (NPN_Construct):
        * bindings/v8/NPV8Object.h: Added.
        (PrivateIdentifier::):
        * bindings/v8/V8NPUtils.cpp: Added.
        (convertV8ObjectToNPVariant):
        (convertNPVariantToV8Object):
        (getStringIdentifier):
        * bindings/v8/V8NPUtils.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45189 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
levin@chromium.org [Thu, 25 Jun 2009 20:34:22 +0000 (20:34 +0000)]
WebCore:

2009-06-25  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26436

        Windows Chromium bug fix: save context of destination canvas in
        TransparencyWin::compositeTextComposite() before the function
        modifies the context.

        Test: fast/canvas/translate-text.html

        * platform/graphics/chromium/TransparencyWin.cpp:
        (WebCore::TransparencyWin::compositeTextComposite):

LayoutTests:

2009-06-25  Shinichiro Hamaji  <hamaji@chromium.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26436

        Windows Chromium bug fix: save context of destination canvas in
        TransparencyWin::compositeTextComposite() before the function
        modifies the context.

        * fast/canvas/resources/translate-text.js: Added.
        (description.pixelValueAt):
        (pixelToString):
        (pixelShouldBe):
        * fast/canvas/translate-text-expected.txt: Added.
        * fast/canvas/translate-text.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45188 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Takeshi Yoshino <tyoshino@google.com>
levin@chromium.org [Thu, 25 Jun 2009 20:34:15 +0000 (20:34 +0000)]
2009-06-25  Takeshi Yoshino  <tyoshino@google.com>

        Reviewed by David Levin.

        Bug 26207: Rebaseline the expected image for fast/forms/select-style.html for Mac.
        https://bugs.webkit.org/show_bug.cgi?id=26207

        Replace the expected image for fast/forms/select-style-expected.html for
        Mac which need to be rebaselined due to r43903
        (http://trac.webkit.org/changeset/43903).

        * platform/mac/fast/forms/select-style-expected.png:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45187 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Patrick Mueller <Patrick_Mueller@us.ibm.com>
levin@chromium.org [Thu, 25 Jun 2009 20:34:10 +0000 (20:34 +0000)]
2009-06-25  Patrick Mueller  <Patrick_Mueller@us.ibm.com>

        Reviewed by Timothy Hatcher.

        Show the filename and first line for "(program)" in the Profiler/Debugger
        https://bugs.webkit.org/show_bug.cgi?id=25475

        Add support to associate a sourceURL with an eval()'d string
        via a @sourceURL comment.  Currently the sourceURL is only available
        in the script debugger, not in the console or profiler, but it's
        most needed in the script debugger.

        * English.lproj/localizedStrings.js: added new "(program): %s" string
        * inspector/front-end/Script.js:
        (WebInspector.Script): if no sourceURL is available for the Script,
        search for a comment of the form //@ sourceURL=(url) to use
        as the sourceURL instead.
        * manual-tests/inspector/named-evals.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45186 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
levin@chromium.org [Thu, 25 Jun 2009 20:34:04 +0000 (20:34 +0000)]
WebCore:

2009-06-25  John Gregg  <johnnyg@google.com>

        Reviewed by Sam Weinig.

        Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
        https://bugs.webkit.org/show_bug.cgi?id=23721

        onchange events fire when a SELECT element has
        focus and the selectedIndex is updated by script in some way--either
        during another onchange, onkeypress, onfocus, or timer--and then
        focus is lost.

        Fixed by making a separate method for user-driven selectedIndex
        changes, leaving scripts to use one which doesn't cause onchange to
        be queued.

        Test: fast/forms/select-script-onchange.html

        * dom/SelectElement.cpp: check if the pending change is user driven
        before calling onchange
        (WebCore::SelectElement::menuListOnChange):
        (WebCore::SelectElement::setSelectedIndex):
        * dom/SelectElement.h: store whether the pending change is user driven
        (WebCore::SelectElementData::userDrivenChange):
        (WebCore::SelectElementData::setUserDrivenChange):
        * html/HTMLSelectElement.cpp: split into two methods -- script version
        [non-user-driven] corresponds to IDL defined property name
        (WebCore::HTMLSelectElement::setSelectedIndex):
        (WebCore::HTMLSelectElement::setSelectedIndexByUser):
        * html/HTMLSelectElement.h:
        * rendering/RenderMenuList.cpp: use ByUser method when coming through
        the renderer
        (WebCore::RenderMenuList::valueChanged):

LayoutTests:

2009-06-25  John Gregg  <johnnyg@google.com>

        Reviewed by Sam Weinig.

        Bug 23721: Changing dropdown's selectedIndex within onchange handler fires another onchange
        https://bugs.webkit.org/show_bug.cgi?id=23721

        Check for unnecessary calls to onchange in response to script
        actions.

        * fast/forms/select-script-onchange-expected.txt: Added.
        * fast/forms/select-script-onchange.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45185 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Jeremy Orlow <jorlow@chromium.org>
darin@chromium.org [Thu, 25 Jun 2009 20:02:24 +0000 (20:02 +0000)]
2009-06-25  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=26698

        Combined LocalStorageArea and SessionStorageArea into StorageArea since
        (after my other refactorings) there are no longer substantial
        differences between the two.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        * storage/LocalStorageArea.cpp: Removed.
        * storage/LocalStorageArea.h: Removed.
        * storage/SessionStorage.cpp:
        (WebCore::SessionStorage::copy):
        (WebCore::SessionStorage::storageArea):
        * storage/SessionStorage.h:
        * storage/SessionStorageArea.cpp: Removed.
        * storage/SessionStorageArea.h: Removed.
        * storage/StorageArea.cpp:
        (WebCore::StorageArea::createLocalStorage):
        (WebCore::StorageArea::StorageArea):
        (WebCore::StorageArea::createSessionStorage):
        (WebCore::StorageArea::copy):
        (WebCore::StorageArea::setItem):
        (WebCore::StorageArea::removeItem):
        (WebCore::StorageArea::clear):
        (WebCore::StorageArea::scheduleFinalSync):
        (WebCore::StorageArea::blockUntilImportComplete):
        (WebCore::StorageArea::dispatchStorageEvent):
        * storage/StorageArea.h:
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::StorageAreaSync):
        (WebCore::StorageAreaSync::scheduleFinalSync):
        (WebCore::StorageAreaSync::syncTimerFired):
        (WebCore::StorageAreaSync::performImport):
        * storage/StorageAreaSync.h:
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45183 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoVersioning.
mrowe@apple.com [Thu, 25 Jun 2009 19:50:05 +0000 (19:50 +0000)]
Versioning.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45182 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 25 Jun 2009 19:45:30 +0000 (19:45 +0000)]
WebCore:

        Reviewed by Darin Adler.

        - fix https://bugs.webkit.org/show_bug.cgi?id=26671
          <rdar://problem/7001880> Safari 4.0 crashes in
          WebCore::DOMTimer::fired()

        Test: fast/dom/style-sheet-candidate-remove-unrendered-document.html

        When a "style sheet candidate" element is removed from a document,
        call Document::removeStyleSheetCandidateNode() regardless of whether
        the document is rendered. Otherwise, the document's style sheet
        candidate set can end up containing stale references.

        * dom/ProcessingInstruction.cpp:
        (WebCore::ProcessingInstruction::removedFromDocument):
        * html/HTMLLinkElement.cpp:
        (WebCore::HTMLLinkElement::removedFromDocument):
        * html/HTMLStyleElement.cpp:
        (WebCore::HTMLStyleElement::removedFromDocument):

LayoutTests:

        Reviewed by Darin Adler.

        - test for https://bugs.webkit.org/show_bug.cgi?id=26671
          <rdar://problem/7001880> Safari 4.0 crashes in
          WebCore::DOMTimer::fired()

        * fast/dom/style-sheet-candidate-remove-unrendered-document-expected.txt: Added.
        * fast/dom/style-sheet-candidate-remove-unrendered-document.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45180 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 25 Jun 2009 18:53:17 +0000 (18:53 +0000)]
2009-06-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Reviewed by Darin Fisher.

        Update CodeGeneratorV8.pm to sync up with the changes downstream.

        * bindings/scripts/CodeGeneratorV8.pm: Added HTMLFrameSetElement check,
          FileList as a ref-counted type, and DataGridColumn as typeCanFailConversion.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45179 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoCredit the correct reviewer.
rwlbuis@webkit.org [Thu, 25 Jun 2009 18:14:29 +0000 (18:14 +0000)]
Credit the correct reviewer.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45178 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Dimitri Glazkov <dglazkov@chromium.org>
dglazkov@chromium.org [Thu, 25 Jun 2009 15:50:51 +0000 (15:50 +0000)]
2009-06-25  Dimitri Glazkov  <dglazkov@chromium.org>

        Unreviewed, build fix.

        Add FileList.h include to fix Chromium build.

        * platform/chromium/ClipboardChromium.cpp: Added FileList.h include.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45176 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Thu, 25 Jun 2009 13:14:52 +0000 (13:14 +0000)]
2009-06-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Simon Hausmann.

        Use Q_ASSERT in Qt's DumpRenderTree instead of JSC's ASSERT

        The WTFReportAssertionFailure function in JSC is not exported when
        building QtWebKit in both debug and release on Mac, so DRT fails to
        link.

        We can revert this patch once the Qt port builds JSC as a separate
        library, and we add the proper export macros to Assertions.cpp

        * DumpRenderTree/qt/WorkQueue.cpp:
        (WorkQueue::queue):
        (WorkQueue::dequeue):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45175 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Tor Arne Vestbø <tor.arne.vestbo@nokia.com>
vestbo@webkit.org [Thu, 25 Jun 2009 13:11:24 +0000 (13:11 +0000)]
2009-06-25  Tor Arne Vestbø  <tor.arne.vestbo@nokia.com>

        Reviewed by Jan Alonzo.

        bugzilla-tool: Add Simon Hausmann as reviewer

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45174 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Joseph Pecoraro <joepeck02@gmail.com>
jmalonzo@webkit.org [Thu, 25 Jun 2009 12:42:32 +0000 (12:42 +0000)]
2009-06-25  Joseph Pecoraro  <joepeck02@gmail.com>

        Reviewed by Jan Alonzo.

        Bug 26489: Web Inspector: Typo in DatabaseQuery Error Message
        https://bugs.webkit.org/show_bug.cgi?id=26489

        Fixed a Typo in a Web Inspector error message.

        * English.lproj/localizedStrings.js:
        * inspector/front-end/DatabaseQueryView.js:
        (WebInspector.DatabaseQueryView.prototype._queryError):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45173 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 25 Jun 2009 11:11:54 +0000 (11:11 +0000)]
2009-06-25  Simon Hausmann  <simon.hausmann@nokia.com>

        Fix the Qt build, add missing StorageAreaSync files to the build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45172 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Simon Hausmann <simon.hausmann@nokia.com>
hausmann@webkit.org [Thu, 25 Jun 2009 10:56:46 +0000 (10:56 +0000)]
2009-06-25  Simon Hausmann  <simon.hausmann@nokia.com>

        Reviewed by and done with Tor Arne Vestbø.

        Fix shortcut keyboard handling with plugins on the Qt/Mac build.

        When we receive shortcut events like Ctrl+V then the text in the QKeyEvent is
        empty. If we're asked to disambiguate the event into a Char keyboard event,
        we try to detect this situation and still set the text, to ensure that the
        general event handling sends a key press event after this disambiguation.

        * platform/qt/PlatformKeyboardEventQt.cpp:
        (WebCore::PlatformKeyboardEvent::disambiguateKeyDownEvent):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45171 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 10:05:02 +0000 (10:05 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        No review, just skipping a new test.

        Skip new test on platforms missing eventSender.beginDragWithFiles
        Test: http/tests/security/clipboard/clipboard-file-access.html
        https://bugs.webkit.org/show_bug.cgi?id=25916

        * platform/gtk/Skipped:
        * platform/qt/Skipped:
        * platform/win/Skipped:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45170 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 09:49:50 +0000 (09:49 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        Build fix only, no review.

        Add FileList.h and NotImplemented.h includes in an attempt to fix bots.

        * platform/gtk/ClipboardGtk.cpp:
        * platform/qt/ClipboardQt.cpp:
        * platform/win/ClipboardWin.cpp:
        * platform/wx/ClipboardWx.cpp:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45169 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Dan Bernstein <mitz@apple.com>
eric@webkit.org [Thu, 25 Jun 2009 09:24:33 +0000 (09:24 +0000)]
2009-06-24  Dan Bernstein  <mitz@apple.com>

        Reviewed by Simon Fraser.

        - test for <rdar://problem/7001817> REGRESSION (r41902): Base position
          track at UCSC Genome Browser doesn't work because image map prevents
          img from hit-testing

        * fast/replaced/image-map-2-expected.txt: Added.
        * fast/replaced/image-map-2.html: Added.

2009-05-21  Eric Seidel  <eric@webkit.org>

        Reviewed by Maciej Stachowiak.

        Expose files in the clipboard in ondrop events
        https://bugs.webkit.org/show_bug.cgi?id=25916

        Make it possible for applications like gmail to implement
        drag and drop of attachments onto email messages.

        This patch exposes an event.dataTransfer.files accessor
        on the drop event.  No information is exposed during dragover.
        This follows the HTML 5 drag and drop security model:
        http://www.w3.org/TR/html5/editing.html#security-risks-in-the-drag-and-drop-model
        The test http/tests/security/clipboard/clipboard-file-access.html
        verifies this behavior.

        Internet Explorer shows historical documentation of supporting
        getData('File') as a way of exposing files on the pasteboard.  The current version of their docs:
        http://msdn.microsoft.com/en-us/library/ms537658(VS.85).aspx
        has removed this reference (as far as I can tell IE never implemented it)
        I have a printed copy of that URL from 2008 on my desk describing getData('File') in IE.
        IE does not follow the HTML5 clipboard security model and always allows access to the full clipboard, even on dragover.

        I choose not to use IE's getData('File') and instead added .files
        so that the accessor could have a type, matching WebKit's existing
        .files accessor on HTMLInputElement.

        Mozilla has equivalent file access:
        event.dataTransfer.mozGetDataAt("application/x-moz-file", 0);
        which also does not return a typed value.
        https://developer.mozilla.org/En/DragDrop/Recommended_Drag_Types#Dragging_Files

        This is only implemented for Mac WebKit.  All other platforms (including Apple's Win WebKit)
        have incomplete Clipboard implementations and will require experts from those platforms
        to add this functionality.  Right now they all have Clipboard*::files() methods which call notImplemented();

        Test: http/tests/security/clipboard/clipboard-file-access.html

        * dom/Clipboard.h:
        * dom/Clipboard.idl:
        * platform/chromium/ClipboardChromium.cpp:
        (WebCore::ClipboardChromium::files):
        * platform/chromium/ClipboardChromium.h:
        * platform/gtk/ClipboardGtk.cpp:
        (WebCore::ClipboardGtk::files):
        * platform/gtk/ClipboardGtk.h:
        * platform/mac/ClipboardMac.h:
        * platform/mac/ClipboardMac.mm:
        (WebCore::absoluteURLsFromPasteboardFilenames):
        (WebCore::absoluteURLsFromPasteboard):
        (WebCore::ClipboardMac::files):
        * platform/qt/ClipboardQt.cpp:
        (WebCore::ClipboardQt::files):
        * platform/qt/ClipboardQt.h:
        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::files):
        * platform/win/ClipboardWin.h:
        * platform/wx/ClipboardWx.cpp:
        (WebCore::ClipboardWx::files):
        * platform/wx/ClipboardWx.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45168 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 08:27:47 +0000 (08:27 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        No review, only completing revert of r45144.

        Add back files deleted by r45144.

        * storage/LocalStorageArea.cpp: Added.
        (WebCore::LocalStorageArea::create):
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::scheduleFinalSync):
        (WebCore::LocalStorageArea::itemChanged):
        (WebCore::LocalStorageArea::itemRemoved):
        (WebCore::LocalStorageArea::areaCleared):
        (WebCore::LocalStorageArea::blockUntilImportComplete):
        (WebCore::LocalStorageArea::dispatchStorageEvent):
        * storage/LocalStorageArea.h: Added.
        * storage/SessionStorageArea.cpp: Added.
        (WebCore::SessionStorageArea::copy):
        (WebCore::SessionStorageArea::SessionStorageArea):
        (WebCore::SessionStorageArea::itemChanged):
        (WebCore::SessionStorageArea::itemRemoved):
        (WebCore::SessionStorageArea::areaCleared):
        (WebCore::SessionStorageArea::blockUntilImportComplete):
        (WebCore::SessionStorageArea::dispatchStorageEvent):
        * storage/SessionStorageArea.h: Added.
        (WebCore::SessionStorageArea::create):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45165 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 08:19:46 +0000 (08:19 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        No review, reverting r45144 only.

        Roll out r45144 after 18 test failures appeared on the bots.
        https://bugs.webkit.org/show_bug.cgi?id=26698

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        * storage/SessionStorage.cpp:
        (WebCore::SessionStorage::copy):
        (WebCore::SessionStorage::storageArea):
        * storage/SessionStorage.h:
        * storage/StorageArea.cpp:
        (WebCore::StorageArea::StorageArea):
        (WebCore::StorageArea::~StorageArea):
        (WebCore::StorageArea::setItem):
        (WebCore::StorageArea::removeItem):
        (WebCore::StorageArea::clear):
        * storage/StorageArea.h:
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::StorageAreaSync):
        (WebCore::StorageAreaSync::scheduleFinalSync):
        (WebCore::StorageAreaSync::syncTimerFired):
        (WebCore::StorageAreaSync::performImport):
        * storage/StorageAreaSync.h:
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45162 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 08:09:28 +0000 (08:09 +0000)]
2009-06-24  Eric Seidel  <eric@webkit.org>

        Reviewed by Dave Levin.

        Support local commits during apply-patches
        and let land-patches take multiple bug ids.
        https://bugs.webkit.org/show_bug.cgi?id=26703

        I also restructured parts of land-patches into
        class methods and static methods in preparation
        for future code sharing with other commands.

        * Scripts/bugzilla-tool:
        * Scripts/modules/bugzilla.py:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45160 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 07:45:30 +0000 (07:45 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Tor Arne Vestbø.

        Make svn-apply work with Git too
        https://bugs.webkit.org/show_bug.cgi?id=26299

        Add an --force option to svn-apply and otherwise make svn-apply
        exit non-zero when patch application fails.
        https://bugs.webkit.org/show_bug.cgi?id=26300

        I did not update svn-unapply, because it makes no sense in a Git world.
        You don't roll in and out patch files.  You make commits and deal with those.
        Git users can just git reset --hard to get the same functionality.

        * Scripts/svn-apply:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45153 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 07:42:33 +0000 (07:42 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Tor Arne Vestbø.

        Remove use of os.system to fix reviewers with unicode chars in their names
        https://bugs.webkit.org/show_bug.cgi?id=26713

        Also change to latin1 encoding of ø to make python happy.

        * Scripts/modules/bugzilla.py:
        * Scripts/modules/scm.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45152 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-25 Eric Seidel <eric@webkit.org>
eric@webkit.org [Thu, 25 Jun 2009 07:06:50 +0000 (07:06 +0000)]
2009-06-25  Eric Seidel  <eric@webkit.org>

        Reviewed by Tor Arne Vestbø.

        Add Adam Roben and Tor Arne Vestbø to the reviewers list.

        * Scripts/modules/bugzilla.py:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45147 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jeremy Orlow <jorlow@chromium.org>
darin@chromium.org [Thu, 25 Jun 2009 06:16:34 +0000 (06:16 +0000)]
2009-06-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=26698

        Combined LocalStorageArea and SessionStorageArea into StorageArea since
        (after my other refactorings) there are no longer substantial
        differences between the two.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/LocalStorage.cpp:
        (WebCore::LocalStorage::storageArea):
        * storage/LocalStorage.h:
        * storage/LocalStorageArea.cpp: Removed.
        * storage/LocalStorageArea.h: Removed.
        * storage/SessionStorage.cpp:
        (WebCore::SessionStorage::copy):
        (WebCore::SessionStorage::storageArea):
        * storage/SessionStorage.h:
        * storage/SessionStorageArea.cpp: Removed.
        * storage/SessionStorageArea.h: Removed.
        * storage/StorageArea.cpp:
        (WebCore::StorageArea::createLocalStorage):
        (WebCore::StorageArea::StorageArea):
        (WebCore::StorageArea::createSessionStorage):
        (WebCore::StorageArea::copy):
        (WebCore::StorageArea::setItem):
        (WebCore::StorageArea::removeItem):
        (WebCore::StorageArea::clear):
        (WebCore::StorageArea::scheduleFinalSync):
        (WebCore::StorageArea::blockUntilImportComplete):
        (WebCore::StorageArea::dispatchStorageEvent):
        * storage/StorageArea.h:
        * storage/StorageAreaSync.cpp:
        (WebCore::StorageAreaSync::StorageAreaSync):
        (WebCore::StorageAreaSync::scheduleFinalSync):
        (WebCore::StorageAreaSync::syncTimerFired):
        (WebCore::StorageAreaSync::performImport):
        * storage/StorageAreaSync.h:
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45144 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
mitz@apple.com [Thu, 25 Jun 2009 05:01:47 +0000 (05:01 +0000)]
WebCore:

        Reviewed by Simon Fraser.

        - fix <rdar://problem/7001817> REGRESSION (r41902): Base position track
          at UCSC Genome Browser doesn't work because image map prevents img
          from hit-testing

        Test: fast/replaced/image-map-2.html

        * rendering/RenderImage.cpp:
        (WebCore::RenderImage::nodeAtPoint): Do not reset 'inside' to false if
        the image map failed the hit test.

LayoutTests:

        Reviewed by Simon Fraser.

        - test for <rdar://problem/7001817> REGRESSION (r41902): Base position
          track at UCSC Genome Browser doesn't work because image map prevents
          img from hit-testing

        * fast/replaced/image-map-2-expected.txt: Added.
        * fast/replaced/image-map-2.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45143 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Thu, 25 Jun 2009 03:07:02 +0000 (03:07 +0000)]
2009-06-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Gavin Barraclough.

        Make the opcode sampler work once again.

        * jit/JIT.h:
        (JSC::JIT::compileGetByIdProto):
        (JSC::JIT::compileGetByIdSelfList):
        (JSC::JIT::compileGetByIdProtoList):
        (JSC::JIT::compileGetByIdChainList):
        (JSC::JIT::compileGetByIdChain):
        (JSC::JIT::compilePutByIdTransition):
        (JSC::JIT::compileCTIMachineTrampolines):
        (JSC::JIT::compilePatchGetArrayLength):
        * jit/JITStubCall.h:
        (JSC::JITStubCall::call):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45138 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-22 Adam Barth <abarth@webkit.org>
abarth@webkit.org [Thu, 25 Jun 2009 02:38:07 +0000 (02:38 +0000)]
2009-06-22  Adam Barth  <abarth@webkit.org>

        Reviewed by Dimitri Glazkov.

        https://bugs.webkit.org/show_bug.cgi?id=26366

        Refactor V8DOMMap to support isolated worlds.

        * bindings/v8/ScriptController.cpp:
        (WebCore::ScriptController::evaluateInNewWorld):
        * bindings/v8/ScriptController.h:
        * bindings/v8/V8DOMMap.cpp:
        (WebCore::DOMDataStore::InternalDOMWrapperMap::InternalDOMWrapperMap):
        (WebCore::DOMDataStore::allStores):
        (WebCore::DOMDataStore::allStoresMutex):
        (WebCore::DOMDataStore::domData):
        (WebCore::ScopedDOMDataStore::ScopedDOMDataStore):
        (WebCore::ScopedDOMDataStore::~ScopedDOMDataStore):
        (WebCore::StaticDOMDataStore::StaticDOMDataStore):
        (WebCore::):
        (WebCore::MainThreadDOMData::MainThreadDOMData):
        (WebCore::MainThreadDOMData::getStore):
        (WebCore::ChildThreadDOMData::ChildThreadDOMData):
        (WebCore::ChildThreadDOMData::getStore):
        (WebCore::DOMDataStore::DOMDataStore):
        (WebCore::DOMDataStore::~DOMDataStore):
        (WebCore::DOMDataStoreHandle::DOMDataStoreHandle):
        (WebCore::DOMDataStoreHandle::~DOMDataStoreHandle):
        (WebCore::::forget):
        (WebCore::getDOMNodeMap):
        (WebCore::getDOMObjectMap):
        (WebCore::getActiveDOMObjectMap):
        (WebCore::getDOMSVGElementInstanceMap):
        (WebCore::getDOMSVGObjectWithContextMap):
        (WebCore::DOMData::getCurrent):
        (WebCore::DOMData::handleWeakObject):
        (WebCore::DOMData::ensureDeref):
        (WebCore::weakDOMObjectCallback):
        (WebCore::weakActiveDOMObjectCallback):
        (WebCore::weakNodeCallback):
        (WebCore::weakSVGElementInstanceCallback):
        (WebCore::weakSVGObjectWithContextCallback):
        (WebCore::DOMData::derefObject):
        (WebCore::DOMData::derefDelayedObjects):
        (WebCore::DOMData::derefDelayedObjectsInCurrentThread):
        (WebCore::DOMData::removeObjectsFromWrapperMap):
        (WebCore::removeAllDOMObjectsInCurrentThreadHelper):
        (WebCore::visitDOMNodesInCurrentThread):
        (WebCore::visitDOMObjectsInCurrentThread):
        (WebCore::visitActiveDOMObjectsInCurrentThread):
        (WebCore::visitDOMSVGElementInstancesInCurrentThread):
        (WebCore::visitSVGObjectsInCurrentThread):
        * bindings/v8/V8DOMMap.h:
        (WebCore::DOMDataStoreHandle::getStore):
        * bindings/v8/V8IsolatedWorld.cpp: Added.
        (WebCore::getIsolatedWorldKey):
        (WebCore::contextWeakReferenceCallback):
        (WebCore::V8IsolatedWorld::evaluate):
        (WebCore::V8IsolatedWorld::V8IsolatedWorld):
        (WebCore::V8IsolatedWorld::~V8IsolatedWorld):
        (WebCore::V8IsolatedWorld::getEntered):
        * bindings/v8/V8IsolatedWorld.h: Added.
        (WebCore::V8IsolatedWorld::getDOMDataStore):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45134 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Mikhail Naganov <mnaganov@chromium.org>
eric@webkit.org [Thu, 25 Jun 2009 01:52:46 +0000 (01:52 +0000)]
2009-06-24  Mikhail Naganov  <mnaganov@chromium.org>

        Reviewed by Timothy Hatcher.

        Bug 26604: Search doesn't work in Web Inspector Profiler
        https://bugs.webkit.org/show_bug.cgi?id=26604

        Seems like search was damaged in revision 42808.

        * inspector/front-end/ProfileView.js:
        (WebInspector.ProfileView.prototype.refresh):
        Here and in other functions: nodes we're searching in are profile data grid
        nodes, so there is no more need for '_dataGridNode' references.
        (WebInspector.ProfileView.prototype.searchCanceled):
        (WebInspector.ProfileView.prototype.performSearch.matchesQuery):
        Fixed accidental semicolon that caused 'matchesQuery' always return true.
        (WebInspector.ProfileView.prototype.performSearch):
        To perform search correctly in the case of bottom up tree, we need to populate
        the tree, because there's no 1-to-1 correspondence between profile nodes and
        data grid nodes in this case.
        (WebInspector.ProfileView.prototype._jumpToSearchResult):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45131 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Thu, 25 Jun 2009 01:32:26 +0000 (01:32 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Maciej Stachowiak.

        Extend FastAllocBase.h with 'using WTF::FastAllocBase' to avoid
        unnecessary WTF:: usings.
        Remove existing unnecessary WTF:: usings.

        * interpreter/Interpreter.h:
        * profiler/CallIdentifier.h:
        * runtime/ScopeChain.h:
        * wtf/FastAllocBase.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45130 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Simon Fraser <simon.fraser@apple.com>
simon.fraser@apple.com [Thu, 25 Jun 2009 01:07:08 +0000 (01:07 +0000)]
2009-06-24  Simon Fraser  <simon.fraser@apple.com>

        Reviewed by Darin Adler.

        <rdar://problem/6450239&6574516>

        Fix flashing issues caused by compositing layers rendering content before
        a deferred layout has happened. Because the -viewWillDraw machinery doesn't
        work for composited layers, we need to use scheduleViewUpdate() to queue
        up a layout via the run loop observer in WebKit, whenever we know we
        are going to be painting soon.

        * rendering/RenderLayerBacking.cpp:
        (WebCore::RenderLayerBacking::setContentsNeedDisplay):
        (WebCore::RenderLayerBacking::setContentsNeedDisplayInRect):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45129 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoJavaScriptCore:
levin@chromium.org [Thu, 25 Jun 2009 00:45:37 +0000 (00:45 +0000)]
JavaScriptCore:

2009-06-24  David Levin  <levin@chromium.org>

        Fix all builds.

        * bytecode/CodeBlock.h:
        * bytecompiler/BytecodeGenerator.h:
        * interpreter/Register.h:

WebCore:

2009-06-24  David Levin  <levin@chromium.org>

        Fix all builds.

        * ForwardingHeaders/wtf/FastAllocBase.h: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45128 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jeremy Orlow <jorlow@chromium.org>
darin@chromium.org [Wed, 24 Jun 2009 23:56:01 +0000 (23:56 +0000)]
2009-06-24  Jeremy Orlow  <jorlow@chromium.org>

        Reviewed by Darin Fisher.

        https://bugs.webkit.org/show_bug.cgi?id=26658

        Split the syncing portions of LocalStorageArea into StorageAreaSync.
        This name will make more sense in the next patch (in this set) when
        LocalStorageArea and SessionStorageArea are merged to become simply
        StorageArea.  (Thus the synching portion of StorageArea is in
        StorageAreaSync.)

        This looks like a big patch, but really all it's doing is splitting
        code and patching split-related things up.

        * GNUmakefile.am:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * storage/LocalStorageArea.cpp:
        (WebCore::LocalStorageArea::create):
        (WebCore::LocalStorageArea::LocalStorageArea):
        (WebCore::LocalStorageArea::scheduleFinalSync):
        (WebCore::LocalStorageArea::itemChanged):
        (WebCore::LocalStorageArea::itemRemoved):
        (WebCore::LocalStorageArea::areaCleared):
        (WebCore::LocalStorageArea::blockUntilImportComplete):
        * storage/LocalStorageArea.h:
        * storage/LocalStorageTask.cpp:
        (WebCore::LocalStorageTask::LocalStorageTask):
        * storage/LocalStorageTask.h:
        (WebCore::LocalStorageTask::createImport):
        (WebCore::LocalStorageTask::createSync):
        * storage/LocalStorageThread.cpp:
        (WebCore::LocalStorageThread::scheduleImport):
        (WebCore::LocalStorageThread::scheduleSync):
        * storage/LocalStorageThread.h:
        * storage/SessionStorageArea.cpp:
        (WebCore::SessionStorageArea::blockUntilImportComplete):
        * storage/SessionStorageArea.h:
        * storage/StorageArea.h:
        * storage/StorageAreaSync.cpp: Copied from WebCore/storage/LocalStorageArea.cpp.
        * storage/StorageAreaSync.h: Copied from WebCore/storage/LocalStorageArea.h.
        * storage/StorageSyncManager.cpp:
        (WebCore::StorageSyncManager::scheduleImport):
        (WebCore::StorageSyncManager::scheduleSync):
        * storage/StorageSyncManager.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45124 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 23:55:57 +0000 (23:55 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=26677

        Inherits CodeBlock class from FastAllocBase because it
        has been instantiated by 'new' in JavaScriptCore/bytecode/CodeBlock.h:217.

        * bytecode/CodeBlock.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45123 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 23:55:11 +0000 (23:55 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=26676

        Inherits BytecodeGenerator class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/parser/Nodes.cpp:1892.

        * bytecompiler/BytecodeGenerator.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45122 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 23:54:25 +0000 (23:54 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Maciej Stachowiak.

        https://bugs.webkit.org/show_bug.cgi?id=26675

        Inherits Register class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/runtime/JSVariableObject.h:149.

        * interpreter/Register.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45121 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Zoltan Horvath <hzoltan@inf.u-szeged.hu>
eric@webkit.org [Wed, 24 Jun 2009 23:53:36 +0000 (23:53 +0000)]
2009-06-24  Zoltan Horvath  <hzoltan@inf.u-szeged.hu>

        Reviewed by Darin Adler.

        https://bugs.webkit.org/show_bug.cgi?id=26674

        Inherits HashMap class from FastAllocBase because it has been
        instantiated by 'new' in JavaScriptCore/runtime/Structure.cpp:458.

        * wtf/HashMap.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45120 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Adam Treat <adam.treat@torchmobile.com>
treat@webkit.org [Wed, 24 Jun 2009 23:32:15 +0000 (23:32 +0000)]
2009-06-24  Adam Treat  <adam.treat@torchmobile.com>

        Fix Qt build.

        * WebCore.pro:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45117 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWindows build fix for fallout from
cfleizach@apple.com [Wed, 24 Jun 2009 23:00:47 +0000 (23:00 +0000)]
Windows build fix for fallout from

Bug 26668: AX: need a way to retrieve the language for an element

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45112 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 David Levin <levin@chromium.org>
levin@chromium.org [Wed, 24 Jun 2009 22:47:45 +0000 (22:47 +0000)]
2009-06-24  David Levin  <levin@chromium.org>

        Reviewed by David Hyatt.

        Bug 26696: Member functions in DataGridColumnList should return pointers instead of PassRefPtr.
        https://bugs.webkit.org/show_bug.cgi?id=26696

        * html/DataGridColumnList.cpp:
        (WebCore::DataGridColumnList::itemWithName):
        (WebCore::DataGridColumnList::add):
        * html/DataGridColumnList.h:
        (WebCore::DataGridColumnList::item):
        (WebCore::DataGridColumnList::primaryColumn):
        (WebCore::DataGridColumnList::sortColumn):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45111 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Sam Weinig <sam@webkit.org>
weinig@apple.com [Wed, 24 Jun 2009 22:19:16 +0000 (22:19 +0000)]
2009-06-24  Sam Weinig  <sam@webkit.org>

        Reviewed by Dave "Messy" Hyatt.

        Little bit of style cleanup.

        * html/DataGridColumn.cpp:
        * html/DataGridColumn.h:
        * html/DataGridColumn.idl:
        * html/DataGridColumnList.cpp:
        * html/DataGridColumnList.h:
        * html/DataGridColumnList.idl:
        * html/HTMLDataGridCellElement.cpp:
        * html/HTMLDataGridCellElement.h:
        * html/HTMLDataGridCellElement.idl:
        * html/HTMLDataGridColElement.cpp:
        * html/HTMLDataGridColElement.h:
        * html/HTMLDataGridColElement.idl:
        * html/HTMLDataGridElement.h:
        * html/HTMLDataGridElement.idl:
        * html/HTMLDataGridRowElement.cpp:
        * html/HTMLDataGridRowElement.h:
        * html/HTMLDataGridRowElement.idl:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45110 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoBug 26668: AX: need a way to retrieve the language for an element
cfleizach@apple.com [Wed, 24 Jun 2009 22:14:58 +0000 (22:14 +0000)]
Bug 26668: AX: need a way to retrieve the language for an element
https://bugs.webkit.org/show_bug.cgi?id=26668

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45109 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 24 Jun 2009 22:04:40 +0000 (22:04 +0000)]
2009-06-24  Brady Eidson  <beidson@apple.com>

        Reviewed by Dan Bernstein.

        <rdar://problem/6893811> Instead of downloading files linked from Google Earth, file contents displayed in browser window as text.

        * platform/network/mac/WebCoreURLResponse.mm:
        (createBinaryExtensionsSet): Add '.kmz' to the list of known-to-be-binary extensions.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45107 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago<rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanne...
oliver@apple.com [Wed, 24 Jun 2009 22:01:34 +0000 (22:01 +0000)]
<rdar://problem/6940519> REGRESSION (Safari 4 Public Beta - TOT): google.com/adplanner shows blank page instead of site details in "basic research'

Reviewed by Darin Adler.

The problem was caused by the page returned with a function using a
var declaration list containing around ~3000 variables.  The solution
to this is to flatten the comma expression representation and make
codegen comma expressions and initializer lists iterative rather than
recursive.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45106 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoRephrased change log
mitz@apple.com [Wed, 24 Jun 2009 21:12:17 +0000 (21:12 +0000)]
Rephrased change log

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45104 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Nicolas Weber <thakis@chromium.org>
eric@webkit.org [Wed, 24 Jun 2009 21:10:18 +0000 (21:10 +0000)]
2009-06-24  Nicolas Weber  <thakis@chromium.org>

        Reviewed by Eric Seidel.

        https://bugs.webkit.org/show_bug.cgi?id=26685
        Accomodate for backwards-incompatible skia api changes.

        * platform/graphics/skia/GraphicsContextSkia.cpp:
        (WebCore::GraphicsContext::clearRect):
        (WebCore::GraphicsContext::setCompositeOperation):
        * platform/graphics/skia/ImageBufferSkia.cpp:
        (WebCore::ImageBuffer::ImageBuffer):
        * platform/graphics/skia/ImageSkia.cpp:
        (WebCore::paintSkBitmap):
        (WebCore::Image::drawPattern):
        * platform/graphics/skia/PlatformContextSkia.cpp:
        (PlatformContextSkia::State::State):
        (PlatformContextSkia::setupPaintCommon):
        (PlatformContextSkia::setXfermodeMode):
        (PlatformContextSkia::applyClipFromImage):
        * platform/graphics/skia/PlatformContextSkia.h:
        * platform/graphics/skia/SkiaUtils.cpp:
        (WebCore::):
        (WebCore::WebCoreCompositeToSkiaComposite):
        * platform/graphics/skia/SkiaUtils.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45103 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Anders Carlsson.
mitz@apple.com [Wed, 24 Jun 2009 21:05:05 +0000 (21:05 +0000)]
    Reviewed by Anders Carlsson.

        Fix the most recently seen kind of crash seen in
        <rdar://problem/5983224>

        * WebView/WebHTMLView.mm:
        (-[WebHTMLView adjustPageHeightNew:top:bottom:limit:]): Null-check the
        Frame.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45102 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jan Michael Alonzo <jmalonzo@webkit.org>
jmalonzo@webkit.org [Wed, 24 Jun 2009 20:51:44 +0000 (20:51 +0000)]
2009-06-24  Jan Michael Alonzo  <jmalonzo@webkit.org>

        Gtk build fix. Add files that were added in r45093 and r45096

        * GNUmakefile.am:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45100 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Brady Eidson <beidson@apple.com>
beidson@apple.com [Wed, 24 Jun 2009 20:33:51 +0000 (20:33 +0000)]
2009-06-24  Brady Eidson  <beidson@apple.com>

        Fix 64-bit SnowLeopard build.

        * html/DataGridColumnList.cpp:
        (WebCore::DataGridColumnList::remove):
        (WebCore::DataGridColumnList::move):

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45098 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoFix Mac build.
hyatt@apple.com [Wed, 24 Jun 2009 20:06:51 +0000 (20:06 +0000)]
Fix Mac build.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45096 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Reviewed by Niko.
rwlbuis@webkit.org [Wed, 24 Jun 2009 19:44:45 +0000 (19:44 +0000)]
    Reviewed by Niko.

        https://bugs.webkit.org/show_bug.cgi?id=26392
        Bug 26392: In html, modification of xlink:href of an newly inserted svg image does not work.
        https://bugs.webkit.org/show_bug.cgi?id=26328
        Bug 26328: changing href attribute of svg images dows not work when changing display attribute as well

        React to href updates even when there is no renderer, i.e. display=none.

        Tests: svg/custom/js-update-image-and-display.svg
               svg/custom/js-update-image-and-display2.svg
               svg/custom/js-update-image-and-display3.svg

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45095 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoAdd Windows test results for a couple of search field tests
mitz@apple.com [Wed, 24 Jun 2009 19:41:46 +0000 (19:41 +0000)]
Add Windows test results for a couple of search field tests

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45094 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoWebCore:
hyatt@apple.com [Wed, 24 Jun 2009 19:22:12 +0000 (19:22 +0000)]
WebCore:

2009-06-24  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig.

        https://bugs.webkit.org/show_bug.cgi?id=26687

        Add basic back-end column support to datagrid.

        Added fast/dom/HTMLDataGridElement/ column tests.

        * DerivedSources.cpp:
        * DerivedSources.make:
        * WebCore.pro:
        * WebCore.vcproj/WebCore.vcproj:
        * WebCore.xcodeproj/project.pbxproj:
        * WebCoreSources.bkl:
        * html/DataGridColumn.cpp: Added.
        (WebCore::DataGridColumn::setPrimary):
        * html/DataGridColumn.h: Added.
        (WebCore::DataGridColumn::create):
        (WebCore::DataGridColumn::id):
        (WebCore::DataGridColumn::setId):
        (WebCore::DataGridColumn::label):
        (WebCore::DataGridColumn::setLabel):
        (WebCore::DataGridColumn::type):
        (WebCore::DataGridColumn::setType):
        (WebCore::DataGridColumn::sortable):
        (WebCore::DataGridColumn::setSortable):
        (WebCore::DataGridColumn::sortDirection):
        (WebCore::DataGridColumn::setSortDirection):
        (WebCore::DataGridColumn::primary):
        (WebCore::DataGridColumn::detachFromColumnList):
        (WebCore::DataGridColumn::DataGridColumn):
        * html/DataGridColumn.idl: Added.
        * html/DataGridColumnList.cpp: Added.
        (WebCore::DataGridColumnList::~DataGridColumnList):
        (WebCore::DataGridColumnList::itemWithName):
        (WebCore::DataGridColumnList::add):
        (WebCore::DataGridColumnList::remove):
        (WebCore::DataGridColumnList::move):
        (WebCore::DataGridColumnList::clear):
        (WebCore::DataGridColumnList::primaryColumnChanged):
        * html/DataGridColumnList.h: Added.
        (WebCore::DataGridColumnList::create):
        (WebCore::DataGridColumnList::length):
        (WebCore::DataGridColumnList::item):
        (WebCore::DataGridColumnList::primaryColumn):
        (WebCore::DataGridColumnList::sortColumn):
        * html/DataGridColumnList.idl: Added.
        * html/HTMLDataGridColElement.cpp:
        (WebCore::HTMLDataGridColElement::sortable):
        (WebCore::HTMLDataGridColElement::setSortable):
        (WebCore::HTMLDataGridColElement::sortDirection):
        (WebCore::HTMLDataGridColElement::setSortDirection):
        * html/HTMLDataGridColElement.h:
        * html/HTMLDataGridColElement.idl:
        * html/HTMLDataGridElement.cpp:
        (WebCore::HTMLDataGridElement::HTMLDataGridElement):
        * html/HTMLDataGridElement.h:
        (WebCore::HTMLDataGridElement::columns):
        * html/HTMLDataGridElement.idl:
        * rendering/RenderDataGrid.cpp:
        (WebCore::RenderDataGrid::paintObject):
        (WebCore::RenderDataGrid::paintColumnHeaders):
        (WebCore::RenderDataGrid::rebuildColumns):
        * rendering/RenderDataGrid.h:
        (WebCore::RenderDataGrid::gridElement):

LayoutTests:

2009-06-24  David Hyatt  <hyatt@apple.com>

        Reviewed by Sam Weinig.

        Add test for https://bugs.webkit.org/show_bug.cgi?id=26687.

        * fast/dom/HTMLDataGridElement/DataGridColumns-basic-expected.txt: Added.
        * fast/dom/HTMLDataGridElement/DataGridColumns-basic.html: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45093 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jessie Berlin <jberlin@apple.com>
jberlin@apple.com [Wed, 24 Jun 2009 17:29:05 +0000 (17:29 +0000)]
2009-06-24  Jessie Berlin  <jberlin@apple.com>

        Reviewed by Adam Roben.

        Partially fixes: https://bugs.webkit.org/show_bug.cgi?id=24735
        (<rdar://problem/5015942>)
        Where on windows it was not possible to set an element as the drag
        image using setDragImage on the dataTransfer object.

        Does not "fix" the case of dragging a link where the default link image
        is still used, even when the -webkit-user-drag is set to "element". This
        is the same behavior as is found on OS X.

        Added a manual test because it is not possible to check that what is
        contained in the image snapshot is indeed the requested element.

        * dom/Clipboard.h:
        (WebCore::Clipboard::dragImageElement):
        Made getting the raw pointer from the RefPtr a const operation.
        * manual-tests/drag-with-div-or-image-as-data-image.html: Added.
        * platform/win/ClipboardWin.cpp:
        (WebCore::ClipboardWin::createDragImage):
        Get an image of the rendered element and its subtree.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45087 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Darin Fisher <darin@chromium.org>
darin@chromium.org [Wed, 24 Jun 2009 16:48:52 +0000 (16:48 +0000)]
2009-06-24  Darin Fisher  <darin@chromium.org>

        Reviewed by David Levin.

        https://bugs.webkit.org/show_bug.cgi?id=26683
        Fix Chromium build bustage: Add custom binding for HTMLDataGridElement.dataSource

        This change just adds a stub implementation for now to help fix the build.

        * bindings/v8/custom/V8CustomBinding.h:
        * bindings/v8/custom/V8HTMLDataGridElementCustom.cpp: Added.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45086 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago Build fixes for ENABLE(PLUGIN_PROXY_FOR_VIDEO)
ddkilzer@apple.com [Wed, 24 Jun 2009 15:53:51 +0000 (15:53 +0000)]
    Build fixes for ENABLE(PLUGIN_PROXY_FOR_VIDEO)

        Reviewed by Adam Roben.

        * html/HTMLMediaElement.cpp:
        (WebCore::HTMLMediaElement::deliverNotification): Removed
        ExceptionCode parameter from togglePlayState().
        (WebCore::HTMLMediaElement::initialURL): Don't convert a KURL
        object to a String when assigning to a KURL variable.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45085 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Adam Treat.
zimmermann@webkit.org [Wed, 24 Jun 2009 15:00:34 +0000 (15:00 +0000)]
Reviewed by Adam Treat.

Save memory by not storing attribute values in member variables, if not absolutely needed.
Also fixes bugs where we're substituting variables too early (noticeable with the upcoming <select> element).

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45084 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Adam Roben.
zimmermann@webkit.org [Wed, 24 Jun 2009 14:35:25 +0000 (14:35 +0000)]
Reviewed by Adam Roben.
Forgot to initialize m_task member variable. Results in crashes sometimes.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45083 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoNot reviewed. Forgot to include within last patch.
zimmermann@webkit.org [Wed, 24 Jun 2009 14:34:50 +0000 (14:34 +0000)]
Not reviewed. Forgot to include within last patch.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45082 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years agoReviewed by Nikolas Zimmermann.
zimmermann@webkit.org [Wed, 24 Jun 2009 14:30:45 +0000 (14:30 +0000)]
Reviewed by Nikolas Zimmermann.

Fixes: https://bugs.webkit.org/show_bug.cgi?id=26474
Adding WML <card> title attribute handling.

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45081 268f45cc-cd09-0410-ab3c-d52691b4dbfc

11 years ago2009-06-24 Jiahua Huang <jhuangjiahua@gmail.com>
zecke@webkit.org [Wed, 24 Jun 2009 14:02:16 +0000 (14:02 +0000)]
2009-06-24  Jiahua Huang  <jhuangjiahua@gmail.com>

        Reviewed by Holger Freyther.

        [Gtk] Add Undo/Redo support to WebKitGtk
        https://bugs.webkit.org/show_bug.cgi?id=26573

        Implement EditorClient::undo and other interested funcs.

        * WebCoreSupport/EditorClientGtk.cpp:
        (WebKit::EditorClient::registerCommandForUndo):
        (WebKit::EditorClient::registerCommandForRedo):
        (WebKit::EditorClient::clearUndoRedoOperations):
        (WebKit::EditorClient::canUndo):
        (WebKit::EditorClient::canRedo):
        (WebKit::EditorClient::undo):
        (WebKit::EditorClient::redo):
        (WebKit::EditorClient::EditorClient):
        * WebCoreSupport/EditorClientGtk.h:

git-svn-id: https://svn.webkit.org/repository/webkit/trunk@45080 268f45cc-cd09-0410-ab3c-d52691b4dbfc